⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 24, 2008:

10:43 PM Changeset in webkit [35912] by sfalken@apple.com
  • 2 edits in trunk/WebCore

2008-08-24 Steve Falkenburg <​sfalken@apple.com>

Add a "last chance" WM_TIMER to the Windows shared timer.


The last chance timer fires every 5 seconds to run any lost WM_TIMER based timers.
Failure to fire a timer is fatal to the cross-platform Timer code, since it won't re-schedule
timers if a timer with an earlier expiration is already pending. This results in no timers
firing from that point on.


We lose WM_TIMER messages occasionally (in the neighborhood of 1 per hour) probably due to a
buggy window message hook.


This timer will start when the first WM_TIMER is scheduled, and will
fire every 5 seconds thereafter, causing any lost timers to be fired.


Found this via one of its symptoms: leaking WebFrames. The fix prevents timers from stalling
and prevents the WebFrame leak.


Reviewed by Darin Adler, Geoff Garen.

  • platform/win/SharedTimerWin.cpp: (WebCore::): (WebCore::TimerWindowWndProc): (WebCore::setSharedTimerFireTime):
9:08 PM Changeset in webkit [35911] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-08-24 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Oliver Hunt.

Bug 20093: JSC shell does not clear exceptions after it executes toString on an expression
<​https://bugs.webkit.org/show_bug.cgi?id=20093>

Clear exceptions after evaluating any code in the JSC shell. We do not
report exceptions that are caused by calling toString on the final
valued, but at least we avoid incorrect behaviour.

Also, print any exceptions that occurred while evaluating code at the
interactive prompt, not just while evaluating code from a file.

  • kjs/Shell.cpp: (runWithScripts): (runInteractive):
8:22 PM Changeset in webkit [35910] by mitz@apple.com
  • 4 edits
    2 adds in trunk

WebCore:

Reviewed by Darin Adler.

  • fix <rdar://problem/6065547> REGRESSION (r34879): "Subject" in unread emails in Yahoo mail is not shown in bold

Test: fast/css/font-property-priority.html

  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Changed to pass the 'important' flag to the font-property-parsing functions. (WebCore::CSSParser::parseFontStyle): Added an 'important' argument and changed to use it rather than the m_important member. (WebCore::CSSParser::parseFontVariant): Ditto. (WebCore::CSSParser::parseFontWeight): Ditto.
  • css/CSSParser.h:

LayoutTests:

Reviewed by Darin Adler.

  • test for <rdar://problem/6065547> REGRESSION (r34879): "Subject" in unread emails in Yahoo mail is not shown in bold
  • fast/css/font-property-priority-expected.txt: Added.
  • fast/css/font-property-priority.html: Added.
6:27 PM Changeset in webkit [35909] by Beth Dakin
  • 4 edits in trunk/WebKit/win

2008-08-24 Beth Dakin <Beth Dakin>

Reviewed by John Sullivan.

Provide the excludeFromTextSearch SPI on Windows as well.

  • Interfaces/IWebFrame.idl:
  • WebFrame.cpp: (WebFrame::setExcludeFromTextSearch):
  • WebFrame.h:
3:28 PM Changeset in webkit [35908] by timothy@apple.com
  • 2 edits
    1 add in trunk/WebCore

Fixes a bug where the Inspector's UI would not animate or
fully function because JavaScript timeouts, intervals and
CSS animation timers where not firing while paused at a
a breakpoint in the inspected page.

​https://bugs.webkit.org/show_bug.cgi?id=20042

Reviewed by Darin Adler.

Test: manual-tests/inspector/forzen-ui-while-paused.html

  • page/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::pauseIfNeeded): Add a call to TimerBase::fireTimersInNestedEventLoop before spinning the EventLoop.
3:25 PM Changeset in webkit [35907] by mrowe@apple.com
  • 1 copy in tags/Safari-6528.2

New tag.

2:30 PM Changeset in webkit [35906] by cwzwarich@webkit.org
  • 2 edits in trunk

2008-08-24 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Oliver.

Remove an unnecessary RefPtr to a RegisterID.

  • kjs/nodes.cpp: (KJS::DeleteBracketNode::emitCode):
11:07 AM Changeset in webkit [35905] by rwlbuis@webkit.org
  • 4 edits
    4 adds in trunk

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=20324
A change in SVG Glyph wont show up

Invalidate the glyph cache when the d attribute is set.

Test: svg/custom/glyph-setting-d-attribute.svg

5:59 AM Changeset in webkit [35904] by jhoneycutt@apple.com
  • 2 edits in trunk/WebKit/win

2008-08-24 Jon Honeycutt <​jhoneycutt@apple.com>

Cannot get the focused accessible object from the root object.

AccessibleBase::get_AccFocus() checks whether the focused object is a
child of the current object, but
​http://msdn.microsoft.com/en-us/library/ms696150(VS.85).aspx states that
the result is the object itself, if it has focus, or a child object of
the active window, not a child of the object.

Reviewed by Sam Weinig.

  • AccessibleBase.cpp: (AccessibleBase::get_accFocus): Don't check whether the focused object is our child.
5:56 AM Changeset in webkit [35903] by jhoneycutt@apple.com
  • 7 edits
    2 adds in trunk/WebKitTools

2008-08-24 Jon Honeycutt <​jhoneycutt@apple.com>

Initial support for accessibility layout tests on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=20497

Reviewed by Sam Weinig.

  • DumpRenderTree/AccessibilityController.h: Fix typos.
  • DumpRenderTree/AccessibilityUIElement.cpp: Change #import to #include.
  • DumpRenderTree/AccessibilityUIElement.h: Define _WINSOCKAPI_ to prevent oleacc.h, which includes windows.h, from including winsock.h. Fixed typos.
  • DumpRenderTree/win/AccessibilityControllerWin.cpp: Added. (AccessibilityController::AccessibilityController): (AccessibilityController::~AccessibilityController): (AccessibilityController::focusedElement): Get the root element, and request its focused object. (AccessibilityController::rootElement): Query Windows for the accessible client object for the WebView's window.
  • DumpRenderTree/win/AccessibilityUIElementWin.cpp: Added. (AccessibilityUIElement::AccessibilityUIElement): (AccessibilityUIElement::~AccessibilityUIElement): (AccessibilityUIElement::getLinkedUIElements): Not implemented. (AccessibilityUIElement::getChildren): Get the child count, and append each child. (AccessibilityUIElement::getChildAtIndex): Get the child at the given index offset by 1. In MSAA, child 0 is the object itself. (AccessibilityUIElement::allAttributes): Not implemented. (AccessibilityUIElement::attributesOfLinkedUIElements): Same. (AccessibilityUIElement::attributesOfChildren): Same. (AccessibilityUIElement::parameterizedAttributeNames): Same. (self): Return a VARIANT representing the "self" object. This is used when calling methods that require a child variant. (AccessibilityUIElement::role): Get the MSAA role, a long value, and convert it into a string with GetRoleText(). (AccessibilityUIElement::title): Get the element's title, and convert it to a JS String. (AccessibilityUIElement::description): Same, for description. (AccessibilityUIElement::width): (AccessibilityUIElement::height): (AccessibilityUIElement::intValue): Get the object's value as a string, and convert the string to a double. (AccessibilityUIElement::minValue): Not implemented. (AccessibilityUIElement::maxValue): Same. (AccessibilityUIElement::insertionPointLineNumber): Same. (AccessibilityUIElement::attributesOfColumnHeaders): Same. (AccessibilityUIElement::attributesOfRowHeaders): Same. (AccessibilityUIElement::attributesOfColumns): Same. (AccessibilityUIElement::attributesOfRows): Same. (AccessibilityUIElement::attributesOfVisibleCells): Same. (AccessibilityUIElement::attributesOfHeader): Same. (AccessibilityUIElement::indexInTable): Same. (AccessibilityUIElement::rowIndexRange): Same. (AccessibilityUIElement::columnIndexRange): Same. (AccessibilityUIElement::lineForIndex): Same. (AccessibilityUIElement::boundsForRange): Same. (AccessibilityUIElement::cellForColumnAndRow): Same.
  • DumpRenderTree/win/DumpRenderTree.vcproj: Add accessibility files to project. Link to oleacc.lib, the MSAA library.
  • DumpRenderTree/win/FrameLoadDelegate.cpp: (FrameLoadDelegate::FrameLoadDelegate): Initialize the accessibility controller. (FrameLoadDelegate::didClearWindowObject): Create a new window object for the accessibility controller.
  • DumpRenderTree/win/FrameLoadDelegate.h:
2:18 AM Changeset in webkit [35902] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Sam Weinig.

  • rendering/RenderText.cpp: (WebCore::RenderText::trimmedPrefWidths): Moved the assignment to beginWS and endWS before the early return to ensure that they are initialized in that case.
1:35 AM Changeset in webkit [35901] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Use the correct version number for when JSGlobalContextCreate was introduced.

Reviewed by Oliver Hunt.

Aug 23, 2008:

1:16 AM Changeset in webkit [35900] by cwzwarich@webkit.org
  • 108 edits in trunk

2008-08-23 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Rubber-stamped by Mark Rowe.

Remove modelines.

JavaScriptCore:

  • API/APICast.h:
  • API/JSBase.cpp:
  • API/JSCallbackConstructor.cpp:
  • API/JSCallbackConstructor.h:
  • API/JSCallbackFunction.cpp:
  • API/JSCallbackFunction.h:
  • API/JSCallbackObject.cpp:
  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h:
  • API/JSClassRef.cpp:
  • API/JSContextRef.cpp:
  • API/JSObjectRef.cpp:
  • API/JSProfilerPrivate.cpp:
  • API/JSStringRef.cpp:
  • API/JSStringRefBSTR.cpp:
  • API/JSStringRefCF.cpp:
  • API/JSValueRef.cpp:
  • API/tests/JSNode.c:
  • API/tests/JSNode.h:
  • API/tests/JSNodeList.c:
  • API/tests/JSNodeList.h:
  • API/tests/Node.c:
  • API/tests/Node.h:
  • API/tests/NodeList.c:
  • API/tests/NodeList.h:
  • API/tests/minidom.c:
  • API/tests/minidom.js:
  • API/tests/testapi.c:
  • API/tests/testapi.js:
  • JavaScriptCore.pro:
  • kjs/FunctionConstructor.h:
  • kjs/FunctionPrototype.h:
  • kjs/JSArray.h:
  • kjs/JSString.h:
  • kjs/JSWrapperObject.cpp:
  • kjs/NumberConstructor.h:
  • kjs/NumberObject.h:
  • kjs/NumberPrototype.h:
  • kjs/lexer.h:
  • kjs/lookup.h:
  • wtf/Assertions.cpp:
  • wtf/Assertions.h:
  • wtf/HashCountedSet.h:
  • wtf/HashFunctions.h:
  • wtf/HashIterators.h:
  • wtf/HashMap.h:
  • wtf/HashSet.h:
  • wtf/HashTable.h:
  • wtf/HashTraits.h:
  • wtf/ListHashSet.h:
  • wtf/ListRefPtr.h:
  • wtf/Noncopyable.h:
  • wtf/OwnArrayPtr.h:
  • wtf/OwnPtr.h:
  • wtf/PassRefPtr.h:
  • wtf/Platform.h:
  • wtf/RefPtr.h:
  • wtf/RefPtrHashMap.h:
  • wtf/RetainPtr.h:
  • wtf/UnusedParam.h:
  • wtf/Vector.h:
  • wtf/VectorTraits.h:
  • wtf/unicode/Unicode.h:
  • wtf/unicode/icu/UnicodeIcu.h:

WebCore:

  • WebCore.pro:
  • bridge/testbindings.cpp:
  • dom/DocPtr.h:
  • loader/SubstituteData.h:
  • page/Chrome.cpp:
  • page/Chrome.h:
  • page/ChromeClient.h:
  • page/Frame.h:
  • page/FrameLoadRequest.h:
  • page/FrameTree.cpp:
  • page/FrameTree.h:
  • page/Page.h:
  • page/mac/ChromeMac.mm:
  • platform/network/HTTPHeaderMap.h:
  • platform/network/ResourceErrorBase.cpp:
  • platform/network/ResourceErrorBase.h:
  • platform/network/ResourceHandleInternal.h:
  • platform/network/ResourceRequestBase.cpp:
  • platform/network/ResourceRequestBase.h:
  • platform/network/ResourceResponseBase.cpp:
  • platform/network/ResourceResponseBase.h:
  • platform/network/cf/ResourceError.h:
  • platform/network/cf/ResourceRequest.h:
  • platform/network/cf/ResourceRequestCFNet.h:
  • platform/network/cf/ResourceResponse.h:
  • platform/network/cf/ResourceResponseCFNet.h:
  • platform/network/curl/ResourceError.h:
  • platform/network/curl/ResourceRequest.h:
  • platform/network/curl/ResourceResponse.h:
  • platform/network/mac/ResourceError.h:
  • platform/network/mac/ResourceErrorMac.mm:
  • platform/network/mac/ResourceRequest.h:
  • platform/network/mac/ResourceRequestMac.mm:
  • platform/network/mac/ResourceResponse.h:
  • platform/network/mac/ResourceResponseMac.mm:
  • platform/network/qt/ResourceError.h:
  • platform/network/qt/ResourceRequest.h:
  • platform/network/qt/ResourceResponse.h:
  • platform/network/soup/CookieJarSoup.cpp:
  • platform/network/soup/ResourceError.h:
  • platform/network/soup/ResourceRequest.h:
  • platform/network/soup/ResourceResponse.h:
12:16 AM Changeset in webkit [35899] by mitz@apple.com
  • 14 edits
    4 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

  • fix <rdar://problem/6065143> Reflowed image in first line of table doesn't affect baseline

Test: fast/table/vertical-align-baseline.html

  • rendering/RenderTable.cpp: (WebCore::RenderTable::getBaselineOfFirstLineBox): Added. Returns the baseline of the first table row, if there is one, -1 otherwise.
  • rendering/RenderTable.h:
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::baselinePosition): Changed to follow the CSS2.1 definition of the baseline of a table cell.
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::getBaselineOfFirstLineBox): Added. Returns the baseline of the first row in the section.
  • rendering/RenderTableSection.h:

LayoutTests:

Reviewed by Dave Hyatt.

  • test and updated results for <rdar://problem/6065143> Reflowed image in first line of table doesn't affect baseline
  • fast/table/vertical-align-baseline.html: Added.
  • platform/mac/fast/table/form-with-table-style-expected.checksum:
  • platform/mac/fast/table/form-with-table-style-expected.png:
  • platform/mac/fast/table/form-with-table-style-expected.txt:
  • platform/mac/fast/table/vertical-align-baseline-expected.checksum: Added.
  • platform/mac/fast/table/vertical-align-baseline-expected.png: Added.
  • platform/mac/fast/table/vertical-align-baseline-expected.txt: Added.
  • platform/mac/tables/mozilla/bugs/bug3037-1-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.checksum:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
Note: See TracTimeline for information about the timeline view.