⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 25, 2008:

9:19 PM Changeset in webkit [35928] by weinig@apple.com
  • 5 edits
    3 adds in trunk

WebCore:

2008-08-25 Sam Weinig <​sam@webkit.org>

Reviewed by Oliver Hunt.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=20514
<rdar://problem/6174096>
Treat SVG images as dirty when drawing to a canvas.

Test: http/tests/security/canvas-remote-read-svg-image.html

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage): (WebCore::CanvasRenderingContext2D::drawImageFromRect):
  • platform/graphics/Image.h: (WebCore::Image::isSVGImage):
  • svg/graphics/SVGImage.h: (WebCore::SVGImage::isSVGImage):

LayoutTests:

2008-08-25 Sam Weinig <​sam@webkit.org>

Reviewed by Oliver Hunt.

Test for ​https://bugs.webkit.org/show_bug.cgi?id=20514

  • http/tests/security/canvas-remote-read-svg-image-expected.txt: Added.
  • http/tests/security/canvas-remote-read-svg-image.html: Added.
  • http/tests/security/resources/image-wrapper.svg: Added.
6:52 PM Changeset in webkit [35927] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-08-25 Sam Weinig <​sam@webkit.org>

Reviewed by Mark Rowe.

Fix ​https://bugs.webkit.org/show_bug.cgi?id=20377
Leak in XMLHttpRequest.

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight):
5:59 PM Changeset in webkit [35926] by sfalken@apple.com
  • 2 edits in trunk/WebKitTools

Build fix. Copy correct version of ICU.

  • DumpRenderTree/win/DumpRenderTree.vcproj:
2:48 PM Changeset in webkit [35925] by beidson@apple.com
  • 2 edits in trunk/WebCore

2008-08-25 Brady Eidson <​beidson@apple.com>

Reviewed by Anders

Speculative fix for <rdar://problem/6173217>

Moves the "clearArchivedResources()" call to exactly where it used to be in the old version of WebArchive code.
Also, adds a null check for m_documentLoader since DocumentLoader::stopLoading() can end up clearing it, rendering
the first null check invalid.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stopAllLoaders):
2:28 PM Changeset in webkit [35924] by kmccullough@apple.com
  • 2 edits in trunk/WebCore

2008-08-25 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Tim.

<rdar://problem/6157711> Heavy/Tree view selector is not grayed out if
there is no profile, can cause crash

  • page/inspector/ProfilesPanel.js:
2:06 PM Changeset in webkit [35923] by dino@apple.com
  • 3 edits
    4 adds in trunk

2008-08-25 Dean Jackson <​dino@apple.com>

Reviewed by Dave Hyatt

Make sure 'inherit' is handled by transition property.
​https://bugs.webkit.org/show_bug.cgi?id=20513

Test: transitions/inherit.html
Test: transitions/inherit-other-props.html

  • css/CSSStyleSelector.cpp: fix macro to check existence of list before getting size
1:56 PM Changeset in webkit [35922] by andersca@apple.com
  • 2 edits in trunk/WebCore

2008-08-25 Anders Carlsson <​andersca@apple.com>

Reviewed by Mark.

<rdar://problem/6149787> crash @ com.apple.JavaScriptCore: WTF::callOnMainThread + 37.


Initialize threading in the call to WebCoreObjCFinalizeOnMainThread. We currently assume
(safely) that any class that needs finalization on the main thread will also need to be deallocated
on the main thread, and calling initializeThreading from WebCoreObjCFinalizeOnMainThread instead of
calling it from WebCoreObjCScheduleDeallocateOnMainThread seems safer.

  • platform/mac/WebCoreObjCExtras.c: (WebCoreObjCFinalizeOnMainThread):
1:41 PM Changeset in webkit [35921] by Antti Koivisto
  • 4 edits in trunk/WebCore

2008-08-25 Antti Koivisto <Antti Koivisto>

Reviewed by Dan Bernstein.

Rename CachedResource::referenced() to CachedResource::hasClients() to
match previous ref() -> addClient() rename.

  • loader/Cache.cpp: (WebCore::Cache::pruneLiveResources): (WebCore::Cache::pruneDeadResources): (WebCore::Cache::remove): (WebCore::Cache::getStatistics): (WebCore::Cache::dumpLRULists):
  • loader/CachedResource.cpp: (WebCore::CachedResource::addClient): (WebCore::CachedResource::removeClient): (WebCore::CachedResource::setDecodedSize): (WebCore::CachedResource::setEncodedSize):
  • loader/CachedResource.h: (WebCore::CachedResource::hasClients): (WebCore::CachedResource::canDelete):
12:53 PM Changeset in webkit [35920] by Adam Roben
  • 2 edits in trunk/WebKit/win

Fix an assertion when showing the Web Inspector

Reviewed by Kevin McCullough.

  • WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::attachWindow): (WebInspectorClient::detachWindow): Recent code changes have caused these functions to get called even when the window is already attached/detached, respectively. Handle this case gracefully instead of asserting something that is no longer true.
11:33 AM Changeset in webkit [35919] by timothy@apple.com
  • 2 edits in trunk/WebCore

Add a missing Inspector localized string for "other".

​https://bugs.webkit.org/show_bug.cgi?id=20509

Reviewed by Tim Hatcher.

  • English.lproj/localizedStrings.js:
11:18 AM Changeset in webkit [35918] by kmccullough@apple.com
  • 12 edits
    2 adds in trunk

JavaScriptCore:

2008-08-25 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Geoff, Tim and Mark.

<rdar://problem/6150623> JSProfiler: It would be nice if the profiles
in the console said what file and line number they came from

  • Lay the foundation for getting line numbers and other data from the JavaScript engine. With the cleanup in kjs/ExecState this is actually a slight performance improvement.
  • JavaScriptCore.exp: Export retrieveLastCaller() for WebCore.
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • VM/Machine.cpp: Now Host and JS functions set a call frame on the exec state, so this and the profiler code were pulled out of the branches. (KJS::Machine::privateExecute): (KJS::Machine::retrieveLastCaller): This get's the lineNumber, sourceID and sourceURL for the previously called function.
  • VM/Machine.h:
  • kjs/ExecState.cpp: Remove references to JSFunction since it's not used anywhere.
  • kjs/ExecState.h:

WebCore:

2008-08-22 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Geoff, Mark and Tim.

<rdar://problem/6150623> JSProfiler: It would be nice if the profiles
in the console said what file and line number they came from

  • Lay the foundation for getting line numbers and other data from the JavaScript engine.
  • ForwardingHeaders/VM: Added.
  • ForwardingHeaders/VM/Machine.h: Added.
  • page/Console.cpp: Gather the line number and file information when profileEnd has been called, but don't use it until didFinishProfiling is called. We won't need to wait once we remove the profiler "zombie" mode which this patch helps pave the foundation for. (WebCore::Console::Console): (WebCore::Console::profileEnd): (WebCore::Console::finishedProfiling):
  • page/Console.h:
  • page/InspectorController.cpp: Modify calls to addProfileMessageToConsole to satisfy the new arguments it takes. (WebCore::InspectorController::finishedProfiling): (WebCore::InspectorController::addProfile): (WebCore::InspectorController::addProfileMessageToConsole): (WebCore::InspectorController::finishedProfiling):
  • page/InspectorController.h:
9:21 AM ApplicationsGtk edited by vperetokin@gmail.com
Fixed the gtkmm entry, because it pointed to the internals of a git … (diff)
5:40 AM Changeset in webkit [35917] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

Ensure that JSGlobalContextRelease() performs garbage collection, even if there are other
contexts in the current context's group.

This is only really necessary when the last reference is released, but there is no way to
determine that, and no harm in collecting slightly more often.

  • API/JSContextRef.cpp: (JSGlobalContextRelease): Explicitly collect the heap if it is not being destroyed.
3:08 AM Changeset in webkit [35916] by Simon Hausmann
  • 2 edits in trunk/WebKitTools

2008-08-25 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Simon.

[run-webkit-tests] Use QtLauncher to show the results of the tests
konqueror might not be installed, xdg-open might not be installed but the
QtLauncher should be present.

3:06 AM Changeset in webkit [35915] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-08-25 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Simon.

[inspector] Update the WebKit.qrc Qt resources file
Catchup with the changes in the directory.

3:06 AM Changeset in webkit [35914] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

[inspector] Emit signals from attachWindow and detachWindow in the Qt platform

Allow the user of the API to honor the attachWindow and detachWindow
requests and attach the QWebPage/QWebView wherever it is wanted. This needs
some more API in QWebPage to be properly exposed.

12:10 AM Changeset in webkit [35913] by Simon Hausmann
  • 2 edits in trunk/WebCore

008-08-25 Dirk Schulze <​vbs85@gmx.de>

Reviewed by Simon.

Transformed the radian to degree, to get rotate()
in canvas work as expected.

[Qt] Canvas.rotate() doesn't work
​https://bugs.webkit.org/show_bug.cgi?id=20496

Aug 24, 2008:

10:43 PM Changeset in webkit [35912] by sfalken@apple.com
  • 2 edits in trunk/WebCore

2008-08-24 Steve Falkenburg <​sfalken@apple.com>

Add a "last chance" WM_TIMER to the Windows shared timer.


The last chance timer fires every 5 seconds to run any lost WM_TIMER based timers.
Failure to fire a timer is fatal to the cross-platform Timer code, since it won't re-schedule
timers if a timer with an earlier expiration is already pending. This results in no timers
firing from that point on.


We lose WM_TIMER messages occasionally (in the neighborhood of 1 per hour) probably due to a
buggy window message hook.


This timer will start when the first WM_TIMER is scheduled, and will
fire every 5 seconds thereafter, causing any lost timers to be fired.


Found this via one of its symptoms: leaking WebFrames. The fix prevents timers from stalling
and prevents the WebFrame leak.


Reviewed by Darin Adler, Geoff Garen.

  • platform/win/SharedTimerWin.cpp: (WebCore::): (WebCore::TimerWindowWndProc): (WebCore::setSharedTimerFireTime):
9:08 PM Changeset in webkit [35911] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-08-24 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Oliver Hunt.

Bug 20093: JSC shell does not clear exceptions after it executes toString on an expression
<​https://bugs.webkit.org/show_bug.cgi?id=20093>

Clear exceptions after evaluating any code in the JSC shell. We do not
report exceptions that are caused by calling toString on the final
valued, but at least we avoid incorrect behaviour.

Also, print any exceptions that occurred while evaluating code at the
interactive prompt, not just while evaluating code from a file.

  • kjs/Shell.cpp: (runWithScripts): (runInteractive):
8:22 PM Changeset in webkit [35910] by mitz@apple.com
  • 4 edits
    2 adds in trunk

WebCore:

Reviewed by Darin Adler.

  • fix <rdar://problem/6065547> REGRESSION (r34879): "Subject" in unread emails in Yahoo mail is not shown in bold

Test: fast/css/font-property-priority.html

  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Changed to pass the 'important' flag to the font-property-parsing functions. (WebCore::CSSParser::parseFontStyle): Added an 'important' argument and changed to use it rather than the m_important member. (WebCore::CSSParser::parseFontVariant): Ditto. (WebCore::CSSParser::parseFontWeight): Ditto.
  • css/CSSParser.h:

LayoutTests:

Reviewed by Darin Adler.

  • test for <rdar://problem/6065547> REGRESSION (r34879): "Subject" in unread emails in Yahoo mail is not shown in bold
  • fast/css/font-property-priority-expected.txt: Added.
  • fast/css/font-property-priority.html: Added.
6:27 PM Changeset in webkit [35909] by Beth Dakin
  • 4 edits in trunk/WebKit/win

2008-08-24 Beth Dakin <Beth Dakin>

Reviewed by John Sullivan.

Provide the excludeFromTextSearch SPI on Windows as well.

  • Interfaces/IWebFrame.idl:
  • WebFrame.cpp: (WebFrame::setExcludeFromTextSearch):
  • WebFrame.h:
3:28 PM Changeset in webkit [35908] by timothy@apple.com
  • 2 edits
    1 add in trunk/WebCore

Fixes a bug where the Inspector's UI would not animate or
fully function because JavaScript timeouts, intervals and
CSS animation timers where not firing while paused at a
a breakpoint in the inspected page.

​https://bugs.webkit.org/show_bug.cgi?id=20042

Reviewed by Darin Adler.

Test: manual-tests/inspector/forzen-ui-while-paused.html

  • page/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::pauseIfNeeded): Add a call to TimerBase::fireTimersInNestedEventLoop before spinning the EventLoop.
3:25 PM Changeset in webkit [35907] by mrowe@apple.com
  • 1 copy in tags/Safari-6528.2

New tag.

2:30 PM Changeset in webkit [35906] by cwzwarich@webkit.org
  • 2 edits in trunk

2008-08-24 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Oliver.

Remove an unnecessary RefPtr to a RegisterID.

  • kjs/nodes.cpp: (KJS::DeleteBracketNode::emitCode):
11:07 AM Changeset in webkit [35905] by rwlbuis@webkit.org
  • 4 edits
    4 adds in trunk

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=20324
A change in SVG Glyph wont show up

Invalidate the glyph cache when the d attribute is set.

Test: svg/custom/glyph-setting-d-attribute.svg

5:59 AM Changeset in webkit [35904] by jhoneycutt@apple.com
  • 2 edits in trunk/WebKit/win

2008-08-24 Jon Honeycutt <​jhoneycutt@apple.com>

Cannot get the focused accessible object from the root object.

AccessibleBase::get_AccFocus() checks whether the focused object is a
child of the current object, but
​http://msdn.microsoft.com/en-us/library/ms696150(VS.85).aspx states that
the result is the object itself, if it has focus, or a child object of
the active window, not a child of the object.

Reviewed by Sam Weinig.

  • AccessibleBase.cpp: (AccessibleBase::get_accFocus): Don't check whether the focused object is our child.
5:56 AM Changeset in webkit [35903] by jhoneycutt@apple.com
  • 7 edits
    2 adds in trunk/WebKitTools

2008-08-24 Jon Honeycutt <​jhoneycutt@apple.com>

Initial support for accessibility layout tests on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=20497

Reviewed by Sam Weinig.

  • DumpRenderTree/AccessibilityController.h: Fix typos.
  • DumpRenderTree/AccessibilityUIElement.cpp: Change #import to #include.
  • DumpRenderTree/AccessibilityUIElement.h: Define _WINSOCKAPI_ to prevent oleacc.h, which includes windows.h, from including winsock.h. Fixed typos.
  • DumpRenderTree/win/AccessibilityControllerWin.cpp: Added. (AccessibilityController::AccessibilityController): (AccessibilityController::~AccessibilityController): (AccessibilityController::focusedElement): Get the root element, and request its focused object. (AccessibilityController::rootElement): Query Windows for the accessible client object for the WebView's window.
  • DumpRenderTree/win/AccessibilityUIElementWin.cpp: Added. (AccessibilityUIElement::AccessibilityUIElement): (AccessibilityUIElement::~AccessibilityUIElement): (AccessibilityUIElement::getLinkedUIElements): Not implemented. (AccessibilityUIElement::getChildren): Get the child count, and append each child. (AccessibilityUIElement::getChildAtIndex): Get the child at the given index offset by 1. In MSAA, child 0 is the object itself. (AccessibilityUIElement::allAttributes): Not implemented. (AccessibilityUIElement::attributesOfLinkedUIElements): Same. (AccessibilityUIElement::attributesOfChildren): Same. (AccessibilityUIElement::parameterizedAttributeNames): Same. (self): Return a VARIANT representing the "self" object. This is used when calling methods that require a child variant. (AccessibilityUIElement::role): Get the MSAA role, a long value, and convert it into a string with GetRoleText(). (AccessibilityUIElement::title): Get the element's title, and convert it to a JS String. (AccessibilityUIElement::description): Same, for description. (AccessibilityUIElement::width): (AccessibilityUIElement::height): (AccessibilityUIElement::intValue): Get the object's value as a string, and convert the string to a double. (AccessibilityUIElement::minValue): Not implemented. (AccessibilityUIElement::maxValue): Same. (AccessibilityUIElement::insertionPointLineNumber): Same. (AccessibilityUIElement::attributesOfColumnHeaders): Same. (AccessibilityUIElement::attributesOfRowHeaders): Same. (AccessibilityUIElement::attributesOfColumns): Same. (AccessibilityUIElement::attributesOfRows): Same. (AccessibilityUIElement::attributesOfVisibleCells): Same. (AccessibilityUIElement::attributesOfHeader): Same. (AccessibilityUIElement::indexInTable): Same. (AccessibilityUIElement::rowIndexRange): Same. (AccessibilityUIElement::columnIndexRange): Same. (AccessibilityUIElement::lineForIndex): Same. (AccessibilityUIElement::boundsForRange): Same. (AccessibilityUIElement::cellForColumnAndRow): Same.
  • DumpRenderTree/win/DumpRenderTree.vcproj: Add accessibility files to project. Link to oleacc.lib, the MSAA library.
  • DumpRenderTree/win/FrameLoadDelegate.cpp: (FrameLoadDelegate::FrameLoadDelegate): Initialize the accessibility controller. (FrameLoadDelegate::didClearWindowObject): Create a new window object for the accessibility controller.
  • DumpRenderTree/win/FrameLoadDelegate.h:
2:18 AM Changeset in webkit [35902] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Sam Weinig.

  • rendering/RenderText.cpp: (WebCore::RenderText::trimmedPrefWidths): Moved the assignment to beginWS and endWS before the early return to ensure that they are initialized in that case.
1:35 AM Changeset in webkit [35901] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Use the correct version number for when JSGlobalContextCreate was introduced.

Reviewed by Oliver Hunt.

Note: See TracTimeline for information about the timeline view.