⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 26, 2008:

9:35 PM WikiStart edited by wsiegrist@apple.com
Fixed register and login links (diff)
5:14 PM Changeset in webkit [35941] by abarth@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2008-08-26 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Test for ​https://bugs.webkit.org/show_bug.cgi?id=20456

  • http/tests/security/object-literals-expected.txt: Added.
  • http/tests/security/object-literals.html: Added.
  • http/tests/security/resources/object-literals-cross-origin.html: Added.
  • http/tests/security/resources/object-literals-same-origin.html: Added.
4:47 PM Changeset in webkit [35940] by kmccullough@apple.com
  • 3 edits
    3 adds in trunk

JavaScriptCore:

2008-08-26 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Geoff and Cameron.

<rdar://problem/6174603> Hitting assertion in Register::codeBlock when
loading facebook (20516).

  • This was a result of my line numbers change. After a host function is called the stack does not get reset correctly.
  • Oddly this also appears to be a slight speedup on SunSpider.
  • VM/Machine.cpp: (KJS::Machine::privateExecute):

LayoutTests:

2008-08-26 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Geoff and Cameron.

<rdar://problem/6174603> Hitting assertion in Register::codeBlock when
loading facebook (20516).

  • This was a result of my line numbers change. After a host function is called the stack does not get reset correctly.
  • Oddly this also appears to be a slight speedup on SunSpider.
  • fast/js/resources/stack-unwinding.js: Added.
  • fast/js/stack-unwinding-expected.txt: Added.
  • fast/js/stack-unwinding.html: Added.
3:56 PM Changeset in webkit [35939] by Chris Fleizach
  • 8 edits
    6 adds in trunk

<rdar://problem/6069462> REGRESSION: webkit is returning flash objects as AXUnknown

3:43 PM Changeset in webkit [35938] by Chris Fleizach
  • 2 edits in trunk/WebCore

<rdar://problem/5817770> can't bring up contextual menu for embedded objects

3:29 PM Changeset in webkit [35937] by Chris Fleizach
  • 3 edits
    2 adds in trunk

<rdar://problem/6176924> CrashTracer: [USER] 4 crashes in Safari at com.apple.WebCore: WebCore::RenderTableSection::numColumns

2:21 PM Changeset in webkit [35936] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-08-26 Sam Weinig <​sam@webkit.org>

Reviewed by Beth Dakin.

Fix typo.

  • dom/DOMCoreException.h:
12:56 PM Changeset in webkit [35935] by weinig@apple.com
  • 5 edits
    3 adds in trunk

WebCore:

2008-08-26 Sam Weinig <​sam@webkit.org>

Reviewed by Oliver Hunt.

Fix ​https://bugs.webkit.org/show_bug.cgi?id=20479
<rdar://problem/6167660>
Take image redirects into account when tainting the canvas.

Test: http/tests/security/canvas-remote-read-redirect-to-remote-image.html

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage): (WebCore::CanvasRenderingContext2D::drawImageFromRect):

LayoutTests:

2008-08-26 Sam Weinig <​sam@webkit.org>

Reviewed by Oliver Hunt.

Test for ​https://bugs.webkit.org/show_bug.cgi?id=20479

  • http/tests/security/canvas-remote-read-redirect-to-remote-image-expected.txt: Added.
  • http/tests/security/canvas-remote-read-redirect-to-remote-image.html: Added.
  • http/tests/security/canvas-remote-read-svg-image-expected.txt:
  • http/tests/security/canvas-remote-read-svg-image.html: Fix incorrect log message.
  • http/tests/security/resources/redir.php: Added.
12:51 PM Changeset in webkit [35934] by weinig@apple.com
  • 7 edits in trunk/WebCore

2008-08-26 Sam Weinig <​sam@webkit.org>

Reviewed by Darin Adler.

Change canvas tainting logic to ask the image if it contains
any resources outside of its own origin. Since there is no
way to determine if SVG images contain any resources outside its
origin, we always assume it does.

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage): (WebCore::CanvasRenderingContext2D::drawImageFromRect):
  • platform/graphics/BitmapImage.h: (WebCore::BitmapImage::hasSingleSecurityOrigin):
  • platform/graphics/GeneratedImage.h: (WebCore::GeneratedImage::hasSingleSecurityOrigin):
  • platform/graphics/Image.h: (WebCore::Image::hasSingleSecurityOrigin):
  • platform/graphics/cg/PDFDocumentImage.h: (WebCore::PDFDocumentImage::hasSingleSecurityOrigin):
  • svg/graphics/SVGImage.h:
10:51 AM Changeset in webkit [35933] by britto@apple.com
  • 6 edits in trunk/WebCore

2008-08-26 Maxime Britto <​britto@apple.com>

Reviewed by Adele.

<rdar://6159244> Pan-scrolling does not work on particular sites (starmagazine.com, nytimes.com)
This patch fixes the issues and modify the behavior of the panscroll by allowing it to jump to a parent layer when it reaches the end of its scrollable area.
This is matching the behavior of the mouse wheel when trying to scroll in a smaller layer of the page (div, textarea, ...) and when we reach the edge and keep scrolling then the whole page scrolls.

  • page/EventHandler.cpp: (WebCore::EventHandler::updateAutoscrollRenderer): if we switch to the parent layer to do the scroll we want to change the renderer for the panning
  • page/EventHandler.h:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::panScrollFromPoint): now calls the scrollByRecursively method when it has computed the xDelta and yDelta (WebCore::RenderLayer::scrollByRecursively): try to scroll the current layer by the xDelta and yDelta provided, if it can't it ask its parent layer to do so.
  • rendering/RenderLayer.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::canBeProgramaticallyScrolled): a RenderObject must have a RenderLayer to be programatically scrolled (WebCore::RenderObject::autoscroll): No need to check for the layer anymore since we verify it's present in the upmentionned method (WebCore::RenderObject::panScroll): No need to check for the layer anymore too.
9:07 AM Changeset in webkit [35932] by Adam Roben
  • 2 edits in trunk/WebKitLibraries

Disable a truncation warning that is disabled/doesn't exist on Mac

This warning was firing when initializing floats from double literals.
I haven't yet found any other situation that would cause this warning
to arise.

Reviewed by Sam Weinig.

  • win/tools/vsprops/common.vsprops: Turn off warning C4305.
3:27 AM Changeset in webkit [35931] by jchaffraix@webkit.org
  • 6 edits
    3 adds in trunk

WebCore:

2008-08-25 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Darin.

Bug 20247: setAttributeNode() does not work when attribute name has a capital letter in it
​https://bugs.webkit.org/show_bug.cgi?id=20247

<rdar://problem/6118218>

Add a boolean parameter to getAttributeItem to choose between case sensitive and case insensitive
check. This keeps the behaviour for setAttribute / hasAttribute (case sensitive) and getAttribute
(case insensitive for HTML elements).

Test: fast/dom/Element/getAttribute-check-case-sensitivity.html

  • dom/Element.cpp: (WebCore::Element::getAttribute):
  • dom/NamedAttrMap.cpp: (WebCore::NamedAttrMap::getNamedItem): (WebCore::NamedAttrMap::getAttributeItem):
  • dom/NamedAttrMap.h:

LayoutTests:

2008-08-25 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Darin.

Test case for Bug 20247: setAttributeNode() does not work when attribute name
has a capital letter in it
​https://bugs.webkit.org/show_bug.cgi?id=20247

<rdar://problem/6118218>

Most of this test case was done by Eric Roman <​minatoar@gmail.com>, the rest by ap and was
tweaked by me.

  • fast/dom/Element/getAttribute-check-case-sensitivity-expected.txt: Added.
  • fast/dom/Element/getAttribute-check-case-sensitivity.html: Added.
  • fast/dom/Element/resources/getAttribute-check-case-sensitivity.js: Added.
12:05 AM Changeset in webkit [35930] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Reviewed by Geoff and Tim.

Export new API methods.

12:00 AM Changeset in webkit [35929] by mrowe@apple.com
  • 2 edits in trunk/WebKitSite

Modernize the bug reporting guidelines and make them a little less Mac-specific.

Reviewed by Dan Bernstein.

  • quality/bugwriting.html:

Aug 25, 2008:

9:19 PM Changeset in webkit [35928] by weinig@apple.com
  • 5 edits
    3 adds in trunk

WebCore:

2008-08-25 Sam Weinig <​sam@webkit.org>

Reviewed by Oliver Hunt.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=20514
<rdar://problem/6174096>
Treat SVG images as dirty when drawing to a canvas.

Test: http/tests/security/canvas-remote-read-svg-image.html

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage): (WebCore::CanvasRenderingContext2D::drawImageFromRect):
  • platform/graphics/Image.h: (WebCore::Image::isSVGImage):
  • svg/graphics/SVGImage.h: (WebCore::SVGImage::isSVGImage):

LayoutTests:

2008-08-25 Sam Weinig <​sam@webkit.org>

Reviewed by Oliver Hunt.

Test for ​https://bugs.webkit.org/show_bug.cgi?id=20514

  • http/tests/security/canvas-remote-read-svg-image-expected.txt: Added.
  • http/tests/security/canvas-remote-read-svg-image.html: Added.
  • http/tests/security/resources/image-wrapper.svg: Added.
6:52 PM Changeset in webkit [35927] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-08-25 Sam Weinig <​sam@webkit.org>

Reviewed by Mark Rowe.

Fix ​https://bugs.webkit.org/show_bug.cgi?id=20377
Leak in XMLHttpRequest.

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight):
5:59 PM Changeset in webkit [35926] by sfalken@apple.com
  • 2 edits in trunk/WebKitTools

Build fix. Copy correct version of ICU.

  • DumpRenderTree/win/DumpRenderTree.vcproj:
2:48 PM Changeset in webkit [35925] by beidson@apple.com
  • 2 edits in trunk/WebCore

2008-08-25 Brady Eidson <​beidson@apple.com>

Reviewed by Anders

Speculative fix for <rdar://problem/6173217>

Moves the "clearArchivedResources()" call to exactly where it used to be in the old version of WebArchive code.
Also, adds a null check for m_documentLoader since DocumentLoader::stopLoading() can end up clearing it, rendering
the first null check invalid.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stopAllLoaders):
2:28 PM Changeset in webkit [35924] by kmccullough@apple.com
  • 2 edits in trunk/WebCore

2008-08-25 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Tim.

<rdar://problem/6157711> Heavy/Tree view selector is not grayed out if
there is no profile, can cause crash

  • page/inspector/ProfilesPanel.js:
2:06 PM Changeset in webkit [35923] by dino@apple.com
  • 3 edits
    4 adds in trunk

2008-08-25 Dean Jackson <​dino@apple.com>

Reviewed by Dave Hyatt

Make sure 'inherit' is handled by transition property.
​https://bugs.webkit.org/show_bug.cgi?id=20513

Test: transitions/inherit.html
Test: transitions/inherit-other-props.html

  • css/CSSStyleSelector.cpp: fix macro to check existence of list before getting size
1:56 PM Changeset in webkit [35922] by andersca@apple.com
  • 2 edits in trunk/WebCore

2008-08-25 Anders Carlsson <​andersca@apple.com>

Reviewed by Mark.

<rdar://problem/6149787> crash @ com.apple.JavaScriptCore: WTF::callOnMainThread + 37.


Initialize threading in the call to WebCoreObjCFinalizeOnMainThread. We currently assume
(safely) that any class that needs finalization on the main thread will also need to be deallocated
on the main thread, and calling initializeThreading from WebCoreObjCFinalizeOnMainThread instead of
calling it from WebCoreObjCScheduleDeallocateOnMainThread seems safer.

  • platform/mac/WebCoreObjCExtras.c: (WebCoreObjCFinalizeOnMainThread):
1:41 PM Changeset in webkit [35921] by Antti Koivisto
  • 4 edits in trunk/WebCore

2008-08-25 Antti Koivisto <Antti Koivisto>

Reviewed by Dan Bernstein.

Rename CachedResource::referenced() to CachedResource::hasClients() to
match previous ref() -> addClient() rename.

  • loader/Cache.cpp: (WebCore::Cache::pruneLiveResources): (WebCore::Cache::pruneDeadResources): (WebCore::Cache::remove): (WebCore::Cache::getStatistics): (WebCore::Cache::dumpLRULists):
  • loader/CachedResource.cpp: (WebCore::CachedResource::addClient): (WebCore::CachedResource::removeClient): (WebCore::CachedResource::setDecodedSize): (WebCore::CachedResource::setEncodedSize):
  • loader/CachedResource.h: (WebCore::CachedResource::hasClients): (WebCore::CachedResource::canDelete):
12:53 PM Changeset in webkit [35920] by Adam Roben
  • 2 edits in trunk/WebKit/win

Fix an assertion when showing the Web Inspector

Reviewed by Kevin McCullough.

  • WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::attachWindow): (WebInspectorClient::detachWindow): Recent code changes have caused these functions to get called even when the window is already attached/detached, respectively. Handle this case gracefully instead of asserting something that is no longer true.
11:33 AM Changeset in webkit [35919] by timothy@apple.com
  • 2 edits in trunk/WebCore

Add a missing Inspector localized string for "other".

​https://bugs.webkit.org/show_bug.cgi?id=20509

Reviewed by Tim Hatcher.

  • English.lproj/localizedStrings.js:
11:18 AM Changeset in webkit [35918] by kmccullough@apple.com
  • 12 edits
    2 adds in trunk

JavaScriptCore:

2008-08-25 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Geoff, Tim and Mark.

<rdar://problem/6150623> JSProfiler: It would be nice if the profiles
in the console said what file and line number they came from

  • Lay the foundation for getting line numbers and other data from the JavaScript engine. With the cleanup in kjs/ExecState this is actually a slight performance improvement.
  • JavaScriptCore.exp: Export retrieveLastCaller() for WebCore.
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • VM/Machine.cpp: Now Host and JS functions set a call frame on the exec state, so this and the profiler code were pulled out of the branches. (KJS::Machine::privateExecute): (KJS::Machine::retrieveLastCaller): This get's the lineNumber, sourceID and sourceURL for the previously called function.
  • VM/Machine.h:
  • kjs/ExecState.cpp: Remove references to JSFunction since it's not used anywhere.
  • kjs/ExecState.h:

WebCore:

2008-08-22 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Geoff, Mark and Tim.

<rdar://problem/6150623> JSProfiler: It would be nice if the profiles
in the console said what file and line number they came from

  • Lay the foundation for getting line numbers and other data from the JavaScript engine.
  • ForwardingHeaders/VM: Added.
  • ForwardingHeaders/VM/Machine.h: Added.
  • page/Console.cpp: Gather the line number and file information when profileEnd has been called, but don't use it until didFinishProfiling is called. We won't need to wait once we remove the profiler "zombie" mode which this patch helps pave the foundation for. (WebCore::Console::Console): (WebCore::Console::profileEnd): (WebCore::Console::finishedProfiling):
  • page/Console.h:
  • page/InspectorController.cpp: Modify calls to addProfileMessageToConsole to satisfy the new arguments it takes. (WebCore::InspectorController::finishedProfiling): (WebCore::InspectorController::addProfile): (WebCore::InspectorController::addProfileMessageToConsole): (WebCore::InspectorController::finishedProfiling):
  • page/InspectorController.h:
9:21 AM ApplicationsGtk edited by vperetokin@gmail.com
Fixed the gtkmm entry, because it pointed to the internals of a git … (diff)
5:40 AM Changeset in webkit [35917] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

Ensure that JSGlobalContextRelease() performs garbage collection, even if there are other
contexts in the current context's group.

This is only really necessary when the last reference is released, but there is no way to
determine that, and no harm in collecting slightly more often.

  • API/JSContextRef.cpp: (JSGlobalContextRelease): Explicitly collect the heap if it is not being destroyed.
3:08 AM Changeset in webkit [35916] by Simon Hausmann
  • 2 edits in trunk/WebKitTools

2008-08-25 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Simon.

[run-webkit-tests] Use QtLauncher to show the results of the tests
konqueror might not be installed, xdg-open might not be installed but the
QtLauncher should be present.

3:06 AM Changeset in webkit [35915] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-08-25 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Simon.

[inspector] Update the WebKit.qrc Qt resources file
Catchup with the changes in the directory.

3:06 AM Changeset in webkit [35914] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

[inspector] Emit signals from attachWindow and detachWindow in the Qt platform

Allow the user of the API to honor the attachWindow and detachWindow
requests and attach the QWebPage/QWebView wherever it is wanted. This needs
some more API in QWebPage to be properly exposed.

12:10 AM Changeset in webkit [35913] by Simon Hausmann
  • 2 edits in trunk/WebCore

008-08-25 Dirk Schulze <​vbs85@gmx.de>

Reviewed by Simon.

Transformed the radian to degree, to get rotate()
in canvas work as expected.

[Qt] Canvas.rotate() doesn't work
​https://bugs.webkit.org/show_bug.cgi?id=20496

Note: See TracTimeline for information about the timeline view.