Context Navigation

← Previous Period
Next Period →

Timeline

Aug 28, 2008:

10:20 PM Changeset in webkit [35986] by cwzwarich@webkit.org

4 edits in trunk/JavaScriptCore

2008-08-28 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Rubber-stamped by Sam Weinig.

Change 'term' to 'expr' in variable names to standardize terminology.

kjs/nodes.cpp: (KJS::BinaryOpNode::emitCode): (KJS::ReverseBinaryOpNode::emitCode): (KJS::ThrowableBinaryOpNode::emitCode):
kjs/nodes.h: (KJS::BinaryOpNode::BinaryOpNode): (KJS::ReverseBinaryOpNode::ReverseBinaryOpNode): (KJS::MultNode::): (KJS::DivNode::): (KJS::ModNode::): (KJS::AddNode::): (KJS::SubNode::): (KJS::LeftShiftNode::): (KJS::RightShiftNode::): (KJS::UnsignedRightShiftNode::): (KJS::LessNode::): (KJS::GreaterNode::): (KJS::LessEqNode::): (KJS::GreaterEqNode::): (KJS::ThrowableBinaryOpNode::): (KJS::InstanceOfNode::): (KJS::InNode::): (KJS::EqualNode::): (KJS::NotEqualNode::): (KJS::StrictEqualNode::): (KJS::NotStrictEqualNode::): (KJS::BitAndNode::): (KJS::BitOrNode::): (KJS::BitXOrNode::):
kjs/nodes2string.cpp: (KJS::MultNode::streamTo): (KJS::DivNode::streamTo): (KJS::ModNode::streamTo): (KJS::AddNode::streamTo): (KJS::SubNode::streamTo): (KJS::LeftShiftNode::streamTo): (KJS::RightShiftNode::streamTo): (KJS::UnsignedRightShiftNode::streamTo): (KJS::LessNode::streamTo): (KJS::GreaterNode::streamTo): (KJS::LessEqNode::streamTo): (KJS::GreaterEqNode::streamTo): (KJS::InstanceOfNode::streamTo): (KJS::InNode::streamTo): (KJS::EqualNode::streamTo): (KJS::NotEqualNode::streamTo): (KJS::StrictEqualNode::streamTo): (KJS::NotStrictEqualNode::streamTo): (KJS::BitAndNode::streamTo): (KJS::BitXOrNode::streamTo): (KJS::BitOrNode::streamTo):

10:09 PM Changeset in webkit [35985] by alp@webkit.org

6 edits in trunk

2008-08-28 Alp Toker <alp@nuanti.com>

GTK+ dist/build fix. List newly added header files.

6:13 PM Changeset in webkit [35984] by weinig@apple.com

7 edits in trunk

JavaScriptCore:

2008-08-28 Sam Weinig <sam@webkit.org>

Reviewed by Oliver Hunt.

Change to throw a ReferenceError at runtime instead of a ParseError
at parse time, when the left hand side expression of a for-in statement
is not an lvalue.

kjs/grammar.y:
kjs/nodes.cpp: (KJS::ForInNode::emitCode):

LayoutTests:

2008-08-28 Sam Weinig <sam@webkit.org>

Reviewed by Oliver Hunt.

Update test results now that test actually works.

fast/js/kde/exception_propagation-expected.txt:
fast/js/kde/resources/exception_propagation.js:

4:04 PM Changeset in webkit [35983] by Simon Fraser

7 edits
2 adds in trunk

2008-08-28 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

Various WebKitCSSTransformValue-related fixes
https://bugs.webkit.org/show_bug.cgi?id=20562

Test: css3/transform-value-types.html

bindings/js/JSCSSValueCustom.cpp: (WebCore::toJS):
css/CSSValue.h:
css/WebKitCSSTransformValue.cpp: (WebCore::WebKitCSSTransformValue::cssText):
css/WebKitCSSTransformValue.h: (WebCore::WebKitCSSTransformValue::):
css/WebKitCSSTransformValue.idl:

3:53 PM Changeset in webkit [35982] by mitz@apple.com

2 edits in trunk/WebCore

Reviewed by Steve Falkenburg.

do not let the "last chance" WM_TIMER trigger WebCore timers when they should be deferred

platform/win/SharedTimerWin.cpp: (WebCore::TimerWindowWndProc):

2:45 PM Changeset in webkit [35981] by hyatt@apple.com

1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Make sure new header files are put in private headers.

2:40 PM Changeset in webkit [35980] by Simon Fraser

2 edits in trunk/LayoutTests

2008-08-28 Simon Fraser <Simon Fraser>

Fix window properties now that CSSRule includes
keyframe-related constants.
Also add window.console.count [function]
https://bugs.webkit.org/show_bug.cgi?id=20552

fast/dom/Window/window-properties-expected.txt:

2:38 PM Changeset in webkit [35979] by hyatt@apple.com

12 edits
7 adds in trunk/WebCore

2008-08-28 David Hyatt <hyatt@apple.com>

RenderStyle cleanup.

Break out StyleImage, StyleGeneratedImage, StyleCachedImage and NinePieceImage into separate files.

Reviewed by Adam

css/CSSImageGeneratorValue.cpp:
css/CSSImageValue.cpp:
css/CSSStyleSelector.cpp:
rendering/RenderImageGeneratedContent.cpp:
rendering/style/NinePieceImage.cpp: Added.
rendering/style/NinePieceImage.h: Added.
rendering/style/RenderStyle.cpp: (WebCore::FillLayer::operator==): (WebCore::FillLayer::containsImage): (WebCore::StyleInheritedData::operator==): (WebCore::RenderStyle::contentDataEquivalent):
rendering/style/RenderStyle.h:
rendering/style/StyleCachedImage.cpp: Added.
rendering/style/StyleCachedImage.h: Added.
rendering/style/StyleGeneratedImage.cpp: Added.
rendering/style/StyleGeneratedImage.h: Added.
rendering/style/StyleImage.h: Added.

2:29 PM Changeset in webkit [35978] by Simon Fraser

5 edits in trunk/WebCore

2008-08-28 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

Make all the 'isFoo()' methods on CSSValue const,
and fix the subclasses.

https://bugs.webkit.org/show_bug.cgi?id=20561

css/CSSTimingFunctionValue.h:
css/CSSValue.h: (WebCore::CSSValue::isFontValue): (WebCore::CSSValue::isImageGeneratorValue): (WebCore::CSSValue::isImageValue): (WebCore::CSSValue::isImplicitInitialValue):
css/CSSValueList.h:
css/FontValue.h:

1:48 PM Changeset in webkit [35977] by kmccullough@apple.com

2 edits in trunk/WebKit/mac

2008-08-28 Kevin McCullough <kmccullough@apple.com>

Reviewed by Geoff.

<rdar://problem/6095949> REGRESSION (5525.8-6527.1?): "this" is null
when you first hit a breakpoint in Dashcode

We wanted to reset the callframe whenever eval() was called but dashcode uses eval() when broken to evaluate the state of the current call frame.

WebView/WebScriptDebugger.mm: (WebScriptDebugger::willExecuteProgram): (WebScriptDebugger::didExecuteProgram):

1:08 PM Changeset in webkit [35976] by hyatt@apple.com

3 edits in trunk/WebCore

2008-08-28 David Hyatt <hyatt@apple.com>

The great RenderStyle cleanup begins!

Move LengthBox and LengthSize out of RenderStyle and into Length.

Reviewed by Adam

rendering/Length.h: (WebCore::): (WebCore::Length::Length): (WebCore::Length::operator==): (WebCore::Length::operator!=): (WebCore::Length::value): (WebCore::Length::rawValue): (WebCore::Length::percent): (WebCore::Length::type): (WebCore::Length::quirk): (WebCore::Length::setValue): (WebCore::Length::setRawValue): (WebCore::Length::calcValue): (WebCore::Length::calcMinValue): (WebCore::Length::calcFloatValue): (WebCore::Length::isUndefined): (WebCore::Length::isZero): (WebCore::Length::isPositive): (WebCore::Length::isNegative): (WebCore::Length::isAuto): (WebCore::Length::isRelative): (WebCore::Length::isPercent): (WebCore::Length::isFixed): (WebCore::Length::isStatic): (WebCore::Length::isIntrinsicOrAuto): (WebCore::Length::blend): (WebCore::LengthBox::LengthBox): (WebCore::LengthBox::operator=): (WebCore::LengthBox::operator==): (WebCore::LengthBox::operator!=): (WebCore::LengthBox::nonZero): (WebCore::LengthSize::LengthSize):
rendering/style/RenderStyle.h:

12:53 PM Changeset in webkit [35975] by hyatt@apple.com

4 edits in trunk/WebCore

2008-08-28 David Hyatt <hyatt@apple.com>

Reviewed by Darin

https://bugs.webkit.org/show_bug.cgi?id=18091

font-size should be animatable using -webkit-transition.

page/AnimationController.cpp: (WebCore::AnimationControllerPrivate::ensurePropertyMap):
rendering/style/RenderStyle.h: (WebCore::RenderStyle::setFontSize):

11:08 AM Changeset in webkit [35974] by adele@apple.com

2 edits in trunk/WebKit/win

2008-08-28 Adele Peterson <adele@apple.com>

Build fix.

WebIconDatabase.cpp: (WebIconDatabase::getOrCreateDefaultIconBitmap):

10:45 AM Changeset in webkit [35973] by mitz@apple.com

2 edits in trunk/WebCore

2008-08-28 Brad Garcia <bgarcia@google.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=20549
Correctly determine when cursor is over a resizable border within
a nested frameset.

rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::canResizeRow): (WebCore::RenderFrameSet::canResizeColumn):

10:30 AM Changeset in webkit [35972] by Simon Fraser

3 edits
6 adds in trunk

2008-08-28 Simon Fraser <Simon Fraser>

Reviewed by Eric Seidel

Add RuleTypes to CSSRule.idl for keyframes and keyframe rules.
https://bugs.webkit.org/show_bug.cgi?id=20552

Test: animations/animation-css-rule-types.html

css/CSSRule.idl:

10:26 AM Changeset in webkit [35971] by andersca@apple.com

2 edits in trunk/WebCore

2008-08-28 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin and Darin.

<rdar://problem/6182541>
https://bugs.webkit.org/show_bug.cgi?id=20202
Missing http status line from the http headers.

Add a status line to the header string.

plugins/PluginStream.cpp: (WebCore::PluginStream::startStream):

8:56 AM Changeset in webkit [35970] by zecke@webkit.org

6 edits
1 delete in trunk

WebCore:
2008-08-28 Holger Hans Peter Freyther <zecke@selfish.org>

Rubber-stamped by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=17261

Make it possible to theme the default Url icon and enable this for
the Qt port. To have a minimal usage of #ifdef in the code the setting
of the icon was moved to a new method which comes in two flavors.

loader/icon/IconDatabase.cpp: (WebCore::loadDefaultIconRecord): Load or set the default icon (WebCore::IconDatabase::defaultIcon):

WebKit/win:
2008-08-28 Holger Hans Peter Freyther <zecke@selfish.org>

Rubber-stamped by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=17261

Remove the urlIcon.png from the project and the resource file. Remove
the usage of this icon from WebKitDLL.cpp and change WebIconDatabase
to get the icon from the IconDatabase code which is using a version of
the icon that is compiled into the code.

WebIconDatabase.cpp: (WebIconDatabase::getOrCreateDefaultIconBitmap): Use the icon from the IconDatabase.cpp
WebKit.vcproj/WebKit.rc: Remove urlIcon.cpp
WebKit.vcproj/urlIcon.png: Removed.
WebKitDLL.cpp: (loadResourceIntoBuffer): Remove "urlIcon"

8:03 AM Changeset in webkit [35969] by zecke@webkit.org

2 edits in trunk/WebCore

2008-08-28 Holger Hans Peter Freyther <zecke@selfish.org>

Unreviewed compile fix

platform/graphics/qt/GraphicsContextQt.cpp: Remove redefinitions

6:34 AM Changeset in webkit [35968] by Adam Roben

2 edits in trunk/WebCore

Windows (and others?) build fix

page/Chrome.cpp: Added a missing #include. (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): Fixed typo.

5:04 AM Changeset in webkit [35967] by eric@webkit.org

4 edits in trunk/WebCore

Reviewed by Oliver Hunt.

Qt and Cairo support from krit (and blind stab @ wx compile support)
https://bugs.webkit.org/show_bug.cgi?id=20373

platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::drawPath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::setPlatformFillColor): (WebCore::GraphicsContext::setPlatformStrokeColor): (WebCore::GraphicsContext::setPlatformStrokeStyle): (WebCore::GraphicsContext::strokeRect): (WebCore::GraphicsContext::setImageInterpolationQuality): (WebCore::GraphicsContext::imageInterpolationQuality): (WebCore::GraphicsContext::setPlatformFillPattern): (WebCore::GraphicsContext::setPlatformStrokePattern): (WebCore::GraphicsContext::setPlatformFillGradient): (WebCore::GraphicsContext::setPlatformStrokeGradient):
platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::strokeRect): (WebCore::GraphicsContext::clipToImageBuffer): (WebCore::GraphicsContext::setPlatformFillPattern): (WebCore::GraphicsContext::setPlatformStrokePattern): (WebCore::GraphicsContext::setPlatformFillGradient): (WebCore::GraphicsContext::setPlatformStrokeGradient): (WebCore::GraphicsContext::setImageInterpolationQuality): (WebCore::GraphicsContext::imageInterpolationQuality):
platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::clipToImageBuffer): (WebCore::GraphicsContext::setImageInterpolationQuality): (WebCore::GraphicsContext::imageInterpolationQuality): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::drawPath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::setPlatformFillPattern): (WebCore::GraphicsContext::setPlatformStrokePattern): (WebCore::GraphicsContext::setPlatformFillGradient):

5:04 AM Changeset in webkit [35966] by eric@webkit.org

23 edits in trunk/WebCore

Reviewed by Oliver Hunt.

Add stroke/fill Gradient and Pattern support to GraphicsContext and update <canvas> to use it.
https://bugs.webkit.org/show_bug.cgi?id=20373

Changed pattern() to canvasPattern() on CanvasStyle to match canvasGradient()

Made Generator (aka Gradient) RefCounted so that GraphicsContext didn't
have to store large Gradient objects in the GraphicsContextState

Made Pattern RefCounted for the same reason.

Many updates to GraphicsContext to support easier drawing with
Patterns and Gradients.

WebCore.xcodeproj/project.pbxproj: Add pre-existing GraphicsContextPrivate.h
bindings/js/JSCanvasRenderingContext2DCustom.cpp: (WebCore::toJS):
css/CSSGradientValue.cpp: (WebCore::CSSGradientValue::createGradient):
css/CSSGradientValue.h:
html/CanvasGradient.cpp: (WebCore::CanvasGradient::CanvasGradient):
html/CanvasGradient.h: (WebCore::CanvasGradient::gradient): (WebCore::CanvasGradient::addColorStop): (WebCore::CanvasGradient::getColor):
html/CanvasPattern.cpp:
html/CanvasPattern.h: (WebCore::CanvasPattern::pattern): (WebCore::CanvasPattern::originClean):
html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::State::State): (WebCore::CanvasRenderingContext2D::setStrokeStyle): (WebCore::CanvasRenderingContext2D::setFillStyle): (WebCore::CanvasRenderingContext2D::fill): (WebCore::CanvasRenderingContext2D::stroke): (WebCore::CanvasRenderingContext2D::fillRect): (WebCore::CanvasRenderingContext2D::strokeRect):
html/CanvasRenderingContext2D.h:
html/CanvasStyle.cpp: (WebCore::CanvasStyle::applyStrokeColor): (WebCore::CanvasStyle::applyFillColor):
html/CanvasStyle.h:
platform/graphics/GeneratedImage.h: (WebCore::GeneratedImage::GeneratedImage):
platform/graphics/Generator.h:
platform/graphics/Gradient.h: (WebCore::Gradient::create):
platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::fillRule): (WebCore::GraphicsContext::setFillRule): (WebCore::GraphicsContext::setStrokePattern): (WebCore::GraphicsContext::setFillPattern): (WebCore::GraphicsContext::setStrokeGradient): (WebCore::GraphicsContext::setFillGradient):
platform/graphics/GraphicsContext.h:
platform/graphics/GraphicsContextPrivate.h: (WebCore::): (WebCore::GraphicsContextState::GraphicsContextState):
platform/graphics/GraphicsTypes.h:
platform/graphics/Path.h:
platform/graphics/Pattern.h: (WebCore::Pattern::create): (WebCore::Pattern::tileImage):
platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::calculateDrawingMode): (WebCore::GraphicsContext::drawPath): (WebCore::fillPathWithFillRule): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::setPlatformStrokePattern): (WebCore::GraphicsContext::setPlatformFillPattern): (WebCore::GraphicsContext::setPlatformStrokeGradient): (WebCore::GraphicsContext::setPlatformFillGradient):

4:44 AM Changeset in webkit [35965] by ap@webkit.org

2 edits in trunk/JavaScriptCore

Not reviewed, build fix (at least for OpenBSD, posssibly more).

https://bugs.webkit.org/show_bug.cgi?id=20545
missing #include <unistd.h> in JavaScriptCore/VM/SamplingTool.cpp

VM/SamplingTool.cpp: add the missing include.

4:42 AM Changeset in webkit [35964] by eric@webkit.org

8 edits in trunk/WebCore

Reviewed by Darin and Alexey.

Close a leak of PausedTimeouts if the JavaScriptDebugServer was destroyed
with timeouts paused.
https://bugs.webkit.org/show_bug.cgi?id=20469

I attempted to clean up the memory management of PausedTimeouts, I'm not
sure the solution I came up with is "cleaner", but it's in some ways
"safer", since it no longer uses raw pointers and manual new/delete.

This also now prevents CachedPage from needlessly creating Window
objects when caching pages which didn't already have one. :)

I also made Chrome.cpp no longer depend on the JavaScript bindings
(aka JSDOMWindowBase.h), since there was no real reason for it to.

bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::pauseTimeouts): (WebCore::JSDOMWindowBase::resumeTimeouts):
bindings/js/JSDOMWindowBase.h:
bindings/js/ScriptController.cpp: (WebCore::ScriptController::pauseTimeouts): (WebCore::ScriptController::resumeTimeouts):
bindings/js/ScriptController.h:
history/CachedPage.cpp: (WebCore::CachedPage::CachedPage): (WebCore::CachedPage::restore):
page/Chrome.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
page/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::~JavaScriptDebugServer): (WebCore::JavaScriptDebugServer::setJavaScriptPaused):

Aug 27, 2008:

8:36 PM Changeset in webkit [35963] by zecke@webkit.org

2 edits
1 add in trunk/WebCore

2008-08-27 Holger Hans Peter Freyther <zecke@selfish.org>

Unreviewed compile fix

Add the stub for the Qt port.

WebCore.pro:
page/qt/AccessibilityObjectQt.cpp: Added. (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):

8:25 PM Changeset in webkit [35962] by zecke@webkit.org

4 edits in trunk/WebKit/qt

2008-08-27 Erik Bunce <elbunce@thehive.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=20223

Add QWebPage::contentsChanged() signal to notify of content changes.

Api/qwebpage.cpp:
Api/qwebpage.h:
WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::respondToChangedContents):

7:18 PM Changeset in webkit [35961] by zecke@webkit.org

2 edits in trunk/WebCore

2008-08-27 Alp Toker <alp@nuanti.com>

Reviewed by Eric.

https://bugs.webkit.org/show_bug.cgi?id=20551
[GTK] search popup crash

platform/gtk/SearchPopupMenuGtk.cpp: (WebCore::SearchPopupMenu::enabled): Fix a search popup crasher by disabling the history popup since we don't support this feature yet in the GTK+ port.

7:15 PM Changeset in webkit [35960] by zecke@webkit.org

2 edits in trunk/WebCore

2008-08-27 Alp Toker <alp@nuanti.com>

Reviewed by Eric.

https://bugs.webkit.org/show_bug.cgi?id=20551
[GTK] curl crashers

platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::startScheduledJobs): Remove the resource handle from the pending list before starting the job, not afterwards. Fixes crashers in the test suite.

Test: fast/dom/clientWidthAfterDocumentIsRemoved.html
Test: fast/encoding/char-encoding.html

7:11 PM Changeset in webkit [35959] by alice.liu@apple.com

4 edits in trunk/WebKit/win

2008-08-27 Alice Liu <alice.liu@apple.com>

Add interface for obtaining JS object counts broken down by type

Reviewed by Steve Falkenburg.

Interfaces/IWebCoreStatistics.idl:
WebCoreStatistics.cpp: (WebCoreStatistics::javaScriptProtectedObjectTypeCounts):
WebCoreStatistics.h:

6:42 PM Changeset in webkit [35958] by zecke@webkit.org

2 edits in trunk/WebKit/gtk

2008-08-27 Adrien Nader <camaradetux@gmail.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=20099
[GTK] SHIFT+PAGE_UP/DOWN doesn't extend selection

WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::handleKeyboardEvent):

6:20 PM Changeset in webkit [35957] by zecke@webkit.org

2 edits
1 add in trunk

2008-08-27 Mike Hommey <glandium@debian.org>

Reviewed by Holger.

GNUmakefile.am:
symbols.filter: Added.

5:50 PM Changeset in webkit [35956] by weinig@apple.com

3 edits
2 adds in trunk

WebKit/mac:

2008-08-27 Robert Kroeger <rjkroege@liqui.org>

Tweaked by Sam Weinig.

Reviewed by Eric Seidel.

Fix https://bugs.webkit.org/show_bug.cgi?id=6595
<rdar://problem/4432150>
Right-click does not fire mouseup event

Adds a rightMouseUp handler to the WebHTMLView.

The added method generates mouseup events for button 2. The result
is that webkit will deliver mousedown and mouseup events for button
2 in a fashion identical to FireFox and will retain event ordering
identical to Internet Explorer.

Test: fast/events/mouseup-from-button2.html

WebView/WebHTMLView.mm: (-[WebHTMLView rightMouseUp:]):

LayoutTests:

2008-08-27 Robert Kroeger <rjkroege@liqui.org>

Reviewed by Eric Seidel.

Test for https://bugs.webkit.org/show_bug.cgi?id=6595

fast/events/mouseup-from-button2-expected.txt: Added.
fast/events/mouseup-from-button2.html: Added.

5:26 PM Changeset in webkit [35955] by eric@webkit.org

2 edits in trunk/WebCore

Reviewed by eseidel.

Fix canvas drawImage to support composite operations.
Composite had no effect on canvas elements like these:
http://philip.html5.org/tests/canvas/suite/tests/index.2d.composite.canvas.html

[CAIRO] Canvas composite don't work on canvas-elements.
https://bugs.webkit.org/show_bug.cgi?id=20548

html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage): pass the current composite operator to the drawImage call

5:04 PM Changeset in webkit [35954] by eric@webkit.org

2 edits in trunk/WebCore

Reviewed by Eric Seidel.

Fix the data content of an image with a base64.

platform/network/curl/ResourceHandleManager.cpp: (WebCore::parseDataUrl): Remove the String and use only the data Vector because the data.latin1().data() convert the data content and the image test ( https://bugs.webkit.org/attachment.cgi?id=21726 ) is not drawn correctly.

4:59 PM Changeset in webkit [35953] by Antti Koivisto

2 edits in trunk/WebCore

2008-08-27 Antti Koivisto <Antti Koivisto>

Reviewed by Eric Seidel.

Crash after OK in dialog box and reloading page in secure mode
https://bugs.webkit.org/show_bug.cgi?id=20493

The new run loop spawned by a modal dialog causes a timer in the loader to run
synchronously inside didFinishLoading() deleting "this" object.

Defer all WebCore timers when a modal dialog is up. They are not
safe to execute.

page/Chrome.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):

4:16 PM Changeset in webkit [35952] by Simon Fraser

3 edits in trunk/WebCore

2008-08-27 Chris Marrin <cmarrin@apple.com>

Reviewed by Dave Hyatt

Memory leaks when animating transforms
https://bugs.webkit.org/show_bug.cgi?id=20532

rendering/style/RenderStyle.cpp: (WebCore::ScaleTransformOperation::blend): (WebCore::RotateTransformOperation::blend): (WebCore::SkewTransformOperation::blend): (WebCore::TranslateTransformOperation::blend): (WebCore::MatrixTransformOperation::blend):
rendering/style/RenderStyle.h:

3:54 PM Changeset in webkit [35951] by adachan@apple.com

2 edits in trunk/WebKit/win

Fixed build.

WebFrame.cpp: (WebFrame::pluginWillHandleLoadError):

3:03 PM Changeset in webkit [35950] by timothy@apple.com

13 edits in trunk

Add support for support for -webkit-appearance: default-button on the Mac platform.

WebCore:

2008-08-27 Timothy Hatcher <timothy@apple.com>

Add support for support for -webkit-appearance: default-button on the Mac platform.

<rdar://problem/6173530>

Reviewed by Dave Hyatt.

WebCore.base.exp: Export new symbols.
platform/mac/WebCoreSystemInterface.h: Add wkAdvanceDefaultButtonPulseAnimation.
platform/mac/WebCoreSystemInterface.mm: Ditto.
rendering/RenderButton.cpp: (WebCore::RenderButton::RenderButton): Remove #if PLATFORM(WIN). (WebCore::RenderButton::setStyle): Ditto.
rendering/RenderButton.h: Ditto.
rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustRepaintRect): Add a case for DefaultButtonAppearance. (WebCore::RenderThemeMac::setButtonCellState): Set the key equivalent to the return key if the button is default, otherwise reset the key equivalent. (WebCore::RenderThemeMac::paintButton): If the button is default call setDefaultButtonCell: on the window, then wkAdvanceDefaultButtonPulseAnimation before painting. Restore the window's previous default button cell when finished.

WebKit/mac:

2008-08-27 Timothy Hatcher <timothy@apple.com>

Add support for support for -webkit-appearance: default-button on the Mac platform.

<rdar://problem/6173530>

Reviewed by Dave Hyatt.

WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Init AdvanceDefaultButtonPulseAnimation.
WebView/WebPreferenceKeysPrivate.h: Added WebKitApplicationChromeModeEnabledPreferenceKey.
WebView/WebPreferences.mm: (+[WebPreferences initialize]): Set WebKitApplicationChromeModeEnabledPreferenceKey to NO. (-[WebPreferences applicationChromeModeEnabled]): Added. (-[WebPreferences setApplicationChromeModeEnabledEnabled:]): Added.
WebView/WebPreferencesPrivate.h:
WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): Call Settings::setApplicationChromeMode with the value of -[WebPreferences applicationChromeModeEnabled].

2:18 PM Changeset in webkit [35949] by hyatt@apple.com

5 edits in trunk/WebCore

2008-08-26 David Hyatt <hyatt@apple.com>

First cut at making form controls on OS X respect full page zoom. There are lots of bugs.

Reviewed by weinig

Added fast/forms/zoomed-controls.html

css/CSSStyleSelector.cpp: (WebCore::addIntrinsicMargins):
rendering/RenderSlider.cpp: (WebCore::RenderSlider::calcPrefWidths):
rendering/RenderThemeMac.h:
rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustRepaintRect): (WebCore::RenderThemeMac::inflateRect): (WebCore::RenderThemeMac::baselinePosition): (WebCore::RenderThemeMac::setControlSize): (WebCore::RenderThemeMac::sizeForFont): (WebCore::RenderThemeMac::sizeForSystemFont): (WebCore::RenderThemeMac::setFontFromControlSize): (WebCore::RenderThemeMac::paintCheckbox): (WebCore::RenderThemeMac::setCheckboxCellState): (WebCore::RenderThemeMac::paintRadio): (WebCore::RenderThemeMac::setRadioCellState): (WebCore::RenderThemeMac::setButtonPaddingFromControlSize): (WebCore::RenderThemeMac::adjustButtonStyle): (WebCore::RenderThemeMac::setButtonCellState): (WebCore::RenderThemeMac::paintButton): (WebCore::RenderThemeMac::paintMenuList): (WebCore::RenderThemeMac::paintMenuListButton): (WebCore::RenderThemeMac::popupInternalPaddingLeft): (WebCore::RenderThemeMac::popupInternalPaddingRight): (WebCore::RenderThemeMac::popupInternalPaddingTop): (WebCore::RenderThemeMac::popupInternalPaddingBottom): (WebCore::RenderThemeMac::setPopupButtonCellState): (WebCore::RenderThemeMac::paintSliderTrack): (WebCore::RenderThemeMac::paintSliderThumb): (WebCore::RenderThemeMac::adjustSliderThumbSize): (WebCore::RenderThemeMac::paintSearchField): (WebCore::RenderThemeMac::adjustSearchFieldStyle): (WebCore::RenderThemeMac::paintSearchFieldCancelButton): (WebCore::RenderThemeMac::paintSearchFieldResultsButton):

1:29 PM Changeset in webkit [35948] by timothy@apple.com

4 edits in trunk/WebKitLibraries

Adds the WKAdvanceDefaultButtonPulseAnimation function.

<rdar://problem/6173530> Add Mac support for -webkit-appearance: default-button

Reviewed by Adele Peterson.

WebKitSystemInterface.h: Added WKAdvanceDefaultButtonPulseAnimation.
libWebKitSystemInterfaceLeopard.a: Updated.
libWebKitSystemInterfaceTiger.a: Updated.

1:12 PM Changeset in webkit [35947] by mrowe@apple.com

68 moves in tags/old

Move aside more old tags.

12:59 PM Changeset in webkit [35946] by beidson@apple.com

16 edits in trunk

WebCore:

2008-08-27 Brady Eidson <beidson@apple.com>

Reviewed by Anders

<rdar://problem/6134133> - Crash when loading large movie as a standalone document

We hand off these loads to Quicktime which manages and spools the data itself, but we also continued
to load and buffer the data for the movie in WebCore. With large media files, this results in blowing
away the virtual address space and a crash.

loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::pluginWillHandleLoadError):
loader/FrameLoaderClient.h: Added client method to get platform specific error for "plugin will handle load"

loader/MediaDocument.cpp: (WebCore::MediaTokenizer::createDocumentStructure): Tell the MainResourceLoader to not buffer data, and cancel the WebCore-managed load (WebCore::MediaTokenizer::writeRawData): (WebCore::MediaTokenizer::finish):

WebKit/gtk:

2008-08-27 Brady Eidson <beidson@apple.com>

Reviewed by Anders

<rdar://problem/6134133> - Crash when loading large movie as a standalone document

WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::pluginWillHandleLoadError): Stubbed for now
WebCoreSupport/FrameLoaderClientGtk.h:

WebKit/mac:

2008-08-27 Brady Eidson <beidson@apple.com>

Reviewed by Anders

<rdar://problem/6134133> - Crash when loading large movie as a standalone document

WebCoreSupport/WebFrameLoaderClient.h:
WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::pluginWillHandleLoadError):

WebKit/qt:

2008-08-27 Brady Eidson <beidson@apple.com>

Reviewed by Anders

<rdar://problem/6134133> - Crash when loading large movie as a standalone document

WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::pluginWillHandleLoadError): Stubbed for now
WebCoreSupport/FrameLoaderClientQt.h:

WebKit/win:

2008-08-27 Brady Eidson <beidson@apple.com>