Context Navigation

← Previous Period
Next Period →

Timeline

Sep 1, 2008:

10:08 PM Changeset in webkit [36023] by mrowe@apple.com

1 copy in tags/Safari-6528.3

New tag.

9:26 PM Changeset in webkit [36022] by abarth@webkit.org

10 edits in trunk

WebCore:

2008-09-01 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=19760

Make granting LoadLocalResources conditional on a policy.

WebCore.base.exp:
dom/Document.cpp: (WebCore::Document::initSecurityContext):
loader/FrameLoader.cpp: (WebCore::FrameLoader::setLocalLoadPolicy): (WebCore::FrameLoader::restrictAccessToLocal):
loader/FrameLoader.h: (WebCore::FrameLoader::):
platform/SecurityOrigin.cpp: (WebCore::SecurityOrigin::grantLoadLocalResources):
platform/SecurityOrigin.h:

WebKit/mac:

2008-09-01 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=19760

Add a linked-on-or-after check to prevent substitute data from loading
local resources on newer users of WebKit.

Misc/WebKitVersionChecks.h:
WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]):

4:34 PM Changeset in webkit [36021] by dino@apple.com

3 edits
23 adds in trunk

2008-09-01 Dean Jackson <dino@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=20571
Make sure Window object can assign Animation/Transition event
listeners via attributes.

Also added a bunch of transition event tests, although
only transition-end-event-window is directly relevant to this patch.

(WebCore::JSDOMWindowBase::put):

Tests: transitions/transition-end-event-all-properties.html

transitions/transition-end-event-attributes.html
transitions/transition-end-event-container.html
transitions/transition-end-event-left.html
transitions/transition-end-event-multiple-01.html
transitions/transition-end-event-multiple-02.html
transitions/transition-end-event-multiple-03.html
transitions/transition-end-event-multiple-04.html
transitions/transition-end-event-nested.html
transitions/transition-end-event-transform.html
transitions/transition-end-event-window.html

4:05 PM Changeset in webkit [36020] by dino@apple.com

2 edits in trunk/WebCore

2008-09-01 Dean Jackson <dino@apple.com>

Reviewed by Sam Weinig

Code styling cleanup.

bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::getValueProperty): (WebCore::JSDOMWindowBase::put):

3:55 PM Changeset in webkit [36019] by weinig@apple.com

2 edits in trunk/JavaScriptCore

2008-09-01 Sam Weinig <sam@webkit.org>

Fix release build.

JavaScriptCore.exp:

3:49 PM Changeset in webkit [36018] by jmalonzo@webkit.org

4 edits in trunk/JavaScriptCore

2008-09-01 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Oliver Hunt.

Gtk buildfix

GNUmakefile.am:
kjs/PropertyMap.cpp: rename Identifier.h to identifier.h
kjs/StructureID.cpp: include JSObject.h

3:40 PM Changeset in webkit [36017] by weinig@apple.com

7 edits in trunk/JavaScriptGlue

2008-09-01 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.

First cut at inline caching for access to vanilla JavaScript properties.

Updated for JavaScriptCore changes. Mostly mechanical addition of StructureIDs
to JavaScriptGlue classes, and PutPropertySlot& arguments to put functions.

2:22 PM Changeset in webkit [36016] by weinig@apple.com

100 edits
20 adds in trunk

JavaScriptCore:

2008-09-01 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.

First cut at inline caching for access to vanilla JavaScript properties.

SunSpider says 4% faster. Tests heavy on dictionary-like access have
regressed a bit -- we have a lot of room to improve in this area,
but this patch is over-ripe as-is.

JSCells now have a StructureID that uniquely identifies their layout,
and holds their prototype.

JSValue::put takes a PropertySlot& argument, so it can fill in details
about where it put a value, for the sake of caching.

VM/CodeGenerator.cpp: (KJS::CodeGenerator::CodeGenerator): Avoid calling removeDirect if we can, since it disables inline caching in the global object. This can probably improve in the future.

kjs/JSGlobalObject.cpp: Nixed reset(), since it complicates caching, and wasn't really necessary.

kjs/JSObject.cpp: Tweaked getter / setter behavior not to rely on the IsGetterSetter flag, since the flag was buggy. This is necessary in order to avoid accidentally accessing a getter / setter as a normal property.

Also changed getter / setter creation to honor ReadOnly, matching Mozilla.

kjs/PropertyMap.cpp: Nixed clear(), since it complicates caching and isn't necessary.

kjs/Shell.cpp: Moved SamplingTool dumping outside the loop. This allows you to aggregate sampling of multiple files (or the same file repeatedly), which helped me track down regressions.

kjs/ustring.h: Moved IdentifierRepHash here to share it.

WebCore:

2008-09-01 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.

First cut at inline caching for access to vanilla JavaScript properties.

Updated for JavaScriptCore changes. Mostly mechanical addition of StructureIDs
to WebCore classes, and PutPropertySlot& arguments to put functions.

(WebCore::JSCSSStyleDeclaration::customPut): Be sure to play nice with
inline caching for global properties, so global assignment can be optimized.

ForwardingHeaders/kjs/StructureID.h: Added.
bindings/js/JSDOMBinding.h: (WebCore::DOMObject::DOMObject):
bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::put):
bindings/js/JSDOMWindowBase.h:
bindings/js/JSDOMWindowCustom.h: (WebCore::JSDOMWindow::customPut):
bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::JSDOMWindowShell): (WebCore::JSDOMWindowShell::put):
bindings/js/JSDOMWindowShell.h:
bindings/js/JSEventTargetBase.h: (WebCore::JSEventTargetBase::put):
bindings/js/JSEventTargetNode.h: (WebCore::JSEventTargetNode::put):
bindings/js/JSHTMLAppletElementCustom.cpp: (WebCore::JSHTMLAppletElement::customPut):
bindings/js/JSHTMLEmbedElementCustom.cpp: (WebCore::JSHTMLEmbedElement::customPut):
bindings/js/JSHTMLInputElementBase.cpp: (WebCore::JSHTMLInputElementBase::put):
bindings/js/JSHTMLInputElementBase.h:
bindings/js/JSHTMLObjectElementCustom.cpp: (WebCore::JSHTMLObjectElement::customPut):
bindings/js/JSHistoryCustom.cpp: (WebCore::JSHistory::customPut):
bindings/js/JSInspectedObjectWrapper.cpp: (WebCore::JSInspectedObjectWrapper::wrap): (WebCore::JSInspectedObjectWrapper::JSInspectedObjectWrapper):
bindings/js/JSInspectedObjectWrapper.h:
bindings/js/JSInspectorCallbackWrapper.cpp: (WebCore::JSInspectorCallbackWrapper::wrap): (WebCore::JSInspectorCallbackWrapper::JSInspectorCallbackWrapper):
bindings/js/JSInspectorCallbackWrapper.h:
bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::customPut):
bindings/js/JSPluginElementFunctions.cpp: (WebCore::runtimeObjectCustomPut):
bindings/js/JSPluginElementFunctions.h:
bindings/js/JSQuarantinedObjectWrapper.cpp: (WebCore::JSQuarantinedObjectWrapper::JSQuarantinedObjectWrapper): (WebCore::JSQuarantinedObjectWrapper::put):
bindings/js/JSQuarantinedObjectWrapper.h:
bindings/js/JSStorageCustom.cpp: (WebCore::JSStorage::customPut):
bindings/objc/WebScriptObject.mm: (-[WebScriptObject setValue:forKey:]):
bindings/scripts/CodeGeneratorJS.pm:
bridge/NP_jsobject.cpp: (_NPN_SetProperty):
bridge/jni/jni_jsobject.mm: (JavaJSObject::setMember):
bridge/objc/objc_class.mm: (KJS::Bindings::ObjcClass::fallbackObject):
bridge/objc/objc_runtime.h:
bridge/objc/objc_runtime.mm: (ObjcFallbackObjectImp::ObjcFallbackObjectImp): (ObjcFallbackObjectImp::put):
bridge/runtime.cpp: (KJS::Bindings::Instance::createRuntimeObject):
bridge/runtime_array.cpp: (RuntimeArray::put):
bridge/runtime_array.h:
bridge/runtime_object.cpp: (RuntimeObjectImp::RuntimeObjectImp): (RuntimeObjectImp::put):
bridge/runtime_object.h:

LayoutTests:

2008-09-01 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.

First cut at inline caching for access to vanilla JavaScript properties.

Tests for things I broke along the way.

fast/dom/getter-on-window-object2-expected.txt:
fast/js/pic: Added.
fast/js/pic/cached-deleted-properties-expected.txt: Added.
fast/js/pic/cached-deleted-properties.html: Added.
fast/js/pic/cached-getter-dictionary-and-proto-expected.txt: Added.
fast/js/pic/cached-getter-dictionary-and-proto.html: Added.
fast/js/pic/cached-getter-setter-expected.txt: Added.
fast/js/pic/cached-getter-setter.html: Added.
fast/js/pic/cached-prototype-setter-expected.txt: Added.
fast/js/pic/cached-prototype-setter.html: Added.
fast/js/pic/cached-single-entry-transition-expected.txt: Added.
fast/js/pic/cached-single-entry-transition.html: Added.
fast/js/pic/get-empty-string-expected.txt: Added.
fast/js/pic/get-empty-string.html: Added.
fast/js/pic/get-set-proxy-object-expected.txt: Added.
fast/js/pic/get-set-proxy-object.html: Added.
fast/js/pic/rehash-poisons-structure-expected.txt: Added.
fast/js/pic/rehash-poisons-structure.html: Added.

12:51 PM Changeset in webkit [36015] by weinig@apple.com

3 edits in trunk/JavaScriptCore

2008-09-01 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Eagerly allocate the Math object's numeric constants. This avoids
constantly reallocating them in loops, and also ensures that the Math
object will not use the single property optimization, which makes
properties ineligible for caching.

SunSpider reports a small speedup, in combination with inline caching.

kjs/MathObject.cpp: (KJS::MathObject::MathObject): (KJS::MathObject::getOwnPropertySlot):
kjs/MathObject.h:

12:46 PM Changeset in webkit [36014] by jmalonzo@webkit.org

2 edits in trunk/JavaScriptCore

2008-09-01 Jan Michael Alonzo <jmalonzo@webkit.org>

Gtk build fix, not reviewed.

GNUmakefile.am: Add SmallStrings.cpp in both release and debug builds

10:18 AM Changeset in webkit [36013] by cwzwarich@webkit.org

1 edit in trunk/JavaScriptCore/ChangeLog

2008-09-01 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Not reviewed.

Fix a typo in the ChangeLog for r36009.

5:44 AM Changeset in webkit [36012] by jmalonzo@webkit.org

3 edits in trunk/WebKit/gtk

2008-09-01 Alp Toker <alp@nuanti.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=19939
[GTK] webkit_web_history_item_get_title() fails with assertion

Make sure newly constructed WebHistoryItem objects wrap a WebCore
history item when necessary. Avoid G_PARAM_CONSTRUCT since it destroys
history data -- use WEBKIT_PARAM flags instead as they do the right
thing. This restores history functionality.

Also use CString to simplify UTF-8 string management.

webkit/webkitwebbackforwardlist.cpp: (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_forward_list_with_limit): (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_back_list_with_limit): No need to initialize the vector with a size since it's cleared by the callee.
webkit/webkitwebhistoryitem.cpp: (_WebKitWebHistoryItemPrivate::webkit_web_history_item_finalize): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_class_init): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_core_item): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_data): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_title): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_alternate_title): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_set_alternate_title): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_uri): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_original_uri):

5:43 AM Changeset in webkit [36011] by jmalonzo@webkit.org

2 edits in trunk/WebCore

2008-09-01 Dirk Schulze <vbs85@gmx.de>

Reviewed by Eric Seidel.

Fixed border-radius for Cairo.

platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::strokeArc):

5:43 AM Changeset in webkit [36010] by jmalonzo@webkit.org

5 edits in trunk/WebCore

2008-09-01 Dirk Schulze <vbs85@gmx.de>

Reviewed by Eric Seidel.

Added canvas's globalAlpha to cairo.

platform/graphics/GraphicsContext.h:
platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::setAlpha): (WebCore::GraphicsContext::getAlpha):
platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::draw):

Aug 31, 2008:

2:57 PM Changeset in webkit [36009] by cwzwarich@webkit.org

3 edits
3 adds in trunk

2008-08-31 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Maciej Stachowiak.

Bug 20577: REGRESSION (r35006): Gmail is broken
<https://bugs.webkit.org/show_bug.cgi?id=20577>

r35006 changed stringProtoFuncSubstr() so that it is uses the more
efficient jsSubstring(), rather than using UString::substr() and then
calling jsString(). However, the change did not account for the case
where the start and the length of the substring extend beyond the length
of the original string. This patch corrects that.