⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 3, 2008:

11:31 PM Changeset in webkit [36080] by eric@webkit.org
  • 2 edits in trunk/WebCore

No review, build fix only.

Attempt to fix the Qt build.

  • WebCore.pro: add page/animation to include path
11:11 PM Changeset in webkit [36079] by alp@webkit.org
  • 3 edits in trunk/WebKit/gtk

2008-09-03 Alp Toker <​alp@nuanti.com>

Build fix following r36073. Include config.h where necessary.

  • WebCoreSupport/PasteboardHelperGtk.cpp:
  • webkit/webkitversion.cpp:
8:46 PM Changeset in webkit [36078] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

More Mac build fixes.

Set ENABLE_DASHBOARD_SUPPORT when building for Mac via build-webkit.
Also set ENABLE_CROSS_DOCUMENT_MESSAGING in order to match the
default configuration specified in the .xcconfig files.

8:29 PM Changeset in webkit [36077] by mrowe@apple.com
  • 1 edit in trunk/WebCore/WebCore.base.exp

Touch an input file to force a derived file to be rebuilt.

8:20 PM Changeset in webkit [36076] by mrowe@apple.com
  • 4 edits in trunk

Fix the Mac build.

6:59 PM Changeset in webkit [36075] by mrowe@apple.com
  • 5 edits in trunk/LayoutTests

Update layout test results after recent canvas changes.

  • fast/canvas/canvas-invalid-fillstyle-expected.txt:
  • fast/canvas/canvas-invalid-strokestyle-expected.txt:
  • fast/canvas/drawImage-with-negative-source-destination-expected.txt:
  • fast/dom/Window/window-properties-expected.txt:
6:32 PM Changeset in webkit [36074] by eric@webkit.org
  • 9 edits in trunk

Reviewed by Sam.

Clean up Platform.h and add PLATFORM(CHROMIUM), PLATFORM(SKIA) and USE(V8_BINDINGS)

  • Configurations/WebCore.xcconfig: add missing ENABLE_*
  • config.h: add rules for V8_BINDINGS
6:32 PM Changeset in webkit [36073] by eric@webkit.org
  • 17 edits in trunk/WebCore

Reviewed by Sam.

​https://bugs.webkit.org/show_bug.cgi?id=20620

Add #if USE(JSC) around KJS dependencies
Remove !USE(JAVASCRIPTCORE_BINDINGS) support for 3 reasons:

  1. Most platforms have it on anyway
  2. V8 is going to want to share some of that code
  3. Those platforms which want it off, should have a separate file instead of an #ifdef in our .cpp
  • bindings/js/JSPluginElementFunctions.cpp: remove !USE(JAVASCRIPTCORE_BINDINGS) support
  • config.h: change JAVASCRIPTCORE_BINDINGS to JSC and add USE(V8)
  • html/HTMLAppletElement.cpp: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
  • html/HTMLAppletElement.h: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
  • html/HTMLEmbedElement.cpp: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
  • html/HTMLEmbedElement.h: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
  • html/HTMLObjectElement.cpp: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
  • html/HTMLObjectElement.h: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
  • html/HTMLPlugInElement.cpp: replace USE(JAVASCRIPTCORE_BINDINGS) with USE(JSC) where needed
  • html/HTMLPlugInElement.h: replace USE(JAVASCRIPTCORE_BINDINGS) with USE(JSC) where needed
  • platform/text/AtomicString.cpp: add USE(JSC)
  • platform/text/AtomicString.h: add USE(JSC)
  • platform/text/PlatformString.h: add USE(JSC)
  • platform/text/String.cpp: add USE(JSC)
  • platform/text/StringImpl.cpp: add USE(JSC)
  • platform/text/StringImpl.h: add USE(JSC)
5:10 PM Changeset in webkit [36072] by mrowe@apple.com
  • 4 edits in trunk

Tidy up some ChangeLog entries.

4:46 PM Changeset in webkit [36071] by mrowe@apple.com
  • 8 edits in trunk/WebCore

2008-09-03 Dean McNamee <​deanm@chromium.org>

Reviewed by Darin Adler.

Fix ​https://bugs.webkit.org/show_bug.cgi?id=20511
Bug 20511: Remove static initializers on Windows

Avoid static initializers on Windows by forcing Visual C++ to put
all static initializers in a code segment that is never executed.

  • config.h:
  • css/MediaFeatureNames.cpp:
  • dom/EventNames.cpp:
  • dom/QualifiedName.cpp:
  • dom/make_names.pl:
  • platform/StaticConstructors.h:
  • platform/text/AtomicString.cpp:
4:40 PM Changeset in webkit [36070] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2008-09-03 Dirk Schulze <​vbs85@gmx.de>

Reviewed by Dave Hyatt.

Make FontCairo draw TextStroke and TextFill separately.

[CAIRO] draw TextFill and TextStroke separately.
​https://bugs.webkit.org/show_bug.cgi?id=20631

  • platform/graphics/cairo/FontCairo.cpp: (WebCore::Font::drawGlyphs):
4:34 PM Changeset in webkit [36069] by mrowe@apple.com
  • 7 edits in trunk/WebCore

2008-09-03 Peter Kasting <​zerodpx@gmail.com>

Reviewed by Dave Hyatt.

​https://bugs.webkit.org/show_bug.cgi?id=19663
Account for paint and timer lag when animating images. Also pretend
that images whose animations were paused (by becoming invisible)
continued to animate, by "catching up" to the correct frame when they're
shown again.

  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::startAnimation): (WebCore::BitmapImage::advanceAnimation): (WebCore::BitmapImage::internalAdvanceAnimation): (WebCore::BitmapImage::notifyObserverAndTrimDecodedData):
  • platform/graphics/BitmapImage.h:
  • platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::draw):
  • platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::draw):
  • platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::draw):
  • platform/graphics/wx/ImageWx.cpp: (WebCore::BitmapImage::draw):
2:53 PM Changeset in webkit [36068] by kmccullough@apple.com
  • 14 edits in trunk

JavaScriptCore:

2008-09-03 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Tim.

Remove the rest of the "zombie" code from the profiler.

  • There is no longer a need for the ProfilerClient callback mechanism.
  • API/JSProfilerPrivate.cpp: (JSStartProfiling):
  • JavaScriptCore.exp:
  • profiler/HeavyProfile.h:
  • profiler/ProfileGenerator.cpp: (KJS::ProfileGenerator::create): (KJS::ProfileGenerator::ProfileGenerator):
  • profiler/ProfileGenerator.h: (KJS::ProfileGenerator::profileGroup):
  • profiler/Profiler.cpp: (KJS::Profiler::startProfiling): (KJS::Profiler::stopProfiling): Immediately return the profile when stopped instead of using a callback.
  • profiler/Profiler.h:
  • profiler/TreeProfile.h:

WebCore:

2008-09-03 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Tim.

Remove the rest of the "zombie" code from the profiler.

  • There is no longer a need for the ProfilerClient callback mechanism.
  • page/Console.cpp: (WebCore::Console::Console): (WebCore::Console::profile): (WebCore::Console::profileEnd): Move the variables from the header to here since we don't have to wait for a callback to use them.
  • page/Console.h:
  • page/InspectorController.cpp: (WebCore::InspectorController::startUserInitiatedProfiling): (WebCore::InspectorController::stopUserInitiatedProfiling):
  • page/InspectorController.h:
2:43 PM Changeset in webkit [36067] by adachan@apple.com
  • 2 edits in trunk/WebCore

Windows build fix.

  • WebCore.vcproj/WebCore.vcproj: Added JSWebKitCSSKeyframeRule.cpp and JSWebKitCSSKeyframesRule.cpp to the project.
2:15 PM Changeset in webkit [36066] by dino@apple.com
  • 10 edits
    4 adds in trunk

2008-09-01 Dean Jackson <​dino@apple.com>

Reviewed by Dave Hyatt.

​https://bugs.webkit.org/show_bug.cgi?id=20594
Add DOM interfaces for WebKitCSSKeyframeRule
and WebKitCSSKeyframesRule.

TEST: LayoutTests/css3/keyframes-rule.html

  • css/WebKitCSSKeyframeRule.idl: Added
  • css/WebKitCSSKeyframesRule.idl: Added
  • bindings/js/JSCSSRuleCustom.cpp: (WebCore::toJS):

Add return of new JS Keyframe rules

  • bindings/objc/DOMInternal.h:

Include new internal header

  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:

Build configs for new files

1:30 PM Changeset in webkit [36065] by Adam Roben
  • 3 edits in trunk/WebCore

Windows build fix

  • DerivedSources.cpp: Add JSTextMetrics.cpp to fix the build.
  • WebCore.vcproj/WebCore.vcproj: Add JSTextMetrics.h for convenience/consistency.
1:13 PM Changeset in webkit [36064] by adele@apple.com
  • 2 edits in trunk/WebCore

2008-09-03 Adele Peterson <​adele@apple.com>

Build fix.

  • WebCore.vcproj/WebCore.vcproj:
12:06 PM Changeset in webkit [36063] by hyatt@apple.com
  • 1 edit in trunk/WebCore/GNUmakefile.am
12:02 PM Changeset in webkit [36062] by adele@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-09-03 Adele Peterson <​adele@apple.com>

Build fix.

  • wtf/win/MainThreadWin.cpp:
11:32 AM Changeset in webkit [36061] by hyatt@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

2008-09-03 David Hyatt <​hyatt@apple.com>

Fix for bug 18203, right floats should be allowed to overflow past the left border edge.

Reviewed by Darin (ages ago)

Added fast/block/float/clamped-right-float.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionNewFloats):

LayoutTests:

2008-09-03 David Hyatt <​hyatt@apple.com>

Fix for bug 18203.

Reviewed by Darin (ages ago).

  • fast/block/float/clamped-right-float.html: Added.
  • platform/mac/fast/block/float/clamped-right-float-expected.checksum: Added.
  • platform/mac/fast/block/float/clamped-right-float-expected.png: Added.
  • platform/mac/fast/block/float/clamped-right-float-expected.txt: Added.
11:13 AM Changeset in webkit [36060] by hyatt@apple.com
  • 17 edits
    10 adds in trunk

WebCore:

2008-09-02 David Hyatt <​hyatt@apple.com>

Add support for canvas text drawing APIs.

Reviewed by olliej

Tests added as fast/canvas/canvas-text-*.html

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSCanvasRenderingContext2DCustom.cpp: (WebCore::JSCanvasRenderingContext2D::fillText): (WebCore::JSCanvasRenderingContext2D::strokeText):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::initForStyleResolve): (WebCore::CSSStyleSelector::applyPropertyToStyle):
  • css/CSSStyleSelector.h:
  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::State::State): (WebCore::CanvasRenderingContext2D::font): (WebCore::CanvasRenderingContext2D::setFont): (WebCore::CanvasRenderingContext2D::textAlign): (WebCore::CanvasRenderingContext2D::setTextAlign): (WebCore::CanvasRenderingContext2D::textBaseline): (WebCore::CanvasRenderingContext2D::setTextBaseline): (WebCore::CanvasRenderingContext2D::fillText): (WebCore::CanvasRenderingContext2D::strokeText): (WebCore::CanvasRenderingContext2D::measureText): (WebCore::CanvasRenderingContext2D::drawTextInternal): (WebCore::CanvasRenderingContext2D::accessFont):
  • html/CanvasRenderingContext2D.h:
  • html/CanvasRenderingContext2D.idl:
  • html/TextMetrics.h: Added. (WebCore::TextMetrics::create): (WebCore::TextMetrics::width): (WebCore::TextMetrics::setWidth): (WebCore::TextMetrics::TextMetrics):
  • html/TextMetrics.idl: Added.
  • platform/graphics/Font.cpp: (WebCore::Font::lineGap):
  • platform/graphics/Font.h:
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawBidiText):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/GraphicsTypes.cpp: (WebCore::textAlignName): (WebCore::parseTextAlign): (WebCore::textBaselineName): (WebCore::parseTextBaseline):
  • platform/graphics/GraphicsTypes.h: (WebCore::):

LayoutTests:

2008-09-02 David Hyatt <​hyatt@apple.com>

Add support for the canvas text APIs.

Reviewed by olliej

  • fast/canvas/canvas-text-alignment.html: Added.
  • fast/canvas/canvas-text-baseline.html: Added.
  • platform/mac/fast/canvas/canvas-text-alignment-expected.checksum: Added.
  • platform/mac/fast/canvas/canvas-text-alignment-expected.png: Added.
  • platform/mac/fast/canvas/canvas-text-alignment-expected.txt: Added.
  • platform/mac/fast/canvas/canvas-text-baseline-expected.checksum: Added.
  • platform/mac/fast/canvas/canvas-text-baseline-expected.png: Added.
  • platform/mac/fast/canvas/canvas-text-baseline-expected.txt: Added.
10:37 AM Changeset in webkit [36059] by sullivan@apple.com
  • 2 edits in trunk/WebCore

2008-09-03 John Sullivan <​sullivan@apple.com>

Fixed <rdar://problem/6193022> <rdar://problem/6193022> Crash occurs at WebCore::AnimationBase::propertiesEqual () after certain steps

Fixed by Darin, reviewed by me

  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::propertiesEqual): added ensurePropertyMap() to this static function (WebCore::AnimationBase::getPropertyAtIndex): ditto (WebCore::AnimationBase::getNumProperties): ditto
10:35 AM Changeset in webkit [36058] by kmccullough@apple.com
  • 18 edits in trunk

JavaScriptCore:

2008-09-02 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Darin and Tim.

Remove most of the "zombie" mode from the profiler. Next we will need
to remove the client callback mechanism in profiles.

  • This simplifies the code, leverages the recent changes I've made in getting line numbers from SquirrelFish, and is a slight speed improvement on SunSpider.
  • Also the "zombie" mode was a constant source of odd edge cases and obscure bugs so it's good to remove since all of its issues may not have been found.
  • API/JSProfilerPrivate.cpp: No need to call didFinishAllExecution() any more. (JSEndProfiling):
  • JavaScriptCore.exp: Export the new signature of retrieveLastCaller()
  • VM/Machine.cpp: (KJS::Machine::execute): No need to call didFinishAllExecution() any more. (KJS::Machine::retrieveCaller): Now operates on InternalFunctions now since the RegisterFile is no longer guaranteeded to store only JSFunctions (KJS::Machine::retrieveLastCaller): Now also retrieve the function's name (KJS::Machine::callFrame): A result of changing retrieveCaller()
  • VM/Machine.h:
  • VM/Register.h:
  • kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::~JSGlobalObject):
  • kjs/nodes.h:
  • profiler/ProfileGenerator.cpp: (KJS::ProfileGenerator::create): Now pass the original exec and get the global exec and client when necessary. We need the original exec so we can have the stack frame where profiling started. (KJS::ProfileGenerator::ProfileGenerator): ditto. (KJS::ProfileGenerator::addParentForConsoleStart): This is where the parent to star of the profile is added, if there is one. (KJS::ProfileGenerator::willExecute): Remove uglyness! (KJS::ProfileGenerator::didExecute): Ditto! (KJS::ProfileGenerator::stopProfiling): (KJS::ProfileGenerator::removeProfileStart): Use a better way to find and remove the function we are looking for. (KJS::ProfileGenerator::removeProfileEnd): Ditto.
  • profiler/ProfileGenerator.h: (KJS::ProfileGenerator::client):
  • profiler/ProfileNode.cpp: (KJS::ProfileNode::removeChild): Add a better way to remove a child from a ProfileNode. (KJS::ProfileNode::stopProfiling): (KJS::ProfileNode::debugPrintData): Modified a debug-only diagnostic function to be sane.
  • profiler/ProfileNode.h:
  • profiler/Profiler.cpp: Change to pass the original exec state. (KJS::Profiler::startProfiling): (KJS::Profiler::stopProfiling): (KJS::Profiler::willExecute): (KJS::Profiler::didExecute): (KJS::Profiler::createCallIdentifier):
  • profiler/Profiler.h:

WebCore:

2008-09-03 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Darin and Tim.

Remove most of the "zombie" mode from the profiler. Next we will need
to remove the client callback mechanism in profiles.

  • These changes are a result of changes to JSCore.
  • manual-tests/inspector/profiler-test-nested-start-and-stop-profiler.html:
  • page/Console.cpp: (WebCore::retrieveLastCaller): (WebCore::Console::profileEnd):
  • page/InspectorController.cpp: (WebCore::InspectorController::stopUserInitiatedProfiling):
9:57 AM Changeset in webkit [36057] by adele@apple.com
  • 6 edits
    4 adds in trunk

WebCore:

2008-09-03 Adele Peterson <​adele@apple.com>

Reviewed by Darin Adler.

Test: fast/forms/search-display-none-cancel-button.html

Allow display:none to work on a search field's cancel button. Prepare for adding more style-ability for the results button too.

  • css/html4.css: Set display:inline-block for these buttons. Now they can be overridden by a web author.
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setStyle): Add nil checks for the button renderers. (WebCore::RenderTextControl::createResultsButtonStyle): Don't set the display explicitly. This is now done in html4.css. (WebCore::RenderTextControl::createCancelButtonStyle): ditto. (WebCore::RenderTextControl::createSubtreeIfNeeded): Reorganize this code so our complicated way of adding shadow nodes is abstracted out into the TextControlInnerElement class. (WebCore::RenderTextControl::updateFromElement): Added nil checks for the button renderers. (WebCore::RenderTextControl::subtreeHasChanged): ditto. (WebCore::RenderTextControl::calcHeight): ditto. (WebCore::RenderTextControl::nodeAtPoint): ditto. (WebCore::RenderTextControl::layout): ditto. (WebCore::RenderTextControl::calcPrefWidths): ditto. (WebCore::RenderTextControl::clientPaddingLeft): ditto. (WebCore::RenderTextControl::clientPaddingRight): ditto.
  • rendering/TextControlInnerElements.cpp: (WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock): Moved from RenderTextControl.cpp. (WebCore::RenderTextControlInnerBlock::nodeAtPoint): ditto. (WebCore::TextControlInnerElement::attachInnerElement): Added. This does all the separate steps of attaching a shadow node that used to be repeated in RenderTextControl::createSubtreeIfNeeded for each element. (WebCore::TextControlInnerTextElement::createRenderer): Added. Creates a RenderTextControlInnerBlock.
  • rendering/TextControlInnerElements.h:

LayoutTests:

2008-09-03 Adele Peterson <​adele@apple.com>

Reviewed by Darin Adler.

Test that display:none works on a search field's cancel button.

  • fast/forms/search-display-none-cancel-button.html: Added.
  • platform/mac/fast/forms/search-display-none-cancel-button-expected.checksum: Added.
  • platform/mac/fast/forms/search-display-none-cancel-button-expected.png: Added.
  • platform/mac/fast/forms/search-display-none-cancel-button-expected.txt: Added.
9:37 AM Changeset in webkit [36056] by ap@webkit.org
  • 7 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.

Implement callOnMainThreadAndWait().

This will be useful when a background thread needs to perform UI calls synchronously
(e.g. an openDatabase() call cannot return until the user answers to a confirmation dialog).

  • wtf/MainThread.cpp: (WTF::FunctionWithContext::FunctionWithContext): Added a ThreadCondition member. When non-zero, the condition is signalled after the function is called. (WTF::mainThreadFunctionQueueMutex): Renamed from functionQueueMutex, sinc this is no longer static. Changed to be initialized from initializeThreading() to avoid lock contention. (WTF::initializeMainThread): On non-Windows platforms, just call mainThreadFunctionQueueMutex. (WTF::dispatchFunctionsFromMainThread): Signal synchronous calls when done. (WTF::callOnMainThread): Updated for functionQueueMutex rename. (WTF::callOnMainThreadAndWait): Added.
  • wtf/MainThread.h: Added callOnMainThreadAndWait(); initializeMainThread() now exists on all platforms.
  • wtf/win/MainThreadWin.cpp: (WTF::initializeMainThread): Added a callOnMainThreadAndWait() call to initialize function queue mutex.
  • wtf/ThreadingGtk.cpp: (WTF::initializeThreading):
  • wtf/ThreadingPthreads.cpp: (WTF::initializeThreading):
  • wtf/ThreadingQt.cpp: (WTF::initializeThreading): Only initialize mainThreadIdentifier on non-Darwin platforms. It was not guaranteed to be accurate on Darwin.
9:20 AM Changeset in webkit [36055] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-09-03 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin Adler.


Use isUndefinedOrNull() instead of separate checks for each in op_eq_null
and op_neq_null.

  • VM/Machine.cpp: (KJS::Machine::privateExecute):
1:08 AM Changeset in webkit [36054] by ap@webkit.org
  • 8 edits
    1 delete in trunk/WebCore

Reviewed by Maciej.

Elminate SQLiteAuthorizer class.

  • WebCore.xcodeproj/project.pbxproj:
  • WebCore.vcproj/WebCore.vcproj:
  • GNUmakefile.am Removed SQLiteAuthorizer.h.
  • platform/sql/SQLiteAuthorizer.cpp:
  • platform/sql/SQLiteAuthorizer.h: Removed.
  • platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::authorizerFunction): (WebCore::SQLiteDatabase::setAuthorizer):
  • platform/sql/SQLiteDatabase.h:
  • storage/DatabaseAuthorizer.h: (WebCore::DatabaseAuthorizer::create): (WebCore::DatabaseAuthorizer::createView): (WebCore::DatabaseAuthorizer::createTempView): (WebCore::DatabaseAuthorizer::dropView): (WebCore::DatabaseAuthorizer::dropTempView): (WebCore::DatabaseAuthorizer::allowSelect): (WebCore::DatabaseAuthorizer::allowReindex): Merge SQLiteAuthorizer and DatabaseAuthorizer, as keeping them separate serves no purpose.
12:09 AM Changeset in webkit [36053] by mrowe@apple.com
  • 1 edit in trunk/WebCore/GNUmakefile.am

Move the backslash to the right place.

12:05 AM Changeset in webkit [36052] by mrowe@apple.com
  • 4 edits in trunk/WebCore

2008-09-03 Dirk Schulze <​vbs85@gmx.de>

Reviewed and tweaked by Mark Rowe.

WebKitGtk build fix.

  • GNUmakefile.am:
  • page/animation/AnimationController.h:

Sep 2, 2008:

11:59 PM Changeset in webkit [36051] by mrowe@apple.com
  • 9 edits
    2 adds in trunk

2008-09-02 Robert Blaut <​webkit@blaut.biz>

Reviewed by Geoff Garen.

Fix for <​https://bugs.webkit.org/show_bug.cgi?id=16913>
Misplaced elements should not close DL lists.

Test: fast/invalid/test-case-tr-th-td-should-not-close-dl-list.html

  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleError):

2008-09-02 Robert Blaut <​webkit@blaut.biz>

Reviewed by Geoff Garen.

Test for <​https://bugs.webkit.org/show_bug.cgi?id=16913>
Misplaced elements should not close DL lists.

  • fast/invalid/test-case-tr-th-td-should-not-close-dl-list-expected.txt: Added.
  • fast/invalid/test-case-tr-th-td-should-not-close-dl-list.html: Added.
  • platform/mac/fast/invalid/missing-dl-end-tag-expected.checksum:
  • platform/mac/fast/invalid/missing-dl-end-tag-expected.png:
  • platform/mac/fast/invalid/missing-dl-end-tag-expected.txt:
  • platform/mac/fast/invalid/missing-dt-end-tag-expected.checksum:
  • platform/mac/fast/invalid/missing-dt-end-tag-expected.png:
  • platform/mac/fast/invalid/missing-dt-end-tag-expected.txt:
11:51 PM Changeset in webkit [36050] by mrowe@apple.com
  • 3 edits
    2 adds in trunk

2008-09-02 Glenn Wilson <​wilsong@gmail.com>

Reviewed by Darin Adler.

Fix for <​https://bugs.webkit.org/show_bug.cgi?id=15360>
Bug 15360: color:#{predefined colorName} is treated as colorName in Safari

We would inappropriately interpret and apply an invalid CSS "color" property
when the value is a predefined color preceded by a '#' symbol. For example,
style="color:#gray;" would apply the color gray when it should not.

In the bison template, "hexcolor" was defined as both "HEX maybe_space" OR "IDENT maybe_space".
This caused identifiers not fitting the appropriate hex format but preceded by a '#' to be
interpreted as a valid color (CSSPrimitiveValue::CSS_PARSER_HEXCOLOR), when it was really just
an ignorable token.

To correct this, "IDENT maybe_space" was removed from "hexcolor" and added under "term" as
'#' IDENT maybe_space, which is then processed as a CSSPrimitiveValue::CSS_STRING instead of
CSSPrimitiveValue::CSS_PARSER_HEXCOLOR.

Test: css1/color_and_background/invalid_color.html

  • css/CSSGrammar.y:

2008-09-02 Glenn Wilson <​wilsong@gmail.com>

Reviewed by Darin Adler.

Test for <​https://bugs.webkit.org/show_bug.cgi?id=15360>
Bug 15360: color:#{predefined colorName} is treated as colorName in Safari

Added new test to verify that CSS "color" attributes with '#'-preceeded predefined color names
are not rendered in those colors.

  • css1/color_and_background/invalid_color.html: Added.
  • css1/color_and_background/invalid_color-expected.txt: Added.
11:38 PM Changeset in webkit [36049] by mrowe@apple.com
  • 2 edits in trunk/WebKit

Build fix. Remove the now unnecessary check for "4" in the user agent string.

Reviewed by Tim Hatcher.

  • WebKit.xcodeproj/project.pbxproj:
11:28 PM Changeset in webkit [36048] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-09-02 Csaba Osztrogonac <​oszi@inf.u-szeged.hu>

Reviewed by Darin Adler.

Bug 20296: OpcodeStats doesn't build on platforms which don't have mergesort().
<​https://bugs.webkit.org/show_bug.cgi?id=20296>

  • VM/Opcode.cpp: (KJS::OpcodeStats::~OpcodeStats): mergesort() replaced with qsort()
11:22 PM Changeset in webkit [36047] by mrowe@apple.com
  • 3 edits
    4 adds in trunk

2008-09-02 Mihnea Ovidenie <​mihnea@adobe.com>

Reviewed by Darin Adler.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=19964
Bug 19964: Divide by zero crash in RenderBox::calculateBackgroundSize with 0,0 bmp background image

Add a check to RenderBox::repaintLayerRectsForImage to make sure the current layer image can be rendered.

Test: css3/khtml-background-size-0x0-bmp.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::repaintLayerRectsForImage):

2008-09-02 Mihnea Ovidenie <​mihnea@adobe.com>

Reviewed by Darin Adler.

Test for ​https://bugs.webkit.org/show_bug.cgi?id=19964
Bug 19964: Divide by zero crash in RenderBox::calculateBackgroundSize with 0,0 bmp background image

  • css3/khtml-background-size-0x0-bmp-expected.txt: Added.
  • css3/khtml-background-size-0x0-bmp.html: Added.
  • css3/support/0x0.bmp: Added.
11:12 PM Changeset in webkit [36046] by mrowe@apple.com
  • 3 edits
    2 adds in trunk

2008-09-02 Glenn Wilson <​wilsong@gmail.com>

Reviewed by Eric Seidel.

Fix ​https://bugs.webkit.org/show_bug.cgi?id=20397
Bug 20397: Invalid webkit-border-bottom-left-radius property causes crash

The function checkForOrphanedUnits() would change the length of a list whose size was
was already determined before the call to checkForOrphanedUnits was made. Later in
the caller, the old size was being used for boundary management.

This has been fixed by moving the call to checkForOrphanedUnits() earlier in the
calling function, before the size of the list is determined.

Test: fast/css/orphaned_units_crash.html

  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Moved call to checkForOrphanedUnits() earlier in the function.

2008-09-02 Glenn Wilson <​wilsong@gmail.com>

Reviewed by Eric Seidel.

Tests for ​https://bugs.webkit.org/show_bug.cgi?id=20397
Bug 20397: Invalid webkit-border-bottom-left-radius property causes crash

Added new tests to check whether an orphaned unit identifier in particular
CSS attributes will crash the browser.

  • fast/css/orphaned_units_crash-expected.txt: Added.
  • fast/css/orphaned_units_crash.html: Added.
11:10 PM Changeset in webkit [36045] by cwzwarich@webkit.org
  • 2 edits in trunk

2008-09-02 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Not reviewed.

Move the ChangeLog of r35906 to its rightful place.

11:01 PM Changeset in webkit [36044] by mrowe@apple.com
  • 3 edits
    6 adds in trunk

2008-09-02 Dirk Schulze <​vbs85@gmx.de>

Reviewed by Darin Adler.

Fallback on invalid fill or stroke styles in Canvas was
transparent black. Changed it to last valid style.

Canvas fillStyle() and strokeStyle() needs fallback
​https://bugs.webkit.org/show_bug.cgi?id=20474

Tests: fast/canvas/canvas-invalid-fillstyle.html

fast/canvas/canvas-invalid-strokestyle.html

  • html/CanvasStyle.cpp: (WebCore::CanvasStyle::applyStrokeColor): (WebCore::CanvasStyle::applyFillColor):

2008-09-02 Dirk Schulze <​vbs85@gmx.de>

Reviewed by Darin Adler.

Tests for ​https://bugs.webkit.org/show_bug.cgi?id=20474
Tests behaviour on invalid fillStyle() or strokeStyle() in canvas.

  • fast/canvas/canvas-invalid-fillstyle-expected.txt: Added.
  • fast/canvas/canvas-invalid-fillstyle.html: Added.
  • fast/canvas/canvas-invalid-fillstyle.js: Added.
  • fast/canvas/canvas-invalid-strokestyle-expected.txt: Added.
  • fast/canvas/canvas-invalid-strokestyle.html: Added.
  • fast/canvas/canvas-invalid-strokestyle.js: Added.
10:49 PM Changeset in webkit [36043] by mrowe@apple.com
  • 5 edits
    3 adds in trunk

2008-09-02 Dirk Schulze <​vbs85@gmx.de>

Reviewed by Darin Adler.

Fix ​https://bugs.webkit.org/show_bug.cgi?id=20468
Updated drawImage() in canvas to match the current specification.

Test: fast/canvas/drawImage-with-negative-source-destination.html

  • html/CanvasRenderingContext2D.cpp: (WebCore::normalizeRect): (WebCore::CanvasRenderingContext2D::drawImage):

2008-09-02 Dirk Schulze <​vbs85@gmx.de>

Reviewed by Darin Adler.

Tests for ​https://bugs.webkit.org/show_bug.cgi?id=20468
Test negative source and destination rect in drawImage()

  • fast/canvas/drawImage-with-invalid-args-expected.txt:
  • fast/canvas/drawImage-with-invalid-args.html:
  • fast/canvas/drawImage-with-negative-source-destination-expected.txt: Added.
  • fast/canvas/drawImage-with-negative-source-destination.html: Added.
  • fast/canvas/drawImage-with-negative-source-destination.js: Added.
10:41 PM Changeset in webkit [36042] by mrowe@apple.com
  • 4 edits in trunk/WebCore

<rdar://problem/5768210> Switch back to the system version of SQLite

Reviewed by Darin Adler.

Use the system version of SQLite when it is new enough to provide the functionality
that WebCore requires.

  • Configurations/Base.xcconfig:
  • Configurations/DebugRelease.xcconfig:
  • Configurations/WebCore.xcconfig:
10:23 PM Changeset in webkit [36041] by mrowe@apple.com
  • 4 edits in tags/Safari-6528.3

Versioning.

10:13 PM Changeset in webkit [36040] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

10:04 PM Changeset in webkit [36039] by ggaren@apple.com
  • 5 edits in trunk/JavaScriptCore

2008-09-02 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.


Fast path for array.length and string.length.


SunSpider says 0.5% faster.

8:19 PM Changeset in webkit [36038] by mitz@apple.com
  • 2 edits in trunk/LayoutTests
  • update expected results now that log() et al. report line numbers
  • fast/dom/Window/console-functions-expected.txt:
7:59 PM Changeset in webkit [36037] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • build fix
  • page/animation/AnimationBase.h:
7:58 PM Changeset in webkit [36036] by ggaren@apple.com
  • 9 edits in trunk/JavaScriptCore

2008-09-02 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Anders Carlsson.


Added optimized paths for comparing to null.


SunSpider says 0.5% faster.

7:46 PM Changeset in webkit [36035] by cwzwarich@webkit.org
  • 2 edits in trunk/SunSpider

2008-09-02 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Not reviewed.

Remove a local change that was accidentally committed in r36034.

  • resources/sunspider-standalone-driver.js:
7:42 PM Changeset in webkit [36034] by cwzwarich@webkit.org
  • 2 edits
    3 adds in trunk

2008-09-02 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Oliver Hunt.

Tests for bug 17936: "ASSERTION FAILED: false" (GetterSetterImp::toObject is called)
<​https://bugs.webkit.org/show_bug.cgi?id=17936>

This bug was fixed by the rewrite of much of the code handling getters
and setters in r36016, the revision that introduced the polymorphic
inline cache.

  • fast/js/delete-getters-setters-expected.txt: Added.
  • fast/js/delete-getters-setters.html: Added.
  • fast/js/resources/delete-getters-setters.js: Added.
7:39 PM Changeset in webkit [36033] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-09-02 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.

Changed jsDriver.pl to dump the exact text you would need in order to
reproduce a test result. This enables a fast workflow where you copy
and paste a test failure in the terminal.

  • tests/mozilla/jsDriver.pl:
7:31 PM Changeset in webkit [36032] by ggaren@apple.com
  • 25 edits
    4 adds in trunk

JavaScriptCore:

2008-09-02 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.


Implemented the rest of Darin's review comments for the 09-01 inline
caching patch.


SunSpider says 0.5% faster, but that seems like noise.

  • JavaScriptCore.xcodeproj/project.pbxproj: Put PutPropertySlot into its own file, and added BatchedTransitionOptimizer.
  • VM/CodeBlock.cpp: (KJS::CodeBlock::~CodeBlock): Use array indexing instead of a pointer iterator.
  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::CodeGenerator): Used BatchedTransitionOptimizer to make batched put and remove for declared variables fast, without forever pessimizing the global object. Removed the old getDirect/removeDirect hack that tried to do the same in a more limited way.
  • VM/CodeGenerator.h: Moved IdentifierRepHash to the KJS namespace since it doesn't specialize anything in WTF.
  • VM/Machine.cpp: (KJS::Machine::Machine): Nixed the DummyConstruct tag because it was confusingly named.

(KJS::Machine::execute): Used BatchedTransitionOptimizer, as above. Fixed
up some comments.

(KJS::cachePrototypeChain): Cast to JSObject*, since it's more specific.

(KJS::Machine::tryCachePutByID): Use isNull() instead of comparing to
jsNull(), since isNull() leaves more options open for the future.
(KJS::Machine::tryCacheGetByID): ditto
(KJS::Machine::privateExecute): ditto

  • VM/SamplingTool.cpp: (KJS::SamplingTool::dump): Use C++-style cast, to match our style guidelines.
  • kjs/BatchedTransitionOptimizer.h: Added. New class that allows host code to add a batch of properties to an object in an efficient way.
  • kjs/JSActivation.cpp: Use isNull(), as above.
  • kjs/JSArray.cpp: Get rid of DummyConstruct tag, as above.
  • kjs/JSArray.h:
  • kjs/JSGlobalData.cpp: Nixed two unused StructureIDs.
  • kjs/JSGlobalData.h:
  • kjs/JSImmediate.cpp: Use isNull(), as above.
  • kjs/JSObject.cpp: (KJS::JSObject::mark): Moved mark tracing code elsewhere, to make this function more readable.

(KJS::JSObject::put): Use isNull(), as above.

(KJS::JSObject::createInheritorID): Return a raw pointer, since the
object is owned by a data member, not necessarily the caller.

  • kjs/JSObject.h:
  • kjs/JSString.cpp: Use isNull(), as above.
  • kjs/PropertyMap.h: Updated to use PropertySlot::invalidOffset.
  • kjs/PropertySlot.h: Changed KJS_INVALID_OFFSET to WTF::notFound because C macros are so 80's.
  • kjs/PutPropertySlot.h: Added. Split out of PropertySlot.h. Also renamed PutPropertySlot::SlotType to PutPropertySlot::Type, and slotBase to base, since "slot" was redundant.
  • kjs/StructureID.cpp: Added a new transition *away* from dictionary status, to support BatchedTransitionOptimizer.

(KJS::StructureIDChain::StructureIDChain): No need to store m_size as
a data member, so keep it in a local, which might be faster.

  • kjs/StructureID.h:
  • kjs/SymbolTable.h: Moved IdentifierRepHash to KJS namespace, as above.
  • kjs/ustring.h:

JavaScriptGlue:

2008-09-02 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.


Implemented the rest of Darin's review comments for the 09-01 inline
caching patch.


  • ForwardingHeaders/kjs/PutPropertySlot.h: Added.
6:32 PM Changeset in webkit [36031] by dino@apple.com
  • 6 edits
    1 move
    10 adds
    1 delete in trunk/WebCore

2008-09-02 Chris Marrin <​cmarrin@apple.com>

Reviewed by Dave Hyatt.

AnimationController.cpp should be split into separate files
​https://bugs.webkit.org/show_bug.cgi?id=20604

Note: All makefiles, except WebCore.xcodeproj have been changed without testing, upon
recommendation of Dave Hyatt.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:

Build files.

  • page/AnimationController.cpp: Removed.
  • page/AnimationController.h: Removed.
  • page/animation: Added.
  • page/animation/AnimationBase.cpp: Added.
  • page/animation/AnimationBase.h: Added.
  • page/animation/AnimationController.cpp: Copied from WebCore/page/AnimationController.cpp.
  • page/animation/AnimationController.h: Copied from WebCore/page/AnimationController.h.
  • page/animation/CompositeAnimation.cpp: Added.
  • page/animation/CompositeAnimation.h: Added.
  • page/animation/ImplicitAnimation.cpp: Added.
  • page/animation/ImplicitAnimation.h: Added.
  • page/animation/KeyframeAnimation.cpp: Added.
  • page/animation/KeyframeAnimation.h: Added.
5:57 PM Changeset in webkit [36030] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • release build fix
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::calculateDrawingMode):
2:35 PM Changeset in webkit [36029] by timothy@apple.com
  • 5 edits in trunk/WebCore

Make console functions log the correct resource URL and
line number for where the call originated.

​https://bugs.webkit.org/show_bug.cgi?id=17234
<rdar://problem/5732837>

Reviewed by Kevin McCullough.

Test: manual-tests/inspector/console-call-line-numbers.html

  • bindings/js/JSConsoleCustom.cpp: (WebCore::JSConsole::count): Call the impl. (WebCore::JSConsole::timeEnd): Ditto.
  • manual-tests/inspector/console-call-line-numbers.html: Added.
  • manual-tests/inspector/resources/script-console-calls.js: Added.
  • page/Console.cpp: (WebCore::retrieveLastCaller): Helper to get the URL and line. (WebCore::Console::error): Call retrieveLastCaller to get the URL and line number to pass to addMessageToConsole. (WebCore::Console::info): Ditto. (WebCore::Console::log): Ditto. (WebCore::Console::assertCondition): Ditto. (WebCore::Console::count): Ditto. (WebCore::Console::timeEnd): Ditto. (WebCore::Console::warn): Ditto.
  • page/Console.h:
  • page/Console.idl: Make count and timeEnd custom.
2:30 PM Changeset in webkit [36028] by timothy@apple.com
  • 2 edits in trunk/WebCore

Removed IDL files from WebCore's framework resources.

  • WebCore.xcodeproj/project.pbxproj:
2:11 PM Changeset in webkit [36027] by cwzwarich@webkit.org
  • 2 edits in trunk/SunSpider

2008-09-02 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Rubber-stamped by Oliver Hunt.

Make SunSpider work with JavaScript shells that don't take filenames
after a '-f' argument.

  • sunspider:
1:39 PM Changeset in webkit [36026] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Dave Hyatt.

  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Added a cap on the number of consecutive identical residual style tags to reopen. (WebCore::HTMLParser::popBlock): Ditto.
9:16 AM Changeset in webkit [36025] by ap@webkit.org
  • 5 edits in trunk/WebCore

Reviewed by Adam Roben.

A little database quota management cleanup.

  • storage/OriginQuotaManager.cpp: (WebCore::OriginQuotaManager::OriginQuotaManager): (WebCore::OriginQuotaManager::lock): (WebCore::OriginQuotaManager::unlock): (WebCore::OriginQuotaManager::trackOrigin): (WebCore::OriginQuotaManager::tracksOrigin): (WebCore::OriginQuotaManager::addDatabase): (WebCore::OriginQuotaManager::removeDatabase): (WebCore::OriginQuotaManager::removeOrigin): (WebCore::OriginQuotaManager::markDatabase): (WebCore::OriginQuotaManager::diskUsage):
  • storage/OriginQuotaManager.h: Changed to assert that a lock is taken more directly and reliably. Removed comments about main/background threads, as this is likely to stop being true with synchronous Database calls being made on worker threads.
  • storage/OriginUsageRecord.cpp: (WebCore::OriginUsageRecord::OriginUsageRecord): (WebCore::OriginUsageRecord::addDatabase): (WebCore::OriginUsageRecord::removeDatabase): (WebCore::OriginUsageRecord::markDatabase): (WebCore::OriginUsageRecord::diskUsage):
  • storage/OriginUsageRecord.h: (WebCore::OriginUsageRecord::DatabaseEntry::DatabaseEntry): Don't use a magic value for unknown. It is totally unnecessary for DatabaseEntry, and can be replaced with a single boolean for OriginUsageRecord. Added assertions for string parameters being unshared.
8:15 AM Changeset in webkit [36024] by Adam Roben
  • 3 edits in trunk/JavaScriptCore

Windows build fixes

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Add StructureID.{cpp,h} to the project. Also let VS reorder this file.
  • VM/CodeBlock.cpp: Include StringExtras so that snprintf will be defined on Windows.
Note: See TracTimeline for information about the timeline view.