⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 11, 2008:

9:44 PM Changeset in webkit [36349] by timothy@apple.com
  • 5 edits in trunk/WebCore

Add a renderedImage method to DOMNode to get an image
of the rendering for the node and it's descendants.

<rdar://problem/5849349> Would like API to create
an image for a DOM node

Reviewed by Oliver Hunt.

  • bindings/objc/DOM.mm: (-[DOMNode renderedImage]): Call Frame::nodeImage.
  • bindings/objc/DOMPrivate.h:
  • page/Frame.h:
  • page/mac/FrameMac.mm: (WebCore::Frame::nodeImage):
6:25 PM Changeset in webkit [36348] by dino@apple.com
  • 3 edits in trunk/LayoutTests

2008-09-11 Dean Jackson <dino@apple.com>

Unfortunately the fix for
https://bugs.webkit.org/show_bug.cgi?id=20680
didn't update the relevant test

  • css3/keyframes-rule-expected.txt:
  • css3/keyframes-rule.html:
5:36 PM Changeset in webkit [36347] by dino@apple.com
  • 11 edits
    2 adds in trunk

2008-09-08 Chris Marrin <cmarrin@apple.com>

Reviewed by Dave Hyatt

Need to support comma separated list of key times in keyframes selectors
https://bugs.webkit.org/show_bug.cgi?id=20680

Test: animations/keyframes-comma-separated.html

  • css/CSSGrammar.y:
  • css/CSSParser.cpp: (WebCore::CSSParser::createKeyframeRule):
  • css/CSSParser.h:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::addKeyframeStyle):
  • css/WebKitCSSKeyframeRule.cpp: (WebCore::WebKitCSSKeyframeRule::WebKitCSSKeyframeRule): (WebCore::WebKitCSSKeyframeRule::cssText): (WebCore::WebKitCSSKeyframeRule::parseKeyString):
  • css/WebKitCSSKeyframeRule.h: (WebCore::WebKitCSSKeyframeRule::keyText): (WebCore::WebKitCSSKeyframeRule::setKeyText): (WebCore::WebKitCSSKeyframeRule::getKeys):
  • css/WebKitCSSKeyframesRule.cpp: (WebCore::WebKitCSSKeyframesRule::append): (WebCore::WebKitCSSKeyframesRule::insertRule): (WebCore::WebKitCSSKeyframesRule::deleteRule): (WebCore::WebKitCSSKeyframesRule::findRule): (WebCore::WebKitCSSKeyframesRule::findRuleIndex):
  • css/WebKitCSSKeyframesRule.h:
  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::blendProperties):
5:24 PM Changeset in webkit [36346] by mrowe@apple.com
  • 4 edits in tags/Safari-6528.3.1

Versioning.

5:24 PM Changeset in webkit [36345] by mrowe@apple.com
  • 2 edits in tags/Safari-6528.3.1/JavaScriptCore

Merge r36292.

5:15 PM Changeset in webkit [36344] by mrowe@apple.com
  • 1 copy in tags/Safari-6528.3.1

New tag.

3:57 PM Changeset in webkit [36343] by kmccullough@apple.com
  • 5 edits in trunk

WebCore:

2008-09-11 Kevin McCullough <kmccullough@apple.com>

RS by Tim.

Reverting because this caused a crash.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::canBeProgramaticallyScrolled): (WebCore::RenderObject::hasScrollableView):
  • rendering/RenderObject.h:

LayoutTests:

2008-09-11 Kevin McCullough <kmccullough@apple.com>

RS = Tim.

Reverted because this caused a crash.

  • fast/events/autoscroll-with-non-scrollable-parent.html:
3:32 PM Changeset in webkit [36342] by Stephanie Lewis
  • 2 edits in trunk/JavaScriptCore

2008-09-11 Stephanie Lewis <Stephanie Lewis>

Reviewed by Oliver Hunt.

Turn off PGO Optimization on CTI.cpp -> <rdar://problem/6207709>. Fixes
crash on CNN and on Dromaeo.
Fix Missing close tag in vcproj.

2:59 PM Changeset in webkit [36341] by dino@apple.com
  • 3 edits
    2 adds in trunk

2008-09-11 Dean Jackson <dino@apple.com>

Reviewed by Dan Bernstein.

Fix assertion on transition property "none"
https://bugs.webkit.org/show_bug.cgi?id=20751

Test: transitions/transition-end-event-set-none.html

  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions):
2:54 PM Changeset in webkit [36340] by dsmith@webkit.org
  • 1 edit
    1 delete in trunk/WebCore

2008-09-11 David Smith <catfish.man@gmail.com>

Rubber-stamped by mitzpettel.

Remove an accidentally added extra file.

  • WebCore: Removed.
2:41 PM Changeset in webkit [36339] by dsmith@webkit.org
  • 13 edits
    4 adds in trunk/WebCore

2008-09-11 David Smith <catfish.man@gmail.com>

Reviewed by Darin

https://bugs.webkit.org/show_bug.cgi?id=20180


This speeds up :nth-child matching as tested by querySelectorAll by around 10% by inlining the common case of Node::renderStyle(). Many thanks to mitzpettel and othermaciej for suggestions and help.

  • WebCore.xcodeproj/project.pbxproj: Add NodeRenderStyle.h
  • css/CSSStyleSelector.cpp: include NodeRenderStyle.h
  • dom/Element.cpp: include NodeRenderStyle.h
  • dom/Node.cpp: Remove the definition of renderStyle() (WebCore::Node::nonRendererRenderStyle):
  • dom/Node.h: Make renderStyle() nonvirtual and add nonRendererRenderStyle()
  • dom/NodeRenderStyle.h: Added. (WebCore::Node::renderStyle): Inline the common case of this, call nonRendererRenderStyle for the part that needed to be virtual
  • html/HTMLOptGroupElement.cpp: include NodeRenderStyle.h
  • html/HTMLOptGroupElement.h: (WebCore::HTMLOptGroupElement::nonRendererRenderStyle): override to return m_style
  • html/HTMLOptionElement.cpp: include NodeRenderStyle.h
  • html/HTMLOptionElement.h: (WebCore::HTMLOptionElement::nonRendererRenderStyle): override to return m_style
  • rendering/RenderListBox.cpp: include NodeRenderStyle.h
  • rendering/RenderMenuList.cpp: include NodeRenderStyle.h
  • svg/SVGUseElement.cpp: include NodeRenderStyle.h
2:15 PM Changeset in webkit [36338] by cwzwarich@webkit.org
  • 1 edit
    2 adds in trunk/JavaScriptCore

2008-09-11 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Not reviewed.

Correct an SVN problem with the last commit and actually add the new
files.

  • wrec/CharacterClassConstructor.cpp: Added. (JSC::): (JSC::getCharacterClassNewline): (JSC::getCharacterClassDigits): (JSC::getCharacterClassSpaces): (JSC::getCharacterClassWordchar): (JSC::getCharacterClassNondigits): (JSC::getCharacterClassNonspaces): (JSC::getCharacterClassNonwordchar): (JSC::CharacterClassConstructor::addSorted): (JSC::CharacterClassConstructor::addSortedRange): (JSC::CharacterClassConstructor::put): (JSC::CharacterClassConstructor::flush): (JSC::CharacterClassConstructor::append):
  • wrec/CharacterClassConstructor.h: Added. (JSC::CharacterClassConstructor::CharacterClassConstructor): (JSC::CharacterClassConstructor::isUpsideDown): (JSC::CharacterClassConstructor::charClass):
2:13 PM Changeset in webkit [36337] by cwzwarich@webkit.org
  • 4 edits in trunk/JavaScriptCore

2008-09-11 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Maciej Stachowiak.

Bug 20788: Split CharacterClassConstructor into its own file
<https://bugs.webkit.org/show_bug.cgi?id=20788>

Split CharacterClassConstructor into its own file and clean up some
style issues.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wrec/CharacterClassConstructor.cpp: Added. (JSC::): (JSC::getCharacterClassNewline): (JSC::getCharacterClassDigits): (JSC::getCharacterClassSpaces): (JSC::getCharacterClassWordchar): (JSC::getCharacterClassNondigits): (JSC::getCharacterClassNonspaces): (JSC::getCharacterClassNonwordchar): (JSC::CharacterClassConstructor::addSorted): (JSC::CharacterClassConstructor::addSortedRange): (JSC::CharacterClassConstructor::put): (JSC::CharacterClassConstructor::flush): (JSC::CharacterClassConstructor::append):
  • wrec/CharacterClassConstructor.h: Added. (JSC::CharacterClassConstructor::CharacterClassConstructor): (JSC::CharacterClassConstructor::isUpsideDown): (JSC::CharacterClassConstructor::charClass):
  • wrec/WREC.cpp: (JSC::WRECParser::parseCharacterClass):
1:29 PM Changeset in webkit [36336] by mitz@apple.com
  • 4 edits in trunk/WebKit/mac

Reviewed by John Sullivan.

  • eliminate excessive repainting when a clipped iframe is moved (noticed in <rdar://problem/6204032>)
  • WebView/WebFrame.mm: (-[WebFrame _getVisibleRect:]): Added. If the frame is in a RenderPart and has layout, gets the visible rect of the RenderPart and returns YES. Returns NO otherwise.
  • WebView/WebFrameInternal.h:
  • WebView/WebFrameView.mm: (-[WebFrameView visibleRect]): Added. Overrides this NSView method to take clipping in the render tree into account.
10:45 AM ProposedWebInspectorRearchitecting edited by ojan@chromium.org
(diff)
10:39 AM Changeset in webkit [36335] by kmccullough@apple.com
  • 5 edits in trunk

WebCore:

2008-09-11 Kevin McCullough <kmccullough@apple.com>

Reviewed by Adele and Tim.

<rdar://problem/6100597> REGRESSION: clicking on search results in Web
Inspector does not scroll to the line of the results (20167)

  • This was put in by Max to fix auto scrolling but is not correct for the whole web: rdar://problem/6213098
  • rendering/RenderObject.cpp: (WebCore::RenderObject::canBeProgramaticallyScrolled):
  • rendering/RenderObject.h:

LayoutTests:

2008-09-11 Kevin McCullough <kmccullough@apple.com>

Reviewed by Adele and Tim.

<rdar://problem/6100597> REGRESSION: clicking on search results in Web
Inspector does not scroll to the line of the results (20167)

  • This was put in by Max to fix some auto scroll behavior but is not correct for the whole web: rdar://problem/6213098
  • fast/events/autoscroll-with-non-scrollable-parent.html:
9:24 AM Changeset in webkit [36334] by Chris Fleizach
  • 3 edits
    2 adds in trunk

<rdar://problem/6210511> AX: if a frame has a title, that should be reported as the AXWebArea's title

3:50 AM Changeset in webkit [36333] by vestbo@webkit.org
  • 2 edits in trunk/WebKit/qt

2008-09-11 Tor Arne Vestbø <tavestbo@trolltech.com>

Rubber-stamped by Simon.

Prevent leaking pages and frames in QWebKit autotest

2:53 AM Changeset in webkit [36332] by vestbo@webkit.org
  • 2 edits in trunk/WebKit/qt

2008-09-11 Tor Arne Vestbø <tavestbo@trolltech.com>

Reviewed by Simon

Fix QtWebKit autotest

1:03 AM Changeset in webkit [36331] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-09-11 Dirk Schulze <vbs85@gmx.de>

Reviewed by Simon.

Fixed stroke() and strokeRect() to support gradients
and patterns on Qt.

[Qt] Canvas stroke don't work for gradients and patterns
https://bugs.webkit.org/show_bug.cgi?id=20749

12:37 AM Changeset in webkit [36330] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-09-11 Dirk Schulze <vbs85@gmx.de>

Reviewed by Simon.

https://bugs.webkit.org/show_bug.cgi?id=20729

Fixed canvas gradients for Qt

12:34 AM Changeset in webkit [36329] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-09-11 Dirk Schulze <vbs85@gmx.de>

Reviewed by Simon.

https://bugs.webkit.org/show_bug.cgi?id=20568

Add support for patterns to Qt.

12:09 AM Changeset in webkit [36328] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2008-09-10 Simon Hausmann <Simon Hausmann>

Not reviewed but trivial one-liner for yet unused macro.

Changed PLATFORM(WINCE) to PLATFORM(WIN_CE) as requested by Mark.

(part of https://bugs.webkit.org/show_bug.cgi?id=20746)

Sep 10, 2008:

10:28 PM Changeset in webkit [36327] by cwzwarich@webkit.org
  • 4 edits in trunk/JavaScriptCore

2008-09-10 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Rubber-stamped by Oliver Hunt.

Fix a typo by renaming the overloaded orl_rr that takes an immediate to
orl_i32r.

  • VM/CTI.cpp: (JSC::CTI::emitFastArithPotentiallyReTagImmediate):
  • masm/X86Assembler.h: (JSC::X86Assembler::orl_i32r):
  • wrec/WREC.cpp: (JSC::WRECGenerator::generatePatternCharacter): (JSC::WRECGenerator::generateCharacterClassInverted):
9:01 PM Changeset in webkit [36326] by weinig@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

2008-09-10 Sam Weinig <sam@webkit.org>

Rubber-stamped by David Hyatt.

Add additional test by Feng Qian.

  • fast/dom/StyleSheet/ownerNode-lifetime-2-expected.txt: Added.
  • fast/dom/StyleSheet/ownerNode-lifetime-2.html: Added.
7:42 PM Changeset in webkit [36325] by weinig@apple.com
  • 9 edits in trunk/JavaScriptCore

2008-09-10 Sam Weinig <sam@webkit.org>

Reviewed by Geoff Garen.

Add inline property storage for JSObject.

1.2% progression on Sunspider. .5% progression on the v8 test suite.

  • JavaScriptCore.exp:
  • VM/CTI.cpp: (JSC::CTI::privateCompileGetByIdProto): (JSC::CTI::privateCompileGetByIdChain):
  • kjs/JSObject.cpp: (JSC::JSObject::mark): There is no reason to check storageSize now that we start from 0. (JSC::JSObject::allocatePropertyStorage): Allocates/reallocates heap storage.
  • kjs/JSObject.h: (JSC::JSObject::offsetForLocation): m_propertyStorage is not an OwnArrayPtr now so there is no reason to .get() (JSC::JSObject::usingInlineStorage): (JSC::JSObject::JSObject): Start with m_propertyStorage pointing to the inline storage. (JSC::JSObject::~JSObject): Free the heap storage if not using the inline storage. (JSC::JSObject::putDirect): Switch to the heap storage only when we know we know that we are about to add a property that will overflow the inline storage.
  • kjs/PropertyMap.cpp: (JSC::PropertyMap::createTable): Don't allocate the propertyStorage, that is now handled by JSObject. (JSC::PropertyMap::rehash): PropertyStorage is not a OwnArrayPtr anymore.
  • kjs/PropertyMap.h: (JSC::PropertyMap::storageSize): Rename from markingCount.
  • kjs/StructureID.cpp: (JSC::StructureID::addPropertyTransition): Don't resize the property storage if we are using inline storage.
  • kjs/StructureID.h:
7:10 PM Changeset in webkit [36324] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

Inline immediate number version of op_mul.

Reviewed by Geoff Garen

Renamed mull_rr to imull_rr as that's what it's
actually doing, and added imull_i32r for the constant
case immediate multiply.

1.1% improvement to SunSpider.

1:30 PM Changeset in webkit [36323] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-09-10 Alp Toker <alp@nuanti.com>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=17267
[GTK] Primary selection/clipboard support

Implement primary selection support (copying only, no paste yet).

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::clipboard_get_contents_cb): (WebKit::clipboard_clear_contents_cb): (WebKit::EditorClient::respondToChangedSelection):
1:22 PM ProposedWebInspectorRearchitecting edited by ojan@chromium.org
(diff)
12:48 PM ProposedWebInspectorRearchitecting created by ojan@chromium.org
12:30 PM Web Inspector edited by ojan@chromium.org
(diff)
11:21 AM Changeset in webkit [36322] by mitz@apple.com
  • 8 edits in trunk/WebCore

Reviewed by Sam Weinig.

  • clean up AnimationBase
  • page/animation/AnimationBase.cpp:
  • page/animation/AnimationBase.h:
  • page/animation/CompositeAnimation.cpp:
  • page/animation/ImplicitAnimation.cpp:
  • page/animation/ImplicitAnimation.h:
  • page/animation/KeyframeAnimation.cpp:
  • page/animation/KeyframeAnimation.h:
11:19 AM Changeset in webkit [36321] by mitz@apple.com
  • 17 edits in trunk/WebCore

Revert erroneous checkin

11:17 AM Changeset in webkit [36320] by mitz@apple.com
  • 15 edits in trunk/WebCore

Reviewed by Sam Weinig.

  • clean up AnimationBase
  • page/animation/AnimationBase.cpp:
  • page/animation/AnimationBase.h:
  • page/animation/CompositeAnimation.cpp:
  • page/animation/ImplicitAnimation.cpp:
  • page/animation/ImplicitAnimation.h:
  • page/animation/KeyframeAnimation.cpp:
  • page/animation/KeyframeAnimation.h:
9:42 AM Changeset in webkit [36319] by ap@webkit.org
  • 4 edits
    15 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=20741
REGRESSION: ISO-8859-8-I encoding is registered incorrectly

Turns out that there were no real behavior changes for 8859-8, as it was only a debug-only
check to ignore this specific registration that was failing. Yet, I decided to add a bunch of
tests for ISO-8859-8 encoding aliases, as we handle them in a quite complicated manner.

I also found and fixed a potential crasher for non-Mac ports.

Tests: fast/encoding/hebrew/8859-8-e.html

fast/encoding/hebrew/8859-8-i.html
fast/encoding/hebrew/8859-8.html
fast/encoding/hebrew/csISO88598I.html
fast/encoding/hebrew/hebrew.html
fast/encoding/hebrew/iso-ir-138.html
fast/encoding/hebrew/logical.html

  • platform/text/TextEncodingRegistry.cpp: (WebCore::checkExistingName): Check for iso-8859-8 (case-insensitively, because different versions of ICU report this MIME name in different case).
  • platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::registerExtendedEncodingNames): Updated some comments. (WebCore::TextCodecICU::registerExtendedCodecs): Try both MIME and IANA names here, too. There are four names in ICU that only have MIME names (x-mac-* ones), so we could end up with an encoding map entry, but no codec for these. This was not an issue on the Mac, as we also support these via TEC (which we should stop doing), but on Windows, this would likely crash.
3:15 AM Changeset in webkit [36318] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-09-10 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Not reviewed.

Mac build fix.

2:23 AM Changeset in webkit [36317] by oliver@apple.com
  • 9 edits in trunk/JavaScriptCore

Add optimised access to known properties on the global object.

Reviewed by Maciej Stachowiak

Improve cross scope access to the global object by emitting
code to access it directly rather than by walking the scope chain.

This is a 0.8% win in SunSpider and a 1.7% win in the v8 benchmarks.

1:42 AM Changeset in webkit [36316] by mjs@apple.com
  • 17 edits in trunk/JavaScriptCore

2008-09-10 Maciej Stachowiak <mjs@apple.com>

Reviewed by Oliver.


  • enable polymorphic inline caching of properties of primitives


1.012x speedup on SunSpider.

We create special structure IDs for JSString and
JSNumberCell. Unlike normal structure IDs, these cannot hold the
true prototype. Due to JS autoboxing semantics, the prototype used
when looking up string or number properties depends on the lexical
global object of the call site, not the creation site. Thus we
enable StructureIDs to handle this quirk for primitives.


Everything else should be straightforward.


  • VM/CTI.cpp: (JSC::CTI::privateCompileGetByIdProto): (JSC::CTI::privateCompileGetByIdChain):
  • VM/CTI.h: (JSC::CTI::compileGetByIdProto): (JSC::CTI::compileGetByIdChain):
  • VM/JSPropertyNameIterator.h: (JSC::JSPropertyNameIterator::JSPropertyNameIterator):
  • VM/Machine.cpp: (JSC::Machine::Machine): (JSC::cachePrototypeChain): (JSC::Machine::tryCachePutByID): (JSC::Machine::tryCacheGetByID): (JSC::Machine::privateExecute): (JSC::Machine::tryCTICachePutByID): (JSC::Machine::tryCTICacheGetByID):
  • kjs/GetterSetter.h: (JSC::GetterSetter::GetterSetter):
  • kjs/JSCell.h:
  • kjs/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
  • kjs/JSGlobalData.h:
  • kjs/JSGlobalObject.h: (JSC::StructureID::prototypeForLookup):
  • kjs/JSNumberCell.h: (JSC::JSNumberCell::JSNumberCell): (JSC::jsNumberCell):
  • kjs/JSObject.h: (JSC::JSObject::prototype):
  • kjs/JSString.cpp: (JSC::jsString): (JSC::jsSubstring): (JSC::jsOwnedString):
  • kjs/JSString.h: (JSC::JSString::JSString): (JSC::JSString::): (JSC::jsSingleCharacterString): (JSC::jsSingleCharacterSubstring): (JSC::jsNontrivialString):
  • kjs/SmallStrings.cpp: (JSC::SmallStrings::createEmptyString): (JSC::SmallStrings::createSingleCharacterString):
  • kjs/StructureID.cpp: (JSC::StructureID::StructureID): (JSC::StructureID::addPropertyTransition): (JSC::StructureID::getterSetterTransition): (JSC::StructureIDChain::StructureIDChain):
  • kjs/StructureID.h: (JSC::StructureID::create): (JSC::StructureID::storedPrototype):
1:09 AM Changeset in webkit [36315] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2008-09-09 Joerg Bornemann <joerg.bornemann@trolltech.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=20746

Added WINCE platform macro.

  • wtf/Platform.h:
12:03 AM Changeset in webkit [36314] by weinig@apple.com
  • 5 edits in trunk/JavaScriptCore

2008-09-09 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Remove unnecessary override of getOffset.

Sunspider reports this as a .6% progression.

  • JavaScriptCore.exp:
  • kjs/JSObject.h: (JSC::JSObject::getDirectLocation): (JSC::JSObject::getOwnPropertySlotForWrite): (JSC::JSObject::putDirect):
  • kjs/PropertyMap.cpp:
  • kjs/PropertyMap.h:
Note: See TracTimeline for information about the timeline view.