Context Navigation

← Previous Period
Next Period →

Timeline

Sep 12, 2008:

9:57 PM Changeset in webkit [36368] by cwzwarich@webkit.org

9 edits in trunk/JavaScriptCore

2008-09-12 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Maciej Stachowiak.

Bug 20819: JSValue::isObject() is slow
<https://bugs.webkit.org/show_bug.cgi?id=20819>

Optimize JSCell::isObject() and JSCell::isString() by making them
non-virtual calls that rely on the StructureID type information.

This is a 0.7% speedup on SunSpider and a 1.0% speedup on the V8
benchmark suite.

JavaScriptCore.exp:
kjs/JSCell.cpp:
kjs/JSCell.h: (JSC::JSCell::isObject): (JSC::JSCell::isString):
kjs/JSObject.cpp:
kjs/JSObject.h:
kjs/JSString.cpp:
kjs/JSString.h: (JSC::JSString::JSString):
kjs/StructureID.h: (JSC::StructureID::type):

7:59 PM Changeset in webkit [36367] by sfalken@apple.com

2 edits in trunk/WebCore

Fix Mac build.

css/CSSStyleSelector.cpp: (WebCore::getTransformOperationType):

6:10 PM Changeset in webkit [36366] by hyatt@apple.com

1 edit in trunk/WebCore/css/CSSStyleSelector.cpp

Fix Windows build bustage.

5:47 PM Changeset in webkit [36365] by dino@apple.com

1 edit in trunk/LayoutTests/ChangeLog

Cleaning up LayoutTests/ChangeLog.

5:45 PM Changeset in webkit [36364] by dino@apple.com

1 edit in trunk/WebCore/ChangeLog

Cleaning up WebCore/ChangeLog

5:41 PM Changeset in webkit [36363] by mrowe@apple.com

15 edits
5 deletes in trunk

Roll out r36360 as it broke all non-Mac builds.

5:33 PM Changeset in webkit [36362] by dino@apple.com

13 edits in trunk

2008-09-12 Chris Marrin <cmarrin@apple.com>

Reviewed by Dave Hyatt.

Make transform animation behavior match spec
https://bugs.webkit.org/show_bug.cgi?id=20770

Tests: transitions/transform-op-list-match.html

transitions/transform-op-list-no-match.html

css/CSSStyleSelector.cpp:
css/CSSStyleSelector.h:
page/animation/AnimationBase.cpp:
page/animation/AnimationBase.h:
page/animation/ImplicitAnimation.cpp:
page/animation/ImplicitAnimation.h:
page/animation/KeyframeAnimation.cpp:
page/animation/KeyframeAnimation.h:
rendering/RenderLayer.cpp:
rendering/style/RenderStyle.cpp:
rendering/style/RenderStyle.h:

4:30 PM Changeset in webkit [36361] by sullivan@apple.com

2 edits in trunk/WebKit/mac

2008-09-12 John Sullivan <sullivan@apple.com>

Fixed <rdar://problem/6110941> Clicking the print button in PDF content does nothing

Reviewed by Darin Adler

WebView/WebPDFView.mm: (-[WebPDFView PDFViewPerformPrint:]): Implemented PDFKit delegate method that's called after a Print action in the PDF content

4:27 PM Changeset in webkit [36360] by Chris Fleizach

15 edits
5 adds in trunk

<rdar://problem/4003789> Expose lists as AXList
<rdar://problem/5707399> VO: Definition lists not announced in Safari

Exposes <ol>, <ul> and <dl> lists as AXLists through accessibility

3:43 PM Changeset in webkit [36359] by timothy@apple.com

4 edits
1 add in trunk/WebCore

Properly escape contents of links added to the inspector.
For now, just build the link with the DOM and get the
outerHTML. Eventually, we probably just want to do
this entirely with the DOM.

Reviewed by Timothy Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=20684

manual-tests/inspector/escape-links.html: Added.
page/inspector/StylesSidebarPane.js:
page/inspector/inspector.js:
page/inspector/utilities.js:

3:14 PM Changeset in webkit [36358] by adele@apple.com

2 edits in trunk/WebCore

2008-09-12 Adele Peterson <adele@apple.com>

Reviewed by John Sullivan and Kevin McCullough.

Fix for <rdar://problem/6216951> REGRESSION (r36000?): Crash due to infinite recursion into EventHandler::hitTestResultAtPoint() with disconnected frames

page/EventHandler.cpp: (WebCore::EventHandler::hitTestResultAtPoint): Hit testing again on the main frame will only work if we aren't already on the main frame. If we are already on the main frame, that will cause infinite recursion. This change checks that we're not already on the main frame before hit testing again.

3:08 PM Changeset in webkit [36357] by kmccullough@apple.com

5 edits in trunk

WebCore:

2008-09-12 Kevin McCullough <kmccullough@apple.com>

RS by Tim .

Re-introducing the code since it was not the cause of the crash.
See r36343.

rendering/RenderObject.cpp: (WebCore::RenderObject::canBeProgramaticallyScrolled):
rendering/RenderObject.h:

LayoutTests:

2008-09-12 Kevin McCullough <kmccullough@apple.com>

RS by Tim.

Re-introducing the code since it was not the cause of the crash.
See r36343.

fast/events/autoscroll-with-non-scrollable-parent.html:

2:54 PM Changeset in webkit [36356] by dino@apple.com

7 edits
2 adds in trunk

2008-09-12 Chris Marrin <cmarrin@apple.com>

Reviewed by Dave Hyatt.

When changing one animation in a list, don't reset other animations
https://bugs.webkit.org/show_bug.cgi?id=20675

Test: animations/change-one-anim.html

page/animation/AnimationBase.cpp: (WebCore::AnimationBase::getNumProperties):
page/animation/AnimationBase.h:
page/animation/AnimationController.cpp:
page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateKeyframeAnimations):
page/animation/CompositeAnimation.h:
page/animation/ImplicitAnimation.cpp:
page/animation/KeyframeAnimation.cpp:
page/animation/KeyframeAnimation.h: (WebCore::KeyframeAnimation::setIndex):

2:43 PM Changeset in webkit [36355] by hyatt@apple.com

1 edit in trunk/WebCore/platform/gtk/ScrollViewGtk.cpp

Fix Gtk build bustage.

2:42 PM Changeset in webkit [36354] by hyatt@apple.com

1 edit in trunk/WebCore/platform/qt/ScrollViewQt.cpp

Fix Qtbuild bustage.

11:47 AM ProposedWebInspectorRearchitecting edited by ojan@chromium.org

(diff)

11:40 AM Changeset in webkit [36353] by beidson@apple.com

2 edits in trunk/WebCore

2008-09-12 Brady Eidson <beidson@apple.com>

Reviewed by Mitz Pettel

Fix the ASSERT and failure in webarchive/archive-empty-frame-source.html

loader/DocumentLoader.cpp: (WebCore::DocumentLoader::mainResource): Further restoration of original WebArchive behavior. Subresources can never be created from nil data, but there is always a MainResource, whether or not there's any data. So in the case where the main resource has no data, fake it for the sake of creating the ArchiveResource.

11:39 AM ProposedWebInspectorRearchitecting edited by ojan@chromium.org

(diff)

11:37 AM Changeset in webkit [36352] by hyatt@apple.com

10 edits in trunk/WebCore

Make Scrollbar derive from Widget. Remove isWidget guards on Scrollbars.

11:22 AM Changeset in webkit [36351] by mitz@apple.com

9 edits in trunk/WebCore

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=20793 clean up page/animation

page/animation/AnimationController.cpp:
page/animation/AnimationController.h:
page/animation/CompositeAnimation.cpp:
page/animation/CompositeAnimation.h:
page/animation/ImplicitAnimation.cpp:
page/animation/ImplicitAnimation.h:
page/animation/KeyframeAnimation.cpp:
page/animation/KeyframeAnimation.h:

10:58 AM Changeset in webkit [36350] by mitz@apple.com

2 edits in trunk/WebKit/mac

Reviewed by John Sullivan.

fix a crash in -visibleRect when it is called during WebFrameView deallocation

WebView/WebFrameView.mm: (-[WebFrameView visibleRect]): Added an early return if _private is 0.

Sep 11, 2008:

9:44 PM Changeset in webkit [36349] by timothy@apple.com

5 edits in trunk/WebCore

Add a renderedImage method to DOMNode to get an image
of the rendering for the node and it's descendants.

<rdar://problem/5849349> Would like API to create
an image for a DOM node

Reviewed by Oliver Hunt.

bindings/objc/DOM.mm: (-[DOMNode renderedImage]): Call Frame::nodeImage.
bindings/objc/DOMPrivate.h:
page/Frame.h:
page/mac/FrameMac.mm: (WebCore::Frame::nodeImage):

6:25 PM Changeset in webkit [36348] by dino@apple.com

3 edits in trunk/LayoutTests

2008-09-11 Dean Jackson <dino@apple.com>

Unfortunately the fix for
https://bugs.webkit.org/show_bug.cgi?id=20680
didn't update the relevant test

css3/keyframes-rule-expected.txt:
css3/keyframes-rule.html:

5:36 PM Changeset in webkit [36347] by dino@apple.com

11 edits
2 adds in trunk

2008-09-08 Chris Marrin <cmarrin@apple.com>

Reviewed by Dave Hyatt

Need to support comma separated list of key times in keyframes selectors
https://bugs.webkit.org/show_bug.cgi?id=20680

Test: animations/keyframes-comma-separated.html

css/CSSGrammar.y:
css/CSSParser.cpp: (WebCore::CSSParser::createKeyframeRule):
css/CSSParser.h:
css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::addKeyframeStyle):
css/WebKitCSSKeyframeRule.cpp: (WebCore::WebKitCSSKeyframeRule::WebKitCSSKeyframeRule): (WebCore::WebKitCSSKeyframeRule::cssText): (WebCore::WebKitCSSKeyframeRule::parseKeyString):
css/WebKitCSSKeyframeRule.h: (WebCore::WebKitCSSKeyframeRule::keyText): (WebCore::WebKitCSSKeyframeRule::setKeyText): (WebCore::WebKitCSSKeyframeRule::getKeys):
css/WebKitCSSKeyframesRule.cpp: (WebCore::WebKitCSSKeyframesRule::append): (WebCore::WebKitCSSKeyframesRule::insertRule): (WebCore::WebKitCSSKeyframesRule::deleteRule): (WebCore::WebKitCSSKeyframesRule::findRule): (WebCore::WebKitCSSKeyframesRule::findRuleIndex):
css/WebKitCSSKeyframesRule.h:
page/animation/AnimationBase.cpp: (WebCore::AnimationBase::blendProperties):

5:24 PM Changeset in webkit [36346] by mrowe@apple.com

4 edits in tags/Safari-6528.3.1

Versioning.

5:24 PM Changeset in webkit [36345] by mrowe@apple.com

2 edits in tags/Safari-6528.3.1/JavaScriptCore

Merge r36292.

5:15 PM Changeset in webkit [36344] by mrowe@apple.com

1 copy in tags/Safari-6528.3.1

New tag.

3:57 PM Changeset in webkit [36343] by kmccullough@apple.com

5 edits in trunk

WebCore:

2008-09-11 Kevin McCullough <kmccullough@apple.com>

RS by Tim.

Reverting because this caused a crash.

rendering/RenderObject.cpp: (WebCore::RenderObject::canBeProgramaticallyScrolled): (WebCore::RenderObject::hasScrollableView):
rendering/RenderObject.h:

LayoutTests:

2008-09-11 Kevin McCullough <kmccullough@apple.com>

RS = Tim.

Reverted because this caused a crash.

fast/events/autoscroll-with-non-scrollable-parent.html:

3:32 PM Changeset in webkit [36342] by Stephanie Lewis

2 edits in trunk/JavaScriptCore

2008-09-11 Stephanie Lewis <Stephanie Lewis>

Reviewed by Oliver Hunt.

Turn off PGO Optimization on CTI.cpp -> <rdar://problem/6207709>. Fixes
crash on CNN and on Dromaeo.
Fix Missing close tag in vcproj.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

2:59 PM Changeset in webkit [36341] by dino@apple.com

3 edits
2 adds in trunk

2008-09-11 Dean Jackson <dino@apple.com>

Reviewed by Dan Bernstein.

Fix assertion on transition property "none"
https://bugs.webkit.org/show_bug.cgi?id=20751

Test: transitions/transition-end-event-set-none.html

page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions):

2:54 PM Changeset in webkit [36340] by dsmith@webkit.org

1 edit
1 delete in trunk/WebCore

2008-09-11 David Smith <catfish.man@gmail.com>

Rubber-stamped by mitzpettel.

Remove an accidentally added extra file.

WebCore: Removed.

2:41 PM Changeset in webkit [36339] by dsmith@webkit.org

13 edits
4 adds in trunk/WebCore

2008-09-11 David Smith <catfish.man@gmail.com>

Reviewed by Darin

https://bugs.webkit.org/show_bug.cgi?id=20180

This speeds up :nth-child matching as tested by querySelectorAll by around 10% by inlining the common case of Node::renderStyle(). Many thanks to mitzpettel and othermaciej for suggestions and help.

WebCore.xcodeproj/project.pbxproj: Add NodeRenderStyle.h
css/CSSStyleSelector.cpp: include NodeRenderStyle.h
dom/Element.cpp: include NodeRenderStyle.h
dom/Node.cpp: Remove the definition of renderStyle() (WebCore::Node::nonRendererRenderStyle):
dom/Node.h: Make renderStyle() nonvirtual and add nonRendererRenderStyle()
dom/NodeRenderStyle.h: Added. (WebCore::Node::renderStyle): Inline the common case of this, call nonRendererRenderStyle for the part that needed to be virtual
html/HTMLOptGroupElement.cpp: include NodeRenderStyle.h
html/HTMLOptGroupElement.h: (WebCore::HTMLOptGroupElement::nonRendererRenderStyle): override to return m_style
html/HTMLOptionElement.cpp: include NodeRenderStyle.h
html/HTMLOptionElement.h: (WebCore::HTMLOptionElement::nonRendererRenderStyle): override to return m_style
rendering/RenderListBox.cpp: include NodeRenderStyle.h
rendering/RenderMenuList.cpp: include NodeRenderStyle.h
svg/SVGUseElement.cpp: include NodeRenderStyle.h

2:15 PM Changeset in webkit [36338] by cwzwarich@webkit.org

1 edit
2 adds in trunk/JavaScriptCore

2008-09-11 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Not reviewed.

Correct an SVN problem with the last commit and actually add the new
files.

wrec/CharacterClassConstructor.cpp: Added. (JSC::): (JSC::getCharacterClassNewline): (JSC::getCharacterClassDigits): (JSC::getCharacterClassSpaces): (JSC::getCharacterClassWordchar): (JSC::getCharacterClassNondigits): (JSC::getCharacterClassNonspaces): (JSC::getCharacterClassNonwordchar): (JSC::CharacterClassConstructor::addSorted): (JSC::CharacterClassConstructor::addSortedRange): (JSC::CharacterClassConstructor::put): (JSC::CharacterClassConstructor::flush): (JSC::CharacterClassConstructor::append):
wrec/CharacterClassConstructor.h: Added. (JSC::CharacterClassConstructor::CharacterClassConstructor): (JSC::CharacterClassConstructor::isUpsideDown): (JSC::CharacterClassConstructor::charClass):

2:13 PM Changeset in webkit [36337] by cwzwarich@webkit.org

4 edits in trunk/JavaScriptCore

2008-09-11 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Maciej Stachowiak.

Bug 20788: Split CharacterClassConstructor into its own file
<https://bugs.webkit.org/show_bug.cgi?id=20788>

Split CharacterClassConstructor into its own file and clean up some
style issues.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
wrec/CharacterClassConstructor.cpp: Added. (JSC::): (JSC::getCharacterClassNewline): (JSC::getCharacterClassDigits): (JSC::getCharacterClassSpaces): (JSC::getCharacterClassWordchar): (JSC::getCharacterClassNondigits): (JSC::getCharacterClassNonspaces): (JSC::getCharacterClassNonwordchar): (JSC::CharacterClassConstructor::addSorted): (JSC::CharacterClassConstructor::addSortedRange): (JSC::CharacterClassConstructor::put): (JSC::CharacterClassConstructor::flush): (JSC::CharacterClassConstructor::append):
wrec/CharacterClassConstructor.h: Added. (JSC::CharacterClassConstructor::CharacterClassConstructor): (JSC::CharacterClassConstructor::isUpsideDown): (JSC::CharacterClassConstructor::charClass):
wrec/WREC.cpp: (JSC::WRECParser::parseCharacterClass):

1:29 PM Changeset in webkit [36336] by mitz@apple.com

4 edits in trunk/WebKit/mac

Reviewed by John Sullivan.

eliminate excessive repainting when a clipped iframe is moved (noticed in <rdar://problem/6204032>)

WebView/WebFrame.mm: (-[WebFrame _getVisibleRect:]): Added. If the frame is in a RenderPart and has layout, gets the visible rect of the RenderPart and returns YES. Returns NO otherwise.
WebView/WebFrameInternal.h:
WebView/WebFrameView.mm: (-[WebFrameView visibleRect]): Added. Overrides this NSView method to take clipping in the render tree into account.

10:45 AM ProposedWebInspectorRearchitecting edited by ojan@chromium.org