Timeline
Sep 13, 2008:
- 11:23 PM ProposedWebInspectorRearchitecting edited by
- (diff)
- 11:21 PM ProposedWebInspectorRearchitecting edited by
- Further define the message types and callback functions. (diff)
- 10:53 PM ProposedWebInspectorRearchitecting edited by
- Defines some messages for Console. (diff)
- 10:29 PM Changeset in webkit [36400] by
-
- 1 edit in trunk/WebCore/platform/qt/PlatformScrollBar.h
Fix Qt bustage.
- 10:05 PM Changeset in webkit [36399] by
-
- 1 edit in trunk/WebKit/win/WebScrollBar.cpp
Fix Windows bustage.
- 9:53 PM Changeset in webkit [36398] by
-
- 1 edit in trunk/WebCore/platform/mac/PlatformScrollBar.h
Fix Mac build bustage.
- 9:25 PM ProposedWebInspectorRearchitecting edited by
- Define some of the Console API. (diff)
- 6:57 PM Changeset in webkit [36397] by
-
- 3 edits in trunk/WebCore
2008-09-13 Jan Michael Alonzo <jmalonzo@webkit.org>
Gtk build fix, not reviewed.
- platform/gtk/PlatformScrollBarGtk.cpp: (PlatformScrollbar::PlatformScrollbar):
- platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::updateScrollbars):
- 6:26 PM Changeset in webkit [36396] by
-
- 17 edits in trunk/WebCore
Eliminate Scrollbar's setRect method. Clients can now just use the Widget base class method, setFrameGeometry instead.
- 6:06 PM Changeset in webkit [36395] by
-
- 11 edits in trunk/WebCore
Remove setEnabled from all Scrollbar subclasses that were just using their Widget base class methods.
- 5:58 PM Changeset in webkit [36394] by
-
- 10 edits in trunk/WebCore
Remove width()/height() from Scrollbar and subclasses that just need to use the Widget method.
- 5:50 PM Changeset in webkit [36393] by
-
- 1 edit in trunk/WebCore/platform/gtk/PlatformScrollBar.h
Remove now unused methods from GTK scrollbars.
- 5:49 PM Changeset in webkit [36392] by
-
- 1 edit in trunk/WebCore/platform/gtk/PlatformScrollBarGtk.cpp
Remove now unused methods from GTK scrollbars.
- 5:32 PM Changeset in webkit [36391] by
-
- 6 edits in trunk/WebCore
Move stopTimerIfNeeded out of PlatformScrollbar destructors and into Scrollbar's destructor.
- 5:22 PM Changeset in webkit [36390] by
-
- 1 edit in trunk/WebCore/platform/ScrollBar.h
Fix Qt build bustage.
- 4:57 PM Changeset in webkit [36389] by
-
- 3 edits in trunk/WebCore
2008-09-13 David Hyatt <hyatt@apple.com>
Move maximum() from Qt's PlatformScrollbar to be a cross-platform
function on Scrollbar. Fixes Qt build bustage.
Reviewed by Sam Weinig
- platform/ScrollBar.h: (WebCore::Scrollbar::orientation): (WebCore::Scrollbar::value): (WebCore::Scrollbar::maximum):
- platform/qt/PlatformScrollBar.h:
- 4:47 PM Changeset in webkit [36388] by
-
- 2 edits in trunk/WebKit/qt/Api
Fix Qt bustage.
- 4:34 PM Changeset in webkit [36387] by
-
- 1 edit in trunk/WebCore/platform/wx/TemporaryLinkStubs.cpp
Fix wx bustage.
- 4:32 PM Changeset in webkit [36386] by
-
- 1 edit in trunk/WebCore/platform/qt/ScrollbarThemeQt.cpp
Fix Qt bustage.
- 4:21 PM Changeset in webkit [36385] by
-
- 3 edits in trunk/WebCore/platform
Fix Qt, Gtk, and Mac build bustage.
- 4:10 PM Changeset in webkit [36384] by
-
- 1 edit in trunk/WebCore/WebCore.pro
Fix Qt bustage.
- 4:08 PM Changeset in webkit [36383] by
-
- 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj
Fix Mac bustage.
- 4:06 PM Changeset in webkit [36382] by
-
- 3 edits4 adds in trunk
WebCore:
Reviewed by Sam Weinig.
- use the LastResort font for missing glyphs instead of showing the primary font's missing glyph
Test: platform/mac/fast/text/last-resort-font.html
- platform/graphics/mac/FontCacheMac.mm: (WebCore::FontCache::getFontDataForCharacters): Changed to return the last resort font if a substitute font cannot be found. (WebCore::FontCache::getLastResortFallbackFont): Removed an outdated comment (the user's preferred standard font is included in the search thanks to code in FontCache::getFontData()) and changed to return the LastResort font.
LayoutTests:
Reviewed by Sam Weinig.
- test that the LastResort font is used for missing glyphs rather than the primary font's missing glyph
- platform/mac/fast/text/last-resort-font-expected.checksum: Added.
- platform/mac/fast/text/last-resort-font-expected.png: Added.
- platform/mac/fast/text/last-resort-font-expected.txt: Added.
- platform/mac/fast/text/last-resort-font.html: Added.
- 3:59 PM Changeset in webkit [36381] by
-
- 2 edits in trunk/WebKit/win
Add ScrollbarTheme to control scrollbar metrics (and eventually hit testing and rendering.
- 3:59 PM Changeset in webkit [36380] by
-
- 16 edits11 adds in trunk/WebCore
Add ScrollbarTheme to control scrollbar metrics (and eventually hit testing and rendering.
- 2:30 PM Changeset in webkit [36379] by
-
- 2 edits in trunk/WebKit/gtk
2008-09-13 Adrien Nader <camaradetux@gmail.com>
Gtk build fix, not reviewed.
- webkit/webkitwebview.cpp:
- 2:05 PM Changeset in webkit [36378] by
-
- 20 edits in trunk
<rdar://problem/5060439> Web elements should have an AXTopLevelUIElement
expose AXTopLevelUIElement as an attribute
- 1:51 PM Changeset in webkit [36377] by
-
- 2 edits in trunk/WebKit/qt/Api
Fix Qt build bustage.
- 1:37 PM Changeset in webkit [36376] by
-
- 1 edit in trunk/WebCore/platform/wx/ScrollViewWx.cpp
Fix wx build bustage.
- 1:33 PM Changeset in webkit [36375] by
-
- 1 edit in trunk/WebCore/platform/qt/PlatformScrollBarQt.cpp
Fix Qt build bustage.
- 1:27 PM Changeset in webkit [36374] by
-
- 2 edits in trunk/WebCore
Reviewed by Timothy Hatcher.
- fix <rdar://problem/6171280> REGRESSION (r35667): Assertion failure in WebCore::FrameView::scheduleRelayout() when releasing a page with counters from the b/f cache
No regression test because the back/forward cache is disabled in DumpRenderTree
- rendering/RenderContainer.cpp: (WebCore::RenderContainer::invalidateCounters): Bail out if the document is being destroyed.
- 12:14 PM Changeset in webkit [36373] by
-
- 3 edits in trunk/WebCore
Fix Mac build bustage.
- 11:52 AM Changeset in webkit [36372] by
-
- 2 edits in trunk/WebCore/platform
Fix Qt build bustage.
- 11:48 AM Changeset in webkit [36371] by
-
- 3 edits in trunk/WebCore
wx build fixes for new methods recently introduced.
- 11:41 AM Changeset in webkit [36370] by
-
- 2 edits in trunk/WebKit/win
more scrollbar refactoring.
- 11:39 AM Changeset in webkit [36369] by
-
- 29 edits1 add in trunk/WebCore
More scrollbar refactoring.
Sep 12, 2008:
- 9:57 PM Changeset in webkit [36368] by
-
- 9 edits in trunk/JavaScriptCore
2008-09-12 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Maciej Stachowiak.
Bug 20819: JSValue::isObject() is slow
<https://bugs.webkit.org/show_bug.cgi?id=20819>
Optimize JSCell::isObject() and JSCell::isString() by making them
non-virtual calls that rely on the StructureID type information.
This is a 0.7% speedup on SunSpider and a 1.0% speedup on the V8
benchmark suite.
- JavaScriptCore.exp:
- kjs/JSCell.cpp:
- kjs/JSCell.h: (JSC::JSCell::isObject): (JSC::JSCell::isString):
- kjs/JSObject.cpp:
- kjs/JSObject.h:
- kjs/JSString.cpp:
- kjs/JSString.h: (JSC::JSString::JSString):
- kjs/StructureID.h: (JSC::StructureID::type):
- 7:59 PM Changeset in webkit [36367] by
-
- 2 edits in trunk/WebCore
Fix Mac build.
- css/CSSStyleSelector.cpp: (WebCore::getTransformOperationType):
- 6:10 PM Changeset in webkit [36366] by
-
- 1 edit in trunk/WebCore/css/CSSStyleSelector.cpp
Fix Windows build bustage.
- 5:47 PM Changeset in webkit [36365] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Cleaning up LayoutTests/ChangeLog.
- 5:45 PM Changeset in webkit [36364] by
-
- 1 edit in trunk/WebCore/ChangeLog
Cleaning up WebCore/ChangeLog
- 5:41 PM Changeset in webkit [36363] by
-
- 15 edits5 deletes in trunk
Roll out r36360 as it broke all non-Mac builds.
- 5:33 PM Changeset in webkit [36362] by
-
- 13 edits in trunk
2008-09-12 Chris Marrin <cmarrin@apple.com>
Reviewed by Dave Hyatt.
Make transform animation behavior match spec
https://bugs.webkit.org/show_bug.cgi?id=20770
Tests: transitions/transform-op-list-match.html
transitions/transform-op-list-no-match.html
- css/CSSStyleSelector.cpp:
- css/CSSStyleSelector.h:
- page/animation/AnimationBase.cpp:
- page/animation/AnimationBase.h:
- page/animation/ImplicitAnimation.cpp:
- page/animation/ImplicitAnimation.h:
- page/animation/KeyframeAnimation.cpp:
- page/animation/KeyframeAnimation.h:
- rendering/RenderLayer.cpp:
- rendering/style/RenderStyle.cpp:
- rendering/style/RenderStyle.h:
- 4:30 PM Changeset in webkit [36361] by
-
- 2 edits in trunk/WebKit/mac
2008-09-12 John Sullivan <sullivan@apple.com>
Fixed <rdar://problem/6110941> Clicking the print button in PDF content does nothing
Reviewed by Darin Adler
- WebView/WebPDFView.mm: (-[WebPDFView PDFViewPerformPrint:]): Implemented PDFKit delegate method that's called after a Print action in the PDF content
- 4:27 PM Changeset in webkit [36360] by
-
- 15 edits5 adds in trunk
<rdar://problem/4003789> Expose lists as AXList
<rdar://problem/5707399> VO: Definition lists not announced in Safari
Exposes <ol>, <ul> and <dl> lists as AXLists through accessibility
- 3:43 PM Changeset in webkit [36359] by
-
- 4 edits1 add in trunk/WebCore
Properly escape contents of links added to the inspector.
For now, just build the link with the DOM and get the
outerHTML. Eventually, we probably just want to do
this entirely with the DOM.
Reviewed by Timothy Hatcher.
- manual-tests/inspector/escape-links.html: Added.
- page/inspector/StylesSidebarPane.js:
- page/inspector/inspector.js:
- page/inspector/utilities.js:
- 3:14 PM Changeset in webkit [36358] by
-
- 2 edits in trunk/WebCore
2008-09-12 Adele Peterson <adele@apple.com>
Reviewed by John Sullivan and Kevin McCullough.
Fix for <rdar://problem/6216951> REGRESSION (r36000?): Crash due to infinite recursion into EventHandler::hitTestResultAtPoint() with disconnected frames
- page/EventHandler.cpp: (WebCore::EventHandler::hitTestResultAtPoint): Hit testing again on the main frame will only work if we aren't already on the main frame. If we are already on the main frame, that will cause infinite recursion. This change checks that we're not already on the main frame before hit testing again.
- 3:08 PM Changeset in webkit [36357] by
-
- 5 edits in trunk
WebCore:
2008-09-12 Kevin McCullough <kmccullough@apple.com>
RS by Tim .
Re-introducing the code since it was not the cause of the crash.
See r36343.
- rendering/RenderObject.cpp: (WebCore::RenderObject::canBeProgramaticallyScrolled):
- rendering/RenderObject.h:
LayoutTests:
2008-09-12 Kevin McCullough <kmccullough@apple.com>
RS by Tim.
Re-introducing the code since it was not the cause of the crash.
See r36343.
- fast/events/autoscroll-with-non-scrollable-parent.html:
- 2:54 PM Changeset in webkit [36356] by
-
- 7 edits2 adds in trunk
2008-09-12 Chris Marrin <cmarrin@apple.com>
Reviewed by Dave Hyatt.
When changing one animation in a list, don't reset other animations
https://bugs.webkit.org/show_bug.cgi?id=20675
Test: animations/change-one-anim.html
- page/animation/AnimationBase.cpp: (WebCore::AnimationBase::getNumProperties):
- page/animation/AnimationBase.h:
- page/animation/AnimationController.cpp:
- page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateKeyframeAnimations):
- page/animation/CompositeAnimation.h:
- page/animation/ImplicitAnimation.cpp:
- page/animation/KeyframeAnimation.cpp:
- page/animation/KeyframeAnimation.h: (WebCore::KeyframeAnimation::setIndex):
- 2:43 PM Changeset in webkit [36355] by
-
- 1 edit in trunk/WebCore/platform/gtk/ScrollViewGtk.cpp
Fix Gtk build bustage.
- 2:42 PM Changeset in webkit [36354] by
-
- 1 edit in trunk/WebCore/platform/qt/ScrollViewQt.cpp
Fix Qtbuild bustage.
- 11:47 AM ProposedWebInspectorRearchitecting edited by
- (diff)
- 11:40 AM Changeset in webkit [36353] by
-
- 2 edits in trunk/WebCore
2008-09-12 Brady Eidson <beidson@apple.com>
Reviewed by Mitz Pettel
Fix the ASSERT and failure in webarchive/archive-empty-frame-source.html
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::mainResource): Further restoration of original WebArchive behavior. Subresources can never be created from nil data, but there is always a MainResource, whether or not there's any data. So in the case where the main resource has no data, fake it for the sake of creating the ArchiveResource.
- 11:39 AM ProposedWebInspectorRearchitecting edited by
- (diff)
- 11:37 AM Changeset in webkit [36352] by
-
- 10 edits in trunk/WebCore
Make Scrollbar derive from Widget. Remove isWidget guards on Scrollbars.
- 11:22 AM Changeset in webkit [36351] by
-
- 9 edits in trunk/WebCore
Reviewed by Sam Weinig.
- https://bugs.webkit.org/show_bug.cgi?id=20793 clean up page/animation
- page/animation/AnimationController.cpp:
- page/animation/AnimationController.h:
- page/animation/CompositeAnimation.cpp:
- page/animation/CompositeAnimation.h:
- page/animation/ImplicitAnimation.cpp:
- page/animation/ImplicitAnimation.h:
- page/animation/KeyframeAnimation.cpp:
- page/animation/KeyframeAnimation.h:
- 10:58 AM Changeset in webkit [36350] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by John Sullivan.
- fix a crash in -visibleRect when it is called during WebFrameView deallocation
- WebView/WebFrameView.mm: (-[WebFrameView visibleRect]): Added an early return if _private is 0.