⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 14, 2008:

11:33 PM Changeset in webkit [36428] by hyatt@apple.com
  • 11 edits in trunk/WebCore

Refactor painting of the native windows scrollbar and prepare for code sharing with the Aqua windows scrollbar.

11:26 PM Changeset in webkit [36427] by mjs@apple.com
  • 4 edits in trunk/JavaScriptCore

2008-09-14 Maciej Stachowiak <mjs@apple.com>

Reviewed by Cameron Zwarich.


  • speed up JS construction by extracting "prototype" lookup so PIC applies.


~0.5% speedup on SunSpider
Speeds up some of the V8 tests as well, most notably earley-boyer.

  • VM/CTI.cpp: (JSC::CTI::compileOpCall): Account for extra arg for prototype. (JSC::CTI::privateCompileMainPass): Account for increased size of op_construct.
  • VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitConstruct): Emit separate lookup to get prototype property.
  • VM/Machine.cpp: (JSC::Machine::privateExecute): Expect prototype arg in op_construct. (JSC::Machine::cti_op_construct_JSConstruct): ditto (JSC::Machine::cti_op_construct_NotJSConstruct): ditto
10:38 PM Changeset in webkit [36426] by timothy@apple.com
  • 3 edits in trunk/WebCore

Moving all resource graphs under the same container for future scalable feature.
This is a speedup on resize but maybe a loss on changing the sorting function.

https://bugs.webkit.org/show_bug.cgi?id=20555

Reviewed by Timothy Hatcher.

  • page/inspector/ResourcesPanel.js: Added a container for all resource graphs. Added WebInspector.ResourceGraph. No more _updateGraphBars on resize.
  • page/inspector/inspector.css: Edited corresponding rules and removed unnecessaries.
10:05 PM Changeset in webkit [36425] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Reviewed by Eric Seidel.

Add a protected destructor for RefCounted.

It is wrong to call its destructor directly, because (1) this should be taken care of by
deref(), and (2) many classes that use RefCounted have non-virtual destructors.

No change in behavior.

  • wtf/RefCounted.h: (WTF::RefCounted::~RefCounted):
10:00 PM Changeset in webkit [36424] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/qt/ScrollbarThemeQt.cpp

Fix Qt bustage.

9:52 PM Changeset in webkit [36423] by ap@webkit.org
  • 4 edits
    2 adds in trunk

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=20738
compareBoundaryPoints gives incorrect results

Test: fast/dom/Range/compareBoundaryPoints-2.html

  • dom/Range.cpp: (WebCore::Range::compareBoundaryPoints): Correct meanings of START_TO_END and END_TO_START.
  • page/DOMSelection.cpp: (WebCore::DOMSelection::addRange): Updated for this change.
8:10 PM Changeset in webkit [36422] by mjs@apple.com
  • 2 edits in trunk/WebCore

2008-09-14 Maciej Stachowiak <mjs@apple.com>

Unreviewed build fix.

Trying again.

  • bindings/js/JSQuarantinedObjectWrapper.cpp: (WebCore::JSQuarantinedObjectWrapper::hasInstance):
7:55 PM Changeset in webkit [36421] by mjs@apple.com
  • 3 edits in trunk/WebCore

2008-09-14 Maciej Stachowiak <mjs@apple.com>

Unreviewed build fix.

Blind attempt to fix build. Correct parameters for hasInstance.

  • bindings/js/JSQuarantinedObjectWrapper.cpp: (WebCore::JSQuarantinedObjectWrapper::hasInstance):
  • bindings/js/JSQuarantinedObjectWrapper.h:
7:23 PM Changeset in webkit [36420] by mitz@apple.com
  • 3 edits
    4 deletes in trunk

WebCore:

Rubber-stamped by Sam Weinig.

  • platform/graphics/mac/FontCacheMac.mm: (WebCore::FontCache::getFontDataForCharacters): (WebCore::FontCache::getLastResortFallbackFont):

LayoutTests:

Rubber-stamped by Sam Weinig.

  • platform/mac/fast/text/last-resort-font-expected.checksum: Removed.
  • platform/mac/fast/text/last-resort-font-expected.png: Removed.
  • platform/mac/fast/text/last-resort-font-expected.txt: Removed.
  • platform/mac/fast/text/last-resort-font.html: Removed.
7:21 PM Changeset in webkit [36419] by barraclough@apple.com
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Now with all new and improved Changelog in the correct order.

7:18 PM Changeset in webkit [36418] by barraclough@apple.com
  • 8 edits in trunk/JavaScriptCore

2008-09-14 Maciej Stachowiak <mjs@apple.com>

Reviewed by Cameron Zwarich.


  • split the "prototype" lookup for hasInstance into opcode stream so it can be cached


~5% speedup on v8 earley-boyer test

  • API/JSCallbackObject.h: Add a parameter for the pre-looked-up prototype.
  • API/JSCallbackObjectFunctions.h: (JSC::::hasInstance): Ditto.
  • API/JSValueRef.cpp: (JSValueIsInstanceOfConstructor): Look up and pass in prototype.
  • JavaScriptCore.exp:
  • VM/CTI.cpp: (JSC::CTI::privateCompileMainPass): Pass along prototype.
  • VM/CodeBlock.cpp: (JSC::CodeBlock::dump): Print third arg.
  • VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitInstanceOf): Implement this, now that there is a third argument.
  • VM/CodeGenerator.h:
  • VM/Machine.cpp: (JSC::Machine::privateExecute): Pass along the prototype. (JSC::Machine::cti_op_instanceof): ditto
  • kjs/JSObject.cpp: (JSC::JSObject::hasInstance): Expect to get a pre-looked-up prototype.
  • kjs/JSObject.h:
  • kjs/nodes.cpp: (JSC::InstanceOfNode::emitCode): Emit a get_by_id of the prototype property and pass that register to instanceof.
  • kjs/nodes.h:
7:13 PM Changeset in webkit [36417] by mjs@apple.com
  • 14 edits in trunk/JavaScriptCore

2008-09-14 Maciej Stachowiak <mjs@apple.com>

Reviewed by Cameron Zwarich.


  • split the "prototype" lookup for hasInstance into opcode stream so it can be cached


~5% speedup on v8 earley-boyer test

  • API/JSCallbackObject.h: Add a parameter for the pre-looked-up prototype.
  • API/JSCallbackObjectFunctions.h: (JSC::::hasInstance): Ditto.
  • API/JSValueRef.cpp: (JSValueIsInstanceOfConstructor): Look up and pass in prototype.
  • JavaScriptCore.exp:
  • VM/CTI.cpp: (JSC::CTI::privateCompileMainPass): Pass along prototype.
  • VM/CodeBlock.cpp: (JSC::CodeBlock::dump): Print third arg.
  • VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitInstanceOf): Implement this, now that there is a third argument.
  • VM/CodeGenerator.h:
  • VM/Machine.cpp: (JSC::Machine::privateExecute): Pass along the prototype. (JSC::Machine::cti_op_instanceof): ditto
  • kjs/JSObject.cpp: (JSC::JSObject::hasInstance): Expect to get a pre-looked-up prototype.
  • kjs/JSObject.h:
  • kjs/nodes.cpp: (JSC::InstanceOfNode::emitCode): Emit a get_by_id of the prototype property and pass that register to instanceof.
  • kjs/nodes.h:
5:56 PM Changeset in webkit [36416] by hyatt@apple.com
  • 4 edits
    2 adds in trunk/WebCore

Add ScrollbarThemeComposite for use by ScrollbarThemeSafari and ScrollbarThemeWin

5:53 PM Changeset in webkit [36415] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/qt/ScrollbarThemeQt.cpp

Fix Qt build bustage.

5:36 PM Changeset in webkit [36414] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/win/ScrollbarThemeSafari.h

Fix Win build bustage.

5:35 PM Changeset in webkit [36413] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-09-14 Gavin Barraclough <barraclough@apple.com>

Reviewed by Sam Weinig.

Remove unnecessary virtual function call from cti_op_call_JSFunction -
~5% on richards, ~2.5% on v8-tests, ~0.5% on sunspider.

  • VM/Machine.cpp: (JSC::Machine::cti_op_call_JSFunction):
5:26 PM Changeset in webkit [36412] by cwzwarich@webkit.org
  • 11 edits
    3 adds in trunk

2008-09-14 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Maciej Stachowiak.

Bug 20827: the 'typeof' operator is slow
<https://bugs.webkit.org/show_bug.cgi?id=20827>

Optimize the 'typeof' operator when its result is compared to a constant
string.

This is a 5.5% speedup on the V8 Earley-Boyer test.

JavaScriptCore:

  • VM/CTI.cpp: (JSC::CTI::privateCompileMainPass):
  • VM/CodeBlock.cpp: (JSC::CodeBlock::dump):
  • VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitEqualityOp):
  • VM/CodeGenerator.h:
  • VM/Machine.cpp: (JSC::jsIsObjectType): (JSC::jsIsFunctionType): (JSC::Machine::privateExecute): (JSC::Machine::cti_op_is_undefined): (JSC::Machine::cti_op_is_boolean): (JSC::Machine::cti_op_is_number): (JSC::Machine::cti_op_is_string): (JSC::Machine::cti_op_is_object): (JSC::Machine::cti_op_is_function):
  • VM/Machine.h:
  • VM/Opcode.h:
  • kjs/nodes.cpp: (JSC::BinaryOpNode::emitCode): (JSC::EqualNode::emitCode): (JSC::StrictEqualNode::emitCode):
  • kjs/nodes.h:

LayoutTests:

  • fast/js/resources/typeof-codegen-crash.js: Added.
  • fast/js/typeof-codegen-crash-expected.txt: Added.
  • fast/js/typeof-codegen-crash.html: Added.
5:20 PM Changeset in webkit [36411] by alp@webkit.org
  • 4 edits in trunk/WebCore

2008-09-14 Alp Toker <alp@nuanti.com>

https://bugs.webkit.org/show_bug.cgi?id=20320
[GTK] A white rectangle is visible behind widgets with rounded corners

Sync bundled gtk2drawing.c to the latest version from Mozilla (coding
style exempt).

Requested by Michael Monreal.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::RenderThemeGtk):
  • platform/gtk/gtk2drawing.c: (moz_gtk_set_widget_name): (ensure_window_widget): (setup_widget_prototype): (ensure_button_arrow_widget): (moz_gtk_get_combo_box_inner_button): (moz_gtk_get_combo_box_button_inner_widgets): (ensure_combo_box_widgets): (moz_gtk_get_combo_box_entry_inner_widgets): (moz_gtk_get_combo_box_entry_arrow): (ensure_combo_box_entry_widgets): (ensure_toolbar_widget): (ensure_tooltip_widget): (ensure_menu_bar_widget): (ensure_menu_bar_item_widget): (ensure_menu_popup_widget): (ensure_menu_item_widget): (ensure_image_menu_item_widget): (ensure_menu_separator_widget): (ensure_check_menu_item_widget): (ensure_tree_header_cell_widget): (ensure_scrolled_window_widget): (moz_gtk_button_paint): (moz_gtk_init): (moz_gtk_button_get_inner_border): (moz_gtk_toggle_paint): (calculate_button_inner_rect): (calculate_arrow_rect): (moz_gtk_scrollbar_button_paint): (moz_gtk_scrollbar_thumb_paint): (moz_gtk_caret_paint): (moz_gtk_entry_paint): (moz_gtk_treeview_paint): (moz_gtk_tree_header_cell_paint): (moz_gtk_combo_box_paint): (moz_gtk_downarrow_paint): (moz_gtk_combo_box_entry_button_paint): (moz_gtk_toolbar_paint): (moz_gtk_tab_scroll_arrow_paint): (moz_gtk_menu_bar_paint): (moz_gtk_menu_item_paint): (moz_gtk_get_widget_border): (moz_gtk_get_combo_box_entry_button_size): (moz_gtk_get_tab_scroll_arrow_size): (moz_gtk_get_downarrow_size): (moz_gtk_images_in_menus): (moz_gtk_widget_paint): (moz_gtk_shutdown):
  • platform/gtk/gtkdrawing.h:
5:12 PM Changeset in webkit [36410] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-09-14 Sam Weinig <sam@webkit.org>

Reviewed by Cameron Zwarich.

Patch for https://bugs.webkit.org/show_bug.cgi?id=20844
Speed up parseInt for numbers

Sunspider reports this as 1.029x as fast overall and 1.37x as fast on string-unpack-code.
No change on the v8 suite.

  • kjs/JSGlobalObjectFunctions.cpp: (JSC::globalFuncParseInt): Don't convert numbers to strings just to convert them back to numbers.
4:55 PM Changeset in webkit [36409] by hyatt@apple.com
  • 17 edits in trunk/WebCore

2008-09-14 David Hyatt <hyatt@apple.com>

Convert Mac, Gtk, wx and Qt over to the new ScrollbarTheme for
painting. Mac and Gtk themes don't do anything and just let the
underlying widget paint. Qt now uses the theme to paint. wx doesn't
do anything yet.

Reviewed by Sam Weinig

  • platform/ScrollBar.cpp: (WebCore::Scrollbar::paint):
  • platform/ScrollBar.h: (WebCore::Scrollbar::value): (WebCore::Scrollbar::visibleSize): (WebCore::Scrollbar::maximum): (WebCore::Scrollbar::lineStep): (WebCore::Scrollbar::pageStep): (WebCore::Scrollbar::pixelStep): (WebCore::Scrollbar::pressedPart): (WebCore::Scrollbar::hoveredPart): (WebCore::Scrollbar::theme):
  • platform/ScrollbarTheme.h: (WebCore::ScrollbarTheme::paint): (WebCore::ScrollbarTheme::scrollbarThickness): (WebCore::ScrollbarTheme::supportsControlTints): (WebCore::ScrollbarTheme::themeChanged):
  • platform/gtk/PlatformScrollBar.h:
  • platform/gtk/PlatformScrollBarGtk.cpp:
  • platform/mac/PlatformScrollBar.h:
  • platform/mac/PlatformScrollBarMac.mm:
  • platform/qt/PlatformScrollBar.h:
  • platform/qt/PlatformScrollBarQt.cpp:
  • platform/qt/ScrollbarThemeQt.cpp: (WebCore::styleOptionSlider):
  • platform/qt/ScrollbarThemeQt.h: (WebCore::ScrollbarThemeQt::paint):
  • platform/win/PlatformScrollBarSafari.cpp: (WebCore::PlatformScrollbar::paint):
  • platform/win/ScrollbarThemeSafari.h: (WebCore::ScrollbarThemeSafari::supportsControlTints):
  • platform/wx/PlatformScrollBar.h:
  • platform/wx/TemporaryLinkStubs.cpp: (PlatformScrollbar::~PlatformScrollbar):
4:01 PM Changeset in webkit [36408] by cwzwarich@webkit.org
  • 7 edits in trunk/JavaScriptCore

2008-09-14 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Oliver Hunt.

Bug 20816: op_lesseq should be optimized
<https://bugs.webkit.org/show_bug.cgi?id=20816>

Add a loop_if_lesseq opcode that is similar to the loop_if_less opcode.

This is a 9.4% speedup on the V8 Crypto benchmark.

  • VM/CTI.cpp: (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases):
  • VM/CodeBlock.cpp: (JSC::CodeBlock::dump):
  • VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitJumpIfTrue):
  • VM/Machine.cpp: (JSC::Machine::privateExecute): (JSC::Machine::cti_op_loop_if_lesseq):
  • VM/Machine.h:
  • VM/Opcode.h:
3:15 PM Changeset in webkit [36407] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-09-14 Sam Weinig <sam@webkit.org>

Qt build fix.

  • platform/qt/PlatformScrollBarQt.cpp:
3:12 PM Changeset in webkit [36406] by weinig@apple.com
  • 12 edits in trunk

JavaScriptCore:

2008-09-14 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Remove extraneous semicolons.

  • kjs/nodes.cpp: (JSC::PrefixResolveNode::emitCode):
  • wtf/FastMalloc.cpp: (WTF::TCMalloc_PageHeap::GrowHeap):

WebCore:

2008-09-14 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Remove extraneous semicolons.

  • bindings/scripts/CodeGeneratorObjC.pm:
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::tokenizeRelAttribute):
  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::charsetAttributeValue): (WebCore::HTMLScriptElement::typeAttributeValue):
  • platform/graphics/qt/GradientQt.cpp: (WebCore::Gradient::platformGradient):
  • platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar):
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::updateScrollbars):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintEllipsisBoxes):
  • svg/SVGPathSegList.cpp: (WebCore::SVGPathSegList::toPathData):
3:00 PM Changeset in webkit [36405] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-09-14 Sam Weinig <sam@webkit.org>

Qt build fix.

  • platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::updateScrollbars):
2:36 PM Changeset in webkit [36404] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-09-14 Sam Weinig <sam@webkit.org>

Qt build fix.

  • platform/qt/PlatformScrollBarQt.cpp: (WebCore::PlatformScrollbar::PlatformScrollbar): (WebCore::PlatformScrollbar::paint):
2:33 AM Changeset in webkit [36403] by mrowe@apple.com
  • 3 edits in trunk/WebKitTools

Build fix.

1:33 AM Changeset in webkit [36402] by weinig@apple.com
  • 5 edits in trunk/JavaScriptCore

2008-09-14 Sam Weinig <sam@webkit.org>

Reviewed by Cameron Zwarich.

Cleanup Sampling code.

  • VM/CTI.cpp: (JSC::CTI::emitCall): (JSC::CTI::privateCompileMainPass):
  • VM/CTI.h: (JSC::CTI::execute):
  • VM/SamplingTool.cpp: (JSC::): (JSC::SamplingTool::run): (JSC::SamplingTool::dump):
  • VM/SamplingTool.h: (JSC::SamplingTool::callingHostFunction):
1:18 AM Changeset in webkit [36401] by oliver@apple.com
  • 13 edits in trunk/JavaScriptCore

Bug 20821: Cache property transitions to speed up object initialization
https://bugs.webkit.org/show_bug.cgi?id=20821

Reviewed by Cameron Zwarich.

Implement a transition cache to improve the performance of new properties
being added to objects. This is extremely beneficial in constructors and
shows up as a 34% improvement on access-binary-trees in SunSpider (0.8%
overall)

Sep 13, 2008:

11:23 PM ProposedWebInspectorRearchitecting edited by timothy@apple.com
(diff)
11:21 PM ProposedWebInspectorRearchitecting edited by timothy@apple.com
Further define the message types and callback functions. (diff)
10:53 PM ProposedWebInspectorRearchitecting edited by timothy@apple.com
Defines some messages for Console. (diff)
10:29 PM Changeset in webkit [36400] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/qt/PlatformScrollBar.h

Fix Qt bustage.

10:05 PM Changeset in webkit [36399] by hyatt@apple.com
  • 1 edit in trunk/WebKit/win/WebScrollBar.cpp

Fix Windows bustage.

9:53 PM Changeset in webkit [36398] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/mac/PlatformScrollBar.h

Fix Mac build bustage.

9:25 PM ProposedWebInspectorRearchitecting edited by timothy@apple.com
Define some of the Console API. (diff)
6:57 PM Changeset in webkit [36397] by jmalonzo@webkit.org
  • 3 edits in trunk/WebCore

2008-09-13 Jan Michael Alonzo <jmalonzo@webkit.org>

Gtk build fix, not reviewed.

  • platform/gtk/PlatformScrollBarGtk.cpp: (PlatformScrollbar::PlatformScrollbar):
  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::updateScrollbars):
6:26 PM Changeset in webkit [36396] by hyatt@apple.com
  • 17 edits in trunk/WebCore

Eliminate Scrollbar's setRect method. Clients can now just use the Widget base class method, setFrameGeometry instead.

6:06 PM Changeset in webkit [36395] by hyatt@apple.com
  • 11 edits in trunk/WebCore

Remove setEnabled from all Scrollbar subclasses that were just using their Widget base class methods.

5:58 PM Changeset in webkit [36394] by hyatt@apple.com
  • 10 edits in trunk/WebCore

Remove width()/height() from Scrollbar and subclasses that just need to use the Widget method.

5:50 PM Changeset in webkit [36393] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/gtk/PlatformScrollBar.h

Remove now unused methods from GTK scrollbars.

5:49 PM Changeset in webkit [36392] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/gtk/PlatformScrollBarGtk.cpp

Remove now unused methods from GTK scrollbars.

5:32 PM Changeset in webkit [36391] by hyatt@apple.com
  • 6 edits in trunk/WebCore

Move stopTimerIfNeeded out of PlatformScrollbar destructors and into Scrollbar's destructor.

5:22 PM Changeset in webkit [36390] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/ScrollBar.h

Fix Qt build bustage.

4:57 PM Changeset in webkit [36389] by hyatt@apple.com
  • 3 edits in trunk/WebCore

2008-09-13 David Hyatt <hyatt@apple.com>

Move maximum() from Qt's PlatformScrollbar to be a cross-platform
function on Scrollbar. Fixes Qt build bustage.

Reviewed by Sam Weinig

  • platform/ScrollBar.h: (WebCore::Scrollbar::orientation): (WebCore::Scrollbar::value): (WebCore::Scrollbar::maximum):
  • platform/qt/PlatformScrollBar.h:
4:47 PM Changeset in webkit [36388] by hyatt@apple.com
  • 2 edits in trunk/WebKit/qt/Api

Fix Qt bustage.

4:34 PM Changeset in webkit [36387] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/wx/TemporaryLinkStubs.cpp

Fix wx bustage.

4:32 PM Changeset in webkit [36386] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/qt/ScrollbarThemeQt.cpp

Fix Qt bustage.

4:21 PM Changeset in webkit [36385] by hyatt@apple.com
  • 3 edits in trunk/WebCore/platform

Fix Qt, Gtk, and Mac build bustage.

4:10 PM Changeset in webkit [36384] by hyatt@apple.com
  • 1 edit in trunk/WebCore/WebCore.pro

Fix Qt bustage.

4:08 PM Changeset in webkit [36383] by hyatt@apple.com
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Fix Mac bustage.

4:06 PM Changeset in webkit [36382] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Sam Weinig.

  • use the LastResort font for missing glyphs instead of showing the primary font's missing glyph

Test: platform/mac/fast/text/last-resort-font.html

  • platform/graphics/mac/FontCacheMac.mm: (WebCore::FontCache::getFontDataForCharacters): Changed to return the last resort font if a substitute font cannot be found. (WebCore::FontCache::getLastResortFallbackFont): Removed an outdated comment (the user's preferred standard font is included in the search thanks to code in FontCache::getFontData()) and changed to return the LastResort font.

LayoutTests:

Reviewed by Sam Weinig.

  • test that the LastResort font is used for missing glyphs rather than the primary font's missing glyph
  • platform/mac/fast/text/last-resort-font-expected.checksum: Added.
  • platform/mac/fast/text/last-resort-font-expected.png: Added.
  • platform/mac/fast/text/last-resort-font-expected.txt: Added.
  • platform/mac/fast/text/last-resort-font.html: Added.
3:59 PM Changeset in webkit [36381] by hyatt@apple.com
  • 2 edits in trunk/WebKit/win

Add ScrollbarTheme to control scrollbar metrics (and eventually hit testing and rendering.

3:59 PM Changeset in webkit [36380] by hyatt@apple.com
  • 16 edits
    11 adds in trunk/WebCore

Add ScrollbarTheme to control scrollbar metrics (and eventually hit testing and rendering.

2:30 PM Changeset in webkit [36379] by jmalonzo@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-09-13 Adrien Nader <camaradetux@gmail.com>

Gtk build fix, not reviewed.

  • webkit/webkitwebview.cpp:
2:05 PM Changeset in webkit [36378] by Chris Fleizach
  • 20 edits in trunk

<rdar://problem/5060439> Web elements should have an AXTopLevelUIElement

expose AXTopLevelUIElement as an attribute

1:51 PM Changeset in webkit [36377] by hyatt@apple.com
  • 2 edits in trunk/WebKit/qt/Api

Fix Qt build bustage.

1:37 PM Changeset in webkit [36376] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/wx/ScrollViewWx.cpp

Fix wx build bustage.

1:33 PM Changeset in webkit [36375] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/qt/PlatformScrollBarQt.cpp

Fix Qt build bustage.

1:27 PM Changeset in webkit [36374] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Timothy Hatcher.

  • fix <rdar://problem/6171280> REGRESSION (r35667): Assertion failure in WebCore::FrameView::scheduleRelayout() when releasing a page with counters from the b/f cache

No regression test because the back/forward cache is disabled in DumpRenderTree

  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::invalidateCounters): Bail out if the document is being destroyed.
12:14 PM Changeset in webkit [36373] by hyatt@apple.com
  • 3 edits in trunk/WebCore

Fix Mac build bustage.

11:52 AM Changeset in webkit [36372] by hyatt@apple.com
  • 2 edits in trunk/WebCore/platform

Fix Qt build bustage.

11:48 AM Changeset in webkit [36371] by kevino@webkit.org
  • 3 edits in trunk/WebCore

wx build fixes for new methods recently introduced.

11:41 AM Changeset in webkit [36370] by hyatt@apple.com
  • 2 edits in trunk/WebKit/win

more scrollbar refactoring.

11:39 AM Changeset in webkit [36369] by hyatt@apple.com
  • 29 edits
    1 add in trunk/WebCore

More scrollbar refactoring.

Note: See TracTimeline for information about the timeline view.