⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 18, 2008:

11:49 PM Changeset in webkit [36662] by Darin Adler
  • 37 edits in trunk

JavaScriptCore:

2008-09-18 Darin Adler <Darin Adler>

Reviewed by Maciej Stachowiak.

  • kjs/lookup.h: Removed things here that were used only in WebCore: cacheGlobalObject, JSC_DEFINE_PROTOTYPE, JSC_DEFINE_PROTOTYPE_WITH_PROTOTYPE, and JSC_IMPLEMENT_PROTOTYPE.

WebCore:

2008-09-18 Darin Adler <Darin Adler>

Reviewed by Maciej Stachowiak.

  • bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::JSCSSStyleDeclaration::customPut): Use setDOMException instead of DOMExceptionTranslator.
  • bindings/js/JSDOMBinding.cpp: (WebCore::getCachedDOMObjectWrapper): Updated function name. (WebCore::cacheDOMObjectWrapper): Ditto. (WebCore::forgetDOMObject): Ditto. (WebCore::getCachedDOMNodeWrapper): Ditto. (WebCore::forgetDOMNode): Ditto. (WebCore::cacheDOMNodeWrapper): Ditto. (WebCore::forgetAllDOMNodesForDocument): Ditto. (WebCore::markDOMNodesForDocument): Ditto. (WebCore::updateDOMNodeDocument): Ditto. (WebCore::getCachedDOMStructure): Added. (WebCore::createDOMStructure): Ditto.
  • bindings/js/JSDOMBinding.h: Get rid of the ScriptInterpreter class and replace the static member functions with non-member functions. Added many other functions for getting at structures, prototypes, wrappers, and creating them. Also moved the cacheGlobalObject function here from JavaScriptCore; eventually I'll remove that once I get rid of the remaining callers. Also removed the DOMExceptionTranslator class.
  • bindings/js/JSDOMWindowBase.h: Added JSDOMStructureMap type, and put one of those maps in each window.
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::markDOMObjectWrapper): Updated for function name change. (WebCore::JSDOMWindow::mark): Added code to mark all the structures in the structure map.
  • bindings/js/JSEventTargetNode.cpp: (WebCore::JSEventTargetNode::JSEventTargetNode): Changed to take a structure instead of a prototype.
  • bindings/js/JSEventTargetNode.h: Ditto.
  • bindings/js/JSHTMLAllCollection.h: (WebCore::JSHTMLAllCollection::JSHTMLAllCollection): Ditto.
  • bindings/js/JSHTMLInputElementBase.cpp: (WebCore::JSHTMLInputElementBase::JSHTMLInputElementBase): Removed use of the JSC_IMPLEMENT_PROTOTYPE macro, and changed to take a structure instead of a prototype.
  • bindings/js/JSHTMLInputElementBase.h: Removed use of the JSC_DEFINE_PROTOTYPE_WITH_PROTOTYPE macro, and changed constructor to take a structure instead of a prototype. Created a dummy prototype class that causes the HTMLInputElement prototype to have the HTMLElement prototype.
  • bindings/scripts/CodeGeneratorJS.pm: Change constructors to take structures instead of prototypes. Changed the prototype self function to use the getDOMPrototype function -- later we can eliminate it and have callers invoke getDOMPrototype directly instead. Updated other functions that have name changes. Added code to generate the createPrototype member function. Changed use of cacheGlobalObject to get it from the WebCore namespace instead of the JSC namespace. Changed cacheDOMObject calls to use getDOMObjectWrapper instead.
  • dom/Document.cpp: (WebCore::Document::~Document): Updated for name change and also removed unnecessary JSLock use -- there's no need to lock around this.
  • dom/Node.cpp: (WebCore::Node::setDocument): Ditto.
  • dom/make_names.pl: Changed to use CREATE_DOM_NODE_WRAPPER macro instead of calling new directly.
  • bindings/js/JSCSSRuleCustom.cpp: (WebCore::toJS): Updated for function name changes and used the CREATE_DOM_OBJECT_WRAPPER macro.
  • bindings/js/JSCSSValueCustom.cpp: (WebCore::toJS): Ditto.
  • bindings/js/JSCanvasPixelArrayCustom.cpp: (WebCore::toJS): Ditto.
  • bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::mark): Ditto. (WebCore::toJS): Ditto.
  • bindings/js/JSElementCustom.cpp: (WebCore::toJSNewlyCreated): Ditto.
  • bindings/js/JSEventCustom.cpp: (WebCore::toJS): Ditto.
  • bindings/js/JSEventTargetBase.cpp: (WebCore::jsEventTargetDispatchEvent): Use setDOMException instead of DOMExceptionTranslator. (WebCore::toJS): Updated for function name changes and used the CREATE_DOM_OBJECT_WRAPPER macro.
  • bindings/js/JSHTMLCollectionCustom.cpp: (WebCore::toJS): Ditto.
  • bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::mark): Ditto. (WebCore::createWrapper): Ditto. (WebCore::toJS): Ditto.
  • bindings/js/JSSVGPathSegCustom.cpp: (WebCore::toJS): Ditto.
  • bindings/js/JSStyleSheetCustom.cpp: (WebCore::toJS): Ditto. (WebCore::JSStyleSheet::mark): Ditto.
  • bindings/js/JSTextCustom.cpp: (WebCore::toJSNewlyCreated): Ditto.
  • bindings/js/JSXMLHttpRequestConstructor.cpp: (WebCore::constructXMLHttpRequest): Ditto.
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::mark): Ditto.
  • bindings/js/JSXMLHttpRequestUploadCustom.cpp: (WebCore::JSXMLHttpRequestUpload::mark): Ditto.
  • bindings/js/JSXSLTProcessorConstructor.cpp: (WebCore::constructXSLTProcessor): Ditto.
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::finishedWithEvent): Ditto.
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::loadRequestAsynchronously): Ditto. (WebCore::XMLHttpRequest::dropProtection): Ditto.

LayoutTests:

2008-09-18 Darin Adler <Darin Adler>

Reviewed by Maciej Stachowiak.

  • platform/mac/fast/dom/wrapper-classes-expected.txt: Update results to reflect correct prototype for CSSStyleRule.
11:48 PM Changeset in webkit [36661] by hyatt@apple.com
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Fix conflict inXCode file.

11:32 PM Changeset in webkit [36660] by Darin Adler
  • 8 edits in trunk/JavaScriptCore

2008-09-18 Darin Adler <Darin Adler>

Reviewed by Maciej Stachowiak.

  • kjs/grammar.y: Get rid of string from the union, and use ident for STRING as well as for IDENT.
  • kjs/lexer.cpp: (JSC::Lexer::lex): Use makeIdentifier instead of makeUString for String.
  • kjs/lexer.h: Remove makeUString.
  • kjs/nodes.h: Changed StringNode to hold an Identifier instead of UString.
  • VM/CodeGenerator.cpp: (JSC::keyForCharacterSwitch): Updated since StringNode now holds an Identifier. (JSC::prepareJumpTableForStringSwitch): Ditto.
  • kjs/nodes.cpp: (JSC::StringNode::emitCode): Ditto. The comment from here is now in the lexer. (JSC::processClauseList): Ditto.
  • kjs/nodes2string.cpp: (JSC::StringNode::streamTo): Ditto.
11:30 PM Changeset in webkit [36659] by hyatt@apple.com
  • 8 edits in trunk/WebCore

2008-09-18 David Hyatt <​hyatt@apple.com>

This patch gets a viewless scrollbar working on Mac. It is turned off
by default. Hit testing works. For now the scrollbar just paints ugly
debug rects in the place of the buttons, track and thumb. It does match
Aqua metrics though.

Reviewed by Sam Weinig

  • WebCore.xcodeproj/project.pbxproj:
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::passMousePressEventToScrollbar):
  • platform/ScrollbarThemeComposite.cpp: (WebCore::ScrollbarThemeComposite::paint): (WebCore::ScrollbarThemeComposite::trackPosition):
  • platform/ScrollbarThemeComposite.h:
  • platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::addChild):
  • platform/mac/ScrollbarThemeMac.cpp: (WebCore::): (WebCore::ScrollbarThemeMac::hasButtons): (WebCore::ScrollbarThemeMac::hasThumb): (WebCore::buttonRepaintRect): (WebCore::ScrollbarThemeMac::backButtonRect): (WebCore::ScrollbarThemeMac::forwardButtonRect): (WebCore::trackRepaintRect): (WebCore::ScrollbarThemeMac::trackRect): (WebCore::ScrollbarThemeMac::minimumThumbLength): (WebCore::ScrollbarThemeMac::shouldCenterOnThumb): (WebCore::ScrollbarThemeMac::paintTrack): (WebCore::ScrollbarThemeMac::paintButton): (WebCore::ScrollbarThemeMac::paintThumb):
  • platform/mac/ScrollbarThemeMac.h: (WebCore::ScrollbarThemeMac::supportsControlTints):
  • platform/qt/ScrollbarThemeQt.cpp: (WebCore::ScrollbarThemeQt::trackPosition):
11:13 PM Changeset in webkit [36658] by collinj@webkit.org
  • 2 edits in trunk/WebCore

2008-09-18 Collin Jackson <​collinj@webkit.org>

Build fix; added missing header file to GNUmakefile.am

  • GNUmakefile.am:
10:54 PM Changeset in webkit [36657] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/mac/ScrollViewMac.mm

Fix Mac release build bustage.

10:53 PM Changeset in webkit [36656] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/mac/ScrollViewMac.mm

Fix Mac release build bustage.

10:52 PM Changeset in webkit [36655] by Darin Adler
  • 2 edits in trunk/WebKitTools

2008-09-18 Darin Adler <Darin Adler>

  • Scripts/do-webcore-rename: More renaming plans.
10:24 PM Changeset in webkit [36654] by collinj@webkit.org
  • 2 edits in trunk/LayoutTests

2008-09-18 Collin Jackson <​collinj@webkit.org>

Reviewed by Antti Koivisto and Mark Rowe.

This is correct expected output for the DNS prefetch control
layout test I just checked in.

  • http/tests/misc/dns-prefetch-control-expected.txt:
9:56 PM Changeset in webkit [36653] by weinig@apple.com
  • 5 edits
    5 moves in trunk/WebCore

2008-09-18 Sam Weinig <​sam@webkit.org>

Reviewed by David "the Hair" Hyatt.

Move DataRef, SVGRenderStyle and SVGRenderStyleDefs in render/style.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/DataRef.h: Removed.
  • rendering/SVGRenderStyle.cpp: Removed.
  • rendering/SVGRenderStyle.h: Removed.
  • rendering/SVGRenderStyleDefs.cpp: Removed.
  • rendering/SVGRenderStyleDefs.h: Removed.
  • rendering/style/DataRef.h: Copied from rendering/DataRef.h.
  • rendering/style/SVGRenderStyle.cpp: Copied from rendering/SVGRenderStyle.cpp.
  • rendering/style/SVGRenderStyle.h: Copied from rendering/SVGRenderStyle.h.
  • rendering/style/SVGRenderStyleDefs.cpp: Copied from rendering/SVGRenderStyleDefs.cpp.
  • rendering/style/SVGRenderStyleDefs.h: Copied from rendering/SVGRenderStyleDefs.h.
9:47 PM Changeset in webkit [36652] by mrowe@apple.com
  • 21 edits in trunk

Clear the main frame's name between tests to get more consistent test results
when running the WebKit tests with --nthly.

Reviewed by Dan Bernstein.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebViewToConsistentStateBeforeTesting):

  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebViewToConsistentStateBeforeTesting):

Add SPI to WebView to allow DRT to clear the main frame's name between tests.

  • Interfaces/IWebViewPrivate.idl:
  • WebView.cpp:

(WebView::clearMainFrameName):

  • WebView.h:

Add SPI to WebView to allow DRT to clear the main frame's name between tests.

  • WebView/WebView.mm:

(-[WebView _clearMainFrameName]):

  • WebView/WebViewPrivate.h:

Add a means of clearing a FrameTree's name.

  • WebCore.base.exp:
  • page/FrameTree.cpp:

(WebCore::FrameTree::clearName):

  • page/FrameTree.h:

Update test results now that frame tree names are cleared between tests.

  • fast/events/onunload-clears-onbeforeunload-expected.txt:
  • fast/events/onunload-expected.txt:
  • fast/events/onunload-not-on-body-expected.txt:
  • fast/events/onunload-window-property-expected.txt:
  • fast/forms/button-state-restore-expected.txt:
  • fast/forms/form-and-frame-interaction-retains-values-expected.txt:
9:30 PM Changeset in webkit [36651] by hyatt@apple.com
  • 4 edits in trunk/WebCore

2008-09-18 David Hyatt <​hyatt@apple.com>

Eliminate addToSuperview from Widget, since it was only called
by ScrollViewMac's addChild method. Just shift the original body
of addToSuperView into addChild.

Reviewed by Sam Weinig

  • platform/Widget.h:
  • platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::addChild):
  • platform/mac/WidgetMac.mm:
9:15 PM Changeset in webkit [36650] by collinj@webkit.org
  • 14 edits
    5 adds in trunk
9:01 PM Changeset in webkit [36649] by hyatt@apple.com
  • 4 edits in trunk/WebCore

2008-09-18 David Hyatt <​hyatt@apple.com>

Eliminate the convertToScreenCoordinate method on Widget, since
ScrollView has redundant methods that already do the same thing.

Reviewed by Sam Weinig

  • editing/mac/SelectionControllerMac.mm: (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
  • platform/Widget.h:
  • platform/mac/WidgetMac.mm: (WebCore::Widget::containingWindow):
8:18 PM Changeset in webkit [36648] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/Scrollbar.cpp

Fix Qt warning.

8:16 PM Changeset in webkit [36647] by hyatt@apple.com
  • 9 edits in trunk/WebCore

2008-09-18 David Hyatt <​hyatt@apple.com>

Move to only one constructor for Widgets. Rename data to m_data and make
it have an #ifdef only for platforms that have platform-specific data (Mac
and Gtk).

Reviewed by Sam Weinig

  • WebCore.base.exp:
  • platform/Widget.cpp: (WebCore::Widget::init):
  • platform/Widget.h:
  • platform/gtk/WidgetGtk.cpp: (WebCore::Widget::Widget): (WebCore::Widget::~Widget): (WebCore::Widget::cursor): (WebCore::Widget::setCursor):
  • platform/mac/WidgetMac.mm: (WebCore::Widget::Widget): (WebCore::Widget::~Widget): (WebCore::Widget::addToSuperview): (WebCore::Widget::removeFromSuperview): (WebCore::Widget::beforeMouseDown): (WebCore::Widget::afterMouseDown):
  • platform/qt/WidgetQt.cpp: (WebCore::Widget::Widget):
  • platform/win/WidgetWin.cpp: (WebCore::Widget::Widget):
  • platform/wx/WidgetWx.cpp: (WebCore::Widget::Widget):
8:04 PM Changeset in webkit [36646] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/Widget.cpp

Fix Qt/Win/Gtk bustage.

8:01 PM Changeset in webkit [36645] by hyatt@apple.com
  • 8 edits in trunk/WebCore

2008-09-18 David Hyatt <​hyatt@apple.com>

Move Qt's isNPAPIPlugin boolean from Widget down to PluginView, since there
was no reason for it to be on Widget. This change eliminates Qt ifdefs
from Widget.

Reviewed by Sam Weinig

  • bindings/js/ScriptControllerQt.cpp: (WebCore::ScriptController::createScriptInstanceForWidget):
  • platform/qt/WidgetQt.cpp: (WebCore::WidgetPrivate::WidgetPrivate): (WebCore::WidgetPrivate::~WidgetPrivate): (WebCore::Widget::Widget): (WebCore::Widget::~Widget):
  • plugins/PluginView.cpp: (WebCore::PluginView::PluginView):
  • plugins/PluginView.h: (WebCore::PluginView::isNPAPIPlugin): (WebCore::PluginView::setIsNPAPIPlugin):
7:53 PM Changeset in webkit [36644] by mjs@apple.com
  • 1 edit
    1 add in trunk/WebKitSite

2008-09-18 Maciej Stachowiak <​mjs@apple.com>

Not reviewed.

  • blog-files/animation-demo.svg: Added.
7:36 PM Changeset in webkit [36643] by hyatt@apple.com
  • 4 edits in trunk/WebCore

2008-09-18 David Hyatt <​hyatt@apple.com>

Make geometryChanged() cross-platform on Widget. GTK and WIN platform
ifdefs are now gone from Widget!

Reviewed by Sam Weinig

  • platform/Widget.h: (WebCore::Widget::geometryChanged):
  • platform/gtk/WidgetGtk.cpp:
  • platform/qt/WidgetQt.cpp:
7:29 PM Changeset in webkit [36642] by hyatt@apple.com
  • 12 edits in trunk/WebCore

2008-09-18 David Hyatt <​hyatt@apple.com>

Consolidate convertTo/FromContainingWindow methods so that all platforms
but Mac share the same code.

Move convertSelfToChild and convertChildToSelf to ScrollView, since
Widget should know nothing about children. Make the methods cross-platform
on ScrollView.

Reviewed by Sam Weinig

  • platform/ScrollView.h: (WebCore::ScrollView::convertChildToSelf): (WebCore::ScrollView::convertSelfToChild):
  • platform/Widget.cpp: (WebCore::Widget::convertToContainingWindow): (WebCore::Widget::convertFromContainingWindow):
  • platform/Widget.h: (WebCore::Widget::geometryChanged):
  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::isScrollViewScrollbar):
  • platform/gtk/WidgetGtk.cpp:
  • platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::isScrollViewScrollbar):
  • platform/mac/WidgetMac.mm:
  • platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::isScrollViewScrollbar):
  • platform/qt/WidgetQt.cpp:
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::isScrollViewScrollbar):
  • platform/win/WidgetWin.cpp:
6:51 PM Changeset in webkit [36641] by mjs@apple.com
  • 1 edit
    1 add in trunk/WebKitSite

2008-09-18 Maciej Stachowiak <​mjs@apple.com>

Not reviewed.

  • blog-files/sfx-perf.png: Added.
6:34 PM Changeset in webkit [36640] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-09-18 Sam Weinig <​sam@webkit.org>

Fix style.

  • VM/Instruction.h: (JSC::Instruction::Instruction):
6:00 PM Changeset in webkit [36639] by zecke@webkit.org
  • 2 edits in trunk/WebCore

[qt] Build fixes after the Widget/ScrollView cleanup

topLevel() is now root()

5:51 PM Changeset in webkit [36638] by hyatt@apple.com
  • 2 edits in trunk/WebCore/platform

Fix WIndows bustage.

5:46 PM Changeset in webkit [36637] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Bug 20911: REGRESSION(r36480?): Reproducible assertion failure below derefStructureIDs 64-bit JavaScriptCore
<​https://bugs.webkit.org/show_bug.cgi?id=20911>

Reviewed by Maciej Stachowiak.

The problem was simply caused by the int constructor for Instruction
failing to initialise the full struct in 64bit builds.

5:39 PM Changeset in webkit [36636] by hyatt@apple.com
  • 4 edits in trunk/WebCore

2008-09-18 David Hyatt <​hyatt@apple.com>

Make the conversion methods that go to and from some containingWindow
cross-platform. Implement them on Mac.

Reviewed by Sam Weinig

  • platform/Widget.h: (WebCore::Widget::setContainingWindow):
  • platform/mac/WidgetMac.mm: (WebCore::Widget::convertFromContainingWindow): (WebCore::Widget::convertToContainingWindow):
5:28 PM Changeset in webkit [36635] by weinig@apple.com
  • 5 edits in trunk/WebCore

2008-09-18 Sam Weinig <​sam@webkit.org>

Rubber-stamped by David "Yeah-yeah" Hyatt.

Cleanup RenderStyle.

  • WebCore.xcodeproj/project.pbxproj:
  • rendering/style/CounterContent.h:
  • rendering/style/RenderStyle.cpp:
  • rendering/style/RenderStyle.h:
5:01 PM Changeset in webkit [36634] by dino@apple.com
  • 15 edits in trunk/WebCore

2008-09-18 Chris Marrin <​cmarrin@apple.com>

Reviewed by Sam Weinig

Fixed ​https://bugs.webkit.org/show_bug.cgi?id=20908
Now TransformOperations and AnimationList no longer
inherit from Vector<> but rather have API to access.

  • css/CSSComputedStyleDeclaration.cpp:
  • css/CSSStyleSelector.cpp:
  • page/animation/AnimationBase.cpp:
  • page/animation/CompositeAnimation.cpp:
  • page/animation/ImplicitAnimation.cpp:
  • page/animation/KeyframeAnimation.cpp:
  • rendering/RenderLayer.cpp:
  • rendering/style/AnimationList.cpp:
  • rendering/style/AnimationList.h:
  • rendering/style/RenderStyle.cpp:
  • rendering/style/RenderStyle.h:
  • rendering/style/TransformOperations.cpp:
  • rendering/style/TransformOperations.h:
4:47 PM Changeset in webkit [36633] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

2008-09-18 Darin Adler <Darin Adler>

  • fix release build
  • wtf/RefCountedLeakCounter.cpp: Removed stray "static".
4:34 PM Changeset in webkit [36632] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

2008-09-18 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

  • kjs/JSGlobalObject.h: Tiny style guideline tweak.
4:30 PM Changeset in webkit [36631] by Darin Adler
  • 7 edits in trunk

2008-09-18 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

  • JavaScriptCore.exp: Updated, and also added an export needed for future WebCore use of JSC::StructureID.
  • wtf/RefCountedLeakCounter.cpp: (WTF::RefCountedLeakCounter::suppressMessages): Added. (WTF::RefCountedLeakCounter::cancelMessageSuppression): Added. (WTF::RefCountedLeakCounter::RefCountedLeakCounter): Tweaked a bit. (WTF::RefCountedLeakCounter::~RefCountedLeakCounter): Added code to log the reason there was no leak checking done. (WTF::RefCountedLeakCounter::increment): Tweaked a bit. (WTF::RefCountedLeakCounter::decrement): Ditto.
  • wtf/RefCountedLeakCounter.h: Replaced setLogLeakMessages with two new functions, suppressMessages and cancelMessageSuppression. Also added m_ prefixes to the data member names.

2008-09-18 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

  • WebView/WebPreferences.mm: (-[WebPreferences setFullDocumentTeardownEnabled:]): Removed unneeded call to setLogLeakMessages.
  • WebView/WebView.mm: (-[WebView _closeWithFastTeardown]): Call RefCountedLeakCounter::suppressMessages, telling it that we can't track leaks because at least one WebView was closed with fast teardown. (-[WebView _close]): Removed unneeded call to setLogLeakMessages. Added a call to cancelMessageSuppression since the WebView is no longer open. Added an explicit garbage collect to help with the case where we're closing during the quit process -- the garbageCollectSoon() calls done inside WebCore won't help us in that case. (-[WebView initWithFrame:frameName:groupName:]): Call RefCountedLeakCounter::suppressMessages telling it that we can't track leaks because at least one WebView is currently open.
4:28 PM Changeset in webkit [36630] by zecke@webkit.org
  • 10 edits
    2 copies in trunk

JavaScriptCore
2008-09-18 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Mark Rowe.

​https://bugs.webkit.org/show_bug.cgi?id=20437

Add a proper #define to define which XML Parser implementation to use. Client
code can use #if USE(QXMLSTREAM) to decide if the Qt XML StreamReader
implementation is going to be used.

  • wtf/Platform.h:

WebCore
2008-09-18 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Mark Rowe.

​https://bugs.webkit.org/show_bug.cgi?id=20437

XMLTokenizer.cpp used to contain two different implementations. One was using
libxml2 and the other was using the Qt XML StreamReader. Clean up the code by
separating the two implementations from each other.
Common code and some small bits are kept inside the XMLTokenizer.cpp, the Qt code
was moved to XMLTokenizerQt.cpp and the Libxml2 based code was moved to
XMLTokenizerLibxml2.cpp. There should be no functional changes.

Attempt to add XMLTokenizerLibxml2.cpp to every buildsystem so the build continues
to work.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • dom/XMLTokenizer.cpp: (WebCore::isScriptElement): (WebCore::castToScriptElement): (WebCore::XMLTokenizer::setCurrentNode): (WebCore::XMLTokenizer::write): (WebCore::XMLTokenizer::eventuallyMarkAsParserCreated): (WebCore::XMLTokenizer::enterText): (WebCore::toString): (WebCore::XMLTokenizer::exitText): (WebCore::XMLTokenizer::end): (WebCore::XMLTokenizer::insertErrorMessageBlock):
  • dom/XMLTokenizer.h: (WebCore::XMLTokenizer::wellFormed):
  • dom/XMLTokenizerLibxml2.cpp: Copied from WebCore/dom/XMLTokenizer.cpp. (WebCore::createMemoryParser): (WebCore::XMLTokenizer::XMLTokenizer): (WebCore::XMLTokenizer::~XMLTokenizer): (WebCore::XMLTokenizer::doWrite): (WebCore::ignorableWhitespaceHandler): (WebCore::XMLTokenizer::initializeParserContext): (WebCore::XMLTokenizer::doEnd): (WebCore::XMLTokenizer::lineNumber): (WebCore::XMLTokenizer::columnNumber): (WebCore::XMLTokenizer::stopParsing): (WebCore::XMLTokenizer::resumeParsing): (WebCore::parseXMLDocumentFragment): (WebCore::attributesStartElementNsHandler): (WebCore::parseAttributes):
  • dom/XMLTokenizerQt.cpp: Copied from WebCore/dom/XMLTokenizer.cpp. (WebCore::EntityResolver::resolveUndeclaredEntity): (WebCore::XMLTokenizer::XMLTokenizer): (WebCore::XMLTokenizer::~XMLTokenizer): (WebCore::XMLTokenizer::doWrite): (WebCore::XMLTokenizer::initializeParserContext): (WebCore::XMLTokenizer::doEnd): (WebCore::XMLTokenizer::lineNumber): (WebCore::XMLTokenizer::columnNumber): (WebCore::XMLTokenizer::stopParsing): (WebCore::XMLTokenizer::resumeParsing): (WebCore::parseXMLDocumentFragment): (WebCore::attributesStartElementNsHandler): (WebCore::parseAttributes): (WebCore::):
4:08 PM Changeset in webkit [36629] by Beth Dakin
  • 2 edits in trunk/WebCore

2008-09-18 Beth Dakin <Beth Dakin>

Reviewed by Geoff Garen.

Build fix for non-Mac builds.

  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cssText):
4:07 PM Changeset in webkit [36628] by eric@webkit.org
  • 7 edits in trunk/WebCore

2008-09-18 Peter Kasting <​pkasting@google.com>

Reviewed by hyatt. Landed by eseidel.

​https://bugs.webkit.org/show_bug.cgi?id=20745
Animated GIFs do not animate properly with (at least) CG.

  • WebCore\platform\graphics\BitmapImage.cpp:
  • WebCore\platform\graphics\BitmapImage.h:
  • WebCore\platform\graphics\cairo\ImageCairo.cpp:
  • WebCore\platform\graphics\cg\ImageCG.cpp:
  • WebCore\platform\graphics\qt\ImageQt.cpp:
  • WebCore\platform\graphics\wx\ImageWx.cpp:
3:54 PM Changeset in webkit [36627] by Chris Fleizach
  • 11 edits
    3 adds in trunk

<rdar://problem/6224222> AX: should not expose a <table> as an AXTable if ARIA role specifies otherwise

If a <table> tag has an aria role, it should not appear as an AXTable
Likewise, it's rows and cells should not appear as AXRow or AXCell

3:29 PM Changeset in webkit [36626] by sfalken@apple.com
  • 2 edits in trunk/WebCore

Use higher-resolution timers on all variants of Windows.


Reviewed by Darin Adler.

  • platform/win/SharedTimerWin.cpp: (WebCore::setSharedTimerFireTime):
3:21 PM Changeset in webkit [36625] by hyatt@apple.com
  • 8 edits in trunk/WebCore

2008-09-18 David Hyatt <​hyatt@apple.com>

Make containingWindow() and setContainingWindow() cross-platform.
Add a root() function cross-platform so Qt doesn't have to
define its own.

Reviewed by Darin Adler

  • platform/Widget.cpp: (WebCore::Widget::root):
  • platform/Widget.h: (WebCore::Widget::setContainingWindow):
  • platform/gtk/WidgetGtk.cpp: (WebCore::Widget::Widget): (WebCore::Widget::containingWindow):
  • platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::addChild): (WebCore::ScrollView::removeChild):
  • platform/mac/WidgetMac.mm: (WebCore::Widget::containingWindow):
  • platform/qt/WidgetQt.cpp: (WebCore::Widget::invalidateRect): (WebCore::Widget::containingWindow):
  • platform/win/WidgetWin.cpp: (WebCore::Widget::Widget): (WebCore::Widget::~Widget): (WebCore::Widget::containingWindow):
3:18 PM Changeset in webkit [36624] by Beth Dakin
  • 5 edits
    2 adds in trunk

WebCore:

2008-09-18 Beth Dakin <Beth Dakin>

Reviewed by Dave Hyatt.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=20515 Crash upon
parsing CSS: unicode-range: searchfield-cancel-buttonpt=-webkit-
dashboard-region=
and corresponding: <rdar://problem/6174100>

This patch makes CSSParserValue::createCSSValue handle unknown
identifiers.

  • css/CSSParserValues.cpp: (WebCore::CSSParserValue::createCSSValue): If we have an identifier with no id (an unknown identifier) create a CSSPrimitiveValue of type CSS_PARSER_IDENTIFIER
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cssText): (WebCore::CSSPrimitiveValue::parserValue):
  • css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::):

LayoutTests:

2008-09-18 Beth Dakin <Beth Dakin>

Reviewed by Dave Hyatt.

Test for ​https://bugs.webkit.org/show_bug.cgi?id=20515 Crash upon
parsing CSS: unicode-range: searchfield-cancel-buttonpt=-webkit-
dashboard-region=
and corresponding: <rdar://problem/6174100>

  • fast/css/variables/invalid-identifier-expected.txt: Added.
  • fast/css/variables/invalid-identifier.html: Added.
2:46 PM Changeset in webkit [36623] by weinig@apple.com
  • 8 edits
    9 copies in trunk/WebCore

2008-09-18 Sam Weinig <​sam@webkit.org>

Rubber-stamped by David "I'd prefer not" Hyatt.

More the remaining class out of RenderStyle.h/cpp

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • rendering/style/CursorData.h: Copied from rendering/style/RenderStyle.h. (WebCore::CursorData::CursorData): (WebCore::CursorData::operator==): (WebCore::CursorData::operator!=):
  • rendering/style/CursorList.h: Copied from rendering/style/RenderStyle.h. (WebCore::CursorList::operator[]): (WebCore::CursorList::CursorList):
  • rendering/style/RenderStyle.cpp:
  • rendering/style/RenderStyle.h: (WebCore::RenderStyle::deref): (WebCore::RenderStyle::hasOneRef): (WebCore::RenderStyle::InheritedFlags::operator!=): (WebCore::RenderStyle::NonInheritedFlags::operator!=): (WebCore::RenderStyle::hasBackground): (WebCore::RenderStyle::outlineWidth): (WebCore::RenderStyle::autoWrap): (WebCore::RenderStyle::preserveNewline): (WebCore::RenderStyle::collapseWhiteSpace): (WebCore::RenderStyle::isCollapsibleWhiteSpace): (WebCore::RenderStyle::breakOnlyAfterWhiteSpace): (WebCore::RenderStyle::breakWords): (WebCore::RenderStyle::outlineOffset): (WebCore::RenderStyle::setLeft): (WebCore::RenderStyle::setRight): (WebCore::RenderStyle::setTop): (WebCore::RenderStyle::setBottom): (WebCore::RenderStyle::setDashboardRegion): (WebCore::RenderStyle::setBackgroundColor): (WebCore::RenderStyle::setBorderImage): (WebCore::RenderStyle::setBorderRadius): (WebCore::RenderStyle::setFontDescription): (WebCore::RenderStyle::adjustBackgroundLayers): (WebCore::RenderStyle::adjustMaskLayers): (WebCore::RenderStyle::deleteBindingURIs): (WebCore::RenderStyle::inheritBindingURIs): (WebCore::RenderStyle::isDisplayReplacedType): (WebCore::RenderStyle::isDisplayInlineType): (WebCore::RenderStyle::isOriginalDisplayInlineType):
  • rendering/style/StyleInheritedData.cpp: Copied from rendering/style/RenderStyle.cpp.
  • rendering/style/StyleInheritedData.h: Copied from rendering/style/RenderStyle.h. (WebCore::StyleInheritedData::operator!=):
  • rendering/style/StyleRareInheritedData.cpp: Copied from rendering/style/RenderStyle.cpp.
  • rendering/style/StyleRareInheritedData.h: Copied from rendering/style/RenderStyle.h. (WebCore::StyleRareInheritedData::operator!=):
  • rendering/style/StyleRareNonInheritedData.cpp: Copied from rendering/style/RenderStyle.cpp.
  • rendering/style/StyleRareNonInheritedData.h: Copied from rendering/style/RenderStyle.h.
  • rendering/style/StyleReflection.h: Copied from rendering/style/RenderStyle.h.
2:29 PM Changeset in webkit [36622] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/Scrollbar.cpp

Fix Mac bustage.

1:24 PM Changeset in webkit [36621] by hyatt@apple.com
  • 7 edits in trunk/WebCore

2008-09-18 David Hyatt <​hyatt@apple.com>

Move the concept of suppression invalidation on Widgets to Scrollbar
instead. Since this is only used by Scrollbars, there is no need for
it to be on Widget.

Reviewed by Sam Weinig

  • platform/Scrollbar.cpp: (WebCore::Scrollbar::Scrollbar): (WebCore::Scrollbar::invalidateRect):
  • platform/Scrollbar.h: (WebCore::Scrollbar::suppressInvalidation): (WebCore::Scrollbar::setSuppressInvalidation):
  • platform/Widget.h:
  • platform/gtk/WidgetGtk.cpp: (WebCore::Widget::Widget): (WebCore::Widget::invalidateRect):
  • platform/qt/WidgetQt.cpp: (WebCore::WidgetPrivate::WidgetPrivate): (WebCore::Widget::invalidateRect):
  • platform/win/WidgetWin.cpp: (WebCore::Widget::Widget): (WebCore::Widget::invalidateRect):
1:09 PM Changeset in webkit [36620] by hyatt@apple.com
  • 8 edits in trunk/WebCore

2008-09-18 David Hyatt <​hyatt@apple.com>

Make invalidate() on Widget non-virtual and make it just call
invalidateRect() on the boundsGeometry() of the Widget.

Reviewed by Dan Bernstein

  • platform/Widget.h: (WebCore::Widget::boundsGeometry): (WebCore::Widget::invalidate):
  • platform/gtk/WidgetGtk.cpp:
  • platform/mac/WidgetMac.mm:
  • platform/qt/WidgetQt.cpp:
  • platform/win/WidgetWin.cpp:
  • platform/wx/WidgetWx.cpp:
12:40 PM Changeset in webkit [36619] by weinig@apple.com
  • 14 edits
    18 copies in trunk/WebCore

2008-09-18 Sam Weinig <​sam@webkit.org>

Rubber-stamped in exile by David Hyatt.

Split Animation, AnimationList, BindingURI, ContentData, CounterContent,
KeyframeList, ShadowData, StyleFlexibleBoxData and TimingFunction out of
RenderStyle.h/cpp

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • css/CSSStyleSelector.cpp:
  • css/CSSStyleSelector.h:
  • page/animation/CompositeAnimation.cpp:
  • page/animation/KeyframeAnimation.cpp:
  • page/animation/KeyframeAnimation.h:
  • rendering/RenderCounter.h:
  • rendering/style/Animation.cpp: Copied from rendering/style/RenderStyle.cpp. (WebCore::Animation::~Animation): (WebCore::Animation::animationsMatch): (WebCore::Animation::keyframeList): (WebCore::Animation::setAnimationKeyframe):
  • rendering/style/Animation.h: Copied from rendering/style/RenderStyle.h.
  • rendering/style/AnimationList.cpp: Copied from rendering/style/RenderStyle.cpp.
  • rendering/style/AnimationList.h: Copied from rendering/style/RenderStyle.h.
  • rendering/style/BindingURI.cpp: Copied from rendering/style/RenderStyle.cpp.
  • rendering/style/BindingURI.h: Copied from rendering/style/RenderStyle.h. (WebCore::BindingURI::operator!=):
  • rendering/style/ContentData.cpp: Copied from rendering/style/RenderStyle.cpp.
  • rendering/style/ContentData.h: Copied from rendering/style/RenderStyle.h. (WebCore::ContentData::ContentData): (WebCore::ContentData::~ContentData):
  • rendering/style/CounterContent.h: Copied from rendering/style/RenderStyle.h. (WebCore::CounterContent::CounterContent):
  • rendering/style/CounterDirectives.cpp: Copied from rendering/style/RenderStyle.cpp.
  • rendering/style/CounterDirectives.h: Copied from rendering/style/RenderStyle.h. (WebCore::CounterDirectives::CounterDirectives):
  • rendering/style/KeyframeList.cpp: Copied from rendering/style/RenderStyle.cpp. (WebCore::KeyframeList::insert):
  • rendering/style/KeyframeList.h: Copied from rendering/style/RenderStyle.h. (WebCore::KeyframeValue::KeyframeValue): (WebCore::KeyframeList::create): (WebCore::KeyframeList::KeyframeList):
  • rendering/style/RenderStyle.cpp:
  • rendering/style/RenderStyle.h:
  • rendering/style/ShadowData.cpp: Copied from rendering/style/RenderStyle.cpp.
  • rendering/style/ShadowData.h: Copied from rendering/style/RenderStyle.h. (WebCore::ShadowData::ShadowData): (WebCore::ShadowData::~ShadowData): (WebCore::ShadowData::operator!=):
  • rendering/style/StyleFlexibleBoxData.cpp: Copied from rendering/style/RenderStyle.cpp.
  • rendering/style/StyleFlexibleBoxData.h: Copied from rendering/style/RenderStyle.h. (WebCore::StyleFlexibleBoxData::operator!=):
  • rendering/style/TimingFunction.h: Copied from rendering/style/RenderStyle.h. (WebCore::TimingFunction::TimingFunction): (WebCore::TimingFunction::operator==):
11:49 AM Changeset in webkit [36618] by adele@apple.com
  • 2 edits in trunk/WebCore

2008-09-18 Adele Peterson <​adele@apple.com>

Reviewed by Dan Bernstein.

Fix RenderStyle leaks.

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::createSubtreeIfNeeded):
11:30 AM Changeset in webkit [36617] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2008-09-18 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam Roben.

Move the remainder of the stream ivars to the C++ object.


  • Plugins/WebBaseNetscapePluginStream.h: (WebNetscapePluginStream::WebNetscapePluginStream):
  • Plugins/WebBaseNetscapePluginStream.mm: (-[WebBaseNetscapePluginStream _pluginCancelledConnectionError]): (-[WebBaseNetscapePluginStream initWithFrameLoader:]): (-[WebBaseNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]): (-[WebBaseNetscapePluginStream initWithRequestURL:plugin:notifyData:sendNotification:]): (-[WebBaseNetscapePluginStream dealloc]): (-[WebBaseNetscapePluginStream finalize]): (-[WebBaseNetscapePluginStream setPlugin:]): (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:headers:]): (-[WebBaseNetscapePluginStream start]): (-[WebBaseNetscapePluginStream stop]): (-[WebBaseNetscapePluginStream wantsAllStreams]): (-[WebBaseNetscapePluginStream _destroyStream]): (-[WebBaseNetscapePluginStream _destroyStreamWithReason:]): (-[WebBaseNetscapePluginStream cancelLoadWithError:]): (-[WebBaseNetscapePluginStream _deliverData]):
11:03 AM Changeset in webkit [36616] by kmccullough@apple.com
  • 2 edits in trunk/WebCore

2008-09-18 Kevin McCullough <​kmccullough@apple.com>

Accidentally checked in code.

  • html/HTMLElementFactory.cpp: (WebCore::frameConstructor): (WebCore::iframeConstructor):
10:21 AM Changeset in webkit [36615] by kmccullough@apple.com
  • 4 edits
    1 add in trunk/WebCore

2008-09-18 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Tim.

<rdar://problem/5722310> gracefully handle too many console messages
(20904)

  • Keep track of the most previous message and then compare it to the subsequent messages as they come in. If there are multiple of the same message create a count that indicates the current number.
  • manual-tests/inspector/multiple-console-messages.html: Added.
  • page/inspector/Console.js:
  • page/inspector/inspector.css:
9:00 AM ProposedWebInspectorRearchitecting edited by Dimitri Glazkov
WebKit -> WebCore rename (diff)
4:50 AM Changeset in webkit [36614] by alp@webkit.org
  • 3 edits in trunk/WebCore

2008-09-18 Jonathon Jongsma <​jonathon@quotidian.org>

Reviewed by Alp Toker

​https://bugs.webkit.org/show_bug.cgi?id=20830
[GTK] Don't use deprecated pango API

Replace deprecated pango functions with non-deprecated ones for newer
versions of pango

  • platform/graphics/gtk/FontGtk.cpp: (WebCore::getDefaultPangoLayout):
  • platform/graphics/gtk/FontPlatformDataPango.cpp: (WebCore::FontPlatformData::FontPlatformData):
2:39 AM Changeset in webkit [36613] by Stephanie Lewis
  • 2 edits in trunk/WebKitTools

2008-09-18 Stephanie Lewis <Stephanie Lewis>

Really fix tiger jsc tests.

  • Scripts/run-javascriptcore-tests:
2:35 AM Changeset in webkit [36612] by cwzwarich@webkit.org
  • 3 edits in trunk/JavaScriptCore

2008-09-18 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Maciej Stachowiak.

Make a Unicode non-breaking space count as a whitespace character in
PCRE. This change was already made in WREC, and it fixes one of the
Mozilla JS tests. Since it is now fixed in PCRE as well, we can check
in a new set of expected test results.

  • pcre/pcre_internal.h: (isSpaceChar):
  • tests/mozilla/expected.html:
2:13 AM Changeset in webkit [36611] by Stephanie Lewis
  • 3 edits in trunk/WebKitTools

2008-09-18 Stephanie Lewis <Stephanie Lewis>

Reviewed by Maciej Stachowiak.

Fix jsc tests on Tiger. Make jsc tests smarter about when to use the arch flag.

  • Scripts/run-javascriptcore-tests:
  • Scripts/webkitdirs.pm:
1:10 AM Changeset in webkit [36610] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-09-18 Alp Toker <​alp@nuanti.com>

Build fix for r36587. Add new sources (and sort the lists).

  • GNUmakefile.am:
12:48 AM Changeset in webkit [36609] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Print warning to stdout rather than stderr when a test attempts to access a remote resource.
This should make it more obvious when a test does this, as stderr output tends to be obscured
by noise in the test results.

Also fixes some coding style issues in ResourceLoadDelegate.mm.

Rubber-stamped by Sam Weinig.

  • DumpRenderTree/mac/ResourceLoadDelegate.mm:

(-[NSError _drt_descriptionSuitableForTestResult]):
(-[NSURL _drt_descriptionSuitableForTestResult]):
(-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
(-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
(-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
(-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
(-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
(-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):

12:48 AM Changeset in webkit [36608] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

Change test to not attempt to access a remote host. This stops
DRT from printing a warning to stderr while running this test.

Rubber-stamped by Sam Weinig.

  • fast/loader/cancel-load-during-port-block-timer.html:
12:43 AM Changeset in webkit [36607] by Stephanie Lewis
  • 4 edits in trunk

2008-09-18 Stephanie Lewis <Stephanie Lewis>

Reviewed by Mark Rowe and Maciej Stachowiak.

add an option use arch to specify which architecture to run.

  • tests/mozilla/jsDriver.pl:

add a --64-bit option and specify which architecture to run on Mac.

  • Scripts/run-javascriptcore-tests:
12:09 AM Changeset in webkit [36606] by mrowe@apple.com
  • 6 edits
    1 add in trunk/WebKitTools

Fix a crash seen running DumpRenderTree on fast/dom/null-document-window-open-crash.html under guard malloc.

Reviewed by Sam Weinig.

The JS wrapper for LayoutTestController could outlive the wrapped instance, and would crash when
attempting to access the wrapped instance within layoutTestControllerObjectFinalize. We fix this by making
LayoutTestController ref-counted to ensure that it is not outlived by the JS wrapper.

  • DumpRenderTree/ForwardingHeaders/wtf/RefCounted.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/RefCounted.h.
  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(notifyDoneCallback): Remove code that is no longer needed now that we must always have a wrapped instance.
(layoutTestControllerObjectFinalize): Deref the wrapped object.
(LayoutTestController::makeWindowObject): Ref the wrapped object.

  • DumpRenderTree/LayoutTestController.h: Make LayoutTestController RefCounted.
  • DumpRenderTree/mac/DumpRenderTree.mm:

(runTest): Deref the LayoutTestController object rather than explicitly deleting it.

  • DumpRenderTree/mac/LayoutTestControllerMac.mm: Remove code that is no longer needed.
  • DumpRenderTree/win/DumpRenderTree.cpp:

(runTest): Deref the LayoutTestController object rather than explicitly deleting it.

Sep 17, 2008:

11:45 PM Changeset in webkit [36605] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-09-17 Oliver Hunt <​oliver@apple.com>

Correctly restore argument reference prior to SFX runtime calls.


Reviewed by Steve Falkenburg.

  • VM/CTI.cpp: (JSC::CTI::privateCompileSlowCases): (JSC::CTI::privateCompile):
11:20 PM Changeset in webkit [36604] by cwzwarich@webkit.org
  • 8 edits in trunk/JavaScriptCore

2008-09-17 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Maciej Stachowiak.

Bug 20876: REGRESSION (r36417, r36427): fast/js/exception-expression-offset.html fails
<​https://bugs.webkit.org/show_bug.cgi?id=20876>

r36417 and r36427 caused an get_by_id opcode to be emitted before the
instanceof and construct opcodes, in order to enable inline caching of
the prototype property. Unfortunately, this regressed some tests dealing
with exceptions thrown by 'instanceof' and the 'new' operator. We fix
these problems by detecting whether an "is not an object" exception is
thrown before op_instanceof or op_construct, and emit the proper
exception in those cases.

  • VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitConstruct):
  • VM/CodeGenerator.h:
  • VM/ExceptionHelpers.cpp: (JSC::createInvalidParamError): (JSC::createNotAConstructorError): (JSC::createNotAnObjectError):
  • VM/ExceptionHelpers.h:
  • VM/Machine.cpp: (JSC::Machine::getOpcode): (JSC::Machine::privateExecute):
  • VM/Machine.h:
  • kjs/nodes.cpp: (JSC::NewExprNode::emitCode): (JSC::InstanceOfNode::emitCode):
10:51 PM Changeset in webkit [36603] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-09-17 Sam Weinig <​sam@webkit.org>

Fix Windows build.

  • WebCore.vcproj/WebCore.vcproj:
10:28 PM Changeset in webkit [36602] by hyatt@apple.com
  • 1 edit in trunk/WebCore/WebCore.base.exp

Fix mysterious Mac bustage.

10:10 PM Changeset in webkit [36601] by hyatt@apple.com
  • 14 edits in trunk/WebCore

2008-09-17 David Hyatt <​hyatt@apple.com>

Switch back to having frameGeometry be virtual in order to keep Mac
the way it used to be.

Reviewed by Sam Weinig

  • WebCore.base.exp:
  • platform/Widget.cpp: (WebCore::Widget::setParent):
  • platform/Widget.h:
  • platform/gtk/WidgetGtk.cpp: (WebCore::Widget::frameGeometry): (WebCore::Widget::setFrameGeometry):
  • platform/mac/WidgetMac.mm: (WebCore::Widget::frameGeometry): (WebCore::Widget::setFrameGeometry):
  • platform/qt/WidgetQt.cpp: (WebCore::Widget::frameGeometry): (WebCore::Widget::setFrameGeometry):
  • platform/win/WidgetWin.cpp: (WebCore::Widget::frameGeometry): (WebCore::Widget::setFrameGeometry):
  • platform/wx/WidgetWx.cpp: (WebCore::Widget::frameGeometry): (WebCore::Widget::setFrameGeometry):
  • plugins/PluginView.cpp: (WebCore::PluginView::setFrameGeometry): (WebCore::PluginView::geometryChanged):
  • plugins/PluginView.h:
  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::updatePluginWidget):
  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::updatePluginWidget):
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginView::updatePluginWidget):
10:03 PM Changeset in webkit [36600] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-09-17 Sam Weinig <​sam@webkit.org>

Reviewed by Mark Rowe.

Fix assertion in DOMWindow::adjustWindowRect where we were passing
in garbage values and were getting lucky that they were a not Nan.

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::windowProtoFuncOpen):
9:28 PM Changeset in webkit [36599] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-09-17 Sam Weinig <​sam@webkit.org>

Fix gtk build.

  • rendering/style/MatrixTransformOperation.cpp:
8:36 PM Changeset in webkit [36598] by hyatt@apple.com
  • 1 edit in trunk/WebCore/WebCore.base.exp

Fix Mac bustage.

8:34 PM Changeset in webkit [36597] by mrowe@apple.com
  • 1 copy in tags/Safari-5525.25.1

New tag.

8:32 PM Changeset in webkit [36596] by hyatt@apple.com
  • 4 edits in trunk/WebCore/platform

Fix build bustage on Qt, Gtk, Win.

8:32 PM Changeset in webkit [36595] by mrowe@apple.com
  • 1 copy in tags/Safari-5525.25

New tag.

8:28 PM Changeset in webkit [36594] by hyatt@apple.com
  • 6 edits in trunk/WebCore

Fix build bustage on Qt, Gtk, Win.

8:23 PM Changeset in webkit [36593] by weinig@apple.com
  • 11 edits
    16 copies in trunk/WebCore

2008-09-17 Sam Weinig <​sam@webkit.org>

Rubber-stamped with love by David Hyatt.

Split IdentityTransformOperation, MatrixTransformOperation, RotateTransformOperation,
ScaleTransformOperation, SkewTransformOperation, StyleTransformData, TransformOperation,
TransformOperations and TranslateTransformOperation out of RenderStyle.h/cpp

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • css/CSSStyleSelector.cpp:
  • page/animation/AnimationBase.cpp: (WebCore::solveEpsilon):
  • rendering/RenderLayer.cpp:
  • rendering/style/IdentityTransformOperation.h: Copied from rendering/style/RenderStyle.h.
  • rendering/style/MatrixTransformOperation.cpp: Copied from rendering/style/RenderStyle.cpp.
  • rendering/style/MatrixTransformOperation.h: Copied from rendering/style/RenderStyle.h. (WebCore::MatrixTransformOperation::MatrixTransformOperation):
  • rendering/style/RenderStyle.cpp:
  • rendering/style/RenderStyle.h:
  • rendering/style/RotateTransformOperation.cpp: Copied from rendering/style/RenderStyle.cpp.
  • rendering/style/RotateTransformOperation.h: Copied from rendering/style/RenderStyle.h. (WebCore::RotateTransformOperation::RotateTransformOperation):
  • rendering/style/ScaleTransformOperation.cpp: Copied from rendering/style/RenderStyle.cpp.
  • rendering/style/ScaleTransformOperation.h: Copied from rendering/style/RenderStyle.h. (WebCore::ScaleTransformOperation::ScaleTransformOperation):
  • rendering/style/SkewTransformOperation.cpp: Copied from rendering/style/RenderStyle.cpp.
  • rendering/style/SkewTransformOperation.h: Copied from rendering/style/RenderStyle.h. (WebCore::SkewTransformOperation::SkewTransformOperation):
  • rendering/style/StyleTransformData.cpp: Copied from rendering/style/RenderStyle.cpp.
  • rendering/style/StyleTransformData.h: Copied from rendering/style/RenderStyle.h. (WebCore::StyleTransformData::operator!=):
  • rendering/style/TransformOperation.h: Copied from rendering/style/RenderStyle.h. (WebCore::TransformOperation::):
  • rendering/style/TransformOperations.cpp: Copied from rendering/style/RenderStyle.cpp. (WebCore::TransformOperations::TransformOperations):
  • rendering/style/TransformOperations.h: Copied from rendering/style/RenderStyle.h. (WebCore::TransformOperations::operator!=):
  • rendering/style/TranslateTransformOperation.cpp: Copied from rendering/style/RenderStyle.cpp.
  • rendering/style/TranslateTransformOperation.h: Copied from rendering/style/RenderStyle.h. (WebCore::TranslateTransformOperation::TranslateTransformOperation):
8:06 PM Changeset in webkit [36592] by hyatt@apple.com
  • 1 edit in trunk/WebCore/WebCore.base.exp

Fix Mac bustage.

8:00 PM Changeset in webkit [36591] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/qt/WidgetQt.cpp

Fix Qt bustage.

7:59 PM Changeset in webkit [36590] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Build fix.

7:48 PM Changeset in webkit [36589] by hyatt@apple.com
  • 12 edits in trunk/WebCore

2008-09-17 David Hyatt <​hyatt@apple.com>

(1) Inline a bunch of methods for accessing frame geometry.
(2) Make sure frameGeometry() works even when you have no underlying
native widget.
(3) Cache a frame geometry rect cross-platform (even for widgets that
have underlying native widgets.
(4) PluginView's updateWindow call is now a virtual function on Widget.

Reviewed by Sam Weinig

  • ChangeLog:
  • WebCore.base.exp:
  • platform/Widget.cpp: (WebCore::Widget::setFrameGeometry):
  • platform/Widget.h: (WebCore::Widget::x): (WebCore::Widget::y): (WebCore::Widget::width): (WebCore::Widget::height): (WebCore::Widget::size): (WebCore::Widget::pos): (WebCore::Widget::frameGeometry): (WebCore::Widget::resize): (WebCore::Widget::move): (WebCore::Widget::isFrameView): (WebCore::Widget::windowClipRect):
  • platform/mac/WidgetMac.mm: (WebCore::Widget::~Widget): (WebCore::Widget::updatePlatformWidgetFrameGeometry):
  • platform/win/WidgetWin.cpp: (WebCore::Widget::updatePlatformWidgetFrameGeometry):
  • plugins/PluginView.cpp: (WebCore::PluginView::setFrameGeometry): (WebCore::PluginView::geometryChanged):
  • plugins/PluginView.h:
  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::updatePlatformWidgetFrameGeometry):
  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::updatePlatformWidgetFrameGeometry):
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginView::updatePlatformWidgetFrameGeometry):
  • plugins/wx/PluginViewWx.cpp:
7:47 PM Changeset in webkit [36588] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-09-17 Sam Weinig <​sam@webkit.org>

Reviewed by David "Waterman" Hyatt.

Fix a leak of NSViews in WidgetMac.mm.

  • platform/mac/WidgetMac.mm: (WebCore::Widget::~Widget):
6:46 PM Changeset in webkit [36587] by weinig@apple.com
  • 8 edits
    13 copies in trunk/WebCore

2008-09-17 Sam Weinig <​sam@webkit.org>

Rubber-stamped by David Waterman Hyatt.

Split FillLayer, StyleBackgroundData, StyleBoxData, StyleDashboardRegion, StyleMarqueeData
StyleMultiColData and StyleVisualData out of RenderStyle.h/cpp

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • rendering/style/FillLayer.cpp: Copied from rendering/style/RenderStyle.cpp.
  • rendering/style/FillLayer.h: Copied from rendering/style/RenderStyle.h. (WebCore::FillLayer::operator!=): (WebCore::FillLayer::hasImage): (WebCore::FillLayer::hasFixedImage):
  • rendering/style/RenderStyle.cpp:
  • rendering/style/RenderStyle.h:
  • rendering/style/StyleBackgroundData.cpp: Copied from rendering/style/RenderStyle.cpp. (WebCore::StyleBackgroundData::StyleBackgroundData):
  • rendering/style/StyleBackgroundData.h: Copied from rendering/style/RenderStyle.h. (WebCore::StyleBackgroundData::~StyleBackgroundData): (WebCore::StyleBackgroundData::operator!=):
  • rendering/style/StyleBoxData.cpp: Copied from rendering/style/RenderStyle.cpp.
  • rendering/style/StyleBoxData.h: Copied from rendering/style/RenderStyle.h. (WebCore::StyleBoxData::operator!=):
  • rendering/style/StyleDashboardRegion.h: Copied from rendering/style/RenderStyle.h. (WebCore::StyleDashboardRegion::operator!=):
  • rendering/style/StyleMarqueeData.cpp: Copied from rendering/style/RenderStyle.cpp.
  • rendering/style/StyleMarqueeData.h: Copied from rendering/style/RenderStyle.h. (WebCore::StyleMarqueeData::operator!=):
  • rendering/style/StyleMultiColData.cpp: Copied from rendering/style/RenderStyle.cpp.
  • rendering/style/StyleMultiColData.h: Copied from rendering/style/RenderStyle.h. (WebCore::StyleMultiColData::operator!=): (WebCore::StyleMultiColData::ruleWidth):
  • rendering/style/StyleVisualData.cpp: Copied from rendering/style/RenderStyle.cpp.
  • rendering/style/StyleVisualData.h: Copied from rendering/style/RenderStyle.h. (WebCore::StyleVisualData::operator==):
6:32 PM Changeset in webkit [36586] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/ScrollbarThemeComposite.cpp

Fix Win build bustage.

6:17 PM Changeset in webkit [36585] by hyatt@apple.com
  • 5 edits in trunk/WebCore

Fix Win and Qt build bustage.

5:56 PM Changeset in webkit [36584] by hyatt@apple.com
  • 9 edits
    1 delete in trunk/WebCore

2008-09-17 David Hyatt <​hyatt@apple.com>

Remove WidgetClient from Widget.

Reviewed by Sam Weinig

  • WebCore.xcodeproj/project.pbxproj:
  • platform/Widget.h: (WebCore::Widget::setClient): (WebCore::Widget::client):
  • platform/WidgetClient.h: Removed.
  • platform/gtk/WidgetGtk.cpp:
  • platform/mac/WidgetMac.mm: (WebCore::Widget::Widget): (WebCore::Widget::show): (WebCore::Widget::hide):
  • platform/qt/WidgetQt.cpp: (WebCore::WidgetPrivate::WidgetPrivate):
  • platform/win/WidgetWin.cpp: (WebCore::Widget::Widget):
  • platform/wx/WidgetWx.cpp: (WebCore::Widget::Widget):
5:40 PM Changeset in webkit [36583] by mrowe@apple.com
  • 4 edits in branches/Safari-3-2-branch

Versioning.

5:39 PM Changeset in webkit [36582] by hyatt@apple.com
  • 14 edits in trunk/WebCore

2008-09-17 David Hyatt <​hyatt@apple.com>

Remove isEnabled/setEnabled from Widget. The concept of being enabled now
only applies to Scrollbars so the method has been moved there and made
cross-platform. Scrollbar subclasses that have a corresponding native
widget can subclass setEnabled to change the enabled state of the native
widget.

Reviewed by Sam Weinig & Darin Adler

  • WebCore.base.exp:
  • platform/Scrollbar.cpp: (WebCore::Scrollbar::Scrollbar):
  • platform/Scrollbar.h: (WebCore::Scrollbar::enabled): (WebCore::Scrollbar::setEnabled):
  • platform/Widget.h:
  • platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::setEnabled):
  • platform/gtk/ScrollbarGtk.h:
  • platform/gtk/WidgetGtk.cpp:
  • platform/mac/ScrollbarMac.h:
  • platform/mac/ScrollbarMac.mm: (WebCore::ScrollbarMac::scrollbarHit): (WebCore::ScrollbarMac::setEnabled):
  • platform/mac/WidgetMac.mm:
  • platform/qt/WidgetQt.cpp: (WebCore::WidgetPrivate::WidgetPrivate):
  • platform/win/WidgetWin.cpp: (WebCore::Widget::Widget):
  • platform/wx/WidgetWx.cpp:
5:36 PM Changeset in webkit [36581] by barraclough@apple.com
  • 4 edits in trunk/JavaScriptCore

2008-09-17 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Oliver Hunt.

JIT generation cti_op_construct_verify.


Quarter to half percent progression on v8-tests.
Roughly not change on SunSpider (possible minor progression).

  • VM/CTI.cpp: (JSC::CTI::privateCompileMainPass):
  • VM/Machine.cpp:
  • VM/Machine.h:
5:05 PM Changeset in webkit [36580] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/Widget.h

Land a comment in Widget.h to help describe the class.

4:56 PM Changeset in webkit [36579] by weinig@apple.com
  • 10 edits
    1 copy in trunk/WebCore

2008-09-17 Sam Weinig <​sam@webkit.org>

Rubber-stamped by David Hyatt.

Split all RenderStyle enums into their own file.

  • GNUmakefile.am:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/style/BorderValue.h:
  • rendering/style/CollapsedBorderValue.h:
  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h: Copied from rendering/style/RenderStyle.h. (WebCore::):
  • rendering/style/StyleCachedImage.h:
  • rendering/style/StyleGeneratedImage.h:
  • rendering/style/StyleImage.h:
4:54 PM Changeset in webkit [36578] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

Improve timer accuracy for JavaScript Date object on Windows.


Use a combination of ftime and QueryPerformanceCounter.
ftime returns the information we want, but doesn't have sufficient resolution.
QueryPerformanceCounter has high resolution, but is only usable to measure time intervals.
To combine them, we call ftime and QueryPerformanceCounter initially. Later calls will use
QueryPerformanceCounter by itself, adding the delta to the saved ftime. We re-sync to
correct for drift if the low-res and high-res elapsed time between calls differs by more
than twice the low-resolution timer resolution.


QueryPerformanceCounter may be inaccurate due to a problems with:


Reviewed by Darin Adler.

  • kjs/DateMath.cpp: (JSC::highResUpTime): (JSC::lowResUTCTime): (JSC::qpcAvailable): (JSC::getCurrentUTCTimeWithMicroseconds):
4:53 PM Changeset in webkit [36577] by sfalken@apple.com
  • 2 edits in trunk/WebCore

Add back isFrameView check to fix failed assertion during scroll bar teardown.


Reviewed by Dave Hyatt.

  • platform/Scrollbar.cpp: (WebCore::Scrollbar::setParent):
4:41 PM Changeset in webkit [36576] by Simon Fraser
  • 1 edit
    6 adds in trunk/LayoutTests

2008-09-17 Simon Fraser <Simon Fraser>

Add pixel test expecteds for transform tests.

  • platform/mac/transforms/2d/compound-transforms-vs-containers-expected.checksum: Added.
  • platform/mac/transforms/2d/compound-transforms-vs-containers-expected.png: Added.
  • platform/mac/transforms/2d/transform-borderbox-expected.checksum: Added.
  • platform/mac/transforms/2d/transform-borderbox-expected.png: Added.
  • platform/mac/transforms/2d/transform-origin-borderbox-expected.checksum: Added.
  • platform/mac/transforms/2d/transform-origin-borderbox-expected.png: Added.
4:39 PM Changeset in webkit [36575] by hyatt@apple.com
  • 1 edit in trunk/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp

Fix win bustage.

4:30 PM Changeset in webkit [36574] by beidson@apple.com
  • 2 edits in trunk/WebCore

2008-09-17 Brady Eidson <​beidson@apple.com>

Reviewed by Mac build fix

  • WebCore.xcodeproj/project.pbxproj: Send appropriate headers to WebKit
4:28 PM Changeset in webkit [36573] by sfalken@apple.com
  • 3 edits in trunk/WebCore

Fix build.

  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::setParentVisible):
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginView::init):
4:25 PM Changeset in webkit [36572] by zecke@webkit.org
  • 2 edits in trunk/WebCore

[QtWebKit] Implement error handling in TextCodecQt::decode

Use the QTextCodec parsing state to set the sawError out variable. This
is needed to pass Test 70 of acid3. The test case for this bug is
fast/encoding/invalid-xml.html that is now partially passed. To pass
it completely the Qt text codecs need to be adjusted to have proper
error handling.

4:12 PM Changeset in webkit [36571] by hyatt@apple.com
  • 1 edit in trunk/WebCore/plugins/win/PluginViewWin.cpp

Fix Windows bustage.

4:11 PM Changeset in webkit [36570] by hyatt@apple.com
  • 1 edit in trunk/WebCore/plugins/win/PluginViewWin.cpp

Fix Windows bustage.

4:07 PM Changeset in webkit [36569] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/win/ScrollViewWin.cpp

Fix Windows bustage.

4:03 PM Changeset in webkit [36568] by weinig@apple.com
  • 8 edits
    6 copies in trunk/WebCore

2008-09-17 Sam Weinig <​sam@webkit.org>

Rubber-stamped by Dave Hyatt.

Split BorderData, BorderValue, CollapsedBorderValue, OutlineValue and StyleSurroundData
out of RenderStyle.h/cpp

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • rendering/style/BorderData.h: Copied from rendering/style/RenderStyle.h. (WebCore::BorderData::hasBorderRadius): (WebCore::BorderData::borderLeftWidth): (WebCore::BorderData::borderRightWidth): (WebCore::BorderData::borderTopWidth): (WebCore::BorderData::borderBottomWidth): (WebCore::BorderData::operator!=):
  • rendering/style/BorderValue.h: Copied from rendering/style/RenderStyle.h. (WebCore::): (WebCore::BorderValue::BorderValue): (WebCore::BorderValue::nonZero): (WebCore::BorderValue::isTransparent): (WebCore::BorderValue::isVisible):
  • rendering/style/CollapsedBorderValue.h: Copied from rendering/style/RenderStyle.h. (WebCore::): (WebCore::CollapsedBorderValue::CollapsedBorderValue): (WebCore::CollapsedBorderValue::operator==):
  • rendering/style/OutlineValue.h: Copied from rendering/style/RenderStyle.h. (WebCore::OutlineValue::OutlineValue):
  • rendering/style/RenderStyle.cpp:
  • rendering/style/RenderStyle.h:
  • rendering/style/StyleSurroundData.cpp: Copied from rendering/style/RenderStyle.cpp.
  • rendering/style/StyleSurroundData.h: Copied from rendering/style/RenderStyle.h. (WebCore::StyleSurroundData::operator!=):
4:00 PM Changeset in webkit [36567] by Beth Dakin
  • 2 edits in trunk/WebCore

2008-09-17 Beth Dakin <Beth Dakin>

Reviewed by Darin Adler.

This is a better fix for: Invalid CSS code crashes Safari
​https://bugs.webkit.org/show_bug.cgi?id=20512

The spec indicates that the only valid input for a counter is a
number or an identifier. So that is exactly what we allow.

  • css/CSSParser.cpp: (WebCore::CSSParser::parseCounterContent):
3:40 PM Changeset in webkit [36566] by barraclough@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-09-17 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Geoff Garen.

Implement JIT generation of CallFrame initialization, for op_call.

1% sunspider 2.5% v8-tests.

  • VM/CTI.cpp: (JSC::CTI::compileOpCall):
  • VM/Machine.cpp: (JSC::Machine::cti_op_call_JSFunction): (JSC::Machine::cti_op_call_NotJSFunction):
3:22 PM Changeset in webkit [36565] by hyatt@apple.com
  • 1 edit in trunk/WebCore/plugins/qt/PluginViewQt.cpp

Fix Qt bustage.

3:21 PM Changeset in webkit [36564] by hyatt@apple.com
  • 1 edit in trunk/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp

Fix Qt bustage.

3:16 PM Changeset in webkit [36563] by alp@webkit.org
  • 3 edits in trunk/WebCore

2008-09-17 Alp Toker <​alp@nuanti.com>

GTK+ build fix. Adapt to use PlatformWidget functions.

  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollViewScrollbar::geometryChanged): (WebCore::ScrollView::addChild): (WebCore::ScrollView::removeChild):
  • platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::ScrollbarGtk): (ScrollbarGtk::~ScrollbarGtk): (ScrollbarGtk::geometryChanged):
3:07 PM Changeset in webkit [36562] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/Widget.h

Fix wx bustage.

3:07 PM Changeset in webkit [36561] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/qt/ScrollViewQt.cpp

Fix Qt bustage.

3:00 PM Changeset in webkit [36560] by weinig@apple.com
  • 3 edits
    3 adds in trunk

WebCore:

2008-09-17 Sam Weinig <​sam@webkit.org>

Reviewed by Adele Peterson.

Patch for <rdar://problem/6133884>
Calling window.resizeTo() on a subframe shouldn't change the window size

Test: fast/dom/Window/window-resize-and-move-sub-frame.html

  • page/DOMWindow.cpp: (WebCore::DOMWindow::moveBy): (WebCore::DOMWindow::moveTo): (WebCore::DOMWindow::resizeBy): (WebCore::DOMWindow::resizeTo):

LayoutTests:

2008-09-17 Sam Weinig <​sam@webkit.org>

Reviewed by Adele Peterson.

Test for <rdar://problem/6133884>
Calling window.resizeTo() on a subframe shouldn't change the window size

  • fast/dom/Window/resources/blank.html: Added.
  • fast/dom/Window/window-resize-and-move-sub-frame-expected.txt: Added.
  • fast/dom/Window/window-resize-and-move-sub-frame.html: Added.
2:49 PM ProposedWebInspectorRearchitecting edited by Dimitri Glazkov
(diff)
2:45 PM ProposedWebInspectorRearchitecting edited by Dimitri Glazkov
(diff)
2:43 PM ProposedWebInspectorRearchitecting edited by Dimitri Glazkov
added random notes (diff)
2:35 PM Changeset in webkit [36559] by Beth Dakin
  • 3 edits
    4 adds in trunk

WebCore:

2008-09-17 Beth Dakin <Beth Dakin>

Reviewed by Adam Roben.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=20512 Invalid CSS
code crashes Safari
and corresponding: <rdar://problem/6173832>

Reading through the spec, it seems like a function is not valid
input for a counter. So this patch checks for that and bails in the
case of invalid input.

  • css/CSSParser.cpp: (WebCore::CSSParser::parseCounterContent):

LayoutTests:

2008-09-17 Beth Dakin <Beth Dakin>

Reviewed by Adam Roben.

Test for ​https://bugs.webkit.org/show_bug.cgi?id=20512 Invalid CSS
code crashes Safari
and corresponding: <rdar://problem/6173832>

  • fast/css/counters/counter-function-input-2-expected.txt: Added.
  • fast/css/counters/counter-function-input-2.html: Added.
  • fast/css/counters/counter-function-input-expected.txt: Added.
  • fast/css/counters/counter-function-input.html: Added.
2:30 PM Changeset in webkit [36558] by hyatt@apple.com
  • 1 edit in trunk/WebCore/plugins/gtk/PluginViewGtk.cpp

Fix Gtk bustage.

2:28 PM Changeset in webkit [36557] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/qt/ScrollViewQt.cpp

Fix Qt bustage.

2:17 PM Changeset in webkit [36556] by hyatt@apple.com
  • 1 edit in trunk/WebCore/WebCore.base.exp

Fix Mac bustage.

2:16 PM Changeset in webkit [36555] by hyatt@apple.com
  • 1 edit in trunk/WebCore/bindings/js/ScriptControllerQt.cpp

Fix Qt bustage

2:14 PM Changeset in webkit [36554] by Antti Koivisto
  • 2 edits in trunk/WebCore

2008-09-17 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Antti Koivisto.

Fix <rdar://problem/6227089>
Crash in WebCore::Frame::setNeedsReapplyStyles()


View is null checked elsewhere too.

  • page/Frame.cpp: (WebCore::Frame::setNeedsReapplyStyles):
1:59 PM Changeset in webkit [36553] by hyatt@apple.com
  • 25 edits in trunk

WebCore:

2008-09-17 David Hyatt <​hyatt@apple.com>

Make the notion of having a native widget backing a Widget cross-platform.
The PlatformWidget abstraction (which already existed) is used for this.

Windows = HWND
Qt = QWidget
Mac = NSView
wx = wxWindow
Gtk = GtkWidget

There are new cross-platform methods that replace all of the unique
platform-specific methods.

platformWidget()
setPlatformWidget()

For plugins, on every platform except Qt on Windows, the plugin's native
widget is now stored in the Widget base class. Since Qt on Windows uses
HWNDs for plugins instead of QWidget, it is the only platform to keep the
m_window variable in PluginView.

Reviewed by Sam Weinig

  • WebCore.base.exp:
  • bindings/js/ScriptControllerMac.mm: (WebCore::ScriptController::createScriptInstanceForWidget):
  • page/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper attachmentView]): (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::passMouseDownEventToWidget): (WebCore::EventHandler::mouseDownViewIfStillGood): (WebCore::EventHandler::passWheelEventToWidget): (WebCore::EventHandler::sendFakeEventsAfterWidgetTracking):
  • platform/Widget.cpp: (WebCore::Widget::init): (WebCore::Widget::setParent): (WebCore::Widget::releasePlatformWidget): (WebCore::Widget::retainPlatformWidget):
  • platform/Widget.h: (WebCore::Widget::platformWidget): (WebCore::Widget::setPlatformWidget):
  • platform/gtk/WidgetGtk.cpp: (WebCore::Widget::Widget): (WebCore::Widget::setFocus): (WebCore::gdkDrawable): (WebCore::Widget::setCursor): (WebCore::Widget::show): (WebCore::Widget::hide): (WebCore::Widget::setEnabled): (WebCore::Widget::isEnabled): (WebCore::Widget::paint):
  • platform/mac/PlatformScreenMac.mm: (WebCore::screenRect): (WebCore::screenAvailableRect):
  • platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::scrollView): (WebCore::ScrollView::update): (WebCore::ScrollView::inWindow):
  • platform/mac/ScrollbarMac.mm: (WebCore::ScrollbarMac::ScrollbarMac): (WebCore::ScrollbarMac::~ScrollbarMac): (WebCore::ScrollbarMac::updateThumbPosition): (WebCore::ScrollbarMac::updateThumbProportion): (WebCore::ScrollbarMac::scrollbarHit):
  • platform/mac/WidgetMac.mm: (WebCore::Widget::Widget): (WebCore::Widget::setEnabled): (WebCore::Widget::isEnabled): (WebCore::Widget::setFocus): (WebCore::Widget::getOuterView): (WebCore::Widget::paint): (WebCore::Widget::invalidate): (WebCore::Widget::invalidateRect): (WebCore::Widget::setIsSelected): (WebCore::Widget::releasePlatformWidget): (WebCore::Widget::retainPlatformWidget):
  • platform/qt/WidgetQt.cpp: (WebCore::WidgetPrivate::WidgetPrivate): (WebCore::Widget::Widget): (WebCore::Widget::setFrameGeometry): (WebCore::Widget::show): (WebCore::Widget::hide): (WebCore::Widget::isEnabled): (WebCore::Widget::setEnabled): (WebCore::Widget::invalidateRect): (WebCore::Widget::containingWindow):
  • platform/win/WidgetWin.cpp: (WebCore::Widget::Widget):
  • platform/wx/WidgetWx.cpp: (WebCore::Widget::Widget): (WebCore::Widget::frameGeometry): (WebCore::Widget::setFocus): (WebCore::Widget::setCursor): (WebCore::Widget::show): (WebCore::Widget::hide): (WebCore::Widget::setFrameGeometry): (WebCore::Widget::setEnabled): (WebCore::Widget::isEnabled): (WebCore::Widget::invalidate): (WebCore::Widget::invalidateRect): (WebCore::Widget::paint):
  • plugins/PluginView.cpp: (WebCore::PluginView::PluginView):
  • plugins/PluginView.h: (WebCore::PluginView::platformPluginWidget):
  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::updateWindow): (WebCore::PluginView::setFocus): (WebCore::PluginView::show): (WebCore::PluginView::hide): (WebCore::PluginView::setParent): (WebCore::PluginView::setNPWindowRect): (WebCore::PluginView::setParentVisible): (WebCore::PluginView::getValue): (WebCore::PluginView::forceRedraw): (WebCore::PluginView::init):
  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::updateWindow): (WebCore::PluginView::setFocus): (WebCore::PluginView::show): (WebCore::PluginView::hide): (WebCore::PluginView::setParent): (WebCore::PluginView::setNPWindowRect): (WebCore::PluginView::setParentVisible): (WebCore::PluginView::getValue): (WebCore::PluginView::~PluginView): (WebCore::PluginView::init):
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginView::updateWindow): (WebCore::PluginView::setFocus): (WebCore::PluginView::show): (WebCore::PluginView::hide): (WebCore::PluginView::paint): (WebCore::PluginView::setParent): (WebCore::PluginView::setParentVisible): (WebCore::PluginView::setNPWindowRect): (WebCore::PluginView::stop): (WebCore::PluginView::invalidateRect): (WebCore::PluginView::forceRedraw): (WebCore::PluginView::~PluginView): (WebCore::PluginView::init):

WebKit/mac:

2008-09-17 David Hyatt <​hyatt@apple.com>

Make the notion of Widget having an underlying native widget cross-platform.

Reviewed by Sam Weinig

  • WebCoreSupport/WebFrameLoaderClient.mm: (NetscapePluginWidget::handleEvent):
  • WebView/WebFrame.mm: (-[WebFrame _dragSourceMovedTo:]): (-[WebFrame _dragSourceEndedAt:operation:]):
  • WebView/WebFrameView.mm: (-[WebFrameView _install]):
  • WebView/WebRenderNode.mm: (copyRenderNode):
1:27 PM Changeset in webkit [36552] by mrowe@apple.com
  • 3 edits in branches/Safari-3-2-branch/WebKit/mac

Merge r36126.

1:27 PM Changeset in webkit [36551] by mrowe@apple.com
  • 13 edits in branches/Safari-3-2-branch

Merge r35950.

1:27 PM Changeset in webkit [36550] by mrowe@apple.com
  • 18 edits in branches/Safari-3-2-branch

Merge r32881.

1:27 PM Changeset in webkit [36549] by mrowe@apple.com
  • 4 edits in branches/Safari-3-2-branch

Versioning.

1:27 PM Changeset in webkit [36548] by mrowe@apple.com
  • 1 edit in branches/Safari-3-2-branch/JavaScriptCore/wtf/Vector.h

Merge new Vector::remove variant from r30593.

1:27 PM Changeset in webkit [36547] by mrowe@apple.com
  • 4 edits in branches/Safari-3-2-branch

Versioning.

1:17 PM Changeset in webkit [36546] by barraclough@apple.com
  • 1 edit in trunk/JavaScriptCore/VM/Machine.cpp

build fix

1:16 PM Changeset in webkit [36545] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-09-17 Sam Weinig <​sam@webkit.org>

Fix assert.

  • platform/Widget.cpp: (WebCore::Widget::setParent):
12:29 PM Changeset in webkit [36544] by barraclough@apple.com
  • 4 edits in trunk/JavaScriptCore

2008-09-17 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Geoff Garen.

Optimizations for op_call in CTI. Move check for (ctiCode == 0) into JIT code,
move copying of scopeChain for CodeBlocks that needFullScopeChain into head of
functions, instead of checking prior to making the call.

3% on v8-tests (4% on richards, 6% in delta-blue)

  • VM/CTI.cpp: (JSC::CTI::compileOpCall): (JSC::CTI::privateCompileSlowCases): (JSC::CTI::privateCompile):
  • VM/Machine.cpp: (JSC::Machine::execute): (JSC::Machine::cti_op_call_JSFunction): (JSC::Machine::cti_vm_compile): (JSC::Machine::cti_vm_updateScopeChain): (JSC::Machine::cti_op_construct_JSConstruct):
  • VM/Machine.h:
11:46 AM Changeset in webkit [36543] by hyatt@apple.com
  • 18 edits in trunk/WebCore

2008-09-17 David Hyatt <​hyatt@apple.com>

Beginnings of Widget refactoring (in order to make the mixing of
widgets with and without corresponding native widgets more cross-platform).

This first patch makes the concept of a parent ScrollView cross-platform.

Note the similarity of the show/hide methods on the three PluginViews. This
will be refactored better in a later patch so that they can all share
a base class Widget show/hide method. For now the changes were made
simply to be able to bring WidgetWin's setParent method up into Widget.

Reviewed by Sam Weinig

  • WebCore.base.exp:
  • platform/ScrollView.h:
  • platform/Widget.cpp: (WebCore::Widget::init): (WebCore::Widget::setParent):
  • platform/Widget.h: (WebCore::Widget::isSelfVisible): (WebCore::Widget::isParentVisible): (WebCore::Widget::isVisible): (WebCore::Widget::setParentVisible): (WebCore::Widget::isPluginView): (WebCore::Widget::parent): (WebCore::Widget::handleEvent): (WebCore::Widget::geometryChanged):
  • platform/gtk/WidgetGtk.cpp: (WebCore::Widget::Widget):
  • platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::addChild): (WebCore::ScrollView::removeChild):
  • platform/mac/ScrollbarMac.mm: (WebCore::ScrollbarMac::~ScrollbarMac):
  • platform/mac/WidgetMac.mm: (WebCore::Widget::Widget): (WebCore::Widget::~Widget):
  • platform/qt/WidgetQt.cpp: (WebCore::WidgetPrivate::WidgetPrivate): (WebCore::Widget::Widget): (WebCore::Widget::topLevel):
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::setAncestorVisible): (WebCore::ScrollView::show): (WebCore::ScrollView::hide):
  • platform/win/WidgetWin.cpp: (WebCore::Widget::Widget): (WebCore::Widget::setParent):
  • platform/wx/WidgetWx.cpp: (WebCore::Widget::Widget):
  • plugins/PluginView.cpp: (WebCore::PluginView::PluginView):
  • plugins/PluginView.h:
  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::show): (WebCore::PluginView::hide): (WebCore::PluginView::setParentVisible):
  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::show): (WebCore::PluginView::hide): (WebCore::PluginView::setParentVisible):
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginView::show): (WebCore::PluginView::hide): (WebCore::PluginView::setParentVisible):
11:16 AM ProposedWebInspectorRearchitecting edited by Dimitri Glazkov
added a note on fetchMessages (diff)
11:08 AM ProposedWebInspectorRearchitecting edited by Dimitri Glazkov
minor tweaking of the description. (diff)
11:02 AM ProposedWebInspectorRearchitecting edited by Dimitri Glazkov
added a bit of background description on current InspectorController … (diff)
9:50 AM Changeset in webkit [36542] by ap@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

<rdar://problem/6219577> Spew in console at launch about encoding mappings when running with ICU 4.0

  • platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::registerExtendedEncodingNames): Updated for new encoding names.
6:29 AM Changeset in webkit [36541] by vestbo@webkit.org
  • 4 edits in trunk

2008-09-17 Tor Arne Vestbø <​tavestbo@trolltech.com>

Fix the QtWebKit/Mac build

1:34 AM Changeset in webkit [36540] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/gtk/ScrollViewGtk.cpp

Fix Gtk bustage.

1:17 AM Changeset in webkit [36539] by hyatt@apple.com
  • 7 edits in trunk/WebCore

\2008-09-17 David Hyatt <​hyatt@apple.com>

Add a #define to control whether or not to use an NSScroller on Mac.
This ifdef will allow the new NSView-less NSScroller on Mac to be
developed side by side with the current one.

The new scroller paints a debug red if turned on (although due to
Widget issues you won't see anything paint yet).

Reviewed by olliej

  • platform/Scrollbar.cpp:
  • platform/Scrollbar.h:
  • platform/mac/ScrollbarMac.h:
  • platform/mac/ScrollbarMac.mm:
  • platform/mac/ScrollbarThemeMac.cpp: (WebCore::ScrollbarThemeMac::paint):
  • platform/mac/ScrollbarThemeMac.h:
Note: See TracTimeline for information about the timeline view.