Context Navigation

html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::setScrollLeft): (WebCore::HTMLBodyElement::setScrollTop):
loader/FrameLoader.cpp: (WebCore::FrameLoader::restoreScrollPositionAndViewState):
loader/ImageDocument.cpp: (WebCore::ImageDocument::imageClicked):
page/DOMWindow.cpp: (WebCore::DOMWindow::scrollBy): (WebCore::DOMWindow::scrollTo):
page/FrameView.cpp: (WebCore::FrameView::scrollTo): (WebCore::FrameView::setScrollPosition):
page/FrameView.h:
platform/ScrollView.cpp: (WebCore::ScrollView::maximumScrollPosition):
platform/ScrollView.h: (WebCore::ScrollView::contentsWidth): (WebCore::ScrollView::contentsHeight): (WebCore::ScrollView::scrollBy):
platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::setScrollPosition):
platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::setScrollPosition):
platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::setScrollPosition): (WebCore::ScrollView::scrollRectIntoViewRecursively):
platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::setScrollPosition): (WebCore::ScrollView::scrollRectIntoViewRecursively):
platform/wx/ScrollViewWx.cpp: (WebCore::ScrollView::setScrollPosition):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollByRecursively): (WebCore::RenderLayer::scrollRectToVisible):

10:25 PM Changeset in webkit [36928] by mitz@apple.com

2 edits in trunk/WebCore

Attempted Windows build fix

10:03 PM Changeset in webkit [36927] by hyatt@apple.com

1 edit in trunk/WebCore/platform/gtk/ScrollViewGtk.cpp

Fix Gtk bustage.

9:35 PM Changeset in webkit [36926] by timothy@apple.com

2 edits in trunk/WebCore

Revert the padding changes done in r36905 to prevent the
scrollbar from overlapping the URLs in the Console.

https://bugs.webkit.org/show_bug.cgi?id=21126

page/inspector/inspector.css:

9:28 PM Changeset in webkit [36925] by hyatt@apple.com

18 edits in trunk/WebCore

2008-09-25 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21129

Refactor contents size and scroll offset to be cross-platform. Reduce further the number
of platform-specific methods required of ScrollView implementations.

Reviewed by Tim Hatcher

dom/MouseRelatedEvent.cpp: (WebCore::contentsX): (WebCore::contentsY):
html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::scrollLeft): (WebCore::HTMLBodyElement::setScrollLeft): (WebCore::HTMLBodyElement::scrollTop): (WebCore::HTMLBodyElement::setScrollTop):
loader/FrameLoader.cpp: (WebCore::FrameLoader::saveScrollPositionAndViewStateToItem):
page/DOMWindow.cpp: (WebCore::DOMWindow::scrollX): (WebCore::DOMWindow::scrollY):
page/EventHandler.cpp: (WebCore::EventHandler::hitTestResultAtPoint):
page/FrameView.cpp: (WebCore::FrameView::scrollTo): (WebCore::FrameView::windowClipRect):
platform/ScrollView.cpp: (WebCore::ScrollView::visibleContentRect): (WebCore::ScrollView::contentsSize): (WebCore::ScrollView::platformContentsSize):
platform/ScrollView.h: (WebCore::ScrollView::scrollPosition): (WebCore::ScrollView::scrollOffset): (WebCore::ScrollView::scrollX): (WebCore::ScrollView::scrollY): (WebCore::ScrollView::contentsWidth): (WebCore::ScrollView::contentsHeight):
platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::ScrollViewPrivate::adjustmentChanged): (WebCore::ScrollView::setGtkAdjustments): (WebCore::ScrollView::resizeContents): (WebCore::ScrollView::contentsWidth): (WebCore::ScrollView::contentsHeight): (WebCore::ScrollView::scrollOffset): (WebCore::ScrollView::maximumScroll): (WebCore::ScrollView::scrollBy): (WebCore::ScrollView::suppressScrollbars): (WebCore::ScrollView::setHScrollbarMode): (WebCore::ScrollView::setVScrollbarMode): (WebCore::ScrollView::setScrollbarsMode): (WebCore::ScrollView::setFrameGeometry): (WebCore::ScrollView::updateScrollbars):
platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::platformContentsSize): (WebCore::ScrollView::scrollBy):
platform/mac/WidgetMac.mm: (WebCore::Widget::convertFromContainingWindow): (WebCore::Widget::convertToContainingWindow):
platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::ScrollViewPrivate::valueChanged): (WebCore::ScrollView::resizeContents): (WebCore::ScrollView::setFrameGeometry): (WebCore::ScrollView::scrollOffset): (WebCore::ScrollView::maximumScroll): (WebCore::ScrollView::scrollBy): (WebCore::ScrollView::setHScrollbarMode): (WebCore::ScrollView::setVScrollbarMode): (WebCore::ScrollView::setScrollbarsMode): (WebCore::ScrollView::updateScrollbars):
platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::ScrollViewPrivate::valueChanged): (WebCore::ScrollView::ScrollViewPrivate::setAllowsScrolling): (WebCore::ScrollView::resizeContents): (WebCore::ScrollView::setFrameGeometry): (WebCore::ScrollView::scrollOffset): (WebCore::ScrollView::maximumScroll): (WebCore::ScrollView::scrollBy): (WebCore::ScrollView::setHScrollbarMode): (WebCore::ScrollView::setVScrollbarMode): (WebCore::ScrollView::setScrollbarsMode): (WebCore::ScrollView::updateScrollbars):
platform/wx/ScrollViewWx.cpp: (WebCore::ScrollView::platformVisibleContentRect): (WebCore::ScrollView::platformContentsSize):
rendering/RenderBlock.cpp: (WebCore::RenderBlock::nodeAtPoint):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible): (WebCore::RenderLayer::calculateClipRects): (WebCore::RenderLayer::calculateRects):
rendering/RenderView.cpp: (WebCore::RenderView::absolutePosition): (WebCore::RenderView::computeAbsoluteRepaintRect):

9:05 PM Changeset in webkit [36924] by dsmith@webkit.org

5 edits in trunk/WebCore

2008-09-25 David Smith <catfish.man@gmail.com>

Reviewed by Dave Hyatt.

Fix a nasty regression I introduced in the previous commit, which caused infinite recursion on facebook.

dom/Element.cpp: (WebCore::Element::rareData):
dom/Element.h:
dom/Node.cpp: (WebCore::Node::rareData):
dom/Node.h:

7:36 PM Changeset in webkit [36923] by dsmith@webkit.org

14 edits
2 adds in trunk/WebCore

2008-09-25 David Smith <catfish.man@gmail.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=20980
Split off uncommonly used data from Node similar to ElementRareData

Saves an OwnPtr and a short on Node, as well as providing room for an isContainer bit,
which in turn allows inlining firstChild(), lastChild(), childNodeCount(), and childNode()
for a 5-10+% performance win on SlickSpeed and assorted speedups on other tests.

WebCore.base.exp:
WebCore.xcodeproj/project.pbxproj:
dom/ChildNodeList.cpp: Include ContainerNode to pick up its definitions for childNodeCount(), etc...
dom/ContainerNode.cpp: Set isContainer to true (WebCore::ContainerNode::ContainerNode):
dom/ContainerNode.h: These Node inlines are here to avoid including ContainerNode.h in Node.h (WebCore::Node::containerChildNodeCount): Use ContainerNode's definition, having proved that the Node is a container (WebCore::Node::containerChildNode): ditto (WebCore::Node::containerFirstChild): ditto (WebCore::Node::containerLastChild): ditto
dom/Element.cpp: Most of the changes here are moving ElementRareData to ElementRareData.h and NodeRareData.h (WebCore::Element::Element): (WebCore::Element::~Element): (WebCore::Element::rareData): (WebCore::Element::ensureRareData): Renamed from createRareData (WebCore::Element::createRareData): Used by ensureRareData to get the correct rareData type (WebCore::Element::attach): Check hasRareData rather than null-checking rareData() (WebCore::Element::detach): ditto (WebCore::Element::recalcStyle): ditto (WebCore::Element::focus): (WebCore::Element::minimumSizeForResizing): ditto (WebCore::Element::setMinimumSizeForResizing): ditto (WebCore::Element::computedStyle): (WebCore::Element::cancelFocusAppearanceUpdate): ditto
dom/Element.h:
dom/ElementRareData.h: Added; everything copied from Element.cpp (WebCore::defaultMinimumSizeForResizing): (WebCore::ElementRareData::ElementRareData): (WebCore::ElementRareData::resetComputedStyle):
dom/EventTargetNode.cpp: (WebCore::EventTargetNode::EventTargetNode): Pass the isContainer flag up the chain
dom/EventTargetNode.h:
dom/Node.cpp: (WebCore::Node::Node): (WebCore::Node::~Node): rareData cleanup code moved from Element and changed to use hasRareData (WebCore::Node::rareData): (WebCore::Node::ensureRareData): (WebCore::Node::createRareData): (WebCore::Node::tabIndex): nonzero tab indexes are now in rareData (WebCore::Node::setTabIndexExplicitly): (WebCore::Node::childNodes): NodeLists are now in rareData (WebCore::Node::setFocus): (WebCore::Node::rareDataFocused): (WebCore::Node::isFocusable): (WebCore::Node::isKeyboardFocusable): (WebCore::Node::registerDynamicNodeList): NodeLists are now in rareData (WebCore::Node::unregisterDynamicNodeList): ditto (WebCore::Node::notifyLocalNodeListsAttributeChanged): ditto (WebCore::Node::notifyLocalNodeListsChildrenChanged): ditto (WebCore::Node::getElementsByName): ditto (WebCore::Node::getElementsByClassName): ditto
dom/Node.h: (WebCore::Node::firstChild): Use isContainerNode() to devirtualize (WebCore::Node::lastChild): ditto (WebCore::Node::isContainerNode): Take advantage of a newly freed bit to store whether we're a container (WebCore::Node::focused): focus is in rareData if set (WebCore::Node::childTypeAllowed): (WebCore::Node::childNodeCount): Use isContainerNode() to devirtualize (WebCore::Node::childNode): ditto (WebCore::Node::hasRareData): Use another newly freed bit to store whether we have rare data; avoids doing hash lookups in the common case
dom/NodeRareData.h: Added. Most of this is just properties moved from Node (WebCore::NodeListsNodeData::~NodeListsNodeData): Moved from Node.cpp since we NodeRareData needs to put them in a HashTable :( (WebCore::NodeRareData::NodeRareData): (WebCore::NodeRareData::rareDataMap): (WebCore::NodeRareData::rareDataFromMap): (WebCore::NodeRareData::clearNodeLists): (WebCore::NodeRareData::setNodeLists): (WebCore::NodeRareData::nodeLists): (WebCore::NodeRareData::tabIndex): (WebCore::NodeRareData::setTabIndex): (WebCore::NodeRareData::tabIndexSetExplicitly):
dom/TreeWalker.cpp: Include ContainerNode to pick up its definitions for childNodeCount(), etc...
xml/XPathUtil.cpp: Include ContainerNode to pick up its definitions for childNodeCount(), etc...

6:54 PM Changeset in webkit [36922] by zecke@webkit.org

2 edits in trunk/WebCore

[qt] ImageBuffer::toDataURL implementation

6:47 PM Changeset in webkit [36921] by zecke@webkit.org

3 edits
1 add in trunk/WebCore

[qt] Implement SharedBuffer for Qt

6:26 PM Changeset in webkit [36920] by mjs@apple.com

1 edit
2 adds in trunk/WebKitSite

2008-09-25 Maciej Stachowiak <mjs@apple.com>

Not reviewed.

add some screenshots.

blog-files/acid3-screenshot.png: Added.
blog-files/acid3-timing-screenshot.png: Added.

6:22 PM Changeset in webkit [36919] by hyatt@apple.com

2 edits in trunk/WebKit/mac

2008-09-25 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21101

Fix the updating of the active state to not be dumb, so that viewless scrollbars repaint properly.

Reviewed by Tim Hatcher

WebView/WebHTMLView.mm: (-[WebHTMLView _updateFocusedAndActiveState]):

5:53 PM Changeset in webkit [36918] by ddkilzer@apple.com

11 edits
2 adds in trunk

WebCore:

Fix bug: https://bugs.webkit.org/show_bug.cgi?id=21032
<rdar://problem/6243032>

Reviewed by Dave Hyatt.

Test: fast/dom/attribute-downcast-right.html

Add isMappedAttribute function to Attribute for checking if an object
is an instance of MappedAttribute. Removed attributeItem,
getAttributeItem functions from NamedMappedAttrMap, and callers
expecting MappedAttribute have to check isMappedAttribute before
downcasting the return value to MappedAttribute.

css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::styleForElement):
dom/Attribute.h: (WebCore::Attribute::isMappedAttribute):
dom/MappedAttribute.h: (WebCore::MappedAttribute::isMappedAttribute):
dom/NamedMappedAttrMap.cpp: (WebCore::NamedMappedAttrMap::declCount): (WebCore::NamedMappedAttrMap::mapsEquivalent):
dom/NamedMappedAttrMap.h:
dom/StyledElement.cpp: (WebCore::StyledElement::attributeChanged):
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setInputType):
svg/SVGForeignObjectElement.cpp: (WebCore::addCSSPropertyAndNotifyAttributeMap):
svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::getPresentationAttribute):

LayoutTests:

Test for: https://bugs.webkit.org/show_bug.cgi?id=21032
<rdar://problem/6243032>

Reviewed by Dave Hyatt.

The test crashes webkit if using Windows heap allocator.

fast/dom/attribute-downcast-right-expected.txt: Added.
fast/dom/attribute-downcast-right.html: Added.

5:26 PM Changeset in webkit [36917] by hyatt@apple.com

1 edit in trunk/WebCore/platform/gtk/ScrollViewGtk.cpp

Fix Gtk bustage.

4:13 PM Changeset in webkit [36916] by hyatt@apple.com

2 edits in trunk/WebKit/win

Fix Win bustage.

4:03 PM Changeset in webkit [36915] by hyatt@apple.com

1 edit in trunk/WebCore/platform/win/ScrollViewWin.cpp

Fix Win bustage.

3:52 PM Changeset in webkit [36914] by hyatt@apple.com

1 edit in trunk/WebCore/platform/ScrollView.cpp

Fix Qt, Win, Gtk bustage.

3:47 PM Changeset in webkit [36913] by hyatt@apple.com

1 edit in trunk/WebCore/platform/qt/ScrollViewQt.cpp

Fix Qt bustage.

3:34 PM Changeset in webkit [36912] by hyatt@apple.com

1 edit in trunk/WebCore/platform/ScrollView.cpp

Fix Win, Gtk, Qt bustage.

3:30 PM Changeset in webkit [36911] by hyatt@apple.com

1 edit in trunk/WebKit/qt/Api/qwebframe.cpp

Fix Qt bustage.

3:28 PM Changeset in webkit [36910] by hyatt@apple.com

1 edit in trunk/WebCore/platform/qt/ScrollViewQt.cpp

Fix Qt bustage.

3:25 PM Changeset in webkit [36909] by hyatt@apple.com

12 edits in trunk/WebCore

2008-09-25 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21120

Make visibleContentRect cross-platform. Note this does add new horizontal/verticalScrollbar accessors
to a bunch of platforms. This is a temporary evil until the scrollbars get made cross-platform (and I
didn't want to mix that change in with this patch).

Reviewed by Sam Weinig

page/Frame.cpp: (WebCore::Frame::markAllMatchesForText):
page/FrameView.cpp: (WebCore::FrameView::repaintContentRectangle): (WebCore::FrameView::windowClipRect): (WebCore::FrameView::updateControlTints):
platform/ScrollView.cpp: (WebCore::ScrollView::visibleContentRect): (WebCore::ScrollView::platformVisibleContentRect):
platform/ScrollView.h: (WebCore::ScrollView::visibleWidth): (WebCore::ScrollView::visibleHeight):
platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::horizontalScrollbar): (WebCore::ScrollView::verticalScrollbar):
platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::horizontalScrollbar): (WebCore::ScrollView::verticalScrollbar): (WebCore::ScrollView::platformVisibleContentRect):
platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::horizontalScrollbar): (WebCore::ScrollView::verticalScrollbar):
platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::horizontalScrollbar): (WebCore::ScrollView::verticalScrollbar):
platform/wx/ScrollViewWx.cpp: (WebCore::ScrollView::platformVisibleContentRect): (WebCore::ScrollView::horizontalScrollbar): (WebCore::ScrollView::verticalScrollbar):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible): (WebCore::frameVisibleRect):
rendering/RenderView.cpp: (WebCore::RenderView::viewRect):

2:21 PM Changeset in webkit [36908] by mrowe@apple.com

4 edits in branches/Safari-3-2-branch

Versioning.

1:55 PM Changeset in webkit [36907] by dsmith@webkit.org

3 edits in trunk/WebCore

2008-09-25 David Smith <catfish.man@gmail.com>

Reviewed by Timothy Hatcher

https://bugs.webkit.org/show_bug.cgi?id=21052
Generalize id selector special case for querySelectorAll

By checking the element we get with getElementById against the selector, we can use the special case in many more circumstances.
Changes results on http://native.khan.mozilla.org
from

#title: 2ms
h1#title: 55ms
div #title: 55ms

to:

#title: 1ms
h1#title: 2ms
div #title: 5ms

dom/Node.cpp: (WebCore::Node::querySelector):
dom/SelectorNodeList.cpp: (WebCore::createSelectorNodeList):

1:49 PM Changeset in webkit [36906] by hyatt@apple.com

9 edits in trunk/WebCore

2008-09-25 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21118

Make the concept of whether you can blit on scroll cross-platform on ScrollView.

Reviewed by Sam Weinig

page/FrameView.cpp: (WebCore::FrameView::clear): (WebCore::FrameView::layout): (WebCore::FrameView::setUseSlowRepaints): (WebCore::FrameView::addSlowRepaintObject): (WebCore::FrameView::removeSlowRepaintObject):
platform/ScrollView.cpp: (WebCore::ScrollView::init): (WebCore::ScrollView::addChild): (WebCore::ScrollView::removeChild): (WebCore::ScrollView::setCanBlitOnScroll):
platform/ScrollView.h: (WebCore::ScrollView::canBlitOnScroll):
platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore): (WebCore::ScrollView::ScrollView):
platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::ScrollView): (WebCore::ScrollView::platformAddChild): (WebCore::ScrollView::platformRemoveChild): (WebCore::ScrollView::platformSetCanBlitOnScroll):
platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore): (WebCore::ScrollView::ScrollView):
platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore): (WebCore::ScrollView::ScrollView):
platform/wx/ScrollViewWx.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::ScrollView): (WebCore::ScrollView::scrollBy):

1:29 PM Changeset in webkit [36905] by kmccullough@apple.com

3 edits in trunk/WebCore

2008-09-25 Kevin McCullough <kmccullough@apple.com>

Reviewed by Tim Hatcher.

Bug 21109: Console should right-align urls

page/inspector/Console.js: Re-order the message elements so that when it overflows it doesn't get mixed in with the next message.
page/inspector/inspector.css:

1:15 PM Changeset in webkit [36904] by hyatt@apple.com

5 edits
2 copies in trunk

2008-09-25 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21113

Putting r36771 back in with a fix to the addPendingSheet check in CSSImportRule::insertedIntoParent.

Reviewed by Darin Adler

css/CSSImportRule.cpp: (WebCore::CSSImportRule::insertedIntoParent):
css/CSSRule.cpp: (WebCore::CSSRule::parentStyleSheet): (WebCore::CSSRule::parentRule):
css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::CSSStyleSheet):
css/CSSStyleSheet.h:

1:02 PM Changeset in webkit [36903] by Darin Adler

2 edits in trunk/WebCore

2008-09-25 Darin Adler <Darin Adler>

Reviewed by Adele Peterson.

fix https://bugs.webkit.org/show_bug.cgi?id=21115 <rdar://problem/6245773> REGRESSION (r34702): Safari no longer zips bundled documents

html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData): Use files() instead of value() to get the path, since value() now returns just the basename.

11:37 AM Changeset in webkit [36902] by beidson@apple.com

6 edits
2 deletes in trunk

WebCore:

2008-09-25 Brady Eidson <beidson@apple.com>

Rubberstamped by Mark Rowe

Roll out 36771 as it caused <rdar://problem/6246554>
"nytimes.com doesn't display after returning to it with back/forward"

css/CSSImportRule.cpp: (WebCore::CSSImportRule::insertedIntoParent):
css/CSSRule.cpp: (WebCore::CSSRule::parentStyleSheet): (WebCore::CSSRule::parentRule):
css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::CSSStyleSheet): (WebCore::CSSStyleSheet::docLoader):
css/CSSStyleSheet.h: (WebCore::CSSStyleSheet::doc):

LayoutTests:

2008-09-25 Brady Eidson <beidson@apple.com>

Rubberstamped by Mark Rowe

Roll out 36771 as it caused <rdar://problem/6246554>
"nytimes.com doesn't display after returning to it with back/forward"

fast/css/nested-rule-parent-sheet-expected.txt: Removed.
fast/css/nested-rule-parent-sheet.html: Removed.

10:47 AM Changeset in webkit [36901] by Adam Roben

2 edits in trunk/WebCore

Windows build fix

WebCore.vcproj/WebCore.vcproj: Add ScrollView.cpp to the project.

10:27 AM Changeset in webkit [36900] by mitz@apple.com

2 edits in trunk/WebCore

Windows build fix

platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::addChildPlatformWidget): (WebCore::ScrollView::removeChildPlatformWidget):

10:24 AM Changeset in webkit [36899] by Darin Adler

2 edits in trunk/WebKitSite

2008-09-25 Darin Adler <Darin Adler>

contact.html: Take a cut at making the role of webkitsdk-dev clearer, specifying that it's Mac OS X specific and hosted at Apple, not WebKit.

10:07 AM Changeset in webkit [36898] by timothy@apple.com

2 edits in trunk/WebCore

Fixes a leak of ConsoleMessage seen when repeated console
messages occur.

Reviewed by Mark Rowe.

page/InspectorController.cpp: (WebCore::InspectorController::addConsoleMessage): Delete the repeat since we don't add it to m_consoleMessages.

9:59 AM Changeset in webkit [36897] by mrowe@apple.com

4 edits in branches/Safari-3-2-branch

Versioning.

9:55 AM Changeset in webkit [36896] by mrowe@apple.com

1 copy in tags/Safari-5525.25.2

New tag.

9:48 AM Changeset in webkit [36895] by kmccullough@apple.com

4 edits in trunk/WebCore

2008-09-25 Kevin McCullough <kmccullough@apple.com>

Reviewed by Dan Bernstein.

Bug 21105: XHRs logged in the console may show the wrong URL for the
source

Get the url at the time of the send() and pass it on to the XHR.

bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::send):
xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didFinishLoading):
xml/XMLHttpRequest.h: (WebCore::XMLHttpRequest::setLastSendURL):

9:04 AM Changeset in webkit [36894] by kmccullough@apple.com

4 edits in trunk/WebCore

2008-09-25 Kevin McCullough <kmccullough@apple.com>

Reviewed by Geoff and Tim.

Bug 20322: XHRs logged in the console do not have line numbers

Get the line number at the time of the send and pass it on to the XHR.

bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::send):
xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::XMLHttpRequest): (WebCore::XMLHttpRequest::didFinishLoading):
xml/XMLHttpRequest.h: (WebCore::XMLHttpRequest::setLastSendLineNumber):

8:33 AM Changeset in webkit [36893] by eric.carlson@apple.com

40 edits in trunk

2008-09-25 Eric Carlson <eric.carlson@apple.com>

Reviewed by Eric Seidel.

<rdar://problem/6171047> HTMLMediaElement "begin" event is now "loadstart"
https://bugs.webkit.org/show_bug.cgi?id=21003

dom/EventNames.h: remove "begin" event
html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::load): Post "loadstart" event instead of "begin"

2008-09-25 Eric Carlson <eric.carlson@apple.com>

Reviewed by Eric Seidel.

<rdar://problem/6171047> HTMLMediaElement "begin" event is now "loadstart"
https://bugs.webkit.org/show_bug.cgi?id=21003

Update media layout test results for progress event name change from "begin" to "loadstart"

media/audio-constructor-expected.txt:
media/audio-constructor-src-expected.txt:
media/audio-constructor-src.html:
media/audio-constructor.html:
media/progress-event-expected.txt:
media/progress-event-total-expected.txt:
media/progress-event-total.html:
media/progress-event.html:
media/video-error-abort-expected.txt:
media/video-error-abort.html:
media/video-load-networkState-expected.txt:
media/video-load-networkState.html:
media/video-load-readyState-expected.txt:
media/video-load-readyState.html:
media/video-pause-empty-events-expected.txt:
media/video-pause-empty-events.html:
media/video-play-empty-events-expected.txt:
media/video-play-empty-events.html:
media/video-source-expected.txt:
media/video-source-media-expected.txt:
media/video-source-media.html:
media/video-source-type-expected.txt:
media/video-source-type-params-expected.txt:
media/video-source-type-params.html:
media/video-source-type.html:
media/video-source.html:
media/video-src-change-expected.txt:
media/video-src-change.html:
media/video-src-expected.txt:
media/video-src-remove-expected.txt:
media/video-src-remove.html:
media/video-src-set-expected.txt:
media/video-src-set.html:
media/video-src-source-expected.txt:
media/video-src-source.html:
media/video-src.html:

4:30 AM Changeset in webkit [36892] by ap@webkit.org

4 edits
2 adds in trunk

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=21097
Calling a MessageChannel constructor from a destroyed document results in a crash

Test: fast/events/message-port-constructor-for-deleted-document.html

bindings/js/JSMessageChannelConstructor.cpp: (WebCore::JSMessageChannelConstructor::construct):
bindings/js/JSMessageChannelConstructor.h: Made m_document a RefPtr.

3:15 AM Changeset in webkit [36891] by ap@webkit.org

28 edits
27 adds in trunk

Reviewed by Sam Weinig, Anders Carlsson, and (unofficially) Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=20879
Implement HTML5 channel messaging

Tests: fast/events/message-channel-gc.html

fast/events/message-port-deleted-document.html
fast/events/message-port-deleted-frame.html
fast/events/message-port-inactive-document.html
fast/events/message-port.html
http/tests/security/MessagePort/event-listener-context.html

Configurations/WebCore.xcconfig: Removed unused ENABLE_CROSS_DOCUMENT_MESSAGING macro.

DerivedSources.make: Added MessageChannel and MessagePort.

WebCore.pro: Made MessageEvent compilation unconditional, as it could not possibly be turmed off anyway. Added new files.

GNUmakefile.am:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
WebCoreSources.bkl: Added new files.

bindings/js/JSDOMWindowBase.h:
bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::getValueProperty): Added suport for window.MessageChannel constructor.

bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::postMessage):
page/DOMWindow.cpp: (WebCore::DOMWindow::postMessage):
page/DOMWindow.h:
page/DOMWindow.idl: Added support for three-argument postMessage (that posts a MessagePort).

dom/EventTarget.cpp: (WebCore::EventTarget::toMessagePort):
dom/EventTarget.h:
bindings/js/JSEventTargetBase.cpp: (WebCore::toJS): Added MessagePort as yet another EventTarget variant.

bindings/js/JSMessageChannelConstructor.h:
bindings/js/JSMessageChannelConstructor.cpp: Added a custom constructor, so that it could take a browsing context (document) parameter.

bindings/js/JSMessageChannelCustom.cpp: Added. (WebCore::JSMessageChannel::mark): JSMessageChannel uses a custom mark function to mark port1 and port2 that it owns.

bindings/js/JSMessagePortCustom.cpp: Added. (WebCore::JSMessagePort::startConversation): (WebCore::JSMessagePort::addEventListener): (WebCore::JSMessagePort::removeEventListener): (WebCore::JSMessagePort::dispatchEvent): (WebCore::JSMessagePort::setOnmessage): (WebCore::JSMessagePort::onmessage): (WebCore::JSMessagePort::setOnclose): (WebCore::JSMessagePort::onclose): (WebCore::JSMessagePort::mark):
dom/MessagePort.cpp: Added.
dom/MessagePort.h: Added.
dom/MessagePort.idl: Added. Added a MessagePort implementation. Currently, it is not thread-safe at all, and only works with Documents as contexts, but in the future, it will be used for communication with worker threads.

bindings/objc/DOMInternal.h: Include "DOMMessagePortInternal.h". The new APIs do not really have Obj-C bindings, as they are far from being final, but a MessagePort stub is needed for MessageEvent.

bindings/scripts/CodeGeneratorJS.pm: Include PlatformString.h for MessagePort happiness.

dom/Document.cpp: (WebCore::MessagePortTimer::MessagePortTimer): (WebCore::MessagePortTimer::fired): (WebCore::Document::processMessagePortMessagesSoon): (WebCore::Document::~Document): (WebCore::Document::dispatchMessagePortEvents): (WebCore::Document::createdMessagePort): (WebCore::Document::destroyedMessagePort):
dom/Document.h: Document keeps track of all MessagePort objects that were created when it was fully active in its context.

dom/EventNames.h: Added closeEvent.

dom/MessageChannel.cpp: Added. (WebCore::MessageChannel::MessageChannel): (WebCore::MessageChannel::~MessageChannel):
dom/MessageChannel.h: Added. (WebCore::MessageChannel::create): (WebCore::MessageChannel::port1): (WebCore::MessageChannel::port2):
dom/MessageChannel.idl: Added. Addded JSMessageChannel implementation.

dom/MessageEvent.cpp: (WebCore::MessageEvent::MessageEvent): (WebCore::MessageEvent::initMessageEvent):
dom/MessageEvent.h: (WebCore::MessageEvent::create): (WebCore::MessageEvent::messagePort):
dom/MessageEvent.idl: MessageEvent has a MessagePort member now, making it possible to pass ports across documents.

1:57 AM Changeset in webkit [36890] by dsmith@webkit.org

5 edits
4 adds in trunk

WebCore:

2008-09-25 David Smith <catfish.man@gmail.com>

Reviewed by Eric Seidel

fix https://bugs.webkit.org/show_bug.cgi?id=21091
Regression: querySelector matches tag names case sensitively

Tests: fast/dom/SelectorAPI/caseTag.html

fast/dom/SelectorAPI/caseTagX.xhtml

css/CSSParser.cpp: (WebCore::CSSParser::parseSelector): Add a Document argument, since tag case sensitivity is different for HTML documents
css/CSSParser.h:
dom/Node.cpp: (WebCore::Node::querySelector): (WebCore::Node::querySelectorAll):

LayoutTests:

2008-09-25 David Smith <catfish.man@gmail.com>

Reviewed by Eric Seidel

Tests for https://bugs.webkit.org/show_bug.cgi?id=21091
Regression: querySelector matches tag names case sensitively

ChangeLog:
fast/dom/SelectorAPI/caseTag-expected.txt: Added.
fast/dom/SelectorAPI/caseTag.html: Added.
fast/dom/SelectorAPI/caseTagX-expected.txt: Added.
fast/dom/SelectorAPI/caseTagX.xhtml: Added.

1:23 AM Changeset in webkit [36889] by hyatt@apple.com

1 edit in trunk/WebCore/page/FrameView.cpp

Fix Qt bustage.

1:09 AM Changeset in webkit [36888] by hyatt@apple.com

1 edit in trunk/WebCore/page/JavaScriptDebugServer.cpp

Fix Qt bustage.

12:57 AM Changeset in webkit [36887] by hyatt@apple.com

1 edit in trunk/WebCore/page/JavaScriptDebugServer.cpp

Fix Qt bustage.

12:38 AM Changeset in webkit [36886] by hyatt@apple.com

19 edits
1 add in trunk/WebCore

2008-09-24 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21084

Make the m_children member of ScrollView cross-platform. Consolidate children add/remove
functionality. Add platform stubs for connecting/disconnecting the platform widgets.

Reviewed by Sam Weinig

GNUmakefile.am:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
WebCoreSources.bkl:
platform/ScrollView.h: (WebCore::ScrollView::children):
platform/Widget.h:
platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::addChildPlatformWidget): (WebCore::ScrollView::removeChildPlatformWidget): (WebCore::ScrollView::geometryChanged):
platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::addChildPlatformWidget): (WebCore::ScrollView::removeChildPlatformWidget):
platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::geometryChanged): (WebCore::ScrollView::addChildPlatformWidget): (WebCore::ScrollView::removeChildPlatformWidget):
platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::geometryChanged): (WebCore::ScrollView::setParentVisible): (WebCore::ScrollView::show): (WebCore::ScrollView::hide):
platform/wx/ScrollViewWx.cpp: (WebCore::ScrollView::addChildPlatformWidget): (WebCore::ScrollView::removeChildPlatformWidget):

12:16 AM Changeset in webkit [36885] by mitz@apple.com

3 edits in trunk/WebCore

Reviewed by Dave Hyatt.

fix https://bugs.webkit.org/show_bug.cgi?id=21024 <rdar://problem/6240821> Scrollbar not painted until hovered

rendering/RenderWidget.cpp: (WebCore::RenderWidget::setWidgetGeometry): Replaced resizeWidget with this method, which sets both the location and the size. (WebCore::RenderWidget::setWidget): Replaced the call to resizeWidget with a call to the new method setWidgetGeometry. Positioning the widget correctly ensures that the scroll bars invalidate correctly when they are created and resized.
rendering/RenderWidget.h:

Sep 24, 2008:

8:32 PM Changeset in webkit [36884] by mrowe@apple.com

9 edits in branches/Safari-3-2-branch

Merge r35897.

8:32 PM Changeset in webkit [36883] by mrowe@apple.com

4 edits in branches/Safari-3-2-branch/WebKit/win

Merge r35896.

7:46 PM Changeset in webkit [36882] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

2008-09-24 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.

Move most of the return code back into the callee, now that the callee
doesn't have to calculate anything dynamically.

11.5% speedup on empty function call benchmark.

SunSpider says 0.3% faster. SunSpider --v8 says no change.

VM/CTI.cpp: (JSC::CTI::compileOpCall): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases):

6:10 PM Changeset in webkit [36881] by pewtermoose@webkit.org

2 edits in trunk/WebKit/win

2008-09-24 Matt Lilek <webkit@mattlilek.com>

Reviewed by Darin Adler.

Bug 20999: Inspector hover to select does not work properly on Windows
https://bugs.webkit.org/show_bug.cgi?id=20999
<rdar://problem/6236524>

WebNodeHighlight.cpp: (WebNodeHighlight::show):

6:08 PM Changeset in webkit [36880] by Darin Adler

5 edits in trunk/WebKit/mac

2008-09-24 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=21079 <rdar://problem/6203938> Disallow embedding Safari-generated pages (e.g bookmarks collection) in subframes

DefaultDelegates/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]): Use the new +[WebView _canHandleRequest:forMainFrame:] so we can give a different answer for the main frame and subframes.
WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::canHandleRequest): Ditto.

WebView/WebView.mm: (+[WebView _canHandleRequest:forMainFrame:]): Added forMainFrame. Only look for scheme-specific representations for the main frame, not subframes. (+[WebView _canHandleRequest:]): Give answer for main frame -- calls the method above with YES for main frame.

WebView/WebViewInternal.h: Added _canHandleRequest:forMainFrame:.

5:53 PM Changeset in webkit [36879] by Darin Adler

4 edits in trunk/WebKit

..:

2008-09-24 Darin Adler <Darin Adler>

StringsNotToBeLocalized.txt: Updated for recent changes.

../win:

2008-09-24 Darin Adler <Darin Adler>

English.lproj/Localizable.strings: Updated for recent changes.

5:50 PM Changeset in webkit [36878] by mitz@apple.com

2 edits in trunk/WebCore

Rubber-stamped by Sam Weinig.

create a "style" subfolder under "rendering" and move style files to that folder

WebCore.vcproj/WebCore.vcproj:

5:39 PM Changeset in webkit [36877] by weinig@apple.com

6 edits in trunk

JavaScriptCore:

2008-09-24 Sam Weinig <sam@webkit.org>

Reviewed by Maciej Stachowiak.

Remove staticFunctionGetter. There is only one remaining user of
staticFunctionGetter and it can be converted to use setUpStaticFunctionSlot.

JavaScriptCore.exp:
kjs/lookup.cpp:
kjs/lookup.h:

WebCore:

2008-09-24 Sam Weinig <sam@webkit.org>

Reviewed by Maciej Stachowiak.

Remove staticFunctionGetter. There is only one remaining user of
staticFunctionGetter and it can be converted to use setUpStaticFunctionSlot.

bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::getOwnPropertySlot):

5:26 PM Changeset in webkit [36876] by mjs@apple.com

5 edits in trunk/JavaScriptCore

2008-09-24 Maciej Stachowiak <mjs@apple.com>

Reviewed by Oliver Hunt.

inline JIT fast case of op_neq
remove extra level of function call indirection from slow cases of eq and neq

1% speedup on Richards

VM/CTI.cpp: (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases):
VM/Machine.cpp: (JSC::Machine::privateExecute): (JSC::Machine::cti_op_eq): (JSC::Machine::cti_op_neq):
kjs/operations.cpp: (JSC::equal): (JSC::equalSlowCase):
kjs/operations.h: (JSC::equalSlowCaseInline):

5:07 PM Changeset in webkit [36875] by weinig@apple.com

5 edits
2 adds in trunk

JavaScriptCore:

2008-09-24 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

Fix for https://bugs.webkit.org/show_bug.cgi?id=21080
<rdar://problem/6243534>
Crash below Function.apply when using a runtime array as the argument list

Test: plugins/bindings-array-apply-crash.html

kjs/FunctionPrototype.cpp: (JSC::functionProtoFuncApply): Revert to the slow case if the object inherits from JSArray (via ClassInfo) but is not a JSArray.

WebKitTools:

2008-09-24 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

Fix for https://bugs.webkit.org/show_bug.cgi?id=21080
<rdar://problem/6243534>
Crash below Function.apply when using a runtime array as the argument list

Add method to ObjCController to return a runtime array.

DumpRenderTree/mac/ObjCController.m: (+[ObjCController isSelectorExcludedFromWebScript:]): (+[ObjCController webScriptNameForSelector:]): (-[ObjCController testArray]):

LayoutTests:

2008-09-24 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

Test for https://bugs.webkit.org/show_bug.cgi?id=21080
<rdar://problem/6243534>
Crash below Function.apply when using a runtime array as the argument list

platform/mac/plugins/bindings-array-apply-crash-expected.txt: Added.
platform/mac/plugins/bindings-array-apply-crash.html: Added.

4:40 PM Changeset in webkit [36874] by mitz@apple.com

3 edits
4 adds in trunk

WebCore:

2008-09-24 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Dan Bernstein.

Test: editing/spelling/inline_spelling_markers.html

https://bugs.webkit.org/show_bug.cgi?id=20092 Spelling markers positioned incorrectly in RTL text

Measure spelling markers with selectionRectForText() to fix RTL.

This patch also fixes hit-testing for spelling marker tool tips,
which used to work only on the first line.

rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):

LayoutTests:

2008-09-24 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=20092 Spelling markers positioned incorrectly in RTL text

editing/spelling/inline_spelling_markers.html: Added.
platform/mac/editing/spelling/inline_spelling_markers-expected.checksum: Added.
platform/mac/editing/spelling/inline_spelling_markers-expected.png: Added.
platform/mac/editing/spelling/inline_spelling_markers-expected.txt: Added.

3:26 PM Changeset in webkit [36873] by Darin Adler

1 edit in trunk/JavaScriptCore/ChangeLog

Removed a stray line from a recent ChangeLog entry.

3:24 PM Changeset in webkit [36872] by kmccullough@apple.com

2 edits in trunk/JavaScriptCore

2008-09-24 Kevin McCullough <kmccullough@apple.com>

Style change.

kjs/nodes.cpp: (JSC::statementListEmitCode):

3:19 PM Changeset in webkit [36871] by kmccullough@apple.com

3 edits in trunk/JavaScriptCore

2008-09-24 Kevin McCullough <kmccullough@apple.com>

Reviewed by Geoff.

Bug 21031: Breakpoints in the condition of loops only breaks the first
time

Now when setting breakpoints in the condition of a loop (for, while, for in, and do while) will successfully break each time throught the loop.
For 'for' loops we need a little more complicated behavior that cannot be accomplished without some more significant changes: https://bugs.webkit.org/show_bug.cgi?id=21073

kjs/nodes.cpp: (JSC::statementListEmitCode): We don't want to blindly emit a debug hook at the first line of loops, instead let the loop emit the debug hooks. (JSC::DoWhileNode::emitCode): (JSC::WhileNode::emitCode): (JSC::ForNode::emitCode): (JSC::ForInNode::emitCode):
kjs/nodes.h: (JSC::StatementNode::): (JSC::DoWhileNode::): (JSC::WhileNode::): (JSC::ForInNode::):

2:48 PM Changeset in webkit [36870] by Beth Dakin

2 edits in trunk/WebKitTools

2008-09-24 Beth Dakin <Beth Dakin>

Reviewed by Sam Weinig.

Speculative build fix.

DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::supportsPressAction):

2:45 PM Changeset in webkit [36869] by hyatt@apple.com

7 edits
2 deletes in trunk/WebCore

2008-09-24 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21074

Make sure the viewless scrollbar knows how to paint properly when transformed.

Reviewed by Sam Weinig

platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::ScrollbarThemeMac): (WebCore::ScrollbarThemeMac::paint):

2:28 PM Changeset in webkit [36868] by hyatt@apple.com

2 edits in trunk/WebCore

2008-09-24 David Hyatt <hyatt@apple.com>

Make sure the viewless scrollbar knows how to paint properly when transformed.

Reviewed by Sam Weinig

platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::ScrollbarThemeMac): (WebCore::ScrollbarThemeMac::paint):

2:18 PM Changeset in webkit [36867] by timothy@apple.com

1 edit
3 adds in trunk/WebKitSite

Add new screenshots of the Web Inspector's Scope Variables pane.

Not reviewed.

blog-files/inspector-closure-scope.png: Added.
blog-files/inspector-event-scope.png: Added.
blog-files/inspector-with-scope.png: Added.

2:17 PM Changeset in webkit [36866] by Nikolas Zimmermann

3 edits in trunk/WebCore

Not reviewed. Try to fix win build.
Add missing ChangeLog entry from last commit.

2:13 PM Changeset in webkit [36865] by Darin Adler

1 edit in trunk/JavaScriptCore/ChangeLog

Remove stray characters Maciej pointed out in log.

2:08 PM Changeset in webkit [36864] by Simon Fraser

4 edits in trunk/WebCore

2008-09-24 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

Wrap up dirtying the z-order list of the stacking context
RenderLayer into a method.
https://bugs.webkit.org/show_bug.cgi?id=21072

rendering/RenderLayer.cpp: (WebCore::RenderLayer::setHasVisibleContent): (WebCore::RenderLayer::addChild): (WebCore::RenderLayer::removeChild): (WebCore::RenderLayer::dirtyStackingContextZOrderLists): (WebCore::RenderLayer::styleChanged):
rendering/RenderLayer.h:
rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle):

1:38 PM Changeset in webkit [36863] by ggaren@apple.com

5 edits
1 add in trunk/JavaScriptCore

2008-09-24 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.

Fixed <rdar://problem/5605532> Need a SPI for telling JS the size of
the objects it retains

API/JSBase.h: Filled in some missing function names.

API/tests/testapi.c: Test the new SPI a little.

API/JSSPI.cpp: Add the new SPI.
API/JSSPI.h: Add the new SPI.
JavaScriptCore.exp: Add the new SPI.
JavaScriptCore.xcodeproj/project.pbxproj: Add the new SPI.

1:37 PM Changeset in webkit [36862] by timothy@apple.com

1 edit
1 add in trunk/WebKitSite

Add another screenshot of the Web Inspector.

Not reviewed.

blog-files/inspector-disabling-properties.png: Added.

1:22 PM Changeset in webkit [36861] by kmccullough@apple.com

3 edits in trunk/WebCore

2008-09-24 Kevin McCullough <kmccullough@apple.com>

Reviewed by Tim.

Bug 21070: REGRESSION Repeated messages with arguments are not repeated
or displayed multiple times

The Insepctor Controller was comparing JSValue pointers so thought the message was not a repeat, but the JS of the inspector compared the strings and so knew it was the same message and so overwrote the old message.

page/InspectorController.cpp: (WebCore::ConsoleMessage::isEqual): (WebCore::InspectorController::addMessageToConsole): (WebCore::InspectorController::addConsoleMessage): (WebCore::InspectorController::startGroup): (WebCore::InspectorController::endGroup):
page/InspectorController.h:

1:19 PM Changeset in webkit [36860] by hyatt@apple.com

5 edits in trunk/WebCore

2008-09-24 David Hyatt <hyatt@apple.com>

Make sure the viewless Mac scrollbar responds properly to system preference changes (including the
arrow placement preference and the thumb jump preference).

Reviewed by Adam Roben

platform/Scrollbar.cpp: (WebCore::Scrollbar::Scrollbar): (WebCore::Scrollbar::~Scrollbar):
platform/ScrollbarTheme.h: (WebCore::ScrollbarTheme::registerScrollbar): (WebCore::ScrollbarTheme::unregisterScrollbar):
platform/mac/ScrollbarThemeMac.h:
platform/mac/ScrollbarThemeMac.mm: (+[ScrollbarPrefsObserver appearancePrefsChanged:]): (+[ScrollbarPrefsObserver behaviorPrefsChanged:]): (+[ScrollbarPrefsObserver registerAsObserver]): (WebCore::ScrollbarThemeMac::registerScrollbar): (WebCore::ScrollbarThemeMac::unregisterScrollbar): (WebCore::ScrollbarThemeMac::ScrollbarThemeMac): (WebCore::ScrollbarThemeMac::preferencesChanged):

1:13 PM Changeset in webkit [36859] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

2008-09-24 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.

API/JSBase.h: Filled in some missing function names.

1:06 PM Changeset in webkit [36858] by Nikolas Zimmermann

2 edits
1 add in trunk/WebCore/dom

Reviewed by Oliver.

Add ContainerNodeAlgorithms.h, as central place to share algorithms
operating on TreeShared-derived classes with a Node-style interface.

This allows SVGElementInstance & ContainerNode to share code.

12:50 PM Changeset in webkit [36857] by timothy@apple.com

1 edit
10 adds in trunk/WebKitSite

Add new screenshots of the Web Inspector.

Not reviewed.

blog-files/inspector-console-autocomplete.png: Added.
blog-files/inspector-databases-panel-query-view.png: Added.
blog-files/inspector-databases-panel.png: Added.
blog-files/inspector-elements-panel.png: Added.
blog-files/inspector-numeric-style-stepping.gif: Added.
blog-files/inspector-profiles-panel.png: Added.
blog-files/inspector-resources-panel.png: Added.
blog-files/inspector-scripts-panel.png: Added.
blog-files/inspector-status-bar-with-errors.png: Added.
blog-files/inspector-toolbar.png: Added.

12:23 PM Changeset in webkit [36856] by rwlbuis@webkit.org

3 edits
2 adds in trunk

Reviewed by Darin.

https://bugs.webkit.org/show_bug.cgi?id=20557
getScreenCTM() returns wrong values

Use the absolute position of the svg root when
determining the screen ctm.

Test: svg/custom/getscreenctm-in-mixed-content2.xhtml

11:26 AM Changeset in webkit [36855] by hyatt@apple.com

52 edits in trunk

2008-09-24 David Hyatt <hyatt@apple.com>

Turn off support for CSS variables.

ChangeLog:
css/CSSParser.cpp: (WebCore::CSSParser::createVariablesRule): (WebCore::CSSParser::addVariable): (WebCore::CSSParser::addVariableDeclarationBlock):

11:15 AM Changeset in webkit [36854] by hyatt@apple.com

5 edits
1 delete in trunk

2008-09-24 David Hyatt <hyatt@apple.com>

Back out the alternate forms of CSS variable call syntax (leaving only the -webkit-var version).

css/CSSGrammar.y:
css/CSSParserValues.cpp: (WebCore::CSSParserValue::isVariable):
css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cleanup): (WebCore::CSSPrimitiveValue::getStringValue): (WebCore::CSSPrimitiveValue::cssText): (WebCore::CSSPrimitiveValue::parserValue):
css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::): (WebCore::CSSPrimitiveValue::isVariable):

10:54 AM Changeset in webkit [36853] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

2008-09-24 Geoffrey Garen <ggaren@apple.com>

Reviewed by Cameron Zwarich.

Fixed https://bugs.webkit.org/show_bug.cgi?id=21057
Crash in RegisterID::deref() running fast/canvas/canvas-putImageData.html

VM/CodeGenerator.h: Changed declaration order to ensure the m_lastConstant, which is a RefPtr that points into m_calleeRegisters, has its destructor called before the destructor for m_calleeRegisters.

10:40 AM Changeset in webkit [36852] by timothy@apple.com

2 edits in trunk/WebKitSite

demos/drosera/demo.js: Add some console.profile() calls.

10:02 AM Changeset in webkit [36851] by Darin Adler

9 edits in trunk/JavaScriptCore

2008-09-24 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=21047 speed up ret_activation with inlining

About 1% on v8-raytrace.

JavaScriptCore.exp: Removed JSVariableObject::setRegisters.

kjs/JSActivation.cpp: Moved copyRegisters to the header to make it inline.
kjs/JSActivation.h: (JSC::JSActivation::copyRegisters): Moved here. Also removed the registerArraySize argument to setRegisters, since the object doesn't need to store the number of registers.

kjs/JSGlobalObject.cpp: (JSC::JSGlobalObject::reset): Removed unnecessary clearing left over from when we used this on objects that weren't brand new. These days, this function is really just part of the constructor.

kjs/JSGlobalObject.h: Added registerArraySize to JSGlobalObjectData, since JSVariableObjectData no longer needs it. Added a setRegisters override here that handles storing the size.

kjs/JSStaticScopeObject.h: Removed code to set registerArraySize, since it no longer exists.

kjs/JSVariableObject.cpp: Moved copyRegisterArray and setRegisters to the header to make them inline.
kjs/JSVariableObject.h: Removed registerArraySize from JSVariableObjectData, since it was only used for the global object. (JSC::JSVariableObject::copyRegisterArray): Moved here ot make it inline. (JSC::JSVariableObject::setRegisters): Moved here to make it inline. Also removed the code to set registerArraySize and changed an if statement into an assert to save an unnnecessary branch.

9:39 AM Changeset in webkit [36850] by mitz@apple.com

1 edit in trunk/WebCore/ChangeLog

Added bug URLs for r36001

9:23 AM Changeset in webkit [36849] by timothy@apple.com

2 edits in trunk/WebCore

Fixes a regression where the "incorrect MIME-type" warning would not
show up correctly in the Console or the resources sidebar.

Reviewed by Kevin McCullough.

page/inspector/Resource.js: (WebInspector.Resource.prototype._addTip): Add the repeat count argument to the WebInspector.ConsoleMessage constructor call. (WebInspector.Resource.prototype._checkWarning): Ditto.

6:47 AM Changeset in webkit [36848] by vestbo@webkit.org

5 edits in trunk

2008-09-23 Tor Arne Vestbø <tavestbo@trolltech.com>

Reviewed by Simon.

Remove deprecated JS Qt bindings object call/construct code and fix autotests

1:11 AM Changeset in webkit [36847] by mjs@apple.com

4 edits in trunk/JavaScriptCore

2008-09-24 Maciej Stachowiak <mjs@apple.com>

Reviewed by Oliver Hunt.

inline PropertyMap::getOffset to speed up polymorphic lookups

~1.5% speedup on v8 benchmark
no effect on SunSpider

JavaScriptCore.exp:
kjs/PropertyMap.cpp:
kjs/PropertyMap.h: (JSC::PropertyMap::getOffset):

12:43 AM Changeset in webkit [36846] by jmalonzo@webkit.org

2 edits in trunk/JavaScriptCore

2008-09-24 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Alp Toker.

https://bugs.webkit.org/show_bug.cgi?id=20992
Build fails on GTK+ Mac OS

wtf/ThreadingGtk.cpp: Remove platform ifdef as suggested by Richard Hult. (WTF::initializeThreading):

12:42 AM Changeset in webkit [36845] by jmalonzo@webkit.org

3 edits in trunk

2008-09-23 Richard Hult <richard@imendio.com>

Reviewed by Alp Toker. Landed by Jan Alonzo.

http://bugs.webkit.org/show_bug.cgi?id=20582
[Gtk] Link error on Mac OS X

GNUmakefile.am: Only use the -version-script flag for the gnu linker.
configure.ac: Check for GNU OSes.

12:42 AM Changeset in webkit [36844] by jmalonzo@webkit.org

3 edits in trunk/WebCore

2008-09-23 Julien Chaffraix <jchaffraix@pleyo.com>

Reviewed by Alp Toker. Landed by Jan Alonzo.

Bug 20883: [CURL] Add deferred loading
https://bugs.webkit.org/show_bug.cgi?id=20883

Implement deferred loading for the libcURL backend using curl_easy_pause.
As the method was introduced in version 7.18.0, all the code checks for libcURL
version.

platform/network/curl/ResourceHandleCurl.cpp: (WebCore::ResourceHandle::setDefersLoading):
platform/network/curl/ResourceHandleManager.cpp: (WebCore::writeCallback): Add an assertion that deferred loading is not activated. (WebCore::headerCallback): Ditto. (WebCore::readCallback): Ditto. (WebCore::ResourceHandleManager::dispatchSynchronousJob): Force defersLoading to be false in order to avoid triggering an assertion. (WebCore::ResourceHandleManager::initializeHandle): If deferred loading is activated, pause the easy handle.

12:32 AM Changeset in webkit [36843] by oliver@apple.com

4 edits in trunk/JavaScriptCore

Bug 19968: Slow Script at www.huffingtonpost.com
<https://bugs.webkit.org/show_bug.cgi?id=19968>

Reviewed by Maciej Stachowiak

Finally found the cause of this accursed issue. It is triggered
by synchronous creation of a new global object from JS. The new
global object resets the timer state in this execution group's
Machine, taking timerCheckCount to 0. Then when JS returns the
timerCheckCount is decremented making it non-zero. The next time
we execute JS we will start the timeout counter, however the non-zero
timeoutCheckCount means we don't reset the timer information. This
means that the timeout check is now checking the cumulative time
since the creation of the global object rather than the time since
JS was last entered. At this point the slow script dialog is guaranteed
to eventually be displayed incorrectly unless a page is loaded
asynchronously (which will reset everything into a sane state).

The fix for this is rather trivial -- the JSGlobalObject constructor
should not be resetting the machine timer state.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed