Context Navigation

platform/ScrollView.cpp: (WebCore::ScrollView::windowToContents): (WebCore::ScrollView::contentsToWindow):
platform/ScrollView.h:
platform/gtk/ScrollViewGtk.cpp:
platform/mac/ScrollViewMac.mm:
platform/qt/ScrollViewQt.cpp:
platform/win/ScrollViewWin.cpp:
platform/wx/ScrollViewWx.cpp:

11:15 PM Changeset in webkit [36987] by weinig@apple.com

2 edits in trunk/WebCore

2008-09-26 Sam Weinig <sam@webkit.org>

GTK build fix.

GNUmakefile.am:

10:47 PM Changeset in webkit [36986] by pewtermoose@webkit.org

6 edits in trunk

JavaScriptCore:

2008-09-26 Matt Lilek <webkit@mattlilek.com>

Reviewed by Tim Hatcher.

Update FEATURE_DEFINES after ENABLE_CROSS_DOCUMENT_MESSAGING was removed.

Configurations/JavaScriptCore.xcconfig:

WebKit/mac:

2008-09-26 Matt Lilek <webkit@mattlilek.com>

Reviewed by Tim Hatcher.

Update FEATURE_DEFINES after ENABLE_CROSS_DOCUMENT_MESSAGING was removed.

Configurations/WebKit.xcconfig:

WebKitTools:

2008-09-26 Matt Lilek <webkit@mattlilek.com>

Reviewed by Tim Hatcher.

Update FEATURE_DEFINES after ENABLE_CROSS_DOCUMENT_MESSAGING was removed.

Scripts/build-webkit:

10:26 PM Changeset in webkit [36985] by hyatt@apple.com

10 edits in trunk/WebCore

2008-09-26 David Hyatt <hyatt@apple.com>

Eliminate shouldUpdateWhileOffscreen from ScrollView. Make the concept of not invalidating while
offscreen cross-platform. Rename the inWindow method to isOffscreen (which flips the boolean), since that
more clearly conveys the intent of the method. Make isOffscreen also check NSWindow visibility on Mac.

Reviewed by Oliver Hunt

page/FrameView.cpp: (WebCore::FrameView::repaintContentRectangle):
page/FrameView.h:
platform/ScrollView.h:
platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::isOffscreen):
platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::updateContents): (WebCore::ScrollView::isOffscreen):
platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::isOffscreen):
platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::isOffscreen):
platform/wx/ScrollViewWx.cpp: (WebCore::ScrollView::isOffscreen):
rendering/RenderObject.cpp: (WebCore::RenderObject::willRenderImage):

10:24 PM Changeset in webkit [36984] by hyatt@apple.com

1 edit in trunk/WebCore/platform/ScrollView.h

Fix WIndows bustage.

9:44 PM Changeset in webkit [36983] by hyatt@apple.com

3 edits in trunk/LayoutTests/platform/mac/editing/selection

Land new result.

9:43 PM Changeset in webkit [36982] by hyatt@apple.com

16 edits in trunk

WebCore:

2008-09-26 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21164

Rework concept of allowsScrolling/setAllowsScrolling to be cross-platform.

Reviewed by Sam Weinig

WebCore.base.exp:
page/FrameView.cpp: (WebCore::FrameView::setAllowsScrolling):
page/FrameView.h:
platform/ScrollView.cpp: (WebCore::ScrollView::setAllowsScrolling):
platform/ScrollView.h: (WebCore::ScrollView::allowsScrolling):
platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::wheelEvent):

WebKit/mac:

2008-09-26 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21164

Rework concept of allowsScrolling/setAllowsScrolling to be cross-platform.

Reviewed by Sam Weinig

WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createFrame):
WebView/WebDynamicScrollBarsView.h:
WebView/WebDynamicScrollBarsView.m:
WebView/WebDynamicScrollBarsViewInternal.h:
WebView/WebFrameView.mm: (-[WebFrameView setAllowsScrolling:]): (-[WebFrameView allowsScrolling]):

8:23 PM Changeset in webkit [36981] by cwzwarich@webkit.org

2 edits in trunk/JavaScriptCore

2008-09-26 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Rubber-stamped by Anders Carlson.

Change the name 'sc' to 'scopeChainNode' in a few places.

kjs/nodes.cpp: (JSC::EvalNode::generateCode): (JSC::FunctionBodyNode::generateCode): (JSC::ProgramNode::generateCode):

8:22 PM Changeset in webkit [36980] by kevino@webkit.org

7 edits in trunk

wx build fixes after Widget/ScrollView changes.

7:44 PM Changeset in webkit [36979] by timothy@apple.com

1 edit
2 adds in trunk/WebKitSite

Add screenshots of searching in the Web Inspector.

Not reviewed.

blog-files/inspector-searching-elements.png: Added.
blog-files/inspector-searching-profiles.png: Added.

7:44 PM Changeset in webkit [36978] by timothy@apple.com

2 edits in trunk/WebCore

Allow searching for paths by always performing the
three search methods in the Elements panel and not
assume a search with a "/" is a XPath query.

https://bugs.webkit.org/show_bug.cgi?id=21159

Reviewed by Geoff Garen.

page/inspector/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.performSearch):

7:36 PM Changeset in webkit [36977] by weinig@apple.com

36 edits in trunk

JavaScriptCore:

2008-09-26 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

Patch for https://bugs.webkit.org/show_bug.cgi?id=21152
Speedup static property get/put

Convert getting/setting static property values to use static functions
instead of storing an integer and switching in getValueProperty/putValueProperty.

kjs/JSObject.cpp: (JSC::JSObject::deleteProperty): (JSC::JSObject::getPropertyAttributes):
kjs/MathObject.cpp: (JSC::MathObject::getOwnPropertySlot):
kjs/NumberConstructor.cpp: (JSC::numberConstructorNaNValue): (JSC::numberConstructorNegInfinity): (JSC::numberConstructorPosInfinity): (JSC::numberConstructorMaxValue): (JSC::numberConstructorMinValue):
kjs/PropertySlot.h: (JSC::PropertySlot::):
kjs/RegExpConstructor.cpp: (JSC::regExpConstructorDollar1): (JSC::regExpConstructorDollar2): (JSC::regExpConstructorDollar3): (JSC::regExpConstructorDollar4): (JSC::regExpConstructorDollar5): (JSC::regExpConstructorDollar6): (JSC::regExpConstructorDollar7): (JSC::regExpConstructorDollar8): (JSC::regExpConstructorDollar9): (JSC::regExpConstructorInput): (JSC::regExpConstructorMultiline): (JSC::regExpConstructorLastMatch): (JSC::regExpConstructorLastParen): (JSC::regExpConstructorLeftContext): (JSC::regExpConstructorRightContext): (JSC::setRegExpConstructorInput): (JSC::setRegExpConstructorMultiline): (JSC::RegExpConstructor::setInput): (JSC::RegExpConstructor::setMultiline): (JSC::RegExpConstructor::multiline):
kjs/RegExpConstructor.h:
kjs/RegExpObject.cpp: (JSC::regExpObjectGlobal): (JSC::regExpObjectIgnoreCase): (JSC::regExpObjectMultiline): (JSC::regExpObjectSource): (JSC::regExpObjectLastIndex): (JSC::setRegExpObjectLastIndex):
kjs/RegExpObject.h: (JSC::RegExpObject::setLastIndex): (JSC::RegExpObject::lastIndex): (JSC::RegExpObject::RegExpObjectData::RegExpObjectData):
kjs/StructureID.cpp: (JSC::StructureID::getEnumerablePropertyNames):
kjs/create_hash_table:
kjs/lexer.cpp: (JSC::Lexer::lex):
kjs/lookup.cpp: (JSC::HashTable::createTable): (JSC::HashTable::deleteTable): (JSC::setUpStaticFunctionSlot):
kjs/lookup.h: (JSC::HashEntry::initialize): (JSC::HashEntry::setKey): (JSC::HashEntry::key): (JSC::HashEntry::attributes): (JSC::HashEntry::function): (JSC::HashEntry::functionLength): (JSC::HashEntry::propertyGetter): (JSC::HashEntry::propertyPutter): (JSC::HashEntry::lexerValue): (JSC::HashEntry::): (JSC::HashTable::entry): (JSC::getStaticPropertySlot): (JSC::getStaticValueSlot): (JSC::lookupPut):

WebCore:

2008-09-26 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

Patch for https://bugs.webkit.org/show_bug.cgi?id=21152
Speedup static property get/put

DerivedSources.make:
GNUmakefile.am:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSDOMBinding.cpp:
bindings/js/JSDOMBinding.h:
bindings/js/JSDOMWindowBase.cpp: (WebCore::getDOMConstructor): (WebCore::jsDOMWindowBaseCrypto): (WebCore::jsDOMWindowBaseEvent): (WebCore::jsDOMWindowBaseImage): (WebCore::jsDOMWindowBaseMessageChannel): (WebCore::jsDOMWindowBaseOption): (WebCore::jsDOMWindowBaseXMLHttpRequest): (WebCore::jsDOMWindowBaseAudio): (WebCore::jsDOMWindowBaseXSLTProcessor): (WebCore::jsDOMWindowBaseOnabort): (WebCore::jsDOMWindowBaseOnblur): (WebCore::jsDOMWindowBaseOnchange): (WebCore::jsDOMWindowBaseOnclick): (WebCore::jsDOMWindowBaseOndblclick): (WebCore::jsDOMWindowBaseOnerror): (WebCore::jsDOMWindowBaseOnfocus): (WebCore::jsDOMWindowBaseOnkeydown): (WebCore::jsDOMWindowBaseOnkeypress): (WebCore::jsDOMWindowBaseOnkeyup): (WebCore::jsDOMWindowBaseOnload): (WebCore::jsDOMWindowBaseOnmousedown): (WebCore::jsDOMWindowBaseOnmousemove): (WebCore::jsDOMWindowBaseOnmouseout): (WebCore::jsDOMWindowBaseOnmouseover): (WebCore::jsDOMWindowBaseOnmouseup): (WebCore::jsDOMWindowBaseOnMouseWheel): (WebCore::jsDOMWindowBaseOnreset): (WebCore::jsDOMWindowBaseOnresize): (WebCore::jsDOMWindowBaseOnscroll): (WebCore::jsDOMWindowBaseOnsearch): (WebCore::jsDOMWindowBaseOnselect): (WebCore::jsDOMWindowBaseOnsubmit): (WebCore::jsDOMWindowBaseOnbeforeunload): (WebCore::jsDOMWindowBaseOnunload): (WebCore::jsDOMWindowBaseOnWebKitAnimationStart): (WebCore::jsDOMWindowBaseOnWebKitAnimationIteration): (WebCore::jsDOMWindowBaseOnWebKitAnimationEnd): (WebCore::jsDOMWindowBaseOnWebKitTransitionEnd): (WebCore::JSDOMWindowBase::getOwnPropertySlot): (WebCore::JSDOMWindowBase::put): (WebCore::setJSDOMWindowBaseOnabort): (WebCore::setJSDOMWindowBaseOnblur): (WebCore::setJSDOMWindowBaseOnchange): (WebCore::setJSDOMWindowBaseOnclick): (WebCore::setJSDOMWindowBaseOndblclick): (WebCore::setJSDOMWindowBaseOnerror): (WebCore::setJSDOMWindowBaseOnfocus): (WebCore::setJSDOMWindowBaseOnkeydown): (WebCore::setJSDOMWindowBaseOnkeypress): (WebCore::setJSDOMWindowBaseOnkeyup): (WebCore::setJSDOMWindowBaseOnload): (WebCore::setJSDOMWindowBaseOnmousedown): (WebCore::setJSDOMWindowBaseOnmousemove): (WebCore::setJSDOMWindowBaseOnmouseout): (WebCore::setJSDOMWindowBaseOnmouseover): (WebCore::setJSDOMWindowBaseOnmouseup): (WebCore::setJSDOMWindowBaseOnMouseWheel): (WebCore::setJSDOMWindowBaseOnreset): (WebCore::setJSDOMWindowBaseOnresize): (WebCore::setJSDOMWindowBaseOnscroll): (WebCore::setJSDOMWindowBaseOnsearch): (WebCore::setJSDOMWindowBaseOnselect): (WebCore::setJSDOMWindowBaseOnsubmit): (WebCore::setJSDOMWindowBaseOnbeforeunload): (WebCore::setJSDOMWindowBaseOnunload): (WebCore::setJSDOMWindowBaseOnWebKitAnimationStart): (WebCore::setJSDOMWindowBaseOnWebKitAnimationIteration): (WebCore::setJSDOMWindowBaseOnWebKitAnimationEnd): (WebCore::setJSDOMWindowBaseOnWebKitTransitionEnd): (WebCore::setJSDOMWindowBaseEvent): (WebCore::setJSDOMWindowBaseAudio): (WebCore::setJSDOMWindowBaseImage): (WebCore::setJSDOMWindowBaseMessageChannel): (WebCore::setJSDOMWindowBaseOption): (WebCore::setJSDOMWindowBaseXMLHttpRequest): (WebCore::setJSDOMWindowBaseXSLTProcessor):
bindings/js/JSDOMWindowBase.h:
bindings/js/JSDOMWindowCustom.cpp: (WebCore::nonCachingStaticCloseFunctionGetter): (WebCore::nonCachingStaticBlurFunctionGetter): (WebCore::nonCachingStaticFocusFunctionGetter): (WebCore::nonCachingStaticPostMessageFunctionGetter):
bindings/js/JSDOMWindowCustom.h: (WebCore::JSDOMWindow::customGetOwnPropertySlot):
bindings/js/JSEventTargetBase.cpp:
bindings/js/JSEventTargetBase.h: (WebCore::JSEventTargetBasePrototype::getOwnPropertySlot): (WebCore::JSEventTargetBasePrototype::classInfo):
bindings/js/JSEventTargetNode.cpp: (WebCore::): (WebCore::JSEventTargetNode::getOwnPropertySlot): (WebCore::JSEventTargetNode::put):
bindings/js/JSEventTargetNode.h: (WebCore::JSEventTargetNode::classInfo): (WebCore::JSEventTargetNode::prototypeClassName):
bindings/js/JSEventTargetSVGElementInstance.cpp: (WebCore::): (WebCore::JSEventTargetSVGElementInstance::getOwnPropertySlot): (WebCore::JSEventTargetSVGElementInstance::put):
bindings/js/JSEventTargetSVGElementInstance.h: (WebCore::JSEventTargetSVGElementInstance::classInfo): (WebCore::JSEventTargetSVGElementInstance::prototypeClassName):
bindings/js/JSHTMLInputElementCustom.cpp: (WebCore::JSHTMLInputElement::customGetOwnPropertySlot):
bindings/js/JSHistoryCustom.cpp: (WebCore::nonCachingStaticBackFunctionGetter): (WebCore::nonCachingStaticForwardFunctionGetter): (WebCore::nonCachingStaticGoFunctionGetter): (WebCore::JSHistory::customGetOwnPropertySlot):
bindings/js/JSLocationCustom.cpp: (WebCore::nonCachingStaticReplaceFunctionGetter): (WebCore::nonCachingStaticReloadFunctionGetter): (WebCore::nonCachingStaticAssignFunctionGetter): (WebCore::JSLocation::customGetOwnPropertySlot): (WebCore::JSLocation::customPut):
bindings/scripts/CodeGeneratorJS.pm:

6:44 PM Changeset in webkit [36976] by barraclough@apple.com

12 edits
1 add in trunk/JavaScriptCore

2008-09-26 Gavin Barraclough <barraclough@apple.com>

Reviewed by Maciej Stachowiak & Oliver Hunt.

Add support for reusing temporary JSNumberCells. This change is based on the observation
that if the result of certain operations is a JSNumberCell and is consumed by a subsequent
operation that would produce a JSNumberCell, we can reuse the object rather than allocating
a fresh one. E.g. given the expression ((a * b) * c), we can statically determine that
(a * b) will have a numeric result (or else it will have thrown an exception), so the result
will either be a JSNumberCell or a JSImmediate.

This patch changes three areas of JSC:

The AST now tracks type information about the result of each node.
This information is consumed in bytecode compilation, and certain bytecode operations now carry the statically determined type information about their operands.
CTI uses the information in a number of fashions:
- Where an operand to certain arithmetic operations is reusable, it will plant code to try to perform the operation in JIT code & reuse the cell, where appropriate.
- Where it can be statically determined that an operand can only be numeric (typically the result of another arithmetic operation) the code will not redundantly check that the JSCell is a JSNumberCell.
- Where either of the operands to an add are non-numeric do not plant an optimized arithmetic code path, just call straight out to the C function.

+6% Sunspider (10% progression on 3D, 16% progression on math, 60% progression on access-nbody),
+1% v8-tests (improvements in raytrace & crypto)

VM/CTI.cpp: Add optimized code generation with reuse of temporary JSNumberCells.
VM/CTI.h:
kjs/JSNumberCell.h:
masm/X86Assembler.h:

VM/CodeBlock.cpp: Add type information to specific bytecodes.
VM/CodeGenerator.cpp:
VM/CodeGenerator.h:
VM/Machine.cpp:

kjs/nodes.cpp: Track static type information for nodes.
kjs/nodes.h:
kjs/ResultDescriptor.h: (Added)
JavaScriptCore.xcodeproj/project.pbxproj:

4:01 PM Changeset in webkit [36975] by alice.liu@apple.com

2 edits in trunk/WebKitTools

2008-09-26 Alice Liu <alice.liu@apple.com>

Remove usage of atlstr.h and CString for VCExpress compatibility

Reviewed by Stephanie Lewis.

record-memory-win/main.cpp: (ProcessArgs): (UseImage): (QueryContinuously): (OneQuery): (OneQueryMP):

3:45 PM Changeset in webkit [36974] by staikos@webkit.org

2 edits in trunk/JavaScriptCore

2008-09-26 Yichao Yin <yichao.yin@torchmobile.com.cn>

Reviewed by George Staikos, Maciej Stachowiak.

Add utility functions needed for upcoming WML code.

wtf/ASCIICType.h: (WTF::isASCIIPrintable):

3:43 PM Changeset in webkit [36973] by ggaren@apple.com

4 edits in trunk/JavaScriptCore

2008-09-26 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.

Reverted the part of r36614 that used static data because static data
is not thread-safe.

3:40 PM Changeset in webkit [36972] by ggaren@apple.com

8 edits in trunk/JavaScriptCore

2008-09-26 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.

Removed dynamic check for whether the callee needs an activation object.
Replaced with callee code to create the activation object.

0.5% speedup on SunSpider.
No change on v8 benchmark. (Might be a speedup, but it's in range of the
variance.)

0.7% speedup on v8 benchmark in bytecode.
1.3% speedup on empty call benchmark in bytecode.

VM/CTI.cpp: (JSC::CTI::privateCompileMainPass): Added support for op_init_activation, the new opcode that specifies that the callee's initialization should create an activation object. (JSC::CTI::privateCompile): Removed previous code that did a similar thing in an ad-hoc way.

VM/CodeBlock.cpp: (JSC::CodeBlock::dump): Added a case for dumping op_init_activation.

VM/CodeGenerator.cpp: (JSC::CodeGenerator::generate): Added fixup code to change op_init to op_init_activation if necessary. (With a better parser, we would know which to use from the beginning.)

VM/Instruction.h: (JSC::Instruction::Instruction): (WTF::): Faster traits for the instruction vector. An earlier version of this patch relied on inserting at the beginning of the vector, and depended on this change for speed.

VM/Machine.cpp: (JSC::Machine::execute): Removed clients of setScopeChain, the old abstraction for dynamically checking for whether an activation object needed to be created. (JSC::Machine::privateExecute): ditto

(JSC::Machine::cti_op_push_activation): Renamed this function from
cti_vm_updateScopeChain, and made it faster by removing the call to
setScopeChain.

VM/Machine.h:

VM/Opcode.h: Declared op_init_activation.

2:57 PM Changeset in webkit [36971] by hyatt@apple.com

3 edits in trunk/WebKit/win

fix Win bustage.

2:53 PM Changeset in webkit [36970] by hyatt@apple.com

1 edit in trunk/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp

fix Win bustage.

2:45 PM Changeset in webkit [36969] by hyatt@apple.com

1 edit in trunk/WebCore/platform/win/ScrollViewWin.cpp

Fix Win bustage.

2:35 PM Changeset in webkit [36968] by hyatt@apple.com

1 edit in trunk/WebKit/qt/Api/qwebframe.cpp

Fix Qt bustage.

2:35 PM Changeset in webkit [36967] by kevino@webkit.org

2 edits in trunk/WebKitTools

wx build fix. Update the version of libpng.

2:22 PM Changeset in webkit [36966] by hyatt@apple.com

1 edit in trunk/WebCore/platform/qt/ScrollViewQt.cpp

Fix Qt bustage.

2:19 PM Changeset in webkit [36965] by mrowe@apple.com

4 edits in branches/Safari-3-2-branch

Versioning.

2:00 PM Changeset in webkit [36964] by hyatt@apple.com

1 edit in trunk/WebCore/platform/gtk/ScrollViewGtk.cpp

Fix gtk bustage.

1:54 PM Changeset in webkit [36963] by hyatt@apple.com

1 edit in trunk/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp

Fix gtk bustage.

1:49 PM Changeset in webkit [36962] by hyatt@apple.com

17 edits in trunk

WebCore:

2008-09-26 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21149

Make the concept of scroll modes cross-platform. Move the scrollbars up into ScrollView as well.
Eliminate the unused isScrollable() method.

Reviewed by Sam Weinig

WebCore.base.exp:
page/FrameView.cpp: (WebCore::FrameView::resetScrollbars): (WebCore::FrameView::initScrollbars): (WebCore::FrameView::layout):
page/FrameView.h:
page/mac/WebCoreFrameView.h:
platform/ScrollView.cpp: (WebCore::ScrollView::init): (WebCore::ScrollView::setScrollbarModes): (WebCore::ScrollView::scrollbarModes): (WebCore::ScrollView::platformSetScrollbarModes): (WebCore::ScrollView::platformScrollbarModes):
platform/ScrollView.h: (WebCore::ScrollView::horizontalScrollbar): (WebCore::ScrollView::verticalScrollbar): (WebCore::ScrollView::isScrollViewScrollbar): (WebCore::ScrollView::setHorizontalScrollbarMode): (WebCore::ScrollView::setVerticalScrollbarMode): (WebCore::ScrollView::horizontalScrollbarMode): (WebCore::ScrollView::verticalScrollbarMode): (WebCore::ScrollView::convertSelfToChild):
platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar): (WebCore::ScrollView::ScrollViewPrivate::setHasVerticalScrollbar): (WebCore::ScrollView::ScrollViewPrivate::valueChanged): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::scrollbarUnderMouse): (WebCore::ScrollView::isScrollViewScrollbar): (WebCore::ScrollView::paint): (WebCore::ScrollView::scroll):
platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::platformSetScrollbarModes): (WebCore::ScrollView::platformScrollbarModes):
platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar): (WebCore::ScrollView::ScrollViewPrivate::setHasVerticalScrollbar): (WebCore::ScrollView::ScrollViewPrivate::valueChanged): (WebCore::ScrollView::horizontalScrollbar): (WebCore::ScrollView::verticalScrollbar): (WebCore::ScrollView::invalidateScrollbars): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::scrollbarUnderMouse): (WebCore::ScrollView::paint): (WebCore::ScrollView::scroll):
platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar): (WebCore::ScrollView::ScrollViewPrivate::setHasVerticalScrollbar): (WebCore::ScrollView::ScrollViewPrivate::valueChanged): (WebCore::ScrollView::ScrollViewPrivate::setAllowsScrolling): (WebCore::ScrollView::ScrollViewPrivate::allowsScrolling): (WebCore::ScrollView::suppressScrollbars): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::scrollbarUnderMouse): (WebCore::ScrollView::paint): (WebCore::ScrollView::scroll):
platform/wx/ScrollViewWx.cpp: (WebCore::ScrollView::platformSetScrollbarModes): (WebCore::ScrollView::platformScrollbarModes):

WebKit/mac:

2008-09-26 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21149

More refactoring to make scrollbar modes cross-platform. Reduce the protocol that
WebDynamicScrollBarsView has to implement for communicating with WebCore to just three methods.

Reviewed by Sam Weinig

WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView scrollingModes:WebCore::vertical:WebCore::]): (-[WebDynamicScrollBarsView setHorizontalScrollingMode:andLock:]): (-[WebDynamicScrollBarsView setVerticalScrollingMode:andLock:]): (-[WebDynamicScrollBarsView setScrollingModes:vertical:andLock:]):
WebView/WebDynamicScrollBarsViewInternal.h:
WebView/WebFrameView.mm: (-[WebFrameView setAllowsScrolling:]):
WebView/WebView.mm: (-[WebView setAlwaysShowVerticalScroller:]): (-[WebView setAlwaysShowHorizontalScroller:]):

1:47 PM Changeset in webkit [36961] by ddkilzer@apple.com

7 edits in trunk

Fix Mac build with XPATH and XSLT disabled

WebCore:

Fix Mac build with XPATH and XSLT disabled

Reviewed by Alexey.

bindings/objc/DOMUtility.mm: (JSC::createDOMWrapper): Conditionalize code with ENABLE(XPATH).
dom/XMLTokenizerLibxml2.cpp: (WebCore::errorFunc): Conditionalize method with ENABLE(XSLT) to prevent an unused code warning.

WebKit/mac:

Fix Mac build with XSLT disabled

Reviewed by Alexey.

Misc/WebCache.mm: (+[WebCache statistics]): Populate xslStyleSheet statistics with zeros if XSLT is disabled.

WebKit/win:

Speculative Windows build fix with XSLT disabled

Reviewed by Alexey.

WebCache.cpp: (WebCache::statistics): Populate xslStyleSheet statistics with zeros if XSLT is disabled.

10:57 AM Changeset in webkit [36960] by kmccullough@apple.com

2 edits in trunk/WebCore

2008-09-26 Kevin McCullough <kmccullough@apple.com>

Rubber stamped by Tim Hatcher.

Bug 21098: Crashing under Console::log

Speculative ASSERT to help find the problem.

page/InspectorController.cpp: (WebCore::ConsoleMessage::isEqual):

10:56 AM Changeset in webkit [36959] by zecke@webkit.org

2 edits in trunk/WebCore

[gtk+] Build fix for the latest ScrollView changes

10:27 AM Changeset in webkit [36958] by timothy@apple.com

3 edits in trunk/WebCore

Fixes a bug where the console message repeat count would be wrong
when typing commands in between repeated messages.

https://bugs.webkit.org/show_bug.cgi?id=21145

Reviewed by Kevin McCullough.

page/InspectorController.cpp: (WebCore::InspectorController::clearConsoleMessages): Reset m_groupLevel. (WebCore::InspectorController::didCommitLoad): Call clearConsoleMessages.
page/inspector/Console.js: (WebInspector.Console.prototype.addMessage): Remember the original repeat count for each message as totalRepeatCount, since we now modify repeatCount to mean repeats since previous console command. If repeatCountBeforeCommand is a number, subtract that value from the repeatCount. (WebInspector.Console.prototype.clearMessages): Delete the repeatCountBeforeCommand and commandSincePreviousMessage properties.

10:26 AM Changeset in webkit [36957] by eric.carlson@apple.com

17 edits in trunk/WebCore

2008-09-26 Eric Carlson <eric.carlson@apple.com>

Reviewed by Antti

https://bugs.webkit.org/show_bug.cgi?id=21116
<rdar://problem/5726325> Audio from <video> can still be heard after navigating
back to page with <video>, then closing tab

Rename willSaveToCache/didRestoreFromCache callbacks to documentWillBecomeInactive/
documentDidBecomeActive, and post documentWillBecomeInactive when a page is marked for
deletion.

dom/Document.cpp: (WebCore::Document::documentWillBecomeInactive): (WebCore::Document::documentDidBecomeActive): (WebCore::Document::registerForDocumentActivationCallbacks): (WebCore::Document::unregisterForDocumentActivationCallbacks):
dom/Document.h:
dom/Element.h: (WebCore::Element::documentWillBecomeInactive): (WebCore::Element::documentDidBecomeActive):
history/CachedPage.cpp: (WebCore::CachedPage::CachedPage):
html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::~HTMLFormElement): (WebCore::HTMLFormElement::parseMappedAttribute): (WebCore::HTMLFormElement::documentDidBecomeActive): (WebCore::HTMLFormElement::willMoveToNewOwnerDocument): (WebCore::HTMLFormElement::didMoveToNewOwnerDocument):
html/HTMLFormElement.h:
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::~HTMLInputElement): (WebCore::HTMLInputElement::setInputType): (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::needsActivationCallback): (WebCore::HTMLInputElement::registerForActivationCallbackIfNeeded): (WebCore::HTMLInputElement::unregisterForActivationCallbackIfNeeded): (WebCore::HTMLInputElement::documentDidBecomeActive): (WebCore::HTMLInputElement::willMoveToNewOwnerDocument): (WebCore::HTMLInputElement::didMoveToNewOwnerDocument):
html/HTMLInputElement.h:
html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): (WebCore::HTMLMediaElement::~HTMLMediaElement): (WebCore::HTMLMediaElement::documentWillBecomeInactive): (WebCore::HTMLMediaElement::documentDidBecomeActive):
html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::inActiveDocument):
loader/FrameLoader.cpp: (WebCore::FrameLoader::opened):
page/Page.cpp: (WebCore::Page::~Page):
rendering/RenderMedia.cpp: (WebCore::RenderMedia::updateControls):
rendering/RenderVideo.cpp: (WebCore::RenderVideo::updatePlayer):
svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::SVGSVGElement): (WebCore::SVGSVGElement::~SVGSVGElement): (WebCore::SVGSVGElement::documentWillBecomeInactive): (WebCore::SVGSVGElement::documentDidBecomeActive):
svg/SVGSVGElement.h:

9:30 AM Changeset in webkit [36956] by Simon Hausmann

2 edits in trunk/WebCore

2008-09-26 Ariya Hidayat <ariya.hidayat@trolltech.com>

Reviewed by Simon

Fix the build inside Qt, don't create faulty prl files for now.

6:17 AM Changeset in webkit [36955] by Simon Hausmann

4 edits in trunk/WebCore

2008-09-26 Simon Hausmann <Simon Hausmann>

Fix compilation on Qt/Windows

Add WebCore/ to the include path so that config.h is found that enables JSC
Link against winmm for the multimedia timer functions
Include DateMath.h instead of JavaScriptCore/DateMath.h as file is in the kjs/ subdirectory
In PluginViewWin.cpp don't use setPlatformWidget with the HWND for the Qt/Windows port but set m_window directly as setPlatformWidget takes a QWidget*.

4:53 AM Changeset in webkit [36954] by oliver@apple.com

14 edits
6 adds in trunk

Bug 21054: Construction of certain DOM objects is heavily regressed by r36675
<https://bugs.webkit.org/show_bug.cgi?id=21054>

Reviewed by Maciej Stachowiak

This performance regression is actually just a symptom of a correctness
bug. The constructor objects for a number of properties that have security
checks on access were returning new objects each time. The most obvious
symptom of this bug is that window.Image != window.Image, etc.

The solution to this is to make sure we cache these constructors
in the same way as all the other DOM constructors. To achieve this
without causing any refcount cycles it is necessary to replace the
refcounted document pointer in the Image, MessageChannel, Option,
XMLHttpRequest, and Audio constructor objects with a reference to
the document's JS wrapper.

Tests: fast/dom/constructors-cached-navigate.html

fast/dom/constructors-cached.html

3:55 AM Changeset in webkit [36953] by Simon Hausmann

2 edits in trunk/WebCore

2008-09-26 Simon Hausmann <Simon Hausmann>

Unreviewed one-liner build fix for the Qt/Windows build.

The build requires NPAPI support to be enabled, fix the condition in
the .pro file for that.

3:51 AM Changeset in webkit [36952] by Simon Hausmann

2 edits in trunk/WebCore

2008-09-26 Trenton Schulz <twschulz@trolltech.com>

Reviewed by Simon.

Fix compilation with the Qt/Cocoa port.

2:37 AM Changeset in webkit [36951] by Simon Hausmann

2 edits in trunk/WebCore

2008-09-26 Simon Hausmann <Simon Hausmann>

Reviewed by Holger.

Fix compilation with VC9SP1, work around bug in TR1 library by
disabling it.

2:37 AM Changeset in webkit [36950] by Simon Hausmann

2 edits in trunk/WebCore

2008-09-26 Simon Hausmann <Simon Hausmann>

Reviewed by Holger.

Fix an lupdate() warning.

Don't use tr() in a class that is not a QObject, use
QCoreApplication::translate() directly.

2:36 AM Changeset in webkit [36949] by Simon Hausmann

3 edits in trunk/WebKit/qt

2008-09-26 Ariya Hidayat <ahidayat@trolltech.com>

Reviewed by Simon.

Fixed potential crash when deleting QWebView instance.

When deleting the view, sets the page's view to NULL.
The reason is that the page is smart and its destructor might lead to a call
that operates on a view (which is in the process of being deleted).

2:36 AM Changeset in webkit [36948] by Simon Hausmann

2 edits in trunk/WebKit/qt

2008-09-26 Ariya Hidayat <ahidayat@trolltech.com>

Reviewed by Simon.

Fixed using modifiers to type special symbols (e.g '@','$') does not work on Mac OS X.

2:36 AM Changeset in webkit [36947] by Simon Hausmann

2 edits in trunk/WebKit/qt

2008-09-26 Håvard Wall <hwall@trolltech.com>

Reviewed by Simon.

Fix compilation with QT_NO_MESSAGEBOX

12:19 AM Changeset in webkit [36946] by hyatt@apple.com

1 edit in trunk/WebCore/platform/gtk/ScrollViewGtk.cpp

Fix Gtk bustage.

12:15 AM Changeset in webkit [36945] by hyatt@apple.com

1 edit in trunk/WebCore/platform/wx/ScrollViewWx.cpp

Fix wx bustage.

12:15 AM Changeset in webkit [36944] by hyatt@apple.com

1 edit in trunk/WebCore/platform/ScrollView.cpp

Fix Win, Gtk, Qt bustage.

12:07 AM Changeset in webkit [36943] by hyatt@apple.com

1 edit in trunk/WebKit/qt/Api/qwebframe.cpp

Fix Qt bustage.

12:03 AM Changeset in webkit [36942] by hyatt@apple.com

1 edit in trunk/WebKit/win/WebView.cpp

Fix Win bustage.

Sep 25, 2008:

11:50 PM Changeset in webkit [36941] by hyatt@apple.com

1 edit in trunk/WebCore/platform/qt/ScrollViewQt.cpp

Put back a hide() call on Qt that I accidentally removed.

11:47 PM Changeset in webkit [36940] by hyatt@apple.com

3 edits in trunk/WebCore/platform

Fix Win, Qt, Gtk bustage.

11:45 PM Changeset in webkit [36939] by hyatt@apple.com

1 edit in trunk/WebCore/platform/gtk/ScrollViewGtk.cpp

Fix Gtk bustage.

11:44 PM Changeset in webkit [36938] by hyatt@apple.com

1 edit in trunk/WebCore/platform/qt/ScrollViewQt.cpp

Fix Qt bustage.

11:33 PM Changeset in webkit [36937] by hyatt@apple.com

1 edit in trunk/WebCore/platform/win/ScrollViewWin.cpp

Fix Win bustage.

11:32 PM Changeset in webkit [36936] by hyatt@apple.com

1 edit in trunk/WebKit/gtk/webkit/webkitwebview.cpp

Fix Gtk bustage.

11:30 PM Changeset in webkit [36935] by hyatt@apple.com

1 edit in trunk/WebCore/platform/graphics/IntPoint.h

Fix Win, Gtk, Qt bustage.

11:21 PM Changeset in webkit [36934] by hyatt@apple.com

3 edits in trunk/WebCore

2008-09-25 David Hyatt <hyatt@apple.com>

Remove the scrollTo() method from FrameView, since it is not used by anyone.

Reviewed by Oliver Hunt

page/FrameView.cpp:
page/FrameView.h:

11:17 PM Changeset in webkit [36933] by hyatt@apple.com

1 edit in trunk/WebCore/platform/ScrollView.h

Add some comments to the ScrollView.h header.

11:15 PM Changeset in webkit [36932] by hyatt@apple.com

7 edits in trunk/WebCore

2008-09-25 David Hyatt <hyatt@apple.com>

Make scrollRectIntoViewRecursively cross-platform.

Reviewed by Oliver Hunt

platform/ScrollView.cpp: (WebCore::ScrollView::scrollRectIntoViewRecursively):
platform/gtk/ScrollViewGtk.cpp:
platform/mac/ScrollViewMac.mm:
platform/qt/ScrollViewQt.cpp:
platform/win/ScrollViewWin.cpp:
platform/wx/ScrollViewWx.cpp:

11:07 PM Changeset in webkit [36931] by hyatt@apple.com

10 edits in trunk/WebCore

2008-09-25 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21133

Rename resizeContents method on ScrollView to setContentsSize (to match contentsSize()). Make it
cross-platform.

Reviewed by Oliver Hunt

loader/FrameLoader.cpp: (WebCore::FrameLoader::begin):
page/FrameView.cpp: (WebCore::FrameView::adjustViewSize):
platform/ScrollView.cpp: (WebCore::ScrollView::setContentsSize):
platform/ScrollView.h: (WebCore::ScrollView::updateScrollbars):
platform/gtk/ScrollViewGtk.cpp:
platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::platformSetContentsSize):
platform/qt/ScrollViewQt.cpp:
platform/win/ScrollViewWin.cpp:
platform/wx/ScrollViewWx.cpp: (WebCore::ScrollView::platformSetContentsSize):

11:03 PM Changeset in webkit [36930] by hyatt@apple.com

1 edit in trunk/WebCore/platform/ScrollView.cpp

Fix Windows bustage when scrolling.

10:40 PM Changeset in webkit [36929] by hyatt@apple.com

15 edits in trunk/WebCore

2008-09-25 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21132

Clean up the methods that actually do the scrolling in ScrollView.

Reviewed by Oliver Hunt

html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::setScrollLeft): (WebCore::HTMLBodyElement::setScrollTop):
loader/FrameLoader.cpp: (WebCore::FrameLoader::restoreScrollPositionAndViewState):
loader/ImageDocument.cpp: (WebCore::ImageDocument::imageClicked):
page/DOMWindow.cpp: (WebCore::DOMWindow::scrollBy): (WebCore::DOMWindow::scrollTo):
page/FrameView.cpp: (WebCore::FrameView::scrollTo): (WebCore::FrameView::setScrollPosition):
page/FrameView.h:
platform/ScrollView.cpp: (WebCore::ScrollView::maximumScrollPosition):
platform/ScrollView.h: (WebCore::ScrollView::contentsWidth): (WebCore::ScrollView::contentsHeight): (WebCore::ScrollView::scrollBy):
platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::setScrollPosition):
platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::setScrollPosition):
platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::setScrollPosition): (WebCore::ScrollView::scrollRectIntoViewRecursively):
platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::setScrollPosition): (WebCore::ScrollView::scrollRectIntoViewRecursively):
platform/wx/ScrollViewWx.cpp: (WebCore::ScrollView::setScrollPosition):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollByRecursively): (WebCore::RenderLayer::scrollRectToVisible):

10:25 PM Changeset in webkit [36928] by mitz@apple.com

2 edits in trunk/WebCore

Attempted Windows build fix

10:03 PM Changeset in webkit [36927] by hyatt@apple.com

1 edit in trunk/WebCore/platform/gtk/ScrollViewGtk.cpp

Fix Gtk bustage.

9:35 PM Changeset in webkit [36926] by timothy@apple.com

2 edits in trunk/WebCore

Revert the padding changes done in r36905 to prevent the
scrollbar from overlapping the URLs in the Console.

https://bugs.webkit.org/show_bug.cgi?id=21126

page/inspector/inspector.css:

9:28 PM Changeset in webkit [36925] by hyatt@apple.com

18 edits in trunk/WebCore

2008-09-25 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21129

Refactor contents size and scroll offset to be cross-platform. Reduce further the number
of platform-specific methods required of ScrollView implementations.

Reviewed by Tim Hatcher

dom/MouseRelatedEvent.cpp: (WebCore::contentsX): (WebCore::contentsY):
html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::scrollLeft): (WebCore::HTMLBodyElement::setScrollLeft): (WebCore::HTMLBodyElement::scrollTop): (WebCore::HTMLBodyElement::setScrollTop):
loader/FrameLoader.cpp: (WebCore::FrameLoader::saveScrollPositionAndViewStateToItem):
page/DOMWindow.cpp: (WebCore::DOMWindow::scrollX): (WebCore::DOMWindow::scrollY):
page/EventHandler.cpp: (WebCore::EventHandler::hitTestResultAtPoint):
page/FrameView.cpp: (WebCore::FrameView::scrollTo): (WebCore::FrameView::windowClipRect):
platform/ScrollView.cpp: (WebCore::ScrollView::visibleContentRect): (WebCore::ScrollView::contentsSize): (WebCore::ScrollView::platformContentsSize):
platform/ScrollView.h: (WebCore::ScrollView::scrollPosition): (WebCore::ScrollView::scrollOffset): (WebCore::ScrollView::scrollX): (WebCore::ScrollView::scrollY): (WebCore::ScrollView::contentsWidth): (WebCore::ScrollView::contentsHeight):
platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::ScrollViewPrivate::adjustmentChanged): (WebCore::ScrollView::setGtkAdjustments): (WebCore::ScrollView::resizeContents): (WebCore::ScrollView::contentsWidth): (WebCore::ScrollView::contentsHeight): (WebCore::ScrollView::scrollOffset): (WebCore::ScrollView::maximumScroll): (WebCore::ScrollView::scrollBy): (WebCore::ScrollView::suppressScrollbars): (WebCore::ScrollView::setHScrollbarMode): (WebCore::ScrollView::setVScrollbarMode): (WebCore::ScrollView::setScrollbarsMode): (WebCore::ScrollView::setFrameGeometry): (WebCore::ScrollView::updateScrollbars):
platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::platformContentsSize): (WebCore::ScrollView::scrollBy):
platform/mac/WidgetMac.mm: (WebCore::Widget::convertFromContainingWindow): (WebCore::Widget::convertToContainingWindow):
platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::ScrollViewPrivate::valueChanged): (WebCore::ScrollView::resizeContents): (WebCore::ScrollView::setFrameGeometry): (WebCore::ScrollView::scrollOffset): (WebCore::ScrollView::maximumScroll): (WebCore::ScrollView::scrollBy): (WebCore::ScrollView::setHScrollbarMode): (WebCore::ScrollView::setVScrollbarMode): (WebCore::ScrollView::setScrollbarsMode): (WebCore::ScrollView::updateScrollbars):
platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::ScrollViewPrivate::valueChanged): (WebCore::ScrollView::ScrollViewPrivate::setAllowsScrolling): (WebCore::ScrollView::resizeContents): (WebCore::ScrollView::setFrameGeometry): (WebCore::ScrollView::scrollOffset): (WebCore::ScrollView::maximumScroll): (WebCore::ScrollView::scrollBy): (WebCore::ScrollView::setHScrollbarMode): (WebCore::ScrollView::setVScrollbarMode): (WebCore::ScrollView::setScrollbarsMode): (WebCore::ScrollView::updateScrollbars):
platform/wx/ScrollViewWx.cpp: (WebCore::ScrollView::platformVisibleContentRect): (WebCore::ScrollView::platformContentsSize):
rendering/RenderBlock.cpp: (WebCore::RenderBlock::nodeAtPoint):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible): (WebCore::RenderLayer::calculateClipRects): (WebCore::RenderLayer::calculateRects):
rendering/RenderView.cpp: (WebCore::RenderView::absolutePosition): (WebCore::RenderView::computeAbsoluteRepaintRect):

9:05 PM Changeset in webkit [36924] by dsmith@webkit.org

5 edits in trunk/WebCore

2008-09-25 David Smith <catfish.man@gmail.com>

Reviewed by Dave Hyatt.

Fix a nasty regression I introduced in the previous commit, which caused infinite recursion on facebook.

dom/Element.cpp: (WebCore::Element::rareData):
dom/Element.h:
dom/Node.cpp: (WebCore::Node::rareData):
dom/Node.h:

7:36 PM Changeset in webkit [36923] by dsmith@webkit.org

14 edits
2 adds in trunk/WebCore

2008-09-25 David Smith <catfish.man@gmail.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=20980
Split off uncommonly used data from Node similar to ElementRareData

Saves an OwnPtr and a short on Node, as well as providing room for an isContainer bit,
which in turn allows inlining firstChild(), lastChild(), childNodeCount(), and childNode()
for a 5-10+% performance win on SlickSpeed and assorted speedups on other tests.

WebCore.base.exp:
WebCore.xcodeproj/project.pbxproj:
dom/ChildNodeList.cpp: Include ContainerNode to pick up its definitions for childNodeCount(), etc...
dom/ContainerNode.cpp: Set isContainer to true (WebCore::ContainerNode::ContainerNode):
dom/ContainerNode.h: These Node inlines are here to avoid including ContainerNode.h in Node.h (WebCore::Node::containerChildNodeCount): Use ContainerNode's definition, having proved that the Node is a container (WebCore::Node::containerChildNode): ditto (WebCore::Node::containerFirstChild): ditto (WebCore::Node::containerLastChild): ditto
dom/Element.cpp: Most of the changes here are moving ElementRareData to ElementRareData.h and NodeRareData.h (WebCore::Element::Element): (WebCore::Element::~Element): (WebCore::Element::rareData): (WebCore::Element::ensureRareData): Renamed from createRareData (WebCore::Element::createRareData): Used by ensureRareData to get the correct rareData type (WebCore::Element::attach): Check hasRareData rather than null-checking rareData() (WebCore::Element::detach): ditto (WebCore::Element::recalcStyle): ditto (WebCore::Element::focus): (WebCore::Element::minimumSizeForResizing): ditto (WebCore::Element::setMinimumSizeForResizing): ditto (WebCore::Element::computedStyle): (WebCore::Element::cancelFocusAppearanceUpdate): ditto
dom/Element.h:
dom/ElementRareData.h: Added; everything copied from Element.cpp (WebCore::defaultMinimumSizeForResizing): (WebCore::ElementRareData::ElementRareData): (WebCore::ElementRareData::resetComputedStyle):
dom/EventTargetNode.cpp: (WebCore::EventTargetNode::EventTargetNode): Pass the isContainer flag up the chain
dom/EventTargetNode.h:
dom/Node.cpp: (WebCore::Node::Node): (WebCore::Node::~Node): rareData cleanup code moved from Element and changed to use hasRareData (WebCore::Node::rareData): (WebCore::Node::ensureRareData): (WebCore::Node::createRareData): (WebCore::Node::tabIndex): nonzero tab indexes are now in rareData (WebCore::Node::setTabIndexExplicitly): (WebCore::Node::childNodes): NodeLists are now in rareData (WebCore::Node::setFocus): (WebCore::Node::rareDataFocused): (WebCore::Node::isFocusable): (WebCore::Node::isKeyboardFocusable): (WebCore::Node::registerDynamicNodeList): NodeLists are now in rareData (WebCore::Node::unregisterDynamicNodeList): ditto (WebCore::Node::notifyLocalNodeListsAttributeChanged): ditto (WebCore::Node::notifyLocalNodeListsChildrenChanged): ditto (WebCore::Node::getElementsByName): ditto (WebCore::Node::getElementsByClassName): ditto
dom/Node.h: (WebCore::Node::firstChild): Use isContainerNode() to devirtualize (WebCore::Node::lastChild): ditto (WebCore::Node::isContainerNode): Take advantage of a newly freed bit to store whether we're a container (WebCore::Node::focused): focus is in rareData if set (WebCore::Node::childTypeAllowed): (WebCore::Node::childNodeCount): Use isContainerNode() to devirtualize (WebCore::Node::childNode): ditto (WebCore::Node::hasRareData): Use another newly freed bit to store whether we have rare data; avoids doing hash lookups in the common case
dom/NodeRareData.h: Added. Most of this is just properties moved from Node (WebCore::NodeListsNodeData::~NodeListsNodeData): Moved from Node.cpp since we NodeRareData needs to put them in a HashTable :( (WebCore::NodeRareData::NodeRareData): (WebCore::NodeRareData::rareDataMap): (WebCore::NodeRareData::rareDataFromMap): (WebCore::NodeRareData::clearNodeLists): (WebCore::NodeRareData::setNodeLists): (WebCore::NodeRareData::nodeLists): (WebCore::NodeRareData::tabIndex): (WebCore::NodeRareData::setTabIndex): (WebCore::NodeRareData::tabIndexSetExplicitly):
dom/TreeWalker.cpp: Include ContainerNode to pick up its definitions for childNodeCount(), etc...
xml/XPathUtil.cpp: Include ContainerNode to pick up its definitions for childNodeCount(), etc...

6:54 PM Changeset in webkit [36922] by zecke@webkit.org

2 edits in trunk/WebCore

[qt] ImageBuffer::toDataURL implementation

6:47 PM Changeset in webkit [36921] by zecke@webkit.org

3 edits
1 add in trunk/WebCore

[qt] Implement SharedBuffer for Qt

6:26 PM Changeset in webkit [36920] by mjs@apple.com

1 edit
2 adds in trunk/WebKitSite

2008-09-25 Maciej Stachowiak <mjs@apple.com>

Not reviewed.

add some screenshots.

blog-files/acid3-screenshot.png: Added.
blog-files/acid3-timing-screenshot.png: Added.

6:22 PM Changeset in webkit [36919] by hyatt@apple.com

2 edits in trunk/WebKit/mac

2008-09-25 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21101

Fix the updating of the active state to not be dumb, so that viewless scrollbars repaint properly.

Reviewed by Tim Hatcher

WebView/WebHTMLView.mm: (-[WebHTMLView _updateFocusedAndActiveState]):

5:53 PM Changeset in webkit [36918] by ddkilzer@apple.com

11 edits
2 adds in trunk

WebCore:

Fix bug: https://bugs.webkit.org/show_bug.cgi?id=21032
<rdar://problem/6243032>

Reviewed by Dave Hyatt.

Test: fast/dom/attribute-downcast-right.html

Add isMappedAttribute function to Attribute for checking if an object
is an instance of MappedAttribute. Removed attributeItem,
getAttributeItem functions from NamedMappedAttrMap, and callers
expecting MappedAttribute have to check isMappedAttribute before
downcasting the return value to MappedAttribute.

css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::styleForElement):
dom/Attribute.h: (WebCore::Attribute::isMappedAttribute):
dom/MappedAttribute.h: (WebCore::MappedAttribute::isMappedAttribute):
dom/NamedMappedAttrMap.cpp: (WebCore::NamedMappedAttrMap::declCount): (WebCore::NamedMappedAttrMap::mapsEquivalent):
dom/NamedMappedAttrMap.h:
dom/StyledElement.cpp: (WebCore::StyledElement::attributeChanged):
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setInputType):
svg/SVGForeignObjectElement.cpp: (WebCore::addCSSPropertyAndNotifyAttributeMap):
svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::getPresentationAttribute):

LayoutTests:

Test for: https://bugs.webkit.org/show_bug.cgi?id=21032
<rdar://problem/6243032>

Reviewed by Dave Hyatt.

The test crashes webkit if using Windows heap allocator.

fast/dom/attribute-downcast-right-expected.txt: Added.
fast/dom/attribute-downcast-right.html: Added.

5:26 PM Changeset in webkit [36917] by hyatt@apple.com

1 edit in trunk/WebCore/platform/gtk/ScrollViewGtk.cpp

Fix Gtk bustage.

4:13 PM Changeset in webkit [36916] by hyatt@apple.com

2 edits in trunk/WebKit/win

Fix Win bustage.

4:03 PM Changeset in webkit [36915] by hyatt@apple.com

1 edit in trunk/WebCore/platform/win/ScrollViewWin.cpp

Fix Win bustage.

3:52 PM Changeset in webkit [36914] by hyatt@apple.com

1 edit in trunk/WebCore/platform/ScrollView.cpp

Fix Qt, Win, Gtk bustage.

3:47 PM Changeset in webkit [36913] by hyatt@apple.com

1 edit in trunk/WebCore/platform/qt/ScrollViewQt.cpp

Fix Qt bustage.

3:34 PM Changeset in webkit [36912] by hyatt@apple.com

1 edit in trunk/WebCore/platform/ScrollView.cpp

Fix Win, Gtk, Qt bustage.

3:30 PM Changeset in webkit [36911] by hyatt@apple.com

1 edit in trunk/WebKit/qt/Api/qwebframe.cpp

Fix Qt bustage.

3:28 PM Changeset in webkit [36910] by hyatt@apple.com

1 edit in trunk/WebCore/platform/qt/ScrollViewQt.cpp

Fix Qt bustage.

3:25 PM Changeset in webkit [36909] by hyatt@apple.com

12 edits in trunk/WebCore

2008-09-25 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21120

Make visibleContentRect cross-platform. Note this does add new horizontal/verticalScrollbar accessors
to a bunch of platforms. This is a temporary evil until the scrollbars get made cross-platform (and I
didn't want to mix that change in with this patch).

Reviewed by Sam Weinig

page/Frame.cpp: (WebCore::Frame::markAllMatchesForText):
page/FrameView.cpp: (WebCore::FrameView::repaintContentRectangle): (WebCore::FrameView::windowClipRect): (WebCore::FrameView::updateControlTints):
platform/ScrollView.cpp: (WebCore::ScrollView::visibleContentRect): (WebCore::ScrollView::platformVisibleContentRect):
platform/ScrollView.h: (WebCore::ScrollView::visibleWidth): (WebCore::ScrollView::visibleHeight):
platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::horizontalScrollbar): (WebCore::ScrollView::verticalScrollbar):
platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::horizontalScrollbar): (WebCore::ScrollView::verticalScrollbar): (WebCore::ScrollView::platformVisibleContentRect):
platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::horizontalScrollbar): (WebCore::ScrollView::verticalScrollbar):
platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::horizontalScrollbar): (WebCore::ScrollView::verticalScrollbar):
platform/wx/ScrollViewWx.cpp: (WebCore::ScrollView::platformVisibleContentRect): (WebCore::ScrollView::horizontalScrollbar): (WebCore::ScrollView::verticalScrollbar):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible): (WebCore::frameVisibleRect):
rendering/RenderView.cpp: (WebCore::RenderView::viewRect):

2:21 PM Changeset in webkit [36908] by mrowe@apple.com

4 edits in branches/Safari-3-2-branch

Versioning.

1:55 PM Changeset in webkit [36907] by dsmith@webkit.org

3 edits in trunk/WebCore

2008-09-25 David Smith <catfish.man@gmail.com>

Reviewed by Timothy Hatcher

https://bugs.webkit.org/show_bug.cgi?id=21052
Generalize id selector special case for querySelectorAll

By checking the element we get with getElementById against the selector, we can use the special case in many more circumstances.
Changes results on http://native.khan.mozilla.org
from

#title: 2ms
h1#title: 55ms
div #title: 55ms

to:

#title: 1ms
h1#title: 2ms
div #title: 5ms

dom/Node.cpp: (WebCore::Node::querySelector):
dom/SelectorNodeList.cpp: (WebCore::createSelectorNodeList):

1:49 PM Changeset in webkit [36906] by hyatt@apple.com

9 edits in trunk/WebCore

2008-09-25 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21118

Make the concept of whether you can blit on scroll cross-platform on ScrollView.

Reviewed by Sam Weinig

page/FrameView.cpp: (WebCore::FrameView::clear): (WebCore::FrameView::layout): (WebCore::FrameView::setUseSlowRepaints): (WebCore::FrameView::addSlowRepaintObject): (WebCore::FrameView::removeSlowRepaintObject):
platform/ScrollView.cpp: (WebCore::ScrollView::init): (WebCore::ScrollView::addChild): (WebCore::ScrollView::removeChild): (WebCore::ScrollView::setCanBlitOnScroll):
platform/ScrollView.h: (WebCore::ScrollView::canBlitOnScroll):
platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore): (WebCore::ScrollView::ScrollView):
platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::ScrollView): (WebCore::ScrollView::platformAddChild): (WebCore::ScrollView::platformRemoveChild): (WebCore::ScrollView::platformSetCanBlitOnScroll):
platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore): (WebCore::ScrollView::ScrollView):
platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore): (WebCore::ScrollView::ScrollView):
platform/wx/ScrollViewWx.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::ScrollView): (WebCore::ScrollView::scrollBy):

1:29 PM Changeset in webkit [36905] by kmccullough@apple.com

3 edits in trunk/WebCore

2008-09-25 Kevin McCullough <kmccullough@apple.com>

Reviewed by Tim Hatcher.

Bug 21109: Console should right-align urls

page/inspector/Console.js: Re-order the message elements so that when it overflows it doesn't get mixed in with the next message.
page/inspector/inspector.css:

1:15 PM Changeset in webkit [36904] by hyatt@apple.com

5 edits
2 copies in trunk

2008-09-25 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21113

Putting r36771 back in with a fix to the addPendingSheet check in CSSImportRule::insertedIntoParent.

Reviewed by Darin Adler

css/CSSImportRule.cpp: (WebCore::CSSImportRule::insertedIntoParent):
css/CSSRule.cpp: (WebCore::CSSRule::parentStyleSheet): (WebCore::CSSRule::parentRule):
css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::CSSStyleSheet):
css/CSSStyleSheet.h:

1:02 PM Changeset in webkit [36903] by Darin Adler

2 edits in trunk/WebCore

2008-09-25 Darin Adler <Darin Adler>

Reviewed by Adele Peterson.

fix https://bugs.webkit.org/show_bug.cgi?id=21115 <rdar://problem/6245773> REGRESSION (r34702): Safari no longer zips bundled documents

html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData): Use files() instead of value() to get the path, since value() now returns just the basename.

11:37 AM Changeset in webkit [36902] by beidson@apple.com

6 edits
2 deletes in trunk

WebCore:

2008-09-25 Brady Eidson <beidson@apple.com>

Rubberstamped by Mark Rowe

Roll out 36771 as it caused <rdar://problem/6246554>
"nytimes.com doesn't display after returning to it with back/forward"

css/CSSImportRule.cpp: (WebCore::CSSImportRule::insertedIntoParent):
css/CSSRule.cpp: (WebCore::CSSRule::parentStyleSheet): (WebCore::CSSRule::parentRule):
css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::CSSStyleSheet): (WebCore::CSSStyleSheet::docLoader):
css/CSSStyleSheet.h: (WebCore::CSSStyleSheet::doc):

LayoutTests:

2008-09-25 Brady Eidson <beidson@apple.com>

Rubberstamped by Mark Rowe

Roll out 36771 as it caused <rdar://problem/6246554>
"nytimes.com doesn't display after returning to it with back/forward"

fast/css/nested-rule-parent-sheet-expected.txt: Removed.
fast/css/nested-rule-parent-sheet.html: Removed.

10:47 AM Changeset in webkit [36901] by Adam Roben

2 edits in trunk/WebCore

Windows build fix

WebCore.vcproj/WebCore.vcproj: Add ScrollView.cpp to the project.

10:27 AM Changeset in webkit [36900] by mitz@apple.com

2 edits in trunk/WebCore

Windows build fix

platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::addChildPlatformWidget): (WebCore::ScrollView::removeChildPlatformWidget):

10:24 AM Changeset in webkit [36899] by Darin Adler

2 edits in trunk/WebKitSite

2008-09-25 Darin Adler <Darin Adler>

contact.html: Take a cut at making the role of webkitsdk-dev clearer, specifying that it's Mac OS X specific and hosted at Apple, not WebKit.

10:07 AM Changeset in webkit [36898] by timothy@apple.com

2 edits in trunk/WebCore

Fixes a leak of ConsoleMessage seen when repeated console
messages occur.

Reviewed by Mark Rowe.

page/InspectorController.cpp: (WebCore::InspectorController::addConsoleMessage): Delete the repeat since we don't add it to m_consoleMessages.

9:59 AM Changeset in webkit [36897] by mrowe@apple.com

4 edits in branches/Safari-3-2-branch

Versioning.

9:55 AM Changeset in webkit [36896] by mrowe@apple.com

1 copy in tags/Safari-5525.25.2

New tag.

9:48 AM Changeset in webkit [36895] by kmccullough@apple.com

4 edits in trunk/WebCore

2008-09-25 Kevin McCullough <kmccullough@apple.com>

Reviewed by Dan Bernstein.

Bug 21105: XHRs logged in the console may show the wrong URL for the
source

Get the url at the time of the send() and pass it on to the XHR.

bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::send):
xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didFinishLoading):
xml/XMLHttpRequest.h: (WebCore::XMLHttpRequest::setLastSendURL):

9:04 AM Changeset in webkit [36894] by kmccullough@apple.com

4 edits in trunk/WebCore

2008-09-25 Kevin McCullough <kmccullough@apple.com>

Reviewed by Geoff and Tim.

Bug 20322: XHRs logged in the console do not have line numbers

Get the line number at the time of the send and pass it on to the XHR.

bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::send):
xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::XMLHttpRequest): (WebCore::XMLHttpRequest::didFinishLoading):
xml/XMLHttpRequest.h: (WebCore::XMLHttpRequest::setLastSendLineNumber):

8:33 AM Changeset in webkit [36893] by eric.carlson@apple.com

40 edits in trunk

2008-09-25 Eric Carlson <eric.carlson@apple.com>

Reviewed by Eric Seidel.

<rdar://problem/6171047> HTMLMediaElement "begin" event is now "loadstart"
https://bugs.webkit.org/show_bug.cgi?id=21003

dom/EventNames.h: remove "begin" event
html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::load): Post "loadstart" event instead of "begin"

2008-09-25 Eric Carlson <eric.carlson@apple.com>

Reviewed by Eric Seidel.

<rdar://problem/6171047> HTMLMediaElement "begin" event is now "loadstart"
https://bugs.webkit.org/show_bug.cgi?id=21003

Update media layout test results for progress event name change from "begin" to "loadstart"

media/audio-constructor-expected.txt:
media/audio-constructor-src-expected.txt:
media/audio-constructor-src.html:
media/audio-constructor.html:
media/progress-event-expected.txt:
media/progress-event-total-expected.txt:
media/progress-event-total.html:
media/progress-event.html:
media/video-error-abort-expected.txt:
media/video-error-abort.html:
media/video-load-networkState-expected.txt:
media/video-load-networkState.html:
media/video-load-readyState-expected.txt:
media/video-load-readyState.html:
media/video-pause-empty-events-expected.txt:
media/video-pause-empty-events.html:
media/video-play-empty-events-expected.txt:
media/video-play-empty-events.html:
media/video-source-expected.txt:
media/video-source-media-expected.txt:
media/video-source-media.html:
media/video-source-type-expected.txt:
media/video-source-type-params-expected.txt:
media/video-source-type-params.html:
media/video-source-type.html:
media/video-source.html:
media/video-src-change-expected.txt:
media/video-src-change.html:
media/video-src-expected.txt:
media/video-src-remove-expected.txt:
media/video-src-remove.html:
media/video-src-set-expected.txt:
media/video-src-set.html:
media/video-src-source-expected.txt:
media/video-src-source.html:
media/video-src.html:

4:30 AM Changeset in webkit [36892] by ap@webkit.org

4 edits
2 adds in trunk

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=21097
Calling a MessageChannel constructor from a destroyed document results in a crash

Test: fast/events/message-port-constructor-for-deleted-document.html

bindings/js/JSMessageChannelConstructor.cpp: (WebCore::JSMessageChannelConstructor::construct):
bindings/js/JSMessageChannelConstructor.h: Made m_document a RefPtr.

3:15 AM Changeset in webkit [36891] by ap@webkit.org

28 edits
27 adds in trunk

Reviewed by Sam Weinig, Anders Carlsson, and (unofficially) Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=20879
Implement HTML5 channel messaging

Tests: fast/events/message-channel-gc.html

fast/events/message-port-deleted-document.html
fast/events/message-port-deleted-frame.html
fast/events/message-port-inactive-document.html
fast/events/message-port.html
http/tests/security/MessagePort/event-listener-context.html

Configurations/WebCore.xcconfig: Removed unused ENABLE_CROSS_DOCUMENT_MESSAGING macro.

DerivedSources.make: Added MessageChannel and MessagePort.

WebCore.pro: Made MessageEvent compilation unconditional, as it could not possibly be turmed off anyway. Added new files.

GNUmakefile.am:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
WebCoreSources.bkl: Added new files.

bindings/js/JSDOMWindowBase.h:
bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::getValueProperty): Added suport for window.MessageChannel constructor.

bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::postMessage):
page/DOMWindow.cpp: (WebCore::DOMWindow::postMessage):
page/DOMWindow.h:
page/DOMWindow.idl: Added support for three-argument postMessage (that posts a MessagePort).

dom/EventTarget.cpp: (WebCore::EventTarget::toMessagePort):
dom/EventTarget.h:
bindings/js/JSEventTargetBase.cpp: (WebCore::toJS): Added MessagePort as yet another EventTarget variant.

bindings/js/JSMessageChannelConstructor.h:
bindings/js/JSMessageChannelConstructor.cpp: Added a custom constructor, so that it could take a browsing context (document) parameter.

bindings/js/JSMessageChannelCustom.cpp: Added. (WebCore::JSMessageChannel::mark): JSMessageChannel uses a custom mark function to mark port1 and port2 that it owns.

bindings/js/JSMessagePortCustom.cpp: Added. (WebCore::JSMessagePort::startConversation): (WebCore::JSMessagePort::addEventListener): (WebCore::JSMessagePort::removeEventListener): (WebCore::JSMessagePort::dispatchEvent): (WebCore::JSMessagePort::setOnmessage): (WebCore::JSMessagePort::onmessage): (WebCore::JSMessagePort::setOnclose): (WebCore::JSMessagePort::onclose): (WebCore::JSMessagePort::mark):
dom/MessagePort.cpp: Added.
dom/MessagePort.h: Added.
dom/MessagePort.idl: Added. Added a MessagePort implementation. Currently, it is not thread-safe at all, and only works with Documents as contexts, but in the future, it will be used for communication with worker threads.

bindings/objc/DOMInternal.h: Include "DOMMessagePortInternal.h". The new APIs do not really have Obj-C bindings, as they are far from being final, but a MessagePort stub is needed for MessageEvent.

bindings/scripts/CodeGeneratorJS.pm: Include PlatformString.h for MessagePort happiness.

dom/Document.cpp: (WebCore::MessagePortTimer::MessagePortTimer): (WebCore::MessagePortTimer::fired): (WebCore::Document::processMessagePortMessagesSoon): (WebCore::Document::~Document): (WebCore::Document::dispatchMessagePortEvents): (WebCore::Document::createdMessagePort): (WebCore::Document::destroyedMessagePort):
dom/Document.h: Document keeps track of all MessagePort objects that were created when it was fully active in its context.

dom/EventNames.h: Added closeEvent.

dom/MessageChannel.cpp: Added. (WebCore::MessageChannel::MessageChannel): (WebCore::MessageChannel::~MessageChannel):
dom/MessageChannel.h: Added. (WebCore::MessageChannel::create): (WebCore::MessageChannel::port1): (WebCore::MessageChannel::port2):
dom/MessageChannel.idl: Added. Addded JSMessageChannel implementation.

dom/MessageEvent.cpp: (WebCore::MessageEvent::MessageEvent): (WebCore::MessageEvent::initMessageEvent):
dom/MessageEvent.h: (WebCore::MessageEvent::create): (WebCore::MessageEvent::messagePort):
dom/MessageEvent.idl: MessageEvent has a MessagePort member now, making it possible to pass ports across documents.

1:57 AM Changeset in webkit [36890] by dsmith@webkit.org

5 edits
4 adds in trunk

WebCore:

2008-09-25 David Smith <catfish.man@gmail.com>

Reviewed by Eric Seidel

fix https://bugs.webkit.org/show_bug.cgi?id=21091
Regression: querySelector matches tag names case sensitively

Tests: fast/dom/SelectorAPI/caseTag.html

fast/dom/SelectorAPI/caseTagX.xhtml

css/CSSParser.cpp: (WebCore::CSSParser::parseSelector): Add a Document argument, since tag case sensitivity is different for HTML documents
css/CSSParser.h:
dom/Node.cpp: (WebCore::Node::querySelector): (WebCore::Node::querySelectorAll):

LayoutTests:

2008-09-25 David Smith <catfish.man@gmail.com>

Reviewed by Eric Seidel

Tests for https://bugs.webkit.org/show_bug.cgi?id=21091
Regression: querySelector matches tag names case sensitively

ChangeLog:
fast/dom/SelectorAPI/caseTag-expected.txt: Added.
fast/dom/SelectorAPI/caseTag.html: Added.
fast/dom/SelectorAPI/caseTagX-expected.txt: Added.
fast/dom/SelectorAPI/caseTagX.xhtml: Added.

1:23 AM Changeset in webkit [36889] by hyatt@apple.com

1 edit in trunk/WebCore/page/FrameView.cpp

Fix Qt bustage.

1:09 AM Changeset in webkit [36888] by hyatt@apple.com

1 edit in trunk/WebCore/page/JavaScriptDebugServer.cpp

Fix Qt bustage.

12:57 AM Changeset in webkit [36887] by hyatt@apple.com

1 edit in trunk/WebCore/page/JavaScriptDebugServer.cpp

Fix Qt bustage.

12:38 AM Changeset in webkit [36886] by hyatt@apple.com

19 edits
1 add in trunk/WebCore

2008-09-24 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21084

Make the m_children member of ScrollView cross-platform. Consolidate children add/remove
functionality. Add platform stubs for connecting/disconnecting the platform widgets.

Reviewed by Sam Weinig

GNUmakefile.am:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
WebCoreSources.bkl:
platform/ScrollView.h: (WebCore::ScrollView::children):
platform/Widget.h:
platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::addChildPlatformWidget): (WebCore::ScrollView::removeChildPlatformWidget): (WebCore::ScrollView::geometryChanged):
platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::addChildPlatformWidget): (WebCore::ScrollView::removeChildPlatformWidget):
platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::geometryChanged): (WebCore::ScrollView::addChildPlatformWidget): (WebCore::ScrollView::removeChildPlatformWidget):
platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::geometryChanged): (WebCore::ScrollView::setParentVisible): (WebCore::ScrollView::show): (WebCore::ScrollView::hide):
platform/wx/ScrollViewWx.cpp: (WebCore::ScrollView::addChildPlatformWidget): (WebCore::ScrollView::removeChildPlatformWidget):

12:16 AM Changeset in webkit [36885] by mitz@apple.com

3 edits in trunk/WebCore

Reviewed by Dave Hyatt.

fix https://bugs.webkit.org/show_bug.cgi?id=21024 <rdar://problem/6240821> Scrollbar not painted until hovered

rendering/RenderWidget.cpp: (WebCore::RenderWidget::setWidgetGeometry): Replaced resizeWidget with this method, which sets both the location and the size. (WebCore::RenderWidget::setWidget): Replaced the call to resizeWidget with a call to the new method setWidgetGeometry. Positioning the widget correctly ensures that the scroll bars invalidate correctly when they are created and resized.
rendering/RenderWidget.h:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed