Context Navigation

← Previous Period
Next Period →

Timeline

Sep 27, 2008:

10:38 PM Changeset in webkit [37030] by eric.carlson@apple.com

5 edits in trunk/WebCore

2008-09-27 Eric Carlson <eric.carlson@apple.com>

Reviewed by Sam Weinig.

fix https://bugs.webkit.org/show_bug.cgi?id=20994
<rdar://problem/6171023> HTMLVideoElement width and height attributes are now unsigned

HTML5 spec says HTMLVideoElement width and height attributes should be unsigned. Convert
all unsigned media attributes from string with toUInt() instead of toInt().

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::playCount): convert from attribute with toUInt().

html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::videoWidth): (WebCore::HTMLVideoElement::videoHeight): return unsigned to match idl. (WebCore::HTMLVideoElement::width): convert from attribute with toUInt() and return unsigned value. (WebCore::HTMLVideoElement::height): Ditto. (WebCore::HTMLVideoElement::setWidth): take unsigned value. (WebCore::HTMLVideoElement::setHeight): Ditto.

html/HTMLVideoElement.h: width, height, videoWidth, and videoHeight are unsigned.

html/HTMLVideoElement.idl: make width and height unsigned to match HTML5 spec.

9:59 PM Changeset in webkit [37029] by hyatt@apple.com

1 edit in trunk/WebCore/platform/mac/WheelEventMac.mm

Fix indentation error from bug 17589 fix made in WheelEventMac.mm

9:57 PM Changeset in webkit [37028] by hyatt@apple.com

1 edit in trunk/WebCore/platform/PlatformWheelEvent.h

It's SENSITIVE. SENSITIVE. Not SENSIBLE.

9:40 PM Changeset in webkit [37027] by timothy@apple.com

2 edits in trunk/WebCore

Fixes an exception when typing a command in the Console.

Reviewed by Oliver Hunt.

page/inspector/Console.js: (WebInspector.Console.prototype.addMessage): Null check this.previosMessage.

9:40 PM Changeset in webkit [37026] by timothy@apple.com

2 edits in trunk/WebCore

Fixes a bug where the Profiles panel sidebar would be empty
after closing and reopening the Web Inspector.

https://bugs.webkit.org/show_bug.cgi?id=21179

Reviewed by Sam Weinig.

page/inspector/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.reset): Don't call populateInterface, it is called automatically. (WebInspector.ProfilesPanel.prototype._populateProfiles): Return early if the sidebar is already populated.

9:38 PM Changeset in webkit [37025] by hyatt@apple.com

2 edits in trunk/WebCore

Fix for line step being too small on Windows.

8:51 PM Changeset in webkit [37024] by hyatt@apple.com

7 edits in trunk/WebCore

2008-09-27 David Hyatt <hyatt@apple.com>

Make the scrollbarUnderMouse method cross-platform.

Reviewed by Sam Weinig

platform/ScrollView.cpp: (WebCore::ScrollView::scrollbarUnderMouse):
platform/gtk/ScrollViewGtk.cpp:
platform/mac/ScrollViewMac.mm:
platform/qt/ScrollViewQt.cpp:
platform/win/ScrollViewWin.cpp:
platform/wx/ScrollViewWx.cpp:

6:50 PM Changeset in webkit [37023] by zecke@webkit.org

2 edits in trunk/WebCore

Gtk+ build fix.

6:49 PM Changeset in webkit [37022] by zecke@webkit.org

5 edits in trunk

/
2008-09-27 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=20287
[Gtk] disable plugins for gtk/directfb target

Introduce WTF_PLATFORM_X11 for X11 builds.
Also use target-specific packages when building the port

configure.ac: Do not check for cairo-ft for directfb builds.

WebCore
2008-09-27 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=20287
[Gtk] disable plugins for gtk/directfb target

Introduce WTF_PLATFORM_X11 for X11 builds.
Also use target-specific packages when building the port

platform/gtk/PlatformScreenGtk.cpp:
plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::updatePluginWidget): (WebCore::PluginView::getValueStatic): (WebCore::PluginView::getValue): (WebCore::PluginView::init):

6:08 PM Changeset in webkit [37021] by hyatt@apple.com

1 edit in trunk/WebKit/win/WebView.cpp

Missed WebKit single line change.

6:07 PM Changeset in webkit [37020] by hyatt@apple.com

1 edit in trunk/WebCore/platform/ScrollView.cpp

Oops. Checked in stale file.

6:07 PM Changeset in webkit [37019] by hyatt@apple.com

12 edits in trunk/WebCore

2008-09-27 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21188

Make scrollbar suppression and resizer avoidance cross-platform.

Reviewed by Anders

loader/FrameLoader.cpp: (WebCore::FrameLoader::transitionToCommitted):
page/FrameView.cpp: (WebCore::FrameView::resetScrollbars): (WebCore::FrameView::clear): (WebCore::FrameView::layout): (WebCore::FrameView::restoreScrollbar): (WebCore::FrameView::windowResizerRect):
page/FrameView.h:
platform/ScrollView.cpp: (WebCore::ScrollView::init): (WebCore::ScrollView::resizerOverlapsContent): (WebCore::ScrollView::adjustScrollbarsAvoidingResizerCount): (WebCore::ScrollView::setParent): (WebCore::ScrollView::setScrollbarsSuppressed): (WebCore::ScrollView::platformSetScrollbarsSuppressed):
platform/ScrollView.h: (WebCore::ScrollView::scrollbarsSuppressed): (WebCore::ScrollView::windowResizerRect):
platform/Scrollbar.cpp: (WebCore::Scrollbar::setFrameRect): (WebCore::Scrollbar::setParent):
platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::ScrollViewPrivate::adjustmentChanged): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::paint):
platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::ScrollView): (WebCore::ScrollView::~ScrollView): (WebCore::ScrollView::platformSetScrollbarsSuppressed): (WebCore::ScrollView::setScrollPosition):
platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::ScrollViewPrivate::valueChanged): (WebCore::ScrollView::frameRectsChanged): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::paint):
platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::ScrollViewPrivate::valueChanged): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::paint):
platform/wx/ScrollViewWx.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):

4:58 PM Changeset in webkit [37018] by timothy@apple.com

1 edit in trunk/LayoutTests/fast/dom/Window/window-properties-expected.txt

Update a layout test result to add console.trace.

4:46 PM Changeset in webkit [37017] by zecke@webkit.org

2 edits in trunk/WebCore

2008-09-27 Holger Hans Peter Freyther <zecke@selfish.org>

Rubber-stamped by Anders Carlsson.

Compile fix.

plugins/PluginView.cpp: (WebCore::PluginView::load):

4:23 PM Changeset in webkit [37016] by mrowe@apple.com

2 edits in trunk/WebCore

Fix <https://bugs.webkit.org/show_bug.cgi?id=21184>.
Bug 21184: REGRESSION: Reproducible crash below StringImpl::hash while running editing/deleting/5408255.html

Remove an assertion that was incorrect and that if made correct would have duplicated a check that occurred earlier in the function.

Rubber-stamped by Sam Weinig.

loader/CachedResource.cpp:

(WebCore::CachedResource::~CachedResource):

3:56 PM Changeset in webkit [37015] by zecke@webkit.org

2 edits in trunk

2008-09-27 Marco Barisione <marco.barisione@collabora.co.uk>

Reviewed by Holger Freyther.

http://bugs.webkit.org/show_bug.cgi?id=21174
[GTK][AUTOTOOLS] Enable large file support at configure time

configure.ac: Enable large file support with AC_SYS_LARGEFILE.

3:46 PM Changeset in webkit [37014] by zecke@webkit.org

2 edits in trunk/WebCore

[qt] Use QImageReader to figure out which image formats are supported

Qt can have many different plugins for different image formats. Instead of checking only for a few in WebCore use Qt to determine if this data can be treated as an image.

3:45 PM Changeset in webkit [37013] by zecke@webkit.org

3 edits in trunk/WebCore

[qt] Clean the pattern code

Use save/restore on the painter after manipulating the pen/brush
Make the context and object null checking consistent. CG is using the object unconditionally so the Qt webkit platform can do the same.
Move code below the early exit. Only use the m_ownerElement before the early exit as the CG code is doing it.

3:18 PM Changeset in webkit [37012] by timothy@apple.com

8 edits in trunk

Added support for console.trace.

JavaScriptCore:

2008-09-27 Keishi Hattori <casey.hattori@gmail.com>

Added Machine::retrieveCaller to the export list.

Reviewed by Kevin McCullough and Tim Hatcher.

JavaScriptCore.exp: Added Machine::retrieveCaller.

WebCore:

2008-09-27 Keishi Hattori <casey.hattori@gmail.com>

Added support for console.trace.

https://bugs.webkit.org/show_bug.cgi?id=19157

Reviewed by Kevin McCullough and Tim Hatcher.

bindings/js/JSConsoleCustom.cpp: (WebCore::JSConsole::trace):
page/Console.cpp: (WebCore::Console::trace): Calls Machine::retrieveCaller to get a stack trace.
page/Console.h: (WebCore::): Added TraceMessageLevel.
page/Console.idl: Added console.trace.
page/inspector/Console.js: (ConsoleMessage): Added case for TraceMessageLevel.

3:18 PM Changeset in webkit [37011] by hyatt@apple.com

2 edits in trunk/WebKit/mac

2008-09-27 David Hyatt <hyatt@apple.com>

Fix for https://bugs.webkit.org/show_bug.cgi?id=21182

Make sure Mac null checks the view like the other platforms do now that Mac goes through WebCore
to call setAllowsScrolling.

Reviewed by Mark Rowe

WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createFrame):

3:15 PM Changeset in webkit [37010] by hyatt@apple.com

5 edits in trunk/WebKit

WebKit/qt:

2008-09-27 David Hyatt <hyatt@apple.com>

Forgot to land renaming changes in WebKit.

Api/qwebframe.cpp: (QWebFrame::render): (QWebFrame::pos): (QWebFrame::geometry):
Api/qwebpage.cpp: (QWebPage::viewportSize): (QWebPage::setViewportSize):

WebKit/win:

2008-09-27 David Hyatt <hyatt@apple.com>

Land the frameGeometry->frameRect changes that I forgot to land in WebKit.

Interfaces/IWebScrollBarPrivate.idl:
WebCoreSupport/EmbeddedWidget.cpp: (EmbeddedWidget::setFrameRect): (EmbeddedWidget::frameRectsChanged):
WebCoreSupport/EmbeddedWidget.h:
WebScrollBar.cpp: (WebScrollBar::setRect): (WebScrollBar::frameRect):
WebScrollBar.h:

2:30 PM Changeset in webkit [37009] by mitz@apple.com

1 edit
2 moves in trunk/LayoutTests

Rubber-stamped by Sam Weinig.

fix typo in test name

media/video-click-dblckick-standalone-expected.txt: Copied from media/video-click-dlbclick-standalone-expected.txt.
media/video-click-dblckick-standalone.html: Copied from media/video-click-dlbclick-standalone.html.
media/video-click-dlbclick-standalone-expected.txt: Removed.
media/video-click-dlbclick-standalone.html: Removed.

2:28 PM Changeset in webkit [37008] by andersca@apple.com

7 edits
2 adds in trunk

WebCore:

2008-09-27 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=21178
<rdar://problem/6248651>

Check if the plug-in is allowed to load the resource. This matches Firefox.

Test: http/tests/plugins/local-geturl-from-remote.html

plugins/PluginView.cpp: (WebCore::PluginView::load):

WebKit/mac:

2008-09-27 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=21178
<rdar://problem/6248651>

Check if the plug-in is allowed to load the resource. This matches Firefox.

Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):

WebKitTools:

2008-09-27 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=21178
<rdar://problem/6248651>

Return the result value from getURL.

DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (getURL):

LayoutTests:

2008-09-27 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=21178
<rdar://problem/6248651>

Add tests.

http/tests/plugins/local-geturl-from-remote-expected.txt: Added.
http/tests/plugins/local-geturl-from-remote.html: Added.

2:13 PM Changeset in webkit [37007] by andersca@apple.com

4 edits in trunk/WebKit/win

2008-09-27 Anders Carlsson <andersca@apple.com>

Fix build.

WebCoreSupport/EmbeddedWidget.cpp: (EmbeddedWidget::setFrameRect): (EmbeddedWidget::frameRectsChanged):
WebCoreSupport/EmbeddedWidget.h:
WebScrollBar.cpp: (WebScrollBar::setRect): (WebScrollBar::frameGeometry):

2:06 PM Changeset in webkit [37006] by zecke@webkit.org

2 edits in trunk/WebCore

2008-09-22 Dirk Schulze <vbs85@gmx.de>

Reviewed by Eric Seidel.

Added SVG pattern support to Qt.

[Qt] SVG patterns are missing
https://bugs.webkit.org/show_bug.cgi?id=20973

svg/graphics/qt/SVGPaintServerPatternQt.cpp: (WebCore::SVGPaintServerPattern::setup):

1:18 PM Changeset in webkit [37005] by timothy@apple.com

2 edits in trunk/WebCore

Fixed a bug in the JS syntax highlighter with multiple line tokens.

https://bugs.webkit.org/show_bug.cgi?id=21171

Reviewed by Tim Hatcher.

page/inspector/SourceFrame.js: (syntaxHighlightJavascriptLine): Initialize previousMatchLength.

1:18 PM Changeset in webkit [37004] by timothy@apple.com

2 edits in trunk/WebCore

Change searching in the Profiles panel to not match the
Self and Total columns when there are no units. The only
column that is matched for unitless number searches is
now the Calls column.

https://bugs.webkit.org/show_bug.cgi?id=21169

Reviewed by Sam Weinig.

page/inspector/ProfileView.js: (WebInspector.ProfileView.prototype.performSearch):

12:56 PM Changeset in webkit [37003] by hyatt@apple.com

11 edits in trunk/WebCore

2008-09-27 David Hyatt <hyatt@apple.com>

Rename boundsGeometry -> boundsRect. Rename geometryChanged -> frameRectsChanged.

Reviewed by Sam Weinig

platform/ScrollView.h:
platform/Widget.h: (WebCore::Widget::boundsRect): (WebCore::Widget::invalidate): (WebCore::Widget::frameRectsChanged):
platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollViewScrollbar::frameRectsChanged): (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore): (WebCore::ScrollView::setFrameRect): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::frameRectsChanged):
platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::setFrameRect): (ScrollbarGtk::frameRectsChanged):
platform/gtk/ScrollbarGtk.h:
platform/gtk/WidgetGtk.cpp:
platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore): (WebCore::ScrollView::setFrameRect): (WebCore::ScrollView::frameRectsChanged): (WebCore::ScrollView::updateScrollbars):
platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore): (WebCore::ScrollView::setFrameRect): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::frameRectsChanged):
plugins/PluginView.cpp: (WebCore::PluginView::frameRectsChanged):
plugins/PluginView.h:

12:49 PM Changeset in webkit [37002] by Simon Hausmann

3 edits in trunk/WebCore

2008-09-27 Simon Hausmann <Simon Hausmann>

Refix the previous build fix to compile on non-Qt platforms, too.

12:15 PM Changeset in webkit [37001] by Simon Hausmann

6 edits in trunk/WebCore

2008-09-27 Simon Hausmann <Simon Hausmann>

Fix compilation with gcc 4.3 (probably > 4.0)

11:32 AM Changeset in webkit [37000] by Simon Hausmann

3 edits in trunk/WebKit/qt

2008-09-27 Simon Hausmann <Simon Hausmann>

Qt build fix - use frameRect instead of frameGeometry, adapt
to renamed scrollbar frameview methods.

10:41 AM Changeset in webkit [36999] by andersca@apple.com

2 edits in trunk/JavaScriptCore

2008-09-27 Anders Carlsson <andersca@apple.com>

Fix build.

VM/CTI.cpp: (JSC::):

10:20 AM Changeset in webkit [36998] by ggaren@apple.com

1 edit in trunk/JavaScriptCore/ChangeLog

Added bug #

10:19 AM Changeset in webkit [36997] by ggaren@apple.com

6 edits in trunk/JavaScriptCore

2008-09-27 Geoffrey Garen <ggaren@apple.com>

Reviewed by Cameron Zwarich.

Store the callee CodeBlock, not the caller CodeBlock, in the call frame
header. Nix the "codeBlock" local variable, and access the callee
CodeBlock through the call frame header instead.

Profit: call + return are simpler, because they don't have to update the
"codeBlock" local variable.

Because CTI keeps "r" in a register, reading the callee CodeBlock relative
to "r" can be very fast, in any cases we care to optimize. Presently,
no such cases seem important.

Also, stop writing "dst" to the call frame header. CTI doesn't use it.

21.6% speedup on empty function call benchmark.
3.8% speedup on SunSpider --v8.
2.1% speedup on v8 benchmark.
0.7% speedup on SunSpider (6% speedup on controlflow-recursive).

Small regression in bytecode, because currently every op_ret reads the
callee CodeBlock to check needsFullScopeChain, and bytecode does not
keep "r" in a register. On-balance, this is probably OK, since CTI is
our high-performance execution model. Also, this should go away once
we make needsFullScopeChain statically determinable at parse time.

VM/CTI.cpp: (JSC::CTI::compileOpCall): The speedup! (JSC::CTI::privateCompileSlowCases): ditto

VM/CTI.h: (JSC::): Fixed up magic trampoline constants to account for the nixed "codeBlock" argument. (JSC::CTI::execute): Changed trampoline function not to take a "codeBlock" argument, since codeBlock is now stored in the call frame header.

VM/Machine.cpp: Read the callee CodeBlock from the register file. Use a NULL CallerRegisters in the call frame header to signal a built-in caller, since CodeBlock is now never NULL.

VM/Machine.h: Made some stand-alone functions Machine member functions so they could call the private codeBlock() accessor in the Register class, of which Machine is a friend. Renamed "CallerCodeBlock" to "CodeBlock", since it's no longer the caller's CodeBlock.

VM/RegisterFile.h: Marked some methods const to accommodate a const RegisterFile* being passed around in Machine.cpp.

1:23 AM Changeset in webkit [36996] by jmalonzo@webkit.org

2 edits in trunk/WebKit/qt

2008-09-27 Jan Michael Alonzo <jmalonzo@webkit.org>

Qt build fix - rename frameGeometry to frameRect per r36995.

Api/qwebframe.cpp: (QWebFrame::render): (QWebFrame::pos): (QWebFrame::geometry):

1:01 AM Changeset in webkit [36995] by hyatt@apple.com

31 edits in trunk/WebCore

2008-09-27 David Hyatt <hyatt@apple.com>

Rename frameGeometry to frameRect. Rename setFrameGeometry to setFrameRect.

Reviewed by Dan Bernstein

WebCore.base.exp:
page/FrameView.cpp: (WebCore::FrameView::FrameView): (WebCore::FrameView::updateControlTints):
platform/ScrollView.h:
platform/Scrollbar.cpp: (WebCore::Scrollbar::Scrollbar): (WebCore::Scrollbar::paint): (WebCore::Scrollbar::setFrameRect):
platform/Scrollbar.h:
platform/ScrollbarThemeComposite.cpp: (WebCore::ScrollbarThemeComposite::paint):
platform/Widget.h: (WebCore::Widget::x): (WebCore::Widget::y): (WebCore::Widget::width): (WebCore::Widget::height): (WebCore::Widget::size): (WebCore::Widget::pos): (WebCore::Widget::resize): (WebCore::Widget::move):
platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollViewScrollbar::geometryChanged): (WebCore::ScrollView::update): (WebCore::ScrollView::setFrameRect): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::scrollbarUnderMouse): (WebCore::ScrollView::paint):
platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::setFrameRect): (ScrollbarGtk::geometryChanged):
platform/gtk/ScrollbarGtk.h:
platform/gtk/WidgetGtk.cpp: (WebCore::Widget::frameRect): (WebCore::Widget::setFrameRect):
platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::trackRect): (WebCore::ScrollbarThemeMac::paint):
platform/mac/WidgetMac.mm: (WebCore::Widget::frameRect): (WebCore::Widget::setFrameRect):
platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::setFrameRect): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::scrollbarUnderMouse): (WebCore::ScrollView::paint):
platform/qt/ScrollbarThemeQt.cpp: (WebCore::styleOptionSlider):
platform/qt/WidgetQt.cpp: (WebCore::Widget::frameRect): (WebCore::Widget::setFrameRect):
platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::invalidateItem): (WebCore::PopupMenu::valueChanged): (WebCore::PopupWndProc):
platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::setFrameRect): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::scrollbarUnderMouse): (WebCore::ScrollView::paint):
platform/win/ScrollbarThemeSafari.cpp: (WebCore::ScrollbarThemeSafari::trackRect):
platform/win/WidgetWin.cpp: (WebCore::Widget::frameRect): (WebCore::Widget::setFrameRect):
platform/wx/WidgetWx.cpp: (WebCore::Widget::frameRect): (WebCore::Widget::setFrameRect):
plugins/PluginView.cpp: (WebCore::PluginView::setFrameRect):
plugins/PluginView.h:
plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::updatePluginWidget): (WebCore::PluginView::paint): (WebCore::PluginView::init):
plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::updatePluginWidget): (WebCore::PluginView::init):
plugins/win/PluginViewWin.cpp: (WebCore::PluginView::updatePluginWidget): (WebCore::PluginView::paintMissingPluginIcon): (WebCore::PluginView::paint): (WebCore::PluginView::init):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::positionOverflowControls):
rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintScrollbar):
rendering/RenderPart.cpp: (WebCore::RenderPart::updateWidgetPosition):
rendering/RenderWidget.cpp: (WebCore::RenderWidget::setWidgetGeometry): (WebCore::RenderWidget::updateWidgetPosition):

12:51 AM Changeset in webkit [36994] by hyatt@apple.com

1 edit in trunk/WebCore/platform/wx/ScrollViewWx.cpp

Fix wx bustage.

12:43 AM Changeset in webkit [36993] by hyatt@apple.com

1 edit in trunk/WebCore/page/FocusController.cpp

12:43 AM Changeset in webkit [36992] by hyatt@apple.com

2 edits in trunk/WebCore

2008-09-27 David Hyatt <hyatt@apple.com>

<rdar://problem/6252041> REGRESSION (4dp-TOT): Crash in Widget::platformWidget() when closing a PDF

This crash was lurking for a while and basically got exposed by my changes to visibleContentRect() to
access an actual member variable.

Reviewed by Dan Bernstein

page/FocusController.cpp: (WebCore::FocusController::setFocusedFrame):

12:38 AM Changeset in webkit [36991] by jmalonzo@webkit.org

2 edits in trunk/WebCore

2008-09-27 Jan Michael Alonzo <jmalonzo@webkit.org>

Attempt to fix QT Build. Not reviewed.

WebCore.pro: add -n WebCore parameter to create_hash_table

Sep 26, 2008:

11:48 PM Changeset in webkit [36990] by jmalonzo@webkit.org

3 edits in trunk/WebCore

2008-09-26 Gwenole Beauchesne <gbeauchesne@splitted-desktop.org>

Reviewed by Eric Seidel.

http://bugs.webkit.org/show_bug.cgi?id=18905
[GTK] Fix build with older pango (1.14.8)

platform/graphics/gtk/FontGtk.cpp:
platform/gtk/Language.cpp: (_pango_get_lc_ctype): (pango_language_get_default):

11:36 PM Changeset in webkit [36989] by jmalonzo@webkit.org

2 edits in trunk/JavaScriptCore

2008-09-26 Jan Michael Alonzo <jmalonzo@webkit.org>

Gtk build fix. Not reviewed.

Narrow-down the target of the JavaScriptCore .lut.h generator so
it won't try to create the WebCore .lut.hs.

GNUmakefile.am:

11:23 PM Changeset in webkit [36988] by hyatt@apple.com

8 edits in trunk/WebCore

2008-09-26 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21168

Make contentsToWindow/windowToContents cross-platform.

Reviewed by Oliver Hunt

platform/ScrollView.cpp: (WebCore::ScrollView::windowToContents): (WebCore::ScrollView::contentsToWindow):
platform/ScrollView.h:
platform/gtk/ScrollViewGtk.cpp:
platform/mac/ScrollViewMac.mm:
platform/qt/ScrollViewQt.cpp:
platform/win/ScrollViewWin.cpp:
platform/wx/ScrollViewWx.cpp:

11:15 PM Changeset in webkit [36987] by weinig@apple.com

2 edits in trunk/WebCore

2008-09-26 Sam Weinig <sam@webkit.org>

GTK build fix.

GNUmakefile.am:

10:47 PM Changeset in webkit [36986] by pewtermoose@webkit.org

6 edits in trunk

JavaScriptCore:

2008-09-26 Matt Lilek <webkit@mattlilek.com>

Reviewed by Tim Hatcher.

Update FEATURE_DEFINES after ENABLE_CROSS_DOCUMENT_MESSAGING was removed.

Configurations/JavaScriptCore.xcconfig:

WebKit/mac:

2008-09-26 Matt Lilek <webkit@mattlilek.com>

Reviewed by Tim Hatcher.

Update FEATURE_DEFINES after ENABLE_CROSS_DOCUMENT_MESSAGING was removed.

Configurations/WebKit.xcconfig:

WebKitTools:

2008-09-26 Matt Lilek <webkit@mattlilek.com>

Reviewed by Tim Hatcher.

Update FEATURE_DEFINES after ENABLE_CROSS_DOCUMENT_MESSAGING was removed.

Scripts/build-webkit:

10:26 PM Changeset in webkit [36985] by hyatt@apple.com

10 edits in trunk/WebCore

2008-09-26 David Hyatt <hyatt@apple.com>

Eliminate shouldUpdateWhileOffscreen from ScrollView. Make the concept of not invalidating while
offscreen cross-platform. Rename the inWindow method to isOffscreen (which flips the boolean), since that
more clearly conveys the intent of the method. Make isOffscreen also check NSWindow visibility on Mac.

Reviewed by Oliver Hunt

page/FrameView.cpp: (WebCore::FrameView::repaintContentRectangle):
page/FrameView.h:
platform/ScrollView.h:
platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::isOffscreen):
platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::updateContents): (WebCore::ScrollView::isOffscreen):
platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::isOffscreen):
platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::isOffscreen):
platform/wx/ScrollViewWx.cpp: (WebCore::ScrollView::isOffscreen):
rendering/RenderObject.cpp: (WebCore::RenderObject::willRenderImage):

10:24 PM Changeset in webkit [36984] by hyatt@apple.com

1 edit in trunk/WebCore/platform/ScrollView.h

Fix WIndows bustage.

9:44 PM Changeset in webkit [36983] by hyatt@apple.com

3 edits in trunk/LayoutTests/platform/mac/editing/selection

Land new result.

9:43 PM Changeset in webkit [36982] by hyatt@apple.com

16 edits in trunk

WebCore:

2008-09-26 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21164

Rework concept of allowsScrolling/setAllowsScrolling to be cross-platform.

Reviewed by Sam Weinig

WebCore.base.exp:
page/FrameView.cpp: (WebCore::FrameView::setAllowsScrolling):
page/FrameView.h:
platform/ScrollView.cpp: (WebCore::ScrollView::setAllowsScrolling):
platform/ScrollView.h: (WebCore::ScrollView::allowsScrolling):
platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::wheelEvent):

WebKit/mac:

2008-09-26 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21164

Rework concept of allowsScrolling/setAllowsScrolling to be cross-platform.

Reviewed by Sam Weinig

WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createFrame):
WebView/WebDynamicScrollBarsView.h:
WebView/WebDynamicScrollBarsView.m:
WebView/WebDynamicScrollBarsViewInternal.h:
WebView/WebFrameView.mm: (-[WebFrameView setAllowsScrolling:]): (-[WebFrameView allowsScrolling]):

8:23 PM Changeset in webkit [36981] by cwzwarich@webkit.org

2 edits in trunk/JavaScriptCore

2008-09-26 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Rubber-stamped by Anders Carlson.

Change the name 'sc' to 'scopeChainNode' in a few places.

kjs/nodes.cpp: (JSC::EvalNode::generateCode): (JSC::FunctionBodyNode::generateCode): (JSC::ProgramNode::generateCode):

8:22 PM Changeset in webkit [36980] by kevino@webkit.org

7 edits in trunk

wx build fixes after Widget/ScrollView changes.

7:44 PM Changeset in webkit [36979] by timothy@apple.com

1 edit
2 adds in trunk/WebKitSite

Add screenshots of searching in the Web Inspector.

Not reviewed.

blog-files/inspector-searching-elements.png: Added.
blog-files/inspector-searching-profiles.png: Added.

7:44 PM Changeset in webkit [36978] by timothy@apple.com

2 edits in trunk/WebCore

Allow searching for paths by always performing the
three search methods in the Elements panel and not
assume a search with a "/" is a XPath query.

https://bugs.webkit.org/show_bug.cgi?id=21159

Reviewed by Geoff Garen.

page/inspector/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.performSearch):

7:36 PM Changeset in webkit [36977] by weinig@apple.com

36 edits in trunk

JavaScriptCore:

2008-09-26 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

Patch for https://bugs.webkit.org/show_bug.cgi?id=21152
Speedup static property get/put

Convert getting/setting static property values to use static functions
instead of storing an integer and switching in getValueProperty/putValueProperty.

kjs/JSObject.cpp: (JSC::JSObject::deleteProperty): (JSC::JSObject::getPropertyAttributes):
kjs/MathObject.cpp: (JSC::MathObject::getOwnPropertySlot):
kjs/NumberConstructor.cpp: (JSC::numberConstructorNaNValue): (JSC::numberConstructorNegInfinity): (JSC::numberConstructorPosInfinity): (JSC::numberConstructorMaxValue): (JSC::numberConstructorMinValue):
kjs/PropertySlot.h: (JSC::PropertySlot::):
kjs/RegExpConstructor.cpp: (JSC::regExpConstructorDollar1): (JSC::regExpConstructorDollar2): (JSC::regExpConstructorDollar3): (JSC::regExpConstructorDollar4): (JSC::regExpConstructorDollar5): (JSC::regExpConstructorDollar6): (JSC::regExpConstructorDollar7): (JSC::regExpConstructorDollar8): (JSC::regExpConstructorDollar9): (JSC::regExpConstructorInput): (JSC::regExpConstructorMultiline): (JSC::regExpConstructorLastMatch): (JSC::regExpConstructorLastParen): (JSC::regExpConstructorLeftContext): (JSC::regExpConstructorRightContext): (JSC::setRegExpConstructorInput): (JSC::setRegExpConstructorMultiline): (JSC::RegExpConstructor::setInput): (JSC::RegExpConstructor::setMultiline): (JSC::RegExpConstructor::multiline):
kjs/RegExpConstructor.h:
kjs/RegExpObject.cpp: (JSC::regExpObjectGlobal): (JSC::regExpObjectIgnoreCase): (JSC::regExpObjectMultiline): (JSC::regExpObjectSource): (JSC::regExpObjectLastIndex): (JSC::setRegExpObjectLastIndex):
kjs/RegExpObject.h: (JSC::RegExpObject::setLastIndex): (JSC::RegExpObject::lastIndex): (JSC::RegExpObject::RegExpObjectData::RegExpObjectData):
kjs/StructureID.cpp: (JSC::StructureID::getEnumerablePropertyNames):
kjs/create_hash_table:
kjs/lexer.cpp: (JSC::Lexer::lex):
kjs/lookup.cpp: (JSC::HashTable::createTable): (JSC::HashTable::deleteTable): (JSC::setUpStaticFunctionSlot):
kjs/lookup.h: (JSC::HashEntry::initialize): (JSC::HashEntry::setKey): (JSC::HashEntry::key): (JSC::HashEntry::attributes): (JSC::HashEntry::function): (JSC::HashEntry::functionLength): (JSC::HashEntry::propertyGetter): (JSC::HashEntry::propertyPutter): (JSC::HashEntry::lexerValue): (JSC::HashEntry::): (JSC::HashTable::entry): (JSC::getStaticPropertySlot): (JSC::getStaticValueSlot): (JSC::lookupPut):

WebCore:

2008-09-26 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

Patch for https://bugs.webkit.org/show_bug.cgi?id=21152
Speedup static property get/put

DerivedSources.make:
GNUmakefile.am:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSDOMBinding.cpp:
bindings/js/JSDOMBinding.h:
bindings/js/JSDOMWindowBase.cpp: (WebCore::getDOMConstructor): (WebCore::jsDOMWindowBaseCrypto): (WebCore::jsDOMWindowBaseEvent): (WebCore::jsDOMWindowBaseImage): (WebCore::jsDOMWindowBaseMessageChannel): (WebCore::jsDOMWindowBaseOption): (WebCore::jsDOMWindowBaseXMLHttpRequest): (WebCore::jsDOMWindowBaseAudio): (WebCore::jsDOMWindowBaseXSLTProcessor): (WebCore::jsDOMWindowBaseOnabort): (WebCore::jsDOMWindowBaseOnblur): (WebCore::jsDOMWindowBaseOnchange): (WebCore::jsDOMWindowBaseOnclick): (WebCore::jsDOMWindowBaseOndblclick): (WebCore::jsDOMWindowBaseOnerror): (WebCore::jsDOMWindowBaseOnfocus): (WebCore::jsDOMWindowBaseOnkeydown): (WebCore::jsDOMWindowBaseOnkeypress): (WebCore::jsDOMWindowBaseOnkeyup): (WebCore::jsDOMWindowBaseOnload): (WebCore::jsDOMWindowBaseOnmousedown): (WebCore::jsDOMWindowBaseOnmousemove): (WebCore::jsDOMWindowBaseOnmouseout): (WebCore::jsDOMWindowBaseOnmouseover): (WebCore::jsDOMWindowBaseOnmouseup): (WebCore::jsDOMWindowBaseOnMouseWheel): (WebCore::jsDOMWindowBaseOnreset): (WebCore::jsDOMWindowBaseOnresize): (WebCore::jsDOMWindowBaseOnscroll): (WebCore::jsDOMWindowBaseOnsearch): (WebCore::jsDOMWindowBaseOnselect): (WebCore::jsDOMWindowBaseOnsubmit): (WebCore::jsDOMWindowBaseOnbeforeunload): (WebCore::jsDOMWindowBaseOnunload): (WebCore::jsDOMWindowBaseOnWebKitAnimationStart): (WebCore::jsDOMWindowBaseOnWebKitAnimationIteration): (WebCore::jsDOMWindowBaseOnWebKitAnimationEnd): (WebCore::jsDOMWindowBaseOnWebKitTransitionEnd): (WebCore::JSDOMWindowBase::getOwnPropertySlot): (WebCore::JSDOMWindowBase::put): (WebCore::setJSDOMWindowBaseOnabort): (WebCore::setJSDOMWindowBaseOnblur): (WebCore::setJSDOMWindowBaseOnchange): (WebCore::setJSDOMWindowBaseOnclick): (WebCore::setJSDOMWindowBaseOndblclick): (WebCore::setJSDOMWindowBaseOnerror): (WebCore::setJSDOMWindowBaseOnfocus): (WebCore::setJSDOMWindowBaseOnkeydown): (WebCore::setJSDOMWindowBaseOnkeypress): (WebCore::setJSDOMWindowBaseOnkeyup): (WebCore::setJSDOMWindowBaseOnload): (WebCore::setJSDOMWindowBaseOnmousedown): (WebCore::setJSDOMWindowBaseOnmousemove): (WebCore::setJSDOMWindowBaseOnmouseout): (WebCore::setJSDOMWindowBaseOnmouseover): (WebCore::setJSDOMWindowBaseOnmouseup): (WebCore::setJSDOMWindowBaseOnMouseWheel): (WebCore::setJSDOMWindowBaseOnreset): (WebCore::setJSDOMWindowBaseOnresize): (WebCore::setJSDOMWindowBaseOnscroll): (WebCore::setJSDOMWindowBaseOnsearch): (WebCore::setJSDOMWindowBaseOnselect): (WebCore::setJSDOMWindowBaseOnsubmit): (WebCore::setJSDOMWindowBaseOnbeforeunload): (WebCore::setJSDOMWindowBaseOnunload): (WebCore::setJSDOMWindowBaseOnWebKitAnimationStart): (WebCore::setJSDOMWindowBaseOnWebKitAnimationIteration): (WebCore::setJSDOMWindowBaseOnWebKitAnimationEnd): (WebCore::setJSDOMWindowBaseOnWebKitTransitionEnd): (WebCore::setJSDOMWindowBaseEvent): (WebCore::setJSDOMWindowBaseAudio): (WebCore::setJSDOMWindowBaseImage): (WebCore::setJSDOMWindowBaseMessageChannel): (WebCore::setJSDOMWindowBaseOption): (WebCore::setJSDOMWindowBaseXMLHttpRequest): (WebCore::setJSDOMWindowBaseXSLTProcessor):
bindings/js/JSDOMWindowBase.h:
bindings/js/JSDOMWindowCustom.cpp: (WebCore::nonCachingStaticCloseFunctionGetter): (WebCore::nonCachingStaticBlurFunctionGetter): (WebCore::nonCachingStaticFocusFunctionGetter): (WebCore::nonCachingStaticPostMessageFunctionGetter):
bindings/js/JSDOMWindowCustom.h: (WebCore::JSDOMWindow::customGetOwnPropertySlot):
bindings/js/JSEventTargetBase.cpp:
bindings/js/JSEventTargetBase.h: (WebCore::JSEventTargetBasePrototype::getOwnPropertySlot): (WebCore::JSEventTargetBasePrototype::classInfo):
bindings/js/JSEventTargetNode.cpp: (WebCore::): (WebCore::JSEventTargetNode::getOwnPropertySlot): (WebCore::JSEventTargetNode::put):
bindings/js/JSEventTargetNode.h: (WebCore::JSEventTargetNode::classInfo): (WebCore::JSEventTargetNode::prototypeClassName):
bindings/js/JSEventTargetSVGElementInstance.cpp: (WebCore::): (WebCore::JSEventTargetSVGElementInstance::getOwnPropertySlot): (WebCore::JSEventTargetSVGElementInstance::put):
bindings/js/JSEventTargetSVGElementInstance.h: (WebCore::JSEventTargetSVGElementInstance::classInfo): (WebCore::JSEventTargetSVGElementInstance::prototypeClassName):
bindings/js/JSHTMLInputElementCustom.cpp: (WebCore::JSHTMLInputElement::customGetOwnPropertySlot):
bindings/js/JSHistoryCustom.cpp: (WebCore::nonCachingStaticBackFunctionGetter): (WebCore::nonCachingStaticForwardFunctionGetter): (WebCore::nonCachingStaticGoFunctionGetter): (WebCore::JSHistory::customGetOwnPropertySlot):
bindings/js/JSLocationCustom.cpp: (WebCore::nonCachingStaticReplaceFunctionGetter): (WebCore::nonCachingStaticReloadFunctionGetter): (WebCore::nonCachingStaticAssignFunctionGetter): (WebCore::JSLocation::customGetOwnPropertySlot): (WebCore::JSLocation::customPut):
bindings/scripts/CodeGeneratorJS.pm:

6:44 PM Changeset in webkit [36976] by barraclough@apple.com

12 edits
1 add in trunk/JavaScriptCore

2008-09-26 Gavin Barraclough <barraclough@apple.com>

Reviewed by Maciej Stachowiak & Oliver Hunt.

Add support for reusing temporary JSNumberCells. This change is based on the observation
that if the result of certain operations is a JSNumberCell and is consumed by a subsequent
operation that would produce a JSNumberCell, we can reuse the object rather than allocating
a fresh one. E.g. given the expression ((a * b) * c), we can statically determine that
(a * b) will have a numeric result (or else it will have thrown an exception), so the result
will either be a JSNumberCell or a JSImmediate.

This patch changes three areas of JSC:

The AST now tracks type information about the result of each node.
This information is consumed in bytecode compilation, and certain bytecode operations now carry the statically determined type information about their operands.
CTI uses the information in a number of fashions:
- Where an operand to certain arithmetic operations is reusable, it will plant code to try to perform the operation in JIT code & reuse the cell, where appropriate.
- Where it can be statically determined that an operand can only be numeric (typically the result of another arithmetic operation) the code will not redundantly check that the JSCell is a JSNumberCell.
- Where either of the operands to an add are non-numeric do not plant an optimized arithmetic code path, just call straight out to the C function.

+6% Sunspider (10% progression on 3D, 16% progression on math, 60% progression on access-nbody),
+1% v8-tests (improvements in raytrace & crypto)

VM/CTI.cpp: Add optimized code generation with reuse of temporary JSNumberCells.
VM/CTI.h:
kjs/JSNumberCell.h:
masm/X86Assembler.h:

VM/CodeBlock.cpp: Add type information to specific bytecodes.
VM/CodeGenerator.cpp:
VM/CodeGenerator.h:
VM/Machine.cpp:

kjs/nodes.cpp: Track static type information for nodes.
kjs/nodes.h:
kjs/ResultDescriptor.h: (Added)
JavaScriptCore.xcodeproj/project.pbxproj:

4:01 PM Changeset in webkit [36975] by alice.liu@apple.com

2 edits in trunk/WebKitTools

2008-09-26 Alice Liu <alice.liu@apple.com>

Remove usage of atlstr.h and CString for VCExpress compatibility

Reviewed by Stephanie Lewis.

record-memory-win/main.cpp: (ProcessArgs): (UseImage): (QueryContinuously): (OneQuery): (OneQueryMP):

3:45 PM Changeset in webkit [36974] by staikos@webkit.org

2 edits in trunk/JavaScriptCore

2008-09-26 Yichao Yin <yichao.yin@torchmobile.com.cn>

Reviewed by George Staikos, Maciej Stachowiak.

Add utility functions needed for upcoming WML code.

wtf/ASCIICType.h: (WTF::isASCIIPrintable):

3:43 PM Changeset in webkit [36973] by ggaren@apple.com

4 edits in trunk/JavaScriptCore

2008-09-26 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.

Reverted the part of r36614 that used static data because static data
is not thread-safe.

3:40 PM Changeset in webkit [36972] by ggaren@apple.com

8 edits in trunk/JavaScriptCore

2008-09-26 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.

Removed dynamic check for whether the callee needs an activation object.
Replaced with callee code to create the activation object.

0.5% speedup on SunSpider.
No change on v8 benchmark. (Might be a speedup, but it's in range of the
variance.)

0.7% speedup on v8 benchmark in bytecode.
1.3% speedup on empty call benchmark in bytecode.

VM/CTI.cpp: (JSC::CTI::privateCompileMainPass): Added support for op_init_activation, the new opcode that specifies that the callee's initialization should create an activation object. (JSC::CTI::privateCompile): Removed previous code that did a similar thing in an ad-hoc way.

VM/CodeBlock.cpp: (JSC::CodeBlock::dump): Added a case for dumping op_init_activation.

VM/CodeGenerator.cpp: (JSC::CodeGenerator::generate): Added fixup code to change op_init to op_init_activation if necessary. (With a better parser, we would know which to use from the beginning.)

VM/Instruction.h: (JSC::Instruction::Instruction): (WTF::): Faster traits for the instruction vector. An earlier version of this patch relied on inserting at the beginning of the vector, and depended on this change for speed.

VM/Machine.cpp: (JSC::Machine::execute): Removed clients of setScopeChain, the old abstraction for dynamically checking for whether an activation object needed to be created. (JSC::Machine::privateExecute): ditto

(JSC::Machine::cti_op_push_activation): Renamed this function from
cti_vm_updateScopeChain, and made it faster by removing the call to
setScopeChain.

VM/Machine.h:

VM/Opcode.h: Declared op_init_activation.

2:57 PM Changeset in webkit [36971] by hyatt@apple.com

3 edits in trunk/WebKit/win

fix Win bustage.

2:53 PM Changeset in webkit [36970] by hyatt@apple.com

1 edit in trunk/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp

fix Win bustage.

2:45 PM Changeset in webkit [36969] by hyatt@apple.com

1 edit in trunk/WebCore/platform/win/ScrollViewWin.cpp

Fix Win bustage.

2:35 PM Changeset in webkit [36968] by hyatt@apple.com

1 edit in trunk/WebKit/qt/Api/qwebframe.cpp

Fix Qt bustage.

2:35 PM Changeset in webkit [36967] by kevino@webkit.org

2 edits in trunk/WebKitTools

wx build fix. Update the version of libpng.

2:22 PM Changeset in webkit [36966] by hyatt@apple.com

1 edit in trunk/WebCore/platform/qt/ScrollViewQt.cpp

Fix Qt bustage.

2:19 PM Changeset in webkit [36965] by mrowe@apple.com

4 edits in branches/Safari-3-2-branch

Versioning.

2:00 PM Changeset in webkit [36964] by hyatt@apple.com

1 edit in trunk/WebCore/platform/gtk/ScrollViewGtk.cpp

Fix gtk bustage.

1:54 PM Changeset in webkit [36963] by hyatt@apple.com

1 edit in trunk/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp

Fix gtk bustage.

1:49 PM Changeset in webkit [36962] by hyatt@apple.com

17 edits in trunk

WebCore:

2008-09-26 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21149

Make the concept of scroll modes cross-platform. Move the scrollbars up into ScrollView as well.
Eliminate the unused isScrollable() method.

Reviewed by Sam Weinig

WebCore.base.exp:
page/FrameView.cpp: (WebCore::FrameView::resetScrollbars): (WebCore::FrameView::initScrollbars): (WebCore::FrameView::layout):
page/FrameView.h:
page/mac/WebCoreFrameView.h:
platform/ScrollView.cpp: (WebCore::ScrollView::init): (WebCore::ScrollView::setScrollbarModes): (WebCore::ScrollView::scrollbarModes): (WebCore::ScrollView::platformSetScrollbarModes): (WebCore::ScrollView::platformScrollbarModes):
platform/ScrollView.h: (WebCore::ScrollView::horizontalScrollbar): (WebCore::ScrollView::verticalScrollbar): (WebCore::ScrollView::isScrollViewScrollbar): (WebCore::ScrollView::setHorizontalScrollbarMode): (WebCore::ScrollView::setVerticalScrollbarMode): (WebCore::ScrollView::horizontalScrollbarMode): (WebCore::ScrollView::verticalScrollbarMode): (WebCore::ScrollView::convertSelfToChild):
platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar): (WebCore::ScrollView::ScrollViewPrivate::setHasVerticalScrollbar): (WebCore::ScrollView::ScrollViewPrivate::valueChanged): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::scrollbarUnderMouse): (WebCore::ScrollView::isScrollViewScrollbar): (WebCore::ScrollView::paint): (WebCore::ScrollView::scroll):
platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::platformSetScrollbarModes): (WebCore::ScrollView::platformScrollbarModes):
platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar): (WebCore::ScrollView::ScrollViewPrivate::setHasVerticalScrollbar): (WebCore::ScrollView::ScrollViewPrivate::valueChanged): (WebCore::ScrollView::horizontalScrollbar): (WebCore::ScrollView::verticalScrollbar): (WebCore::ScrollView::invalidateScrollbars): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::scrollbarUnderMouse): (WebCore::ScrollView::paint): (WebCore::ScrollView::scroll):
platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar): (WebCore::ScrollView::ScrollViewPrivate::setHasVerticalScrollbar): (WebCore::ScrollView::ScrollViewPrivate::valueChanged): (WebCore::ScrollView::ScrollViewPrivate::setAllowsScrolling): (WebCore::ScrollView::ScrollViewPrivate::allowsScrolling): (WebCore::ScrollView::suppressScrollbars): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::scrollbarUnderMouse): (WebCore::ScrollView::paint): (WebCore::ScrollView::scroll):
platform/wx/ScrollViewWx.cpp: (WebCore::ScrollView::platformSetScrollbarModes): (WebCore::ScrollView::platformScrollbarModes):

WebKit/mac:

2008-09-26 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21149

More refactoring to make scrollbar modes cross-platform. Reduce the protocol that
WebDynamicScrollBarsView has to implement for communicating with WebCore to just three methods.

Reviewed by Sam Weinig

WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView scrollingModes:WebCore::vertical:WebCore::]): (-[WebDynamicScrollBarsView setHorizontalScrollingMode:andLock:]): (-[WebDynamicScrollBarsView setVerticalScrollingMode:andLock:]): (-[WebDynamicScrollBarsView setScrollingModes:vertical:andLock:]):
WebView/WebDynamicScrollBarsViewInternal.h:
WebView/WebFrameView.mm: (-[WebFrameView setAllowsScrolling:]):
WebView/WebView.mm: (-[WebView setAlwaysShowVerticalScroller:]): (-[WebView setAlwaysShowHorizontalScroller:]):

1:47 PM Changeset in webkit [36961] by ddkilzer@apple.com

7 edits in trunk

Fix Mac build with XPATH and XSLT disabled

WebCore:

Fix Mac build with XPATH and XSLT disabled

Reviewed by Alexey.

bindings/objc/DOMUtility.mm: (JSC::createDOMWrapper): Conditionalize code with ENABLE(XPATH).
dom/XMLTokenizerLibxml2.cpp: (WebCore::errorFunc): Conditionalize method with ENABLE(XSLT) to prevent an unused code warning.

WebKit/mac:

Fix Mac build with XSLT disabled

Reviewed by Alexey.

Misc/WebCache.mm: (+[WebCache statistics]): Populate xslStyleSheet statistics with zeros if XSLT is disabled.

WebKit/win:

Speculative Windows build fix with XSLT disabled

Reviewed by Alexey.

WebCache.cpp: (WebCache::statistics): Populate xslStyleSheet statistics with zeros if XSLT is disabled.

10:57 AM Changeset in webkit [36960] by kmccullough@apple.com

2 edits in trunk/WebCore

2008-09-26 Kevin McCullough <kmccullough@apple.com>

Rubber stamped by Tim Hatcher.

Bug 21098: Crashing under Console::log

Speculative ASSERT to help find the problem.

page/InspectorController.cpp: (WebCore::ConsoleMessage::isEqual):

10:56 AM Changeset in webkit [36959] by zecke@webkit.org

2 edits in trunk/WebCore

[gtk+] Build fix for the latest ScrollView changes

10:27 AM Changeset in webkit [36958] by timothy@apple.com

3 edits in trunk/WebCore

Fixes a bug where the console message repeat count would be wrong
when typing commands in between repeated messages.

https://bugs.webkit.org/show_bug.cgi?id=21145

Reviewed by Kevin McCullough.

page/InspectorController.cpp: (WebCore::InspectorController::clearConsoleMessages): Reset m_groupLevel. (WebCore::InspectorController::didCommitLoad): Call clearConsoleMessages.
page/inspector/Console.js: (WebInspector.Console.prototype.addMessage): Remember the original repeat count for each message as totalRepeatCount, since we now modify repeatCount to mean repeats since previous console command. If repeatCountBeforeCommand is a number, subtract that value from the repeatCount. (WebInspector.Console.prototype.clearMessages): Delete the repeatCountBeforeCommand and commandSincePreviousMessage properties.

10:26 AM Changeset in webkit [36957] by eric.carlson@apple.com

17 edits in trunk/WebCore

2008-09-26 Eric Carlson <eric.carlson@apple.com>

Reviewed by Antti

https://bugs.webkit.org/show_bug.cgi?id=21116
<rdar://problem/5726325> Audio from <video> can still be heard after navigating
back to page with <video>, then closing tab

Rename willSaveToCache/didRestoreFromCache callbacks to documentWillBecomeInactive/
documentDidBecomeActive, and post documentWillBecomeInactive when a page is marked for
deletion.

dom/Document.cpp: (WebCore::Document::documentWillBecomeInactive): (WebCore::Document::documentDidBecomeActive): (WebCore::Document::registerForDocumentActivationCallbacks): (WebCore::Document::unregisterForDocumentActivationCallbacks):
dom/Document.h:
dom/Element.h: (WebCore::Element::documentWillBecomeInactive): (WebCore::Element::documentDidBecomeActive):
history/CachedPage.cpp: (WebCore::CachedPage::CachedPage):
html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::~HTMLFormElement): (WebCore::HTMLFormElement::parseMappedAttribute): (WebCore::HTMLFormElement::documentDidBecomeActive): (WebCore::HTMLFormElement::willMoveToNewOwnerDocument): (WebCore::HTMLFormElement::didMoveToNewOwnerDocument):
html/HTMLFormElement.h:
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::~HTMLInputElement): (WebCore::HTMLInputElement::setInputType): (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::needsActivationCallback): (WebCore::HTMLInputElement::registerForActivationCallbackIfNeeded): (WebCore::HTMLInputElement::unregisterForActivationCallbackIfNeeded): (WebCore::HTMLInputElement::documentDidBecomeActive): (WebCore::HTMLInputElement::willMoveToNewOwnerDocument): (WebCore::HTMLInputElement::didMoveToNewOwnerDocument):
html/HTMLInputElement.h:
html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): (WebCore::HTMLMediaElement::~HTMLMediaElement): (WebCore::HTMLMediaElement::documentWillBecomeInactive): (WebCore::HTMLMediaElement::documentDidBecomeActive):
html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::inActiveDocument):
loader/FrameLoader.cpp: (WebCore::FrameLoader::opened):
page/Page.cpp: (WebCore::Page::~Page):
rendering/RenderMedia.cpp: (WebCore::RenderMedia::updateControls):
rendering/RenderVideo.cpp: (WebCore::RenderVideo::updatePlayer):
svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::SVGSVGElement): (WebCore::SVGSVGElement::~SVGSVGElement): (WebCore::SVGSVGElement::documentWillBecomeInactive): (WebCore::SVGSVGElement::documentDidBecomeActive):
svg/SVGSVGElement.h:

9:30 AM Changeset in webkit [36956] by Simon Hausmann

2 edits in trunk/WebCore

2008-09-26 Ariya Hidayat <ariya.hidayat@trolltech.com>

Reviewed by Simon

Fix the build inside Qt, don't create faulty prl files for now.

6:17 AM Changeset in webkit [36955] by Simon Hausmann

4 edits in trunk/WebCore

2008-09-26 Simon Hausmann <Simon Hausmann>

Fix compilation on Qt/Windows

Add WebCore/ to the include path so that config.h is found that enables JSC
Link against winmm for the multimedia timer functions
Include DateMath.h instead of JavaScriptCore/DateMath.h as file is in the kjs/ subdirectory
In PluginViewWin.cpp don't use setPlatformWidget with the HWND for the Qt/Windows port but set m_window directly as setPlatformWidget takes a QWidget*.

4:53 AM Changeset in webkit [36954] by oliver@apple.com

14 edits
6 adds in trunk

Bug 21054: Construction of certain DOM objects is heavily regressed by r36675
<https://bugs.webkit.org/show_bug.cgi?id=21054>

Reviewed by Maciej Stachowiak

This performance regression is actually just a symptom of a correctness
bug. The constructor objects for a number of properties that have security
checks on access were returning new objects each time. The most obvious
symptom of this bug is that window.Image != window.Image, etc.

The solution to this is to make sure we cache these constructors
in the same way as all the other DOM constructors. To achieve this
without causing any refcount cycles it is necessary to replace the
refcounted document pointer in the Image, MessageChannel, Option,
XMLHttpRequest, and Audio constructor objects with a reference to
the document's JS wrapper.

Tests: fast/dom/constructors-cached-navigate.html

fast/dom/constructors-cached.html

3:55 AM Changeset in webkit [36953] by Simon Hausmann

2 edits in trunk/WebCore

2008-09-26 Simon Hausmann <Simon Hausmann>

Unreviewed one-liner build fix for the Qt/Windows build.

The build requires NPAPI support to be enabled, fix the condition in
the .pro file for that.

3:51 AM Changeset in webkit [36952] by Simon Hausmann

2 edits in trunk/WebCore

2008-09-26 Trenton Schulz <twschulz@trolltech.com>

Reviewed by Simon.

Fix compilation with the Qt/Cocoa port.

2:37 AM Changeset in webkit [36951] by Simon Hausmann

2 edits in trunk/WebCore

2008-09-26 Simon Hausmann <Simon Hausmann>

Reviewed by Holger.

Fix compilation with VC9SP1, work around bug in TR1 library by
disabling it.

2:37 AM Changeset in webkit [36950] by Simon Hausmann

2 edits in trunk/WebCore

2008-09-26 Simon Hausmann <Simon Hausmann>

Reviewed by Holger.

Fix an lupdate() warning.

Don't use tr() in a class that is not a QObject, use
QCoreApplication::translate() directly.

2:36 AM Changeset in webkit [36949] by Simon Hausmann

3 edits in trunk/WebKit/qt

2008-09-26 Ariya Hidayat <ahidayat@trolltech.com>

Reviewed by Simon.

Fixed potential crash when deleting QWebView instance.

When deleting the view, sets the page's view to NULL.
The reason is that the page is smart and its destructor might lead to a call
that operates on a view (which is in the process of being deleted).

2:36 AM Changeset in webkit [36948] by Simon Hausmann