Context Navigation

JavaScriptCore.exp:
VM/CTI.cpp: (JSC::CTI::privateCompileMainPass):
VM/CodeBlock.cpp: (JSC::CodeBlock::dump):
VM/CodeGenerator.cpp: (JSC::CodeGenerator::CodeGenerator): (JSC::CodeGenerator::registerFor):
VM/CodeGenerator.h: (JSC::CodeGenerator::registerFor):
VM/Machine.cpp: (JSC::Machine::initializeCallFrame): (JSC::Machine::dumpRegisters): (JSC::Machine::privateExecute): (JSC::Machine::retrieveArguments): (JSC::Machine::cti_op_call_JSFunction): (JSC::Machine::cti_op_create_arguments): (JSC::Machine::cti_op_construct_JSConstruct):
VM/Machine.h:
VM/Opcode.h:
VM/RegisterFile.h: (JSC::RegisterFile::):
kjs/JSActivation.cpp: (JSC::JSActivation::mark): (JSC::JSActivation::argumentsGetter):
kjs/JSActivation.h: (JSC::JSActivation::JSActivationData::JSActivationData):
kjs/NodeInfo.h:
kjs/Parser.cpp: (JSC::Parser::didFinishParsing):
kjs/Parser.h: (JSC::Parser::parse):
kjs/grammar.y:
kjs/nodes.cpp: (JSC::ScopeNode::ScopeNode): (JSC::ProgramNode::ProgramNode): (JSC::ProgramNode::create): (JSC::EvalNode::EvalNode): (JSC::EvalNode::create): (JSC::FunctionBodyNode::FunctionBodyNode): (JSC::FunctionBodyNode::create):
kjs/nodes.h: (JSC::ScopeNode::usesArguments):

7:45 PM Changeset in webkit [37049] by mrowe@apple.com

2 edits in trunk/JavaScriptCore

Add an ASCII fast-path to toLowerCase and toUpperCase.

The fast path speeds up the common case of an ASCII-only string by up to 60% while adding a less than 5% penalty
to the less common non-ASCII case.

This also removes stringProtoFuncToLocaleLowerCase and stringProtoFuncToLocaleUpperCase, which were identical
to the non-locale variants of the functions. toLocaleLowerCase and toLocaleUpperCase now use the non-locale
variants of the functions directly.

Reviewed by Sam Weinig.

kjs/StringPrototype.cpp:

(JSC::stringProtoFuncToLowerCase):
(JSC::stringProtoFuncToUpperCase):

7:00 PM Changeset in webkit [37048] by mrowe@apple.com

2 edits in trunk/JavaScriptCore

Speed up parseInt and parseFloat.

Repeatedly indexing into a UString is slow, so retrieve a pointer into the underlying buffer once up front
and use that instead. This is a 7% win on a parseInt/parseFloat micro-benchmark.

Reviewed by Cameron Zwarich.

4:57 PM Changeset in webkit [37047] by ddkilzer@apple.com

2 edits in trunk/WebKitTools

Bug 21185: resolve-ChangeLogs should be able to fix poorly merged ChangeLog entries after a git svn rebase

<https://bugs.webkit.org/show_bug.cgi?id=21185>

Reviewed by Adam.

Scripts/resolve-ChangeLogs: Added new -ffix-merge switch that

will attempt to reapply the last commit to a ChangeLog file such
that the ChangeLog entry appears at the top of the file.
(findChangeLog): Added prototype and moved method below the exit
statement.
(fixMergedChangeLog): Added. Method to fix incorrectly merged
ChangeLog entries.

4:31 PM Changeset in webkit [37046] by timothy@apple.com

9 edits in trunk

Improves the Web Inspector node highlight so it does not scroll to reveal the node in the page.

WebCore:

2008-09-28 Timothy Hatcher <timothy@apple.com>

Remove the scrollIntoViewIfNeeded() call when drawing the
Inspector node highlight.

<rdar://problem/6115804> Don't scroll when highlighting (21000)
https://bugs.webkit.org/show_bug.cgi?id=21000

Reviewed by Dan Bernstein.

page/InspectorController.cpp: (WebCore::InspectorController::drawNodeHighlight):

WebKit/mac:

2008-09-28 Timothy Hatcher <timothy@apple.com>

Improves the Web Inspector node highlight so it does not scroll
to reveal the node in the page. This makes the highlight less
invasive and causes less things to change on screen. Also makes
the highlight redraw when the WebView draws, so it stays current
if the node changes on the page for any reason.

<rdar://problem/6115804> Don't scroll when highlighting (21000)
https://bugs.webkit.org/show_bug.cgi?id=21000

Reviewed by Dan Bernstein.

WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController highlightNode:]): Call setNeedsDisplay:YES if there is an existing highlight. (-[WebInspectorWindowController didAttachWebNodeHighlight:]): Set the current highlight node on the inspected WebView. (-[WebInspectorWindowController willDetachWebNodeHighlight:]): Set the current highlight node on the inspected WebView to nil.
WebInspector/WebNodeHighlight.m: (-[WebNodeHighlight setNeedsUpdateInTargetViewRect:]): Disable screen updates until flush for the inspected window. Invalidate the whole highlight view since we don't know the rect that needs updated since the highlight can be larger than the highlighted element due to the margins and other factors.
WebInspector/WebNodeHighlightView.m:
WebView/WebHTMLView.mm: (-[WebHTMLView drawSingleRect:]): Call setNeedsUpdateInTargetViewRect: on the current highlight node.
WebView/WebView.mm: (-[WebViewPrivate dealloc]): Release the current highlight node. (-[WebView setCurrentNodeHighlight:]): Set the current highlight node. (-[WebView currentNodeHighlight]): Return the current highlight node.
WebView/WebViewInternal.h:

12:58 PM Changeset in webkit [37045] by hyatt@apple.com

2 edits in trunk/WebCore

2008-09-28 David Hyatt <hyatt@apple.com>

Fix crash when WebKit has no instantiated Scrollbars and the appearance prefs for scrollbars are
changed.

Reviewed by Dan Bernstein

platform/mac/ScrollbarThemeMac.mm: (+[ScrollbarPrefsObserver appearancePrefsChanged:]):

12:52 PM Changeset in webkit [37044] by timothy@apple.com

2 edits in trunk/WebCore

Clear the current search results in the Inspector when
the search query is less than 3 characters long. Incremental
searches only occur for 3 characters or longer, but deleting
under this limit would not clear the results unless the whole
query was deleted.

https://bugs.webkit.org/show_bug.cgi?id=21196

Reviewed by Dan Bernstein.

page/inspector/inspector.js: (WebInspector.performSearch): Check for short queries in the if statement that triggers the clear.

12:41 PM Changeset in webkit [37043] by mitz@apple.com

1 edit in trunk/WebCore/ChangeLog

Fix typo noticed by Hyatt in review, which I forgot to fix before checking in.

12:38 PM Changeset in webkit [37042] by mitz@apple.com

4 edits in trunk/WebCore

Reviewed by Dave Hyatt.

fix <rdar://problem/6202962> "Tibetan Machine Uni" font does not work as a web font on Windows because TTLoadEmbeddedFont fails with E_NAMECHANGEFAILED

platform/graphics/win/FontCustomPlatformData.cpp: (WebCore::EOTStream::EOTStream): Added overlayDst, overlaySrc and overlayLength parameters. (WebCore::EOTStream::read): Added code to overlay the the m_overlayLength bytes starting at m_overlayDst with the same number of bytes from m_overlaySrc. (WebCore::createFontCustomPlatformData): Changed to get overlay parameters from getEOTHeader.
platform/graphics/win/GetEOTHeader.cpp: (WebCore::getEOTHeader): Added code to specify overlaying of the family name with the prefix of the full name if they differ, because that such a difference causes TTLoadEmbeddedFont to fail.
platform/graphics/win/GetEOTHeader.h:

12:17 PM QtWebKitTodo edited by Simon Hausmann

(diff)

11:57 AM Changeset in webkit [37041] by Simon Hausmann

2 edits in trunk/WebKit/qt

2008-09-28 Simon Hausmann <Simon Hausmann>

Reviewed by David Hyatt.

Ensure the mainThreadIdentifier is set as well as other bits and pieces of
the threading machinery, by calling JSC::initializeThreading().

11:56 AM Changeset in webkit [37040] by Simon Hausmann

2 edits in trunk/JavaScriptCore

2008-09-28 Simon Hausmann <Simon Hausmann>

Reviewed by David Hyatt.

In Qt's initializeThreading re-use an existing thread identifier for the main
thread if it exists.

currentThread() implicitly creates new identifiers and it could be that
it is called before initializeThreading().

11:48 AM QtWebKitGitInstructions edited by Simon Hausmann

Update to the current branch situation (diff)

11:43 AM QtWebKitTodo edited by Simon Hausmann

Cleanups and start of 4.5 plan (diff)

11:22 AM Changeset in webkit [37039] by ddkilzer@apple.com

2 edits in trunk/WebKit/mac

Fix build warning in WebDefaultUIDelegate.m

Reviewed by Dan Bernstein.

This fixes a warning noticed by the clang static analyzer:
.../WebDefaultUIDelegate.m: In function ‘-[WebDefaultUIDelegate webViewFirstResponder:]’:
.../WebDefaultUIDelegate.m:92: warning: initialization from distinct Objective-C type

Note that this doesn't actually cause any change in behavior since
the gcc compiler ignores the semi-colon anyway.

DefaultDelegates/WebDefaultUIDelegate.m: (-[WebDefaultUIDelegate webViewFirstResponder:]): Removed semi-colon from method signature.

6:23 AM Changeset in webkit [37038] by ap@webkit.org

6 edits in trunk

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=20366
Reproducible test failure for editing/undo/undo-iframe-location-change.html

This does not fix the problem, but makes the test more predictable by using iframe onload.
Also, makes the test runnable in browser. Turns out that the test reliably fails there too,
even without any special steps needed in DRT.

editing/undo/undo-iframe-location-change-expected.txt:
editing/undo/undo-iframe-location-change.html:

ChangeLog-2007-10-14: Added bug URLs for a patch that included this test.

WebCore:

ChangeLog-2006-05-10: Added bug URLs for a fix that included this test.

2:35 AM Changeset in webkit [37037] by Darin Adler

28 edits in trunk/WebCore

2008-09-28 Darin Adler <Darin Adler>

Reviewed by Sam Weinig (except for a few comment and header tweaks).

https://bugs.webkit.org/show_bug.cgi?id=21158 reduce use of virtual functions in Node for speed

Speeds up Dromaeo a bit less than 1%.

bindings/js/JSNamedNodesCollection.cpp: Include Element.h instead of Node.h now that some inlines are in there.

dom/Attr.h: Override both the virtual and non-virtual name functions.

dom/ChildNodeList.cpp: (WebCore::ChildNodeList::nodeMatches): Updated to take an Element.
dom/ChildNodeList.h: Ditto.
dom/ClassNodeList.cpp: (WebCore::ClassNodeList::nodeMatches): Ditto.
dom/ClassNodeList.h: Ditto.

dom/Document.h: Put the Node::isDocumentNode() function's inline definition here where it can see the Document class definition.

dom/DynamicNodeList.cpp: (WebCore::DynamicNodeList::length): Changed to pass an Element. (WebCore::DynamicNodeList::itemForwardsFromCurrent): Ditto. (WebCore::DynamicNodeList::itemBackwardsFromCurrent): Ditto. (WebCore::DynamicNodeList::itemWithName): Ditto.
dom/DynamicNodeList.h: Ditto.

dom/Element.cpp: Removed virtualHasTagName.
dom/Element.h: Made localName, prefix, namespaceURI, and styleForRenderer non-virtual. Added virtualPrefix, virtualLocalName, virtualNamespaceURI, and removed virtualHasTagName. Put the Node::hasTagName, Node::hasAttributes, and Node::attributes functions' inline definitions here where they can see the Element class definition.

dom/NameNodeList.cpp: (WebCore::NameNodeList::nodeMatches): Updated to take an Element.
dom/NameNodeList.h: Ditto.

dom/Node.cpp: (WebCore::Node::virtualPrefix): Renamed from prefix. (WebCore::Node::virtualLocalName): Renamed from localName. (WebCore::Node::virtualNamespaceURI): Renamed from namespaceURI. (WebCore::Node::styleForRenderer): Handle the Element case here.

dom/Node.h: Removed definition of hasTagName that calls virtual, since we now have a non-virtual version. Made hasAttributes, attributes, remove, localName, namespaceURI, prefix, isDocumentNode, and styleForRenderer non-virtual. Added virtualPrefix, virtualLocalName, and virtualNamespaceURI. Removed isMalformed and setMalformed, which are used only on HTMLFormElement objects.

dom/TagNodeList.cpp: (WebCore::TagNodeList::nodeMatches): Updated to take an Element.
dom/TagNodeList.h: Ditto.

html/HTMLAnchorElement.cpp: Added a comment.
html/HTMLFormControlElement.cpp: Ditto.

html/HTMLAnchorElement.h: Removed unused, unimplemented setTabIndex function. Marked tabIndex function virtual explicitly for clarity.

html/HTMLAreaElement.h: Removed unused, unimplemented setTabIndex function. Marked isFocusable function virtual explicitly for clarity.

html/HTMLElement.h: Marked tabIndex function virtual explicitly for clarity.
html/HTMLFormControlElement.h: Ditto.

html/HTMLFormElement.h: Made isMalformed non-virtual.

html/HTMLParser.cpp: (WebCore::HTMLParser::handleError): Use the already-cast-to-HTMLElement pointer to call localName since that one does not need to call a virtual function.

rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): Cast to HTMLFormElement before calling isMalformed. We already did a tag name check so we know it's an HTMLFormELement.

xml/XPathUtil.cpp: (WebCore::XPath::isValidContextNode): Rewrote to not make so many calls to nodeType(), since it's a virtual function.

2:33 AM Changeset in webkit [37036] by hyatt@apple.com

1 edit in trunk/WebCore/platform/wx/MouseWheelEventWx.cpp

Fix wx bustage.

1:52 AM Changeset in webkit [37035] by hyatt@apple.com

7 edits in trunk/WebCore

2008-09-28 David Hyatt <hyatt@apple.com>

Make frameRectsChanged() cross-platform on ScrollView.

Reviewed by Oliver Hunt

platform/ScrollView.cpp: (WebCore::ScrollView::frameRectsChanged):
platform/ScrollView.h:
platform/gtk/ScrollViewGtk.cpp:
platform/qt/ScrollViewQt.cpp:
platform/win/ScrollViewWin.cpp:
platform/wx/ScrollViewWx.cpp:

1:36 AM Changeset in webkit [37034] by oliver@apple.com

2 edits in trunk/WebCore

Bug 21141: REGRESSION: Exception messages for user entered commands are poor
<https://bugs.webkit.org/show_bug.cgi?id=21141>

Reviewed by Maciej Stachowiak.

The bug repsonsible for this was the the JSInspectedObjectWrapper instances
were not initialising their StructureID's to indicate that the wrapper
overrides hasInstance, etc. The solution is simply to use the createStructureID
helper on JSQuarantinedObjectWrapper to create a correct StructureID.

1:30 AM Changeset in webkit [37033] by hyatt@apple.com

1 edit in trunk/WebKit/gtk/webkit/webkitwebview.cpp

Fix GTK bustage.

1:29 AM Changeset in webkit [37032] by hyatt@apple.com

2 edits in trunk/WebCore

2008-09-28 David Hyatt <hyatt@apple.com>

Make sure pixel wheel scrolls (formerly "continuous" wheel events) send deltas to DOM wheel events in
terms of lines.

Reviewed by Oliver Hunt

dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchWheelEvent):

1:21 AM Changeset in webkit [37031] by hyatt@apple.com

16 edits in trunk/WebCore

2008-09-28 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21191

Rework mouse wheeling significantly to make the platform event less messy and to enable wheelEvent
on ScrollView to be cross-platform.

Give the wheel event a concept of granularity (pixel, line or page). What used to be called continuous
events are now pixel wheel events.

Page scrolling as implemented in bug 17589 was completely broken. It had the following problems:
(1) Page scrolling has been corrected to be properly detected (on Windows
page wheeling is only done in the vertical direction and it is keyed off a special return value of -1). The
old code had some bizarre incorrect heuristic for "guessing" that you should page scroll and also thought
you could page scroll horizontally.
(2) Page scrolling a layer used the enclosing ScrollView's width/height instead of the layer's width/height.
This caused the scroll amount for page scrolling to be way too large on layers.

Bug 17589 got the default horizontal scrolling value wrong. It assumed 1, when the Vista default is 3.

Incorporate WebCore's line multiplier right into the deltas of the event. This eliminates the need
for separate multiplier fields (or for the need to ask if you're looking for line sensitivity).

Reviewed by Oliver Hunt

editing/EditorCommand.cpp: (WebCore::verticalScrollDistance):
page/EventHandler.cpp: (WebCore::scrollAndAcceptEvent): (WebCore::EventHandler::handleWheelEvent):
platform/PlatformWheelEvent.h: (WebCore::): (WebCore::PlatformWheelEvent::pos): (WebCore::PlatformWheelEvent::globalPos): (WebCore::PlatformWheelEvent::deltaX): (WebCore::PlatformWheelEvent::deltaY): (WebCore::PlatformWheelEvent::granularity): (WebCore::PlatformWheelEvent::x): (WebCore::PlatformWheelEvent::globalX): (WebCore::PlatformWheelEvent::ignore): (WebCore::PlatformWheelEvent::horizontalLineMultiplier): (WebCore::PlatformWheelEvent::verticalLineMultiplier):
platform/ScrollView.cpp: (WebCore::ScrollView::wheelEvent):
platform/Scrollbar.h:
platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::updateScrollbars):
platform/gtk/WheelEventGtk.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
platform/mac/ScrollViewMac.mm:
platform/mac/WheelEventMac.mm: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::updateScrollbars):
platform/qt/WheelEventQt.cpp:
platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::updateScrollbars):
platform/win/WheelEventWin.cpp: (WebCore::PlatformWheelEvent::horizontalLineMultiplier): (WebCore::PlatformWheelEvent::verticalLineMultiplier): (WebCore::PlatformWheelEvent::PlatformWheelEvent):
platform/wx/ScrollViewWx.cpp: (WebCore::ScrollView::ScrollViewPrivate::OnScrollWinEvents): (WebCore::ScrollView::wheelEvent):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateScrollInfoAfterLayout):

Sep 27, 2008:

10:38 PM Changeset in webkit [37030] by eric.carlson@apple.com

5 edits in trunk/WebCore

2008-09-27 Eric Carlson <eric.carlson@apple.com>

Reviewed by Sam Weinig.

fix https://bugs.webkit.org/show_bug.cgi?id=20994
<rdar://problem/6171023> HTMLVideoElement width and height attributes are now unsigned

HTML5 spec says HTMLVideoElement width and height attributes should be unsigned. Convert
all unsigned media attributes from string with toUInt() instead of toInt().

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::playCount): convert from attribute with toUInt().

html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::videoWidth): (WebCore::HTMLVideoElement::videoHeight): return unsigned to match idl. (WebCore::HTMLVideoElement::width): convert from attribute with toUInt() and return unsigned value. (WebCore::HTMLVideoElement::height): Ditto. (WebCore::HTMLVideoElement::setWidth): take unsigned value. (WebCore::HTMLVideoElement::setHeight): Ditto.

html/HTMLVideoElement.h: width, height, videoWidth, and videoHeight are unsigned.

html/HTMLVideoElement.idl: make width and height unsigned to match HTML5 spec.

9:59 PM Changeset in webkit [37029] by hyatt@apple.com

1 edit in trunk/WebCore/platform/mac/WheelEventMac.mm

Fix indentation error from bug 17589 fix made in WheelEventMac.mm

9:57 PM Changeset in webkit [37028] by hyatt@apple.com

1 edit in trunk/WebCore/platform/PlatformWheelEvent.h

It's SENSITIVE. SENSITIVE. Not SENSIBLE.

9:40 PM Changeset in webkit [37027] by timothy@apple.com

2 edits in trunk/WebCore

Fixes an exception when typing a command in the Console.

Reviewed by Oliver Hunt.

page/inspector/Console.js: (WebInspector.Console.prototype.addMessage): Null check this.previosMessage.

9:40 PM Changeset in webkit [37026] by timothy@apple.com

2 edits in trunk/WebCore

Fixes a bug where the Profiles panel sidebar would be empty
after closing and reopening the Web Inspector.

https://bugs.webkit.org/show_bug.cgi?id=21179

Reviewed by Sam Weinig.

page/inspector/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.reset): Don't call populateInterface, it is called automatically. (WebInspector.ProfilesPanel.prototype._populateProfiles): Return early if the sidebar is already populated.

9:38 PM Changeset in webkit [37025] by hyatt@apple.com

2 edits in trunk/WebCore

Fix for line step being too small on Windows.

8:51 PM Changeset in webkit [37024] by hyatt@apple.com

7 edits in trunk/WebCore

2008-09-27 David Hyatt <hyatt@apple.com>

Make the scrollbarUnderMouse method cross-platform.

Reviewed by Sam Weinig

platform/ScrollView.cpp: (WebCore::ScrollView::scrollbarUnderMouse):
platform/gtk/ScrollViewGtk.cpp:
platform/mac/ScrollViewMac.mm:
platform/qt/ScrollViewQt.cpp:
platform/win/ScrollViewWin.cpp:
platform/wx/ScrollViewWx.cpp:

6:50 PM Changeset in webkit [37023] by zecke@webkit.org

2 edits in trunk/WebCore

Gtk+ build fix.

6:49 PM Changeset in webkit [37022] by zecke@webkit.org

5 edits in trunk

/
2008-09-27 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=20287
[Gtk] disable plugins for gtk/directfb target

Introduce WTF_PLATFORM_X11 for X11 builds.
Also use target-specific packages when building the port

configure.ac: Do not check for cairo-ft for directfb builds.

WebCore
2008-09-27 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=20287
[Gtk] disable plugins for gtk/directfb target

Introduce WTF_PLATFORM_X11 for X11 builds.
Also use target-specific packages when building the port

platform/gtk/PlatformScreenGtk.cpp:
plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::updatePluginWidget): (WebCore::PluginView::getValueStatic): (WebCore::PluginView::getValue): (WebCore::PluginView::init):

6:08 PM Changeset in webkit [37021] by hyatt@apple.com

1 edit in trunk/WebKit/win/WebView.cpp

Missed WebKit single line change.

6:07 PM Changeset in webkit [37020] by hyatt@apple.com

1 edit in trunk/WebCore/platform/ScrollView.cpp

Oops. Checked in stale file.

6:07 PM Changeset in webkit [37019] by hyatt@apple.com

12 edits in trunk/WebCore

2008-09-27 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21188

Make scrollbar suppression and resizer avoidance cross-platform.

Reviewed by Anders

loader/FrameLoader.cpp: (WebCore::FrameLoader::transitionToCommitted):
page/FrameView.cpp: (WebCore::FrameView::resetScrollbars): (WebCore::FrameView::clear): (WebCore::FrameView::layout): (WebCore::FrameView::restoreScrollbar): (WebCore::FrameView::windowResizerRect):
page/FrameView.h:
platform/ScrollView.cpp: (WebCore::ScrollView::init): (WebCore::ScrollView::resizerOverlapsContent): (WebCore::ScrollView::adjustScrollbarsAvoidingResizerCount): (WebCore::ScrollView::setParent): (WebCore::ScrollView::setScrollbarsSuppressed): (WebCore::ScrollView::platformSetScrollbarsSuppressed):
platform/ScrollView.h: (WebCore::ScrollView::scrollbarsSuppressed): (WebCore::ScrollView::windowResizerRect):
platform/Scrollbar.cpp: (WebCore::Scrollbar::setFrameRect): (WebCore::Scrollbar::setParent):
platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::ScrollViewPrivate::adjustmentChanged): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::paint):
platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::ScrollView): (WebCore::ScrollView::~ScrollView): (WebCore::ScrollView::platformSetScrollbarsSuppressed): (WebCore::ScrollView::setScrollPosition):
platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::ScrollViewPrivate::valueChanged): (WebCore::ScrollView::frameRectsChanged): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::paint):
platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::ScrollViewPrivate::valueChanged): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::paint):
platform/wx/ScrollViewWx.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):

4:58 PM Changeset in webkit [37018] by timothy@apple.com

1 edit in trunk/LayoutTests/fast/dom/Window/window-properties-expected.txt

Update a layout test result to add console.trace.

4:46 PM Changeset in webkit [37017] by zecke@webkit.org

2 edits in trunk/WebCore

2008-09-27 Holger Hans Peter Freyther <zecke@selfish.org>

Rubber-stamped by Anders Carlsson.

Compile fix.

plugins/PluginView.cpp: (WebCore::PluginView::load):

4:23 PM Changeset in webkit [37016] by mrowe@apple.com

2 edits in trunk/WebCore

Fix <https://bugs.webkit.org/show_bug.cgi?id=21184>.
Bug 21184: REGRESSION: Reproducible crash below StringImpl::hash while running editing/deleting/5408255.html

Remove an assertion that was incorrect and that if made correct would have duplicated a check that occurred earlier in the function.

Rubber-stamped by Sam Weinig.

loader/CachedResource.cpp:

(WebCore::CachedResource::~CachedResource):

3:56 PM Changeset in webkit [37015] by zecke@webkit.org

2 edits in trunk

2008-09-27 Marco Barisione <marco.barisione@collabora.co.uk>

Reviewed by Holger Freyther.

http://bugs.webkit.org/show_bug.cgi?id=21174
[GTK][AUTOTOOLS] Enable large file support at configure time

configure.ac: Enable large file support with AC_SYS_LARGEFILE.

3:46 PM Changeset in webkit [37014] by zecke@webkit.org

2 edits in trunk/WebCore

[qt] Use QImageReader to figure out which image formats are supported

Qt can have many different plugins for different image formats. Instead of checking only for a few in WebCore use Qt to determine if this data can be treated as an image.

3:45 PM Changeset in webkit [37013] by zecke@webkit.org

3 edits in trunk/WebCore

[qt] Clean the pattern code

Use save/restore on the painter after manipulating the pen/brush
Make the context and object null checking consistent. CG is using the object unconditionally so the Qt webkit platform can do the same.
Move code below the early exit. Only use the m_ownerElement before the early exit as the CG code is doing it.

3:18 PM Changeset in webkit [37012] by timothy@apple.com

8 edits in trunk

Added support for console.trace.

JavaScriptCore:

2008-09-27 Keishi Hattori <casey.hattori@gmail.com>

Added Machine::retrieveCaller to the export list.

Reviewed by Kevin McCullough and Tim Hatcher.

JavaScriptCore.exp: Added Machine::retrieveCaller.

WebCore:

2008-09-27 Keishi Hattori <casey.hattori@gmail.com>

Added support for console.trace.

https://bugs.webkit.org/show_bug.cgi?id=19157

Reviewed by Kevin McCullough and Tim Hatcher.

bindings/js/JSConsoleCustom.cpp: (WebCore::JSConsole::trace):
page/Console.cpp: (WebCore::Console::trace): Calls Machine::retrieveCaller to get a stack trace.
page/Console.h: (WebCore::): Added TraceMessageLevel.
page/Console.idl: Added console.trace.
page/inspector/Console.js: (ConsoleMessage): Added case for TraceMessageLevel.

3:18 PM Changeset in webkit [37011] by hyatt@apple.com

2 edits in trunk/WebKit/mac

2008-09-27 David Hyatt <hyatt@apple.com>

Fix for https://bugs.webkit.org/show_bug.cgi?id=21182

Make sure Mac null checks the view like the other platforms do now that Mac goes through WebCore
to call setAllowsScrolling.

Reviewed by Mark Rowe

WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createFrame):

3:15 PM Changeset in webkit [37010] by hyatt@apple.com

5 edits in trunk/WebKit

WebKit/qt:

2008-09-27 David Hyatt <hyatt@apple.com>

Forgot to land renaming changes in WebKit.

Api/qwebframe.cpp: (QWebFrame::render): (QWebFrame::pos): (QWebFrame::geometry):
Api/qwebpage.cpp: (QWebPage::viewportSize): (QWebPage::setViewportSize):

WebKit/win:

2008-09-27 David Hyatt <hyatt@apple.com>

Land the frameGeometry->frameRect changes that I forgot to land in WebKit.

Interfaces/IWebScrollBarPrivate.idl:
WebCoreSupport/EmbeddedWidget.cpp: (EmbeddedWidget::setFrameRect): (EmbeddedWidget::frameRectsChanged):
WebCoreSupport/EmbeddedWidget.h:
WebScrollBar.cpp: (WebScrollBar::setRect): (WebScrollBar::frameRect):
WebScrollBar.h:

2:30 PM Changeset in webkit [37009] by mitz@apple.com

1 edit
2 moves in trunk/LayoutTests

Rubber-stamped by Sam Weinig.

fix typo in test name

media/video-click-dblckick-standalone-expected.txt: Copied from media/video-click-dlbclick-standalone-expected.txt.
media/video-click-dblckick-standalone.html: Copied from media/video-click-dlbclick-standalone.html.
media/video-click-dlbclick-standalone-expected.txt: Removed.
media/video-click-dlbclick-standalone.html: Removed.

2:28 PM Changeset in webkit [37008] by andersca@apple.com

7 edits
2 adds in trunk

WebCore:

2008-09-27 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=21178
<rdar://problem/6248651>

Check if the plug-in is allowed to load the resource. This matches Firefox.

Test: http/tests/plugins/local-geturl-from-remote.html

plugins/PluginView.cpp: (WebCore::PluginView::load):

WebKit/mac:

2008-09-27 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=21178
<rdar://problem/6248651>

Check if the plug-in is allowed to load the resource. This matches Firefox.

Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):

WebKitTools:

2008-09-27 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=21178
<rdar://problem/6248651>

Return the result value from getURL.

DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (getURL):

LayoutTests:

2008-09-27 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=21178
<rdar://problem/6248651>

Add tests.

http/tests/plugins/local-geturl-from-remote-expected.txt: Added.
http/tests/plugins/local-geturl-from-remote.html: Added.

2:13 PM Changeset in webkit [37007] by andersca@apple.com

4 edits in trunk/WebKit/win

2008-09-27 Anders Carlsson <andersca@apple.com>

Fix build.

WebCoreSupport/EmbeddedWidget.cpp: (EmbeddedWidget::setFrameRect): (EmbeddedWidget::frameRectsChanged):
WebCoreSupport/EmbeddedWidget.h:
WebScrollBar.cpp: (WebScrollBar::setRect): (WebScrollBar::frameGeometry):

2:06 PM Changeset in webkit [37006] by zecke@webkit.org

2 edits in trunk/WebCore

2008-09-22 Dirk Schulze <vbs85@gmx.de>

Reviewed by Eric Seidel.

Added SVG pattern support to Qt.

[Qt] SVG patterns are missing
https://bugs.webkit.org/show_bug.cgi?id=20973

svg/graphics/qt/SVGPaintServerPatternQt.cpp: (WebCore::SVGPaintServerPattern::setup):

1:18 PM Changeset in webkit [37005] by timothy@apple.com

2 edits in trunk/WebCore

Fixed a bug in the JS syntax highlighter with multiple line tokens.

https://bugs.webkit.org/show_bug.cgi?id=21171

Reviewed by Tim Hatcher.

page/inspector/SourceFrame.js: (syntaxHighlightJavascriptLine): Initialize previousMatchLength.

1:18 PM Changeset in webkit [37004] by timothy@apple.com

2 edits in trunk/WebCore

Change searching in the Profiles panel to not match the
Self and Total columns when there are no units. The only
column that is matched for unitless number searches is
now the Calls column.

https://bugs.webkit.org/show_bug.cgi?id=21169

Reviewed by Sam Weinig.

page/inspector/ProfileView.js: (WebInspector.ProfileView.prototype.performSearch):

12:56 PM Changeset in webkit [37003] by hyatt@apple.com

11 edits in trunk/WebCore

2008-09-27 David Hyatt <hyatt@apple.com>

Rename boundsGeometry -> boundsRect. Rename geometryChanged -> frameRectsChanged.

Reviewed by Sam Weinig

platform/ScrollView.h:
platform/Widget.h: (WebCore::Widget::boundsRect): (WebCore::Widget::invalidate): (WebCore::Widget::frameRectsChanged):
platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollViewScrollbar::frameRectsChanged): (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore): (WebCore::ScrollView::setFrameRect): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::frameRectsChanged):
platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::setFrameRect): (ScrollbarGtk::frameRectsChanged):
platform/gtk/ScrollbarGtk.h:
platform/gtk/WidgetGtk.cpp:
platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore): (WebCore::ScrollView::setFrameRect): (WebCore::ScrollView::frameRectsChanged): (WebCore::ScrollView::updateScrollbars):
platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore): (WebCore::ScrollView::setFrameRect): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::frameRectsChanged):
plugins/PluginView.cpp: (WebCore::PluginView::frameRectsChanged):
plugins/PluginView.h:

12:49 PM Changeset in webkit [37002] by Simon Hausmann

3 edits in trunk/WebCore

2008-09-27 Simon Hausmann <Simon Hausmann>

Refix the previous build fix to compile on non-Qt platforms, too.

12:15 PM Changeset in webkit [37001] by Simon Hausmann

6 edits in trunk/WebCore

2008-09-27 Simon Hausmann <Simon Hausmann>

Fix compilation with gcc 4.3 (probably > 4.0)

11:32 AM Changeset in webkit [37000] by Simon Hausmann

3 edits in trunk/WebKit/qt

2008-09-27 Simon Hausmann <Simon Hausmann>

Qt build fix - use frameRect instead of frameGeometry, adapt
to renamed scrollbar frameview methods.

10:41 AM Changeset in webkit [36999] by andersca@apple.com

2 edits in trunk/JavaScriptCore

2008-09-27 Anders Carlsson <andersca@apple.com>

Fix build.

VM/CTI.cpp: (JSC::):

10:20 AM Changeset in webkit [36998] by ggaren@apple.com

1 edit in trunk/JavaScriptCore/ChangeLog

Added bug #

10:19 AM Changeset in webkit [36997] by ggaren@apple.com

6 edits in trunk/JavaScriptCore

2008-09-27 Geoffrey Garen <ggaren@apple.com>

Reviewed by Cameron Zwarich.

Store the callee CodeBlock, not the caller CodeBlock, in the call frame
header. Nix the "codeBlock" local variable, and access the callee
CodeBlock through the call frame header instead.

Profit: call + return are simpler, because they don't have to update the
"codeBlock" local variable.

Because CTI keeps "r" in a register, reading the callee CodeBlock relative
to "r" can be very fast, in any cases we care to optimize. Presently,
no such cases seem important.

Also, stop writing "dst" to the call frame header. CTI doesn't use it.

21.6% speedup on empty function call benchmark.
3.8% speedup on SunSpider --v8.
2.1% speedup on v8 benchmark.
0.7% speedup on SunSpider (6% speedup on controlflow-recursive).

Small regression in bytecode, because currently every op_ret reads the
callee CodeBlock to check needsFullScopeChain, and bytecode does not
keep "r" in a register. On-balance, this is probably OK, since CTI is
our high-performance execution model. Also, this should go away once
we make needsFullScopeChain statically determinable at parse time.

VM/CTI.cpp: (JSC::CTI::compileOpCall): The speedup! (JSC::CTI::privateCompileSlowCases): ditto

VM/CTI.h: (JSC::): Fixed up magic trampoline constants to account for the nixed "codeBlock" argument. (JSC::CTI::execute): Changed trampoline function not to take a "codeBlock" argument, since codeBlock is now stored in the call frame header.

VM/Machine.cpp: Read the callee CodeBlock from the register file. Use a NULL CallerRegisters in the call frame header to signal a built-in caller, since CodeBlock is now never NULL.

VM/Machine.h: Made some stand-alone functions Machine member functions so they could call the private codeBlock() accessor in the Register class, of which Machine is a friend. Renamed "CallerCodeBlock" to "CodeBlock", since it's no longer the caller's CodeBlock.

VM/RegisterFile.h: Marked some methods const to accommodate a const RegisterFile* being passed around in Machine.cpp.

1:23 AM Changeset in webkit [36996] by jmalonzo@webkit.org

2 edits in trunk/WebKit/qt

2008-09-27 Jan Michael Alonzo <jmalonzo@webkit.org>

Qt build fix - rename frameGeometry to frameRect per r36995.

Api/qwebframe.cpp: (QWebFrame::render): (QWebFrame::pos): (QWebFrame::geometry):

1:01 AM Changeset in webkit [36995] by hyatt@apple.com

31 edits in trunk/WebCore

2008-09-27 David Hyatt <hyatt@apple.com>

Rename frameGeometry to frameRect. Rename setFrameGeometry to setFrameRect.

Reviewed by Dan Bernstein

WebCore.base.exp:
page/FrameView.cpp: (WebCore::FrameView::FrameView): (WebCore::FrameView::updateControlTints):
platform/ScrollView.h:
platform/Scrollbar.cpp: (WebCore::Scrollbar::Scrollbar): (WebCore::Scrollbar::paint): (WebCore::Scrollbar::setFrameRect):
platform/Scrollbar.h:
platform/ScrollbarThemeComposite.cpp: (WebCore::ScrollbarThemeComposite::paint):
platform/Widget.h: (WebCore::Widget::x): (WebCore::Widget::y): (WebCore::Widget::width): (WebCore::Widget::height): (WebCore::Widget::size): (WebCore::Widget::pos): (WebCore::Widget::resize): (WebCore::Widget::move):
platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollViewScrollbar::geometryChanged): (WebCore::ScrollView::update): (WebCore::ScrollView::setFrameRect): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::scrollbarUnderMouse): (WebCore::ScrollView::paint):
platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::setFrameRect): (ScrollbarGtk::geometryChanged):
platform/gtk/ScrollbarGtk.h:
platform/gtk/WidgetGtk.cpp: (WebCore::Widget::frameRect): (WebCore::Widget::setFrameRect):
platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::trackRect): (WebCore::ScrollbarThemeMac::paint):
platform/mac/WidgetMac.mm: (WebCore::Widget::frameRect): (WebCore::Widget::setFrameRect):
platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::setFrameRect): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::scrollbarUnderMouse): (WebCore::ScrollView::paint):
platform/qt/ScrollbarThemeQt.cpp: (WebCore::styleOptionSlider):
platform/qt/WidgetQt.cpp: (WebCore::Widget::frameRect): (WebCore::Widget::setFrameRect):
platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::invalidateItem): (WebCore::PopupMenu::valueChanged): (WebCore::PopupWndProc):
platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::setFrameRect): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::scrollbarUnderMouse): (WebCore::ScrollView::paint):
platform/win/ScrollbarThemeSafari.cpp: (WebCore::ScrollbarThemeSafari::trackRect):
platform/win/WidgetWin.cpp: (WebCore::Widget::frameRect): (WebCore::Widget::setFrameRect):
platform/wx/WidgetWx.cpp: (WebCore::Widget::frameRect): (WebCore::Widget::setFrameRect):
plugins/PluginView.cpp: (WebCore::PluginView::setFrameRect):
plugins/PluginView.h:
plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::updatePluginWidget): (WebCore::PluginView::paint): (WebCore::PluginView::init):
plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::updatePluginWidget): (WebCore::PluginView::init):
plugins/win/PluginViewWin.cpp: (WebCore::PluginView::updatePluginWidget): (WebCore::PluginView::paintMissingPluginIcon): (WebCore::PluginView::paint): (WebCore::PluginView::init):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::positionOverflowControls):
rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintScrollbar):
rendering/RenderPart.cpp: (WebCore::RenderPart::updateWidgetPosition):
rendering/RenderWidget.cpp: (WebCore::RenderWidget::setWidgetGeometry): (WebCore::RenderWidget::updateWidgetPosition):

12:51 AM Changeset in webkit [36994] by hyatt@apple.com