⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 2, 2008:

11:20 PM Changeset in webkit [37222] by mitz@apple.com
  • 5 edits
    2 adds in trunk

WebCore:

Reviewed by Geoffrey Garen and Sam Weinig.

  • fix SVGFontFaceElement leaks seen in Acid3
  • make font-face elements take effect only when they are in the document tree

Test: svg/custom/font-face-not-in-document.svg

  • svg/SVGFontData.h: Changed the m_svgFontFaceElement member from a RefPtr to a plain pointer to break a ref cycle. (WebCore::SVGFontData::svgFontFaceElement):
  • svg/SVGFontFaceElement.cpp: Changed to insert and remove the @font-face rule from the document's mapped element sheet when the element is inserted and removed from the document, and to update it only when the element is in the document. (WebCore::SVGFontFaceElement::SVGFontFaceElement): (WebCore::SVGFontFaceElement::parseMappedAttribute): (WebCore::SVGFontFaceElement::rebuildFontFace): (WebCore::SVGFontFaceElement::insertedIntoDocument): (WebCore::SVGFontFaceElement::removedFromDocument): (WebCore::SVGFontFaceElement::childrenChanged): (WebCore::SVGFontFaceElement::removeFromMappedElementSheet):
  • svg/SVGFontFaceElement.h:

LayoutTests:

Reviewed by Geoffrey Garen and Sam Weinig.

  • svg/custom/font-face-not-in-document-expected.txt: Added.
  • svg/custom/font-face-not-in-document.svg: Added.
6:59 PM Changeset in webkit [37221] by mrowe@apple.com
  • 2 edits in branches/Safari-3-2-branch/JavaScriptCore

Merge r31824.

5:43 PM Changeset in webkit [37220] by Simon Fraser
  • 6 edits in trunk/WebCore

2008-10-01 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

Fix RenderFileUploadControl::setStyle() and
RenderMenuList::setStyle() to not touch the style; replace
with html4.css and CSSStyleSelector changes.

​https://bugs.webkit.org/show_bug.cgi?id=21287

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle):
  • css/html4.css:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::setStyle):
  • rendering/RenderFileUploadControl.cpp:
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::setStyle):
5:41 PM Changeset in webkit [37219] by Simon Fraser
  • 7 edits in trunk

2008-10-01 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

Clean up code that changes the RenderStyle passed in to
table renderer setStyle() methods.

​https://bugs.webkit.org/show_bug.cgi?id=21287

Tests: fast/table/floating-th.html

fast/table/table-display-types-strict.html
fast/table/table-display-types.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::setStyle):
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::setStyle):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::setStyle):
5:28 PM Changeset in webkit [37218] by Darin Adler
  • 2 edits in trunk/WebCore

2008-10-02 Darin Adler <Darin Adler>

  • fix build
  • bindings/scripts/CodeGeneratorJS.pm: Need to replace the -> with a . here too. Not just locally in my generated file!
5:25 PM Changeset in webkit [37217] by adele@apple.com
  • 15 edits in trunk

WebCore:

2008-10-02 Adele Peterson <​adele@apple.com>

Reviewed by Dan Bernstein.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=21299
REGRESSION: <input> color specified in inline style applies to placeholder

I recently added a pseudo-class for the placeholder, but that can be overridden by inline style changes. A pseudo-element
is more appropriate. This change adds "-webkit-input-placeholder".

  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): Added definition for "-webkit-input-placeholder" pseudo element.
  • css/CSSSelector.h: (WebCore::CSSSelector::): Added PseudoInputPlaceholder.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Added case for PseudoInputPlaceholder.
  • css/html4.css: Added rule for -webkit-input-placeholder pseudo-element.
  • rendering/style/RenderStyle.h: (WebCore::RenderStyle::): Added INPUT_PLACEHOLDER.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setValue): Check that its a text field before calling updatePlaceholderVisibility. (WebCore::HTMLInputElement::setValueFromRenderer): ditto. (WebCore::HTMLInputElement::updatePlaceholderVisibility): Instead of calling setChanged(), call updatePlaceholderVisibility on the renderer. setChanged wouldn't actually trigger setStyle since the style for the input element won't actually change.
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::createInnerTextStyle): Get the pseudoStyle when the placeholder is visible. (WebCore::RenderTextControl::updatePlaceholderVisibility): Sets the style on the inner text block, and calls updateFromElement so the text will be updated correctly.
  • rendering/RenderTextControl.h:

LayoutTests:

2008-10-02 Adele Peterson <​adele@apple.com>

Reviewed by Dan Bernstein.

Update tests for ​https://bugs.webkit.org/show_bug.cgi?id=21299
REGRESSION: <input> color specified in inline style applies to placeholder

  • fast/forms/placeholder-pseudo-style.html:
  • platform/mac/fast/forms/password-placeholder-expected.txt:
  • platform/mac/fast/forms/password-placeholder-text-security-expected.txt:
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/mac/fast/forms/placeholder-set-attribute-expected.txt:
4:59 PM Changeset in webkit [37216] by Chris Fleizach
  • 6 edits in trunk

<rdar://problem/6227690> There are a bunch of tables on this page that don't seem to be real tables

4:48 PM Changeset in webkit [37215] by Darin Adler
  • 20 edits in trunk

JavaScriptCore:

2008-10-02 Darin Adler <Darin Adler>

Reviewed by Geoff Garen.

1.019x as fast on SunSpider.

  • API/JSBase.cpp: (JSEvaluateScript): Use heap. instead of heap-> to work with the heap. (JSCheckScriptSyntax): Ditto. (JSGarbageCollect): Ditto. (JSReportExtraMemoryCost): Ditto.
  • API/JSContextRef.cpp: (JSGlobalContextRetain): Ditto. (JSGlobalContextRelease): Destroy the heap with the destroy function instead of the delete operator. (JSContextGetGlobalObject): Use heap. instead of heap-> to work with the heap.
  • API/JSObjectRef.cpp: (JSObjectMake): Use heap. instead of heap-> to work with the heap. (JSObjectMakeFunctionWithCallback): Ditto. (JSObjectMakeConstructor): Ditto. (JSObjectMakeFunction): Ditto. (JSObjectMakeArray): Ditto. (JSObjectMakeDate): Ditto. (JSObjectMakeError): Ditto. (JSObjectMakeRegExp): Ditto. (JSObjectHasProperty): Ditto. (JSObjectGetProperty): Ditto. (JSObjectSetProperty): Ditto. (JSObjectGetPropertyAtIndex): Ditto. (JSObjectSetPropertyAtIndex): Ditto. (JSObjectDeleteProperty): Ditto. (JSObjectCallAsFunction): Ditto. (JSObjectCallAsConstructor): Ditto. (JSObjectCopyPropertyNames): Ditto. (JSPropertyNameAccumulatorAddName): Ditto.
  • API/JSValueRef.cpp: (JSValueIsEqual): Ditto. (JSValueIsInstanceOfConstructor): Ditto. (JSValueMakeNumber): Ditto. (JSValueMakeString): Ditto. (JSValueToNumber): Ditto. (JSValueToStringCopy): Ditto. (JSValueToObject): Ditto. (JSValueProtect): Ditto. (JSValueUnprotect): Ditto.
  • kjs/ExecState.h: (JSC::ExecState::heap): Update to use the & operator.
  • kjs/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): Update to initialize a heap member instead of calling new to make a heap. (JSC::JSGlobalData::~JSGlobalData): Destroy the heap with the destroy function instead of the delete operator.
  • kjs/JSGlobalData.h: Change from Heap* to a Heap.
  • kjs/JSGlobalObject.cpp: (JSC::JSGlobalObject::mark): Use the & operator here. (JSC::JSGlobalObject::operator new): Use heap. instead of heap-> to work with the heap.

WebCore:

2008-10-02 Darin Adler <Darin Adler>

Reviewed by Geoff Garen.

  • bindings/js/GCController.cpp: (WebCore::collect): Use heap. instead of heap-> to work with the heap. (WebCore::GCController::gcTimerFired): Ditto. (WebCore::GCController::garbageCollectNow): Ditto.
  • bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::operator new): Ditto.
  • storage/Database.cpp: (WebCore::Database::Database): Ditto.

WebKit/mac:

2008-10-02 Darin Adler <Darin Adler>

Reviewed by Geoff Garen.

  • Misc/WebCoreStatistics.mm: (+[WebCoreStatistics javaScriptObjectsCount]): Use heap. instead of heap-> to work with the heap. (+[WebCoreStatistics javaScriptGlobalObjectsCount]): Ditto. (+[WebCoreStatistics javaScriptProtectedObjectsCount]): Ditto. (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]): Ditto. (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]): Ditto. (+[WebCoreStatistics javaScriptReferencedObjectsCount]): Ditto.

WebKit/win:

2008-10-02 Darin Adler <Darin Adler>

  • WebCoreStatistics.cpp: (WebCoreStatistics::javaScriptObjectsCount): Use heap. instead of heap-> to work with the heap. (WebCoreStatistics::javaScriptGlobalObjectsCount): Ditto. (WebCoreStatistics::javaScriptProtectedObjectsCount): Ditto. (WebCoreStatistics::javaScriptProtectedGlobalObjectsCount): Ditto. (WebCoreStatistics::javaScriptProtectedObjectTypeCounts): Ditto.
  • WebJavaScriptCollector.cpp: (WebJavaScriptCollector::objectCount): Ditto.
4:05 PM Changeset in webkit [37214] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/gtk/ScrollViewGtk.cpp

Fix Gtk bustage.

3:19 PM Changeset in webkit [37213] by cwzwarich@webkit.org
  • 5 edits in trunk/JavaScriptCore

2008-10-02 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Geoff Garen.

Bug 21317: Replace RegisterFile size and capacity information with Register pointers
<​https://bugs.webkit.org/show_bug.cgi?id=21317>

This is a 2.3% speedup on the V8 DeltaBlue benchmark, a 3.3% speedup on
the V8 Raytrace benchmark, and a 1.0% speedup on SunSpider.

  • VM/Machine.cpp: (JSC::slideRegisterWindowForCall): (JSC::Machine::callEval): (JSC::Machine::execute): (JSC::Machine::privateExecute): (JSC::Machine::cti_op_call_JSFunction): (JSC::Machine::cti_op_construct_JSConstruct):
  • VM/RegisterFile.cpp: (JSC::RegisterFile::~RegisterFile):
  • VM/RegisterFile.h: (JSC::RegisterFile::RegisterFile): (JSC::RegisterFile::start): (JSC::RegisterFile::end): (JSC::RegisterFile::size): (JSC::RegisterFile::shrink): (JSC::RegisterFile::grow): (JSC::RegisterFile::lastGlobal): (JSC::RegisterFile::markGlobals): (JSC::RegisterFile::markCallFrames):
  • kjs/JSGlobalObject.cpp: (JSC::JSGlobalObject::copyGlobalsTo):
2:54 PM Changeset in webkit [37212] by adele@apple.com
  • 8 edits in trunk/LayoutTests

2008-10-02 Adele Peterson <​adele@apple.com>

Update results for mac-tiger.

  • platform/mac-tiger/svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
  • platform/mac-tiger/svg/hixie/perf/001-expected.txt:
  • platform/mac-tiger/svg/hixie/perf/002-expected.txt:
  • platform/mac-tiger/svg/hixie/text/003-expected.txt:
  • platform/mac-tiger/svg/hixie/text/003a-expected.txt:
  • platform/mac-tiger/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt:
  • platform/mac-tiger/svg/text/text-path-01-b-expected.txt:
2:33 PM Changeset in webkit [37211] by hyatt@apple.com
  • 2 edits in trunk/WebKit/win

Fix scrolling=no iframe regression on Windows.

2:03 PM Changeset in webkit [37210] by hyatt@apple.com
  • 2 edits in trunk/WebKit/win

Fix Win build bustage.

1:46 PM Changeset in webkit [37209] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Alexey Proskuryakov.

  • fix a Database leak that resulted in Document leaks
  • storage/Database.cpp: (WebCore::Database::openDatabase): Account for the fact that RefCounted objects start out with a ref count of 1.
1:29 PM Changeset in webkit [37208] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-10-02 Sam Weinig <​sam@webkit.org>

Reviewed by Mr. Geoffrey Garen.

Always mark your parent before marking members.

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::mark):
1:26 PM Changeset in webkit [37207] by Adam Roben
  • 2 edits in trunk/BugsSite
  • template/en/custom/attachment/reviewform.html.tmpl: Fix typo.
1:23 PM Changeset in webkit [37206] by Adam Roben
  • 2 edits in trunk/BugsSite
  • template/en/custom/attachment/review.html.tmpl: Fix URLs
1:21 PM Changeset in webkit [37205] by Adam Roben
  • 3 edits
    2 adds in trunk/BugsSite

Fix Bug 21315: bugs.webkit.org should have a nicer patch review interface

​https://bugs.webkit.org/show_bug.cgi?id=21315

Reviewed by Tim Hatcher.

  • attachment.cgi: (top level): Added support for the "review" and "reviewform" actions. (sub edit): Accept the template name as a parameter. If no name is give, use "edit" as before.
  • template/en/custom/attachment/list.html.tmpl: Added a "Review Patch" link for all patch attachments.
  • template/en/custom/attachment/review.html.tmpl: Added. Simple <frameset> page to show the patch on the top and a comment form on the bottom.
  • template/en/custom/attachment/reviewform.html.tmpl: Added. Simple comment form for reviewing patches.
1:17 PM Changeset in webkit [37204] by hyatt@apple.com
  • 26 edits in trunk

WebCore:

2008-10-02 David Hyatt <​hyatt@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=21314


Make scrollBackingStore cross-platform.

Reviewed by Sam Weinig

  • loader/EmptyClients.h: (WebCore::EmptyChromeClient::repaint): (WebCore::EmptyChromeClient::scroll):
  • page/Chrome.cpp: (WebCore::Chrome::repaint): (WebCore::Chrome::scroll):
  • page/Chrome.h:
  • page/ChromeClient.h:
  • page/EventHandler.cpp: (WebCore::EventHandler::handleAutoscroll):
  • platform/HostWindow.h:
  • platform/ScrollView.cpp: (WebCore::ScrollView::scrollContents): (WebCore::ScrollView::addPanScrollIcon): (WebCore::ScrollView::removePanScrollIcon):
  • platform/ScrollView.h:
  • platform/gtk/ScrollViewGtk.cpp:
  • platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::~ScrollView):
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::ScrollView): (WebCore::ScrollView::~ScrollView):

WebKit/gtk:

2008-10-02 David Hyatt <​hyatt@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=21314


Make scrollBackingStore cross-platform.

Reviewed by Sam Weinig

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::repaint): (WebKit::ChromeClient::scroll):
  • WebCoreSupport/ChromeClientGtk.h:

WebKit/mac:

2008-10-02 David Hyatt <​hyatt@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=21314


Make scrollBackingStore cross-platform.

Reviewed by Sam Weinig

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::repaint): (WebChromeClient::scroll):

WebKit/qt:

2008-10-02 David Hyatt <​hyatt@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=21314


Make scrollBackingStore cross-platform.

Reviewed by Sam Weinig

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::repaint): (WebCore::ChromeClientQt::scroll):
  • WebCoreSupport/ChromeClientQt.h:

WebKit/win:

2008-10-02 David Hyatt <​hyatt@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=21314


Make scrollBackingStore cross-platform.

Reviewed by Sam Weinig

  • WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::repaint): (WebChromeClient::scroll):
  • WebCoreSupport/WebChromeClient.h:
  • WebView.cpp: (WebView::repaint):
  • WebView.h:
12:59 PM Changeset in webkit [37203] by kevino@webkit.org
  • 5 edits in trunk

wx build fixes after Frame/ScrollView changes.

12:33 PM Changeset in webkit [37202] by brettw@chromium.org
  • 92 edits in trunk

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=21292

Revert the changes to enclosingIntRect made in r12530 since the new code
doesn't round correctly.

11:48 AM Changeset in webkit [37201] by mitz@apple.com
  • 4 edits in trunk/WebCore

Reviewed by Anders Carlsson and Eric Seidel.

  • fix HTMLCanvaseElement leak from -webkit-canvas() values

Changed the m_element member of CSSCanvasValue from a RefPtr to a plain
pointer, as the document owns the canvas elements. Added code to release
those elements in Document::removedLastRef() because they reference
the document.

  • css/CSSCanvasValue.cpp: (WebCore::CSSCanvasValue::element):
  • css/CSSCanvasValue.h: (WebCore::CSSCanvasValue::CSSCanvasValue):
  • dom/Document.cpp: (WebCore::Document::removedLastRef):
11:40 AM Changeset in webkit [37200] by ap@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

A typo fix for ChangeLog.

11:39 AM Changeset in webkit [37199] by ap@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Maciej Stachowiak.

Build fix for platform that don't implement WTF::ThreadSpecific.

  • bindings/js/JSDOMBinding.cpp: (WebCore::wrapperSet): Guard ThreadSpecific use with #if ENABLE(WORKERS). No platform defines this yet, but this code is only needed for JS bindings in worker threads.
11:23 AM Changeset in webkit [37198] by hyatt@apple.com
  • 23 edits in trunk

WebCore:

2008-10-01 David Hyatt <​hyatt@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=21298


Make updateScrollbars cross-platform. For now a stubbed out scrollContents function is invoked to do the scrolling of the backing store. Next patch
will make that cross-platform.


The ScrollView now implements ScrollbarClient, which means that there was a clash of windowClipRect methods from the
multiple inheritance. For now I solved this by adding a Scrollbar* to the ScrollbarClient version of the method, but longer term
windowClipRect is going to be removed from ScrollbarClient (when Widget invalidation gets rewritten).


Reviewed by Sam Weinig

  • page/FrameView.cpp: (WebCore::FrameView::windowClipRect): (WebCore::FrameView::isActive):
  • page/FrameView.h: (WebCore::FrameView::visibleContentsResized):
  • platform/PopupMenu.h:
  • platform/ScrollView.cpp: (WebCore::ScrollView::init): (WebCore::ScrollView::destroy): (WebCore::ScrollView::setHasHorizontalScrollbar): (WebCore::ScrollView::setHasVerticalScrollbar): (WebCore::ScrollView::valueChanged): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::scrollContents): (WebCore::ScrollView::platformHandleHorizontalAdjustment): (WebCore::ScrollView::platformHandleVerticalAdjustment):
  • platform/ScrollView.h:
  • platform/Scrollbar.cpp: (WebCore::Scrollbar::windowClipRect):
  • platform/ScrollbarClient.h:
  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::platformHandleHorizontalAdjustment): (WebCore::ScrollView::platformHandleVerticalAdjustment):
  • platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::scrollContents):
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::windowClipRect):
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::scrollContents):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::windowClipRect):
  • rendering/RenderLayer.h:
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::panScroll): (WebCore::RenderListBox::windowClipRect):
  • rendering/RenderListBox.h:

WebKit/win:

2008-10-01 David Hyatt <​hyatt@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=21298


Make updateScrollbars cross-platform. For now a stubbed out scrollContents function is invoked to do the scrolling of the backing store. Next patch
will make that cross-platform.


The ScrollView now implements ScrollbarClient, which means that there was a clash of windowClipRect methods from the
multiple inheritance. For now I solved this by adding a Scrollbar* to the ScrollbarClient version of the method, but longer term
windowClipRect is going to be removed from ScrollbarClient (when Widget invalidation gets rewritten).

Reviewed by Sam Weinig

  • WebScrollBar.cpp: (WebScrollBar::windowClipRect):
  • WebScrollBar.h:
10:54 AM Changeset in webkit [37197] by sfalken@apple.com
  • 2 edits in branches/Safari-3-2-branch/WebKit/win

Merge r31212 for fix <rdar://problem/6168976> visitCount not updated in History.plist

10:03 AM Changeset in webkit [37196] by Adam Roben
  • 2 edits
    2 deletes in trunk/BugsSite

Remove references to some backup files I created when implementing PrettyPatch in Bugzilla

Reviewed by Tim Hatcher.

  • attachment-aroben.cgi: Removed.
  • template/en/default/attachment/edit-aroben.html.tmpl: Removed.
  • template/en/custom/attachment/edit.html.tmpl: Removed an erroneous reference to attachment-aroben.cgi. attachment.cgi will work just fine.
10:00 AM Changeset in webkit [37195] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-10-02 Cameron Zwarich <​zwarich@apple.com>

Rubber-stamped by Darin Adler.

Change bitwise operations introduced in r37166 to boolean operations. We
only use bitwise operations over boolean operations for increasing
performance in extremely hot code, but that does not apply to anything
in the parser.

  • kjs/grammar.y:
9:45 AM Changeset in webkit [37194] by barraclough@apple.com
  • 6 edits
    3 adds in trunk

JavaScriptCore:

2008-10-02 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Darin Adler.

Fix for bug #21232 - should reset m_isPendingDash on flush,
and should allow '\-' as beginning or end of a range (though
not to specifiy a range itself).

  • ChangeLog:
  • wrec/CharacterClassConstructor.cpp: (JSC::CharacterClassConstructor::put): (JSC::CharacterClassConstructor::flush):
  • wrec/CharacterClassConstructor.h: (JSC::CharacterClassConstructor::flushBeforeEscapedHyphen):
  • wrec/WREC.cpp: (JSC::WRECGenerator::generateDisjunction): (JSC::WRECParser::parseCharacterClass): (JSC::WRECParser::parseDisjunction):
  • wrec/WREC.h:

LayoutTests:

2008-10-02 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Darin Adler.

Layout tests for for bug #21232 - plus a range of tests for, um, ranges.

  • fast/js/regexp-ranges-and-escaped-hyphens-expected.txt: Added.
  • fast/js/regexp-ranges-and-escaped-hyphens.html: Added.
  • fast/js/resources/regexp-ranges-and-escaped-hyphens.js: Added.
9:45 AM Changeset in webkit [37193] by ap@webkit.org
  • 1 edit in trunk/JavaScriptCore/JavaScriptCore.exp

Forgot to land JavaScriptCore.exp with the previous check-in.

9:39 AM Changeset in webkit [37192] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

2008-10-02 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

  • remove the "static" from declarations in a header file, since we don't want them to have internal linkage
  • VM/Machine.h: Remove the static keyword from the constant and the three inline functions that Geoff just moved here.
9:22 AM Changeset in webkit [37191] by ggaren@apple.com
  • 4 edits in trunk/JavaScriptCore

2008-10-02 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.


Fixed ​https://bugs.webkit.org/show_bug.cgi?id=21283.
Profiler Crashes When Started

  • VM/Machine.cpp:
  • VM/Machine.h: (JSC::makeHostCallFramePointer): (JSC::isHostCallFrame): (JSC::stripHostCallFrameBit): Moved some things to the header so JSGlobalObject could use them.
  • kjs/JSGlobalObject.h: (JSC::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData): Call the new makeHostCallFramePointer API, since 0 no longer indicates a host call frame.
9:18 AM Changeset in webkit [37190] by ap@webkit.org
  • 35 edits
    2 deletes in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=21304
Stop using a static wrapper map for WebCore JS bindings

The static domObjects map was not thread safe.

  • dom/Document.h: (WebCore::Document::messagePorts): Added an accessor for JSDocument to iterate over message ports. (WebCore::Document::xmlHttpRequests): Ditto for XMLHttpRequests.
  • dom/Document.cpp: (WebCore::Document::createdXMLHttpRequest): (WebCore::Document::destroyedXMLHttpRequest): Moved XMLHttpRequest tracking from a global map to Document.
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • webcore-base.bkl:
  • bindings/DOMProtect.cpp: Removed.
  • bindings/DOMProtect.h: Removed. Removed gcProtect(Unprotect)DOMObject - its callers do not have a JSGlobalData reference, so they can no longer protect bindings objects.
  • dom/MessagePort.cpp: (WebCore::CloseMessagePortTimer::CloseMessagePortTimer): (WebCore::CloseMessagePortTimer::fired): (WebCore::MessagePort::MessagePort): (WebCore::MessagePort::queueCloseEvent): (WebCore::MessagePort::setPendingActivity): (WebCore::MessagePort::unsetPendingActivity):
  • dom/MessagePort.h: (WebCore::MessagePort::hasPendingActivity): MessagePort now counts outstanding async events, so JSDocument::mark can decide whether to protect it.
  • xml/XMLHttpRequest.h: (WebCore::XMLHttpRequest::hasPendingActivity):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::XMLHttpRequest): (WebCore::XMLHttpRequest::~XMLHttpRequest): (WebCore::XMLHttpRequest::loadRequestAsynchronously): (WebCore::XMLHttpRequest::dropProtection): (WebCore::XMLHttpRequest::didFinishLoadingPreflight): (WebCore::XMLHttpRequest::cancelRequests): (WebCore::XMLHttpRequest::detachRequests): (WebCore::XMLHttpRequest::setPendingActivity): (WebCore::XMLHttpRequest::unsetPendingActivity): Moved XMLHttpRequest tracking from a global map to Document.
  • bindings/js/JSDOMBinding.cpp: (WebCore::wrapperSet): (WebCore::DOMObjectWrapperMap::mapFor): (WebCore::DOMObjectWrapperMap::get): (WebCore::DOMObjectWrapperMap::set): (WebCore::DOMObjectWrapperMap::remove): (WebCore::getCachedDOMObjectWrapper): (WebCore::cacheDOMObjectWrapper): (WebCore::forgetDOMObject): (WebCore::getCachedDOMNodeWrapper): (WebCore::forgetDOMNode): (WebCore::cacheDOMNodeWrapper): (WebCore::markActiveObjectsForDocument):
  • bindings/js/JSDOMBinding.h: (WebCore::createDOMObjectWrapper): (WebCore::getDOMObjectWrapper): Wrapper map is now kept as JSGlobalData::clientData. Also changed debug-only wrapperSet to be per-thread (this is slower than going to JSGlobalData, but fast enough for debug). WebCore objects can never migrate between threads.
  • bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::mark): Call markActiveObjectsForDocument() from JSDOMBinding.
  • bindings/js/JSCSSRuleCustom.cpp: (WebCore::toJS):
  • bindings/js/JSCSSValueCustom.cpp: (WebCore::toJS):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::markDOMObjectWrapper): (WebCore::JSDOMWindow::mark):
  • bindings/js/JSEventCustom.cpp: (WebCore::toJS):
  • bindings/js/JSEventTarget.cpp: (WebCore::toJS):
  • bindings/js/JSHTMLCollectionCustom.cpp: (WebCore::toJS):
  • bindings/js/JSImageDataCustom.cpp: (WebCore::toJS):
  • bindings/js/JSMessageChannelCustom.cpp: (WebCore::JSMessageChannel::mark):
  • bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::mark):
  • bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::mark):
  • bindings/js/JSSVGPathSegCustom.cpp: (WebCore::toJS):
  • bindings/js/JSStyleSheetCustom.cpp: (WebCore::toJS):
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::mark):
  • bindings/js/JSXMLHttpRequestUploadCustom.cpp: (WebCore::JSXMLHttpRequestUpload::mark):
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::finishedWithEvent):
  • bindings/scripts/CodeGeneratorJS.pm: Pass a JSGlobalData reference to functions that track JS wrapper objects.

JavaScriptCore:

  • kjs/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): (JSC::JSGlobalData::~JSGlobalData): (JSC::JSGlobalData::ClientData::~ClientData):
  • kjs/JSGlobalData.h: Added a client data member to JSGlobalData. WebCore will use it to store bindings-related global data.
12:52 AM Changeset in webkit [37189] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • build fix
  • page/JavaScriptCallFrame.idl:
12:35 AM Changeset in webkit [37188] by oliver@apple.com
  • 4 edits in trunk/WebCore

Add new file to project files

Reviewed by NOBODY (Build fix)

12:15 AM Changeset in webkit [37187] by ggaren@apple.com
  • 3 edits in trunk/WebCore

2008-10-02 Geoffrey Garen <​ggaren@apple.com>

Not reviewed.

Try to fix some more builds.

  • GNUmakefile.am:
  • WebCore.pro:
12:13 AM Changeset in webkit [37186] by ggaren@apple.com
  • 2 edits in trunk/WebCore

2008-10-02 Geoffrey Garen <​ggaren@apple.com>

Not reviewed.


Try to fix Windows build.

  • WebCore.vcproj/WebCore.vcproj:
12:04 AM Changeset in webkit [37185] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-10-02 Geoffrey Garen <​ggaren@apple.com>

Not reviewed.


Try to fix Qt build.

  • kjs/Error.h:

Oct 1, 2008:

11:44 PM Changeset in webkit [37184] by ggaren@apple.com
  • 54 edits
    1 copy in trunk

JavaScriptCore:

2008-10-01 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin Adler and Cameron Zwarich.

Preliminary step toward dynamic recompilation: Standardized and
simplified the parsing interface.


The main goal in this patch is to make it easy to ask for a duplicate
compilation, and get back a duplicate result -- same source URL, same
debugger / profiler ID, same toString behavior, etc.


The basic unit of compilation and evaluation is now SourceCode, which
encompasses a SourceProvider, a range in that provider, and a starting
line number.

A SourceProvider now encompasses a source URL, and *is* a source ID,
since a pointer is a unique identifier.

  • API/JSBase.cpp: (JSEvaluateScript): (JSCheckScriptSyntax): Provide a SourceCode to the Interpreter, since other APIs are no longer supported.


  • VM/CodeBlock.h: (JSC::EvalCodeCache::get): Provide a SourceCode to the Interpreter, since other APIs are no longer supported. (JSC::CodeBlock::CodeBlock): ASSERT something that used to be ASSERTed by our caller -- this is a better bottleneck.
  • VM/CodeGenerator.cpp: (JSC::CodeGenerator::CodeGenerator): Updated for the fact that FunctionBodyNode's parameters are no longer a WTF::Vector.
  • kjs/Arguments.cpp: (JSC::Arguments::Arguments): ditto
  • kjs/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::evaluate): Provide a SourceCode to the Parser, since other APIs are no longer supported.
  • kjs/FunctionConstructor.cpp: (JSC::constructFunction): Provide a SourceCode to the Parser, since other APIs are no longer supported. Adopt FunctionBodyNode's new "finishParsing" API.
  • kjs/JSFunction.cpp: (JSC::JSFunction::lengthGetter): (JSC::JSFunction::getParameterName): Updated for the fact that FunctionBodyNode's parameters are no longer a wtf::Vector.
  • kjs/JSFunction.h: Nixed some cruft.
  • kjs/JSGlobalObjectFunctions.cpp: (JSC::globalFuncEval): Provide a SourceCode to the Parser, since other APIs are no longer supported.
  • kjs/Parser.cpp: (JSC::Parser::parse): Require a SourceCode argument, instead of a bunch of broken out parameters. Stop tracking sourceId as an integer, since we use the SourceProvider pointer for this now. Don't clamp the startingLineNumber, since SourceCode does that now.
  • kjs/Parser.h: (JSC::Parser::parse): Standardized the parsing interface to require a SourceCode.
  • kjs/Shell.cpp: (functionRun): (functionLoad): (prettyPrintScript): (runWithScripts): (runInteractive): Provide a SourceCode to the Interpreter, since other APIs are no longer supported.
  • kjs/SourceProvider.h: (JSC::SourceProvider::SourceProvider): (JSC::SourceProvider::url): (JSC::SourceProvider::asId): (JSC::UStringSourceProvider::create): (JSC::UStringSourceProvider::UStringSourceProvider): Added new responsibilities described above.
  • kjs/SourceRange.h: (JSC::SourceCode::SourceCode): (JSC::SourceCode::toString): (JSC::SourceCode::provider): (JSC::SourceCode::firstLine): (JSC::SourceCode::data): (JSC::SourceCode::length): Added new responsibilities described above. Renamed SourceRange to SourceCode, based on review feedback. Added a makeSource function for convenience.
  • kjs/debugger.h: Provide a SourceCode to the client, since other APIs are no longer supported.
  • kjs/grammar.y: Provide startingLineNumber when creating a SourceCode.
  • kjs/debugger.h: Treat sourceId as intptr_t to avoid loss of precision on 64bit platforms.
  • kjs/interpreter.cpp: (JSC::Interpreter::checkSyntax): (JSC::Interpreter::evaluate):
  • kjs/interpreter.h: Require a SourceCode instead of broken out arguments.
  • kjs/lexer.cpp: (JSC::Lexer::setCode):
  • kjs/lexer.h: (JSC::Lexer::sourceRange): Fold together the SourceProvider and line number into a SourceCode. Fixed a bug where the Lexer would accidentally keep alive the last SourceProvider forever.
  • kjs/nodes.cpp: (JSC::ScopeNode::ScopeNode): (JSC::ProgramNode::ProgramNode): (JSC::ProgramNode::create): (JSC::EvalNode::EvalNode): (JSC::EvalNode::generateCode): (JSC::EvalNode::create): (JSC::FunctionBodyNode::FunctionBodyNode): (JSC::FunctionBodyNode::finishParsing): (JSC::FunctionBodyNode::create): (JSC::FunctionBodyNode::generateCode): (JSC::ProgramNode::generateCode): (JSC::FunctionBodyNode::paramString):
  • kjs/nodes.h: (JSC::ScopeNode::): (JSC::ScopeNode::sourceId): (JSC::FunctionBodyNode::): (JSC::FunctionBodyNode::parameterCount): (JSC::FuncExprNode::): (JSC::FuncDeclNode::): Store a SourceCode in all ScopeNodes, since SourceCode is now responsible for tracking URL, ID, etc. Streamlined some ad hoc FunctionBodyNode fixups into a "finishParsing" function, to help make clear what you need to do in order to finish parsing a FunctionBodyNode.
  • wtf/Vector.h: (WTF::::releaseBuffer): Don't ASSERT that releaseBuffer() is only called when buffer is not 0, since FunctionBodyNode is more than happy to get back a 0 buffer, and other functions like RefPtr::release() allow for 0, too.

JavaScriptGlue:

2008-10-01 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin Adler and Cameron Zwarich.

  • JSRun.cpp: (JSRun::Evaluate): (JSRun::CheckSyntax): Provide a SourceCode to the Interpreter, since other APIs are no longer supported.

WebCore:

2008-10-01 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin Adler and Cameron Zwarich.

Updated for JavaScriptCore API changes: use a SourceCode instead of
broken out parameters; treat sourceId as intptr_t.

  • ForwardingHeaders/kjs/SourceRange.h: Copied from ForwardingHeaders/kjs/SourceProvider.h.
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::send):
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluate):
  • bindings/js/StringSourceProvider.h: (WebCore::StringSourceProvider::create): (WebCore::StringSourceProvider::StringSourceProvider):

(WebCore::makeSource): Added a makeSource function for convenience.

  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject evaluateWebScript:]):
  • bridge/NP_jsobject.cpp: (_NPN_Evaluate):
  • bridge/jni/jni_jsobject.mm: (JavaJSObject::call): (JavaJSObject::eval): (JavaJSObject::getMember): (JavaJSObject::setMember): (JavaJSObject::removeMember):
  • bridge/jni/jni_runtime.h: (JSC::Bindings::JavaString::operator UString): Replaced the explicit ustring() function with an implicit operator because this class already holds a UString::rep.
  • page/Console.cpp: (WebCore::retrieveLastCaller): (WebCore::Console::trace):
  • page/InspectorController.cpp: (WebCore::jsStringRef): (WebCore::InspectorController::addBreakpoint): (WebCore::InspectorController::removeBreakpoint): (WebCore::InspectorController::didParseSource): (WebCore::InspectorController::failedToParseSource):
  • page/InspectorController.h:
  • page/JavaScriptCallFrame.cpp: (WebCore::JavaScriptCallFrame::JavaScriptCallFrame):
  • page/JavaScriptCallFrame.h: (WebCore::JavaScriptCallFrame::create): (WebCore::JavaScriptCallFrame::sourceIdentifier): (WebCore::JavaScriptCallFrame::update):
  • page/JavaScriptDebugListener.h:
  • page/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::addBreakpoint): (WebCore::JavaScriptDebugServer::removeBreakpoint): (WebCore::JavaScriptDebugServer::hasBreakpoint): (WebCore::dispatchDidParseSource): (WebCore::dispatchFailedToParseSource): (WebCore::JavaScriptDebugServer::sourceParsed): (WebCore::JavaScriptDebugServer::callEvent): (WebCore::JavaScriptDebugServer::atStatement): (WebCore::JavaScriptDebugServer::returnEvent): (WebCore::JavaScriptDebugServer::exception): (WebCore::JavaScriptDebugServer::willExecuteProgram): (WebCore::JavaScriptDebugServer::didExecuteProgram): (WebCore::JavaScriptDebugServer::didReachBreakpoint):
  • page/JavaScriptDebugServer.h:
  • page/inspector/ScriptsPanel.js: Renamed internal uses of sourceId and sourceIdentifier to sourceID.

WebKit/mac:

2008-10-01 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin Adler and Cameron Zwarich.

Updated for JavaScriptCore API changes: use a SourceCode instead of
broken out parameters; treat sourceId as intptr_t.


We still treat sourceId as int in some cases because of DashCode. See
<rdar://problem/6263293> WebScriptDebugDelegate should use intptr_t for
sourceId, not int.

  • WebView/WebScriptDebugger.h:
  • WebView/WebScriptDebugger.mm: (toNSString): (WebScriptDebugger::sourceParsed): (WebScriptDebugger::callEvent): (WebScriptDebugger::atStatement): (WebScriptDebugger::returnEvent): (WebScriptDebugger::exception): (WebScriptDebugger::willExecuteProgram): (WebScriptDebugger::didExecuteProgram): (WebScriptDebugger::didReachBreakpoint):
11:08 PM Changeset in webkit [37183] by mitz@apple.com
  • 6 edits in trunk/WebCore

Reviewed by Geoffrey Garen.

  • fix SVGFontFaceElement leak seen on svg/custom/acid3-test-77.html

Broke a ref cycle by changing the m_svgFontFaceElement members of
CSSFontFaceSource and CSSFontFaceSrcValue from RefPtrs to plain
pointers. Also made sure that the @font-face rule added by
SVGFontFaceElement to the document's mapped element sheet is removed
when the font-face element is deleted or moved to another document.

  • css/CSSFontFaceSource.cpp: (WebCore::CSSFontFaceSource::CSSFontFaceSource): (WebCore::CSSFontFaceSource::getFontData):
  • css/CSSFontFaceSource.h: (WebCore::CSSFontFaceSource::svgFontFaceElement):
  • css/CSSFontFaceSrcValue.h: (WebCore::CSSFontFaceSrcValue::svgFontFaceElement): (WebCore::CSSFontFaceSrcValue::CSSFontFaceSrcValue):
  • svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::~SVGFontFaceElement): (WebCore::SVGFontFaceElement::willMoveToNewOwnerDocument): (WebCore::SVGFontFaceElement::didMoveToNewOwnerDocument): (WebCore::SVGFontFaceElement::removeFromMappedElementSheet):
  • svg/SVGFontFaceElement.h:
10:06 PM Changeset in webkit [37182] by cwzwarich@webkit.org
  • 3 edits in trunk/JavaScriptCore

2008-10-01 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Maciej Stachowiak.

Bug 21289: REGRESSION (r37160): Inspector crashes on load
<​https://bugs.webkit.org/show_bug.cgi?id=21289>

The code in Arguments::mark() in r37160 was wrong. It marks indices in
d->registers, but that makes no sense (they are local variables, not
arguments). It should mark those indices in d->registerArray instead.

This patch also changes Arguments::copyRegisters() to use d->numParameters
instead of recomputing it.

  • kjs/Arguments.cpp: (JSC::Arguments::mark):
  • kjs/Arguments.h: (JSC::Arguments::copyRegisters):
10:02 PM Changeset in webkit [37181] by oliver@apple.com
  • 5 edits
    1 add
    1 delete in trunk/WebCore

Bug 20315: Memory leak with Canvas getImageData
<​https://bugs.webkit.org/show_bug.cgi?id=20315>

Reviewed by Maciej Stachowiak

This wasn't a leak, the issue was that we were reporting the cost
of the CanvasPixelArray when creating the JSCanvasPixelArray wrapper
and we should have been reporting the cost when we create the
JSImageData wrapper.

9:54 PM Changeset in webkit [37180] by mitz@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Mark Rowe.

  • svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::~SVGMarkerElement): Call detach() here so that renderer destruction happens before the SVGMarkerElement is destroyed.
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::~SVGSVGElement): Ditto for SVGSVGElement.
7:48 PM Changeset in webkit [37179] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/win/ScrollViewWin.cpp

Fix Win32 bustage.

6:47 PM Changeset in webkit [37178] by eric@webkit.org
  • 2 edits in trunk/WebCore

2008-10-01 Evan Martin <​evan@chromium.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=20669

  • css/makeprop.pl: Die if gperf fails.
6:43 PM Changeset in webkit [37177] by eric@webkit.org
  • 2 edits in trunk/WebCore

2008-10-01 Evan Martin <​evan@chromium.org>

Reviewed by Eric Seidel.

  • loader/icon/IconDatabase.h: IconDatabase uses HashMap, so it needs to #include the header.
6:35 PM Changeset in webkit [37176] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Mark Rowe.

  • fix an assertion failure in http/tests/security/canvas-remote-read-svg-image.html due to re-entry into Cache::pruneDeadResources()
  • loader/Cache.cpp: (WebCore::Cache::remove): Disable pruning temporarily during CachedResource deletion.
6:30 PM Changeset in webkit [37175] by Darin Adler
  • 8 edits in trunk/JavaScriptCore

2008-09-30 Darin Adler <Darin Adler>

Reviewed by Eric Seidel.

Eliminate some unneeded uses of dynamicGlobalObject.

  • API/JSClassRef.cpp: (OpaqueJSClass::contextData): Changed to use a map in the global data instead of on the global object. Also fixed to use only a single hash table lookup.
  • API/JSObjectRef.cpp: (JSObjectMakeConstructor): Use lexicalGlobalObject rather than dynamicGlobalObject to get the object prototype.
  • kjs/ArrayPrototype.cpp: (JSC::arrayProtoFuncToString): Use arrayVisitedElements set in global data rather than in the global object. (JSC::arrayProtoFuncToLocaleString): Ditto. (JSC::arrayProtoFuncJoin): Ditto.
  • kjs/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): Don't initialize opaqueJSClassData, since it's no longer a pointer. (JSC::JSGlobalData::~JSGlobalData): We still need to delete all the values, but we don't need to delete the map since it's no longer a pointer.
  • kjs/JSGlobalData.h: Made opaqueJSClassData a map instead of a pointer to a map. Also added arrayVisitedElements.
  • kjs/JSGlobalObject.h: Removed arrayVisitedElements.
  • kjs/Shell.cpp: (functionRun): Use lexicalGlobalObject instead of dynamicGlobalObject. (functionLoad): Ditto.
6:05 PM Changeset in webkit [37174] by hyatt@apple.com
  • 1 edit in trunk/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp

Fix Gtk repaint method finally. Should fix build bustage.

5:56 PM Changeset in webkit [37173] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/gtk/ScrollViewGtk.cpp

Fix Gtk bustage from removal of update(). Make sure to include HostWindow.h

5:56 PM Changeset in webkit [37172] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/gtk/ScrollViewGtk.cpp

Fix Gtk bustage from removal of update().

5:48 PM Changeset in webkit [37171] by mitz@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Mark Rowe.

  • fix SVGFontElement leaks seen on buildbot by breaking a ref cycle
  • svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::rebuildFontFace):
  • svg/SVGFontFaceElement.h: (WebCore::SVGFontFaceElement::associatedFontElement):
5:40 PM Changeset in webkit [37170] by hyatt@apple.com
  • 1 edit in trunk/WebKit/win/WebView.cpp

Fix Win bustage.

5:22 PM Changeset in webkit [37169] by hyatt@apple.com
  • 1 edit in trunk/WebKit/gtk/WebCoreSupport/ChromeClientGtk.h

Fix Gtk bustage.

5:21 PM Changeset in webkit [37168] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/qt/ScrollbarThemeQt.cpp

Fix Qt bustage.

5:20 PM Changeset in webkit [37167] by hyatt@apple.com
  • 1 edit in trunk/WebKit/win/WebCoreSupport/WebChromeClient.cpp

Fix Win bustage.

4:38 PM Changeset in webkit [37166] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-10-01 Cameron Zwarich <​zwarich@apple.com>

Not reviewed.

Speculative Windows build fix.

  • kjs/grammar.y:
3:43 PM Changeset in webkit [37165] by hyatt@apple.com
  • 1 edit in trunk/WebCore/page/PrintContext.cpp

Fix Qt bustage.

3:43 PM Changeset in webkit [37164] by hyatt@apple.com
  • 1 edit in trunk/WebCore/page/PrintContext.cpp

Fix Qt bustage.

3:34 PM Changeset in webkit [37163] by brettw@chromium.org
  • 2 edits in trunk/WebCore

Reviewed by Maciej Stachowiak.

Document the rounding behavior of the mapRect(IntRect) function in
AffineTransform.h.

  • platform/graphics/AffineTransform.h:
3:30 PM Changeset in webkit [37162] by hyatt@apple.com
  • 13 edits in trunk

WebCore:

2008-10-01 David Hyatt <​hyatt@apple.com>

Move prohibitsScrolling from the Frame to the ScrollView.

Reviewed by Sam Weinig

  • WebCore.base.exp:
  • page/Frame.cpp: (WebCore::FramePrivate::FramePrivate):
  • page/Frame.h:
  • page/FramePrivate.h:
  • page/FrameView.cpp: (WebCore::FrameView::scrollRectIntoViewRecursively): (WebCore::FrameView::setScrollPosition):
  • platform/ScrollView.cpp: (WebCore::ScrollView::init): (WebCore::ScrollView::scrollRectIntoViewRecursively): (WebCore::ScrollView::setScrollPosition):
  • platform/ScrollView.h: (WebCore::ScrollView::setProhibitsScrolling): (WebCore::ScrollView::prohibitsScrolling):
  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::updateScrollbars):
  • platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::updateScrollbars):
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::updateScrollbars):

WebKit/mac:

2008-10-01 David Hyatt <​hyatt@apple.com>

Move prohibitsScrolling from the Frame to the ScrollView.

Reviewed by Sam Weinig

  • WebView/WebView.mm: (-[WebView setProhibitsMainFrameScrolling:]):
3:24 PM Changeset in webkit [37161] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Fix leaks seen during http/tests/xmlhttprequest/access-control-basic-non-simple-allow.html.

Reviewed by Geoff Garen.

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::didFinishLoadingPreflight): Balance the ref and GC protect
that we do during the loadRequestAsynchronously of the preflight request with a deref and
GC unprotect.

3:18 PM Changeset in webkit [37160] by cwzwarich@webkit.org
  • 19 edits in trunk

2008-10-01 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Darin Adler.

Bug 21123: using "arguments" in a function should not force creation of an activation object
<​https://bugs.webkit.org/show_bug.cgi?id=21123>

Make the 'arguments' object not require a JSActivation. We store the
'arguments' object in the OptionalCalleeArguments call frame slot. We
need to be able to get the original 'arguments' object to tear it off
when returning from a function, but 'arguments' may be assigned to in a
number of ways.

Therefore, we use the OptionalCalleeArguments slot when we want to get
the original activation or we know that 'arguments' was not assigned a
different value. When 'arguments' may have been assigned a new value,
we use a new local variable that is initialized with 'arguments'. Since
a function parameter named 'arguments' may overwrite the value of
'arguments', we also need to be careful to look up 'arguments' in the
symbol table, so we get the parameter named 'arguments' instead of the
local variable that we have added for holding the 'arguments' object.

This is a 19.1% win on the V8 Raytrace benchmark using the SunSpider
harness, and a 20.7% win using the V8 harness. This amounts to a 6.5%
total speedup on the V8 benchmark suite using the V8 harness.

JavaScriptCore:

  • VM/CTI.cpp: (JSC::CTI::privateCompileMainPass):
  • VM/CodeBlock.h:
  • VM/CodeGenerator.cpp: (JSC::CodeGenerator::CodeGenerator):
  • VM/Machine.cpp: (JSC::Machine::unwindCallFrame): (JSC::Machine::privateExecute): (JSC::Machine::retrieveArguments): (JSC::Machine::cti_op_init_arguments): (JSC::Machine::cti_op_ret_activation_arguments):
  • VM/Machine.h:
  • VM/RegisterFile.h: (JSC::RegisterFile::):
  • kjs/Arguments.cpp: (JSC::Arguments::mark): (JSC::Arguments::fillArgList): (JSC::Arguments::getOwnPropertySlot): (JSC::Arguments::put):
  • kjs/Arguments.h: (JSC::Arguments::setRegisters): (JSC::Arguments::init): (JSC::Arguments::Arguments): (JSC::Arguments::copyRegisters): (JSC::JSActivation::copyRegisters):
  • kjs/JSActivation.cpp: (JSC::JSActivation::argumentsGetter):
  • kjs/JSActivation.h: (JSC::JSActivation::JSActivationData::JSActivationData):
  • kjs/grammar.y:
  • kjs/nodes.h: (JSC::ScopeNode::setUsesArguments):
  • masm/X86Assembler.h: (JSC::X86Assembler::): (JSC::X86Assembler::orl_mr):

LayoutTests:

  • fast/js/arguments-expected.txt:
  • fast/js/function-dot-arguments-expected.txt:
  • fast/js/resources/arguments.js:
  • fast/js/resources/function-dot-arguments.js:
3:12 PM Changeset in webkit [37159] by hyatt@apple.com
  • 12 edits in trunk

2008-10-01 David Hyatt <​hyatt@apple.com>

Rename allowsScrolling/setAllowsScrolling to canHaveScrollbars/setCanHaveScrollbars to make it more
clear that the boolean doesn't actually stop all scrolling. It just gets rid of scrollbars.

Reviewed by Tim Hatcher

  • WebCore.base.exp:
  • page/FrameView.cpp: (WebCore::FrameView::setCanHaveScrollbars):
  • page/FrameView.h:
  • platform/ScrollView.cpp: (WebCore::ScrollView::setCanHaveScrollbars): (WebCore::ScrollView::wheelEvent):
  • platform/ScrollView.h: (WebCore::ScrollView::canHaveScrollbars):
2:48 PM Changeset in webkit [37158] by hyatt@apple.com
  • 1 edit in trunk/WebKit/win/WebCoreSupport/WebChromeClient.h

Fix Win bustage.

2:19 PM Changeset in webkit [37157] by mitz@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Mark Rowe.

  • fix some CachedResource leaks seen on buildbot

The issue here was that emptying the cache was a no-op when it only
contained resources with no data. Changed to go after those
resources when the desired cache capacity is zero.

  • loader/Cache.cpp: (WebCore::Cache::pruneLiveResources): (WebCore::Cache::pruneDeadResources):
  • loader/Cache.h: (WebCore::Cache::prune):
2:11 PM Changeset in webkit [37156] by hyatt@apple.com
  • 7 edits in trunk/WebCore

2008-10-01 David Hyatt <​hyatt@apple.com>

Make isOffscreen cross-platform. Only Mac implements this method, so hold off on adding API to the
HostWindow object until other platforms decide they want this method. (We need it for Win though at some point.)

Reviewed by Adam Roben

  • platform/ScrollView.cpp: (WebCore::ScrollView::isOffscreen): (WebCore::ScrollView::platformIsOffscreen):
  • platform/ScrollView.h:
  • platform/gtk/ScrollViewGtk.cpp:
  • platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::platformIsOffscreen):
  • platform/qt/ScrollViewQt.cpp:
  • platform/wx/ScrollViewWx.cpp:
1:58 PM Changeset in webkit [37155] by hyatt@apple.com
  • 5 edits in trunk/WebCore

2008-10-01 David Hyatt <​hyatt@apple.com>

Make show/hide/setParentVisible cross-platform on ScrollView.

Reviewed by Adam Roben

  • platform/ScrollView.cpp: (WebCore::ScrollView::setParentVisible): (WebCore::ScrollView::show): (WebCore::ScrollView::hide):
  • platform/ScrollView.h:
  • platform/win/ScrollViewWin.cpp:
1:41 PM Changeset in webkit [37154] by kmccullough@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

2008-10-01 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=21284
Bug 21284: Max height affects max width

  • Looks like a cut and paste bug
  • Added layout test fast/css/max-height-and-max-width.html
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

2008-10-01 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=21284
Bug 21284: Max height affects max width

  • Looks like a cut and paste bug
  • fast/css/max-height-and-max-width-expected.txt: Added.
  • fast/css/max-height-and-max-width.html: Added.
1:34 PM Changeset in webkit [37153] by hyatt@apple.com
  • 25 edits in trunk

WebCore:

2008-10-01 David Hyatt <​hyatt@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=21282


Make contentsToScreen/screenToContents cross-platform. Only implemented by Mac/Win right now.


Reviewed by Adam Roben

  • loader/EmptyClients.h: (WebCore::EmptyChromeClient::screenToWindow): (WebCore::EmptyChromeClient::windowToScreen):
  • page/Chrome.cpp: (WebCore::Chrome::screenToWindow): (WebCore::Chrome::windowToScreen):
  • page/Chrome.h:
  • page/ChromeClient.h:
  • platform/HostWindow.h:
  • platform/ScrollView.cpp: (WebCore::ScrollView::contentsToScreen): (WebCore::ScrollView::screenToContents): (WebCore::ScrollView::platformContentsToScreen): (WebCore::ScrollView::platformScreenToContents):
  • platform/ScrollView.h:
  • platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::platformContentsToScreen): (WebCore::ScrollView::platformScreenToContents):
  • platform/win/ScrollViewWin.cpp:

WebKit/gtk:

2008-10-01 David Hyatt <​hyatt@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=21282


Make contentsToScreen/screenToContents cross-platform. Only implemented by Mac/Win right now.


Reviewed by Adam Roben

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::windowToScreen): (WebKit::ChromeClient::screenToWindow):
  • WebCoreSupport/ChromeClientGtk.h:

WebKit/mac:

2008-10-01 David Hyatt <​hyatt@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=21282


Make contentsToScreen/screenToContents cross-platform. Only implemented by Mac/Win right now.


Reviewed by Adam Roben

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::repaint): (WebChromeClient::screenToWindow): (WebChromeClient::windowToScreen):

WebKit/qt:

2008-10-01 David Hyatt <​hyatt@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=21282


Make contentsToScreen/screenToContents cross-platform. Only implemented by Mac/Win right now.


Reviewed by Adam Roben

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::windowToScreen): (WebCore::ChromeClientQt::screenToWindow):
  • WebCoreSupport/ChromeClientQt.h:

WebKit/win:

2008-10-01 David Hyatt <​hyatt@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=21282


Make contentsToScreen/screenToContents cross-platform. Only implemented by Mac/Win right now.


Reviewed by Adam Roben

  • WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::windowToScreen): (WebChromeClient::screenToWindow):
  • WebCoreSupport/WebChromeClient.h:

WebKit/wx:

2008-10-01 David Hyatt <​hyatt@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=21282


Make contentsToScreen/screenToContents cross-platform. Only implemented by Mac/Win right now.


Reviewed by Adam Roben

  • WebKitSupport/ChromeClientWx.cpp: (WebCore::ChromeClientWx::windowToScreen): (WebCore::ChromeClientWx::screenToWindow):
  • WebKitSupport/ChromeClientWx.h:
1:31 PM Changeset in webkit [37152] by mitz@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Darin Adler.

  • fix <rdar://problem/6255862> domfuzz: null deref in WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks(WebCore::HTMLStackElem*)

Test: fast/parser/residual-style-close-across-removed-block.html

  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Removed an assertion that turned out to be wrong in this case, and changed to terminate the algorithm at the first empty block.

LayoutTests:

Reviewed by Darin Adler.

  • test for <rdar://problem/6255862> domfuzz: null deref in WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks(WebCore::HTMLStackElem*)
  • fast/parser/residual-style-close-across-removed-block-expected.txt: Added.
  • fast/parser/residual-style-close-across-removed-block.html: Added.
12:24 PM Changeset in webkit [37151] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/ScrollView.h

Fix Mac bustage. Make sure the setFrameRect method is moved outside the ifdef in the header.

12:23 PM Changeset in webkit [37150] by hyatt@apple.com
  • 7 edits in trunk/WebCore

2008-10-01 David Hyatt <​hyatt@apple.com>

Make setFrameRect on ScrollView cross-platform.

Reviewed by Sam Weinig

  • page/FrameView.h: (WebCore::FrameView::contentsResized):
  • platform/ScrollView.cpp: (WebCore::ScrollView::setFrameRect):
  • platform/ScrollView.h:
  • platform/gtk/ScrollViewGtk.cpp:
  • platform/qt/ScrollViewQt.cpp:
  • platform/win/ScrollViewWin.cpp:
12:17 PM Changeset in webkit [37149] by weinig@apple.com
  • 6 edits in trunk/WebCore

2008-10-01 Sam Weinig <​sam@webkit.org>

Reviewed by Adele Peterson.

Move setTimeout, clearTimeout, setInterval, clearInterval, atob and btoa
to JSDOMWindow from JSDOMWindowBase.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::removeTimeout):
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::setTimeoutOrInterval): (WebCore::JSDOMWindow::setTimeout): (WebCore::JSDOMWindow::clearTimeout): (WebCore::JSDOMWindow::setInterval): (WebCore::JSDOMWindow::clearInterval): (WebCore::JSDOMWindow::atob): (WebCore::JSDOMWindow::btoa):
  • page/DOMWindow.idl:
11:40 AM Changeset in webkit [37148] by kmccullough@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-10-01 Kevin McCullough <​kmccullough@apple.com>

Rubberstamped by Geoff .

Remove BreakpointCheckStatement because it's not used anymore.
No effect on sunspider or the jsc tests.

  • kjs/nodes.cpp:
  • kjs/nodes.h:
11:12 AM Changeset in webkit [37147] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • Mac build fix
  • WebCore.base.exp:
10:51 AM Changeset in webkit [37146] by hyatt@apple.com
  • 25 edits in trunk

Make ScrollView::paint cross-platform.

10:33 AM Changeset in webkit [37145] by timothy@apple.com
  • 2 edits in trunk/WebCore

Prevent stealing focus from the search field when focusing a DOM node.

​https://bugs.webkit.org/show_bug.cgi?id=21275

Reviewed by Kevin McCullough.

  • page/inspector/ElementsPanel.js: (WebInspector.ElementsPanel.treeOutline.focusedNodeChanged): Don't steal focus if the current focus element is the search field.
6:32 AM QtWebKitJournal edited by Simon Hausmann
(diff)
12:59 AM Changeset in webkit [37144] by hyatt@apple.com
  • 1 edit in trunk/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp

Speculative fix for Gtk bustage.

12:55 AM Changeset in webkit [37143] by hyatt@apple.com
  • 1 edit in trunk/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp

Fix Qt bustage.

12:27 AM Changeset in webkit [37142] by weinig@apple.com
  • 16 edits in trunk/WebCore

2008-09-30 Sam Weinig <​sam@webkit.org>

Reviewed by Nikolas Zimmermann and Alexey Proskuryakov.

Final patch for ​https://bugs.webkit.org/show_bug.cgi?id=21122
Autogenerate JS event listeners

  • Generate getting/setting of EventListeners.
  • Adding a new named EventListener now has the same process as adding any other DOM attribute. (Add a method with the same name in the c++ file).

(The EventListeners for MessagePort have been intentionally left custom so that we
can continue to experiment with making those EventListeners work in a frame-less world.)

  • bindings/js/JSDOMApplicationCacheCustom.cpp: Remove custom methods.
  • bindings/js/JSDOMWindowCustom.cpp: ditto.
  • bindings/js/JSEventTargetNodeCustom.cpp: ditto.
  • bindings/js/JSXMLHttpRequestCustom.cpp: ditto.
  • bindings/js/JSXMLHttpRequestUploadCustom.cpp: ditto.
  • bindings/scripts/CodeGeneratorJS.pm: Add code to generate EventListener getter/setters
  • dom/EventTargetNode.cpp: Add getter/setters for named EventListener.
  • dom/EventTargetNode.h: ditto.
  • dom/EventTargetNode.idl: Mark EventListeners as Protected so that the codegenerator will use JSEventListerner instead of JSUnprotectedEventListener.
  • loader/appcache/DOMApplicationCache.idl: Remove custom attributes..
  • page/DOMWindow.cpp: Add getter/setters for named EventListener
  • page/DOMWindow.h: ditto.
  • page/DOMWindow.idl: Mark EventListeners as Protected so that the codegenerator will use JSEventListerner instead of JSUnprotectedEventListener.
  • xml/XMLHttpRequest.idl: Remove custom attributes.
  • xml/XMLHttpRequestUpload.idl: ditto.
Note: See TracTimeline for information about the timeline view.