⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 3, 2008:

11:40 PM Changeset in webkit [37284] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/qt/WidgetQt.cpp

Fix Qt bustage.

10:47 PM Changeset in webkit [37283] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-10-03 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Maciej Stachowiak.

Bug 21356: The size of the RegisterFile differs depending on 32-bit / 64-bit and Debug / Release
<​https://bugs.webkit.org/show_bug.cgi?id=21356>

The RegisterFile decreases in size (measured in terms of numbers of
Registers) as the size of a Register increases. This causes

js1_5/Regress/regress-159334.js

to fail in 64-bit debug builds. This fix makes the RegisterFile on all
platforms the same size that it is in 32-bit Release builds.

  • VM/RegisterFile.h: (JSC::RegisterFile::RegisterFile):
10:16 PM Changeset in webkit [37282] by weinig@apple.com
  • 6 edits
    3 moves in trunk/WebCore

2008-10-03 Sam Weinig <​sam@webkit.org>

Reviewed by David "The Motivator" Hyatt.

Patch for ​https://bugs.webkit.org/show_bug.cgi?id=21355
Move SecurityOrigin out of platform/ to page/.

It was a layering violation for SecurityOrigin to be in platform
as it depended on FrameLoader.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • page/SecurityOrigin.cpp: Copied from platform/SecurityOrigin.cpp.
  • page/SecurityOrigin.h: Copied from platform/SecurityOrigin.h.
  • page/SecurityOriginHash.h: Copied from platform/SecurityOriginHash.h.
  • platform/SecurityOrigin.cpp: Removed.
  • platform/SecurityOrigin.h: Removed.
  • platform/SecurityOriginHash.h: Removed.
9:24 PM Changeset in webkit [37281] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2008-10-03 Marco Barisione <​marco.barisione@collabora.co.uk>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=18832
[curl] file upload does not work

The curl_off_t integer type has a different size depending if large
file support is enabled or not. There is no different public API for
the two cases, so the same function accepts a different type based on
a compilation option the could be different in WebKit and libcurl.
To fix the bug we query libcurl at runtime for large file support and
pass the right type based on that.

  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::setupPOST):
9:02 PM Changeset in webkit [37280] by jmalonzo@webkit.org
  • 7 edits in trunk/WebCore

2008-10-03 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by David Hyatt.

Gtk build fixes.

  • platform/gtk/FileChooserGtk.cpp: (WebCore::FileChooser::openFileChooser):
  • platform/gtk/PlatformScreenGtk.cpp: (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenAvailableRect):
  • platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenu::show):
  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::platformAddChild): (WebCore::ScrollView::platformRemoveChild):
  • platform/gtk/WidgetGtk.cpp: (WebCore::Widget::setCursor):
  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::getValue): (WebCore::PluginView::forceRedraw): (WebCore::PluginView::init):
8:31 PM Changeset in webkit [37279] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/qt/PopupMenuQt.cpp

Fix Qt bustage.

7:02 PM Changeset in webkit [37278] by hyatt@apple.com
  • 1 edit in trunk/WebKit/win/WebCoreSupport/WebChromeClient.h

Fix Windows bustage in WebKit side.

7:01 PM Changeset in webkit [37277] by hyatt@apple.com
  • 3 edits in trunk/WebKit/win

Fix Windows bustage in WebKit side.

6:50 PM Changeset in webkit [37276] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/win/FileChooserWin.cpp

Fix Win bustage.

6:39 PM Changeset in webkit [37275] by mjs@apple.com
  • 9 edits in trunk/JavaScriptCore

2008-10-03 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Cameron Zwarich.


  • Some code cleanup to how we handle code features.


1) Rename FeatureInfo typedef to CodeFeatures.
2) Rename NodeFeatureInfo template to NodeInfo.
3) Keep CodeFeature bitmask in ScopeNode instead of trying to break it out into individual bools.
4) Rename misleadingly named "needsClosure" method to "containsClosures", which better describes the meaning
of ClosureFeature.
5) Make setUsersArguments() not take an argument since it only goes one way.

  • JavaScriptCore.exp:
  • VM/CodeBlock.h: (JSC::CodeBlock::CodeBlock):
  • kjs/NodeInfo.h:
  • kjs/Parser.cpp: (JSC::Parser::didFinishParsing):
  • kjs/Parser.h: (JSC::Parser::parse):
  • kjs/grammar.y:
  • kjs/nodes.cpp: (JSC::ScopeNode::ScopeNode): (JSC::ProgramNode::ProgramNode): (JSC::ProgramNode::create): (JSC::EvalNode::EvalNode): (JSC::EvalNode::create): (JSC::FunctionBodyNode::FunctionBodyNode): (JSC::FunctionBodyNode::create):
  • kjs/nodes.h: (JSC::ScopeNode::usesEval): (JSC::ScopeNode::containsClosures): (JSC::ScopeNode::usesArguments): (JSC::ScopeNode::setUsesArguments):
6:11 PM Changeset in webkit [37274] by hyatt@apple.com
  • 2 edits in trunk/WebKit/gtk

2008-10-03 David Hyatt <​hyatt@apple.com>

Fix Gtk bustage from use of containingWindow() over on the WebKit side. Replace with HostWindow use.

  • webkit/webkitwebview.cpp:
6:09 PM Changeset in webkit [37273] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2008-10-03 David Hyatt <​hyatt@apple.com>

Fix Qt bustage from missing include.

  • platform/qt/PlatformScreenQt.cpp:
6:08 PM Changeset in webkit [37272] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2008-10-03 David Hyatt <​hyatt@apple.com>

Fix Windows scrollbar bustage in popup menus.

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupWndProc):
6:07 PM Changeset in webkit [37271] by hyatt@apple.com
  • 5 edits in trunk/WebCore

2008-10-03 David Hyatt <​hyatt@apple.com>

Fix Windows bustage.

  • platform/win/FileChooserWin.cpp: (WebCore::FileChooser::openFileChooser):
  • platform/win/PlatformScreenWin.cpp: (WebCore::monitorInfoForWidget):
  • platform/win/WidgetWin.cpp:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginView::getValue): (WebCore::PluginView::forceRedraw): (WebCore::PluginView::init):
5:21 PM Changeset in webkit [37270] by Simon Fraser
  • 2 edits in trunk/WebKitTools

2008-10-03 Pierre-Olivier Latour <​pol@apple.com>

Reviewed by Darin Adler

Render images to RGBA8 bitmaps independently of platform endianness.

Create image difference bitmap in reference image colorspace instead of device colorspace
(which depends on the main display profile), so that no color matching happens.

​https://bugs.webkit.org/show_bug.cgi?id=21336

  • DumpRenderTree/cg/ImageDiffCG.cpp: (createDifferenceBitmap): (computePercentageDifferent): (compareImages):
5:16 PM Changeset in webkit [37269] by Simon Fraser
  • 2 edits in trunk/WebKitTools

2008-10-02 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler

Fix hang when running with --pixel --reset, which occurs
because DRT spews PNG data when the script does not expect it.

​https://bugs.webkit.org/show_bug.cgi?id=21323

  • Scripts/run-webkit-tests:
5:10 PM Changeset in webkit [37268] by cwzwarich@webkit.org
  • 5 edits in trunk/JavaScriptCore

2008-10-03 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Maciej Stachowiak.

Bug 21343: REGRESSSION (r37160): ecma_3/ExecutionContexts/10.1.3-1.js and js1_4/Functions/function-001.js fail on 64-bit
<​https://bugs.webkit.org/show_bug.cgi?id=21343>

A fix was landed for this issue in r37253, and the ChangeLog assumes
that it is a compiler bug, but it turns out that it is a subtle issue
with mixing signed and unsigned 32-bit values in a 64-bit environment.
In order to properly fix this bug, we should convert our signed offsets
into the register file to use ptrdiff_t.

This may not be the only instance of this issue, but I will land this
fix first and look for more later.

  • VM/Machine.cpp: (JSC::Machine::getArgumentsData):
  • VM/Machine.h:
  • kjs/Arguments.cpp: (JSC::Arguments::getOwnPropertySlot):
  • kjs/Arguments.h: (JSC::Arguments::init):
4:15 PM Changeset in webkit [37267] by sullivan@apple.com
  • 2 edits in trunk/WebKit/mac

2008-10-03 John Sullivan <​sullivan@apple.com>

Fixed Release build

  • Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::destroyStream): added !LOG_DISABLED guard around declaration of npErr used only in LOG
3:55 PM Changeset in webkit [37266] by Darin Adler
  • 2 edits in trunk/WebCore

2008-10-03 Darin Adler <Darin Adler>

  • bindings/js/JSInspectedObjectWrapper.cpp: Try to fix a build failure seen on some machines but not others by adding an include.
3:41 PM Changeset in webkit [37265] by Darin Adler
  • 3 edits in trunk/WebCore

2008-10-03 Darin Adler <Darin Adler>

  • Qt build fix
  • bridge/qt/qt_runtime.cpp: Remove long-obsolete codeType and execute functions. Declarations for these relied on the CodeType enumeration, which used to be in ExecState.h; but the functions aren't needed at all.
  • bridge/qt/qt_runtime.h: Ditto.
3:29 PM Changeset in webkit [37264] by Darin Adler
  • 3 edits in trunk/JavaScriptCore

2008-10-03 Darin Adler <Darin Adler>

  • VM/CTI.cpp: Another Windows build fix. Change the args of ctiTrampoline.
  • kjs/JSNumberCell.h: A build fix for newer versions of gcc. Added declarations of JSGlobalData overloads of jsNumberCell.
3:24 PM Changeset in webkit [37263] by hyatt@apple.com
  • 1 edit in trunk/WebKit/wx/WebKitSupport/ChromeClientWx.cpp

Fix wx bustage.

3:24 PM Changeset in webkit [37262] by hyatt@apple.com
  • 1 edit in trunk/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp

Fix Qt bustage.

3:23 PM Changeset in webkit [37261] by hyatt@apple.com
  • 1 edit in trunk/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp

Fix Gtk bustage.

2:58 PM Changeset in webkit [37260] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2008-10-03 Anders Carlsson <​andersca@apple.com>

Reviewed by David Hyatt.


Convert destroyStream over to C++.


  • Plugins/WebBaseNetscapePluginStream.h:
  • Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::destroyStream): (-[WebBaseNetscapePluginStream _destroyStreamWithReason:]): (-[WebBaseNetscapePluginStream _deliverData]):
2:54 PM Changeset in webkit [37259] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

2008-10-03 Darin Adler <Darin Adler>

  • try to fix Windows build
  • kjs/ScopeChain.h: Add forward declaration of JSGlobalData.
2:45 PM Changeset in webkit [37258] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2008-10-03 Anders Carlsson <​andersca@apple.com>

Reviewed by David Hyatt.

Use a Timer instead of -[NSObject performSelector:withObject:afterDelay];


  • Plugins/WebBaseNetscapePluginStream.h: (WebNetscapePluginStream::WebNetscapePluginStream):
  • Plugins/WebBaseNetscapePluginStream.mm: (-[WebBaseNetscapePluginStream _destroyStream]): (-[WebBaseNetscapePluginStream _deliverData]): (WebNetscapePluginStream::deliverDataTimerFired):
2:39 PM Changeset in webkit [37257] by Darin Adler
  • 42 edits in trunk

JavaScriptCore:

2008-10-03 Darin Adler <Darin Adler>

Reviewed by Geoff Garen.

Remove m_globalObject and m_globalData from ExecState.

SunSpider says this is a wash (slightly faster but not statistically
significant); which is good enough since it's a preparation step and
not supposed to be a spedup.

  • API/JSCallbackFunction.cpp: (JSC::JSCallbackFunction::JSCallbackFunction):
  • kjs/ArrayConstructor.cpp: (JSC::ArrayConstructor::ArrayConstructor):
  • kjs/BooleanConstructor.cpp: (JSC::BooleanConstructor::BooleanConstructor):
  • kjs/DateConstructor.cpp: (JSC::DateConstructor::DateConstructor):
  • kjs/ErrorConstructor.cpp: (JSC::ErrorConstructor::ErrorConstructor):
  • kjs/FunctionPrototype.cpp: (JSC::FunctionPrototype::FunctionPrototype):
  • kjs/JSFunction.cpp: (JSC::JSFunction::JSFunction):
  • kjs/NativeErrorConstructor.cpp: (JSC::NativeErrorConstructor::NativeErrorConstructor):
  • kjs/NumberConstructor.cpp: (JSC::NumberConstructor::NumberConstructor):
  • kjs/ObjectConstructor.cpp: (JSC::ObjectConstructor::ObjectConstructor):
  • kjs/PrototypeFunction.cpp: (JSC::PrototypeFunction::PrototypeFunction):
  • kjs/RegExpConstructor.cpp: (JSC::RegExpConstructor::RegExpConstructor):
  • kjs/StringConstructor.cpp: (JSC::StringConstructor::StringConstructor): Pass JSGlobalData* instead of ExecState* to the InternalFunction constructor.
  • API/OpaqueJSString.cpp: Added now-needed include.
  • VM/CTI.cpp: (JSC::CTI::emitSlowScriptCheck): Changed to use ARGS_globalData instead of ARGS_exec.
  • VM/CTI.h: Added a new argument to the CTI, the global data pointer. While it's possible to get to the global data pointer using the ExecState pointer, it's slow enough that it's better to just keep it around in the CTI arguments.
  • VM/CodeBlock.h: Moved the CodeType enum here from ExecState.h.
  • VM/Machine.cpp: (JSC::Machine::execute): Pass fewer arguments when constructing ExecState, and pass the global data pointer when invoking CTI. (JSC::Machine::firstCallFrame): Added. Used to get the dynamic global object, which is in the scope chain of the first call frame. (JSC::Machine::cti_op_add): Use globalData instead of exec when possible, to keep fast cases fast, since it's now more expensive to get to it through the exec pointer. (JSC::Machine::cti_timeout_check): Ditto. (JSC::Machine::cti_op_put_by_id_second): Ditto. (JSC::Machine::cti_op_get_by_id_second): Ditto. (JSC::Machine::cti_op_mul): Ditto. (JSC::Machine::cti_vm_compile): Ditto. (JSC::Machine::cti_op_get_by_val): Ditto. (JSC::Machine::cti_op_sub): Ditto. (JSC::Machine::cti_op_put_by_val): Ditto. (JSC::Machine::cti_op_put_by_val_array): Ditto. (JSC::Machine::cti_op_negate): Ditto. (JSC::Machine::cti_op_div): Ditto. (JSC::Machine::cti_op_pre_dec): Ditto. (JSC::Machine::cti_op_post_inc): Ditto. (JSC::Machine::cti_op_lshift): Ditto. (JSC::Machine::cti_op_bitand): Ditto. (JSC::Machine::cti_op_rshift): Ditto. (JSC::Machine::cti_op_bitnot): Ditto. (JSC::Machine::cti_op_mod): Ditto. (JSC::Machine::cti_op_post_dec): Ditto. (JSC::Machine::cti_op_urshift): Ditto. (JSC::Machine::cti_op_bitxor): Ditto. (JSC::Machine::cti_op_bitor): Ditto. (JSC::Machine::cti_op_call_eval): Ditto. (JSC::Machine::cti_op_throw): Ditto. (JSC::Machine::cti_op_is_string): Ditto. (JSC::Machine::cti_op_debug): Ditto. (JSC::Machine::cti_vm_throw): Ditto.
  • VM/Machine.h: Added firstCallFrame.
  • kjs/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::evaluate): Pass fewer arguments when constructing ExecState.
  • kjs/ExecState.cpp: Deleted contents. Later we'll remove the file altogether.
  • kjs/ExecState.h: Removed m_globalObject and m_globalData. Moved CodeType into another header. (JSC::ExecState::ExecState): Take only a single argument, a call frame pointer. (JSC::ExecState::dynamicGlobalObject): Get the object from the first call frame since it's no longer stored. (JSC::ExecState::globalData): Get the global data from the scope chain, since we no longer store a pointer to it here. (JSC::ExecState::identifierTable): Ditto. (JSC::ExecState::propertyNames): Ditto. (JSC::ExecState::emptyList): Ditto. (JSC::ExecState::lexer): Ditto. (JSC::ExecState::parser): Ditto. (JSC::ExecState::machine): Ditto. (JSC::ExecState::arrayTable): Ditto. (JSC::ExecState::dateTable): Ditto. (JSC::ExecState::mathTable): Ditto. (JSC::ExecState::numberTable): Ditto. (JSC::ExecState::regExpTable): Ditto. (JSC::ExecState::regExpConstructorTable): Ditto. (JSC::ExecState::stringTable): Ditto. (JSC::ExecState::heap): Ditto.
  • kjs/FunctionConstructor.cpp: (JSC::FunctionConstructor::FunctionConstructor): Pass JSGlobalData* instead of ExecState* to the InternalFunction constructor. (JSC::constructFunction): Pass the global data pointer when constructing a new scope chain.
  • kjs/InternalFunction.cpp: (JSC::InternalFunction::InternalFunction): Take a JSGlobalData* instead of an ExecState*. Later we can change more places to work this way -- it's more efficient to take the type you need since the caller might already have it.
  • kjs/InternalFunction.h: Ditto.
  • kjs/JSCell.h: (JSC::JSCell::operator new): Added an overload that takes a JSGlobalData* so you can construct without an ExecState*.
  • kjs/JSGlobalObject.cpp: (JSC::JSGlobalObject::init): Moved creation of the global scope chain in here, since it now requires a pointer to the global data. Moved the initialization of the call frame in here since it requires the global scope chain node. Removed the extra argument to ExecState when creating the global ExecState*.
  • kjs/JSGlobalObject.h: Removed initialization of globalScopeChain and the call frame from the JSGlobalObjectData constructor. Added a thisValue argument to the init function.
  • kjs/JSNumberCell.cpp: Added versions of jsNumberCell that take JSGlobalData* rather than ExecState*.
  • kjs/JSNumberCell.h: (JSC::JSNumberCell::operator new): Added a version that takes JSGlobalData*. (JSC::JSNumberCell::JSNumberCell): Ditto. (JSC::jsNumber): Ditto.
  • kjs/JSString.cpp: (JSC::jsString): Ditto. (JSC::jsSubstring): Ditto. (JSC::jsOwnedString): Ditto.
  • kjs/JSString.h: (JSC::JSString::JSString): Changed to take JSGlobalData*. (JSC::jsEmptyString): Added a version that takes JSGlobalData*. (JSC::jsSingleCharacterString): Ditto. (JSC::jsSingleCharacterSubstring): Ditto. (JSC::jsNontrivialString): Ditto. (JSC::JSString::getIndex): Ditto. (JSC::jsString): Ditto. (JSC::jsSubstring): Ditto. (JSC::jsOwnedString): Ditto.
  • kjs/ScopeChain.h: Added a globalData pointer to each node. (JSC::ScopeChainNode::ScopeChainNode): Initialize the globalData pointer. (JSC::ScopeChainNode::push): Set the global data pointer in the new node. (JSC::ScopeChain::ScopeChain): Take a globalData argument.
  • kjs/SmallStrings.cpp: (JSC::SmallStrings::createEmptyString): Take JSGlobalData* instead of ExecState*. (JSC::SmallStrings::createSingleCharacterString): Ditto.
  • kjs/SmallStrings.h: (JSC::SmallStrings::emptyString): Ditto. (JSC::SmallStrings::singleCharacterString): Ditto.

WebCore:

2008-10-03 Darin Adler <Darin Adler>

Reviewed by Geoff Garen.

Remove m_globalObject and m_globalData from ExecState.

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::JSDOMWindowBaseData::JSDOMWindowBaseData): Removed an argument now that JSGlobalObject doesn't need it any more. (WebCore::JSDOMWindowBase::JSDOMWindowBase): Removed the argument from the JSDOMWindowBaseData constructor, and added the this argument to the JSGlobalObject constructor. This is because a couple key bits of initialization moved from the data constructor to the JSGlobalObject constructor.
  • bindings/js/JSDOMWindowBase.h: Ditto.
  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):
  • bridge/runtime_method.cpp: (JSC::RuntimeMethod::RuntimeMethod): Pass JSGlobalData* instead of ExecState* to the InternalFunction constructor.
2:34 PM Changeset in webkit [37256] by Simon Fraser
  • 1 edit
    2 adds in trunk/LayoutTests

2008-10-03 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler

Testcase for "white-space: -webkit-nowrap" only being converted to
"white-space: nowrap" on <td> and <th> now, not any element with a table-cell
dispay type.

See ​https://bugs.webkit.org/show_bug.cgi?id=21287#c3

  • fast/table/td-display-nowrap-expected.txt: Added.
  • fast/table/td-display-nowrap.html: Added.
2:34 PM Changeset in webkit [37255] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2008-10-03 Anders Carlsson <​andersca@apple.com>

Reviewed by David Hyatt.

More plug-in stream cleanup.


  • Plugins/WebBaseNetscapePluginStream.h: (WebNetscapePluginStream::create): (WebNetscapePluginStream::WebNetscapePluginStream):
  • Plugins/WebBaseNetscapePluginStream.mm: (-[WebBaseNetscapePluginStream initWithFrameLoader:]): (-[WebBaseNetscapePluginStream initWithRequestURL:plugin:notifyData:sendNotification:]): (-[WebBaseNetscapePluginStream dealloc]): (-[WebBaseNetscapePluginStream finalize]): (-[WebBaseNetscapePluginStream setPlugin:]): (WebNetscapePluginStream::setPlugin): (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:headers:]): (-[WebBaseNetscapePluginStream _destroyStream]):
2:16 PM Changeset in webkit [37254] by hyatt@apple.com
  • 19 edits in trunk

2008-10-03 David Hyatt <​hyatt@apple.com>

Fix Windows/Qt build bustage.

Reviewed by ggaren

  • loader/EmptyClients.h: (WebCore::EmptyChromeClient::platformWindow):
  • page/Chrome.cpp: (WebCore::Chrome::platformWindow):
  • page/Chrome.h:
  • page/ChromeClient.h:
  • platform/HostWindow.h:
  • platform/qt/PlatformScreenQt.cpp: (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::screenRect): (WebCore::screenAvailableRect):
  • platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenu::show):
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::show): (WebCore::PopupMenu::calculatePositionAndSize): (WebCore::PopupWndProc):
1:56 PM Changeset in webkit [37253] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-10-03 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Geoff Garen.

Bug 21343: REGRESSSION (r37160): ecma_3/ExecutionContexts/10.1.3-1.js and js1_4/Functions/function-001.js fail on 64-bit
<​https://bugs.webkit.org/show_bug.cgi?id=21343>

Add a workaround for a bug in GCC, which affects GCC 4.0, GCC 4.2, and
llvm-gcc 4.2. I put it in an #ifdef because it was a slight regression
on SunSpider in 32-bit, although that might be entirely random.

  • kjs/Arguments.cpp: (JSC::Arguments::getOwnPropertySlot):
1:20 PM Changeset in webkit [37252] by Simon Fraser
  • 46 edits in trunk/WebCore

2008-10-03 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

Make setStyle() take a const RenderStyle, to ensure that an
earlier RenderStyle::diff() remains valid.

1:10 PM Changeset in webkit [37251] by hyatt@apple.com
  • 10 edits in trunk/WebCore

2008-10-03 David Hyatt <​hyatt@apple.com>

Preparation for enabling scrollbars to hit test properly inside transforms. Clean up the scrollbar
event handlers to no longer be virtual. Don't pass a mouse event where none is needed. Add a new
method on Scrollbars called transformEvent that will apply all of the transforms to make a new event
that will work properly for hit testing. This patch just stubs out that method to return the same
event untransformed.

Reviewed by Darin Adler

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseDoubleClickEvent): (WebCore::EventHandler::handleMouseMoveEvent): (WebCore::EventHandler::handleMouseReleaseEvent): (WebCore::EventHandler::passMousePressEventToScrollbar):
  • page/gtk/EventHandlerGtk.cpp:
  • page/mac/EventHandlerMac.mm:
  • page/qt/EventHandlerQt.cpp:
  • page/win/EventHandlerWin.cpp:
  • page/wx/EventHandlerWx.cpp:
  • platform/Scrollbar.cpp: (WebCore::Scrollbar::mouseMoved): (WebCore::Scrollbar::mouseExited): (WebCore::Scrollbar::mouseUp): (WebCore::Scrollbar::mouseDown): (WebCore::Scrollbar::transformEvent):
  • platform/Scrollbar.h:
1:00 PM Changeset in webkit [37250] by Simon Fraser
  • 1 edit
    6 adds in trunk/LayoutTests

2008-10-03 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyat

Clean up code that changes the RenderStyle passed in to
table renderer setStyle() methods.

​https://bugs.webkit.org/show_bug.cgi?id=21287

  • fast/table/floating-th.html: Added.
  • fast/table/table-display-types-strict.html: Added.
  • fast/table/table-display-types.html: Added.
  • platform/mac/fast/table/floating-th-expected.txt: Added.
  • platform/mac/fast/table/table-display-types-expected.txt: Added.
  • platform/mac/fast/table/table-display-types-strict-expected.txt: Added.
12:17 PM Changeset in webkit [37249] by hyatt@apple.com
  • 12 edits in trunk

WebCore:

2008-10-03 David Hyatt <​hyatt@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=21340


Remove "containingWindow()/setContainingWindow()" from Widget. HostWindow covers this now.


Reviewed by Dan Bernstein & Darin Adler


  • platform/ScrollView.cpp: (WebCore::ScrollView::addChild):
  • platform/Widget.cpp: (WebCore::Widget::init):
  • platform/Widget.h:
  • platform/mac/WidgetMac.mm:
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::show):

WebKit/gtk:

2008-10-03 David Hyatt <​hyatt@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=21340


Remove "containingWindow()/setContainingWindow()" from Widget. HostWindow covers this now.

Reviewed by Dan Bernstein & Darin Adler


  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):

WebKit/win:

2008-10-03 David Hyatt <​hyatt@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=21340


Remove "containingWindow()/setContainingWindow()" from Widget. HostWindow covers this now.


Reviewed by Dan Bernstein & Darin Adler

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::transitionToCommittedForNewPage):
  • WebScrollBar.cpp: (WebScrollBar::WebScrollBar): (WebScrollBar::init): (WebScrollBar::invalidateScrollbarRect):
  • WebScrollBar.h:
12:06 PM Changeset in webkit [37248] by adele@apple.com
  • 2 edits in trunk/WebCore

2008-10-03 Adele Peterson <​adele@apple.com>

Reviewed by Sam Weinig.

  • css/CSSFontSelector.cpp: (WebCore::fontDataForGenericFamily): Return early if settings is nil.
12:00 PM Changeset in webkit [37247] by rwlbuis@webkit.org
  • 3 edits
    2 adds in trunk

Reviewed by Darin.

​https://bugs.webkit.org/show_bug.cgi?id=20134
REGRESSION (2.0.4-3.0.4): No default value set for <input type=range> with an even difference of (max - min)

Make sure the input element gets the right default value when no value is set.

Test: fast/forms/range-default-value.html

11:50 AM Changeset in webkit [37246] by hyatt@apple.com
  • 3 edits in trunk/WebKit/qt

2008-10-03 David Hyatt <​hyatt@apple.com>

Fix scroll method on Qt. The delta was supposed to use .width()/.height() and not .x()/.y().

Fix the QtPluginWidget to do an invalidate properly.

Reviewed by ggaren

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::scroll):
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::):
11:42 AM Changeset in webkit [37245] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/win/WidgetWin.cpp

Remove commented out method.

11:29 AM Changeset in webkit [37244] by hyatt@apple.com
  • 9 edits
    1 delete in trunk/WebCore

2008-10-03 David Hyatt <​hyatt@apple.com>

Instead of a cross-platform init/destroy that forces every ScrollView platform to have a constructor/
destructor that calls them, switch to having a cross-platform constructor/destructor that calls
platform-specific init/destroy methods.

With this change, ScrollViewWin.cpp can be removed from the build (yay!).

Reviewed by Darin Adler

  • WebCore.vcproj/WebCore.vcproj:
  • platform/ScrollView.cpp: (WebCore::ScrollView::ScrollView): (WebCore::ScrollView::~ScrollView): (WebCore::ScrollView::platformInit): (WebCore::ScrollView::platformDestroy): (WebCore::ScrollView::platformAddChild): (WebCore::ScrollView::platformRemoveChild):
  • platform/ScrollView.h:
  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::platformInit): (WebCore::ScrollView::platformDestroy):
  • platform/mac/ScrollViewMac.mm:
  • platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::platformInit): (WebCore::ScrollView::platformDestroy):
  • platform/win/ScrollViewWin.cpp: Removed.
  • platform/wx/ScrollViewWx.cpp: (WebCore::ScrollView::platformInit): (WebCore::ScrollView::platformDestroy): (WebCore::ScrollView::setPlatformWidget):
11:13 AM Changeset in webkit [37243] by adele@apple.com
  • 2 edits in trunk/WebCore

2008-10-03 Adele Peterson <​adele@apple.com>

Reviewed by Dan Bernstein.

Fix for <rdar://problem/6012018>
​https://bugs.webkit.org/show_bug.cgi?id=21335
CrashTracer: [USER] 4959 crashes in Safari at com.apple.WebCore: WebCore::Frame::settings const + 8

  • css/CSSFontSelector.cpp: (WebCore::fontDataForGenericFamily): Return early if the frame is nil.
10:27 AM Changeset in webkit [37242] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

2008-10-03 Darin Adler <Darin Adler>

Rubber stamped by Alexey Proskuryakov.

  • kjs/Shell.cpp: (main): Don't delete JSGlobalData. Later, we need to change this tool to use public JavaScriptCore API instead.
10:01 AM Changeset in webkit [37241] by vestbo@webkit.org
  • 2 edits in trunk/WebKit/qt

2008-10-03 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Build fix. Remove addToDirtyRegion from the header file.

  • WebCoreSupport/ChromeClientQt.h:
9:09 AM Changeset in webkit [37240] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

2008-10-03 Darin Adler <Darin Adler>

Suggested by Alexey Proskuryakov.

  • kjs/JSGlobalData.cpp: (JSC::JSGlobalData::~JSGlobalData): Remove call to heap.destroy() because it's too late to ref the JSGlobalData object once it's already being destroyed. In practice this is not a problem because WebCore's JSGlobalData is never destroyed and JSGlobalContextRelease takes care of calling heap.destroy() in advance.
9:02 AM Changeset in webkit [37239] by Simon Hausmann
  • 5 edits in trunk

2008-10-03 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Build fix.

  • platform/qt/WidgetQt.cpp: (WebCore::Widget::invalidateRect):

2008-10-03 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Build fix.

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::scroll):
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::): (WebCore::FrameLoaderClientQt::createPlugin):
6:36 AM Changeset in webkit [37238] by alp@webkit.org
  • 6 edits in trunk

2008-10-03 Alp Toker <​alp@nuanti.com>

Remove some left-over GTK+ includes. No change in functionality.

5:59 AM Changeset in webkit [37237] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-10-03 Alp Toker <​alp@nuanti.com>

Build fix following r37234. Remove addToDirtyRegion from the header
too.

  • WebCoreSupport/ChromeClientGtk.h:
5:38 AM Changeset in webkit [37236] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-10-03 Alp Toker <​alp@nuanti.com>

Build fix for trailing comment after #endif

  • dom/ElementRareData.h:
4:11 AM Changeset in webkit [37235] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Replace SSE3 check with an SSE2 check, and implement SSE2 check on windows.

Reviewed by Maciej Stachowiak

5.6% win on SunSpider on windows.

2:03 AM Changeset in webkit [37234] by hyatt@apple.com
  • 19 edits in trunk

WebCore:

2008-10-03 David Hyatt <​hyatt@apple.com>

Remove addToDirtyRegion.


Reviewed by Oliver Hunt

  • page/Chrome.cpp:
  • page/Chrome.h:
  • page/ChromeClient.h:
  • platform/ScrollView.h:
  • platform/gtk/ScrollViewGtk.cpp:
  • platform/qt/ScrollViewQt.cpp:
  • platform/win/ScrollViewWin.cpp:

WebKit/gtk:

2008-10-03 David Hyatt <​hyatt@apple.com>

Remove addToDirtyRegion.


Reviewed by Oliver Hunt

  • WebCoreSupport/ChromeClientGtk.cpp:

WebKit/mac:

2008-10-03 David Hyatt <​hyatt@apple.com>

Remove addToDirtyRegion.


Reviewed by Oliver Hunt


  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

WebKit/qt:

2008-10-03 David Hyatt <​hyatt@apple.com>

Remove addToDirtyRegion.


Reviewed by Oliver Hunt

  • WebCoreSupport/ChromeClientQt.cpp:

WebKit/win:

2008-10-03 David Hyatt <​hyatt@apple.com>

Remove addToDirtyRegion.


Reviewed by Oliver Hunt

  • WebCoreSupport/WebChromeClient.cpp:

WebKit/wx:

2008-10-03 David Hyatt <​hyatt@apple.com>

Remove addToDirtyRegion.


Reviewed by Oliver Hunt

  • WebKitSupport/ChromeClientWx.cpp:
2:00 AM Changeset in webkit [37233] by mitz@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Maciej Stachowiak.

  • fix a CachedResource leak introduced in r37176

Undo r37176 and instead allow pruneDeadResources() to be re-entered, but
afterwards bail out of the outer pruneDeadResources().

  • loader/Cache.cpp: (WebCore::Cache::Cache): (WebCore::Cache::pruneDeadResources): (WebCore::Cache::remove):
  • loader/Cache.h:
1:50 AM Changeset in webkit [37232] by hyatt@apple.com
  • 4 edits in trunk/WebCore

2008-10-03 David Hyatt <​hyatt@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=21330

Fix Gtk adjustments so that they are properly checked again before creating horizontal/vertical
scrollbars.


Reviewed by Oliver Hunt

  • platform/ScrollView.cpp: (WebCore::ScrollView::setHasHorizontalScrollbar): (WebCore::ScrollView::setHasVerticalScrollbar): (WebCore::ScrollView::platformHasHorizontalAdjustment): (WebCore::ScrollView::platformHasVerticalAdjustment):
  • platform/ScrollView.h:
  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::adjustmentChanged): (WebCore::ScrollView::ScrollView): (WebCore::ScrollView::~ScrollView): (WebCore::ScrollView::setGtkAdjustments): (WebCore::ScrollView::platformHandleHorizontalAdjustment): (WebCore::ScrollView::platformHandleVerticalAdjustment):
1:15 AM Changeset in webkit [37231] by jchaffraix@webkit.org
  • 4 edits in trunk/WebCore

2008-10-03 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Maciej Stachowiak.

Bug 21106: .in format discussed changes
​https://bugs.webkit.org/show_bug.cgi?id=21106

Change "upperCase" to "interfaceName" per-tag parameter as
discussed on the mailing list. Removed the per-attribute version
as it was not used.

Also add the "Element" suffix to all interfaceName parameter to match
the class name (and thus remove it from make_names.pl).

  • dom/make_names.pl:
  • html/HTMLTagNames.in:
  • svg/svgtags.in:
12:52 AM Changeset in webkit [37230] by hyatt@apple.com
  • 1 edit in trunk/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp

Another speculative Gtk scrolling fix.

12:52 AM Changeset in webkit [37229] by hyatt@apple.com
  • 1 edit in trunk/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp

Another speculative Gtk scrolling fix.

12:51 AM Changeset in webkit [37228] by hyatt@apple.com
  • 1 edit in trunk/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp

Another speculative Gtk scrolling fix.

12:47 AM Changeset in webkit [37227] by mjs@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-10-03 Maciej Stachowiak <​mjs@apple.com>

Rubber stamped by Cameron Zwarich.


fix mistaken change of | to
which caused a big perf regression on EarleyBoyer
  • kjs/grammar.y:
12:44 AM Changeset in webkit [37226] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/ScrollView.h

Fix Qt bustage.

12:41 AM Changeset in webkit [37225] by hyatt@apple.com
  • 1 edit in trunk/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp

Speculative fix for gtk not painting on scroll.

12:38 AM Changeset in webkit [37224] by hyatt@apple.com
  • 4 edits in trunk/WebCore

2008-10-03 David Hyatt <​hyatt@apple.com>

Preserve Qt's disabling of blitting when any native widgets are present anywhere on the page (ick).
Hopefully this is a temporary hack that could eventually be removed.

Reviewed by Sam Weinig

  • platform/ScrollView.cpp: (WebCore::ScrollView::scrollContents):
  • platform/ScrollView.h: (WebCore::ScrollView::rootPreventsBlitting):
  • platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::ScrollView): (WebCore::ScrollView::~ScrollView): (WebCore::ScrollView::platformAddChild): (WebCore::ScrollView::platformRemoveChild):
12:06 AM Changeset in webkit [37223] by hyatt@apple.com
  • 31 edits in trunk

WebCore:

2008-10-02 David Hyatt <​hyatt@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=21328


Make widget invalidation more cross-platform.


(1) Make invalidateRect a pure virtual function on Widget. All leaf widgets must now implement this function.


(2) Scrollbars now send invalidations through the ScrollbarClient. windowClipRect on ScrollbarClient has been removed and replaced with this invalidation call.
This allows all scrollbar invalidations to go through the render tree so that transforms and reflections will be respected.


(3) Plugins now have the native window invalidation code for windowed plugins. Windowless plugins do a repaintRectangle on the plugin's renderer.


(4) FrameViews now do a repaintRectangle on their owner element's renderer.

Reviewed by Sam Weinig

  • WebCore.base.exp:
  • page/FrameView.cpp: (WebCore::FrameView::invalidateRect): (WebCore::FrameView::invalidateScrollbarRect):
  • page/FrameView.h:
  • platform/PopupMenu.h:
  • platform/ScrollView.cpp: (WebCore::ScrollView::scrollContents):
  • platform/ScrollView.h:
  • platform/Scrollbar.cpp: (WebCore::Scrollbar::setEnabled): (WebCore::Scrollbar::invalidateRect):
  • platform/Scrollbar.h:
  • platform/ScrollbarClient.h:
  • platform/Widget.h:
  • platform/gtk/WidgetGtk.cpp:
  • platform/mac/WidgetMac.mm:
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::invalidateScrollbarRect):
  • platform/win/WidgetWin.cpp:
  • plugins/PluginView.cpp: (WebCore::PluginView::invalidateTimerFired): (WebCore::PluginView::invalidateWindowlessPluginRect):
  • plugins/PluginView.h:
  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::invalidateRect):
  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::invalidateRect):
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginView::invalidateRect): (WebCore::PluginView::invalidateRegion):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::invalidateScrollbarRect):
  • rendering/RenderLayer.h:
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintObject): (WebCore::RenderListBox::paintScrollbar): (WebCore::RenderListBox::invalidateScrollbarRect):
  • rendering/RenderListBox.h:

WebKit/mac:

2008-10-02 David Hyatt <​hyatt@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=21328


Make widget invalidation more cross-platform.


(1) Make invalidateRect a pure virtual function on Widget. All leaf widgets must now implement this function.


(2) Scrollbars now send invalidations through the ScrollbarClient. windowClipRect on ScrollbarClient has been removed and replaced with this invalidation call.
This allows all scrollbar invalidations to go through the render tree so that transforms and reflections will be respected.


(3) Plugins now have the native window invalidation code for windowed plugins. Windowless plugins do a repaintRectangle on the plugin's renderer.


(4) FrameViews now do a repaintRectangle on their owner element's renderer.

Reviewed by Sam Weinig

  • WebCoreSupport/WebFrameLoaderClient.mm: (PluginWidget::PluginWidget): (PluginWidget::invalidateRect): (NetscapePluginWidget::NetscapePluginWidget): (WebFrameLoaderClient::createPlugin):

WebKit/win:

2008-10-02 David Hyatt <​hyatt@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=21328


Make widget invalidation more cross-platform.


(1) Make invalidateRect a pure virtual function on Widget. All leaf widgets must now implement this function.


(2) Scrollbars now send invalidations through the ScrollbarClient. windowClipRect on ScrollbarClient has been removed and replaced with this invalidation call.
This allows all scrollbar invalidations to go through the render tree so that transforms and reflections will be respected.


(3) Plugins now have the native window invalidation code for windowed plugins. Windowless plugins do a repaintRectangle on the plugin's renderer.


(4) FrameViews now do a repaintRectangle on their owner element's renderer.

Reviewed by Sam Weinig

  • WebCoreSupport/EmbeddedWidget.cpp: (EmbeddedWidget::invalidateRect):
  • WebCoreSupport/EmbeddedWidget.h:
  • WebScrollBar.cpp: (WebScrollBar::invalidateScrollbarRect):
  • WebScrollBar.h:

Oct 2, 2008:

11:20 PM Changeset in webkit [37222] by mitz@apple.com
  • 5 edits
    2 adds in trunk

WebCore:

Reviewed by Geoffrey Garen and Sam Weinig.

  • fix SVGFontFaceElement leaks seen in Acid3
  • make font-face elements take effect only when they are in the document tree

Test: svg/custom/font-face-not-in-document.svg

  • svg/SVGFontData.h: Changed the m_svgFontFaceElement member from a RefPtr to a plain pointer to break a ref cycle. (WebCore::SVGFontData::svgFontFaceElement):
  • svg/SVGFontFaceElement.cpp: Changed to insert and remove the @font-face rule from the document's mapped element sheet when the element is inserted and removed from the document, and to update it only when the element is in the document. (WebCore::SVGFontFaceElement::SVGFontFaceElement): (WebCore::SVGFontFaceElement::parseMappedAttribute): (WebCore::SVGFontFaceElement::rebuildFontFace): (WebCore::SVGFontFaceElement::insertedIntoDocument): (WebCore::SVGFontFaceElement::removedFromDocument): (WebCore::SVGFontFaceElement::childrenChanged): (WebCore::SVGFontFaceElement::removeFromMappedElementSheet):
  • svg/SVGFontFaceElement.h:

LayoutTests:

Reviewed by Geoffrey Garen and Sam Weinig.

  • svg/custom/font-face-not-in-document-expected.txt: Added.
  • svg/custom/font-face-not-in-document.svg: Added.
6:59 PM Changeset in webkit [37221] by mrowe@apple.com
  • 2 edits in branches/Safari-3-2-branch/JavaScriptCore

Merge r31824.

5:43 PM Changeset in webkit [37220] by Simon Fraser
  • 6 edits in trunk/WebCore

2008-10-01 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

Fix RenderFileUploadControl::setStyle() and
RenderMenuList::setStyle() to not touch the style; replace
with html4.css and CSSStyleSelector changes.

​https://bugs.webkit.org/show_bug.cgi?id=21287

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle):
  • css/html4.css:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::setStyle):
  • rendering/RenderFileUploadControl.cpp:
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::setStyle):
5:41 PM Changeset in webkit [37219] by Simon Fraser
  • 7 edits in trunk

2008-10-01 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

Clean up code that changes the RenderStyle passed in to
table renderer setStyle() methods.

​https://bugs.webkit.org/show_bug.cgi?id=21287

Tests: fast/table/floating-th.html

fast/table/table-display-types-strict.html
fast/table/table-display-types.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::setStyle):
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::setStyle):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::setStyle):
5:28 PM Changeset in webkit [37218] by Darin Adler
  • 2 edits in trunk/WebCore

2008-10-02 Darin Adler <Darin Adler>

  • fix build
  • bindings/scripts/CodeGeneratorJS.pm: Need to replace the -> with a . here too. Not just locally in my generated file!
5:25 PM Changeset in webkit [37217] by adele@apple.com
  • 15 edits in trunk

WebCore:

2008-10-02 Adele Peterson <​adele@apple.com>

Reviewed by Dan Bernstein.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=21299
REGRESSION: <input> color specified in inline style applies to placeholder

I recently added a pseudo-class for the placeholder, but that can be overridden by inline style changes. A pseudo-element
is more appropriate. This change adds "-webkit-input-placeholder".

  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): Added definition for "-webkit-input-placeholder" pseudo element.
  • css/CSSSelector.h: (WebCore::CSSSelector::): Added PseudoInputPlaceholder.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Added case for PseudoInputPlaceholder.
  • css/html4.css: Added rule for -webkit-input-placeholder pseudo-element.
  • rendering/style/RenderStyle.h: (WebCore::RenderStyle::): Added INPUT_PLACEHOLDER.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setValue): Check that its a text field before calling updatePlaceholderVisibility. (WebCore::HTMLInputElement::setValueFromRenderer): ditto. (WebCore::HTMLInputElement::updatePlaceholderVisibility): Instead of calling setChanged(), call updatePlaceholderVisibility on the renderer. setChanged wouldn't actually trigger setStyle since the style for the input element won't actually change.
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::createInnerTextStyle): Get the pseudoStyle when the placeholder is visible. (WebCore::RenderTextControl::updatePlaceholderVisibility): Sets the style on the inner text block, and calls updateFromElement so the text will be updated correctly.
  • rendering/RenderTextControl.h:

LayoutTests:

2008-10-02 Adele Peterson <​adele@apple.com>

Reviewed by Dan Bernstein.

Update tests for ​https://bugs.webkit.org/show_bug.cgi?id=21299
REGRESSION: <input> color specified in inline style applies to placeholder

  • fast/forms/placeholder-pseudo-style.html:
  • platform/mac/fast/forms/password-placeholder-expected.txt:
  • platform/mac/fast/forms/password-placeholder-text-security-expected.txt:
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/mac/fast/forms/placeholder-set-attribute-expected.txt:
4:59 PM Changeset in webkit [37216] by Chris Fleizach
  • 6 edits in trunk

<rdar://problem/6227690> There are a bunch of tables on this page that don't seem to be real tables

4:48 PM Changeset in webkit [37215] by Darin Adler
  • 20 edits in trunk

JavaScriptCore:

2008-10-02 Darin Adler <Darin Adler>

Reviewed by Geoff Garen.

1.019x as fast on SunSpider.

  • API/JSBase.cpp: (JSEvaluateScript): Use heap. instead of heap-> to work with the heap. (JSCheckScriptSyntax): Ditto. (JSGarbageCollect): Ditto. (JSReportExtraMemoryCost): Ditto.
  • API/JSContextRef.cpp: (JSGlobalContextRetain): Ditto. (JSGlobalContextRelease): Destroy the heap with the destroy function instead of the delete operator. (JSContextGetGlobalObject): Use heap. instead of heap-> to work with the heap.
  • API/JSObjectRef.cpp: (JSObjectMake): Use heap. instead of heap-> to work with the heap. (JSObjectMakeFunctionWithCallback): Ditto. (JSObjectMakeConstructor): Ditto. (JSObjectMakeFunction): Ditto. (JSObjectMakeArray): Ditto. (JSObjectMakeDate): Ditto. (JSObjectMakeError): Ditto. (JSObjectMakeRegExp): Ditto. (JSObjectHasProperty): Ditto. (JSObjectGetProperty): Ditto. (JSObjectSetProperty): Ditto. (JSObjectGetPropertyAtIndex): Ditto. (JSObjectSetPropertyAtIndex): Ditto. (JSObjectDeleteProperty): Ditto. (JSObjectCallAsFunction): Ditto. (JSObjectCallAsConstructor): Ditto. (JSObjectCopyPropertyNames): Ditto. (JSPropertyNameAccumulatorAddName): Ditto.
  • API/JSValueRef.cpp: (JSValueIsEqual): Ditto. (JSValueIsInstanceOfConstructor): Ditto. (JSValueMakeNumber): Ditto. (JSValueMakeString): Ditto. (JSValueToNumber): Ditto. (JSValueToStringCopy): Ditto. (JSValueToObject): Ditto. (JSValueProtect): Ditto. (JSValueUnprotect): Ditto.
  • kjs/ExecState.h: (JSC::ExecState::heap): Update to use the & operator.
  • kjs/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): Update to initialize a heap member instead of calling new to make a heap. (JSC::JSGlobalData::~JSGlobalData): Destroy the heap with the destroy function instead of the delete operator.
  • kjs/JSGlobalData.h: Change from Heap* to a Heap.
  • kjs/JSGlobalObject.cpp: (JSC::JSGlobalObject::mark): Use the & operator here. (JSC::JSGlobalObject::operator new): Use heap. instead of heap-> to work with the heap.

WebCore:

2008-10-02 Darin Adler <Darin Adler>

Reviewed by Geoff Garen.

  • bindings/js/GCController.cpp: (WebCore::collect): Use heap. instead of heap-> to work with the heap. (WebCore::GCController::gcTimerFired): Ditto. (WebCore::GCController::garbageCollectNow): Ditto.
  • bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::operator new): Ditto.
  • storage/Database.cpp: (WebCore::Database::Database): Ditto.

WebKit/mac:

2008-10-02 Darin Adler <Darin Adler>

Reviewed by Geoff Garen.

  • Misc/WebCoreStatistics.mm: (+[WebCoreStatistics javaScriptObjectsCount]): Use heap. instead of heap-> to work with the heap. (+[WebCoreStatistics javaScriptGlobalObjectsCount]): Ditto. (+[WebCoreStatistics javaScriptProtectedObjectsCount]): Ditto. (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]): Ditto. (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]): Ditto. (+[WebCoreStatistics javaScriptReferencedObjectsCount]): Ditto.

WebKit/win:

2008-10-02 Darin Adler <Darin Adler>

  • WebCoreStatistics.cpp: (WebCoreStatistics::javaScriptObjectsCount): Use heap. instead of heap-> to work with the heap. (WebCoreStatistics::javaScriptGlobalObjectsCount): Ditto. (WebCoreStatistics::javaScriptProtectedObjectsCount): Ditto. (WebCoreStatistics::javaScriptProtectedGlobalObjectsCount): Ditto. (WebCoreStatistics::javaScriptProtectedObjectTypeCounts): Ditto.
  • WebJavaScriptCollector.cpp: (WebJavaScriptCollector::objectCount): Ditto.
4:05 PM Changeset in webkit [37214] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/gtk/ScrollViewGtk.cpp

Fix Gtk bustage.

3:19 PM Changeset in webkit [37213] by cwzwarich@webkit.org
  • 5 edits in trunk/JavaScriptCore

2008-10-02 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Geoff Garen.

Bug 21317: Replace RegisterFile size and capacity information with Register pointers
<​https://bugs.webkit.org/show_bug.cgi?id=21317>

This is a 2.3% speedup on the V8 DeltaBlue benchmark, a 3.3% speedup on
the V8 Raytrace benchmark, and a 1.0% speedup on SunSpider.

  • VM/Machine.cpp: (JSC::slideRegisterWindowForCall): (JSC::Machine::callEval): (JSC::Machine::execute): (JSC::Machine::privateExecute): (JSC::Machine::cti_op_call_JSFunction): (JSC::Machine::cti_op_construct_JSConstruct):
  • VM/RegisterFile.cpp: (JSC::RegisterFile::~RegisterFile):
  • VM/RegisterFile.h: (JSC::RegisterFile::RegisterFile): (JSC::RegisterFile::start): (JSC::RegisterFile::end): (JSC::RegisterFile::size): (JSC::RegisterFile::shrink): (JSC::RegisterFile::grow): (JSC::RegisterFile::lastGlobal): (JSC::RegisterFile::markGlobals): (JSC::RegisterFile::markCallFrames):
  • kjs/JSGlobalObject.cpp: (JSC::JSGlobalObject::copyGlobalsTo):
2:54 PM Changeset in webkit [37212] by adele@apple.com
  • 8 edits in trunk/LayoutTests

2008-10-02 Adele Peterson <​adele@apple.com>

Update results for mac-tiger.

  • platform/mac-tiger/svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
  • platform/mac-tiger/svg/hixie/perf/001-expected.txt:
  • platform/mac-tiger/svg/hixie/perf/002-expected.txt:
  • platform/mac-tiger/svg/hixie/text/003-expected.txt:
  • platform/mac-tiger/svg/hixie/text/003a-expected.txt:
  • platform/mac-tiger/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt:
  • platform/mac-tiger/svg/text/text-path-01-b-expected.txt:
2:33 PM Changeset in webkit [37211] by hyatt@apple.com
  • 2 edits in trunk/WebKit/win

Fix scrolling=no iframe regression on Windows.

2:03 PM Changeset in webkit [37210] by hyatt@apple.com
  • 2 edits in trunk/WebKit/win

Fix Win build bustage.

1:46 PM Changeset in webkit [37209] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Alexey Proskuryakov.

  • fix a Database leak that resulted in Document leaks
  • storage/Database.cpp: (WebCore::Database::openDatabase): Account for the fact that RefCounted objects start out with a ref count of 1.
1:29 PM Changeset in webkit [37208] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-10-02 Sam Weinig <​sam@webkit.org>

Reviewed by Mr. Geoffrey Garen.

Always mark your parent before marking members.

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::mark):
1:26 PM Changeset in webkit [37207] by Adam Roben
  • 2 edits in trunk/BugsSite
  • template/en/custom/attachment/reviewform.html.tmpl: Fix typo.
1:23 PM Changeset in webkit [37206] by Adam Roben
  • 2 edits in trunk/BugsSite
  • template/en/custom/attachment/review.html.tmpl: Fix URLs
1:21 PM Changeset in webkit [37205] by Adam Roben
  • 3 edits
    2 adds in trunk/BugsSite

Fix Bug 21315: bugs.webkit.org should have a nicer patch review interface

​https://bugs.webkit.org/show_bug.cgi?id=21315

Reviewed by Tim Hatcher.

  • attachment.cgi: (top level): Added support for the "review" and "reviewform" actions. (sub edit): Accept the template name as a parameter. If no name is give, use "edit" as before.
  • template/en/custom/attachment/list.html.tmpl: Added a "Review Patch" link for all patch attachments.
  • template/en/custom/attachment/review.html.tmpl: Added. Simple <frameset> page to show the patch on the top and a comment form on the bottom.
  • template/en/custom/attachment/reviewform.html.tmpl: Added. Simple comment form for reviewing patches.
1:17 PM Changeset in webkit [37204] by hyatt@apple.com
  • 26 edits in trunk

WebCore:

2008-10-02 David Hyatt <​hyatt@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=21314


Make scrollBackingStore cross-platform.

Reviewed by Sam Weinig

  • loader/EmptyClients.h: (WebCore::EmptyChromeClient::repaint): (WebCore::EmptyChromeClient::scroll):
  • page/Chrome.cpp: (WebCore::Chrome::repaint): (WebCore::Chrome::scroll):
  • page/Chrome.h:
  • page/ChromeClient.h:
  • page/EventHandler.cpp: (WebCore::EventHandler::handleAutoscroll):
  • platform/HostWindow.h:
  • platform/ScrollView.cpp: (WebCore::ScrollView::scrollContents): (WebCore::ScrollView::addPanScrollIcon): (WebCore::ScrollView::removePanScrollIcon):
  • platform/ScrollView.h:
  • platform/gtk/ScrollViewGtk.cpp:
  • platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::~ScrollView):
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::ScrollView): (WebCore::ScrollView::~ScrollView):

WebKit/gtk:

2008-10-02 David Hyatt <​hyatt@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=21314


Make scrollBackingStore cross-platform.

Reviewed by Sam Weinig

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::repaint): (WebKit::ChromeClient::scroll):
  • WebCoreSupport/ChromeClientGtk.h:

WebKit/mac:

2008-10-02 David Hyatt <​hyatt@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=21314


Make scrollBackingStore cross-platform.

Reviewed by Sam Weinig

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::repaint): (WebChromeClient::scroll):

WebKit/qt:

2008-10-02 David Hyatt <​hyatt@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=21314


Make scrollBackingStore cross-platform.

Reviewed by Sam Weinig

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::repaint): (WebCore::ChromeClientQt::scroll):
  • WebCoreSupport/ChromeClientQt.h:

WebKit/win:

2008-10-02 David Hyatt <​hyatt@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=21314


Make scrollBackingStore cross-platform.

Reviewed by Sam Weinig

  • WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::repaint): (WebChromeClient::scroll):
  • WebCoreSupport/WebChromeClient.h:
  • WebView.cpp: (WebView::repaint):
  • WebView.h:
12:59 PM Changeset in webkit [37203] by kevino@webkit.org
  • 5 edits in trunk

wx build fixes after Frame/ScrollView changes.

12:33 PM Changeset in webkit [37202] by brettw@chromium.org
  • 92 edits in trunk

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=21292

Revert the changes to enclosingIntRect made in r12530 since the new code
doesn't round correctly.

11:48 AM Changeset in webkit [37201] by mitz@apple.com
  • 4 edits in trunk/WebCore

Reviewed by Anders Carlsson and Eric Seidel.

  • fix HTMLCanvaseElement leak from -webkit-canvas() values

Changed the m_element member of CSSCanvasValue from a RefPtr to a plain
pointer, as the document owns the canvas elements. Added code to release
those elements in Document::removedLastRef() because they reference
the document.

  • css/CSSCanvasValue.cpp: (WebCore::CSSCanvasValue::element):
  • css/CSSCanvasValue.h: (WebCore::CSSCanvasValue::CSSCanvasValue):
  • dom/Document.cpp: (WebCore::Document::removedLastRef):
11:40 AM Changeset in webkit [37200] by ap@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

A typo fix for ChangeLog.

11:39 AM Changeset in webkit [37199] by ap@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Maciej Stachowiak.

Build fix for platform that don't implement WTF::ThreadSpecific.

  • bindings/js/JSDOMBinding.cpp: (WebCore::wrapperSet): Guard ThreadSpecific use with #if ENABLE(WORKERS). No platform defines this yet, but this code is only needed for JS bindings in worker threads.
11:23 AM Changeset in webkit [37198] by hyatt@apple.com
  • 23 edits in trunk

WebCore:

2008-10-01 David Hyatt <​hyatt@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=21298


Make updateScrollbars cross-platform. For now a stubbed out scrollContents function is invoked to do the scrolling of the backing store. Next patch
will make that cross-platform.


The ScrollView now implements ScrollbarClient, which means that there was a clash of windowClipRect methods from the
multiple inheritance. For now I solved this by adding a Scrollbar* to the ScrollbarClient version of the method, but longer term
windowClipRect is going to be removed from ScrollbarClient (when Widget invalidation gets rewritten).


Reviewed by Sam Weinig

  • page/FrameView.cpp: (WebCore::FrameView::windowClipRect): (WebCore::FrameView::isActive):
  • page/FrameView.h: (WebCore::FrameView::visibleContentsResized):
  • platform/PopupMenu.h:
  • platform/ScrollView.cpp: (WebCore::ScrollView::init): (WebCore::ScrollView::destroy): (WebCore::ScrollView::setHasHorizontalScrollbar): (WebCore::ScrollView::setHasVerticalScrollbar): (WebCore::ScrollView::valueChanged): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::scrollContents): (WebCore::ScrollView::platformHandleHorizontalAdjustment): (WebCore::ScrollView::platformHandleVerticalAdjustment):
  • platform/ScrollView.h:
  • platform/Scrollbar.cpp: (WebCore::Scrollbar::windowClipRect):
  • platform/ScrollbarClient.h:
  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::platformHandleHorizontalAdjustment): (WebCore::ScrollView::platformHandleVerticalAdjustment):
  • platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::scrollContents):
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::windowClipRect):
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::scrollContents):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::windowClipRect):
  • rendering/RenderLayer.h:
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::panScroll): (WebCore::RenderListBox::windowClipRect):
  • rendering/RenderListBox.h:

WebKit/win:

2008-10-01 David Hyatt <​hyatt@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=21298


Make updateScrollbars cross-platform. For now a stubbed out scrollContents function is invoked to do the scrolling of the backing store. Next patch
will make that cross-platform.


The ScrollView now implements ScrollbarClient, which means that there was a clash of windowClipRect methods from the
multiple inheritance. For now I solved this by adding a Scrollbar* to the ScrollbarClient version of the method, but longer term
windowClipRect is going to be removed from ScrollbarClient (when Widget invalidation gets rewritten).

Reviewed by Sam Weinig

  • WebScrollBar.cpp: (WebScrollBar::windowClipRect):
  • WebScrollBar.h:
10:54 AM Changeset in webkit [37197] by sfalken@apple.com
  • 2 edits in branches/Safari-3-2-branch/WebKit/win

Merge r31212 for fix <rdar://problem/6168976> visitCount not updated in History.plist

10:03 AM Changeset in webkit [37196] by Adam Roben
  • 2 edits
    2 deletes in trunk/BugsSite

Remove references to some backup files I created when implementing PrettyPatch in Bugzilla

Reviewed by Tim Hatcher.

  • attachment-aroben.cgi: Removed.
  • template/en/default/attachment/edit-aroben.html.tmpl: Removed.
  • template/en/custom/attachment/edit.html.tmpl: Removed an erroneous reference to attachment-aroben.cgi. attachment.cgi will work just fine.
10:00 AM Changeset in webkit [37195] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-10-02 Cameron Zwarich <​zwarich@apple.com>

Rubber-stamped by Darin Adler.

Change bitwise operations introduced in r37166 to boolean operations. We
only use bitwise operations over boolean operations for increasing
performance in extremely hot code, but that does not apply to anything
in the parser.

  • kjs/grammar.y:
9:45 AM Changeset in webkit [37194] by barraclough@apple.com
  • 6 edits
    3 adds in trunk

JavaScriptCore:

2008-10-02 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Darin Adler.

Fix for bug #21232 - should reset m_isPendingDash on flush,
and should allow '\-' as beginning or end of a range (though
not to specifiy a range itself).

  • ChangeLog:
  • wrec/CharacterClassConstructor.cpp: (JSC::CharacterClassConstructor::put): (JSC::CharacterClassConstructor::flush):
  • wrec/CharacterClassConstructor.h: (JSC::CharacterClassConstructor::flushBeforeEscapedHyphen):
  • wrec/WREC.cpp: (JSC::WRECGenerator::generateDisjunction): (JSC::WRECParser::parseCharacterClass): (JSC::WRECParser::parseDisjunction):
  • wrec/WREC.h:

LayoutTests:

2008-10-02 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Darin Adler.

Layout tests for for bug #21232 - plus a range of tests for, um, ranges.

  • fast/js/regexp-ranges-and-escaped-hyphens-expected.txt: Added.
  • fast/js/regexp-ranges-and-escaped-hyphens.html: Added.
  • fast/js/resources/regexp-ranges-and-escaped-hyphens.js: Added.
9:45 AM Changeset in webkit [37193] by ap@webkit.org
  • 1 edit in trunk/JavaScriptCore/JavaScriptCore.exp

Forgot to land JavaScriptCore.exp with the previous check-in.

9:39 AM Changeset in webkit [37192] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

2008-10-02 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

  • remove the "static" from declarations in a header file, since we don't want them to have internal linkage
  • VM/Machine.h: Remove the static keyword from the constant and the three inline functions that Geoff just moved here.
9:22 AM Changeset in webkit [37191] by ggaren@apple.com
  • 4 edits in trunk/JavaScriptCore

2008-10-02 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.


Fixed ​https://bugs.webkit.org/show_bug.cgi?id=21283.
Profiler Crashes When Started

  • VM/Machine.cpp:
  • VM/Machine.h: (JSC::makeHostCallFramePointer): (JSC::isHostCallFrame): (JSC::stripHostCallFrameBit): Moved some things to the header so JSGlobalObject could use them.
  • kjs/JSGlobalObject.h: (JSC::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData): Call the new makeHostCallFramePointer API, since 0 no longer indicates a host call frame.
9:18 AM Changeset in webkit [37190] by ap@webkit.org
  • 35 edits
    2 deletes in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=21304
Stop using a static wrapper map for WebCore JS bindings

The static domObjects map was not thread safe.

  • dom/Document.h: (WebCore::Document::messagePorts): Added an accessor for JSDocument to iterate over message ports. (WebCore::Document::xmlHttpRequests): Ditto for XMLHttpRequests.
  • dom/Document.cpp: (WebCore::Document::createdXMLHttpRequest): (WebCore::Document::destroyedXMLHttpRequest): Moved XMLHttpRequest tracking from a global map to Document.
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • webcore-base.bkl:
  • bindings/DOMProtect.cpp: Removed.
  • bindings/DOMProtect.h: Removed. Removed gcProtect(Unprotect)DOMObject - its callers do not have a JSGlobalData reference, so they can no longer protect bindings objects.
  • dom/MessagePort.cpp: (WebCore::CloseMessagePortTimer::CloseMessagePortTimer): (WebCore::CloseMessagePortTimer::fired): (WebCore::MessagePort::MessagePort): (WebCore::MessagePort::queueCloseEvent): (WebCore::MessagePort::setPendingActivity): (WebCore::MessagePort::unsetPendingActivity):
  • dom/MessagePort.h: (WebCore::MessagePort::hasPendingActivity): MessagePort now counts outstanding async events, so JSDocument::mark can decide whether to protect it.
  • xml/XMLHttpRequest.h: (WebCore::XMLHttpRequest::hasPendingActivity):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::XMLHttpRequest): (WebCore::XMLHttpRequest::~XMLHttpRequest): (WebCore::XMLHttpRequest::loadRequestAsynchronously): (WebCore::XMLHttpRequest::dropProtection): (WebCore::XMLHttpRequest::didFinishLoadingPreflight): (WebCore::XMLHttpRequest::cancelRequests): (WebCore::XMLHttpRequest::detachRequests): (WebCore::XMLHttpRequest::setPendingActivity): (WebCore::XMLHttpRequest::unsetPendingActivity): Moved XMLHttpRequest tracking from a global map to Document.
  • bindings/js/JSDOMBinding.cpp: (WebCore::wrapperSet): (WebCore::DOMObjectWrapperMap::mapFor): (WebCore::DOMObjectWrapperMap::get): (WebCore::DOMObjectWrapperMap::set): (WebCore::DOMObjectWrapperMap::remove): (WebCore::getCachedDOMObjectWrapper): (WebCore::cacheDOMObjectWrapper): (WebCore::forgetDOMObject): (WebCore::getCachedDOMNodeWrapper): (WebCore::forgetDOMNode): (WebCore::cacheDOMNodeWrapper): (WebCore::markActiveObjectsForDocument):
  • bindings/js/JSDOMBinding.h: (WebCore::createDOMObjectWrapper): (WebCore::getDOMObjectWrapper): Wrapper map is now kept as JSGlobalData::clientData. Also changed debug-only wrapperSet to be per-thread (this is slower than going to JSGlobalData, but fast enough for debug). WebCore objects can never migrate between threads.
  • bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::mark): Call markActiveObjectsForDocument() from JSDOMBinding.
  • bindings/js/JSCSSRuleCustom.cpp: (WebCore::toJS):
  • bindings/js/JSCSSValueCustom.cpp: (WebCore::toJS):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::markDOMObjectWrapper): (WebCore::JSDOMWindow::mark):
  • bindings/js/JSEventCustom.cpp: (WebCore::toJS):
  • bindings/js/JSEventTarget.cpp: (WebCore::toJS):
  • bindings/js/JSHTMLCollectionCustom.cpp: (WebCore::toJS):
  • bindings/js/JSImageDataCustom.cpp: (WebCore::toJS):
  • bindings/js/JSMessageChannelCustom.cpp: (WebCore::JSMessageChannel::mark):
  • bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::mark):
  • bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::mark):
  • bindings/js/JSSVGPathSegCustom.cpp: (WebCore::toJS):
  • bindings/js/JSStyleSheetCustom.cpp: (WebCore::toJS):
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::mark):
  • bindings/js/JSXMLHttpRequestUploadCustom.cpp: (WebCore::JSXMLHttpRequestUpload::mark):
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::finishedWithEvent):
  • bindings/scripts/CodeGeneratorJS.pm: Pass a JSGlobalData reference to functions that track JS wrapper objects.

JavaScriptCore:

  • kjs/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): (JSC::JSGlobalData::~JSGlobalData): (JSC::JSGlobalData::ClientData::~ClientData):
  • kjs/JSGlobalData.h: Added a client data member to JSGlobalData. WebCore will use it to store bindings-related global data.
12:52 AM Changeset in webkit [37189] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • build fix
  • page/JavaScriptCallFrame.idl:
12:35 AM Changeset in webkit [37188] by oliver@apple.com
  • 4 edits in trunk/WebCore

Add new file to project files

Reviewed by NOBODY (Build fix)

12:15 AM Changeset in webkit [37187] by ggaren@apple.com
  • 3 edits in trunk/WebCore

2008-10-02 Geoffrey Garen <​ggaren@apple.com>

Not reviewed.

Try to fix some more builds.

  • GNUmakefile.am:
  • WebCore.pro:
12:13 AM Changeset in webkit [37186] by ggaren@apple.com
  • 2 edits in trunk/WebCore

2008-10-02 Geoffrey Garen <​ggaren@apple.com>

Not reviewed.


Try to fix Windows build.

  • WebCore.vcproj/WebCore.vcproj:
12:04 AM Changeset in webkit [37185] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-10-02 Geoffrey Garen <​ggaren@apple.com>

Not reviewed.


Try to fix Qt build.

  • kjs/Error.h:
Note: See TracTimeline for information about the timeline view.