⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 7, 2008:

11:36 PM Changeset in webkit [37408] by weinig@apple.com
  • 5 edits in trunk/JavaScriptCore

2008-10-07 Sam Weinig <​sam@webkit.org>

Roll out r37405.

10:24 PM Changeset in webkit [37407] by mrowe@apple.com
  • 1 copy in tags/Safari-5525.26

New tag.

9:56 PM Changeset in webkit [37406] by oliver@apple.com
  • 6 edits in trunk/JavaScriptCore

Switch CTI runtime calls to the fastcall calling convention

Reviewed by Cameron Zwarich

Basically this means that we get to store the argument for CTI
calls in the ECX register, which saves a register->memory write
and subsequent memory->register read.

This is a 1.7% progression in SunSpider and 2.4% on commandline
v8 tests on Windows

8:46 PM Changeset in webkit [37405] by mjs@apple.com
  • 5 edits in trunk/JavaScriptCore

2008-10-07 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Mark Rowe.


  • optimize away multiplication by constant 1.0


2.3% speedup on v8 RayTrace benchmark

Apparently it's not uncommon for JavaScript code to multiply by
constant 1.0 in the mistaken belief that this converts integer to
floating point and that there is any operational difference.


  • VM/CTI.cpp: (JSC::CTI::privateCompileMainPass): Optimize to_jsnumber for case where parameter is already number. (JSC::CTI::privateCompileSlowCases): ditto
  • VM/Machine.cpp: (JSC::Machine::privateExecute): ditto
  • kjs/grammar.y: (makeMultNode): Transform as follows: +FOO * BAR ==> FOO * BAR FOO * +BAR ==> FOO * BAR FOO * 1 ==> +FOO 1 * FOO ==> +FOO (makeDivNode): Transform as follows: +FOO / BAR ==> FOO / BAR FOO / +BAR ==> FOO / BAR (makeSubNode): Transform as follows: +FOO - BAR ==> FOO - BAR FOO - +BAR ==> FOO - BAR
  • kjs/nodes.h: (JSC::ExpressionNode::stripUnaryPlus): Helper for above grammar.y changes (JSC::UnaryPlusNode::stripUnaryPlus): ditto
8:46 PM Changeset in webkit [37404] by mjs@apple.com
  • 1 edit
    3 adds in trunk/LayoutTests

2008-10-07 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Mark Rowe.


  • test cases that will check some possible edge cases for math optimizations
  • fast/js/math-transforms-expected.txt: Added.
  • fast/js/math-transforms.html: Added.
  • fast/js/resources/math-transforms.js: Added.
5:42 PM Changeset in webkit [37403] by alp@webkit.org
  • 4 edits in trunk

2008-10-07 Alp Toker <​alp@nuanti.com>

GTK+ build fix for older automake versions (1.7). Discussed in bug
#21392.

5:15 PM Changeset in webkit [37402] by mjs@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-10-07 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Oliver Hunt.


  • make constant folding code more consistent


Added a makeSubNode to match add, mult and div; use the makeFooNode functions always,
instead of allocating nodes directly in other places in the grammar.

  • kjs/grammar.y:
5:12 PM Changeset in webkit [37401] by mrowe@apple.com
  • 5 edits
    4 deletes in trunk

Roll out r37391 as it appears to have broken 40+ regression tests.

4:49 PM Changeset in webkit [37400] by weinig@apple.com
  • 6 edits in trunk/JavaScriptCore

2008-10-07 Sam Weinig <​sam@webkit.org>

Reviewed by Cameron Zwarich.

Move hasGetterSetterProperties flag from PropertyMap to StructureID.

  • kjs/JSObject.cpp: (JSC::JSObject::put): (JSC::JSObject::defineGetter): (JSC::JSObject::defineSetter):
  • kjs/JSObject.h: (JSC::JSObject::hasGetterSetterProperties): (JSC::JSObject::getOwnPropertySlotForWrite): (JSC::JSObject::getOwnPropertySlot):
  • kjs/PropertyMap.h:
  • kjs/StructureID.cpp: (JSC::StructureID::StructureID): (JSC::StructureID::addPropertyTransition): (JSC::StructureID::toDictionaryTransition): (JSC::StructureID::changePrototypeTransition): (JSC::StructureID::getterSetterTransition):
  • kjs/StructureID.h: (JSC::StructureID::hasGetterSetterProperties): (JSC::StructureID::setHasGetterSetterProperties):
4:31 PM Changeset in webkit [37399] by andersca@apple.com
  • 2 edits in trunk/WebCore

2008-10-07 Anders Carlsson <​andersca@apple.com>

Reviewed by Antti Koivisto.

<rdar://problem/6273887> Crash in ApplicationCacheGroup


Make sure to stop loading even before a cache update is in progress so that the
manifest load will be stopped.

  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::~ApplicationCacheGroup): (WebCore::ApplicationCacheGroup::stopLoading): (WebCore::ApplicationCacheGroup::cacheUpdateFailed):
3:09 PM Changeset in webkit [37398] by timothy@apple.com
  • 2 edits in trunk/WebCore/bindings/objc

Fix the build due to a bad patch apply.

3:08 PM Changeset in webkit [37397] by timothy@apple.com
  • 2 edits in trunk/WebCore/bindings/objc

Fix the build due to a bad patch apply.

2:49 PM Changeset in webkit [37396] by timothy@apple.com
  • 10 edits
    2 adds in trunk/WebCore

Auto-generate DOMDocument's createNodeIterator: and createTreeWalker: methods.

​https://bugs.webkit.org/show_bug.cgi?id=21433

Reviewed by Sam Weinig.

  • WebCore.xcodeproj/project.pbxproj: Add ObjCNodeFilterCondition.{mm,h}.
  • bindings/objc/DOM.mm: Remove previous category implementations on DOMDocument for createNodeIterator: and createTreeWalker:. Also moves ObjCNodeFilterCondition to its own file.
  • bindings/objc/DOMTraversal.h: Remove the category methods that added createNodeIterator: and createTreeWalker: to DOMDocument. This is fine to do since DOmDocument.h is included still, and has these methods.
  • bindings/objc/DOMUtility.mm: (JSC::createDOMWrapper): Remove special case for JSNodeIterator and JSTreeWalker now that the ObjC binding conforms to the standard wrap.
  • bindings/objc/ObjCNodeFilterCondition.h: Split out from DOM.mm. (WebCore::ObjCNodeFilterCondition::create): Moved from DOM.mm. (WebCore::ObjCNodeFilterCondition::ObjCNodeFilterCondition): Ditto.
  • bindings/objc/ObjCNodeFilterCondition.mm: Split out from DOM.mm. (WebCore::ObjCNodeFilterCondition::acceptNode): Moved from DOM.mm.
  • bindings/objc/PublicDOMInterfaces.h: Add the createNodeIterator: and createTreeWalker: methods to DOMDocument.
  • bindings/scripts/CodeGeneratorObjC.pm: (GetObjCTypeGetter): Add a case for NodeFilter. (AddIncludesForType): Include ObjCNodeFilterCondition.h for NodeFilter. (GenerateImplementation): Remove existing NodeFilter special case that used the m_filter member variable. Add a new special getter for protocol types that aren't EventTarget, so the right class is used for NodeFilter. Add a special case for NodeFilter where it creates an ObjCNodeFilterCondition.
  • dom/Document.idl: Remove the #ifdef LANGUAGE_OBJECTIVE_C. Add the OldStyleObjC extended attribute to createNodeIterator and createTreeWalker. Rename the entityReferenceExpansion parameter to expandEntityReferences to match the previous ObjC API.
  • dom/NodeIterator.idl: Remove ObjCIvar from the filter attribute. The m_filter member variable was never used in practice, it was always nil! We can remove it and not pad the object because this can't be subclassed.
  • dom/TreeWalker.idl: Ditto.
2:49 PM Changeset in webkit [37395] by timothy@apple.com
  • 7 edits
    2 adds in trunk/WebCore

Auto-generate the DOMEventTarget protocol implementation for
DOMNode and DOMSVGElementInstance.

​https://bugs.webkit.org/show_bug.cgi?id=21432

Reviewed by Darin Adler.

  • WebCore.xcodeproj/project.pbxproj: Add ObjCEventListener.{mm,h}.
  • bindings/objc/DOM.mm: Remove many unneeded header includes. Move ObjCEventListener to it's own file. Remove the manual impelmentations of the DOMEventTarget protocol for DOMNode and DOMSVGElementInstance.
  • bindings/objc/DOMEvents.h: Remove the categories that defined DOMEventTarget for DOMNode and DOMSVGElementInstance.
  • bindings/objc/ObjCEventListener.h: Split out from DOM.mm.
  • bindings/objc/ObjCEventListener.mm: Split out from DOM.mm. (WebCore::ObjCEventListener::find): Moved from DOM.mm. (WebCore::ObjCEventListener::wrap): Use PassRefPtr to prevent the callers from doing a manual deref. (WebCore::ObjCEventListener::ObjCEventListener): Moved from DOM.mm. (WebCore::ObjCEventListener::~ObjCEventListener): Ditto.
  • bindings/scripts/CodeGeneratorObjC.pm: (GetObjCTypeGetter): Add a case for EventListener and use WTF::getPtr. (AddIncludesForType): Include ObjCEventListener.h for EventListener. And include EventTargetSVGElementInstance.h for SVGElementInstance. (GenerateHeader): Remove the check for multiple parents. (GenerateImplementation): Remove the check for multiple parents. Remove the @deprecatedFunctions array since deprecated methods get generated into the main @interface now to work with protocols. Add support for the EventTargetNodeCast extended attribute. Add support for EventListener parameters.
  • dom/Node.idl: Define superclasses for ObjC so the implementation and interface implement the DOMEventTarget protocol. Explicitly specify Object as a superclass to use DOMEventTarget. Object will turn into DOMObject. This is needed to take the code generator down the right path of multiple super-classes as protocols. It is ObjC only for legacy reasons. The event target methods are normally on NodeEventTarget, a subclass of Node. But the ObjC API has never has this subclass and they are on DOMNode.
  • svg/SVGElementInstance.idl: Ditto.
2:36 PM Changeset in webkit [37394] by hyatt@apple.com
  • 3 edits in trunk/WebCore

2008-10-07 David Hyatt <​hyatt@apple.com>

Add new pseudo-elements and pseudo-classes that will enable scrollbars to be styled by CSS.

The new pseudo-elements are:

scrollbar
scrollbar-button
scrollbar-corner
scrollbar-thumb
scrollbar-track


These elements will work with all the usual pseudo-classes (:hover, :active, :enabled, :disabled, etc.) and with
the following new pseudo-classes:

scrollbar-active
scrollbar-back
scrollbar-forward
scrollbar-horizontal
scrollbar-vertical


Reviewed by Adele

  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
2:35 PM Changeset in webkit [37393] by Adam Roben
  • 2 edits in trunk/WebKitTools

Make sure short functions get included in ChangeLog output for git repositories

Reviewed by Dave Kilzer.

  • Scripts/prepare-ChangeLog: (sub diffCommand): Pass -U0 to git diff so that each contiguous change will get its own chunk without any surrounding context. (sub extractLineRange): Use the line numbers from the chunk header without modifying them now that they're accurate.
2:29 PM Changeset in webkit [37392] by andersca@apple.com
  • 3 edits in trunk/WebKitLibraries

2008-10-07 Anders Carlsson <​andersca@apple.com>

Reviewed by Mitz Pettel.

Update WebKitSystemInterface.


  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
2:27 PM Changeset in webkit [37391] by eric@webkit.org
  • 5 edits
    4 adds in trunk

Reviewed by Darin Adler, Nikolas Zimmermann and Dave Hyatt.

svgElement.className.baseValue = "foo" does not work
​https://bugs.webkit.org/show_bug.cgi?id=20651

  • dom/StyledElement.cpp: (WebCore::StyledElement::classAttributeChanged): (WebCore::StyledElement::parseMappedAttribute):
  • dom/StyledElement.h:
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::svgAttributeChanged):
2:22 PM Changeset in webkit [37390] by hyatt@apple.com
  • 2 edits in trunk/SunSpider

2008-10-07 David Hyatt <​hyatt@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=18989

Remove global substitution from SunSpider regexp test, since only Firefox was honoring it and
we want all browsers to be doing the same thing on the test.

Reviewed by Maciej

  • tests/regexp-dna.js:
2:08 PM Changeset in webkit [37389] by timothy@apple.com
  • 3 edits in trunk/WebCore

Add support to the Resources panel for queries like "#123", "foo #123",
"line: 123" and "foo line: 123". These will match the query limiting
the search only to the line specified. If only a line is specified,
the whole line is matched.

​https://bugs.webkit.org/show_bug.cgi?id=21422

Reviewed by Darin Adler.

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.sourceRow): Don't return the last row if the index is greater than the rows collection. Let it return undefined by indexing out-of-bounds.
  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.performSearch): Add support for queries like "#123", "foo #123", "line: 123" and "foo line: 123". Also match the whole query to the whole document in case there are colors like "#333".
1:49 PM Changeset in webkit [37388] by weinig@apple.com
  • 10 edits in trunk/JavaScriptCore

2008-10-07 Sam Weinig <​sam@webkit.org>

Reviewed by Cameron Zwarich.

Roll r37370 back in with bug fixes.

  • PropertyMap::storageSize() should reflect the number of keys + deletedOffsets and has nothing to do with the internal deletedSentinel count anymore.
1:32 PM Changeset in webkit [37387] by hyatt@apple.com
  • 4 edits in trunk/WebKit/mac

2008-10-07 David Hyatt <​hyatt@apple.com>

Move viewless WebKit methods that Safari needs from WebViewInternal to WebViewPrivate.

Reviewed by Tim Hatcher

  • WebView/WebView.mm: (WebKitInitializeApplicationCachePathIfNecessary): (-[WebView _registerDraggedTypes]): (-[WebView _usesDocumentViews]): (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): (-[WebView _initWithFrame:frameName:groupName:usesDocumentViews:]): (-[WebView isFlipped]): (-[WebView viewWillDraw]):
  • WebView/WebViewInternal.h:
  • WebView/WebViewPrivate.h:
1:27 PM Changeset in webkit [37386] by barraclough@apple.com
  • 7 edits in trunk/JavaScriptCore

2008-10-07 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Oliver Hunt.

Move callframe initialization into JIT code, again.


As a part of the restructuring the second result from functions is now
returned in edx, allowing the new value of 'r' to be returned via a
register, and stored to the stack from JIT code, too.

4.5% progression on v8-tests. (3% in their harness)

  • VM/CTI.cpp: (JSC::): (JSC::CTI::emitCall): (JSC::CTI::compileOpCall): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases): (JSC::CTI::privateCompile):
  • VM/CTI.h: (JSC::CallRecord::CallRecord):
  • VM/Machine.cpp: (JSC::Machine::cti_op_call_JSFunction): (JSC::Machine::cti_op_construct_JSConstruct): (JSC::Machine::cti_op_resolve_func): (JSC::Machine::cti_op_post_inc): (JSC::Machine::cti_op_resolve_with_base): (JSC::Machine::cti_op_post_dec):
  • VM/Machine.h:
  • kjs/JSFunction.h:
  • kjs/ScopeChain.h:
1:17 PM Changeset in webkit [37385] by hyatt@apple.com
  • 2 edits in trunk/WebKit/mac

2008-10-07 David Hyatt <​hyatt@apple.com>

Fix crash in isFlipped. Null check _private since isFlipped can get called from within AppKit
machinery during teardown of the WebView.

Reviewed by Adam Roben

  • WebView/WebView.mm: (-[WebView isFlipped]):
1:15 PM Changeset in webkit [37384] by hyatt@apple.com
  • 4 edits in trunk/WebKit/mac

2008-10-07 David Hyatt <​hyatt@apple.com>

Make viewless WebKit update focused and active state when the window becomes and loses key.
The focus controller has been patched to understand that in viewless mode it can recur down and
update all of the frames, which is why this code works now when placed just on the WebView.

Reviewed by Adam Roben

  • WebView/WebView.mm: (-[WebView addWindowObservers]): (-[WebView removeWindowObservers]): (-[WebView viewWillMoveToWindow:]): (-[WebView viewDidMoveToWindow]): (-[WebView _updateFocusedAndActiveState]): (-[WebView _windowDidBecomeKey:]): (-[WebView _windowDidResignKey:]): (-[WebView _windowWillOrderOnScreen:]):
12:35 PM Changeset in webkit [37383] by mrowe@apple.com
  • 3 edits in trunk/JavaScriptCore

Fix typo in method name.

11:28 AM Changeset in webkit [37382] by alp@webkit.org
  • 4 edits in trunk

2008-10-07 Alp Toker <​alp@nuanti.com>

Reviewed by Mark Rowe.

​https://bugs.webkit.org/show_bug.cgi?id=21392
[GTK] Auto-generate JS DOM binding sources list

Remove the huge lists of generated DOM binding sources and headers in
the build system. These are difficult to maintain and can be derived
automatically.

The new strategy is to re-use the existing lists of IDL sources (which
are needed for dist support anyway). This will also ease the addition
of new language bindings.

11:17 AM Changeset in webkit [37381] by cwzwarich@webkit.org
  • 10 edits in trunk/JavaScriptCore

2008-10-07 Cameron Zwarich <​zwarich@apple.com>

Rubber-stamped by Mark Rowe.

Roll out r37370.

10:30 AM Changeset in webkit [37380] by mrowe@apple.com
  • 6 edits
    4 adds in branches/Safari-3-2-branch

Merge r35415.

10:30 AM Changeset in webkit [37379] by mrowe@apple.com
  • 11 edits
    2 adds in branches/Safari-3-2-branch

Merge r35362.

10:27 AM Changeset in webkit [37378] by Darin Adler
  • 2 edits in trunk/WebKitSite

2008-10-07 Darin Adler <Darin Adler>

  • coding/RefPtr.html: Second draft.
9:30 AM Changeset in webkit [37377] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2008-10-07 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon.

Don't attempt to paint when updating control tints

We don't have a valid PlatformGraphicsContext so schedule
the dirty scrollbar/scrollview area for repaint instead.

4:20 AM Changeset in webkit [37376] by vestbo@webkit.org
  • 2 edits in trunk/WebKit/qt

2008-10-07 Tor Arne Vestbø <​tavestbo@trolltech.com>

QtWebKit build fix after changes to FrameLoaderClient.h in r37371

3:39 AM QtWebKitContrib edited by ariya.hidayat@trolltech.com
add irc nicks (diff)
3:36 AM QtWebKitJournal edited by ariya.hidayat@trolltech.com
(diff)
1:09 AM Changeset in webkit [37375] by hyatt@apple.com
  • 2 edits in trunk/WebKit/mac

2008-10-07 David Hyatt <​hyatt@apple.com>

Make sure the parent visibility state is set up properly on the outermost ScrollView widget.
This fixes the repainting issues with viewless WebKit on Mac.

Reviewed by Sam Weinig

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::transitionToCommittedForNewPage):
12:54 AM Changeset in webkit [37374] by zecke@webkit.org
  • 4 edits in trunk

[qt] Build fix after Scrollbar.h and Widget.h changes.

12:50 AM Changeset in webkit [37373] by hyatt@apple.com
  • 2 edits in trunk/WebKit/mac

2008-10-07 David Hyatt <​hyatt@apple.com>

Make sure viewless Mac WebKit does a layout if needed before drawing.

Reviewed by Sam Weinig

  • WebView/WebView.mm: (-[WebView viewWillDraw]):
12:47 AM Changeset in webkit [37372] by hyatt@apple.com
  • 3 edits in trunk/WebKit/mac

2008-10-07 David Hyatt <​hyatt@apple.com>

Make sure observers get hooked up to watch for size changes in viewless WebKit mode.

Reviewed by Sam Weinig

  • ChangeLog:
  • WebView/WebFrame.mm: (-[WebFrame _drawRect:contentsOnly:]):
  • WebView/WebView.mm: (-[WebView viewWillDraw]): (-[WebView _boundsChanged]): (-[WebView addSizeObservers]): (-[WebView viewDidMoveToWindow]): (-[WebView viewDidMoveToSuperview]):

Oct 6, 2008:

11:58 PM Changeset in webkit [37371] by hyatt@apple.com
  • 31 edits in trunk

WebCore:

2008-10-06 David Hyatt <​hyatt@apple.com>

Enable viewless Mac WebKit to (kinda sorta) paint basic pages (with no frames on them).

Reviewed by Sam Weinig

  • WebCore.base.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::hasWebView):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadWithDocumentLoader): (WebCore::FrameLoader::transitionToCommitted):
  • loader/FrameLoaderClient.h:
  • page/FocusController.cpp: (WebCore::FocusController::setActive):
  • page/FrameView.cpp: (WebCore::FrameView::FrameView): (WebCore::FrameView::init): (WebCore::FrameView::layoutIfNeededRecursive):
  • page/FrameView.h:

WebKit/gtk:

2008-10-06 David Hyatt <​hyatt@apple.com>

Enable viewless Mac WebKit to paint some basic pages.


Reviewed by Sam Weinig

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
  • WebCoreSupport/FrameLoaderClientGtk.h:

WebKit/mac:

2008-10-06 David Hyatt <​hyatt@apple.com>

Enable viewless Mac WebKit to paint some basic pages.


Reviewed by Sam Weinig

  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::windowResizerRect): (WebChromeClient::repaint): (WebChromeClient::screenToWindow): (WebChromeClient::windowToScreen): (WebChromeClient::platformWindow):
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::forceLayoutForNonHTML): (WebFrameLoaderClient::dispatchDidCommitLoad): (WebFrameLoaderClient::transitionToCommittedForNewPage): (WebFrameLoaderClient::createFrame):
  • WebView/WebFrame.mm: (-[WebFrame _drawRect:contentsOnly:]):
  • WebView/WebFrameInternal.h:
  • WebView/WebFrameView.mm:
  • WebView/WebFrameViewInternal.h:
  • WebView/WebHTMLView.mm: (-[WebHTMLView drawSingleRect:]): (-[WebHTMLView drawRect:]):
  • WebView/WebView.mm: (-[WebView isFlipped]): (-[WebView _boundsChanged]): (-[WebView _mustDrawUnionedRect:singleRects:count:]): (-[WebView drawSingleRect:]): (-[WebView drawRect:]): (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): (-[WebView initWithFrame:frameName:groupName:]): (-[WebView _initWithFrame:frameName:groupName:usesDocumentViews:]): (-[WebView initWithCoder:]): (-[WebView removeSizeObservers]): (-[WebView viewWillMoveToWindow:]): (-[WebView viewWillMoveToSuperview:]): (-[WebView _usesDocumentViews]):
  • WebView/WebViewInternal.h:

WebKit/qt:

2008-10-06 David Hyatt <​hyatt@apple.com>

Enable viewless Mac WebKit to paint some basic pages.


Reviewed by Sam Weinig

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::transitionToCommittedForNewPage):

WebKit/win:

2008-10-06 David Hyatt <​hyatt@apple.com>

Enable viewless Mac WebKit to paint some basic pages.


Reviewed by Sam Weinig

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createFrame):
  • WebCoreSupport/WebFrameLoaderClient.h:

WebKit/wx:

2008-10-06 David Hyatt <​hyatt@apple.com>

Enable viewless Mac WebKit to paint some basic pages.


Reviewed by Sam Weinig

  • WebKitSupport/FrameLoaderClientWx.cpp:
  • WebKitSupport/FrameLoaderClientWx.h:
10:43 PM Changeset in webkit [37370] by weinig@apple.com
  • 10 edits in trunk/JavaScriptCore

2008-10-06 Sam Weinig <​sam@webkit.org>

Reviewed by Cameron Zwarich.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=21415
Improve the division between PropertyStorageArray and PropertyMap

  • Rework ProperyMap to store offsets in the value so that they don't change when rehashing. This allows us not to have to keep the PropertyStorageArray in sync and thus not have to pass it in.
  • Rename PropertyMap::getOffset -> PropertyMap::get since put/remove now also return offsets.
  • A Vector of deleted offsets is now needed since the storage is out of band.

1% win on SunSpider. Wash on V8 suite.

  • JavaScriptCore.exp:
  • VM/CTI.cpp: (JSC::transitionWillNeedStorageRealloc):
  • VM/Machine.cpp: (JSC::Machine::privateExecute): Transition logic can be greatly simplified by the fact that the storage capacity is always known, and is correct for the inline case.
  • kjs/JSObject.cpp: (JSC::JSObject::put): Rename getOffset -> get. (JSC::JSObject::deleteProperty): Ditto. (JSC::JSObject::getPropertyAttributes): Ditto. (JSC::JSObject::removeDirect): Use returned offset to clear the value in the PropertyNameArray. (JSC::JSObject::allocatePropertyStorage): Add assert.
  • kjs/JSObject.h: (JSC::JSObject::getDirect): Rename getOffset -> get (JSC::JSObject::getDirectLocation): Rename getOffset -> get (JSC::JSObject::putDirect): Use propertyStorageCapacity to determine whether or not to resize. Also, since put now returns an offset (and thus addPropertyTransition does also) setting of the PropertyStorageArray is now done here. (JSC::JSObject::transitionTo):
  • kjs/PropertyMap.cpp: (JSC::PropertyMap::checkConsistency): PropertyStorageArray is no longer passed in. (JSC::PropertyMap::operator=): Copy the delete offsets vector. (JSC::PropertyMap::put): Instead of setting the PropertyNameArray explicitly, return the offset where the value should go. (JSC::PropertyMap::remove): Instead of removing from the PropertyNameArray explicitly, return the offset where the value should be removed. (JSC::PropertyMap::get): Switch to using the stored offset, instead of the implicit one. (JSC::PropertyMap::insert): (JSC::PropertyMap::expand): This is never called when m_table is null, so remove that branch and add it as an assertion. (JSC::PropertyMap::createTable): Consistency checks no longer take a PropertyNameArray. (JSC::PropertyMap::rehash): No need to rehash the PropertyNameArray now that it is completely out of band.
  • kjs/PropertyMap.h: (JSC::PropertyMapEntry::PropertyMapEntry): Store offset into PropertyNameArray. (JSC::PropertyMap::get): Switch to using the stored offset, instead of the implicit one.
  • kjs/StructureID.cpp: (JSC::StructureID::StructureID): Initialize the propertyStorageCapacity to JSObject::inlineStorageCapacity. (JSC::StructureID::growPropertyStorageCapacity): Grow the storage capacity as described below. (JSC::StructureID::addPropertyTransition): Copy the storage capacity. (JSC::StructureID::toDictionaryTransition): Ditto. (JSC::StructureID::changePrototypeTransition): Ditto. (JSC::StructureID::getterSetterTransition): Ditto.
  • kjs/StructureID.h: (JSC::StructureID::propertyStorageCapacity): Add propertyStorageCapacity which is the current capacity for the JSObjects PropertyStorageArray. It starts at the JSObject::inlineStorageCapacity (currently 2), then when it first needs to be resized moves to the JSObject::nonInlineBaseStorageCapacity (currently 16), and after that doubles each time.
9:42 PM Changeset in webkit [37369] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • build fix
  • bindings/objc/DOMEvents.h:
9:16 PM Changeset in webkit [37368] by mrowe@apple.com
  • 4 edits
    3 adds in branches/Safari-3-2-branch

Merge r33567.

9:16 PM Changeset in webkit [37367] by mrowe@apple.com
  • 3 edits
    2 adds in branches/Safari-3-2-branch/WebCore

Merge r36108.

8:53 PM Changeset in webkit [37366] by cwzwarich@webkit.org
  • 8 edits in trunk/JavaScriptCore

2008-10-06 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Oliver Hunt.

Bug 21396: Remove the OptionalCalleeActivation call frame slot
<​https://bugs.webkit.org/show_bug.cgi?id=21396>

Remove the OptionalCalleeActivation call frame slot. We have to be
careful to store the activation object in a register, because objects
in the scope chain do not get marked.

This is a 0.3% speedup on both SunSpider and the V8 benchmark.

  • VM/CTI.cpp: (JSC::CTI::privateCompileMainPass):
  • VM/CodeBlock.cpp: (JSC::CodeBlock::dump):
  • VM/CodeGenerator.cpp: (JSC::CodeGenerator::CodeGenerator): (JSC::CodeGenerator::emitReturn):
  • VM/CodeGenerator.h:
  • VM/Machine.cpp: (JSC::Machine::dumpRegisters): (JSC::Machine::unwindCallFrame): (JSC::Machine::privateExecute): (JSC::Machine::cti_op_call_JSFunction): (JSC::Machine::cti_op_push_activation): (JSC::Machine::cti_op_tear_off_activation): (JSC::Machine::cti_op_construct_JSConstruct):
  • VM/Machine.h: (JSC::Machine::initializeCallFrame):
  • VM/RegisterFile.h: (JSC::RegisterFile::):
7:15 PM Changeset in webkit [37365] by mrowe@apple.com
  • 2 edits in branches/Safari-3-2-branch/WebKit/mac/Misc

Merge _webkit_localCacheDirectoryWithBundleIdentifier:.

6:21 PM Changeset in webkit [37364] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-10-06 Tony Chang <​tony@chromium.org>

Reviewed by Alexey Proskuryakov.

Chromium doesn't use pthreads on windows, so make its use conditional.

Also convert a WORD to a DWORD to avoid a compiler warning. This
matches the other methods around it.

  • wtf/ThreadingWin.cpp: (WTF::wtfThreadEntryPoint): (WTF::ThreadCondition::broadcast):
6:15 PM Changeset in webkit [37363] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-10-06 Mark Mentovai <​mark@moxienet.com>

Reviewed by Tim Hatcher.

Allow ENABLE_DASHBOARD_SUPPORT and ENABLE_MAC_JAVA_BRIDGE to be
disabled on the Mac.

​https://bugs.webkit.org/show_bug.cgi?id=21333

  • wtf/Platform.h:
6:14 PM Changeset in webkit [37362] by eric@webkit.org
  • 6 edits in trunk/WebCore

2008-10-06 Mark Mentovai <​mark@moxienet.com>

Reviewed by Tim Hatcher.

Use #if ENABLE(feature) where possible, and #if ENABLE_feature where
Platform.h is not available, in preference to #ifdef ENABLE_feature.
#ifdef is wrong now that features are disabled by #defining
ENABLE_feature to 0.

​https://bugs.webkit.org/show_bug.cgi?id=21338

  • bindings/objc/DOMEvents.h:
  • bindings/objc/PublicDOMInterfaces.h:
  • dom/Document.idl:
  • page/DOMWindow.idl:
  • svg/svgtags.in:
6:11 PM Changeset in webkit [37361] by eric@webkit.org
  • 2 edits in trunk/WebCore

2008-10-06 Mark Mentovai <​mark@moxienet.com>

Reviewed by Sam Weinig.

  • platform/network/mac/FormDataStreamMac.mm: #import <wtf/Threading.h> to get the declaration for isMainThread().
6:10 PM Changeset in webkit [37360] by mrowe@apple.com
  • 2 edits in branches/Safari-3-2-branch/WebCore

Merge r36811.

6:10 PM Changeset in webkit [37359] by mrowe@apple.com
  • 7 edits
    2 adds in branches/Safari-3-2-branch

Merge r37008.

6:09 PM Changeset in webkit [37358] by eric@webkit.org
  • 2 edits
    1 move in trunk/WebCore

2008-10-06 Jeremy Moskovich <​jeremy@chromium.org>

Reviewed by Tim Hatcher.

WebCoreObjCExtras.c is actually an obj-c++ file, so change its name
to reflect that.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/mac/WebCoreObjCExtras.c: Removed.
  • platform/mac/WebCoreObjCExtras.mm: Copied from WebCore/platform/mac/WebCoreObjCExtras.c.
6:05 PM Changeset in webkit [37357] by eric@webkit.org
  • 2 edits in trunk/WebCore

2008-10-06 Jeremy Moskovich <​jeremy@chromium.org>

Reviewed by Dan Bernstein.

Added C++ forward declaration for the NSURLAuthenticationChallenge class
so that the m_currentMacChallenge variable doesn't cause a
compilation error when ResourceHandleInternal.h is included from a C++ file.
Fixes: ​https://bugs.webkit.org/show_bug.cgi?id=21411

  • platform/network/ResourceHandleInternal.h:
5:38 PM Changeset in webkit [37356] by mrowe@apple.com
  • 3 edits
    3 adds in branches/Safari-3-2-branch

Merge r36810.

5:38 PM Changeset in webkit [37355] by mrowe@apple.com
  • 4 edits
    3 adds in branches/Safari-3-2-branch

Merge r33972.

5:17 PM Changeset in webkit [37354] by sfalken@apple.com
  • 2 edits in trunk/WebCore

Windows build fix.

4:47 PM Changeset in webkit [37353] by sfalken@apple.com
  • 4 edits in trunk

JavaScriptCore:

​https://bugs.webkit.org/show_bug.cgi?id=21416
Pass 0 for size to VirtualAlloc, as documented by MSDN.
Identified by Application Verifier.


Reviewed by Darin Adler.

  • kjs/collector.cpp: (KJS::freeBlock):

WebCore:

​https://bugs.webkit.org/show_bug.cgi?id=21416
Add missing null checks identified by Application Verifier.


Reviewed by Darin Adler.

  • platform/win/SharedTimerWin.cpp: (WebCore::clearTimer):
4:15 PM Changeset in webkit [37352] by kmccullough@apple.com
  • 2 edits in trunk/WebCore

2008-10-06 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Tim Hatcher.

Removed accidentally left in debugging statement.

  • inspector/front-end/inspector.js:
4:10 PM Changeset in webkit [37351] by kmccullough@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

2008-10-06 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Tim Hatcher and Oliver Hunt.

​https://bugs.webkit.org/show_bug.cgi?id=21412
Bug 21412: Refactor user initiated profile count to be more stable

  • inspector/InspectorController.cpp: Keep track of the user-initiated profiles here now. (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::startUserInitiatedProfiling): (WebCore::InspectorController::stopUserInitiatedProfiling):
  • inspector/InspectorController.h: The front end will now need to check for the existence of the user- initiated profile title and use its count instead of keeping its own.
  • inspector/front-end/ProfilesPanel.js:
4:09 PM Changeset in webkit [37350] by kmccullough@apple.com
  • 1 edit in trunk/JavaScriptCore/ChangeLog

2008-10-06 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Tim Hatcheri and Oliver Hunt.

​https://bugs.webkit.org/show_bug.cgi?id=21412
Bug 21412: Refactor user initiated profile count to be more stable

  • Export UString::from for use with creating the profile title.
4:08 PM Changeset in webkit [37349] by kmccullough@apple.com
  • 6 edits in trunk

JavaScriptCore:

2008-10-06 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Tim Hatcher.

​https://bugs.webkit.org/show_bug.cgi?id=21412
Bug 21412: Refactor user initiated profile count to be more stable

  • Export UString::from for use with creating the profile title.

WebCore:

2008-10-06 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Tim Hatcher.

​https://bugs.webkit.org/show_bug.cgi?id=21412
Bug 21412: Refactor user initiated profile count to be more stable

  • inspector/InspectorController.cpp: Keep track of the user-initiated profiles here now. (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::startUserInitiatedProfiling): (WebCore::InspectorController::stopUserInitiatedProfiling):
  • inspector/InspectorController.h: The front end will now need to check for the existence of the user- initiated profile title and use its count instead of keeping its own.
  • inspector/front-end/ProfilesPanel.js:
3:41 PM Changeset in webkit [37348] by kdecker@apple.com
  • 5 edits in trunk/WebKit/mac

Rubber-stamped by Anders Carlsson.

Rename _webkit_applicationCacheDirectoryWithBundleIdentifier to _webkit_localCacheDirectoryWithBundleIdentifier.


  • Misc/WebKitNSStringExtras.h:
  • Misc/WebKitNSStringExtras.m: (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]):
  • WebView/WebDataSource.mm: (-[WebDataSource _transferApplicationCache:]):
  • WebView/WebView.mm: (WebKitInitializeApplicationCachePathIfNecessary):
3:22 PM Changeset in webkit [37347] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2008-10-06 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Make WebNetscapePluginStream a WebCore::NetscapePlugInStreamLoaderClient.


  • Plugins/WebBaseNetscapePluginStream.h: (WebNetscapePluginStream::~WebNetscapePluginStream):
  • Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::didReceiveResponse): (-[WebBaseNetscapePluginStream startStreamWithResponse:]): (WebNetscapePluginStream::wantsAllStreams): (-[WebBaseNetscapePluginStream wantsAllStreams]): (WebNetscapePluginStream::didFail): (-[WebBaseNetscapePluginStream destroyStreamWithError:]): (WebNetscapePluginStream::didFinishLoading): (-[WebBaseNetscapePluginStream finishedLoading]): (WebNetscapePluginStream::didReceiveData): (-[WebBaseNetscapePluginStream receivedData:]):
2:56 PM Changeset in webkit [37346] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2008-10-06 Anders Carlsson <​andersca@apple.com>

Bring back the stop method. It was called through performSelector, which
is why I couldn't find any references to it.

  • Plugins/WebBaseNetscapePluginStream.h:
  • Plugins/WebBaseNetscapePluginStream.mm: (-[WebBaseNetscapePluginStream stop]):
2:28 PM Changeset in webkit [37345] by andersca@apple.com
  • 4 edits in trunk/WebKit/mac

2008-10-06 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

More conversion and cleanup.


  • Plugins/WebBaseNetscapePluginStream.h:
  • Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::startStream): (-[WebBaseNetscapePluginStream startStreamWithResponse:]):
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]):
2:05 PM Changeset in webkit [37344] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2008-10-06 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Fold initWithRequestURL into initWithRequest.


  • Plugins/WebBaseNetscapePluginStream.h:
  • Plugins/WebBaseNetscapePluginStream.mm: (-[WebBaseNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]):
1:57 PM Changeset in webkit [37343] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2008-10-06 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Change the init methods not to return nil on failures. (These failures never occur anyway)


Use initWithRequest as the initializer, initWithRequestURL is going to be merged with it.


  • Plugins/WebBaseNetscapePluginStream.mm: (-[WebBaseNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]): (-[WebBaseNetscapePluginStream initWithRequestURL:plugin:notifyData:sendNotification:]):
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]):
1:34 PM Changeset in webkit [37342] by andersca@apple.com
  • 4 edits in trunk/WebKit/mac

2008-10-06 Anders Carlsson <​andersca@apple.com>

Reviewed by David Hyatt.

Convert more methods over to C++.


  • Plugins/WebBaseNetscapePluginStream.h:
  • Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::ownerForStream): (WebNetscapePluginStream::pluginCancelledConnectionError): (WebNetscapePluginStream::errorForReason): (-[WebBaseNetscapePluginStream errorForReason:]): (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:headers:]): (WebNetscapePluginStream::cancelLoadAndDestroyStreamWithError): (-[WebBaseNetscapePluginStream cancelLoadAndDestroyStreamWithError:]): (WebNetscapePluginStream::deliverData): (WebNetscapePluginStream::deliverDataTimerFired): (WebNetscapePluginStream::deliverDataToFile): (-[WebBaseNetscapePluginStream finishedLoading]): (-[WebBaseNetscapePluginStream receivedData:]):
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView destroyStream:reason:]):
1:25 PM Changeset in webkit [37341] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Sam Weinig.

  • separate GDI text drawing into its own function
  • platform/graphics/win/FontCGWin.cpp: (WebCore::drawGDIGlyphs): (WebCore::Font::drawGlyphs):
1:13 PM Changeset in webkit [37340] by hyatt@apple.com
  • 3 edits in trunk/WebKit/mac

2008-10-06 David Hyatt <​hyatt@apple.com>

Add SPI for a new viewless WebKit mode. The idea is that when this flag is set there will be no
views created except for the outermost WebView.

Reviewed by Tim Hatcher

  • WebView/WebView.mm:
  • WebView/WebViewInternal.h:
1:02 PM Changeset in webkit [37339] by andersca@apple.com
  • 4 edits in trunk/WebKit/mac

2008-10-06 Anders Carlsson <​andersca@apple.com>

Reviewed by David Hyatt.

Convert more methods over to C++.


  • Plugins/WebBaseNetscapePluginStream.h:
  • Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::reasonForError): (WebNetscapePluginStream::destroyStreamWithReason): (WebNetscapePluginStream::cancelLoadWithError): (-[WebBaseNetscapePluginStream cancelLoadWithError:]): (WebNetscapePluginStream::destroyStreamWithError): (-[WebBaseNetscapePluginStream destroyStreamWithError:]): (-[WebBaseNetscapePluginStream cancelLoadAndDestroyStreamWithError:]): (-[WebBaseNetscapePluginStream _deliverDataToFile:]): (-[WebBaseNetscapePluginStream finishedLoading]):
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView webFrame:didFinishLoadWithError:]):
12:55 PM Changeset in webkit [37338] by sfalken@apple.com
  • 3 edits in trunk/WebCore

<rdar://problem/6249833> Fix default button appearance


Reviewed by Adele Peterson.

  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::supportsFocus): (WebCore::RenderThemeWin::determineClassicState): (WebCore::RenderThemeWin::determineButtonState): (WebCore::RenderThemeWin::getClassicThemeData): (WebCore::RenderThemeWin::getThemeData): (WebCore::drawControl):
  • rendering/RenderThemeWin.h:
11:31 AM Changeset in webkit [37337] by mjs@apple.com
  • 21 edits in trunk

JavaScriptCore:

2008-10-06 Maciej Stachowiak <​mjs@apple.com>

Not reviewed. Build fix.


  • revert toBoolean changes (r37333 and r37335); need to make WebCore work with these
  • API/JSValueRef.cpp: (JSValueToBoolean):
  • ChangeLog:
  • JavaScriptCore.exp:
  • VM/CodeBlock.cpp: (JSC::CodeBlock::dump):
  • VM/Machine.cpp: (JSC::Machine::privateExecute): (JSC::Machine::cti_op_loop_if_true): (JSC::Machine::cti_op_not): (JSC::Machine::cti_op_jtrue):
  • kjs/ArrayPrototype.cpp: (JSC::arrayProtoFuncFilter): (JSC::arrayProtoFuncEvery): (JSC::arrayProtoFuncSome):
  • kjs/BooleanConstructor.cpp: (JSC::constructBoolean): (JSC::callBooleanConstructor):
  • kjs/GetterSetter.h:
  • kjs/JSCell.h: (JSC::JSValue::toBoolean):
  • kjs/JSNumberCell.cpp: (JSC::JSNumberCell::toBoolean):
  • kjs/JSNumberCell.h:
  • kjs/JSObject.cpp: (JSC::JSObject::toBoolean):
  • kjs/JSObject.h:
  • kjs/JSString.cpp: (JSC::JSString::toBoolean):
  • kjs/JSString.h:
  • kjs/JSValue.h:
  • kjs/RegExpConstructor.cpp: (JSC::setRegExpConstructorMultiline):
  • kjs/RegExpObject.cpp: (JSC::RegExpObject::match):
  • kjs/RegExpPrototype.cpp: (JSC::regExpProtoFuncToString):

JavaScriptGlue:

2008-10-06 Maciej Stachowiak <​mjs@apple.com>

Not reviewed. Build fix.

  • revert toBoolean changes (r37333 and r37335); need to make WebCore work with these
  • JSUtils.cpp: (KJSValueToCFTypeInternal):
11:19 AM Changeset in webkit [37336] by mjs@apple.com
  • 2 edits in trunk/JavaScriptGlue

2008-10-06 Maciej Stachowiak <​mjs@apple.com>

Not reviewed.


  • fix build; toBoolean no longer takes an ExecState
  • JSUtils.cpp: (KJSValueToCFTypeInternal):
11:11 AM Changeset in webkit [37335] by vestbo@webkit.org
  • 7 edits in trunk/WebCore

2008-10-06 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon.

Add native virtual keycode to PlatformKeyboardEvent

10:51 AM Changeset in webkit [37334] by vestbo@webkit.org
  • 5 edits in trunk/WebCore

2008-10-06 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon.

Enable WebCore::String <> CFStringRef conversion functions for QtWebKit/Mac

10:50 AM Changeset in webkit [37333] by mjs@apple.com
  • 19 edits in trunk/JavaScriptCore

2008-10-06 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Sam Weinig.



1) Make JSValue::toBoolean nonvirtual and completely inline by
making use of the StructureID type field.


2) Make JSValue::toBoolean not take an ExecState; doesn't need it.


3) Make op_not, op_loop_if_true and op_jtrue not read the
ExecState (toBoolean doesn't need it any more) and not check
exceptions (toBoolean can't throw).

  • API/JSValueRef.cpp: (JSValueToBoolean):
  • JavaScriptCore.exp:
  • VM/CodeBlock.cpp: (JSC::CodeBlock::dump):
  • VM/Machine.cpp: (JSC::Machine::privateExecute): (JSC::Machine::cti_op_loop_if_true): (JSC::Machine::cti_op_not): (JSC::Machine::cti_op_jtrue):
  • kjs/ArrayPrototype.cpp: (JSC::arrayProtoFuncFilter): (JSC::arrayProtoFuncEvery): (JSC::arrayProtoFuncSome):
  • kjs/BooleanConstructor.cpp: (JSC::constructBoolean): (JSC::callBooleanConstructor):
  • kjs/GetterSetter.h:
  • kjs/JSCell.h: (JSC::JSValue::toBoolean):
  • kjs/JSNumberCell.cpp:
  • kjs/JSNumberCell.h: (JSC::JSNumberCell::toBoolean):
  • kjs/JSObject.cpp:
  • kjs/JSObject.h: (JSC::JSObject::toBoolean): (JSC::JSCell::toBoolean):
  • kjs/JSString.cpp:
  • kjs/JSString.h: (JSC::JSString::toBoolean):
  • kjs/JSValue.h:
  • kjs/RegExpConstructor.cpp: (JSC::setRegExpConstructorMultiline):
  • kjs/RegExpObject.cpp: (JSC::RegExpObject::match):
  • kjs/RegExpPrototype.cpp: (JSC::regExpProtoFuncToString):
10:46 AM Changeset in webkit [37332] by vestbo@webkit.org
  • 3 edits in trunk/WebCore

2008-10-06 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon.

Use bundles on QtWebKit/Mac for platform modules

10:00 AM Changeset in webkit [37331] by Simon Hausmann
  • 6 edits in trunk

2008-10-06 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Reviewed by Simon.

Build fix for MinGW.

  • platform/win/SystemTimeWin.cpp:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginView::invalidateRect):

2008-10-06 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Reviewed by Simon.

Build fix for MinGW.

8:44 AM Changeset in webkit [37330] by Adam Roben
  • 2 edits in trunk/WebCore

Mimic the inspector/ directory structure in WebCore.vcproj

  • WebCore.vcproj/WebCore.vcproj:
8:39 AM Changeset in webkit [37329] by Adam Roben
  • 2 edits in trunk/WebCore

Windows build fix

  • WebCore.vcproj/WebCore.vcproj: Update the Include path for all configurations to include WebCore/inspector.
1:23 AM Changeset in webkit [37328] by eric@webkit.org
  • 938 edits in trunk

Reviewed by Darin Adler.

SVG should support ascent and descent properties <font-face> instead of <font>!
​https://bugs.webkit.org/show_bug.cgi?id=21365

Tested by many many existing SVG tests.

  • svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::ascent): (WebCore::SVGFontFaceElement::descent):
Note: See TracTimeline for information about the timeline view.