⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 9, 2008:

11:39 PM Changeset in webkit [37474] by timothy@apple.com
  • 3 edits in trunk/WebKit/mac

Another build fix.

11:12 PM Changeset in webkit [37473] by timothy@apple.com
  • 3 edits in trunk

Full build fix for the fail on Tiger.

10:56 PM Changeset in webkit [37472] by hyatt@apple.com
  • 8 edits
    4 adds in trunk

WebCore:

2008-10-09 David Hyatt <​hyatt@apple.com>

Add support for pseudo classes on scrollbar pseudo elements. As an initial proof of concept only
:enabled/:disabled are supported. More pseudo classes will follow quickly now that this works.

Reviewed by Tim Hatcher

Added scrollbars/disabled-scrollbar.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkSelector): (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
  • css/CSSStyleSelector.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::getPseudoStyle):
  • rendering/RenderObject.h:
  • rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::setEnabled): (WebCore::RenderScrollbar::scrollbarForStyleResolve): (WebCore::RenderScrollbar::getScrollbarPseudoStyle): (WebCore::RenderScrollbar::paintPart):
  • rendering/RenderScrollbar.h:

LayoutTests:

2008-10-09 David Hyatt <​hyatt@apple.com>

Add test case for disabled scrollbars.

Reviewed by Tim Hatcher

  • platform/mac/scrollbars/disabled-scrollbar-expected.checksum: Added.
  • platform/mac/scrollbars/disabled-scrollbar-expected.png: Added.
  • platform/mac/scrollbars/disabled-scrollbar-expected.txt: Added.
  • scrollbars/disabled-scrollbar.html: Added.
9:34 PM Changeset in webkit [37471] by timothy@apple.com
  • 2 edits in trunk

Tiger build fix.

9:04 PM Changeset in webkit [37470] by eric.carlson@apple.com
  • 5 edits in trunk/WebCore

2008-10-09 Eric Carlson <​eric.carlson@apple.com>

Media controls should not show when element is not visible

​https://bugs.webkit.org/show_bug.cgi?id=21155


Reviewed by Adele Peterson.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::recalcStyle): New, call renderer()->updateFromElement to stay in sync with visibility changes
  • html/HTMLMediaElement.h:
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::RenderMedia): initialize m_previousVisible (WebCore::RenderMedia::updateControlVisibility): consider style()->visibility() when determining if element is visible or not. Don't animate controller visibility when change triggered by showing or hiding media element.
  • rendering/RenderMedia.h: declare m_previousVisible
8:42 PM Changeset in webkit [37469] by hyatt@apple.com
  • 1 edit in trunk/WebCore/GNUmakefile.am

Fix Gtk bustage.

8:41 PM Changeset in webkit [37468] by hyatt@apple.com
  • 1 edit in trunk/WebCore/WebCore.pro

Fix Qt bustage.

8:37 PM Changeset in webkit [37467] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/win/ScrollbarThemeWin.cpp

Fix Windows bustage.

8:25 PM Changeset in webkit [37466] by hyatt@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fix typo in my Changelog comment

8:23 PM Changeset in webkit [37465] by timothy@apple.com
  • 15 edits in trunk

Annotate the Objective-C DOM APIs with the JavaScriptCore/WebKitAvailability.h availability macros and version macros.

WebCore:

2008-10-09 Timothy Hatcher <​timothy@apple.com>

Annotate the Objective-C DOM APIs with the JavaScriptCore/WebKitAvailability.h
availability macros and version macros.

​https://bugs.webkit.org/show_bug.cgi?id=21496
rdar://problem/6259225

Reviewed by Sam Weinig.

  • bindings/objc/DOMCSS.h: Add a version #if around catgory interface.
  • bindings/objc/DOMEventException.h: Include JavaScriptCore/WebKitAvailability.h and add an #if around the enum.
  • bindings/objc/DOMException.h: Ditto. Give the enum a name and remove the comment to match the other headers.
  • bindings/objc/DOMExtensions.h: Annotate the methods with version 3.0 or later.
  • bindings/objc/DOMObject.h: Add a version #if around class interface.
  • bindings/objc/DOMRangeException.h: Include JavaScriptCore/WebKitAvailability.h and add a version #if around the enum.
  • bindings/objc/DOMSVGException.h: Ditto. Use the latest version since SVG is new.
  • bindings/objc/DOMXPathException.h: Ditto. Use the 3.0 version.
  • bindings/objc/PublicDOMInterfaces.h: Annotate classes and protocols for when they where added to WebKit. Also annotate individual methods that are deprecated or where added after the class was added to WebKit.
  • bindings/objc/WebScriptObject.h: Include JavaScriptCore/WebKitAvailability.h since this header is included by most DOM headers. Annotate the JSObject method.
  • bindings/scripts/CodeGeneratorObjC.pm: (ReadPublicInterfaces): Parse out the availability macro for each function/property. And parse out the availability version for the class/protocol. Default to WEBKIT_VERSION_LATEST if the class is new. (GenerateHeader): Include JavaScriptCore/WebKitAvailability.h if needed. Add the interface availability version check if the class has a required version. Create a public interface key (used to lookup in $publicInterfaces) and make a declaration suffix that includes the availability macro (if needed). Use the "available in 1.3 and later but deprecated in 3.0" macro instead of "deprecated in 10.5 and later" as the default availability macro for old style methods. Tweak line breaks in the generated headers to look good and not have too many extra lines.

WebKit/mac:

2008-10-09 Timothy Hatcher <​timothy@apple.com>

Don't convert JavaScriptCore header include paths to WebKit paths. This was needed
back when NPAPI and WebScriptObject migrated from JavaScriptCore. Also remove
JavaScriptCore from the VPATH.

Reviewed by Sam Weinig.

  • MigrateHeaders.make:
8:15 PM Changeset in webkit [37464] by Simon Fraser
  • 47 edits in trunk/WebCore

2008-10-09 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

​https://bugs.webkit.org/show_bug.cgi?id=20947

Refactor setStyle() methods into styleWillChange()
and styleDidChange(), so most of the setStyle() overrides can
be removed.

8:13 PM Changeset in webkit [37463] by hyatt@apple.com
  • 3 edits in trunk/WebCore

2008-10-09 David Hyatt <​hyatt@apple.com>

Make sure to destroy a custom scrollbar's RenderObject's before the arena goes away. When our widget
parent is nulled out is a good time.

Reviewed by Oliver Hunt

  • rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::~RenderScrollbar): (WebCore::RenderScrollbar::setParent): (WebCore::RenderScrollbar::updateScrollbarPart):
  • rendering/RenderScrollbar.h:
7:33 PM Changeset in webkit [37462] by hyatt@apple.com
  • 19 edits
    12 adds in trunk

WebCore:

2008-10-09 David Hyatt <​hyatt@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=21446

This patch gets CSS scrollbars up and limping. There's no way to distinguish between states or between
orientation and back vs. forward on the buttons, but it's a start.

Reviewed by Oliver Hunt

Added scrollbars/basic-scrollbar.html

  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
  • platform/ScrollTypes.h: (WebCore::):
  • platform/Scrollbar.h: (WebCore::Scrollbar::styleChanged):
  • platform/ScrollbarThemeComposite.cpp: (WebCore::ScrollbarThemeComposite::paint): (WebCore::ScrollbarThemeComposite::splitTrack):
  • platform/ScrollbarThemeComposite.h: (WebCore::ScrollbarThemeComposite::paintScrollbarBackground): (WebCore::ScrollbarThemeComposite::paintTrackBackground): (WebCore::ScrollbarThemeComposite::paintTrackPiece):
  • platform/win/ScrollbarThemeSafari.cpp: (WebCore::ScrollbarThemeSafari::paintTrackBackground):
  • platform/win/ScrollbarThemeSafari.h:
  • platform/win/ScrollbarThemeWin.cpp: (WebCore::ScrollbarThemeWin::paintTrack):
  • platform/win/ScrollbarThemeWin.h:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::createScrollbar): (WebCore::RenderLayer::styleChanged):
  • rendering/RenderScrollbar.cpp: Added. (WebCore::RenderScrollbar::createCustomScrollbar): (WebCore::RenderScrollbar::RenderScrollbar): (WebCore::RenderScrollbar::~RenderScrollbar): (WebCore::RenderScrollbar::getScrollbarPseudoStyle): (WebCore::RenderScrollbar::updateScrollbarParts): (WebCore::RenderScrollbar::updateScrollbarPart): (WebCore::RenderScrollbar::paintPart): (WebCore::RenderScrollbar::buttonRect): (WebCore::RenderScrollbar::minimumThumbLength):
  • rendering/RenderScrollbar.h: Added. (WebCore::RenderScrollbar::styleChanged): (WebCore::RenderScrollbar::owningRenderer):
  • rendering/RenderScrollbarPart.cpp: Added. (WebCore::RenderScrollbarPart::RenderScrollbarPart): (WebCore::RenderScrollbarPart::~RenderScrollbarPart): (WebCore::RenderScrollbarPart::layout): (WebCore::RenderScrollbarPart::layoutHorizontalPart): (WebCore::RenderScrollbarPart::layoutVerticalPart): (WebCore::calcScrollbarThicknessUsing): (WebCore::RenderScrollbarPart::computeScrollbarWidth): (WebCore::RenderScrollbarPart::computeScrollbarHeight): (WebCore::RenderScrollbarPart::calcPrefWidths): (WebCore::RenderScrollbarPart::setStyle):
  • rendering/RenderScrollbarPart.h: Added. (WebCore::RenderScrollbarPart::renderName): (WebCore::RenderScrollbarPart::requiresLayer):
  • rendering/RenderScrollbarTheme.cpp: Added. (WebCore::RenderScrollbarTheme::renderScrollbarTheme): (WebCore::RenderScrollbarTheme::buttonSizesAlongTrackAxis): (WebCore::RenderScrollbarTheme::hasButtons): (WebCore::RenderScrollbarTheme::hasThumb): (WebCore::RenderScrollbarTheme::minimumThumbLength): (WebCore::RenderScrollbarTheme::backButtonRect): (WebCore::RenderScrollbarTheme::forwardButtonRect): (WebCore::RenderScrollbarTheme::trackRect): (WebCore::RenderScrollbarTheme::paintScrollCorner): (WebCore::RenderScrollbarTheme::paintScrollbarBackground): (WebCore::RenderScrollbarTheme::paintTrackBackground): (WebCore::RenderScrollbarTheme::paintTrackPiece): (WebCore::RenderScrollbarTheme::paintButton): (WebCore::RenderScrollbarTheme::paintThumb):
  • rendering/RenderScrollbarTheme.h: Added. (WebCore::RenderScrollbarTheme::~RenderScrollbarTheme): (WebCore::RenderScrollbarTheme::scrollbarThickness): (WebCore::RenderScrollbarTheme::buttonsPlacement): (WebCore::RenderScrollbarTheme::supportsControlTints): (WebCore::RenderScrollbarTheme::shouldCenterOnThumb): (WebCore::RenderScrollbarTheme::initialAutoscrollTimerDelay): (WebCore::RenderScrollbarTheme::autoscrollTimerDelay): (WebCore::RenderScrollbarTheme::registerScrollbar): (WebCore::RenderScrollbarTheme::unregisterScrollbar):
  • rendering/style/RenderStyle.h: (WebCore::RenderStyle::):

LayoutTests:

2008-10-09 David Hyatt <​hyatt@apple.com>

Land layout test for CSS scrollbars.

Reviewed by Oliver Hunt

  • platform/mac/scrollbars: Added.
  • platform/mac/scrollbars/basic-scrollbar-expected.checksum: Added.
  • platform/mac/scrollbars/basic-scrollbar-expected.png: Added.
  • platform/mac/scrollbars/basic-scrollbar-expected.txt: Added.
  • scrollbars: Added.
  • scrollbars/basic-scrollbar.html: Added.
7:27 PM Changeset in webkit [37461] by eric@webkit.org
  • 3 edits
    7 adds in trunk

Reviewed by Oliver Hunt.

Test cases for ​https://bugs.webkit.org/show_bug.cgi?id=21498

  • fast/canvas/gradient-with-clip-expected.txt: Added.
  • fast/canvas/gradient-with-clip.html: Added.
  • fast/canvas/pattern-with-transform-expected.txt: Added.
  • fast/canvas/pattern-with-transform.html: Added.
  • fast/canvas/resources/TEMPLATE.html: Copied from LayoutTests/fast/dom/resources/TEMPLATE.html.
  • fast/canvas/resources/gradient-with-clip.js: Added.
  • fast/canvas/resources/pattern-with-transform.js: Added.
7:26 PM Changeset in webkit [37460] by eric@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Oliver Hunt.

Fix Canvex DOOM Game
Gradient clips were not getting cleared after filling the
gradient, this was causing nothing to draw in Canvex
​https://bugs.webkit.org/show_bug.cgi?id=21498

Tests forthcoming.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect):
7:17 PM Changeset in webkit [37459] by cwzwarich@webkit.org
  • 2 edits in trunk/WebKitTools

2008-10-09 Cameron Zwarich <​zwarich@apple.com>

Not reviewed.

Add StructureID.o to the exclusion list in the global initializers
script to fix the Debug build.

  • Scripts/check-for-global-initializers:
6:21 PM Changeset in webkit [37458] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-10-09 Sam Weinig <​sam@webkit.org>

Reviewed by Maciej Stachowiak.

Add leaks checking to StructureID.

  • kjs/StructureID.cpp: (JSC::StructureID::StructureID): (JSC::StructureID::~StructureID):
5:50 PM Changeset in webkit [37457] by alp@webkit.org
  • 11 edits in trunk

2008-10-09 Alp Toker <​alp@nuanti.com>

Reviewed by Mark Rowe.

​https://bugs.webkit.org/show_bug.cgi?id=20760
Implement support for x86 Linux in CTI

Prepare to enable CTI/WREC on supported architectures.

Make it possible to use the CTI_ARGUMENT workaround with GCC as well
as MSVC by fixing some preprocessor conditionals.

Note that CTI/WREC no longer requires CTI_ARGUMENT on Linux so we
don't actually enable it except when building with MSVC. GCC on Win32
remains untested.

Adapt inline ASM code to use the global symbol underscore prefix only
on Darwin and to call the properly mangled Machine::cti_vm_throw
symbol name depending on CTI_ARGUMENT.

Also avoid global inclusion of the JIT infrastructure headers
throughout WebCore and WebKit causing recompilation of about ~1500
source files after modification to X86Assembler.h, CTI.h, WREC.h,
which are only used deep inside JavaScriptCore.

5:08 PM Changeset in webkit [37456] by eric@webkit.org
  • 55 edits in trunk

Reviewed by Oliver Hunt.

Fix transformed patterns
​https://bugs.webkit.org/show_bug.cgi?id=21498

Test: fast/canvas/patternfill-repeat.html

  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setStrokePattern): (WebCore::GraphicsContext::setFillPattern): (WebCore::GraphicsContext::setStrokeGradient): (WebCore::GraphicsContext::setFillGradient):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp:
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::applyStrokePattern): (WebCore::applyFillPattern): (WebCore::GraphicsContext::drawPath): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect):
  • platform/graphics/qt/GraphicsContextQt.cpp:
  • platform/graphics/wx/GraphicsContextWx.cpp:
5:04 PM Changeset in webkit [37455] by cmarrin@apple.com
  • 1 edit
    4 adds in trunk/LayoutTests

2008-10-09 Chris Marrin <​cmarrin@apple.com>

Reviewed by Darin Adler.

More testcases for animation using font metrics
​https://bugs.webkit.org/show_bug.cgi?id=21246

  • animations/font-size-using-ems-expected.txt: Added.
  • animations/font-size-using-ems.html: Added.
  • animations/width-using-ems-expected.txt: Added.
  • animations/width-using-ems.html: Added.
4:59 PM Changeset in webkit [37454] by cmarrin@apple.com
  • 2 edits in trunk/WebCore

2008-10-09 Chris Marrin <​cmarrin@apple.com>

Reviewed by Darin Adler.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=21217
Animations assert when navigating from page

Changed assertions to test the right flag for the paused state

  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::updateStateMachine):
4:59 PM Changeset in webkit [37453] by barraclough@apple.com
  • 6 edits in trunk

JavaScriptCore:

2008-10-09 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Cameron Zwarich.

Fix for bug #21160, x=0;1/(x*-1) == -Infinity

  • ChangeLog:
  • VM/CTI.cpp: (JSC::CTI::emitFastArithDeTagImmediate): (JSC::CTI::emitFastArithDeTagImmediateJumpIfZero): (JSC::CTI::compileBinaryArithOp): (JSC::CTI::compileBinaryArithOpSlowCase): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases):
  • VM/CTI.h:
  • masm/X86Assembler.h: (JSC::X86Assembler::): (JSC::X86Assembler::emitUnlinkedJs):

LayoutTests:

2008-10-09 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Cameron Zwarich.

Correct results for -0 cases.

  • fast/js/math-transforms-expected.txt:
4:44 PM Changeset in webkit [37452] by kevino@webkit.org
  • 8 edits in trunk

wx build fixes.

4:04 PM Changeset in webkit [37451] by cmarrin@apple.com
  • 3 edits
    2 adds in trunk

2008-10-09 Chris Marrin <​cmarrin@apple.com>

Reviewed by Dan Bernstein.

Fixed > 180 degree rotation bug
Ensure that validateTransformFunctionList() is called after updating keyframe styles

​https://bugs.webkit.org/show_bug.cgi?id=21420

Test: animations/big-rotation.html

  • page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::KeyframeAnimation):
2:47 PM Changeset in webkit [37450] by cwzwarich@webkit.org
  • 3 edits in trunk/JavaScriptCore

2008-10-09 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Oliver Hunt.

Bug 21459: REGRESSION (r37324): Safari crashes inside JavaScriptCore while browsing hulu.com
<​https://bugs.webkit.org/show_bug.cgi?id=21459>

After r37324, an Arguments object does not mark an associated activation
object. This change was made because Arguments no longer directly used
the activation object in any way. However, if an activation is torn off,
then the backing store of Arguments becomes the register array of the
activation object. Arguments directly marks all of the arguments, but
the activation object is being collected, which causes its register
array to be freed and new memory to be allocated in its place.

Unfortunately, it does not seem possible to reproduce this issue in a
layout test.

  • kjs/Arguments.cpp: (JSC::Arguments::mark):
  • kjs/Arguments.h: (JSC::Arguments::setActivation): (JSC::Arguments::Arguments): (JSC::JSActivation::copyRegisters):
1:43 PM Changeset in webkit [37449] by beidson@apple.com
  • 2 edits in trunk/WebCore

2008-10-09 Brady Eidson <​beidson@apple.com>

Reviewed by Anders

<rdar://problem/6250856> - Calling [WebView close] from within a redirection callback can cause bad things

The API usage to reveal this crash was so particular that a layout test is not possible with our current infrastructure.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::changeLocation): Protect the Frame from deletion (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): stopAllLoaders() might clear the Frame's page, so perform a second null check on the page. Bail if it has been cleared.
9:21 AM Changeset in webkit [37448] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-10-09 Alp Toker <​alp@nuanti.com>

Build fix for recent DOM generation Makefile changes when custom
CFLAGS/CXXFLAGS are passed in.

  • GNUmakefile.am:
9:13 AM Changeset in webkit [37447] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-10-09 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Alp Toker.

​https://bugs.webkit.org/show_bug.cgi?id=21390
[Gtk] Linux/Gtk: GtkLauncher crashes on Acid3 (but after test 80 this time)

  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::platformRemoveChild):
7:26 AM Changeset in webkit [37446] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2008-10-09 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Reviewed by Simon.

Build fix for MinGW.

  • wtf/AlwaysInline.h:
1:37 AM Changeset in webkit [37445] by Darin Adler
  • 2 edits in trunk/WebCore

2008-10-09 Darin Adler <Darin Adler>

  • try to fix Qt build
  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertQVariantToValue): Pass JSGlobalData instead of ExecState to RegExp constructor.
12:25 AM Changeset in webkit [37444] by Darin Adler
  • 1 edit
    1 add in trunk/LayoutTests

2008-10-09 Darin Adler <Darin Adler>

  • checked in a missing expected result
  • fast/dom/css-RGBValue-expected.txt: Added.

Oct 8, 2008:

10:38 PM Changeset in webkit [37443] by mrowe@apple.com
  • 3 edits in tags/Safari-6528.4.1/WebKitLibraries

Merge r37442.

10:36 PM Changeset in webkit [37442] by mrowe@apple.com
  • 2 edits in trunk/WebKitLibraries

Remove restriction on version number ending in a 4.

Rubber-stamped by Jon Honeycutt.

  • win/tools/scripts/auto-version.sh:
10:30 PM Changeset in webkit [37441] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-10-08 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Maciej Stachowiak.

Bug 21497: REGRESSION (r37433): Bytecode JSC tests are severely broken
<​https://bugs.webkit.org/show_bug.cgi?id=21497>

Fix a typo in r37433 that causes the failure of a large number of JSC
tests with the bytecode interpreter enabled.

  • VM/Machine.cpp: (JSC::Machine::privateExecute):
10:19 PM Changeset in webkit [37440] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Fix the Windows build after r37434.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(dump): Update code to approximate valid C++ syntax.

9:34 PM Changeset in webkit [37439] by timothy@apple.com
  • 2 edits in trunk/WebKitTools

Add SVGElementInstance to the list of exceptions that have
global initializers in debug builds.

Rubber-stamped by Mark Rowe.

  • Scripts/check-for-global-initializers: Add SVGElementInstance.o.
9:05 PM Changeset in webkit [37438] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix.

  • VM/CTI.cpp:

(JSC::): Update type of argument to ctiTrampoline.

8:57 PM Changeset in webkit [37437] by mitz@apple.com
  • 7 edits in trunk/LayoutTests/platform/mac

Correct MIME types

8:54 PM Changeset in webkit [37436] by Nikolas Zimmermann
  • 2 edits in trunk

Not reviewed. Fix Sams name :-)

8:34 PM Changeset in webkit [37435] by Nikolas Zimmermann
  • 22 edits
    4 moves
    18 adds
    4 deletes in trunk

Reviewed by Oliver Hunt & Sam Weining.

Fixes: ​https://bugs.webkit.org/show_bug.cgi?id=15413 (SVGElementInstance does not implement EventTarget)
Fixes: ​https://bugs.webkit.org/show_bug.cgi?id=15430 (SVGElementInstances should rebuild themselves lazily)
Fixes: ​https://bugs.webkit.org/show_bug.cgi?id=20550 (SVGUseElement.setAttribute crashes Safari)

Rebuild SVG use element shadow tree lazily. Mark SVGElementInstance with the "needsUpdate" flag.
Next time SVGUseElement::recalcStyle is invoked (ie. via Document::updateDocumentsRendering()) the
use tree is rebuild.

Make SVGElementInstance a real EventTarget, as the SVG specification demands.
When dispatching events to a shadow tree element of a use element, the associated SVGElementInstance
is used as event target. The SVGElementInstance, the shadow tree element and the corresponding element
share an event listener list. Every event listener change on the SVGElementInstance object is forwared
to the corresponding element. Each change marks the SVGElementInstance tree dirty, and causes a reclone.
Each event listener defined via attributes (onclick/onkeydown/...) is copied from the correspondingElement
to the shadow tree element - through the cloneNode calls - if the use element's shadow tree gets rebuild.
Each listener, dynamically created using addEventListener, gets copied to the corersponding element as well.

Now that the target/currentTarget properties of the Events are correct, event bubbling works as expected,
see resources/use-instanceRoot-event-bubbling.js for details.

Tests: svg/custom/use-elementInstance-event-target.svg (reenabled)

svg/custom/use-elementInstance-methods.svg (reenabled)
svg/custom/use-setAttribute-crash.svg (covers bug 20550)
svg/custom/use-instanceRoot-as-event-target.xhtml (covers bug 15413)
svg/custom/use-instanceRoot-event-bubbling.xhtml (covers bug 15413)
svg/custom/use-instanceRoot-event-listeners.xhtml (covers bug 15413 & 15430)

5:45 PM Changeset in webkit [37434] by Simon Fraser
  • 5 edits in trunk/WebKitTools

2008-10-08 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein

Avoid disconnect between DRT and run-webkit-tests
about whether to expect PNG dumps by having DRT always
print two blocks terminated by #EOF, the second of which
may be empty.

​https://bugs.webkit.org/show_bug.cgi?id=21483

  • DumpRenderTree/cg/PixelDumpSupportCG.cpp: (printPNG): (dumpWebViewAsPixelsAndCompareWithExpected):
  • DumpRenderTree/mac/DumpRenderTree.mm: (dump):
  • DumpRenderTree/win/DumpRenderTree.cpp: (dump):
  • Scripts/run-webkit-tests:
5:40 PM Changeset in webkit [37433] by Darin Adler
  • 41 edits in trunk

JavaScriptCore:

2008-10-08 Darin Adler <Darin Adler>

Reviewed by Cameron Zwarich.

Add CallFrame as a synonym for ExecState. Arguably, some day we should switch every
client over to the new name.

Use CallFrame* consistently rather than Register* or ExecState* in low-level code such
as Machine.cpp and CTI.cpp. Similarly, use callFrame rather than r as its name and use
accessor functions to get at things in the frame.

Eliminate other uses of ExecState* that aren't needed, replacing in some cases with
JSGlobalData* and in other cases eliminating them entirely.

  • API/JSObjectRef.cpp: (JSObjectMakeFunctionWithCallback): (JSObjectMakeFunction): (JSObjectHasProperty): (JSObjectGetProperty): (JSObjectSetProperty): (JSObjectDeleteProperty):
  • API/OpaqueJSString.cpp:
  • API/OpaqueJSString.h:
  • VM/CTI.cpp: (JSC::CTI::getConstant): (JSC::CTI::emitGetArg): (JSC::CTI::emitGetPutArg): (JSC::CTI::getConstantImmediateNumericArg): (JSC::CTI::printOpcodeOperandTypes): (JSC::CTI::CTI): (JSC::CTI::compileOpCall): (JSC::CTI::compileBinaryArithOp): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompile): (JSC::CTI::privateCompileGetByIdProto): (JSC::CTI::privateCompileGetByIdChain): (JSC::CTI::compileRegExp):
  • VM/CTI.h:
  • VM/CodeBlock.h:
  • VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitEqualityOp): (JSC::CodeGenerator::emitLoad): (JSC::CodeGenerator::emitUnexpectedLoad): (JSC::CodeGenerator::emitConstruct):
  • VM/CodeGenerator.h:
  • VM/Machine.cpp: (JSC::jsLess): (JSC::jsLessEq): (JSC::jsAddSlowCase): (JSC::jsAdd): (JSC::jsTypeStringForValue): (JSC::Machine::resolve): (JSC::Machine::resolveSkip): (JSC::Machine::resolveGlobal): (JSC::inlineResolveBase): (JSC::Machine::resolveBase): (JSC::Machine::resolveBaseAndProperty): (JSC::Machine::resolveBaseAndFunc): (JSC::Machine::slideRegisterWindowForCall): (JSC::isNotObject): (JSC::Machine::callEval): (JSC::Machine::dumpCallFrame): (JSC::Machine::dumpRegisters): (JSC::Machine::unwindCallFrame): (JSC::Machine::throwException): (JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope): (JSC::DynamicGlobalObjectScope::~DynamicGlobalObjectScope): (JSC::Machine::execute): (JSC::Machine::debug): (JSC::Machine::createExceptionScope): (JSC::cachePrototypeChain): (JSC::Machine::tryCachePutByID): (JSC::Machine::tryCacheGetByID): (JSC::Machine::privateExecute): (JSC::Machine::retrieveArguments): (JSC::Machine::retrieveCaller): (JSC::Machine::retrieveLastCaller): (JSC::Machine::findFunctionCallFrame): (JSC::Machine::getArgumentsData): (JSC::Machine::tryCTICachePutByID): (JSC::Machine::getCTIArrayLengthTrampoline): (JSC::Machine::getCTIStringLengthTrampoline): (JSC::Machine::tryCTICacheGetByID): (JSC::Machine::cti_op_convert_this): (JSC::Machine::cti_op_end): (JSC::Machine::cti_op_add): (JSC::Machine::cti_op_pre_inc): (JSC::Machine::cti_timeout_check): (JSC::Machine::cti_op_loop_if_less): (JSC::Machine::cti_op_loop_if_lesseq): (JSC::Machine::cti_op_new_object): (JSC::Machine::cti_op_put_by_id): (JSC::Machine::cti_op_put_by_id_second): (JSC::Machine::cti_op_put_by_id_generic): (JSC::Machine::cti_op_put_by_id_fail): (JSC::Machine::cti_op_get_by_id): (JSC::Machine::cti_op_get_by_id_second): (JSC::Machine::cti_op_get_by_id_generic): (JSC::Machine::cti_op_get_by_id_fail): (JSC::Machine::cti_op_instanceof): (JSC::Machine::cti_op_del_by_id): (JSC::Machine::cti_op_mul): (JSC::Machine::cti_op_new_func): (JSC::Machine::cti_op_call_JSFunction): (JSC::Machine::cti_vm_compile): (JSC::Machine::cti_op_push_activation): (JSC::Machine::cti_op_call_NotJSFunction): (JSC::Machine::cti_op_create_arguments): (JSC::Machine::cti_op_tear_off_activation): (JSC::Machine::cti_op_tear_off_arguments): (JSC::Machine::cti_op_ret_profiler): (JSC::Machine::cti_op_ret_scopeChain): (JSC::Machine::cti_op_new_array): (JSC::Machine::cti_op_resolve): (JSC::Machine::cti_op_construct_JSConstruct): (JSC::Machine::cti_op_construct_NotJSConstruct): (JSC::Machine::cti_op_get_by_val): (JSC::Machine::cti_op_resolve_func): (JSC::Machine::cti_op_sub): (JSC::Machine::cti_op_put_by_val): (JSC::Machine::cti_op_put_by_val_array): (JSC::Machine::cti_op_lesseq): (JSC::Machine::cti_op_loop_if_true): (JSC::Machine::cti_op_negate): (JSC::Machine::cti_op_resolve_base): (JSC::Machine::cti_op_resolve_skip): (JSC::Machine::cti_op_resolve_global): (JSC::Machine::cti_op_div): (JSC::Machine::cti_op_pre_dec): (JSC::Machine::cti_op_jless): (JSC::Machine::cti_op_not): (JSC::Machine::cti_op_jtrue): (JSC::Machine::cti_op_post_inc): (JSC::Machine::cti_op_eq): (JSC::Machine::cti_op_lshift): (JSC::Machine::cti_op_bitand): (JSC::Machine::cti_op_rshift): (JSC::Machine::cti_op_bitnot): (JSC::Machine::cti_op_resolve_with_base): (JSC::Machine::cti_op_new_func_exp): (JSC::Machine::cti_op_mod): (JSC::Machine::cti_op_less): (JSC::Machine::cti_op_neq): (JSC::Machine::cti_op_post_dec): (JSC::Machine::cti_op_urshift): (JSC::Machine::cti_op_bitxor): (JSC::Machine::cti_op_new_regexp): (JSC::Machine::cti_op_bitor): (JSC::Machine::cti_op_call_eval): (JSC::Machine::cti_op_throw): (JSC::Machine::cti_op_get_pnames): (JSC::Machine::cti_op_next_pname): (JSC::Machine::cti_op_push_scope): (JSC::Machine::cti_op_pop_scope): (JSC::Machine::cti_op_typeof): (JSC::Machine::cti_op_to_jsnumber): (JSC::Machine::cti_op_in): (JSC::Machine::cti_op_push_new_scope): (JSC::Machine::cti_op_jmp_scopes): (JSC::Machine::cti_op_put_by_index): (JSC::Machine::cti_op_switch_imm): (JSC::Machine::cti_op_switch_char): (JSC::Machine::cti_op_switch_string): (JSC::Machine::cti_op_del_by_val): (JSC::Machine::cti_op_put_getter): (JSC::Machine::cti_op_put_setter): (JSC::Machine::cti_op_new_error): (JSC::Machine::cti_op_debug): (JSC::Machine::cti_vm_throw):
  • VM/Machine.h:
  • VM/Register.h:
  • VM/RegisterFile.h:
  • kjs/Arguments.h:
  • kjs/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::functionName): (JSC::DebuggerCallFrame::type): (JSC::DebuggerCallFrame::thisObject): (JSC::DebuggerCallFrame::evaluate):
  • kjs/DebuggerCallFrame.h:
  • kjs/ExecState.cpp: (JSC::CallFrame::thisValue):
  • kjs/ExecState.h:
  • kjs/FunctionConstructor.cpp: (JSC::constructFunction):
  • kjs/JSActivation.cpp: (JSC::JSActivation::JSActivation): (JSC::JSActivation::argumentsGetter):
  • kjs/JSActivation.h:
  • kjs/JSGlobalObject.cpp: (JSC::JSGlobalObject::init):
  • kjs/JSGlobalObjectFunctions.cpp: (JSC::globalFuncEval):
  • kjs/JSVariableObject.h:
  • kjs/Parser.cpp: (JSC::Parser::parse):
  • kjs/RegExpConstructor.cpp: (JSC::constructRegExp):
  • kjs/RegExpPrototype.cpp: (JSC::regExpProtoFuncCompile):
  • kjs/Shell.cpp: (prettyPrintScript):
  • kjs/StringPrototype.cpp: (JSC::stringProtoFuncMatch): (JSC::stringProtoFuncSearch):
  • kjs/identifier.cpp: (JSC::Identifier::checkSameIdentifierTable):
  • kjs/interpreter.cpp: (JSC::Interpreter::checkSyntax): (JSC::Interpreter::evaluate):
  • kjs/nodes.cpp: (JSC::ThrowableExpressionData::emitThrowError): (JSC::RegExpNode::emitCode): (JSC::ArrayNode::emitCode): (JSC::InstanceOfNode::emitCode):
  • kjs/nodes.h:
  • kjs/regexp.cpp: (JSC::RegExp::RegExp): (JSC::RegExp::create):
  • kjs/regexp.h:
  • profiler/HeavyProfile.h:
  • profiler/Profile.h:
  • wrec/WREC.cpp:
  • wrec/WREC.h:

WebKit/mac:

2008-10-08 Darin Adler <Darin Adler>

Reviewed by Cameron Zwarich.

  • WebView/WebScriptDebugger.mm: (WebScriptDebugger::WebScriptDebugger): Update since DebuggerCallFrame is simpler now.
5:14 PM Changeset in webkit [37432] by weinig@apple.com
  • 4 edits
    2 adds in trunk

WebCore:

2008-10-08 Sam Weinig <​sam@webkit.org>

Reviewed by Cameron Zwarich.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=21241
REGRESSION (r36977): getRGBColorValue().red returning incorrect value

Update JSRGBColor to use the new static function per getter approach.

Test: fast/dom/css-RGBValue.html

  • bindings/js/JSRGBColor.cpp: (WebCore::): (jsRGBColorRed): (jsRGBColorGreen): (jsRGBColorBlue):
  • bindings/js/JSRGBColor.h:

LayoutTests:

2008-10-08 Sam Weinig <​sam@webkit.org>

Reviewed by Cameron Zwarich.

Test for ​https://bugs.webkit.org/show_bug.cgi?id=21241
REGRESSION (r36977): getRGBColorValue().red returning incorrect value

  • fast/dom/css-RGBValue.html: Added.
  • fast/dom/resources/css-RGBValue.js: Added.
3:48 PM Changeset in webkit [37431] by eric@webkit.org
  • 5 edits
    4 adds in trunk

Reviewed by Darin Adler, Nikolas Zimmermann and Dave Hyatt.

svgElement.className.baseValue = "foo" does not work
​https://bugs.webkit.org/show_bug.cgi?id=20651

  • dom/StyledElement.cpp: (WebCore::StyledElement::classAttributeChanged): (WebCore::StyledElement::parseMappedAttribute):
  • dom/StyledElement.h:
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::svgAttributeChanged):
3:38 PM Changeset in webkit [37430] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix crash in fast/js/constant-folding.html with CTI disabled.

Typed by Maciej Stachowiak, reviewed by Mark Rowe.

  • VM/Machine.cpp:

(JSC::Machine::privateExecute):

1:30 PM Changeset in webkit [37429] by mjs@apple.com
  • 3 edits in trunk/LayoutTests

2008-10-08 Maciej Stachowiak <​mjs@apple.com>

Not reviewed, trying to fix bot.


Update -0 expectations better.

  • fast/xpath/4XPath/Core/test_numeric_expr-expected.txt:
  • fast/xpath/4XPath/Core/test_numeric_expr.html:
10:50 AM Changeset in webkit [37428] by timothy@apple.com
  • 41 edits in trunk

Roll out r37427 because it causes an infinite recursion loading about:blank.

​https://bugs.webkit.org/show_bug.cgi?id=21476

10:03 AM Changeset in webkit [37427] by Darin Adler
  • 41 edits in trunk

JavaScriptCore:

2008-10-08 Darin Adler <Darin Adler>

Reviewed by Cameron Zwarich.

Add CallFrame as a synonym for ExecState. Arguably, some day we should switch every
client over to the new name.

Use CallFrame* consistently rather than Register* or ExecState* in low-level code such
as Machine.cpp and CTI.cpp. Similarly, use callFrame rather than r as its name and use
accessor functions to get at things in the frame.

Eliminate other uses of ExecState* that aren't needed, replacing in some cases with
JSGlobalData* and in other cases eliminating them entirely.

  • API/JSObjectRef.cpp: (JSObjectMakeFunctionWithCallback): (JSObjectMakeFunction): (JSObjectHasProperty): (JSObjectGetProperty): (JSObjectSetProperty): (JSObjectDeleteProperty):
  • API/OpaqueJSString.cpp:
  • API/OpaqueJSString.h:
  • VM/CTI.cpp: (JSC::CTI::getConstant): (JSC::CTI::emitGetArg): (JSC::CTI::emitGetPutArg): (JSC::CTI::getConstantImmediateNumericArg): (JSC::CTI::printOpcodeOperandTypes): (JSC::CTI::CTI): (JSC::CTI::compileOpCall): (JSC::CTI::compileBinaryArithOp): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompile): (JSC::CTI::privateCompileGetByIdProto): (JSC::CTI::privateCompileGetByIdChain): (JSC::CTI::compileRegExp):
  • VM/CTI.h:
  • VM/CodeBlock.h:
  • VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitEqualityOp): (JSC::CodeGenerator::emitLoad): (JSC::CodeGenerator::emitUnexpectedLoad): (JSC::CodeGenerator::emitConstruct):
  • VM/CodeGenerator.h:
  • VM/Machine.cpp: (JSC::jsLess): (JSC::jsLessEq): (JSC::jsAddSlowCase): (JSC::jsAdd): (JSC::jsTypeStringForValue): (JSC::Machine::resolve): (JSC::Machine::resolveSkip): (JSC::Machine::resolveGlobal): (JSC::inlineResolveBase): (JSC::Machine::resolveBase): (JSC::Machine::resolveBaseAndProperty): (JSC::Machine::resolveBaseAndFunc): (JSC::Machine::slideRegisterWindowForCall): (JSC::isNotObject): (JSC::Machine::callEval): (JSC::Machine::dumpCallFrame): (JSC::Machine::dumpRegisters): (JSC::Machine::unwindCallFrame): (JSC::Machine::throwException): (JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope): (JSC::DynamicGlobalObjectScope::~DynamicGlobalObjectScope): (JSC::Machine::execute): (JSC::Machine::debug): (JSC::Machine::createExceptionScope): (JSC::cachePrototypeChain): (JSC::Machine::tryCachePutByID): (JSC::Machine::tryCacheGetByID): (JSC::Machine::privateExecute): (JSC::Machine::retrieveArguments): (JSC::Machine::retrieveCaller): (JSC::Machine::retrieveLastCaller): (JSC::Machine::findFunctionCallFrame): (JSC::Machine::getArgumentsData): (JSC::Machine::tryCTICachePutByID): (JSC::Machine::getCTIArrayLengthTrampoline): (JSC::Machine::getCTIStringLengthTrampoline): (JSC::Machine::tryCTICacheGetByID): (JSC::Machine::cti_op_convert_this): (JSC::Machine::cti_op_end): (JSC::Machine::cti_op_add): (JSC::Machine::cti_op_pre_inc): (JSC::Machine::cti_timeout_check): (JSC::Machine::cti_op_loop_if_less): (JSC::Machine::cti_op_loop_if_lesseq): (JSC::Machine::cti_op_new_object): (JSC::Machine::cti_op_put_by_id): (JSC::Machine::cti_op_put_by_id_second): (JSC::Machine::cti_op_put_by_id_generic): (JSC::Machine::cti_op_put_by_id_fail): (JSC::Machine::cti_op_get_by_id): (JSC::Machine::cti_op_get_by_id_second): (JSC::Machine::cti_op_get_by_id_generic): (JSC::Machine::cti_op_get_by_id_fail): (JSC::Machine::cti_op_instanceof): (JSC::Machine::cti_op_del_by_id): (JSC::Machine::cti_op_mul): (JSC::Machine::cti_op_new_func): (JSC::Machine::cti_op_call_JSFunction): (JSC::Machine::cti_vm_compile): (JSC::Machine::cti_op_push_activation): (JSC::Machine::cti_op_call_NotJSFunction): (JSC::Machine::cti_op_create_arguments): (JSC::Machine::cti_op_tear_off_activation): (JSC::Machine::cti_op_tear_off_arguments): (JSC::Machine::cti_op_ret_profiler): (JSC::Machine::cti_op_ret_scopeChain): (JSC::Machine::cti_op_new_array): (JSC::Machine::cti_op_resolve): (JSC::Machine::cti_op_construct_JSConstruct): (JSC::Machine::cti_op_construct_NotJSConstruct): (JSC::Machine::cti_op_get_by_val): (JSC::Machine::cti_op_resolve_func): (JSC::Machine::cti_op_sub): (JSC::Machine::cti_op_put_by_val): (JSC::Machine::cti_op_put_by_val_array): (JSC::Machine::cti_op_lesseq): (JSC::Machine::cti_op_loop_if_true): (JSC::Machine::cti_op_negate): (JSC::Machine::cti_op_resolve_base): (JSC::Machine::cti_op_resolve_skip): (JSC::Machine::cti_op_resolve_global): (JSC::Machine::cti_op_div): (JSC::Machine::cti_op_pre_dec): (JSC::Machine::cti_op_jless): (JSC::Machine::cti_op_not): (JSC::Machine::cti_op_jtrue): (JSC::Machine::cti_op_post_inc): (JSC::Machine::cti_op_eq): (JSC::Machine::cti_op_lshift): (JSC::Machine::cti_op_bitand): (JSC::Machine::cti_op_rshift): (JSC::Machine::cti_op_bitnot): (JSC::Machine::cti_op_resolve_with_base): (JSC::Machine::cti_op_new_func_exp): (JSC::Machine::cti_op_mod): (JSC::Machine::cti_op_less): (JSC::Machine::cti_op_neq): (JSC::Machine::cti_op_post_dec): (JSC::Machine::cti_op_urshift): (JSC::Machine::cti_op_bitxor): (JSC::Machine::cti_op_new_regexp): (JSC::Machine::cti_op_bitor): (JSC::Machine::cti_op_call_eval): (JSC::Machine::cti_op_throw): (JSC::Machine::cti_op_get_pnames): (JSC::Machine::cti_op_next_pname): (JSC::Machine::cti_op_push_scope): (JSC::Machine::cti_op_pop_scope): (JSC::Machine::cti_op_typeof): (JSC::Machine::cti_op_to_jsnumber): (JSC::Machine::cti_op_in): (JSC::Machine::cti_op_push_new_scope): (JSC::Machine::cti_op_jmp_scopes): (JSC::Machine::cti_op_put_by_index): (JSC::Machine::cti_op_switch_imm): (JSC::Machine::cti_op_switch_char): (JSC::Machine::cti_op_switch_string): (JSC::Machine::cti_op_del_by_val): (JSC::Machine::cti_op_put_getter): (JSC::Machine::cti_op_put_setter): (JSC::Machine::cti_op_new_error): (JSC::Machine::cti_op_debug): (JSC::Machine::cti_vm_throw):
  • VM/Machine.h:
  • VM/Register.h:
  • VM/RegisterFile.h:
  • kjs/Arguments.h:
  • kjs/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::functionName): (JSC::DebuggerCallFrame::type): (JSC::DebuggerCallFrame::thisObject): (JSC::DebuggerCallFrame::evaluate):
  • kjs/DebuggerCallFrame.h:
  • kjs/ExecState.cpp: (JSC::CallFrame::thisValue):
  • kjs/ExecState.h:
  • kjs/FunctionConstructor.cpp: (JSC::constructFunction):
  • kjs/JSActivation.cpp: (JSC::JSActivation::JSActivation): (JSC::JSActivation::argumentsGetter):
  • kjs/JSActivation.h:
  • kjs/JSGlobalObject.cpp: (JSC::JSGlobalObject::init):
  • kjs/JSGlobalObjectFunctions.cpp: (JSC::globalFuncEval):
  • kjs/JSVariableObject.h:
  • kjs/Parser.cpp: (JSC::Parser::parse):
  • kjs/RegExpConstructor.cpp: (JSC::constructRegExp):
  • kjs/RegExpPrototype.cpp: (JSC::regExpProtoFuncCompile):
  • kjs/Shell.cpp: (prettyPrintScript):
  • kjs/StringPrototype.cpp: (JSC::stringProtoFuncMatch): (JSC::stringProtoFuncSearch):
  • kjs/identifier.cpp: (JSC::Identifier::checkSameIdentifierTable):
  • kjs/interpreter.cpp: (JSC::Interpreter::checkSyntax): (JSC::Interpreter::evaluate):
  • kjs/nodes.cpp: (JSC::ThrowableExpressionData::emitThrowError): (JSC::RegExpNode::emitCode): (JSC::ArrayNode::emitCode): (JSC::InstanceOfNode::emitCode):
  • kjs/nodes.h:
  • kjs/regexp.cpp: (JSC::RegExp::RegExp): (JSC::RegExp::create):
  • kjs/regexp.h:
  • profiler/HeavyProfile.h:
  • profiler/Profile.h:
  • wrec/WREC.cpp:
  • wrec/WREC.h:

WebKit/mac:

2008-10-08 Darin Adler <Darin Adler>

Reviewed by Cameron Zwarich.

  • WebView/WebScriptDebugger.mm: (WebScriptDebugger::WebScriptDebugger): Update since DebuggerCallFrame is simpler now.
9:41 AM Changeset in webkit [37426] by timothy@apple.com
  • 2 edits in trunk/WebCore

Make the toolbar label text-shadow not disappear when clicking on the
search result count or around the search field.

Reviewed by Timothy Hatcher.

  • inspector/front-end/inspector.css: (.toolbar-item:active .toolbar-label): Make this rule also require the toggleable class with the toolbar-item class.
8:06 AM QtWebKitJournal edited by ariya.hidayat@trolltech.com
(diff)
6:30 AM Changeset in webkit [37425] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2008-10-08 Matthias Ettrich <​ettrich@nokia.com>

Reviewed by Simon.

Make QWebView ignore focus changes with PopupFocusReason to avoid
massive updates when menus open and close.

6:13 AM Changeset in webkit [37424] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-10-08 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon.

Updated the qrc file for the Web Inspector to contain the current set
of images.

5:43 AM Changeset in webkit [37423] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-10-08 Prasanth Ullattil <​pullatti@trolltech.com>

Reviewed by Simon.

Fix the linking of applications against WebKit on Qt/Windows.

The prl files that qmake creates are buggy on Unix, but we they're
fine on Windows and we have to have them there in order to get the
dependencies correct.

5:20 AM Changeset in webkit [37422] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2008-10-08 Prasanth Ullattil <​pullatti@trolltech.com>

Reviewed by Oliver Hunt.

Avoid endless loops when compiling without the computed goto
optimization.

NEXT_OPCODE expands to "continue", which will not work inside
loops.

5:11 AM Changeset in webkit [37421] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-10-08 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Reviewed by Simon.

Speed up rectangle filling by not re-creating a QBrush all the time.

This triggers faster path in QPainter where the brush is reused.

5:08 AM Changeset in webkit [37420] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2008-10-08 Kavindra Palaraja <​kdpalara@trolltech.com>

Reviewed by Simon.

Fixed a qdoc warning and adjusted some spacing

4:33 AM Changeset in webkit [37419] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2008-10-08 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Oliver Hunt.


  • update for new -0 handling in shouldBe


(I confirmed the correctness of this change against other browsers, too.)

  • fast/xpath/4XPath/Core/test_numeric_expr.html:
4:01 AM Changeset in webkit [37418] by dino@apple.com
  • 4 edits in trunk/WebKitSite/specs/CSSVisualEffects

2008-10-08 Dean Jackson <​dino@apple.com>

Forgot to set the date on the spec documents with last commit.

  • CSSAnimations.html:
  • CSSTransforms.html:
  • CSSTransitions.html:
3:53 AM Changeset in webkit [37417] by mjs@apple.com
  • 5 edits in trunk/JavaScriptCore

2008-10-08 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Oliver Hunt.

Re-landing the following fix with the crashing bug in it fixed (r37405):


  • optimize away multiplication by constant 1.0


2.3% speedup on v8 RayTrace benchmark

Apparently it's not uncommon for JavaScript code to multiply by
constant 1.0 in the mistaken belief that this converts integer to
floating point and that there is any operational difference.

  • VM/CTI.cpp: (JSC::CTI::privateCompileMainPass): Optimize to_jsnumber for case where parameter is already number. (JSC::CTI::privateCompileSlowCases): ditto
  • VM/Machine.cpp: (JSC::Machine::privateExecute): ditto
  • kjs/grammar.y: (makeMultNode): Transform as follows: +FOO * BAR ==> FOO * BAR FOO * +BAR ==> FOO * BAR FOO * 1 ==> +FOO 1 * FOO ==> +FOO (makeDivNode): Transform as follows: +FOO / BAR ==> FOO / BAR FOO / +BAR ==> FOO / BAR (makeSubNode): Transform as follows: +FOO - BAR ==> FOO - BAR FOO - +BAR ==> FOO - BAR
  • kjs/nodes.h: (JSC::ExpressionNode::stripUnaryPlus): Helper for above grammar.y changes (JSC::UnaryPlusNode::stripUnaryPlus): ditto
3:27 AM Changeset in webkit [37416] by mjs@apple.com
  • 6 edits in trunk/LayoutTests

2008-10-08 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Oliver Hunt.


  • update regression testing system to be able to tell 0 from -0


  • fast/js/resources/js-test-pre.js:

Update tests and results appropriately.

  • fast/js/resources/constant-folding.js:
  • fast/js/constant-folding-expected.txt:
  • fast/js/math-transforms-expected.txt:
  • fast/js/resources/math-transforms.js:
2:18 AM Changeset in webkit [37415] by mjs@apple.com
  • 6 edits in trunk

JavaScriptCore:

2008-10-08 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Oliver Hunt.


  • correctly handle appending -0 to a string, it should stringify as just 0
  • kjs/ustring.cpp: (JSC::concatenate):

LayoutTests:

2008-10-08 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Oliver Hunt.

  • added test case for: correctly handle appending -0 to a string, it should stringify as just 0 (added to existing test)


  • fast/js/number-toString-expected.txt:
  • fast/js/resources/number-toString.js:
  • updated results in light of above fix


  • fast/js/math-transforms-expected.txt:
2:10 AM Changeset in webkit [37414] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-10-08 Thiago Macieira <​thiago.macieira@nokia.com>

Reviewed by Simon.

Fixes: Encoding of Qt URLs

This encoding was added by Simon and I because QUrl's
tolerant parser wasn't tolerant enough. Now it is, so we don't need
this anymore.

2:10 AM Changeset in webkit [37413] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-10-08 Marius Storm-Olsen <​marius@trolltech.com>

Reviewed by Simon.

Fixes dependencies in qmake generated visual studio projects.

Only add debug lib name if we're in the debug build_pass, else the release version.
The MSVC solution generator would pick up the debug javascriptcore lib as a dependency.

2:10 AM Changeset in webkit [37412] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2008-10-08 Prasanth Ullattil <​pullatti@trolltech.com>

Reviewed by Simon.

Fix WebKit compilation with VC2008SP1

Apply the TR1 workaround for JavaScriptCore, too.

2:10 AM Changeset in webkit [37411] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2008-10-08 Rhys Weatherley <​rhys.weatherley@nokia.com>

Reviewed by Simon.

Compile for platforms without context menus.

2:10 AM Changeset in webkit [37410] by Simon Hausmann
  • 6 edits in trunk

2008-10-08 Prasanth Ullattil <​pullatti@trolltech.com>

Reviewed by Simon.

Fix compilation errors on VS2008 64Bit

2:09 AM Changeset in webkit [37409] by Simon Hausmann
  • 4 edits in trunk

2008-10-08 André Pönitz <​apoenitz@trolltech.com>

Reviewed by Simon.

Fix compilation with Qt namespaces.

12:35 AM QtWebKitJournal edited by ariya.hidayat@trolltech.com
(diff)
12:34 AM QtWebKitJournal edited by ariya.hidayat@trolltech.com
(diff)
Note: See TracTimeline for information about the timeline view.