Context Navigation

← Previous Period
Next Period →

Timeline

Oct 10, 2008:

11:33 PM Changeset in webkit [37506] by hyatt@apple.com

4 edits in trunk/LayoutTests/scrollbars

Update scrollbars layout tests to new syntax.

11:30 PM Changeset in webkit [37505] by hyatt@apple.com

4 edits in trunk/WebCore

2008-10-10 David Hyatt <hyatt@apple.com>

Drop -webkit-scrollbar- from all the scrollbar pseudo-classes, since they are scoped to
the scrollbar pseudo-elements anyway.

Reviewed by Tim Hatcher

css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
css/CSSSelector.h: (WebCore::CSSSelector::):
css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):

11:26 PM Changeset in webkit [37504] by mitz@apple.com

3 edits in trunk/WebCore

Reviewed by Sam Weinig.

separate Cache::remove() into a private method and a public interface, then make Cache::pruneDeadResources() use the private method.

loader/Cache.cpp: (WebCore::Cache::pruneDeadResources): (WebCore::Cache::evict):
loader/Cache.h: (WebCore::Cache::remove):

11:12 PM Changeset in webkit [37503] by hyatt@apple.com

2 edits in trunk/WebCore

2008-10-10 David Hyatt <hyatt@apple.com>

Fix a math error when splitting a vertical track. Clean up more of ScrollbarThemeComposite
now that the track pieces meet under the thumb.

Reviewed by Tim Hatcher

platform/ScrollbarThemeComposite.cpp: (WebCore::ScrollbarThemeComposite::paint): (WebCore::ScrollbarThemeComposite::splitTrack):

11:04 PM Changeset in webkit [37502] by hyatt@apple.com

2 edits in trunk/WebCore

2008-10-10 David Hyatt <hyatt@apple.com>

Make the track pieces of a scrollbar extend under the thumb (each gets half the thumb).

Reviewed by Tim Hatcher

platform/ScrollbarThemeComposite.cpp: (WebCore::ScrollbarThemeComposite::hitTest): (WebCore::ScrollbarThemeComposite::splitTrack):

10:54 PM Changeset in webkit [37501] by hyatt@apple.com

5 edits in trunk/WebCore

2008-10-10 David Hyatt <hyatt@apple.com>

Make sure specialized ::scrollbar rules are still triggering custom scrollbar creation.

Reviewed by Tim Hatcher

rendering/RenderLayer.cpp: (WebCore::RenderLayer::createScrollbar):
rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::createCustomScrollbar): (WebCore::RenderScrollbar::RenderScrollbar): (WebCore::RenderScrollbar::setParent): (WebCore::RenderScrollbar::updateScrollbarParts): (WebCore::RenderScrollbar::updateScrollbarPart):
rendering/RenderScrollbar.h:
rendering/style/RenderStyle.h: (WebCore::RenderStyle::):

10:49 PM Changeset in webkit [37500] by oliver@apple.com

4 edits in trunk/JavaScriptCore

Use fastcall calling convention on GCC > 4.0

Reviewed by Cameron Zwarich

Results in a 2-3% improvement in GCC 4.2 performance, so
that it is no longer a regression vs. GCC 4.0

10:30 PM Changeset in webkit [37499] by hyatt@apple.com

4 edits in trunk/WebCore

2008-10-10 David Hyatt <hyatt@apple.com>

Make sure scrollbar background images cause proper part invalidation to occur.

Reviewed by Tim Hatcher

rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::setHoveredPart): (WebCore::RenderScrollbar::setPressedPart):
rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::styleDidChange): (WebCore::RenderScrollbarPart::imageChanged):
rendering/RenderScrollbarPart.h:

7:53 PM Changeset in webkit [37498] by weinig@apple.com

8 edits in trunk

JavaScriptCore:

2008-10-10 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

Add a workaround for a bug in ceil in Darwin libc.
Remove old workarounds for JS math functions that are not needed anymore.

The math functions are heavily tested by fast/js/math.html.

kjs/MathObject.cpp: (JSC::mathProtoFuncAbs): Remove workaround. (JSC::mathProtoFuncCeil): Ditto. (JSC::mathProtoFuncFloor): Ditto.
wtf/MathExtras.h: (wtf_ceil): Add ceil workaround for darwin.

LayoutTests:

2008-10-10 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

Update tests after fixing ceil(-0.1) behavior on darwin.

fast/js/math-expected.txt:
fast/js/resources/math.js: Remove code to detect sign of 0 now that the harness can handle it.
fast/xpath/4XPath/Core/test_core_functions-expected.txt:
fast/xpath/4XPath/Core/test_core_functions.html: Update test expect correct result of -0.

7:05 PM Changeset in webkit [37497] by weinig@apple.com

2 edits in trunk/JavaScriptCore

2008-10-10 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler

Add Assertions to JSObject constructor.

kjs/JSObject.h: (JSC::JSObject::JSObject):

5:35 PM Changeset in webkit [37496] by Simon Fraser

3 edits
2 adds in trunk

2008-10-10 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler

https://bugs.webkit.org/show_bug.cgi?id=21538

The blendFunc() for TransformOperations should never mess with the
operation lists by replacing some ops with identity, otherwise the lists
no longer match and transitions break.

Test: transitions/matched-transform-functions.html

page/animation/AnimationBase.cpp: (WebCore::blendFunc):

5:32 PM Changeset in webkit [37495] by Simon Fraser

3 edits
2 adds in trunk

2008-10-10 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler

https://bugs.webkit.org/show_bug.cgi?id=21537

Fix re-targetting a running transition; if the target property
changes, we do need to make a new ImplicitAnimation.

Test: transitions/retargetted-transition.html

page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimationPrivate::updateTransitions):

4:21 PM Changeset in webkit [37494] by oliver@apple.com

2 edits in trunk/WebCore

Part of <rdar://problem/6278147> Cannot stop a slow script -- Fix assertion

Reviewed by Cameron Zwarich

When JS is terminated by the user choosing to stop a slow script
the exception toString method throws, yet the console logger does
not perform exception checks after logging. This leaves an
exception on the Machine, which in turn results in an assertion
failure next time we attempt to enter JS. The solution is just to
clear the exception state after attempting to record the exception.

3:24 PM Changeset in webkit [37493] by hyatt@apple.com

2 edits in trunk/WebCore

2008-10-10 David Hyatt <hyatt@apple.com>

Make textareas work with custom CSS scrollbars and resizers. Need to access the correct renderer
when looking for pseudo styles.

Reviewed by Tim Hatcher

rendering/RenderLayer.cpp: (WebCore::RenderLayer::createScrollbar): (WebCore::RenderLayer::styleChanged):

3:19 PM Changeset in webkit [37492] by dino@apple.com

2 edits in trunk/WebKitSite/specs/CSSVisualEffects

2008-10-10 Dean Jackson <dino@apple.com>

Keyframe example had "0" rather than "0%".

WebKitSite/specs/CSSVisualEffects/CSSAnimations.html:

3:16 PM Changeset in webkit [37491] by hyatt@apple.com

10 edits in trunk/WebCore

2008-10-10 David Hyatt <hyatt@apple.com>

Add the ability to style the scroll corner and the resizer from CSS.

Reviewed by Tim Hatcher

css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
css/CSSSelector.h: (WebCore::CSSSelector::):
css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::~RenderLayer): (WebCore::RenderLayer::paintOverflowControls): (WebCore::RenderLayer::paintScrollCorner): (WebCore::RenderLayer::paintResizer): (WebCore::RenderLayer::styleChanged):
rendering/RenderLayer.h:
rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::updateScrollbarPart): (WebCore::RenderScrollbar::paintPart):
rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::RenderScrollbarPart): (WebCore::RenderScrollbarPart::paintIntoRect):
rendering/RenderScrollbarPart.h:
rendering/style/RenderStyle.h: (WebCore::RenderStyle::):

2:05 PM Changeset in webkit [37490] by hyatt@apple.com

10 edits in trunk/WebCore

2008-10-10 David Hyatt <hyatt@apple.com>

Make CSS scrollbars respect the OS setting regarding where buttons should be placed.

Reviewed by Sam Weinig

No test case possible, since the OS setting can vary.

css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
css/CSSSelector.h: (WebCore::CSSSelector::):
css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
platform/Scrollbar.h: (WebCore::Scrollbar::styleChanged):
platform/mac/ScrollbarThemeMac.mm: (+[ScrollbarPrefsObserver appearancePrefsChanged:]): (WebCore::ScrollbarThemeMac::preferencesChanged):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::invalidateScrollbarRect):
rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::styleChanged): (WebCore::RenderScrollbar::updateScrollbarPart):
rendering/RenderScrollbar.h:
rendering/RenderScrollbarTheme.h: (WebCore::RenderScrollbarTheme::buttonsPlacement):

1:43 PM Changeset in webkit [37489] by adachan@apple.com

3 edits in trunk/WebKit/win

Bug 21526: The hashmap webPreferencesInstances in WebPreferences.cpp can
potentially hold onto stale instances of WebPreferences
https://bugs.webkit.org/show_bug.cgi?id=21526

webPreferencesInstances now keeps a reference to all the instances it holds.
Fix up callers of WebPreferences::removeReferenceForIdentifier() to call
it after they have released their references to the WebPreferences objects.

Reviewed by Adam Roben.

WebPreferences.cpp: (WebPreferences::getInstanceForIdentifier): (WebPreferences::removeReferenceForIdentifier):
WebView.cpp: (WebView::close): (WebView::setPreferences):

1:27 PM Changeset in webkit [37488] by timothy@apple.com

4 edits
2 adds in trunk

Fixes a regression with input search fields, where the placeholder text
would not be updated when the value of the placeholder attribute changed.

https://bugs.webkit.org/show_bug.cgi?id=21521

Reviewed by Adele Peterson.

Test: fast/forms/search-placeholder-value-changed.html

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute): Pass true for the placeholderValueChanged parameter of updatePlaceholderVisibility. (WebCore::HTMLInputElement::updatePlaceholderVisibility): Add parameter for placeholderValueChanged that informs the method that the value changed.
html/HTMLInputElement.h: Add the placeholderValueChanged to the updatePlaceholderVisibility method. Made it default to false.

1:12 PM Changeset in webkit [37487] by hyatt@apple.com

6 edits in trunk/WebCore

2008-10-10 David Hyatt <hyatt@apple.com>

Allow the track part to have negative margins so that it can slightly overlap buttons. This
is necessary to emulate the Aqua look in CSS.

Reviewed by Sam Weinig

platform/ScrollbarThemeComposite.cpp: (WebCore::ScrollbarThemeComposite::paint): (WebCore::ScrollbarThemeComposite::hitTest):
rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::setHoveredPart): (WebCore::RenderScrollbar::trackRect):
rendering/RenderScrollbar.h:
rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::computeScrollbarWidth): (WebCore::RenderScrollbarPart::computeScrollbarHeight):
rendering/RenderScrollbarTheme.cpp: (WebCore::RenderScrollbarTheme::backButtonRect): (WebCore::RenderScrollbarTheme::forwardButtonRect): (WebCore::RenderScrollbarTheme::trackRect):

12:32 PM Changeset in webkit [37486] by hyatt@apple.com

6 edits
1 add in trunk/WebCore

2008-10-10 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21527

Make CSS scrollbars support :not, :hover and :active.

Reviewed by Adam Roben

Added WebCore/manual-tests/scrollbar-hover-active.html

css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
platform/Scrollbar.cpp: (WebCore::Scrollbar::autoscrollPressedPart): (WebCore::Scrollbar::startTimerIfNeeded): (WebCore::Scrollbar::setHoveredPart): (WebCore::Scrollbar::setPressedPart): (WebCore::Scrollbar::mouseMoved): (WebCore::Scrollbar::mouseExited): (WebCore::Scrollbar::mouseUp): (WebCore::Scrollbar::mouseDown):
platform/Scrollbar.h:
rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::setHoveredPart): (WebCore::RenderScrollbar::setPressedPart): (WebCore::RenderScrollbar::updateScrollbarParts): (WebCore::pseudoForScrollbarPart): (WebCore::RenderScrollbar::updateScrollbarPart):
rendering/RenderScrollbar.h:

11:43 AM Changeset in webkit [37485] by cmarrin@apple.com

4 edits
2 adds in trunk

2008-10-10 Chris Marrin <cmarrin@apple.com>

Reviewed by Dan Bernstein.

Fix for https://bugs.webkit.org/show_bug.cgi?id=21025
CSS transition with duration=0 and delay=0 doesn't override ongoing transition

Test: transitions/interrupt-zero-duration.html

page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions):

11:04 AM Changeset in webkit [37484] by cmarrin@apple.com

10 edits in trunk/WebCore

2008-10-09 Chris Marrin <cmarrin@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=21310

Redesigned how animation events are sent in order to get rid of
AnimationEventDispatcher. ImplicitAnimation and KeyframeAnimation
are now ref counted. While calling the event handler, I keep a
reference to this class to avoid it getting destroyed out from under me.

I also moved most of the functionality of CompositeAnimation to
and internal class (CompositeAnimationPrivate) to reduce the exposure
of the internals of the various animation classes.

We have several transition and animation LayoutTests which verify that
this fix works as expected and continues to avoid crashes.

10:13 AM Changeset in webkit [37483] by kevino@webkit.org

2 edits in trunk/WebCore

wx build fix. Add new scrollbar-related sources.

9:59 AM Changeset in webkit [37482] by hyatt@apple.com

3 edits
4 adds in trunk

WebCore:

2008-10-10 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21522

Support increment/decrement/start/end on scrollbars. Allows a fully functional scrollbar to be
created. (Just :hover/:active left to finish it up.)

Reviewed by Adam Roben

Added scrollbars/scrollbar-buttons.html

css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):

LayoutTests:

2008-10-10 David Hyatt <hyatt@apple.com>

Add test for scrollbar buttons and track supporting increment/decrement/start/end.

Reviewed by Adam Roben

platform/mac/scrollbars/scrollbar-buttons-expected.checksum: Added.
platform/mac/scrollbars/scrollbar-buttons-expected.png: Added.
platform/mac/scrollbars/scrollbar-buttons-expected.txt: Added.
scrollbars/scrollbar-buttons.html: Added.

9:40 AM Changeset in webkit [37481] by hyatt@apple.com

1 edit in trunk/LayoutTests/scrollbars/scrollbar-orientation.html

Land updated layout test after pseudoclass rename.

9:40 AM Changeset in webkit [37480] by hyatt@apple.com

4 edits in trunk/WebCore

2008-10-10 David Hyatt <hyatt@apple.com>

Rename some pseudoclasses. Removing "-scrollbar-" from a bunch of the pseudoclasses. Renaming
back/forward to decrement/increment. Adding start/end pseudoclasses.

Reviewed by Eric Seidel

css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
css/CSSSelector.h: (WebCore::CSSSelector::):
css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):

12:18 AM Changeset in webkit [37479] by weinig@apple.com

3 edits in trunk/JavaScriptCore

2008-10-10 Sam Weinig <sam@webkit.org>

Reviewed by Cameron Zwarich.

Remove now unused m_getterSetterFlag variable from PropertyMap.

kjs/PropertyMap.cpp: (JSC::PropertyMap::operator=):
kjs/PropertyMap.h: (JSC::PropertyMap::PropertyMap):

12:15 AM Changeset in webkit [37478] by hyatt@apple.com

1 edit in trunk/WebCore/css/CSSStyleSelector.cpp

Fix build.

12:15 AM Changeset in webkit [37477] by hyatt@apple.com

4 edits in trunk/WebCore

2008-10-10 David Hyatt <hyatt@apple.com>

Switch window-active to window-inactive, since that will work better as far as degrading in other
browsers.

Reviewed by Tim Hatcher

css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
css/CSSSelector.h: (WebCore::CSSSelector::):
css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):

12:06 AM Changeset in webkit [37476] by timothy@apple.com

1 edit in trunk/WebCore/bindings/objc/WebScriptObject.h

Yet another Tiger build fix.

12:04 AM Changeset in webkit [37475] by hyatt@apple.com

9 edits
4 adds in trunk

WebCore:

2008-10-09 David Hyatt <hyatt@apple.com>

Add support for scrollbar orientation as a pseudoclass. Add support for whether or not the scrollbar
is active as well.

Reviewed by Tim Hatcher

Added scrollbars/scrollbar-orientation.html

css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
css/CSSSelector.h: (WebCore::CSSSelector::):
css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
platform/Scrollbar.cpp: (WebCore::Scrollbar::isWindowActive):
platform/Scrollbar.h:
rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::paint): (WebCore::RenderScrollbar::partForStyleResolve):
rendering/RenderScrollbar.h:

LayoutTests:

2008-10-09 David Hyatt <hyatt@apple.com>

Add layout test for scrollbars honoring orientation and window active state.

Reviewed by Tim Hatcher

platform/mac/scrollbars/scrollbar-orientation-expected.checksum: Added.
platform/mac/scrollbars/scrollbar-orientation-expected.png: Added.
platform/mac/scrollbars/scrollbar-orientation-expected.txt: Added.
scrollbars/scrollbar-orientation.html: Added.

Oct 9, 2008:

11:39 PM Changeset in webkit [37474] by timothy@apple.com

3 edits in trunk/WebKit/mac

Another build fix.

11:12 PM Changeset in webkit [37473] by timothy@apple.com

3 edits in trunk

Full build fix for the fail on Tiger.

10:56 PM Changeset in webkit [37472] by hyatt@apple.com

8 edits
4 adds in trunk

WebCore:

2008-10-09 David Hyatt <hyatt@apple.com>

Add support for pseudo classes on scrollbar pseudo elements. As an initial proof of concept only
:enabled/:disabled are supported. More pseudo classes will follow quickly now that this works.

Reviewed by Tim Hatcher

Added scrollbars/disabled-scrollbar.html

css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkSelector): (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
css/CSSStyleSelector.h:
rendering/RenderObject.cpp: (WebCore::RenderObject::getPseudoStyle):
rendering/RenderObject.h:
rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::setEnabled): (WebCore::RenderScrollbar::scrollbarForStyleResolve): (WebCore::RenderScrollbar::getScrollbarPseudoStyle): (WebCore::RenderScrollbar::paintPart):
rendering/RenderScrollbar.h:

LayoutTests:

2008-10-09 David Hyatt <hyatt@apple.com>

Add test case for disabled scrollbars.

Reviewed by Tim Hatcher

platform/mac/scrollbars/disabled-scrollbar-expected.checksum: Added.
platform/mac/scrollbars/disabled-scrollbar-expected.png: Added.
platform/mac/scrollbars/disabled-scrollbar-expected.txt: Added.
scrollbars/disabled-scrollbar.html: Added.

9:34 PM Changeset in webkit [37471] by timothy@apple.com

2 edits in trunk

Tiger build fix.

9:04 PM Changeset in webkit [37470] by eric.carlson@apple.com

5 edits in trunk/WebCore

2008-10-09 Eric Carlson <eric.carlson@apple.com>

Media controls should not show when element is not visible

https://bugs.webkit.org/show_bug.cgi?id=21155

Reviewed by Adele Peterson.

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::recalcStyle): New, call renderer()->updateFromElement to stay in sync with visibility changes
html/HTMLMediaElement.h:
rendering/RenderMedia.cpp: (WebCore::RenderMedia::RenderMedia): initialize m_previousVisible (WebCore::RenderMedia::updateControlVisibility): consider style()->visibility() when determining if element is visible or not. Don't animate controller visibility when change triggered by showing or hiding media element.
rendering/RenderMedia.h: declare m_previousVisible

8:42 PM Changeset in webkit [37469] by hyatt@apple.com

1 edit in trunk/WebCore/GNUmakefile.am

Fix Gtk bustage.

8:41 PM Changeset in webkit [37468] by hyatt@apple.com

1 edit in trunk/WebCore/WebCore.pro

Fix Qt bustage.

8:37 PM Changeset in webkit [37467] by hyatt@apple.com

1 edit in trunk/WebCore/platform/win/ScrollbarThemeWin.cpp

Fix Windows bustage.

8:25 PM Changeset in webkit [37466] by hyatt@apple.com

1 edit in trunk/WebCore/ChangeLog

Fix typo in my Changelog comment

8:23 PM Changeset in webkit [37465] by timothy@apple.com

15 edits in trunk

Annotate the Objective-C DOM APIs with the JavaScriptCore/WebKitAvailability.h availability macros and version macros.

WebCore:

2008-10-09 Timothy Hatcher <timothy@apple.com>

Annotate the Objective-C DOM APIs with the JavaScriptCore/WebKitAvailability.h
availability macros and version macros.

https://bugs.webkit.org/show_bug.cgi?id=21496
rdar://problem/6259225

Reviewed by Sam Weinig.

bindings/objc/DOMCSS.h: Add a version #if around catgory interface.
bindings/objc/DOMEventException.h: Include JavaScriptCore/WebKitAvailability.h and add an #if around the enum.
bindings/objc/DOMException.h: Ditto. Give the enum a name and remove the comment to match the other headers.
bindings/objc/DOMExtensions.h: Annotate the methods with version 3.0 or later.
bindings/objc/DOMObject.h: Add a version #if around class interface.
bindings/objc/DOMRangeException.h: Include JavaScriptCore/WebKitAvailability.h and add a version #if around the enum.
bindings/objc/DOMSVGException.h: Ditto. Use the latest version since SVG is new.
bindings/objc/DOMXPathException.h: Ditto. Use the 3.0 version.
bindings/objc/PublicDOMInterfaces.h: Annotate classes and protocols for when they where added to WebKit. Also annotate individual methods that are deprecated or where added after the class was added to WebKit.
bindings/objc/WebScriptObject.h: Include JavaScriptCore/WebKitAvailability.h since this header is included by most DOM headers. Annotate the JSObject method.

bindings/scripts/CodeGeneratorObjC.pm: (ReadPublicInterfaces): Parse out the availability macro for each function/property. And parse out the availability version for the class/protocol. Default to WEBKIT_VERSION_LATEST if the class is new. (GenerateHeader): Include JavaScriptCore/WebKitAvailability.h if needed. Add the interface availability version check if the class has a required version. Create a public interface key (used to lookup in $publicInterfaces) and make a declaration suffix that includes the availability macro (if needed). Use the "available in 1.3 and later but deprecated in 3.0" macro instead of "deprecated in 10.5 and later" as the default availability macro for old style methods. Tweak line breaks in the generated headers to look good and not have too many extra lines.

WebKit/mac:

2008-10-09 Timothy Hatcher <timothy@apple.com>

Don't convert JavaScriptCore header include paths to WebKit paths. This was needed
back when NPAPI and WebScriptObject migrated from JavaScriptCore. Also remove
JavaScriptCore from the VPATH.

Reviewed by Sam Weinig.

MigrateHeaders.make:

8:15 PM Changeset in webkit [37464] by Simon Fraser

47 edits in trunk/WebCore

2008-10-09 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=20947

Refactor setStyle() methods into styleWillChange()
and styleDidChange(), so most of the setStyle() overrides can
be removed.

8:13 PM Changeset in webkit [37463] by hyatt@apple.com

3 edits in trunk/WebCore

2008-10-09 David Hyatt <hyatt@apple.com>

Make sure to destroy a custom scrollbar's RenderObject's before the arena goes away. When our widget
parent is nulled out is a good time.

Reviewed by Oliver Hunt

rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::~RenderScrollbar): (WebCore::RenderScrollbar::setParent): (WebCore::RenderScrollbar::updateScrollbarPart):
rendering/RenderScrollbar.h:

7:33 PM Changeset in webkit [37462] by hyatt@apple.com

19 edits
12 adds in trunk

WebCore:

2008-10-09 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21446

This patch gets CSS scrollbars up and limping. There's no way to distinguish between states or between
orientation and back vs. forward on the buttons, but it's a start.

Reviewed by Oliver Hunt

Added scrollbars/basic-scrollbar.html

WebCore.xcodeproj/project.pbxproj:
css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
css/CSSSelector.h: (WebCore::CSSSelector::):
css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
platform/ScrollTypes.h: (WebCore::):
platform/Scrollbar.h: (WebCore::Scrollbar::styleChanged):
platform/ScrollbarThemeComposite.cpp: (WebCore::ScrollbarThemeComposite::paint): (WebCore::ScrollbarThemeComposite::splitTrack):
platform/ScrollbarThemeComposite.h: (WebCore::ScrollbarThemeComposite::paintScrollbarBackground): (WebCore::ScrollbarThemeComposite::paintTrackBackground): (WebCore::ScrollbarThemeComposite::paintTrackPiece):
platform/win/ScrollbarThemeSafari.cpp: (WebCore::ScrollbarThemeSafari::paintTrackBackground):
platform/win/ScrollbarThemeSafari.h:
platform/win/ScrollbarThemeWin.cpp: (WebCore::ScrollbarThemeWin::paintTrack):
platform/win/ScrollbarThemeWin.h:
rendering/RenderLayer.cpp: (WebCore::RenderLayer::createScrollbar): (WebCore::RenderLayer::styleChanged):
rendering/RenderScrollbar.cpp: Added. (WebCore::RenderScrollbar::createCustomScrollbar): (WebCore::RenderScrollbar::RenderScrollbar): (WebCore::RenderScrollbar::~RenderScrollbar): (WebCore::RenderScrollbar::getScrollbarPseudoStyle): (WebCore::RenderScrollbar::updateScrollbarParts): (WebCore::RenderScrollbar::updateScrollbarPart): (WebCore::RenderScrollbar::paintPart): (WebCore::RenderScrollbar::buttonRect): (WebCore::RenderScrollbar::minimumThumbLength):
rendering/RenderScrollbar.h: Added. (WebCore::RenderScrollbar::styleChanged): (WebCore::RenderScrollbar::owningRenderer):
rendering/RenderScrollbarPart.cpp: Added. (WebCore::RenderScrollbarPart::RenderScrollbarPart): (WebCore::RenderScrollbarPart::~RenderScrollbarPart): (WebCore::RenderScrollbarPart::layout): (WebCore::RenderScrollbarPart::layoutHorizontalPart): (WebCore::RenderScrollbarPart::layoutVerticalPart): (WebCore::calcScrollbarThicknessUsing): (WebCore::RenderScrollbarPart::computeScrollbarWidth): (WebCore::RenderScrollbarPart::computeScrollbarHeight): (WebCore::RenderScrollbarPart::calcPrefWidths): (WebCore::RenderScrollbarPart::setStyle):
rendering/RenderScrollbarPart.h: Added. (WebCore::RenderScrollbarPart::renderName): (WebCore::RenderScrollbarPart::requiresLayer):
rendering/RenderScrollbarTheme.cpp: Added. (WebCore::RenderScrollbarTheme::renderScrollbarTheme): (WebCore::RenderScrollbarTheme::buttonSizesAlongTrackAxis): (WebCore::RenderScrollbarTheme::hasButtons): (WebCore::RenderScrollbarTheme::hasThumb): (WebCore::RenderScrollbarTheme::minimumThumbLength): (WebCore::RenderScrollbarTheme::backButtonRect): (WebCore::RenderScrollbarTheme::forwardButtonRect): (WebCore::RenderScrollbarTheme::trackRect): (WebCore::RenderScrollbarTheme::paintScrollCorner): (WebCore::RenderScrollbarTheme::paintScrollbarBackground): (WebCore::RenderScrollbarTheme::paintTrackBackground): (WebCore::RenderScrollbarTheme::paintTrackPiece): (WebCore::RenderScrollbarTheme::paintButton): (WebCore::RenderScrollbarTheme::paintThumb):
rendering/RenderScrollbarTheme.h: Added. (WebCore::RenderScrollbarTheme::~RenderScrollbarTheme): (WebCore::RenderScrollbarTheme::scrollbarThickness): (WebCore::RenderScrollbarTheme::buttonsPlacement): (WebCore::RenderScrollbarTheme::supportsControlTints): (WebCore::RenderScrollbarTheme::shouldCenterOnThumb): (WebCore::RenderScrollbarTheme::initialAutoscrollTimerDelay): (WebCore::RenderScrollbarTheme::autoscrollTimerDelay): (WebCore::RenderScrollbarTheme::registerScrollbar): (WebCore::RenderScrollbarTheme::unregisterScrollbar):
rendering/style/RenderStyle.h: (WebCore::RenderStyle::):

LayoutTests:

2008-10-09 David Hyatt <hyatt@apple.com>

Land layout test for CSS scrollbars.

Reviewed by Oliver Hunt

platform/mac/scrollbars: Added.
platform/mac/scrollbars/basic-scrollbar-expected.checksum: Added.
platform/mac/scrollbars/basic-scrollbar-expected.png: Added.
platform/mac/scrollbars/basic-scrollbar-expected.txt: Added.
scrollbars: Added.
scrollbars/basic-scrollbar.html: Added.

7:27 PM Changeset in webkit [37461] by eric@webkit.org

3 edits
7 adds in trunk

Reviewed by Oliver Hunt.

Test cases for https://bugs.webkit.org/show_bug.cgi?id=21498

fast/canvas/gradient-with-clip-expected.txt: Added.
fast/canvas/gradient-with-clip.html: Added.
fast/canvas/pattern-with-transform-expected.txt: Added.
fast/canvas/pattern-with-transform.html: Added.
fast/canvas/resources/TEMPLATE.html: Copied from LayoutTests/fast/dom/resources/TEMPLATE.html.
fast/canvas/resources/gradient-with-clip.js: Added.
fast/canvas/resources/pattern-with-transform.js: Added.

7:26 PM Changeset in webkit [37460] by eric@webkit.org

2 edits in trunk/WebCore

Reviewed by Oliver Hunt.

Fix Canvex DOOM Game
Gradient clips were not getting cleared after filling the
gradient, this was causing nothing to draw in Canvex
https://bugs.webkit.org/show_bug.cgi?id=21498

Tests forthcoming.

WebCore.xcodeproj/project.pbxproj:
platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect):

7:17 PM Changeset in webkit [37459] by cwzwarich@webkit.org

2 edits in trunk/WebKitTools

2008-10-09 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Add StructureID.o to the exclusion list in the global initializers
script to fix the Debug build.

Scripts/check-for-global-initializers:

6:21 PM Changeset in webkit [37458] by weinig@apple.com

2 edits in trunk/JavaScriptCore

2008-10-09 Sam Weinig <sam@webkit.org>

Reviewed by Maciej Stachowiak.

Add leaks checking to StructureID.

kjs/StructureID.cpp: (JSC::StructureID::StructureID): (JSC::StructureID::~StructureID):

5:50 PM Changeset in webkit [37457] by alp@webkit.org

11 edits in trunk

2008-10-09 Alp Toker <alp@nuanti.com>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=20760
Implement support for x86 Linux in CTI

Prepare to enable CTI/WREC on supported architectures.

Make it possible to use the CTI_ARGUMENT workaround with GCC as well
as MSVC by fixing some preprocessor conditionals.

Note that CTI/WREC no longer requires CTI_ARGUMENT on Linux so we
don't actually enable it except when building with MSVC. GCC on Win32
remains untested.

Adapt inline ASM code to use the global symbol underscore prefix only
on Darwin and to call the properly mangled Machine::cti_vm_throw
symbol name depending on CTI_ARGUMENT.

Also avoid global inclusion of the JIT infrastructure headers
throughout WebCore and WebKit causing recompilation of about ~1500
source files after modification to X86Assembler.h, CTI.h, WREC.h,
which are only used deep inside JavaScriptCore.

5:08 PM Changeset in webkit [37456] by eric@webkit.org

55 edits in trunk

Reviewed by Oliver Hunt.

Fix transformed patterns
https://bugs.webkit.org/show_bug.cgi?id=21498

Test: fast/canvas/patternfill-repeat.html

WebCore.xcodeproj/project.pbxproj:
platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setStrokePattern): (WebCore::GraphicsContext::setFillPattern): (WebCore::GraphicsContext::setStrokeGradient): (WebCore::GraphicsContext::setFillGradient):
platform/graphics/GraphicsContext.h:
platform/graphics/cairo/GraphicsContextCairo.cpp:
platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::applyStrokePattern): (WebCore::applyFillPattern): (WebCore::GraphicsContext::drawPath): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect):
platform/graphics/qt/GraphicsContextQt.cpp:
platform/graphics/wx/GraphicsContextWx.cpp:

5:04 PM Changeset in webkit [37455] by cmarrin@apple.com

1 edit
4 adds in trunk/LayoutTests

2008-10-09 Chris Marrin <cmarrin@apple.com>

Reviewed by Darin Adler.

More testcases for animation using font metrics
https://bugs.webkit.org/show_bug.cgi?id=21246

animations/font-size-using-ems-expected.txt: Added.
animations/font-size-using-ems.html: Added.
animations/width-using-ems-expected.txt: Added.
animations/width-using-ems.html: Added.

4:59 PM Changeset in webkit [37454] by cmarrin@apple.com

2 edits in trunk/WebCore

2008-10-09 Chris Marrin <cmarrin@apple.com>

Reviewed by Darin Adler.

Fix for https://bugs.webkit.org/show_bug.cgi?id=21217
Animations assert when navigating from page

Changed assertions to test the right flag for the paused state

page/animation/AnimationBase.cpp: (WebCore::AnimationBase::updateStateMachine):

4:59 PM Changeset in webkit [37453] by barraclough@apple.com

6 edits in trunk

JavaScriptCore:

2008-10-09 Gavin Barraclough <barraclough@apple.com>

Reviewed by Cameron Zwarich.

Fix for bug #21160, x=0;1/(x*-1) == -Infinity

ChangeLog:
VM/CTI.cpp: (JSC::CTI::emitFastArithDeTagImmediate): (JSC::CTI::emitFastArithDeTagImmediateJumpIfZero): (JSC::CTI::compileBinaryArithOp): (JSC::CTI::compileBinaryArithOpSlowCase): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases):
VM/CTI.h:
masm/X86Assembler.h: (JSC::X86Assembler::): (JSC::X86Assembler::emitUnlinkedJs):

LayoutTests:

2008-10-09 Gavin Barraclough <barraclough@apple.com>

Reviewed by Cameron Zwarich.

Correct results for -0 cases.

fast/js/math-transforms-expected.txt:

4:44 PM Changeset in webkit [37452] by kevino@webkit.org

8 edits in trunk

wx build fixes.

4:04 PM Changeset in webkit [37451] by cmarrin@apple.com

3 edits
2 adds in trunk

2008-10-09 Chris Marrin <cmarrin@apple.com>

Reviewed by Dan Bernstein.

Fixed > 180 degree rotation bug
Ensure that validateTransformFunctionList() is called after updating keyframe styles

https://bugs.webkit.org/show_bug.cgi?id=21420

Test: animations/big-rotation.html

page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::KeyframeAnimation):

2:47 PM Changeset in webkit [37450] by cwzwarich@webkit.org

3 edits in trunk/JavaScriptCore

2008-10-09 Cameron Zwarich <zwarich@apple.com>

Reviewed by Oliver Hunt.

Bug 21459: REGRESSION (r37324): Safari crashes inside JavaScriptCore while browsing hulu.com
<https://bugs.webkit.org/show_bug.cgi?id=21459>

After r37324, an Arguments object does not mark an associated activation
object. This change was made because Arguments no longer directly used
the activation object in any way. However, if an activation is torn off,
then the backing store of Arguments becomes the register array of the
activation object. Arguments directly marks all of the arguments, but
the activation object is being collected, which causes its register
array to be freed and new memory to be allocated in its place.

Unfortunately, it does not seem possible to reproduce this issue in a
layout test.

kjs/Arguments.cpp: (JSC::Arguments::mark):
kjs/Arguments.h: (JSC::Arguments::setActivation): (JSC::Arguments::Arguments): (JSC::JSActivation::copyRegisters):

1:43 PM Changeset in webkit [37449] by beidson@apple.com

2 edits in trunk/WebCore

2008-10-09 Brady Eidson <beidson@apple.com>

Reviewed by Anders

<rdar://problem/6250856> - Calling [WebView close] from within a redirection callback can cause bad things

The API usage to reveal this crash was so particular that a layout test is not possible with our current infrastructure.

loader/FrameLoader.cpp: (WebCore::FrameLoader::changeLocation): Protect the Frame from deletion (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): stopAllLoaders() might clear the Frame's page, so perform a second null check on the page. Bail if it has been cleared.

9:21 AM Changeset in webkit [37448] by alp@webkit.org