⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 11, 2008:

11:50 PM Changeset in webkit [37521] by alp@webkit.org
  • 3 edits in trunk/WebCore

2008-10-11 Alp Toker <​alp@nuanti.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=20592
The focus ring is not shown while navigating on some pages

Fix drawFocusRing() so it doesn't depend on the current graphics
state, thus matching other platforms which already work this way.

This patch provides two code paths: one using straight Cairo and
one specialised for the GTK+ port with a more conventional appearance.

Also change focusRingColor() to return a null color, allowing the
focus ring to pick up the style's current color if it isn't overridden
with CSS.

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawFocusRing):
  • platform/gtk/TemporaryLinkStubs.cpp: (WebCore::focusRingColor):
10:00 PM Changeset in webkit [37520] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-10-11 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Sam Weinig.

Clean up RegExpMatchesArray.h to match our coding style.

  • kjs/RegExpMatchesArray.h: (JSC::RegExpMatchesArray::getOwnPropertySlot): (JSC::RegExpMatchesArray::put): (JSC::RegExpMatchesArray::deleteProperty): (JSC::RegExpMatchesArray::getPropertyNames):
9:56 PM Changeset in webkit [37519] by mitz@apple.com
  • 2 edits in trunk/WebCore

Rubber-stamped by Sam Weinig.

  • change all internal callers to use Cache::evict() instead of remove()
  • loader/Cache.cpp: (WebCore::Cache::revalidateResource): (WebCore::Cache::revalidationSucceeded): (WebCore::Cache::pruneDeadResources): (WebCore::Cache::setDisabled):
9:26 PM Changeset in webkit [37518] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2008-10-11 David Hyatt <​hyatt@apple.com>

Make sure invalidatePart knows how to invalidate the track and scrollbar backgrounds.

Reviewed by Tim Hatcher

  • platform/ScrollbarThemeComposite.cpp: (WebCore::ScrollbarThemeComposite::invalidatePart):
9:20 PM Changeset in webkit [37517] by hyatt@apple.com
  • 6 edits in trunk/WebCore

2008-10-11 David Hyatt <​hyatt@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=21549 (regression in before/after track pieces).

Also fixed resizer positioning problems.

Reviewed by Tim Hatcher

  • platform/ScrollbarThemeComposite.cpp: (WebCore::ScrollbarThemeComposite::splitTrack): (WebCore::ScrollbarThemeComposite::trackPosition): (WebCore::ScrollbarThemeComposite::trackLength):
  • platform/ScrollbarThemeComposite.h: (WebCore::ScrollbarThemeComposite::constrainTrackRectToTrackPieces):
  • rendering/RenderLayer.cpp: (WebCore::scrollCornerRect): (WebCore::RenderLayer::positionOverflowControls): (WebCore::RenderLayer::paintOverflowControls): (WebCore::RenderLayer::isPointInResizeControl): (WebCore::RenderLayer::hitTestOverflowControls):
  • rendering/RenderScrollbarTheme.cpp: (WebCore::RenderScrollbarTheme::constrainTrackRectToTrackPieces):
  • rendering/RenderScrollbarTheme.h:
8:48 PM Changeset in webkit [37516] by mrowe@apple.com
  • 1 edit in branches/Safari-3-2-branch/JavaScriptCore/wtf/ASCIICType.h

Merge ASCIICType.h portion of r36244.

8:33 PM Changeset in webkit [37515] by alp@webkit.org
  • 3 edits in trunk/WebCore

2008-10-11 Alp Toker <​alp@nuanti.com>

Reviewed by David Hyatt.

Implement release/retain for Widget GTK+.

  • platform/Widget.cpp:
  • platform/gtk/WidgetGtk.cpp: (WebCore::Widget::~Widget): (WebCore::Widget::releasePlatformWidget): (WebCore::Widget::retainPlatformWidget):
6:38 PM Changeset in webkit [37514] by mrowe@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fix ChangeLog header that was mangled in r37484.

6:31 PM Changeset in webkit [37513] by mrowe@apple.com
  • 1 move in trunk/LayoutTests/animations/font-size-using-ems.html-disabled

Disable animations/font-size-using-ems.html as it has been causing the following test, animatinos/generic-from-to.html, to hang since it was added.

4:10 PM Changeset in webkit [37512] by mitz@apple.com
  • 4 edits in trunk/WebKitTools

Reviewed by Sam Weinig and Anders Carlsson.

  • update Mac DumpRenderTree to use the new WebView SPI for forcing the complex text code path
  • add --complex-text support to Windows DumpRenderTree
  • DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree):
  • DumpRenderTree/win/DumpRenderTree.cpp: (createWebViewAndOffscreenWindow): (main):
  • Scripts/run-webkit-tests:
3:53 PM Changeset in webkit [37511] by mitz@apple.com
  • 15 edits in trunk

WebCore:

Reviewed by Sam Weinig.

  • rename WebCoreSetAlwaysUseATSU to WebCoreSetAlwaysUsesComplexTextCodePath and add a corresponding getter; add the same functions on Windows
  • WebCore.base.exp:
  • platform/graphics/Font.cpp: (WebCore::Font::setCodePath): (WebCore::codePath): (WebCore::Font::canUseGlyphCache):
  • platform/graphics/Font.h:
  • platform/mac/WebCoreTextRenderer.h:
  • platform/mac/WebCoreTextRenderer.mm: (WebCoreSetAlwaysUsesComplexTextCodePath): (WebCoreAlwaysUsesComplexTextCodePath):
  • platform/win/WebCoreTextRenderer.cpp: (WebCore::WebCoreSetAlwaysUsesComplexTextCodePath): (WebCore::WebCoreAlwaysUsesComplexTextCodePath):
  • platform/win/WebCoreTextRenderer.h:

WebKit/mac:

Reviewed by Sam Weinig.

  • rename _setAlwaysUseATSU to _setAlwaysUsesComplexTextCodePath and update it for the renamed WebCoreTextRenderer method; keep the old method around for clients that use it
  • WebView/WebView.mm: (+[WebView _setAlwaysUseATSU:]): (+[WebView _setAlwaysUsesComplexTextCodePath:]):
  • WebView/WebViewPrivate.h:

WebKit/win:

Reviewed by Sam Weinig.

  • add SPI for forcing the complex text code path to be used for all text
  • Interfaces/IWebViewPrivate.idl:
  • WebView.cpp: (WebView::setAlwaysUsesComplexTextCodePath): (WebView::alwaysUsesComplexTextCodePath):
  • WebView.h:
3:20 PM Changeset in webkit [37510] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-10-11 Sam Weinig <​sam@webkit.org>

Reviewed by Cameron Zwarich.

Stop leaking the event parameter names. The protected strings were showing up
in the caches window after one use. No measurable performance loss.

  • bindings/js/JSEventListener.cpp: (WebCore::eventParameterName):
3:10 PM Changeset in webkit [37509] by weinig@apple.com
  • 3 edits in trunk/WebCore

2008-10-11 Sam Weinig <​sam@webkit.org>

Reviewed by Cameron Zwarich.

Remove unused function getNodeEventListener.

  • bindings/js/JSEventListener.cpp:
  • bindings/js/JSEventListener.h:
1:58 PM Changeset in webkit [37508] by cwzwarich@webkit.org
  • 3 edits in trunk/JavaScriptCore

2008-10-11 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Sam Weinig.

Bug 21525: 55 StructureID leaks on Wikitravel's main page
<​https://bugs.webkit.org/show_bug.cgi?id=21525>

Bug 21533: Simple JavaScript code leaks StructureIDs
<​https://bugs.webkit.org/show_bug.cgi?id=21533>

StructureID::getEnumerablePropertyNames() ends up calling back to itself
via JSObject::getPropertyNames(), which causes the PropertyNameArray to
be cached twice. This leads to a memory leak in almost every use of
JSObject::getPropertyNames() on an object. The fix here is based on a
suggestion of Sam Weinig.

This patch also fixes every StructureID leaks that occurs while running
the Mozilla MemBuster test.

  • kjs/PropertyNameArray.h: (JSC::PropertyNameArray::PropertyNameArray): (JSC::PropertyNameArray::setCacheable): (JSC::PropertyNameArray::cacheable):
  • kjs/StructureID.cpp: (JSC::StructureID::getEnumerablePropertyNames):
12:50 AM Changeset in webkit [37507] by hyatt@apple.com
  • 8 edits in trunk/WebCore

2008-10-11 David Hyatt <​hyatt@apple.com>

Add support for both positive and negative margins to tracks and track pieces.

Reviewed by Tim Hatcher

  • platform/ScrollbarThemeComposite.cpp: (WebCore::ScrollbarThemeComposite::paint): (WebCore::ScrollbarThemeComposite::hitTest): (WebCore::ScrollbarThemeComposite::splitTrack): (WebCore::ScrollbarThemeComposite::trackPieceRects): (WebCore::ScrollbarThemeComposite::trackPosition): (WebCore::ScrollbarThemeComposite::trackLength):
  • platform/ScrollbarThemeComposite.h: (WebCore::ScrollbarThemeComposite::adjustTrackPieceRect):
  • rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::trackRect): (WebCore::RenderScrollbar::trackPieceRectWithMargins):
  • rendering/RenderScrollbar.h:
  • rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::computeScrollbarWidth): (WebCore::RenderScrollbarPart::computeScrollbarHeight):
  • rendering/RenderScrollbarTheme.cpp: (WebCore::RenderScrollbarTheme::adjustTrackPieceRect):
  • rendering/RenderScrollbarTheme.h:

Oct 10, 2008:

11:33 PM Changeset in webkit [37506] by hyatt@apple.com
  • 4 edits in trunk/LayoutTests/scrollbars

Update scrollbars layout tests to new syntax.

11:30 PM Changeset in webkit [37505] by hyatt@apple.com
  • 4 edits in trunk/WebCore

2008-10-10 David Hyatt <​hyatt@apple.com>

Drop -webkit-scrollbar- from all the scrollbar pseudo-classes, since they are scoped to
the scrollbar pseudo-elements anyway.

Reviewed by Tim Hatcher

  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
11:26 PM Changeset in webkit [37504] by mitz@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Sam Weinig.

  • separate Cache::remove() into a private method and a public interface, then make Cache::pruneDeadResources() use the private method.
  • loader/Cache.cpp: (WebCore::Cache::pruneDeadResources): (WebCore::Cache::evict):
  • loader/Cache.h: (WebCore::Cache::remove):
11:12 PM Changeset in webkit [37503] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2008-10-10 David Hyatt <​hyatt@apple.com>

Fix a math error when splitting a vertical track. Clean up more of ScrollbarThemeComposite
now that the track pieces meet under the thumb.

Reviewed by Tim Hatcher

  • platform/ScrollbarThemeComposite.cpp: (WebCore::ScrollbarThemeComposite::paint): (WebCore::ScrollbarThemeComposite::splitTrack):
11:04 PM Changeset in webkit [37502] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2008-10-10 David Hyatt <​hyatt@apple.com>

Make the track pieces of a scrollbar extend under the thumb (each gets half the thumb).

Reviewed by Tim Hatcher

  • platform/ScrollbarThemeComposite.cpp: (WebCore::ScrollbarThemeComposite::hitTest): (WebCore::ScrollbarThemeComposite::splitTrack):
10:54 PM Changeset in webkit [37501] by hyatt@apple.com
  • 5 edits in trunk/WebCore

2008-10-10 David Hyatt <​hyatt@apple.com>

Make sure specialized ::scrollbar rules are still triggering custom scrollbar creation.

Reviewed by Tim Hatcher

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::createScrollbar):
  • rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::createCustomScrollbar): (WebCore::RenderScrollbar::RenderScrollbar): (WebCore::RenderScrollbar::setParent): (WebCore::RenderScrollbar::updateScrollbarParts): (WebCore::RenderScrollbar::updateScrollbarPart):
  • rendering/RenderScrollbar.h:
  • rendering/style/RenderStyle.h: (WebCore::RenderStyle::):
10:49 PM Changeset in webkit [37500] by oliver@apple.com
  • 4 edits in trunk/JavaScriptCore

Use fastcall calling convention on GCC > 4.0

Reviewed by Cameron Zwarich

Results in a 2-3% improvement in GCC 4.2 performance, so
that it is no longer a regression vs. GCC 4.0

10:30 PM Changeset in webkit [37499] by hyatt@apple.com
  • 4 edits in trunk/WebCore

2008-10-10 David Hyatt <​hyatt@apple.com>

Make sure scrollbar background images cause proper part invalidation to occur.

Reviewed by Tim Hatcher

  • rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::setHoveredPart): (WebCore::RenderScrollbar::setPressedPart):
  • rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::styleDidChange): (WebCore::RenderScrollbarPart::imageChanged):
  • rendering/RenderScrollbarPart.h:
7:53 PM Changeset in webkit [37498] by weinig@apple.com
  • 8 edits in trunk

JavaScriptCore:

2008-10-10 Sam Weinig <​sam@webkit.org>

Reviewed by Darin Adler.

  • Add a workaround for a bug in ceil in Darwin libc.
  • Remove old workarounds for JS math functions that are not needed anymore.

The math functions are heavily tested by fast/js/math.html.

  • kjs/MathObject.cpp: (JSC::mathProtoFuncAbs): Remove workaround. (JSC::mathProtoFuncCeil): Ditto. (JSC::mathProtoFuncFloor): Ditto.
  • wtf/MathExtras.h: (wtf_ceil): Add ceil workaround for darwin.

LayoutTests:

2008-10-10 Sam Weinig <​sam@webkit.org>

Reviewed by Darin Adler.

  • Update tests after fixing ceil(-0.1) behavior on darwin.
  • fast/js/math-expected.txt:
  • fast/js/resources/math.js: Remove code to detect sign of 0 now that the harness can handle it.
  • fast/xpath/4XPath/Core/test_core_functions-expected.txt:
  • fast/xpath/4XPath/Core/test_core_functions.html: Update test expect correct result of -0.
7:05 PM Changeset in webkit [37497] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-10-10 Sam Weinig <​sam@webkit.org>

Reviewed by Darin Adler

Add Assertions to JSObject constructor.

  • kjs/JSObject.h: (JSC::JSObject::JSObject):
5:35 PM Changeset in webkit [37496] by Simon Fraser
  • 3 edits
    2 adds in trunk

2008-10-10 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler

​https://bugs.webkit.org/show_bug.cgi?id=21538

The blendFunc() for TransformOperations should never mess with the
operation lists by replacing some ops with identity, otherwise the lists
no longer match and transitions break.

Test: transitions/matched-transform-functions.html

  • page/animation/AnimationBase.cpp: (WebCore::blendFunc):
5:32 PM Changeset in webkit [37495] by Simon Fraser
  • 3 edits
    2 adds in trunk

2008-10-10 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler

​https://bugs.webkit.org/show_bug.cgi?id=21537

Fix re-targetting a running transition; if the target property
changes, we do need to make a new ImplicitAnimation.

Test: transitions/retargetted-transition.html

  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimationPrivate::updateTransitions):
4:21 PM Changeset in webkit [37494] by oliver@apple.com
  • 2 edits in trunk/WebCore

Part of <rdar://problem/6278147> Cannot stop a slow script -- Fix assertion

Reviewed by Cameron Zwarich

When JS is terminated by the user choosing to stop a slow script
the exception toString method throws, yet the console logger does
not perform exception checks after logging. This leaves an
exception on the Machine, which in turn results in an assertion
failure next time we attempt to enter JS. The solution is just to
clear the exception state after attempting to record the exception.

3:24 PM Changeset in webkit [37493] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2008-10-10 David Hyatt <​hyatt@apple.com>

Make textareas work with custom CSS scrollbars and resizers. Need to access the correct renderer
when looking for pseudo styles.

Reviewed by Tim Hatcher

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::createScrollbar): (WebCore::RenderLayer::styleChanged):
3:19 PM Changeset in webkit [37492] by dino@apple.com
  • 2 edits in trunk/WebKitSite/specs/CSSVisualEffects

2008-10-10 Dean Jackson <​dino@apple.com>

Keyframe example had "0" rather than "0%".

  • WebKitSite/specs/CSSVisualEffects/CSSAnimations.html:
3:16 PM Changeset in webkit [37491] by hyatt@apple.com
  • 10 edits in trunk/WebCore

2008-10-10 David Hyatt <​hyatt@apple.com>

Add the ability to style the scroll corner and the resizer from CSS.

Reviewed by Tim Hatcher

  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::~RenderLayer): (WebCore::RenderLayer::paintOverflowControls): (WebCore::RenderLayer::paintScrollCorner): (WebCore::RenderLayer::paintResizer): (WebCore::RenderLayer::styleChanged):
  • rendering/RenderLayer.h:
  • rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::updateScrollbarPart): (WebCore::RenderScrollbar::paintPart):
  • rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::RenderScrollbarPart): (WebCore::RenderScrollbarPart::paintIntoRect):
  • rendering/RenderScrollbarPart.h:
  • rendering/style/RenderStyle.h: (WebCore::RenderStyle::):
2:05 PM Changeset in webkit [37490] by hyatt@apple.com
  • 10 edits in trunk/WebCore

2008-10-10 David Hyatt <​hyatt@apple.com>

Make CSS scrollbars respect the OS setting regarding where buttons should be placed.

Reviewed by Sam Weinig

No test case possible, since the OS setting can vary.

  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
  • platform/Scrollbar.h: (WebCore::Scrollbar::styleChanged):
  • platform/mac/ScrollbarThemeMac.mm: (+[ScrollbarPrefsObserver appearancePrefsChanged:]): (WebCore::ScrollbarThemeMac::preferencesChanged):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::invalidateScrollbarRect):
  • rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::styleChanged): (WebCore::RenderScrollbar::updateScrollbarPart):
  • rendering/RenderScrollbar.h:
  • rendering/RenderScrollbarTheme.h: (WebCore::RenderScrollbarTheme::buttonsPlacement):
1:43 PM Changeset in webkit [37489] by adachan@apple.com
  • 3 edits in trunk/WebKit/win

Bug 21526: The hashmap webPreferencesInstances in WebPreferences.cpp can
potentially hold onto stale instances of WebPreferences
​https://bugs.webkit.org/show_bug.cgi?id=21526


webPreferencesInstances now keeps a reference to all the instances it holds.
Fix up callers of WebPreferences::removeReferenceForIdentifier() to call
it after they have released their references to the WebPreferences objects.

Reviewed by Adam Roben.

  • WebPreferences.cpp: (WebPreferences::getInstanceForIdentifier): (WebPreferences::removeReferenceForIdentifier):
  • WebView.cpp: (WebView::close): (WebView::setPreferences):
1:27 PM Changeset in webkit [37488] by timothy@apple.com
  • 4 edits
    2 adds in trunk

Fixes a regression with input search fields, where the placeholder text
would not be updated when the value of the placeholder attribute changed.

​https://bugs.webkit.org/show_bug.cgi?id=21521

Reviewed by Adele Peterson.

Test: fast/forms/search-placeholder-value-changed.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute): Pass true for the placeholderValueChanged parameter of updatePlaceholderVisibility. (WebCore::HTMLInputElement::updatePlaceholderVisibility): Add parameter for placeholderValueChanged that informs the method that the value changed.
  • html/HTMLInputElement.h: Add the placeholderValueChanged to the updatePlaceholderVisibility method. Made it default to false.
1:12 PM Changeset in webkit [37487] by hyatt@apple.com
  • 6 edits in trunk/WebCore

2008-10-10 David Hyatt <​hyatt@apple.com>

Allow the track part to have negative margins so that it can slightly overlap buttons. This
is necessary to emulate the Aqua look in CSS.

Reviewed by Sam Weinig

  • platform/ScrollbarThemeComposite.cpp: (WebCore::ScrollbarThemeComposite::paint): (WebCore::ScrollbarThemeComposite::hitTest):
  • rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::setHoveredPart): (WebCore::RenderScrollbar::trackRect):
  • rendering/RenderScrollbar.h:
  • rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::computeScrollbarWidth): (WebCore::RenderScrollbarPart::computeScrollbarHeight):
  • rendering/RenderScrollbarTheme.cpp: (WebCore::RenderScrollbarTheme::backButtonRect): (WebCore::RenderScrollbarTheme::forwardButtonRect): (WebCore::RenderScrollbarTheme::trackRect):
12:32 PM Changeset in webkit [37486] by hyatt@apple.com
  • 6 edits
    1 add in trunk/WebCore

2008-10-10 David Hyatt <​hyatt@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=21527

Make CSS scrollbars support :not, :hover and :active.

Reviewed by Adam Roben

Added WebCore/manual-tests/scrollbar-hover-active.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
  • platform/Scrollbar.cpp: (WebCore::Scrollbar::autoscrollPressedPart): (WebCore::Scrollbar::startTimerIfNeeded): (WebCore::Scrollbar::setHoveredPart): (WebCore::Scrollbar::setPressedPart): (WebCore::Scrollbar::mouseMoved): (WebCore::Scrollbar::mouseExited): (WebCore::Scrollbar::mouseUp): (WebCore::Scrollbar::mouseDown):
  • platform/Scrollbar.h:
  • rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::setHoveredPart): (WebCore::RenderScrollbar::setPressedPart): (WebCore::RenderScrollbar::updateScrollbarParts): (WebCore::pseudoForScrollbarPart): (WebCore::RenderScrollbar::updateScrollbarPart):
  • rendering/RenderScrollbar.h:
11:43 AM Changeset in webkit [37485] by cmarrin@apple.com
  • 4 edits
    2 adds in trunk

2008-10-10 Chris Marrin <​cmarrin@apple.com>

Reviewed by Dan Bernstein.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=21025
CSS transition with duration=0 and delay=0 doesn't override ongoing transition

Test: transitions/interrupt-zero-duration.html

  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions):
11:04 AM Changeset in webkit [37484] by cmarrin@apple.com
  • 10 edits in trunk/WebCore

2008-10-09 Chris Marrin <​cmarrin@apple.com>

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=21310

Redesigned how animation events are sent in order to get rid of
AnimationEventDispatcher. ImplicitAnimation and KeyframeAnimation
are now ref counted. While calling the event handler, I keep a
reference to this class to avoid it getting destroyed out from under me.

I also moved most of the functionality of CompositeAnimation to
and internal class (CompositeAnimationPrivate) to reduce the exposure
of the internals of the various animation classes.

We have several transition and animation LayoutTests which verify that
this fix works as expected and continues to avoid crashes.

10:13 AM Changeset in webkit [37483] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx build fix. Add new scrollbar-related sources.

9:59 AM Changeset in webkit [37482] by hyatt@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

2008-10-10 David Hyatt <​hyatt@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=21522

Support increment/decrement/start/end on scrollbars. Allows a fully functional scrollbar to be
created. (Just :hover/:active left to finish it up.)

Reviewed by Adam Roben

Added scrollbars/scrollbar-buttons.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):

LayoutTests:

2008-10-10 David Hyatt <​hyatt@apple.com>

Add test for scrollbar buttons and track supporting increment/decrement/start/end.

Reviewed by Adam Roben

  • platform/mac/scrollbars/scrollbar-buttons-expected.checksum: Added.
  • platform/mac/scrollbars/scrollbar-buttons-expected.png: Added.
  • platform/mac/scrollbars/scrollbar-buttons-expected.txt: Added.
  • scrollbars/scrollbar-buttons.html: Added.
9:40 AM Changeset in webkit [37481] by hyatt@apple.com
  • 1 edit in trunk/LayoutTests/scrollbars/scrollbar-orientation.html

Land updated layout test after pseudoclass rename.

9:40 AM Changeset in webkit [37480] by hyatt@apple.com
  • 4 edits in trunk/WebCore

2008-10-10 David Hyatt <​hyatt@apple.com>

Rename some pseudoclasses. Removing "-scrollbar-" from a bunch of the pseudoclasses. Renaming
back/forward to decrement/increment. Adding start/end pseudoclasses.

Reviewed by Eric Seidel

  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
12:18 AM Changeset in webkit [37479] by weinig@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-10-10 Sam Weinig <​sam@webkit.org>

Reviewed by Cameron Zwarich.

Remove now unused m_getterSetterFlag variable from PropertyMap.

  • kjs/PropertyMap.cpp: (JSC::PropertyMap::operator=):
  • kjs/PropertyMap.h: (JSC::PropertyMap::PropertyMap):
12:15 AM Changeset in webkit [37478] by hyatt@apple.com
  • 1 edit in trunk/WebCore/css/CSSStyleSelector.cpp

Fix build.

12:15 AM Changeset in webkit [37477] by hyatt@apple.com
  • 4 edits in trunk/WebCore

2008-10-10 David Hyatt <​hyatt@apple.com>

Switch window-active to window-inactive, since that will work better as far as degrading in other
browsers.

Reviewed by Tim Hatcher

  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
12:06 AM Changeset in webkit [37476] by timothy@apple.com
  • 1 edit in trunk/WebCore/bindings/objc/WebScriptObject.h

Yet another Tiger build fix.

12:04 AM Changeset in webkit [37475] by hyatt@apple.com
  • 9 edits
    4 adds in trunk

WebCore:

2008-10-09 David Hyatt <​hyatt@apple.com>

Add support for scrollbar orientation as a pseudoclass. Add support for whether or not the scrollbar
is active as well.

Reviewed by Tim Hatcher

Added scrollbars/scrollbar-orientation.html

  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
  • platform/Scrollbar.cpp: (WebCore::Scrollbar::isWindowActive):
  • platform/Scrollbar.h:
  • rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::paint): (WebCore::RenderScrollbar::partForStyleResolve):
  • rendering/RenderScrollbar.h:

LayoutTests:

2008-10-09 David Hyatt <​hyatt@apple.com>

Add layout test for scrollbars honoring orientation and window active state.

Reviewed by Tim Hatcher

  • platform/mac/scrollbars/scrollbar-orientation-expected.checksum: Added.
  • platform/mac/scrollbars/scrollbar-orientation-expected.png: Added.
  • platform/mac/scrollbars/scrollbar-orientation-expected.txt: Added.
  • scrollbars/scrollbar-orientation.html: Added.
Note: See TracTimeline for information about the timeline view.