Context Navigation

Remove a race condition in a test by promoting layoutTestController
calls outside document.write(). Add document.close().
See https://bugs.webkit.org/show_bug.cgi?id=21524

Reviewed by Darin Adler.
Landed by Adam Barth.

fast/encoding/script-in-head.html:

6:15 PM Changeset in webkit [37546] by abarth@webkit.org

4 edits
1 add in trunk/LayoutTests

2008-10-12 Pamela Greene <pam@chromium.org>

Remove data: URLs to avoid cross-domain security restrictions.
See https://bugs.webkit.org/show_bug.cgi?id=21528

Reviewed by Darin Adler.
Landed by Adam Barth.

fast/events/resources/tabindex-focus-blur-all-frame1.html:
fast/events/resources/tabindex-focus-blur-all-frame2.html:
fast/events/resources/tabindex-focus-blur-all-frame3.html: Added.
fast/events/tabindex-focus-blur-all.html:

6:15 PM Changeset in webkit [37545] by abarth@webkit.org

2 edits in trunk/LayoutTests

2008-10-12 Pamela Greene <pam@chromium.org>

Fix test when removesExtraParentheses == false.
See https://bugs.webkit.org/show_bug.cgi?id=21529

Reviewed by Darin Adler.
Landed by Adam Barth.

fast/js/resources/function-toString-parentheses.js:

6:15 PM Changeset in webkit [37544] by abarth@webkit.org

4 edits in trunk/LayoutTests

2008-10-12 Pamela Greene <pam@chromium.org>

Fix a race condition by waiting for all create functions to be called
before terminating.
See https://bugs.webkit.org/show_bug.cgi?id=21531

Reviewed by Darin Adler.
Landed by Adam Barth.

platform/mac/svg/carto.net/window-expected.checksum:
platform/mac/svg/carto.net/window-expected.png:
platform/mac/svg/carto.net/window-expected.txt:
svg/carto.net/window.svg:

6:14 PM Changeset in webkit [37543] by abarth@webkit.org

3 edits in trunk/LayoutTests

2008-10-12 Pamela Greene <pam@chromium.org>

Remove inadvertent const redefinition, and add specific test for it.
See https://bugs.webkit.org/show_bug.cgi?id=21532

Reviewed by Darin Adler.
Landed by Adam Barth.

fast/js/const-expected.txt:
fast/js/resources/const.js:

6:14 PM Changeset in webkit [37542] by abarth@webkit.org

1 edit
2 adds in trunk/LayoutTests

2008-10-12 Pamela Greene <pam@chromium.org>

Add a test for null character data.
See https://bugs.webkit.org/show_bug.cgi?id=21535

Reviewed by Darin Adler.
Landed by Adam Barth.

fast/dom/null-chardata-crash-expected.txt: Added.
fast/dom/null-chardata-crash.html: Added.

6:13 PM Changeset in webkit [37541] by Darin Adler

3 edits in trunk/WebCore

2008-10-12 Tony Chang <tony@chromium.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=21480 Remove duplicate definitions of MimeClassInfo and PluginInfo.

plugins/PluginInfoStore.cpp: Added an include.
plugins/PluginInfoStore.h: Removed struct declarations.

6:07 PM Changeset in webkit [37540] by Darin Adler

3 edits in trunk/WebCore

2008-10-12 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=21563 Bug 21563: platform Gradient class should not use the CSS parser

platform/graphics/Gradient.cpp: Removed the overload of addColorStop that accepts a CSS color string. That's handled in the DOM now, not here. (WebCore::Gradient::addColorStop): Use getRGBA instead of having our own copy of it here.
platform/graphics/Gradient.h: More of the same. Tweak formatting a bit.

5:58 PM Changeset in webkit [37539] by Darin Adler

4 edits
3 adds
6 deletes in trunk

WebCore:

2008-10-12 Glenn Wilson <gwilson@google.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=20461

Added feature to allow multi-line inputs into text fields.
HTMLInputElement would cut the set text at the first 'system' character,
so it would truncate at the first carriage return or newline.
This fix modifies that behavior to truncate at any non-space system character
but changes \r, \n, and \r\n to a single space.

Tests: editing/pasteboard/paste-multiline-text-input.html

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::constrainValue):

LayoutTests:

2008-10-12 Glenn Wilson <gwilson@google.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=20461

Added new test to verify that the user can cut and paste multiple lines of text
into a single line text field.

fast/forms/paste-multiline-text-input-expected.txt: Added.
fast/forms/paste-multiline-text-input.html: Added.
fast/forms/input-truncate-newline-expected.txt: Removed.
fast/forms/input-truncate-newline.html: Removed.

fast/forms/8250-expected.txt: Added.
fast/forms/8250.html: Updated test to be text-only and expect new results.
platform/mac/fast/forms/8250-expected.checksum: Removed.
platform/mac/fast/forms/8250-expected.png: Removed.
platform/mac/fast/forms/8250-expected.txt: Removed.
platform/qt/fast/forms/8250-expected.txt: Removed.

5:25 PM Changeset in webkit [37538] by Darin Adler

8 edits
9 adds in trunk

WebCore:

2008-10-12 Dirk Schulze <vbs85@gmx.de>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=20435

Added exception codes to canvas gradients to match current specification.

Tests: fast/canvas/gradient-addColorStop-with-invalid-color.html

fast/canvas/linearGradient-infinite-values.html
fast/canvas/radialGradient-infinite-values.html

html/CanvasGradient.cpp: (WebCore::CanvasGradient::addColorStop):
html/CanvasGradient.h:
html/CanvasGradient.idl:
html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createLinearGradient): (WebCore::CanvasRenderingContext2D::createRadialGradient):
html/CanvasRenderingContext2D.h:
html/CanvasRenderingContext2D.idl:

LayoutTests:

2008-10-12 Dirk Schulze <vbs85@gmx.de>

Reviewed by Eric Seidel.

test for https://bugs.webkit.org/show_bug.cgi?id=20435

Added new tests to check behavior of canvas gradients to infinite values
or invalid colors.

fast/canvas/gradient-addColorStop-with-invalid-color-expected.txt: Added.
fast/canvas/gradient-addColorStop-with-invalid-color.html: Added.
fast/canvas/linearGradient-infinite-values-expected.txt: Added.
fast/canvas/linearGradient-infinite-values.html: Added.
fast/canvas/radialGradient-infinite-values-expected.txt: Added.
fast/canvas/radialGradient-infinite-values.html: Added.
fast/canvas/resources/gradient-addColorStop-with-invalid-color.js: Added.
fast/canvas/resources/linearGradient-infinite-values.js: Added.
fast/canvas/resources/radialGradient-infinite-values.js: Added.

4:59 PM Changeset in webkit [37537] by Darin Adler

3 edits in trunk/WebCore

2008-10-12 Eric Roman <eroman@chromium.org>

https://bugs.webkit.org/show_bug.cgi?id=20246 Implement RenderThemeWin::systemColor() to match Windows colors.

Reviewed by David Hyatt.

rendering/RenderThemeWin.cpp: (WebCore::cssValueIdToSysColorIndex): (WebCore::RenderThemeWin::systemColor):
rendering/RenderThemeWin.h:

4:51 PM Changeset in webkit [37536] by mrowe@apple.com

4 edits in branches/Safari-3-2-branch/WebKit/win

Merge r36005.

4:50 PM Changeset in webkit [37535] by Darin Adler

2 edits in trunk/WebCore

2008-10-12 Aaron Bockover <abockover@novell.com>

Reviewed by Alp Toker.

Add version parsing for Flash, and the PluginQuirkDontSetNullWindowHandleOnDestroy
plugin quirk if Flash 10 or newer since at least in b218, setting a NULL window
handler on destroy crashes WebKit <https://bugs.webkit.org/show_bug.cgi?id=19859>

plugins/gtk/PluginPackageGtk.cpp:

4:01 PM Changeset in webkit [37534] by Darin Adler

2 edits in trunk/WebCore

2008-10-12 Jonathon Jongsma <jonathon.jongsma@collabora.co.uk>

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=19331 <rdar://problem/5984433>: Drag and drop of links in edit mode violates assert in MoveSelectionCommand::doApply()

page/DragController.cpp: (WebCore::DragController::startDrag): When a link is dragged without any text selected (note: for this to work, the EditableLinkBehavior setting must be set to 'live' or 'default') and then dropped into an editable html document it will eventually violate an ASSERT in MoveSelectionCommand that requires that there is a selection. To prevent this, expand the selection to the enclosing anchor tag when the drag begins.

3:53 PM Changeset in webkit [37533] by Darin Adler

2 edits in trunk/WebCore

2008-10-12 Darin Adler <Darin Adler>

Reviewed by Mark Rowe.

fix https://bugs.webkit.org/show_bug.cgi?id=21557 Bug 21557: REGRESSION: generated-layer-scrollbar-crash.html is crashing

rendering/RenderObject.cpp: (WebCore::RenderObject::getPseudoStyle): Keep walking up the parent chain until we hit an Element. Nowadays, Node::isElementNode() is just as efficient as RenderObject::isText(), and this guarantees that the node can be cast to Element*, which is done just below. The reason this is hit is that RenderLayer can call getPseudoStyle on a RenderView, which has the document as its element() -- and a document is neither a Text node nor an Element. A loose end is that this seems to mean you can't style the scrollbar corner or the resizer on a RenderView. Hyatt may want to look into that later.

3:51 PM Changeset in webkit [37532] by Darin Adler

3 edits in trunk/JavaScriptCore

2008-10-12 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

wtf/unicode/icu/UnicodeIcu.h: Fixed indentation to match WebKit coding style.
wtf/unicode/qt4/UnicodeQt4.h: Ditto.

3:49 PM Changeset in webkit [37531] by Darin Adler

8 edits
12 adds in trunk

JavaScriptCore:

2008-10-12 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=21556 Bug 21556: non-ASCII digits are allowed in places where only ASCII should be

wtf/unicode/icu/UnicodeIcu.h: Removed isDigit, digitValue, and isFormatChar.
wtf/unicode/qt4/UnicodeQt4.h: Ditto.

WebCore:

2008-10-12 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=21556 Bug 21556: non-ASCII digits are allowed in places where only ASCII should be

Tests: fast/dom/HTMLFontElement/size-attribute.html

fast/dom/HTMLInputElement/size-attribute.html
fast/dom/HTMLTableElement/cellpadding-attribute.html

html/HTMLFontElement.cpp: (WebCore::parseFontSizeNumber): Use isASCIIDigit instead of Unicode::isDigit, since non-ASCII digits are not valid here.
html/HTMLFontElement.h: Tweaked formatting a bit and removed the unneeded destructor declaration.
platform/text/String.cpp: (WebCore::lengthOfCharactersAsInteger): Use isASCIIDigit instead of Unicode::isDigit, since non-ASCII digits are not valid.

LayoutTests:

2008-10-12 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

tests for https://bugs.webkit.org/show_bug.cgi?id=21556 Bug 21556: non-ASCII digits are allowed in places where only ASCII should be

The fix was in a function used all over the place. I set a breakpoint in the
function and made some regression tests for the first few places it was used.

fast/dom/HTMLFontElement: Added.
fast/dom/HTMLFontElement/resources: Added.
fast/dom/HTMLFontElement/resources/TEMPLATE.html: Added.
fast/dom/HTMLFontElement/resources/size-attribute.js: Added.
fast/dom/HTMLFontElement/size-attribute-expected.txt: Added.
fast/dom/HTMLFontElement/size-attribute.html: Added.
fast/dom/HTMLInputElement/resources/size-attribute.js: Added.
fast/dom/HTMLInputElement/size-attribute-expected.txt: Added.
fast/dom/HTMLInputElement/size-attribute.html: Added.
fast/dom/HTMLTableElement/cellpadding-attribute-expected.txt: Added.
fast/dom/HTMLTableElement/cellpadding-attribute.html: Added.
fast/dom/HTMLTableElement/resources/cellpadding-attribute.js: Added.

3:38 PM Changeset in webkit [37530] by Darin Adler

3 edits
2 adds in trunk

WebCore:

2008-10-12 Jungshik Shin <jshin@chromium.org>

Reviewed by Darin Adler.

Treat x-user-defined as windows-1252 for html files with meta charset
declaration to be compatible with Indian web sites.
( https://bugs.webkit.org/show_bug.cgi?id=18270 )

Test: fast/encoding/charset-xuser-defined.html

loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::setEncoding):

LayoutTests:

2008-10-12 Jungshik Shin <jshin@chromium.org>

Reviewed by Darin Adler.

Treat x-user-defined as windows-1252 for html files with meta charset
declaration to be compatible with Indian web sites.
( https://bugs.webkit.org/show_bug.cgi?id=18270 )

fast/encoding/charset-xuser-defined-expected.txt: Added.
fast/encoding/charset-xuser-defined.html: Added.

3:24 PM Changeset in webkit [37529] by Darin Adler

130 edits in trunk/LayoutTests

2008-10-12 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=21559 Bug 21559: many SVG tests are slightly different from what make-js-test-wrappers would make

svg/custom/immutable-properties.html: Updated path to test resources so it does not go up out of and back into LayoutTests.
svg/custom/svg-modify-currentTranslate.html: Ditto.
svg/custom/svg-xml-dom-sync.html: Ditto.
svg/custom/tearoffs-with-tearoffs.html: Ditto.

svg/dynamic-updates/resources/*.js: Allow the make-js-test-wrappers script to add var successfullyParsed = true; to these files. It's not helpful for the tests, but it's not harmful either.

2:32 PM Changeset in webkit [37528] by weinig@apple.com

2 edits in trunk/WebCore

2008-10-12 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Remove unneeded forward declaration.

platform/graphics/ImageBuffer.h:

1:43 PM Changeset in webkit [37527] by weinig@apple.com

14 edits
1 add in trunk/WebCore

2008-10-12 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

Fix for https://bugs.webkit.org/show_bug.cgi?id=21560
Layering violation: String should not be responsible for creating Lengths

It was a layering violation for String to know haw to parse
into Lengths, LengthArrays, and CoordsArrays.

GNUmakefile.am:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
WebCoreSources.bkl:
html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::parseMappedAttribute):
html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::parseMappedAttribute):
platform/text/AtomicString.h: (WebCore::AtomicString::percentage):
platform/text/PlatformString.h:
platform/text/String.cpp:
platform/text/StringImpl.cpp:
platform/text/StringImpl.h:
rendering/Length.cpp: Added. (WebCore::parseLength): (WebCore::countCharacter): (WebCore::newCoordsArray): (WebCore::newLengthArray):
rendering/Length.h: (WebCore::LengthSize::LengthSize):

12:51 PM Changeset in webkit [37526] by andersca@apple.com

2 edits in trunk/JavaScriptCore

2008-10-12 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Make the append method that takes a Vector more strict - it now requires the elements
of the vector to be appended same type as the elements of the Vector they're being appended to.

This would cause problems when dealing with Vectors containing other Vectors.

wtf/Vector.h: (WTF::::append):

12:34 PM Changeset in webkit [37525] by Darin Adler

2 edits in trunk/WebKitTools

2008-10-12 Darin Adler <Darin Adler>

Scripts/make-js-test-wrappers: Update exceptions list so the script won't overwrite files and mangle tests.

11:23 AM Changeset in webkit [37524] by Darin Adler

3 edits
2 adds in trunk

WebCore:

2008-10-12 Brad Garcia <bgarcia@google.com>

Reviewed by Darin Adler.

Interpret fractional percentage values for %MultiLength values.
Fix for https://bugs.webkit.org/show_bug.cgi?id=3591
Test: fast/frames/frame-length-fractional-percentage.html

platform/text/StringImpl.cpp: (WebCore::parseLength):

LayoutTests:

2008-10-12 Brad Garcia <bgarcia@google.com>

Reviewed by Darin Adler.

Testcases for fractional frame lengths.
https://bugs.webkit.org/show_bug.cgi?id=3591

fast/frames/frame-length-fractional.html: Added.
fast/frames/frame-length-fractional-expected.txt: Added.

10:04 AM Changeset in webkit [37523] by timothy@apple.com

4 edits in trunk/WebCore

Remember the expanded state of the rules in the Styles pane. So
collapsing a rule will persist across all the elements that have
that same rule. The same applies to Computed Style, so the Computed
Style rule is now collapsed by default. This should help lessen the
confusion on why Computed Style can't be edited (a common confusion.)

https://bugs.webkit.org/show_bug.cgi?id=21553

Reviewed by Darin Adler.

inspector/front-end/PropertiesSection.js: (WebInspector.PropertiesSection): Set the _expanded property directly, instead of using the setter. Expanded is the default, so no work is needed. This prevents calling StylesSidebarPane.collapse before object initialization is complete.
inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update): Check the Preferences object for the expanded state of the StylePropertiesSection. Collapse computed style by default and expand everything else. (WebInspector.StylePropertiesSection): Make a semi unique identifier to be used when remembering expanded state. (WebInspector.StylePropertiesSection.prototype.expand): Set the expanded state to true for this identifier in Preferences.styleRulesExpandedState. Don't remember the state if the dontRememberState property is true. (WebInspector.StylePropertiesSection.prototype.collapse): Set the expanded state to false for this identifier in Preferences.styleRulesExpandedState.
inspector/front-end/inspector.js: (Preferences.styleRulesExpandedState): Initialize to an empty object.

4:47 AM Changeset in webkit [37522] by jmalonzo@webkit.org

2 edits in trunk/WebCore

2008-10-12 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Alp Toker.

[Gtk] Remove libWebCoreJS.la when doing make clean
https://bugs.webkit.org/show_bug.cgi?id=21544

Remove libWebCoreJS.la when doing a clean target

GNUmakefile.am: add libWebCoreJS.la to CLEANFILES

Oct 11, 2008:

11:50 PM Changeset in webkit [37521] by alp@webkit.org

3 edits in trunk/WebCore

2008-10-11 Alp Toker <alp@nuanti.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=20592
The focus ring is not shown while navigating on some pages

Fix drawFocusRing() so it doesn't depend on the current graphics
state, thus matching other platforms which already work this way.

This patch provides two code paths: one using straight Cairo and
one specialised for the GTK+ port with a more conventional appearance.

Also change focusRingColor() to return a null color, allowing the
focus ring to pick up the style's current color if it isn't overridden
with CSS.

platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawFocusRing):
platform/gtk/TemporaryLinkStubs.cpp: (WebCore::focusRingColor):

10:00 PM Changeset in webkit [37520] by cwzwarich@webkit.org

2 edits in trunk/JavaScriptCore

2008-10-11 Cameron Zwarich <zwarich@apple.com>

Reviewed by Sam Weinig.

Clean up RegExpMatchesArray.h to match our coding style.

kjs/RegExpMatchesArray.h: (JSC::RegExpMatchesArray::getOwnPropertySlot): (JSC::RegExpMatchesArray::put): (JSC::RegExpMatchesArray::deleteProperty): (JSC::RegExpMatchesArray::getPropertyNames):

9:56 PM Changeset in webkit [37519] by mitz@apple.com

2 edits in trunk/WebCore

Rubber-stamped by Sam Weinig.

change all internal callers to use Cache::evict() instead of remove()

loader/Cache.cpp: (WebCore::Cache::revalidateResource): (WebCore::Cache::revalidationSucceeded): (WebCore::Cache::pruneDeadResources): (WebCore::Cache::setDisabled):

9:26 PM Changeset in webkit [37518] by hyatt@apple.com

2 edits in trunk/WebCore

2008-10-11 David Hyatt <hyatt@apple.com>

Make sure invalidatePart knows how to invalidate the track and scrollbar backgrounds.

Reviewed by Tim Hatcher

platform/ScrollbarThemeComposite.cpp: (WebCore::ScrollbarThemeComposite::invalidatePart):

9:20 PM Changeset in webkit [37517] by hyatt@apple.com

6 edits in trunk/WebCore

2008-10-11 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21549 (regression in before/after track pieces).

Also fixed resizer positioning problems.

Reviewed by Tim Hatcher

platform/ScrollbarThemeComposite.cpp: (WebCore::ScrollbarThemeComposite::splitTrack): (WebCore::ScrollbarThemeComposite::trackPosition): (WebCore::ScrollbarThemeComposite::trackLength):
platform/ScrollbarThemeComposite.h: (WebCore::ScrollbarThemeComposite::constrainTrackRectToTrackPieces):
rendering/RenderLayer.cpp: (WebCore::scrollCornerRect): (WebCore::RenderLayer::positionOverflowControls): (WebCore::RenderLayer::paintOverflowControls): (WebCore::RenderLayer::isPointInResizeControl): (WebCore::RenderLayer::hitTestOverflowControls):
rendering/RenderScrollbarTheme.cpp: (WebCore::RenderScrollbarTheme::constrainTrackRectToTrackPieces):
rendering/RenderScrollbarTheme.h:

8:48 PM Changeset in webkit [37516] by mrowe@apple.com

1 edit in branches/Safari-3-2-branch/JavaScriptCore/wtf/ASCIICType.h

Merge ASCIICType.h portion of r36244.

8:33 PM Changeset in webkit [37515] by alp@webkit.org

3 edits in trunk/WebCore

2008-10-11 Alp Toker <alp@nuanti.com>

Reviewed by David Hyatt.

Implement release/retain for Widget GTK+.

platform/Widget.cpp:
platform/gtk/WidgetGtk.cpp: (WebCore::Widget::~Widget): (WebCore::Widget::releasePlatformWidget): (WebCore::Widget::retainPlatformWidget):

6:38 PM Changeset in webkit [37514] by mrowe@apple.com

1 edit in trunk/WebCore/ChangeLog

Fix ChangeLog header that was mangled in r37484.

6:31 PM Changeset in webkit [37513] by mrowe@apple.com

1 move in trunk/LayoutTests/animations/font-size-using-ems.html-disabled

Disable animations/font-size-using-ems.html as it has been causing the following test, animatinos/generic-from-to.html, to hang since it was added.

4:10 PM Changeset in webkit [37512] by mitz@apple.com

4 edits in trunk/WebKitTools

Reviewed by Sam Weinig and Anders Carlsson.

update Mac DumpRenderTree to use the new WebView SPI for forcing the complex text code path
add --complex-text support to Windows DumpRenderTree

DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree):
DumpRenderTree/win/DumpRenderTree.cpp: (createWebViewAndOffscreenWindow): (main):
Scripts/run-webkit-tests:

3:53 PM Changeset in webkit [37511] by mitz@apple.com

15 edits in trunk

WebCore:

Reviewed by Sam Weinig.

rename WebCoreSetAlwaysUseATSU to WebCoreSetAlwaysUsesComplexTextCodePath and add a corresponding getter; add the same functions on Windows

WebCore.base.exp:
platform/graphics/Font.cpp: (WebCore::Font::setCodePath): (WebCore::codePath): (WebCore::Font::canUseGlyphCache):
platform/graphics/Font.h:
platform/mac/WebCoreTextRenderer.h:
platform/mac/WebCoreTextRenderer.mm: (WebCoreSetAlwaysUsesComplexTextCodePath): (WebCoreAlwaysUsesComplexTextCodePath):
platform/win/WebCoreTextRenderer.cpp: (WebCore::WebCoreSetAlwaysUsesComplexTextCodePath): (WebCore::WebCoreAlwaysUsesComplexTextCodePath):
platform/win/WebCoreTextRenderer.h:

WebKit/mac:

Reviewed by Sam Weinig.

rename _setAlwaysUseATSU to _setAlwaysUsesComplexTextCodePath and update it for the renamed WebCoreTextRenderer method; keep the old method around for clients that use it

WebView/WebView.mm: (+[WebView _setAlwaysUseATSU:]): (+[WebView _setAlwaysUsesComplexTextCodePath:]):
WebView/WebViewPrivate.h:

WebKit/win:

Reviewed by Sam Weinig.

add SPI for forcing the complex text code path to be used for all text

Interfaces/IWebViewPrivate.idl:
WebView.cpp: (WebView::setAlwaysUsesComplexTextCodePath): (WebView::alwaysUsesComplexTextCodePath):
WebView.h:

3:20 PM Changeset in webkit [37510] by weinig@apple.com

2 edits in trunk/WebCore

2008-10-11 Sam Weinig <sam@webkit.org>

Reviewed by Cameron Zwarich.

Stop leaking the event parameter names. The protected strings were showing up
in the caches window after one use. No measurable performance loss.

bindings/js/JSEventListener.cpp: (WebCore::eventParameterName):

3:10 PM Changeset in webkit [37509] by weinig@apple.com

3 edits in trunk/WebCore

2008-10-11 Sam Weinig <sam@webkit.org>

Reviewed by Cameron Zwarich.

Remove unused function getNodeEventListener.

bindings/js/JSEventListener.cpp:
bindings/js/JSEventListener.h:

1:58 PM Changeset in webkit [37508] by cwzwarich@webkit.org

3 edits in trunk/JavaScriptCore

2008-10-11 Cameron Zwarich <zwarich@apple.com>

Reviewed by Sam Weinig.

Bug 21525: 55 StructureID leaks on Wikitravel's main page
<https://bugs.webkit.org/show_bug.cgi?id=21525>

Bug 21533: Simple JavaScript code leaks StructureIDs
<https://bugs.webkit.org/show_bug.cgi?id=21533>

StructureID::getEnumerablePropertyNames() ends up calling back to itself
via JSObject::getPropertyNames(), which causes the PropertyNameArray to
be cached twice. This leads to a memory leak in almost every use of
JSObject::getPropertyNames() on an object. The fix here is based on a
suggestion of Sam Weinig.

This patch also fixes every StructureID leaks that occurs while running
the Mozilla MemBuster test.

kjs/PropertyNameArray.h: (JSC::PropertyNameArray::PropertyNameArray): (JSC::PropertyNameArray::setCacheable): (JSC::PropertyNameArray::cacheable):
kjs/StructureID.cpp: (JSC::StructureID::getEnumerablePropertyNames):

12:50 AM Changeset in webkit [37507] by hyatt@apple.com

8 edits in trunk/WebCore

2008-10-11 David Hyatt <hyatt@apple.com>

Add support for both positive and negative margins to tracks and track pieces.

Reviewed by Tim Hatcher

platform/ScrollbarThemeComposite.cpp: (WebCore::ScrollbarThemeComposite::paint): (WebCore::ScrollbarThemeComposite::hitTest): (WebCore::ScrollbarThemeComposite::splitTrack): (WebCore::ScrollbarThemeComposite::trackPieceRects): (WebCore::ScrollbarThemeComposite::trackPosition): (WebCore::ScrollbarThemeComposite::trackLength):
platform/ScrollbarThemeComposite.h: (WebCore::ScrollbarThemeComposite::adjustTrackPieceRect):
rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::trackRect): (WebCore::RenderScrollbar::trackPieceRectWithMargins):
rendering/RenderScrollbar.h:
rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::computeScrollbarWidth): (WebCore::RenderScrollbarPart::computeScrollbarHeight):
rendering/RenderScrollbarTheme.cpp: (WebCore::RenderScrollbarTheme::adjustTrackPieceRect):
rendering/RenderScrollbarTheme.h:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed