⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 13, 2008:

11:45 PM Changeset in webkit [37579] by hyatt@apple.com
  • 3 edits in trunk/WebCore

2008-10-13 David Hyatt <​hyatt@apple.com>

Add support for CSS transitions on some SVG properties. This patch is intended to be a guideline
for how to add support for the rest.

Reviewed by Oliver Hunt

  • page/animation/AnimationBase.cpp: (WebCore::ensurePropertyMap):
  • rendering/style/RenderStyle.h: (WebCore::RenderStyle::fillOpacity): (WebCore::RenderStyle::setFillOpacity): (WebCore::RenderStyle::strokeOpacity): (WebCore::RenderStyle::setStrokeOpacity): (WebCore::RenderStyle::floodOpacity): (WebCore::RenderStyle::setFloodOpacity):
11:29 PM Changeset in webkit [37578] by hyatt@apple.com
  • 4 edits in trunk/WebCore

2008-10-13 David Hyatt <​hyatt@apple.com>

<rdar://problem/6289712> REGRESSION(r37432-37490): Scroll bar is not drawn in Bookmark View, Preferences sheets.

Fix for disabled scrollbars not painting in Windows Safari. Make sure that the Windows theme
implements paintTrackBackground so that when the thumb is not present the track still paints.

Reviewed by Oliver Hunt

  • platform/ScrollbarThemeComposite.cpp: (WebCore::ScrollbarThemeComposite::paint):
  • platform/win/ScrollbarThemeWin.cpp: (WebCore::ScrollbarThemeWin::paintTrackBackground):
  • platform/win/ScrollbarThemeWin.h:
11:12 PM Changeset in webkit [37577] by hyatt@apple.com
  • 4 edits in trunk/WebCore

2008-10-13 David Hyatt <​hyatt@apple.com>

Fix over-invalidation of native scrollbars.

Reviewed by Oliver Hunt

  • platform/Scrollbar.h: (WebCore::Scrollbar::styleChanged):
  • platform/mac/ScrollbarThemeMac.mm: (+[ScrollbarPrefsObserver appearancePrefsChanged:]):
  • rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::styleChanged):
10:29 PM Changeset in webkit [37576] by mjs@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-10-13 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Cameron Zwarich.


  • make Machine::getArgumentsData an Arguments method and inline it


~2% on v8 raytrace

  • VM/Machine.cpp:
  • kjs/Arguments.h: (JSC::Machine::getArgumentsData):
9:14 PM Changeset in webkit [37575] by alp@webkit.org
  • 4 edits in trunk

2008-10-13 Alp Toker <​alp@nuanti.com>

Fix autotools dist build target by listing recently added header
files only. Not reviewed.

7:28 PM Changeset in webkit [37574] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Don't run a SQLite query on every iteration of the sync thread when the query
will touch a large portion of the icon database while performing no useful work.

Reviewed by Brady Eidson.

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::writeToDatabase): Don't call checkForDanglingPageURLs unless
we modified the database.
(WebCore::IconDatabase::checkForDanglingPageURLs): Don't do any work in a release build
unless we've been asked to prune any dangling pageURLs that we find.

7:16 PM Changeset in webkit [37573] by alp@webkit.org
  • 2 edits in trunk

2008-10-13 Alp Toker <​alp@nuanti.com>

GTK+ build fix: Ensure correct builds when debugging is
enabled/disabled by defining NDEBUG in autotoolsconfig.h as needed.
It's still passed as a compiler flag since some sources (DRT) don't
use config.h yet.

  • configure.ac:
6:21 PM Changeset in webkit [37572] by mjs@apple.com
  • 9 edits in trunk

JavaScriptCore:

2008-10-13 Maciej Stachowiak <​mjs@apple.com>

Rubber stamped by Mark Rowe.


  • fixed <rdar://problem/5806316> JavaScriptCore should not force building with gcc 4.0
  • use gcc 4.2 when building with Xcode 3.1 or newer on Leopard, even though this is not the default
  • Configurations/DebugRelease.xcconfig:
  • JavaScriptCore.xcodeproj/project.pbxproj:

JavaScriptGlue:

2008-10-13 Maciej Stachowiak <​mjs@apple.com>

Rubber stamped by Mark Rowe.


  • use gcc 4.2 when building with Xcode 3.1 or newer on Leopard, even though this is not the default
  • Configurations/DebugRelease.xcconfig:

WebCore:

2008-10-13 Maciej Stachowiak <​mjs@apple.com>

Rubber stamped by Mark Rowe.


  • use gcc 4.2 when building with Xcode 3.1 or newer on Leopard, even though this is not the default
  • Configurations/DebugRelease.xcconfig:

WebKit/mac:

2008-10-13 Maciej Stachowiak <​mjs@apple.com>

Rubber stamped by Mark Rowe.


  • use gcc 4.2 when building with Xcode 3.1 or newer on Leopard, even though this is not the default
  • Configurations/DebugRelease.xcconfig:
5:59 PM Changeset in webkit [37571] by hyatt@apple.com
  • 7 edits in trunk/WebCore

2008-10-13 David Hyatt <​hyatt@apple.com>

Make dropdown lists on Windows work with CSS custom scrollbars.

Reviewed by Adele

  • platform/PopupMenu.h: (WebCore::PopupMenu::scrollbarCornerPresent):
  • platform/PopupMenuClient.h:
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::show):
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::createScrollbar):
  • rendering/RenderMenuList.h:
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::createScrollbar):
  • rendering/RenderTextControl.h:
5:20 PM Changeset in webkit [37570] by cwzwarich@webkit.org
  • 6 edits in trunk/JavaScriptCore

2008-10-13 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Geoff Garen.

Bug 21541: Move RegisterFile growth check to callee
<​https://bugs.webkit.org/show_bug.cgi?id=21541>

Move the RegisterFile growth check to the callee in the common case,
where some of the information is known statically at JIT time. There is
still a check in the caller in the case where the caller provides too
few arguments.

This is a 2.1% speedup on the V8 benchmark, including a 5.1% speedup on
the Richards benchmark, a 4.1% speedup on the DeltaBlue benchmark, and a
1.4% speedup on the Earley-Boyer benchmark. It is also a 0.5% speedup on
SunSpider.

  • VM/CTI.cpp: (JSC::CTI::privateCompile):
  • VM/Machine.cpp: (JSC::Machine::cti_register_file_check): (JSC::Machine::cti_op_call_JSFunction): (JSC::Machine::cti_op_construct_JSConstruct):
  • VM/Machine.h:
  • VM/RegisterFile.h:
  • masm/X86Assembler.h: (JSC::X86Assembler::): (JSC::X86Assembler::cmpl_mr): (JSC::X86Assembler::emitUnlinkedJg):
4:39 PM Changeset in webkit [37569] by hyatt@apple.com
  • 1 edit in trunk/WebKit/win/WebScrollBar.h

Fix Windows build bustage.

4:39 PM Changeset in webkit [37568] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/PopupMenu.h

Fix Windows build bustage.

3:48 PM Changeset in webkit [37567] by Chris Fleizach
  • 14 edits
    2 adds in trunk

<rdar://problem/6271864> Links from image maps not being included in AXLinkUIElements

This also fixes the positions of image map links

3:42 PM Changeset in webkit [37566] by hyatt@apple.com
  • 4 edits
    4 adds in trunk

WebCore:

2008-10-13 David Hyatt <​hyatt@apple.com>

Make RenderListBox work with CSS scrollbars. Refactoring this code to support creation/destruction in
the same way RenderLayer does also fixes a bug where the PLT would assert on the next-to-last page (no
idea how to make a test case for that, though, since I couldn't repro without running the whole PLT).

Reviewed by Tim Hatcher

Added scrollbars/listbox-scrollbar-combinations.html

  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::~RenderListBox): (WebCore::RenderListBox::updateFromElement): (WebCore::RenderListBox::createScrollbar): (WebCore::RenderListBox::destroyScrollbar): (WebCore::RenderListBox::setHasVerticalScrollbar):
  • rendering/RenderListBox.h:

LayoutTests:

2008-10-13 David Hyatt <​hyatt@apple.com>

Add test case for custom CSS listbox scrollbars.

Reviewed by Tim Hatcher

  • platform/mac/scrollbars/listbox-scrollbar-combinations-expected.checksum: Added.
  • platform/mac/scrollbars/listbox-scrollbar-combinations-expected.png: Added.
  • platform/mac/scrollbars/listbox-scrollbar-combinations-expected.txt: Added.
  • scrollbars/listbox-scrollbar-combinations.html: Added.
3:25 PM Changeset in webkit [37565] by timothy@apple.com
  • 1 edit
    45 adds in trunk/LayoutTests

Adds an complex styled scrollbar test that exercises all pseudo-elements and pseudo-classes.
Also uses positive and negative margins on the scrollbar track and track pieces.
Tests all the combinations of scrollbars for overflow elements, with and without resizers.

Rubber-stamped by Dave Hyatt.

  • platform/mac/scrollbars/overflow-scrollbar-combinations-expected.checksum: Added.
  • platform/mac/scrollbars/overflow-scrollbar-combinations-expected.png: Added.
  • platform/mac/scrollbars/overflow-scrollbar-combinations-expected.txt: Added.
  • scrollbars/overflow-scrollbar-combinations.html: Added.
  • scrollbars/resources: Added.
  • scrollbars/resources/corner-inactive.png: Added.
  • scrollbars/resources/corner.png: Added.
  • scrollbars/resources/horizontal-button-active.png: Added.
  • scrollbars/resources/horizontal-button-background-active.png: Added.
  • scrollbars/resources/horizontal-button-background-hover.png: Added.
  • scrollbars/resources/horizontal-button-background-inactive.png: Added.
  • scrollbars/resources/horizontal-button-background.png: Added.
  • scrollbars/resources/horizontal-button-hover.png: Added.
  • scrollbars/resources/horizontal-button-inactive.png: Added.
  • scrollbars/resources/horizontal-button.png: Added.
  • scrollbars/resources/horizontal-decrement-arrow.png: Added.
  • scrollbars/resources/horizontal-increment-arrow.png: Added.
  • scrollbars/resources/horizontal-thumb-active.png: Added.
  • scrollbars/resources/horizontal-thumb-hover.png: Added.
  • scrollbars/resources/horizontal-thumb-inactive.png: Added.
  • scrollbars/resources/horizontal-thumb.png: Added.
  • scrollbars/resources/horizontal-track-active.png: Added.
  • scrollbars/resources/horizontal-track-disabled.png: Added.
  • scrollbars/resources/horizontal-track-hover.png: Added.
  • scrollbars/resources/horizontal-track.png: Added.
  • scrollbars/resources/resizer-inactive.png: Added.
  • scrollbars/resources/resizer.png: Added.
  • scrollbars/resources/vertical-button-active.png: Added.
  • scrollbars/resources/vertical-button-background-active.png: Added.
  • scrollbars/resources/vertical-button-background-hover.png: Added.
  • scrollbars/resources/vertical-button-background-inactive.png: Added.
  • scrollbars/resources/vertical-button-background.png: Added.
  • scrollbars/resources/vertical-button-hover.png: Added.
  • scrollbars/resources/vertical-button-inactive.png: Added.
  • scrollbars/resources/vertical-button.png: Added.
  • scrollbars/resources/vertical-decrement-arrow.png: Added.
  • scrollbars/resources/vertical-increment-arrow.png: Added.
  • scrollbars/resources/vertical-thumb-active.png: Added.
  • scrollbars/resources/vertical-thumb-hover.png: Added.
  • scrollbars/resources/vertical-thumb-inactive.png: Added.
  • scrollbars/resources/vertical-thumb.png: Added.
  • scrollbars/resources/vertical-track-active.png: Added.
  • scrollbars/resources/vertical-track-disabled.png: Added.
  • scrollbars/resources/vertical-track-hover.png: Added.
  • scrollbars/resources/vertical-track.png: Added.
2:53 PM Changeset in webkit [37564] by hyatt@apple.com
  • 3 edits in trunk/WebCore

2008-10-13 David Hyatt <​hyatt@apple.com>

In order to always match the :corner-present pseudo-class properly, delay initial updating of
scrollbar styles until the layer has the scrollbars in its member variables.

Reviewed by Tim Hatcher

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::setHasHorizontalScrollbar): (WebCore::RenderLayer::setHasVerticalScrollbar):
  • rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::RenderScrollbar):
2:41 PM Changeset in webkit [37563] by weinig@apple.com
  • 8 edits in trunk

JavaScriptCore:

2008-10-13 Sam Weinig <​sam@webkit.org>

Reviewed by Dan Bernstein.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=21577
5 false positive StructureID leaks

  • Add leak ignore set to StructureID to selectively ignore leaking some StructureIDs.
  • Add create method to JSGlolalData to be used when the data will be intentionally leaked and ignore all leaks caused the StructureIDs stored in it.
  • JavaScriptCore.exp:
  • kjs/JSGlobalData.cpp: (JSC::JSGlobalData::createLeaked):
  • kjs/JSGlobalData.h:
  • kjs/StructureID.cpp: (JSC::StructureID::StructureID): (JSC::StructureID::~StructureID): (JSC::StructureID::startIgnoringLeaks): (JSC::StructureID::stopIgnoringLeaks):
  • kjs/StructureID.h:

WebCore:

2008-10-13 Sam Weinig <​sam@webkit.org>

Reviewed by Dan Bernstein.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=21577
5 false positive StructureID leaks

In WebCore, we intentionally leak the common JSGlobalData which in turn
leaks 5 StructureIDs. Use the new JSGlobalData::createLeaked in order to
ignore the StructureIDs leaked within.

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::commonJSGlobalData):
2:23 PM Changeset in webkit [37562] by hyatt@apple.com
  • 10 edits in trunk/WebCore

2008-10-13 David Hyatt <​hyatt@apple.com>

Add support for the :corner-present pseudoclass, which enables scrollbar pieces to change their
artwork based on whether there is a scrollbar corner present.

Reviewed by Tim Hatcher

  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
  • platform/ScrollView.cpp: (WebCore::ScrollView::scrollbarCornerPresent):
  • platform/ScrollView.h:
  • platform/ScrollbarClient.h:
  • rendering/RenderLayer.cpp: (WebCore::cornerRect): (WebCore::scrollCornerRect): (WebCore::resizerCornerRect): (WebCore::RenderLayer::scrollbarCornerPresent): (WebCore::RenderLayer::setHasHorizontalScrollbar): (WebCore::RenderLayer::setHasVerticalScrollbar):
  • rendering/RenderLayer.h: (WebCore::RenderLayer::horizontalScrollbar): (WebCore::RenderLayer::verticalScrollbar):
  • rendering/RenderListBox.h: (WebCore::RenderListBox::scrollbarCornerPresent):
1:56 PM Changeset in webkit [37561] by hyatt@apple.com
  • 6 edits in trunk/WebCore

2008-10-13 David Hyatt <​hyatt@apple.com>

Make resizers and scrollbar corners respect :window-inactive (one more bug fix and then Tim's master
test case for all this can land).

Reviewed by Tim Hatcher

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkSelector): (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintOverflowControls): (WebCore::RenderLayer::paintScrollCorner): (WebCore::RenderLayer::paintResizer): (WebCore::RenderLayer::styleChanged): (WebCore::RenderLayer::updateScrollCornerStyle): (WebCore::RenderLayer::updateResizerStyle):
  • rendering/RenderLayer.h:
  • rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::paint):
  • rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::paintIntoRect):
1:21 PM Changeset in webkit [37560] by hyatt@apple.com
  • 5 edits in trunk/WebCore

2008-10-13 David Hyatt <​hyatt@apple.com>

Rework resizer and scroll corner painting so that custom resizers and scroll corners will paint
and invalidate properly as images load, etc.

Reviewed by Tim Hatcher

  • rendering/RenderLayer.cpp: (WebCore::cornerRect): (WebCore::scrollCornerRect): (WebCore::resizerCornerRect): (WebCore::RenderLayer::positionOverflowControls): (WebCore::RenderLayer::paintOverflowControls): (WebCore::RenderLayer::paintScrollCorner): (WebCore::RenderLayer::paintResizer): (WebCore::RenderLayer::isPointInResizeControl): (WebCore::RenderLayer::hitTestOverflowControls): (WebCore::RenderLayer::styleChanged):
  • rendering/RenderLayer.h:
  • rendering/RenderObject.h: (WebCore::RenderObject::setRect):
  • rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::styleDidChange): (WebCore::RenderScrollbarPart::imageChanged):
11:55 AM Changeset in webkit [37559] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

Bug 21457: resolve-ChangeLogs should be able to operate on a git revision range

<​https://bugs.webkit.org/show_bug.cgi?id=21457>

Reviewed by Adam.

  • Scripts/resolve-ChangeLogs: Added optional parameter to
-ffix-merged switch to run the script on a revision range.

Updated command-line validation checks.
(findChangeLog): Fixed long-standing bug that should have used
$_[0] instead of $_.
(fixMergedChangeLog): Renamed to fixOneMergedChangeLog($). Updated
to work when called from git filter-branch. It always restores a
copy of the previous revision before reapplying the patch.
(fixMergedChangeLogs): Added. Calls itself through git filter-branch
to re-merge ChangeLog files across a revision range. Removes
.git/refs/original directory on success.

(parseFixMerged): Added. Custom method to parse the -ffix-merged

switch.
(removeChangeLogArguments): Added. Removes items from @ARGV when
they are ChangeLog paths, and return a list of paths. This makes it
easier to validate the command-line.
(resolveChangeLog): Added. Extracted from main code block. Runs
the traditional single-file merge algorithm.
(usageAndExit): Added. Extracted from main code block. Prints
usage statement and exits with error status.

11:31 AM Changeset in webkit [37558] by sfalken@apple.com
  • 9 edits in branches/Safari-3-2-branch

WebCore:

2008-10-13 Steve Falkenburg <​sfalken@apple.com>

Roll out r36884.

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/win/GraphicsContextCGWin.cpp: (WebCore::CGContextWithHDC): (WebCore::GraphicsContext::GraphicsContext):

WebKit/win:

2008-10-13 Steve Falkenburg <​sfalken@apple.com>

Roll out r36883, r36884.

Added unimplemented method to IWebViewPrivate (paintDocumentRectToContext) for nightly compatibility
(we need to preserve vtable order).

  • Interfaces/IWebViewPrivate.idl:
  • WebFrame.cpp: (WebFrame::transitionToCommittedForNewPage): (WebFrame::unmarkAllBadGrammar):
  • WebFrame.h:
  • WebView.cpp: (WebView::WebView): (WebView::paintIntoBackingStore): (WebView::paintDocumentRectToContext):
  • WebView.h:
11:23 AM Changeset in webkit [37557] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

2008-10-13 Steve Falkenburg <​sfalken@apple.com>

Reorder methods to preserve compatibility.


Rubber stamped by Oliver Hunt.

  • Interfaces/IWebViewPrivate.idl:
4:44 AM Changeset in webkit [37556] by jmalonzo@webkit.org
  • 6 edits
    2 adds in trunk

2008-10-13 Marco Barisione <​marco.barisione@collabora.co.uk>

Reviewed by Darin Adler. Landed by Jan Alonzo.

WebKit GTK Port needs a smartpointer to handle g_free (GFreePtr?)
​http://bugs.webkit.org/show_bug.cgi?id=20483

Start the conversion to use GOwnPtr and fix a memory leak.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateErrorCallback):

2008-10-13 Marco Barisione <​marco.barisione@collabora.co.uk>

Reviewed by Darin Adler. Landed by Jan Alonzo.

WebKit GTK Port needs a smartpointer to handle g_free (GFreePtr?)
​http://bugs.webkit.org/show_bug.cgi?id=20483

Add a GOwnPtr smart pointer (similar to OwnPtr) to handle memory
allocated by GLib and start the conversion to use it.

  • GNUmakefile.am:
  • wtf/GOwnPtr.cpp: Added. (WTF::GError): (WTF::GList): (WTF::GCond): (WTF::GMutex): (WTF::GPatternSpec): (WTF::GDir):
  • wtf/GOwnPtr.h: Added. (WTF::freeOwnedPtr): (WTF::GOwnPtr::GOwnPtr): (WTF::GOwnPtr::~GOwnPtr): (WTF::GOwnPtr::get): (WTF::GOwnPtr::release): (WTF::GOwnPtr::rawPtr): (WTF::GOwnPtr::set): (WTF::GOwnPtr::clear): (WTF::GOwnPtr::operator*): (WTF::GOwnPtr::operator->): (WTF::GOwnPtr::operator!): (WTF::GOwnPtr::operator UnspecifiedBoolType): (WTF::GOwnPtr::swap): (WTF::swap): (WTF::operator==): (WTF::operator!=): (WTF::getPtr):
  • wtf/Threading.h:
  • wtf/ThreadingGtk.cpp: (WTF::Mutex::~Mutex): (WTF::Mutex::lock): (WTF::Mutex::tryLock): (WTF::Mutex::unlock): (WTF::ThreadCondition::~ThreadCondition): (WTF::ThreadCondition::wait): (WTF::ThreadCondition::timedWait): (WTF::ThreadCondition::signal): (WTF::ThreadCondition::broadcast):

Oct 12, 2008:

7:43 PM Changeset in webkit [37555] by jhoneycutt@apple.com
  • 2 edits in trunk/WebCore

2008-10-12 Jon Honeycutt <​jhoneycutt@apple.com>

Windows build fix.

  • loader/TextResourceDecoder.cpp:
7:20 PM Changeset in webkit [37554] by Darin Adler
  • 5 edits in trunk/LayoutTests

2008-10-12 Pamela Greene <​pam@chromium.org>

Reviewed by Darin Adler.

Add tests to cover more gradient edge cases: missing endpoints, only
endpoints, only one stop.

  • fast/canvas/fillrect_gradient.html:
  • platform/mac/fast/canvas/fillrect_gradient-expected.checksum:
  • platform/mac/fast/canvas/fillrect_gradient-expected.png:
  • platform/mac/fast/canvas/fillrect_gradient-expected.txt:
7:16 PM Changeset in webkit [37553] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

2008-10-12 Gabriella Toth <​gtoth@inf.u-szeged.hu>

Reviewed by Darin Adler.

  • kjs/nodes.cpp: Deleted a function that is not invoked: statementListInitializeVariableAccessStack.
7:13 PM Changeset in webkit [37552] by Darin Adler
  • 2 edits in trunk/WebCore

2008-10-12 Darin Fisher <​darin@chromium.org>

Reviewed by Darin Adler.

  • platform/network/NetworkStateNotifier.h: Add the #include.
6:41 PM Changeset in webkit [37551] by abarth@webkit.org
  • 1 edit in trunk/LayoutTests/ChangeLog

Fix typo in LayoutTests/ChangeLog

6:37 PM Changeset in webkit [37550] by Darin Adler
  • 6 edits
    2 adds in trunk/WebCore

2008-10-12 Darin Adler <Darin Adler>

Based on work by Holger Freyther.

  • GNUmakefile.am: Added new source files.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • WebCoreSources.bkl: Ditto.
  • platform/graphics/Font.cpp: Use WidthIterator from its new place.
  • platform/graphics/WidthIterator.cpp: Added.
  • platform/graphics/WidthIterator.h: Added.
6:29 PM Changeset in webkit [37549] by abarth@webkit.org
  • 3 edits in trunk/LayoutTests

2008-10-12 Pamela Greene <​pam@chromium.org>

Fixed 'completed' variable name to match 'running' one.
See ​https://bugs.webkit.org/show_bug.cgi?21506

Reviewed by Darin Adler.
Landed by Adam Barth.

  • dom/html/level2/html/HTMLFrameElement09.js:
  • dom/html/level2/html/HTMLIFrameElement11.js:
6:26 PM Changeset in webkit [37548] by mrowe@apple.com
  • 2 edits in branches/Safari-3-2-branch/JavaScriptCore

Merge r37526.

6:15 PM Changeset in webkit [37547] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2008-10-12 Pamela Greene <​pam@chromium.org>

Remove a race condition in a test by promoting layoutTestController
calls outside document.write(). Add document.close().
See ​https://bugs.webkit.org/show_bug.cgi?id=21524

Reviewed by Darin Adler.
Landed by Adam Barth.

  • fast/encoding/script-in-head.html:
6:15 PM Changeset in webkit [37546] by abarth@webkit.org
  • 4 edits
    1 add in trunk/LayoutTests

2008-10-12 Pamela Greene <​pam@chromium.org>

Remove data: URLs to avoid cross-domain security restrictions.
See ​https://bugs.webkit.org/show_bug.cgi?id=21528

Reviewed by Darin Adler.
Landed by Adam Barth.

  • fast/events/resources/tabindex-focus-blur-all-frame1.html:
  • fast/events/resources/tabindex-focus-blur-all-frame2.html:
  • fast/events/resources/tabindex-focus-blur-all-frame3.html: Added.
  • fast/events/tabindex-focus-blur-all.html:
6:15 PM Changeset in webkit [37545] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2008-10-12 Pamela Greene <​pam@chromium.org>

Fix test when removesExtraParentheses == false.
See ​https://bugs.webkit.org/show_bug.cgi?id=21529

Reviewed by Darin Adler.
Landed by Adam Barth.

  • fast/js/resources/function-toString-parentheses.js:
6:15 PM Changeset in webkit [37544] by abarth@webkit.org
  • 4 edits in trunk/LayoutTests

2008-10-12 Pamela Greene <​pam@chromium.org>

Fix a race condition by waiting for all create functions to be called
before terminating.
See ​https://bugs.webkit.org/show_bug.cgi?id=21531

Reviewed by Darin Adler.
Landed by Adam Barth.

  • platform/mac/svg/carto.net/window-expected.checksum:
  • platform/mac/svg/carto.net/window-expected.png:
  • platform/mac/svg/carto.net/window-expected.txt:
  • svg/carto.net/window.svg:
6:14 PM Changeset in webkit [37543] by abarth@webkit.org
  • 3 edits in trunk/LayoutTests

2008-10-12 Pamela Greene <​pam@chromium.org>

Remove inadvertent const redefinition, and add specific test for it.
See ​https://bugs.webkit.org/show_bug.cgi?id=21532

Reviewed by Darin Adler.
Landed by Adam Barth.

  • fast/js/const-expected.txt:
  • fast/js/resources/const.js:
6:14 PM Changeset in webkit [37542] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2008-10-12 Pamela Greene <​pam@chromium.org>

Add a test for null character data.
See ​https://bugs.webkit.org/show_bug.cgi?id=21535

Reviewed by Darin Adler.
Landed by Adam Barth.

  • fast/dom/null-chardata-crash-expected.txt: Added.
  • fast/dom/null-chardata-crash.html: Added.
6:13 PM Changeset in webkit [37541] by Darin Adler
  • 3 edits in trunk/WebCore

2008-10-12 Tony Chang <​tony@chromium.org>

Reviewed by Sam Weinig.

  • plugins/PluginInfoStore.cpp: Added an include.
  • plugins/PluginInfoStore.h: Removed struct declarations.
6:07 PM Changeset in webkit [37540] by Darin Adler
  • 3 edits in trunk/WebCore

2008-10-12 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

  • platform/graphics/Gradient.cpp: Removed the overload of addColorStop that accepts a CSS color string. That's handled in the DOM now, not here. (WebCore::Gradient::addColorStop): Use getRGBA instead of having our own copy of it here.
  • platform/graphics/Gradient.h: More of the same. Tweak formatting a bit.
5:58 PM Changeset in webkit [37539] by Darin Adler
  • 4 edits
    3 adds
    6 deletes in trunk

WebCore:

2008-10-12 Glenn Wilson <​gwilson@google.com>

Reviewed by Darin Adler.

Added feature to allow multi-line inputs into text fields.
HTMLInputElement would cut the set text at the first 'system' character,
so it would truncate at the first carriage return or newline.
This fix modifies that behavior to truncate at any non-space system character
but changes \r, \n, and \r\n to a single space.

Tests: editing/pasteboard/paste-multiline-text-input.html


  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::constrainValue):

LayoutTests:

2008-10-12 Glenn Wilson <​gwilson@google.com>

Reviewed by Darin Adler.

Added new test to verify that the user can cut and paste multiple lines of text
into a single line text field.

  • fast/forms/paste-multiline-text-input-expected.txt: Added.
  • fast/forms/paste-multiline-text-input.html: Added.
  • fast/forms/input-truncate-newline-expected.txt: Removed.
  • fast/forms/input-truncate-newline.html: Removed.
  • fast/forms/8250-expected.txt: Added.
  • fast/forms/8250.html: Updated test to be text-only and expect new results.
  • platform/mac/fast/forms/8250-expected.checksum: Removed.
  • platform/mac/fast/forms/8250-expected.png: Removed.
  • platform/mac/fast/forms/8250-expected.txt: Removed.
  • platform/qt/fast/forms/8250-expected.txt: Removed.
5:25 PM Changeset in webkit [37538] by Darin Adler
  • 8 edits
    9 adds in trunk

WebCore:

2008-10-12 Dirk Schulze <​vbs85@gmx.de>

Reviewed by Eric Seidel.

Added exception codes to canvas gradients to match current specification.

Tests: fast/canvas/gradient-addColorStop-with-invalid-color.html

fast/canvas/linearGradient-infinite-values.html
fast/canvas/radialGradient-infinite-values.html

  • html/CanvasGradient.cpp: (WebCore::CanvasGradient::addColorStop):
  • html/CanvasGradient.h:
  • html/CanvasGradient.idl:
  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createLinearGradient): (WebCore::CanvasRenderingContext2D::createRadialGradient):
  • html/CanvasRenderingContext2D.h:
  • html/CanvasRenderingContext2D.idl:

LayoutTests:

2008-10-12 Dirk Schulze <​vbs85@gmx.de>

Reviewed by Eric Seidel.

Added new tests to check behavior of canvas gradients to infinite values
or invalid colors.

  • fast/canvas/gradient-addColorStop-with-invalid-color-expected.txt: Added.
  • fast/canvas/gradient-addColorStop-with-invalid-color.html: Added.
  • fast/canvas/linearGradient-infinite-values-expected.txt: Added.
  • fast/canvas/linearGradient-infinite-values.html: Added.
  • fast/canvas/radialGradient-infinite-values-expected.txt: Added.
  • fast/canvas/radialGradient-infinite-values.html: Added.
  • fast/canvas/resources/gradient-addColorStop-with-invalid-color.js: Added.
  • fast/canvas/resources/linearGradient-infinite-values.js: Added.
  • fast/canvas/resources/radialGradient-infinite-values.js: Added.
4:59 PM Changeset in webkit [37537] by Darin Adler
  • 3 edits in trunk/WebCore

2008-10-12 Eric Roman <​eroman@chromium.org>

Reviewed by David Hyatt.

  • rendering/RenderThemeWin.cpp: (WebCore::cssValueIdToSysColorIndex): (WebCore::RenderThemeWin::systemColor):
  • rendering/RenderThemeWin.h:
4:51 PM Changeset in webkit [37536] by mrowe@apple.com
  • 4 edits in branches/Safari-3-2-branch/WebKit/win

Merge r36005.

4:50 PM Changeset in webkit [37535] by Darin Adler
  • 2 edits in trunk/WebCore

2008-10-12 Aaron Bockover <​abockover@novell.com>

Reviewed by Alp Toker.

Add version parsing for Flash, and the PluginQuirkDontSetNullWindowHandleOnDestroy
plugin quirk if Flash 10 or newer since at least in b218, setting a NULL window
handler on destroy crashes WebKit <​https://bugs.webkit.org/show_bug.cgi?id=19859>

  • plugins/gtk/PluginPackageGtk.cpp:
4:01 PM Changeset in webkit [37534] by Darin Adler
  • 2 edits in trunk/WebCore

2008-10-12 Jonathon Jongsma <​jonathon.jongsma@collabora.co.uk>

Reviewed by Oliver Hunt.

  • page/DragController.cpp: (WebCore::DragController::startDrag): When a link is dragged without any text selected (note: for this to work, the EditableLinkBehavior setting must be set to 'live' or 'default') and then dropped into an editable html document it will eventually violate an ASSERT in MoveSelectionCommand that requires that there is a selection. To prevent this, expand the selection to the enclosing anchor tag when the drag begins.
3:53 PM Changeset in webkit [37533] by Darin Adler
  • 2 edits in trunk/WebCore

2008-10-12 Darin Adler <Darin Adler>

Reviewed by Mark Rowe.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::getPseudoStyle): Keep walking up the parent chain until we hit an Element. Nowadays, Node::isElementNode() is just as efficient as RenderObject::isText(), and this guarantees that the node can be cast to Element*, which is done just below. The reason this is hit is that RenderLayer can call getPseudoStyle on a RenderView, which has the document as its element() -- and a document is neither a Text node nor an Element. A loose end is that this seems to mean you can't style the scrollbar corner or the resizer on a RenderView. Hyatt may want to look into that later.
3:51 PM Changeset in webkit [37532] by Darin Adler
  • 3 edits in trunk/JavaScriptCore

2008-10-12 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

  • wtf/unicode/icu/UnicodeIcu.h: Fixed indentation to match WebKit coding style.
  • wtf/unicode/qt4/UnicodeQt4.h: Ditto.
3:49 PM Changeset in webkit [37531] by Darin Adler
  • 8 edits
    12 adds in trunk

JavaScriptCore:

2008-10-12 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

  • wtf/unicode/icu/UnicodeIcu.h: Removed isDigit, digitValue, and isFormatChar.
  • wtf/unicode/qt4/UnicodeQt4.h: Ditto.

WebCore:

2008-10-12 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Tests: fast/dom/HTMLFontElement/size-attribute.html

fast/dom/HTMLInputElement/size-attribute.html
fast/dom/HTMLTableElement/cellpadding-attribute.html

  • html/HTMLFontElement.cpp: (WebCore::parseFontSizeNumber): Use isASCIIDigit instead of Unicode::isDigit, since non-ASCII digits are not valid here.
  • html/HTMLFontElement.h: Tweaked formatting a bit and removed the unneeded destructor declaration.
  • platform/text/String.cpp: (WebCore::lengthOfCharactersAsInteger): Use isASCIIDigit instead of Unicode::isDigit, since non-ASCII digits are not valid.

LayoutTests:

2008-10-12 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

The fix was in a function used all over the place. I set a breakpoint in the
function and made some regression tests for the first few places it was used.

  • fast/dom/HTMLFontElement: Added.
  • fast/dom/HTMLFontElement/resources: Added.
  • fast/dom/HTMLFontElement/resources/TEMPLATE.html: Added.
  • fast/dom/HTMLFontElement/resources/size-attribute.js: Added.
  • fast/dom/HTMLFontElement/size-attribute-expected.txt: Added.
  • fast/dom/HTMLFontElement/size-attribute.html: Added.
  • fast/dom/HTMLInputElement/resources/size-attribute.js: Added.
  • fast/dom/HTMLInputElement/size-attribute-expected.txt: Added.
  • fast/dom/HTMLInputElement/size-attribute.html: Added.
  • fast/dom/HTMLTableElement/cellpadding-attribute-expected.txt: Added.
  • fast/dom/HTMLTableElement/cellpadding-attribute.html: Added.
  • fast/dom/HTMLTableElement/resources/cellpadding-attribute.js: Added.
3:38 PM Changeset in webkit [37530] by Darin Adler
  • 3 edits
    2 adds in trunk

WebCore:

2008-10-12 Jungshik Shin <​jshin@chromium.org>

Reviewed by Darin Adler.

Treat x-user-defined as windows-1252 for html files with meta charset
declaration to be compatible with Indian web sites.
( ​https://bugs.webkit.org/show_bug.cgi?id=18270 )

Test: fast/encoding/charset-xuser-defined.html

  • loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::setEncoding):

LayoutTests:

2008-10-12 Jungshik Shin <​jshin@chromium.org>

Reviewed by Darin Adler.

Treat x-user-defined as windows-1252 for html files with meta charset
declaration to be compatible with Indian web sites.
( ​https://bugs.webkit.org/show_bug.cgi?id=18270 )

  • fast/encoding/charset-xuser-defined-expected.txt: Added.
  • fast/encoding/charset-xuser-defined.html: Added.
3:24 PM Changeset in webkit [37529] by Darin Adler
  • 130 edits in trunk/LayoutTests

2008-10-12 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

  • svg/custom/immutable-properties.html: Updated path to test resources so it does not go up out of and back into LayoutTests.
  • svg/custom/svg-modify-currentTranslate.html: Ditto.
  • svg/custom/svg-xml-dom-sync.html: Ditto.
  • svg/custom/tearoffs-with-tearoffs.html: Ditto.
  • svg/dynamic-updates/resources/*.js: Allow the make-js-test-wrappers script to add var successfullyParsed = true; to these files. It's not helpful for the tests, but it's not harmful either.
2:32 PM Changeset in webkit [37528] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-10-12 Sam Weinig <​sam@webkit.org>

Reviewed by Dan Bernstein.

Remove unneeded forward declaration.

  • platform/graphics/ImageBuffer.h:
1:43 PM Changeset in webkit [37527] by weinig@apple.com
  • 14 edits
    1 add in trunk/WebCore

2008-10-12 Sam Weinig <​sam@webkit.org>

Reviewed by Darin Adler.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=21560
Layering violation: String should not be responsible for creating Lengths

It was a layering violation for String to know haw to parse
into Lengths, LengthArrays, and CoordsArrays.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::parseMappedAttribute):
  • html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::parseMappedAttribute):
  • platform/text/AtomicString.h: (WebCore::AtomicString::percentage):
  • platform/text/PlatformString.h:
  • platform/text/String.cpp:
  • platform/text/StringImpl.cpp:
  • platform/text/StringImpl.h:
  • rendering/Length.cpp: Added. (WebCore::parseLength): (WebCore::countCharacter): (WebCore::newCoordsArray): (WebCore::newLengthArray):
  • rendering/Length.h: (WebCore::LengthSize::LengthSize):
12:51 PM Changeset in webkit [37526] by andersca@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-10-12 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler.

Make the append method that takes a Vector more strict - it now requires the elements
of the vector to be appended same type as the elements of the Vector they're being appended to.


This would cause problems when dealing with Vectors containing other Vectors.


  • wtf/Vector.h: (WTF::::append):
12:34 PM Changeset in webkit [37525] by Darin Adler
  • 2 edits in trunk/WebKitTools

2008-10-12 Darin Adler <Darin Adler>

  • Scripts/make-js-test-wrappers: Update exceptions list so the script won't overwrite files and mangle tests.
11:23 AM Changeset in webkit [37524] by Darin Adler
  • 3 edits
    2 adds in trunk

WebCore:

2008-10-12 Brad Garcia <​bgarcia@google.com>

Reviewed by Darin Adler.

Interpret fractional percentage values for %MultiLength values.
Fix for ​https://bugs.webkit.org/show_bug.cgi?id=3591
Test: fast/frames/frame-length-fractional-percentage.html

  • platform/text/StringImpl.cpp: (WebCore::parseLength):

LayoutTests:

2008-10-12 Brad Garcia <​bgarcia@google.com>

Reviewed by Darin Adler.

Testcases for fractional frame lengths.
​https://bugs.webkit.org/show_bug.cgi?id=3591

  • fast/frames/frame-length-fractional.html: Added.
  • fast/frames/frame-length-fractional-expected.txt: Added.
10:04 AM Changeset in webkit [37523] by timothy@apple.com
  • 4 edits in trunk/WebCore

Remember the expanded state of the rules in the Styles pane. So
collapsing a rule will persist across all the elements that have
that same rule. The same applies to Computed Style, so the Computed
Style rule is now collapsed by default. This should help lessen the
confusion on why Computed Style can't be edited (a common confusion.)

​https://bugs.webkit.org/show_bug.cgi?id=21553

Reviewed by Darin Adler.

  • inspector/front-end/PropertiesSection.js: (WebInspector.PropertiesSection): Set the _expanded property directly, instead of using the setter. Expanded is the default, so no work is needed. This prevents calling StylesSidebarPane.collapse before object initialization is complete.
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update): Check the Preferences object for the expanded state of the StylePropertiesSection. Collapse computed style by default and expand everything else. (WebInspector.StylePropertiesSection): Make a semi unique identifier to be used when remembering expanded state. (WebInspector.StylePropertiesSection.prototype.expand): Set the expanded state to true for this identifier in Preferences.styleRulesExpandedState. Don't remember the state if the dontRememberState property is true. (WebInspector.StylePropertiesSection.prototype.collapse): Set the expanded state to false for this identifier in Preferences.styleRulesExpandedState.
  • inspector/front-end/inspector.js: (Preferences.styleRulesExpandedState): Initialize to an empty object.
4:47 AM Changeset in webkit [37522] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2008-10-12 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Alp Toker.

[Gtk] Remove libWebCoreJS.la when doing make clean
​https://bugs.webkit.org/show_bug.cgi?id=21544

Remove libWebCoreJS.la when doing a clean target

  • GNUmakefile.am: add libWebCoreJS.la to CLEANFILES
Note: See TracTimeline for information about the timeline view.