⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 15, 2008:

11:41 PM Changeset in webkit [37630] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=21610
run-webkit-threads --threaded crashes in StructureID destructor

  • kjs/StructureID.cpp: (JSC::StructureID::StructureID): (JSC::StructureID::~StructureID): Protect access to a static (debug-only) HashSet with a lock.
10:31 PM Changeset in webkit [37629] by weinig@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-10-15 Sam Weinig <​sam@webkit.org>

Reviewed by Goeffrey Garen.

Add function to dump statistics for StructureIDs.

  • kjs/StructureID.cpp: (JSC::StructureID::dumpStatistics): (JSC::StructureID::StructureID): (JSC::StructureID::~StructureID):
  • kjs/StructureID.h:
9:56 PM Changeset in webkit [37628] by jhoneycutt@apple.com
  • 2 edits in trunk/WebCore

2008-10-15 Jon Honeycutt <​jhoneycutt@apple.com>

Remove unneeded check of whether a Page defers loading before running it
in a modal dialog.

No test possible.

Reviewed by Tim Hatcher.

  • page/Chrome.cpp:
9:36 PM Changeset in webkit [37627] by cwzwarich@webkit.org
  • 3 edits in trunk/JavaScriptCore

2008-10-15 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Maciej Stachowiak.

Bug 21633: Avoid using a HashMap when there is only a single transition
<​https://bugs.webkit.org/show_bug.cgi?id=21633>

This is a 0.8% speedup on SunSpider and between a 0.5% and 1.0% speedup
on the V8 benchmark suite, depending on which harness we use. It will
also slightly reduce the memory footprint of a StructureID.

  • kjs/StructureID.cpp: (JSC::StructureID::StructureID): (JSC::StructureID::~StructureID): (JSC::StructureID::addPropertyTransition):
  • kjs/StructureID.h: (JSC::StructureID::):
8:09 PM Changeset in webkit [37626] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

Fix a leak of a CFStringRef reported by the build bot.

Reviewed by Jon Honeycutt.

  • Plugins/WebBaseNetscapePluginView.mm:

(-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]): Use a autoreleased
NSString rather than manually releasing a CFStringRef when we're done with it.

7:36 PM Changeset in webkit [37625] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-10-15 Csaba Osztrogonac <​oszi@inf.u-szeged.hu>

Reviewed by Geoffrey Garen.

1.40% speedup on SunSpider, 1.44% speedup on V8. (Linux)


No change on Mac.

  • VM/Machine.cpp: (JSC::fastIsNumber): ALWAYS_INLINE modifier added.
6:14 PM Changeset in webkit [37624] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2008-10-15 Kenneth Russell <​kenneth.russell@sun.com>

Reviewed and landed by Anders Carlsson.

​https://bugs.webkit.org/show_bug.cgi?id=21572


Initialize pluginFunc.size to the correct size before calling NP_GetEntryPoints.


  • Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]):
6:05 PM Changeset in webkit [37623] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

<rdar://problem/6272508> Crash occurs after loading flash content at ​http://www.macrumors.com/

Restore some code related to the CoreGraphics drawing model that was misplaced in r37131.

Reviewed by Dan Bernstein.

  • Plugins/WebBaseNetscapePluginView.mm:

(-[WebBaseNetscapePluginView invalidateRegion:]):
(-[WebBaseNetscapePluginView setVariable:value:]):

4:33 PM Changeset in webkit [37622] by ggaren@apple.com
  • 32 edits
    2 copies
    1 add in trunk

JavaScriptCore:

2008-10-15 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Cameron Zwarich.

Fixed ​https://bugs.webkit.org/show_bug.cgi?id=21345
Start the debugger without reloading the inspected page

  • VM/CodeBlock.h: (JSC::EvalCodeCache::get): Updated for tweak to parsing API.
  • kjs/CollectorHeapIterator.h: Added. An iterator for the object heap, which we use to find all the live functions and recompile them.
  • kjs/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::evaluate): Updated for tweak to parsing API.
  • kjs/FunctionConstructor.cpp: (JSC::constructFunction): Updated for tweak to parsing API.
  • kjs/JSFunction.cpp: (JSC::JSFunction::JSFunction): Try to validate our SourceCode in debug builds by ASSERTing that it's syntactically valid. This doesn't catch all SourceCode bugs, but it catches a lot of them.
  • kjs/JSGlobalObjectFunctions.cpp: (JSC::globalFuncEval): Updated for tweak to parsing API.
  • kjs/Parser.cpp: (JSC::Parser::parse):
  • kjs/Parser.h: (JSC::Parser::parse): Tweaked the parser to make it possible to parse without an ExecState, and to allow the client to specify a debugger to notify (or not) about the source we parse. This allows the inspector to recompile even though no JavaScript is executing, then notify the debugger about all source code when it's done.
  • kjs/Shell.cpp: (prettyPrintScript): Updated for tweak to parsing API.
  • kjs/SourceRange.h: (JSC::SourceCode::isNull): Added to help with ASSERTs.
  • kjs/collector.cpp: (JSC::Heap::heapAllocate): (JSC::Heap::sweep): (JSC::Heap::primaryHeapBegin): (JSC::Heap::primaryHeapEnd):
  • kjs/collector.h: (JSC::): Moved a bunch of declarations around to enable compilation of CollectorHeapIterator.
  • kjs/interpreter.cpp: (JSC::Interpreter::checkSyntax): (JSC::Interpreter::evaluate): Updated for tweak to parsing API.
  • kjs/lexer.h: (JSC::Lexer::sourceCode): BUG FIX: Calculate SourceCode ranges relative to the SourceCode range in which we're lexing, otherwise nested functions that are compiled individually get SourceCode ranges that don't reflect their nesting.
  • kjs/nodes.cpp: (JSC::FunctionBodyNode::FunctionBodyNode): (JSC::FunctionBodyNode::finishParsing): (JSC::FunctionBodyNode::create): (JSC::FunctionBodyNode::copyParameters):
  • kjs/nodes.h: (JSC::ScopeNode::setSource): (JSC::FunctionBodyNode::parameterCount): Added some helper functions for copying one FunctionBodyNode's parameters to another. The recompiler uses these when calling "finishParsing".

WebCore:

2008-10-15 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Cameron Zwarich.

Fixed ​https://bugs.webkit.org/show_bug.cgi?id=21345
Start the debugger without reloading the inspected page

  • WebCore.base.exp: New symbols.
  • ForwardingHeaders/kjs/CollectorHeapIterator.h: Copied from ForwardingHeaders/kjs/ustring.h.
  • ForwardingHeaders/kjs/Parser.h: Copied from ForwardingHeaders/kjs/ustring.h.
  • WebCore.xcodeproj/project.pbxproj: New forwarding headers.
  • inspector/InspectorController.cpp: (WebCore::InspectorController::setWindowVisible): (WebCore::InspectorController::windowScriptObjectAvailable): (WebCore::InspectorController::startDebugging):
  • inspector/InspectorController.h: Renamed startDebuggingAndReloadInspectedPage to startDebugging, and changed its behavior to match.
  • inspector/JavaScriptDebugListener.h:
  • inspector/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::JavaScriptDebugServer): (WebCore::JavaScriptDebugServer::addListener): (WebCore::JavaScriptDebugServer::removeListener): (WebCore::JavaScriptDebugServer::recompileAllJSFunctions): (WebCore::JavaScriptDebugServer::willAddFirstListener): (WebCore::JavaScriptDebugServer::didRemoveLastListener):
  • inspector/JavaScriptDebugServer.h: Refactored the JavaScriptDebugServer to centralize handling of adding the first listener and removing the last. Then, added a feature to recompile all JS functions in these cases. This allows us to dynamically add and remove hooks like the debugger hooks without reloading the page.
  • inspector/front-end/ScriptsPanel.js:
  • English.lproj/localizedStrings.js: Updated for startDebuggingAndReloadInspectedPage => startDebugging rename. Removed all UI that claimed that starting the debugger would reload the page.

WebKit/mac:

2008-10-15 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Cameron Zwarich.

Fixed ​https://bugs.webkit.org/show_bug.cgi?id=21345
Start the debugger without reloading the inspected page

WebKit/win:

2008-10-15 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Cameron Zwarich.

Fixed ​https://bugs.webkit.org/show_bug.cgi?id=21345
Start the debugger without reloading the inspected page

  • WebInspector.cpp: (WebInspector::toggleDebuggingJavaScript): Updated for rename.
3:22 PM Changeset in webkit [37621] by zecke@webkit.org
  • 2 edits in trunk/WebCore

2008-10-15 Holger Hans Peter Freyther <​zecke@selfish.org>

Build fix attempt.

Try to fix static/non-static declaration of g_string_append_uri_escape
by renaming that string. Another look needs to be taken.

  • platform/gtk/guriescape.c: (_webcore_g_string_append_uri_escaped): (_webcore_g_uri_escape_string):
3:10 PM Changeset in webkit [37620] by adele@apple.com
  • 2 edits in trunk/WebCore

2008-10-15 Adele Peterson <​adele@apple.com>

Attempt to fix the Tiger build.

  • platform/network/mac/ResourceHandleMac.mm:
3:08 PM Changeset in webkit [37619] by zecke@webkit.org
  • 2 edits in trunk/WebCore

Build fix for Cairo after changes to BitmapeImage.h

3:01 PM Changeset in webkit [37618] by zecke@webkit.org
  • 2 edits in trunk/WebCore

2008-10-15 Jeff Cook <​cookiecaper@gmail.com>

Reviewed by Holger Freyther.

Stop SIGSEGV when leaving a page with a Flash object by reordering
window destruction and plugin stop.

See ​https://bugs.webkit.org/show_bug.cgi?id=20779

  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::stop):
3:01 PM Changeset in webkit [37617] by mrowe@apple.com
  • 2 edits in trunk/WebKit

<rdar://problem/5803460> A file named StringsNotToBeLocalized.txt file is installed Webkit.framework/Resources.

Rubber-stamped by Brady Eidson.

  • WebKit.xcodeproj/project.pbxproj: Don't install StringsNotToBeLocalized.txt.
2:53 PM Changeset in webkit [37616] by adele@apple.com
  • 4 edits in trunk/WebCore

2008-10-15 Adele Peterson <​adele@apple.com>

Reviewed by Sam Weinig.

Implement didSendBodyData delegate method, and use older code path when that delegate doesn't exist.

  • platform/network/ResourceHandle.h:
  • platform/network/mac/FormDataStreamMac.mm: (WebCore::formRead):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::didSendBodyDataDelegateExists): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel): (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): (-[WebCoreResourceHandleAsDelegate connection:didSendBodyData:totalBytesWritten:totalBytesExpectedToWrite:]): (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]): (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]):
2:11 PM Changeset in webkit [37615] by pkasting@chromium.org
  • 2 edits in trunk/WebCore

2008-10-15 Peter Kasting <​pkasting@google.com>

Reviewed by David Hyatt.

Qt build bustage fix.

  • platform/graphics/qt/StillImageQt.h: (WebCore::StillImage::destroyDecodedData):
2:06 PM Changeset in webkit [37614] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2008-10-15 David Hyatt <​hyatt@apple.com>

Make sure scrollbar styles get deleted if they aren't assigned to a renderer.

Reviewed by Mark Rowe

  • rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::getScrollbarPseudoStyle): (WebCore::RenderScrollbar::updateScrollbarPart):
1:53 PM Changeset in webkit [37613] by zecke@webkit.org
  • 4 edits in trunk/WebCore

2008-10-15 Marco Barisione <​marco.barisione@collabora.co.uk>

Reviewed by Holger Freyther.

​http://bugs.webkit.org/show_bug.cgi?id=21211
[CURL] Upload doesn't work because cancel is called

FormDataStream::read returns 0 when retrieving data from the form
fails, but also when there is no more data to send. This means that
ResourceHandleManager::cancel is always called even when the data was
successfully sent.

Check if there are more elements in the form before calling
FormDataStream::read.

  • platform/network/curl/FormDataStreamCurl.cpp: (WebCore::FormDataStream::hasMoreElements):
  • platform/network/curl/FormDataStreamCurl.h:
  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::readCallback):
1:38 PM Changeset in webkit [37612] by pkasting@chromium.org
  • 11 edits in trunk/WebCore

2008-10-15 Peter Kasting <​pkasting@google.com>

Reviewed by David Hyatt.

​https://bugs.webkit.org/show_bug.cgi?id=19663 (Second attempt)
Account for paint and timer lag when animating images. Also pretend
that images whose animations were paused (by becoming invisible)
continued to animate, by "catching up" to the correct frame when they're
shown again.

  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::destroyDecodedData): (WebCore::BitmapImage::cacheFrame): (WebCore::BitmapImage::frameIsCompleteAtIndex): (WebCore::BitmapImage::frameDurationAtIndex): (WebCore::BitmapImage::frameHasAlphaAtIndex): (WebCore::BitmapImage::repetitionCount): (WebCore::BitmapImage::shouldAnimate): (WebCore::BitmapImage::startAnimation): (WebCore::BitmapImage::resetAnimation): (WebCore::BitmapImage::advanceAnimation): (WebCore::BitmapImage::internalAdvanceAnimation): (WebCore::BitmapImage::notifyObserverAndTrimDecodedData):
  • platform/graphics/BitmapImage.h: (WebCore::FrameData::FrameData): (WebCore::BitmapImage::):
  • platform/graphics/GeneratedImage.h: (WebCore::GeneratedImage::destroyDecodedData):
  • platform/graphics/Image.h:
  • platform/graphics/cairo/ImageCairo.cpp: (WebCore::FrameData::clear): (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::draw):
  • platform/graphics/cg/ImageCG.cpp: (WebCore::FrameData::clear): (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::draw):
  • platform/graphics/cg/PDFDocumentImage.h: (WebCore::PDFDocumentImage::destroyDecodedData):
  • platform/graphics/qt/ImageQt.cpp: (WebCore::FrameData::clear): (WebCore::BitmapImage::draw):
  • platform/graphics/wx/ImageWx.cpp: (WebCore::FrameData::clear): (WebCore::BitmapImage::draw):
  • svg/graphics/SVGImage.h: (WebCore::SVGImage::destroyDecodedData):
1:32 PM Changeset in webkit [37611] by Beth Dakin
  • 9 edits
    2 adds in trunk

WebCore:

2008-10-14 Maxime Britto <​britto@apple.com>

Reviewed by Darin Adler, tweaked and landed by Beth.

  • WebCore.base.exp: Exposes two functions to be able to create a selection from a point on the screen. Also exposes the new TextIterator::currentNode function.
  • WebCore/editing/TextIterator.cpp: (TextIterator::currentNode) : New function that returns the current text node or NULL if there is no text node.

WebKit:

2008-10-14 Maxime Britto <​britto@apple.com>

Reviewed by Darin Adler.

  • WebKit.xcodeproj/project.pbxproj: Added two files for the WebTextIterator, and made the WebTextIterator.h private

WebKit/mac:

2008-10-14 Maxime Britto <​britto@apple.com>

Reviewed by Darin Adler.

Added SPI to use WebCore's TextIterator with WebKit.

  • WebView/WebTextIterator.h: Added.
  • WebView/WebTextIterator.mm: Added. (-[WebTextIteratorPrivate dealloc]): (-[WebTextIterator dealloc]): (-[WebTextIterator initWithRange:]): Creates a TextIterator instance (-[WebTextIterator advance]): Asks the iterator to advance() . (-[WebTextIterator currentNode]): Returns the current DOMNode from the iterator (-[WebTextIterator currentText]): Returns the current text from the iterator (-[WebTextIterator atEnd]): Indicated whether the iterator has reached the end of the range.
  • WebView/WebView.h:
  • WebView/WebView.mm: (-[WebView textIteratorForRect:]): Returns a WebTextIterator with the DOMRange contained in the rectangle given as a parameter.
1:18 PM Changeset in webkit [37610] by zecke@webkit.org
  • 7 edits
    2 adds in trunk/WebCore

2008-10-15 Marco Barisione <​marco.barisione@collabora.co.uk>

Reviewed by Holger Freyther.

​http://bugs.webkit.org/show_bug.cgi?id=20664
[GTK] File names are not always encodable in UTF-8

On Linux file names are just raw data and cannot always be directly
encoded in UTF-8 or in any other encodings, so we escape them before
storing the file name in a String and unescape them before passing
them to native functions handling files.

  • GNUmakefile.am:
  • platform/FileSystem.h:
  • platform/gtk/FileChooserGtk.cpp: (WebCore::stringByAdoptingFileSystemRepresentation): (WebCore::FileChooser::basenameForWidth):
  • platform/gtk/FileSystemGtk.cpp: (WebCore::filenameToString): (WebCore::filenameFromString): (WebCore::filenameForDisplay): (WebCore::fileExists): (WebCore::deleteFile): (WebCore::deleteEmptyDirectory): (WebCore::getFileSize): (WebCore::getFileModificationTime): (WebCore::makeAllDirectories): (WebCore::homeDirectoryPath): (WebCore::pathGetFileName): (WebCore::listDirectory):
  • platform/gtk/KURLGtk.cpp: (WebCore::KURL::fileSystemPath):
  • platform/gtk/SharedBufferGtk.cpp: (WebCore::SharedBuffer::createWithContentsOfFile):
  • platform/gtk/guriescape.c: Added. (is_valid): (gunichar_ok): (g_string_append_uri_escaped): (_webcore_g_uri_escape_string):
  • platform/gtk/guriescape.h: Added.
11:23 AM Changeset in webkit [37609] by Adam Roben
  • 3 edits in trunk/WebKit/win

Export WTF::Mutex::tryLock

  • WebKit.vcproj/WebKit.def:
  • WebKit.vcproj/WebKit_debug.def:
11:19 AM Changeset in webkit [37608] by sfalken@apple.com
  • 1 edit in tags/Safari-6528.4.2/WebCore/WebCore.vcproj/WebCore.submit.sln

Merge r37596.

11:12 AM Changeset in webkit [37607] by sfalken@apple.com
  • 1 copy in tags/Safari-6528.4.2

New tag.

10:21 AM Changeset in webkit [37606] by timothy@apple.com
  • 3 edits in trunk/WebKit/mac

Clean up user agent generation to simplify the _standardUserAgentWithApplicationName:
class method to not require a WebKit version.

Reviewed by Darin Adler.

  • WebView/WebView.mm: (+[WebView _standardUserAgentWithApplicationName:]): Create the WebKit version. (-[WebView WebCore::_userAgentForURL:]): Use the simplified _standardUserAgentWithApplicationName:. Remove code that created the WebKit version.
  • WebView/WebViewPrivate.h: Change the method name of _standardUserAgentWithApplicationName:.
10:02 AM Changeset in webkit [37605] by Darin Adler
  • 15 edits in trunk/WebCore

2008-10-15 Dirk Schulze <​vbs85@gmx.de>

Reviewed by Eric Seidel.

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::spreadMethod): (WebCore::GraphicsContext::setSpreadMethod):
  • platform/graphics/GraphicsContext.h: (WebCore::):
  • platform/graphics/GraphicsContextPrivate.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::applySpreadMethod): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::applySpreadMethod): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath):
  • svg/GradientAttributes.h: (WebCore::GradientAttributes::GradientAttributes): (WebCore::GradientAttributes::spreadMethod): (WebCore::GradientAttributes::setSpreadMethod):
  • svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::parseMappedAttribute):
  • svg/SVGGradientElement.h:
  • svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::collectGradientProperties):
  • svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::collectGradientProperties):
  • svg/graphics/SVGPaintServerGradient.cpp: (WebCore::operator<<): (WebCore::SVGPaintServerGradient::SVGPaintServerGradient): (WebCore::SVGPaintServerGradient::spreadMethod): (WebCore::SVGPaintServerGradient::setGradientSpreadMethod): (WebCore::SVGPaintServerGradient::externalRepresentation):
  • svg/graphics/SVGPaintServerGradient.h:
  • svg/graphics/cairo/SVGPaintServerGradientCairo.cpp: (WebCore::SVGPaintServerGradient::setup):
  • svg/graphics/qt/SVGPaintServerGradientQt.cpp: (WebCore::SVGPaintServerGradient::setup):
9:42 AM Changeset in webkit [37604] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

2008-10-15 Joerg Bornemann <​joerg.bornemann@trolltech.com>

Reviewed by Darin Adler.

str(n)icmp, strdup and vsnprintf are not available on Windows CE,
they are called _str(n)icmp, etc. instead

  • wtf/StringExtras.h: Added inline function implementations.
9:34 AM Changeset in webkit [37603] by jchaffraix@webkit.org
  • 7 edits
    4 copies in branches/XBL2/WebCore

2008-10-15 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by David Hyatt.

Bug 20490: [XBL] XBLBinding should be split into several classes

  • Distribute XBLBinding's methods and attributes between 2 new classes:
  • XBLBindingPrototype: holds and manages the binding element.
  • XBLDocumentPrototype: loads and stores the binding document.
  • Make the 2 new classes RefCounted as they should be shared between multiple bindings.

No functional changes, thus no test cases.

  • GNUmakefile.am: Add the 2 new files to compile.
  • WebCore.pro: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • xbl/XBLBinding.cpp: (WebCore::XBLBinding::XBLBinding): Take an XBLBindingPrototype. (WebCore::XBLBinding::~XBLBinding): Zero the XBLBindingPrototype. (WebCore::XBLBinding::uri):
  • xbl/XBLBinding.h:
  • xbl/XBLBindingManager.cpp: (WebCore::XBLBindingManager::addBinding):
  • xbl/XBLBindingPrototype.cpp: Copied from WebCore/xbl/XBLBinding.cpp. (WebCore::XBLBindingPrototype::XBLBindingPrototype): (WebCore::XBLBindingPrototype::~XBLBindingPrototype): (WebCore::XBLBindingPrototype::updateBindingElement): Renamed getBindingElement to updateBindingElement.
  • xbl/XBLBindingPrototype.h: Copied from WebCore/xbl/XBLBinding.h. (WebCore::XBLBindingPrototype::create):
  • xbl/XBLDocumentPrototype.cpp: Copied from WebCore/xbl/XBLBinding.cpp. (WebCore::XBLDocumentPrototype::XBLDocumentPrototype): (WebCore::XBLDocumentPrototype::~XBLDocumentPrototype): (WebCore::XBLDocumentPrototype::setXBLDocument):
  • xbl/XBLDocumentPrototype.h: Copied from WebCore/xbl/XBLBinding.h. (WebCore::XBLDocumentPrototype::create): (WebCore::XBLDocumentPrototype::bindingDocument):
2:35 AM Changeset in webkit [37602] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-10-15 Gabor Loki <​loki@inf.u-szeged.hu>

Reviewed by Cameron Zwarich.

<​https://bugs.webkit.org/show_bug.cgi?id=20912>
Use simple uint32_t multiplication on op_mul if both operands are
immediate number and they are between zero and 0x7FFF.

  • VM/Machine.cpp: (JSC::Machine::privateExecute):

Oct 14, 2008:

10:22 PM Changeset in webkit [37601] by darin@chromium.org
  • 2 edits in trunk/WebCore

2008-10-09 Darin Fisher <​darin@chromium.org>

Reviewed by Sam Weinig.

Make pan scrolling a platform configurable option
​https://bugs.webkit.org/show_bug.cgi?id=21515

  • page/EventHandler.cpp: (WebCore::EventHandler::handleAutoscroll): (WebCore::EventHandler::autoscrollTimerFired): (WebCore::EventHandler::stopAutoscrollTimer): (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::keyEvent):
10:21 PM Changeset in webkit [37600] by darin@chromium.org
  • 2 edits in trunk/JavaScriptCore

2008-10-09 Darin Fisher <​darin@chromium.org>

Reviewed by Sam Weinig.

Make pan scrolling a platform configurable option.
​https://bugs.webkit.org/show_bug.cgi?id=21515

  • wtf/Platform.h: Add ENABLE_PAN_SCROLLING
10:15 PM Changeset in webkit [37599] by darin@chromium.org
  • 17 edits in trunk/WebCore

2008-10-10 Darin Fisher <​darin@chromium.org>

Reviewed by Darin Adler.

Add some PLATFORM(CHROMIUM) ifdefs to WebCore
​https://bugs.webkit.org/show_bug.cgi?id=21511

  • loader/FTPDirectoryDocument.cpp:
  • loader/FTPDirectoryParser.cpp:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::finishedLoadingDocument):
  • platform/ContextMenuItem.h:
  • platform/Cursor.h:
  • platform/DragData.h:
  • platform/DragImage.h:
  • platform/Pasteboard.h:
  • platform/PlatformKeyboardEvent.h: (WebCore::PlatformKeyboardEvent::isSystemKey):
  • platform/PlatformMenuDescription.h:
  • platform/PlatformMouseEvent.h:
  • platform/PlatformWheelEvent.h:
  • platform/PopupMenu.h:
  • platform/ScrollView.h:
  • platform/Widget.h:
  • platform/network/NetworkStateNotifier.h:
8:41 PM Changeset in webkit [37598] by timothy@apple.com
  • 3 edits in trunk/WebKit/mac

Make the user agent generation method a class method and cache the WebKit
version in a static to prevent generating it every time. This is needed
clean up to fix <rdar://problem/6292331>. Moved all code to WebPrivate so
the class method can be in the WebViewPrivate.h header.

Reviewed by John Sullivan.

  • WebView/WebView.mm: (callGestalt): Moved. Same code. (createMacOSXVersionString): Moved. Same code. (createUserVisibleWebKitVersionString): Moved from _userVisibleBundleVersionFromFullVersion: and returns a copied string. (+[WebView _standardUserAgentWithApplicationName:andWebKitVersion:]): Made into a class method. (-[WebView WebCore::_userAgentForURL:]): Changed to cache the WebKit version.
  • WebView/WebViewPrivate.h: Added +_standardUserAgentWithApplicationName:andWebKitVersion:.
7:39 PM Changeset in webkit [37597] by mjs@apple.com
  • 9 edits in trunk/JavaScriptCore

2008-10-14 Maciej Stachowiak <​mjs@apple.com>

Rubber stamped by Sam Weinig.



Turns out GCC 4.2 is still a (small) regression, we'll have to do
more work to turn it on.

  • Configurations/DebugRelease.xcconfig:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • VM/CTI.cpp:
  • VM/CTI.h:
  • VM/Machine.cpp: (JSC::Machine::cti_op_convert_this): (JSC::Machine::cti_op_end): (JSC::Machine::cti_op_add): (JSC::Machine::cti_op_pre_inc): (JSC::Machine::cti_timeout_check): (JSC::Machine::cti_register_file_check): (JSC::Machine::cti_op_loop_if_less): (JSC::Machine::cti_op_loop_if_lesseq): (JSC::Machine::cti_op_new_object): (JSC::Machine::cti_op_put_by_id): (JSC::Machine::cti_op_put_by_id_second): (JSC::Machine::cti_op_put_by_id_generic): (JSC::Machine::cti_op_put_by_id_fail): (JSC::Machine::cti_op_get_by_id): (JSC::Machine::cti_op_get_by_id_second): (JSC::Machine::cti_op_get_by_id_generic): (JSC::Machine::cti_op_get_by_id_fail): (JSC::Machine::cti_op_instanceof): (JSC::Machine::cti_op_del_by_id): (JSC::Machine::cti_op_mul): (JSC::Machine::cti_op_new_func): (JSC::Machine::cti_op_call_JSFunction): (JSC::Machine::cti_vm_compile): (JSC::Machine::cti_op_push_activation): (JSC::Machine::cti_op_call_NotJSFunction): (JSC::Machine::cti_op_create_arguments): (JSC::Machine::cti_op_tear_off_activation): (JSC::Machine::cti_op_tear_off_arguments): (JSC::Machine::cti_op_ret_profiler): (JSC::Machine::cti_op_ret_scopeChain): (JSC::Machine::cti_op_new_array): (JSC::Machine::cti_op_resolve): (JSC::Machine::cti_op_construct_JSConstruct): (JSC::Machine::cti_op_construct_NotJSConstruct): (JSC::Machine::cti_op_get_by_val): (JSC::Machine::cti_op_resolve_func): (JSC::Machine::cti_op_sub): (JSC::Machine::cti_op_put_by_val): (JSC::Machine::cti_op_put_by_val_array): (JSC::Machine::cti_op_lesseq): (JSC::Machine::cti_op_loop_if_true): (JSC::Machine::cti_op_negate): (JSC::Machine::cti_op_resolve_base): (JSC::Machine::cti_op_resolve_skip): (JSC::Machine::cti_op_resolve_global): (JSC::Machine::cti_op_div): (JSC::Machine::cti_op_pre_dec): (JSC::Machine::cti_op_jless): (JSC::Machine::cti_op_not): (JSC::Machine::cti_op_jtrue): (JSC::Machine::cti_op_post_inc): (JSC::Machine::cti_op_eq): (JSC::Machine::cti_op_lshift): (JSC::Machine::cti_op_bitand): (JSC::Machine::cti_op_rshift): (JSC::Machine::cti_op_bitnot): (JSC::Machine::cti_op_resolve_with_base): (JSC::Machine::cti_op_new_func_exp): (JSC::Machine::cti_op_mod): (JSC::Machine::cti_op_less): (JSC::Machine::cti_op_neq): (JSC::Machine::cti_op_post_dec): (JSC::Machine::cti_op_urshift): (JSC::Machine::cti_op_bitxor): (JSC::Machine::cti_op_new_regexp): (JSC::Machine::cti_op_bitor): (JSC::Machine::cti_op_call_eval): (JSC::Machine::cti_op_throw): (JSC::Machine::cti_op_get_pnames): (JSC::Machine::cti_op_next_pname): (JSC::Machine::cti_op_push_scope): (JSC::Machine::cti_op_pop_scope): (JSC::Machine::cti_op_typeof): (JSC::Machine::cti_op_is_undefined): (JSC::Machine::cti_op_is_boolean): (JSC::Machine::cti_op_is_number): (JSC::Machine::cti_op_is_string): (JSC::Machine::cti_op_is_object): (JSC::Machine::cti_op_is_function): (JSC::Machine::cti_op_stricteq): (JSC::Machine::cti_op_nstricteq): (JSC::Machine::cti_op_to_jsnumber): (JSC::Machine::cti_op_in): (JSC::Machine::cti_op_push_new_scope): (JSC::Machine::cti_op_jmp_scopes): (JSC::Machine::cti_op_put_by_index): (JSC::Machine::cti_op_switch_imm): (JSC::Machine::cti_op_switch_char): (JSC::Machine::cti_op_switch_string): (JSC::Machine::cti_op_del_by_val): (JSC::Machine::cti_op_put_getter): (JSC::Machine::cti_op_put_setter): (JSC::Machine::cti_op_new_error): (JSC::Machine::cti_op_debug): (JSC::Machine::cti_vm_throw):
  • VM/Machine.h:
  • masm/X86Assembler.h: (JSC::X86Assembler::emitRestoreArgumentReference): (JSC::X86Assembler::emitRestoreArgumentReferenceForTrampoline):
  • wtf/Platform.h:
5:23 PM Changeset in webkit [37596] by sfalken@apple.com
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore.submit.sln

Build fix. Fix dependency chain in sln file.

3:43 PM Changeset in webkit [37595] by pam@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2008-10-14 Pamela Greene <​pam@chromium.org>

Add test to verify popup properties while they're opening.
The expected result is currently not the desired result.
See ​https://bugs.webkit.org/show_bug.cgi?id=21419 and
​https://bugs.webkit.org/show_bug.cgi?id=21597 .

Reviewed by Eric Seidel.

  • fast/dom/Window/window-open-pending-url-expected.txt: Added.
  • fast/dom/Window/window-open-pending-url.html: Added.
3:16 PM Changeset in webkit [37594] by adachan@apple.com
  • 6 edits in trunk/WebKitTools

Fix windows build.

Reviewed by Sam Weinig.

  • DumpRenderTree/cg/PixelDumpSupportCG.cpp:
  • DumpRenderTree/config.h:
  • DumpRenderTree/win/DumpRenderTreeWin.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp:
  • DumpRenderTree/win/UIDelegate.cpp:
3:11 PM Changeset in webkit [37593] by Adam Roben
  • 2 edits in trunk/BugsSite

Fix Bug 21602: Bugzilla times out trying to display formatted diff for attachment 24345

​https://bugs.webkit.org/show_bug.cgi?id=21602

Reviewed by Dave Kilzer.

  • PrettyPatch/PrettyPatch.rb: (PrettyPatch.BINARY_FILE_MARKER_FORMAT): Added. (PrettyPatch.FileDiff.initialize): If any of the lines in the diff are a binary file marker, mark this FileDiff as binary and stop trying to process the lines. (PrettyDiff.FileDiff.to_html): If we're binary, just print a string saying so.
2:31 PM Changeset in webkit [37592] by cmarrin@apple.com
  • 3 edits
    2 adds in trunk

2008-10-14 Chris Marrin <​cmarrin@apple.com>

Reviewed by Darin Adler.

Fixed ​https://bugs.webkit.org/show_bug.cgi?id=21490
Optimize keyframe style sheet changes by avoiding styleSheetChanged()

Test: css3/change-keyframes.html

  • css/WebKitCSSKeyframesRule.cpp: (WebCore::WebKitCSSKeyframesRule::append): (WebCore::WebKitCSSKeyframesRule::deleteRule):
1:35 PM Changeset in webkit [37591] by hyatt@apple.com
  • 5 edits
    273 adds in trunk

WebCore:

2008-10-14 David Hyatt <​hyatt@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=21595

Clean up background and overflow propagation from the body to the viewport. Make it match the
latest CSS2.1 spec thinking.

Reviewed by Adam Roben

Added many tests at fast/body-propagation/. These are Simon Pieters' tests of propagation handling
(available at ​http://simon.html5.org/test/css/magic-body/).

  • dom/Document.cpp: (WebCore::Document::body):
  • page/FrameView.cpp: (WebCore::FrameView::layout):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::styleDidChange): (WebCore::RenderBox::paintRootBoxDecorations): (WebCore::RenderBox::paintBoxDecorations): (WebCore::RenderBox::repaintLayerRectsForImage):

LayoutTests:

2008-10-14 David Hyatt <​hyatt@apple.com>

Add layout tests for body propagation of overflow and background to the viewport.

Reviewed by Adam Roben

  • fast/body-propagation: Added.
  • fast/body-propagation/background-color: Added.
  • fast/body-propagation/background-color/001-xhtml.xhtml: Added.
  • fast/body-propagation/background-color/001.html: Added.
  • fast/body-propagation/background-color/002-xhtml.xhtml: Added.
  • fast/body-propagation/background-color/002.html: Added.
  • fast/body-propagation/background-color/003-declarative.xhtml: Added.
  • fast/body-propagation/background-color/003-xhtml.xhtml: Added.
  • fast/body-propagation/background-color/003.html: Added.
  • fast/body-propagation/background-color/004-declarative.xhtml: Added.
  • fast/body-propagation/background-color/004-xhtml.xhtml: Added.
  • fast/body-propagation/background-color/004.html: Added.
  • fast/body-propagation/background-color/005-declarative.xhtml: Added.
  • fast/body-propagation/background-color/005-xhtml.xhtml: Added.
  • fast/body-propagation/background-color/005.html: Added.
  • fast/body-propagation/background-color/006-declarative.xhtml: Added.
  • fast/body-propagation/background-color/006-xhtml.xhtml: Added.
  • fast/body-propagation/background-color/006.html: Added.
  • fast/body-propagation/background-color/007-declarative.xhtml: Added.
  • fast/body-propagation/background-color/007-xhtml.xhtml: Added.
  • fast/body-propagation/background-color/007.html: Added.
  • fast/body-propagation/background-color/008-xhtml.xhtml: Added.
  • fast/body-propagation/background-color/008.html: Added.
  • fast/body-propagation/background-image: Added.
  • fast/body-propagation/background-image/001-xhtml.xhtml: Added.
  • fast/body-propagation/background-image/001.html: Added.
  • fast/body-propagation/background-image/002-xhtml.xhtml: Added.
  • fast/body-propagation/background-image/002.html: Added.
  • fast/body-propagation/background-image/003-declarative.xhtml: Added.
  • fast/body-propagation/background-image/003-xhtml.xhtml: Added.
  • fast/body-propagation/background-image/003.html: Added.
  • fast/body-propagation/background-image/004-declarative.xhtml: Added.
  • fast/body-propagation/background-image/004-xhtml.xhtml: Added.
  • fast/body-propagation/background-image/004.html: Added.
  • fast/body-propagation/background-image/005-declarative.xhtml: Added.
  • fast/body-propagation/background-image/005-xhtml.xhtml: Added.
  • fast/body-propagation/background-image/005.html: Added.
  • fast/body-propagation/background-image/006-declarative.xhtml: Added.
  • fast/body-propagation/background-image/006-xhtml.xhtml: Added.
  • fast/body-propagation/background-image/006.html: Added.
  • fast/body-propagation/background-image/007-declarative.xhtml: Added.
  • fast/body-propagation/background-image/007-xhtml.xhtml: Added.
  • fast/body-propagation/background-image/007.html: Added.
  • fast/body-propagation/background-image/008-xhtml.xhtml: Added.
  • fast/body-propagation/background-image/008.html: Added.
  • fast/body-propagation/background-image/009-xhtml.xhtml: Added.
  • fast/body-propagation/background-image/009.html: Added.
  • fast/body-propagation/background-image/010-xhtml.xhtml: Added.
  • fast/body-propagation/background-image/010.html: Added.
  • fast/body-propagation/background-image/resources: Added.
  • fast/body-propagation/background-image/resources/lime.png: Added.
  • fast/body-propagation/background-image/resources/red.png: Added.
  • fast/body-propagation/background-image/resources/white.png: Added.
  • fast/body-propagation/background-image/resources/yellow.png: Added.
  • fast/body-propagation/overflow: Added.
  • fast/body-propagation/overflow/001-xhtml.xhtml: Added.
  • fast/body-propagation/overflow/001.html: Added.
  • fast/body-propagation/overflow/002-xhtml.xhtml: Added.
  • fast/body-propagation/overflow/002.html: Added.
  • fast/body-propagation/overflow/003-declarative.xhtml: Added.
  • fast/body-propagation/overflow/003-xhtml.xhtml: Added.
  • fast/body-propagation/overflow/003.html: Added.
  • fast/body-propagation/overflow/004-declarative.xhtml: Added.
  • fast/body-propagation/overflow/004-xhtml.xhtml: Added.
  • fast/body-propagation/overflow/004.html: Added.
  • fast/body-propagation/overflow/005-declarative.xhtml: Added.
  • fast/body-propagation/overflow/005-xhtml.xhtml: Added.
  • fast/body-propagation/overflow/005.html: Added.
  • fast/body-propagation/overflow/006-declarative.xhtml: Added.
  • fast/body-propagation/overflow/006-xhtml.xhtml: Added.
  • fast/body-propagation/overflow/006.html: Added.
  • fast/body-propagation/overflow/007-declarative.xhtml: Added.
  • fast/body-propagation/overflow/007-xhtml.xhtml: Added.
  • fast/body-propagation/overflow/007.html: Added.
  • platform/mac/fast/body-propagation: Added.
  • platform/mac/fast/body-propagation/background-color: Added.
  • platform/mac/fast/body-propagation/background-color/001-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-color/001-expected.png: Added.
  • platform/mac/fast/body-propagation/background-color/001-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-color/001-xhtml-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-color/001-xhtml-expected.png: Added.
  • platform/mac/fast/body-propagation/background-color/001-xhtml-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-color/002-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-color/002-expected.png: Added.
  • platform/mac/fast/body-propagation/background-color/002-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-color/002-xhtml-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-color/002-xhtml-expected.png: Added.
  • platform/mac/fast/body-propagation/background-color/002-xhtml-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-color/003-declarative-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-color/003-declarative-expected.png: Added.
  • platform/mac/fast/body-propagation/background-color/003-declarative-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-color/003-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-color/003-expected.png: Added.
  • platform/mac/fast/body-propagation/background-color/003-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-color/003-xhtml-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-color/003-xhtml-expected.png: Added.
  • platform/mac/fast/body-propagation/background-color/003-xhtml-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-color/004-declarative-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-color/004-declarative-expected.png: Added.
  • platform/mac/fast/body-propagation/background-color/004-declarative-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-color/004-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-color/004-expected.png: Added.
  • platform/mac/fast/body-propagation/background-color/004-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-color/004-xhtml-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-color/004-xhtml-expected.png: Added.
  • platform/mac/fast/body-propagation/background-color/004-xhtml-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-color/005-declarative-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-color/005-declarative-expected.png: Added.
  • platform/mac/fast/body-propagation/background-color/005-declarative-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-color/005-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-color/005-expected.png: Added.
  • platform/mac/fast/body-propagation/background-color/005-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-color/005-xhtml-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-color/005-xhtml-expected.png: Added.
  • platform/mac/fast/body-propagation/background-color/005-xhtml-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-color/006-declarative-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-color/006-declarative-expected.png: Added.
  • platform/mac/fast/body-propagation/background-color/006-declarative-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-color/006-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-color/006-expected.png: Added.
  • platform/mac/fast/body-propagation/background-color/006-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-color/006-xhtml-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-color/006-xhtml-expected.png: Added.
  • platform/mac/fast/body-propagation/background-color/006-xhtml-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-color/007-declarative-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-color/007-declarative-expected.png: Added.
  • platform/mac/fast/body-propagation/background-color/007-declarative-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-color/007-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-color/007-expected.png: Added.
  • platform/mac/fast/body-propagation/background-color/007-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-color/007-xhtml-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-color/007-xhtml-expected.png: Added.
  • platform/mac/fast/body-propagation/background-color/007-xhtml-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-color/008-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-color/008-expected.png: Added.
  • platform/mac/fast/body-propagation/background-color/008-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-color/008-xhtml-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-color/008-xhtml-expected.png: Added.
  • platform/mac/fast/body-propagation/background-color/008-xhtml-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-image: Added.
  • platform/mac/fast/body-propagation/background-image/001-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-image/001-expected.png: Added.
  • platform/mac/fast/body-propagation/background-image/001-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-image/001-xhtml-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-image/001-xhtml-expected.png: Added.
  • platform/mac/fast/body-propagation/background-image/001-xhtml-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-image/002-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-image/002-expected.png: Added.
  • platform/mac/fast/body-propagation/background-image/002-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-image/002-xhtml-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-image/002-xhtml-expected.png: Added.
  • platform/mac/fast/body-propagation/background-image/002-xhtml-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-image/003-declarative-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-image/003-declarative-expected.png: Added.
  • platform/mac/fast/body-propagation/background-image/003-declarative-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-image/003-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-image/003-expected.png: Added.
  • platform/mac/fast/body-propagation/background-image/003-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-image/003-xhtml-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-image/003-xhtml-expected.png: Added.
  • platform/mac/fast/body-propagation/background-image/003-xhtml-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-image/004-declarative-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-image/004-declarative-expected.png: Added.
  • platform/mac/fast/body-propagation/background-image/004-declarative-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-image/004-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-image/004-expected.png: Added.
  • platform/mac/fast/body-propagation/background-image/004-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-image/004-xhtml-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-image/004-xhtml-expected.png: Added.
  • platform/mac/fast/body-propagation/background-image/004-xhtml-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-image/005-declarative-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-image/005-declarative-expected.png: Added.
  • platform/mac/fast/body-propagation/background-image/005-declarative-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-image/005-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-image/005-expected.png: Added.
  • platform/mac/fast/body-propagation/background-image/005-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-image/005-xhtml-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-image/005-xhtml-expected.png: Added.
  • platform/mac/fast/body-propagation/background-image/005-xhtml-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-image/006-declarative-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-image/006-declarative-expected.png: Added.
  • platform/mac/fast/body-propagation/background-image/006-declarative-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-image/006-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-image/006-expected.png: Added.
  • platform/mac/fast/body-propagation/background-image/006-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-image/006-xhtml-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-image/006-xhtml-expected.png: Added.
  • platform/mac/fast/body-propagation/background-image/006-xhtml-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-image/007-declarative-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-image/007-declarative-expected.png: Added.
  • platform/mac/fast/body-propagation/background-image/007-declarative-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-image/007-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-image/007-expected.png: Added.
  • platform/mac/fast/body-propagation/background-image/007-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-image/007-xhtml-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-image/007-xhtml-expected.png: Added.
  • platform/mac/fast/body-propagation/background-image/007-xhtml-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-image/008-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-image/008-expected.png: Added.
  • platform/mac/fast/body-propagation/background-image/008-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-image/008-xhtml-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-image/008-xhtml-expected.png: Added.
  • platform/mac/fast/body-propagation/background-image/008-xhtml-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-image/009-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-image/009-expected.png: Added.
  • platform/mac/fast/body-propagation/background-image/009-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-image/009-xhtml-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-image/009-xhtml-expected.png: Added.
  • platform/mac/fast/body-propagation/background-image/009-xhtml-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-image/010-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-image/010-expected.png: Added.
  • platform/mac/fast/body-propagation/background-image/010-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-image/010-xhtml-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-image/010-xhtml-expected.png: Added.
  • platform/mac/fast/body-propagation/background-image/010-xhtml-expected.txt: Added.
  • platform/mac/fast/body-propagation/overflow: Added.
  • platform/mac/fast/body-propagation/overflow/001-expected.checksum: Added.
  • platform/mac/fast/body-propagation/overflow/001-expected.png: Added.
  • platform/mac/fast/body-propagation/overflow/001-expected.txt: Added.
  • platform/mac/fast/body-propagation/overflow/001-xhtml-expected.checksum: Added.
  • platform/mac/fast/body-propagation/overflow/001-xhtml-expected.png: Added.
  • platform/mac/fast/body-propagation/overflow/001-xhtml-expected.txt: Added.
  • platform/mac/fast/body-propagation/overflow/002-expected.checksum: Added.
  • platform/mac/fast/body-propagation/overflow/002-expected.png: Added.
  • platform/mac/fast/body-propagation/overflow/002-expected.txt: Added.
  • platform/mac/fast/body-propagation/overflow/002-xhtml-expected.checksum: Added.
  • platform/mac/fast/body-propagation/overflow/002-xhtml-expected.png: Added.
  • platform/mac/fast/body-propagation/overflow/002-xhtml-expected.txt: Added.
  • platform/mac/fast/body-propagation/overflow/003-declarative-expected.checksum: Added.
  • platform/mac/fast/body-propagation/overflow/003-declarative-expected.png: Added.
  • platform/mac/fast/body-propagation/overflow/003-declarative-expected.txt: Added.
  • platform/mac/fast/body-propagation/overflow/003-expected.checksum: Added.
  • platform/mac/fast/body-propagation/overflow/003-expected.png: Added.
  • platform/mac/fast/body-propagation/overflow/003-expected.txt: Added.
  • platform/mac/fast/body-propagation/overflow/003-xhtml-expected.checksum: Added.
  • platform/mac/fast/body-propagation/overflow/003-xhtml-expected.png: Added.
  • platform/mac/fast/body-propagation/overflow/003-xhtml-expected.txt: Added.
  • platform/mac/fast/body-propagation/overflow/004-declarative-expected.checksum: Added.
  • platform/mac/fast/body-propagation/overflow/004-declarative-expected.png: Added.
  • platform/mac/fast/body-propagation/overflow/004-declarative-expected.txt: Added.
  • platform/mac/fast/body-propagation/overflow/004-expected.checksum: Added.
  • platform/mac/fast/body-propagation/overflow/004-expected.png: Added.
  • platform/mac/fast/body-propagation/overflow/004-expected.txt: Added.
  • platform/mac/fast/body-propagation/overflow/004-xhtml-expected.checksum: Added.
  • platform/mac/fast/body-propagation/overflow/004-xhtml-expected.png: Added.
  • platform/mac/fast/body-propagation/overflow/004-xhtml-expected.txt: Added.
  • platform/mac/fast/body-propagation/overflow/005-declarative-expected.checksum: Added.
  • platform/mac/fast/body-propagation/overflow/005-declarative-expected.png: Added.
  • platform/mac/fast/body-propagation/overflow/005-declarative-expected.txt: Added.
  • platform/mac/fast/body-propagation/overflow/005-expected.checksum: Added.
  • platform/mac/fast/body-propagation/overflow/005-expected.png: Added.
  • platform/mac/fast/body-propagation/overflow/005-expected.txt: Added.
  • platform/mac/fast/body-propagation/overflow/005-xhtml-expected.checksum: Added.
  • platform/mac/fast/body-propagation/overflow/005-xhtml-expected.png: Added.
  • platform/mac/fast/body-propagation/overflow/005-xhtml-expected.txt: Added.
  • platform/mac/fast/body-propagation/overflow/006-declarative-expected.checksum: Added.
  • platform/mac/fast/body-propagation/overflow/006-declarative-expected.png: Added.
  • platform/mac/fast/body-propagation/overflow/006-declarative-expected.txt: Added.
  • platform/mac/fast/body-propagation/overflow/006-expected.checksum: Added.
  • platform/mac/fast/body-propagation/overflow/006-expected.png: Added.
  • platform/mac/fast/body-propagation/overflow/006-expected.txt: Added.
  • platform/mac/fast/body-propagation/overflow/006-xhtml-expected.checksum: Added.
  • platform/mac/fast/body-propagation/overflow/006-xhtml-expected.png: Added.
  • platform/mac/fast/body-propagation/overflow/006-xhtml-expected.txt: Added.
  • platform/mac/fast/body-propagation/overflow/007-declarative-expected.checksum: Added.
  • platform/mac/fast/body-propagation/overflow/007-declarative-expected.png: Added.
  • platform/mac/fast/body-propagation/overflow/007-declarative-expected.txt: Added.
  • platform/mac/fast/body-propagation/overflow/007-expected.checksum: Added.
  • platform/mac/fast/body-propagation/overflow/007-expected.png: Added.
  • platform/mac/fast/body-propagation/overflow/007-expected.txt: Added.
  • platform/mac/fast/body-propagation/overflow/007-xhtml-expected.checksum: Added.
  • platform/mac/fast/body-propagation/overflow/007-xhtml-expected.png: Added.
  • platform/mac/fast/body-propagation/overflow/007-xhtml-expected.txt: Added.
12:55 PM Changeset in webkit [37590] by weinig@apple.com
  • 16 edits
    9 deletes in trunk

WebCore:

2008-10-14 Dimitri Glazkov <Dimitri Glazkov>

Reviewed and landed by Sam Weinig.

Due to change in spec (​http://dev.w3.org/2006/webapi/selectors-api/#namespace),
remove NSResolver code, leaving only checking for selectors that need
NS resolution and throwing a coresponding error.

  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSDocumentCustom.cpp:
  • bindings/js/JSDocumentFragmentCustom.cpp:
  • bindings/js/JSElementCustom.cpp:
  • bindings/js/JSNSResolver.cpp: Removed.
  • bindings/js/JSNSResolver.h: Removed.
  • dom/Document.idl:
  • dom/DocumentFragment.idl:
  • dom/Element.idl:
  • dom/NSResolver.h: Removed.
  • dom/NSResolver.idl: Removed.
  • dom/Node.h:
  • dom/Node.cpp: (WebCore::forEachTagSelector): (WebCore::SelectorNeedsNamespaceResolutionFunctor::operator()): (WebCore::selectorNeedsNamespaceResolution): (WebCore::Node::querySelector): (WebCore::Node::querySelectorAll):

LayoutTests:

2008-10-14 Dimitri Glazkov <Dimitri Glazkov>

Reviewed and landed by Sam Weinig.

Due to change in spec (​http://dev.w3.org/2006/webapi/selectors-api/#namespace),
remove no longer relevant NSResolver tests.

  • fast/dom/SelectorAPI/NSResolver-basic-expected.txt: Removed.
  • fast/dom/SelectorAPI/NSResolver-basic.xhtml: Removed.
  • fast/dom/SelectorAPI/NSResolver-exceptions-expected.txt: Removed.
  • fast/dom/SelectorAPI/NSResolver-exceptions.xhtml: Removed.
  • fast/dom/SelectorAPI/resources/NSResolver-exceptions.js: Removed.
12:19 PM Changeset in webkit [37589] by Darin Adler
  • 5 edits in trunk/WebCore

2008-10-14 Darin Adler <Darin Adler>

Reviewed by Sam Weinig (all but the FormDataListItem rename).

  • html/FormDataList.cpp: Removed appendFile since it's now inline. Also took incorrect old copyrights off of this file that are left over from when it was split.
  • html/FormDataList.h: Ditto. Renamed FormDataListItem to Item and made it a member of FormDataList. Changed it to hold a File object instead of a path. And made its data members private. Changed FormDataList::appendFile accordingly.
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData): Updated for above changes. Removed the code that special-cases HTMLInputElement, because now the FormDataListItem has everything we need. And if there are multiple files, we'll get multiple list items for them.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::appendFormData): Changed the code for <input type=file> to use File objects instead of path strings and also to append multiple files if the file list has them.
12:17 PM Changeset in webkit [37588] by timothy@apple.com
  • 2 edits in trunk/WebKitTools

Make prepare-ChangeLog populate the changed functions for JavaScript files.

​https://bugs.webkit.org/show_bug.cgi?id=21567

Reviewed by David Kilzer.

  • Scripts/prepare-ChangeLog: (get_function_line_ranges): Call get_function_line_ranges_for_javascript for files that end with ".js". (get_function_line_ranges_for_javascript): Find functions, anonymous functions and getters/setters.
11:43 AM Changeset in webkit [37587] by Darin Adler
  • 26 edits
    1 add in trunk/WebKitTools

2008-10-14 Alp Toker <​alp@nuanti.com>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=16299
Add a config.h file to DRT

Add a config.h to DumpRenderTree and reduce use of DumpRenderTree.h as
an ad-hoc config header.

  • DumpRenderTree/AccessibilityController.cpp:
  • DumpRenderTree/AccessibilityUIElement.cpp:
  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/DumpRenderTree.h:
  • DumpRenderTree/GCController.cpp:
  • DumpRenderTree/LayoutTestController.cpp:
  • DumpRenderTree/WorkQueue.cpp:
  • DumpRenderTree/config.h: Added.
  • DumpRenderTree/gtk/DumpRenderTree.cpp:
  • DumpRenderTree/gtk/GCControllerGtk.cpp:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  • DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
  • DumpRenderTree/win/AccessibilityControllerWin.cpp:
  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:
  • DumpRenderTree/win/DumpRenderTree.cpp:
  • DumpRenderTree/win/DumpRenderTreeWin.h:
  • DumpRenderTree/win/EditingDelegate.cpp:
  • DumpRenderTree/win/EventSender.cpp:
  • DumpRenderTree/win/FrameLoadDelegate.cpp:
  • DumpRenderTree/win/GCControllerWin.cpp:
  • DumpRenderTree/win/MD5.cpp:
  • DumpRenderTree/win/PixelDumpSupportWin.cpp:
  • DumpRenderTree/win/PolicyDelegate.cpp:
  • DumpRenderTree/win/ResourceLoadDelegate.cpp:
  • DumpRenderTree/win/WorkQueueItemWin.cpp:
  • GNUmakefile.am:
9:22 AM Changeset in webkit [37586] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=20256
Array.push and other standard methods disappear

  • kjs/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): (JSC::JSGlobalData::~JSGlobalData): Don't use static hash tables even on platforms that don't enable JSC_MULTIPLE_THREADS - these tables reference IdentifierTable, which is always per-GlobalData.
5:50 AM Changeset in webkit [37585] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2008-10-14 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon.

Fix QtWebKit scrollbar painting errors

1:46 AM Changeset in webkit [37584] by vestbo@webkit.org
  • 2 edits in trunk/WebKit/qt

2008-10-14 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon.

Clip painter to dirty rect before passing on to WebKit

This was previously done in ScrollViewQt, but after the
refactoring of ScrollView we need to do it in QWebFrame
instead, similar to Safari/Win.

1:43 AM Changeset in webkit [37583] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2008-10-14 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon.

Fix scrollbar arrows for horizontal scrollbars

1:38 AM Changeset in webkit [37582] by vestbo@webkit.org
  • 4 edits in trunk/WebCore

2008-10-14 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon.

Use style-painter to draw scrollbars in ScrollbarThemeQt

This has the benefit of setting up the painter properly without
antialiasing and saving and restoring the brush. It also ensures
that we use the style of the QWebView over the QApplication style
if possible.

1:21 AM Changeset in webkit [37581] by mjs@apple.com
  • 7 edits in trunk/JavaScriptCore

2008-10-14 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Cameron Zwarich.


  • always use CTI_ARGUMENTS and CTI_ARGUMENTS_FASTCALL


This is a small regression for GCC 4.0, but simplifies the code
for future improvements and lets us focus on GCC 4.2+ and MSVC.

  • VM/CTI.cpp:
  • VM/CTI.h:
  • VM/Machine.cpp: (JSC::Machine::cti_op_convert_this): (JSC::Machine::cti_op_end): (JSC::Machine::cti_op_add): (JSC::Machine::cti_op_pre_inc): (JSC::Machine::cti_timeout_check): (JSC::Machine::cti_register_file_check): (JSC::Machine::cti_op_loop_if_less): (JSC::Machine::cti_op_loop_if_lesseq): (JSC::Machine::cti_op_new_object): (JSC::Machine::cti_op_put_by_id): (JSC::Machine::cti_op_put_by_id_second): (JSC::Machine::cti_op_put_by_id_generic): (JSC::Machine::cti_op_put_by_id_fail): (JSC::Machine::cti_op_get_by_id): (JSC::Machine::cti_op_get_by_id_second): (JSC::Machine::cti_op_get_by_id_generic): (JSC::Machine::cti_op_get_by_id_fail): (JSC::Machine::cti_op_instanceof): (JSC::Machine::cti_op_del_by_id): (JSC::Machine::cti_op_mul): (JSC::Machine::cti_op_new_func): (JSC::Machine::cti_op_call_JSFunction): (JSC::Machine::cti_vm_compile): (JSC::Machine::cti_op_push_activation): (JSC::Machine::cti_op_call_NotJSFunction): (JSC::Machine::cti_op_create_arguments): (JSC::Machine::cti_op_tear_off_activation): (JSC::Machine::cti_op_tear_off_arguments): (JSC::Machine::cti_op_ret_profiler): (JSC::Machine::cti_op_ret_scopeChain): (JSC::Machine::cti_op_new_array): (JSC::Machine::cti_op_resolve): (JSC::Machine::cti_op_construct_JSConstruct): (JSC::Machine::cti_op_construct_NotJSConstruct): (JSC::Machine::cti_op_get_by_val): (JSC::Machine::cti_op_resolve_func): (JSC::Machine::cti_op_sub): (JSC::Machine::cti_op_put_by_val): (JSC::Machine::cti_op_put_by_val_array): (JSC::Machine::cti_op_lesseq): (JSC::Machine::cti_op_loop_if_true): (JSC::Machine::cti_op_negate): (JSC::Machine::cti_op_resolve_base): (JSC::Machine::cti_op_resolve_skip): (JSC::Machine::cti_op_resolve_global): (JSC::Machine::cti_op_div): (JSC::Machine::cti_op_pre_dec): (JSC::Machine::cti_op_jless): (JSC::Machine::cti_op_not): (JSC::Machine::cti_op_jtrue): (JSC::Machine::cti_op_post_inc): (JSC::Machine::cti_op_eq): (JSC::Machine::cti_op_lshift): (JSC::Machine::cti_op_bitand): (JSC::Machine::cti_op_rshift): (JSC::Machine::cti_op_bitnot): (JSC::Machine::cti_op_resolve_with_base): (JSC::Machine::cti_op_new_func_exp): (JSC::Machine::cti_op_mod): (JSC::Machine::cti_op_less): (JSC::Machine::cti_op_neq): (JSC::Machine::cti_op_post_dec): (JSC::Machine::cti_op_urshift): (JSC::Machine::cti_op_bitxor): (JSC::Machine::cti_op_new_regexp): (JSC::Machine::cti_op_bitor): (JSC::Machine::cti_op_call_eval): (JSC::Machine::cti_op_throw): (JSC::Machine::cti_op_get_pnames): (JSC::Machine::cti_op_next_pname): (JSC::Machine::cti_op_push_scope): (JSC::Machine::cti_op_pop_scope): (JSC::Machine::cti_op_typeof): (JSC::Machine::cti_op_is_undefined): (JSC::Machine::cti_op_is_boolean): (JSC::Machine::cti_op_is_number): (JSC::Machine::cti_op_is_string): (JSC::Machine::cti_op_is_object): (JSC::Machine::cti_op_is_function): (JSC::Machine::cti_op_stricteq): (JSC::Machine::cti_op_nstricteq): (JSC::Machine::cti_op_to_jsnumber): (JSC::Machine::cti_op_in): (JSC::Machine::cti_op_push_new_scope): (JSC::Machine::cti_op_jmp_scopes): (JSC::Machine::cti_op_put_by_index): (JSC::Machine::cti_op_switch_imm): (JSC::Machine::cti_op_switch_char): (JSC::Machine::cti_op_switch_string): (JSC::Machine::cti_op_del_by_val): (JSC::Machine::cti_op_put_getter): (JSC::Machine::cti_op_put_setter): (JSC::Machine::cti_op_new_error): (JSC::Machine::cti_op_debug): (JSC::Machine::cti_vm_throw):
  • VM/Machine.h:
  • masm/X86Assembler.h: (JSC::X86Assembler::emitRestoreArgumentReference): (JSC::X86Assembler::emitRestoreArgumentReferenceForTrampoline):
  • wtf/Platform.h:
12:49 AM Changeset in webkit [37580] by jhoneycutt@apple.com
  • 3 edits in trunk/WebKit/win

2008-10-14 Jon Honeycutt <​jhoneycutt@apple.com>

Export currentThread.

Rubber-stamped by Dan Bernstein.

  • WebKit.vcproj/WebKit.def:
  • WebKit.vcproj/WebKit_debug.def:
Note: See TracTimeline for information about the timeline view.