Timeline
Oct 21, 2008:
- 11:49 PM Changeset in webkit [37772] by
-
- 2 edits in trunk/JavaScriptCore
Attempt to make the win2k3 bot be more useful for testing
RS=Maciej Stachowiak.
Force FastMalloc to make all allocated pages executable in
a vague hope this will allow the Win2k3 bot to be able to
run tests.
Filed Bug 21783: Need more granular control over allocation of executable memory
to cover a more granular version of this patch.
- 11:07 PM Changeset in webkit [37771] by
-
- 7 edits2 adds in trunk
Reviewed by Darin Adler.
Test: fast/events/message-channel-gc-3.html
https://bugs.webkit.org/show_bug.cgi?id=21769
MessagePort should be GC protected if there are messages to be delivered
- dom/MessagePort.h: Removed pending activity count. Now we track if a close event is pending, and check if the queue is non-empty. (WebCore::MessagePort::workerContext): Added a stub implementation for a cross-heap GC bug fix (below).
- dom/MessagePort.cpp: (WebCore::CloseMessagePortTimer::fired): (WebCore::MessagePort::MessagePort): (WebCore::MessagePort::queueCloseEvent): (WebCore::MessagePort::dispatchCloseEvent): (WebCore::MessagePort::hasPendingActivity): Track message and close event activity separately.
- bindings/js/JSDOMBinding.cpp: (WebCore::markCrossHeapDependentObjectsForDocument): Fixed a bug in cross-heap GC that was causing same-heap ports to never be deleted.
- wtf/MessageQueue.h: (WTF::::isEmpty): Added. Also added a warning for methods that return a snapshot of queue state, thus likely to cause race conditions.
- 8:10 PM Changeset in webkit [37770] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam Weinig.
- remove unreachable code
- platform/text/BidiResolver.h: (WebCore::::embed):
- 5:41 PM Changeset in webkit [37769] by
-
- 2 edits in trunk/WebKitTools
2008-10-21 Steve Falkenburg <sfalken@apple.com>
Exclude strings marked with UNLOCALIZED_STRING or UNLOCALIZED_LPCTSTR.
- Scripts/extract-localizable-strings:
- 5:22 PM Changeset in webkit [37768] by
-
- 2 edits in trunk/WebCore
2008-10-21 Beth Dakin <Beth Dakin>
Reviewed by Darin Adler.
Fix for https://bugs.webkit.org/show_bug.cgi?id=20352
REGRESSION(r31030-31055): Choosing "Print window" from frame set
prints blank page
and corresponding: <rdar://problem/6142398>
viewHeight() and viewWidth() only return valuable information if we
are not printing. Everywhere else in the code, we make sure we are
not printing before we call these functions. Adding a check for
printing here fixes this bug, and framesets print again.
- rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::layout):
- 5:16 PM Changeset in webkit [37767] by
-
- 3 edits in branches/Safari-3-2-branch/WebKit/win
Merge r37489.
- 5:16 PM Changeset in webkit [37766] by
-
- 2 edits in branches/Safari-3-2-branch/WebCore
Merge r37704.
- 5:16 PM Changeset in webkit [37765] by
-
- 8 edits in branches/Safari-3-2-branch
Merge r31577.
- 3:33 PM Changeset in webkit [37764] by
-
- 4 edits in trunk/WebKit/qt
2008-06-03 Siraj Razick <siraj.razick@collabora.co.uk>
Reviewed by Simon Hausmann.
Expose boundingBox value in QWebHitTestResult
Add API function QRect QWebHitResult::boundingBox() const
API docs by Ariya.
- 2:29 PM Changeset in webkit [37763] by
-
- 2 edits in trunk/JavaScriptCore
2008-10-21 Darin Adler <Darin Adler>
Reviewed by Maciej Stachowiak.
- convert post-increment to pre-increment in a couple more places for speed
Speeds up V8 benchmarks a little on most computers. (But, strangely, slows
them down a little on my computer.)
- kjs/nodes.cpp: (JSC::statementListEmitCode): Removed default argument, since we always want to specify this explicitly. (JSC::ForNode::emitCode): Tolerate ignoredResult() as the dst -- means the same thing as 0. (JSC::ReturnNode::emitCode): Ditto. (JSC::ThrowNode::emitCode): Ditto. (JSC::FunctionBodyNode::emitCode): Pass ignoredResult() so that we know we don't have to compute the result of function statements.
- 2:09 PM Changeset in webkit [37762] by
-
- 2 edits in trunk/JavaScriptCore
2008-10-21 Peter Kasting <pkasting@google.com>
Reviewed by Maciej Stachowiak.
Fix an include of a non-public header to use "" instead of <>.
- API/JSProfilerPrivate.cpp:
- 10:27 AM Changeset in webkit [37761] by
-
- 2 edits in trunk/WebKit
2008-10-21 Yael <yael.aharon@nokia.com>
Reviewed by Simon Hausmann.
emit repaintRequested unconditionally when repaint is requested.
- 5:57 AM Changeset in webkit [37760] by
-
- 2 edits in trunk/WebCore
2008-10-21 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Simon.
Pixmap in canvas tag was not getting initialized.
Oct 20, 2008:
- 11:08 PM Changeset in webkit [37759] by
-
- 10 edits in trunk
2008-10-20 Sam Weinig <sam@webkit.org>
Reviewed by Cameron Zwarich.
Fix for https://bugs.webkit.org/show_bug.cgi?id=21766
REGRESSION: 12 JSC tests fail
The JSGlobalObject was mutating the shared nullProtoStructureID when
used in jsc. Instead of using nullProtoStructureID, use a new StructureID.
- API/JSCallbackObject.h:
- API/JSCallbackObjectFunctions.h: (JSC::::JSCallbackObject):
- API/JSContextRef.cpp: (JSGlobalContextCreateInGroup):
- kjs/JSGlobalObject.h: (JSC::JSGlobalObject::JSGlobalObject):
- kjs/Shell.cpp: (GlobalObject::GlobalObject): (jscmain):
JavaScriptGlue:
2008-10-20 Sam Weinig <sam@webkit.org>
Reviewed by Cameron Zwarich.
Fix for https://bugs.webkit.org/show_bug.cgi?id=21766
REGRESSION: 12 JSC tests fail
The JSGlobalObject constructor no longer takes a JSGlobalData
as an argument.
- JSRun.cpp: (JSRun::JSRun):
- JSRun.h: (JSGlueGlobalObject::JSGlueGlobalObject):
- JSUtils.cpp: (getThreadGlobalExecState):
- 11:01 PM Changeset in webkit [37758] by
-
- 3 edits in trunk/WebCore
2008-10-20 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein
Add a comment explaining layoutDelta(), and an assertion
that checks that delta changes were correctly paired during layout.
- rendering/RenderView.cpp: (WebCore::RenderView::layout):
- rendering/RenderView.h:
- 9:50 PM Changeset in webkit [37757] by
-
- 2 edits in trunk/WebCore
Make auto-complete only suggest properties that are valid syntax
when using dot-notation. Also when completing numeric properties,
the quotes are omitted inside the brackets.
https://bugs.webkit.org/show_bug.cgi?id=21760
https://bugs.webkit.org/show_bug.cgi?id=21761
Reviewed by Oliver Hunt.
- inspector/front-end/Console.js: (WebInspector.Console.prototype.completions): Skip properties that are not valid identifies when using dot-notation. And omit the quotes when completing numbers in bracket-notation.
- 9:50 PM Changeset in webkit [37756] by
-
- 3 edits in trunk/WebCore
Fixes the Profiles panel in the Web Inspector, which was broken by
the JSValue base-class changes. Also renames some functions and
variables in JavaScriptProfileNode.cpp that where title case.
Reviewed by Oliver Hunt.
- inspector/JavaScriptProfile.cpp: (WebCore::toJS): Use a JSObject pointer instead of JSValuePtr so the returned JSValuePtr will be treated as an object and not a value.
- inspector/JavaScriptProfileNode.cpp: (WebCore::toJS): Ditto.
- 7:45 PM Changeset in webkit [37755] by
-
- 2 edits in trunk/JavaScriptCore
2008-10-20 Cameron Zwarich <zwarich@apple.com>
Reviewed by Maciej Stachowiak.
Remove an untaken branch in CodeGenerator::emitJumpIfFalse(). This
function is never called with a backwards target LabelID, and there is
even an assertion to this effect at the top of the function body.
- VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitJumpIfFalse):
- 7:14 PM Changeset in webkit [37754] by
-
- 19 edits in trunk
WebCore:
2008-10-20 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Remove FrameLoaderClient::detachedFromParent4. It is no longer used by any port.
- loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::detachedFromParent4):.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::detachFromParent):
- loader/FrameLoaderClient.h:
WebKit/gtk:
2008-10-20 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Remove FrameLoaderClient::detachedFromParent4. It is no longer used by any port.
- WebCoreSupport/FrameLoaderClientGtk.cpp:
- WebCoreSupport/FrameLoaderClientGtk.h:
WebKit/mac:
2008-10-20 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Remove FrameLoaderClient::detachedFromParent4. It is no longer used by any port.
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm:
WebKit/qt:
2008-10-20 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Remove FrameLoaderClient::detachedFromParent4. It is no longer used by any port.
- WebCoreSupport/FrameLoaderClientQt.cpp:
- WebCoreSupport/FrameLoaderClientQt.h:
WebKit/win:
2008-10-20 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Remove FrameLoaderClient::detachedFromParent4. It is no longer used by any port.
- WebFrame.cpp:
- WebFrame.h:
WebKit/wx:
2008-10-20 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Remove FrameLoaderClient::detachedFromParent4. It is no longer used by any port.
- WebKitSupport/FrameLoaderClientWx.cpp:
- WebKitSupport/FrameLoaderClientWx.h:
- 6:22 PM Changeset in webkit [37753] by
-
- 2 edits in trunk/WebCore
2008-10-20 Antti Koivisto <Antti Koivisto>
Reviewed by Adele Peterson.
Fix https://bugs.webkit.org/show_bug.cgi?id=21763
REGRESSION (r36108-r36113): Can't load picture content on wired.com galleries
<rdar://problem/6285025
If we get 304 response we need to explicitly check if that completes the frame load.
No test case, simulating the condition is pretty difficult.
- loader/loader.cpp: (WebCore::Loader::Host::didReceiveResponse):
- 6:05 PM Changeset in webkit [37752] by
-
- 2 edits in trunk/WebCore
2008-10-20 Anders Carlsson <andersca@apple.com>
Reviewed by Mark Rowe.
Work around <rdar://problem/6301728>.
Don't assert that loads are deferred when we're using CFNetwork on Mac or Windows.
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::didReceiveResponse): (WebCore::MainResourceLoader::didReceiveData): (WebCore::MainResourceLoader::didFinishLoading): (WebCore::MainResourceLoader::didFail):
- 5:20 PM Changeset in webkit [37751] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
2008-10-20 Cameron Zwarich <zwarich@apple.com>
Not reviewed.
Update the ChangeLog for previous commit to contain meaningful
information.
- ChangeLog
- 5:10 PM Changeset in webkit [37750] by
-
- 2 edits in trunk/JavaScriptCore
2008-10-20 Cameron Zwarich <zwarich@apple.com>
Rubber-stamped by Sam Weinig.
- VM/Machine.cpp: (JSC::Machine::privateExecute):
- 3:47 PM Changeset in webkit [37749] by
-
- 2 edits in trunk/WebCore
2008-10-20 Beth Dakin <Beth Dakin>
Reviewed by Adele Peterson.
Speculative fix for <rdar://problem/6242585> CrashTracer: [USER] 19
crashes in Safari at com.apple.WebCore
WebCore::ScrollView::visibleContentRect const + 153
d->m_view can be null and is null-checked at other points in the
code. The logs indicate that this crash occurs when closing a
window containing a PDF, so in case where we crash, the PDF's view
is probably already null. So the fix is to simply add a null-check.
- page/Frame.cpp: (WebCore::Frame::selectionRect):
- 2:31 PM Changeset in webkit [37748] by
-
- 2 edits in trunk/WebCore
2008-10-20 Adele Peterson <adele@apple.com>
Reviewed by Darin Adler.
- html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData): Removed stray increment that would screw up any form with multiple files in it.
- 2:27 PM Changeset in webkit [37747] by
-
- 24 edits in trunk/JavaScriptCore
2008-10-16 Sam Weinig <sam@webkit.org>
Reviewed by Cameron Zwarich.
Fix for https://bugs.webkit.org/show_bug.cgi?id=21683
Don't create intermediate StructureIDs for builtin objects
Second stage in reduce number of StructureIDs created when initializing the
JSGlobalObject.
- Use putDirectWithoutTransition for the remaining singleton objects to reduce the number of StructureIDs create for about:blank from 132 to 73.
- kjs/ArrayConstructor.cpp: (JSC::ArrayConstructor::ArrayConstructor):
- kjs/BooleanConstructor.cpp: (JSC::BooleanConstructor::BooleanConstructor):
- kjs/BooleanPrototype.cpp: (JSC::BooleanPrototype::BooleanPrototype):
- kjs/DateConstructor.cpp: (JSC::DateConstructor::DateConstructor):
- kjs/ErrorConstructor.cpp: (JSC::ErrorConstructor::ErrorConstructor):
- kjs/ErrorPrototype.cpp: (JSC::ErrorPrototype::ErrorPrototype):
- kjs/FunctionConstructor.cpp: (JSC::FunctionConstructor::FunctionConstructor):
- kjs/FunctionPrototype.cpp: (JSC::FunctionPrototype::FunctionPrototype): (JSC::FunctionPrototype::addFunctionProperties):
- kjs/FunctionPrototype.h: (JSC::FunctionPrototype::createStructureID):
- kjs/InternalFunction.cpp:
- kjs/InternalFunction.h: (JSC::InternalFunction::InternalFunction):
- kjs/JSGlobalObject.cpp: (JSC::JSGlobalObject::reset):
- kjs/JSObject.h:
- kjs/MathObject.cpp: (JSC::MathObject::MathObject):
- kjs/NumberConstructor.cpp: (JSC::NumberConstructor::NumberConstructor):
- kjs/NumberPrototype.cpp: (JSC::NumberPrototype::NumberPrototype):
- kjs/ObjectConstructor.cpp: (JSC::ObjectConstructor::ObjectConstructor):
- kjs/RegExpConstructor.cpp: (JSC::RegExpConstructor::RegExpConstructor):
- kjs/RegExpPrototype.cpp: (JSC::RegExpPrototype::RegExpPrototype):
- kjs/StringConstructor.cpp: (JSC::StringConstructor::StringConstructor):
- kjs/StringPrototype.cpp: (JSC::StringPrototype::StringPrototype):
- kjs/StructureID.cpp: (JSC::StructureID::dumpStatistics):
- kjs/StructureID.h: (JSC::StructureID::setPrototypeWithoutTransition):
- 1:42 PM Changeset in webkit [37746] by
-
- 12 edits2 copies in trunk/WebCore
2008-10-20 Sam Weinig <sam@webkit.org>
Rubber-stamped by David Hyatt.
Split LengthBox and LengthSize into their own files.
- GNUmakefile.am:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/Length.h: (WebCore::Length::blend):
- platform/LengthBox.h: Copied from platform/Length.h. (WebCore::LengthBox::LengthBox): (WebCore::LengthBox::nonZero):
- platform/LengthSize.h: Copied from platform/Length.h. (WebCore::LengthSize::LengthSize): (WebCore::LengthSize::setWidth): (WebCore::LengthSize::setHeight): (WebCore::LengthSize::height):
- platform/Theme.h:
- rendering/style/FillLayer.h:
- rendering/style/NinePieceImage.h: (WebCore::NinePieceImage::NinePieceImage):
- rendering/style/RenderStyle.h:
- rendering/style/StyleDashboardRegion.h:
- rendering/style/StyleSurroundData.h:
- rendering/style/StyleVisualData.h:
- 1:15 PM Changeset in webkit [37745] by
-
- 2 edits in trunk/WebCore
- Mac build fix
- WebCore.xcodeproj/project.pbxproj:
- 12:30 PM Changeset in webkit [37744] by
-
- 4 edits in trunk
2008-10-20 Alp Toker <alp@nuanti.com>
Fix autotools dist build target by listing recently added header
files only. Not reviewed.
- 12:27 PM Changeset in webkit [37743] by
-
- 7 edits1 add in trunk/WebCore
2008-10-20 David Hyatt <hyatt@apple.com>
Clean up some USE(NEW_THEME) ifdefs (I botched one of them and have broken non-Mac platforms). Also
refactor some of the code that I put in ThemeMac to be cross-platform, since it was in RenderTheme.cpp
originally.
ifdef some methods in RenderTheme.cpp also that are no longer needed with the new Theme.
Reviewed by Adam Roben
- WebCore.xcodeproj/project.pbxproj:
- platform/Theme.cpp: Added. (WebCore::Theme::controlSupportsBorder): (WebCore::Theme::controlSupportsPadding):
- platform/Theme.h:
- platform/mac/ThemeMac.h:
- platform/mac/ThemeMac.mm:
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle):
- rendering/RenderTheme.h:
- 12:18 PM Changeset in webkit [37742] by
-
- 7 edits in trunk/WebCore
2008-10-20 David Hyatt <hyatt@apple.com>
Rename LengthBox's members to have m_ in front of them.
Reviewed by Sam Weinig
- css/CSSComputedStyleDeclaration.cpp: (WebCore::valueForNinePieceImage): (WebCore::getPositionOffsetValue): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::mapNinePieceImage):
- platform/Length.h: (WebCore::LengthBox::LengthBox): (WebCore::LengthBox::left): (WebCore::LengthBox::right): (WebCore::LengthBox::top): (WebCore::LengthBox::bottom): (WebCore::LengthBox::operator==): (WebCore::LengthBox::nonZero):
- rendering/RenderObject.cpp: (WebCore::RenderObject::paintNinePieceImage): (WebCore::RenderObject::addDashboardRegions):
- rendering/style/RenderStyle.cpp: (WebCore::positionedObjectMoved): (WebCore::RenderStyle::setClip): (WebCore::RenderStyle::noneDashboardRegions):
- rendering/style/RenderStyle.h: (WebCore::InheritedFlags::left): (WebCore::InheritedFlags::right): (WebCore::InheritedFlags::top): (WebCore::InheritedFlags::bottom): (WebCore::InheritedFlags::clipLeft): (WebCore::InheritedFlags::clipRight): (WebCore::InheritedFlags::clipTop): (WebCore::InheritedFlags::clipBottom): (WebCore::InheritedFlags::marginTop): (WebCore::InheritedFlags::marginBottom): (WebCore::InheritedFlags::marginLeft): (WebCore::InheritedFlags::marginRight): (WebCore::InheritedFlags::paddingTop): (WebCore::InheritedFlags::paddingBottom): (WebCore::InheritedFlags::paddingLeft): (WebCore::InheritedFlags::paddingRight): (WebCore::InheritedFlags::setLeft): (WebCore::InheritedFlags::setRight): (WebCore::InheritedFlags::setTop): (WebCore::InheritedFlags::setBottom): (WebCore::InheritedFlags::setDashboardRegion): (WebCore::InheritedFlags::setClipLeft): (WebCore::InheritedFlags::setClipRight): (WebCore::InheritedFlags::setClipTop): (WebCore::InheritedFlags::setClipBottom): (WebCore::InheritedFlags::setMarginTop): (WebCore::InheritedFlags::setMarginBottom): (WebCore::InheritedFlags::setMarginLeft): (WebCore::InheritedFlags::setMarginRight): (WebCore::InheritedFlags::setPaddingTop): (WebCore::InheritedFlags::setPaddingBottom): (WebCore::InheritedFlags::setPaddingLeft): (WebCore::InheritedFlags::setPaddingRight):
- 12:03 PM Changeset in webkit [37741] by
-
- 3 edits in trunk/WebCore
Make the Resource panel perform graph updates atomically, so when resources
are added the graph and summary graph update at the same time.
Reviewed by Kevin McCullough.
- inspector/front-end/Resource.js: (WebInspector.Resource.prototype.get startTime): Return -1 if the _startTime property is undefined, null or 0. This allows callers to check for -1 and not the other values when there is no startTime yet. (WebInspector.Resource.prototype.get responseReceivedTime): Ditto. (WebInspector.Resource.prototype.get endTime): Ditto. (WebInspector.Resource.prototype.get duration): Remove an extra empty line. (WebInspector.Resource.prototype.get latency): Ditto. (WebInspector.Resource.prototype.get contentLength): Return 0 if the _duration property is undefined or null. This allows callers to always assume a number. (WebInspector.Resource.prototype.get expectedContentLength): Ditto. (WebInspector.Resource.prototype.get errors): Simplify the case where there is no _errors property yet. (WebInspector.Resource.prototype.set errors): Remove the check if the new value if the same as the previous value, since there is no work to guard. (WebInspector.Resource.prototype.get warnings): Simplify the case where there is no _warnings property yet. (WebInspector.Resource.prototype.set warnings): Remove the check if the new value if the same as the previous value, since there is no work to guard. (WebInspector.Resource.CompareByResponseReceivedTime): Add cases for when the responseReceivedTime is -1. (WebInspector.Resource.CompareByEndTime): Add cases for when the endTime is -1.
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.get searchableViews): If a resource does not have a _resourcesTreeElement yet, exclude it from the searchable views. (WebInspector.ResourcesPanel.prototype.set calculator): Set _staleResource to _resources and call refresh to refresh the entire graph. (WebInspector.ResourcesPanel.prototype.set needsRefresh): Set a timeout if the panel is visible that calls refresh. (WebInspector.ResourcesPanel.prototype.refresh): Create the resource tree element and graph for a resource if it hasn't been created yet. If the boundaries changed during the first stale resource pass, do a full pass of all resources when updating the graphs. (WebInspector.ResourcesPanel.prototype.reset): Remove the legend items. (WebInspector.ResourcesPanel.prototype.addResource): Don't create the tree element and graph, these are now created during the first refresh. (WebInspector.ResourcesPanel.prototype.removeResource): Null check _resourcesTreeElement. (WebInspector.ResourcesPanel.prototype.addMessageToResource): Ditto. (WebInspector.ResourcesPanel.prototype.clearMessages): Ditto. (WebInspector.ResourcesPanel.prototype.refreshResource): Remove most of the work, just add the resource to the _staleResources and set needsRefresh. (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded): Null check _resourcesTreeElement. (WebInspector.ResourcesPanel.prototype._sortResourcesIfNeeded): Remove code to clear the timeout used by the deleted _sortResourcesSoonIfNeeded. Remove call to removeChild since the insertBefore call will do it if needed. (WebInspector.ResourcesPanel.prototype._updateGraphDividersIfNeeded): Remove code to clear the timeout used by the deleted _updateGraphDividersSoonIfNeeded. (WebInspector.ResourcesPanel.prototype._updateSummaryGraph): Remove code to clear the timeout used by the deleted _updateSummaryGraphSoon. No need to remove the totalLegendLabel, since all the legend items are removed in one pass right before. (WebInspector.ResourcesPanel.prototype._changeSortingFunction): Set the sortingFunction before the calculator so the correct sortingFunction is there when a refresh happens. (WebInspector.ResourceTimeCalculator.prototype.computeBarGraphPercentages): Set start to 0 when the startTime is -1, since that looks best visually. Also set middle and end to the start and middle (respectfully) when startAtZero. This looks best visually. (WebInspector.ResourceGraph): Start the graph as hidden until the first refresh. (WebInspector.ResourceGraph.prototype.refresh): Remove the hidden class.
- 11:45 AM Changeset in webkit [37740] by
-
- 3 edits in trunk/WebCore
2008-10-20 David Hyatt <hyatt@apple.com>
Make sure that the haveMetadata flag is set to true for generated images from image buffers, so that
no attempt is made to re-cache the frame from a non-existent image source.
Reviewed by Sam Weinig
- platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::BitmapImage):
- platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::BitmapImage):
- 11:23 AM Changeset in webkit [37739] by
-
- 2 edits in trunk/WebCore
Reviewed by John Sullivan.
- make hasARenderedDescendant() have internal linkage
- editing/CompositeEditCommand.cpp: (WebCore::hasARenderedDescendant):
- 11:04 AM Changeset in webkit [37738] by
-
- 2 edits in trunk
2008-10-20 Alp Toker <alp@nuanti.com>
Partial GTK+/Win32 build fix. Lowercase library name to enable linking
when cross-compiling Windows binaries from Linux: -lWs2_32 -> -lws2_32
- configure.ac:
- 10:57 AM Changeset in webkit [37737] by
-
- 3 edits2 adds in trunk
Bug 21721: 1 crash in Safari at com.apple.WebCore • WebCore::RenderTableSection::numColumns const + 12
- 10:42 AM Changeset in webkit [37736] by
-
- 2 edits in trunk/JavaScriptCore
2008-10-20 Geoffrey Garen <ggaren@apple.com>
Reviewed by Anders Carlsson.
- VM/Machine.cpp: (JSC::Machine::tryCacheGetByID): Removed a redundant and sometimes incorrect cast, which started ASSERTing after Darin's last checkin.
- 10:40 AM Changeset in webkit [37735] by
-
- 2 edits in trunk/WebCore
2008-10-20 David Hyatt <hyatt@apple.com>
Avoid some stderr spew from CG by checking if we have a decoder yet in ImageSourceCG.
Reviewed by Darin Adler
- platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::repetitionCount): (WebCore::ImageSource::frameDurationAtIndex):
- 10:28 AM Changeset in webkit [37734] by
-
- 2 edits in trunk/JavaScriptCore
2008-10-20 Geoffrey Garen <ggaren@apple.com>
Not reviewed.
Re-enable CTI, which I accidentally disabled while checking in fixes
to bytecode.
- wtf/Platform.h:
- 10:10 AM Changeset in webkit [37733] by
-
- 2 edits in trunk/JavaScriptCore
2008-10-20 Alp Toker <alp@nuanti.com>
Rubber-stamped by Mark Rowe.
Typo fix in function name: mimimum -> minimum.
- kjs/DateMath.cpp: (JSC::minimumYearForDST): (JSC::equivalentYearForDST):
- 10:06 AM Changeset in webkit [37732] by
-
- 9 edits in trunk
2008-10-20 Alp Toker <alp@nuanti.com>
Reviewed by Mark Rowe.
Use pthread instead of GThread where possible in the GTK+ port. This
fixes issues with global initialisation, particularly on GTK+/Win32
where a late g_thread_init() will cause hangs.
Fix the pthread conditionals in the FTP code to correctly define
threadsafe *_r functions on Windows. Partly fixes the GTK+/Win32
build.
- 9:50 AM Changeset in webkit [37731] by
-
- 15 edits in trunk/WebCore
2008-10-20 David Hyatt <hyatt@apple.com>
Convert checkboxes and radio buttons on OS X over to the new Theme API.
Reviewed by Adam Roben
- css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::mapFillSize):
- platform/Length.h: (WebCore::LengthSize::LengthSize): (WebCore::LengthSize::operator==): (WebCore::LengthSize::width): (WebCore::LengthSize::height): (WebCore::LengthSize::setWidth): (WebCore::LengthSize::setHeight):
- platform/Theme.h: (WebCore::Theme::controlSize): (WebCore::Theme::controlSupportsBorder): (WebCore::Theme::controlSupportsPadding): (WebCore::Theme::paint): (WebCore::Theme::inflateControlPaintRect):
- platform/ThemeTypes.h: (WebCore::):
- platform/mac/ThemeMac.h:
- platform/mac/ThemeMac.mm: (WebCore::): (WebCore::controlSizeForFont): (WebCore::sizeFromFont): (WebCore::setControlSize): (WebCore::updateStates): (WebCore::inflateRect): (WebCore::checkboxSizes): (WebCore::checkboxMargins): (WebCore::checkboxSize): (WebCore::checkbox): (WebCore::paintCheckbox): (WebCore::radioSizes): (WebCore::radioMargins): (WebCore::radioSize): (WebCore::radio): (WebCore::paintRadio): (WebCore::ThemeMac::baselinePositionAdjustment): (WebCore::ThemeMac::controlSize): (WebCore::ThemeMac::controlSupportsBorder): (WebCore::ThemeMac::controlSupportsPadding): (WebCore::ThemeMac::inflateControlPaintRect): (WebCore::ThemeMac::paint):
- rendering/RenderBox.cpp: (WebCore::RenderBox::calculateBackgroundSize):
- rendering/RenderObject.cpp: (WebCore::mustRepaintFillLayers):
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): (WebCore::RenderTheme::paint): (WebCore::RenderTheme::baselinePosition): (WebCore::RenderTheme::adjustRepaintRect): (WebCore::RenderTheme::controlStatesForRenderer): (WebCore::RenderTheme::isFocused):
- rendering/RenderTheme.h:
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustRepaintRect):
- rendering/style/FillLayer.cpp: (WebCore::FillLayer::operator==):
- 9:48 AM Changeset in webkit [37730] by
-
- 20 edits2 adds in trunk
2008-10-20 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
Fixed https://bugs.webkit.org/show_bug.cgi?id=21735
Emit profiling instrumentation only if the Web Inspector's profiling
feature is enabled
22.2% speedup on empty function call benchmark.
2.9% speedup on v8 benchmark.
0.7% speedup on SunSpider.
Lesser but similar speedups in bytecode.
- VM/CTI.cpp: (JSC::CTI::compileOpCall): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases): Nixed JITed profiler hooks. Profiler hooks now have their own opcodes. Added support for compiling profiler hook opcodes.
(JSC::CodeBlock::dump): Dump support for the new profiling opcodes.
- VM/CodeGenerator.h:
- VM/CodeGenerator.cpp: (JSC::CodeGenerator::CodeGenerator): (JSC::CodeGenerator::emitCall): (JSC::CodeGenerator::emitConstruct): Conditionally emit profiling hooks around call and construct, at the call site. (It's easier to get things right this way, if you have profiled code calling non-profiled code. Also, you get a slightly more accurate profile, since you charge the full cost of the call / construct operation to the callee.)
Also, fixed a bug where construct would fetch the ".prototype" property
from the constructor before evaluating the arguments to the constructor,
incorrectly allowing an "invalid constructor" exception to short-circuit
argument evaluation. I encountered this bug when trying to make
constructor exceptions work with profiling.
- VM/Machine.cpp: (JSC::Machine::callEval): Removed obsolete profiler hooks.
(JSC::Machine::throwException): Added a check for an exception thrown
within a call instruction. We didn't need this before because the call
instruction would check for a valid call before involing the profiler.
(JSC::Machine::execute): Added a didExecute hook at the end of top-level
function invocation, since op_ret no longer does this for us.
(JSC::Machine::privateExecute): Removed obsolete profiler hooks. Added
profiler opcodes. Changed some ++vPC to vPC[x] notation, since the
latter is better for performance, and it makes reasoning about the
current opcode in exception handling much simpler.
(JSC::Machine::cti_op_call_NotJSFunction): Removed obsolete profiler
hooks.
(JSC::Machine::cti_op_create_arguments_no_params): Added missing
CTI_STACK_HACK that I noticed when adding CTI_STACK_HACK to the new
profiler opcode functions.
(JSC::Machine::cti_op_profile_will_call):
(JSC::Machine::cti_op_profile_did_call): The new profiler opcode
functions.
(JSC::Machine::cti_op_construct_NotJSConstruct): Removed obsolete profiler
hooks.
- VM/Machine.h: (JSC::Machine::isCallOpcode): Helper for exception handling.
- VM/Opcode.h: Declare new opcodes.
- kjs/JSGlobalObject.h: (JSC::JSGlobalObject::supportsProfiling): Added virtual interface that allows WebCore to specify whether the target global object has the Web Inspector's profiling feature enabled.
- profiler/Profiler.cpp: (JSC::Profiler::willExecute): (JSC::Profiler::didExecute): (JSC::Profiler::createCallIdentifier):
- profiler/Profiler.h: Added support for invoking the profiler with an arbitrary JSValue*, and not a known object. We didn't need this before because the call instruction would check for a valid call before involing the profiler.
WebCore:
2008-10-18 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
Fixed https://bugs.webkit.org/show_bug.cgi?id=21735
Emit profiling instrumentation only if the Web Inspector's profiling
feature is enabled
- bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::supportsProfiling):
- bindings/js/JSDOMWindowBase.h: Implemented the interface for specifying whether a target global object has the Web Inspector's profiling feature enabled.
- inspector/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::recompileAllJSFunctionsSoon): (WebCore::JavaScriptDebugServer::didAddListener): (WebCore::JavaScriptDebugServer::didRemoveListener):
- inspector/JavaScriptDebugServer.h: Exported an API for recompiling, used by the Settings object.
- page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setDeveloperExtrasEnabled):
- page/Settings.h: Recompile when the developer menu is enabled/disabled for the first time, to add/remove profiling hooks. In the future, with better Web Inspector UI, we can do this on a page-by-page basis, instead of a global basis.
LayoutTests:
2008-10-18 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
Test for bugs fixed while working on https://bugs.webkit.org/show_bug.cgi?id=21735
Emit profiling instrumentation only if the Web Inspector's profiling
feature is enabled
- fast/js/exception-thrown-from-new-expected.txt: Added.
- fast/js/exception-thrown-from-new.html: Added.
- 9:42 AM Changeset in webkit [37729] by
-
- 2 edits in trunk/LayoutTests
Add Worker to the results - although it is just a stub right now, it is present in the list
of window properties.
- fast/dom/Window/window-properties-expected.txt:
- 9:22 AM Changeset in webkit [37728] by
-
- 5 edits in trunk/JavaScriptCore
2008-10-20 Darin Adler <Darin Adler>
Reviewed by Geoff Garen.
- get CTI working on Windows again
- VM/CTI.cpp: (JSC::CTI::emitCTICall): Add an overload for functions that return JSObject*.
- VM/CTI.h: Use JSValue* and JSObject* as return types for cti_op functions. Apparently, MSVC doesn't handle returning the JSValuePtr struct in a register. We'll have to look into this more.
- VM/Machine.cpp: (JSC::Machine::cti_op_convert_this): (JSC::Machine::cti_op_add): (JSC::Machine::cti_op_pre_inc): (JSC::Machine::cti_op_new_object): (JSC::Machine::cti_op_get_by_id): (JSC::Machine::cti_op_get_by_id_second): (JSC::Machine::cti_op_get_by_id_generic): (JSC::Machine::cti_op_get_by_id_fail): (JSC::Machine::cti_op_instanceof): (JSC::Machine::cti_op_del_by_id): (JSC::Machine::cti_op_mul): (JSC::Machine::cti_op_new_func): (JSC::Machine::cti_op_push_activation): (JSC::Machine::cti_op_call_NotJSFunction): (JSC::Machine::cti_op_new_array): (JSC::Machine::cti_op_resolve): (JSC::Machine::cti_op_construct_JSConstructFast): (JSC::Machine::cti_op_construct_NotJSConstruct): (JSC::Machine::cti_op_get_by_val): (JSC::Machine::cti_op_sub): (JSC::Machine::cti_op_lesseq): (JSC::Machine::cti_op_negate): (JSC::Machine::cti_op_resolve_base): (JSC::Machine::cti_op_resolve_skip): (JSC::Machine::cti_op_resolve_global): (JSC::Machine::cti_op_div): (JSC::Machine::cti_op_pre_dec): (JSC::Machine::cti_op_not): (JSC::Machine::cti_op_eq): (JSC::Machine::cti_op_lshift): (JSC::Machine::cti_op_bitand): (JSC::Machine::cti_op_rshift): (JSC::Machine::cti_op_bitnot): (JSC::Machine::cti_op_new_func_exp): (JSC::Machine::cti_op_mod): (JSC::Machine::cti_op_less): (JSC::Machine::cti_op_neq): (JSC::Machine::cti_op_urshift): (JSC::Machine::cti_op_bitxor): (JSC::Machine::cti_op_new_regexp): (JSC::Machine::cti_op_bitor): (JSC::Machine::cti_op_call_eval): (JSC::Machine::cti_op_throw): (JSC::Machine::cti_op_next_pname): (JSC::Machine::cti_op_typeof): (JSC::Machine::cti_op_is_undefined): (JSC::Machine::cti_op_is_boolean): (JSC::Machine::cti_op_is_number): (JSC::Machine::cti_op_is_string): (JSC::Machine::cti_op_is_object): (JSC::Machine::cti_op_is_function): (JSC::Machine::cti_op_stricteq): (JSC::Machine::cti_op_nstricteq): (JSC::Machine::cti_op_to_jsnumber): (JSC::Machine::cti_op_in): (JSC::Machine::cti_op_push_new_scope): (JSC::Machine::cti_op_del_by_val): (JSC::Machine::cti_op_new_error): (JSC::Machine::cti_vm_throw): Change these functions to return pointer types, and never JSValuePtr.
- VM/Machine.h: Ditto.
- 9:09 AM Changeset in webkit [37727] by
-
- 3 edits in trunk/JavaScriptCore
2008-10-20 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
Fixed some recent break-age in bytecode mode.
- VM/CodeBlock.cpp: (JSC::CodeBlock::printStructureIDs): Fixed up an ASSERT caused by Gavin's last checkin. This is a temporary fix so I can keep on moving. I'll send email about what I think is an underlying problem soon.
- VM/Machine.cpp: (JSC::Machine::privateExecute): Removed a redundant and sometimes incorrect cast, which started ASSERTing after Darin's last checkin.
- 8:54 AM Changeset in webkit [37726] by
-
- 6 edits2 moves in trunk/WebCore
2008-10-20 David Hyatt <hyatt@apple.com>
Move Length to platform/.
Reviewed by Adam Roben
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- platform/Length.cpp: Copied from rendering/Length.cpp.
- platform/Length.h: Copied from rendering/Length.h.
- 8:39 AM Changeset in webkit [37725] by
-
- 4 edits in trunk/WebKit/gtk
2008-10-20 Alp Toker <alp@nuanti.com>
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=21303
[GTK] Scrolling glitches
Implement a buffering scheme to avoid full repaints when scrolling
views or subframes significantly improving scrolling performance.
Improve rendering performance by coalescing large numbers of small
repaints.
Also fixes long-running issues with scrollbar positioning and frame
invalidation.
Rendering in the GTK+ port should be more similar to other ports after
these changes.
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::repaint): (WebKit::ChromeClient::scroll):
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::forceLayout):
- webkit/webkitwebview.cpp:
- 8:29 AM Changeset in webkit [37724] by
-
- 2 edits in trunk/WebCore
2008-10-20 Darin Adler <Darin Adler>
- try to fix Qt build
- bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtRuntimeMetaMethod::connectGetter): Add asObject calls. (JSC::Bindings::QtRuntimeMetaMethod::disconnectGetter): Ditto.
- 8:28 AM Changeset in webkit [37723] by
-
- 3 edits in trunk/WebCore
2008-10-20 Darin Adler <Darin Adler>
- try to fix Qt build
- bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::mark): Use JSValue* instead of JSValuePtr. (JSC::Bindings::QtField::valueFromInstance): Ditto.
- bridge/qt/qt_instance.h: Ditto.
- 8:24 AM Changeset in webkit [37722] by
-
- 2 edits in trunk/JavaScriptCore
2008-10-20 Darin Adler <Darin Adler>
- another similar Windows build fix
- VM/CTI.cpp: Changed return type to JSObject* instead of JSValuePtr.
- 8:19 AM Changeset in webkit [37721] by
-
- 3 edits in trunk/JavaScriptCore
2008-10-20 Darin Adler <Darin Adler>
- try to fix Windows build
- VM/CTI.cpp: Use JSValue* instead of JSValuePtr for ctiTrampoline.
- VM/CTI.h: Ditto.
- 8:16 AM Changeset in webkit [37720] by
-
- 3 edits in trunk/WebCore
2008-10-20 Darin Adler <Darin Adler>
- try to fix Tiger build
- bridge/objc/objc_instance.mm: (ObjcInstance::invokeMethod): Add a const_cast to remove the unwanted volatile qualifier. (ObjcInstance::invokeDefaultMethod): Ditto. (ObjcInstance::getValueOfUndefinedField): Ditto.
- bridge/objc/objc_runtime.mm: (JSC::Bindings::ObjcField::valueFromInstance): Ditto.
- 8:14 AM Changeset in webkit [37719] by
-
- 1 edit in trunk/WebCore/rendering/RenderLayer.cpp
Commit a file that was missing from the previous check-in.
- 8:13 AM Changeset in webkit [37718] by
-
- 24 edits in trunk/WebCore
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=21750
Eliminate the notion of "temporary events"
We mark some events as temporary when dispatching, for the sole reason of
manually calling forgetDOMObject when done dispatching.
There doesn't seem to be any reason to call it manually, as JSEvent destructor
will do this automatically right away.
- bindings/js/ScriptController.cpp:
- bindings/js/ScriptController.h: Removed ScriptController::finishedWithEvent(), which was called after dispatching a temporary event.
- dom/ContainerNode.cpp: (WebCore::dispatchChildInsertionEvents): (WebCore::dispatchChildRemovalEvents):
- dom/EventTarget.h:
- dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchEvent): (WebCore::EventTargetNode::dispatchGenericEvent): (WebCore::EventTargetNode::dispatchSubtreeModifiedEvent): (WebCore::EventTargetNode::dispatchWindowEvent): (WebCore::EventTargetNode::dispatchUIEvent): (WebCore::EventTargetNode::dispatchKeyEvent): (WebCore::EventTargetNode::dispatchMouseEvent): (WebCore::EventTargetNode::dispatchWheelEvent): (WebCore::EventTargetNode::dispatchWebKitAnimationEvent): (WebCore::EventTargetNode::dispatchWebKitTransitionEvent): (WebCore::EventTargetNode::dispatchEventForType): (WebCore::EventTargetNode::dispatchProgressEvent): (WebCore::EventTargetNode::dispatchStorageEvent):
- dom/EventTargetNode.h:
- dom/MessagePort.cpp: (WebCore::MessagePort::dispatchMessages): (WebCore::MessagePort::dispatchCloseEvent): (WebCore::MessagePort::dispatchEvent):
- dom/MessagePort.h:
- editing/Editor.cpp: (WebCore::Editor::dispatchCPPEvent): (WebCore::dispatchEditableContentChangedEvents):
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment):
- editing/TypingCommand.cpp: (WebCore::TypingCommand::insertText):
- loader/appcache/DOMApplicationCache.cpp: (WebCore::DOMApplicationCache::dispatchEvent): (WebCore::DOMApplicationCache::callListener):
- loader/appcache/DOMApplicationCache.h:
- page/EventHandler.cpp: (WebCore::EventHandler::dispatchDragEvent): (WebCore::EventHandler::keyEvent): (WebCore::EventHandler::handleTextInputEvent):
- page/FrameView.cpp: (WebCore::FrameView::scheduleEvent): (WebCore::FrameView::updateOverflowStatus): (WebCore::FrameView::dispatchScheduledEvents):
- page/FrameView.h:
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollToOffset): (WebCore::RenderLayer::updateOverflowStatus):
- svg/SVGElement.cpp: (WebCore::SVGElement::sendSVGLoadEventIfPossible):
- svg/SVGElementInstance.cpp: (WebCore::SVGElementInstance::dispatchEvent):
- svg/SVGElementInstance.h:
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::dispatchEvent): (WebCore::XMLHttpRequest::dispatchReadyStateChangeEvent): (WebCore::XMLHttpRequest::dispatchXMLHttpRequestProgressEvent):
- xml/XMLHttpRequest.h:
- xml/XMLHttpRequestUpload.cpp: (WebCore::XMLHttpRequestUpload::dispatchEvent): (WebCore::XMLHttpRequestUpload::dispatchXMLHttpRequestProgressEvent):
- xml/XMLHttpRequestUpload.h: Don't pass the tempEvent boolean around.
- 7:34 AM Changeset in webkit [37717] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Oliver Hunt.
<rdar://problem/6277777> REGRESSION (r36954): XMLHttpRequest not working when
certain WebView delegate actions are taken
- WebView/WebFrame.mm: (-[WebFrame _attachScriptDebugger]): Don't accidentally create a window shell if there is none yet.
- 4:32 AM Changeset in webkit [37716] by
-
- 2 edits in trunk/WebCore
2008-10-20 Alp Toker <alp@nuanti.com>
Remove unused includes only. Partial GTK+/Win build fix.
- platform/graphics/gtk/SimpleFontDataPango.cpp:
- 2:24 AM Changeset in webkit [37715] by
-
- 4 edits6 adds in trunk/WebCore
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=21705
Implement Web Workers client-side API
The implementation is experimental, and disabled by default. It doesn't quite match the
published draft, being influenced by further WHATWG discussions.
This only implements the client-side API, and does not actually create any threads or
global contexts yet.
- DerivedSources.make: Added DedicatedWorker. SharedWorker is not implemented yet, as I'm still not sure if having separate classes for these helps at all.
- WebCore.xcodeproj/project.pbxproj: Added new files.
- bindings/js/JSDOMWindowBase.cpp: (jsDOMWindowBaseWorker): (WebCore::JSDOMWindowBase::put): (setJSDOMWindowBaseWorker): Added window.Worker constructor. Moved JSXSLTProcessorConstructor.h include out of ifdef to match prevailing style.
- bindings/js/JSDedicatedWorkerConstructor.cpp: Added.
- bindings/js/JSDedicatedWorkerConstructor.h: Added.
- bindings/js/JSDedicatedWorkerCustom.cpp: Added. The implementation of event listeners are left custom intentionally, for easier implementation of listeners that are not tied to any Document in the future.
- dom/DedicatedWorker.cpp: Added.
- dom/DedicatedWorker.h: Added.
- dom/DedicatedWorker.idl: Added. Added an implementation that can only load requested scripts for now.
- 12:29 AM Changeset in webkit [37714] by
-
- 4 edits in trunk/JavaScriptCore
2008-10-19 Darin Adler <Darin Adler>
Reviewed by Cameron Zwarich.
- finish https://bugs.webkit.org/show_bug.cgi?id=21732 improve performance by eliminating JSValue as a base class for JSCell
- VM/Machine.cpp: (JSC::Machine::cti_op_call_profiler): Use asFunction. (JSC::Machine::cti_vm_lazyLinkCall): Ditto. (JSC::Machine::cti_op_construct_JSConstructFast): Use asObject.
- kjs/JSCell.h: Re-sort friend classes. Eliminate inheritance from JSValue. Changed cast in asCell from static_cast to reinterpret_cast. Removed JSValue::getNumber(double&) and one of JSValue::getObject overloads.
- kjs/JSValue.h: Made the private constructor and destructor both non-virtual and also remove the definitions. This class can never be instantiated or derived.
