Context Navigation

← Previous Period
Next Period →

Timeline

Oct 22, 2008:

8:36 PM Changeset in webkit [37804] by oliver@apple.com

6 edits in trunk/JavaScriptCore

Really "fix" CTI mode on windows 2k3.

Reviewed my Maciej Stachowiak

This adds new methods fastMallocExecutable and fastFreeExecutable
to wrap allocation for cti code. This still just makes fastMalloc
return executable memory all the time, which will be fixed in a
later patch.

However in windows debug builds all executable allocations will be
allocated on separate executable pages, which should resolve any
remaining 2k3 issues. Conveniently the 2k3 bot will now also fail
if there are any fastFree vs. fastFreeExecutable errors.

7:53 PM Changeset in webkit [37803] by ddkilzer@apple.com

6 edits in trunk/WebCore

Bug 21781: WebCore::Settings should have a maximum decoded image size setting

<https://bugs.webkit.org/show_bug.cgi?id=21781>

Reviewed by Antti.

No tests since there is no change in behavior.

loader/CachedImage.cpp: (WebCore::CachedImage::maximumDecodedImageSize): Added. Returns WebCore::Settings::maximumDecodedImageSize() or 0 on error. (WebCore::CachedImage::data): Flag an error if the image being loaded is too big.
loader/CachedImage.h: (WebCore::CachedImage::maximumDecodedImageSize): Added declaration.
page/Settings.cpp: (WebCore::Settings::Settings): Initialize m_maximumDecodedImageSize to the maximum value of size_t.
page/Settings.h: (WebCore::Settings::setMaximumDecodedImageSize): Added method. (WebCore::Settings::maximumDecodedImageSize): Ditto.

7:31 PM Changeset in webkit [37802] by cwzwarich@webkit.org

2 edits in trunk/LayoutTests

2008-10-22 Cameron Zwarich <zwarich@apple.com>

Reviewed by Kevin McCullough.

Check in changed test results for r37792.

fast/dom/Window/window-properties-expected.txt:

6:43 PM Changeset in webkit [37801] by Darin Adler

2 edits in trunk/WebCore

2008-10-22 Mike Pinkerton <pinkerton@chromium.org>

Reviewed by Dan Bernstein.
Landed and tweaked a bit by Darin Adler.

fix https://bugs.webkit.org/show_bug.cgi?id=21809

Remove PLATFORM(MAC) wrapping USE(ATSUI). It's redundant and inhibits
its use for PLATFORM(CHROMIUM) in the future.

platform/graphics/SimpleFontData.h:

5:49 PM Changeset in webkit [37800] by dsmith@webkit.org

3 edits
2 adds in trunk

WebCore:

2008-10-22 David Smith <catfish.man@gmail.com>

Reviewed by andersca.

https://bugs.webkit.org/show_bug.cgi?id=19974
getElementsByClassName not live enough

Test: fast/dom/getElementsByClassName/015.html

dom/StyledElement.cpp: (WebCore::StyledElement::classAttributeChanged): call dispatchSubtreeModifiedEvent()

LayoutTests:

2008-10-22 David Smith <catfish.man@gmail.com>

Reviewed by andersca.

https://bugs.webkit.org/show_bug.cgi?id=19974
getElementsByClassName not live enough

fast/dom/getElementsByClassName/015-expected.txt: Added.
fast/dom/getElementsByClassName/015.html: Added.

5:11 PM Changeset in webkit [37799] by Darin Adler

42 edits in trunk

JavaScriptCore:

2008-10-22 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

fix https://bugs.webkit.org/show_bug.cgi?id=21294 Bug 21294: Devirtualize getOwnPropertySlot()

A bit over 3% faster on V8 tests.

JavascriptCore.exp: Export leak-related functions..

API/JSCallbackConstructor.h: (JSC::JSCallbackConstructor::createStructureID): Set HasStandardGetOwnPropertySlot since this class doesn't override getPropertySlot.
API/JSCallbackFunction.h: (JSC::JSCallbackFunction::createStructureID): Ditto.

VM/ExceptionHelpers.cpp: (JSC::InterruptedExecutionError::InterruptedExecutionError): Use a structure that's created just for this class instead of trying to share a single "null prototype" structure.

VM/Machine.cpp: (JSC::Machine::cti_op_create_arguments_no_params): Rename Arguments::ArgumentsNoParameters to Arguments::NoParameters.

kjs/Arguments.h: Rename the enum from Arguments::ArgumentsParameters to Arguments::NoParametersType and the value from Arguments::ArgumentsNoParameters to Arguments::NoParameters. (JSC::Arguments::createStructureID): Added. Returns a structure without HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot. (JSC::Arguments::Arguments): Added an assertion that there are no parameters.

kjs/DatePrototype.h: (JSC::DatePrototype::createStructureID): Added. Returns a structure without HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.

kjs/FunctionPrototype.h: (JSC::FunctionPrototype::createStructureID): Set HasStandardGetOwnPropertySlot since this class doesn't override getPropertySlot.
kjs/InternalFunction.h: (JSC::InternalFunction::createStructureID): Ditto.

kjs/JSArray.h: (JSC::JSArray::createStructureID): Added. Returns a structure without HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.

kjs/JSCell.h: Added declaration of fastGetOwnPropertySlot; a non-virtual version that uses the structure bit to decide whether to call the virtual version.

kjs/JSFunction.h: (JSC::JSFunction::createStructureID): Added. Returns a structure without HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.

kjs/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): Initialize new structures; removed nullProtoStructureID.
kjs/JSGlobalData.h: Added new structures. Removed nullProtoStructureID.

kjs/JSGlobalObject.h: (JSC::JSGlobalObject::createStructureID): Added. Returns a structure without HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.

kjs/JSNotAnObject.h: (JSC::JSNotAnObjectErrorStub::JSNotAnObjectErrorStub): Use a structure that's created just for this class instead of trying to share a single "null prototype" structure. (JSC::JSNotAnObjectErrorStub::isNotAnObjectErrorStub): Marked this function virtual for clarity and made it private since no one should call it if they already have a pointer to this specific type. (JSC::JSNotAnObject::JSNotAnObject): Use a structure that's created just for this class instead of trying to share a single "null prototype" structure. (JSC::JSNotAnObject::createStructureID): Added. Returns a structure without HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.

kjs/JSObject.h: (JSC::JSObject::createStructureID): Added HasStandardGetOwnPropertySlot. (JSC::JSObject::inlineGetOwnPropertySlot): Added. Used so we can share code between getOwnPropertySlot and fastGetOwnPropertySlot. (JSC::JSObject::getOwnPropertySlot): Moved so that functions are above the functions that call them. Moved the guts of this function into inlineGetOwnPropertySlot. (JSC::JSCell::fastGetOwnPropertySlot): Added. Checks the HasStandardGetOwnPropertySlot bit and if it's set, calls inlineGetOwnPropertySlot, otherwise calls getOwnPropertySlot. (JSC::JSObject::getPropertySlot): Changed to call fastGetOwnPropertySlot. (JSC::JSValue::get): Changed to call fastGetOwnPropertySlot.

kjs/JSWrapperObject.h: Made constructor protected to emphasize that this class is only a base class and never instantiated.

kjs/MathObject.h: (JSC::MathObject::createStructureID): Added. Returns a structure without HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.
kjs/NumberConstructor.h: (JSC::NumberConstructor::createStructureID): Ditto.
kjs/RegExpConstructor.h: (JSC::RegExpConstructor::createStructureID): Ditto.
kjs/RegExpObject.h: (JSC::RegExpObject::createStructureID): Ditto.
kjs/StringObject.h: (JSC::StringObject::createStructureID): Ditto.

kjs/TypeInfo.h: Added HasStandardGetOwnPropertySlot flag and hasStandardGetOwnPropertySlot accessor function.

JavaScriptGlue:

2008-10-22 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

fix https://bugs.webkit.org/show_bug.cgi?id=21294 Bug 21294: Devirtualize getOwnPropertySlot()

JSRun.cpp: (JSGlueGlobalObject::JSGlueGlobalObject): Moved constructor here. Set up flags in its new location in global object data, and set up a structure for UserObjectImp too. (JSRun::JSRun): Added code to give the JSGlueGlobalObject its own unique structure, rather than using the default one from JSGlobalObject.

JSRun.h: Made JSGlueGlobalObject take a structure ID. Also moved the data into a separate data object. And added userObjectStructure, a Structure to be used by UserObjectImp.

JSUtils.cpp: Removed unused sharedGlobalData global. (JSObjectKJSValue): Pass Structure in when creating UserObjectImp. (unprotectGlobalObject): Use JSGlueGLobalObject type specifically. (initializeGlobalObjectKey): Removed code to set up unused sharedGlobalData. (getThreadGlobalObject): Added. Shared by JSObjectKJSValue and getThreadGlobalExecState. Also now passes in a structure ID when creating the global object. (getThreadGlobalExecState): Changed to call getThreadGlobalObject.

UserObjectImp.cpp: (UserObjectImp::UserObjectImp): Changed to take a structure.
UserObjectImp.h: (UserObjectImp::createStructureID): Added. Returns a structure without HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.

WebCore:

2008-10-22 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

fix https://bugs.webkit.org/show_bug.cgi?id=21294 Bug 21294: Devirtualize getOwnPropertySlot()

bindings/js/JSDOMWindowShell.h: (WebCore::JSDOMWindowShell::createStructureID): Added. Returns a structure without HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.

bindings/js/JSInspectorCallbackWrapper.cpp: (WebCore::JSInspectorCallbackWrapper::wrap): Change to use a unique structure for this class rather than sharing nullProtoStructureID, which no longer exists.

bindings/js/JSNamedNodesCollection.h: (WebCore::JSNamedNodesCollection::createStructureID): Added. Returns a structure without HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.
bindings/js/JSRGBColor.h: (WebCore::JSRGBColor::createStructureID): Ditto.

bindings/scripts/CodeGeneratorJS.pm: Added createStructureID functions for the wrappers, constructors, and prototypes in any case where they override getOwnPropertySlot, without HasStandardGetOwnPropertySlot.

bridge/objc/objc_runtime.h: (JSC::Bindings::ObjcFallbackObjectImp::createStructureID): Added. Returns a structure without HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.
bridge/qt/qt_runtime.h: (JSC::Bindings::QtRuntimeMethod::createStructureID): Ditto.
bridge/runtime_array.h: (JSC::RuntimeArray::createStructureID): Ditto.
bridge/runtime_method.h: (JSC::RuntimeMethod::createStructureID): Ditto.
bridge/runtime_object.h: (JSC::RuntimeObjectImp::createStructureID): Ditto.

4:34 PM Changeset in webkit [37798] by Adam Roben

2 edits in trunk/WebCore

Bring Windows Cairo Port's font handling in line with CG.
http://bugs.webkit.org/show_bug.cgi?id=21812.

Reviewed by Adam Roben.

platform/graphics/win/FontCacheWin.cpp: (WebCore::createGDIFont): Remove unnecessary special-case for Cairo TrueType font search. It should match CG in all font selections.

4:33 PM Changeset in webkit [37797] by Adam Roben

7 edits
1 add in trunk

WebCore:

2008-10-22 Brent Fulgham <bfulgham@gmail.com>

Correct build regressions in Cairo port for Windows.
http://bugs.webkit.org/show_bug.cgi?id=21724

Reviewed by Adam Roben.

WebCore.vcproj/WebCore.vcproj: Fixed include paths and post-build event for the Debug_Cairo and Release_Cairo configurations.
platform/graphics/win/GraphicsContextCairoWin.cpp: (WebCore::GraphicsContext::GraphicsContext): Update to newer constructor signature.
platform/network/curl/DNSCurl.cpp: Added. (WebCore::prefetchDNS):
platform/network/curl/ResourceRequest.h:
platform/win/ScrollbarThemeWin.cpp: (WebCore::ScrollbarTheme::nativeTheme):

WebKit/win:

2008-10-22 Brent Fulgham <bfulgham@gmail.com>

Correct build regressions in Cairo port for Windows.
http://bugs.webkit.org/show_bug.cgi?id=21724

Reviewed by Adam Roben.

WebView.cpp: (WebView::notifyPreferencesChanged): Don't try to call setShouldPaintNativeControls when SafariTheme support is disabled, as that function doesn't exist in that case.

4:31 PM Changeset in webkit [37796] by beidson@apple.com

9 edits in trunk

LayoutTests:
2008-10-22 Brady Eidson <beidson@apple.com>

Reviewed by Adam Roben

<rdar://6261773> - autocomplete="off" doesn't work on Windows

Remove a skipped test that can now pass with proper DRT support

platform/win/Skipped: Remove security/autocomplete-cleared-on-back.html

WebKitTools:
2008-10-22 Brady Eidson <beidson@apple.com>

Reviewed by Adam Roben

<rdar://6261773> - autocomplete="off" doesn't work on Windows

Implement LayoutTestController::elementDoesAutoCompleteForElementWithId() on Windows

DumpRenderTree/win/LayoutTestControllerWin.cpp:

WebKit/win:
2008-10-22 Brady Eidson <beidson@apple.com>

Reviewed by Adam Roben

Move elementDoesAutoComplete() to IWebFramePrivate so it is exposed for DRT to use

Interfaces/IWebFramePrivate.idl:

WebFrame.cpp: (WebFrame::elementDoesAutoComplete):
WebFrame.h:

WebHTMLRepresentation.cpp: (WebHTMLRepresentation::elementDoesAutoComplete):

4:19 PM Changeset in webkit [37795] by mrowe@apple.com

2 edits in branches/Safari-3-2-branch/WebCore

Merge r37793.

4:12 PM Changeset in webkit [37794] by timothy@apple.com

1 edit in trunk/WebCore/inspector/front-end/ElementsTreeOutline.js

Add a license to ElementsTreeOutline.js that was left off when it was split out from ElementsPanel.js.

4:06 PM Changeset in webkit [37793] by beidson@apple.com

2 edits in trunk/WebCore

Reviewed by Adam Roben

<rdar://6261773> - autocomplete="off" doesn't work on Windows

Visual Studio makes a poor decision regarding the combination of enums and bitfields, such that a
statement like "m_autocomplete = Off" followed by "return m_autocomplete == Off" would return "false"
instead of the much more correct "true."

In the past we have worked around this by declaring the bitfield member as an unsigned instead
of the enum type.

For more discussion, see http://trac.webkit.org/changeset/25329

html/HTMLInputElement.h: Work around insane Visual Studio enum issue *sigh*

4:05 PM Changeset in webkit [37792] by kmccullough@apple.com

1 edit in trunk/WebCore/ChangeLog

2008-10-22 Kevin McCullough <kmccullough@apple.com>

Reviewed by Oliver Hunt and Tim Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=19225
Bug 19225: JSProfiler: Create automated profiler tests

This change exports profiles on the console object so that they can be iterated over via JavaScript, and thus can be used in automated tests.

bindings/js/JSConsoleCustom.cpp: Get the profiles and return an array that JS can use. (WebCore::JSConsole::profiles):
inspector/InspectorController.h: Use the new typedef. (WebCore::InspectorController::profiles):
page/Console.cpp: Keep our own array of profile objects. (WebCore::Console::profileEnd):
page/Console.h: Ditto. (WebCore::Console::profiles):
page/Console.idl: Expose the profiles to JS.

4:04 PM Changeset in webkit [37791] by kmccullough@apple.com

6 edits in trunk/WebCore

2008-10-22 Kevin McCullough <kmccullough@apple.com>

Reviewed by Oliver Hunt and Tim Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=19225
Bug 19225: JSProfiler: Create automated profiler tests

This change exports profiles on the console object so that they can be iterated over via JavaScript, and thus can be used in automated tests.

bindings/js/JSConsoleCustom.cpp: Get the profiles and return an array that JS can use. (WebCore::JSConsole::profiles):
inspector/InspectorController.h: Use the new typedef. (WebCore::InspectorController::profiles):
page/Console.cpp: Keep our own array of profile objects. (WebCore::Console::profileEnd):
page/Console.h: Ditto. (WebCore::Console::profiles):
page/Console.idl: Expose the profiles to JS.

2:51 PM Changeset in webkit [37790] by hyatt@apple.com

11 edits in trunk/WebCore

2008-10-22 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21775

Convert buttons over to use the new Theme API on OS X.

Reviewed by Adam Roben

platform/LengthBox.h: (WebCore::LengthBox::LengthBox):
platform/Theme.cpp: (WebCore::Theme::controlBorder): (WebCore::Theme::controlPadding):
platform/Theme.h: (WebCore::Theme::controlFont): (WebCore::Theme::controlSize): (WebCore::Theme::minControlSize): (WebCore::Theme::controlRequiresPreWhiteSpace):
platform/mac/ThemeMac.h: (WebCore::ThemeMac::controlRequiresPreWhiteSpace):
platform/mac/ThemeMac.mm: (WebCore::checkboxSize): (WebCore::radioSize): (WebCore::buttonSizes): (WebCore::buttonMargins): (WebCore::button): (WebCore::paintButton): (WebCore::ThemeMac::controlFont): (WebCore::ThemeMac::controlSize): (WebCore::ThemeMac::minControlSize): (WebCore::ThemeMac::controlBorder): (WebCore::ThemeMac::controlPadding): (WebCore::ThemeMac::inflateControlPaintRect): (WebCore::ThemeMac::paint):
rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): (WebCore::RenderTheme::paint): (WebCore::RenderTheme::controlStatesForRenderer): (WebCore::RenderTheme::isDefault): (WebCore::RenderTheme::adjustRadioStyle):
rendering/RenderTheme.h: (WebCore::RenderTheme::setRadioSize):
rendering/RenderThemeMac.h:
rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustRepaintRect): (WebCore::menuListButtonSizes): (WebCore::RenderThemeMac::adjustMenuListStyle):
rendering/style/RenderStyle.h: (WebCore::InheritedFlags::paddingBox): (WebCore::InheritedFlags::setPaddingBox):

2:06 PM Changeset in webkit [37789] by cwzwarich@webkit.org

6 edits in trunk/JavaScriptCore

2008-10-22 Cameron Zwarich <zwarich@apple.com>

Reviewed by Geoff Garen.

Bug 21803: Fuse op_jfalse with op_eq_null and op_neq_null
<https://bugs.webkit.org/show_bug.cgi?id=21803>

Fuse op_jfalse with op_eq_null and op_neq_null to make the new opcodes
op_jeq_null and op_jneq_null.

This is a 2.6% speedup on the V8 Raytrace benchmark, and strangely also
a 4.7% speedup on the V8 Arguments benchmark, even though it uses
neither of the two new opcodes.

VM/CTI.cpp: (JSC::CTI::privateCompileMainPass):
VM/CodeBlock.cpp: (JSC::CodeBlock::dump):
VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitJumpIfTrue): (JSC::CodeGenerator::emitJumpIfFalse):
VM/Machine.cpp: (JSC::Machine::privateExecute):
VM/Opcode.h:

12:53 PM Changeset in webkit [37788] by Simon Fraser

1 edit
6 moves in trunk/LayoutTests

2008-10-22 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

Moved tests from css3 to animations/transforms directories.

animations/change-keyframes-expected.txt: Renamed from LayoutTests/css3/change-keyframes-expected.txt.
animations/change-keyframes.html: Renamed from LayoutTests/css3/change-keyframes.html.
animations/keyframes-rule-expected.txt: Renamed from LayoutTests/css3/keyframes-rule-expected.txt.
animations/keyframes-rule.html: Renamed from LayoutTests/css3/keyframes-rule.html.
transforms/transform-value-types-expected.txt: Renamed from LayoutTests/css3/transform-value-types-expected.txt.
transforms/transform-value-types.html: Renamed from LayoutTests/css3/transform-value-types.html.

12:53 PM Changeset in webkit [37787] by Simon Hausmann

4 edits in trunk/WebKit/qt

2008-10-22 Ariya Hidayat <ariya.hidayat@trolltech.com>

Reviewed by Simon Hausmann.

For public API, use the term boundingRect instead of boundingBox.

Api/qwebframe.cpp: (QWebHitTestResultPrivate::QWebHitTestResultPrivate): (QWebHitTestResult::boundingRect):
Api/qwebframe.h:
Api/qwebframe_p.h:

12:35 PM Changeset in webkit [37786] by Simon Fraser

5 edits
2 adds in trunk

2008-10-22 Chris Marrin <cmarrin@apple.com>

Reviewed by Dave Hyatt

Make sure that the AtomicString that identifies a set of animation keyframes
stays live by keeping a copy in the WebKitCSSKeyframesRule.

Also call styleSheetChanged() when the keyframes name changes, but
add an internal method that doesn't call styleSheetChanged() for use
during normal stylesheet parsing.

Test: animations/change-keyframes-name.html

css/CSSGrammar.y:
css/WebKitCSSKeyframesRule.cpp: (WebCore::WebKitCSSKeyframesRule::setName):
css/WebKitCSSKeyframesRule.h: (WebCore::WebKitCSSKeyframesRule::setNameInternal):

11:32 AM Changeset in webkit [37785] by Darin Adler

2 edits in trunk/WebKitTools

2008-10-22 Darin Adler <Darin Adler>

Scripts/do-webcore-rename: More renaming plans.

10:43 AM Changeset in webkit [37784] by ap@webkit.org

6 edits in trunk/WebCore

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=21791
WebCore JS bindings should be able to use non-static hash tables for properties

Add a map for HashTables to WebCore JS client data.

This makes property access noticeably slower, so it is an opt-in. For classes that need to be
supported in workers in forseeable future this is not critical.

bindings/js/JSDOMBinding.cpp: (WebCore::DOMObjectHashTableMap::get): (WebCore::DOMObjectHashTableMap::mapFor): (WebCore::getHashTableForGlobalData): (WebCore::DOMObjectWrapperMap::mapFor): WebCore client data is now a class that contains both a DOM wrapper map and a property hash table one.

bindings/js/JSDOMBinding.h: Added getHashTableForGlobalData() to query the hash table map.

bindings/scripts/CodeGeneratorJS.pm: If the class has a NoStaticTables attribute, use JSDOMBinding map to access its property hash tables.

dom/MessageChannel.idl:
dom/MessagePort.idl: Added NoStaticTables attribute.

9:47 AM Changeset in webkit [37783] by darin@chromium.org

2 edits in trunk/JavaScriptCore

2008-10-22 Darin Fisher <darin@chromium.org>

Reviewed by Eric Seidel.

Should not define PLATFORM(WIN,MAC,GTK) when PLATFORM(CHROMIUM) is defined
https://bugs.webkit.org/show_bug.cgi?id=21757

PLATFORM(CHROMIUM) implies HAVE_ACCESSIBILITY

wtf/Platform.h:

9:16 AM Changeset in webkit [37782] by alp@webkit.org

2 edits in trunk/WebKit/gtk

2008-10-22 Alp Toker <alp@nuanti.com>

Build fix for older GTK+ versions where GTK_TYPE_TARGET_LIST isn't
defined.

webkit/webkitwebview.cpp:

7:24 AM Changeset in webkit [37781] by cwzwarich@webkit.org

2 edits in trunk/JavaScriptCore

2008-10-22 Cameron Zwarich <zwarich@apple.com>

Reviewed by Alexey Proskuryakov.

Correct opcode names in documentation.

VM/Machine.cpp: (JSC::Machine::privateExecute):

6:55 AM Changeset in webkit [37780] by alp@webkit.org

2 edits in trunk/WebCore

2008-10-22 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Timothy Hatcher.

Build failure because of missing include
https://bugs.webkit.org/show_bug.cgi?id=21765

Build failure fix for WebKit/GTK+; added missing
include (GOwnPtr.h)

platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:

6:51 AM Changeset in webkit [37779] by alp@webkit.org

4 edits in trunk

2008-10-22 Alp Toker <alp@nuanti.com>

Reviewed by Adam Roben.

Fix crashes on older GTK+ versions (2.8). gtk_widget_style_get()
doesn't initialize values if the requested property doesn't exist, so
initialize the values to the documented defaults before calling it
where necessary. Additionally, avoid critical warnings by not calling
gtk_widget_style_get() when we know the property isn't available.

Note that this is an imported source file which doesn't follow the
WebKit coding style.

Avoid critical warnings on older GTK+ versions (2.8) by not checking
for GTK+ setting properties when we know they don't exist.

3:38 AM Changeset in webkit [37778] by alp@webkit.org

5 edits in trunk

2008-10-22 Alp Toker <alp@nuanti.com>

Fix build for Cairo 1.2.

1:22 AM Changeset in webkit [37777] by mrowe@apple.com

4 edits in branches/Safari-3-2-branch

Versioning.

12:56 AM Changeset in webkit [37776] by darin@chromium.org

3 edits in trunk/WebCore

2008-10-22 Darin Fisher <darin@chromium.org>

Reviewed by Eric Seidel.

A little more PLATFORM(CHROMIUM) in WebCore
https://bugs.webkit.org/show_bug.cgi?id=21758

page/AccessibilityObject.h:
platform/graphics/Icon.h:

12:54 AM Changeset in webkit [37775] by abarth@webkit.org

3 edits in trunk/LayoutTests

2008-10-22 Jungshik Shin <jshin@chromium.org>

Reviewed by Alexey Proskuryakov.
Landed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=21581

Replace x-mac-cyrillic by windows-1256.

http/tests/misc/frame-default-enc-same-domain-expected.txt:
http/tests/misc/frame-default-enc-same-domain.html:

12:15 AM Changeset in webkit [37774] by mrowe@apple.com

4 edits in branches/Safari-3-2-branch

Versioning.

12:14 AM Changeset in webkit [37773] by mrowe@apple.com

1 copy in tags/Safari-5525.26.2

New tag.

Oct 21, 2008:

11:49 PM Changeset in webkit [37772] by oliver@apple.com

2 edits in trunk/JavaScriptCore

Attempt to make the win2k3 bot be more useful for testing

RS=Maciej Stachowiak.

Force FastMalloc to make all allocated pages executable in
a vague hope this will allow the Win2k3 bot to be able to
run tests.

Filed Bug 21783: Need more granular control over allocation of executable memory
to cover a more granular version of this patch.

11:07 PM Changeset in webkit [37771] by ap@webkit.org

7 edits
2 adds in trunk

Reviewed by Darin Adler.

Test: fast/events/message-channel-gc-3.html

https://bugs.webkit.org/show_bug.cgi?id=21769
MessagePort should be GC protected if there are messages to be delivered

dom/MessagePort.h: Removed pending activity count. Now we track if a close event is pending, and check if the queue is non-empty. (WebCore::MessagePort::workerContext): Added a stub implementation for a cross-heap GC bug fix (below).

dom/MessagePort.cpp: (WebCore::CloseMessagePortTimer::fired): (WebCore::MessagePort::MessagePort): (WebCore::MessagePort::queueCloseEvent): (WebCore::MessagePort::dispatchCloseEvent): (WebCore::MessagePort::hasPendingActivity): Track message and close event activity separately.

bindings/js/JSDOMBinding.cpp: (WebCore::markCrossHeapDependentObjectsForDocument): Fixed a bug in cross-heap GC that was causing same-heap ports to never be deleted.

wtf/MessageQueue.h: (WTF::::isEmpty): Added. Also added a warning for methods that return a snapshot of queue state, thus likely to cause race conditions.

8:10 PM Changeset in webkit [37770] by mitz@apple.com

2 edits in trunk/WebCore

Reviewed by Sam Weinig.

remove unreachable code

platform/text/BidiResolver.h: (WebCore::::embed):

5:41 PM Changeset in webkit [37769] by sfalken@apple.com

2 edits in trunk/WebKitTools

2008-10-21 Steve Falkenburg <sfalken@apple.com>

Exclude strings marked with UNLOCALIZED_STRING or UNLOCALIZED_LPCTSTR.

Scripts/extract-localizable-strings:

5:22 PM Changeset in webkit [37768] by Beth Dakin

2 edits in trunk/WebCore

2008-10-21 Beth Dakin <Beth Dakin>

Reviewed by Darin Adler.

Fix for https://bugs.webkit.org/show_bug.cgi?id=20352
REGRESSION(r31030-31055): Choosing "Print window" from frame set
prints blank page
and corresponding: <rdar://problem/6142398>

viewHeight() and viewWidth() only return valuable information if we
are not printing. Everywhere else in the code, we make sure we are
not printing before we call these functions. Adding a check for
printing here fixes this bug, and framesets print again.

rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::layout):

5:16 PM Changeset in webkit [37767] by mrowe@apple.com

3 edits in branches/Safari-3-2-branch/WebKit/win

Merge r37489.

5:16 PM Changeset in webkit [37766] by mrowe@apple.com

2 edits in branches/Safari-3-2-branch/WebCore

Merge r37704.

5:16 PM Changeset in webkit [37765] by mrowe@apple.com

8 edits in branches/Safari-3-2-branch

Merge r31577.

3:33 PM Changeset in webkit [37764] by Simon Hausmann

4 edits in trunk/WebKit/qt

2008-06-03 Siraj Razick <siraj.razick@collabora.co.uk>

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=19374

Expose boundingBox value in QWebHitTestResult

Add API function QRect QWebHitResult::boundingBox() const

API docs by Ariya.

2:29 PM Changeset in webkit [37763] by Darin Adler

2 edits in trunk/JavaScriptCore

2008-10-21 Darin Adler <Darin Adler>

Reviewed by Maciej Stachowiak.

convert post-increment to pre-increment in a couple more places for speed

Speeds up V8 benchmarks a little on most computers. (But, strangely, slows
them down a little on my computer.)

kjs/nodes.cpp: (JSC::statementListEmitCode): Removed default argument, since we always want to specify this explicitly. (JSC::ForNode::emitCode): Tolerate ignoredResult() as the dst -- means the same thing as 0. (JSC::ReturnNode::emitCode): Ditto. (JSC::ThrowNode::emitCode): Ditto. (JSC::FunctionBodyNode::emitCode): Pass ignoredResult() so that we know we don't have to compute the result of function statements.

2:09 PM Changeset in webkit [37762] by pkasting@chromium.org