Context Navigation

platform/FileChooser.cpp: (WebCore::FileChooserClient::~FileChooserClient):
platform/FileChooser.h: Moved destructor to .cpp file, to avoid a weak exported symbol.

12:59 PM Changeset in webkit [37891] by ggaren@apple.com

16 edits in trunk/JavaScriptCore

2008-10-25 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig, with Gavin Barraclough's help.

Fixed Sampling Tool:

Made CodeBlock sampling work with CTI
Improved accuracy by unifying most sampling data into a single 32bit word, which can be written / read atomically.
Split out three different #ifdefs for modularity: OPCODE_SAMPLING; CODEBLOCK_SAMPLING; OPCODE_STATS.
Improved reporting clarity
Refactored for code clarity

JavaScriptCore.exp: Exported another symbol.

VM/CTI.cpp: (JSC::CTI::emitCTICall): (JSC::CTI::compileOpCall): (JSC::CTI::emitSlowScriptCheck): (JSC::CTI::compileBinaryArithOpSlowCase): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases): (JSC::CTI::privateCompile):
VM/CTI.h: Updated CTI codegen to use the unified SamplingTool interface for encoding samples. (This required passing the current vPC to a lot more functions, since the unified interface samples the current vPC.) Added hooks for writing the current CodeBlock* on function entry and after a function call, for the sake of the CodeBlock sampler. Removed obsolete hook for clearing the current sample inside op_end. Also removed the custom enum used to differentiate flavors of op_call, since the OpcodeID enum works just as well. (This was important in an earlier version of the patch, but now it's just cleanup.)

VM/CodeBlock.cpp: (JSC::CodeBlock::lineNumberForVPC):
VM/CodeBlock.h: Upated for refactored #ifdefs. Changed lineNumberForVPC to be robust against vPCs not recorded for exception handling, since the Sampler may ask for an arbitrary vPC.

VM/Machine.cpp: (JSC::Machine::execute): (JSC::Machine::privateExecute): (JSC::Machine::cti_op_call_NotJSFunction): (JSC::Machine::cti_op_construct_NotJSConstruct):
VM/Machine.h: (JSC::Machine::setSampler): (JSC::Machine::sampler): (JSC::Machine::jitCodeBuffer): Upated for refactored #ifdefs. Changed Machine to use SamplingTool helper objects to record movement in and out of host code. This makes samples a bit more precise.

VM/Opcode.cpp: (JSC::OpcodeStats::~OpcodeStats):
VM/Opcode.h: Upated for refactored #ifdefs. Added a little more padding, to accomodate our more verbose opcode names.

VM/SamplingTool.cpp: (JSC::ScopeSampleRecord::sample): Only count a sample toward our total if we actually record it. This solves cases where a CodeBlock will claim to have been sampled many times, with reported samples that don't match.

(JSC::SamplingTool::run): Read the current sample into a Sample helper
object, to ensure that the data doesn't change while we're analyzing it,
and to help decode the data. Only access the CodeBlock sampling hash
table if CodeBlock sampling has been enabled, so non-CodeBlock sampling
runs can operate with even less overhead.

(JSC::SamplingTool::dump): I reorganized this code a lot to print the
most important info at the top, print as a table, annotate and document
the stuff I didn't understand when I started, etc.

VM/SamplingTool.h: New helper classes, described above.

kjs/Parser.h:
kjs/Shell.cpp: (runWithScripts):
kjs/nodes.cpp: (JSC::ScopeNode::ScopeNode): Updated for new sampling APIs.

wtf/Platform.h: Moved sampling #defines here, since our custom is to put ENABLE #defines into Platform.h. Made explicit the fact that CODEBLOCK_SAMPLING depends on OPCODE_SAMPLING.

12:11 PM Changeset in webkit [37890] by kevino@webkit.org

2 edits in trunk/WebKit/wx

wx build fix.

8:22 AM Changeset in webkit [37889] by vestbo@webkit.org

4 edits in trunk

2008-10-25 Jade Han <jade.han@nokia.com>

Reviewed by Anders.

Enable custom properties for Qt runtime objects in QtWebKit

https://bugs.webkit.org/show_bug.cgi?id=21813

2:37 AM Changeset in webkit [37888] by jmalonzo@webkit.org

2 edits in trunk/JavaScriptCore

2008-10-25 Jan Michael Alonzo <jmalonzo@webkit.org>

JSC Build fix, not reviewed.

VM/CTI.cpp: add missing include stdio.h for debug builds

12:24 AM Changeset in webkit [37887] by jmalonzo@webkit.org

2 edits in trunk

2008-10-25 Jan Michael Alonzo <jmalonzo@webkit.org>

Gtk build fix: add '-' to Wl which was missed in r36845

GNUmakefile.am:

Oct 24, 2008:

11:58 PM Changeset in webkit [37886] by weinig@apple.com

2 edits in trunk/WebKit/win

2008-10-24 Sam Weinig <sam@webkit.org>

Yet another windows build fix.

WebCoreSupport/WebChromeClient.cpp:

11:39 PM Changeset in webkit [37885] by weinig@apple.com

2 edits in trunk/WebKit/qt

2008-10-24 Sam Weinig <sam@webkit.org>

Another Qt build fix.

WebCoreSupport/ChromeClientQt.cpp:

11:38 PM Changeset in webkit [37884] by weinig@apple.com

2 edits in trunk/WebKit/win

2008-10-24 Sam Weinig <sam@webkit.org>

Another windows build fix.

WebCoreSupport/WebChromeClient.cpp:

11:36 PM Changeset in webkit [37883] by weinig@apple.com

3 edits in trunk/WebCore

2008-10-24 Sam Weinig <sam@webkit.org>

Fix windows build.

page/Chrome.cpp:
page/Chrome.h:

11:31 PM Changeset in webkit [37882] by weinig@apple.com

2 edits in trunk/WebKit/gtk

2008-10-24 Sam Weinig <sam@webkit.org>

Fix the Gtk build.

WebCoreSupport/ChromeClientGtk.cpp:

11:29 PM Changeset in webkit [37881] by weinig@apple.com

2 edits in trunk/WebCore

2008-10-24 Sam Weinig <sam@webkit.org>

Fix Qt build.

platform/qt/FileChooserQt.cpp:

11:02 PM Changeset in webkit [37880] by weinig@apple.com

28 edits in trunk

WebCore:

2008-10-24 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Fix https://bugs.webkit.org/show_bug.cgi?id=21759
Layering violation: FileChooser should not depend on Document/Frame/Page

Move file choosing into WebKit ChromeClient.

loader/EmptyClients.h: (WebCore::EmptyChromeClient::runOpenPanel):
page/Chrome.cpp: (WebCore::Chrome::runOpenPanel):
page/Chrome.h:
page/ChromeClient.h:
page/mac/ChromeMac.mm:
platform/FileChooser.h:
platform/mac/FileChooserMac.mm:
platform/qt/FileChooserQt.cpp:
platform/win/FileChooserWin.cpp:
platform/wx/TemporaryLinkStubs.cpp:
rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::click):

WebKit/gtk:

2008-10-24 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Fix https://bugs.webkit.org/show_bug.cgi?id=21759
Layering violation: FileChooser should not depend on Document/Frame/Page

WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::runOpenPanel):
WebCoreSupport/ChromeClientGtk.h:

WebKit/mac:

2008-10-24 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Fix https://bugs.webkit.org/show_bug.cgi?id=21759
Layering violation: FileChooser should not depend on Document/Frame/Page

WebCoreSupport/WebChromeClient.h:
WebCoreSupport/WebChromeClient.mm: (WebChromeClient::runOpenPanel):

WebKit/qt:

2008-10-24 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Fix https://bugs.webkit.org/show_bug.cgi?id=21759
Layering violation: FileChooser should not depend on Document/Frame/Page

WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::runOpenPanel):
WebCoreSupport/ChromeClientQt.h:

WebKit/win:

2008-10-24 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Fix https://bugs.webkit.org/show_bug.cgi?id=21759
Layering violation: FileChooser should not depend on Document/Frame/Page

WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::runOpenPanel):
WebCoreSupport/WebChromeClient.h:

WebKit/wx:

2008-10-24 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Fix https://bugs.webkit.org/show_bug.cgi?id=21759
Layering violation: FileChooser should not depend on Document/Frame/Page

WebKitSupport/ChromeClientWx.cpp: (WebCore::ChromeClientWx::runOpenPanel):
WebKitSupport/ChromeClientWx.h:

9:48 PM Changeset in webkit [37879] by eric@webkit.org

1 edit
1 add in trunk/LayoutTests

Reviewed by Sam Weinig.

Add missing results.

fast/js/global-constructors-expected.txt: Added.

6:34 PM Changeset in webkit [37878] by kevino@webkit.org

2 edits in trunk/WebCore

wx build fix - add newIconForFiles stub.

6:15 PM Changeset in webkit [37877] by kevino@webkit.org

3 edits in trunk/WebCore

Reviewed by Kevin Ollivier.

Use the CGFont metrics APIs for more accurate measurements, and tweak the y
value the text is drawn at (it was a couple pixels off before because wx
internally adds to the y value.

https://bugs.webkit.org/show_bug.cgi?id=21853

5:09 PM Changeset in webkit [37876] by eric@webkit.org

2 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.

Get rid of a bonus ASSERT when using a null string as a regexp.
Specifically calling: RegularExpression::match() with String::empty()
will hit this ASSERT.
Chromium hits this, but I don't know of any way to make a layout test.

pcre/pcre_exec.cpp: (jsRegExpExecute):

4:46 PM Changeset in webkit [37875] by eric@webkit.org

9 edits
2 adds
1 delete in trunk

Reviewed by Sam Weinig.

Generate missing constructors and add test to prevent missing ones in the future
https://bugs.webkit.org/show_bug.cgi?id=21846

fast/dom/wrapper-classes-expected.txt results were incorrectly platform-specific
that test used to be platform-dependent, but isn't anymore

fast/dom/Window/window-properties-expected.txt:
fast/dom/wrapper-classes-expected.txt:
fast/js/global-constructors.html: Added.
fast/js/resources/global-constructors.js: Added.
platform/mac/fast/dom/wrapper-classes-expected.txt: Removed.

4:39 PM Changeset in webkit [37874] by ap@webkit.org

3 edits
3 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=21836
REGRESSION: Sign-in on Fancast.com causes crash in Webkit nightly

Test: http/tests/xmlhttprequest/detaching-frame.html

xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::dropProtection): Null check the window - even though XHR needs a context (AKA frame) to be serviced, the frame may be disconnected when dispatching the same callback that results in this function being called.

4:07 PM Changeset in webkit [37873] by andersca@apple.com

2 edits in trunk/WebKitTools

2008-10-24 Anders Carlsson <andersca@apple.com>

Try fixing the 64-bit build.

DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: (testGetProperty):

4:06 PM Changeset in webkit [37872] by andersca@apple.com

2 edits in trunk/WebKit/mac

2008-10-24 Anders Carlsson <andersca@apple.com>

Fix Tiger build.

WebView/WebUIDelegate.h:

4:04 PM Changeset in webkit [37871] by ddkilzer@apple.com

2 edits in trunk/WebCore

Gtk build fix.

platform/gtk/TemporaryLinkStubs.cpp: (WebCore::setFocusRingColorChangeFunction): Removed in r37858.

3:20 PM Changeset in webkit [37870] by mrowe@apple.com

2 edits in trunk/WebCore

<rdar://problem/6164952> Use constant kCGInterpolationMedium in GraphicsContextCG.cpp rather than hard-coded values.

Reviewed by Sam Weinig.

3:16 PM Changeset in webkit [37869] by andersca@apple.com

19 edits
2 adds in trunk

WebCore:

2008-10-24 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/5440917> Support NPN_Construct

WebCore.NPAPI.exp: Export _NPN_Construct.

bridge/NP_jsobject.cpp: (_NPN_Construct): Implement this.

bridge/c/c_instance.cpp: (JSC::Bindings::CInstance::supportsConstruct): (JSC::Bindings::CInstance::invokeConstruct): Have this call the appropriate NPClass method.

bridge/npruntime.h: Add NPN_Construct.

bridge/npruntime_impl.h: Add _NPN_Construct.

bridge/runtime.h: (JSC::Bindings::Instance::supportsConstruct): (JSC::Bindings::Instance::invokeConstruct): New methods.

bridge/runtime_object.cpp: (JSC::callRuntimeConstructor): Call the native instance.

(JSC::RuntimeObjectImp::getConstructData):
Implement this.

bridge/runtime_object.h: Add new method declarations.

plugins/gtk/PluginPackageGtk.cpp: (WebCore::PluginPackage::load):
plugins/qt/PluginPackageQt.cpp: (WebCore::PluginPackage::load):
plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::load): Initialize m_pluginFuncs.construct.

WebKit/mac:

2008-10-24 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/5440917> Support NPN_Construct

Set construct.

Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]):

WebKitTools:

2008-10-24 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/5440917> Support NPN_Construct

DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (testCallback): Fix a memory leak.

(testConstruct):
New test method that treats it first argument as a constructor and invokes it with the rest of the arguments.

(pluginInvoke):
Handle testConstruct.

DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: (testGetProperty): Add objectPointer property.

(testEnumerate):
Only enumerate the two first properties.

(testConstruct):
Add a simple construct implementation that just returns the test object.

LayoutTests:

2008-10-24 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/5440917> Support NPN_Construct

Add testcase.

plugins/netscape-construct-expected.txt: Added.
plugins/netscape-construct.html: Added.

3:16 PM Changeset in webkit [37868] by ap@webkit.org

2 edits in trunk/JavaScriptCore

Suggested and rubber-stamped by Geoff Garen.

Fix a crash when opening Font Picker.

The change also hopefully fixes this bug, which I could never reproduce:
https://bugs.webkit.org/show_bug.cgi?id=20241
<rdar://problem/6290576> Safari crashes at JSValueUnprotect() when fontpicker view close

API/JSContextRef.cpp: (JSContextGetGlobalObject): Use lexical global object instead of dynamic one.

3:09 PM Changeset in webkit [37867] by adele@apple.com

3 edits in trunk/WebCore

2008-10-24 Adele Peterson <adele@apple.com>

Build fix.

platform/FileChooser.h: (WebCore::FileChooserClient::~FileChooserClient):
platform/graphics/mac/IconMac.mm: (WebCore::Icon::newIconForFiles):

2:51 PM Changeset in webkit [37866] by ddkilzer@apple.com

2 edits in trunk/WebCore

2008-10-24 Greg Bolsinga <bolsinga@apple.com>

Fix GTK build break.

Reviewed by David Kilzer.

GNUmakefile.am: Do not include .idl files whose generated files should not be compiled.

2:46 PM Changeset in webkit [37865] by ddkilzer@apple.com

2 edits in trunk/WebCore

Wx build fix.

platform/wx/TemporaryLinkStubs.cpp: (WebCore::setFocusRingColorChangeFunction): Removed in r37858.

2:44 PM Changeset in webkit [37864] by mrowe@apple.com

2 edits in trunk/WebKit/mac

<rdar://problem/6119711> Remove the dependency on Foundation's private COCOA_FORMAL_PROTOCOLS define.

Rubber-stamped by Tim Hatcher.

2:12 PM Changeset in webkit [37863] by adele@apple.com

23 edits
6 adds in trunk

WebCore:

2008-10-24 Adele Peterson <adele@apple.com>

Reviewed by Sam Weinig.

WebCore part of fix for <rdar://problem/5839256> FILE CONTROL: multi-file upload.

This change adds support for multiple file selection in an <input type="file"> control when the "multiple" attribute is used.
This is consistent with the direction HTML5 will be going in the future.

The initial implementation here will show "n files" as the text next to the control when multiple files are selected. You can view
the individual files in a tooltip for now. Improvements to this control will come later.

Web developers will be able to access the FileList from the HTMLInputElement element, where they can get a base name and a size for each file.
These FileList Files can also be sent in an XMLHTTPRequest.

manual-tests/post-multi-file-upload.html: Added.
manual-tests/resources/multiFileResources: Added.
manual-tests/resources/multiFileResources/post-echo-and-notify-done.cgi: Added.
manual-tests/resources/multiFileResources/testFile1.html: Added.
manual-tests/resources/multiFileResources/testFile2.html: Added.
manual-tests/resources/multiFileResources/testFile3.html: Added.

WebCore.base.exp: Added support to export the new "chooseFilenames" method to be used in WebKit.

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute): Add support for the multiple attribute. (WebCore::HTMLInputElement::value): Added comments. The HTML5 spec says that value shouldn't apply for the file upload control, but we don't want to break the behavior for existing websites that may rely on this. (WebCore::HTMLInputElement::setValue): ditto. (WebCore::HTMLInputElement::setValueFromRenderer): This is no longer used for file upload controls. setFileListFromRenderer is used instead. (WebCore::HTMLInputElement::setFileListFromRenderer): Added.
html/HTMLInputElement.h:

page/Chrome.cpp: (WebCore::Chrome::setToolTip): Show a tooltip with the file name list for the multi-file upload control.

page/DragController.cpp: (WebCore::DragController::concludeDrag): Updated to support multiple files.

platform/FileChooser.cpp: Add support for maintaining a list of file paths that can be retrieved by the renderer. (WebCore::FileChooser::FileChooser): (WebCore::FileChooser::create): (WebCore::FileChooser::clear): (WebCore::FileChooser::chooseFile): (WebCore::FileChooser::chooseFiles): (WebCore::FileChooser::chooseIcon):
platform/FileChooser.h: (WebCore::FileChooser::filePaths): (WebCore::FileChooser::allowsMultipleFiles):

platform/graphics/Icon.h:
platform/graphics/mac/IconMac.mm: (WebCore::Icon::newIconForFiles): Returns a generic icon for multiple files.
platform/graphics/gtk/IconGtk.cpp: (WebCore::Icon::newIconForFiles): stubbed out.
platform/graphics/qt/IconQt.cpp: (WebCore::Icon::newIconForFiles): ditto.
platform/graphics/win/IconWin.cpp: (WebCore::Icon::newIconForFiles): ditto.

platform/gtk/FileChooserGtk.cpp: (WebCore::FileChooser::basenameForWidth): Updated to deal with new filenames vector.
platform/mac/FileChooserMac.mm: (WebCore::FileChooser::basenameForWidth): ditto.
platform/qt/FileChooserQt.cpp: (WebCore::FileChooser::openFileChooser): (WebCore::FileChooser::basenameForWidth):
platform/win/FileChooserWin.cpp: (WebCore::FileChooser::basenameForWidth):

platform/network/mac/FormDataStreamMac.mm: (WebCore::disassociateStreamWithResourceHandle): Removed unnecessary assertion. This can get hit when connectionDidFinishLoading and cancel both get called for the same ResourceHandle. This getting called twice has no negative effect.

rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::valueChanged): Calls setFileListFromRenderer. (WebCore::RenderFileUploadControl::allowsMultipleFiles): Added. (WebCore::RenderFileUploadControl::updateFromElement): Uses the new filenames call from FileChooser. (WebCore::RenderFileUploadControl::receiveDroppedFiles): Updated to support multiple files.
rendering/RenderFileUploadControl.h:

WebKit/mac:

2008-10-24 Adele Peterson <adele@apple.com>

Reviewed by Sam Weinig.

WebKit part of fix for <rdar://problem/5839256> FILE CONTROL: multi-file upload.

WebCoreSupport/WebChromeClient.mm: (WebChromeClient::runOpenPanel): (-[WebOpenPanelResultListener chooseFilenames:]):
WebView/WebUIDelegate.h:

2:09 PM Changeset in webkit [37862] by Adam Roben

2 edits in trunk/WebKit/cf

Windows build fix

WebCoreSupport/WebInspectorClientCF.cpp: Define WTF_PLATFORM_CF manually. Normally this gets defined on Windows by including config.h, but Mac has no config.h for WebKit, so we can't do that here.

2:07 PM Changeset in webkit [37861] by cwzwarich@webkit.org

3 edits in trunk/JavaScriptCore

2008-10-24 Cameron Zwarich <zwarich@apple.com>

Reviewed by Geoff Garen.

Remove ScopeChainNode::bottom() and inline it into its only caller,
ScopeChainnode::globalObject().

kjs/JSGlobalObject.h: (JSC::ScopeChainNode::globalObject):
kjs/ScopeChain.h: (JSC::ScopeChain::bottom):

1:54 PM Changeset in webkit [37860] by ddkilzer@apple.com

2 edits in trunk/WebKit/wx

Build fix.

Reviewed by Greg Bolsinga.

WebKitSupport/InspectorClientWx.cpp: (WebCore::InspectorClientWx::populateSetting): Changed

InspectorClient: to InspectorClientWx::. (WebCore::InspectorClientWx::storeSetting): Ditto. (WebCore::InspectorClientWx::removeSetting): Ditto.

1:44 PM Changeset in webkit [37859] by cwzwarich@webkit.org

3 edits in trunk/JavaScriptCore

2008-10-24 Cameron Zwarich <zwarich@apple.com>

Reviewed by Maciej Stachowiak.

Bug 21862: Create JSFunction prototype property lazily
<https://bugs.webkit.org/show_bug.cgi?id=21862>

This is a 1.5% speedup on SunSpider and a 1.4% speedup on the V8
benchmark suite, including a 3.8% speedup on Earley-Boyer.

kjs/JSFunction.cpp: (JSC::JSFunction::getOwnPropertySlot):
kjs/nodes.cpp: (JSC::FuncDeclNode::makeFunction): (JSC::FuncExprNode::makeFunction):

1:43 PM Changeset in webkit [37858] by pkasting@chromium.org

6 edits in trunk/WebCore

2008-10-23 Peter Kasting <pkasting@google.com>

Reviewed by David Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=21844
Remove setFocusRingColorChangeFunction.

page/Page.cpp: (WebCore::Page::Page):
platform/graphics/Color.h:
platform/graphics/mac/ColorMac.mm: (WebCore::focusRingColor):
platform/graphics/qt/GraphicsContextQt.cpp:
platform/graphics/win/ColorSafari.cpp:

1:32 PM Changeset in webkit [37857] by ddkilzer@apple.com

2 edits in trunk/WebCore

Build fix for Qt.

Reviewed by Greg.

WebCore.pro: Added missing *.idl files.

1:27 PM Changeset in webkit [37856] by timothy@apple.com

1 edit in trunk/WebKit/cf/WebCoreSupport/WebInspectorClientCF.cpp

Fix the Windows build.

1:23 PM Changeset in webkit [37855] by Simon Fraser

2 edits in trunk/LayoutTests

2008-10-24 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig

Add to the comment some new CSSRule types that are not yet tested.

fast/dom/wrapper-classes.html:

1:10 PM Changeset in webkit [37854] by ddkilzer@apple.com

20 edits
24 adds in trunk

JavaScriptCore:

2008-10-24 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=21475

Provide support for the Geolocation API

http://dev.w3.org/geo/api/spec-source.html

wtf/Platform.h: ENABLE_GEOLOCATION defaults to 0

WebCore:

2008-10-24 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=21475

Provide support for the Geolocation API

http://dev.w3.org/geo/api/spec-source.html

Test: geolocation/geolocation-not-implemented.html

DerivedSources.make:
GNUmakefile.am: Added Geolocation support
WebCore.pro: Added Geolocation support
WebCore.vcproj/WebCore.vcproj: Added Geolocation support
WebCore.xcodeproj/project.pbxproj: Added Geolocation support
WebCoreSources.bkl: Added Geolocation support
bindings/js/JSCustomPositionCallback.cpp: Added. (WebCore::JSCustomPositionCallback::JSCustomPositionCallback): (WebCore::JSCustomPositionCallback::handleEvent):
bindings/js/JSCustomPositionCallback.h: Added. (WebCore::JSCustomPositionCallback::create):
bindings/js/JSCustomPositionErrorCallback.cpp: Added. (WebCore::JSCustomPositionErrorCallback::JSCustomPositionErrorCallback): (WebCore::JSCustomPositionErrorCallback::handleEvent):
bindings/js/JSCustomPositionErrorCallback.h: Added. (WebCore::JSCustomPositionErrorCallback::create):
bindings/js/JSDOMBinding.cpp: move markDOMObjectWrapper here from JSDOMWindowCustom (WebCore::markDOMObjectWrapper):
bindings/js/JSDOMBinding.h: move markDOMObjectWrapper here from JSDOMWindowCustom
bindings/js/JSDOMWindowCustom.cpp: move markDOMObjectWrapper to JSDOMBinding
bindings/js/JSGeolocationCustom.cpp: Added. (WebCore::JSGeolocation::getCurrentPosition): (WebCore::JSGeolocation::watchPosition):
bindings/js/JSNavigatorCustom.cpp: handle marking Geolocation (WebCore::JSNavigator::mark):
dom/Document.cpp: (WebCore::Document::Document):
dom/Document.h: (WebCore::Document::setUsingGeolocation): (WebCore::Document::usingGeolocation):
loader/FrameLoader.cpp: don't add to back forward cache if using Geolocation (WebCore::FrameLoader::canCachePage):
page/Geolocation.cpp: Added. (WebCore::Geolocation::GeoNotifier::GeoNotifier): (WebCore::Geolocation::GeoNotifier::timerFired): (WebCore::Geolocation::Geolocation): (WebCore::Geolocation::disconnectFrame): (WebCore::Geolocation::getCurrentPosition): (WebCore::Geolocation::watchPosition): (WebCore::Geolocation::clearWatch): (WebCore::Geolocation::stopUpdatingIfEmpty): (WebCore::Geolocation::sendErrorToOneShots): (WebCore::Geolocation::sendErrorToWatchers): (WebCore::Geolocation::sendPositionToOneShots): (WebCore::Geolocation::sendPositionToWatchers): (WebCore::Geolocation::handleError): (WebCore::Geolocation::geolocationServicePositionChanged): (WebCore::Geolocation::geolocationServiceErrorOccurred):
page/Geolocation.h: Added. (WebCore::Geolocation::create): (WebCore::Geolocation::~Geolocation): (WebCore::Geolocation::lastPosition): (WebCore::Geolocation::GeoNotifier::create):
page/Geolocation.idl: Added.
page/Geoposition.cpp: Added. (WebCore::Geoposition::toString):
page/Geoposition.h: Added. (WebCore::Geoposition::create): (WebCore::Geoposition::latitude): (WebCore::Geoposition::longitude): (WebCore::Geoposition::altitude): (WebCore::Geoposition::accuracy): (WebCore::Geoposition::altitudeAccuracy): (WebCore::Geoposition::heading): (WebCore::Geoposition::velocity): (WebCore::Geoposition::timestamp): (WebCore::Geoposition::Geoposition):
page/Geoposition.idl: Added.
page/Navigator.cpp: (WebCore::Navigator::disconnectFrame): disconnect Geolocation (WebCore::Navigator::geolocation): accessor for Geolocation
page/Navigator.h: (WebCore::Navigator::optionalGeolocation): accessor for Geolocation
page/Navigator.idl: accessor for Geolocation
page/PositionCallback.h: Added. (WebCore::PositionCallback::~PositionCallback):
page/PositionCallback.idl: Added.
page/PositionError.h: Added. (WebCore::PositionError::): (WebCore::PositionError::create): (WebCore::PositionError::code): (WebCore::PositionError::message): (WebCore::PositionError::PositionError):
page/PositionError.idl: Added.
page/PositionErrorCallback.h: Added. (WebCore::PositionErrorCallback::~PositionErrorCallback):
page/PositionErrorCallback.idl: Added.
page/PositionOptions.h: Added. (WebCore::PositionOptions::create): (WebCore::PositionOptions::enableHighAccuracy): (WebCore::PositionOptions::setEnableHighAccuracy): (WebCore::PositionOptions::timeout): (WebCore::PositionOptions::setTimeout): (WebCore::PositionOptions::PositionOptions):
page/PositionOptions.idl: Added.
platform/GeolocationService.cpp: Added. (WebCore::GeolocationService::GeolocationService): (WebCore::GeolocationService::positionChanged): (WebCore::GeolocationService::errorOccurred):
platform/GeolocationService.h: Added. (WebCore::GeolocationServiceClient::~GeolocationServiceClient): (WebCore::GeolocationServiceClient::geolocationServicePositionChanged): (WebCore::GeolocationServiceClient::geolocationServiceErrorOccurred): (WebCore::GeolocationService::~GeolocationService):

LayoutTests:

2008-10-24 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=21475

Provide support for the Geolocation API

http://dev.w3.org/geo/api/spec-source.html

Tests to verify Geolocation isn't implemented (so that it didn't leak into
WebCore for platforms that do not support it).

geolocation: Added.
geolocation/geolocation-not-implemented-expected.txt: Added.
geolocation/geolocation-not-implemented.html: Added.
geolocation/geolocation-test.js: Copied from LayoutTests/media/video-test.js. (reset): (hanged): (watchPositionAndEnd): (watchPosition._positionCallback): (watchPosition): (watchPositionTestAndEnd): (watchPositionAndFail): (watchPositionAndTest._positionCallback): (watchPositionAndTest): (getCurrentPositionAndEnd): (getCurrentPosition._positionCallback): (getCurrentPosition): (getCurrentPositionTestAndEnd): (getCurrentPositionAndFail): (getCurrentPositionAndTest._positionCallback): (getCurrentPositionAndTest): (endTest): (relativeURL):

12:59 PM Changeset in webkit [37853] by Simon Fraser

4 edits in trunk/LayoutTests

2008-10-24 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler

https://bugs.webkit.org/show_bug.cgi?id=21858

Add additional CSSRule types to the DOM-wrapper tests.

fast/dom/resources/wrapper-identity-base.js:
fast/dom/wrapper-identity-expected.txt:
platform/mac/fast/dom/objc-wrapper-identity-expected.txt:

12:32 PM Changeset in webkit [37852] by Simon Fraser

7 edits
1 add in trunk/WebCore

2008-10-24 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler

https://bugs.webkit.org/show_bug.cgi?id=21818

Add HashTraits for AtomicString so that AtomicString can be used as
the key for a HashMap or HashSet.

GNUmakefile.am: add AtomicStringHash.h
WebCore.vcproj/WebCore.vcproj: add AtomicStringHash.h
WebCore.xcodeproj/project.pbxproj: add AtomicStringHash.h
platform/text/AtomicString.h: (WebCore::AtomicString::AtomicString): (WebCore::AtomicString::isHashTableDeletedValue):

specialize DefaultHash for AtomicString to use AtomicStringHash

platform/text/AtomicStringHash.h: Added.
platform/text/StringImpl.cpp: (WebCore::StringImpl::StringImpl):

compute the hash up-front for the empty string

platform/text/StringImpl.h: (WebCore::StringImpl::existingHash):

method to get the hash without a test and branch, for callers like
AtomicStringHash who can guarantee that the hash has already been computed.

12:15 PM Changeset in webkit [37851] by Simon Fraser

2 edits in trunk/WebCore

2008-10-24 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig

https://bugs.webkit.org/show_bug.cgi?id=21857

Add WebKitCSSKeyframeRule and WebKitCSSKeyframesRule to the
switch in _wrapCSSRule.

bindings/objc/DOMCSS.mm: (+[DOMCSSRule _wrapCSSRule:WebCore::]):

12:14 PM Changeset in webkit [37850] by Adam Roben

2 edits in trunk/WebCore

Windows build fix

plugins/PluginView.cpp:

12:10 PM Changeset in webkit [37849] by mitz@apple.com

3 edits
4 adds in trunk

WebCore:

Reviewed by Sam Weinig.

fix https://bugs.webkit.org/show_bug.cgi?id=21851 <rdar://problem/6304151> REGRESSION (r36513): Crash when removing a widget with percent height

Test: fast/replaced/percent-height-in-anonymous-block-widget.html

rendering/RenderWidget.cpp: (WebCore::RenderWidget::destroy): Copied code added to RenderBox::destroy() in r36513 into this function.

LayoutTests:

Reviewed by Sam Weinig.

test for https://bugs.webkit.org/show_bug.cgi?id=21851 <rdar://problem/6304151> REGRESSION (r36513): Crash when removing a widget with percent height

fast/replaced/percent-height-in-anonymous-block-widget.html: Added.
platform/mac/fast/replaced/percent-height-in-anonymous-block-widget-expected.checksum: Added.
platform/mac/fast/replaced/percent-height-in-anonymous-block-widget-expected.png: Added.
platform/mac/fast/replaced/percent-height-in-anonymous-block-widget-expected.txt: Added.

11:49 AM Changeset in webkit [37848] by timothy@apple.com

22 edits
4 adds in trunk

Add a mechanism to store and retrieve preferences for the Web Inspector.

WebCore:

2008-10-24 Timothy Hatcher <timothy@apple.com>

Add a mechanism to ask the InspectorClient for key/value setting pairs.
These settings can be strings, numbers, booleans or string vectors. The
settings are also bridged to and from JavaScript.

https://bugs.webkit.org/show_bug.cgi?id=21856

Reviewed by Darin Adler.

WebCore.base.exp: Expose the String CFStringRef constructor.
inspector/InspectorClient.h: (WebCore::InspectorClient::populateSetting): Added, pure virtual. (WebCore::InspectorClient::storeSetting): Ditto. (WebCore::InspectorClient::removeSetting): Ditto.
inspector/InspectorController.cpp: (WebCore::setting): Calls InspectorController::setting and wraps the result in script types. (WebCore::setSetting): Calls InspectorController::setSetting after converting from script types. (WebCore::InspectorController::InspectorController): Increment a global static to track the number of live InspectorControllers. (WebCore::InspectorController::~InspectorController): Decrement the global static that tracks the number of live InspectorControllers. Delete the setting cache if there are no more live controllers. (WebCore::InspectorController::setting): Check the cache and return the setting from there, otherwise make a new Setting and ask the client to populate it. (WebCore::InspectorController::setSetting): Change the cache and ask the client to store it. (WebCore::InspectorController::windowScriptObjectAvailable): Add setting and setSetting to the InspectorController script class.
inspector/InspectorController.h: (WebCore::InspectorController::Setting::Setting): (WebCore::InspectorController::Setting::operator=): (WebCore::InspectorController::Setting::type): Return m_type. (WebCore::InspectorController::Setting::string): Return m_string. Assert the type is correct. (WebCore::InspectorController::Setting::stringVector): Return m_stringVector. Assert the type is correct. (WebCore::InspectorController::Setting::doubleValue): Return m_simpleContent.m_double. Assert the type is correct. (WebCore::InspectorController::Setting::integerValue): Return m_simpleContent.m_integer. Assert the type is correct. (WebCore::InspectorController::Setting::booleanValue): Return m_simpleContent.m_boolean. Assert the type is correct. (WebCore::InspectorController::Setting::set): Overloaded for each data type, sets the right field and the type.
loader/EmptyClients.h: (WebCore::EmptyInspectorClient::populateSetting): Added, empty method. (WebCore::EmptyInspectorClient::storeSetting): Ditto. (WebCore::EmptyInspectorClient::removeSetting): Ditto.

WebKit:

2008-10-24 Timothy Hatcher <timothy@apple.com>

Implement new InspectorClient methods to work with Settings.

https://bugs.webkit.org/show_bug.cgi?id=21856

Reviewed by Darin Adler.

WebKit.xcodeproj/project.pbxproj: Add the new InspectorClientCF.cpp file.

WebKit/gtk:

2008-10-24 Timothy Hatcher <timothy@apple.com>

Stub out new InspectorClient methods.

https://bugs.webkit.org/show_bug.cgi?id=21856

Reviewed by Darin Adler.

WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::populateSetting): Not implemented. (WebKit::InspectorClient::storeSetting): Ditto. (WebKit::InspectorClient::removeSetting): Ditto.
WebCoreSupport/InspectorClientGtk.h:

WebKit/mac:

2008-10-24 Timothy Hatcher <timothy@apple.com>

Implement new InspectorClient methods to work with Settings.

https://bugs.webkit.org/show_bug.cgi?id=21856

Reviewed by Darin Adler.

WebCoreSupport/WebInspectorClient.h: Add the new methods and guard the ObjC parts of the header.

WebKit/qt:

2008-10-24 Timothy Hatcher <timothy@apple.com>

Stub out new InspectorClient methods.

https://bugs.webkit.org/show_bug.cgi?id=21856

Reviewed by Darin Adler.

WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::populateSetting): Not implemented. (WebCore::InspectorClientQt::storeSetting): Ditto. (WebCore::InspectorClientQt::removeSetting): Ditto.
WebCoreSupport/InspectorClientQt.h:

WebKit/win:

2008-10-24 Timothy Hatcher <timothy@apple.com>

Implement new InspectorClient methods to work with Settings.

https://bugs.webkit.org/show_bug.cgi?id=21856

Reviewed by Adam Roben.

WebKit.vcproj/WebKit.vcproj: Add the new InspectorClientCF.cpp file.
WebCoreSupport/WebInspectorClient.h: Add the new methods.

WebKit/wx:

2008-10-24 Timothy Hatcher <timothy@apple.com>

Stub out new InspectorClient methods.

https://bugs.webkit.org/show_bug.cgi?id=21856

Reviewed by Darin Adler.

WebKitSupport/InspectorClientWx.cpp: (WebCore::InspectorClient::populateSetting): Not implemented. (WebCore::InspectorClient::storeSetting): Ditto. (WebCore::InspectorClient::removeSetting): Ditto.
WebKitSupport/InspectorClientWx.h:

11:19 AM Changeset in webkit [37847] by ddkilzer@apple.com

3 edits in trunk/WebKitTools

Bug 21850: svn-apply and svn-unapply should preserve patch line endings

<https://bugs.webkit.org/show_bug.cgi?id=21850>

Reviewed by Adam Roben.

Scripts/svn-apply: Save end-of-line characters when stripping them off each line of a patch so that they may be restored after processing the line.
Scripts/svn-unapply: Ditto.

11:10 AM Changeset in webkit [37846] by cwzwarich@webkit.org

2 edits in trunk/WebCore

2008-10-24 Cameron Zwarich <zwarich@apple.com>

Reviewed by Sam Weinig.

Remove some C-style casts.

html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::addViewSourceToken):

9:22 AM Changeset in webkit [37845] by Darin Adler

301 edits in trunk

JavaScriptCore: