Context Navigation

Stop discarding CodeBlock samples that can't be charged to a specific
opcode. Instead, charge the relevant CodeBlock, and provide a footnote
explaining the situation.

This will help us tell which CodeBlocks are hot, even if we can't
identify specific lines of code within the CodeBlocks.

VM/SamplingTool.cpp: (JSC::ScopeSampleRecord::sample): (JSC::compareScopeSampleRecords): (JSC::SamplingTool::dump):

VM/SamplingTool.h: (JSC::ScopeSampleRecord::ScopeSampleRecord): (JSC::ScopeSampleRecord::~ScopeSampleRecord):

7:21 PM Changeset in webkit [37918] by Antti Koivisto

1 edit
1 add in trunk/WebKitSite

2008-10-27 Antti Koivisto <Antti Koivisto>

Add a file.

blog-files/squirrelfish-link-animated.svg: Added.

6:40 PM Changeset in webkit [37917] by andersca@apple.com

1 edit in trunk/WebKit/mac/Plugins/WebBaseNetscapePluginStream.h

Whoops, did not mean to commit this.

6:39 PM Changeset in webkit [37916] by andersca@apple.com

3 edits in trunk/WebKit/mac

2008-10-27 Anders Carlsson <andersca@apple.com>

Reviewed by Maciej Stachowiak.

Use the C++ stream object for JS requests as well.

Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): (-[WebBaseNetscapePluginView destroyStream:reason:]):

6:31 PM Changeset in webkit [37915] by andersca@apple.com

4 edits in trunk/WebKit/mac

2008-10-27 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Use the C++ stream object in WebBaseNetscapePluginView. Use a HashSet of RefPtrs to keep track of the streams.

Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::~WebNetscapePluginStream): (WebNetscapePluginStream::setPlugin): (WebNetscapePluginStream::startStream): (WebNetscapePluginStream::destroyStream): (WebNetscapePluginStream::destroyStreamWithReason): (WebNetscapePluginStream::cancelLoadAndDestroyStreamWithError): (WebNetscapePluginStream::deliverData):
Plugins/WebBaseNetscapePluginView.h:
Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView stop]): (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]): (-[WebBaseNetscapePluginView disconnectStream:]): (-[WebBaseNetscapePluginView dealloc]): (-[WebBaseNetscapePluginView pluginView:receivedResponse:]): (-[WebBaseNetscapePluginView pluginView:receivedData:]): (-[WebBaseNetscapePluginView pluginView:receivedError:]): (-[WebBaseNetscapePluginView pluginViewFinishedLoading:]): (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):

6:07 PM Changeset in webkit [37914] by andersca@apple.com

3 edits in trunk/WebKit/mac

2008-10-27 Anders Carlsson <andersca@apple.com>

Reviewed by Mitz Pettel.

Move code from dealloc and finalize to the WebNetscapePluginStream destructor.

Plugins/WebBaseNetscapePluginStream.h:
Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::~WebNetscapePluginStream): (-[WebBaseNetscapePluginStream dealloc]): (-[WebBaseNetscapePluginStream finalize]):

6:01 PM Changeset in webkit [37913] by andersca@apple.com

4 edits in trunk/WebKit/mac

2008-10-27 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Get rid of WebNetscapePlugInStreamLoaderClient, the plug-in stream is its own client.

Plugins/WebBaseNetscapePluginStream.h:
Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::WebNetscapePluginStream): (-[WebBaseNetscapePluginStream dealloc]): (-[WebBaseNetscapePluginStream finalize]):
Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView pluginView:receivedError:]): (-[WebBaseNetscapePluginView pluginViewFinishedLoading:]): (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): (-[WebBaseNetscapePluginView destroyStream:reason:]):

5:43 PM Changeset in webkit [37912] by andersca@apple.com

3 edits in trunk/WebKit/mac

2008-10-27 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Change the Obj-C init methods to simply call WebNetscapePluginStream::create.

Plugins/WebBaseNetscapePluginStream.h: (WebNetscapePluginStream::create):
Plugins/WebBaseNetscapePluginStream.mm: (-[WebBaseNetscapePluginStream initWithFrameLoader:]): (WebNetscapePluginStream::WebNetscapePluginStream): (-[WebBaseNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]):

5:18 PM Changeset in webkit [37911] by andersca@apple.com

4 edits in trunk/WebKit/mac

2008-10-27 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Convert more code over to C++.

Plugins/WebBaseNetscapePluginStream.h: (WebNetscapePluginStream::plugin): (WebNetscapePluginStream::setRequestURL): Convert to C++.

Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::start): (WebNetscapePluginStream::stop): Ditto.

(WebNetscapePluginStream::startStreamWithResponse):
Ditto.

(-[WebBaseNetscapePluginStream startStreamWithResponse:]):
Call the C++ version.

(-[WebBaseNetscapePluginStream impl]):
New accessor for the C++ class.

Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView pluginView:receivedData:]): (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]): (-[WebBaseNetscapePluginView destroyStream:reason:]): Call the C++ methods.

4:48 PM Changeset in webkit [37910] by mrowe@apple.com

2 edits in branches/Safari-3-2-branch/WebCore

Merge r37628.

4:47 PM Changeset in webkit [37909] by mrowe@apple.com

2 edits in branches/Safari-3-2-branch/WebCore

Merge r37897.

4:25 PM Changeset in webkit [37908] by Antti Koivisto

1 edit
2 adds in trunk/WebKitSite

2008-10-27 Antti Koivisto <Antti Koivisto>

Add some svg files.

blog-files/cubes-7.svg: Added.
blog-files/number-morph.svg: Added.

3:57 PM Changeset in webkit [37907] by Darin Adler

2 edits in trunk/WebKit

2008-10-27 Darin Adler <Darin Adler>

StringsNotToBeLocalized.txt: Updated for recent changes.

3:15 PM Changeset in webkit [37906] by kevino@webkit.org

2 edits in trunk

Reviewed by Kevin Ollivier.

Update the active state as well as the focused state as both need to be true
for the caret to be drawn.

https://bugs.webkit.org/show_bug.cgi?id=21900

3:10 PM Changeset in webkit [37905] by Darin Adler

2 edits in trunk/BugsSite

2008-10-27 Darin Adler <Darin Adler>

template/en/custom/attachment/reviewform.html.tmpl: Leave out the comment if it's untouched.

3:07 PM Changeset in webkit [37904] by kevino@webkit.org

6 edits in trunk

wx build fix on Linux/GTK. Enable support for #include <JavaScriptCore/XYZ.h> style includes.

2:45 PM Changeset in webkit [37903] by jmalonzo@webkit.org

2 edits in trunk/WebKit/gtk

2008-10-27 Michael Tross <michael@tross.org>

Reviewed by Alp Toker. Landed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=21827
[GTK] Fix memory leak in webkit_web_view_load_string

webkit/webkitwebview.cpp:

2:20 PM Changeset in webkit [37902] by Darin Adler

13 edits in trunk/WebCore

2008-10-27 Michael Knaup <michael.knaup@mac.com>

Reviewed and tweaked by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=8988

Bug 8988: Add support for Mozilla CSS custom cursors.
Added -webkit-grab and -webkit-grabbing cursor suppport
for the Mac, dummy implementations for other platforms.

css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Updated since the -webkit-grabbing cursor is now the last one.

css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added CURSOR_WEBKIT_GRAB and CURSOR_WEBKIT_GRABBING.

css/CSSValueKeywords.in: Added -webkit-grab and -webkit-grabbing.

manual-tests/cursor.html: Added -webkit-zoom-in, webkit-zoom-out, -webkit-grab, and -webkit-grabbing.

page/EventHandler.cpp: (WebCore::EventHandler::selectCursor): Added CURSOR_WEBKIT_GRAB and CURSOR_WEBKIT_GRABBING.

platform/Cursor.h: Added grabCursor and grabbingCursor.

platform/gtk/CursorGtk.cpp: (WebCore::grabCursor): Added. (WebCore::grabbingCursor): Added.
platform/mac/CursorMac.mm: (WebCore::grabCursor): Added. (WebCore::grabbingCursor): Added.
platform/qt/CursorQt.cpp: (WebCore::grabCursor): Added. (WebCore::grabbingCursor): Added.
platform/win/CursorWin.cpp: (WebCore::grabCursor): Added. (WebCore::grabbingCursor): Added.
platform/wx/CursorWx.cpp: (WebCore::grabCursor): Added. (WebCore::grabbingCursor): Added.

rendering/style/RenderStyleConstants.h: Added CURSOR_WEBKIT_GRAB and CURSOR_WEBKIT_GRABBING. Also broke ECursor out into a single constant per line. Also added a couple of comments.

1:37 PM Changeset in webkit [37901] by ggaren@apple.com

3 edits in trunk/JavaScriptCore

2008-10-27 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Added a mutex around the SamplingTool's ScopeNode* map, to solve a crash
when sampling the v8 tests.

VM/SamplingTool.cpp: (JSC::SamplingTool::run): (JSC::SamplingTool::notifyOfScope):
VM/SamplingTool.h: Since new ScopeNodes can be created after the SamplingTools has begun sampling, reads and writes to / from the map need to be synchronized. Shark says this doesn't measurably increase sampling overhead.

1:07 PM Changeset in webkit [37900] by eric@webkit.org

2 edits in trunk/WebCore

2008-10-27 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

svg/SVGAnimatedTemplate.h: needed a HashMap define

12:49 PM Changeset in webkit [37899] by eric@webkit.org

3 edits
2 adds in trunk

Reviewed by Dave Hyatt.

Infinite recursion crash in WebCore::RenderSVGRoot::absoluteClippedOverflowRect on a <stop> element outside of a gradient block
https://bugs.webkit.org/show_bug.cgi?id=20400

Test: svg/custom/stop-crash.svg

WebCore.xcodeproj/project.pbxproj:
rendering/RenderSVGGradientStop.h: (WebCore::RenderSVGGradientStop::absoluteClippedOverflowRect):

11:55 AM Changeset in webkit [37898] by andersca@apple.com

2 edits in trunk/WebCore

2008-10-27 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

No need to call release if the connection is null.

platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start):

11:52 AM Changeset in webkit [37897] by andersca@apple.com

2 edits in trunk/WebCore

2008-10-27 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

<rdar://problem/6322650> Crash in fast/loader/simultaneous-reloads-assert.html

Make sure to null check the NSURLConnection object.

platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::setDefersLoading):

1:53 AM Changeset in webkit [37896] by ap@webkit.org

5 edits in trunk/WebCore

Fix non-Mac builds.

GNUmakefile.am:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCoreSources.bkl: Renamed JSHTMLOptionElementConstructor to JSOptionConstructor.

12:59 AM Changeset in webkit [37895] by ap@webkit.org

10 edits
2 moves
2 adds in trunk

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=21886
window.HTMLOptionElement == "[object HTMLElementConstructor]" instead of HTMLOptionElementConstructor

Test: fast/dom/HTMLOptionElement/option-prototype.html

We now have separate objects for window.Option and window.HTMLOptionElement - the latter
"constructor" cannot be used to construct anything. This matches Firefox behavior.

WebCore.xcodeproj/project.pbxproj:
bindings/js/JSDOMWindowBase.cpp: (jsDOMWindowBaseOption):
bindings/js/JSHTMLOptionElementConstructor.cpp: Removed.
bindings/js/JSHTMLOptionElementConstructor.h: Removed.
bindings/js/JSOptionConstructor.cpp: Copied from WebCore/bindings/js/JSHTMLOptionElementConstructor.cpp.
bindings/js/JSOptionConstructor.h: Copied from WebCore/bindings/js/JSHTMLOptionElementConstructor.h.
html/HTMLOptionElement.idl: Renamed JSHTMLOptionElementConstructor to JSOptionConstructor.

html/HTMLOptionElement.idl: Generate a constructor.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed