Context Navigation

← Previous Period
Next Period →

Timeline

Nov 1, 2008:

2:31 AM Changeset in webkit [38065] by abarth@webkit.org

6 edits
6 adds in trunk

WebCore:

2008-11-01 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

Be sure to check the final URLs of requested resources to make sure we
don't get fooled by HTTP redirects.

https://bugs.webkit.org/show_bug.cgi?id=21963

Tests: http/tests/security/xss-DENIED-xsl-document-redirect.xml

http/tests/security/xss-DENIED-xsl-external-entity-redirect.xml

dom/XMLTokenizerLibxml2.cpp: (WebCore::openFunc):
loader/DocLoader.cpp: (WebCore::DocLoader::canRequest): (WebCore::DocLoader::requestResource):
loader/DocLoader.h:
xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc):

LayoutTests:

2008-11-01 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

Test that we properly block non-same-origin redirects for these
esoteric loads.

https://bugs.webkit.org/show_bug.cgi?id=21963

http/tests/security/resources/xsl-using-document-redirect.xsl: Added.
http/tests/security/resources/xsl-using-external-entity-redirect.xsl: Added.
http/tests/security/xss-DENIED-xsl-document-redirect-expected.txt: Copied from LayoutTests/http/tests/security/xss-DENIED-xsl-document-expected.txt.
http/tests/security/xss-DENIED-xsl-document-redirect.xml: Added.
http/tests/security/xss-DENIED-xsl-external-entity-redirect-expected.txt: Copied from LayoutTests/http/tests/security/xss-DENIED-xsl-external-entity-expected.txt.
http/tests/security/xss-DENIED-xsl-external-entity-redirect.xml: Added.

12:21 AM Changeset in webkit [38064] by ap@webkit.org

10 edits
2 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=22001
AtomicStringImpl* keys of event listener maps can outlive their strings

Test: fast/events/destroyed-atomic-string.html

dom/MessagePort.cpp: (WebCore::MessagePort::addEventListener): (WebCore::MessagePort::removeEventListener): (WebCore::MessagePort::dispatchEvent):
dom/MessagePort.h:
loader/appcache/DOMApplicationCache.cpp: (WebCore::DOMApplicationCache::addEventListener): (WebCore::DOMApplicationCache::removeEventListener): (WebCore::DOMApplicationCache::dispatchEvent):
loader/appcache/DOMApplicationCache.h:
xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::addEventListener): (WebCore::XMLHttpRequest::removeEventListener): (WebCore::XMLHttpRequest::dispatchEvent):
xml/XMLHttpRequest.h:
xml/XMLHttpRequestUpload.cpp: (WebCore::XMLHttpRequestUpload::addEventListener): (WebCore::XMLHttpRequestUpload::removeEventListener): (WebCore::XMLHttpRequestUpload::dispatchEvent):
xml/XMLHttpRequestUpload.h: Changed EventListenersMap to use AtomicString as key (instead of AtomicStringImpl*).

12:11 AM Changeset in webkit [38063] by ap@webkit.org

22 edits in trunk/WebCore

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=21998
Use JSDOMGlobalObject in EventListener-related bindings

dom/MessagePort.idl: Auto-generate bindings for onclose and onmessage.

bindings/scripts/CodeGeneratorJS.pm: Use JSDOMGlobalObject instead of JSDOMWindow in JS bindings for inline event handlers.

bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::addEventListener): (WebCore::JSDOMApplicationCache::removeEventListener):
bindings/js/JSEventTargetNodeCustom.cpp: (WebCore::JSEventTargetNode::addEventListener): (WebCore::JSEventTargetNode::removeEventListener):
bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::removeEventListener):
bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::addEventListener): (WebCore::JSSVGElementInstance::removeEventListener):
bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::addEventListener): (WebCore::JSXMLHttpRequest::removeEventListener):
bindings/js/JSXMLHttpRequestUploadCustom.cpp: (WebCore::JSXMLHttpRequestUpload::addEventListener): (WebCore::JSXMLHttpRequestUpload::removeEventListener): Use ScriptExecutionContext and JSDOMGlobalObject in bindings.

dom/EventTarget.h:
dom/EventTargetNode.cpp: (WebCore::EventTargetNode::scriptExecutionContext):
dom/EventTargetNode.h:
dom/MessagePort.cpp:
dom/MessagePort.h: (WebCore::MessagePort::scriptExecutionContext):
loader/appcache/DOMApplicationCache.cpp: (WebCore::DOMApplicationCache::scriptExecutionContext):
loader/appcache/DOMApplicationCache.h:
svg/SVGElementInstance.cpp: (WebCore::SVGElementInstance::scriptExecutionContext):
svg/SVGElementInstance.h:
xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::scriptExecutionContext):
xml/XMLHttpRequest.h:
xml/XMLHttpRequestUpload.cpp: (WebCore::XMLHttpRequestUpload::scriptExecutionContext):
xml/XMLHttpRequestUpload.h: Remove associatedFrame() method, and provide scriptExecutionContext() where it wasn't available yet.

Oct 31, 2008:

9:28 PM Changeset in webkit [38062] by Stephanie Lewis

2 edits in trunk/JavaScriptGlue

2008-10-31 Stephanie Lewis <Stephanie Lewis>

Fix build by including right files.

JSRun.cpp:

6:05 PM Changeset in webkit [38061] by cwzwarich@webkit.org

13 edits
2 moves in trunk

2008-10-31 Cameron Zwarich <zwarich@apple.com>

Rubber-stamped by Geoff Garen.

Rename SourceRange.h to SourceCode.h.

JavaScriptCore:

API/JSBase.cpp:
GNUmakefile.am:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
VM/CodeBlock.h:
kjs/SourceCode.h: Copied from kjs/SourceRange.h.
kjs/SourceRange.h: Removed.
kjs/grammar.y:
kjs/lexer.h:
kjs/nodes.cpp: (JSC::ForInNode::ForInNode):
kjs/nodes.h: (JSC::ThrowableExpressionData::setExceptionSourceCode):

WebCore:

ForwardingHeaders/kjs/SourceCode.h: Copied from ForwardingHeaders/kjs/SourceRange.h.
ForwardingHeaders/kjs/SourceRange.h: Removed.
bindings/js/StringSourceProvider.h:
bridge/NP_jsobject.cpp:

5:35 PM Changeset in webkit [38060] by cwzwarich@webkit.org

10 edits in trunk

2008-10-31 Cameron Zwarich <zwarich@apple.com>

Reviewed by Darin Adler.

Bug 22019: Move JSC::Interpreter::shouldPrintExceptions() to WebCore::Console
<https://bugs.webkit.org/show_bug.cgi?id=22019>

The JSC::Interpreter::shouldPrintExceptions() function is not used at
all in JavaScriptCore, so it should be moved to WebCore::Console, its
only user.

JavaScriptCore:

JavaScriptCore.exp:
kjs/interpreter.cpp:
kjs/interpreter.h:

WebCore:

WebCore.base.exp:
page/Console.cpp: (WebCore::printToStandardOut): (WebCore::Console::shouldPrintExceptions): (WebCore::Console::setShouldPrintExceptions):
page/Console.h:

WebKit/mac:

Misc/WebCoreStatistics.mm: (+[WebCoreStatistics shouldPrintExceptions]): (+[WebCoreStatistics setShouldPrintExceptions:]):

5:26 PM Changeset in webkit [38059] by christian@webkit.org

2 edits in trunk/WebKit/gtk

Reviewed by Mark Rowe.

http://bugs.webkit.org/show_bug.cgi?id=22018
enable-developer-extras doesn't toggle WebInspector

webkit/webkitwebview.cpp:

Add missing 'if' in notification for 'enable-developer-extras'.

4:35 PM Changeset in webkit [38058] by mitz@apple.com

12 edits in trunk

WebCore:

Reviewed by John Sullivan.

WebCore part of <rdar://problem/6334641> Add WebView SPI for disabling document.cookie

dom/Document.cpp: (WebCore::Document::cookie): Added checking if cookies are disabled. (WebCore::Document::setCookie): Ditto.
page/Navigator.cpp: (WebCore::Navigator::cookieEnabled): Ditto.
page/Page.cpp: (WebCore::Page::Page): Initialize m_cookieEnabled to true.
page/Page.h: (WebCore::Page::cookieEnabled): Added. (WebCore::Page::setCookieEnabled): Added.

WebKit/mac:

Reviewed by John Sullivan.

WebKit/mac part of <rdar://problem/6334641> Add WebView SPI for disabling document.cookie

WebView/WebView.mm: (-[WebView _cookieEnabled]): (-[WebView _setCookieEnabled:]):
WebView/WebViewPrivate.h:

WebKit/win:

Reviewed by John Sullivan.

WebKit/win part of <rdar://problem/6334641> Add WebView SPI for disabling document.cookie

Interfaces/IWebViewPrivate.idl:
WebView.cpp: (WebView::setCookieEnabled): (WebView::cookieEnabled):
WebView.h:

4:25 PM Changeset in webkit [38057] by adele@apple.com

11 edits in trunk

WebCore:

2008-10-31 Adele Peterson <adele@apple.com>

Reviewed by Darin Adler.

WebCore Windows part of fix for <rdar://problem/5839256> FILE CONTROL: multi-file upload.
https://bugs.webkit.org/show_bug.cgi?id=22008

platform/FileChooser.cpp: (WebCore::FileChooser::chooseIcon): Rename newIconForFile and newIconForFiles to createIconForFile and createIconForFiles.
platform/graphics/Icon.h: ditto.
platform/graphics/gtk/IconGtk.cpp: (WebCore::Icon::createIconForFile): ditto. (WebCore::Icon::createIconForFiles): ditto.
platform/graphics/mac/IconMac.mm: (WebCore::Icon::createIconForFile): ditto. (WebCore::Icon::createIconForFiles): ditto.
platform/graphics/qt/IconQt.cpp: (WebCore::Icon::createIconForFile): ditto. (WebCore::Icon::createIconForFiles): ditto.
platform/wx/TemporaryLinkStubs.cpp: (Icon::createIconForFile): ditto. (Icon::createIconForFiles): ditto.
platform/graphics/win/IconWin.cpp: (WebCore::Icon::createIconForFile): ditto. (WebCore::Icon::createIconForFiles): Add creation of an icon for multiple files.

rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::paintSearchFieldResultsDecoration): Improve icon creation code to match new code in Icon::createIconForFiles

WebKit/win:

2008-10-31 Adele Peterson <adele@apple.com>

Reviewed by Darin Adler.

WebKit Windows part of fix for <rdar://problem/5839256> FILE CONTROL: multi-file upload.
https://bugs.webkit.org/show_bug.cgi?id=22008

WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::runOpenPanel): Add support for mulitple file selection.

3:56 PM Changeset in webkit [38056] by andersca@apple.com

2 edits in trunk/WebKit

2008-10-31 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Move WebNetscapePluginEventHandler classes to a subgroup of Netscape Plug-Ins.

WebKit.xcodeproj/project.pbxproj:

3:26 PM Changeset in webkit [38055] by cwzwarich@webkit.org

2 edits in trunk/JavaScriptCore

2008-10-31 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Windows build fix.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

3:18 PM Changeset in webkit [38054] by cwzwarich@webkit.org

2 edits in trunk/JavaScriptCore

2008-10-31 Cameron Zwarich <zwarich@apple.com>

Rubber-stamped by Sam Weinig.

Remove the call to Interpreter::setShouldPrintExceptions() from the
GlobalObject constructor in the shell. The shouldPrintExceptions()
information is not used anywhere in JavaScriptCore, only in WebCore.

kjs/Shell.cpp: (GlobalObject::GlobalObject):

2:59 PM Changeset in webkit [38053] by kevino@webkit.org

4 edits in trunk

A couple wxMSW build fixes.

2:40 PM Changeset in webkit [38052] by cwzwarich@webkit.org

6 edits
7 moves in trunk/JavaScriptCore

2008-10-31 Cameron Zwarich <zwarich@apple.com>

Rubber-stamped by Sam Weinig.

Move more files from the kjs subdirectory of JavaScriptCore to the
runtime subdirectory.

GNUmakefile.am:
JavaScriptCore.pri:
JavaScriptCore.xcodeproj/project.pbxproj:
JavaScriptCoreSources.bkl:
kjs/AllInOneFile.cpp:
kjs/RegExpConstructor.cpp: Removed.
kjs/RegExpConstructor.h: Removed.
kjs/RegExpMatchesArray.h: Removed.
kjs/RegExpObject.cpp: Removed.
kjs/RegExpObject.h: Removed.
kjs/RegExpPrototype.cpp: Removed.
kjs/RegExpPrototype.h: Removed.
runtime/RegExpConstructor.cpp: Copied from kjs/RegExpConstructor.cpp.
runtime/RegExpConstructor.h: Copied from kjs/RegExpConstructor.h.
runtime/RegExpMatchesArray.h: Copied from kjs/RegExpMatchesArray.h.
runtime/RegExpObject.cpp: Copied from kjs/RegExpObject.cpp.
runtime/RegExpObject.h: Copied from kjs/RegExpObject.h.
runtime/RegExpPrototype.cpp: Copied from kjs/RegExpPrototype.cpp.
runtime/RegExpPrototype.h: Copied from kjs/RegExpPrototype.h.

2:19 PM Changeset in webkit [38051] by mrowe@apple.com

2 edits in trunk/JavaScriptCore

Revert an incorrect portion of r38034.

profiler/ProfilerServer.mm:

2:19 PM Changeset in webkit [38050] by mrowe@apple.com

2 edits in trunk/JavaScriptCore

Fix the 64-bit build.

Disable strict aliasing in ProfilerServer.mm as it leads to the compiler being unhappy
with the common Obj-C idiom self = [super init];

JavaScriptCore.xcodeproj/project.pbxproj:

1:47 PM Changeset in webkit [38049] by cwzwarich@webkit.org

2 edits in trunk/WebKitTools

2008-10-31 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Scripts/do-webcore-rename:

Add some renames to contemplate for the future.

1:44 PM Changeset in webkit [38048] by cwzwarich@webkit.org

2 edits in trunk/JavaScriptCore

2008-10-31 Cameron Zwarich <zwarich@apple.com>

Reviewed by Alexey Proskuryakov.

Change a header guard to match our coding style.

kjs/InitializeThreading.h:

12:59 PM Changeset in webkit [38047] by ggaren@apple.com

14 edits
1 add
2 deletes in trunk/JavaScriptCore

2008-10-30 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Fixed a small bit of https://bugs.webkit.org/show_bug.cgi?id=21962
AST uses way too much memory

Removed a word from StatementNode by nixing LabelStack and turning it
into a compile-time data structure managed by CodeGenerator.

v8 tests and SunSpider, run by Gavin, report no change.

GNUmakefile.am:
JavaScriptCore.order:
JavaScriptCore.pri:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
kjs/AllInOneFile.cpp:
JavaScriptCoreSources.bkl: I sure hope this builds!

VM/CodeGenerator.cpp: (JSC::CodeGenerator::CodeGenerator): (JSC::CodeGenerator::newLabelScope): (JSC::CodeGenerator::breakTarget): (JSC::CodeGenerator::continueTarget):
VM/CodeGenerator.h: Nixed the JumpContext system because it depended on a LabelStack in the AST, and it was a little cumbersome on the client side. Replaced with LabelScope, which tracks all break / continue information in the CodeGenerator, just like we track LabelIDs and other stacks of compile-time data.

kjs/LabelScope.h: Added. (JSC::LabelScope::): (JSC::LabelScope::LabelScope): (JSC::LabelScope::ref): (JSC::LabelScope::deref): (JSC::LabelScope::refCount): (JSC::LabelScope::breakTarget): (JSC::LabelScope::continueTarget): (JSC::LabelScope::type): (JSC::LabelScope::name): (JSC::LabelScope::scopeDepth): Simple abstraction for holding everything you might want to know about a break-able / continue-able scope.

kjs/LabelStack.cpp: Removed.
kjs/LabelStack.h: Removed.

kjs/grammar.y: No need to push labels at parse time -- we don't store LabelStacks in the AST anymore.

kjs/nodes.cpp: (JSC::DoWhileNode::emitCode): (JSC::WhileNode::emitCode): (JSC::ForNode::emitCode): (JSC::ForInNode::emitCode): (JSC::ContinueNode::emitCode): (JSC::BreakNode::emitCode): (JSC::SwitchNode::emitCode): (JSC::LabelNode::emitCode):
kjs/nodes.h: (JSC::StatementNode::): (JSC::LabelNode::): Use LabelScope where we used to use JumpContext. Simplified a bunch of code. Touched up label-related error messages a bit.

kjs/nodes2string.cpp: (JSC::LabelNode::streamTo): Updated for rename.

12:53 PM Changeset in webkit [38046] by cwzwarich@webkit.org

8 edits
2 copies in trunk/JavaScriptCore

2008-10-31 Cameron Zwarich <zwarich@apple.com>

Reviewed by Darin Adler.

Bug 22005: Move StructureIDChain into its own file
<https://bugs.webkit.org/show_bug.cgi?id=22005>

GNUmakefile.am:
JavaScriptCore.pri:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
JavaScriptCoreSources.bkl:
runtime/StructureID.cpp:
runtime/StructureID.h:
runtime/StructureIDChain.cpp: Copied from runtime/StructureID.cpp.
runtime/StructureIDChain.h: Copied from runtime/StructureID.h.

12:53 PM Changeset in webkit [38045] by Darin Adler

2 edits in trunk/WebKitTools

2008-10-31 Darin Adler <Darin Adler>

Requested by Mark Rowe.

Scripts/check-for-global-initializers: s/Web Kit/WebKit/.

12:44 PM Changeset in webkit [38044] by sfalken@apple.com

2 edits in trunk/JavaScriptCore

2008-10-31 Steve Falkenburg <sfalken@apple.com>

Build fix.

JavaScriptCore.vcproj/jsc/jsc.vcproj:

12:35 PM Changeset in webkit [38043] by beidson@apple.com

1 edit in trunk/WebKit/mac/ChangeLog

Expand that name!

12:34 PM Changeset in webkit [38042] by beidson@apple.com

2 edits in trunk/WebKit/mac

2008-10-31 Brady Eidson <beidson@apple.com>

Reviewed by Darin

[WebHistory setLastVisitedTimeInterval:forItem] was internal to WebHistory.mm and
completely unused. Nuke it!

History/WebHistory.mm:

11:53 AM Changeset in webkit [38041] by sfalken@apple.com

2 edits in trunk/JavaScriptCore

2008-10-31 Steve Falkenburg <sfalken@apple.com>

Build fix.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

11:49 AM Changeset in webkit [38040] by timothy@apple.com

3 edits
2 adds in trunk

Emit the WillExecuteStatement debugger hook before the for loop body when the statement node for the body isn't a block. This allows breakpoints on those statements in the Web Inspector.

JavaScriptCore:

2008-10-31 Timothy Hatcher <timothy@apple.com>

Emit the WillExecuteStatement debugger hook before the for loop body
when the statement node for the body isn't a block. This allows
breakpoints on those statements in the Web Inspector.

https://bugs.webkit.org/show_bug.cgi?id=22004

Reviewed by Darin Adler.

kjs/nodes.cpp: (JSC::ForNode::emitCode): Emit the WillExecuteStatement debugger hook before the statement node if isn't a block. Also emit the WillExecuteStatement debugger hook for the loop as the first op-code. (JSC::ForInNode::emitCode): Ditto.

WebCore:

2008-10-31 Timothy Hatcher <timothy@apple.com>

Add manual tests that check breakpoints on a blockless body of "for" loops.

https://bugs.webkit.org/show_bug.cgi?id=22004

Reviewed by Darin Adler.

manual-tests/inspector/debugger-pause-on-for-in-statements.html: Added.
manual-tests/inspector/debugger-pause-on-for-statements.html: Added.

11:45 AM Changeset in webkit [38039] by Darin Adler

2 edits in trunk/WebCore

2008-10-31 Darin Adler <Darin Adler>

fix build

platform/win/WCDataObject.cpp: Added missing include of "config.h".

11:08 AM Changeset in webkit [38038] by ddkilzer@apple.com

2 edits in trunk/WebKitTools

Bug 21997: prepare-ChangeLog should filter out ChangeLog files

<https://bugs.webkit.org/show_bug.cgi?id=21997>

Reviewed by Darin Adler.

Scripts/prepare-ChangeLog: (generateFileList): Don't add ChangeLog files to %{$functionLists}. This prevents them from showing up in the new ChangeLog entry. They were already excluded from @{$changedFiles}.

10:59 AM Changeset in webkit [38037] by Darin Adler

2 edits in trunk/JavaScriptCore

2008-10-31 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

fix storage leak seen on buildbot

Some other cleanup too. The storage leak was caused by the fact
that HashTraits<CallIdentifier>::needsDestruction was false, so
the call identifier objects didn't get deleted.

profiler/CallIdentifier.h:

Added a default constructor to create empty call identifiers.

Changed the normal constructor to use const UString&
to avoid extra copying and reference count thrash.

Removed the explicit copy constructor definition, since it's what
the compiler will automatically generate. (Rule of thumb: Either
you need both a custom copy constructor and a custom assignment
operator, or neither.)

Moved the CallIdentifier hash function out of the WTF namespace;
there's no reason to put it there.

Changed the CallIdentifier hash function to be a struct rather than
a specialization of the IntHash struct template. Having it be
a specialization made no sense, since CallIdentifier is not an integer,
and did no good.

Removed explicit definition of emptyValueIsZero in the hash traits,
since inheriting from GenericHashTraits already makes that false.

Removed explicit definition of emptyValue, instead relying on the
default constructor and GenericHashTraits.

Removed explicit definition of needsDestruction, because we want it
to have its default value: true, not false. This fixes the leak!

Changed constructDeletedValue and isDeletedValue to use a line number
of numeric_limits<unsigned>::max() to indicate a value is deleted.
Previously this used empty strings for the empty value and null strings
for the deleted value, but it's more efficient to use null for both.

10:56 AM Changeset in webkit [38036] by Darin Adler

2 edits in trunk/WebKit/win

2008-10-31 Darin Adler <Darin Adler>

try to fix build

WebView.cpp: (WebView::setCacheModel): Roll out the part of my last change that involved no longer using wkCopyFoundationCacheDirectory.

10:15 AM Changeset in webkit [38035] by Chris Fleizach

2 edits in trunk/WebKit/mac

Bug 22002: AX: scroll bars show should not appear in AX hierarchy when WebFrameView does not allow scrolling
https://bugs.webkit.org/show_bug.cgi?id=22002

3:17 AM Changeset in webkit [38034] by timothy@apple.com

2 edits in trunk/JavaScriptCore

Fixes console warnings about not having an autorelease pool.
Also fixes the build for Snow Leopard, by including individual
Foundation headers instead of Foundation.h.

https://bugs.webkit.org/show_bug.cgi?id=21995

Reviewed by Oliver Hunt.

profiler/ProfilerServer.mm: (-[ProfilerServer init]): Create a NSAutoreleasePool and drain it.

2:44 AM Changeset in webkit [38033] by ap@webkit.org

11 edits in trunk/WebCore

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=21970
Make MessagePort event dispatch work in workers

bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::JSDOMGlobalObjectData::JSDOMGlobalObjectData): (WebCore::JSDOMGlobalObject::~JSDOMGlobalObject): (WebCore::JSDOMGlobalObject::findJSEventListener): (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener): (WebCore::JSDOMGlobalObject::findJSUnprotectedEventListener): (WebCore::JSDOMGlobalObject::findOrCreateJSUnprotectedEventListener): (WebCore::JSDOMGlobalObject::jsEventListeners): (WebCore::JSDOMGlobalObject::jsInlineEventListeners): (WebCore::JSDOMGlobalObject::jsUnprotectedEventListeners): (WebCore::JSDOMGlobalObject::jsUnprotectedInlineEventListeners): (WebCore::JSDOMGlobalObject::setCurrentEvent): (WebCore::JSDOMGlobalObject::currentEvent): (WebCore::toJSDOMGlobalObject):
bindings/js/JSDOMGlobalObject.h:
bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::JSDOMWindowBaseData::JSDOMWindowBaseData): (WebCore::JSDOMWindowBase::~JSDOMWindowBase): (WebCore::JSDOMWindowBase::clearHelperObjectProperties):
bindings/js/JSDOMWindowBase.h: Moved event listener tracking from JSDOMWindow to JSDOMGlobalObject.

bindings/js/JSEventListener.cpp: (WebCore::JSAbstractEventListener::handleEvent): (WebCore::JSUnprotectedEventListener::JSUnprotectedEventListener): (WebCore::JSUnprotectedEventListener::~JSUnprotectedEventListener): (WebCore::JSUnprotectedEventListener::globalObject): (WebCore::JSUnprotectedEventListener::clearGlobalObject): (WebCore::JSEventListener::JSEventListener): (WebCore::JSEventListener::~JSEventListener): (WebCore::JSEventListener::globalObject): (WebCore::JSEventListener::clearGlobalObject): (WebCore::JSLazyEventListener::JSLazyEventListener): (WebCore::JSLazyEventListener::parseCode):
bindings/js/JSEventListener.h: (WebCore::JSUnprotectedEventListener::create): (WebCore::JSEventListener::create): (WebCore::JSLazyEventListener::create): Changed to use JSDOMGlobalObject and ScriptExecutionContext.

bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::startConversation): (WebCore::JSMessagePort::addEventListener): (WebCore::JSMessagePort::removeEventListener): (WebCore::JSMessagePort::setOnmessage): (WebCore::JSMessagePort::setOnclose): Updated bindings to work with JSDOMGlobalObject. Next step is to make code generator emit such code, and stop using a custom implementation for JSMessagePort inline event handler getters and setters.

dom/Document.cpp: (WebCore::Document::virtualURL):
dom/Document.h:
dom/ScriptExecutionContext.h: Expose url() method on ScriptExecutionContext (necessary for compiling scripts in JSLazyEventListener).

1:18 AM Changeset in webkit [38032] by cwzwarich@webkit.org