Timeline

Nov 2, 2008:

1:14 PM Changeset in webkit [38068] by pewtermoose@webkit.org

• 2 edits in trunk/JavaScriptCore

2008-11-02 Matt Lilek <​webkit@mattlilek.com>

Reviewed by Cameron Zwarich.

Bug 22042: REGRESSION(r38066): ASSERTION FAILED: source in CodeBlock
<​https://bugs.webkit.org/show_bug.cgi?id=22042>

Rename parameter name to avoid ASSERT.

• VM/CodeBlock.h: (JSC::CodeBlock::CodeBlock): (JSC::ProgramCodeBlock::ProgramCodeBlock): (JSC::EvalCodeBlock::EvalCodeBlock):

12:23 PM Changeset in webkit [38067] by christian@webkit.org

• 4 edits in trunk

2008-11-02 Xan Lopez <​xan@gnome.org>

Reviewed by Holger Freyther

​https://bugs.webkit.org/show_bug.cgi?id=22009
HTML5 Video with GStreamer pulls gnome-vfs without using it.

• configure.ac: Remove gnome-vfs from configure.ac, it's unused.

3:29 AM Changeset in webkit [38066] by cwzwarich@webkit.org

• 4 edits in trunk/JavaScriptCore

2008-11-02 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Oliver Hunt.

Bug 22035: Remove the '_' suffix on constructor parameter names for structs
<​https://bugs.webkit.org/show_bug.cgi?id=22035>

• API/JSCallbackObject.h: (JSC::JSCallbackObject::JSCallbackObjectData::JSCallbackObjectData):
• VM/CodeBlock.h: (JSC::CodeBlock::CodeBlock): (JSC::ProgramCodeBlock::ProgramCodeBlock): (JSC::EvalCodeBlock::EvalCodeBlock):
• wrec/WREC.h: (JSC::Quantifier::Quantifier):

Nov 1, 2008:

2:31 AM Changeset in webkit [38065] by abarth@webkit.org

• 6 edits
  6 adds in trunk

WebCore:

2008-11-01 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

Be sure to check the final URLs of requested resources to make sure we
don't get fooled by HTTP redirects.

​https://bugs.webkit.org/show_bug.cgi?id=21963

Tests: http/tests/security/xss-DENIED-xsl-document-redirect.xml

http/tests/security/xss-DENIED-xsl-external-entity-redirect.xml

• dom/XMLTokenizerLibxml2.cpp: (WebCore::openFunc):
• loader/DocLoader.cpp: (WebCore::DocLoader::canRequest): (WebCore::DocLoader::requestResource):
• loader/DocLoader.h:
• xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc):

LayoutTests:

2008-11-01 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

Test that we properly block non-same-origin redirects for these
esoteric loads.

​https://bugs.webkit.org/show_bug.cgi?id=21963

• http/tests/security/resources/xsl-using-document-redirect.xsl: Added.
• http/tests/security/resources/xsl-using-external-entity-redirect.xsl: Added.
• http/tests/security/xss-DENIED-xsl-document-redirect-expected.txt: Copied from LayoutTests/http/tests/security/xss-DENIED-xsl-document-expected.txt.
• http/tests/security/xss-DENIED-xsl-document-redirect.xml: Added.
• http/tests/security/xss-DENIED-xsl-external-entity-redirect-expected.txt: Copied from LayoutTests/http/tests/security/xss-DENIED-xsl-external-entity-expected.txt.
• http/tests/security/xss-DENIED-xsl-external-entity-redirect.xml: Added.

12:21 AM Changeset in webkit [38064] by ap@webkit.org

• 10 edits
  2 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=22001
AtomicStringImpl* keys of event listener maps can outlive their strings

Test: fast/events/destroyed-atomic-string.html

• dom/MessagePort.cpp: (WebCore::MessagePort::addEventListener): (WebCore::MessagePort::removeEventListener): (WebCore::MessagePort::dispatchEvent):
• dom/MessagePort.h:
• loader/appcache/DOMApplicationCache.cpp: (WebCore::DOMApplicationCache::addEventListener): (WebCore::DOMApplicationCache::removeEventListener): (WebCore::DOMApplicationCache::dispatchEvent):
• loader/appcache/DOMApplicationCache.h:
• xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::addEventListener): (WebCore::XMLHttpRequest::removeEventListener): (WebCore::XMLHttpRequest::dispatchEvent):
• xml/XMLHttpRequest.h:
• xml/XMLHttpRequestUpload.cpp: (WebCore::XMLHttpRequestUpload::addEventListener): (WebCore::XMLHttpRequestUpload::removeEventListener): (WebCore::XMLHttpRequestUpload::dispatchEvent):
• xml/XMLHttpRequestUpload.h: Changed EventListenersMap to use AtomicString as key (instead of AtomicStringImpl*).

12:11 AM Changeset in webkit [38063] by ap@webkit.org

• 22 edits in trunk/WebCore

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=21998
Use JSDOMGlobalObject in EventListener-related bindings

• dom/MessagePort.idl: Auto-generate bindings for onclose and onmessage.

• bindings/scripts/CodeGeneratorJS.pm: Use JSDOMGlobalObject instead of JSDOMWindow in JS bindings for inline event handlers.

• bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::addEventListener): (WebCore::JSDOMApplicationCache::removeEventListener):
• bindings/js/JSEventTargetNodeCustom.cpp: (WebCore::JSEventTargetNode::addEventListener): (WebCore::JSEventTargetNode::removeEventListener):
• bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::removeEventListener):
• bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::addEventListener): (WebCore::JSSVGElementInstance::removeEventListener):
• bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::addEventListener): (WebCore::JSXMLHttpRequest::removeEventListener):
• bindings/js/JSXMLHttpRequestUploadCustom.cpp: (WebCore::JSXMLHttpRequestUpload::addEventListener): (WebCore::JSXMLHttpRequestUpload::removeEventListener): Use ScriptExecutionContext and JSDOMGlobalObject in bindings.

• dom/EventTarget.h:
• dom/EventTargetNode.cpp: (WebCore::EventTargetNode::scriptExecutionContext):
• dom/EventTargetNode.h:
• dom/MessagePort.cpp:
• dom/MessagePort.h: (WebCore::MessagePort::scriptExecutionContext):
• loader/appcache/DOMApplicationCache.cpp: (WebCore::DOMApplicationCache::scriptExecutionContext):
• loader/appcache/DOMApplicationCache.h:
• svg/SVGElementInstance.cpp: (WebCore::SVGElementInstance::scriptExecutionContext):
• svg/SVGElementInstance.h:
• xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::scriptExecutionContext):
• xml/XMLHttpRequest.h:
• xml/XMLHttpRequestUpload.cpp: (WebCore::XMLHttpRequestUpload::scriptExecutionContext):
• xml/XMLHttpRequestUpload.h: Remove associatedFrame() method, and provide scriptExecutionContext() where it wasn't available yet.