⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 7, 2008:

2:29 PM Changeset in webkit [38232] by alp@webkit.org
  • 8 edits in trunk/WebCore

2008-11-07 Alp Toker <alp@nuanti.com>

Fix build with bleeding edge GTK+ versions. GTK+ and other libraries
now require that only their top-level header file is included.

Patch tested and still builds fine with older GTK+ versions (back to
2.8).

Future WebKit GTK+ contributions are required to adhere to this
policy.

  • platform/gtk/FileSystemGtk.cpp:
  • platform/gtk/KeyEventGtk.cpp:
  • platform/gtk/MouseEventGtk.cpp:
  • platform/gtk/WheelEventGtk.cpp:
  • platform/gtk/gtkdrawing.h:
  • plugins/gtk/gtk2xtbin.c:
  • plugins/gtk/gtk2xtbin.h:
1:34 PM Changeset in webkit [38231] by andersca@apple.com
  • 2 edits in trunk/WebCore

2008-11-07 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker

Explicitly initialize the NPDrawingModelCoreAnimation.

  • bridge/npapi.h:
1:15 PM Changeset in webkit [38230] by cwzwarich@webkit.org
  • 3 edits
    3 adds in trunk

2008-11-07 Cameron Zwarich <zwarich@apple.com>

Reviewed by Geoff Garen.

Bug 21801: REGRESSION (r37821): YUI date formatting JavaScript puts the letter 'd' in place of the day
<https://bugs.webkit.org/show_bug.cgi?id=21801>

Fix the constant register check in the 'typeof' optimization in
CodeGenerator, which was completely broken after r37821.

JavaScriptCore:

  • bytecompiler/CodeGenerator.cpp: (JSC::CodeGenerator::emitEqualityOp):

LayoutTests:

  • fast/js/resources/typeof-constant-string.js: Added.
  • fast/js/typeof-constant-string-expected.txt: Added.
  • fast/js/typeof-constant-string.html: Added.
12:41 PM Changeset in webkit [38229] by cwzwarich@webkit.org
  • 4 edits in trunk/JavaScriptCore

2008-11-07 Cameron Zwarich <zwarich@apple.com>

Reviewed by Geoff Garen.

Bug 22129: Move CTI::isConstant() to CodeBlock
<https://bugs.webkit.org/show_bug.cgi?id=22129>

  • VM/CTI.cpp: (JSC::CTI::emitGetArg): (JSC::CTI::emitGetPutArg): (JSC::CTI::getConstantImmediateNumericArg): (JSC::CTI::printOpcodeOperandTypes): (JSC::CTI::privateCompileMainPass):
  • VM/CTI.h:
  • VM/CodeBlock.h: (JSC::CodeBlock::isConstant):
11:35 AM Changeset in webkit [38228] by alp@webkit.org
  • 4 edits in trunk

2008-11-07 Alp Toker <alp@nuanti.com>

autotools fix. Always use the configured perl binary (which may be
different to the one in $PATH) when generating sources.

11:17 AM Changeset in webkit [38227] by Simon Fraser
  • 8 edits in trunk/WebCore

2008-11-07 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein

https://bugs.webkit.org/show_bug.cgi?id=22122

Use a stack-based object to simplify the pushLayoutState/popLayoutState
code. LayoutStateMaintainer either pushes in the constructor, or allows
an explicit push() later. Both cases require an explicit pop().

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::layoutOnlyPositionedObjects):
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::layout):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::layout):
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::layout):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::setCellWidths): (WebCore::RenderTableSection::calcRowHeight): (WebCore::RenderTableSection::layoutRows):
  • rendering/RenderView.h: (WebCore::LayoutStateMaintainer::LayoutStateMaintainer): (WebCore::LayoutStateMaintainer::~LayoutStateMaintainer): (WebCore::LayoutStateMaintainer::pop): (WebCore::LayoutStateMaintainer::push): (WebCore::LayoutStateMaintainer::didPush):
10:07 AM Changeset in webkit [38226] by cwzwarich@webkit.org
  • 4 edits in trunk/JavaScriptCore

2008-11-07 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Change grammar.cpp to Grammar.cpp and grammar.h to Grammar.h in several
build scripts.

  • DerivedSources.make:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCoreSources.bkl:
9:48 AM Changeset in webkit [38225] by alp@webkit.org
  • 3 edits in trunk/JavaScriptCore

2008-11-07 Alp Toker <alp@nuanti.com>

More grammar.cpp -> Grammar.cpp build fixes.

  • AllInOneFile.cpp:
  • GNUmakefile.am:
7:39 AM Changeset in webkit [38224] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2008-11-07 Tor Arne Vestbø <tavestbo@trolltech.com>

Fix the QtWebKit build on Mac

7:01 AM Changeset in webkit [38223] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2008-11-07 Tor Arne Vestbø <tavestbo@trolltech.com>

Rubber-stamped by Simon Hausmann.

Don't allow Phonon's invisible video widget to keep the app running

6:47 AM Changeset in webkit [38222] by vestbo@webkit.org
  • 3 edits in trunk/WebKit/qt

2008-11-07 Ariya Hidayat <ariya.hidayat@trolltech.com>

Reviewed by Tor Arne Vestbø and Simon Hausmann.

Added an option to allow printing the background color and images.
Mostly reworked from a patch by Holger.
This setting is enabled by default.

  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): (QWebSettings::QWebSettings):
  • Api/qwebsettings.h:
6:11 AM Changeset in webkit [38221] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2008-11-07 Simon Hausmann <Simon Hausmann>

Fix the build on case-sensitive file systems. grammar.y was renamed to
Grammar.y but Lexer.cpp includes grammar.h. The build bots didn't
notice this change because of stale files.

3:32 AM Changeset in webkit [38220] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-11-07 Henrik Hartz <henrik.hartz@nokia.com>

Reviewed by Simon Hausmann.

Fix valgrind warning about uninitialized lastStop variable.

1:22 AM Changeset in webkit [38219] by cwzwarich@webkit.org
  • 3 edits in trunk/JavaScriptCore

2008-11-07 Cameron Zwarich <zwarich@apple.com>

Reviewed by Alexey Proskuryakov.

Rename the m_nextGlobal, m_nextParameter, and m_nextConstant member
variables of CodeGenerator to m_nextGlobalIndex, m_nextParameterIndex,
and m_nextConstantIndex respectively. This is to distinguish these from
member variables like m_lastConstant, which are actually RefPtrs to
Registers.

  • bytecompiler/CodeGenerator.cpp: (JSC::CodeGenerator::addGlobalVar): (JSC::CodeGenerator::allocateConstants): (JSC::CodeGenerator::CodeGenerator): (JSC::CodeGenerator::addParameter): (JSC::CodeGenerator::addConstant):
  • bytecompiler/CodeGenerator.h:
1:22 AM Changeset in webkit [38218] by ap@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Maciej Stachowiak.

Fix layout test brokenness following r38211.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleAccessKey): Restore old Shift key behavior. We ignore Shift key state when matching access keys (which matches neither IE nor Firefox), and this patch made WebKit behave like Firefox inadvertently. This may or may not be a good thing, but it's certainly not something that should change by accident.
1:20 AM Applications using WebKit edited by barbarosa100@hotmail.com
Added DVDpedia, Bookpedia, CDpedia and Gamepedia as apps that use WebKit (diff)
12:59 AM Changeset in webkit [38217] by zecke@webkit.org
  • 2 edits in trunk/LayoutTests

2008-11-07 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=22039

Enable text only and succeeding fast tests for the gtk port

Enable the tests from the fast directory that succeed. Classify the
remaining tests from the fast directory.

  • platform/gtk/Skipped:
12:53 AM Changeset in webkit [38216] by zecke@webkit.org
  • 2 edits in trunk/LayoutTests

2008-11-07 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=22039

Skip every test on the Gtk+ platform

Add every test directory to the Skipped list in order to create
a baseline for the Gtk+ port.

  • platform/gtk/Skipped:

Nov 6, 2008:

11:41 PM Changeset in webkit [38215] by cwzwarich@webkit.org
  • 2 edits in trunk

2008-11-06 Cameron Zwarich <zwarich@apple.com>

Reviewed by Geoff Garen.

Move the remaining files in the kjs subdirectory of JavaScriptCore to
a new parser subdirectory, and remove the kjs subdirectory entirely.

JavaScriptCore:

  • AllInOneFile.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore.vcproj/jsc/jsc.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • VM/CodeBlock.h:
  • VM/ExceptionHelpers.cpp:
  • VM/SamplingTool.h:
  • bytecompiler/CodeGenerator.h:
  • jsc.pro:
  • jscore.bkl:
  • kjs: Removed.
  • kjs/NodeInfo.h: Removed.
  • kjs/Parser.cpp: Removed.
  • kjs/Parser.h: Removed.
  • kjs/ResultType.h: Removed.
  • kjs/SourceCode.h: Removed.
  • kjs/SourceProvider.h: Removed.
  • kjs/grammar.y: Removed.
  • kjs/keywords.table: Removed.
  • kjs/lexer.cpp: Removed.
  • kjs/lexer.h: Removed.
  • kjs/nodes.cpp: Removed.
  • kjs/nodes.h: Removed.
  • kjs/nodes2string.cpp: Removed.
  • parser: Added.
  • parser/Grammar.y: Copied from kjs/grammar.y.
  • parser/Keywords.table: Copied from kjs/keywords.table.
  • parser/Lexer.cpp: Copied from kjs/lexer.cpp.
  • parser/Lexer.h: Copied from kjs/lexer.h.
  • parser/NodeInfo.h: Copied from kjs/NodeInfo.h.
  • parser/Nodes.cpp: Copied from kjs/nodes.cpp.
  • parser/Nodes.h: Copied from kjs/nodes.h.
  • parser/Parser.cpp: Copied from kjs/Parser.cpp.
  • parser/Parser.h: Copied from kjs/Parser.h.
  • parser/ResultType.h: Copied from kjs/ResultType.h.
  • parser/SourceCode.h: Copied from kjs/SourceCode.h.
  • parser/SourceProvider.h: Copied from kjs/SourceProvider.h.
  • parser/nodes2string.cpp: Copied from kjs/nodes2string.cpp.
  • pcre/pcre.pri:
  • pcre/pcre_exec.cpp:
  • runtime/FunctionConstructor.cpp:
  • runtime/JSActivation.h:
  • runtime/JSFunction.h:
  • runtime/JSGlobalData.cpp:
  • runtime/JSGlobalObjectFunctions.cpp:
  • runtime/JSObject.cpp: (JSC::JSObject::toNumber):
  • runtime/RegExp.cpp:

WebCore:

  • ForwardingHeaders/kjs: Removed.
  • ForwardingHeaders/kjs/Parser.h: Removed.
  • ForwardingHeaders/kjs/SavedBuiltins.h: Removed.
  • ForwardingHeaders/kjs/SourceCode.h: Removed.
  • ForwardingHeaders/kjs/SourceProvider.h: Removed.
  • ForwardingHeaders/parser: Added.
  • ForwardingHeaders/parser/Parser.h: Copied from ForwardingHeaders/kjs/Parser.h.
  • ForwardingHeaders/parser/SourceCode.h: Copied from ForwardingHeaders/kjs/SourceCode.h.
  • ForwardingHeaders/parser/SourceProvider.h: Copied from ForwardingHeaders/kjs/SourceProvider.h.
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • bindings/js/StringSourceProvider.h:
  • bindings/js/WorkerScriptController.cpp:
  • bridge/NP_jsobject.cpp:
  • bridge/jni/jni_jsobject.mm:
  • bridge/testbindings.pro:
  • inspector/JavaScriptDebugServer.cpp:

WebKit/mac:

  • ForwardingHeaders/kjs: Removed.
  • ForwardingHeaders/kjs/SavedBuiltins.h: Removed.
11:26 PM Changeset in webkit [38214] by Antti Koivisto
  • 2 edits in trunk/WebCore

2008-11-06 Antti Koivisto <Antti Koivisto>

Eh, this trivial last minute change was wrong.

  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::sheetText):
11:22 PM Changeset in webkit [38213] by Antti Koivisto
  • 3 edits in trunk/WebCore

2008-11-06 Antti Koivisto <Antti Koivisto>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=22093


Delaying the text decoding caused regression since the decoding
also determines the encoding in case of @charset rule.


Decode immediately in data() and keep the decoded string around
during the checkNotify().

  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::sheetText): (WebCore::CachedCSSStyleSheet::data):
  • loader/CachedCSSStyleSheet.h:
9:54 PM Changeset in webkit [38212] by ap@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=22097
Expose MessageEvent constructor on WorkerContext

  • bindings/js/JSWorkerContext.cpp: (WebCore::jsWorkerContextMessageEvent): (WebCore::setJSWorkerContextMessageEvent):
9:52 PM Changeset in webkit [38211] by ap@webkit.org
  • 8 edits in trunk/WebCore

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=21107
<rdar://problem/6264219> New access key combination conflicts with VoiceOver

  • page/EventHandler.h:
  • page/gtk/EventHandlerGtk.cpp: (WebCore::EventHandler::accessKeyModifiers):
  • page/qt/EventHandlerQt.cpp: (WebCore::EventHandler::accessKeyModifiers):
  • page/win/EventHandlerWin.cpp: (WebCore::EventHandler::accessKeyModifiers):
  • page/wx/EventHandlerWx.cpp: (WebCore::EventHandler::accessKeyModifiers): Access access key modifiers via a function, not a static variable.
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::accessKeyModifiers): Use Ctrl when VoiceOver is enabled, because a conflict with Emacs-style key bindings is less troublesome than one with VO keys.
  • page/EventHandler.cpp: (WebCore::EventHandler::handleAccessKey): Also fix an access key matching bug introduced in r32424 - Any superset of specified modifier set invoked access keys. We can use simple equality comparison instead because CapsLock is not part of modifiers(), so it doesn't need to be ignored explicitly.
8:04 PM Changeset in webkit [38210] by andersca@apple.com
  • 4 edits in trunk

WebCore:

2008-11-06 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

https://bugs.webkit.org/show_bug.cgi?id=22115
NPN_HasPropertyUPP and NPN_HasMethodUPP entries in NPNetscapeFuncs are NULL

Export _NPN_HasMethod and _NPN_HasProperty.


  • WebCore.NPAPI.exp:

WebKit/mac:

2008-11-06 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

https://bugs.webkit.org/show_bug.cgi?id=22115
NPN_HasPropertyUPP and NPN_HasMethodUPP entries in NPNetscapeFuncs are NULL


Initialize the browser funcs correctly.


  • Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]):
5:30 PM Changeset in webkit [38209] by barraclough@apple.com
  • 6 edits in trunk/JavaScriptCore

2008-11-06 Gavin Barraclough barraclough@apple.com

Reviewed by Oliver Hunt.

Do not make a cti_* call to perform an op_call unless either:
(1) The codeblock for the function body has not been generated.
(2) The number of arguments passed does not match the callee arity.

~1% progression on sunspider --v8

  • VM/CTI.cpp: (JSC::CTI::compileOpCallInitializeCallFrame): (JSC::CTI::compileOpCall): (JSC::CTI::privateCompileSlowCases):
  • VM/CTI.h:
  • VM/Machine.cpp: (JSC::Machine::cti_op_call_JSFunction): (JSC::Machine::cti_op_call_arityCheck): (JSC::Machine::cti_op_construct_JSConstruct):
  • VM/Machine.h:
  • kjs/nodes.h:
5:11 PM Changeset in webkit [38208] by Simon Fraser
  • 2 edits in trunk/WebCore

2008-11-06 Simon Fraser <Simon Fraser>

Reviewed by Antti Koivisto

https://bugs.webkit.org/show_bug.cgi?id=15678

Fix transformed menu selects to show the popup in the correct
location.

  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::showPopup):
4:55 PM Changeset in webkit [38207] by ddkilzer@apple.com
  • 83 edits in trunk

BUILD FIX: Backed out r38189 (and r38203) for Xcode 3.0.

WebCore:

BUILD FIX: Backed out r38189 (and r38203) for Xcode 3.0.

Apparently older versions of gcc have issues with this patch.
Backing out a second time until the issues are resolved.

WebKit/mac:

BUILD FIX: Backed out r38189 (and r38203) for Xcode 3.0.

Apparently older versions of gcc have issues with this patch.
Backing out a second time until the issues are resolved.

WebKitTools:

BUILD FIX: Backed out r38189 (and r38203) for Xcode 3.0.

Apparently older versions of gcc have issues with this patch.
Backing out a second time until the issues are resolved.

4:47 PM Changeset in webkit [38206] by jchaffraix@webkit.org
  • 4 edits in trunk/WebCore

2008-11-06 Julien Chaffraix <jchaffraix@pleyo.com>

Reviewed by Maciej Stachowiak.

Bug 21106: .in format discussed changes
https://bugs.webkit.org/show_bug.cgi?id=21106

Include the namespace into the interfaceName.

  • dom/make_names.pl: Do not append the namespace when using the interfaceName.
  • html/HTMLTagNames.in: Added namespace prefix for custom interfaceName.
  • svg/svgtags.in: Ditto.
4:18 PM Changeset in webkit [38205] by cwzwarich@webkit.org
  • 35 edits
    16 copies
    2 adds
    3 deletes in trunk

2008-11-06 Cameron Zwarich <zwarich@apple.com>

Reviewed by Geoff Garen.

Move the remaining files in the kjs subdirectory of JavaScriptCore to
a new parser subdirectory, and remove the kjs subdirectory entirely.

JavaScriptCore:

  • AllInOneFile.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore.vcproj/jsc/jsc.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • VM/CodeBlock.h:
  • VM/ExceptionHelpers.cpp:
  • VM/SamplingTool.h:
  • bytecompiler/CodeGenerator.h:
  • jsc.pro:
  • jscore.bkl:
  • kjs: Removed.
  • kjs/NodeInfo.h: Removed.
  • kjs/Parser.cpp: Removed.
  • kjs/Parser.h: Removed.
  • kjs/ResultType.h: Removed.
  • kjs/SourceCode.h: Removed.
  • kjs/SourceProvider.h: Removed.
  • kjs/grammar.y: Removed.
  • kjs/keywords.table: Removed.
  • kjs/lexer.cpp: Removed.
  • kjs/lexer.h: Removed.
  • kjs/nodes.cpp: Removed.
  • kjs/nodes.h: Removed.
  • kjs/nodes2string.cpp: Removed.
  • parser: Added.
  • parser/Grammar.y: Copied from kjs/grammar.y.
  • parser/Keywords.table: Copied from kjs/keywords.table.
  • parser/Lexer.cpp: Copied from kjs/lexer.cpp.
  • parser/Lexer.h: Copied from kjs/lexer.h.
  • parser/NodeInfo.h: Copied from kjs/NodeInfo.h.
  • parser/Nodes.cpp: Copied from kjs/nodes.cpp.
  • parser/Nodes.h: Copied from kjs/nodes.h.
  • parser/Parser.cpp: Copied from kjs/Parser.cpp.
  • parser/Parser.h: Copied from kjs/Parser.h.
  • parser/ResultType.h: Copied from kjs/ResultType.h.
  • parser/SourceCode.h: Copied from kjs/SourceCode.h.
  • parser/SourceProvider.h: Copied from kjs/SourceProvider.h.
  • parser/nodes2string.cpp: Copied from kjs/nodes2string.cpp.
  • pcre/pcre.pri:
  • pcre/pcre_exec.cpp:
  • runtime/FunctionConstructor.cpp:
  • runtime/JSActivation.h:
  • runtime/JSFunction.h:
  • runtime/JSGlobalData.cpp:
  • runtime/JSGlobalObjectFunctions.cpp:
  • runtime/JSObject.cpp: (JSC::JSObject::toNumber):
  • runtime/RegExp.cpp:

WebCore:

  • ForwardingHeaders/kjs: Removed.
  • ForwardingHeaders/kjs/Parser.h: Removed.
  • ForwardingHeaders/kjs/SavedBuiltins.h: Removed.
  • ForwardingHeaders/kjs/SourceCode.h: Removed.
  • ForwardingHeaders/kjs/SourceProvider.h: Removed.
  • ForwardingHeaders/parser: Added.
  • ForwardingHeaders/parser/Parser.h: Copied from ForwardingHeaders/kjs/Parser.h.
  • ForwardingHeaders/parser/SourceCode.h: Copied from ForwardingHeaders/kjs/SourceCode.h.
  • ForwardingHeaders/parser/SourceProvider.h: Copied from ForwardingHeaders/kjs/SourceProvider.h.
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • bindings/js/StringSourceProvider.h:
  • bindings/js/WorkerScriptController.cpp:
  • bridge/NP_jsobject.cpp:
  • bridge/jni/jni_jsobject.mm:
  • bridge/testbindings.pro:
  • inspector/JavaScriptDebugServer.cpp:

WebKit/mac:

  • ForwardingHeaders/kjs: Removed.
  • ForwardingHeaders/kjs/SavedBuiltins.h: Removed.
4:17 PM Changeset in webkit [38204] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

2008-11-06 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Fix test that would fail if it had the wrong set of plugins.

  • plugins/plugin-javascript-access.html:
3:46 PM Changeset in webkit [38203] by ddkilzer@apple.com
  • 83 edits in trunk

BUILD WAS NOT BROKEN: Rolling r38189 back in.

WebCore:

BUILD WAS NOT BROKEN: Rolling r38189 back in.

Please perform a clean build if you see crashes.

WebKit/mac:

BUILD WAS NOT BROKEN: Rolling r38189 back in.

Please perform a clean build if you see crashes.

WebKitTools:

BUILD WAS NOT BROKEN: Rolling r38189 back in.

Please perform a clean build if you see crashes.

3:10 PM Changeset in webkit [38202] by ddkilzer@apple.com
  • 83 edits in trunk

BUILD FIX: Backed out r38189 since it apparently broke the world.

WebCore:

BUILD FIX: Backed out r38189 since it apparently broke the world.

WebKit/mac:

BUILD FIX: Backed out r38189 since it apparently broke the world.

WebKitTools:

BUILD FIX: Backed out r38189 since it apparently broke the world.

2:23 PM Changeset in webkit [38201] by ddkilzer@apple.com
  • 1 edit in trunk/WebCore/loader/FrameLoader.cpp

Fix indentation.

2:16 PM Changeset in webkit [38200] by Chris Fleizach
  • 8 edits
    2 adds in trunk

Bug 22112: if a <body> has contenteditable=true, it should report a writable AXValue
https://bugs.webkit.org/show_bug.cgi?id=22112

2:03 PM Changeset in webkit [38199] by Adam Roben
  • 2 edits in trunk/JavaScriptCore

Windows build fix after r38196

  • JavaScriptCore.vcproj/jsc/jsc.vcproj: Added bytecompiler/ to the include path.
1:55 PM Changeset in webkit [38198] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-11-06 Sam Weinig <sam@webkit.org>

Reviewed by Alice Liu.

Fix failed assert at launch caused by unintialized data member on the mac.

  • platform/network/mac/NetworkStateNotifierMac.cpp: (WebCore::NetworkStateNotifier::NetworkStateNotifier):
1:47 PM Changeset in webkit [38197] by sfalken@apple.com
  • 2 edits in trunk/WebCore

2008-11-06 Steve Falkenburg <sfalken@apple.com>

Fix failed assert at launch caused by unintialized data member.


Reviewed by Maciej Stachowiak.

  • platform/network/win/NetworkStateNotifierWin.cpp: (WebCore::NetworkStateNotifier::NetworkStateNotifier):
1:43 PM Changeset in webkit [38196] by cwzwarich@webkit.org
  • 8 edits
    3 moves
    1 add in trunk/JavaScriptCore

2008-11-06 Cameron Zwarich <zwarich@apple.com>

Rubber-stamped by Sam Weinig.

Create a new bytecompiler subdirectory of JavaScriptCore and move some
relevant files to it.

  • AllInOneFile.cpp:
  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • VM/CodeGenerator.cpp: Removed.
  • VM/CodeGenerator.h: Removed.
  • bytecompiler: Added.
  • bytecompiler/CodeGenerator.cpp: Copied from VM/CodeGenerator.cpp.
  • bytecompiler/CodeGenerator.h: Copied from VM/CodeGenerator.h.
  • bytecompiler/LabelScope.h: Copied from kjs/LabelScope.h.
  • jscore.bkl:
  • kjs/LabelScope.h: Removed.
1:35 PM Changeset in webkit [38195] by sullivan@apple.com
  • 3 edits in trunk/WebKit/win

2008-11-06 John Sullivan <sullivan@apple.com>

Eliminated one of the two booleans tracking whether zoom was text-only, to avoid future problems.


Reviewed by Adam Roben

  • WebView.h: removed m_zoomMultiplierIsTextOnly


  • WebView.cpp: (WebView::WebView): removed initialization of m_zoomMultiplierIsTextOnly (WebView::setZoomMultiplier): use m_page->settings()->setZoomsTextOnly() instead of setting m_zoomMultiplierIsTextOnly (WebView::zoomMultiplier): use m_page->settings()->zoomsTextOnly() instead of reading m_zoomMultiplierIsTextOnly
1:22 PM Changeset in webkit [38194] by sullivan@apple.com
  • 2 edits in trunk/WebKit/mac

2008-11-06 John Sullivan <sullivan@apple.com>

Fixed problem with switching between text-only zoom and full-content zoom


There were two booleans tracking whether zoom was text-only, one in WebCore settings
and one in WebViewPrivate. Fixed by eliminating the one in WebViewPrivate.

Reviewed by Adam Roben

  • WebView/WebView.mm: remove declaration of zoomMultiplierIsTextOnly instance variable in WebViewPrivate (-[WebViewPrivate init]): removed initialization of zoomMultiplierIsTextOnly (-[WebView textSizeMultiplier]): call [self _realZoomMultiplierIsTextOnly] instead of accessing WebViewPrivate instance variable (-[WebView _setZoomMultiplier:isTextOnly:]): update WebCore settings rather than WebViewPrivate instance variable (-[WebView _zoomMultiplier:]): call [self _realZoomMultiplierIsTextOnly] instead of accessing WebViewPrivate instance variable (-[WebView _realZoomMultiplierIsTextOnly]): return value from WebCore settings instead of accessing WebViewPrivate instance variable (-[WebView pageSizeMultiplier]): call [self _realZoomMultiplierIsTextOnly] instead of accessing WebViewPrivate instance variable
12:55 PM Changeset in webkit [38193] by Simon Fraser
  • 4 edits
    2 adds in trunk

2008-11-06 Simon Fraser <Simon Fraser>

Reviewed by Antti Koivisto

https://bugs.webkit.org/show_bug.cgi?id=22109
Make <input type="range"> work correctly with transforms

Test: fast/forms/slider-transformed.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):

Compute a correct local point when the event is retargeted

  • rendering/RenderSlider.cpp: (WebCore::HTMLSliderThumbElement::defaultEventHandler):

Compute m_initialClickPoint in slider-local coords, so that
deltas are computed correctly with transforms

(WebCore::RenderSlider::mouseEventIsInThumb):

Rather than computing an absolute bounds for the thumb,
convert the point to local coords and compare it with the border box.

12:36 PM Changeset in webkit [38192] by Adam Roben
  • 2 edits in trunk/JavaScriptCore

Windows clean build fix after r38155

Rubberstamped by Cameron Zwarich.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Update the post-build event for the move of create_hash_table out of kjs/.
12:35 PM Changeset in webkit [38191] by adele@apple.com
  • 6 edits in trunk/WebKit/win

2008-11-06 Adele Peterson <adele@apple.com>

Reviewed by Adam Roben.

Add support for a WebKitZoomsTextOnly preference.

  • Interfaces/IWebPreferences.idl:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp: (WebPreferences::setZoomsTextOnly): (WebPreferences::zoomsTextOnly):
  • WebPreferences.h:
  • WebView.cpp: (WebView::canMakeTextLarger): Consider the zoomsTextOnly setting when computing this. (WebView::makeTextLarger): ditto. (WebView::canMakeTextSmaller): ditto. (WebView::makeTextSmaller): ditto. (WebView::canMakeTextStandardSize): Don't consider the setting in this case since we need to reset both text zoom and page zoom regardless of the setting. (WebView::makeTextStandardSize): (WebView::notifyPreferencesChanged): Set the WebCore settings to match the WebPreference for WebKitZoomsTextOnly.
11:30 AM Changeset in webkit [38190] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2008-11-06 Laszlo Gombos <Laszlo Gombos>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=22107

Bug uncovered during RVCT port in functions not used. get_lt() and
get_gt() takes only one argument - remove second argument where
applicable.

11:28 AM Changeset in webkit [38189] by ddkilzer@apple.com
  • 83 edits in trunk

Bug 21810: Remove use of static C++ objects that are destroyed at exit time (destructors)

WebCore:

2008-11-06 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Bug 21810: Remove use of static C++ objects that are destroyed at exit time (destructors)
https://bugs.webkit.org/show_bug.cgi?id=21810

  • bindings/js/GCController.cpp: (WebCore::gcController): Changed to leak an object to avoid an exit-time destructor.
  • bindings/js/JSDOMBinding.cpp: (WebCore::wrapperSet): Ditto
  • bindings/js/JSInspectedObjectWrapper.cpp: (WebCore::wrappers): Ditto
  • bindings/js/JSInspectorCallbackWrapper.cpp: (WebCore::wrappers): Ditto
  • bridge/runtime_root.cpp: (JSC::Bindings::rootObjectSet): Ditto
  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::removeProperty): Ditto
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cssText): Ditto
  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): Ditto
  • css/CSSStyleSelector.cpp: (WebCore::screenEval): Ditto (WebCore::printEval): Ditto
  • dom/DOMImplementation.cpp: (WebCore::isSVG10Feature): Ditto (WebCore::isSVG11Feature): Ditto (WebCore::DOMImplementation::isXMLMIMEType): Ditto
  • dom/Document.cpp: (WebCore::Document::hasPrefixNamespaceMismatch): Ditto
  • dom/ScriptElement.cpp: (WebCore::isSupportedJavaScriptLanguage): Ditto
  • editing/ApplyStyleCommand.cpp: (WebCore::styleSpanClassString): Ditto
  • editing/HTMLInterchange.cpp: (WebCore::): Ditto
  • editing/IndentOutdentCommand.cpp: (WebCore::indentBlockquoteString): Ditto
  • editing/ReplaceSelectionCommand.cpp: (WebCore::isInterchangeNewlineNode): Ditto (WebCore::isInterchangeConvertedSpaceSpan): Ditto
  • editing/htmlediting.cpp: (WebCore::stringWithRebalancedWhitespace): Ditto (WebCore::nonBreakingSpaceString): Ditto
  • editing/markup.cpp: (WebCore::appendAttributeValue): Ditto (WebCore::appendEscapedContent): Ditto (WebCore::shouldAddNamespaceAttr): Ditto (WebCore::appendNamespace): Ditto (WebCore::appendStartMarkup): Ditto (WebCore::createMarkup): Ditto
  • html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::type): Ditto
  • html/HTMLElement.cpp: (WebCore::HTMLElement::isRecognizedTagName): Ditto (WebCore::inlineTagList): Ditto (WebCore::blockTagList): Ditto
  • html/HTMLFieldSetElement.cpp: (WebCore::HTMLFieldSetElement::type): Ditto
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::type): Ditto
  • html/HTMLKeygenElement.cpp: (WebCore::HTMLKeygenElement::type): Ditto
  • html/HTMLLegendElement.cpp: (WebCore::HTMLLegendElement::type): Ditto
  • html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::type): Ditto
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::type): Ditto
  • html/HTMLParser.cpp: (WebCore::HTMLParser::getNode): Ditto (WebCore::HTMLParser::isHeaderTag): Ditto (WebCore::HTMLParser::isResidualStyleTag): Ditto (WebCore::HTMLParser::isAffectedByResidualStyle): Ditto
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::type): Ditto
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::type): Ditto
  • inspector/InspectorController.cpp: (WebCore::platform): Ditto
  • inspector/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::shared): Ditto
  • inspector/JavaScriptProfile.cpp: (WebCore::profileCache): Ditto
  • inspector/JavaScriptProfileNode.cpp: (WebCore::profileNodeCache): Ditto
  • loader/FrameLoader.cpp: (WebCore::localSchemes): Ditto
  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::cacheStorage): Ditto
  • loader/archive/ArchiveFactory.cpp: (WebCore::archiveMIMETypes): Ditto
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::defaultDatabaseFilename): Ditto
  • page/EventHandler.cpp: (WebCore::EventHandler::dragState): Ditto
  • page/Frame.cpp: (WebCore::createRegExpForLabels): Ditto (WebCore::keepAliveSet): Ditto
  • page/Page.cpp: (WebCore::Page::groupName): Ditto
  • page/SecurityOrigin.cpp: (WebCore::isDefaultPortForProtocol): Ditto (WebCore::SecurityOrigin::databaseIdentifier): Ditto
  • page/mac/FrameMac.mm: (WebCore::regExpForLabels): Ditto
  • platform/KURL.cpp: (WebCore::blankURL): Ditto
  • platform/graphics/FontCache.cpp: (WebCore::alternateFamilyName): Ditto
  • platform/graphics/mac/FontCacheMac.mm: (WebCore::FontCache::getSimilarFontPlatformData): Ditto (WebCore::FontCache::getLastResortFallbackFont): Ditto
  • platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarTheme::nativeTheme): Ditto
  • platform/mac/ThemeMac.mm: (WebCore::platformTheme): Ditto
  • platform/mac/ThreadCheck.mm: (WebCoreReportThreadViolation): Ditto
  • platform/network/NetworkStateNotifier.cpp: (WebCore::networkStateNotifier): Ditto
  • platform/network/mac/FormDataStreamMac.mm: (WebCore::getStreamFormDataMap): Ditto (WebCore::getStreamResourceHandleMap): Ditto
  • platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::platformLazyInit): Ditto
  • platform/text/TextEncoding.cpp: (WebCore::TextEncoding::isJapanese): Ditto
  • rendering/RenderBlock.cpp: (WebCore::continuationOutlineTable): Ditto
  • rendering/RenderCounter.cpp: (WebCore::counterMaps): Ditto
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutVerticalBox): Ditto
  • rendering/RenderListItem.cpp: (WebCore::RenderListItem::markerText): Ditto
  • rendering/RenderScrollbarTheme.cpp: (WebCore::RenderScrollbarTheme::renderScrollbarTheme): Ditto
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::systemFont): Ditto
  • rendering/bidi.cpp: (WebCore::RenderBlock::checkLinesForTextOverflow): Ditto
  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::initialDashboardRegions): Ditto (WebCore::RenderStyle::noneDashboardRegions): Ditto
  • storage/LocalStorage.cpp: (WebCore::localStorageMap): Ditto
  • svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::rotateMode): Ditto
  • svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::calcMode): Ditto (WebCore::SVGAnimationElement::attributeType): Ditto (WebCore::SVGAnimationElement::isAdditive): Ditto (WebCore::SVGAnimationElement::isAccumulated): Ditto
  • svg/SVGLangSpace.cpp: (WebCore::SVGLangSpace::xmlspace): Ditto
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::contentScriptType): Ditto (WebCore::SVGSVGElement::contentStyleType): Ditto
  • svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::type): Ditto (WebCore::SVGStyleElement::media): Ditto
  • svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::parseMappedAttribute): Ditto
  • svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::parseClockValue): Ditto (WebCore::SVGSMILElement::restart): Ditto (WebCore::SVGSMILElement::fill): Ditto (WebCore::SVGSMILElement::repeatCount): Ditto (WebCore::SVGSMILElement::notifyDependentsIntervalChanged): Ditto
  • svg/graphics/SVGResource.cpp: (WebCore::clientMap): Ditto
  • svg/graphics/SVGResourceMarker.cpp: (WebCore::SVGResourceMarker::draw): Ditto
  • xml/XMLHttpRequest.cpp: (WebCore::preflightResultCache): Ditto (WebCore::isSafeRequestHeader): Ditto (WebCore::isOnAccessControlResponseHeaderWhitelist): Ditto
  • xml/XPathExpressionNode.cpp: (WebCore::XPath::Expression::evaluationContext): Ditto
  • xml/XPathParser.cpp: (WebCore::XPath::isAxisName): Ditto (WebCore::XPath::isNodeTypeName): Ditto
  • xml/XPathValue.cpp: (WebCore::XPath::Value::toNodeSet): Ditto

WebKit/mac:

2008-11-06 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Bug 21810: Remove use of static C++ objects that are destroyed at exit time (destructors)
https://bugs.webkit.org/show_bug.cgi?id=21810

  • History/WebBackForwardList.mm: (backForwardLists): Changed to leak an object to avoid an exit-time destructor.
  • History/WebHistoryItem.mm: (historyItemWrappers): Ditto
  • Misc/WebStringTruncator.m: (fontFromNSFont): Ditto
  • Plugins/WebBaseNetscapePluginStream.mm: (streams): Ditto
  • WebView/WebView.mm: (aeDescFromJSValue): Ditto

WebKitTools:

2008-11-06 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Bug 21810: Remove use of static C++ objects that are destroyed at exit time (destructors)
https://bugs.webkit.org/show_bug.cgi?id=21810

Remove .o files from the exclude list that have had their exit-time destructors removed.

  • Scripts/check-for-exit-time-destructors:
11:04 AM Changeset in webkit [38188] by vestbo@webkit.org
  • 3 edits in trunk/WebCore

2008-11-06 Tor Arne Vestbø <tavestbo@trolltech.com>

Rubber-stamped by Simon Hausmann.

Remove a bunch of unused methods in the Qt media element implementation

10:47 AM Changeset in webkit [38187] by alp@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-06 Alp Toker <alp@nuanti.com>

Reviewed by Cameron Zwarich.

https://bugs.webkit.org/show_bug.cgi?id=22033
[GTK] CTI/Linux r38064 crashes; JIT requires executable memory

Mark pages allocated by the FastMalloc mmap code path executable with
PROT_EXEC. This fixes crashes seen on CPUs and kernels that enforce
non-executable memory (like ExecShield on Fedora Linux) when the JIT
is enabled.

This patch does not resolve the issue on debug builds so affected
developers may still need to pass --disable-jit to configure.

  • wtf/TCSystemAlloc.cpp: (TryMmap): (TryDevMem): (TCMalloc_SystemRelease):
10:42 AM Changeset in webkit [38186] by Simon Fraser
  • 11 edits
    2 adds in trunk

2008-11-05 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=21870

Implement absoluteToLocal() to convert a point from absolute
to local coordinates, optionally taking transforms into account.

Use this to set offsetX/offsetY in mouse events, thus fixing
offsetX/offsetY in events on elements with transforms.

Test: fast/events/offsetX-offsetY.html

10:41 AM Changeset in webkit [38185] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-06 Peter Gal <galpeter@inf.u-szeged.hu>

Reviewed by Cameron Zwarich.

Bug 22099: Make the Qt port build the JSC shell in the correct place
<https://bugs.webkit.org/show_bug.cgi?id=22099>

Adjust include paths and build destination dir for the 'jsc' executable
in the Qt build.

  • jsc.pro:
10:41 AM Changeset in webkit [38184] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-11-06 Alp Toker <alp@nuanti.com>

Reviewed by Cameron Zwarich.

https://bugs.webkit.org/show_bug.cgi?id=22067
[GTK] Sun Java plugin segfaults at PluginPackage::createPackage()

null-check symbols loaded from plugin modules, initialize the function
table (like Win already does) and update it with the latest
additions. Adjust whitespace for easy diff'ing with the Win port code
from which it was forked.

This fixes crashes with libnspr4.so and any other plugins that don't
provide the symbols we expect.

  • plugins/gtk/PluginPackageGtk.cpp: (WebCore::PluginPackage::fetchInfo): (WebCore::PluginPackage::load):
10:38 AM Changeset in webkit [38183] by Simon Hausmann
  • 4 edits in trunk/WebCore

2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Simon Hausmann.

Removed dead (and broken) code from an ancient Symbian port.

10:38 AM Changeset in webkit [38182] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Simon Hausmann.

Use QLibrary as PlatformModule when compiling with Qt for S60.

10:38 AM Changeset in webkit [38181] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Simon Hausmann.

Implemented the block allocation on Symbian through heap allocation.

Unfortunately there is no way to allocate virtual memory. The Posix
layer provides mmap() but no anonymous mapping. So this is a very slow
solution but it should work as a start.

10:38 AM Changeset in webkit [38180] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Simon Hausmann.

Compile fix for Symbian.
The snprintf function is defined in stdio.h, the inclusion
of snprintf.h inside this PLATFORM(SYMBIAN) block does not
compile.

10:36 AM Changeset in webkit [38179] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-11-06 Alp Toker <alp@nuanti.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=22047
GTK: Add support for multiple file selection in the file upload control

Implemented with GtkFileChooser.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::runOpenPanel):
10:12 AM Changeset in webkit [38178] by Simon Hausmann
  • 1 edit in trunk/JavaScriptCore/runtime/Collector.cpp

Removed misplaced fixme comment that doesn't belong there.
Noticed by Darin

10:03 AM Changeset in webkit [38177] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2008-11-06 Laszlo Gombos <Laszlo Gombos>

Reviewed by Simon Hausmann.

Borrow some math functions from the MSVC port to the build with the
RVCT compiler.

10:03 AM Changeset in webkit [38176] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2008-11-06 Laszlo Gombos <Laszlo Gombos>

Reviewed by Simon Hausmann.

Include strings.h for strncasecmp().
This is needed for compilation inside Symbian and it is also
confirmed by the man-page on Linux.

9:48 AM Changeset in webkit [38175] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2008-11-06 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Simon Hausmann.

Implemented currentThreadStackBase for Symbian.

9:48 AM Changeset in webkit [38174] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2008-11-06 Laszlo Gombos <Laszlo Gombos>

Reviewed by Simon Hausmann.

RVCT does not support tm_gmtoff field, so disable that code just like
for MSVC.

9:47 AM Changeset in webkit [38173] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Simon Hausmann.

Use the GCC defines of the WTF_ALIGN* macros for the RVCT and the
MINSCW compiler.

9:42 AM Changeset in webkit [38172] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Simon Hausmann.

Define capabilities of the SYMBIAN platform. Some of the system
headers are actually dependent on RVCT.

9:42 AM Changeset in webkit [38171] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Simon Hausmann.

Add missing stddef.h header needed for compilation in Symbian.

8:50 AM Changeset in webkit [38170] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Simon Hausmann.

Define PLATFORM(UNIX) for S60. Effectively WebKit on S60 is compiled
on top of the Posix layer.

8:50 AM Changeset in webkit [38169] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2008-11-06 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Simon Hausmann.

Added SYMBIAN32 condition for defining PLATFORM(SYMBIAN).

8:39 AM Changeset in webkit [38168] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2008-11-06 Ariya Hidayat <ariya.hidayat@trolltech.com>

Reviewed by Simon Hausmann.

Added WINSCW compiler define for Symbian S60.

8:39 AM Changeset in webkit [38167] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Simon Hausmann.

Added COMPILER(RVCT) to detect the ARM RVCT compiler used in the Symbian environment.

8:38 AM Changeset in webkit [38166] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Simon Hausmann.

Disable webkit plugins for Symbian.

4:15 AM Changeset in webkit [38165] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2008-11-06 Tor Arne Vestbø <tavestbo@trolltech.com>

Fix build break in debug mode when XSLT is not enabled

4:14 AM Changeset in webkit [38164] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2008-11-06 Tor Arne Vestbø <tavestbo@trolltech.com>

Reviewed by Simon Hausmann.

Repaint video on UpdateRequest to prevent recursive painting

Calling QWidget::render() to update the video generates a paint
event that's then picked up by the event filter once more :(

We're really only interested in updates from Phonon, which we
get through the UpdateRequest for each new frame.

3:46 AM Changeset in webkit [38163] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2008-11-06 Simon Hausmann <Simon Hausmann>

Fix the Qt build, adjust include paths after move of jsc.pro.

2:21 AM Changeset in webkit [38162] by cwzwarich@webkit.org
  • 6 edits
    1 move in trunk/JavaScriptCore

2008-11-06 Cameron Zwarich <zwarich@apple.com>

Rubber-stamped by Sam Weinig.

Move kjs/Shell.cpp to the top level of the JavaScriptCore directory and
rename it to jsc.cpp to reflect the name of the binary compiled from it.

  • GNUmakefile.am:
  • JavaScriptCore.vcproj/jsc/jsc.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • jsc.cpp: Copied from kjs/Shell.cpp.
  • jsc.pro:
  • jscore.bkl:
  • kjs/Shell.cpp: Removed.
1:50 AM Changeset in webkit [38161] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2008-11-06 Simon Hausmann <Simon Hausmann>

Reviewed by Tor Arne Vestbø.

Added a unit tests for QWebFrame::metaData().

1:49 AM Changeset in webkit [38160] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2008-11-06 Simon Hausmann <Simon Hausmann>

Reviewed by Tor Arne Vestbø.

Improved documentation for QWebFrame::metaData().

1:49 AM Changeset in webkit [38159] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

2008-11-05 Sriram Yadavalli <sriram.yadavalli@nokia.com>

Reviewed by Simon Hausmann.

Added QWebFrame::metaData() to provide a way in the public API
to retrieve the values of the <meta> tags.

See https://bugs.webkit.org/show_bug.cgi?id=22071

1:22 AM Changeset in webkit [38158] by cwzwarich@webkit.org
  • 3 edits in trunk/WebCore

2008-11-06 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Fix the WebCore build for some platforms by changing build scripts to
account for the recent move of the create_hash_table script from the kjs
subdirectory of JavaScriptCore to the root directory.

  • WebCore.pro:
  • make-generated-sources.sh:
12:58 AM Changeset in webkit [38157] by alp@webkit.org
  • 2 edits in trunk

2008-11-06 Alp Toker <alp@nuanti.com>

GTK build fix for r38155. create_hash_table was moved out of kjs/

  • GNUmakefile.am:
12:55 AM Changeset in webkit [38156] by cwzwarich@webkit.org
  • 2 edits in trunk

2008-11-05 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Correct the date on previous ChangeLogs.

  • ChangeLog:
  • JavaScriptCore/ChangeLog:
12:53 AM Changeset in webkit [38155] by cwzwarich@webkit.org
  • 7 edits
    2 moves in trunk

2008-11-05 Cameron Zwarich <zwarich@apple.com>

Rubber-stamped by Sam Weinig.

Move create_hash_table and jsc.pro out of the kjs directory and into the
root directory of JavaScriptCore.

JavaScriptCore:

  • DerivedSources.make:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • create_hash_table: Copied from kjs/create_hash_table.
  • jsc.pro: Copied from kjs/jsc.pro.
  • kjs/create_hash_table: Removed.
  • kjs/jsc.pro: Removed.
  • make-generated-sources.sh:
  • WebKit.pro:
12:18 AM Changeset in webkit [38154] by cwzwarich@webkit.org
  • 2 edits in trunk/WebCore

2008-11-06 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Fix a case-sensitivity issue in Mac forwarding headers. Strangely
enough, this does not always cause the build to break, even with a
case-sensitive filesystem.

  • ForwardingHeaders/runtime/Interpreter.h:
Note: See TracTimeline for information about the timeline view.