Context Navigation

← Previous Period
Next Period →

Timeline

Nov 8, 2008:

11:36 PM WikiStart edited by mjs@apple.com

(diff)

8:11 PM Changeset in webkit [38240] by Antti Koivisto

3 edits
4 adds in trunk

WebCore:

2008-11-08 Antti Koivisto <Antti Koivisto>

Reviewed by Sam Weinig.

Fix https://bugs.webkit.org/show_bug.cgi?id=22141
REGRESSION: Safari error page is not fully styled when loaded from cache

Reset text decoder on flush so it does not pass through the BOM when it is reused.

Test: fast/encoding/css-cached-bom.html

loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::flush):

LayoutTests:

2008-11-08 Antti Koivisto <Antti Koivisto>

Reviewed by Sam Weinig.

Test for https://bugs.webkit.org/show_bug.cgi?id=22141
REGRESSION: Safari error page is not fully styled when loaded from cache

fast/encoding/css-cached-bom.html: Added.
fast/encoding/css-cached-bom-expected.txt: Added.
fast/encoding/resources/css-cached-bom-frame.html: Added.
fast/encoding/resources/utf-16-little-endian.css: Added.

7:14 PM Changeset in webkit [38239] by kevino@webkit.org

2 edits in trunk/WebCore

Reviewed by Mark Rowe.

Send URL errors to stderr rather than stdout. While debugging wx DumpRenderTree,
it was causing these errors to end up in the page's text representation.

6:35 PM Changeset in webkit [38238] by kevino@webkit.org

8 edits in trunk

wx build fixes after addition of JSCore parser and bycompiler dirs.

5:09 PM Changeset in webkit [38237] by Simon Fraser

5 edits
4 adds in trunk

2008-11-08 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein

https://bugs.webkit.org/show_bug.cgi?id=21906

Override addFocusRingRects() in RenderTextControl to avoid
the RenderFlow behavior of recursing on descendent renderers.
RenderTextControl should only ever need a simple focus rect.

This fixes focus ring issues with transforms on text controls.

Test: fast/transforms/transformed-focused-text-input.html

rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::addFocusRingRects):
rendering/RenderTextControl.h:

4:33 PM Changeset in webkit [38236] by timothy@apple.com

2 edits in trunk/WebCore

Make sure the icon thumbnail width/height is at least 1px in
the Web Inspector's resource panel.

<rdar://problem/5988888>

Reviewed by Tim Hatcher.

inspector/front-end/inspector.css:

11:42 AM Changeset in webkit [38235] by ddkilzer@apple.com

7 edits in trunk

Bug 22137: PLATFORM(MAC) build broken with HAVE(ACCESSIBILITY) disabled

<https://bugs.webkit.org/show_bug.cgi?id=22137>

Reviewed by Darin Adler.

WebCore:

page/AccessibilityObject.h: (WebCore::AccessibilityObject::accessibilityIgnoreAttachment): Provide a default implementation when HAVE(ACCESSIBILITY) is false.
page/mac/AXObjectCacheMac.mm: Added HAVE(ACCESSIBILITY) guard.
page/mac/AccessibilityObjectMac.mm: Ditto.
page/mac/AccessibilityObjectWrapper.mm: Ditto.

WebKit/mac:

WebView/WebFrame.mm: (-[WebFrame _accessibilityTree]): Return nil if HAVE(ACCESSIBILITY) is false.

11:12 AM Changeset in webkit [38234] by mitz@apple.com

16 edits in trunk

WebCore:

Reviewed by Darin Adler.

WebCore part of adding WebPreferences for controlling databases and local storage

WebCore.base.exp: Exported Settings::setDatabasesEnabled() and Settings::setLocalStorageEnabled().
page/DOMWindow.cpp: (WebCore::DOMWindow::localStorage): Changed to return 0 if local storage is disabled in settings. (WebCore::DOMWindow::openDatabase): Changed to return 0 if databases are disabled in settings.
page/Settings.cpp: (WebCore::Settings::Settings): Initialize m_databasesEnabled and m_localStorageEnabled. (WebCore::Settings::setDatabasesEnabled): Added. (WebCore::Settings::setLocalStorageEnabled): Added.
page/Settings.h: (WebCore::Settings::databasesEnabled): Added. (WebCore::Settings::localStorageEnabled): Added.

WebKit/mac:

Reviewed by Darin Adler.

WebKit/mac part of adding WebPreferences for controlling databases and local storage

WebView/WebPreferenceKeysPrivate.h: Added WebKitDatabasesEnabledPreferenceKey and WebKitLocalStorageEnabledPreferenceKey.
WebView/WebPreferences.mm: (+[WebPreferences initialize]): Made databases and local storage enabled by default. (-[WebPreferences databasesEnabled]): Added. (-[WebPreferences setDatabasesEnabled:]): Added. (-[WebPreferences localStorageEnabled]): Added. (-[WebPreferences setLocalStorageEnabled:]): Added.
WebView/WebPreferencesPrivate.h:
WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): Transfer the databases and local storage preferences to WebCore settings.

WebKit/win:

Reviewed by Darin Adler.

WebKit/win part of adding WebPreferences for controlling databases and local storage

Interfaces/IWebPreferencesPrivate.idl: Declared setDatabasesEnabled, databasesEnabled, setLocalStorageEnabled and localStorageEnabled.
WebPreferenceKeysPrivate.h: Added WebKitDatabasesEnabledPreferenceKey and WebKitLocalStorageEnabledPreferenceKey.
WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): Made databases and local storage enabled by default. (WebPreferences::setDatabasesEnabled): Added. (WebPreferences::databasesEnabled): Added. (WebPreferences::setLocalStorageEnabled): Added. (WebPreferences::localStorageEnabled): Added.
WebPreferences.h:
WebView.cpp: (WebView::notifyPreferencesChanged): Transfer the databases and local storage preferences to WebCore settings.

5:57 AM Changeset in webkit [38233] by staikos@webkit.org

1 edit in trunk/WebCore/ChangeLog-2008-08-10

Just adjusting email address in changelog.

Nov 7, 2008:

2:29 PM Changeset in webkit [38232] by alp@webkit.org

8 edits in trunk/WebCore

2008-11-07 Alp Toker <alp@nuanti.com>

Fix build with bleeding edge GTK+ versions. GTK+ and other libraries
now require that only their top-level header file is included.

Patch tested and still builds fine with older GTK+ versions (back to
2.8).

Future WebKit GTK+ contributions are required to adhere to this
policy.

platform/gtk/FileSystemGtk.cpp:
platform/gtk/KeyEventGtk.cpp:
platform/gtk/MouseEventGtk.cpp:
platform/gtk/WheelEventGtk.cpp:
platform/gtk/gtkdrawing.h:
plugins/gtk/gtk2xtbin.c:
plugins/gtk/gtk2xtbin.h:

1:34 PM Changeset in webkit [38231] by andersca@apple.com

2 edits in trunk/WebCore

2008-11-07 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker

Explicitly initialize the NPDrawingModelCoreAnimation.

bridge/npapi.h:

1:15 PM Changeset in webkit [38230] by cwzwarich@webkit.org

3 edits
3 adds in trunk

2008-11-07 Cameron Zwarich <zwarich@apple.com>

Reviewed by Geoff Garen.

Bug 21801: REGRESSION (r37821): YUI date formatting JavaScript puts the letter 'd' in place of the day
<https://bugs.webkit.org/show_bug.cgi?id=21801>

Fix the constant register check in the 'typeof' optimization in
CodeGenerator, which was completely broken after r37821.

JavaScriptCore:

bytecompiler/CodeGenerator.cpp: (JSC::CodeGenerator::emitEqualityOp):

LayoutTests:

fast/js/resources/typeof-constant-string.js: Added.
fast/js/typeof-constant-string-expected.txt: Added.
fast/js/typeof-constant-string.html: Added.

12:41 PM Changeset in webkit [38229] by cwzwarich@webkit.org

4 edits in trunk/JavaScriptCore

2008-11-07 Cameron Zwarich <zwarich@apple.com>

Reviewed by Geoff Garen.

Bug 22129: Move CTI::isConstant() to CodeBlock
<https://bugs.webkit.org/show_bug.cgi?id=22129>

VM/CTI.cpp: (JSC::CTI::emitGetArg): (JSC::CTI::emitGetPutArg): (JSC::CTI::getConstantImmediateNumericArg): (JSC::CTI::printOpcodeOperandTypes): (JSC::CTI::privateCompileMainPass):
VM/CTI.h:
VM/CodeBlock.h: (JSC::CodeBlock::isConstant):

11:35 AM Changeset in webkit [38228] by alp@webkit.org

4 edits in trunk

2008-11-07 Alp Toker <alp@nuanti.com>

autotools fix. Always use the configured perl binary (which may be
different to the one in $PATH) when generating sources.

11:17 AM Changeset in webkit [38227] by Simon Fraser

8 edits in trunk/WebCore

2008-11-07 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein

https://bugs.webkit.org/show_bug.cgi?id=22122

Use a stack-based object to simplify the pushLayoutState/popLayoutState
code. LayoutStateMaintainer either pushes in the constructor, or allows
an explicit push() later. Both cases require an explicit pop().

rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::layoutOnlyPositionedObjects):
rendering/RenderContainer.cpp: (WebCore::RenderContainer::layout):
rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock):
rendering/RenderTable.cpp: (WebCore::RenderTable::layout):
rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::layout):
rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::setCellWidths): (WebCore::RenderTableSection::calcRowHeight): (WebCore::RenderTableSection::layoutRows):
rendering/RenderView.h: (WebCore::LayoutStateMaintainer::LayoutStateMaintainer): (WebCore::LayoutStateMaintainer::~LayoutStateMaintainer): (WebCore::LayoutStateMaintainer::pop): (WebCore::LayoutStateMaintainer::push): (WebCore::LayoutStateMaintainer::didPush):

10:07 AM Changeset in webkit [38226] by cwzwarich@webkit.org

4 edits in trunk/JavaScriptCore

2008-11-07 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Change grammar.cpp to Grammar.cpp and grammar.h to Grammar.h in several
build scripts.

DerivedSources.make:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCoreSources.bkl:

9:48 AM Changeset in webkit [38225] by alp@webkit.org

3 edits in trunk/JavaScriptCore

2008-11-07 Alp Toker <alp@nuanti.com>

More grammar.cpp -> Grammar.cpp build fixes.

AllInOneFile.cpp:
GNUmakefile.am:

7:39 AM Changeset in webkit [38224] by vestbo@webkit.org

2 edits in trunk/WebCore

2008-11-07 Tor Arne Vestbø <tavestbo@trolltech.com>

Fix the QtWebKit build on Mac

7:01 AM Changeset in webkit [38223] by vestbo@webkit.org

2 edits in trunk/WebCore

2008-11-07 Tor Arne Vestbø <tavestbo@trolltech.com>

Rubber-stamped by Simon Hausmann.

Don't allow Phonon's invisible video widget to keep the app running

6:47 AM Changeset in webkit [38222] by vestbo@webkit.org

3 edits in trunk/WebKit/qt

2008-11-07 Ariya Hidayat <ariya.hidayat@trolltech.com>

Reviewed by Tor Arne Vestbø and Simon Hausmann.

Added an option to allow printing the background color and images.
Mostly reworked from a patch by Holger.
This setting is enabled by default.

Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): (QWebSettings::QWebSettings):
Api/qwebsettings.h:

6:11 AM Changeset in webkit [38221] by Simon Hausmann

2 edits in trunk/JavaScriptCore

2008-11-07 Simon Hausmann <Simon Hausmann>

Fix the build on case-sensitive file systems. grammar.y was renamed to
Grammar.y but Lexer.cpp includes grammar.h. The build bots didn't
notice this change because of stale files.

3:32 AM Changeset in webkit [38220] by Simon Hausmann

2 edits in trunk/WebCore

2008-11-07 Henrik Hartz <henrik.hartz@nokia.com>

Reviewed by Simon Hausmann.

Fix valgrind warning about uninitialized lastStop variable.

1:22 AM Changeset in webkit [38219] by cwzwarich@webkit.org

3 edits in trunk/JavaScriptCore

2008-11-07 Cameron Zwarich <zwarich@apple.com>

Reviewed by Alexey Proskuryakov.

Rename the m_nextGlobal, m_nextParameter, and m_nextConstant member
variables of CodeGenerator to m_nextGlobalIndex, m_nextParameterIndex,
and m_nextConstantIndex respectively. This is to distinguish these from
member variables like m_lastConstant, which are actually RefPtrs to
Registers.

bytecompiler/CodeGenerator.cpp: (JSC::CodeGenerator::addGlobalVar): (JSC::CodeGenerator::allocateConstants): (JSC::CodeGenerator::CodeGenerator): (JSC::CodeGenerator::addParameter): (JSC::CodeGenerator::addConstant):
bytecompiler/CodeGenerator.h:

1:22 AM Changeset in webkit [38218] by ap@webkit.org

2 edits in trunk/WebCore

Reviewed by Maciej Stachowiak.

Fix layout test brokenness following r38211.

page/EventHandler.cpp: (WebCore::EventHandler::handleAccessKey): Restore old Shift key behavior. We ignore Shift key state when matching access keys (which matches neither IE nor Firefox), and this patch made WebKit behave like Firefox inadvertently. This may or may not be a good thing, but it's certainly not something that should change by accident.

1:20 AM Applications using WebKit edited by barbarosa100@hotmail.com