⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 9, 2008:

10:26 PM Changeset in webkit [38250] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-09 Cameron Zwarich <​zwarich@apple.com>

Not reviewed.

Speculatively fix the non-AllInOne build.

  • runtime/NativeErrorConstructor.cpp:
5:28 PM Changeset in webkit [38249] by Darin Adler
  • 15 edits
    1 delete in trunk/JavaScriptCore

2008-11-09 Darin Adler <Darin Adler>

Reviewed by Tim Hatcher.

  • VM/CodeBlock.h: Added include.
  • VM/Machine.cpp: (JSC::Machine::execute): Use the types from
DeclarationStacks as DeclarationStacks
rather than Node:: since "Node" really has little to do with it.
  • bytecompiler/CodeGenerator.cpp: (JSC::CodeGenerator::CodeGenerator): Ditto.
  • jsc.cpp: (Options::Options): Removed prettyPrint option. (runWithScripts): Ditto. (printUsageStatement): Ditto. (parseArguments): Ditto. (jscmain): Ditto.
  • parser/Grammar.y: Removed use of obsolete ImmediateNumberNode.
  • parser/Nodes.cpp: (JSC::ThrowableExpressionData::emitThrowError): Use inline functions instead of direct member access for ThrowableExpressionData values. (JSC::BracketAccessorNode::emitCode): Ditto. (JSC::DotAccessorNode::emitCode): Ditto. (JSC::NewExprNode::emitCode): Ditto. (JSC::EvalFunctionCallNode::emitCode): Ditto. (JSC::FunctionCallValueNode::emitCode): Ditto. (JSC::FunctionCallResolveNode::emitCode): Ditto. (JSC::FunctionCallBracketNode::emitCode): Ditto. (JSC::FunctionCallDotNode::emitCode): Ditto. (JSC::PostfixResolveNode::emitCode): Ditto. (JSC::PostfixBracketNode::emitCode): Ditto. (JSC::PostfixDotNode::emitCode): Ditto. (JSC::DeleteResolveNode::emitCode): Ditto. (JSC::DeleteBracketNode::emitCode): Ditto. (JSC::DeleteDotNode::emitCode): Ditto. (JSC::PrefixResolveNode::emitCode): Ditto. (JSC::PrefixBracketNode::emitCode): Ditto. (JSC::PrefixDotNode::emitCode): Ditto. (JSC::ThrowableBinaryOpNode::emitCode): Ditto. (JSC::InstanceOfNode::emitCode): Ditto. (JSC::ReadModifyResolveNode::emitCode): Ditto. (JSC::AssignResolveNode::emitCode): Ditto. (JSC::AssignDotNode::emitCode): Ditto. (JSC::ReadModifyDotNode::emitCode): Ditto. (JSC::AssignBracketNode::emitCode): Ditto. (JSC::ReadModifyBracketNode::emitCode): Ditto. (JSC::statementListEmitCode): Take a const StatementVector instead of a non-const one. Also removed unused statementListPushFIFO. (JSC::ForInNode::emitCode): Inline functions instead of member access. (JSC::ThrowNode::emitCode): Ditto. (JSC::EvalNode::emitCode): Ditto. (JSC::FunctionBodyNode::emitCode): Ditto. (JSC::ProgramNode::emitCode): Ditto.
  • parser/Nodes.h: Removed unused includes and forward declarations. Removed Precedence enum. Made many more members private instead of protected or public. Removed unused NodeStack typedef. Moved the VarStack and FunctionStack typedefs from Node to ScopeNode. Made Node::emitCode pure virtual and changed classes that don't emit any code to inherit from ParserRefCounted rather than Node. Moved isReturnNode from Node to StatementNode. Removed the streamTo, precedence, and needsParensIfLeftmost functions from all classes. Removed the ImmediateNumberNode class and make NumberNode::setValue nonvirtual.
  • parser/nodes2string.cpp: Removed.
5:19 PM Changeset in webkit [38248] by cwzwarich@webkit.org
  • 3 edits
    2 adds in trunk

2008-11-09 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Darin Adler.

Bug 19541: Null pointer in showModalDialog()
<​https://bugs.webkit.org/show_bug.cgi?id=19541>

Add null frame->page() checks to JSDOMWindowBase::canShowModalDialog()
and JSDOMWindowBase::canShowModalDialogNow()C

WebCore:

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::canShowModalDialog): (WebCore::canShowModalDialogNow):

LayoutTests:

  • fast/dom/null-page-show-modal-dialog-crash-expected.txt: Added.
  • fast/dom/null-page-show-modal-dialog-crash.html: Added.
5:04 PM Changeset in webkit [38247] by Darin Adler
  • 6 edits
    3 adds in trunk

JavaScriptCore:

2008-11-09 Darin Adler <Darin Adler>

Reviewed by Sam Weinig and Maciej Stachowiak.
Includes some work done by Chris Brichford.

Test: fast/js/large-expressions.html

1) Code generation is recursive, so takes stack proportional to the complexity

of the source code expression. Fixed by setting an arbitrary recursion limit
of 10,000 nodes.

2) Destruction of the syntax tree was recursive. Fixed by introducing a

non-recursive mechanism for destroying the tree.

  • bytecompiler/CodeGenerator.cpp: (JSC::CodeGenerator::CodeGenerator): Initialize depth to 0. (JSC::CodeGenerator::emitThrowExpressionTooDeepException): Added. Emits the code to throw a "too deep" exception.
  • bytecompiler/CodeGenerator.h: (JSC::CodeGenerator::emitNode): Check depth and emit an exception if we exceed the maximum depth.
  • parser/Nodes.cpp: (JSC::NodeReleaser::releaseAllNodes): Added. To be called inside node destructors to avoid recursive calls to destructors for nodes inside this one. (JSC::NodeReleaser::release): Added. To be called inside releaseNodes functions. Also added releaseNodes functions and calls to releaseAllNodes inside destructors for each class derived from Node that has RefPtr to other nodes. (JSC::NodeReleaser::adopt): Added. Used by the release function. (JSC::NodeReleaser::adoptFunctionBodyNode): Added.
  • parser/Nodes.h: Added declarations of releaseNodes and destructors in all classes that needed it. Eliminated use of ListRefPtr and releaseNext, which are the two parts of an older solution to the non-recursive destruction problem that works only for lists, whereas the new solution works for other graphs. Changed ReverseBinaryOpNode to use BinaryOpNode as a base class to avoid some duplicated code.

LayoutTests:

2008-11-09 Alexey Proskuryakov <​ap@webkit.org>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=22104
Javascript URL percent encoding/decoding broken by some characters

  • fast/loader/javascript-url-encoding-2-expected.txt:
  • fast/loader/javascript-url-encoding-2.html:
4:22 PM Changeset in webkit [38246] by Darin Adler
  • 2 edits in trunk/WebCore

2008-11-09 Darin Adler <Darin Adler>

  • try to fix Windows build
  • platform/graphics/Color.cpp: For some reason MSVC doesn't follow the rules about needed a separate definition for static const integer data members. Until I get to the bottom of this, put the definitions inside an ifdef.
12:19 PM Changeset in webkit [38245] by Darin Adler
  • 4 edits in trunk/WebKit/mac

2008-11-09 Darin Adler <Darin Adler>

Reviewed by John Sullivan.

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::frameLoadCompleted): Added comments, and got rid of a local variable to make this code match the code in the function below more closely. (WebFrameLoaderClient::provisionalLoadStarted): Added comments.
  • WebView/WebFrame.mm: (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]): Improved comment.
  • WebView/WebFrameView.mm: (-[WebFrameView _scrollView]): Tweaked formatting. (-[WebFrameView initWithFrame:]): Ditto. (-[WebFrameView setFrameSize:]): Added a comment and tweaked formatting. (-[WebFrameView viewDidMoveToWindow]): Added. This is the change that fixes the bug. Calls setDrawsBackground:YES as appropriate since moving the view out of the window to switch to another view disrupts the special technique for showing the old page during the start of loading. This is the identical reason for the setFrameSize: method above, and the code is almost the same.
11:50 AM Changeset in webkit [38244] by ddkilzer@apple.com
  • 6 edits in trunk/WebCore

BUILD FIX: Qt build broke after r38235.

Added HAVE(ACCESSIBILITY) header guards to platform implementation
source files.

  • page/gtk/AccessibilityObjectAtk.cpp: Added HAVE(ACCESSIBILITY) guards.
  • page/gtk/AccessibilityObjectWrapperAtk.cpp: Ditto.
  • page/qt/AccessibilityObjectQt.cpp: Ditto.
  • page/win/AccessibilityObjectWin.cpp: Ditto.
  • page/wx/AccessibilityObjectWx.cpp: Ditto.
11:08 AM Changeset in webkit [38243] by ap@webkit.org
  • 3 edits
    2 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=22104
Javascript URL percent encoding/decoding broken by some characters

Test: fast/loader/javascript-url-encoding-2.html

  • platform/KURL.cpp: (WebCore::encodeRelativeString): Don't try to break down javascript URLs.
10:20 AM Changeset in webkit [38242] by Darin Adler
  • 2 edits in trunk/WebCore

2008-11-09 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed and tweaked by Darin Adler.

  • platform/graphics/Color.cpp: Added definitions for the static data members in this class. Static data members need a definition, even when they are the simple integer constant kind that can be initialized in the header.
7:50 AM Changeset in webkit [38241] by Darin Adler
  • 8 edits in trunk/LayoutTests

2008-11-09 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

  • fast/canvas/gradient-addColorStop-with-invalid-color-expected.txt: Fixed spelling error: "gradieints".
  • fast/canvas/gradient-addColorStop-with-invalid-color.html: Regenerated with make-js-test-wrappers script; removes the canvas element that was in here.
  • fast/canvas/linearGradient-infinite-values.html: Ditto.
  • fast/canvas/radialGradient-infinite-values.html: Ditto.
  • fast/canvas/resources/gradient-addColorStop-with-invalid-color.js: Fixed spelling error and changed code to use createElement to make a canvas element rather than using getElementById to find an existing canvas element.
  • fast/canvas/resources/linearGradient-infinite-values.js: Ditto.
  • fast/canvas/resources/radialGradient-infinite-values.js: Ditto.
4:56 AM Companies and Organizations that have contributed to WebKit edited by ddkilzer@webkit.org
Added reference to KSVG2 (diff)
2:36 AM Companies and Organizations that have contributed to WebKit edited by staikos@kde.org
(diff)
12:04 AM Companies and Organizations that have contributed to WebKit edited by mjs@apple.com
(diff)
12:02 AM Companies and Organizations that have contributed to WebKit created by mjs@apple.com

Nov 8, 2008:

11:36 PM WikiStart edited by mjs@apple.com
(diff)
8:11 PM Changeset in webkit [38240] by Antti Koivisto
  • 3 edits
    4 adds in trunk

WebCore:

2008-11-08 Antti Koivisto <Antti Koivisto>

Reviewed by Sam Weinig.


Fix ​https://bugs.webkit.org/show_bug.cgi?id=22141
REGRESSION: Safari error page is not fully styled when loaded from cache


Reset text decoder on flush so it does not pass through the BOM when it is reused.

Test: fast/encoding/css-cached-bom.html

  • loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::flush):

LayoutTests:

2008-11-08 Antti Koivisto <Antti Koivisto>

Reviewed by Sam Weinig.


Test for ​https://bugs.webkit.org/show_bug.cgi?id=22141
REGRESSION: Safari error page is not fully styled when loaded from cache

  • fast/encoding/css-cached-bom.html: Added.
  • fast/encoding/css-cached-bom-expected.txt: Added.
  • fast/encoding/resources/css-cached-bom-frame.html: Added.
  • fast/encoding/resources/utf-16-little-endian.css: Added.
7:14 PM Changeset in webkit [38239] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Mark Rowe.

Send URL errors to stderr rather than stdout. While debugging wx DumpRenderTree,
it was causing these errors to end up in the page's text representation.

6:35 PM Changeset in webkit [38238] by kevino@webkit.org
  • 8 edits in trunk

wx build fixes after addition of JSCore parser and bycompiler dirs.

5:09 PM Changeset in webkit [38237] by Simon Fraser
  • 5 edits
    4 adds in trunk

2008-11-08 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein

​https://bugs.webkit.org/show_bug.cgi?id=21906

Override addFocusRingRects() in RenderTextControl to avoid
the RenderFlow behavior of recursing on descendent renderers.
RenderTextControl should only ever need a simple focus rect.

This fixes focus ring issues with transforms on text controls.

Test: fast/transforms/transformed-focused-text-input.html

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::addFocusRingRects):
  • rendering/RenderTextControl.h:
4:33 PM Changeset in webkit [38236] by timothy@apple.com
  • 2 edits in trunk/WebCore

Make sure the icon thumbnail width/height is at least 1px in
the Web Inspector's resource panel.

<rdar://problem/5988888>

Reviewed by Tim Hatcher.

  • inspector/front-end/inspector.css:
11:42 AM Changeset in webkit [38235] by ddkilzer@apple.com
  • 7 edits in trunk

Bug 22137: PLATFORM(MAC) build broken with HAVE(ACCESSIBILITY) disabled

<​https://bugs.webkit.org/show_bug.cgi?id=22137>

Reviewed by Darin Adler.

WebCore:

  • page/AccessibilityObject.h: (WebCore::AccessibilityObject::accessibilityIgnoreAttachment): Provide a default implementation when HAVE(ACCESSIBILITY) is false.
  • page/mac/AXObjectCacheMac.mm: Added HAVE(ACCESSIBILITY) guard.
  • page/mac/AccessibilityObjectMac.mm: Ditto.
  • page/mac/AccessibilityObjectWrapper.mm: Ditto.

WebKit/mac:

  • WebView/WebFrame.mm: (-[WebFrame _accessibilityTree]): Return nil if HAVE(ACCESSIBILITY) is false.
11:12 AM Changeset in webkit [38234] by mitz@apple.com
  • 16 edits in trunk

WebCore:

Reviewed by Darin Adler.

  • WebCore part of adding WebPreferences for controlling databases and local storage
  • WebCore.base.exp: Exported Settings::setDatabasesEnabled() and Settings::setLocalStorageEnabled().
  • page/DOMWindow.cpp: (WebCore::DOMWindow::localStorage): Changed to return 0 if local storage is disabled in settings. (WebCore::DOMWindow::openDatabase): Changed to return 0 if databases are disabled in settings.
  • page/Settings.cpp: (WebCore::Settings::Settings): Initialize m_databasesEnabled and m_localStorageEnabled. (WebCore::Settings::setDatabasesEnabled): Added. (WebCore::Settings::setLocalStorageEnabled): Added.
  • page/Settings.h: (WebCore::Settings::databasesEnabled): Added. (WebCore::Settings::localStorageEnabled): Added.

WebKit/mac:

Reviewed by Darin Adler.

  • WebKit/mac part of adding WebPreferences for controlling databases and local storage
  • WebView/WebPreferenceKeysPrivate.h: Added WebKitDatabasesEnabledPreferenceKey and WebKitLocalStorageEnabledPreferenceKey.
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): Made databases and local storage enabled by default. (-[WebPreferences databasesEnabled]): Added. (-[WebPreferences setDatabasesEnabled:]): Added. (-[WebPreferences localStorageEnabled]): Added. (-[WebPreferences setLocalStorageEnabled:]): Added.
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): Transfer the databases and local storage preferences to WebCore settings.

WebKit/win:

Reviewed by Darin Adler.

  • WebKit/win part of adding WebPreferences for controlling databases and local storage
  • Interfaces/IWebPreferencesPrivate.idl: Declared setDatabasesEnabled, databasesEnabled, setLocalStorageEnabled and localStorageEnabled.
  • WebPreferenceKeysPrivate.h: Added WebKitDatabasesEnabledPreferenceKey and WebKitLocalStorageEnabledPreferenceKey.
  • WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): Made databases and local storage enabled by default. (WebPreferences::setDatabasesEnabled): Added. (WebPreferences::databasesEnabled): Added. (WebPreferences::setLocalStorageEnabled): Added. (WebPreferences::localStorageEnabled): Added.
  • WebPreferences.h:
  • WebView.cpp: (WebView::notifyPreferencesChanged): Transfer the databases and local storage preferences to WebCore settings.
5:57 AM Changeset in webkit [38233] by staikos@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog-2008-08-10

Just adjusting email address in changelog.

Note: See TracTimeline for information about the timeline view.