⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 10, 2008:

11:57 PM Changeset in webkit [38294] by cwzwarich@webkit.org
  • 3 edits in trunk/JavaScriptCore

2008-11-10 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Oliver Hunt.

Make CTI::asInteger() a non-member function, since it needs no access to
any of CTI's member variables.

  • VM/CTI.cpp: (JSC::asInteger):
  • VM/CTI.h:
11:06 PM Changeset in webkit [38293] by Stephanie Lewis
  • 3 edits in trunk/WebCore

2008-11-10 Stephanie Lewis <Stephanie Lewis>

Reviewed by Dan Bernstein.

Clear the image source cache even if we haven't decoded any of the image data.
We use the image source cache when calculating layout.

  • loader/Cache.cpp: (WebCore::Cache::pruneDeadResources):
  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::destroyDecodedData):
10:04 PM Changeset in webkit [38292] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-10 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Maciej Stachowiak.

Use 'value' instead of 'js' in CTI as a name for JSValue* to match our
usual convention elsewhere.

  • VM/CTI.cpp: (JSC::CTI::emitGetArg): (JSC::CTI::emitGetPutArg): (JSC::CTI::getConstantImmediateNumericArg): (JSC::CTI::printOpcodeOperandTypes):
9:55 PM Changeset in webkit [38291] by cwzwarich@webkit.org
  • 4 edits in trunk/JavaScriptCore

2008-11-10 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Maciej Stachowiak.

Make CTI::getConstant() a member function of CodeBlock instead.

  • VM/CTI.cpp: (JSC::CTI::emitGetArg): (JSC::CTI::emitGetPutArg): (JSC::CTI::getConstantImmediateNumericArg): (JSC::CTI::printOpcodeOperandTypes): (JSC::CTI::privateCompileMainPass):
  • VM/CTI.h:
  • VM/CodeBlock.h: (JSC::CodeBlock::getConstant):
9:45 PM Changeset in webkit [38290] by cwzwarich@webkit.org
  • 4 edits in trunk/JavaScriptCore

2008-11-10 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Sam Weinig.

Rename CodeBlock::isConstant() to isConstantRegisterIndex().

  • VM/CTI.cpp: (JSC::CTI::emitGetArg): (JSC::CTI::emitGetPutArg): (JSC::CTI::getConstantImmediateNumericArg): (JSC::CTI::printOpcodeOperandTypes): (JSC::CTI::privateCompileMainPass):
  • VM/CodeBlock.h: (JSC::CodeBlock::isConstantRegisterIndex):
  • bytecompiler/CodeGenerator.cpp: (JSC::CodeGenerator::emitEqualityOp):
9:40 PM Changeset in webkit [38289] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

non-CTI build fix take 2

9:31 PM Changeset in webkit [38288] by barraclough@apple.com
  • 1 edit in trunk/JavaScriptCore/VM/Machine.cpp

non-CTI build fix

9:22 PM Changeset in webkit [38287] by cwzwarich@webkit.org
  • 3 edits in trunk/JavaScriptCore

2008-11-10 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Sam Weinig.

Remove the unused labels member variable of CodeBlock.

  • VM/CodeBlock.h:
  • VM/LabelID.h: (JSC::LabelID::setLocation):
9:09 PM Changeset in webkit [38286] by barraclough@apple.com
  • 7 edits in trunk/JavaScriptCore

2008-11-10 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Camron Zwarich.

Batch compile the set of static trampolines at the point Machine is constructed, using a single allocation.
Refactor out m_callFrame from CTI, since this is only needed to access the global data (instead store a
pointer to the global data directly, since this is available at the point the Machine is constructed).
Add a method to align the code buffer, to allow JIT generation for multiple trampolines in one block.

  • VM/CTI.cpp: (JSC::CTI::getConstant): (JSC::CTI::emitGetArg): (JSC::CTI::emitGetPutArg): (JSC::CTI::getConstantImmediateNumericArg): (JSC::CTI::printOpcodeOperandTypes): (JSC::CTI::CTI): (JSC::CTI::compileBinaryArithOp): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileGetByIdProto): (JSC::CTI::privateCompileGetByIdChain): (JSC::CTI::privateCompileCTIMachineTrampolines): (JSC::CTI::freeCTIMachineTrampolines):
  • VM/CTI.h: (JSC::CTI::compile): (JSC::CTI::compileGetByIdSelf): (JSC::CTI::compileGetByIdProto): (JSC::CTI::compileGetByIdChain): (JSC::CTI::compilePutByIdReplace): (JSC::CTI::compilePutByIdTransition): (JSC::CTI::compileCTIMachineTrampolines): (JSC::CTI::compilePatchGetArrayLength):
  • VM/Machine.cpp: (JSC::Machine::initialize): (JSC::Machine::~Machine): (JSC::Machine::execute): (JSC::Machine::tryCTICachePutByID): (JSC::Machine::tryCTICacheGetByID): (JSC::Machine::cti_op_call_JSFunction): (JSC::Machine::cti_vm_lazyLinkCall):
  • VM/Machine.h:
  • masm/X86Assembler.h: (JSC::JITCodeBuffer::isAligned): (JSC::X86Assembler::): (JSC::X86Assembler::align):
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
7:51 PM Changeset in webkit [38285] by mjs@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-11-10 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Antti Koivisto.


  • wtf/Vector.h: (WTF::VectorBufferBase::deallocateBuffer): Set capacity to 0 as well as size, otherwise shrinking capacity to 0 can fail to reset the capacity and thus cause a future crash. (WTF::Vector::~Vector): Shrink size not capacity; we only need to call destructors, the buffer will be freed anyway. (WTF::Vector::clear): Change this to shrinkCapacity(0), not just shrink(0). (WTF::::shrinkCapacity): Use shrink() instead of resize() for case where the size is greater than the new capacity, to work with types that have no default constructor.
7:38 PM Changeset in webkit [38284] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-10 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Maciej Stachowiak.

Split multiple definitions into separate lines.

  • VM/CTI.cpp: (JSC::CTI::compileBinaryArithOp):
5:26 PM Changeset in webkit [38283] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2008-11-10 Anders Carlsson <​andersca@apple.com>

Reviewed by Kevin Decker.

Move renewGState to the base class.


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView renewGState]):
  • Plugins/WebNetscapePluginView.mm:
5:23 PM Changeset in webkit [38282] by andersca@apple.com
  • 5 edits in trunk/WebKit/mac

2008-11-10 Anders Carlsson <​andersca@apple.com>

Reviewed by Kevin Decker.

Move start, stop and all the related methods down to WebBaseNetscapePluginView.


  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView updateAndSetWindow]): (-[WebBaseNetscapePluginView addWindowObservers]): (-[WebBaseNetscapePluginView removeWindowObservers]): (-[WebBaseNetscapePluginView start]): (-[WebBaseNetscapePluginView stop]): (-[WebBaseNetscapePluginView viewWillMoveToWindow:]): (-[WebBaseNetscapePluginView viewWillMoveToSuperview:]): (-[WebBaseNetscapePluginView viewDidMoveToWindow]): (-[WebBaseNetscapePluginView viewWillMoveToHostWindow:]): (-[WebBaseNetscapePluginView viewDidMoveToHostWindow]): (-[WebBaseNetscapePluginView windowWillClose:]): (-[WebBaseNetscapePluginView windowBecameKey:]): (-[WebBaseNetscapePluginView windowResignedKey:]): (-[WebBaseNetscapePluginView windowDidMiniaturize:]): (-[WebBaseNetscapePluginView windowDidDeminiaturize:]): (-[WebBaseNetscapePluginView loginWindowDidSwitchFromUser:]): (-[WebBaseNetscapePluginView loginWindowDidSwitchToUser:]): (-[WebBaseNetscapePluginView preferencesHaveChanged:]):
  • Plugins/WebNetscapePluginView.h:
  • Plugins/WebNetscapePluginView.mm:
5:13 PM Changeset in webkit [38281] by andersca@apple.com
  • 4 edits in trunk/WebKit/mac

2008-11-10 Anders Carlsson <​andersca@apple.com>

Reviewed by Kevin Decker.

Move rightMouseDown, rightMouseUp and sendActivateEvent to the base plugin view.
Add stubs for createPlugin, loadStream, shouldStop and destroyPlugin.


  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView windowFocusChanged:]): (-[WebBaseNetscapePluginView createPlugin]): (-[WebBaseNetscapePluginView loadStream]): (-[WebBaseNetscapePluginView destroyPlugin]): (-[WebBaseNetscapePluginView sendActivateEvent:]): (-[WebBaseNetscapePluginView rightMouseDown:]): (-[WebBaseNetscapePluginView rightMouseUp:]):
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView windowFocusChanged:]):
4:51 PM Changeset in webkit [38280] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2008-11-10 Anders Carlsson <​andersca@apple.com>

Reviewed by Kevin Decker.

Factor plug-in type specific code out to three new methods, createPlugin, destroyPlugin and loadStream.


  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView createPlugin]): (-[WebNetscapePluginView loadStream]): (-[WebNetscapePluginView start]): (-[WebNetscapePluginView shouldStop]): (-[WebNetscapePluginView destroyPlugin]): (-[WebNetscapePluginView stop]):
4:38 PM Changeset in webkit [38279] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2008-11-10 Anders Carlsson <​andersca@apple.com>

Fix Tiger build.


  • Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]):
4:29 PM Changeset in webkit [38278] by andersca@apple.com
  • 5 edits in trunk/WebKit/mac

2008-11-10 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Move even more code down to WebBaseNetscapePluginView, get rid of some unnecessary methods.


  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView focusChanged]): (-[WebBaseNetscapePluginView visibleRect]): (-[WebBaseNetscapePluginView acceptsFirstResponder]): (-[WebBaseNetscapePluginView setHasFocus:]): (-[WebBaseNetscapePluginView becomeFirstResponder]): (-[WebBaseNetscapePluginView resignFirstResponder]):
  • Plugins/WebNetscapePluginView.h:
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView focusChanged]): (-[WebNetscapePluginView tellQuickTimeToChill]): (-[WebNetscapePluginView updateAndSetWindow]): (-[WebNetscapePluginView start]): (-[WebNetscapePluginView stop]): (-[WebNetscapePluginView viewWillMoveToWindow:]): (-[WebNetscapePluginView createPluginScriptableObject]): (-[WebNetscapePluginView pluginView:receivedData:]): (-[WebNetscapePluginView pluginView:receivedError:]): (-[WebNetscapePluginView pluginViewFinishedLoading:]): (-[WebNetscapePluginView inputContext]): (-[WebNetscapePluginView hasMarkedText]): (-[WebNetscapePluginView insertText:]): (-[WebNetscapePluginView markedRange]): (-[WebNetscapePluginView selectedRange]): (-[WebNetscapePluginView setMarkedText:selectedRange:]): (-[WebNetscapePluginView unmarkText]): (-[WebNetscapePluginView validAttributesForMarkedText]): (-[WebNetscapePluginView attributedSubstringFromRange:]): (-[WebNetscapePluginView characterIndexForPoint:]): (-[WebNetscapePluginView doCommandBySelector:]): (-[WebNetscapePluginView firstRectForCharacterRange:]): (-[WebNetscapePluginView _viewHasMoved]): (-[WebNetscapePluginView _redeliverStream]):
3:43 PM Changeset in webkit [38277] by andersca@apple.com
  • 6 edits in trunk/WebKit/mac

2008-11-10 Anders Carlsson <​andersca@apple.com>

Reviewed by Kevin Decker.

Move timer handling code down to WebBaseNetscapePluginView.


  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView stopTimers]): (-[WebBaseNetscapePluginView startTimers]): (-[WebBaseNetscapePluginView restartTimers]):
  • Plugins/WebNetscapePluginView.h:
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView stopTimers]): (-[WebNetscapePluginView startTimers]): (-[WebNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
  • WebView/WebHTMLView.mm: (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]):
2:59 PM Changeset in webkit [38276] by andersca@apple.com
  • 8 edits in trunk/WebKit

WebKit:

2008-11-10 Anders Carlsson <​andersca@apple.com>

Reviewed by Kevin Decker.


Add WebHostedNetscapePluginView to the project.


  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2008-11-10 Anders Carlsson <​andersca@apple.com>

Reviewed by Kevin Decker.

Move a bunch of methods and ivars up to WebBaseNetscapePluginView.


  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView dealloc]): (-[WebBaseNetscapePluginView finalize]): (-[WebBaseNetscapePluginView removeTrackingRect]): (-[WebBaseNetscapePluginView resetTrackingRect]): (-[WebBaseNetscapePluginView dataSource]): (-[WebBaseNetscapePluginView webFrame]): (-[WebBaseNetscapePluginView webView]): (-[WebBaseNetscapePluginView currentWindow]):
  • Plugins/WebNetscapePluginEventHandlerCarbon.mm: (WebNetscapePluginEventHandlerCarbon::windowFocusChanged):
  • Plugins/WebNetscapePluginView.h:
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView sendEvent:isDrawRect:]): (-[WebNetscapePluginView sendActivateEvent:]): (-[WebNetscapePluginView restartTimers]): (-[WebNetscapePluginView setHasFocus:]): (-[WebNetscapePluginView mouseDown:]): (-[WebNetscapePluginView mouseUp:]): (-[WebNetscapePluginView mouseEntered:]): (-[WebNetscapePluginView mouseExited:]): (-[WebNetscapePluginView handleMouseMoved:]): (-[WebNetscapePluginView mouseDragged:]): (-[WebNetscapePluginView scrollWheel:]): (-[WebNetscapePluginView keyUp:]): (-[WebNetscapePluginView keyDown:]): (-[WebNetscapePluginView flagsChanged:]): (-[WebNetscapePluginView updateAndSetWindow]): (-[WebNetscapePluginView setWindowIfNecessary]): (-[WebNetscapePluginView start]): (-[WebNetscapePluginView stop]): (-[WebNetscapePluginView isStarted]): (-[WebNetscapePluginView dealloc]): (-[WebNetscapePluginView finalize]): (-[WebNetscapePluginView drawRect:]): (-[WebNetscapePluginView windowBecameKey:]): (-[WebNetscapePluginView preferencesHaveChanged:]): (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]): (-[WebNetscapePluginView webFrame:didFinishLoadWithReason:]): (-[WebNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]): (-[WebNetscapePluginView _viewHasMoved]):
2:27 PM Changeset in webkit [38275] by andersca@apple.com
  • 8 edits
    2 adds in trunk/WebKit/mac

2008-11-10 Anders Carlsson <​andersca@apple.com>

Reviewed by Kevin Decker and Mark Rowe.

Add a WebHostedNetscapePluginView class.


  • Plugins/WebHostedNetscapePluginView.h: Added.
  • Plugins/WebHostedNetscapePluginView.mm: Added.
  • Plugins/WebNetscapePluginPackage.h: Use the right define.


  • Plugins/WebPluginDatabase.mm: (-[WebPluginDatabase removePluginInstanceViewsFor:]): Check for WebBaseNetscapePluginView.


(-[WebPluginDatabase destroyAllPluginInstanceViews]):
Check for WebBaseNetscapePluginView.


  • WebCoreSupport/WebFrameLoaderClient.mm: (NetscapePluginWidget::NetscapePluginWidget): (NetscapePluginWidget::handleEvent): Use WebBaseNetscapePluginView.


(netscapePluginViewClass):
New function that returns the right netscape plugin view type to use.


(WebFrameLoaderClient::createPlugin):
Get the right class.


  • WebKitPrefix.h: Prefix the #define with WTF_.


  • WebView/WebHTMLView.mm: (-[NSArray _web_makePluginViewsPerformSelector:withObject:]): Check for WebBaseNetscapePluginView.


  • WebView/WebView.mm: Remove an unnecessary include.
2:12 PM Changeset in webkit [38274] by Adam Roben
  • 3 edits
    2 adds in trunk

Fix Bug 22161: Assertion failure in RenderThemeWin::systemColor when loading microsoftpdc.com

WebCore:

Fix Bug 22161: Assertion failure in RenderThemeWin::systemColor when
loading microsoftpdc.com

<​https://bugs.webkit.org/show_bug.cgi?id=22161>

Reviewed by Dan Bernstein.

Test: fast/css/outline-invert-assertion.html

  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::systemColor): If we can't determine a good Win32 system color to use, defer to RenderTheme instead of asserting. This matches what RenderThemeMac does.

LayoutTests:

Test for Bug 22161: Assertion failure in RenderThemeWin::systemColor
when loading microsoftpdc.com

<​https://bugs.webkit.org/show_bug.cgi?id=22161>

Note that this test would only fail if DumpRenderTree used
RenderThemeWin, which it doesn't. I did test that locally, though.

Reviewed by Dan Bernstein.

  • fast/css/outline-invert-assertion-expected.txt: Added.
  • fast/css/outline-invert-assertion.html: Added.
1:51 PM Changeset in webkit [38273] by Beth Dakin
  • 6 edits
    8 adds in trunk

WebCore:

2008-11-10 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Beth Dakin.

<rdar://problem/4037481> REGRESSION (Mail): pasting quoted text
into quoted text yields double-quoting


Don't nest inserted content in Mail blockquotes. Perform a
BreakBlockquoteCommand if we're in
one and insert the incoming fragment between the split blockquotes.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::shouldMerge): Renamed from -> source and to -> destination. (WebCore::ReplaceSelectionCommand::doApply):

LayoutTests:

2008-11-10 Beth Dakin <Beth Dakin>

Rubber stamped by Justin Garcia.

New tests for <rdar://problem/4037481> REGRESSION (Mail): pasting
quoted text into quoted text yields double-quoting

  • editing/pasteboard/paste-blockquote-into-blockquote-2.html: Added.
  • editing/pasteboard/paste-blockquote-into-blockquote.html: Added.
  • platform/mac/editing/pasteboard/paste-blockquote-into- blockquote-2-expected.checksum: Added.
  • platform/mac/editing/pasteboard/paste-blockquote-into- blockquote-2-expected.png: Added.
  • platform/mac/editing/pasteboard/paste-blockquote-into- blockquote-2-expected.txt: Added.
  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote- expected.checksum: Added.
  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote- expected.png: Added.
  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote- expected.txt: Added.


Test with new results because of this patch:

  • platform/mac/editing/pasteboard/merge-end-blockquote- expected.checksum:
  • platform/mac/editing/pasteboard/merge-end-blockquote- expected.png:
  • platform/mac/editing/pasteboard/merge-end-blockquote- expected.txt:
1:47 PM Changeset in webkit [38272] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config

Commit the current configuration of build.webkit.org.

1:45 PM Changeset in webkit [38271] by mrowe@apple.com
  • 5 edits in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/webkit

Commit the current configuration of build.webkit.org.

1:33 PM Changeset in webkit [38270] by andersca@apple.com
  • 6 edits in trunk/WebKit/mac

2008-11-10 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Don't use individual ivars for each plug-in vtable function. Instead, get them from the plugin package.


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]):
  • Plugins/WebNetscapePluginPackage.h:
  • Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]): (-[WebNetscapePluginPackage _unloadWithShutdown:]):
  • Plugins/WebNetscapePluginView.h:
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView sendEvent:isDrawRect:]): (-[WebNetscapePluginView setWindowIfNecessary]): (-[WebNetscapePluginView start]): (-[WebNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]): (-[WebNetscapePluginView createPluginScriptableObject]): (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]): (-[WebNetscapePluginView webFrame:didFinishLoadWithReason:]): (-[WebNetscapePluginView loadPluginRequest:]): (-[WebNetscapePluginView _createPlugin]): (-[WebNetscapePluginView _destroyPlugin]): (-[WebNetscapePluginView _printedPluginBitmap]):
1:00 PM Changeset in webkit [38269] by andersca@apple.com
  • 5 edits
    2 adds in trunk/WebKit

WebKit:

2008-11-10 Anders Carlsson <​andersca@apple.com>

Reviewed by Kevin Decker.

Add a new WebBaseNetscapePluginView class.


  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2008-11-10 Anders Carlsson <​andersca@apple.com>

Reviewed by Kevin Decker.

Add a new WebBaseNetscapePluginView class.

  • Plugins/WebBaseNetscapePluginView.h: Added.
  • Plugins/WebBaseNetscapePluginView.mm: Added. (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]): (-[WebBaseNetscapePluginView setAttributeKeys:andValues:]): (-[WebBaseNetscapePluginView handleMouseMoved:]):
  • Plugins/WebNetscapePluginView.h:
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView cut:]): (-[WebNetscapePluginView copy:]): (-[WebNetscapePluginView paste:]): (-[WebNetscapePluginView selectAll:]): (-[WebNetscapePluginView start]): (-[WebNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]):
12:25 PM Changeset in webkit [38268] by cwzwarich@webkit.org
  • 3 edits in trunk/JavaScriptCore

2008-11-10 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Geoff Garen.

Bug 22162: Remove cachedValueGetter from the JavaScriptCore API implementation
<​https://bugs.webkit.org/show_bug.cgi?id=22162>

There is no more need for the cachedValueGetter hack now that we have
PropertySlot::setValue(), so we should remove it.

  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h: (JSC::::getOwnPropertySlot):
12:20 PM Changeset in webkit [38267] by andersca@apple.com
  • 17 edits
    2 moves in trunk/WebKit

WebKit:

2008-11-10 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam Roben.


Rename WebBaseNetscapePluginView to WebNetscapePluginView.

  • StringsNotToBeLocalized.txt:
  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2008-11-10 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam Roben.


Rename WebBaseNetscapePluginView to WebNetscapePluginView.

  • Plugins/WebBaseNetscapePluginStream.h:
  • Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::WebNetscapePluginStream): (WebNetscapePluginStream::setPlugin):
  • Plugins/WebBaseNetscapePluginView.h: Removed.
  • Plugins/WebBaseNetscapePluginView.mm: Removed.
  • Plugins/WebNetscapePluginEventHandler.h: (WebNetscapePluginEventHandler::WebNetscapePluginEventHandler):
  • Plugins/WebNetscapePluginEventHandler.mm: (WebNetscapePluginEventHandler::create):
  • Plugins/WebNetscapePluginEventHandlerCarbon.h:
  • Plugins/WebNetscapePluginEventHandlerCarbon.mm: (WebNetscapePluginEventHandlerCarbon::WebNetscapePluginEventHandlerCarbon):
  • Plugins/WebNetscapePluginEventHandlerCocoa.h:
  • Plugins/WebNetscapePluginEventHandlerCocoa.mm: (WebNetscapePluginEventHandlerCocoa::WebNetscapePluginEventHandlerCocoa):
  • Plugins/WebNetscapePluginView.h: Copied from mac/Plugins/WebBaseNetscapePluginView.h.
  • Plugins/WebNetscapePluginView.mm: Copied from mac/Plugins/WebBaseNetscapePluginView.mm. (+[WebNetscapePluginView setCurrentPluginView:]): (+[WebNetscapePluginView currentPluginView]): (-[WebNetscapePluginView loadPluginRequest:]):
  • Plugins/WebPluginDatabase.mm: (-[WebPluginDatabase removePluginInstanceViewsFor:]): (-[WebPluginDatabase destroyAllPluginInstanceViews]):
  • Plugins/npapi.mm: (pluginViewForInstance): (NPN_MarkedTextAbandoned): (NPN_MarkedTextSelectionChanged):
  • WebCoreSupport/WebFrameLoaderClient.mm: (NetscapePluginWidget::NetscapePluginWidget): (NetscapePluginWidget::handleEvent): (WebFrameLoaderClient::createPlugin):
  • WebView/WebHTMLView.mm: (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): (-[NSArray _web_makePluginViewsPerformSelector:withObject:]):
  • WebView/WebView.mm:
10:38 AM Changeset in webkit [38266] by Adam Roben
  • 4 edits
    1 add in trunk

Fix Bug 22158: Would like to turn on WebCore logging channels via an environment variable

WebCore:

Fix Bug 22158: Would like to turn on WebCore logging channels via an
environment variable

<​https://bugs.webkit.org/show_bug.cgi?id=22158>

Logging channels can now be enabled by setting the WebCoreLogLevel
environment variable to a hexadecimal number.

Reviewed by Anders Carlsson.

  • WebCore.vcproj/WebCore.vcproj: Added LoggingWin.cpp.
  • platform/win/LoggingWin.cpp: Copied from WebCore/platform/mac/LoggingMac.mm. (WebCore::initializeWithUserDefault): Read in the WebCoreLogLevel environment variable, parse its value as a hexadecimal number, and turn the channel on/off based on whether the mask bit is set. (WebCore::InitializeLoggingChannelsIfNecessary): Initialize each logging channel in turn.

WebKit/win:

Fix Bug 22158: Would like to turn on WebCore logging channels via an
environment variable

<​https://bugs.webkit.org/show_bug.cgi?id=22158>

Reviewed by Anders Carlsson.

  • WebView.cpp: (WebView::initWithFrame): Call WebCore's InitializeLoggingChannelsIfNecessary.
10:17 AM Changeset in webkit [38265] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-10 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Darin Adler.

Bug 22152: Remove asObject() call from JSCallbackObject::getOwnPropertySlot()
<​https://bugs.webkit.org/show_bug.cgi?id=22152>

With the recent change to adopt asType() style cast functions with
assertions instead of static_casts in many places, the assertion for
the asObject() call in JSCallbackObject::getOwnPropertySlot() has been
failing when using any nontrivial client of the JavaScriptCore API.
The cast isn't even necessary to call slot.setCustom(), so it should
be removed.

  • API/JSCallbackObjectFunctions.h: (JSC::JSCallbackObject::getOwnPropertySlot):
9:06 AM Changeset in webkit [38264] by Darin Adler
  • 4 edits in trunk/WebCore

2008-11-10 Darin Adler <Darin Adler>

Reviewed by Adam Roben.

This broke when the meaning of FrameView::invalidate changed.
I changed setNeedsReapplyStyles to no longer depend on invalidate.

  • dom/Document.cpp: (WebCore::Document::shouldScheduleLayout): Removed the part of this function that duplicated what's already in FrameView::needsLayout, since the copy here left out a few key things. For example, it didn't handle the fact that "needs reapply styles" counts as needing layout.
  • page/Frame.cpp: (WebCore::Frame::setNeedsReapplyStyles): This called FrameView::invalidate before. There were two things wrong with that. 1) It requested that the entire view repaint even if the style change didn't necessitate that. 2) FrameView::invalidate no longer causes any repainting at all in certain cases, because of Hyatt's changes to how widgets and the host window are involved in the repainting process. So call FrameView::scheduleRelayout instead, which is more precisely what we want and need here.
  • page/FrameView.cpp: (WebCore::FrameView::scheduleRelayout): Add a call to needsLayout here so that Document::shouldScheduleLayout doesn't have to replicate the logic that's in needsLayout and can instead rely on the fact that it was already called. (WebCore::FrameView::needsLayout): Tweaked the comments and formatting in this function.
9:03 AM Changeset in webkit [38263] by Darin Adler
  • 2 edits in trunk/WebCore

2008-11-10 Darin Adler <Darin Adler>

Reviewed by Adam Roben.

  • speculative fix for <rdar://problem/5557243> crashes in Safari at WebCore::HTMLSelectElement::updateListBoxSelection + 280
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::updateListBoxSelection): Check index against size of vector before indexing into the vector.
7:55 AM Changeset in webkit [38262] by vestbo@webkit.org
  • 2 edits in trunk

2008-11-10 Tor Arne Vestbø <​tavestbo@trolltech.com>

Rubber-stamped by Simon Hausmann.

Distinguish between building from trunk and as part of Qt

7:42 AM Changeset in webkit [38261] by Darin Adler
  • 4 edits in trunk/BugsSite

2008-11-10 Darin Adler <Darin Adler>

  • globals.pl: Fix cases that are automatically generated, such as links in comments in bugs.
  • template/en/custom/attachment/created.html.tmpl: Fix the link on the "I just created an attachment" page.
  • template/en/custom/request/queue.html.tmpl: Fix the link in the queue page.
7:31 AM Changeset in webkit [38260] by Darin Adler
  • 2 edits in trunk/BugsSite

2008-11-10 Darin Adler <Darin Adler>

  • template/en/custom/request/email.txt.tmpl: Send review links instead of edit links when flags are set on a bug.
7:03 AM Changeset in webkit [38259] by ap@webkit.org
  • 3 edits in trunk/JavaScriptCore

Reviewed by Adam Roben.

A few coding style fixes for AVLTree.

  • wtf/AVLTree.h: Moved to WTF namespace, Removed "KJS_" from include guards. (WTF::AVLTree::Iterator::start_iter): Fixed indentation
  • runtime/JSArray.cpp: Added "using namepace WTF".
6:37 AM Changeset in webkit [38258] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

2008-11-10 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Rubber-stamped by Simon Hausmann.

To fit Qt API, scroll offset is a QPoint instead of a QSize.

  • Api/qwebframe.cpp: (QWebFrame::scrollOffset): (QWebFrame::setScrollOffset):
  • Api/qwebframe.h:
3:46 AM Changeset in webkit [38257] by Simon Hausmann
  • 2 edits in trunk

2008-11-10 Morten Sørvig <​msorvig@trolltech.com>

Reviewed by Simon Hausmann.

Make tests/auto/qwebframe compile on Qt/Mac.

3:46 AM Changeset in webkit [38256] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

2008-11-10 David Boddie <​dboddie@trolltech.com>

Reviewed by Simon Hausmann.

Doc: Fixed qdoc warnings by supplying function documentation.

3:45 AM Changeset in webkit [38255] by Simon Hausmann
  • 1 edit
    1 delete in trunk/WebKit/qt

2008-11-10 Tobias Koenig <​tobias.koenig@trolltech.com>

Reviewed by Simon Hausmann.

Removed old and stale prf file that breaks the MingW build.

3:45 AM Changeset in webkit [38254] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-11-10 Tom Cooksey <​thomas.cooksey@trolltech.com>

Reviewed by Tor Arne Vestbø.

Fix QtWebkit build failure on arm.

pen.widthF() is a qreal, which means it's a float on arm.

3:45 AM Changeset in webkit [38253] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

2008-11-10 Kavindra Palaraja <​kdpalara@trolltech.com>

Reviewed by Simon Hausmann.

Clarify QWebFrame/View::setHTML docs with regards to relative URLs

3:45 AM Changeset in webkit [38252] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2008-11-10 Joerg Bornemann <​joerg.bornemann@nokia.com>

Reviewed by Simon Hausmann

Don't define _CRT_RAND_S on Windows CE in the precompiled
header, to fix the CE build.

3:45 AM Changeset in webkit [38251] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-11-10 Morten Sørvig <​msorvig@trolltech.com>

Reviewed by Simon Hausmann.

Improve mouse wheel scolling on Qt/Cocoa.
Cocoa differs from Carbon (and other platforms I think) in that the
mouse wheel events we get have a much higher acceleration factor.

This submit switches over to scroll-per-pixel from scroll-per-line
for most of our scrolling views. This matches the native views
and works well with the increased acceleration.

Nov 9, 2008:

10:26 PM Changeset in webkit [38250] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-09 Cameron Zwarich <​zwarich@apple.com>

Not reviewed.

Speculatively fix the non-AllInOne build.

  • runtime/NativeErrorConstructor.cpp:
5:28 PM Changeset in webkit [38249] by Darin Adler
  • 15 edits
    1 delete in trunk/JavaScriptCore

2008-11-09 Darin Adler <Darin Adler>

Reviewed by Tim Hatcher.

  • VM/CodeBlock.h: Added include.
  • VM/Machine.cpp: (JSC::Machine::execute): Use the types from
DeclarationStacks as DeclarationStacks
rather than Node:: since "Node" really has little to do with it.
  • bytecompiler/CodeGenerator.cpp: (JSC::CodeGenerator::CodeGenerator): Ditto.
  • jsc.cpp: (Options::Options): Removed prettyPrint option. (runWithScripts): Ditto. (printUsageStatement): Ditto. (parseArguments): Ditto. (jscmain): Ditto.
  • parser/Grammar.y: Removed use of obsolete ImmediateNumberNode.
  • parser/Nodes.cpp: (JSC::ThrowableExpressionData::emitThrowError): Use inline functions instead of direct member access for ThrowableExpressionData values. (JSC::BracketAccessorNode::emitCode): Ditto. (JSC::DotAccessorNode::emitCode): Ditto. (JSC::NewExprNode::emitCode): Ditto. (JSC::EvalFunctionCallNode::emitCode): Ditto. (JSC::FunctionCallValueNode::emitCode): Ditto. (JSC::FunctionCallResolveNode::emitCode): Ditto. (JSC::FunctionCallBracketNode::emitCode): Ditto. (JSC::FunctionCallDotNode::emitCode): Ditto. (JSC::PostfixResolveNode::emitCode): Ditto. (JSC::PostfixBracketNode::emitCode): Ditto. (JSC::PostfixDotNode::emitCode): Ditto. (JSC::DeleteResolveNode::emitCode): Ditto. (JSC::DeleteBracketNode::emitCode): Ditto. (JSC::DeleteDotNode::emitCode): Ditto. (JSC::PrefixResolveNode::emitCode): Ditto. (JSC::PrefixBracketNode::emitCode): Ditto. (JSC::PrefixDotNode::emitCode): Ditto. (JSC::ThrowableBinaryOpNode::emitCode): Ditto. (JSC::InstanceOfNode::emitCode): Ditto. (JSC::ReadModifyResolveNode::emitCode): Ditto. (JSC::AssignResolveNode::emitCode): Ditto. (JSC::AssignDotNode::emitCode): Ditto. (JSC::ReadModifyDotNode::emitCode): Ditto. (JSC::AssignBracketNode::emitCode): Ditto. (JSC::ReadModifyBracketNode::emitCode): Ditto. (JSC::statementListEmitCode): Take a const StatementVector instead of a non-const one. Also removed unused statementListPushFIFO. (JSC::ForInNode::emitCode): Inline functions instead of member access. (JSC::ThrowNode::emitCode): Ditto. (JSC::EvalNode::emitCode): Ditto. (JSC::FunctionBodyNode::emitCode): Ditto. (JSC::ProgramNode::emitCode): Ditto.
  • parser/Nodes.h: Removed unused includes and forward declarations. Removed Precedence enum. Made many more members private instead of protected or public. Removed unused NodeStack typedef. Moved the VarStack and FunctionStack typedefs from Node to ScopeNode. Made Node::emitCode pure virtual and changed classes that don't emit any code to inherit from ParserRefCounted rather than Node. Moved isReturnNode from Node to StatementNode. Removed the streamTo, precedence, and needsParensIfLeftmost functions from all classes. Removed the ImmediateNumberNode class and make NumberNode::setValue nonvirtual.
  • parser/nodes2string.cpp: Removed.
5:19 PM Changeset in webkit [38248] by cwzwarich@webkit.org
  • 3 edits
    2 adds in trunk

2008-11-09 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Darin Adler.

Bug 19541: Null pointer in showModalDialog()
<​https://bugs.webkit.org/show_bug.cgi?id=19541>

Add null frame->page() checks to JSDOMWindowBase::canShowModalDialog()
and JSDOMWindowBase::canShowModalDialogNow()C

WebCore:

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::canShowModalDialog): (WebCore::canShowModalDialogNow):

LayoutTests:

  • fast/dom/null-page-show-modal-dialog-crash-expected.txt: Added.
  • fast/dom/null-page-show-modal-dialog-crash.html: Added.
5:04 PM Changeset in webkit [38247] by Darin Adler
  • 6 edits
    3 adds in trunk

JavaScriptCore:

2008-11-09 Darin Adler <Darin Adler>

Reviewed by Sam Weinig and Maciej Stachowiak.
Includes some work done by Chris Brichford.

Test: fast/js/large-expressions.html

1) Code generation is recursive, so takes stack proportional to the complexity

of the source code expression. Fixed by setting an arbitrary recursion limit
of 10,000 nodes.

2) Destruction of the syntax tree was recursive. Fixed by introducing a

non-recursive mechanism for destroying the tree.

  • bytecompiler/CodeGenerator.cpp: (JSC::CodeGenerator::CodeGenerator): Initialize depth to 0. (JSC::CodeGenerator::emitThrowExpressionTooDeepException): Added. Emits the code to throw a "too deep" exception.
  • bytecompiler/CodeGenerator.h: (JSC::CodeGenerator::emitNode): Check depth and emit an exception if we exceed the maximum depth.
  • parser/Nodes.cpp: (JSC::NodeReleaser::releaseAllNodes): Added. To be called inside node destructors to avoid recursive calls to destructors for nodes inside this one. (JSC::NodeReleaser::release): Added. To be called inside releaseNodes functions. Also added releaseNodes functions and calls to releaseAllNodes inside destructors for each class derived from Node that has RefPtr to other nodes. (JSC::NodeReleaser::adopt): Added. Used by the release function. (JSC::NodeReleaser::adoptFunctionBodyNode): Added.
  • parser/Nodes.h: Added declarations of releaseNodes and destructors in all classes that needed it. Eliminated use of ListRefPtr and releaseNext, which are the two parts of an older solution to the non-recursive destruction problem that works only for lists, whereas the new solution works for other graphs. Changed ReverseBinaryOpNode to use BinaryOpNode as a base class to avoid some duplicated code.

LayoutTests:

2008-11-09 Alexey Proskuryakov <​ap@webkit.org>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=22104
Javascript URL percent encoding/decoding broken by some characters

  • fast/loader/javascript-url-encoding-2-expected.txt:
  • fast/loader/javascript-url-encoding-2.html:
4:22 PM Changeset in webkit [38246] by Darin Adler
  • 2 edits in trunk/WebCore

2008-11-09 Darin Adler <Darin Adler>

  • try to fix Windows build
  • platform/graphics/Color.cpp: For some reason MSVC doesn't follow the rules about needed a separate definition for static const integer data members. Until I get to the bottom of this, put the definitions inside an ifdef.
12:19 PM Changeset in webkit [38245] by Darin Adler
  • 4 edits in trunk/WebKit/mac

2008-11-09 Darin Adler <Darin Adler>

Reviewed by John Sullivan.

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::frameLoadCompleted): Added comments, and got rid of a local variable to make this code match the code in the function below more closely. (WebFrameLoaderClient::provisionalLoadStarted): Added comments.
  • WebView/WebFrame.mm: (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]): Improved comment.
  • WebView/WebFrameView.mm: (-[WebFrameView _scrollView]): Tweaked formatting. (-[WebFrameView initWithFrame:]): Ditto. (-[WebFrameView setFrameSize:]): Added a comment and tweaked formatting. (-[WebFrameView viewDidMoveToWindow]): Added. This is the change that fixes the bug. Calls setDrawsBackground:YES as appropriate since moving the view out of the window to switch to another view disrupts the special technique for showing the old page during the start of loading. This is the identical reason for the setFrameSize: method above, and the code is almost the same.
11:50 AM Changeset in webkit [38244] by ddkilzer@apple.com
  • 6 edits in trunk/WebCore

BUILD FIX: Qt build broke after r38235.

Added HAVE(ACCESSIBILITY) header guards to platform implementation
source files.

  • page/gtk/AccessibilityObjectAtk.cpp: Added HAVE(ACCESSIBILITY) guards.
  • page/gtk/AccessibilityObjectWrapperAtk.cpp: Ditto.
  • page/qt/AccessibilityObjectQt.cpp: Ditto.
  • page/win/AccessibilityObjectWin.cpp: Ditto.
  • page/wx/AccessibilityObjectWx.cpp: Ditto.
11:08 AM Changeset in webkit [38243] by ap@webkit.org
  • 3 edits
    2 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=22104
Javascript URL percent encoding/decoding broken by some characters

Test: fast/loader/javascript-url-encoding-2.html

  • platform/KURL.cpp: (WebCore::encodeRelativeString): Don't try to break down javascript URLs.
10:20 AM Changeset in webkit [38242] by Darin Adler
  • 2 edits in trunk/WebCore

2008-11-09 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed and tweaked by Darin Adler.

  • platform/graphics/Color.cpp: Added definitions for the static data members in this class. Static data members need a definition, even when they are the simple integer constant kind that can be initialized in the header.
7:50 AM Changeset in webkit [38241] by Darin Adler
  • 8 edits in trunk/LayoutTests

2008-11-09 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

  • fast/canvas/gradient-addColorStop-with-invalid-color-expected.txt: Fixed spelling error: "gradieints".
  • fast/canvas/gradient-addColorStop-with-invalid-color.html: Regenerated with make-js-test-wrappers script; removes the canvas element that was in here.
  • fast/canvas/linearGradient-infinite-values.html: Ditto.
  • fast/canvas/radialGradient-infinite-values.html: Ditto.
  • fast/canvas/resources/gradient-addColorStop-with-invalid-color.js: Fixed spelling error and changed code to use createElement to make a canvas element rather than using getElementById to find an existing canvas element.
  • fast/canvas/resources/linearGradient-infinite-values.js: Ditto.
  • fast/canvas/resources/radialGradient-infinite-values.js: Ditto.
4:56 AM Companies and Organizations that have contributed to WebKit edited by ddkilzer@webkit.org
Added reference to KSVG2 (diff)
2:36 AM Companies and Organizations that have contributed to WebKit edited by staikos@kde.org
(diff)
12:04 AM Companies and Organizations that have contributed to WebKit edited by mjs@apple.com
(diff)
12:02 AM Companies and Organizations that have contributed to WebKit created by mjs@apple.com
Note: See TracTimeline for information about the timeline view.