⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 12, 2008:

11:35 PM Changeset in webkit [38367] by ap@webkit.org
  • 2 edits in trunk/WebKitTools

2008-11-12 Dmitry Titov <​dimich@chromium.org>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=22216

  • Scripts/build-webkit: Addes ENABLE_WORKERS to build-webkit so it's possible to build with workers enabled.
11:32 PM Changeset in webkit [38366] by ap@webkit.org
  • 4 edits
    2 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=22200
Crash when close event is dispatched to MessagePort due to document destruction

Test: fast/events/message-port-onclose.html

  • dom/MessagePort.cpp: (WebCore::MessagePort::contextDestroyed): Don't dispatch close event, even though HTML5 currently says that we should. It is not right for GC to have observable effects.
11:27 PM Changeset in webkit [38365] by ap@webkit.org
  • 24 edits
    2 adds in trunk/WebCore

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=22203
Implement Worker messaging

No test cases included, because this functionality is disabled by default.

The implementation is known to still have many race condition, but works quite well for
testing.

  • WebCore.xcodeproj/project.pbxproj: Added WorkerTask.{h,cpp}.
  • bindings/js/JSDOMBinding.cpp: (WebCore::markActiveObjectsForContext): Re-worded comments a little. (WebCore::markCrossHeapDependentObjectsForContext): Existing cross-heap GC protocol was incorrect, changed it to a much simpler (but still incorrect) version.
  • dom/WorkerTask.cpp: Added. (WebCore::WorkerTask::~WorkerTask):
  • dom/WorkerTask.h: Added. Tasks posted to workers implement this new interface.
  • bindings/js/JSDedicatedWorkerCustom.cpp: (WebCore::JSDedicatedWorker::mark): (WebCore::JSDedicatedWorker::connect):
  • dom/DedicatedWorker.h:
  • dom/DedicatedWorker.idl: Auto-generate event listener attributes. Renamed startConversation() to connect(), tracking WHATWG discussions.
  • dom/DedicatedWorker.cpp: (WebCore::WorkerConnectTask::WorkerConnectTask): A task that performs worker-side connect() operations. (WebCore::DedicatedWorker::DedicatedWorker): Initialize WorkerThread pointer. (WebCore::DedicatedWorker::connect): Connect() creates a pair of entangled ports, and posts one to worker. Since message port registration in ScriptExecutionContext is not thread safe, this port starts with a null context pointer. (WebCore::DedicatedWorker::notifyFinished): Since Worker methods should work immediately after creation, we have to queue tasks until after a WorkerThread object is created. Then we forward all queued tasks to its queue.
  • dom/EventTarget.cpp: (WebCore::EventTarget::toWorkerContext):
  • dom/EventTarget.h:
  • bindings/js/JSEventTarget.cpp: (WebCore::toJS): Added cases for WorkerContext, which is now an EventTarget, too.
  • bindings/js/JSWorkerContext.h: Added JSWorkerContext::put() to make onconnect settable.
  • bindings/js/JSWorkerContext.cpp: (WebCore::JSWorkerContext::mark): Mark event listeners. (WebCore::JSWorkerContext::createPrototype): Fixed a typo, use the right StructureID. (WebCore::JSWorkerContext::put): Implemented. (WebCore::jsWorkerContextPrototypeFunctionAddEventListener): Added an EventTarget implementation. (WebCore::jsWorkerContextPrototypeFunctionRemoveEventListener): Ditto. (WebCore::jsWorkerContextPrototypeFunctionDispatchEvent): Ditto. (WebCore::jsWorkerContextOnconnect): Added. (WebCore::setJSWorkerContextOnconnect): Added.
  • bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate): Made it actually work by adding necessary setup.
  • bindings/js/WorkerScriptController.h: (WebCore::WorkerScriptController::initScriptIfNeeded): Check the right variable - it is the wrapper that may not be initialized yet.
  • dom/ActiveDOMObject.cpp: (WebCore::ActiveDOMObject::ActiveDOMObject): (WebCore::ActiveDOMObject::~ActiveDOMObject): Assert being called from the correct thread, as active DOM object tracking is not thread safe.
  • dom/ScriptExecutionContext.h: Added a Task interface and a postTask() method, to be used for asynchronously executing tasks in context's thread.
  • dom/ScriptExecutionContext.cpp: (WebCore::ProcessMessagesSoonTask): Changed from a Timer to a Task (WebCore::ScriptExecutionContext::ScriptExecutionContext): Removed m_firedMessagePortTimer. It was an optimization that couldn't be easily preserved without introducing race conditions in multithreading case. (WebCore::ScriptExecutionContext::processMessagePortMessagesSoon): Use postTask(). (WebCore::ScriptExecutionContext::dispatchMessagePortEvents): Added a comment explaining why it's OK to not ref() ports in a frozen copy. (WebCore::ScriptExecutionContext::createdMessagePort): Assert that we're not being called from a wrong thread. (WebCore::ScriptExecutionContext::destroyedMessagePort): Ditto. (WebCore::ScriptExecutionContextTaskTimer): Part of ScriptExecutionContext::Task implementation - use Timer if posting from main thread to main thread. (WebCore::ScriptExecutionContextTaskWorkerTask): Another part - use WorkerTask if posting to a worker. (WebCore::PerformTaskContext::PerformTaskContext): Finally, use callOnMainThread() if posting to main thread from a secondary one. (WebCore::performTask): A helper function for callOnMainThread(). (WebCore::ScriptExecutionContext::postTask): Use one of the above implementations.
  • dom/MessagePort.h: Fixed message queue to keep EventData pointers - otherwise, we would ref/deref EventData::message from different threads, which is not allowed.
  • dom/MessagePort.cpp: (WebCore::MessagePortCloseEventTask): Use a task instead of a timer to work across threads. (WebCore::MessagePort::EventData::create): Updated for EventData being refcountable now. (WebCore::MessagePort::EventData::EventData): Ditto. (WebCore::MessagePort::MessagePort): ScriptExecutionContext is now allowed to be null at first, because we need to create ports for posting to other threads, and it is not possible to register in a context from another thread. (WebCore::MessagePort::clone): Always create ports with null contexts - it is now message receiver's job to set the context. (WebCore::MessagePort::postMessage): Enable posting to ports that are not attached to any context yet. (WebCore::MessagePort::startConversation): Ditto. Data port is always posted unattached. (WebCore::MessagePort::contextDestroyed): Assert that we had a context. (WebCore::MessagePort::attachToContext): Called when receiving a data port to register in context. (WebCore::MessagePort::scriptExecutionContext): Moved from header, as the function is virtual. (WebCore::MessagePort::dispatchMessages): Attach data port to receiving context. Use postTask(). (WebCore::MessagePort::queueCloseEvent): Use postTask(). (WebCore::MessagePort::hasPendingActivity): Reworded comment a little. As mentioned above, MessagePort cross-heap GC is still quite wrong.
  • dom/WorkerContext.h: Made WorkerContext an event target, added onconnect attribute.
  • dom/WorkerContext.cpp: Keep a pointer to WorkerThread. It is only used for debug assertions now, but there is no harm in tracking it in release builds, too.
  • dom/WorkerThread.cpp: (WebCore::WorkerThread::create): WorkerThread is refcountable, construct with create(). (WebCore::WorkerThread::workerThread): Implemented a message loop.
  • dom/WorkerThread.h: (WebCore::WorkerThread::threadID): Also only used for assertions. (WebCore::WorkerThread::messageQueue): Return a reference to queue, so clients can post to it.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::postMessage): MessagePort::clone() no longer takes a context, as it always sets it to null. (WebCore::DOMWindow::postMessageTimerFired): Attach data port to receiving context.
11:17 PM Changeset in webkit [38364] by krit@webkit.org
  • 3 edits
    3 adds in trunk

2008-11-12 Dirk Schulze <​vbs85@gmx.de>

WebCore:

Reviewed Darin Adler.

use strokeColor.alpha() instead of fillColor.alpha()
on GraphicsContext::strokePath()

[Canvas] Transparent fillStyle stops line rendering
​https://bugs.webkit.org/show_bug.cgi?id=21888

Test: fast/canvas/canvas-stroke-empty-fill.html

  • ChangeLog:
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::strokePath):

LayoutTests:

Reviewed by Darin Adler.

Check behavior of canvas.stroke() on transparent fillStyle()

  • fast/canvas/canvas-stroke-empty-fill-expected.txt: Added.
  • fast/canvas/canvas-stroke-empty-fill.html: Added.
  • fast/canvas/canvas-stroke-empty-fill.js: Added.
11:17 PM Changeset in webkit [38363] by Stephanie Lewis
  • 2 edits in trunk/WebKit/mac

2008-11-12 Stephanie Lewis <Stephanie Lewis>

Fix Mac build.

  • Panels/WebAuthenticationPanel.m:
10:08 PM Changeset in webkit [38362] by Stephanie Lewis
  • 2 edits in trunk/WebCore

2008-11-12 Stephanie <Stephanie Lewis>

Reviewed by Mark Rowe.

Fix context leak in XSLStyleSheets.
See bug ​https://bugs.webkit.org/show_bug.cgi?id=15715

  • xml/XSLStyleSheet.cpp: (WebCore::XSLStyleSheet::parseString):
8:47 PM Changeset in webkit [38361] by sullivan@apple.com
  • 5 edits in trunk/WebKit

WebKit:

2008-11-12 John Sullivan <​sullivan@apple.com>

fixed <rdar://problem/3839110> Authentication dialogs talk about passwords being sent "in the clear"

Reviewed by Tim Hatcher

  • English.lproj/Localizable.strings:
  • StringsNotToBeLocalized.txt: updated for this change

WebKit/mac:

2008-11-12 John Sullivan <​sullivan@apple.com>

fixed <rdar://problem/3839110> Authentication dialogs talk about passwords being sent "in the clear"

Reviewed by Tim Hatcher

  • Panels/WebAuthenticationPanel.m: (-[WebAuthenticationPanel setUpForChallenge:]): use "unencrypted" instead of "in the clear". Also, use the "Your log-in information will be sent securely" version when the receiving server is https, regardless of whether it uses basic or digest authentication.
8:26 PM Changeset in webkit [38360] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-11-12 Alp Toker <​alp@nuanti.com>

autotools: List web worker-related headers needed for a successful
build. distcheck is passing again with this change.

  • GNUmakefile.am:
7:57 PM Changeset in webkit [38359] by mrowe@apple.com
  • 4 edits in tags/Safari-6528.4.3

Versioning.

7:57 PM Changeset in webkit [38358] by mrowe@apple.com
  • 2 edits in tags/Safari-6528.4.3/WebKit/mac

Merge r37827.

7:39 PM Changeset in webkit [38357] by mrowe@apple.com
  • 1 copy in tags/Safari-6528.4.3

New tag.

6:30 PM Changeset in webkit [38356] by alp@webkit.org
  • 4 edits in trunk

2008-11-12 Alp Toker <​alp@nuanti.com>

autotools build system fix-up only. Add FloatQuad.h to the source
lists and sort them.

6:04 PM Changeset in webkit [38355] by Darin Adler
  • 2 edits in trunk/WebKit/mac

2008-11-12 Darin Adler <Darin Adler>

Reviewed by Mark Rowe.

  • WebView/WebFrameView.mm: (-[WebFrameView viewDidMoveToWindow]): Add missing null check.
5:41 PM Changeset in webkit [38354] by mitz@apple.com
  • 5 edits
    40 adds in trunk/LayoutTests

2008-11-12 Pierre-Olivier Latour <​pol@apple.com>

Reviewed by Dan Bernstein.

Updated reference images so that all pixel tests now "pass" on 10.4.11 PowerPC + r38347.
​https://bugs.webkit.org/show_bug.cgi?id=21821

Checked-in specific reference images for pixel tests that are valid on Tiger but fail
because difference with reference image due to text rendering is greater than 1.0%

  • platform/mac-tiger/svg/carto.net: Added.
  • platform/mac-tiger/svg/carto.net/selectionlist-expected.checksum: Added.
  • platform/mac-tiger/svg/carto.net/selectionlist-expected.png: Added.
  • platform/mac-tiger/svg/custom/feComponentTransfer-Gamma-expected.checksum: Added.
  • platform/mac-tiger/svg/custom/feComponentTransfer-Gamma-expected.png: Added.
  • platform/mac-tiger/svg/text/text-align-01-b-expected.checksum: Added.
  • platform/mac-tiger/svg/text/text-align-01-b-expected.png: Added.
  • platform/mac-tiger/svg/text/text-align-02-b-expected.checksum: Added.
  • platform/mac-tiger/svg/text/text-align-02-b-expected.png: Added.
  • platform/mac-tiger/svg/text/text-align-04-b-expected.checksum: Added.
  • platform/mac-tiger/svg/text/text-align-04-b-expected.png: Added.
  • platform/mac-tiger/svg/text/text-fonts-01-t-expected.checksum: Added.
  • platform/mac-tiger/svg/text/text-fonts-01-t-expected.png: Added.
  • platform/mac-tiger/svg/text/text-text-03-b-expected.checksum: Added.
  • platform/mac-tiger/svg/text/text-text-03-b-expected.png: Added.
  • platform/mac-tiger/svg/text/text-tselect-01-b-expected.checksum: Added.
  • platform/mac-tiger/svg/text/text-tselect-01-b-expected.png: Added.
  • platform/mac-tiger/svg/text/text-tspan-01-b-expected.checksum: Added.
  • platform/mac-tiger/svg/text/text-tspan-01-b-expected.png: Added.
  • platform/mac-tiger/svg/text/text-ws-01-t-expected.checksum: Added.
  • platform/mac-tiger/svg/text/text-ws-01-t-expected.png: Added.
  • platform/mac-tiger/svg/text/text-ws-02-t-expected.checksum: Added.
  • platform/mac-tiger/svg/text/text-ws-02-t-expected.png: Added.
  • platform/mac-tiger/svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum: Added.
  • platform/mac-tiger/svg/W3C-SVG-1.1/filters-color-01-b-expected.png: Added.
  • platform/mac-tiger/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.checksum: Added.
  • platform/mac-tiger/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png: Added.

svg/batik/paints/gradientLimit.svg is rendering different on Tiger and Leopard
​https://bugs.webkit.org/show_bug.cgi?id=22219

  • platform/mac-tiger/svg/batik: Added.
  • platform/mac-tiger/svg/batik/paints: Added.
  • platform/mac-tiger/svg/batik/paints/gradientLimit-expected.checksum: Added.
  • platform/mac-tiger/svg/batik/paints/gradientLimit-expected.png: Added.

svg/custom/mask-excessive-malloc.svg is failing on Tiger
​https://bugs.webkit.org/show_bug.cgi?id=22218

  • platform/mac-tiger/svg/custom/mask-excessive-malloc-expected.checksum: Added.
  • platform/mac-tiger/svg/custom/mask-excessive-malloc-expected.png: Added.

svg/W3C-SVG-1.1/pservers-grad-17-b.svg is failing on Leopard
​https://bugs.webkit.org/show_bug.cgi?id=22220

  • platform/mac-leopard/svg: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.checksum: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.png:

svg/custom/foreign-object-skew.svg is failing on Leopard
​https://bugs.webkit.org/show_bug.cgi?id=22221

  • platform/mac-leopard/svg/custom: Added.
  • platform/mac-leopard/svg/custom/foreign-object-skew-expected.checksum: Added.
  • platform/mac-leopard/svg/custom/foreign-object-skew-expected.png: Added.
  • platform/mac/svg/custom/foreign-object-skew-expected.checksum:
  • platform/mac/svg/custom/foreign-object-skew-expected.png:
5:32 PM Changeset in webkit [38353] by Simon Fraser
  • 17 edits
    4 adds in trunk

2008-11-12 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein

​https://bugs.webkit.org/show_bug.cgi?id=22212

Rename absoluteOutlineBox() to absoluteOutlineBounds(), to indicate that
it may be the bounding outline box of a transformed element, and fix it
to respect transforms by mapping the outline box to an absolute quad and
taking the enclosing rect.

RenderBox::localToAbsoluteQuad() can no longer assert that there is no
LayoutState, but LayoutState cannot be used during quad mapping (it knows
nothing about transforms).

Finally, fix a bug in RenderBox::localToAbsoluteQuad() which was getting
borderTopExtra() from the object, rather than its container (as localToAbsolute()
does).

Test: fast/repaint/transform-absolute-child.html

5:22 PM Changeset in webkit [38352] by ggaren@apple.com
  • 1 edit in trunk/LayoutTests/ChangeLog

dyslexics untie\!

5:20 PM Changeset in webkit [38351] by ggaren@apple.com
  • 2 edits in trunk/LayoutTests

2008-11-12 Geoffrey Garen <​ggaren@apple.com>

Roll in r38322, onw that test failures have been fixed.


  • fast/js/global-recursion-on-full-stack-expected.txt:
4:51 PM Changeset in webkit [38350] by jchaffraix@webkit.org
  • 6 edits in branches/XBL2/WebCore

2008-11-12 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Darin Adler.

Bug 22133: [XBL] Add shorter method to get the global XBLBindingManager

Renamed XBBindingManager::sharedInstance() to bindingManager().

Suggested by Eric Seidel.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::removeBindings):
  • dom/Document.cpp: (WebCore::Document::~Document): (WebCore::Document::recalcStyleSelector): (WebCore::Document::addBindingSheet): (WebCore::Document::removeBindingSheet):
  • dom/Element.cpp: (WebCore::Element::~Element): (WebCore::Element::addBinding): (WebCore::Element::removeBinding): (WebCore::Element::hasBinding):
  • xbl/XBLBindingManager.cpp: (WebCore::bindingManager):
  • xbl/XBLBindingManager.h:
4:48 PM Changeset in webkit [38349] by ggaren@apple.com
  • 11 edits in trunk/JavaScriptCore

2008-11-12 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.


Fixed ​https://bugs.webkit.org/show_bug.cgi?id=22192
+37 failures in fast/profiler


along with Darin's review comments in
​https://bugs.webkit.org/show_bug.cgi?id=22174
Simplified op_call by nixing its responsibility for moving the value of
"this" into the first argument slot

  • VM/Machine.cpp: (JSC::returnToThrowTrampoline): (JSC::throwStackOverflowError): (JSC::Machine::cti_register_file_check): (JSC::Machine::cti_op_call_arityCheck): (JSC::Machine::cti_vm_throw): Moved the throw logic into a function, since functions are better than macros.
  • bytecompiler/CodeGenerator.cpp: (JSC::CodeGenerator::emitCall): (JSC::CodeGenerator::emitConstruct): Ensure that the function register is preserved if profiling is enabled, since the profiler uses that register.
  • runtime/JSGlobalData.h: Renamed throwReturnAddress to exceptionLocation, because I had a hard time understanding what "throwReturnAddress" meant.
4:44 PM Changeset in webkit [38348] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-11-12 Alp Toker <​alp@nuanti.com>

Build fixes for r38346. FloatQuad.cpp is missing:

1) #include "config.h"
2) #include <algorithm> for various mathematical definitions it uses.

  • platform/graphics/FloatQuad.cpp:
4:24 PM Changeset in webkit [38347] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

2008-11-12 Pierre-Olivier Latour <​pol@apple.com>

Reviewed by Dan Bernstein.

Skip fast/repaint/body-background-image.html test as it is not reliable.

​https://bugs.webkit.org/show_bug.cgi?id=21913

  • platform/mac/Skipped:
3:43 PM Changeset in webkit [38346] by Simon Fraser
  • 41 edits
    2 adds in trunk/WebCore

2008-11-12 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

​https://bugs.webkit.org/show_bug.cgi?id=21942
​https://bugs.webkit.org/show_bug.cgi?id=18557

Add methods which can be used to map renderer-local rectangles
to quads in absolute coordinates, taking transforms into account:

localToAbsoluteQuad() converts a local rect into an absolute quad.
collectAbsoluteLineBoxQuads() is an analogue of addLineBoxRects()

that works with quads.

absoluteQuads() is an analogue of absoluteRects(), for quads.

Use the quad methods to fix the inspector highlight for transformed
elements.

3:04 PM Changeset in webkit [38345] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2008-11-12 Anders Carlsson <​andersca@apple.com>

Reviewed by Kevin Decker.

Fix stupid bug.


  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView createPlugin]):
2:53 PM Changeset in webkit [38344] by mitz@apple.com
  • 1 edit
    1 delete in trunk/LayoutTests

2008-11-12 Dan Bernstein <​mitz@apple.com>

  • remove an empty directory
  • platform/mac-leopard/http: Removed.
  • platform/mac-leopard/http/tests: Removed.
  • platform/mac-leopard/http/tests/security: Removed.
  • platform/mac-leopard/http/tests/security/dataURL: Removed.
1:54 PM Changeset in webkit [38343] by Adam Roben
  • 2 edits in trunk/WebCore

Fix Bug 22178: Build errors in WebKit Cairo port

<​https://bugs.webkit.org/show_bug.cgi?id=22178>

Reviewed by Mark Rowe.

  • platform/graphics/cairo/PatternCairo.cpp: Correct build error under Visual Studio. (WebCore::Pattern::createPlatformPattern):
1:49 PM Changeset in webkit [38342] by Adam Roben
  • 2 edits in trunk/WebCore

Fix a typo in the include path for the Release_Cairo configuration

  • WebCore.vcproj/WebCore.vcproj: Fixed "caro" -> "cairo" typo.
1:02 PM Changeset in webkit [38341] by sfalken@apple.com
  • 1 edit in trunk/WebKit/win/WebKitPrefix.cpp

Touch precompiled header wrapper to fix build.

12:44 PM Changeset in webkit [38340] by mitz@apple.com
  • 4 edits in trunk/LayoutTests/platform/mac/fast

Set svn:mime-type to image/png on .png files that did not have it

12:28 PM Changeset in webkit [38339] by Simon Fraser
  • 2 edits in trunk/WebCore

2008-11-12 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

​https://bugs.webkit.org/show_bug.cgi?id=17840
Patch 2

Code cleanup in RenderBox::computeAbsoluteRepaintRect().

  • rendering/RenderBox.cpp: (WebCore::RenderBox::computeAbsoluteRepaintRect):
12:22 PM Changeset in webkit [38338] by Simon Fraser
  • 3 edits
    8 adds in trunk

2008-11-12 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

​https://bugs.webkit.org/show_bug.cgi?id=17840

Fix repainting when the transform on a positioned element changes.
In computeAbsoluteRepaintRect(), add the offsets due to relative positioning,
and being in a positioned container after applying the transform to the local
rect.

Tests: fast/repaint/transform-absolute-in-positioned-container.html

fast/repaint/transform-relative-position.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::computeAbsoluteRepaintRect):
12:08 PM Changeset in webkit [38337] by justin.garcia@apple.com
  • 7 edits
    2 adds in trunk

WebCore:

2008-11-12 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Beth Dakin.


<rdar://problem/5495723> Selecting and deleting quoted text quotes other text
<rdar://problem/4775313> Deleting lines from the bottom of a messages leaves the last blank line quoted


We don't want to merge into a block if it will mean changing the quote level of content after deleting
selections that contain a whole number paragraphs plus a line break, since it is unclear to most users
that such a selection actually ends at the start of the next paragraph. Instead we want to completely
remove the selected paragraph(s) and all evidence of the first one's quote level. This matches TextEdit behavior
for indented paragraphs.


  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializePositionData): For the selections described above, do not try to merge after the deletion. Instead try and prune the start block or blocks if they've been emptied so that we remove evidence of the deleted paragraphs' quote level. (WebCore::DeleteSelectionCommand::mergeParagraphs): Try and prune the start block(s) if necessary. Also make sure that the caret is placed correctly so that it ends up on the same line that the deleted selection started on, instead of one higher.
  • editing/DeleteSelectionCommand.h:
  • editing/htmlediting.cpp: (WebCore::numEnclosingMailBlockquotes): Added.
  • editing/htmlediting.h:

LayoutTests:

2008-11-12 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Beth Dakin.


<rdar://problem/5495723> Selecting and deleting quoted text quotes other text
<rdar://problem/4775313> Deleting lines from the bottom of a messages leaves the last blank line quoted

  • editing/deleting/5495723-expected.txt: Added.
  • editing/deleting/5495723.html: Added.
  • platform/mac/editing/deleting/delete-4038408-fix-expected.txt: Change demonstrates that we now behave correctly when pressing delete when the caret is just after empty quoted paragraphs.
11:40 AM Changeset in webkit [38336] by sfalken@apple.com
  • 1 edit in trunk/WebCore/WebCorePrefix.cpp

Touch precompiled header wrapper to try and fix build.

10:35 AM Changeset in webkit [38335] by mitz@apple.com
  • 50 edits in trunk/LayoutTests

2008-11-12 Pierre-Olivier Latour <​pol@apple.com>

Reviewed by Dan Bernstein.

Updated reference images so that all pixel tests now "pass" on 10.5.5 Intel + r38318.
​https://bugs.webkit.org/show_bug.cgi?id=21821

Removed empty directory.

  • platform/mac-leopard/http: Removed.
  • platform/mac-leopard/http/tests: Removed.
  • platform/mac-leopard/http/tests/security: Removed.
  • platform/mac-leopard/http/tests/security/dataURL: Removed.

Test doesn't repaint entire view so result is corrupted by previous test
​https://bugs.webkit.org/show_bug.cgi?id=21916

  • platform/mac/Skipped:

Test is passing but original reference image was invalid.

  • platform/mac/fast/backgrounds/size/backgroundSize05-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize05-expected.png:

Invalid image tiling
​https://bugs.webkit.org/show_bug.cgi?id=21915

  • platform/mac/fast/backgrounds/size/backgroundSize19-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize19-expected.png:

SVG not rendering
​https://bugs.webkit.org/show_bug.cgi?id=21910

  • platform/mac/fast/backgrounds/svg-as-background-1-expected.checksum:
  • platform/mac/fast/backgrounds/svg-as-background-1-expected.png:
  • platform/mac/fast/backgrounds/svg-as-background-2-expected.checksum:
  • platform/mac/fast/backgrounds/svg-as-background-2-expected.png:
  • platform/mac/fast/backgrounds/svg-as-background-3-expected.checksum:
  • platform/mac/fast/backgrounds/svg-as-background-3-expected.png:
  • platform/mac/fast/backgrounds/svg-as-background-4-expected.checksum:
  • platform/mac/fast/backgrounds/svg-as-background-4-expected.png:
  • platform/mac/fast/backgrounds/svg-as-background-5-expected.checksum:
  • platform/mac/fast/backgrounds/svg-as-background-5-expected.png:
  • platform/mac/fast/backgrounds/svg-as-background-6-expected.checksum:
  • platform/mac/fast/backgrounds/svg-as-background-6-expected.png:
  • platform/mac/fast/backgrounds/svg-as-mask-expected.checksum:
  • platform/mac/fast/backgrounds/svg-as-mask-expected.png:
  • platform/mac/fast/borders/svg-as-border-image-2-expected.checksum:
  • platform/mac/fast/borders/svg-as-border-image-2-expected.png:
  • platform/mac/fast/borders/svg-as-border-image-expected.checksum:
  • platform/mac/fast/borders/svg-as-border-image-expected.png:
  • platform/mac/fast/images/svg-as-background-expected.checksum:
  • platform/mac/fast/images/svg-as-background-expected.png:
  • platform/mac/fast/images/svg-as-image-expected.checksum:
  • platform/mac/fast/images/svg-as-image-expected.png:
  • platform/mac/fast/images/svg-as-relative-image-expected.checksum:
  • platform/mac/fast/images/svg-as-relative-image-expected.png:
  • platform/mac/fast/images/svg-as-tiled-background-expected.checksum:
  • platform/mac/fast/images/svg-as-tiled-background-expected.png:

Possible Flash failure
​https://bugs.webkit.org/show_bug.cgi?id=21912

  • platform/mac/fast/dynamic/flash-replacement-test-expected.checksum:
  • platform/mac/fast/dynamic/flash-replacement-test-expected.png:

Repaint failure
​https://bugs.webkit.org/show_bug.cgi?id=21913

  • platform/mac/fast/repaint/body-background-image-expected.checksum:
  • platform/mac/fast/repaint/body-background-image-expected.png:

Excessive repainting
​https://bugs.webkit.org/show_bug.cgi?id=21914

  • platform/mac/fast/repaint/float-overflow-expected.checksum:
  • platform/mac/fast/repaint/float-overflow-expected.png:
  • platform/mac/fast/repaint/float-overflow-right-expected.checksum:
  • platform/mac/fast/repaint/float-overflow-right-expected.png:

No video images
​https://bugs.webkit.org/show_bug.cgi?id=21911

  • platform/mac/media/video-aspect-ratio-expected.checksum:
  • platform/mac/media/video-aspect-ratio-expected.png:
  • platform/mac/media/video-controls-rendering-expected.checksum:
  • platform/mac/media/video-controls-rendering-expected.png:
  • platform/mac/media/video-display-toggle-expected.checksum:
  • platform/mac/media/video-display-toggle-expected.png:
  • platform/mac/media/video-layer-crash-expected.checksum:
  • platform/mac/media/video-layer-crash-expected.png:
  • platform/mac/media/video-transformed-expected.checksum:
  • platform/mac/media/video-transformed-expected.png:
3:31 AM Changeset in webkit [38334] by barraclough@apple.com
  • 3 edits
    2 adds in trunk

JavaScriptCore:

2008-11-12 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Cameron Zwarich.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=22201
Integer conversion in array.length was safe signed values,
but the length is unsigned.

  • VM/CTI.cpp: (JSC::CTI::privateCompilePatchGetArrayLength):

LayoutTests:

2008-11-12 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Cameron Zwarich.

Test for ​https://bugs.webkit.org/show_bug.cgi?id=22201

  • fast/js/pic/cached-array-length-access-expected.txt: Added.
  • fast/js/pic/cached-array-length-access.html: Added.
2:51 AM Changeset in webkit [38333] by vestbo@webkit.org
  • 6 edits in trunk

2008-11-10 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon Hausmann.

Move _web_encodingForResource from WebKit into WebCore and change return type

This change is needed to implement NSAPI in WebCore for Mac, see:

​https://bugs.webkit.org/show_bug.cgi?id=21427

2:44 AM Changeset in webkit [38332] by vestbo@webkit.org
  • 6 edits in trunk

2008-11-10 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon Hausmann.

Moved the implementation of _webkit_isCaseInsensitiveEqualToString to
WebCore's WebCoreNSStringExtras as _stringIsCaseInsensitiveEqualToString.

This change is needed to implement NSAPI in WebCore for Mac, see:

​https://bugs.webkit.org/show_bug.cgi?id=21427

1:51 AM Changeset in webkit [38331] by vestbo@webkit.org
  • 3 edits in trunk/WebKit/qt

2008-11-11 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Reviewed by Tor Arne Vestbø and Simon Hausmann.

Use QPalette::Base (instead of QPalette::Background) for the page
background.

  • Api/qwebframe.cpp: (QWebFramePrivate::updateBackground):
  • Api/qwebview.cpp: (QWebView::QWebView):
1:34 AM Changeset in webkit [38330] by cwzwarich@webkit.org
  • 12 edits in trunk

2008-11-12 Cameron Zwarich <​zwarich@apple.com>

Rubber-stamped by Mark Rowe.

Roll out r38322 due to test failures on the bots.

JavaScriptCore:

  • VM/CTI.cpp: (JSC::CTI::compileOpCallSetupArgs): (JSC::CTI::compileOpCall): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases):
  • VM/CTI.h:
  • VM/CodeBlock.cpp: (JSC::CodeBlock::dump):
  • VM/Machine.cpp: (JSC::Machine::callEval): (JSC::Machine::dumpCallFrame): (JSC::Machine::dumpRegisters): (JSC::Machine::execute): (JSC::Machine::privateExecute): (JSC::Machine::throwStackOverflowPreviousFrame): (JSC::Machine::cti_register_file_check): (JSC::Machine::cti_op_call_arityCheck): (JSC::Machine::cti_op_call_NotJSFunction): (JSC::Machine::cti_op_construct_JSConstruct): (JSC::Machine::cti_op_construct_NotJSConstruct): (JSC::Machine::cti_op_call_eval): (JSC::Machine::cti_vm_throw):
  • VM/Machine.h:
  • bytecompiler/CodeGenerator.cpp: (JSC::CodeGenerator::emitCall): (JSC::CodeGenerator::emitCallEval): (JSC::CodeGenerator::emitConstruct):
  • bytecompiler/CodeGenerator.h:
  • parser/Nodes.cpp: (JSC::EvalFunctionCallNode::emitCode): (JSC::FunctionCallValueNode::emitCode): (JSC::FunctionCallResolveNode::emitCode): (JSC::FunctionCallBracketNode::emitCode): (JSC::FunctionCallDotNode::emitCode):
  • parser/Nodes.h: (JSC::ScopeNode::neededConstants):

LayoutTests:

  • fast/js/global-recursion-on-full-stack-expected.txt:

Nov 11, 2008:

7:30 PM Changeset in webkit [38329] by Stephanie Lewis
  • 3 edits
    2 adds in trunk

2008-11-11 Stephanie <Stephanie Lewis>

Reviewed by Dan Bernstein.

Null check image data before setting it as image source.

Test: fast/images/image-empty-data.html

  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::destroyDecodedData):

Test loading an image with no data.

  • fast/images/image-empty-data-expected.txt: Added.
  • fast/images/image-empty-data.html: Added.
7:09 PM Changeset in webkit [38328] by adele@apple.com
  • 2 edits in trunk/WebCore

2008-11-11 Adele Peterson <​adele@apple.com>

Reviewed by Tim Hatcher.

Remove ifdef so future OS versions can use the new delegate method.

  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::didSendBodyDataDelegateExists):
5:53 PM Changeset in webkit [38327] by eric@webkit.org
  • 14 edits in trunk/WebCore

Reviewed by Antti Koivisto and Sam Weinig.

Clean up HTMLTokenizer a litle
​https://bugs.webkit.org/show_bug.cgi?id=22188

Rename pendingScripts to m_pendingScripts
Rename scriptNode to m_scriptNode make the type specific
Rename pendingSrc to m_pendingSrc
Rename currentPrependingSrc to m_currentPrependingSrc
Rename noMoreData to m_noMoreData and cBuffer to m_cBuffer
Remove long-since-dead kdDebug and qDebug calls
Rename brokenComments to m_brokenComments
Remove HTMLTokenizer includes and document the rest
Rename src to m_src
Rename parser to m_parser and make it an OwnPtr
Rename inWrite to m_inWrite and jsProxy to scriptController
Rename brokenServer to m_brokenServer
Rename buffer to m_buffer and dest to m_dest
Rename size to m_bufferSize
Rename attrName to m_attrName
Rename searchStopper to m_searchStopper and searchStopperLen to m_searchStopperLen
Rename scriptCode* to m_scriptCode* and change scriptCodeMax to m_scriptCodeCapacity
Rename scriptStartLineno to m_currentScriptTagStartLineNumber and tagStartLineno to m_currentTagStartLineNumber
Rename scriptSrc to m_scriptTagSrcAttrValue and scriptSrcCharset to m_scriptTagCharsetAttrValue -- a bit unwieldy, but more precise
Rename flat to selfClosingTag
Rename currToken to m_currentToken

  • css/CSSParser.cpp:
  • dom/XMLTokenizer.cpp:
  • dom/XMLTokenizerLibxml2.cpp:
  • html/HTMLDocument.cpp:
  • html/HTMLElement.cpp:
  • html/HTMLFormControlElement.cpp:
  • html/HTMLParser.h:
  • html/HTMLTokenizer.cpp: (WebCore::Token::addAttribute): (WebCore::HTMLTokenizer::HTMLTokenizer): (WebCore::HTMLTokenizer::reset): (WebCore::HTMLTokenizer::begin): (WebCore::HTMLTokenizer::processListing): (WebCore::HTMLTokenizer::parseSpecial): (WebCore::HTMLTokenizer::scriptHandler): (WebCore::HTMLTokenizer::scriptExecution): (WebCore::HTMLTokenizer::parseComment): (WebCore::HTMLTokenizer::parseServer): (WebCore::HTMLTokenizer::parseProcessingInstruction): (WebCore::HTMLTokenizer::parseText): (WebCore::HTMLTokenizer::parseEntity): (WebCore::HTMLTokenizer::parseTag): (WebCore::HTMLTokenizer::write): (WebCore::HTMLTokenizer::processingData): (WebCore::HTMLTokenizer::end): (WebCore::HTMLTokenizer::finish): (WebCore::HTMLTokenizer::processToken): (WebCore::HTMLTokenizer::processDoctypeToken): (WebCore::HTMLTokenizer::~HTMLTokenizer): (WebCore::HTMLTokenizer::enlargeBuffer): (WebCore::HTMLTokenizer::enlargeScriptBuffer): (WebCore::HTMLTokenizer::notifyFinished): (WebCore::HTMLTokenizer::setSrc):
  • html/HTMLTokenizer.h: (WebCore::Token::Token): (WebCore::Token::reset): (WebCore::HTMLTokenizer::processingContentWrittenByScript): (WebCore::HTMLTokenizer::htmlParser): (WebCore::HTMLTokenizer::checkBuffer): (WebCore::HTMLTokenizer::checkScriptBuffer):
  • html/HTMLViewSourceDocument.h:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::leftRelOffset): (WebCore::RenderBlock::rightRelOffset): (WebCore::RenderBlock::lineWidth):
  • xml/XSLTProcessor.cpp:
5:37 PM Changeset in webkit [38326] by Simon Fraser
  • 3 edits in trunk/WebKitSite

2008-11-11 Simon Fraser <Simon Fraser>

Update leaves animation sample.

  • blog-files/leaves/index.html:
  • blog-files/leaves/leaves.css:
5:35 PM Changeset in webkit [38325] by dino@apple.com
  • 2 edits in trunk/WebKitSite

2008-11-11 Dean Jackson <​dino@apple.com>

Removed quotes in animation name value.

  • blog-files/pulse.html:
4:49 PM Changeset in webkit [38324] by dino@apple.com
  • 1 edit
    1 add in trunk/WebKitSite

2008-11-11 Dean Jackson <​dino@apple.com>

Added a smaller version of a screenshot.

  • blog-files/leaves-screenshot-small.jpg: Added.
4:32 PM Changeset in webkit [38323] by dino@apple.com
  • 1 edit
    17 adds in trunk/WebKitSite

2008-11-11 Dean Jackson <​dino@apple.com>

Add a bunch of examples for CSS Animation blog draft.

  • blog-files/bounce.html: Added.
  • blog-files/bounce.png: Added.
  • blog-files/leaves-screenshot.jpg: Added.
  • blog-files/leaves/images/apple-touch-icon.png: Added.
  • blog-files/leaves/images/backgroundLeaves.jpg: Added.
  • blog-files/leaves/images/realLeaf1.png: Added.
  • blog-files/leaves/images/realLeaf2.png: Added.
  • blog-files/leaves/images/realLeaf3.png: Added.
  • blog-files/leaves/images/realLeaf4.png: Added.
  • blog-files/leaves/images/textBackground.png: Added.
  • blog-files/leaves/index.html: Added.
  • blog-files/leaves/leaves.css: Added.
  • blog-files/leaves/leaves.js: Added.
  • blog-files/pulse.html: Added.
  • blog-files/pulse.png: Added.
4:32 PM Changeset in webkit [38322] by ggaren@apple.com
  • 12 edits in trunk

2008-11-11 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin Adler.


Fixed ​https://bugs.webkit.org/show_bug.cgi?id=22174
Simplified op_call by nixing its responsibility for moving the value of
"this" into the first argument slot.

Instead, the caller emits an explicit load or mov instruction, or relies
on implicit knowledge that "this" is already in the first argument slot.
As a result, two operands to op_call are gone: firstArg and thisVal.


SunSpider and v8 tests show no change in bytecode or CTI.

  • VM/CTI.cpp: (JSC::CTI::compileOpCallSetupArgs): (JSC::CTI::compileOpCallEvalSetupArgs): (JSC::CTI::compileOpConstructSetupArgs): Split apart these three versions of setting up arguments to op_call, because they're more different than they are the same -- even more so with this patch.

(JSC::CTI::compileOpCall): Updated for the fact that op_construct doesn't
match op_call anymore.

(JSC::CTI::privateCompileMainPass):
(JSC::CTI::privateCompileSlowCases): Merged a few call cases. Updated
for changes mentioned above.

  • VM/CTI.h:
  • VM/CodeBlock.cpp: (JSC::CodeBlock::dump): Updated for new bytecode format of call / construct.
  • VM/Machine.cpp: (JSC::Machine::callEval): Updated for new bytecode format of call / construct.

(JSC::Machine::dumpCallFrame):
(JSC::Machine::dumpRegisters): Simplified these debugging functions,
taking advantage of the new call frame layout.

(JSC::Machine::execute): Fixed up the eval version of execute to be
friendlier to calls in the new format.

(JSC::Machine::privateExecute): Implemented the new call format in
bytecode.

(JSC::Machine::cti_op_call_NotJSFunction):
(JSC::Machine::cti_op_construct_JSConstruct):
(JSC::Machine::cti_op_construct_NotJSConstruct):
(JSC::Machine::cti_op_call_eval): Updated CTI helpers to match the new
call format.


Fixed a latent bug in stack overflow checking that is now hit because
the register layout has changed a bit -- namely: when throwing a stack
overflow exception inside an op_call helper, we need to account for the
fact that the current call frame is only half-constructed, and use the
parent call frame instead.

  • VM/Machine.h:
  • bytecompiler/CodeGenerator.cpp: (JSC::CodeGenerator::emitCall): (JSC::CodeGenerator::emitCallEval): (JSC::CodeGenerator::emitConstruct):
  • bytecompiler/CodeGenerator.h: Updated codegen to match the new call format.
  • parser/Nodes.cpp: (JSC::EvalFunctionCallNode::emitCode): (JSC::FunctionCallValueNode::emitCode): (JSC::FunctionCallResolveNode::emitCode): (JSC::FunctionCallBracketNode::emitCode): (JSC::FunctionCallDotNode::emitCode):
  • parser/Nodes.h: (JSC::ScopeNode::neededConstants): ditto

2008-11-10 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin Adler.


Updated a test after fixing ​https://bugs.webkit.org/show_bug.cgi?id=22174
Simplified op_call by nixing its responsibility for moving the value of
"this" into the first argument slot.

  • fast/js/global-recursion-on-full-stack-expected.txt: This test passes a little differently now, because the register layout has changed. Specifically, the stack overflow now happens in the call to f() instead of the initiation of the <script> tag, so it is caught, and it does not log an exception to the console.
4:28 PM Changeset in webkit [38321] by weinig@apple.com
  • 4 edits in trunk/WebCore

2008-11-11 Sam Weinig <​sam@webkit.org>

Reviewed by Dan Bernstein.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=22189
Track CachedScript decoded data

We now track the decoded size of CachedScripts in the Cache allowing
them to accounted for when deciding when to evict data. The decoded
data itself can be evicted when Cache pressure gets high enough through
CachedScript::destroyDecodedData.

  • loader/CachedResource.h: (WebCore::CachedResource::allClientsRemoved): (WebCore::CachedResource::destroyDecodedData):
  • loader/CachedScript.cpp: (WebCore::CachedScript::script): (WebCore::CachedScript::data): (WebCore::CachedScript::destroyDecodedData):
  • loader/CachedScript.h:
3:39 PM Changeset in webkit [38320] by cwzwarich@webkit.org
  • 8 edits
    1 delete in trunk

2008-11-11 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Geoff Garen.

Remove pointless dependencies on the now-deleted kjs directory and
mentions of it in comments that are no longer relevant.

JavaScriptCore:

  • ForwardingHeaders/JavaScriptCore/JSLock.h: Removed.

WebCore:

  • WebCore.pro:
  • webcore-base.bkl:

WebKit/qt:

  • WebKit_pch.h:

WebKit/wx:

  • presets/wxwebkit.bkl:
3:26 PM Changeset in webkit [38319] by adachan@apple.com
  • 2 edits in trunk/WebKitLibraries

Fix: ​https://bugs.webkit.org/show_bug.cgi?id=22187
Bug 22187: CLEARTYPE_QUALITY flag is not supported on Win2000


Update window versions to correspond to Windows XP.

Reviewed by Steve Falkenburg.

  • win/tools/vsprops/common.vsprops:
2:45 PM Changeset in webkit [38318] by mitz@apple.com
  • 16 edits in trunk

WebCore:

Reviewed by Adam Roben.

WebCore part of adding a master volume control for media elements in a WebView

  • WebCore.base.exp: Exported WebCore::Page::setMediaVolume().
  • dom/Document.cpp: (WebCore::Document::mediaVolumeDidChange): Added. Called by the Page when the media volume is changed. (WebCore::Document::registerForMediaVolumeCallbacks): Added. Allows elements to register for a callback when the media volume is changed. (WebCore::Document::unregisterForMediaVolumeCallbacks): Added. Allows elements to unregister for the callback.
  • dom/Document.h:
  • dom/Element.h: (WebCore::Element::mediaVolumeDidChange): Added an empty implementation.
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Added a call to registerForMediaVolumeCallbacks(). (WebCore::HTMLMediaElement::~HTMLMediaElement): Added a call to unregisterForMediaVolumeCallbacks(). (WebCore::HTMLMediaElement::updateVolume): Changed to multiply the element's intrinsic volume by the master volume from the page. (WebCore::HTMLMediaElement::mediaVolumeDidChange): Added. Calls updateVolume().
  • html/HTMLMediaElement.h:
  • page/Page.cpp: (WebCore::Page::Page): Initialize m_mediaVolume to 1. (WebCore::Page::setMediaVolume): Added. Calls mediaVolumeDidChange() on every document in the page when the master volume changes.
  • page/Page.h: (WebCore::Page::mediaVolume): Added this getter.

WebKit/mac:

Reviewed by Adam Roben.

WebKit/mac part of adding a master volume control for media elements in a WebView

  • WebView/WebView.mm: (-[WebView setMediaVolume:]): Added. (-[WebView mediaVolume]): Added.
  • WebView/WebViewPrivate.h:

WebKit/win:

Reviewed by Adam Roben.

WebKit/win part of adding a master volume control for media elements in a WebView

  • Interfaces/IWebViewPrivate.idl: Added setMediaVolume() and mediaVolume().
  • WebView.cpp: (WebView::setMediaVolume): Added. (WebView::mediaVolume): Added.
  • WebView.h:
2:31 PM Changeset in webkit [38317] by andersca@apple.com
  • 1 edit
    6 deletes in trunk/LayoutTests

2008-11-11 Pierre-Olivier Latour <​pol@apple.com>

Reviewed by Mark Rowe.

Removed invalid bases incorrectly checked-in in r38305.

​https://bugs.webkit.org/show_bug.cgi?id=22185

  • platform/mac-tiger/fast/text/international/complex-character-based-fallback-expected.checksum: Removed.
  • platform/mac-tiger/fast/text/international/complex-character-based-fallback-expected.png: Removed.
  • platform/mac-tiger/fast/text/international/complex-character-based-fallback-expected.txt: Removed.
  • platform/mac-tiger/fast/text/international/hindi-spacing-expected.checksum: Removed.
  • platform/mac-tiger/fast/text/international/hindi-spacing-expected.png: Removed.
  • platform/mac-tiger/fast/text/international/hindi-spacing-expected.txt: Removed.
2:25 PM Changeset in webkit [38316] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix broken dependencies building JavaScriptCore on a freezing cold cat, caused
by failure to update all instances of "kjs" to their new locations.

2:13 PM Changeset in webkit [38315] by ddkilzer@apple.com
  • 2 edits in trunk/WebKit/mac

2008-11-11 Aaron Golden <​agolden@apple.com>

Bug 22134: -[WebHistoryItem dictionaryRepresentation] accesses past the end of a vector

<​https://bugs.webkit.org/show_bug.cgi?id=22134>

Reviewed by Geoff Garen.

  • History/WebHistoryItem.mm: (-[WebHistoryItem initFromDictionaryRepresentation:]): (-[WebHistoryItem dictionaryRepresentation]):
1:49 PM Changeset in webkit [38314] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Rubber-stamped by Adam Roben.

  • wtf/AVLTree.h: (WTF::AVLTree::Iterator::start_iter): Fix indentation a little more.
1:11 PM Changeset in webkit [38313] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-11 Cameron Zwarich <​zwarich@apple.com>

Rubber-stamped by Sam Weinig.

Clean up EvalCodeCache to match our coding style a bit more.

  • VM/EvalCodeCache.h: (JSC::EvalCodeCache::get):
12:43 PM Changeset in webkit [38312] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2008-11-11 David Hyatt <​hyatt@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=22182

Fix problems with scrollbars when the OS setting for clicks in the track jumping the thumb to that location
is turned on. Make sure to only jump the thumb if the click happens in the track. Also fix some math
errors when jumping the thumb that cause dragging after the jump to incorrectly jump the thumb again.

Reviewed by Adele

  • platform/Scrollbar.cpp: (WebCore::Scrollbar::mouseDown):
12:06 PM Changeset in webkit [38311] by cwzwarich@webkit.org
  • 6 edits
    1 copy in trunk/JavaScriptCore

2008-11-11 Cameron Zwarich <​zwarich@apple.com>

Rubber-stamped by Sam Weinig.

Bug 22179: Move EvalCodeCache from CodeBlock.h into its own file
<​https://bugs.webkit.org/show_bug.cgi?id=22179>

  • GNUmakefile.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • VM/CodeBlock.h:
  • VM/EvalCodeCache.h: Copied from VM/CodeBlock.h.
  • VM/Machine.cpp:
11:58 AM Changeset in webkit [38310] by Beth Dakin
  • 12 edits
    4 adds in trunk

WebCore:

2008-11-11 Beth Dakin <Beth Dakin>

Reviewed by Darin Adler.

Fix for <rdar://problem/5089327> Too much indentation when pasting
quoted paragraphs

This patch re-addresses pasting blockquotes into blockquotes. It
backs out most of revision 38273. 38273 fixed the bug by inserting
the pasted content as a sibling blockquote node to the pre-existing
blockquote node. The problem with that is that by default,
blockquotes have a giant margin, so visually, this can be weird.
This patch instead inserts the pasted content as siblings of the
the content already inside the outer blockquote, and then removes
the blockquote node from the pasted content itself, so that it
doesn't nest itself into the outer blockquote.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):

Move contains() from Element to Node since there is nothing
Element-specific about it.

  • dom/Element.cpp:
  • dom/Element.h:
  • dom/Node.cpp: (WebCore::Node::contains):
  • dom/Node.h:

LayoutTests:

2008-11-11 Beth Dakin <Beth Dakin>

Reviewed by Darin Adler.

Tests for <rdar://problem/5089327> Too much indentation when
pasting quoted paragraphs

This is a new test:

  • editing/pasteboard/paste-blockquote-into-blockquote-3.html: Added.
  • platform/mac/editing/pasteboard/paste-blockquote-into- blockquote-3-expected.checksum: Added.
  • platform/mac/editing/pasteboard/paste-blockquote-into- blockquote-3-expected.png: Added.
  • platform/mac/editing/pasteboard/paste-blockquote-into- blockquote-3-expected.txt: Added.

The results for these tests previously reflected the behavior
implemented in revision 38273. We have since decided that that
behavior is wrong and we changed it with this patch.

  • platform/mac/editing/pasteboard/merge-end-blockquote- expected.checksum:
  • platform/mac/editing/pasteboard/merge-end-blockquote- expected.png:
  • platform/mac/editing/pasteboard/merge-end-blockquote- expected.txt:
  • platform/mac/editing/pasteboard/paste-blockquote-into- blockquote-2-expected.txt:
  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote- expected.txt:
11:50 AM Changeset in webkit [38309] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2008-11-11 David Hyatt <​hyatt@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=17997

Stop using the new Leopard API tiling call for scaled tiles when drawing background images. The method
is buggy. Fall back to using the slower (and more correct) pattern tiling that Tiger still uses. This
is a Leopard-only workaround, since the API has been fixed on Snow Leopard.

Reviewed by John Sullivan

  • platform/graphics/cg/ImageCG.cpp: (WebCore::Image::drawPattern):
11:41 AM Changeset in webkit [38308] by krit@webkit.org
  • 5 edits in trunk/LayoutTests

2008-11-11 Dirk Schulze <​krit@webkit.org>

Reviewed by Dave Hyatt.

Pattern transform check was too strict for Cg. Scaling can cause a wrong
color on the borders of the scaled object.

Correct expected result of the tests.

  • fast/canvas/canvas-pattern-transform-expected.txt:
  • fast/canvas/canvas-pattern-transform.html:
  • fast/canvas/canvas-pattern-transform.js:
  • fast/canvas/canvas-radial-gradient-spreadMethod-expected.txt:
11:18 AM Changeset in webkit [38307] by hyatt@apple.com
  • 2 edits
    4 adds in trunk

2008-11-10 David Hyatt <​hyatt@apple.com>

Disable the Aqua look for menu lists when full page zoom is turned on. Because the control is buggy
when scaling and because it's impossible to paint into an offscreen bitmap without completely rewriting
how we draw the control on Mac, our only real option for now is to just switch to our styled look when zoomed.

Reviewed by Adam Roben

  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::isControlStyled):
10:31 AM Changeset in webkit [38306] by cwzwarich@webkit.org
  • 3 edits in trunk/JavaScriptCore

2008-11-11 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Sam Weinig.

Remove the 'm_' prefix from the fields of the SwitchRecord struct.

  • VM/CTI.cpp: (JSC::CTI::privateCompile):
  • VM/CTI.h: (JSC::SwitchRecord): (JSC::SwitchRecord::SwitchRecord):
10:26 AM Changeset in webkit [38305] by mitz@apple.com
  • 27 edits
    18 adds
    640 deletes in trunk/LayoutTests

2008-11-11 Pierre-Olivier Latour <​pol@apple.com>

Rubber-stamped by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=21821

Removed pixel results in platform/mac-tiger that were only slightly different
(within 1% tolerance) from the platform/mac results.
Removed results in platform/mac-tiger where the results in platform/mac were
also correct for Tiger.
Also updated results in platform/mac-tiger that were out of date.

Made sure every test that has a specific mac-tiger render tree output also has matching images.

(file listing elided)

9:59 AM Changeset in webkit [38304] by Darin Adler
  • 2 edits in trunk/WebCore

2008-11-11 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

  • editing/visible_units.cpp: (WebCore::nextLinePosition): Use RenderObject::node instead of RenderObject::element to check editingIgnoresContent. It makes sense to use the associated DOM node for this, even in cases of anonymous content, and it avoids the case where element() can be 0. (WebCore::previousLinePosition): Ditto.
9:54 AM Changeset in webkit [38303] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-11 Cameron Zwarich <​zwarich@apple.com>

Rubber-stamped by Sam Weinig.

Make asInteger() a static function so that it has internal linkage.

  • VM/CTI.cpp: (JSC::asInteger):
9:40 AM Changeset in webkit [38302] by krit@webkit.org
  • 3 edits
    3 adds in trunk

2008-11-11 Dirk Schulze <​vbs85@gmx.de>

WebCore:

Reviewed by Darin Adler.

Removed default: in applySpreadMethod. This causes the problems
in radial gradients. We don't need CAIRO_EXTEND_NONE in SVG, Canvas
or CSS.

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::applySpreadMethod):

LayoutTests:

Reviewed by Darin Adler.

Check behavior of default spreadMethod on radial gradients.

  • fast/canvas/canvas-radial-gradient-spreadMethod-expected.txt: Added.
  • fast/canvas/canvas-radial-gradient-spreadMethod.html: Added.
  • fast/canvas/canvas-radial-gradient-spreadMethod.js: Added.
5:32 AM Changeset in webkit [38301] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2008-11-11 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Reviewed by Tor Arne Vestbø.

Fix crash when rendering the file chooser.
Also proper implementation for multi-selected files.

  • platform/qt/FileChooserQt.cpp: (WebCore::FileChooser::basenameForWidth):
3:35 AM Changeset in webkit [38300] by krit@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2008-11-11 Dirk Schulze <​vbs85@gmx.de>

Reviewed by Oliver Hunter.

Added test to check behavior on transformations of patterns in canvas.

  • fast/canvas/canvas-pattern-transform-expected.txt: Added.
  • fast/canvas/canvas-pattern-transform.html: Added.
  • fast/canvas/canvas-pattern-transform.js: Added.
3:05 AM Changeset in webkit [38299] by krit@webkit.org
  • 4 edits in trunk/WebCore
1:51 AM Changeset in webkit [38298] by mjs@apple.com
  • 4 edits in trunk/JavaScriptCore

2008-11-11 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Mark Rowe.


  • shrink CodeBlock and AST related Vectors to exact fit (5-10M savings on membuster test)


No perf regression combined with the last patch (each seems like a small regression individually)

  • bytecompiler/CodeGenerator.cpp: (JSC::CodeGenerator::generate):
  • parser/Nodes.h: (JSC::SourceElements::releaseContentsIntoVector):
  • wtf/Vector.h: (WTF::Vector::shrinkToFit):
1:11 AM Changeset in webkit [38297] by mitz@apple.com
  • 2023 edits
    35 adds in trunk/LayoutTests

2008-11-11 Pierre-Olivier Latour <​pol@apple.com>

Rubber-stamped by Dan Bernstein

​https://bugs.webkit.org/show_bug.cgi?id=21821

Remaining set of updated expected pixel results. This includes http/,
media/, plugins/, scrollbars/, tables/, transforms/, transitions/ and
webarchive/.

(file listing elided)

1:10 AM Changeset in webkit [38296] by mjs@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-11-11 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Mark Rowe.


  • remove inline capacity from declaration stacks (15M savings on membuster test)

No perf regression on SunSpider or V8 test combined with other upcoming memory improvement patch.


12:06 AM Changeset in webkit [38295] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-11 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Oliver Hunt.

While r38286 removed the need for the m_callFrame member variable of
CTI, it should be also be removed.

  • VM/CTI.h:
Note: See TracTimeline for information about the timeline view.