⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 13, 2008:

8:39 PM Changeset in webkit [38386] by mrowe@apple.com
  • 3 edits in trunk/WebKit/mac

Fix the build.

Don't use NSPICTPboardType on systems where it is deprecated. The system will take care of converting
from this format to a format that we can understand.

  • WebCoreSupport/WebPasteboardHelper.mm:

(WebPasteboardHelper::insertablePasteboardTypes):

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
(+[WebHTMLView _insertablePasteboardTypes]):
(-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):

8:29 PM Changeset in webkit [38385] by Adam Roben
  • 2 edits in trunk/WebKit/win

Fix Bug 22244: Webkit nightly builds crash with Safari 3.2

<​https://bugs.webkit.org/show_bug.cgi?id=22244>

r36652 added IWebViewPrivate::clearMainFrameName into the middle of
the IWebViewPrivate interface, which modifies the part of the
IWebViewPrivate vtable that Safari 3.2 relies on.

Reviewed by Dan Bernstein.

  • Interfaces/IWebViewPrivate.idl: Move clearMainFrameName to the end of the interface.
8:26 PM Changeset in webkit [38384] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

Reviewed by Adam Roben.

Add a basic Scons-based build system for building
Chromium-Mac WebCore.
​https://bugs.webkit.org/show_bug.cgi?id=21991

The build currently fails due to missing files from our
platform directory (platform skia and platform chromium)
I will be sending those up shortly in separate patches.
I expect it will be a while before our WebCore build links.

  • SConstruct: Added.
  • WebCore.scons: Added.
8:26 PM Changeset in webkit [38383] by eric@webkit.org
  • 1 edit
    2 adds in trunk/JavaScriptCore

Reviewed by Adam Roben.

Add a Scons-based build system for building
the Chromium-Mac build of JavaScriptCore.
​https://bugs.webkit.org/show_bug.cgi?id=21991

7:54 PM Changeset in webkit [38382] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

Reviewed by Adam Roben.

Add PLATFORM(CHROMIUM) to the "we don't use cairo" blacklist
until ​https://bugs.webkit.org/show_bug.cgi?id=22250 is fixed.

  • wtf/Platform.h:
7:45 PM Changeset in webkit [38381] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-13 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Sam Weinig.

In r38375 the 'jsc' shell was changed to improve teardown on quit. The
main() function in jsc.cpp uses Structured Exception Handling, so Visual
C++ emits a warning when destructors are used.


In order to speculatively fix the Windows build, this patch changes that
code to use explicit pointer manipulation and locking rather than smart
pointers and RAII.

  • jsc.cpp: (main):
5:54 PM Changeset in webkit [38380] by darin@chromium.org
  • 2 edits in trunk/WebCore

2008-11-13 Darin Fisher <​darin@chromium.org>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=22248
AtomicString.cpp uses JSC types outside of #if USE(JSC)

  • platform/text/AtomicString.cpp: (WebCore::AtomicString::add):
5:40 PM Changeset in webkit [38379] by cwzwarich@webkit.org
  • 3 edits in trunk/JavaScriptCore

2008-11-13 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Darin Adler.

Bug 22246: Get arguments for opcodes together to eliminate more redundant memory reads
<​https://bugs.webkit.org/show_bug.cgi?id=22246>

It is common for opcodes to read their first operand into eax and their
second operand into edx. If the value intended for the second operand is
in eax, we should first move eax to the register for the second operand
and then read the first operand into eax.

This is a 0.5% speedup on SunSpider and a 2.0% speedup on the V8
benchmark suite when measured using the V8 harness.

  • VM/CTI.cpp: (JSC::CTI::emitGetArgs): (JSC::CTI::compileOpStrictEq): (JSC::CTI::compileBinaryArithOp): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases):
  • VM/CTI.h:
2:54 PM Changeset in webkit [38378] by mrowe@apple.com
  • 4 copies
    1 add in releases/Apple/Safari 3.2

Tag the Safari 3.2 release.

This release consists of JavaScriptCore-x525.26.2, JavaScriptGlue-x525.26.2, WebCore-x525.26.6 and WebKit-x525.26.2.

2:27 PM Changeset in webkit [38377] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-13 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Darin Adler.

Bug 22238: Avoid unnecessary reads of temporaries when the target machine register is not eax
<​https://bugs.webkit.org/show_bug.cgi?id=22238>

Enable the optimization of not reading a value back from memory that we
just wrote when the target machine register is not eax. In order to do
this, the code generation for op_put_global_var must be changed to
read its argument into a register before overwriting eax.

This is a 0.5% speedup on SunSpider and shows no change on the V8
benchmark suite when run in either harness.

  • VM/CTI.cpp: (JSC::CTI::emitGetArg): (JSC::CTI::privateCompileMainPass):
1:04 PM Changeset in webkit [38376] by justin.garcia@apple.com
  • 2 edits in trunk/WebCore

2008-11-13 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Darin Adler.


​https://bugs.webkit.org/show_bug.cgi?id=18620
Long hang under TextIterator::advance() when loading ​http://www.lsvd.de/

A huge section at the beginning of this document is invisible. As we iterate through it,
we create VisiblePositions unnecessarily.

  • editing/TextIterator.cpp: (WebCore::TextIterator::shouldRepresentNodeOffsetZero): Don't proceed to VisiblePosition creation if m_node is unrendered or invisible. The answers wouldn't have much meaning and would be wasteful. Also fixed some comments to reflect the fact that this function isn't specifically about emitting a newline.
11:50 AM Changeset in webkit [38375] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-13 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Alexey Proskuryakov.

Perform teardown in the 'jsc' shell in order to suppress annoying and
misleading leak messages. There is still a lone JSC::Node leaking when
quit() is called, but hopefully that can be fixed as well.

  • jsc.cpp: (functionQuit): (main):
10:49 AM Changeset in webkit [38374] by cmarrin@apple.com
  • 3 edits in trunk/WebCore

2008-11-13 Pierre-Olivier Latour <​pol@apple.com>

Reviewed by Sam Weinig.

Remove unused or unnecessary code from AnimationBase class.

  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::AnimationBase): (WebCore::AnimationBase::playStatePlaying):
  • page/animation/AnimationBase.h:
10:35 AM Changeset in webkit [38373] by sullivan@apple.com
  • 8 edits
    1 add
    1 delete in trunk/WebKit

WebKit:

2008-11-13 John Sullivan <​sullivan@apple.com>

fixed <rdar://problem/6361578> Web Kit UI strings: a few edits

Reviewed by Tim Hatcher

  • English.lproj/Localizable.strings: updated for these changes


  • StringsNotToBeLocalized.txt: removed unused exception

WebKit/mac:

2008-11-13 John Sullivan <​sullivan@apple.com>

fixed <rdar://problem/6361578> Web Kit UI strings: a few edits

Reviewed by Tim Hatcher

  • Misc/WebKitErrors.m: "Cannot show content with specified mime type" -> "Content with specified MIME type can't be shown" "Cannot show URL" -> "The URL can't be shown" "Cannot find plug-in" -> "The plug-in can't be found" "Cannot load plug-in" -> "The plug-in can't be loaded"


  • Panels/English.lproj/WebAuthenticationPanel.nib/classes.nib:
  • Panels/English.lproj/WebAuthenticationPanel.nib/info.nib:
  • Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib: Added.
  • Panels/English.lproj/WebAuthenticationPanel.nib/objects.nib: Removed. Changed placeholder fine print in the nib to match one of the two strings it might be replaced by. This automagically updated the nib to a newer format, hence the objects -> keyedobjects change. I could have changed the placeholder fine print to be empty but this lets localizers understand the dialog layout better.


  • Panels/WebAuthenticationPanel.m: (-[WebAuthenticationPanel setUpForChallenge:]): "you need to log in" -> "you must log in" "Your log-in information" -> "Your login information" "The name or password entered" -> "The user name or password you entered" "Please try again." -> "Make sure you're entering them correctly, and then try again."
10:09 AM Changeset in webkit [38372] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-11-13 Mike Pinkerton <​pinkerton@chromium.org>

Reviewed by Sam Weinig.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=22087
Need correct platform defines for Mac Chromium

Set the appropriate platform defines for Mac Chromium, which is
similar to PLATFORM(MAC), but isn't.

  • wtf/Platform.h:
7:20 AM Changeset in webkit [38371] by vestbo@webkit.org
  • 5 edits
    2 adds in trunk/WebCore

2008-11-12 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon Hausmann.

Inital implementation of PluginPackage and PluginView for Mac NPAPI support in WebCore

Currently only used by QtWebKit. See also:

​https://bugs.webkit.org/show_bug.cgi?id=21427

7:20 AM Changeset in webkit [38370] by vestbo@webkit.org
  • 2 edits in trunk/WebKit/qt

2008-11-12 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Rubber-stamped by Tor Arne Vestbø.

Mention the color role change (r38331) in the API doc.

  • Api/qwebpage.cpp:
4:53 AM Changeset in webkit [38369] by mjs@apple.com
  • 4 edits in trunk/JavaScriptCore

2008-11-13 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Cameron Zwarich.


  • remove immediate checks from native codegen for known non-immediate cases like "this"


~.5% speedup on v8 benchmarks


In the future we can extend this model to remove all sorts of
typechecks based on local type info or type inference.


I also added an assertion to verify that all slow cases linked as
many slow case jumps as the corresponding fast case generated, and
fixed the pre-existing cases where this was not true.


  • VM/CTI.cpp: (JSC::CTI::emitJumpSlowCaseIfNotJSCell): (JSC::CTI::linkSlowCaseIfNotJSCell): (JSC::CTI::compileBinaryArithOp): (JSC::CTI::compileBinaryArithOpSlowCase): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases):
  • VM/CTI.h:
  • VM/CodeBlock.h: (JSC::CodeBlock::isKnownNotImmediate):
3:26 AM Changeset in webkit [38368] by cwzwarich@webkit.org
  • 5 edits in trunk/JavaScriptCore

2008-11-13 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Maciej Stachowiak.

Bug 21943: Avoid needless reads of temporary values in CTI code
<​https://bugs.webkit.org/show_bug.cgi?id=21943>

If an opcode needs to load a virtual register and a previous opcode left
the contents of that virtual register in a machine register, use the
value in the machine register rather than getting it from memory.

In order to perform this optimization, it is necessary to know the
jump tagets in the CodeBlock. For temporaries, the only problematic
jump targets are binary logical operators and the ternary conditional
operator. However, if this optimization were to be extended to local
variable registers as well, other jump targets would need to be
included, like switch statement cases and the beginnings of catch
blocks.

This optimization also requires that the fast case and the slow case
of an opcode use emitPutResult() on the same register, which was chosen
to be eax, as that is the register into which we read the first operand
of opcodes. In order to make this the case, we needed to add some mov
instructions to the slow cases of some instructions.

This optimizaton is not applied whenever compileBinaryArithOp() is used
to compile an opcode, because different machine registers may be used to
store the final result. It seems possible to rewrite the code generation
in compileBinaryArithOp() to allow for this optimization.

This optimization is also not applied when generating slow cases,
because some fast cases overwrite the value of eax before jumping to the
slow case. In the future, it may be possible to apply this optimization
to slow cases as well, but it did not seem to be a speedup when testing
an early version of this patch.

This is a 1.0% speedup on SunSpider and a 6.3% speedup on the V8
benchmark suite.

  • VM/CTI.cpp: (JSC::CTI::killLastResultRegister): (JSC::CTI::emitGetArg): (JSC::CTI::emitGetPutArg): (JSC::CTI::emitGetCTIParam): (JSC::CTI::emitGetFromCallFrameHeader): (JSC::CTI::emitPutResult): (JSC::CTI::emitCTICall): (JSC::CTI::CTI): (JSC::CTI::compileOpCall): (JSC::CTI::compileOpStrictEq): (JSC::CTI::emitSlowScriptCheck): (JSC::CTI::compileBinaryArithOp): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases): (JSC::CTI::privateCompileGetByIdProto): (JSC::CTI::privateCompilePatchGetArrayLength):
  • VM/CTI.h:
  • VM/CodeBlock.h: (JSC::CodeBlock::isTemporaryRegisterIndex):
  • bytecompiler/CodeGenerator.cpp: (JSC::CodeGenerator::emitLabel):

Nov 12, 2008:

11:35 PM Changeset in webkit [38367] by ap@webkit.org
  • 2 edits in trunk/WebKitTools

2008-11-12 Dmitry Titov <​dimich@chromium.org>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=22216

  • Scripts/build-webkit: Addes ENABLE_WORKERS to build-webkit so it's possible to build with workers enabled.
11:32 PM Changeset in webkit [38366] by ap@webkit.org
  • 4 edits
    2 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=22200
Crash when close event is dispatched to MessagePort due to document destruction

Test: fast/events/message-port-onclose.html

  • dom/MessagePort.cpp: (WebCore::MessagePort::contextDestroyed): Don't dispatch close event, even though HTML5 currently says that we should. It is not right for GC to have observable effects.
11:27 PM Changeset in webkit [38365] by ap@webkit.org
  • 24 edits
    2 adds in trunk/WebCore

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=22203
Implement Worker messaging

No test cases included, because this functionality is disabled by default.

The implementation is known to still have many race condition, but works quite well for
testing.

  • WebCore.xcodeproj/project.pbxproj: Added WorkerTask.{h,cpp}.
  • bindings/js/JSDOMBinding.cpp: (WebCore::markActiveObjectsForContext): Re-worded comments a little. (WebCore::markCrossHeapDependentObjectsForContext): Existing cross-heap GC protocol was incorrect, changed it to a much simpler (but still incorrect) version.
  • dom/WorkerTask.cpp: Added. (WebCore::WorkerTask::~WorkerTask):
  • dom/WorkerTask.h: Added. Tasks posted to workers implement this new interface.
  • bindings/js/JSDedicatedWorkerCustom.cpp: (WebCore::JSDedicatedWorker::mark): (WebCore::JSDedicatedWorker::connect):
  • dom/DedicatedWorker.h:
  • dom/DedicatedWorker.idl: Auto-generate event listener attributes. Renamed startConversation() to connect(), tracking WHATWG discussions.
  • dom/DedicatedWorker.cpp: (WebCore::WorkerConnectTask::WorkerConnectTask): A task that performs worker-side connect() operations. (WebCore::DedicatedWorker::DedicatedWorker): Initialize WorkerThread pointer. (WebCore::DedicatedWorker::connect): Connect() creates a pair of entangled ports, and posts one to worker. Since message port registration in ScriptExecutionContext is not thread safe, this port starts with a null context pointer. (WebCore::DedicatedWorker::notifyFinished): Since Worker methods should work immediately after creation, we have to queue tasks until after a WorkerThread object is created. Then we forward all queued tasks to its queue.
  • dom/EventTarget.cpp: (WebCore::EventTarget::toWorkerContext):
  • dom/EventTarget.h:
  • bindings/js/JSEventTarget.cpp: (WebCore::toJS): Added cases for WorkerContext, which is now an EventTarget, too.
  • bindings/js/JSWorkerContext.h: Added JSWorkerContext::put() to make onconnect settable.
  • bindings/js/JSWorkerContext.cpp: (WebCore::JSWorkerContext::mark): Mark event listeners. (WebCore::JSWorkerContext::createPrototype): Fixed a typo, use the right StructureID. (WebCore::JSWorkerContext::put): Implemented. (WebCore::jsWorkerContextPrototypeFunctionAddEventListener): Added an EventTarget implementation. (WebCore::jsWorkerContextPrototypeFunctionRemoveEventListener): Ditto. (WebCore::jsWorkerContextPrototypeFunctionDispatchEvent): Ditto. (WebCore::jsWorkerContextOnconnect): Added. (WebCore::setJSWorkerContextOnconnect): Added.
  • bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate): Made it actually work by adding necessary setup.
  • bindings/js/WorkerScriptController.h: (WebCore::WorkerScriptController::initScriptIfNeeded): Check the right variable - it is the wrapper that may not be initialized yet.
  • dom/ActiveDOMObject.cpp: (WebCore::ActiveDOMObject::ActiveDOMObject): (WebCore::ActiveDOMObject::~ActiveDOMObject): Assert being called from the correct thread, as active DOM object tracking is not thread safe.
  • dom/ScriptExecutionContext.h: Added a Task interface and a postTask() method, to be used for asynchronously executing tasks in context's thread.
  • dom/ScriptExecutionContext.cpp: (WebCore::ProcessMessagesSoonTask): Changed from a Timer to a Task (WebCore::ScriptExecutionContext::ScriptExecutionContext): Removed m_firedMessagePortTimer. It was an optimization that couldn't be easily preserved without introducing race conditions in multithreading case. (WebCore::ScriptExecutionContext::processMessagePortMessagesSoon): Use postTask(). (WebCore::ScriptExecutionContext::dispatchMessagePortEvents): Added a comment explaining why it's OK to not ref() ports in a frozen copy. (WebCore::ScriptExecutionContext::createdMessagePort): Assert that we're not being called from a wrong thread. (WebCore::ScriptExecutionContext::destroyedMessagePort): Ditto. (WebCore::ScriptExecutionContextTaskTimer): Part of ScriptExecutionContext::Task implementation - use Timer if posting from main thread to main thread. (WebCore::ScriptExecutionContextTaskWorkerTask): Another part - use WorkerTask if posting to a worker. (WebCore::PerformTaskContext::PerformTaskContext): Finally, use callOnMainThread() if posting to main thread from a secondary one. (WebCore::performTask): A helper function for callOnMainThread(). (WebCore::ScriptExecutionContext::postTask): Use one of the above implementations.
  • dom/MessagePort.h: Fixed message queue to keep EventData pointers - otherwise, we would ref/deref EventData::message from different threads, which is not allowed.
  • dom/MessagePort.cpp: (WebCore::MessagePortCloseEventTask): Use a task instead of a timer to work across threads. (WebCore::MessagePort::EventData::create): Updated for EventData being refcountable now. (WebCore::MessagePort::EventData::EventData): Ditto. (WebCore::MessagePort::MessagePort): ScriptExecutionContext is now allowed to be null at first, because we need to create ports for posting to other threads, and it is not possible to register in a context from another thread. (WebCore::MessagePort::clone): Always create ports with null contexts - it is now message receiver's job to set the context. (WebCore::MessagePort::postMessage): Enable posting to ports that are not attached to any context yet. (WebCore::MessagePort::startConversation): Ditto. Data port is always posted unattached. (WebCore::MessagePort::contextDestroyed): Assert that we had a context. (WebCore::MessagePort::attachToContext): Called when receiving a data port to register in context. (WebCore::MessagePort::scriptExecutionContext): Moved from header, as the function is virtual. (WebCore::MessagePort::dispatchMessages): Attach data port to receiving context. Use postTask(). (WebCore::MessagePort::queueCloseEvent): Use postTask(). (WebCore::MessagePort::hasPendingActivity): Reworded comment a little. As mentioned above, MessagePort cross-heap GC is still quite wrong.
  • dom/WorkerContext.h: Made WorkerContext an event target, added onconnect attribute.
  • dom/WorkerContext.cpp: Keep a pointer to WorkerThread. It is only used for debug assertions now, but there is no harm in tracking it in release builds, too.
  • dom/WorkerThread.cpp: (WebCore::WorkerThread::create): WorkerThread is refcountable, construct with create(). (WebCore::WorkerThread::workerThread): Implemented a message loop.
  • dom/WorkerThread.h: (WebCore::WorkerThread::threadID): Also only used for assertions. (WebCore::WorkerThread::messageQueue): Return a reference to queue, so clients can post to it.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::postMessage): MessagePort::clone() no longer takes a context, as it always sets it to null. (WebCore::DOMWindow::postMessageTimerFired): Attach data port to receiving context.
11:17 PM Changeset in webkit [38364] by krit@webkit.org
  • 3 edits
    3 adds in trunk

2008-11-12 Dirk Schulze <​vbs85@gmx.de>

WebCore:

Reviewed Darin Adler.

use strokeColor.alpha() instead of fillColor.alpha()
on GraphicsContext::strokePath()

[Canvas] Transparent fillStyle stops line rendering
​https://bugs.webkit.org/show_bug.cgi?id=21888

Test: fast/canvas/canvas-stroke-empty-fill.html

  • ChangeLog:
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::strokePath):

LayoutTests:

Reviewed by Darin Adler.

Check behavior of canvas.stroke() on transparent fillStyle()

  • fast/canvas/canvas-stroke-empty-fill-expected.txt: Added.
  • fast/canvas/canvas-stroke-empty-fill.html: Added.
  • fast/canvas/canvas-stroke-empty-fill.js: Added.
11:17 PM Changeset in webkit [38363] by Stephanie Lewis
  • 2 edits in trunk/WebKit/mac

2008-11-12 Stephanie Lewis <Stephanie Lewis>

Fix Mac build.

  • Panels/WebAuthenticationPanel.m:
10:08 PM Changeset in webkit [38362] by Stephanie Lewis
  • 2 edits in trunk/WebCore

2008-11-12 Stephanie <Stephanie Lewis>

Reviewed by Mark Rowe.

Fix context leak in XSLStyleSheets.
See bug ​https://bugs.webkit.org/show_bug.cgi?id=15715

  • xml/XSLStyleSheet.cpp: (WebCore::XSLStyleSheet::parseString):
8:47 PM Changeset in webkit [38361] by sullivan@apple.com
  • 5 edits in trunk/WebKit

WebKit:

2008-11-12 John Sullivan <​sullivan@apple.com>

fixed <rdar://problem/3839110> Authentication dialogs talk about passwords being sent "in the clear"

Reviewed by Tim Hatcher

  • English.lproj/Localizable.strings:
  • StringsNotToBeLocalized.txt: updated for this change

WebKit/mac:

2008-11-12 John Sullivan <​sullivan@apple.com>

fixed <rdar://problem/3839110> Authentication dialogs talk about passwords being sent "in the clear"

Reviewed by Tim Hatcher

  • Panels/WebAuthenticationPanel.m: (-[WebAuthenticationPanel setUpForChallenge:]): use "unencrypted" instead of "in the clear". Also, use the "Your log-in information will be sent securely" version when the receiving server is https, regardless of whether it uses basic or digest authentication.
8:26 PM Changeset in webkit [38360] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-11-12 Alp Toker <​alp@nuanti.com>

autotools: List web worker-related headers needed for a successful
build. distcheck is passing again with this change.

  • GNUmakefile.am:
7:57 PM Changeset in webkit [38359] by mrowe@apple.com
  • 4 edits in tags/Safari-6528.4.3

Versioning.

7:57 PM Changeset in webkit [38358] by mrowe@apple.com
  • 2 edits in tags/Safari-6528.4.3/WebKit/mac

Merge r37827.

7:39 PM Changeset in webkit [38357] by mrowe@apple.com
  • 1 copy in tags/Safari-6528.4.3

New tag.

6:30 PM Changeset in webkit [38356] by alp@webkit.org
  • 4 edits in trunk

2008-11-12 Alp Toker <​alp@nuanti.com>

autotools build system fix-up only. Add FloatQuad.h to the source
lists and sort them.

6:04 PM Changeset in webkit [38355] by Darin Adler
  • 2 edits in trunk/WebKit/mac

2008-11-12 Darin Adler <Darin Adler>

Reviewed by Mark Rowe.

  • WebView/WebFrameView.mm: (-[WebFrameView viewDidMoveToWindow]): Add missing null check.
5:41 PM Changeset in webkit [38354] by mitz@apple.com
  • 5 edits
    40 adds in trunk/LayoutTests

2008-11-12 Pierre-Olivier Latour <​pol@apple.com>

Reviewed by Dan Bernstein.

Updated reference images so that all pixel tests now "pass" on 10.4.11 PowerPC + r38347.
​https://bugs.webkit.org/show_bug.cgi?id=21821

Checked-in specific reference images for pixel tests that are valid on Tiger but fail
because difference with reference image due to text rendering is greater than 1.0%

  • platform/mac-tiger/svg/carto.net: Added.
  • platform/mac-tiger/svg/carto.net/selectionlist-expected.checksum: Added.
  • platform/mac-tiger/svg/carto.net/selectionlist-expected.png: Added.
  • platform/mac-tiger/svg/custom/feComponentTransfer-Gamma-expected.checksum: Added.
  • platform/mac-tiger/svg/custom/feComponentTransfer-Gamma-expected.png: Added.
  • platform/mac-tiger/svg/text/text-align-01-b-expected.checksum: Added.
  • platform/mac-tiger/svg/text/text-align-01-b-expected.png: Added.
  • platform/mac-tiger/svg/text/text-align-02-b-expected.checksum: Added.
  • platform/mac-tiger/svg/text/text-align-02-b-expected.png: Added.
  • platform/mac-tiger/svg/text/text-align-04-b-expected.checksum: Added.
  • platform/mac-tiger/svg/text/text-align-04-b-expected.png: Added.
  • platform/mac-tiger/svg/text/text-fonts-01-t-expected.checksum: Added.
  • platform/mac-tiger/svg/text/text-fonts-01-t-expected.png: Added.
  • platform/mac-tiger/svg/text/text-text-03-b-expected.checksum: Added.
  • platform/mac-tiger/svg/text/text-text-03-b-expected.png: Added.
  • platform/mac-tiger/svg/text/text-tselect-01-b-expected.checksum: Added.
  • platform/mac-tiger/svg/text/text-tselect-01-b-expected.png: Added.
  • platform/mac-tiger/svg/text/text-tspan-01-b-expected.checksum: Added.
  • platform/mac-tiger/svg/text/text-tspan-01-b-expected.png: Added.
  • platform/mac-tiger/svg/text/text-ws-01-t-expected.checksum: Added.
  • platform/mac-tiger/svg/text/text-ws-01-t-expected.png: Added.
  • platform/mac-tiger/svg/text/text-ws-02-t-expected.checksum: Added.
  • platform/mac-tiger/svg/text/text-ws-02-t-expected.png: Added.
  • platform/mac-tiger/svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum: Added.
  • platform/mac-tiger/svg/W3C-SVG-1.1/filters-color-01-b-expected.png: Added.
  • platform/mac-tiger/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.checksum: Added.
  • platform/mac-tiger/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png: Added.

svg/batik/paints/gradientLimit.svg is rendering different on Tiger and Leopard
​https://bugs.webkit.org/show_bug.cgi?id=22219

  • platform/mac-tiger/svg/batik: Added.
  • platform/mac-tiger/svg/batik/paints: Added.
  • platform/mac-tiger/svg/batik/paints/gradientLimit-expected.checksum: Added.
  • platform/mac-tiger/svg/batik/paints/gradientLimit-expected.png: Added.

svg/custom/mask-excessive-malloc.svg is failing on Tiger
​https://bugs.webkit.org/show_bug.cgi?id=22218

  • platform/mac-tiger/svg/custom/mask-excessive-malloc-expected.checksum: Added.
  • platform/mac-tiger/svg/custom/mask-excessive-malloc-expected.png: Added.

svg/W3C-SVG-1.1/pservers-grad-17-b.svg is failing on Leopard
​https://bugs.webkit.org/show_bug.cgi?id=22220

  • platform/mac-leopard/svg: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.checksum: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.png:

svg/custom/foreign-object-skew.svg is failing on Leopard
​https://bugs.webkit.org/show_bug.cgi?id=22221

  • platform/mac-leopard/svg/custom: Added.
  • platform/mac-leopard/svg/custom/foreign-object-skew-expected.checksum: Added.
  • platform/mac-leopard/svg/custom/foreign-object-skew-expected.png: Added.
  • platform/mac/svg/custom/foreign-object-skew-expected.checksum:
  • platform/mac/svg/custom/foreign-object-skew-expected.png:
5:32 PM Changeset in webkit [38353] by Simon Fraser
  • 17 edits
    4 adds in trunk

2008-11-12 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein

​https://bugs.webkit.org/show_bug.cgi?id=22212

Rename absoluteOutlineBox() to absoluteOutlineBounds(), to indicate that
it may be the bounding outline box of a transformed element, and fix it
to respect transforms by mapping the outline box to an absolute quad and
taking the enclosing rect.

RenderBox::localToAbsoluteQuad() can no longer assert that there is no
LayoutState, but LayoutState cannot be used during quad mapping (it knows
nothing about transforms).

Finally, fix a bug in RenderBox::localToAbsoluteQuad() which was getting
borderTopExtra() from the object, rather than its container (as localToAbsolute()
does).

Test: fast/repaint/transform-absolute-child.html

5:22 PM Changeset in webkit [38352] by ggaren@apple.com
  • 1 edit in trunk/LayoutTests/ChangeLog

dyslexics untie\!

5:20 PM Changeset in webkit [38351] by ggaren@apple.com
  • 2 edits in trunk/LayoutTests

2008-11-12 Geoffrey Garen <​ggaren@apple.com>

Roll in r38322, onw that test failures have been fixed.


  • fast/js/global-recursion-on-full-stack-expected.txt:
4:51 PM Changeset in webkit [38350] by jchaffraix@webkit.org
  • 6 edits in branches/XBL2/WebCore

2008-11-12 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Darin Adler.

Bug 22133: [XBL] Add shorter method to get the global XBLBindingManager

Renamed XBBindingManager::sharedInstance() to bindingManager().

Suggested by Eric Seidel.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::removeBindings):
  • dom/Document.cpp: (WebCore::Document::~Document): (WebCore::Document::recalcStyleSelector): (WebCore::Document::addBindingSheet): (WebCore::Document::removeBindingSheet):
  • dom/Element.cpp: (WebCore::Element::~Element): (WebCore::Element::addBinding): (WebCore::Element::removeBinding): (WebCore::Element::hasBinding):
  • xbl/XBLBindingManager.cpp: (WebCore::bindingManager):
  • xbl/XBLBindingManager.h:
4:48 PM Changeset in webkit [38349] by ggaren@apple.com
  • 11 edits in trunk/JavaScriptCore

2008-11-12 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.


Fixed ​https://bugs.webkit.org/show_bug.cgi?id=22192
+37 failures in fast/profiler


along with Darin's review comments in
​https://bugs.webkit.org/show_bug.cgi?id=22174
Simplified op_call by nixing its responsibility for moving the value of
"this" into the first argument slot

  • VM/Machine.cpp: (JSC::returnToThrowTrampoline): (JSC::throwStackOverflowError): (JSC::Machine::cti_register_file_check): (JSC::Machine::cti_op_call_arityCheck): (JSC::Machine::cti_vm_throw): Moved the throw logic into a function, since functions are better than macros.
  • bytecompiler/CodeGenerator.cpp: (JSC::CodeGenerator::emitCall): (JSC::CodeGenerator::emitConstruct): Ensure that the function register is preserved if profiling is enabled, since the profiler uses that register.
  • runtime/JSGlobalData.h: Renamed throwReturnAddress to exceptionLocation, because I had a hard time understanding what "throwReturnAddress" meant.
4:44 PM Changeset in webkit [38348] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-11-12 Alp Toker <​alp@nuanti.com>

Build fixes for r38346. FloatQuad.cpp is missing:

1) #include "config.h"
2) #include <algorithm> for various mathematical definitions it uses.

  • platform/graphics/FloatQuad.cpp:
4:24 PM Changeset in webkit [38347] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

2008-11-12 Pierre-Olivier Latour <​pol@apple.com>

Reviewed by Dan Bernstein.

Skip fast/repaint/body-background-image.html test as it is not reliable.

​https://bugs.webkit.org/show_bug.cgi?id=21913

  • platform/mac/Skipped:
3:43 PM Changeset in webkit [38346] by Simon Fraser
  • 41 edits
    2 adds in trunk/WebCore

2008-11-12 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

​https://bugs.webkit.org/show_bug.cgi?id=21942
​https://bugs.webkit.org/show_bug.cgi?id=18557

Add methods which can be used to map renderer-local rectangles
to quads in absolute coordinates, taking transforms into account:

localToAbsoluteQuad() converts a local rect into an absolute quad.
collectAbsoluteLineBoxQuads() is an analogue of addLineBoxRects()

that works with quads.

absoluteQuads() is an analogue of absoluteRects(), for quads.

Use the quad methods to fix the inspector highlight for transformed
elements.

3:04 PM Changeset in webkit [38345] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2008-11-12 Anders Carlsson <​andersca@apple.com>

Reviewed by Kevin Decker.

Fix stupid bug.


  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView createPlugin]):
2:53 PM Changeset in webkit [38344] by mitz@apple.com
  • 1 edit
    1 delete in trunk/LayoutTests

2008-11-12 Dan Bernstein <​mitz@apple.com>

  • remove an empty directory
  • platform/mac-leopard/http: Removed.
  • platform/mac-leopard/http/tests: Removed.
  • platform/mac-leopard/http/tests/security: Removed.
  • platform/mac-leopard/http/tests/security/dataURL: Removed.
1:54 PM Changeset in webkit [38343] by Adam Roben
  • 2 edits in trunk/WebCore

Fix Bug 22178: Build errors in WebKit Cairo port

<​https://bugs.webkit.org/show_bug.cgi?id=22178>

Reviewed by Mark Rowe.

  • platform/graphics/cairo/PatternCairo.cpp: Correct build error under Visual Studio. (WebCore::Pattern::createPlatformPattern):
1:49 PM Changeset in webkit [38342] by Adam Roben
  • 2 edits in trunk/WebCore

Fix a typo in the include path for the Release_Cairo configuration

  • WebCore.vcproj/WebCore.vcproj: Fixed "caro" -> "cairo" typo.
1:02 PM Changeset in webkit [38341] by sfalken@apple.com
  • 1 edit in trunk/WebKit/win/WebKitPrefix.cpp

Touch precompiled header wrapper to fix build.

12:44 PM Changeset in webkit [38340] by mitz@apple.com
  • 4 edits in trunk/LayoutTests/platform/mac/fast

Set svn:mime-type to image/png on .png files that did not have it

12:28 PM Changeset in webkit [38339] by Simon Fraser
  • 2 edits in trunk/WebCore

2008-11-12 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

​https://bugs.webkit.org/show_bug.cgi?id=17840
Patch 2

Code cleanup in RenderBox::computeAbsoluteRepaintRect().

  • rendering/RenderBox.cpp: (WebCore::RenderBox::computeAbsoluteRepaintRect):
12:22 PM Changeset in webkit [38338] by Simon Fraser
  • 3 edits
    8 adds in trunk

2008-11-12 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

​https://bugs.webkit.org/show_bug.cgi?id=17840

Fix repainting when the transform on a positioned element changes.
In computeAbsoluteRepaintRect(), add the offsets due to relative positioning,
and being in a positioned container after applying the transform to the local
rect.

Tests: fast/repaint/transform-absolute-in-positioned-container.html

fast/repaint/transform-relative-position.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::computeAbsoluteRepaintRect):
12:08 PM Changeset in webkit [38337] by justin.garcia@apple.com
  • 7 edits
    2 adds in trunk

WebCore:

2008-11-12 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Beth Dakin.


<rdar://problem/5495723> Selecting and deleting quoted text quotes other text
<rdar://problem/4775313> Deleting lines from the bottom of a messages leaves the last blank line quoted


We don't want to merge into a block if it will mean changing the quote level of content after deleting
selections that contain a whole number paragraphs plus a line break, since it is unclear to most users
that such a selection actually ends at the start of the next paragraph. Instead we want to completely
remove the selected paragraph(s) and all evidence of the first one's quote level. This matches TextEdit behavior
for indented paragraphs.


  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializePositionData): For the selections described above, do not try to merge after the deletion. Instead try and prune the start block or blocks if they've been emptied so that we remove evidence of the deleted paragraphs' quote level. (WebCore::DeleteSelectionCommand::mergeParagraphs): Try and prune the start block(s) if necessary. Also make sure that the caret is placed correctly so that it ends up on the same line that the deleted selection started on, instead of one higher.
  • editing/DeleteSelectionCommand.h:
  • editing/htmlediting.cpp: (WebCore::numEnclosingMailBlockquotes): Added.
  • editing/htmlediting.h:

LayoutTests:

2008-11-12 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Beth Dakin.


<rdar://problem/5495723> Selecting and deleting quoted text quotes other text
<rdar://problem/4775313> Deleting lines from the bottom of a messages leaves the last blank line quoted

  • editing/deleting/5495723-expected.txt: Added.
  • editing/deleting/5495723.html: Added.
  • platform/mac/editing/deleting/delete-4038408-fix-expected.txt: Change demonstrates that we now behave correctly when pressing delete when the caret is just after empty quoted paragraphs.
11:40 AM Changeset in webkit [38336] by sfalken@apple.com
  • 1 edit in trunk/WebCore/WebCorePrefix.cpp

Touch precompiled header wrapper to try and fix build.

10:35 AM Changeset in webkit [38335] by mitz@apple.com
  • 50 edits in trunk/LayoutTests

2008-11-12 Pierre-Olivier Latour <​pol@apple.com>

Reviewed by Dan Bernstein.

Updated reference images so that all pixel tests now "pass" on 10.5.5 Intel + r38318.
​https://bugs.webkit.org/show_bug.cgi?id=21821

Removed empty directory.

  • platform/mac-leopard/http: Removed.
  • platform/mac-leopard/http/tests: Removed.
  • platform/mac-leopard/http/tests/security: Removed.
  • platform/mac-leopard/http/tests/security/dataURL: Removed.

Test doesn't repaint entire view so result is corrupted by previous test
​https://bugs.webkit.org/show_bug.cgi?id=21916

  • platform/mac/Skipped:

Test is passing but original reference image was invalid.

  • platform/mac/fast/backgrounds/size/backgroundSize05-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize05-expected.png:

Invalid image tiling
​https://bugs.webkit.org/show_bug.cgi?id=21915

  • platform/mac/fast/backgrounds/size/backgroundSize19-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize19-expected.png:

SVG not rendering
​https://bugs.webkit.org/show_bug.cgi?id=21910

  • platform/mac/fast/backgrounds/svg-as-background-1-expected.checksum:
  • platform/mac/fast/backgrounds/svg-as-background-1-expected.png:
  • platform/mac/fast/backgrounds/svg-as-background-2-expected.checksum:
  • platform/mac/fast/backgrounds/svg-as-background-2-expected.png:
  • platform/mac/fast/backgrounds/svg-as-background-3-expected.checksum:
  • platform/mac/fast/backgrounds/svg-as-background-3-expected.png:
  • platform/mac/fast/backgrounds/svg-as-background-4-expected.checksum:
  • platform/mac/fast/backgrounds/svg-as-background-4-expected.png:
  • platform/mac/fast/backgrounds/svg-as-background-5-expected.checksum:
  • platform/mac/fast/backgrounds/svg-as-background-5-expected.png:
  • platform/mac/fast/backgrounds/svg-as-background-6-expected.checksum:
  • platform/mac/fast/backgrounds/svg-as-background-6-expected.png:
  • platform/mac/fast/backgrounds/svg-as-mask-expected.checksum:
  • platform/mac/fast/backgrounds/svg-as-mask-expected.png:
  • platform/mac/fast/borders/svg-as-border-image-2-expected.checksum:
  • platform/mac/fast/borders/svg-as-border-image-2-expected.png:
  • platform/mac/fast/borders/svg-as-border-image-expected.checksum:
  • platform/mac/fast/borders/svg-as-border-image-expected.png:
  • platform/mac/fast/images/svg-as-background-expected.checksum:
  • platform/mac/fast/images/svg-as-background-expected.png:
  • platform/mac/fast/images/svg-as-image-expected.checksum:
  • platform/mac/fast/images/svg-as-image-expected.png:
  • platform/mac/fast/images/svg-as-relative-image-expected.checksum:
  • platform/mac/fast/images/svg-as-relative-image-expected.png:
  • platform/mac/fast/images/svg-as-tiled-background-expected.checksum:
  • platform/mac/fast/images/svg-as-tiled-background-expected.png:

Possible Flash failure
​https://bugs.webkit.org/show_bug.cgi?id=21912

  • platform/mac/fast/dynamic/flash-replacement-test-expected.checksum:
  • platform/mac/fast/dynamic/flash-replacement-test-expected.png:

Repaint failure
​https://bugs.webkit.org/show_bug.cgi?id=21913

  • platform/mac/fast/repaint/body-background-image-expected.checksum:
  • platform/mac/fast/repaint/body-background-image-expected.png:

Excessive repainting
​https://bugs.webkit.org/show_bug.cgi?id=21914

  • platform/mac/fast/repaint/float-overflow-expected.checksum:
  • platform/mac/fast/repaint/float-overflow-expected.png:
  • platform/mac/fast/repaint/float-overflow-right-expected.checksum:
  • platform/mac/fast/repaint/float-overflow-right-expected.png:

No video images
​https://bugs.webkit.org/show_bug.cgi?id=21911

  • platform/mac/media/video-aspect-ratio-expected.checksum:
  • platform/mac/media/video-aspect-ratio-expected.png:
  • platform/mac/media/video-controls-rendering-expected.checksum:
  • platform/mac/media/video-controls-rendering-expected.png:
  • platform/mac/media/video-display-toggle-expected.checksum:
  • platform/mac/media/video-display-toggle-expected.png:
  • platform/mac/media/video-layer-crash-expected.checksum:
  • platform/mac/media/video-layer-crash-expected.png:
  • platform/mac/media/video-transformed-expected.checksum:
  • platform/mac/media/video-transformed-expected.png:
3:31 AM Changeset in webkit [38334] by barraclough@apple.com
  • 3 edits
    2 adds in trunk

JavaScriptCore:

2008-11-12 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Cameron Zwarich.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=22201
Integer conversion in array.length was safe signed values,
but the length is unsigned.

  • VM/CTI.cpp: (JSC::CTI::privateCompilePatchGetArrayLength):

LayoutTests:

2008-11-12 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Cameron Zwarich.

Test for ​https://bugs.webkit.org/show_bug.cgi?id=22201

  • fast/js/pic/cached-array-length-access-expected.txt: Added.
  • fast/js/pic/cached-array-length-access.html: Added.
2:51 AM Changeset in webkit [38333] by vestbo@webkit.org
  • 6 edits in trunk

2008-11-10 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon Hausmann.

Move _web_encodingForResource from WebKit into WebCore and change return type

This change is needed to implement NSAPI in WebCore for Mac, see:

​https://bugs.webkit.org/show_bug.cgi?id=21427

2:44 AM Changeset in webkit [38332] by vestbo@webkit.org
  • 6 edits in trunk

2008-11-10 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon Hausmann.

Moved the implementation of _webkit_isCaseInsensitiveEqualToString to
WebCore's WebCoreNSStringExtras as _stringIsCaseInsensitiveEqualToString.

This change is needed to implement NSAPI in WebCore for Mac, see:

​https://bugs.webkit.org/show_bug.cgi?id=21427

1:51 AM Changeset in webkit [38331] by vestbo@webkit.org
  • 3 edits in trunk/WebKit/qt

2008-11-11 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Reviewed by Tor Arne Vestbø and Simon Hausmann.

Use QPalette::Base (instead of QPalette::Background) for the page
background.

  • Api/qwebframe.cpp: (QWebFramePrivate::updateBackground):
  • Api/qwebview.cpp: (QWebView::QWebView):
1:34 AM Changeset in webkit [38330] by cwzwarich@webkit.org
  • 12 edits in trunk

2008-11-12 Cameron Zwarich <​zwarich@apple.com>

Rubber-stamped by Mark Rowe.

Roll out r38322 due to test failures on the bots.

JavaScriptCore:

  • VM/CTI.cpp: (JSC::CTI::compileOpCallSetupArgs): (JSC::CTI::compileOpCall): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases):
  • VM/CTI.h:
  • VM/CodeBlock.cpp: (JSC::CodeBlock::dump):
  • VM/Machine.cpp: (JSC::Machine::callEval): (JSC::Machine::dumpCallFrame): (JSC::Machine::dumpRegisters): (JSC::Machine::execute): (JSC::Machine::privateExecute): (JSC::Machine::throwStackOverflowPreviousFrame): (JSC::Machine::cti_register_file_check): (JSC::Machine::cti_op_call_arityCheck): (JSC::Machine::cti_op_call_NotJSFunction): (JSC::Machine::cti_op_construct_JSConstruct): (JSC::Machine::cti_op_construct_NotJSConstruct): (JSC::Machine::cti_op_call_eval): (JSC::Machine::cti_vm_throw):
  • VM/Machine.h:
  • bytecompiler/CodeGenerator.cpp: (JSC::CodeGenerator::emitCall): (JSC::CodeGenerator::emitCallEval): (JSC::CodeGenerator::emitConstruct):
  • bytecompiler/CodeGenerator.h:
  • parser/Nodes.cpp: (JSC::EvalFunctionCallNode::emitCode): (JSC::FunctionCallValueNode::emitCode): (JSC::FunctionCallResolveNode::emitCode): (JSC::FunctionCallBracketNode::emitCode): (JSC::FunctionCallDotNode::emitCode):
  • parser/Nodes.h: (JSC::ScopeNode::neededConstants):

LayoutTests:

  • fast/js/global-recursion-on-full-stack-expected.txt:
Note: See TracTimeline for information about the timeline view.