⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 19, 2008:

8:46 PM Changeset in webkit [38616] by darin@chromium.org
  • 2 edits in trunk/WebKit/qt

2008-11-19 Darin Fisher <​darin@chromium.org>

Fix bustage.

​https://bugs.webkit.org/show_bug.cgi?id=22373
Ports busted by addition of ScriptValue.{h,cpp}

  • Api/qwebframe.cpp: (QWebFrame::evaluateJavaScript):
7:31 PM Changeset in webkit [38615] by darin@chromium.org
  • 2 edits in trunk/WebKit/qt

2008-11-19 Darin Fisher <​darin@chromium.org>

Fix bustage.

​https://bugs.webkit.org/show_bug.cgi?id=22373
Ports busted by addition of ScriptValue.{h,cpp}

  • Api/qwebframe.cpp:
7:27 PM Changeset in webkit [38614] by darin@chromium.org
  • 2 edits in trunk/WebCore

2008-11-19 Darin Fisher <​darin@chromium.org>

Fix bustage.

​https://bugs.webkit.org/show_bug.cgi?id=22373
Ports busted by addition of ScriptValue.{h,cpp}


  • plugins/PluginView.cpp: (WebCore::PluginView::performRequest):
7:19 PM Changeset in webkit [38613] by darin@chromium.org
  • 8 edits in trunk

2008-11-19 Darin Fisher <​darin@chromium.org>

Bustage fix.

​https://bugs.webkit.org/show_bug.cgi?id=22373
Ports busted by addition of ScriptValue.{h,cpp}

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCoreSources.bkl:
  • dom/XMLTokenizerQt.cpp:
  • plugins/PluginView.cpp:
6:44 PM Changeset in webkit [38612] by Simon Fraser
  • 4 edits
    2 adds in trunk

Reviewed by Antti Koivisto

​https://bugs.webkit.org/show_bug.cgi?id=22111

Fix hit testing in controls on transformed video elements
by replacing absoluteBoundingBoxRect().contains() with
code that maps the point into local coords, taking
transforms into account.

Test: media/video-controls-transformed.html

  • platform/graphics/MediaPlayer.h:
  • rendering/RenderMedia.cpp: (WebCore::rendererContainsPoint): (WebCore::RenderMedia::forwardEvent):
6:33 PM Changeset in webkit [38611] by andersca@apple.com
  • 3 edits
    1 copy
    1 add in trunk

WebKit/mac:

2008-11-19 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Test: plugins/netscape-plugin-setwindow-size-2.html


Fix bug where NPP_SetWindow wasn't getting called for some plug-ins.


  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView updateAndSetWindow]): Don't bail if the drawing model is not the CA drawing model. Remove some code that was doing the wrong thing.

LayoutTests:

2008-11-19 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Add NPP_SetWindow test.


  • plugins/netscape-plugin-setwindow-size-2-expected.txt: Added.
  • plugins/netscape-plugin-setwindow-size-2.html: Copied from plugins/netscape-plugin-setwindow-size.html.
6:05 PM Changeset in webkit [38610] by darin@chromium.org
  • 19 edits
    2 adds in trunk

2008-11-18 Darin Fisher <​darin@chromium.org>

Reviewed by Geoff Garen.

​https://bugs.webkit.org/show_bug.cgi?id=22345
Define ScriptValue as a thin container for a JSC::Value*.

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/ScheduledAction.cpp:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluate):
  • bindings/js/ScriptController.h:
  • bindings/js/ScriptValue.cpp: Added. (WebCore::ScriptValue::getString):
  • bindings/js/ScriptValue.h: Added. (WebCore::ScriptValue::ScriptValue): (WebCore::ScriptValue::jsValue):
  • dom/ScriptElement.cpp:
  • dom/XMLTokenizer.cpp:
  • dom/XMLTokenizerLibxml2.cpp:
  • html/HTMLTokenizer.cpp:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::executeIfJavaScriptURL): (WebCore::FrameLoader::executeScript):
  • loader/FrameLoader.h:
5:53 PM Changeset in webkit [38609] by wsiegrist@apple.com
  • 1 edit in trunk/BugsSite/data/params

2008-11-19 William Siegrist <​wsiegrist@apple.com>

Reviewed by David Kilzer

Sync config changes made to bugzilla on the server

5:33 PM Changeset in webkit [38608] by Beth Dakin
  • 2 edits in trunk/WebCore

2008-11-19 Beth Dakin <Beth Dakin>

Reviewed by Justin Garcia.

Fix for <rdar://problem/5472507> Remove color property when a user
sets color to black

This patch prevents us from inserting font nodes during the
ApplyStyleCommand if they will not change the computed style of an
element.

  • editing/ApplyStyleCommand.cpp: (WebCore::fontColorChangesComputedStyle): (WebCore::fontSizeChangesComputedStyle): (WebCore::fontFaceChangesComputedStyle): (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
5:30 PM Changeset in webkit [38607] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2008-11-19 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/6383762> WebKit r38340 crash on key press in plugin


Set the value to 0 before calling NPP_GetValue, in case the plug-in returns NPERR_NO_ERROR but does not
update the value.


  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView createPlugin]):
4:45 PM Changeset in webkit [38606] by adele@apple.com
  • 2 edits in trunk/WebKit/win

2008-11-19 Adele Peterson <​adele@apple.com>

Reviewed by Darin Adler.

For transparent views, clear the dirty rect instead of painting it white.


  • WebView.cpp: (WebView::paintIntoBackingStore):
2:11 PM Changeset in webkit [38605] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2008-11-19 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Make sure to copy the MIME type.


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]):
1:59 PM Changeset in webkit [38604] by ggaren@apple.com
  • 4 edits in trunk/WebKit/mac

2008-11-19 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin Adler.


First step toward fixing <rdar://problem/6263293> WebScriptDebugDelegate
should use intptr_t for sourceId, not int


Added a conditional typedef (currently disabled) to switch sourceId to
intptr_t in non-Tiger, non-Leopard builds.

  • DefaultDelegates/WebDefaultScriptDebugDelegate.m: (-[WebDefaultScriptDebugDelegate webView:didParseSource:fromURL:sourceId:forWebFrame:]): (-[WebDefaultScriptDebugDelegate webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]): (-[WebDefaultScriptDebugDelegate webView:didEnterCallFrame:sourceId:line:forWebFrame:]): (-[WebDefaultScriptDebugDelegate webView:willExecuteStatement:sourceId:line:forWebFrame:]): (-[WebDefaultScriptDebugDelegate webView:willLeaveCallFrame:sourceId:line:forWebFrame:]): (-[WebDefaultScriptDebugDelegate webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
  • WebView/WebScriptDebugDelegate.h:
  • WebView/WebScriptDebugger.mm: (WebScriptDebugger::sourceParsed): (WebScriptDebugger::callEvent): (WebScriptDebugger::atStatement): (WebScriptDebugger::returnEvent): (WebScriptDebugger::exception):
1:08 PM Changeset in webkit [38603] by ggaren@apple.com
  • 6 edits
    2 adds in trunk

JavaScriptCore:

2008-11-19 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin Adler.


​https://bugs.webkit.org/show_bug.cgi?id=22361
A little more RegExp refactoring.


Consistently named variables holding the starting position at which
regexp matching should begin to "startOffset".


A few more "regExpObject" => "regExpConstructor" changes.


Refactored RegExpObject::match for clarity, and replaced a slow "get"
of the "global" property with a fast access to the global bit.


Made the error message you see when RegExpObject::match has no input a
little more informative, as in Firefox.

  • runtime/RegExp.cpp: (JSC::RegExp::match):
  • runtime/RegExp.h:
  • runtime/RegExpObject.cpp: (JSC::RegExpObject::match):
  • runtime/StringPrototype.cpp: (JSC::stringProtoFuncReplace): (JSC::stringProtoFuncMatch): (JSC::stringProtoFuncSearch):

LayoutTests:

2008-11-19 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin Adler.


Test for ​https://bugs.webkit.org/show_bug.cgi?id=22361
A little more RegExp refactoring

  • fast/js/regexp-test-null-string.html: Added.
  • fast/js/regexp-test-null-expected.txt: Added.
1:07 PM Changeset in webkit [38602] by Simon Fraser
  • 5 edits in trunk/WebCore

2008-11-19 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler

​https://bugs.webkit.org/show_bug.cgi?id=22348

Need to educate style sharing about autofill, so that style does not
get shared between input elements that are autofilled, and those
that are not. Setting autofill should also do a setChanged on the node.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::canShareStyleWithElement): (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
  • dom/Node.h: (WebCore::Node::isAutofilled):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setAutofilled):
  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::isAutofilled):
12:44 PM Changeset in webkit [38601] by brettw@chromium.org
  • 2 edits in trunk/WebCore

Reviewed by Antti Koivisto.

​https://bugs.webkit.org/show_bug.cgi?id=22349

Clear the subresource loader client when the client is removed in
response to a 304 (not modified). This prevents an inconsistent state
where the loader thinks it's active and the loader::Host doesn't.

11:16 AM Changeset in webkit [38600] by ggaren@apple.com
  • 5 edits in trunk/JavaScriptCore

2008-11-19 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.


A little more refactoring.


Removed the "emit" and "emitUnlinked" prefixes from the assembler.


Moved the JmpSrc and JmpDst class definitions to the top of the X86
assembler class, in accordance with WebKit style guidelines.

  • assembler/X86Assembler.h: (JSC::X86Assembler::JmpSrc::JmpSrc): (JSC::X86Assembler::JmpDst::JmpDst): (JSC::X86Assembler::int3): (JSC::X86Assembler::pushl_m): (JSC::X86Assembler::popl_m): (JSC::X86Assembler::movl_rr): (JSC::X86Assembler::addl_rr): (JSC::X86Assembler::addl_i8r): (JSC::X86Assembler::addl_i8m): (JSC::X86Assembler::addl_i32r): (JSC::X86Assembler::addl_mr): (JSC::X86Assembler::andl_rr): (JSC::X86Assembler::andl_i32r): (JSC::X86Assembler::cmpl_i8r): (JSC::X86Assembler::cmpl_rr): (JSC::X86Assembler::cmpl_rm): (JSC::X86Assembler::cmpl_mr): (JSC::X86Assembler::cmpl_i32r): (JSC::X86Assembler::cmpl_i32m): (JSC::X86Assembler::cmpl_i8m): (JSC::X86Assembler::cmpw_rm): (JSC::X86Assembler::orl_rr): (JSC::X86Assembler::orl_mr): (JSC::X86Assembler::orl_i32r): (JSC::X86Assembler::subl_rr): (JSC::X86Assembler::subl_i8r): (JSC::X86Assembler::subl_i8m): (JSC::X86Assembler::subl_i32r): (JSC::X86Assembler::subl_mr): (JSC::X86Assembler::testl_i32r): (JSC::X86Assembler::testl_i32m): (JSC::X86Assembler::testl_rr): (JSC::X86Assembler::xorl_i8r): (JSC::X86Assembler::xorl_rr): (JSC::X86Assembler::sarl_i8r): (JSC::X86Assembler::sarl_CLr): (JSC::X86Assembler::shl_i8r): (JSC::X86Assembler::shll_CLr): (JSC::X86Assembler::imull_rr): (JSC::X86Assembler::imull_i32r): (JSC::X86Assembler::idivl_r): (JSC::X86Assembler::negl_r): (JSC::X86Assembler::movl_mr): (JSC::X86Assembler::movzbl_rr): (JSC::X86Assembler::movzwl_mr): (JSC::X86Assembler::movl_rm): (JSC::X86Assembler::movl_i32r): (JSC::X86Assembler::movl_i32m): (JSC::X86Assembler::leal_mr): (JSC::X86Assembler::jmp_r): (JSC::X86Assembler::jmp_m): (JSC::X86Assembler::movsd_mr): (JSC::X86Assembler::xorpd_mr): (JSC::X86Assembler::movsd_rm): (JSC::X86Assembler::movd_rr): (JSC::X86Assembler::cvtsi2sd_rr): (JSC::X86Assembler::cvttsd2si_rr): (JSC::X86Assembler::addsd_mr): (JSC::X86Assembler::subsd_mr): (JSC::X86Assembler::mulsd_mr): (JSC::X86Assembler::addsd_rr): (JSC::X86Assembler::subsd_rr): (JSC::X86Assembler::mulsd_rr): (JSC::X86Assembler::ucomis_rr): (JSC::X86Assembler::pextrw_irr): (JSC::X86Assembler::call): (JSC::X86Assembler::jmp): (JSC::X86Assembler::jne): (JSC::X86Assembler::jnz): (JSC::X86Assembler::je): (JSC::X86Assembler::jl): (JSC::X86Assembler::jb): (JSC::X86Assembler::jle): (JSC::X86Assembler::jbe): (JSC::X86Assembler::jge): (JSC::X86Assembler::jg): (JSC::X86Assembler::ja): (JSC::X86Assembler::jae): (JSC::X86Assembler::jo): (JSC::X86Assembler::jp): (JSC::X86Assembler::js): (JSC::X86Assembler::predictNotTaken): (JSC::X86Assembler::convertToFastCall): (JSC::X86Assembler::restoreArgumentReference): (JSC::X86Assembler::restoreArgumentReferenceForTrampoline): (JSC::X86Assembler::modRm_rr): (JSC::X86Assembler::modRm_rr_Unchecked): (JSC::X86Assembler::modRm_rm): (JSC::X86Assembler::modRm_rm_Unchecked): (JSC::X86Assembler::modRm_rmsib): (JSC::X86Assembler::modRm_opr): (JSC::X86Assembler::modRm_opr_Unchecked): (JSC::X86Assembler::modRm_opm): (JSC::X86Assembler::modRm_opm_Unchecked): (JSC::X86Assembler::modRm_opmsib):
  • jit/JIT.cpp: (JSC::JIT::emitNakedCall): (JSC::JIT::emitNakedFastCall): (JSC::JIT::emitCTICall): (JSC::JIT::emitJumpSlowCaseIfNotJSCell): (JSC::JIT::emitJumpSlowCaseIfNotImmNum): (JSC::JIT::emitFastArithDeTagImmediateJumpIfZero): (JSC::JIT::emitFastArithIntToImmOrSlowCase): (JSC::JIT::emitArithIntToImmWithJump): (JSC::JIT::compileOpCall): (JSC::JIT::compileOpStrictEq): (JSC::JIT::emitSlowScriptCheck): (JSC::JIT::putDoubleResultToJSNumberCellOrJSImmediate): (JSC::JIT::compileBinaryArithOp): (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases): (JSC::JIT::privateCompile): (JSC::JIT::privateCompileGetByIdSelf): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdChain): (JSC::JIT::privateCompilePutByIdReplace): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompileCTIMachineTrampolines): (JSC::JIT::privateCompilePatchGetArrayLength):
  • wrec/WREC.cpp: (JSC::WREC::compileRegExp):
  • wrec/WRECGenerator.cpp: (JSC::WREC::Generator::generateBackreferenceQuantifier): (JSC::WREC::Generator::generateNonGreedyQuantifier): (JSC::WREC::Generator::generateGreedyQuantifier): (JSC::WREC::Generator::generatePatternCharacter): (JSC::WREC::Generator::generateCharacterClassInvertedRange): (JSC::WREC::Generator::generateCharacterClassInverted): (JSC::WREC::Generator::generateCharacterClass): (JSC::WREC::Generator::generateParentheses): (JSC::WREC::Generator::generateParenthesesNonGreedy): (JSC::WREC::Generator::generateParenthesesResetTrampoline): (JSC::WREC::Generator::generateAssertionBOL): (JSC::WREC::Generator::generateAssertionEOL): (JSC::WREC::Generator::generateAssertionWordBoundary): (JSC::WREC::Generator::generateBackreference): (JSC::WREC::Generator::generateDisjunction):
10:28 AM Changeset in webkit [38599] by ap@webkit.org
  • 4 edits
    2 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=22355
Systematize code for replacing global constructors

Test: fast/workers/worker-replace-global-constructor.html

  • bindings/js/JSDOMWindowBase.cpp: (setJSDOMWindowBaseEvent): Changed to put the value as property, matching what generated code for global constructor setters does. (setJSDOMWindowBaseAudio): Ditto. (setJSDOMWindowBaseImage): Ditto. (setJSDOMWindowBaseMessageChannel): Ditto. (setJSDOMWindowBaseOption): Ditto. (setJSDOMWindowBaseWorker): Ditto. (setJSDOMWindowBaseXMLHttpRequest): Ditto. (setJSDOMWindowBaseXSLTProcessor): Ditto. (WebCore::JSDOMWindowBase::put): Removed special cases for global constructors.
  • bindings/js/JSWorkerContext.cpp: (WebCore::JSWorkerContext::getOwnPropertySlot): Look up overrides before own properties, as it is done for Window. (WebCore::setJSWorkerContextMessageEvent): Implemented in the same way as Window global constructors are. (WebCore::setJSWorkerContextWorkerLocation): Ditto.
10:09 AM Changeset in webkit [38598] by bolsinga@apple.com
  • 2 edits in trunk/WebKitTools

2008-11-19 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=21810
Remove use of static C++ objects that are destroyed at exit time (destructors)

All static C++ objects that create atexit calls are gone. Update script
to indicate how to fix the problem should a new one appear.


  • Scripts/check-for-exit-time-destructors:
9:57 AM Changeset in webkit [38597] by ap@webkit.org
  • 4 edits in trunk/WebCore

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=22341
Text codecs should not use static data without locking

  • platform/text/TextCodecICU.cpp:
  • platform/text/mac/TextCodecMac.cpp: Made cached converters per-thread.
  • platform/text/TextEncodingRegistry.cpp: (WebCore::encodingRegistryMutex): Added a mutex for codec maps access. (WebCore::addToTextCodecMap): Don't use TextEncoding just to cacnonicalize the name, as it causes a dedalock due to a recursive call into registry. (WebCore::buildBaseTextCodecMaps): Added assertions. (WebCore::newTextCodec): Take a lock to avoid concurrent access to codec maps. (WebCore::atomicCanonicalTextEncodingName): Ditto. (WebCore::noExtendedTextEncodingNameUsed): Added a comment, explaining why locking is not necessary here.
9:57 AM Changeset in webkit [38596] by ap@webkit.org
  • 2 edits in trunk/WebCore

Touch WebCorePrefix.h to force a rebuild, needed because of changed feature defines.

  • WebCorePrefix.h:
9:42 AM Changeset in webkit [38595] by ap@webkit.org
  • 25 edits in trunk/WebCore

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=22310
Worker exceptions should be printed to console

  • dom/Document.cpp: (WebCore::Document::reportException):
  • dom/Document.h:
  • dom/ScriptExecutionContext.h:
  • dom/WorkerContext.cpp: (WebCore::WorkerContext::reportException):
  • dom/WorkerContext.h: Added a reportException() method on ScriptExecutionContext. It forwards the exception info up until it finds a Document context, and then it prints it to console.
  • bindings/js/JSEventListener.cpp: (WebCore::JSAbstractEventListener::handleEvent): Don't talk to Console directly, use ScriptExecutionContext::reportException. Also, fixed a bug where Document::updateDocumentsRendering() could be called from workers. (WebCore::JSLazyEventListener::parseCode): Moved variable declaration inside if block for clarity.
  • bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate): Report exceptions to ScriptExecutionContext.
  • dom/WorkerMessagingProxy.cpp: (WebCore::MessageWorkerTask::performTask): (WebCore::WorkerExceptionTask::create): (WebCore::WorkerExceptionTask::WorkerExceptionTask): (WebCore::WorkerExceptionTask::performTask): (WebCore::WorkerMessagingProxy::postWorkerException):
  • dom/WorkerMessagingProxy.h: Added a task for posting exception information.
  • bindings/js/JSDOMBinding.cpp: (WebCore::reportException): (WebCore::reportCurrentException):
  • bindings/js/JSDOMBinding.h: Added helper methods for reporting exceptions via ScriptExecutionContext.
  • page/Console.cpp:
  • page/Console.h: Removed methods for directly reporting exceptions to console.
  • bindings/js/JSCustomPositionCallback.cpp: (WebCore::JSCustomPositionCallback::handleEvent):
  • bindings/js/JSCustomPositionErrorCallback.cpp: (WebCore::JSCustomPositionErrorCallback::handleEvent):
  • bindings/js/JSCustomSQLStatementCallback.cpp: (WebCore::JSCustomSQLStatementCallback::handleEvent):
  • bindings/js/JSCustomSQLStatementErrorCallback.cpp: (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
  • bindings/js/JSCustomSQLTransactionCallback.cpp: (WebCore::JSCustomSQLTransactionCallback::handleEvent):
  • bindings/js/JSCustomSQLTransactionErrorCallback.cpp: (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
  • bindings/js/JSCustomVoidCallback.cpp: (WebCore::JSCustomVoidCallback::handleEvent):
  • bindings/js/JSCustomXPathNSResolver.cpp: (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
  • bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::execute):
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluate):
  • bindings/objc/WebScriptObject.mm: (WebCore::addExceptionToConsole): Switch to JSDOMBinding methods for reporting exceptions.
8:19 AM Changeset in webkit [38594] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2008-11-19 Simon Hausmann <Simon Hausmann>

Sun CC build fix, removed trailing comman for last enum value.

4:17 AM Changeset in webkit [38593] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2008-11-19 Simon Hausmann <Simon Hausmann>

Fix the Qt build, remove file referenced in the qrc file that does not
exist and is not needed.

1:06 AM Changeset in webkit [38592] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Expand the workaround for Apple GCC compiler bug <rdar://problem/6354696> to all versions of GCC 4.0.1.
It has been observed with builds 5465 (Xcode 3.0) and 5484 (Xcode 3.1), and there is no evidence
that it has been fixed in newer builds of GCC 4.0.1.

This addresses <​https://bugs.webkit.org/show_bug.cgi?id=22351> (WebKit nightly crashes on launch on 10.4.11).

Reviewed by Alexey Proskuryakov.

  • wtf/StdLibExtras.h:

Nov 18, 2008:

11:51 PM Changeset in webkit [38591] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Mark Rowe.

  • platform/ContextMenuItem.h: (WebCore::ContextMenuAction): Reorder this enum to keep it in sync with the one in WebUIDelegate.h.
8:04 PM Changeset in webkit [38590] by cwzwarich@webkit.org
  • 3 edits
    3 adds in trunk

2008-11-18 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Maciej Stachowiak and Geoff Garen.

Bug 22287: ASSERTION FAILED: Not enough jumps linked in slow case codegen in CTI::privateCompileSlowCases())
<​https://bugs.webkit.org/show_bug.cgi?id=22287>

Fix a typo in the number cell reuse code where the first and second
operands are sometimes confused.

JavaScriptcore:

  • jit/JIT.cpp: (JSC::JIT::compileBinaryArithOpSlowCase):

LayoutTests:

  • fast/js/number-cell-reuse-expected.txt: Added.
  • fast/js/number-cell-reuse.html: Added.
  • fast/js/resources/number-cell-reuse.js: Added.
5:58 PM Changeset in webkit [38589] by darin@chromium.org
  • 2 edits in trunk/WebCore

2008-11-18 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=22346
PlatformString should also include HashSet.h for non-JSC builds

  • platform/text/PlatformString.h:
5:22 PM Changeset in webkit [38588] by adele@apple.com
  • 2 edits in trunk/WebKit/win

2008-11-18 Adele Peterson <​adele@apple.com>

Reverting last change. I just realized it causes the view to never get cleared out.

  • WebView.cpp: (WebView::paintIntoBackingStore):
5:11 PM Changeset in webkit [38587] by adele@apple.com
  • 2 edits in trunk/WebKit/win

2008-11-18 Adele Peterson <​adele@apple.com>

Reviewed by John Sullivan.

Don't fill the view with white if its transparent.


  • WebView.cpp: (WebView::paintIntoBackingStore):
4:57 PM Changeset in webkit [38586] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Mark Rowe.

  • WebView/WebUIDelegatePrivate.h: Reorder new enum values after existing ones.
4:46 PM Changeset in webkit [38585] by zecke@webkit.org
  • 2 edits in trunk/LayoutTests

2008-11-18 Holger Hans Peter Freyther <​zecke@selfish.org>

Rubber-stamped by Mark Rowe.

Skip some more tests to make the Gtk+ build bot pass. We will
have to investigate why some tests only fail on the build bot.

  • platform/gtk/Skipped:
4:25 PM Changeset in webkit [38584] by adele@apple.com
  • 2 edits in trunk/WebCore

2008-11-18 Adele Peterson <​adele@apple.com>

Reviewed by Holger Hans Peter Freyther.

Flip check added in recent refactoring so the background gets updated when the background color is valid, not invalid.

  • loader/FrameLoaderClient.cpp: (WebCore::FrameLoaderClient::transitionToCommittedForNewPage):
4:05 PM Changeset in webkit [38583] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

2008-11-18 Sam Weinig <​sam@webkit.org>

Fix incorrect result.

  • fast/dom/Window/window-properties-expected.txt:
3:52 PM Changeset in webkit [38582] by darin@chromium.org
  • 2 edits in trunk/WebCore

Reverting r38574 since it caused some layout test failures.

3:51 PM Changeset in webkit [38581] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

Not reviewed. Checked in wrong result in last commit.

3:39 PM Changeset in webkit [38580] by darin@chromium.org
  • 2 edits in trunk/WebCore

2008-11-18 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=22343
Remove unused runtime/Collector, JSLock includes in Page.cpp

  • page/Page.cpp:
3:30 PM Changeset in webkit [38579] by adachan@apple.com
  • 2 edits in trunk/WebCore

Bug 22344: Make select popup window opaque
​https://bugs.webkit.org/show_bug.cgi?id=22344

Reviewed by Steve Falkenburg.

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::show):
3:16 PM Changeset in webkit [38578] by darin@chromium.org
  • 2 edits in trunk/WebCore

2008-11-18 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=22342
Remove unused JSLock.h include

  • dom/Document.cpp:
2:15 PM Changeset in webkit [38577] by Nikolas Zimmermann
  • 14 edits
    93 adds in trunk

Reviewed by Sam Weinig.

Fixes: ​https://bugs.webkit.org/show_bug.cgi?id=22334

Add WMLBRElement, correcting <br/> behaviour in WML.
Enable entity replacment for WML documents.
Handle WML specific <p> 'mode' attribute.

Generate layout tests results for fast/wml.

Tests cases that pass now:
fast/wml/br-element-in-table.wml
fast/wml/br-element-in-text.wml
fast/wml/case-sensitivity.wml
fast/wml/cdata-section.wml
fast/wml/comment.wml
fast/wml/entity.wml
fast/wml/p-align.wml
fast/wml/p-mode.wml
fast/wml/text-emphasis.wml
fast/wml/validate-dtd.wml

2:04 PM Changeset in webkit [38576] by mitz@apple.com
  • 2 edits in trunk/JavaScriptCore
  • try to fix the Windows build
  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
1:52 PM Changeset in webkit [38575] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-11-18 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.


Minor RegExp cleanup.


SunSpider says no change.

  • runtime/RegExpObject.cpp: (JSC::RegExpObject::match): Renamed "regExpObj" to "regExpConstructor".
  • wrec/WREC.cpp: (JSC::WREC::compileRegExp): Instead of checking for a NULL output vector, ASSERT that the output vector is not NULL. (The rest of WREC is not safe to use with a NULL output vector, and we probably don't want to spend the time and/or performance to make it safe.)
1:21 PM Changeset in webkit [38574] by darin@chromium.org
  • 2 edits in trunk/WebCore

2008-11-18 Aaron Boodman ​aa@chromium.org

Reviewed by Maciej Stachowiak.

​https://bugs.webkit.org/show_bug.cgi?id=22301
Always call dispatchDidFinishDocumentLoad before Window's onload event.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::finishedParsing):
12:38 PM Changeset in webkit [38573] by ggaren@apple.com
  • 2 edits in trunk/LayoutTests

2008-11-18 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Alexey Proskuryakov.


Updated layout test result for addition of window.Worker.

  • fast/js/global-constructors-expected.txt:
12:07 PM Changeset in webkit [38572] by ggaren@apple.com
  • 5 edits in trunk/JavaScriptCore

2008-11-18 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin Adler.


A little more renaming and refactoring.


VM_CHECK_EXCEPTION() => CHECK_FOR_EXCEPTION().
NEXT_INSTRUCTION => NEXT_INSTRUCTION().

Removed the "Error_" and "TempError_" prefixes from WREC error types.

Refactored the WREC parser so it doesn't need a "setError" function,
and changed "isEndOfPattern" and its use -- they read kind of backwards
before.


Changed our "TODO:" error messages at least to say something, since you
can't say "TODO:" in shipping software.

  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute): (JSC::Interpreter::cti_op_convert_this): (JSC::Interpreter::cti_op_add): (JSC::Interpreter::cti_op_pre_inc): (JSC::Interpreter::cti_op_loop_if_less): (JSC::Interpreter::cti_op_loop_if_lesseq): (JSC::Interpreter::cti_op_put_by_id): (JSC::Interpreter::cti_op_put_by_id_second): (JSC::Interpreter::cti_op_put_by_id_generic): (JSC::Interpreter::cti_op_put_by_id_fail): (JSC::Interpreter::cti_op_get_by_id): (JSC::Interpreter::cti_op_get_by_id_second): (JSC::Interpreter::cti_op_get_by_id_generic): (JSC::Interpreter::cti_op_get_by_id_fail): (JSC::Interpreter::cti_op_instanceof): (JSC::Interpreter::cti_op_del_by_id): (JSC::Interpreter::cti_op_mul): (JSC::Interpreter::cti_op_call_NotJSFunction): (JSC::Interpreter::cti_op_resolve): (JSC::Interpreter::cti_op_construct_NotJSConstruct): (JSC::Interpreter::cti_op_get_by_val): (JSC::Interpreter::cti_op_resolve_func): (JSC::Interpreter::cti_op_sub): (JSC::Interpreter::cti_op_put_by_val): (JSC::Interpreter::cti_op_put_by_val_array): (JSC::Interpreter::cti_op_lesseq): (JSC::Interpreter::cti_op_loop_if_true): (JSC::Interpreter::cti_op_negate): (JSC::Interpreter::cti_op_resolve_skip): (JSC::Interpreter::cti_op_resolve_global): (JSC::Interpreter::cti_op_div): (JSC::Interpreter::cti_op_pre_dec): (JSC::Interpreter::cti_op_jless): (JSC::Interpreter::cti_op_not): (JSC::Interpreter::cti_op_jtrue): (JSC::Interpreter::cti_op_post_inc): (JSC::Interpreter::cti_op_eq): (JSC::Interpreter::cti_op_lshift): (JSC::Interpreter::cti_op_bitand): (JSC::Interpreter::cti_op_rshift): (JSC::Interpreter::cti_op_bitnot): (JSC::Interpreter::cti_op_resolve_with_base): (JSC::Interpreter::cti_op_mod): (JSC::Interpreter::cti_op_less): (JSC::Interpreter::cti_op_neq): (JSC::Interpreter::cti_op_post_dec): (JSC::Interpreter::cti_op_urshift): (JSC::Interpreter::cti_op_bitxor): (JSC::Interpreter::cti_op_bitor): (JSC::Interpreter::cti_op_push_scope): (JSC::Interpreter::cti_op_to_jsnumber): (JSC::Interpreter::cti_op_in): (JSC::Interpreter::cti_op_del_by_val):
  • wrec/WREC.cpp: (JSC::WREC::compileRegExp):
  • wrec/WRECParser.cpp: (JSC::WREC::Parser::parseGreedyQuantifier): (JSC::WREC::Parser::parseParentheses): (JSC::WREC::Parser::parseCharacterClass): (JSC::WREC::Parser::parseEscape):
  • wrec/WRECParser.h: (JSC::WREC::Parser::): (JSC::WREC::Parser::atEndOfPattern):
11:58 AM Changeset in webkit [38571] by Beth Dakin
  • 1 edit in trunk/WebKit/mac/ChangeLog

2008-11-17 Beth Dakin <Beth Dakin>

Reviewed by Adele Peterson.

Fix for <rdar://problem/6373102> REGRESSION (r36919): In a new mail
message, the caret appears in message body by default

This fixes a regression caused by ​http://trac.webkit.org/changeset/36919.
That change was too sweeping; we do not want to
unconditionally set the page to be active, but we can be looser
than the original constraints. This patch set the window active if
the first responder is or is a descendant of the main frame's frame
view.

  • WebView/WebView.mm: (-[WebView _updateFocusedAndActiveStateForFrame:]):
11:57 AM Changeset in webkit [38570] by Beth Dakin
  • 2 edits in trunk/WebKit/mac

2008-11-17 Beth Dakin <Beth Dakin>

Reviewed by Adele Peterson.

Fix for <rdar://problem/6373102> REGRESSION (r36919): In a new mail
message, the caret appears in message body by default

This fixes a regression caused by ​http://trac.webkit.org/changeset/

  1. That change was too sweeping; we do not want to unconditionally set the page to be active, but we can be looser than the original constraints. This patch set the window active if the first responder is or is a descendant of the main frame's frame view.
  • WebView/WebView.mm: (-[WebView _updateFocusedAndActiveStateForFrame:]):
11:23 AM Changeset in webkit [38569] by ap@webkit.org
  • 2 edits in trunk/WebCore

Windows build fix.

  • WebCore.vcproj/WebCore.vcproj: Fix relative paths to use $(WebKitOutputDir).
10:26 AM Changeset in webkit [38568] by Darin Adler
  • 2 edits in trunk/WebCore

2008-11-18 Darin Adler <Darin Adler>

  • try to fix Wx build
  • WebCoreSources.bkl: Added FrameLoaderClient.cpp.
10:25 AM Changeset in webkit [38567] by ap@webkit.org
  • 11 edits
    12 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=22337
Enable workers by default

10:23 AM Changeset in webkit [38566] by Darin Adler
  • 11 edits
    3 adds in trunk

WebCore:

2008-11-18 Darin Adler <Darin Adler>

Reviewed by Alexey Proskuryakov.

Test: http/tests/xmlhttprequest/get-dangerous-headers.html

No test for HTTP-only support in JavaScript yet, since the Mac and Win changes
require an updated CFNetwork.

  • platform/mac/CookieJar.mm: (WebCore::isHTTPOnly): Added. (WebCore::filterCookies): Added. (WebCore::cookies): Use filterCookies to prevent getting HTTP-only cookies. (WebCore::setCookies): Use filterCookies to prevent setting HTTP-only cookies.
  • platform/network/win/CookieJarCFNetWin.cpp: (WebCore::isHTTPOnly): Added. (WebCore::filterCookies): Added. (WebCore::setCookies): Use filterCookies to prevent getting HTTP-only cookies. (WebCore::cookies): Use filterCookies to prevent getting HTTP-only cookies.
  • xml/XMLHttpRequest.cpp: (WebCore::isSetCookieHeader): Added. (WebCore::XMLHttpRequest::getAllResponseHeaders): Hide Set-Cookie headers from clients that don't have local-resource privileges. (WebCore::XMLHttpRequest::getResponseHeader): Ditto.
  • clean soup-specific details out of shared cookie jar header
  • platform/CookieJar.h: Removed the soup-specific parts of this.
  • platform/network/soup/CookieJarSoup.cpp: Changed to include CookieJarSoup.h. Tweaked implementation a bit to handle UTF-8 better.
  • platform/network/soup/CookieJarSoup.h: Added. Has the Soup-specified part of CookieJar.h.
  • platform/network/soup/ResourceHandleSoup.cpp: Changed to include CookieJarSoup.h.

LayoutTests:

2008-11-18 Darin Adler <Darin Adler>

Reviewed by Alexey Proskuryakov.

  • add a test for XMLHttpRequest Set-Cookie blocking
  • http/tests/xmlhttprequest/access-control-basic-whitelist-response-headers-expected.txt: Updated since we now log attempts to get headers that are not allowed cross-domain to the console.
  • http/tests/xmlhttprequest/get-dangerous-headers-expected.txt: Added.
  • http/tests/xmlhttprequest/get-dangerous-headers.html: Added.
  • http/tests/xmlhttprequest/resources/get-set-cookie.cgi: Tweak script a bit.
9:59 AM Changeset in webkit [38565] by sfalken@apple.com
  • 2 edits in trunk/WebCore

2008-11-18 Steve Falkenburg <​sfalken@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=22329
Improper bitwise and tests against 0 in Windows context menu code

Reviewed by John Sullivan.

  • platform/win/ContextMenuItemWin.cpp: (WebCore::ContextMenuItem::type): (WebCore::ContextMenuItem::enabled):
9:32 AM Changeset in webkit [38564] by sullivan@apple.com
  • 2 edits in trunk/WebCore

2008-11-18 John Sullivan <​sullivan@apple.com>

Yet more Mac build fixing

  • WebCore.base.exp: Export ZTVN7WebCore17FrameLoaderClientE
8:19 AM Changeset in webkit [38563] by vestbo@webkit.org
  • 2 edits
    1 add in trunk/WebKit/qt

2008-11-18 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Rubber-stamped by Tor Arne Vestbø.

Missing file in new unit test for QWebFrame (r38493).

  • tests/qwebframe/qwebframe.pro:
  • tests/qwebframe/qwebframe.qrc: Added.
8:09 AM Changeset in webkit [38562] by vestbo@webkit.org
  • 2 edits in trunk/WebKit/qt

2008-11-18 Tor Arne Vestbø <​tavestbo@trolltech.com>

Rubber-stamped by Simon Hausmann.

Make sure QWidget based plugins are invisible until placed into the layout

6:43 AM Changeset in webkit [38561] by ap@webkit.org
  • 4 edits in trunk/JavaScriptCore
  • Windows build fix
  • wrec/WRECFunctors.h:
  • wrec/WRECGenerator.h:
  • wrec/WRECParser.h: CharacterClass is a struct, not a class, fix forward declarations.
6:41 AM Changeset in webkit [38560] by vestbo@webkit.org
  • 4 edits in trunk

2008-11-18 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon Hausmann.

React properly to frame rect changes for QWidget based plugins

We now set the geometry of the QWidget in frameRectsChanged,
intead of setFrameRect, which means we pick up the changes to
the frame rect when scrolling. We also set a mask on the
widget to keep it from painting over scrollbars and the like

6:41 AM Changeset in webkit [38559] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2008-11-18 Tor Arne Vestbø <​tavestbo@trolltech.com>

Rubber-stamped by Simon Hausmann.

Don't mark scrollbars as focused in QtWebKit

When initing from the widget we also got the focus state,
but this does not make sense for scrollbars.

6:30 AM Changeset in webkit [38558] by zecke@webkit.org
  • 2 edits in trunk/WebKit/win

Try to fix the Windows build.

5:46 AM Changeset in webkit [38557] by ap@webkit.org
  • 2 edits in trunk/WebCore

More Mac build fixing.

  • WebCore.base.exp: Export FrameLoaderClient destructor.
4:53 AM Changeset in webkit [38556] by ap@webkit.org
  • 2 edits in trunk/WebCore

Mac build fix.

  • WebCore.xcodeproj/project.pbxproj: Add FrameLoaderClient.cpp for now.
4:37 AM Changeset in webkit [38555] by vestbo@webkit.org
  • 2 edits in trunk/WebKit/qt

2008-11-18 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Reviewed by Tor Arne Vestbø.

Fix crash when trying to pick a file using the file chooser.

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::runOpenPanel):

2008-11-17 Geoffrey Garen <​ggaren@apple.com>

4:33 AM Changeset in webkit [38554] by zecke@webkit.org
  • 14 edits
    1 add in trunk

Attempt to share transitionToCommittedForNewPage of FrameLoaderClient with the different ports

​https://bugs.webkit.org/show_bug.cgi?id=22056

After Hyatt's work on Widget and ScrollView there is little difference
between the implementation of Qt, Gtk+ and Win. In fact any kind of
difference is mostly a bug. Alp has fixed two of such errors for the Gtk+
port and the Qt port has at least one of them left.

The only difference between the implementations is in getting the the
IntSize for the new FrameView, the background color to be applied and
eventually some post processing.

Unify the implementations by providing a static helper function that
takes a Frame, IntSize, color and transparency bit and calling it from
the Gtk+, the Qt and the Windows port.

4:32 AM Changeset in webkit [38553] by zecke@webkit.org
  • 5 edits in trunk

Move setting the background color and transparency to WebCore

Move setting the background color and transparency from WebKit/win
to WebCore. This allows WebKit/win, WebKit/Qt and WebKit/Gtk+
to share this code.

3:36 AM Changeset in webkit [38552] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2008-11-17 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Reviewed by Tor Arne Vestbø.

Fix the bug where select elements are painted without border.
​http://trolltech.com/developer/task-tracker/index_html?id=218957&method=entry

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::paintMenuList):
2:06 AM Changeset in webkit [38551] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2008-11-18 Jan Michael Alonzo <​jmalonzo@webkit.org>

Gtk build fix. Not reviewed.

  • GNUmakefile.am: Fix USER_AGENT_STYLESHEETS, wml.css is in css/, not in wml/.
12:53 AM Changeset in webkit [38550] by ap@webkit.org
  • 2 edits in trunk/WebKitTools

Rubber-stamped by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=22306
Disable channel messaging support

  • Scripts/build-webkit: Add an option to enable channel messaging.
12:44 AM Changeset in webkit [38549] by ap@webkit.org
  • 12 edits in trunk/WebCore

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=22308
Improve Worker GC behavior

  • dom/ActiveDOMObject.cpp: (WebCore::ActiveDOMObject::hasPendingActivity):
  • dom/ActiveDOMObject.h: Made hasPendingActivity() virtual, letting Worker add behavior to it.
  • bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate):
  • dom/WorkerThread.cpp: (WebCore::WorkerThread::workerThread): Tell message proxy whether there are active objects in the worker whenever JS execution finishes.
  • dom/ScriptExecutionContext.h: (WebCore::ScriptExecutionContext::activeDOMObjects): Added a typedef for activeDOMObjects() return type, necessary to declare iterators.
  • dom/Worker.h:
  • dom/Worker.cpp: (WebCore::Worker::hasPendingActivity): A Worker is active if it is still loading, or if it has unconfirmed messages, or it the worker thread has pending activity.
  • dom/WorkerContext.h:
  • dom/WorkerContext.cpp: (WebCore::WorkerContext::hasPendingActivity): Check all registered active objects for pending activity.
  • dom/WorkerMessagingProxy.cpp: (WebCore::MessageWorkerContextTask::performTask): (WebCore::WorkerThreadActivityReportTask::create): (WebCore::WorkerThreadActivityReportTask::WorkerThreadActivityReportTask): (WebCore::WorkerThreadActivityReportTask::performTask): (WebCore::WorkerMessagingProxy::WorkerMessagingProxy): (WebCore::WorkerMessagingProxy::postMessageToWorkerContext): (WebCore::WorkerMessagingProxy::workerObjectDestroyed): (WebCore::WorkerMessagingProxy::workerContextDestroyedInternal): (WebCore::WorkerMessagingProxy::confirmWorkerThreadMessage): (WebCore::WorkerMessagingProxy::reportWorkerThreadActivity): (WebCore::WorkerMessagingProxy::reportWorkerThreadActivityInternal): (WebCore::WorkerMessagingProxy::workerThreadHasPendingActivity):
  • dom/WorkerMessagingProxy.h: Track outstanding messages, and activity reported by worker thread.
12:25 AM Changeset in webkit [38548] by mitz@apple.com
  • 2 edits in trunk/JavaScriptCore
  • Windows build fix
  • assembler/X86Assembler.h:
12:03 AM Changeset in webkit [38547] by ap@webkit.org
  • 8 edits
    12 moves
    1 add in trunk

Rubber-stamped by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=22306
Disable channel messaging support

WebCore:

  • bindings/js/JSDOMWindowBase.cpp: (jsDOMWindowBaseMessageChannel):
  • page/DOMWindow.idl: Hide MesssagePort and MessageChannel global constructors. Due to the way MessageChannel constructor is added, it remains enumerable, but undefined.

LayoutTests:

  • fast/events/message-port-no-wrapper.html-disabled: Added a test that I had in my tree.
  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/constructors-cached-expected.txt:
  • fast/dom/constructors-cached-navigate-expected.txt:
  • fast/js/global-constructors-expected.txt: Updated results.
  • fast/events/destroyed-atomic-string.html: Removed.
  • fast/events/destroyed-atomic-string.html-disabled: Copied from LayoutTests/fast/events/destroyed-atomic-string.html.
  • fast/events/message-channel-gc-2.html: Removed.
  • fast/events/message-channel-gc-2.html-disabled: Copied from LayoutTests/fast/events/message-channel-gc-2.html.
  • fast/events/message-channel-gc-3.html: Removed.
  • fast/events/message-channel-gc-3.html-disabled: Copied from LayoutTests/fast/events/message-channel-gc-3.html.
  • fast/events/message-channel-gc.html: Removed.
  • fast/events/message-channel-gc.html-disabled: Copied from LayoutTests/fast/events/message-channel-gc.html.
  • fast/events/message-channel-listener-circular-ownership.html: Removed.
  • fast/events/message-channel-listener-circular-ownership.html-disabled: Copied from LayoutTests/fast/events/message-channel-listener-circular-ownership.html.
  • fast/events/message-port-constructor-for-deleted-document.html: Removed.
  • fast/events/message-port-constructor-for-deleted-document.html-disabled: Copied from LayoutTests/fast/events/message-port-constructor-for-deleted-document.html.
  • fast/events/message-port-deleted-document.html: Removed.
  • fast/events/message-port-deleted-document.html-disabled: Copied from LayoutTests/fast/events/message-port-deleted-document.html.
  • fast/events/message-port-deleted-frame.html: Removed.
  • fast/events/message-port-deleted-frame.html-disabled: Copied from LayoutTests/fast/events/message-port-deleted-frame.html.
  • fast/events/message-port-inactive-document.html: Removed.
  • fast/events/message-port-inactive-document.html-disabled: Copied from LayoutTests/fast/events/message-port-inactive-document.html.
  • fast/events/message-port-onclose.html: Removed.
  • fast/events/message-port-onclose.html-disabled: Copied from LayoutTests/fast/events/message-port-onclose.html.
  • fast/events/message-port.html: Removed.
  • fast/events/message-port.html-disabled: Copied from LayoutTests/fast/events/message-port.html.
  • http/tests/security/MessagePort/event-listener-context.html: Removed.
  • http/tests/security/MessagePort/event-listener-context.html-disabled: Copied from LayoutTests/http/tests/security/MessagePort/event-listener-context.html. Disabled MessagePort tests.
Note: See TracTimeline for information about the timeline view.