⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 22, 2008:

10:47 AM Changeset in webkit [38693] by Nikolas Zimmermann
  • 2 edits
    4 adds in trunk/WebCore

Reviewed by Holger Freyther.
Fixes: ​https://bugs.webkit.org/show_bug.cgi?id=22426

Add WMLInstrinsicEvent/EventHandler implementation. Code not yet used.

8:37 AM Changeset in webkit [38692] by Nikolas Zimmermann
  • 5 edits
    8 adds in trunk/WebCore

Reviewed by Holger Freyther.

Fixes: ​https://bugs.webkit.org/show_bug.cgi?id=22423

Add <go> stub implementation. Add complete <prev>/<refresh> and <setvar> implementation.
Activate code handling <setvar> registration in WMLTaskElement.

7:39 AM Changeset in webkit [38691] by Nikolas Zimmermann
  • 3 edits in trunk/WebCore

Not reviewed. Forgot to include WMLPageState.* in the last commit.

Nov 21, 2008:

11:46 PM Changeset in webkit [38690] by ap@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

Reviewed by Geoff Garen.

​https://bugs.webkit.org/show_bug.cgi?id=22400
Add a stress test for concurrent JS execution

  • fast/workers/resources/stress-js-execution.js: Added.
  • fast/workers/stress-js-execution-expected.txt: Added.
  • fast/workers/stress-js-execution.html: Added. Tests that the basics don't cause a crash.
11:42 PM Changeset in webkit [38689] by ap@webkit.org
  • 6 edits in trunk/WebCore

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=22397
Worker threads are not destroyed if running a JS loop

Since the event loop is not ever entered again in this case, the fix necessarily involves
some shared data hackery.

  • dom/WorkerThread.cpp: (WebCore::WorkerThread::stop):
  • dom/WorkerThread.h: Added a stop() method, which asks the thread to exit as soon as possible. In the future, it may need to abort other kinds of synchronous processing, such as importScripts or XHR.
  • bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::WorkerScriptController): (WebCore::WorkerScriptController::evaluate): (WebCore::WorkerScriptController::forbidExecution):
  • bindings/js/WorkerScriptController.h: Added a forbidExecution() method, which interrupts currently running JS, and makes any future calls to evaluate() return immediately.
  • dom/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::workerObjectDestroyed): Call WorkerThread::stop().
7:34 PM Changeset in webkit [38688] by barraclough@apple.com
  • 7 edits in trunk/JavaScriptCore

2008-11-21 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Oliver Hunt.

Add (really) polymorphic caching for get by id self.
Very similar to caching of prototype accesses, described below.

Oh, also, probably shouldn't have been leaking those structure list objects.


4% preogression on deltablue.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump): (JSC::CodeBlock::derefStructures): (JSC::PrototypeStructureList::derefStructures):
  • bytecode/Instruction.h:
  • bytecode/Opcode.h:
  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute): (JSC::Interpreter::cti_op_get_by_id_self_fail):
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::patchGetByIdSelf):
  • jit/JIT.h: (JSC::JIT::compileGetByIdSelfList):
7:24 PM Changeset in webkit [38687] by kevino@webkit.org
  • 8 edits
    2 adds in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

Maintain an EditCommand stack in WebFramePrivate, and expose Undo and
Redo in wxWebView.

​https://bugs.webkit.org/show_bug.cgi?id=22403

7:21 PM Changeset in webkit [38686] by kevino@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

forgot to update the date when preparing the patch.

7:08 PM Changeset in webkit [38685] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Kevin Ollivier.

Improve wx image drawing performance considerably when using wxGraphicsContext
by avoiding unnecessary copies and drawing.

​https://bugs.webkit.org/show_bug.cgi?id=22404

6:27 PM Changeset in webkit [38684] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Kevin Ollivier.

Implementation of AffineTransform::mapRect for wx.

​https://bugs.webkit.org/show_bug.cgi?id=22401

5:50 PM Changeset in webkit [38683] by justin.garcia@apple.com
  • 14 edits
    1 add
    9 deletes in trunk

WebCore:

2008-11-21 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Darin Adler.

<rdar://problem/5381788> Match NSTextView editing behavior at the end of hyperlink text


Change link editing behavior to match TextEdit and MS Word when editing before and after
a link (Pages has two caret positions at link boundaries, Thunderbird and FF behave like we
used to, so it's difficult to get out of link editing mode):
When inserting before or after a link, always insert content outside of the link. This
makes it impossible to get stuck in link editing mode, while making it slightly more
difficult to edit link labels. WebKit editors that care about this can add UI for editing
link labels, like GMail and GoogleDocs have done. We never actually had any bugs complaining
about how it was difficult to edit link labels at the start/end, the code was just introduced
with another bug fix without much thought.


Don't remember removed links anymore, no other editor does this and it made it
difficult/impossible to get out of link editing mode. This code was added to fix
<rdar://problem/4069359>, which is fixed instead by removing the styles from an
enclosing anchor element from those styles that we remember when we delete content.

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary):
  • editing/CompositeEditCommand.h:
  • editing/DeleteSelectionCommand.cpp: (WebCore::removeEnclosingAnchorStyle): (WebCore::DeleteSelectionCommand::saveTypingStyleState): (WebCore::DeleteSelectionCommand::doApply):
  • editing/DeleteSelectionCommand.h:
  • editing/EditCommand.cpp: (WebCore::EditCommand::apply):
  • editing/Editor.cpp: (WebCore::Editor::appliedEditing):
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::prepareForTextInsertion): (WebCore::InsertTextCommand::input):
  • editing/RemoveFormatCommand.cpp: (WebCore::RemoveFormatCommand::doApply):
  • editing/SelectionController.cpp: (WebCore::SelectionController::setSelection):
  • editing/SelectionController.h:

LayoutTests:

2008-11-21 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Darin Adler.


<rdar://problem/5381788> Match NSTextView editing behavior at the end of hyperlink text


Removed tests for behaviors that we're no longer interested in:

  • editing/deleting/delete-link-1.html: Removed.
  • platform/mac/editing/deleting/delete-link-1-expected.checksum: Removed.
  • platform/mac/editing/deleting/delete-link-1-expected.png: Removed.
  • platform/mac/editing/deleting/delete-link-1-expected.txt: Removed.
  • editing/execCommand/19653-4-expected.txt: Removed.
  • editing/execCommand/19653-4.html: Removed.


Reflects new behavior (don't remember removed anchors):

  • platform/mac/editing/deleting/5168598-expected.txt:


Reflects new behavior. Also made this test cross-platform:

  • editing/inserting/insert-before-link-1-expected.txt: Added.
  • editing/inserting/insert-before-link-1.html:
  • platform/mac/editing/inserting/insert-before-link-1-expected.checksum: Removed.
  • platform/mac/editing/inserting/insert-before-link-1-expected.png: Removed.
  • platform/mac/editing/inserting/insert-before-link-1-expected.txt: Removed.
5:48 PM Changeset in webkit [38682] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-11-21 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.


Fixed many crashes seen 'round the world (but only in release builds).


Update outputParameter offset to reflect slight re-ordering of push
instructions in r38669.

  • wrec/WRECGenerator.cpp:
5:38 PM Changeset in webkit [38681] by alice.liu@apple.com
  • 2 edits in trunk/WebCore

2008-11-21 Alice Liu <​alice.liu@apple.com>

Rubber-stamped by Dan Bernstein.

fixed <rdar://6340771> crashing on print preview

  • platform/graphics/win/GraphicsContextCGWin.cpp: (WebCore::GraphicsContext::drawWindowsBitmap):
4:11 PM Changeset in webkit [38680] by darin@chromium.org
  • 5 edits
    1 add in trunk/WebCore

2008-11-21 Darin Fisher <​darin@chromium.org>

Reviewed by Geoffrey Garen.

​https://bugs.webkit.org/show_bug.cgi?id=22390

Abstract away JSC
usage in WebCore/xml
  • bindings/js/ScriptString.h: Added. (WebCore::ScriptString::ScriptString): (WebCore::ScriptString::operator JSC::UString): (WebCore::ScriptString::isNull): (WebCore::ScriptString::size): (WebCore::ScriptString::operator=): (WebCore::ScriptString::operator+=):
  • inspector/InspectorController.cpp: (WebCore::XMLHttpRequestResource::XMLHttpRequestResource): (WebCore::InspectorResource::setXMLHttpRequestProperties): (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
  • inspector/InspectorController.h:
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::responseText): (WebCore::XMLHttpRequest::clearResponse): (WebCore::XMLHttpRequest::dropProtection): (WebCore::XMLHttpRequest::didFinishLoading): (WebCore::XMLHttpRequest::didReceiveData):
  • xml/XMLHttpRequest.h: (WebCore::XMLHttpRequest::setLastSendURL):
2:54 PM Changeset in webkit [38679] by weinig@apple.com
  • 3 edits in trunk/WebCore

2008-11-21 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Destroy script decoded data on a zero-delay timer after
decoding. This means we now have no decoded script data
at the end of Membuster.

  • loader/CachedScript.cpp: (WebCore::CachedScript::CachedScript): (WebCore::CachedScript::allClientsRemoved): (WebCore::CachedScript::script): (WebCore::CachedScript::decodedDataDeletionTimerFired):
  • loader/CachedScript.h:
2:49 PM Changeset in webkit [38678] by Simon Fraser
  • 9 edits
    4 adds in trunk

2008-11-21 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler

​https://bugs.webkit.org/show_bug.cgi?id=22159

RenderBox::absoluteClippedOverflowRect() needs to inflate the rect by
maximalOutlineSize(), since a child might have an outline which projects
outside the parent overflowRect().

We also need to ensure that maximalOutlineSize() is updated early in styleDidChange,
so that it is valid for these repaints.

Test: fast/repaint/outline-child-repaint.html

  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::styleDidChange): (WebCore::RenderBox::absoluteClippedOverflowRect):
2:03 PM Changeset in webkit [38677] by jmalonzo@webkit.org
  • 4 edits in trunk/WebCore

2008-11-21 Jan Michael Alonzo <​jmalonzo@webkit.org>

Gtk, Qt, and Wx build fix.

Add LinkHash.cpp in the build scripts.
Add LinkHash.h to Gtk's build script.

LinkHash.cpp/h was introduced in r38661.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCoreSources.bkl:
1:40 PM Changeset in webkit [38676] by weinig@apple.com
  • 3 edits in trunk/WebCore

2008-11-21 Sam Weinig <​sam@webkit.org>

Reviewed by Dan Bernstein.

Third step in ​https://bugs.webkit.org/show_bug.cgi?id=22394
Be more eager in destroying script decoded data

Destroy the decoded data when all clients are removed from a CachedScript.

  • loader/CachedScript.cpp: (WebCore::CachedScript::allClientsRemoved):
  • loader/CachedScript.h: (WebCore::CachedScript::allClientsRemoved):
1:34 PM Changeset in webkit [38675] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-11-21 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.


A little more RegExp refactoring.


Deployed a helper function for reading the next character. Used the "link
vector of jumps" helper in a place I missed before.

  • wrec/WRECGenerator.cpp: (JSC::WREC::Generator::generateLoadCharacter): (JSC::WREC::Generator::generatePatternCharacter): (JSC::WREC::Generator::generateCharacterClass): (JSC::WREC::Generator::generateAssertionEOL): (JSC::WREC::Generator::generateAssertionWordBoundary):
  • wrec/WRECGenerator.h:
1:26 PM Changeset in webkit [38674] by cwzwarich@webkit.org
  • 3 edits in trunk/LayoutTests

2008-11-21 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Sam Weinig.

Add a test for <rdar://problem/4268912>, which was fixed in r13294 (!!).

  • fast/js/resources/string-sort.js:
  • fast/js/string-sort-expected.txt:
1:20 PM Changeset in webkit [38673] by ap@webkit.org
  • 6 edits in trunk/JavaScriptCore

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=22402
Replace abort() with CRASH()

  • wtf/Assertions.h: Added a different method to crash, which should work even is 0xbbadbeef is a valid memory address.
  • runtime/Collector.cpp:
  • wtf/FastMalloc.cpp:
  • wtf/FastMalloc.h:
  • wtf/TCSpinLock.h: Replace abort() with CRASH().
12:09 PM Changeset in webkit [38672] by ap@webkit.org
  • 6 edits in trunk/JavaScriptCore

Reverted fix for bug 22042 (Replace abort() with CRASH()), because it was breaking
FOR_EACH_OPCODE_ID macro somehow, making Safari crash.

12:01 PM Changeset in webkit [38671] by dino@apple.com
  • 9 edits in trunk

2008-11-21 Pierre-Olivier Latour <​pol@apple.com>

WebKit/mac:

Reviewed by Dan Bernstein.

WebKit should be using Device RGB colorspace everywhere for
consistency.

​https://bugs.webkit.org/show_bug.cgi?id=22300

  • WebView/WebHTMLView.mm: (-[WebHTMLView _dragImageForURL:withLabel:]): (-[WebHTMLView _colorAsString:]):

WebCore:

Reviewed by Dan Bernstein.

WebKit should be using Device RGB colorspace everywhere for
consistency.

​https://bugs.webkit.org/show_bug.cgi?id=22300

  • page/mac/AccessibilityObjectWrapper.mm: (CreateCGColorIfDifferent):
  • platform/graphics/mac/ColorMac.h:
  • platform/graphics/mac/ColorMac.mm: (WebCore::nsColor): (+[WebCoreControlTintObserver controlTintDidChange]):
  • rendering/RenderThemeMac.mm: (WebCore::convertNSColorToColor): (WebCore::menuBackgroundColor):

LayoutTests:

Reviewed by Dan Bernstein.

WebKit should be using Device RGB colorspace everywhere for
consistency.

​https://bugs.webkit.org/show_bug.cgi?id=22300

  • platform/mac/fast/text/attributed-substring-from-range-001-expected.txt:
11:32 AM Changeset in webkit [38670] by jchaffraix@webkit.org
  • 4 edits in trunk/WebCore

2008-11-20 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Darin Adler.

Bug 22388: Add JSInterfaceName to the .in files
​https://bugs.webkit.org/show_bug.cgi?id=22388

Add JSInterfaceName that is similar to interfaceName but
for the JS wrappers. JSInterfaceName is always equal to interfaceName
unless explicitly set.

  • dom/make_names.pl:
  • html/HTMLTagNames.in:
  • svg/svgtags.in:
11:31 AM Changeset in webkit [38669] by ggaren@apple.com
  • 7 edits in trunk/JavaScriptCore

2008-11-21 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.


A little more RegExp refactoring.


Moved all assembly from WREC.cpp into WRECGenerator helper functions.
This should help with portability and readability.


Removed ASSERTs after calls to executableCopy(), and changed
executableCopy() to ASSERT instead.

  • assembler/X86Assembler.h: (JSC::X86Assembler::executableCopy):
  • jit/JIT.cpp: (JSC::JIT::privateCompile): (JSC::JIT::privateCompileGetByIdSelf): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdChain): (JSC::JIT::privateCompilePutByIdReplace): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompileCTIMachineTrampolines): (JSC::JIT::privateCompilePatchGetArrayLength):
  • wrec/WREC.cpp: (JSC::WREC::compileRegExp):
  • wrec/WRECGenerator.cpp: (JSC::WREC::Generator::generateEnter): (JSC::WREC::Generator::generateReturnSuccess): (JSC::WREC::Generator::generateSaveIndex): (JSC::WREC::Generator::generateIncrementIndex): (JSC::WREC::Generator::generateLoopIfNotEndOfInput): (JSC::WREC::Generator::generateReturnFailure):
  • wrec/WRECGenerator.h:
  • wrec/WRECParser.h: (JSC::WREC::Parser::ignoreCase): (JSC::WREC::Parser::generator):
11:27 AM Changeset in webkit [38668] by ap@webkit.org
  • 2 edits in trunk/WebKit/win

2008-11-21 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Alexey Proskuryakov.

Debug WebKit crashes on launch because of threading not being initialized early enough.

  • WebKitClassFactory.cpp: (WebKitClassFactory::WebKitClassFactory): Call JSC::InitializeThreading().
11:25 AM Changeset in webkit [38667] by dino@apple.com
  • 1 edit
    4 adds in trunk/LayoutTests

2008-11-21 Pierre-Olivier Latour <​pol@apple.com>

Reviewed by Dan Bernstein.

Add missing reference images for tests added as part of
​https://bugs.webkit.org/show_bug.cgi?id=21261

​https://bugs.webkit.org/show_bug.cgi?id=22391

  • platform/mac/animations/animation-drt-api-expected.checksum: Added.
  • platform/mac/animations/animation-drt-api-expected.png: Added.
  • platform/mac/transitions/transition-drt-api-expected.checksum: Added.
  • platform/mac/transitions/transition-drt-api-expected.png: Added.
11:07 AM Changeset in webkit [38666] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Build fix.

  • wtf/Assertions.h: Use ::abort for C++ code.
10:49 AM Changeset in webkit [38665] by ap@webkit.org
  • 6 edits in trunk/JavaScriptCore

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=22402
Replace abort() with CRASH()

  • wtf/Assertions.h: Added abort() after an attempt to crash for extra safety.
  • runtime/Collector.cpp:
  • wtf/FastMalloc.cpp:
  • wtf/FastMalloc.h:
  • wtf/TCSpinLock.h: Replace abort() with CRASH().
10:44 AM Changeset in webkit [38664] by weinig@apple.com
  • 7 edits
    1 add in trunk/WebCore

2008-11-21 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Second step in ​https://bugs.webkit.org/show_bug.cgi?id=22394
Be more eager in destroying script decoded data

Use a new CachedScriptSourceProvider to keep CachedScripts as
CachedScripts, even down into JSC. This has the added benefit
of showing the CachedScripts as live in the Caches window.

  • GNUmakefile.am:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/CachedScriptSourceProvider.h: Added. (WebCore::CachedScriptSourceProvider::create): (WebCore::CachedScriptSourceProvider::~CachedScriptSourceProvider): (WebCore::CachedScriptSourceProvider::getRange): (WebCore::CachedScriptSourceProvider::data): (WebCore::CachedScriptSourceProvider::length): (WebCore::CachedScriptSourceProvider::CachedScriptSourceProvider): (WebCore::makeSource):
  • dom/ScriptElement.cpp: (WebCore::ScriptElementData::notifyFinished):
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::notifyFinished):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::notifyFinished):
10:22 AM Changeset in webkit [38663] by brettw@chromium.org
  • 3 edits in trunk/WebCore

Fix debug-only build bustage due to a typo in an assert, and add new
files to the Windows build.

10:22 AM Changeset in webkit [38662] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-11-21 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.


Renamed wrec => generator.

  • wrec/WRECFunctors.cpp: (JSC::WREC::GeneratePatternCharacterFunctor::generateAtom): (JSC::WREC::GeneratePatternCharacterFunctor::backtrack): (JSC::WREC::GenerateCharacterClassFunctor::generateAtom): (JSC::WREC::GenerateCharacterClassFunctor::backtrack): (JSC::WREC::GenerateBackreferenceFunctor::generateAtom): (JSC::WREC::GenerateBackreferenceFunctor::backtrack): (JSC::WREC::GenerateParenthesesNonGreedyFunctor::generateAtom):
9:07 AM Changeset in webkit [38661] by brettw@chromium.org
  • 10 edits
    2 adds in trunk/WebCore

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=22131

Factor out visited link hashing and types into a new file, LinkHash.
This also changes the hash type to 64 bits, but does not actually use
the extra bits yet.

8:47 AM Changeset in webkit [38660] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

Reviewed by Alexey Proskuryakov.

No need to use getElementsByTagNameNS() in WML documents. Revert to using getElementByTagName() again.

7:25 AM Changeset in webkit [38659] by Nikolas Zimmermann
  • 3 edits in trunk/WebCore

Reviewed by Alexey Proskuryakov.

Fix some coding style/formatting issues in WMLAElement.

7:20 AM Changeset in webkit [38658] by Nikolas Zimmermann
  • 5 edits
    6 adds in trunk/WebCore

Reviewed by Alexey Proskuryakov.

Fixes: ​https://bugs.webkit.org/show_bug.cgi?id=22399

Implement <anchor> support for WML, add WMLVariables file containing helper functions
for variable support, and a WMLTaskElement base class for WMLPrev/Go/RefreshElement.

6:30 AM Changeset in webkit [38657] by jchaffraix@webkit.org
  • 2 edits in trunk/WebCore

2008-11-21 Julien Chaffraix <​jchaffraix@pleyo.com>

Rubber-stamped by Alexey Proskuryakov.

Build fix when building without WORKERS on non-POSIX, non-WINDOWS
machine.

Spotted by Mario Bensi.

  • platform/text/TextCodecICU.cpp:
1:39 AM Changeset in webkit [38656] by ap@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

Fix ChangeLog typos.

Note: See TracTimeline for information about the timeline view.