⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 24, 2008:

11:23 PM Changeset in webkit [38747] by cwzwarich@webkit.org
  • 4 edits
    3 adds in trunk

2008-11-24 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Geoff Garen.

Bug 13790: Function declarations are not treated as statements (used to affect starcraft2.com)
<​https://bugs.webkit.org/show_bug.cgi?id=13790>

Modify the parser to treat function declarations as statements,
simplifying the grammar in the process. Technically, according to the
grammar in the ECMA spec, function declarations are not statements and
can not be used everywhere that statements can, but it is not worth the
possibility compatibility issues just to stick to the spec in this case.

JavaScriptCore:

  • parser/Grammar.y:
  • parser/Nodes.cpp: (JSC::FuncDeclNode::emitBytecode): Avoid returning ignoredResult() as a result, because it causes a crash in DoWhileNode::emitBytecode().

LayoutTests:

  • fast/js/function-declaration-statement-expected.txt: Added.
  • fast/js/function-declaration-statement.html: Added.
  • fast/js/resources/function-declaration-statement.js: Added.
10:47 PM Changeset in webkit [38746] by darin@chromium.org
  • 4 edits in trunk/WebCore

2008-11-24 Darin Fisher <​darin@chromium.org>

Reviewed by Geoffrey Garen.

​https://bugs.webkit.org/show_bug.cgi?id=22465
Define KURL::copy() and use it in WorkerThread.cpp

  • dom/WorkerThread.cpp: (WebCore::WorkerThread::WorkerThread):
  • platform/KURL.cpp: (WebCore::KURL::copy):
  • platform/KURL.h:
10:10 PM Changeset in webkit [38745] by ggaren@apple.com
  • 5 edits in trunk/JavaScriptCore

2008-11-24 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.


Unroll the regexp matching loop by 1. 10% speedup on simple matching
stress test. No change on SunSpider.


(I decided not to unroll to arbitrary levels because the returns diminsh
quickly.)

  • wrec/WREC.cpp: (JSC::WREC::compileRegExp):
  • wrec/WRECGenerator.cpp: (JSC::WREC::Generator::generateJumpIfEndOfInput): (JSC::WREC::Generator::generateJumpIfNotEndOfInput):
  • wrec/WRECGenerator.h:
  • wrec/WRECParser.h: (JSC::WREC::Parser::error): (JSC::WREC::Parser::parsePattern):
7:43 PM Changeset in webkit [38744] by Nikolas Zimmermann
  • 5 edits in trunk/WebCore

Reviewed by Sam Weinig.

Name enum values in a style guide compatible way.
Allow WMLIntrinsicEvent inclusion, without needing other includes.

7:36 PM Changeset in webkit [38743] by Nikolas Zimmermann
  • 9 edits in trunk/WebCore

Reviewed by Sam Weinig.

Add wmlPageStateForDocument() helper function and use it in some places.

7:16 PM Changeset in webkit [38742] by Antti Koivisto
  • 1 edit in trunk/WebCore/ChangeLog

Fix ChangeLog spelling plus credit weinig.

7:11 PM Changeset in webkit [38741] by Antti Koivisto
  • 15 edits
    2 adds in trunk/WebCore

2008-11-24 Antti Koivisto <Antti Koivisto>

Reviewed by Geoff Garen.

​https://bugs.webkit.org/show_bug.cgi?id=22214
Keep dead resourcs in memory cache in purgeable memory.
<rdar://problem/6333088>


OS X 10.5 has purgeable memory kernel facility that allows marking reserved memory
areas as less important. Under memory pressure system can steal pages that have
been marked purgeable for (hopefully) better uses. This is ideal for caches.


Only resources larger than 16KB will be moved to the purgsable memory.

  • WebCore.base.exp:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/Cache.cpp: (WebCore::Cache::requestResource): (WebCore::Cache::requestUserCSSStyleSheet): (WebCore::Cache::resourceForURL): (WebCore::Cache::pruneDeadResources): (WebCore::Cache::TypeStatistic::addResource): (WebCore::Cache::getStatistics): (WebCore::Cache::dumpStats):
  • loader/Cache.h: (WebCore::Cache::TypeStatistic::TypeStatistic):
  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::allClientsRemoved): (WebCore::CachedCSSStyleSheet::sheetText):
  • loader/CachedCSSStyleSheet.h:
  • loader/CachedImage.cpp: (WebCore::CachedImage::addClient): (WebCore::CachedImage::image): (WebCore::CachedImage::imageSize): (WebCore::CachedImage::imageRect): (WebCore::CachedImage::destroyDecodedData):
  • loader/CachedResource.cpp: (WebCore::CachedResource::addClient): (WebCore::CachedResource::makePurgeable): (WebCore::CachedResource::isPurgeable): (WebCore::CachedResource::wasPurged):
  • loader/CachedResource.h: (WebCore::CachedResource::data):
  • loader/CachedScript.cpp: (WebCore::CachedScript::allClientsRemoved): (WebCore::CachedScript::script): (WebCore::CachedScript::destroyDecodedData):
  • platform/PurgeableBuffer.h: Added. (WebCore::PurgeableBuffer::create): (WebCore::PurgeableBuffer::size): (WebCore::PurgeableBuffer::): (WebCore::PurgeableBuffer::purgePriority): (WebCore::PurgeableBuffer::isPurgeable): (WebCore::PurgeableBuffer::~PurgeableBuffer): (WebCore::PurgeableBuffer::data): (WebCore::PurgeableBuffer::setPurgePriority): (WebCore::PurgeableBuffer::wasPurged): (WebCore::PurgeableBuffer::makePurgeable):
  • platform/SharedBuffer.cpp: (WebCore::SharedBuffer::~SharedBuffer): (WebCore::SharedBuffer::adoptPurgeableBuffer): (WebCore::SharedBuffer::size): (WebCore::SharedBuffer::data): (WebCore::SharedBuffer::append): (WebCore::SharedBuffer::clear): (WebCore::SharedBuffer::releasePurgeableBuffer):
  • platform/SharedBuffer.h: (WebCore::SharedBuffer::hasPurgeableBuffer):
  • platform/cf/SharedBufferCF.cpp:
  • platform/mac/PurgeableBufferMac.cpp: Added. (WebCore::PurgeableBuffer::PurgeableBuffer): (WebCore::PurgeableBuffer::~PurgeableBuffer): (WebCore::PurgeableBuffer::create): (WebCore::PurgeableBuffer::makePurgeable): (WebCore::PurgeableBuffer::wasPurged): (WebCore::PurgeableBuffer::setPurgePriority): (WebCore::PurgeableBuffer::data):
6:20 PM Changeset in webkit [38740] by darin@chromium.org
  • 2 edits in trunk/WebKit/mac

2008-11-24 Darin Fisher <​darin@chromium.org>

Fix bustage.

  • History/WebHistory.mm:
5:53 PM Changeset in webkit [38739] by darin@chromium.org
  • 2 edits in trunk/WebKitTools

2008-11-24 Darin Fisher <​darin@chromium.org>

Fix bustage.

​https://bugs.webkit.org/show_bug.cgi?id=15643

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setSelectTrailingWhitespaceEnabled):
5:45 PM Changeset in webkit [38738] by darin@chromium.org
  • 9 edits in trunk/WebKit

2008-11-24 Darin Fisher <​darin@chromium.org>

Fix bustage.

​http://bugs.webkit.org/show_bug.cgi?id=15643

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::isSelectTrailingWhitespaceEnabled):
  • WebCoreSupport/EditorClientQt.h:
5:33 PM Changeset in webkit [38737] by dino@apple.com
  • 2 edits
    1 add in trunk/WebKitSite

2008-11-24 Dean Jackson <​dino@apple.com>

Document the work-in-progress proposed extensions to
CSS 3 Media Queries.

  • specs/MediaQueriesExtensions.html: Added.
  • specs/index.html:
4:23 PM Changeset in webkit [38736] by Nikolas Zimmermann
  • 29 edits in trunk

Reviewed by George Staikos & Eric Seidel.

Fixes: ​https://bugs.webkit.org/show_bug.cgi?id=22430

Regenerate WML layout test results after implementing WML specific <card> handling:
Only the first <card> element should be visible after loading the document, others
can be shown by using the <go> task element.

4:18 PM Changeset in webkit [38735] by darin@chromium.org
  • 25 edits
    2 adds in trunk

2008-11-24 Glenn Wilson <​gwilson@chromium.org>

Reviewed by Alexey Proskuryakov.

​http://bugs.webkit.org/show_bug.cgi?id=15643

Added support for clients that wish to disable smart insert/delete
and enable the "trailing whitespace selection" work-around.

Tests: editing/selection/doubleclick-whitespace.html

  • editing/Editor.cpp: (WebCore::Editor::selectTrailingWhitespaceEnabled):
  • editing/Editor.h:
  • editing/Selection.cpp: (WebCore::Selection::includeTrailingWhitespace):
  • editing/Selection.h:
  • loader/EmptyClients.h: (WebCore::EmptyEditorClient::selectTrailingWhitespaceEnabled):
  • page/EditorClient.h:
  • page/EventHandler.cpp: (WebCore::EventHandler::selectClosestWordFromMouseEvent):
4:04 PM Changeset in webkit [38734] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

Not reviewed. Forgot to include WMLPageState.h in last commit.

4:02 PM Changeset in webkit [38733] by Nikolas Zimmermann
  • 5 edits
    2 adds in trunk/WebCore

Reviewed by Oliver Hunt & Eric Seidel.
Fixes: ​https://bugs.webkit.org/show_bug.cgi?id=22431

Implement WMLAccessElement. It just propogates two attributes values to WMLPageState.

3:32 PM Changeset in webkit [38732] by Darin Adler
  • 19 edits in trunk

WebCore:

2008-11-24 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

  • loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::updateGlobalHistory): Remove argument.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::updateHistoryForStandardLoad): Don't pass the URL. (WebCore::FrameLoader::updateHistoryForRedirectWithLockedHistory): Ditto.
  • loader/FrameLoaderClient.h: Remove argument.

WebKit/gtk:

2008-11-24 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::updateGlobalHistory): Remove argument.
  • WebCoreSupport/FrameLoaderClientGtk.h: Ditto.

WebKit/mac:

2008-11-24 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

  • WebCoreSupport/WebFrameLoaderClient.h: Remove argument.
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::updateGlobalHistory): Get the URL from the DocumentLoader, just as we do the title and the failure flag.

WebKit/qt:

2008-11-24 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::updateGlobalHistory): Get the URL from the DocumentLoader.
  • WebCoreSupport/FrameLoaderClientQt.h: Remove argument.

WebKit/win:

2008-11-24 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::updateGlobalHistory): Get the URL from the DocumentLoader, just as we do the title and the failure flag.
  • WebCoreSupport/WebFrameLoaderClient.h: Remove argument.

WebKit/wx:

2008-11-24 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::updateGlobalHistory): Remove argument.
  • WebKitSupport/FrameLoaderClientWx.h: Ditto.
3:28 PM Changeset in webkit [38731] by darin@chromium.org
  • 2 edits in trunk/WebKit/qt

2008-11-24 Darin Fisher <​darin@chromium.org>

Fix bustage.

​https://bugs.webkit.org/show_bug.cgi?id=22448

  • Api/qwebframe.cpp: (QWebFrame::evaluateJavaScript):
3:12 PM Changeset in webkit [38730] by darin@chromium.org
  • 3 edits in trunk/WebCore

2008-11-24 Finnur Thorarinsson <​finnur.webkit@gmail.com>

Reviewed by Darin Adler.

Fixes: ​https://bugs.webkit.org/show_bug.cgi?id=22432

Add plumbing for tickmark support for the scrollbars. The painting code
for the scrollbar just needed to call paintTickmarks at the right time
and a default no-op implementation is provided, which the ports will
need to override.

  • platform/ScrollbarThemeComposite.cpp: (WebCore::ScrollbarThemeComposite::paint):
  • platform/ScrollbarThemeComposite.h: (WebCore::ScrollbarThemeComposite::paintTickmarks):
3:07 PM Changeset in webkit [38729] by darin@chromium.org
  • 21 edits
    1 add in trunk/WebCore

2008-11-24 Darin Fisher <​darin@chromium.org>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=22448
Create an abstraction for JSC::SourceCode

  • WebCore.vcproj/WebCore.vcproj:
  • bindings/js/CachedScriptSourceProvider.h:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluate):
  • bindings/js/ScriptController.h:
  • bindings/js/ScriptSourceCode.h: Added. (WebCore::ScriptSourceCode::ScriptSourceCode): (WebCore::ScriptSourceCode::length): (WebCore::ScriptSourceCode::jsSourceCode):
  • bindings/js/WorkerScriptController.cpp: (WebCore::Workevn ScriptController::evaluate):
  • bindings/js/WorkerScriptController.h:
  • dom/ScriptElement.cpp: (WebCore::ScriptElement::insertedIntoDocument): (WebCore::ScriptElement::childrenChanged): (WebCore::ScriptElementData::evaluateScript): (WebCore::ScriptElementData::notifyFinished):
  • dom/ScriptElement.h:
  • dom/WorkerThread.cpp: (WebCore::WorkerThread::workerThread):
  • dom/WorkerThread.h:
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::notifyFinished):
  • dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::endElementNs):
  • dom/XMLTokenizerQt.cpp: (WebCore::XMLTokenizer::parseEndElement):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler): (WebCore::HTMLTokenizer::scriptExecution): (WebCore::HTMLTokenizer::notifyFinished):
  • html/HTMLTokenizer.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::executeScript):
  • loader/FrameLoader.h:
2:48 PM Changeset in webkit [38728] by Darin Adler
  • 15 edits in trunk

WebCore:

2008-11-24 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

  • WebCore.base.exp: Exported new function.
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::urlForHistoryReflectsFailure): Added.
  • loader/DocumentLoader.h: Ditto.

WebKit/mac:

2008-11-24 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Last time around I did this only for the back/forward list and missed the
global history list.

  • History/WebHistory.mm: (-[WebHistory _visitedURL:withTitle:wasFailure:]): Added wasFailure argument. Set the flag on the newly created history item. Also eliminated the use of autorelease on the added-items array.
  • History/WebHistoryInternal.h: Ditto.
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::updateGlobalHistory): Added code to check for failure and pass the argument in to WebHistory. Given that this function gets other data from the DocumentLoader, I think we should get rid of the KURL argument, but that's a separate issue so I don't do it in this patch.

WebKit/win:

2008-11-24 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Last time around I did this only for the back/forward list and missed the
global history list.

  • Interfaces/IWebHistoryItemPrivate.idl: Added setLastVisitWasFailure.
  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::updateGlobalHistory): Added code to check for failure and pass the argument in to WebHistory.
  • WebHistory.cpp: (WebHistory::addItem): Added wasFailure argument. Set the flag on the newly created history item.
  • WebHistory.h: Ditto.
  • WebHistoryItem.cpp: (WebHistoryItem::setLastVisitWasFailure): Added.
  • WebHistoryItem.h: Ditto.
2:46 PM Changeset in webkit [38727] by beidson@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Update radar in an old Changelog entry to be "more correct"

2:33 PM Changeset in webkit [38726] by Chris Fleizach
  • 3 edits in trunk/WebCore

Bug 22461: AccessibilityListBox::doAccessibilityHitTest() signature does not match the base class

2:31 PM Changeset in webkit [38725] by mrowe@apple.com
  • 4 copies
    1 add in releases/Apple/Safari 3.2.1

Tag the Safari 3.2.1 release.

JavaScriptCore, JavaScriptGlue and WebCore are unchanged from Safari 3.2. WebKit is WebKit-x525.27.1.

1:54 PM Changeset in webkit [38724] by Simon Fraser
  • 2 edits in trunk/WebCore

2008-11-24 Simon Fraser <Simon Fraser>

Fix Windows build: selectionRect() -> selectionBounds().

  • page/win/FrameCGWin.cpp: (WebCore::imageFromSelection):
1:42 PM Changeset in webkit [38723] by Simon Fraser
  • 2 edits in trunk/WebKit/win

2008-11-24 Simon Fraser <Simon Fraser>

Fix call to Frame::selectionBounds in Windows build.

  • WebView.cpp: (WebView::selectionRect):
1:40 PM Changeset in webkit [38722] by darin@chromium.org
  • 3 edits
    2 adds in trunk

2008-11-24 Glenn Wilson <​gwilson@chromium.org>

Reviewed by Darin Adler.

​http://bugs.webkit.org/show_bug.cgi?id=18703
"Changing the 'size' property on a text input does not affect its length"

Text fields would not repaint themselves after having their "size"
attributes modified. This fix tells the object to recalculate its
width and repaint itself when its "size" attribute is parsed.

Test: fast/js/text-field-resize.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute):
1:35 PM Changeset in webkit [38721] by Simon Fraser
  • 2 edits in trunk/WebKit/mac

2008-11-24 Simon Fraser <Simon Fraser>

Fix call to Frame::selectionBounds in Tiger build.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
1:25 PM Changeset in webkit [38720] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-11-24 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.


Removed some unnecessary "Generator::" prefixes.

  • wrec/WRECGenerator.cpp: (JSC::WREC::Generator::generateEnter): (JSC::WREC::Generator::generateReturnSuccess): (JSC::WREC::Generator::generateSaveIndex): (JSC::WREC::Generator::generateIncrementIndex): (JSC::WREC::Generator::generateLoopIfNotEndOfInput): (JSC::WREC::Generator::generateReturnFailure):
1:21 PM Changeset in webkit [38719] by Simon Fraser
  • 2 edits in trunk/WebCore

2008-11-24 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler

Followup from changes for ​https://bugs.webkit.org/show_bug.cgi?id=22433

Make RenderView::selectionRect() private to cause compile-time
errors if someone tries to call it.

  • rendering/RenderView.h:
1:20 PM Changeset in webkit [38718] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-11-24 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.


Made a bunch of WREC::Parser functions private, and added an explicit
"reset()" function, so a parser can be reused.

  • wrec/WRECParser.h: (JSC::WREC::Parser::Parser): (JSC::WREC::Parser::generator): (JSC::WREC::Parser::ignoreCase): (JSC::WREC::Parser::multiline): (JSC::WREC::Parser::recordSubpattern): (JSC::WREC::Parser::numSubpatterns): (JSC::WREC::Parser::parsePattern): (JSC::WREC::Parser::parseAlternative): (JSC::WREC::Parser::reset):
12:16 PM Changeset in webkit [38717] by dino@apple.com
  • 5 edits
    1 copy in trunk/WebKitSite/specs/CSSVisualEffects

2008-11-21 Dean Jackson <​dino@apple.com>

CSSAnimation.html:

  • animation-name should accept IDENT not <string>
  • animation-play-state marked as "about to be removed"
  • more description of when an animation is applied, that they snapshot keyframes and values as they start and how they need to be removed to reset.

CSSTransitions.html:

  • list of animatable properties and how to animate property types.
  • specify that values for bezier points outside of [0,1] are invalid.

CSSTransforms.html:

  • split into 2d and 3d specifications
  • transform-origin now matches background-position definition.
  • describe how to animate between lists of transforms

CSSTransforms3D.html

  • new specification which is the 3d parts of transforms
  • perspective must be > 0
  • perspective-origin also matches background-position
  • describe how to animate between lists of transforms, but this time in 3d which is harder.
11:58 AM Changeset in webkit [38716] by Simon Fraser
  • 11 edits in trunk

2008-11-24 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein

Via: ​https://bugs.webkit.org/show_bug.cgi?id=22433

Rename RenderView::selectionRect() to selectionBounds(), to remove
longstanding ambiguity with the base class selectionRect() method.
Do the same on Frame for consistency with RenderView. Assert
that RenderView::selectionRect() is never called.

11:41 AM Changeset in webkit [38715] by christian@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-11-24 Christian Dywan <​christian@twotoasts.de>

Reviewed by Holger Freyther.

​http://bugs.webkit.org/show_bug.cgi?id=17122
[GTK] Bad font default settings

  • webkit/webkitwebsettings.cpp: (_WebKitWebSettingsPrivate::webkit_web_settings_class_init): Use default font size 12 instead of 10
11:29 AM Changeset in webkit [38714] by jchaffraix@webkit.org
  • 7 edits in trunk/WebCore

2008-11-19 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Darin Adler.

Bug 22441: Bridge the gap between the generated ElementFactory and HTMLElementFactory
​https://bugs.webkit.org/show_bug.cgi?id=22441

  • Make HTMLElementFactory::createHTMLElement take a QualifiedName instead of an AtomicString.
  • Updated the elements' constructors and the callers to reflect the previous change.
  • dom/Document.cpp: (WebCore::Document::createElement):
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::createElement):
  • html/HTMLElement.cpp: (WebCore::HTMLElement::cloneNode):
  • html/HTMLElementFactory.cpp: (WebCore::htmlConstructor): (WebCore::headConstructor): (WebCore::bodyConstructor): (WebCore::baseConstructor): (WebCore::linkConstructor): (WebCore::metaConstructor): (WebCore::styleConstructor): (WebCore::titleConstructor): (WebCore::frameConstructor): (WebCore::framesetConstructor): (WebCore::iframeConstructor): (WebCore::formConstructor): (WebCore::buttonConstructor): (WebCore::inputConstructor): (WebCore::isindexConstructor): (WebCore::fieldsetConstructor): (WebCore::keygenConstructor): (WebCore::labelConstructor): (WebCore::legendConstructor): (WebCore::optgroupConstructor): (WebCore::optionConstructor): (WebCore::selectConstructor): (WebCore::textareaConstructor): (WebCore::dlConstructor): (WebCore::ulConstructor): (WebCore::olConstructor): (WebCore::dirConstructor): (WebCore::menuConstructor): (WebCore::liConstructor): (WebCore::blockquoteConstructor): (WebCore::divConstructor): (WebCore::headingConstructor): (WebCore::hrConstructor): (WebCore::paragraphConstructor): (WebCore::preConstructor): (WebCore::basefontConstructor): (WebCore::fontConstructor): (WebCore::modConstructor): (WebCore::anchorConstructor): (WebCore::imageConstructor): (WebCore::mapConstructor): (WebCore::areaConstructor): (WebCore::canvasConstructor): (WebCore::appletConstructor): (WebCore::embedConstructor): (WebCore::objectConstructor): (WebCore::paramConstructor): (WebCore::scriptConstructor): (WebCore::tableConstructor): (WebCore::tableCaptionConstructor): (WebCore::tableColConstructor): (WebCore::tableRowConstructor): (WebCore::tableCellConstructor): (WebCore::tableSectionConstructor): (WebCore::brConstructor): (WebCore::quoteConstructor): (WebCore::marqueeConstructor): (WebCore::audioConstructor): (WebCore::videoConstructor): (WebCore::sourceConstructor): (WebCore::HTMLElementFactory::createHTMLElement):
  • html/HTMLElementFactory.h:
  • html/HTMLParser.cpp: (WebCore::HTMLParser::getNode):
11:21 AM Changeset in webkit [38713] by ap@webkit.org
  • 2 edits in trunk/WebCore

2008-11-24 Brent Fulgham <​bfulgham@gmail.com>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=22444

Correct bad default constructor for Cairo FontPlatformData so that
the m_scaledFont member is initialized. Previously this would be
set to 0xbaadf00d, which would result in infinite loops while
attempting to deal with the font cache.

  • platform/graphics/win/FontPlatformData.h: (WebCore::FontPlatformData::FontPlatformData): Initialize m_scaledFont to 0
10:37 AM Changeset in webkit [38712] by Simon Fraser
  • 1 edit
    1 add in trunk/WebKitTools

2008-11-24 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler

​https://bugs.webkit.org/show_bug.cgi?id=22433

Add script that attempts to detect virtual methods
whose signatures differ only by constness (which can
indicate a programming error).

  • Scripts/detect-mismatched-virtual-const: Added.
10:21 AM Changeset in webkit [38711] by ap@webkit.org
  • 9 edits in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=22455
Add support for Worker.terminate()

Test: fast/workers/worker-terminate.html

  • dom/Worker.idl:
  • dom/Worker.cpp:
  • dom/Worker.h: Added terminate().
  • dom/WorkerMessagingProxy.h: (WebCore::WorkerMessagingProxy::askedToTerminate):
  • dom/WorkerMessagingProxy.cpp: (WebCore::MessageWorkerTask::performTask): Don't dispatch messages if the worker was asked to terminate (this is not mentioned in draft spec, but makes sense anyway). (WebCore::WorkerMessagingProxy::WorkerMessagingProxy): The proxy now remembers if it was asked to terminate in m_askedToTerminate member variable. Also, changed m_unconfirmedMessageCount to only track messages that were posted to worker thread, avoiding a leak if the script could not be loaded. (WebCore::WorkerMessagingProxy::postMessageToWorkerContext): Return early if terminating. (WebCore::WorkerMessagingProxy::workerThreadCreated): Stop the thread if already asked for. (WebCore::WorkerMessagingProxy::workerContextDestroyedInternal): Even if worker context was destroyed, the worker object may still be alive now, so don't delete self in this case. (WebCore::WorkerMessagingProxy::terminate): Stop the thread if it was already created, or remember to stop it when it is created. (WebCore::WorkerMessagingProxy::reportWorkerThreadActivityInternal): Don't track activity if the thread asked to stop anyway. (WebCore::WorkerMessagingProxy::workerThreadHasPendingActivity): Ditto.
  • dom/WorkerThread.cpp:
  • dom/WorkerThread.h: Fixed a race condition in stop().
9:04 AM Changeset in webkit [38710] by zecke@webkit.org
  • 10 edits
    7 adds in trunk

[Gtk+] Implement TestNetscapePlugin for Gtk+ port.

LayoutTests:
2008-11-24 Zan Dobersek <​zandobersek@gmail.com>

Reviewed by Holger Freyther.

Some tests in plugins/ directory now pass.

  • platform/gtk/Skipped:

WebCore/ChangeLog:
2008-11-24 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Mark Rowe.

[Gtk+] Add configure option to enable Web Workers and enable it by default

Add --enable-workers to the buildsystem (used by build-webkit) add
the to be build files to the GNUmakefile.am and change build-webkit
to enable Web Workers by default.

  • GNUmakefile.am:

WebKit/gtk/ChangeLog
2008-11-24 Zan Dobersek <​zandobersek@gmail.com>

Reviewed by Holger Freyther.

​https://bugs.webkit.org/show_bug.cgi?id=22039

Implement a semi-private function for adding a directory to
PluginDatabase's paths.

  • webkit/webkitprivate.h:
  • webkit/webkitwebsettings.cpp: (_WebKitWebSettingsPrivate::webkit_web_settings_add_extra_plugin_directory):

WebKitTools/ChangeLog
2008-11-24 Zan Dobersek <​zandobersek@gmail.com>

Reviewed by Holger Freyther.

​https://bugs.webkit.org/show_bug.cgi?id=22039

[Gtk+] Implement TestNetscapePlugin for Gtk+ port and add it to the
build.

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
  • DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
  • DumpRenderTree/gtk/DumpRenderTree.cpp: (setDefaultsToConsistentStateValuesForTesting):
  • DumpRenderTree/gtk/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h: Added.
  • DumpRenderTree/gtk/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h: Added.
  • DumpRenderTree/gtk/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h: Added.
  • GNUmakefile.am:
6:42 AM Changeset in webkit [38709] by ap@webkit.org
  • 4 edits in trunk/LayoutTests

Reviewed by Mark Rowe.

​https://bugs.webkit.org/show_bug.cgi?id=22428
xmlhttprequest-onProgress-open-should-zero-length.html fails intermittently

  • http/tests/xmlhttprequest/resources/big-response.php: Reduce the size of big response to make the test faster, but practically guarantee that the response will be delivered in many chunks.
  • http/tests/xmlhttprequest/xmlhttprequest-onProgress-open-should-zero-length-expected.txt:
  • http/tests/xmlhttprequest/xmlhttprequest-onProgress-open-should-zero-length.html: Made the test more reliable by comparing final response position with known resource size.
6:40 AM Changeset in webkit [38708] by ap@webkit.org
  • 4 edits
    3 adds in trunk

Reviewed by Mark Rowe.

​https://bugs.webkit.org/show_bug.cgi?id=22439
Won't load stylesheets with filenames less than 2 characters long in xhtml.

Test: http/tests/misc/single-character-pi-stylesheet.xhtml

  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet): Fix up the logic.
5:07 AM Changeset in webkit [38707] by zecke@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

The "WARNING" should not be there, remove it. There was no need to add a test case.

5:01 AM Changeset in webkit [38706] by zecke@webkit.org
  • 2 edits in trunk/LayoutTests

[Gtk+] We are passing all but one worker test. Enable them.

We fail on fast/workers/worker-location.html due some weird
issue with the bidi resolver "skipping" whitespace at the end
of the line.

4:56 AM Changeset in webkit [38705] by zecke@webkit.org
  • 6 edits in trunk

[Gtk+] Add configure option to enable Web Workers and enable it by default

Add --enable-workers to the buildsystem (used by build-webkit) add
the to be build files to the GNUmakefile.am and change build-webkit
to enable Web Workers by default.

3:54 AM Changeset in webkit [38704] by ap@webkit.org
  • 2 edits in trunk/WebCore

Build fix (for Windows Cairo port?)

  • page/DOMWindow.idl: Ese ENABLE_CHANNEL_MESSAGING instead of ENABLE(CHANNEL_MESSAGING), as the ENABLE macro is not available in idls.
3:12 AM Changeset in webkit [38703] by barraclough@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

2008-11-24 Gavin Barraclough <​barraclough@apple.com>

Rubber stamped by Mark Rowe.

Add test cases to ensure the PIC trampolines for prototype and prototype chain
accesses properly check for JSImmediate values, rather than segfaulting.

​https://bugs.webkit.org/show_bug.cgi?id=22451

  • fast/js/pic/cached-prototype-then-immediate-expected.txt: Added.
  • fast/js/pic/cached-prototype-then-immediate.html: Added.
2:59 AM Changeset in webkit [38702] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Let gdb-safari accept the --debug and --release options once more.

Reviewed by Alexey Proskuryakov.

  • Scripts/gdb-safari:
2:28 AM Changeset in webkit [38701] by barraclough@apple.com
  • 1 edit in trunk/JavaScriptCore/ChangeLog

tyop fix in jsc Changelog

2:14 AM Changeset in webkit [38700] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-11-24 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Camron Zwarich.

Implement repatching for get by id chain.
Previously the access is performed in a function stufb, in the reptach form
the trampoline is not called to; instead the hot patch is relinkde to jump
directly to the trampoline, if it fails it will jump to the slow case.

​https://bugs.webkit.org/show_bug.cgi?id=22449
3% progression on deltablue.

  • jit/JIT.cpp: (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdChain):
12:09 AM Changeset in webkit [38699] by Simon Hausmann
  • 11 edits in trunk/JavaScriptCore

2008-11-24 Joerg Bornemann <​joerg.bornemann@trolltech.com>

Reviewed by Simon Hausmann.

​https://bugs.webkit.org/show_bug.cgi?id=20746

Various small compilation fixes to make the Qt port of WebKit
compile on Windows CE.

  • config.h: Don't set _CRT_RAND_S for CE, it's not available.
  • jsc.cpp: Disabled use of debugger includes for CE. It does not have the debugging functions.
  • runtime/DateMath.cpp: Use localtime() on Windows CE.
  • wtf/Assertions.cpp: Compile on Windows CE without debugger.
  • wtf/Assertions.h: Include windows.h before defining ASSERT.
  • wtf/MathExtras.h: Include stdlib.h instead of xmath.h.
  • wtf/Platform.h: Disable ERRNO_H and detect endianess based on the Qt endianess. On Qt for Windows CE the endianess is defined by the vendor specific build spec.
  • wtf/Threading.h: Use the volatile-less atomic functions.
  • wtf/dtoa.cpp: Compile without errno.
  • wtf/win/MainThreadWin.cpp: Don't include windows.h on CE after Assertions.h due to the redefinition of ASSERT.

Nov 23, 2008:

10:04 PM Changeset in webkit [38698] by darin@chromium.org
  • 3 edits in trunk/WebCore

2008-11-22 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=22421
Added ScriptValue to Visual Studio and XCode projects.

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
10:01 PM Changeset in webkit [38697] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-11-22 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Camron Zwarich.

Replace accidentally deleted immediate check from get by id chain trampoline.
​https://bugs.webkit.org/show_bug.cgi?id=22413

  • jit/JIT.cpp: (JSC::JIT::privateCompileGetByIdChain):
2:19 PM Changeset in webkit [38696] by zecke@webkit.org
  • 1 edit
    5 adds in trunk/WebKit/gtk

Add gtk-doc configuration/source for the WebKit/Gtk+ Reference Manual

These files will be used by gtk-doc to generate the documentation. They
contain information how to group the symbols of our API, which objects
to inspect during the generation of the manual and how to display the
manual.

2:18 PM Changeset in webkit [38695] by zecke@webkit.org
  • 9 edits in trunk/WebKit/gtk

Make gtk-doc happy with the existing API documentation

  • Mark the *Private pointers in the struct private
  • Use Returns: where gtk-doc wants us to
  • Fix the parameters to make gtk-doc happy
  • Fix signal references
12:21 AM Changeset in webkit [38694] by jmalonzo@webkit.org
  • 2 edits in trunk/WebKitTools

2008-11-23 Zan Dobersek <​zandobersek@gmail.com>

Reviewed by Holger Freyther. Landed by Jan Alonzo.

Get SVG tests tested on GTK port.

  • Scripts/webkitdirs.pm:
Note: See TracTimeline for information about the timeline view.