Timeline
Nov 28, 2008:
- 8:00 PM Changeset in webkit [38838] by
-
- 14 edits2 adds in trunk
Reviewed by Cameron Zwarich.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=22550
Add <timer> element support. It provides a way to execute a task with a delay.
The user is notified by firing the task associated with the <card>'s ontimer attribute.
Only one timer element is allowed per <card> (fix wrong error message in reportWMLError)
- 6:52 PM Changeset in webkit [38837] by
-
- 21 edits2 adds in trunk
Reviewed by Holger Freyther.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=22549
Add <do> element support. It provides a way to bind a task element to a <template>/<card> element.
Changes numerous of layout tests which contain <do> elements, as they render as buttons now.
- 5:23 PM Changeset in webkit [38836] by
-
- 2 edits in trunk/WebKit/gtk
2008-11-28 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Nikolas Zimmermann.
Simplify the code. There is no reason to have code like
if (true) return false; which is using temporary variables.
- webkit/webkitwebview.cpp:
- 5:23 PM Changeset in webkit [38835] by
-
- 2 edits in trunk/WebKit/gtk
2008-11-28 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Nikolas Zimmermann.
Remove bogus null checks. The WebKitWebView own's a WebCore::Page
which is owning a WebCore::ChromeClient. There is no way that a
WebCore::ChromeClient is still around when the WebKitWebView is gone.
m_webView can only be null when a ChromeClient gets constructed with
a null WebKitWebView which is not allowed.
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::ChromeClient): (WebKit::ChromeClient::windowRect): (WebKit::ChromeClient::setWindowRect): (WebKit::ChromeClient::pageRect): (WebKit::ChromeClient::focus): (WebKit::ChromeClient::unfocus): (WebKit::ChromeClient::show): (WebKit::ChromeClient::setToolbarsVisible): (WebKit::ChromeClient::toolbarsVisible): (WebKit::ChromeClient::setStatusbarVisible): (WebKit::ChromeClient::statusbarVisible): (WebKit::ChromeClient::setScrollbarsVisible): (WebKit::ChromeClient::setMenubarVisible): (WebKit::ChromeClient::menubarVisible): (WebKit::ChromeClient::canTakeFocus): (WebKit::ChromeClient::repaint): (WebKit::ChromeClient::scroll): (WebKit::ChromeClient::platformWindow):
- 4:20 PM Changeset in webkit [38834] by
-
- 13 edits2 adds in trunk
2008-11-28 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed and slightly modified by Holger Freyther.
ChromeClient::createWindow and friends need to be implemented
Code from Gustavo Noronha and Marco Barisione
<marco.barisione@collabora.co.uk> in this change set.
Implemented all the ChromeClient interfaces needed to have new
window creation functioning and exposed to client code. We
implemented a mirror GObject to the WindowFeatures object provided
by WebCore.
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::windowRect): (WebKit::ChromeClient::setWindowRect): (WebKit::ChromeClient::unfocus): (WebKit::ChromeClient::createWindow): (WebKit::ChromeClient::show): (WebKit::ChromeClient::setToolbarsVisible): (WebKit::ChromeClient::toolbarsVisible): (WebKit::ChromeClient::setStatusbarVisible): (WebKit::ChromeClient::statusbarVisible): (WebKit::ChromeClient::setScrollbarsVisible): (WebKit::ChromeClient::scrollbarsVisible): (WebKit::ChromeClient::setMenubarVisible): (WebKit::ChromeClient::menubarVisible): (WebKit::ChromeClient::setResizable):
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebKit::FrameLoaderClient::dispatchShow): (WebKit::FrameLoaderClient::dispatchCreatePage):
- webkit/webkit.h:
- webkit/webkitdefines.h:
- webkit/webkitprivate.h:
- webkit/webkitwebview.cpp:
- webkit/webkitwebview.h:
- webkit/webkitwebwindowfeatures.cpp: Added. (_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_class_init): (_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_init): (_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_finalize): (_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_set_property): (_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_get_property): (_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_new): (_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_new_from_core_features): (_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_equal):
- webkit/webkitwebwindowfeatures.h: Added.
- 1:36 PM Changeset in webkit [38833] by
-
- 6 edits in trunk/WebCore
Reviewed by Sam Weinig.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=22545
Add onenterforward/onenterbackward/ontimer support for <card> elements.
No testing possible at the moment because WMLGoElement is not yet implemented.
After that we can add tests covering the <card> event handling.
- 10:14 AM Changeset in webkit [38832] by
-
- 2 edits in trunk/WebCore
2008-11-27 Laszlo Gombos <Laszlo Gombos>
Reviewed by Tor Arne Vestbø.
Regression seen on QtWebKit - causes a build failure on Win using MinGW
- 7:19 AM Changeset in webkit [38831] by
-
- 2 edits in trunk/JavaScriptCore
2008-11-28 Simon Hausmann <Simon Hausmann>
Reviewed by Tor Arne Vestbø.
Fix compilation on Windows CE
Port away from the use of errno after calling strtol(), instead
detect conversion errors by checking the result and the stop
position.
- 7:19 AM Changeset in webkit [38830] by
-
- 2 edits in trunk/JavaScriptCore
2008-11-28 Joerg Bornemann <joerg.bornemann@trolltech.com>
Reviewed by Simon Hausmann.
Implement lowResUTCTime() on Windows CE using GetSystemTime as _ftime() is not available.
- 7:18 AM Changeset in webkit [38829] by
-
- 3 edits in trunk/WebCore
2008-11-28 Simon Hausmann <Simon Hausmann>
Reviewed by Tor Arne Vestbø.
Fix compilation and linking on Windows CE.
Use WIN_OS instead of WIN and therefore exclude determineModuleVersionFromDescription()
from the Windows'ish build.
Link against the newly required mmtimer.
- 7:18 AM Changeset in webkit [38828] by
-
- 2 edits in trunk/JavaScriptCore
2008-11-28 Simon Hausmann <Simon Hausmann>
Rubber-stamped by Tor Arne Vestbø.
Removed unnecessary inclusion of errno.h, which also fixes compilation on Windows CE.
- 2:23 AM Changeset in webkit [38827] by
-
- 3 edits in trunk/WebCore
2008-11-28 David Levin <levin@chromium.org>
Reviewed by Alexey Proskuryakov.
Made static initializations in XMLHttpRequest.cpp thread-safe in preparation for usage
of XMLHttpRequest by Workers (on threads).
No observable change in behavior, so no test.
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequestStaticData::XMLHttpRequestStaticData): (WebCore::PreflightResultCacheItem::allowsCrossSiteMethod): (WebCore::PreflightResultCacheItem::allowsCrossSiteHeaders): (WebCore::PreflightResultCacheItem::allowsRequest): (WebCore::createXMLHttpRequestStaticData): (WebCore::initializeXMLHttpRequestStaticData): (WebCore::XMLHttpRequest::XMLHttpRequest): (WebCore::XMLHttpRequest::isSafeRequestHeader): (WebCore::XMLHttpRequest::isOnAccessControlResponseHeaderWhitelist):
- xml/XMLHttpRequest.h:
Nov 27, 2008:
- 9:03 PM Changeset in webkit [38826] by
-
- 4 edits in trunk
2008-11-27 Cameron Zwarich <zwarich@apple.com>
Not reviewed.
r38825 made JSFunction::m_body private, but some inspector code in
WebCore sets the field. Add setters for it, and update the inspector
code to use the new getters and setters.
- runtime/JSFunction.h: (JSC::JSFunction::setBody):
WebCore:
- inspector/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::recompileAllJSFunctions):
- 6:24 PM Changeset in webkit [38825] by
-
- 6 edits in trunk/JavaScriptCore
2008-11-27 Sam Weinig <sam@webkit.org>
Reviewed by Cameron Zwarich.
Fix FIXME by adding accessor for JSFunction's m_body property.
- interpreter/Interpreter.cpp: (JSC::Interpreter::cti_op_call_JSFunction): (JSC::Interpreter::cti_vm_dontLazyLinkCall): (JSC::Interpreter::cti_vm_lazyLinkCall):
- profiler/Profiler.cpp: (JSC::createCallIdentifierFromFunctionImp):
- runtime/Arguments.h: (JSC::Arguments::getArgumentsData): (JSC::Arguments::Arguments):
- runtime/FunctionPrototype.cpp: (JSC::functionProtoFuncToString):
- runtime/JSFunction.h: (JSC::JSFunction::JSFunction): (JSC::JSFunction::body):
- 5:43 PM Changeset in webkit [38824] by
-
- 2 edits in trunk/WebKitSite
2008-11-27 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Eric Seidel.
Bug 22468: Coding style: config.h should only be included in implementation files, not in header
https://bugs.webkit.org/show_bug.cgi?id=22468
Clarified the rules about config.h inclusion and added 2 new examples to illustrate it. Also
added an explanation about the implementation files.
- coding/coding-style.html:
- 5:26 PM Changeset in webkit [38823] by
-
- 2 edits in trunk/JavaScriptCore
2008-11-27 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
Remove unused member variables from ProgramNode.
- parser/Nodes.h:
- 3:30 PM Changeset in webkit [38822] by
-
- 2 edits in trunk/JavaScriptCore
2008-11-26 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Alexey Proskuryakov.
Enable mouse panning feaure on Windows Cairo build.
See http://bugs.webkit.org/show_bug.cgi?id=22525
- wtf/Platform.h: Enable mouse panning feaure on Windows Cairo build.
- 10:03 AM Changeset in webkit [38821] by
-
- 2 edits in trunk/WebCore
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=22529
Crashes seen on buildbots due to trying to stop a worker thread twice
- dom/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::workerObjectDestroyed): Don't try to stop the thread if it's already stopping.
- 8:13 AM Changeset in webkit [38820] by
-
- 4 edits in trunk
WebCore:
2008-11-27 Kent Hansen <khansen@trolltech.com>
Reviewed by Simon Hausmann.
Make JavaScript bindings for Qt plugin widgets work again
this was a regression; need to handle non-NPAPI plugins as in 4.4.
WebKit:
2008-11-27 Kent Hansen <khansen@trolltech.com>
Reviewed by Simon Hausmann.
Added auto tests for making JavaScript bindings for Qt plugin widgets
work again.
- 5:07 AM Changeset in webkit [38819] by
-
- 5 edits in trunk
2008-11-27 Alp Toker <alp@nuanti.com>
Change recently introduced C++ comments in Platform.h to C comments to
fix the minidom build with traditional C.
Build GtkLauncher and minidom with the '-ansi' compiler flag to detect
API header breakage at build time.
- 4:21 AM Changeset in webkit [38818] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fixed ChangeLog dates.
- 4:14 AM Changeset in webkit [38817] by
-
- 2 edits in trunk/JavaScriptCore
2008-11-27 Alp Toker <alp@nuanti.com>
Remove C++ comment from JavaScriptCore API headers (introduced r35449).
Fixes build for ANSI C applications using the public API.
- API/WebKitAvailability.h:
