⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 4, 2008:

10:58 PM Changeset in webkit [39020] by barraclough@apple.com
  • 8 edits in trunk/JavaScriptCore

2008-12-04 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Geoff Garen.

Start porting the JIT to use the MacroAssembler.

​https://bugs.webkit.org/show_bug.cgi?id=22671
No change in performance.

  • assembler/MacroAssembler.h: (JSC::MacroAssembler::Jump::operator X86Assembler::JmpSrc): (JSC::MacroAssembler::add32): (JSC::MacroAssembler::and32): (JSC::MacroAssembler::lshift32): (JSC::MacroAssembler::rshift32): (JSC::MacroAssembler::storePtr): (JSC::MacroAssembler::store32): (JSC::MacroAssembler::poke): (JSC::MacroAssembler::move): (JSC::MacroAssembler::compareImm32ForBranchEquality): (JSC::MacroAssembler::jnePtr): (JSC::MacroAssembler::jnset32): (JSC::MacroAssembler::jset32): (JSC::MacroAssembler::jzeroSub32): (JSC::MacroAssembler::joverAdd32): (JSC::MacroAssembler::call):
  • assembler/X86Assembler.h: (JSC::X86Assembler::shll_i8r):
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompile): (JSC::JIT::privateCompileCTIMachineTrampolines):
  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::compileBinaryArithOp):
  • jit/JITInlineMethods.h: (JSC::JIT::emitGetVirtualRegister): (JSC::JIT::emitPutCTIArg): (JSC::JIT::emitPutCTIArgConstant): (JSC::JIT::emitGetCTIArg): (JSC::JIT::emitPutCTIArgFromVirtualRegister): (JSC::JIT::emitPutCTIParam): (JSC::JIT::emitGetCTIParam): (JSC::JIT::emitPutToCallFrameHeader): (JSC::JIT::emitPutImmediateToCallFrameHeader): (JSC::JIT::emitGetFromCallFrameHeader): (JSC::JIT::emitPutVirtualRegister): (JSC::JIT::emitInitRegister): (JSC::JIT::emitNakedCall): (JSC::JIT::restoreArgumentReference): (JSC::JIT::restoreArgumentReferenceForTrampoline): (JSC::JIT::emitCTICall): (JSC::JIT::checkStructure): (JSC::JIT::emitJumpSlowCaseIfNotJSCell): (JSC::JIT::emitJumpSlowCaseIfNotImmNum): (JSC::JIT::emitJumpSlowCaseIfNotImmNums): (JSC::JIT::emitFastArithDeTagImmediate): (JSC::JIT::emitFastArithDeTagImmediateJumpIfZero): (JSC::JIT::emitFastArithReTagImmediate): (JSC::JIT::emitFastArithPotentiallyReTagImmediate): (JSC::JIT::emitFastArithImmToInt): (JSC::JIT::emitFastArithIntToImmOrSlowCase): (JSC::JIT::emitFastArithIntToImmNoCheck): (JSC::JIT::emitTagAsBoolImmediate):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition):
8:38 PM Changeset in webkit [39019] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

8:36 PM Changeset in webkit [39018] by mrowe@apple.com
  • 2 edits in tags/Safari-6528.6/JavaScriptCore

Work around a GCC 4.2 bug that leads to the compiler hanging while attempting to build Interpreter.cpp.

  • Configurations/JavaScriptCore.xcconfig:
8:36 PM Changeset in webkit [39017] by mrowe@apple.com
  • 2 edits in tags/Safari-6528.6/WebKit/mac

Merge r38950.

8:14 PM Changeset in webkit [39016] by mrowe@apple.com
  • 1 copy in tags/Safari-6528.6

New tag.

8:13 PM Changeset in webkit [39015] by Stephanie Lewis
  • 2 edits in trunk/WebKit/mac

2008-12-04 Stephanie Lewis <Stephanie Lewis>

Fix build.

  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCLoadURL):
7:42 PM Changeset in webkit [39014] by kevino@webkit.org
  • 3 edits in trunk/WebCore

Reviewed by Kevin Ollivier.

Add a MIME mapping for the .htm extension to wx and GTK ports.

​https://bugs.webkit.org/show_bug.cgi?id=22668

7:29 PM Changeset in webkit [39013] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Kevin Ollivier.

Implement basic text paste support in wx and add notImplemented stubs to catch other methods.

​https://bugs.webkit.org/show_bug.cgi?id=22667

5:55 PM Changeset in webkit [39012] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx build fix for !USE(WXGC) build config.

5:39 PM Changeset in webkit [39011] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Kevin Ollivier.

Turn off styled controls until we can implement them properly.

​https://bugs.webkit.org/show_bug.cgi?id=22662

4:40 PM Changeset in webkit [39010] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-12-04 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.


Some refactoring for generateGreedyQuantifier.


SunSpider reports no change (possibly a 0.3% speedup).

  • wrec/WRECGenerator.cpp: (JSC::WREC::Generator::generateGreedyQuantifier): Clarified label meanings and unified some logic to simplify things.
  • wrec/WRECParser.h: (JSC::WREC::Parser::parseAlternative): Added a version of parseAlternative that can jump to a Label, instead of a JumpList, upon failure. (Eventually, when we have a true Label class, this will be redundant.) This makes things easier for generateGreedyQuantifier, because it can avoid explicitly linking things.
4:10 PM Changeset in webkit [39009] by andersca@apple.com
  • 6 edits
    2 adds in trunk/WebKit

..:

2008-12-04 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Add HostedNetscapePluginStream.


  • WebKit.xcodeproj/project.pbxproj:

../mac:

2008-12-04 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

More work on streams.


  • Plugins/Hosted/HostedNetscapePluginStream.h: Added. (WebKit::HostedNetscapePluginStream::create):
  • Plugins/Hosted/HostedNetscapePluginStream.mm: Added. (WebKit::HostedNetscapePluginStream::HostedNetscapePluginStream): (WebKit::HostedNetscapePluginStream::startStreamWithResponse): (WebKit::HostedNetscapePluginStream::startStream): (WebKit::HostedNetscapePluginStream::didReceiveData): (WebKit::HostedNetscapePluginStream::didFinishLoading): (WebKit::HostedNetscapePluginStream::didReceiveResponse):
  • Plugins/Hosted/NetscapePluginInstanceProxy.h: (WebKit::NetscapePluginInstanceProxy::pluginView): (WebKit::NetscapePluginInstanceProxy::hostProxy):
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::PluginRequest::PluginRequest): (WebKit::NetscapePluginInstanceProxy::PluginRequest::requestID): (WebKit::NetscapePluginInstanceProxy::PluginRequest::request): (WebKit::NetscapePluginInstanceProxy::PluginRequest::frameName): (WebKit::NetscapePluginInstanceProxy::PluginRequest::didStartFromUserGesture): (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): (WebKit::NetscapePluginInstanceProxy::performRequest): (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript): (WebKit::NetscapePluginInstanceProxy::requestTimerFired): (WebKit::NetscapePluginInstanceProxy::loadRequest):
  • Plugins/Hosted/WebKitPluginHost.defs:
4:03 PM Changeset in webkit [39008] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Kevin Ollivier.

wx implementations for Path API.

​https://bugs.webkit.org/show_bug.cgi?id=22661

2:39 PM Changeset in webkit [39007] by jchaffraix@webkit.org
  • 41 edits in trunk/WebCore

2008-12-04 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Eric Seidel.

Bug 22564: Make HTML elements' constructors take a QualifiedName
​https://bugs.webkit.org/show_bug.cgi?id=22564

Updated the remaining constructors.

  • bindings/js/JSImageConstructor.cpp: (WebCore::constructImage):
  • dom/Document.cpp: (WebCore::Document::getCSSCanvasElement):
  • editing/DeleteButton.cpp: (WebCore::DeleteButton::DeleteButton):
  • html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::HTMLAppletElement):
  • html/HTMLAppletElement.h:
  • html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::HTMLAreaElement):
  • html/HTMLAreaElement.h:
  • html/HTMLBaseFontElement.cpp: (WebCore::HTMLBaseFontElement::HTMLBaseFontElement):
  • html/HTMLBaseFontElement.h:
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::HTMLCanvasElement):
  • html/HTMLCanvasElement.h:
  • html/HTMLElementFactory.cpp: (WebCore::hrConstructor): (WebCore::paragraphConstructor): (WebCore::basefontConstructor): (WebCore::fontConstructor): (WebCore::anchorConstructor): (WebCore::imageConstructor): (WebCore::mapConstructor): (WebCore::areaConstructor): (WebCore::canvasConstructor): (WebCore::appletConstructor): (WebCore::embedConstructor): (WebCore::objectConstructor): (WebCore::paramConstructor): (WebCore::scriptConstructor): (WebCore::tableConstructor): (WebCore::tableCaptionConstructor): (WebCore::tableRowConstructor):
  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::HTMLEmbedElement):
  • html/HTMLEmbedElement.h:
  • html/HTMLFontElement.cpp: (WebCore::HTMLFontElement::HTMLFontElement):
  • html/HTMLFontElement.h:
  • html/HTMLHRElement.cpp: (WebCore::HTMLHRElement::HTMLHRElement):
  • html/HTMLHRElement.h:
  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::HTMLImageElement):
  • html/HTMLImageElement.h:
  • html/HTMLMapElement.cpp: (WebCore::HTMLMapElement::HTMLMapElement):
  • html/HTMLMapElement.h:
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::HTMLObjectElement):
  • html/HTMLObjectElement.h:
  • html/HTMLParagraphElement.cpp: (WebCore::HTMLParagraphElement::HTMLParagraphElement):
  • html/HTMLParagraphElement.h:
  • html/HTMLParamElement.cpp: (WebCore::HTMLParamElement::HTMLParamElement):
  • html/HTMLParamElement.h:
  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleError): (WebCore::HTMLParser::mapCreateErrorCheck): (WebCore::HTMLParser::handleIsindex):
  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::HTMLScriptElement):
  • html/HTMLScriptElement.h:
  • html/HTMLTableCaptionElement.cpp: (WebCore::HTMLTableCaptionElement::HTMLTableCaptionElement):
  • html/HTMLTableCaptionElement.h:
  • html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::HTMLTableElement): (WebCore::HTMLTableElement::createCaption): (WebCore::HTMLTableElement::insertRow):
  • html/HTMLTableElement.h:
  • html/HTMLTableRowElement.cpp: (WebCore::HTMLTableRowElement::HTMLTableRowElement):
  • html/HTMLTableRowElement.h:
  • html/HTMLTableSectionElement.cpp: (WebCore::HTMLTableSectionElement::insertRow):
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createContainingTable): (WebCore::HTMLViewSourceDocument::addLine):
  • loader/ImageDocument.cpp: (WebCore::ImageDocumentElement::ImageDocumentElement):
2:02 PM Changeset in webkit [39006] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

Implement IPropertyBag2::Read.
Fill in dwType for IPropertyBag2::GetPropertyInfo (we always use PROPBAG2_TYPE_DATA).
​https://bugs.webkit.org/show_bug.cgi?id=22659


This fixes <rdar://problem/6419127> REGRESSION: Forms autocomplete is broken for "other forms"


Reviewed by Ada Chan, Alice Liu.

  • COMPropertyBag.h: (::Read): Implemented. (::GetPropertyInfo): Set dwType to PROPBAG2_TYPE_DATA.
1:08 PM Changeset in webkit [39005] by eric@webkit.org
  • 1 edit
    1 add in trunk/WebCore

No review, build fix only.

Add file missing from last commit.

  • bindings/js/ScriptState.h: Added.
1:01 PM Changeset in webkit [39004] by Simon Hausmann
  • 3 edits in trunk/JavaScriptCore

2008-12-04 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Holger Freyther.

Fix crashes in the Qt build on Linux/i386 with non-executable memory
by enabling TCSystemAlloc and the PROT_EXEC flag for mmap.

12:51 PM Changeset in webkit [39003] by eric@webkit.org
  • 16 edits in trunk/WebCore

Reviewed by Geoff Garen.

Implement ScriptState abstraction (initially, a simple typedef)
as means of carrying exception information across bindings boundaries
and in a script engine-independent way.

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMBinding.cpp: (WebCore::scriptStateFromNode):
  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSNodeFilterCondition.h:
  • bindings/js/ScriptState.h: Added.
  • dom/NodeFilter.cpp: (WebCore::NodeFilter::acceptNode):
  • dom/NodeFilter.h: (WebCore::NodeFilter::acceptNode):
  • dom/NodeFilterCondition.cpp: (WebCore::NodeFilterCondition::acceptNode):
  • dom/NodeFilterCondition.h:
  • dom/NodeIterator.cpp: (WebCore::NodeIterator::nextNode): (WebCore::NodeIterator::previousNode):
  • dom/NodeIterator.h: (WebCore::NodeIterator::nextNode): (WebCore::NodeIterator::previousNode):
  • dom/Traversal.cpp: (WebCore::Traversal::acceptNode):
  • dom/Traversal.h:
  • dom/TreeWalker.cpp: (WebCore::TreeWalker::parentNode): (WebCore::TreeWalker::firstChild): (WebCore::TreeWalker::lastChild): (WebCore::TreeWalker::previousSibling): (WebCore::TreeWalker::nextSibling): (WebCore::TreeWalker::previousNode): (WebCore::TreeWalker::nextNode):
  • dom/TreeWalker.h: (WebCore::TreeWalker::parentNode): (WebCore::TreeWalker::firstChild): (WebCore::TreeWalker::lastChild): (WebCore::TreeWalker::previousSibling): (WebCore::TreeWalker::nextSibling): (WebCore::TreeWalker::previousNode): (WebCore::TreeWalker::nextNode):
12:44 PM Changeset in webkit [39002] by pol@apple.com
  • 2 edits in trunk/WebCore

2008-12-04 Pierre-Olivier Latour <​pol@apple.com>

Reviewed by Dan Bernstein.

Fixed pauseTransitionAtTimeOnElementWithId() in DRT asserting when passed invalid property name
and potential similar issue with pauseAnimationAtTimeOnElementWithId().

​https://bugs.webkit.org/show_bug.cgi?id=22641

  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimationPrivate::pauseAnimationAtTime): (WebCore::CompositeAnimationPrivate::pauseTransitionAtTime):
12:42 PM Changeset in webkit [39001] by andersca@apple.com
  • 6 edits in trunk/WebKit/mac

2008-12-04 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Start implementing WKPCLoadURL. Currently this has copied a lot of code from WebNetscapePluginView
but once we have a more complete implementation of NPStreams we can start refactoring things so that the
implementations can share more code.


  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCLoadURL):
  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): (WebKit::NetscapePluginInstanceProxy::loadURL): (WebKit::NetscapePluginInstanceProxy::performRequest): (WebKit::NetscapePluginInstanceProxy::requestTimerFired): (WebKit::NetscapePluginInstanceProxy::loadRequest):
  • Plugins/Hosted/WebKitPluginClient.defs:
  • Plugins/Hosted/WebKitPluginHost.defs:
12:37 PM Changeset in webkit [39000] by brettw@chromium.org
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

Remove unused Completion.h include.

  • html/CanvasRenderingContext2D.cpp: Removed Completion.h include.
12:07 PM Changeset in webkit [38999] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2008-11-13 David Hyatt <​hyatt@apple.com>

Fix a bug in ScrollView's refactoring. An isVisible check should have been isSelfVisible.

Reviewed by Darin Adler

  • platform/ScrollView.cpp: (WebCore::ScrollView::setParentVisible):
11:38 AM Changeset in webkit [38998] by andersca@apple.com
  • 4 edits in trunk/WebKit/mac

2008-12-04 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.


Move requestWithURLCString to WebBaseNetscapePluginView.


  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView requestWithURLCString:]):
  • Plugins/WebNetscapePluginView.mm:
8:38 AM Changeset in webkit [38997] by vestbo@webkit.org
  • 1 edit in trunk/JavaScriptCore/JavaScriptCore.pri

Fix the Qt build

8:21 AM Changeset in webkit [38996] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2008-12-04 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Tor Arne Vestbø.

Enable ENABLE_JIT_OPTIMIZE_CALL, ENABLE_JIT_OPTIMIZE_PROPERTY_ACCESS
and ENABLE_JIT_OPTIMIZE_ARITHMETIC, as suggested by Niko.

6:41 AM Changeset in webkit [38995] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-12-04 Friedemann Kleint <​friedemann.kleint@nokia.com>

Reviewed by Tor Arne Vestbø.

Fix small translation glitch in the Qt file chooser.

6:32 AM Changeset in webkit [38994] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2008-12-04 Kent Hansen <​khansen@trolltech.com>

Reviewed by Simon Hausmann.

Enable the JSC JIT for the Qt build by default for release builds on
linux-g++ and win32-msvc.

5:01 AM Changeset in webkit [38993] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2008-12-04 Tor Arne Vestbø <​tavestbo@trolltech.com>

Rubber-stamped by Simon Hausmann.

Blacklist Silverlight plugin on Qt/Mac until supported

Currently the plugin crashes with a corrupted stack trace, possibly
related to ​https://bugs.webkit.org/show_bug.cgi?id=20635

3:10 AM Changeset in webkit [38992] by barraclough@apple.com
  • 7 edits
    2 copies in trunk/JavaScriptCore

2008-12-04 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Oliver Hunt.

Allow JIT to function without property access repatching and arithmetic optimizations.
Controlled by ENABLE_JIT_OPTIMIZE_PROPERTY_ACCESS and ENABLE_JIT_OPTIMIZE_ARITHMETIC switches.

​https://bugs.webkit.org/show_bug.cgi?id=22643

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
  • jit/JIT.h:
  • jit/JITArithmetic.cpp: Copied from jit/JIT.cpp. (JSC::JIT::compileBinaryArithOp): (JSC::JIT::compileBinaryArithOpSlowCase):
  • jit/JITPropertyAccess.cpp: Copied from jit/JIT.cpp. (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compileGetByIdSlowCase): (JSC::JIT::compilePutByIdHotPath): (JSC::JIT::compilePutByIdSlowCase): (JSC::resizePropertyStorage): (JSC::transitionWillNeedStorageRealloc): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchPutByIdReplace): (JSC::JIT::privateCompilePatchGetArrayLength):
  • wtf/Platform.h:
2:26 AM Changeset in webkit [38991] by vestbo@webkit.org
  • 1 edit in trunk/WebCore/bridge/qt/qt_runtime.cpp

Qt build fix after r38975

12:41 AM Changeset in webkit [38990] by ap@webkit.org
  • 2 edits in trunk/WebCore

2008-12-03 Dmitry Titov <​dimich@chromium.org>

Reviewed by Alexey Proskuryakov.

Fix non-Mac build.

  • page/Chrome.cpp: (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):

Dec 3, 2008:

11:43 PM Changeset in webkit [38989] by ggaren@apple.com
  • 9 edits in trunk

JavaScriptCore:

2008-12-03 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.


Optimized sequences of characters in regular expressions by comparing
two characters at a time.


1-2% speedup on SunSpider, 19-25% speedup on regexp-dna.

  • assembler/MacroAssembler.h: (JSC::MacroAssembler::load32): (JSC::MacroAssembler::jge32): Filled out a few more macro methods.
  • assembler/X86Assembler.h: (JSC::X86Assembler::movl_mr): Added a verion of movl_mr that operates without an offset, to allow the macro assembler to optmize for that case.


  • wrec/WREC.cpp: (JSC::WREC::Generator::compileRegExp): Test the saved value of index instead of the index register when checking for "end of input." The index register doesn't increment by 1 in an orderly fashion, so testing it for == "end of input" is not valid.


Also, jump all the way to "return failure" upon reaching "end of input,"
instead of executing the next alternative. This is more logical, and
it's a slight optimization in the case of an expression with many alternatives.

  • wrec/WRECGenerator.cpp: (JSC::WREC::Generator::generateIncrementIndex): Added support for jumping to a failure label in the case where the index has reached "end of input."

(JSC::WREC::Generator::generatePatternCharacterSequence):
(JSC::WREC::Generator::generatePatternCharacterPair): This is the
optmization. It's basically like generatePatternCharacter, but it runs two
characters at a time.


(JSC::WREC::Generator::generatePatternCharacter): Changed to use isASCII,
since it's clearer than comparing to a magic hex value.


  • wrec/WRECGenerator.h:

LayoutTests:

2008-12-03 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.


Added a test for another input length miscalculation.

  • fast/regex/alternative-length-miscalculation-expected.txt:
  • fast/regex/resources/alternative-length-miscalculation.js:
11:27 PM Changeset in webkit [38988] by ap@webkit.org
  • 1 edit
    3 moves
    14 adds in trunk/LayoutTests

Reviewed by Darin Adler.

Add missing test files (utf-16,32 files) and two php files
for bug 21635 and enabled utf-7 tests (bug 22492). The patch
for bug 21635 was landed in ​http://trac.webkit.org/changeset/38755,
but binary test files (utf-16/32) were omitted in the changeset.

​https://bugs.webkit.org/show_bug.cgi?id=21635
​https://bugs.webkit.org/show_bug.cgi?id=22492

  • http/tests/misc/resources/check-query-param.php: Added.
  • http/tests/misc/resources/echo-query-param.php: Added.
  • http/tests/misc/submit-get-in-utf16be.html: Added.
  • http/tests/misc/submit-get-in-utf16le.html: Added.
  • http/tests/misc/submit-get-in-utf32be.html: Added.
  • http/tests/misc/submit-get-in-utf32le.html: Added.
  • http/tests/misc/submit-get-in-utf7.html: Copied from http/tests/misc/submit-get-in-utf7.html-disabled.
  • http/tests/misc/submit-get-in-utf7.html-disabled: Removed.
  • http/tests/misc/submit-post-in-utf16be.html: Added.
  • http/tests/misc/submit-post-in-utf16le.html: Added.
  • http/tests/misc/submit-post-in-utf32be.html: Added.
  • http/tests/misc/submit-post-in-utf32le.html: Added.
  • http/tests/misc/submit-post-in-utf7.html: Copied from http/tests/misc/submit-post-in-utf7.html-disabled.
  • http/tests/misc/submit-post-in-utf7.html-disabled: Removed.
  • http/tests/misc/url-in-utf16be.html: Added.
  • http/tests/misc/url-in-utf16le.html: Added.
  • http/tests/misc/url-in-utf32be.html: Added.
  • http/tests/misc/url-in-utf32le.html: Added.
  • http/tests/misc/url-in-utf7.html: Copied from http/tests/misc/url-in-utf7.html-disabled.
  • http/tests/misc/url-in-utf7.html-disabled: Removed.
11:21 PM Changeset in webkit [38987] by ap@webkit.org
  • 2 edits in trunk/WebCore

2008-12-03 David Levin <​levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Remove uses of document() in XMLHttpRequest where simple.
​https://bugs.webkit.org/show_bug.cgi?id=22619

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::responseXML): Return NULL in the worker case which is according to spec (and avoids using document()).

(WebCore::XMLHttpRequest::callReadyStateChangeListener):
(WebCore::XMLHttpRequest::initSend):
Use scriptExecutionContext() instead of document().

11:20 PM Changeset in webkit [38986] by ap@webkit.org
  • 7 edits in trunk/WebCore

Reviewed by Alexey Proskuryakov.

Make ScriptExecutionContextTaskWorkerTask::performTask a pure virtual function.
​https://bugs.webkit.org/show_bug.cgi?id=22642

  • dom/Document.cpp: (WebCore::ScriptExecutionContextTaskTimer::ScriptExecutionContextTaskTimer): (WebCore::ScriptExecutionContextTaskTimer::fired): (WebCore::PerformTaskContext::PerformTaskContext): (WebCore::performTask): (WebCore::Document::postTask):
  • dom/Document.h:
  • dom/ScriptExecutionContext.cpp:
  • dom/ScriptExecutionContext.h:
  • dom/WorkerContext.cpp: (WebCore::ScriptExecutionContextTaskWorkerTask::create): (WebCore::ScriptExecutionContextTaskWorkerTask::ScriptExecutionContextTaskWorkerTask): (WebCore::ScriptExecutionContextTaskWorkerTask::performTask): (WebCore::WorkerContext::postTask):
  • dom/WorkerContext.h:
11:19 PM Changeset in webkit [38985] by ap@webkit.org
  • 18 edits in trunk/WebCore

2008-12-03 Dmitry Titov <​dimich@chromium.org>

Reviewed by Alexey Proskuryakov.

Using ActiveDOMObject as base class for DOMTimer.
​https://bugs.webkit.org/show_bug.cgi?id=22620

Using ActiveDOMObject simplifies the code because ActiveDOMObject
is wired for stop/pause/resume on loading/unloading/caching the page etc
so the timer-specific code that does the same can be removed.
In addition, timers can be now paused/resumed 'in place' which
makes it unnecessary to 'serialize' them into special PausedTimeouts
instance, so pause/resumeTimeouts implementation in JSDOMWindowBase can also be removed.
Also, moving TimeoutMap from JSDOMWindowBase to Document matches lifetime
of timeouts and makes it possible to not roundtrip them via PausedTimeouts
every time when JSDOMWindow wrapper is destroyed while the page is in the b/f cache.

Timeouts are now paused with other ActiveDOMObjects:

  • before creating CachedPage in FrameLoader::commitProvisionalLoad()
  • in JavaScriptDebugServer::setJavaScriptPaused
  • during modal UI operations in Chrome::* this is equivalent to previous usage of JSDOMWindowBase::pauseTimeouts()

Timeouts are stopped to prevent future firing from:

  • FrameLoader::clear()
  • FrameLoader::frameDetached() this is equivalent to previous usage of JSDOMWindowBase::clearAllTimeouts()

This is also one of the steps to having timers in Workers. See the plan of
the next steps in the bug above.

  • bindings/js/DOMTimer.cpp: (WebCore::DOMTimer::DOMTimer): (WebCore::DOMTimer::fired): (WebCore::DOMTimer::hasPendingActivity): (WebCore::DOMTimer::contextDestroyed): (WebCore::DOMTimer::stop): (WebCore::DOMTimer::suspend): (WebCore::DOMTimer::resume): (WebCore::DOMTimer::canSuspend): Implemented ActiveDOMObject methods.
  • bindings/js/DOMTimer.h:
  • bindings/js/JSDOMBinding.cpp: ActiveDOMObject can have no JS wrapper (WebCore::markActiveObjectsForContext):
  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::~JSDOMWindowBase): (WebCore::JSDOMWindowBase::clear): (WebCore::JSDOMWindowBase::installTimeout): (WebCore::JSDOMWindowBase::removeTimeout): (WebCore::JSDOMWindowBase::timerFired): (WebCore::JSDOMWindowBase::disconnectFrame):
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/ScriptController.cpp:
  • bindings/js/ScriptController.h:
  • dom/Document.cpp: Document now holds a hash map id->timeout (WebCore::Document::addTimeout): (WebCore::Document::removeTimeout): (WebCore::Document::findTimeout):
  • dom/Document.h:
  • history/CachedPage.cpp: (WebCore::CachedPage::CachedPage): (WebCore::CachedPage::restore): (WebCore::CachedPage::clear):
  • history/CachedPage.h:
  • inspector/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::~JavaScriptDebugServer): (WebCore::JavaScriptDebugServer::setJavaScriptPaused):
  • inspector/JavaScriptDebugServer.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::commitProvisionalLoad): removed clearAllTimeouts since all ActiveDOMObjects will be stopped in FrameLoader::clear(); I don't see how the old comment can be correct - the code in the same method proceeds to invoke 'onunload' and then calls into client which can be external code and can cause any active object created in onunload to fire. We can stop them all before firing onunload but it does not make a lot of sense. I have a test to go with the next patch which verifies that timers set in onunload do not fire.

(WebCore::FrameLoader::open):

  • page/Chrome.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
9:43 PM Changeset in webkit [38984] by barraclough@apple.com
  • 7 edits
    2 copies in trunk/JavaScriptCore

2008-12-03 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Camron Zwarich.

Allow JIT to operate without the call-repatching optimization.
Controlled by ENABLE(JIT_OPTIMIZE_CALL), defaults on, disabling
this leads to significant performance regression.

​https://bugs.webkit.org/show_bug.cgi?id=22639

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • jit/JIT.cpp: (JSC::JIT::privateCompileSlowCases):
  • jit/JIT.h:
  • jit/JITCall.cpp: Copied from jit/JIT.cpp. (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::compileOpCallSetupArgs): (JSC::JIT::compileOpCallEvalSetupArgs): (JSC::JIT::compileOpConstructSetupArgs): (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase): (JSC::unreachable):
  • jit/JITInlineMethods.h: Copied from jit/JIT.cpp. (JSC::JIT::checkStructure): (JSC::JIT::emitFastArithPotentiallyReTagImmediate): (JSC::JIT::emitTagAsBoolImmediate):
  • wtf/Platform.h:
7:39 PM Changeset in webkit [38983] by justin.garcia@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

2008-12-03 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Beth Dakin.

<rdar://problem/6018653> Extra blank line when pasting paragraph in plain text


In SnowLeopard, Mail occasionally adds an empty, unstyled paragraph at the
end of pasted content so that users don't get stuck with non-standard pargraph
spacing. This content threw off our handling of interchange newlines. Any interchange
newline, regardless of it's position in the incoming fragment was considered to be
"at the start" of the fragment, and would result in us inserting in a newline before
inserted content. This patch makes the checks for interchange newlines more strict,
and treats interchange newlines found elsewhere as normal <br>s.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): (WebCore::ReplacementFragment::removeInterchangeNodes):
  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::init): (WebCore::VisiblePosition::canonicalPosition):
  • editing/VisiblePosition.h:

LayoutTests:

2008-12-03 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Beth Dakin.

<rdar://problem/6018653> Extra blank line when pasting paragraph in plain text

  • editing/pasteboard/6018653-expected.txt: Added.
  • editing/pasteboard/6018653.html: Added.
6:11 PM Changeset in webkit [38982] by andersca@apple.com
  • 2 edits in trunk/WebKit

2008-12-03 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.


Move WebPluginRequest to its own file.


  • WebKit.xcodeproj/project.pbxproj:
6:10 PM Changeset in webkit [38981] by andersca@apple.com
  • 2 edits
    2 adds in trunk/WebKit/mac

2008-12-03 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Move WebPluginRequest to its own file.


  • Plugins/WebNetscapePluginView.mm:
  • Plugins/WebPluginRequest.h: Added.
  • Plugins/WebPluginRequest.m: Added. (-[WebPluginRequest initWithRequest:frameName:notifyData:sendNotification:didStartFromUserGesture:]): (-[WebPluginRequest dealloc]): (-[WebPluginRequest request]): (-[WebPluginRequest frameName]): (-[WebPluginRequest isCurrentEventUserGesture]): (-[WebPluginRequest sendNotification]): (-[WebPluginRequest notifyData]):
5:47 PM Changeset in webkit [38980] by eric@webkit.org
  • 4 edits
    4 adds in trunk

Rubber-stamped by David Hyatt.

Bring the WebCore chromium build a couple steps closer to building.

  • WebCore.scons:
5:03 PM Changeset in webkit [38979] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2008-12-03 Anders Carlsson <​andersca@apple.com>

Handle the CA model.

  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView setWindowIfNecessary]):
4:57 PM Changeset in webkit [38978] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx build fix.

4:37 PM Changeset in webkit [38977] by Nikolas Zimmermann
  • 6 edits in trunk/LayoutTests

Reviewed by George Staikos.
Forgot to rerun make-js-test-wrappers, and update some fast/wml results.

4:26 PM Changeset in webkit [38976] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-12-03 Sam Weinig <​sam@webkit.org>

Fix build.

  • assembler/X86Assembler.h: (JSC::X86Assembler::orl_i32r):
4:10 PM Changeset in webkit [38975] by weinig@apple.com
  • 16 edits in trunk/JavaScriptCore

2008-12-03 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Remove shared AssemblerBuffer 1MB buffer and instead give AssemblerBuffer
an 256 byte inline capacity.

1% progression on Sunspider.

  • assembler/AssemblerBuffer.h: (JSC::AssemblerBuffer::AssemblerBuffer): (JSC::AssemblerBuffer::~AssemblerBuffer): (JSC::AssemblerBuffer::grow):
  • assembler/MacroAssembler.h: (JSC::MacroAssembler::MacroAssembler):
  • assembler/X86Assembler.h: (JSC::X86Assembler::X86Assembler):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::Interpreter):
  • interpreter/Interpreter.h:
  • jit/JIT.cpp: (JSC::JIT::JIT):
  • parser/Nodes.cpp: (JSC::RegExpNode::emitBytecode):
  • runtime/RegExp.cpp: (JSC::RegExp::RegExp): (JSC::RegExp::create):
  • runtime/RegExp.h:
  • runtime/RegExpConstructor.cpp: (JSC::constructRegExp):
  • runtime/RegExpPrototype.cpp: (JSC::regExpProtoFuncCompile):
  • runtime/StringPrototype.cpp: (JSC::stringProtoFuncMatch): (JSC::stringProtoFuncSearch):
  • wrec/WREC.cpp: (JSC::WREC::Generator::compileRegExp):
  • wrec/WRECGenerator.h: (JSC::WREC::Generator::Generator):
  • wrec/WRECParser.h: (JSC::WREC::Parser::Parser):
3:48 PM Changeset in webkit [38974] by Nikolas Zimmermann
  • 4 edits
    10 adds in trunk

Reviewed by George Staikos.

Fixes: ​https://bugs.webkit.org/show_bug.cgi?id=22636

Implement WML variable substitution & validation.
Created a framework for scriptable WML layout tests, that are able to test variable substiution & validation.

Tests: wml/variable-reference-invalid-character.html

wml/variable-reference-valid.html

3:26 PM Changeset in webkit [38973] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

Build fix for --gtk and --chromium, no review.

Fix run-javascriptcore-tests to pass --gtk, --qt, --chromium, etc.
through to build-jsc.

  • Scripts/build-jsc:
  • Scripts/webkitdirs.pm:
3:20 PM Changeset in webkit [38972] by Nikolas Zimmermann
  • 10 edits in trunk

Reviewed by Cameron Zwarich.

Further preparations for WML layout tests.

  • Enable variable substitution in Text.cpp - if the parent is a WMLElement derived class.
  • Dump WMLMessageSource messages to the console, just like it's done for JSMessageSource
  • Add helper method in Document.idl, to reset the WML page state to a well-known default state. (will be used in the upcoming LayoutTests/wml testcases)
2:54 PM Changeset in webkit [38971] by ggaren@apple.com
  • 4 edits in trunk/JavaScriptCore

2008-12-03 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt, with help from Gavin Barraclough.


orl_i32r was actually coded as an 8bit OR. So, I renamed orl_i32r to
orl_i8r, changed all orl_i32r clients to use orl_i8r, and then added
a new orl_i32r that actually does a 32bit OR.


(32bit OR is currently unused, but a patch I'm working on uses it.)

  • assembler/MacroAssembler.h: (JSC::MacroAssembler::or32): Updated to choose between 8bit and 32bit OR.
  • assembler/X86Assembler.h: (JSC::X86Assembler::orl_i8r): The old orl_i32r. (JSC::X86Assembler::orl_i32r): The new orl_i32r.


  • jit/JIT.cpp: (JSC::JIT::emitFastArithPotentiallyReTagImmediate): (JSC::JIT::emitTagAsBoolImmediate): Use orl_i8r, since we're ORing 8bit values.
2:38 PM Changeset in webkit [38970] by Antti Koivisto
  • 3 edits in trunk/WebCore

2008-12-03 Antti Koivisto <Antti Koivisto>

Reviewed by Sam Weinig.

Don't leak selectors in case selector list parsing failed.

  • css/CSSGrammar.y:
  • css/CSSParser.cpp: (WebCore::CSSParser::~CSSParser):
2:34 PM Changeset in webkit [38969] by Simon Fraser
  • 1 edit
    4 adds
    4 deletes in trunk/LayoutTests

2008-12-03 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

Clean up and unify transition and animation test cases that destroy
the renderer in the 'ended' event callback, either through setting display:none,
or removing the element.

  • animations/animation-end-event-destroy-renderer-expected.txt: Added.
  • animations/animation-end-event-destroy-renderer.html: Added.
  • animations/transform-animation-event-destroy-element-expected.txt: Removed.
  • animations/transform-animation-event-destroy-element.html: Removed.
  • transitions/transform-transition-event-destroy-element-expected.txt: Removed.
  • transitions/transform-transition-event-destroy-element.html: Removed.
  • transitions/transition-end-event-destroy-renderer-expected.txt: Added.
  • transitions/transition-end-event-destroy-renderer.html: Added.
2:20 PM Changeset in webkit [38968] by cmarrin@apple.com
  • 2 edits in trunk/WebCore

2008-12-03 Chris Marrin <​cmarrin@apple.com>

Reviewed by Dave Hyatt.

Fix ​https://bugs.webkit.org/show_bug.cgi?id=22520

This is a regression (causes a crash of LayoutTests/animations/transform-animation-event-destroy-element.html).
This patch fixes the testcase.

This is another case of animations getting destroyed in the end animation callback and causing dangling
pointers on return. This one involves iterating over the CompositeAnimation, which has been destroyed.
So I now check for a null m_object pointer (which is nullified when the CompositeAnimation is destroyed)
and skip that call.

  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::updateStateMachine):
2:15 PM Changeset in webkit [38967] by andersca@apple.com
  • 1 edit in trunk/WebKit/mac/ChangeLog

Add radar number

2:13 PM Changeset in webkit [38966] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2008-12-03 Anders Carlsson <​andersca@apple.com>

Reviewed by Kevin Decker.


Call NPP_SetWindow for CA plug-ins.


  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]): (-[WebNetscapePluginView restorePortState:]): (-[WebNetscapePluginView isNewWindowEqualToOldWindow]): (-[WebNetscapePluginView updateAndSetWindow]): (-[WebNetscapePluginView setWindowIfNecessary]):
2:01 PM Changeset in webkit [38965] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

Build fix only, no review.

Remove support for build-webkit --svg-experimental.
All of the "experimental" svg features have their own toggles anyway.
I broke --svg-experimental in my last commit (which then broke clean builds)
I can't find any use of --svg-experimental in our source tree, so removing it.

  • Scripts/build-webkit:
1:52 PM Changeset in webkit [38964] by Antti Koivisto
  • 16 edits
    2 adds in trunk/WebCore

2008-12-03 Antti Koivisto <Antti Koivisto>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=22379
Make CSSOM use less memory

Reduce size of the CSSSelector by one more pointer by using an array
instead of a linked list to store them.

  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSGrammar.y:
  • css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::parseSelector): (WebCore::CSSParser::createStyleRule):
  • css/CSSParser.h: (WebCore::CSSParser::reusableSelectorVector):
  • css/CSSSelector.h: (WebCore::CSSSelector::CSSSelector): (WebCore::CSSSelector::~CSSSelector): (WebCore::CSSSelector::isLastInSelectorList): (WebCore::CSSSelector::setLastInSelectorList):
  • css/CSSStyleRule.cpp: (WebCore::CSSStyleRule::CSSStyleRule): (WebCore::CSSStyleRule::~CSSStyleRule): (WebCore::CSSStyleRule::selectorText):
  • css/CSSStyleRule.h: (WebCore::CSSStyleRule::adoptSelectorVector): (WebCore::CSSStyleRule::selectorList):
  • css/CSSStyleSelector.cpp: (WebCore::CSSRuleSet::addRulesFromSheet):
  • dom/Node.cpp: (WebCore::forEachSelector): (WebCore::selectorNeedsNamespaceResolution): (WebCore::Node::querySelector): (WebCore::Node::querySelectorAll):
  • dom/SelectorNodeList.cpp: (WebCore::createSelectorNodeList):
  • dom/SelectorNodeList.h:
1:52 PM Changeset in webkit [38963] by dino@apple.com
  • 3 edits in trunk/WebKitSite/specs/CSSVisualEffects

2008-12-03 Dean Jackson <​dino@apple.com>

CSSTransforms.html +
CSSTransforms3D.html:

  • Use SYNTAX_ERR for exceptions that are parsing errors in CSSMatrix
1:44 PM Changeset in webkit [38962] by ap@webkit.org
  • 4 edits
    3 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=22630
Assertion failure in XMLHttpRequest::contextDestroyed

Test: http/tests/xmlhttprequest/close-window.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::clear): (WebCore::FrameLoader::commitProvisionalLoad): Move stopping active objects to clear(), so that closing a window is also covered.
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::abort): Protect the object in abort(), because internalAbort() deref()'s.
1:36 PM Changeset in webkit [38961] by dino@apple.com
  • 2 edits in trunk/WebKitSite

2008-12-03 Dean Jackson <​dino@apple.com>

Added links to the WebKit and Mozilla bugs for pointer-events.

  • specs/PointerEventsProperty.html:
1:34 PM Changeset in webkit [38960] by eric@webkit.org
  • 5 edits in trunk/WebKitTools

Reviewed by David Hyatt (and Mark Rowe).

Move --coverage support from build-webkit to webkitdirs.pm to share it with build-jsc
Move --coverage support out of run-javascriptcore-tests and into build-jsc

Finally add a buildXCodeProject function to webkitdirs.pm and move --clean support
there from build-webkit (to allow future sharing with other build-* scripts)

Change run-javascriptcore-tests to expect a --jsDriver-args= argument instead of
picking through ARGV with a blacklist of what arguments weren't jsDriver args
this makes run-javascriptcore-tests transparently support all arguments which
webkitdirs.pm gives it support for.

Make run-javascriptcore-tests actually print what commands it's running before running them.

Add --help support to build-jsc and run-javascriptcore-tests!

Make code to support --svg-experimental defaults take up half as many lines.

  • Scripts/build-jsc:
  • Scripts/build-webkit:
  • Scripts/run-javascriptcore-tests:
  • Scripts/webkitdirs.pm:
12:46 PM Changeset in webkit [38959] by dino@apple.com
  • 14 edits in trunk

2008-12-03 Dean Jackson <​dino@apple.com>

Reviewed by Dan Bernstein.

JavaScriptCore:

Helper functions for turn -> degrees.
​https://bugs.webkit.org/show_bug.cgi?id=22497

  • wtf/MathExtras.h: (turn2deg): (deg2turn):

WebCore:

Implement CSS 3 <angle> turn unit and support it
in rotations.
​https://bugs.webkit.org/show_bug.cgi?id=22497

  • css/CSSGrammar.y:
  • css/CSSParser.cpp: (WebCore::CSSParser::validUnit): (WebCore::unitFromString): (WebCore::CSSParser::lex):
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cssText): (WebCore::CSSPrimitiveValue::parserValue):
  • css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::createTransformOperations):
  • css/tokenizer.flex:

LayoutTests:

Tests for CSS 3 <angle> turn unit
​https://bugs.webkit.org/show_bug.cgi?id=22497

  • transforms/2d/transform-2d-expected.txt:
  • transforms/2d/transform-2d.html:
  • transforms/transform-value-types-expected.txt:
  • transforms/transform-value-types.html:
12:32 PM Changeset in webkit [38958] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2008-12-03 Anders Carlsson <​andersca@apple.com>

Fix the release build.

  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WebKit::NetscapePluginHostProxy::deadNameNotificationCallback):
12:00 PM Changeset in webkit [38957] by dino@apple.com
  • 6 edits in trunk/LayoutTests

2008-12-03 Dean Jackson <​dino@apple.com>

Reviewed by Dan Bernstein.

Clean up some tests for private DRT API.
​https://bugs.webkit.org/show_bug.cgi?id=22498

  • platform/win/Skipped:
  • transitions/transition-drt-api-delay-expected.txt:
  • transitions/transition-drt-api-delay.html:
  • transitions/transition-shorthand-delay-expected.txt:
  • transitions/transition-shorthand-delay.html:
11:57 AM Changeset in webkit [38956] by sfalken@apple.com
  • 2 edits in trunk/WebKit

Update strings not to be localized.

Reviewed by Adam Roben.

  • StringsNotToBeLocalized.txt:
11:51 AM Changeset in webkit [38955] by Adam Roben
  • 2 edits in trunk/WebKitTools

Fix a leak in WinLauncher shutdown

Reviewed by Sam Weinig.

  • WinLauncher/WinLauncher.cpp: (_tWinMain): Replaced a delete with a Release. We can't delete the WebView properly since we only have a pointer to one of its interfaces. We also shouldn't be deleting COM objects directly anyway, for a number of reasons.
11:51 AM Changeset in webkit [38954] by Adam Roben
  • 2 edits in trunk/WebKitTools

Fix a crash on exit in WinLauncher

Reviewed by Sam Weinig.

  • WinLauncher/WinLauncher.cpp: (_tWinMain): Call shutDownWebKit before exiting.
11:50 AM Changeset in webkit [38953] by Adam Roben
  • 2 edits in trunk/WebKitTools

Add a Debug_Internal configuration to WinLauncher

This matches our other projects.

Reviewed by Sam Weinig.

  • WinLauncher/WinLauncher.vcproj: Added a Debug_Internal configuration, which is identical to Debug except that it also references debug_internal.vsprops. Also removed some settings that we should be picking up from the .vsprops files.
10:59 AM Changeset in webkit [38952] by krit@webkit.org
  • 19 edits
    5 deletes in trunk

2008-12-03 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

WebCore:

Make use of the gradient code in GraphicsContext and get rid of most of the
platform dependent code.

SVG should use the new Gradient support on GraphicsContext
​https://bugs.webkit.org/show_bug.cgi?id=20543

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/FloatSize.h: (WebCore::FloatSize::shrunkTo):
  • svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::buildGradient):
  • svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient):
  • svg/graphics/SVGPaintServer.h:
  • svg/graphics/SVGPaintServerGradient.cpp: (WebCore::SVGPaintServerGradient::SVGPaintServerGradient): (WebCore::SVGPaintServerGradient::~SVGPaintServerGradient): (WebCore::SVGPaintServerGradient::gradient): (WebCore::SVGPaintServerGradient::setGradient): (WebCore::findTextRootObject): (WebCore::createMaskAndSwapContextForTextGradient): (WebCore::clipToTextMask): (WebCore::SVGPaintServerGradient::setup): (WebCore::SVGPaintServerGradient::renderPath): (WebCore::SVGPaintServerGradient::teardown):
  • svg/graphics/SVGPaintServerGradient.h: (WebCore::SVGPaintServerGradient::setGradientStops): (WebCore::SVGPaintServerGradient::gradientStops):
  • svg/graphics/SVGPaintServerLinearGradient.h:
  • svg/graphics/SVGPaintServerRadialGradient.h:
  • svg/graphics/cairo/SVGPaintServerGradientCairo.cpp: Removed.
  • svg/graphics/cg/SVGPaintServerCg.cpp:
  • svg/graphics/cg/SVGPaintServerGradientCg.cpp: Removed.
  • svg/graphics/qt/SVGPaintServerGradientQt.cpp: Removed.
  • svg/graphics/qt/SVGPaintServerLinearGradientQt.cpp: Removed.
  • svg/graphics/qt/SVGPaintServerRadialGradientQt.cpp: Removed.

LayoutTests:

Updated/Correcte the SVG pixel tests.
We pass two more SVG tests now.

  • platform/mac-leopard/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.checksum:
  • platform/mac-leopard/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.png:
  • platform/mac/svg/batik/text/textEffect3-expected.checksum:
  • platform/mac/svg/batik/text/textEffect3-expected.png:
10:55 AM Changeset in webkit [38951] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-12-03 Sam Weinig <​sam@webkit.org>

Reviewed by Mark Rowe.

Fix formatting.

  • css/CSSSelector.h: (WebCore::CSSSelector::createRareData):
10:54 AM Changeset in webkit [38950] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2008-12-03 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6412234>
Don't crash if we can't launch the plug-in host.

  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::instantiatePlugin):
9:36 AM Changeset in webkit [38949] by Nikolas Zimmermann
  • 3 edits in trunk/WebCore

Reviewed by Adam Roben.

As Adam Roben noticed, synchronize MessageSource enum with Console.js, and add a comment.

9:00 AM Changeset in webkit [38948] by Nikolas Zimmermann
  • 7 edits in trunk/WebCore

Reviewed by Alexey Proskuryakov.

Next steps to make LayoutTests work:
Never access the main frame from WMLRefreshElement/WMLCardElement, but
the current documents frame (WML layout tests will run in an <iframe>)

Prepare WMLErrorHandling for the case that no tokenizer is available anymore
-> report errors through Console::addMessage(), so they get logged in the

expected layout test results.

8:53 AM Changeset in webkit [38947] by vestbo@webkit.org
  • 4 edits in trunk

2008-12-03 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon Hausmann.

Allow passing jsNull and jsUndefined to Qt plugins

Currently limited to functions with QString and QVariant arguments,
and properties of these types. Both jsNull and jsUndefined ends up
as default-constructed QStrings and QVariants, which means you can
check for isEmpty() and isValid() in the native plugin code.

Based on patches by Jade Han <​jade.han@nokia.com>

8:36 AM Changeset in webkit [38946] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-12-03 Trenton Schulz <​trenton.schulz@nokia.com>

Reviewed by Simon Hausmann.

Fix the build with Qt for Mac OS X.

8:28 AM Changeset in webkit [38945] by Nikolas Zimmermann
  • 5 edits in trunk/WebCore

Reviewed by Alexey Proskuryakov.

Fix error handling in WMLSetvarElement. If an invalid variable reference is contained
in the 'name' attribute of <setvar>, a 'WMLErrorInvalidVariab

8:12 AM Changeset in webkit [38944] by Nikolas Zimmermann
  • 5 edits in trunk/WebCore

Reviewed by Alexey Proskuryakov.

Preparations to get WML layout tests going.
Make WMLPageState an OwnPtr to Page, and let Page create it on demand.

7:57 AM Changeset in webkit [38943] by ap@webkit.org
  • 3 edits in trunk/WebCore

Reviewed by Mark Rowe.

​https://bugs.webkit.org/show_bug.cgi?id=22627
fast/workers/worker-terminate.html fails randomly

The problem is that worker termination uses script timeouts, so an InterruptedExecutionError
is raised, and it sometimes reaches the main thread.

  • dom/WorkerMessagingProxy.cpp: (WebCore::WorkerExceptionTask::create): (WebCore::WorkerExceptionTask::WorkerExceptionTask): (WebCore::WorkerExceptionTask::performTask): (WebCore::WorkerMessagingProxy::postWorkerException):
  • dom/WorkerMessagingProxy.h: Ignore exceptions that happen in terminated workers.
7:52 AM Changeset in webkit [38942] by Nikolas Zimmermann
  • 4 edits in trunk/WebCore

Reviewed by Alexey Proskuryakov.
Remove some unncessary includes.

7:25 AM Changeset in webkit [38941] by ap@webkit.org
  • 3 edits in trunk/WebCore

Rubber-stamped by Cameron Zwarich and Adam Roben.

Fix a typo: m_executionForbidded.

  • bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::WorkerScriptController): (WebCore::WorkerScriptController::evaluate): (WebCore::WorkerScriptController::forbidExecution):
  • bindings/js/WorkerScriptController.h:
7:01 AM Changeset in webkit [38940] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

2008-12-03 Dean McNamee <​deanm@chromium.org>

Bug 22623: Uninitialized memory access in cache parsing code
<​https://bugs.webkit.org/show_bug.cgi?id=22623>

Reviewed by David Kilzer.

Initialize m_haveParsedCacheControlHeader and m_haveParsedPragmaHeader.

  • platform/network/ResourceResponseBase.h: (WebCore::ResourceResponseBase::ResourceResponseBase):
6:54 AM Changeset in webkit [38939] by ddkilzer@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Removed unchanged file from ChangeLog entry in r38918.

6:10 AM Changeset in webkit [38938] by Simon Hausmann
  • 2 edits in trunk

2008-12-03 Simon Hausmann <Simon Hausmann>

Reviewed by Tor Arne Vestbø.

Fix the build of WebKit inside Qt by making sure that qmake generators
that do not produce generated sources (i.e. cpp files) are not
included in SOURCES.

2:50 AM Changeset in webkit [38937] by vestbo@webkit.org
  • 1 edit in trunk/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp

2008-12-03 Tor Arne Vestbø <​tavestbo@trolltech.com>

Rubber-stamped by Simon Hausmann.

Fix QWebFrame auto-test by giving it a little more time to load the image

1:56 AM Changeset in webkit [38936] by Antti Koivisto
  • 2 edits in trunk/WebCore

2008-12-03 Antti Koivisto <Antti Koivisto>

Probable build fix.

  • WebCoreSources.bkl:
1:51 AM Changeset in webkit [38935] by Antti Koivisto
  • 3 edits in trunk/WebCore

2008-12-03 Antti Koivisto <Antti Koivisto>

Forgot to commit these.

  • dom/Node.cpp: (WebCore::forEachTagSelector): (WebCore::SelectorNeedsNamespaceResolutionFunctor::operator()): (WebCore::Node::querySelector):
  • dom/SelectorNodeList.cpp: (WebCore::createSelectorNodeList):
1:42 AM Changeset in webkit [38934] by Antti Koivisto
  • 12 edits
    2 deletes in trunk/WebCore

2008-12-03 Antti Koivisto <Antti Koivisto>

Reviewed by Dan Bernstein and Mark Rowe.

​https://bugs.webkit.org/show_bug.cgi?id=22379
Make CSSOM use less memory

Reduce size of the CSSSelector by 3/8 by moving rarely used fields to a rare data
struct. Browsing around with some instrumentation showed that ~0.1% of all selectors
encountered had rare data.


This also eliminates the CSSNthSelector subclass which will make possible to store
CSSSelectors in an array instead of a linked list for futher memory savings.

  • css/CSSGrammar.y:
  • css/CSSNthSelector.cpp: Removed.
  • css/CSSNthSelector.h: Removed.
  • css/CSSParser.cpp: (WebCore::CSSParser::createFloatingSelector):
  • css/CSSParser.h:
  • css/CSSSelector.cpp: (WebCore::CSSSelector::specificity): (WebCore::CSSSelector::operator==): (WebCore::CSSSelector::selectorText): (WebCore::CSSSelector::setTagHistory): (WebCore::CSSSelector::attribute): (WebCore::CSSSelector::setAttribute): (WebCore::CSSSelector::setArgument): (WebCore::CSSSelector::setSimpleSelector): (WebCore::CSSSelector::parseNth): (WebCore::CSSSelector::matchNth): (WebCore::CSSSelector::RareData::parseNth): (WebCore::CSSSelector::RareData::matchNth):
  • css/CSSSelector.h: (WebCore::CSSSelector::CSSSelector): (WebCore::CSSSelector::~CSSSelector): (WebCore::CSSSelector::tagHistory): (WebCore::CSSSelector::hasAttribute): (WebCore::CSSSelector::argument): (WebCore::CSSSelector::simpleSelector): (WebCore::CSSSelector::RareData::RareData): (WebCore::CSSSelector::createRareData): (WebCore::CSSSelector::):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkSelector): (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
12:30 AM Changeset in webkit [38933] by ap@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2008-12-03 Dmitry Titov <​dimich@chromium.org>

Reviewed by Alexey Proskuryakov.

Add test for ​https://bugs.webkit.org/show_bug.cgi?id=22600,
verifying that timeout callback is executed in the right scope.

  • fast/dom/Window/timeout-callback-scope-expected.txt: Added.
  • fast/dom/Window/timeout-callback-scope.html: Added.
12:27 AM Changeset in webkit [38932] by ap@webkit.org
  • 2 edits in trunk/WebCore

2008-12-03 Jian Li <​jianli@chromium.org>

Reviewed by Alexey Proskuryakov.

Remove unneeded included file in WorkerThread.cpp.
​https://bugs.webkit.org/show_bug.cgi?id=22613

  • dom/WorkerThread.cpp: No need to include JSWorkerContext.h.
Note: See TracTimeline for information about the timeline view.