⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 9, 2008:

11:59 PM Changeset in webkit [39165] by ap@webkit.org
  • 2 edits
    1 move in trunk

Rubber-stamped by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=19762
Crash in svg/webarchive/svg-cursor-subresources.svg

  • svg/webarchive/svg-cursor-subresources.svg: Copied from LayoutTests/svg/webarchive/svg-cursor-subresources.svg-disabled.
  • svg/webarchive/svg-cursor-subresources.svg-disabled: Removed. Re-enabling the test.
11:54 PM Changeset in webkit [39164] by ggaren@apple.com
  • 4 edits
    1 copy
    2 adds in trunk

JavaScriptCore:

2008-12-09 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Added WREC support for an assertion followed by a quantifier. Fixed
PCRE to match.

  • wrec/WRECParser.cpp: (JSC::WREC::Parser::parseParentheses): Throw away the quantifier, since it's meaningless. (Firefox does the same.)
  • pcre/pcre_compile.cpp: (compileBranch): ditto.

LayoutTests:

2008-12-09 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Added a test for an assertion followed by a quantifier.

  • fast/regex/quantified-assertions-expected.txt: Added.
  • fast/regex/quantified-assertions.html: Added.
  • fast/regex/resources/quantified-assertions.js: Copied from fast/regex/resources/alternative-length-miscalculation.js.
10:48 PM Changeset in webkit [39163] by abarth@webkit.org
  • 4 edits in trunk/WebCore

2008-12-09 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

Add ScriptController::updateSecurityOrigin to notify the bindings
that a document's securityOrigin has been updated. This is used by
V8 to update its security context.

  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::updateSecurityOrigin):
  • bindings/js/ScriptController.h:
  • dom/Document.cpp: (WebCore::Document::setDomain):
8:59 PM Changeset in webkit [39162] by ggaren@apple.com
  • 12 edits in trunk

JavaScriptCore:

2008-12-09 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Cameron Zwarich.

In preparation for compiling WREC without PCRE:


Further relaxed WREC's parsing to be more web-compatible. Fixed PCRE to
match in cases where it didn't already.


Changed JavaScriptCore to report syntax errors detected by WREC, rather
than falling back on PCRE any time WREC sees an error.


  • pcre/pcre_compile.cpp: (checkEscape): Relaxed parsing of \c and \N escapes to be more web-compatible.


  • runtime/RegExp.cpp: (JSC::RegExp::RegExp): Only fall back on PCRE if WREC has not reported a syntax error.
  • wrec/WREC.cpp: (JSC::WREC::Generator::compileRegExp): Fixed some error reporting to match PCRE.
  • wrec/WRECParser.cpp: Added error messages that match PCRE.

(JSC::WREC::Parser::consumeGreedyQuantifier):
(JSC::WREC::Parser::parseParentheses):
(JSC::WREC::Parser::parseCharacterClass):
(JSC::WREC::Parser::parseNonCharacterEscape): Updated the above functions to
use the new setError API.

(JSC::WREC::Parser::consumeEscape): Relaxed parsing of \c \N \u \x \B
to be more web-compatible.

(JSC::WREC::Parser::parseAlternative): Distinguish between a malformed
quantifier and a quantifier with no prefix, like PCRE does.

(JSC::WREC::Parser::consumeParenthesesType): Updated to use the new setError API.

  • wrec/WRECParser.h: (JSC::WREC::Parser::error): (JSC::WREC::Parser::syntaxError): (JSC::WREC::Parser::parsePattern): (JSC::WREC::Parser::reset): (JSC::WREC::Parser::setError): Store error messages instead of error codes, to provide for exception messages. Use a setter for reporting errors, so errors detected early are not overwritten by errors detected later.

LayoutTests:

2008-12-09 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Cameron Zwarich.

Updated regular expression layout tests to be agnostic between WREC
and PCRE quirks. Also, updated results to match new, more web-compatible
regular expression parsing.

  • fast/js/regexp-charclass-crash-expected.txt:
  • fast/js/regexp-charclass-crash.html:
  • fast/js/regexp-no-extensions-expected.txt:
  • fast/js/resources/regexp-no-extensions.js:
  • fast/regex/test1-expected.txt:
8:22 PM Changeset in webkit [39161] by barraclough@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-12-09 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Oliver Hunt.

Use va_args to access cti function arguments.
​https://bugs.webkit.org/show_bug.cgi?id=22774

This may be a minor regression, but we'll take the hit if so to reduce fragility.

  • interpreter/Interpreter.cpp:
  • interpreter/Interpreter.h:
5:42 PM Changeset in webkit [39160] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Fix gdb-safari on Tiger.

gdb on Tiger does not take the -arch flag, so do not pass it.

Rubber-stamped by Ada Chan.

5:35 PM Changeset in webkit [39159] by pam@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

2008-12-09 David Levin <​levin@chromium.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=22512

Add a test to check for checks when attaching an event to a document created by
'document.implementation.createDocument'.

  • fast/events/create-document-crash-on-attach-event-expected.txt: Added.
  • fast/events/create-document-crash-on-attach-event.html: Added.
  • fast/events/resources/create-document-crash-on-attach-event.js: Added. (doc.onload):
5:28 PM Changeset in webkit [39158] by pam@chromium.org
  • 1 edit
    5 adds in trunk/LayoutTests

2008-12-09 David Levin <​levin@chromium.org>

Reviewed by Eric Seidel.

Add a test to check the event order for context clicks on Windows.

​https://bugs.webkit.org/show_bug.cgi?id=22505

  • platform/win/fast/events/context-click-events-expected.txt: Added.
  • platform/win/fast/events/context-click-events.html: Added.
  • platform/win/fast/events/resources: Added.
  • platform/win/fast/events/resources/TEMPLATE.html: Added.
  • platform/win/fast/events/resources/context-click-events.js: Added. (clickHandler): (traceMouseEvent):
4:39 PM Changeset in webkit [39157] by weinig@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-12-09 Sam Weinig <​sam@webkit.org>

Reviewed twice by Cameron Zwarich.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=22752
Clear SymbolTable after codegen for Function codeblocks that
don't require an activation

This is a ~1.5MB improvement on Membuster-head.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dumpStatistics): Add logging of non-empty symbol tables and total size used by symbol tables.
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::generate): Clear the symbol table here.
4:26 PM Changeset in webkit [39156] by weinig@apple.com
  • 5 edits in trunk/JavaScriptCore

2008-12-09 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Remove unnecessary extra lookup when throwing an exception.
We used to first lookup the target offset using getHandlerForVPC
and then we would lookup the native code stub using
nativeExceptionCodeForHandlerVPC. Instead, we can just pass around
the HandlerInfo.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::handlerForVPC): Return the HandlerInfo.
  • bytecode/CodeBlock.h: Remove nativeExceptionCodeForHandlerVPC.
  • interpreter/Interpreter.cpp: (JSC::Interpreter::throwException): Return a HandlerInfo instead of and Instruction offset. (JSC::Interpreter::privateExecute): Get the offset from HandlerInfo. (JSC::Interpreter::cti_op_throw): Get the native code from the HandleInfo. (JSC::Interpreter::cti_vm_throw): Ditto.
  • interpreter/Interpreter.h:
4:14 PM Changeset in webkit [39155] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2008-12-09 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler.

Fix typecast.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]):
4:13 PM Changeset in webkit [39154] by andersca@apple.com
  • 5 edits in trunk/WebKit/mac

2008-12-09 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler.

Implement software rendering of hosted plug-ins.


  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCInvalidateRect): New MiG function. This is called by the plug-in host when it has drawn something.


  • Plugins/Hosted/WebHostedNetscapePluginView.h:
  • Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView createPlugin]): Create a software renderer.


(-[WebHostedNetscapePluginView destroyPlugin]):
Destroy the software renderer.


(-[WebHostedNetscapePluginView drawRect:]):
Draw using the software renderer.


  • Plugins/Hosted/WebKitPluginClient.defs: Add InvalidateRect.
4:11 PM Changeset in webkit [39153] by eric@webkit.org
  • 4 edits in trunk

No review, build fix only.

Fix a few config issues to let the Chromium Windows WebCore build get further.

  • WebCore.scons:
4:01 PM Changeset in webkit [39152] by brettw@chromium.org
  • 16 edits in trunk

Reviewed by Dave Hyatt.

​https://bugs.webkit.org/show_bug.cgi?id=22177

Add a callback on ChromeClient that the state of form elements on
the page has changed. This is to allow clients implementing session
saving to know when the current state is dirty.

3:51 PM Changeset in webkit [39151] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2008-12-09 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Make sure to pause null events for hosted plug-ins as well.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]):
3:49 PM Changeset in webkit [39150] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2008-12-09 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler.

  • Plugins/Hosted/NetscapePluginHostProxy.h:
  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Unfortunately we can't use a libdispatch source right now, because of <rdar://problem/6393180>.
3:36 PM Changeset in webkit [39149] by weinig@apple.com
  • 6 edits in trunk/WebCore

2008-12-09 Sam Weinig <​sam@webkit.org>

Reviewed by Darin Adler.

Fix intermittent crash in buildbot. The CSSCursorImageValues and
SVGCursorElements held onto raw SVGElement pointers without any
guarantee that the element is still around.

We did not fix the design that resulted in this issue, we just fixed
the pointer lifetimes.

  • css/CSSCursorImageValue.cpp: (WebCore::CSSCursorImageValue::~CSSCursorImageValue): Zero out the back pointers. (WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed): Set up a back pointer. (WebCore::CSSCursorImageValue::removeReferencedElement): Added. Used when the element is destroyed.
  • css/CSSCursorImageValue.h: Added removeReferencedElement.
  • svg/SVGCursorElement.cpp: (WebCore::SVGCursorElement::~SVGCursorElement): Zero out the back pointers. (WebCore::SVGCursorElement::addClient): Set up a back pointer. (WebCore::SVGCursorElement::removeClient): Zero out the back pointer.
  • svg/SVGElement.cpp: (WebCore::SVGElement::SVGElement): Initialize back pointers to zero. (WebCore::SVGElement::~SVGElement): Call both the element and cursor image value to remove the element from their sets.
  • svg/SVGElement.h: (WebCore::SVGElement::setCursorElement): Added. (WebCore::SVGElement::setCursorImageValue): Added.
3:33 PM Changeset in webkit [39148] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

No review, build fix only.

Add ExecutableAllocator files missing from Scons build.

3:11 PM Changeset in webkit [39147] by darin@chromium.org
  • 2 edits in trunk/WebKit/cf

2008-12-09 Dimitri Glazkov <Dimitri Glazkov>

Fix bustage.

  • WebCoreSupport/WebInspectorClientCF.cpp:
2:36 PM Changeset in webkit [39146] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2008-12-09 David Hyatt <​hyatt@apple.com>

Add code that will create custom CSS scrollbars from the <body>, the document element (<html>) and the owning
frame/iframe. If any of them set a custom style, it will be used. The scrollbars do not update dynamically
yet as you switch from page to page (until they are destroyed and recreated).

Reviewed by Adele

  • page/FrameView.cpp: (WebCore::FrameView::createScrollbar):
2:02 PM Changeset in webkit [39145] by timothy@apple.com
  • 3 edits in trunk/WebKit/mac

Implement a few methods needed to keep Dictionary.app working on Leopard.

<rdar://problem/6002160> Internal changes to WebKit in Safari 4
Developer Preview might break Dictionary

Reviewed by Dan Bernstein.

  • WebView/WebFrame.mm: (-[WebFrame convertNSRangeToDOMRange:]): Added. Calls _convertNSRangeToDOMRange. (-[WebFrame convertDOMRangeToNSRange:]): Added. Calls _convertDOMRangeToNSRange.
  • WebView/WebHTMLView.mm: (-[WebHTMLView _bridge]): Added. Returns the WebFrame, which has the methods that Dictionary.app is using.
1:46 PM Changeset in webkit [39144] by darin@chromium.org
  • 7 edits in trunk/WebCore

2008-12-09 Ojan Vafai <​ojan@chromium.org>

Reviewed by Dave Hyatt.

​https://bugs.webkit.org/show_bug.cgi?id=22689
Match Firefox button metrics on Windows.

  • rendering/RenderButton.cpp: (WebCore::RenderButton::addChild): (WebCore::RenderButton::styleDidChange): (WebCore::RenderButton::setupInnerStyle):
  • rendering/RenderButton.h:
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustButtonInnerStyle):
  • rendering/RenderTheme.h:
  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::adjustSliderThumbSize): (WebCore::RenderThemeWin::adjustButtonInnerStyle):
  • rendering/RenderThemeWin.h:
12:43 PM Changeset in webkit [39143] by darin@chromium.org
  • 1 edit
    4 adds in trunk/WebCore

2008-12-09 Darin Fisher <​darin@chromium.org>

Fixes bustages.

​https://bugs.webkit.org/show_bug.cgi?id=22631
Adding missing files from previous commit.

  • bindings/js/ScriptCallFrame.cpp: Added. (WebCore::ScriptCallFrame::ScriptCallFrame): (WebCore::ScriptCallFrame::~ScriptCallFrame): (WebCore::ScriptCallFrame::argumentAt):
  • bindings/js/ScriptCallFrame.h: Added. (WebCore::ScriptCallFrame::functionName): (WebCore::ScriptCallFrame::sourceURL): (WebCore::ScriptCallFrame::lineNumber): (WebCore::ScriptCallFrame::argumentCount):
  • bindings/js/ScriptCallStack.cpp: Added. (WebCore::ScriptCallStack::ScriptCallStack): (WebCore::ScriptCallStack::~ScriptCallStack): (WebCore::ScriptCallStack::at): (WebCore::ScriptCallStack::size): (WebCore::ScriptCallStack::initialize):
  • bindings/js/ScriptCallStack.h: Added. (WebCore::ScriptCallStack::state):
12:25 PM Changeset in webkit [39142] by darin@chromium.org
  • 19 edits in trunk

2008-12-09 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Timothy Hatcher.

​https://bugs.webkit.org/show_bug.cgi?id=22631
Streamline Console.cpp, abstract out the use of JSC::ExecState and
JSC::ArgList by introducing ScriptCallFrame and ScriptCallStack
abstractions.

  • GNUmakefile.am: Added ScriptCallFrame and ScriptCallStack to build
  • WebCore.pro: Added ScriptCallFrame and ScriptCallStack to build
  • WebCore.vcproj/WebCore.vcproj: Added ScriptCallFrame and ScriptCallStack to project
  • WebCore.xcodeproj/project.pbxproj: Added ScriptCallFrame and ScriptCallStack to project
  • bindings/js/JSConsoleCustom.cpp: Remove custom bindings.
  • bindings/js/ScriptCallFrame.cpp: Added. (WebCore::ScriptCallFrame::ScriptCallFrame): (WebCore::ScriptCallFrame::~ScriptCallFrame): (WebCore::ScriptCallFrame::argumentAt):
  • bindings/js/ScriptCallFrame.h: Added. (WebCore::ScriptCallFrame::functionName): (WebCore::ScriptCallFrame::sourceURL): (WebCore::ScriptCallFrame::lineNumber): (WebCore::ScriptCallFrame::argumentCount):
  • bindings/js/ScriptCallStack.cpp: Added. (WebCore::ScriptCallStack::ScriptCallStack): (WebCore::ScriptCallStack::~ScriptCallStack): (WebCore::ScriptCallStack::at): (WebCore::ScriptCallStack::size): (WebCore::ScriptCallStack::initialize):
  • bindings/js/ScriptCallStack.h: Added. (WebCore::ScriptCallStack::ScriptCallStack): (WebCore::ScriptCallStack::~ScriptCallStack): (WebCore::ScriptCallStack::state): (WebCore::ScriptCallStack::at): (WebCore::ScriptCallStack::size): (WebCore::ScriptCallStack::initialize):
  • bindings/js/ScriptString.h: Added missing PlatformString include. (WebCore::ScriptString::ScriptString): Added default constructor. (WebCore::ScriptString::operator==): Added equality operator. (WebCore::ScriptString::operator!=):
  • bindings/js/ScriptValue.cpp: Added isNull and isUndefined. (WebCore::ScriptValue::isNull): (WebCore::ScriptValue::isUndefined):
  • bindings/js/ScriptValue.h: Added isNull and isUndefined
  • bindings/scripts/CodeGeneratorJS.pm: Add handling for CustomArgumentHandling attribute.
  • inspector/InspectorController.cpp: Refactored to use ScriptCallFrame and ScriptCallStack. (WebCore::ConsoleMessage::ConsoleMessage): (WebCore::InspectorController::addMessageToConsole): (WebCore::InspectorController::startGroup): (WebCore::InspectorController::addScriptConsoleMessage): (WebCore::InspectorController::count): (WebCore::InspectorController::startTiming): (WebCore::InspectorController::stopTiming):
  • inspector/InspectorController.h: Refactored to use ScriptCallFrame and ScriptCallStack.
  • inspector/front-end/Console.js: Modified to use argument value itself rather than f.name for stack trace.
  • page/Console.cpp: Refactored to use ScriptCallFrame and ScriptCallStack. (WebCore::getFirstArgumentAsString): (WebCore::Console::addMessage): (WebCore::Console::debug): (WebCore::Console::error): (WebCore::Console::info): (WebCore::Console::log): (WebCore::Console::dir): (WebCore::Console::dirxml): (WebCore::Console::trace): (WebCore::Console::assertCondition): (WebCore::Console::count): (WebCore::Console::profile): (WebCore::Console::profileEnd): (WebCore::Console::time): (WebCore::Console::timeEnd): (WebCore::Console::group): (WebCore::Console::warn):
  • page/Console.h:
  • page/Console.idl: Removed Custom attributes, added CustomArgumentHandling attributes, and tweaked argument defs.
11:19 AM Changeset in webkit [39141] by cwzwarich@webkit.org
  • 5 edits in trunk/JavaScriptCore

2008-12-08 Judit Jasz <​jasy@inf.u-szeged.hu>

Reviewed and tweaked by Cameron Zwarich.

Bug 22352: Annotate opcodes with their length
<​https://bugs.webkit.org/show_bug.cgi?id=22352>

  • bytecode/Opcode.cpp:
  • bytecode/Opcode.h:
  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
10:42 AM Changeset in webkit [39140] by Darin Adler
  • 7 edits in trunk/WebCore

2008-12-09 Darin Adler <Darin Adler>

Try to fix non-Mac builds.

  • GNUmakefile.am: Added NavigatorBase.
  • WebCore.pro: Ditto.
  • WebCore.scons: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCoreSources.bkl: Ditto.

Unrelated tweak sitting in my tree.

  • bindings/objc/DOMAbstractView.mm: Remove pointless override of finalize method.
10:38 AM Changeset in webkit [39139] by Darin Adler
  • 2 edits in trunk/WebCore

2008-12-09 Darin Adler <Darin Adler>

Try to fix Tiger build.

  • platform/network/mac/NetworkStateNotifierMac.cpp: Declare CFRunLoopGetMain.
9:58 AM Changeset in webkit [39138] by ap@webkit.org
  • 17 edits
    7 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=22719
Implement Navigator object in Workers

Test: fast/workers/worker-navigator.html

  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj: Added WorkerNavigator sources.
  • bindings/js/JSWorkerContext.cpp: (WebCore::jsWorkerContextNavigator): Worker.navigator returns a WoerkerNavigator object (it is named just Navigator in the spec, but it is not the same interface that is available on Windows).
  • dom/Worker.cpp: (WebCore::Worker::notifyFinished):
  • dom/WorkerContext.cpp: (WebCore::WorkerContext::WorkerContext): (WebCore::WorkerContext::navigator):
  • dom/WorkerContext.h: (WebCore::WorkerContext::create):
  • dom/WorkerThread.cpp: (WebCore::WorkerThread::create): (WebCore::WorkerThread::WorkerThread): (WebCore::WorkerThread::workerThread):
  • dom/WorkerThread.h: Pass a pre-computed user agent string into worker, because it cannot call a client method directly, and pre-computing is easier than sending a synchronous message to the main thread.
  • page/Navigator.cpp:
  • page/Navigator.h:
  • page/NavigatorBase.cpp: Added.
  • page/NavigatorBase.h: Added. Factor out common (and uncommon, but very similar) functionality into a base class.
  • page/WorkerNavigator.cpp: Added.
  • page/WorkerNavigator.h: Added.
  • page/WorkerNavigator.idl: Added. Per Web Workers and HTML5, implement a small subset of what we currently have in Window.Navigator.
  • platform/network/NetworkStateNotifier.cpp: (WebCore::networkStateNotifier): Make networkStateNotifier() static constructor thread safe. The object is created on the thread it is first called from, while callbacks are registered on the main thread. Calls to onLine() from other threads are safe, because it is just loading a boolean.
  • platform/network/mac/NetworkStateNotifierMac.cpp: (WebCore::NetworkStateNotifier::NetworkStateNotifier): Schedule notifications on main event loop, not the current one.
9:53 AM Changeset in webkit [39137] by pam@chromium.org
  • 2 edits in trunk/LayoutTests

2008-12-09 Pamela Greene <​pam@chromium.org>

Submitted without review.
Corrected results so the test passes.

  • fast/events/special-key-events-in-input-text-expected.txt:
8:42 AM QtWebKitGitInstructions edited by Simon Hausmann
(diff)
8:40 AM Changeset in webkit [39136] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

008-12-09 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Reviewed by Simon Hausmann.

Fix the documentation of the localStorageDatabasePath setters/getters.

6:50 AM Changeset in webkit [39135] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

Rubber-stamped by Alexey Proskuryakov.
Forgot to update Qt/WML build - add some new files to the build.

6:48 AM Changeset in webkit [39134] by ddkilzer@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fixed more ChangeLog dates.

6:42 AM Changeset in webkit [39133] by Nikolas Zimmermann
  • 16 edits
    2 moves
    13 adds in trunk

Reviewed by Alexey Proskuryakov.

Fixes: ​https://bugs.webkit.org/show_bug.cgi?id=22637

Implement the GET method for WMLGoElement, and some test covering it's behaviour.
Update all build systems supporting WML that haven't been updated since a while.

Add WMLPostField stub implementation, needed for implementing POST method.

Tests: wml/go-task-get-method-external-deck-with-href.html

wml/go-task-get-method-external-deck.html
wml/go-task-get-method-same-deck.html

2:13 AM Changeset in webkit [39132] by Simon Hausmann
  • 4 edits in trunk/WebKit/qt

2008-12-08 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Reviewed by Simon Hausmann.

Multiple files support for the file chooser.

  • Api/qwebpage.cpp: (QWebPage::chooseFiles):
  • Api/qwebpage.h:
  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::runOpenPanel):

Dec 8, 2008:

11:48 PM Changeset in webkit [39131] by ap@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2008-12-08 Dmitry Titov <​dimich@chromium.org>

Reviewed by Darin Adler.

Test for ​https://bugs.webkit.org/show_bug.cgi?id=22710
Verifies that active timeout does not cause memory leak.

  • fast/dom/Window/resources/long_timeout.html: Added.
  • fast/dom/Window/timeout-released-on-close-expected.txt: Added.
  • fast/dom/Window/timeout-released-on-close.html: Added.
11:24 PM Changeset in webkit [39130] by ggaren@apple.com
  • 6 edits in trunk/JavaScriptCore

2008-12-08 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.


Implemented more of the relaxed and somewhat weird rules for deciding
how to interpret a non-pattern-character.


  • wrec/Escapes.h: (JSC::WREC::Escape::): (JSC::WREC::Escape::Escape): Eliminated Escape::None because it was unused. If you see an '
    ', it's either a valid escape or an error.
  • wrec/Quantifier.h: (JSC::WREC::Quantifier::Quantifier):
  • wrec/WRECGenerator.cpp: (JSC::WREC::Generator::generateNonGreedyQuantifier): (JSC::WREC::Generator::generateGreedyQuantifier): Renamed "noMaxSpecified" to "Infinity", since that's what it means.
  • wrec/WRECParser.cpp: (JSC::WREC::Parser::consumeGreedyQuantifier): Re-wrote {n,m} parsing rules because they were too strict before. Added support for backtracking in the case where the {n,m} fails to parse as a quantifier, and yet is not a syntax error.

(JSC::WREC::Parser::parseCharacterClass):
(JSC::WREC::Parser::parseNonCharacterEscape): Eliminated Escape::None,
as above.

(JSC::WREC::Parser::consumeEscape): Don't treat ASCII and _ escapes
as syntax errors. See fast/regex/non-pattern-characters.html.


  • wrec/WRECParser.h: (JSC::WREC::Parser::SavedState::SavedState): (JSC::WREC::Parser::SavedState::restore): Added a state backtracker, since parsing {n,m} forms requires backtracking if the form turns out not to be a quantifier.
11:07 PM Changeset in webkit [39129] by ggaren@apple.com
  • 2 edits in trunk/WebKitTools

2008-12-08 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.


Added a shortcut for --jsDriver-args, which I use a lot.

  • Scripts/run-javascriptcore-tests:
10:47 PM Changeset in webkit [39128] by ggaren@apple.com
  • 4 edits in trunk/JavaScriptCore

2008-12-08 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.


Refactored WREC parsing so that only one piece of code needs to know
the relaxed and somewhat weird rules for deciding how to interpret a
non-pattern-character, in preparation for implementing those rules.


Also, implemented the relaxed and somewhat weird rules for '}' and ']'.

  • wrec/WREC.cpp: Reduced the regular expression size limit. Now that WREC handles ']' properly, it compiles fast/js/regexp-charclass-crash.html, which makes it hang at the old limit. (The old limit was based on the misimpression that the same value in PCRE limited the regular expression pattern size; in reality, it limited the expected compiled regular expression size. WREC doesn't have a way to calculate an expected compiled regular expression size, but this should be good enough.)
  • wrec/WRECParser.cpp: (JSC::WREC::parsePatternCharacterSequence): Nixed this function because it contained a second copy of the logic for handling non-pattern-characters, which is about to get a lot more complicated.

(JSC::WREC::PatternCharacterSequence::PatternCharacterSequence):
(JSC::WREC::PatternCharacterSequence::size):
(JSC::WREC::PatternCharacterSequence::append):
(JSC::WREC::PatternCharacterSequence::flush): Helper object for generating
an optimized sequence of pattern characters.

(JSC::WREC::Parser::parseNonCharacterEscape): Renamed to reflect the fact
that the main parseAlternative loop handles character escapes.

(JSC::WREC::Parser::parseAlternative): Moved pattern character sequence
logic from parsePatternCharacterSequence to here, using
PatternCharacterSequence to help with the details.

  • wrec/WRECParser.h: Updated for renames.
10:46 PM Changeset in webkit [39127] by ap@webkit.org
  • 3 edits in trunk/JavaScriptCore

Reviewed by Geoff Garen.

<rdar://problem/6166088> Give JSGlobalContextCreate a behavior that is concurrency aware,
and un-deprecate it

  • API/JSContextRef.cpp: (JSGlobalContextCreate):
  • API/JSContextRef.h: Use a unique context group for the context, unless the application was linked against old JavaScriptCore.
10:29 PM Changeset in webkit [39126] by mitz@apple.com
  • 2 edits in trunk/WebKit/win

Reviewed by Adam Roben.

  • Fix nightly builds
  • Interfaces/IWebViewPrivate.idl: Moved globalHistoryItem() to the end, so that it comes after all methods used by Safari 3.2.1.
10:23 PM Changeset in webkit [39125] by ggaren@apple.com
  • 3 edits in trunk/LayoutTests

2008-12-08 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.


Fixed js-test-pre.js to print a meaningful, complete sentence when
exception tests fail.

  • fast/js/const-expected.txt: Updated test for new results.
  • fast/js/resources/js-test-pre.js: (shouldThrow):
9:34 PM Changeset in webkit [39124] by Stephanie Lewis
  • 2 edits in trunk/WebKitTools

2008-12-08 Stephanie Lewis <Stephanie Lewis>

Fix Tiger build.

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:
9:27 PM Changeset in webkit [39123] by weinig@apple.com
  • 5 edits in trunk/JavaScriptCore

2008-12-08 Sam Weinig <​sam@webkit.org>

Reviewed by Cameron Zwarich.

Fix for <rdar://problem/6428332> Remove the CTI return address table from CodeBlock

Step 1:

Remove use of jitReturnAddressVPCMap when looking for vPC to store Structures
in for cached lookup. Instead, use the offset in the StructureStubInfo that is
already required.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dumpStatistics): Fix extraneous semicolon.
  • interpreter/Interpreter.cpp: (JSC::Interpreter::tryCTICachePutByID): (JSC::Interpreter::tryCTICacheGetByID): (JSC::Interpreter::cti_op_get_by_id_self_fail): (JSC::Interpreter::cti_op_get_by_id_proto_list):
  • jit/JIT.h: (JSC::JIT::compileGetByIdSelf): (JSC::JIT::compileGetByIdProto): (JSC::JIT::compileGetByIdChain): (JSC::JIT::compilePutByIdReplace): (JSC::JIT::compilePutByIdTransition):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchPutByIdReplace): (JSC::JIT::privateCompilePatchGetArrayLength): Remove extra call to getStubInfo. (JSC::JIT::privateCompileGetByIdSelf): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdChain): (JSC::JIT::privateCompilePutByIdReplace):
8:54 PM Changeset in webkit [39122] by barraclough@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-12-08 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Oliver Hunt.

Port the op_j?n?eq_null JIT code generation to use the MacroAssembler,
and clean up slightly at the same time. The 'j' forms currently compare,
then set a register, then compare again, then branch. Branch directly on
the result of the first compare.

Around a 1% progression on deltablue, crypto & early boyer, for about 1/2%
overall on v8-tests.

  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::compileGetByIdSlowCase):
6:10 PM Changeset in webkit [39121] by barraclough@apple.com
  • 5 edits in trunk/JavaScriptCore

2008-12-08 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Geoff Garen.

Expand MacroAssembler to support more operations, required by the JIT.

Generally adds more operations and permutations of operands to the existing
interface. Rename 'jset' to 'jnz' and 'jnset' to 'jz', which seem clearer,
and require that immediate pointer operands (though not pointer addresses to
load and store instructions) are wrapped in a ImmPtr() type, akin to Imm32().

No performance impact.

  • assembler/MacroAssembler.h: (JSC::MacroAssembler::): (JSC::MacroAssembler::ImmPtr::ImmPtr): (JSC::MacroAssembler::add32): (JSC::MacroAssembler::and32): (JSC::MacroAssembler::or32): (JSC::MacroAssembler::sub32): (JSC::MacroAssembler::xor32): (JSC::MacroAssembler::loadPtr): (JSC::MacroAssembler::load32): (JSC::MacroAssembler::storePtr): (JSC::MacroAssembler::store32): (JSC::MacroAssembler::poke): (JSC::MacroAssembler::move): (JSC::MacroAssembler::testImm32): (JSC::MacroAssembler::jae32): (JSC::MacroAssembler::jb32): (JSC::MacroAssembler::jePtr): (JSC::MacroAssembler::je32): (JSC::MacroAssembler::jnePtr): (JSC::MacroAssembler::jne32): (JSC::MacroAssembler::jnzPtr): (JSC::MacroAssembler::jnz32): (JSC::MacroAssembler::jzPtr): (JSC::MacroAssembler::jz32): (JSC::MacroAssembler::joSub32): (JSC::MacroAssembler::jump): (JSC::MacroAssembler::sete32): (JSC::MacroAssembler::setne32): (JSC::MacroAssembler::setnz32): (JSC::MacroAssembler::setz32):
  • assembler/X86Assembler.h: (JSC::X86Assembler::addl_mr): (JSC::X86Assembler::andl_i8r): (JSC::X86Assembler::cmpl_rm): (JSC::X86Assembler::cmpl_mr): (JSC::X86Assembler::cmpl_i8m): (JSC::X86Assembler::subl_mr): (JSC::X86Assembler::testl_i32m): (JSC::X86Assembler::xorl_i32r): (JSC::X86Assembler::movl_rm): (JSC::X86Assembler::modRm_opmsib):
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
  • jit/JITInlineMethods.h: (JSC::JIT::emitGetVirtualRegister): (JSC::JIT::emitPutCTIArgConstant): (JSC::JIT::emitPutCTIParam): (JSC::JIT::emitPutImmediateToCallFrameHeader): (JSC::JIT::emitInitRegister): (JSC::JIT::checkStructure): (JSC::JIT::emitJumpIfJSCell): (JSC::JIT::emitJumpIfNotJSCell): (JSC::JIT::emitJumpSlowCaseIfNotImmNum):
6:01 PM Changeset in webkit [39120] by pol@apple.com
  • 2 edits in trunk/LayoutTests

2008-12-08 Pierre-Olivier Latour <​pol@apple.com>

Reviewed by Dan Bernstein.

Increase timeout in video-paint-test.js so that <video> tests pass on the Tiger pixel bot which is slower
than the Leopard one.

​https://bugs.webkit.org/show_bug.cgi?id=22742

  • media/video-paint-test.js: (init):
5:10 PM Changeset in webkit [39119] by ggaren@apple.com
  • 4 edits
    3 adds in trunk

JavaScriptCore:

2008-12-08 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.


Fixed a bug where WREC would allow a quantifier whose minimum was
greater than its maximum.


  • wrec/Quantifier.h: (JSC::WREC::Quantifier::Quantifier): ASSERT that the quantifier is not backwards.


  • wrec/WRECParser.cpp: (JSC::WREC::Parser::consumeGreedyQuantifier): Verify that the minimum is not greater than the maximum.

LayoutTests:

2008-12-08 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.


Added a test for interesting uses of non-pattern-characters in regular
expressions.

  • fast/regex/non-pattern-characters-expected.txt: Added.
  • fast/regex/non-pattern-characters.html: Added.
  • fast/regex/resources/non-pattern-characters.js: Added.
5:09 PM Changeset in webkit [39118] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

Build fix only, no review.

5:07 PM Changeset in webkit [39117] by andersca@apple.com
  • 12 edits in trunk/WebKit/mac

2008-12-08 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler.

More work towards getting NPN_GetURL working.


  • Plugins/Hosted/HostedNetscapePluginStream.h: Inherit from NetscapePlugInStreamLoaderClient.


(WebKit::HostedNetscapePluginStream::streamID):

  • Plugins/Hosted/HostedNetscapePluginStream.mm: (WebKit::HostedNetscapePluginStream::startStream): Keep track of the resposne URL and the MIME type. Pass the response URL to the plug-in host.


(WebKit::HostedNetscapePluginStream::didFinishLoading):
Disconnect the stream.


(WebKit::HostedNetscapePluginStream::start):
Create a plug-in stream loader and start loading.


(WebKit::HostedNetscapePluginStream::stop):
Cancel the load.


  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCLoadURL): Fix the parameter order.


(WKPCCancelLoadURL):
New function that cancels a load of a stream with a given reason.


  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::destroy): Stop the streams.


(WebKit::NetscapePluginInstanceProxy::pluginStream):
Return a plug-in stream given a stream ID.


(WebKit::NetscapePluginInstanceProxy::disconnectStream):
Remove the stream from the streams map.


(WebKit::NetscapePluginInstanceProxy::loadRequest):
Create a stream and load it.


  • Plugins/Hosted/WebKitPluginClient.defs: Add CancelLoadURL.


  • Plugins/Hosted/WebKitPluginHost.defs: Add responseURL to StartStream.


  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView pluginPackage]): Move this down to the base class from WebNetscapePluginView.


  • Plugins/WebNetscapePluginView.h:
  • Plugins/WebNetscapePluginView.mm:
5:06 PM Changeset in webkit [39116] by weinig@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-12-08 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Patch for ​https://bugs.webkit.org/show_bug.cgi?id=22716
<rdar://problem/6428315>
Add RareData structure to CodeBlock for infrequently used auxiliary data
members.

Reduces memory on Membuster-head by ~.5MB

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump): (JSC::CodeBlock::dumpStatistics): (JSC::CodeBlock::mark): (JSC::CodeBlock::getHandlerForVPC): (JSC::CodeBlock::nativeExceptionCodeForHandlerVPC): (JSC::CodeBlock::shrinkToFit):
  • bytecode/CodeBlock.h: (JSC::CodeBlock::numberOfExceptionHandlers): (JSC::CodeBlock::addExceptionHandler): (JSC::CodeBlock::exceptionHandler): (JSC::CodeBlock::addFunction): (JSC::CodeBlock::function): (JSC::CodeBlock::addUnexpectedConstant): (JSC::CodeBlock::unexpectedConstant): (JSC::CodeBlock::addRegExp): (JSC::CodeBlock::regexp): (JSC::CodeBlock::numberOfImmediateSwitchJumpTables): (JSC::CodeBlock::addImmediateSwitchJumpTable): (JSC::CodeBlock::immediateSwitchJumpTable): (JSC::CodeBlock::numberOfCharacterSwitchJumpTables): (JSC::CodeBlock::addCharacterSwitchJumpTable): (JSC::CodeBlock::characterSwitchJumpTable): (JSC::CodeBlock::numberOfStringSwitchJumpTables): (JSC::CodeBlock::addStringSwitchJumpTable): (JSC::CodeBlock::stringSwitchJumpTable): (JSC::CodeBlock::evalCodeCache): (JSC::CodeBlock::createRareDataIfNecessary):
4:35 PM Changeset in webkit [39115] by pkasting@chromium.org
  • 4 edits in trunk

JavaScriptCore:

2008-11-26 Peter Kasting <​pkasting@google.com>

Reviewed by Anders Carlsson.

​https://bugs.webkit.org/show_bug.cgi?id=16814
Allow ports to disable ActiveX->NPAPI conversion for Media Player.
Improve handling of miscellaneous ActiveX objects.

  • wtf/Platform.h: Add another ENABLE(...).

WebCore:

2008-11-26 Peter Kasting <​pkasting@google.com>

Reviewed by Anders Carlsson.

​https://bugs.webkit.org/show_bug.cgi?id=16814
Allow ports to disable ActiveX->NPAPI conversion for Media Player.
Improve handling of miscellaneous ActiveX objects.

  • rendering/RenderPartObject.cpp: (WebCore::mapClassIdToServiceType): (WebCore::shouldUseChildEmbedOfObject): (WebCore::RenderPartObject::updateWidget):
4:15 PM Changeset in webkit [39114] by Darin Adler
  • 13 edits
    1 copy
    7 adds in trunk

WebCore:

2008-12-03 Darin Adler <Darin Adler>

Reviewed by John Sullivan.

Tests: editing/execCommand/enabling-and-selection-2.html

editing/execCommand/enabling-and-selection.html

  • editing/EditorCommand.cpp: Updated table to use these functions by their new names. (WebCore::enabledVisibleSelection): Renamed this to reflect its new algorithm. An invisible selection with a position that selects no characters doesn't count as a visible selection. (WebCore::enabledVisibleSelectionAndMark): Ditto.

WebKitTools:

2008-12-08 Darin Adler <Darin Adler>

Reviewed by John Sullivan.

  • DumpRenderTree/LayoutTestController.cpp: (isCommandEnabledCallback): Added. (LayoutTestController::staticFunctions): Added "isCommandEnabled".
  • DumpRenderTree/LayoutTestController.h: Ditto.
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::isCommandEnabled): Ditto.
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (-[CommandValidationTarget initWithAction:]): Added. Used to get the command validation system to tell us if a comment is enabled. (-[CommandValidationTarget action]): Ditto. (-[CommandValidationTarget tag]): Ditto. (LayoutTestController::isCommandEnabled): Ditto.
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::isCommandEnabled): Ditto.

LayoutTests:

2008-12-08 Darin Adler <Darin Adler>

Reviewed by John Sullivan.

  • editing/execCommand/enabling-and-selection-2-expected.txt: Added.
  • editing/execCommand/enabling-and-selection-2.html: Added.
  • editing/execCommand/enabling-and-selection-expected.txt: Added.
  • editing/execCommand/enabling-and-selection.html: Added.
  • editing/execCommand/resources: Added.
  • editing/execCommand/resources/TEMPLATE.html: Copied from LayoutTests/fast/js/resources/TEMPLATE.html.
  • editing/execCommand/resources/enabling-and-selection-2.js: Added.
  • editing/execCommand/resources/enabling-and-selection.js: Added.
  • fast/canvas/canvas-setTransform.html: Let make-js-test-wrappers update this.
  • fast/canvas/canvas-strokeRect.html: Ditto.
  • platform/qt/Skipped: Added enabling-and-selection-2 to the skipped list.
  • platform/win/Skipped: Ditto.
4:14 PM Changeset in webkit [39113] by weinig@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-12-08 Sam Weinig <​sam@webkit.org>

Reviewed by Mark Rowe.

Add dumping of CodeBlock member structure usage.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dumpStatistics):
  • bytecode/EvalCodeCache.h: (JSC::EvalCodeCache::isEmpty):
4:11 PM Changeset in webkit [39112] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

Remove duplicate entries from WebCore project.

Reviewed by Eric Seidel.

Bug 22555: Sort "children" sections in Xcode project files.
<​https://bugs.webkit.org/show_bug.cgi?id=22555>

Recipe for removing duplicates:
$ ./WebKitTools/Scripts/sort-Xcode-project-file project.pbxproj
$ uniq < project.pbxproj | diff -u project.pbxproj - | patch -p0 project.pbxproj

  • WebCore.xcodeproj/project.pbxproj: Removed duplicates.
4:06 PM Changeset in webkit [39111] by jchaffraix@webkit.org
  • 10 edits in trunk/WebCore

2008-12-08 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Darin Adler.

Bug 22665: Remove setCreatedByParser(bool) from the few elements that use it
​https://bugs.webkit.org/show_bug.cgi?id=22665

Remove setCreatedByParser from the script elements (HTML and SVG).

  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::eventuallyMarkAsParserCreated): Removed call to setCreatedByParser for the 2 elements.
  • dom/make_names.pl: Modified to call the constructor with the createByParser parameter if 'constructorNeedsCreatedByParser' is set.


  • html/HTMLElementFactory.cpp: (WebCore::scriptConstructor):
  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::HTMLScriptElement):
  • html/HTMLScriptElement.h:
  • html/HTMLTagNames.in: Added constructorNeedsCreatedByParser to script.
  • svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::SVGScriptElement):
  • svg/SVGScriptElement.h:
  • svg/svgtags.in: Added constructorNeedsCreatedByParser to script.
4:03 PM Changeset in webkit [39110] by pam@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2008-12-08 Pamela Greene <​pam@chromium.org>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=22739
Test the sequence of keyboard events generated for a keypress.

  • fast/events/special-key-events-in-input-text-expected.txt: Added.
  • fast/events/special-key-events-in-input-text.html: Added.
4:01 PM Changeset in webkit [39109] by ddkilzer@apple.com
  • 15 edits in trunk

Bug 22555: Sort "children" sections in Xcode project files

<​https://bugs.webkit.org/show_bug.cgi?id=22555>

Reviewed by Eric Seidel.

JavaScriptCore:

JavaScriptGlue:

  • JavaScriptGlue.xcodeproj/project.pbxproj: Sorted.

WebCore:

  • WebCore.xcodeproj/project.pbxproj: Sorted.
  • manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj/project.pbxproj: Sorted.

WebKit:

  • WebKit.xcodeproj/project.pbxproj: Sorted.

WebKitExamplePlugins:

  • NetscapeCocoaPlugin/NetscapeCocoaPlugin.xcodeproj/project.pbxproj: Sorted.

WebKitTools:

  • DrawTest/DrawTest.xcodeproj/project.pbxproj: Sorted.
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Sorted.
  • WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj: Sorted.
3:57 PM Changeset in webkit [39108] by Darin Adler
  • 2 edits in trunk/WebKit

2008-12-08 Darin Adler <Darin Adler>

  • StringsNotToBeLocalized.txt: Updated for recent changes.
3:44 PM Changeset in webkit [39107] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

Bug 22555: Sort "children" sections in Xcode project files

<​https://bugs.webkit.org/show_bug.cgi?id=22555>

Reviewed by Timothy Hatcher.

  • Scripts/sort-Xcode-project-file: By popular request, don't sort the mainGroup in the project (the list of items below the top-level project file).
3:42 PM Changeset in webkit [39106] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-12-08 Tony Chang <​tony@chromium.org>

Reviewed by Eric Seidel.

Enable Pan scrolling only when building on PLATFORM(WIN_OS)
Previously platforms like Apple Windows WebKit, Cairo Windows WebKit,
Wx and Chromium were enabling it explicitly, now we just turn it on
for all WIN_OS, later platforms can turn it off as needed on Windows
(or turn it on under Linux, etc.)
​https://bugs.webkit.org/show_bug.cgi?id=22698

  • wtf/Platform.h:
3:42 PM Changeset in webkit [39105] by eric@webkit.org
  • 7 edits in trunk/WebCore

2008-12-08 Tony Chang <​tony@chromium.org>

Reviewed by Eric Seidel.

Add a bool to GraphicsContext so that shadows can ignore
transformations. This is needed by HTML canvas element
where the spec says shadows are applied w/o transformations.
​https://bugs.webkit.org/show_bug.cgi?id=22580

No functional changes, thus no tests.

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setShadow): (WebCore::CanvasRenderingContext2D::applyShadow):
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createImageBuffer):
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setShadowsIgnoreTransforms):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/GraphicsContextPrivate.h: (WebCore::GraphicsContextState::GraphicsContextState):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setPlatformShadow):
3:18 PM Changeset in webkit [39104] by jchaffraix@webkit.org
  • 10 edits
    10 adds in trunk

WebCore:

2008-12-08 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Darin Adler.

Bug 17897: Not Rendering Images Imported from XHTML Document
<rdar://problem/5827614>

When we were loading document with XMLHttpRequest that contained images, the images
would not be fetched as they would not be displayed. However if we inserted such
an image element into a rendered document, we would not fetch the image and thus never
display it.

Now we check if the image has been loaded when we insert an HTMLImageElement into a
document.
To enable this, the image loader has an error flag. To avoid doing several attempts
when we know that the image is in error, we store the failed URL.
However Firefox and Opera ignore errors when the 'src' attribute changes and thus
we also have an updateFromElementIgnoringPreviousError to match the other browser.

Tests: http/tests/misc/image-blocked-src-change.html

http/tests/misc/image-blocked-src-no-change.html
http/tests/xmlhttprequest/xmlhttprequest-image-not-loaded-svg.svg
http/tests/xmlhttprequest/xmlhttprequest-image-not-loaded.html

  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::parseMappedAttribute): Changed to call updateFromElementIgnoringPreviousError.
  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::parseMappedAttribute): Ditto. (WebCore::HTMLImageElement::insertedIntoDocument): Call updateFromElement if we do not have an image.


  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute): Changed to call updateFromElementIgnoringPreviousError.
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::parseMappedAttribute): Ditto.
  • html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::parseMappedAttribute): Ditto.
  • loader/ImageLoader.cpp: (WebCore::ImageLoader::setImage): Added an assertion. (WebCore::ImageLoader::updateFromElement): Added a check for load error (to avoid displaying multiple errors in the console for a single image load).

(WebCore::ImageLoader::updateFromElementIgnoringPreviousError): This method clears previous error
before calling updateFromElement.

(WebCore::ImageLoader::notifyFinished): Added an assertion.

  • loader/ImageLoader.h:
  • svg/SVGImageElement.cpp: (WebCore::SVGImageElement::svgAttributeChanged): Changed to call updateFromElementIgnoringPreviousError.

LayoutTests:

2008-12-08 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Darin Adler.

Tests cases for bug 17897: Not Rendering Images Imported from XHTML Document
<rdar://problem/5827614>

  • xmlhttprequest-image-not-loaded*: test that an image loaded by an XMLHttpRequest and inserted into a XHTML or SVG Document is properly rendered.
  • image-blocked-src-change.html and image-blocked-src-no-change.html: test that an image that was in error is responding to src attribute change (whether it does really change the url or not).
  • http/tests/misc/image-blocked-src-change-expected.txt: Added.
  • http/tests/misc/image-blocked-src-change.html: Added.
  • http/tests/misc/image-blocked-src-no-change-expected.txt: Added.
  • http/tests/misc/image-blocked-src-no-change.html: Added.
  • http/tests/xmlhttprequest/resources/load-icon.svg: Added.
  • http/tests/xmlhttprequest/resources/load-icon.xhtml: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-image-not-loaded-expected.txt: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-image-not-loaded-svg-expected.txt: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-image-not-loaded-svg.svg: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-image-not-loaded.html: Added.
2:36 PM Changeset in webkit [39103] by hyatt@apple.com
  • 5 edits in trunk/WebCore

2008-12-08 David Hyatt <​hyatt@apple.com>

Make scrollbar creation virtual on ScrollView so that FrameView can have the capability to create
custom CSS scrollbars.

Reviewed by Eric Seidel

  • page/FrameView.cpp: (WebCore::FrameView::createScrollbar):
  • page/FrameView.h:
  • platform/ScrollView.cpp: (WebCore::ScrollView::setHasHorizontalScrollbar): (WebCore::ScrollView::setHasVerticalScrollbar): (WebCore::ScrollView::createScrollbar):
  • platform/ScrollView.h:
1:40 PM Changeset in webkit [39102] by weinig@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-12-08 Sam Weinig <​sam@webkit.org>

Reviewed by Cameron Zwarich.

Add basic memory statistics dumping for CodeBlock.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dumpStatistics): (JSC::CodeBlock::CodeBlock): (JSC::CodeBlock::~CodeBlock):
  • bytecode/CodeBlock.h:
1:39 PM Changeset in webkit [39101] by mrowe@apple.com
  • 1 edit
    2 moves in trunk/LayoutTests

Disable the WML tests since no platforms build with WML enabled by default and the test failures are annoying.

Rubber-stamped by Sam Weinig.

  • wml/variable-reference-invalid-character.html-disabled: Renamed from LayoutTests/wml/variable-reference-invalid-character.html.
  • wml/variable-reference-valid.html-disabled: Renamed from LayoutTests/wml/variable-reference-valid.html.
1:18 PM Changeset in webkit [39100] by mitz@apple.com
  • 11 edits in trunk

WebCore:

Reviewed by John Sullivan.

  • WebCore part of tracking the global history item for a WebView
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Set the page's global history item to the current back/forward list item, respecting private browsing mode. (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Ditto in this case. (WebCore::FrameLoader::goToItem): Ditto in this case. (WebCore::FrameLoader::updateHistoryForStandardLoad): If this load creates a new global history item, set the page's global history item to it. (WebCore::FrameLoader::updateHistoryForRedirectWithLockedHistory): Ditto.
  • page/Page.cpp: (WebCore::Page::setGlobalHistoryItem): Added this setter.
  • page/Page.h: Added a m_globalHistoryItem data member. (WebCore::Page::globalHistoryItem): Added this getter.

WebKit/mac:

Reviewed by John Sullivan.

  • WebKit/mac part of tracking the global history item for a WebView
  • WebView/WebView.mm: (-[WebView _globalHistoryItem]): Added. Returns the page's global history item.
  • WebView/WebViewPrivate.h:

WebKit/win:

Reviewed by John Sullivan.

  • WebKit/win part of tracking the global history item for a WebView
  • Interfaces/IWebViewPrivate.idl: Declared globalHistoryItem()
  • WebView.cpp: (WebView::globalHistoryItem): Added. Gets the page's global history item.
  • WebView.h:
11:28 AM Changeset in webkit [39099] by Antti Koivisto
  • 2 edits in trunk/WebCore

2008-12-08 Antti Koivisto <Antti Koivisto>

Reviewed by Dave Kilzer.

A few stylistic fixes suggested by Dave Kilzer.

  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::createIdentifier): (WebCore::CSSPrimitiveValue::create):
10:36 AM Changeset in webkit [39098] by ap@webkit.org
  • 3 edits in trunk/WebCore

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=22737
Try debug version when locating CFNetwork

  • platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::findCFNetworkModule): (WebCore::findCFURLRequestSetContentDispositionEncodingFallbackArrayFunction): (WebCore::findCFURLRequestCopyContentDispositionEncodingFallbackArrayFunction):
  • platform/network/win/CookieJarCFNetWin.cpp: (WebCore::findCFNetworkModule): (WebCore::findIsHTTPOnlyFunction):
10:13 AM Changeset in webkit [39097] by darin@chromium.org
  • 14 edits in trunk

2008-12-08 Aaron Boodman <​aa@chromium.org>

Reviewed by Stephanie Lewis.

​https://bugs.webkit.org/show_bug.cgi?id=22301
Make dispatchDidFinishLoading() always fire before didFinishLoadForFrame().

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::finishedParsing):
8:56 AM Changeset in webkit [39096] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2008-12-08 Simon Hausmann <​simon.hausmann@nokia.com>

Fix the Linux build with newer gcc/glibc.

8:53 AM Changeset in webkit [39095] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2008-12-08 Simon Hausmann <​simon.hausmann@nokia.com>

Fix the build with Qt on Windows.

5:38 AM Changeset in webkit [39094] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2008-12-08 Trenton Schulz <​trenton.schulz@nokia.com>

Rubber-stamped by Tor Arne Vestbø.

Fix build warning on Mac

2:42 AM Changeset in webkit [39093] by Simon Hausmann
  • 2 edits in trunk/WebCore

Fix the Qt build

2:35 AM Changeset in webkit [39092] by oliver@apple.com
  • 3 edits
    2 adds in trunk

Bug 22398: r39059: Crash when clearing webkitTransitionDuration in webkitTransitionEnd event handler
<rdar://problem/6426245> REGRESSION(r39059): Reproducible crash when clearing webkitTransitionDuration in webkitTransitionEnd event handler (22398)

Reviewed by Alexey Proskuryakov.

This regression was caused by r39059 replacing the protector on the active
animation with a protector on just the composition. It turns out that both
protectors are necessary.

Test: transitions/transition-duration-cleared-in-transitionend-crash.html

12:54 AM Changeset in webkit [39091] by ap@webkit.org
  • 9 edits
    2 deletes in trunk/WebCore

2008-12-08 Dmitry Titov <​dimich@chromium.org>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=22732
Remove unused files PausedTimeouts.h,.cpp
The change that deprecated this code was ​https://bugs.webkit.org/show_bug.cgi?id=22620

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.scons:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl: These are build files which had PausedTimeouts referenced.
  • bindings/js/PausedTimeouts.cpp: Removed.
  • bindings/js/PausedTimeouts.h: Removed.
  • bindings/js/ScriptController.cpp: Removed '#include'
  • page/Chrome.cpp: Removed '#include' and unused variable.
Note: See TracTimeline for information about the timeline view.