⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 10, 2008:

10:27 PM Changeset in webkit [39198] by cwzwarich@webkit.org
  • 3 edits in trunk/JavaScriptCore

2008-12-10 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Oliver Hunt.

Bug 22734: Debugger crashes when stepping into a function call in a return statement
<​https://bugs.webkit.org/show_bug.cgi?id=22734>
<rdar://problem/6426796>

  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): The DebuggerCallFrame uses the 'this' value stored in a callFrame, so op_convert_this should be emitted at the beginning of a function body when generating bytecode with debug hooks.
  • debugger/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::thisObject): The assertion inherent in the call to asObject() here is valid, because any 'this' value should have been converted to a JSObject*.
8:35 PM Changeset in webkit [39197] by barraclough@apple.com
  • 5 edits in trunk/JavaScriptCore

2008-12-10 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Geoff Garen.

Port more of the JIT to use the MacroAssembler interface.


Everything in the main pass, bar a few corner cases (operations with required
registers, or calling convention code). Slightly refactors array creation,
moving the offset calculation into the callFrame into C code (reducing code
planted).

Overall this appears to be a 1% win on v8-tests, due to the smaller immediates
being planted (in jfalse in particular).

  • interpreter/Interpreter.cpp: (JSC::Interpreter::cti_op_new_array):
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
  • jit/JIT.h:
  • wrec/WRECGenerator.cpp: (JSC::WREC::Generator::generateEnter):
6:42 PM Changeset in webkit [39196] by Nikolas Zimmermann
  • 5 edits in trunk/LayoutTests

Rubber-stamped by George Staikos.
Update WML pixel test results, after adding <template> support.

6:41 PM Changeset in webkit [39195] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2008-12-10 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler.

Implement support for NPN_PostURL/NPN_PostURLNotify in WebKit.


  • Plugins/Hosted/NetscapePluginInstanceProxy.h: Add stopAllStreams.


  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::stopAllStreams): Factored out this from ::destroy.


(WebKit::NetscapePluginInstanceProxy::destroy):
Call stopAllStreams().


(WebKit::NetscapePluginInstanceProxy::pluginHostDied):
Ditto.


(WebKit::NetscapePluginInstanceProxy::loadURL):
Handle post being true. This code has been copied from WebNetscapePluginView.mm (for now).

6:34 PM Changeset in webkit [39194] by Nikolas Zimmermann
  • 18 edits
    2 adds in trunk

Reviewed by Eric Seidel and George Staikos.

Fixes: ​https://bugs.webkit.org/show_bug.cgi?id=22799

Add WML <template> support. The <template> element is specified at deck-level
and declares a template for all <card> elements in the document.

6:14 PM Changeset in webkit [39193] by oliver@apple.com
  • 2 edits in trunk/WebCore

2008-12-09 Dmitry Titov <​dimich@chromium.org>

Reviewed by Darin Adler.

Fix memory leak - need to call stopActiveDOMObjects
when cached pages get destroyed.
​https://bugs.webkit.org/show_bug.cgi?id=22753

  • dom/Document.cpp: (WebCore::Document::detach):
5:55 PM Changeset in webkit [39192] by Simon Fraser
  • 2 edits in trunk/WebCore

2008-12-10 Simon Fraser <Simon Fraser>

Reviewed by Antti Koivisto

<rdar://problem/6431224>

When updating the value of a slider, don't mark the parents
as needing layout, because the size of the slider can never
change. This fixes full-page repaints in some cases.

  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::updateFromElement):
5:51 PM Changeset in webkit [39191] by beidson@apple.com
  • 8 edits in trunk

WebKitTools:
2008-12-10 Brady Eidson <​beidson@apple.com>

Reviewed by Darin


Implement the new policy delegate (including navigation type and permissive mode) for DRT/win

  • DumpRenderTree/win/DumpRenderTree.cpp:
  • DumpRenderTree/win/DumpRenderTreeWin.h:


  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setCustomPolicyDelegate):


  • DumpRenderTree/win/PolicyDelegate.cpp: (PolicyDelegate::PolicyDelegate): (PolicyDelegate::decidePolicyForNavigationAction):
  • DumpRenderTree/win/PolicyDelegate.h: (PolicyDelegate::setPermissive):

LayoutTests:
2008-12-10 Brady Eidson <​beidson@apple.com>

Reviewed by Darin

Most of these policy delegate related tests will now pass with accompanying DRT changes.


  • platform/win/Skipped:
5:49 PM Changeset in webkit [39190] by pol@apple.com
  • 3 edits in trunk/LayoutTests

2008-12-10 Pierre-Olivier Latour <​pol@apple.com>

Reviewed by Darin Adler.

Replaced outdated reference image for svg/webarchive/svg-cursor-subresources.svg

​https://bugs.webkit.org/show_bug.cgi?id=22801

  • platform/mac/svg/webarchive/svg-cursor-subresources-expected.checksum:
  • platform/mac/svg/webarchive/svg-cursor-subresources-expected.png:
5:25 PM Changeset in webkit [39189] by andersca@apple.com
  • 4 edits in trunk/WebKit/mac

2008-12-10 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler.

Move two NSData category methods to WebNSDataExtras.m.


  • Misc/WebNSDataExtras.h:
  • Misc/WebNSDataExtras.m: (-[NSData _web_startsWithBlankLine]): (-[NSData _web_locationAfterFirstBlankLine]):
  • Plugins/WebNetscapePluginView.mm:
5:01 PM Changeset in webkit [39188] by ddkilzer@apple.com
  • 1 edit in trunk/LayoutTests/platform/win/Skipped

Updated Radar bug reference.

4:48 PM Changeset in webkit [39187] by pol@apple.com
  • 39 edits in trunk/LayoutTests

2008-12-10 Pierre-Olivier Latour <​pol@apple.com>

Reviewed by Darin Adler.

Rewrote animations/animation-test-helpers.js to take advantage of the pauseAnimationAtTimeOnElementWithId()
API when available in DRT.

Updated all animations tests that check for values of animated CSS properties to use these new helper functions.

​https://bugs.webkit.org/show_bug.cgi?id=22796

  • animations/animation-test-helpers.js: (isCloseEnough): (checkExpectedValue): (endTest): (startTest): (runAnimationTest):
  • animations/big-rotation-expected.txt:
  • animations/big-rotation.html:
  • animations/change-keyframes-expected.txt:
  • animations/change-keyframes-name-expected.txt:
  • animations/change-keyframes-name.html:
  • animations/change-keyframes.html:
  • animations/change-one-anim-expected.txt:
  • animations/change-one-anim.html:
  • animations/generic-from-to-expected.txt:
  • animations/generic-from-to.html:
  • animations/import-expected.txt:
  • animations/import.html:
  • animations/keyframe-timing-functions-expected.txt:
  • animations/keyframe-timing-functions.html:
  • animations/keyframes-comma-separated-expected.txt:
  • animations/keyframes-comma-separated.html:
  • animations/keyframes-expected.txt:
  • animations/keyframes-from-missing.html:
  • animations/keyframes-out-of-order-expected.txt:
  • animations/keyframes-out-of-order.html:
  • animations/keyframes-to-missing.html:
  • animations/keyframes.html:
  • animations/lineheight-animation-expected.txt:
  • animations/lineheight-animation.html:
  • animations/matrix-anim-expected.txt:
  • animations/matrix-anim.html:
  • animations/multiple-animations-expected.txt:
  • animations/multiple-animations.html:
  • animations/multiple-keyframes-expected.txt:
  • animations/multiple-keyframes.html:
  • animations/transition-and-animation-1-expected.txt:
  • animations/transition-and-animation-1.html:
  • animations/transition-and-animation-2-expected.txt:
  • animations/transition-and-animation-2.html:
  • animations/width-using-ems-expected.txt:
  • animations/width-using-ems.html:
  • platform/win/Skipped:
4:00 PM Changeset in webkit [39186] by alice.liu@apple.com
  • 6 edits
    2 adds in trunk

WebCore:

2008-12-10 Alice Liu <​alice.liu@apple.com>

Manual test for ​https://bugs.webkit.org/show_bug.cgi?id=20685

Reviewed by Darin Adler.

  • manual-tests/drag-image-to-desktop.html: Added.

LayoutTests:

2008-12-10 Alice Liu <​alice.liu@apple.com>

Adding tweak to .conf files needed for
WebCore/manual-tests/drag-image-to-desktop.html

Reviewed by Darin Adler.

  • http/conf/apache2-debian-httpd.conf:
  • http/conf/apache2-httpd.conf:
  • http/conf/cygwin-httpd.conf:
  • http/conf/httpd.conf:
  • http/tests/misc/resources/generatedimage.bat: Added.
3:57 PM Changeset in webkit [39185] by alice.liu@apple.com
  • 17 edits
    3 adds in trunk

WebCore:

2008-12-10 Alice Liu <​alice.liu@apple.com>

fixed ​https://bugs.webkit.org/show_bug.cgi?id=20685

Reviewed by Darin Adler.

Manual test case is manual-tests/drag-image-to-desktop.html

Added new files to projects

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • page/DragController.cpp: (WebCore::DragController::startDrag):
  • platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedImageMIMETypes): (WebCore::initializeSupportedImageMIMETypesForEncoding):

These changes add a method to obtain the extension for an image

  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::filenameExtension):
  • platform/graphics/BitmapImage.h:
  • platform/graphics/Image.h: (WebCore::Image::filenameExtension):
  • platform/graphics/ImageSource.h:
  • platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::filenameExtension):
  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::filenameExtension):

These changes added a utility that returns the preferred extension for a UTI

  • platform/graphics/cg/ImageSourceCG.h: Added.
  • platform/graphics/cg/ImageSourceCGMac.mm: Added. (WebCore::MIMETypeForImageSourceType): (WebCore::preferredExtensionForImageSourceType):
  • platform/graphics/cg/ImageSourceCGWin.cpp: Added. (WebCore::MIMETypeForImageSourceType): (WebCore::preferredExtensionForImageSourceType):
  • platform/mac/MIMETypeRegistryMac.mm: moved getMIMETypeForUTI to ImageSourceCGMac.mm

Ask image for its file extension instead of relying on MIME type and file path

  • platform/win/ClipboardWin.cpp: (WebCore::createGlobalImageFileDescriptor):

Remove extraneous code from getPreferredExtensionForMIMEType.
Also moved getMIMETypeForUTI to ImageSourceCGWin.cpp

  • platform/win/MIMETypeRegistryWin.cpp: (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):

WebKit/mac:

2008-12-10 Alice Liu <​alice.liu@apple.com>

fixed ​https://bugs.webkit.org/show_bug.cgi?id=20685

Reviewed by Darin Adler.

  • Misc/WebNSPasteboardExtras.mm: Ask image for its file extension instead of falling back on MIME type and file path. Also moved this code to before setting the pasteboard data so as not to set any if no extension can be determined. (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
  • WebView/WebHTMLView.mm: Fixed a separate but related long-standing bug of how the filename for the promised drag data is determined by asking the image for a proper file extension. (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
1:33 PM Changeset in webkit [39184] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-12-10 Sam Weinig <​sam@webkit.org>

Fix non-JIT builds.

  • bytecode/CodeBlock.h:
12:57 PM Changeset in webkit [39183] by Simon Fraser
  • 2 edits in trunk/WebCore

2008-12-10 Simon Fraser <Simon Fraser>

Potential build fix. The forward declaration of FloatPoint should
be inside the WebCore namespace.

  • platform/graphics/FloatPoint3D.h:
12:05 PM Changeset in webkit [39182] by weinig@apple.com
  • 5 edits in trunk/JavaScriptCore

2008-12-10 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

<rdar://problem/6428332> Remove the CTI return address table from CodeBlock

Step 2:

Convert the return address table from a HashMap to a sorted Vector. This
reduces the size of the data structure by ~4.5MB on Membuster head.

SunSpider reports a 0.5% progression.

  • bytecode/CodeBlock.cpp: (JSC::sizeInBytes): Generic method to get the cost of a Vector. (JSC::CodeBlock::dumpStatistics): Add dumping of member sizes.
  • bytecode/CodeBlock.h: (JSC::PC::PC): Struct representing NativePC -> VirtualPC mappings. (JSC::getNativePC): Helper for binary chop. (JSC::CodeBlock::getBytecodeIndex): Used to get the VirtualPC from a NativePC using a binary chop of the pcVector. (JSC::CodeBlock::pcVector): Accessor.
  • interpreter/Interpreter.cpp: (JSC::vPCForPC): Use getBytecodeIndex instead of jitReturnAddressVPCMap().get(). (JSC::Interpreter::cti_op_instanceof): Ditto. (JSC::Interpreter::cti_op_resolve): Ditto. (JSC::Interpreter::cti_op_resolve_func): Ditto. (JSC::Interpreter::cti_op_resolve_skip): Ditto. (JSC::Interpreter::cti_op_resolve_with_base): Ditto. (JSC::Interpreter::cti_op_throw): Ditto. (JSC::Interpreter::cti_op_in): Ditto. (JSC::Interpreter::cti_vm_throw): Ditto.
  • jit/JIT.cpp: (JSC::JIT::privateCompile): Reserve exact capacity and fill the pcVector.
12:03 PM Changeset in webkit [39181] by Simon Fraser
  • 3 edits in trunk/WebCore

2008-12-10 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig

​https://bugs.webkit.org/show_bug.cgi?id=22793

Cleanup FloatPoint3D: inline the getters and setters,
fix a potential divide-by-zero in normalize(), and add
a FloatPoint constructor.

11:18 AM Changeset in webkit [39180] by jchaffraix@webkit.org
  • 14 edits in trunk/WebCore

2008-12-10 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Eric Seidel.

Bug 22665: Remove setCreatedByParser(bool) from the few elements that use it
​https://bugs.webkit.org/show_bug.cgi?id=22665

  • Removed setCreatedByParser from style and link elements.
  • Removed XMLTokenizer::eventuallyMarkAsCreatedByParser.
  • dom/XMLTokenizer.cpp:
  • dom/XMLTokenizer.h:
  • dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::startElementNs):
  • dom/XMLTokenizerQt.cpp: (WebCore::XMLTokenizer::parseStartElement):
  • html/HTMLElementFactory.cpp: (WebCore::linkConstructor): (WebCore::styleConstructor):
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::HTMLLinkElement):
  • html/HTMLLinkElement.h:
  • html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::HTMLStyleElement):
  • html/HTMLStyleElement.h:
  • html/HTMLTagNames.in:
  • svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::SVGStyleElement):
  • svg/SVGStyleElement.h:
  • svg/svgtags.in:
10:58 AM Changeset in webkit [39179] by ggaren@apple.com
  • 1 edit
    3 adds in trunk/LayoutTests

2008-12-10 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam :( Weinig.


Added a test for ​http://trac.webkit.org/changeset/39162.

  • fast/regex/malformed-escapes-expected.txt: Added.
  • fast/regex/malformed-escapes.html: Added.
  • fast/regex/resources/malformed-escapes.js: Added.
10:37 AM Changeset in webkit [39178] by beidson@apple.com
  • 31 edits
    4 adds in trunk

WebCore:

2008-12-10 Brady Eidson <​beidson@apple.com>

Reviewed by Darin

​https://bugs.webkit.org/show_bug.cgi?id=22194 and <rdar://problem/6388378> -
Dialog when going back to a page from whence you submitted a form

​http://trac.webkit.org/changeset/37317 changed the manner in which headers are added to
http requests, which caused the networking layer to have an incomplete set of headers
just before consulting the Policy Delegate. This caused a cache miss and incorrectly made
us believe we'd be resubmitting the form.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadItem): Being careful to maintain the new behavior required by the Origin header mechanism as discussed in bug 22194, restore the previous behavior of setting all the headers before the networking layer is asked about the cache lookup.

WebKitTools:

2008-12-10 Brady Eidson <​beidson@apple.com>

Reviewed by Darin

Change the custom policy delegate to actually allow navigation for tests that need it.
The new behavior is opt-in and doesn't require any changes in old tests.

  • DumpRenderTree/LayoutTestController.cpp: (setCustomPolicyDelegateCallback): Allow for a second boolean argument to set the permissive flag on the custom policy delegate, which will be false by default to maintain original behavior.
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setCustomPolicyDelegate):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setCustomPolicyDelegate): Partially stubbed out for now.
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setCustomPolicyDelegate): Still stubbed out, but with new param.
  • DumpRenderTree/mac/PolicyDelegate.h:
  • DumpRenderTree/mac/PolicyDelegate.mm: (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]): If the permissive flag is set, allow the navigation. (-[PolicyDelegate setPermissive:]): Change the behavior between "use" and "ignore" - allowing navigation or not.

LayoutTests:

2008-12-10 Brady Eidson <​beidson@apple.com>

Reviewed by Darin

New layout tests for testing the fix for ​https://bugs.webkit.org/show_bug.cgi?id=22194:

  • http/tests/navigation/post-goback-repost-policy-expected.txt: Added.
  • http/tests/navigation/post-goback-repost-policy.html: Added.
  • http/tests/navigation/resources/goback-with-policydelegate.html: Added.
  • http/tests/navigation/resources/post-target-policy-test.html: Added.

Updated layout test results for the new "custom policy delegate" mechanism:

  • fast/encoding/mailto-always-utf-8-expected.txt:
  • fast/forms/mailto/advanced-get-expected.txt:
  • fast/forms/mailto/advanced-put-expected.txt:
  • fast/forms/mailto/get-multiple-items-expected.txt:
  • fast/forms/mailto/get-multiple-items-text-plain-expected.txt:
  • fast/forms/mailto/get-multiple-items-x-www-form-urlencoded-expected.txt:
  • fast/forms/mailto/get-non-ascii-always-utf-8-expected.txt:
  • fast/forms/mailto/get-non-ascii-expected.txt:
  • fast/forms/mailto/get-non-ascii-text-plain-expected.txt:
  • fast/forms/mailto/get-non-ascii-text-plain-latin-1-expected.txt:
  • fast/forms/mailto/get-overwrite-query-expected.txt:
  • fast/forms/mailto/post-append-query-expected.txt:
  • fast/forms/mailto/post-multiple-items-expected.txt:
  • fast/forms/mailto/post-multiple-items-multipart-form-data-expected.txt:
  • fast/forms/mailto/post-multiple-items-text-plain-expected.txt:
  • fast/forms/mailto/post-multiple-items-x-www-form-urlencoded-expected.txt:
  • fast/forms/mailto/post-text-plain-expected.txt:
  • fast/forms/mailto/post-text-plain-with-accept-charset-expected.txt:
  • http/tests/security/feed-urls-from-remote-expected.txt:

Skip the new test on Windows until the policy delegate can be enhanced there:

  • platform/win/Skipped: (It is already implicitly skipped for qt and gtk)
10:27 AM Changeset in webkit [39177] by darin@chromium.org
  • 2 edits in trunk/WebCore

2008-12-10 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Timothy Hatcher.

Add back ability to end all profiling via console by invoking profileEnd
with no arguments.

  • page/Console.cpp: (WebCore::Console::profileEnd): Removed title null-checking and

subsequent early exit.

10:00 AM Changeset in webkit [39176] by pol@apple.com
  • 4 edits
    4 adds in trunk

2008-12-10 Pierre-Olivier Latour <​pol@apple.com>

Reviewed by Darin Adler.

KeyframeAnimation::animate() needs to compute the elapsed animation time
properly taking into account its paused state.

​https://bugs.webkit.org/show_bug.cgi?id=22773

Test: animations/animation-drt-api-multiple-keyframes.html

  • page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::animate):
9:18 AM Changeset in webkit [39175] by Simon Fraser
  • 6 edits in trunk/WebCore

2008-12-10 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein

Part of
​https://bugs.webkit.org/show_bug.cgi?id=22570

Rename methods on RenderLayer for clarity:

clearClipRects -> clearClipRectsIncludingDescendants
clearClipRect -> clearClipRects

9:06 AM Changeset in webkit [39174] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx build fix after the script call stack/frame additions.

8:41 AM Changeset in webkit [39173] by zecke@webkit.org
  • 14 edits in trunk/WebKit/qt

2008-12-10 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Simon Hausmann.

API changes discussed with Simon Hausmann, Tor Arne
Vestbø, Ariya Hidayat...

  • Api/qwebdatabase.cpp: (QWebDatabase::fileName): (QWebDatabase::removeDatabase):
  • Api/qwebdatabase.h:
  • Api/qwebframe.cpp: (QWebFrame::scroll): (QWebFrame::scrollPosition): (QWebFrame::setScrollPosition):
  • Api/qwebframe.h:
  • Api/qwebpage.cpp: (QWebPage::setContentEditable): (QWebPage::isContentEditable): (QWebPage::extension):
  • Api/qwebpage.h:
  • Api/qwebsecurityorigin.cpp:
  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): (QWebSettings::QWebSettings):
  • Api/qwebsettings.h:
  • QtLauncher/main.cpp: (MainWindow::setEditable):
  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::exceededDatabaseQuota): (WebCore::ChromeClientQt::runOpenPanel):
  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::isEditable):
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::database):
8:35 AM Changeset in webkit [39172] by zecke@webkit.org
  • 2 edits in trunk/WebCore

2008-12-10 Srinivasa Rao M. Hamse <​msrinirao@gmail.com>

Reviewed by Holger Freyther.

F1-F12 key mappings for WebKit Gtk Port

  • platform/gtk/KeyEventGtk.cpp: (WebCore::windowsKeyCodeForKeyEvent):
8:06 AM Changeset in webkit [39171] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-12-10 Enrico Ros <​enrico.ros@m31.com>

Reviewed by Simon Hausmann.

Fix the Qt build when SVG is disabled. A broken dependancy caused
unnecessary rebuilds even with no changes.

7:59 AM Changeset in webkit [39170] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2008-12-09 Balazs Kelemen <​Kelemen.Balazs.3@stud.u-szeged.hu>

Reviewed by Simon Hausmann.

Extended QtLauncher so now it can load pages from an url list
one by one. This can be useful for testing purposes (eq. leak hunting).
The -r option activates this feature.

​https://bugs.webkit.org/show_bug.cgi?id=20932

4:49 AM Changeset in webkit [39169] by ap@webkit.org
  • 3 edits
    6 adds in trunk

2008-12-10 Hironori Bono <​hbono@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 21820: Unable to enter the Tamil UNICODE Characters via Thamizha Phonetic IME
​https://bugs.webkit.org/show_bug.cgi?id=21820

<rdar://problem/5683248> Typing backspace to delete a diacritical mark also deletes the character before (Arabic)
<rdar://problem/5702038> Backspace removes Thai Character in wrong sequence

Tests: editing/deleting/delete-ligature-001.html

editing/deleting/delete-ligature-002.html
editing/deleting/delete-ligature-003.html

  • editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): Delete only the last character of a ligature which consists of multiple Unicode characters when deleting it with a backspace key.
4:23 AM Changeset in webkit [39168] by ap@webkit.org
  • 3 edits in trunk

2008-12-10 David Levin <​levin@chromium.org>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=22177
Fix the windows build by removing calls to notifyFormStateChanged
where they didn't appear in the original reviewed patch.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::type): (WebCore::HTMLInputElement::attach):
1:10 AM Changeset in webkit [39167] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2008-12-10 Simon Hausmann <Simon Hausmann>

Fix the Qt build, added const to Node* parameter after change
in signature.

12:15 AM Changeset in webkit [39166] by ap@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Rubber-stamped by Maciej Stachowiak.

<rdar://problem/5959165> Crash in a number of iExploder tests in WebCore::CachedImage::notifyObservers

Add a test for a crash that is no longer reproducible.

  • fast/css/mask-missing-image-crash-expected.txt: Added.
  • fast/css/mask-missing-image-crash.html: Added.

Dec 9, 2008:

11:59 PM Changeset in webkit [39165] by ap@webkit.org
  • 2 edits
    1 move in trunk

Rubber-stamped by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=19762
Crash in svg/webarchive/svg-cursor-subresources.svg

  • svg/webarchive/svg-cursor-subresources.svg: Copied from LayoutTests/svg/webarchive/svg-cursor-subresources.svg-disabled.
  • svg/webarchive/svg-cursor-subresources.svg-disabled: Removed. Re-enabling the test.
11:54 PM Changeset in webkit [39164] by ggaren@apple.com
  • 4 edits
    1 copy
    2 adds in trunk

JavaScriptCore:

2008-12-09 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Added WREC support for an assertion followed by a quantifier. Fixed
PCRE to match.

  • wrec/WRECParser.cpp: (JSC::WREC::Parser::parseParentheses): Throw away the quantifier, since it's meaningless. (Firefox does the same.)
  • pcre/pcre_compile.cpp: (compileBranch): ditto.

LayoutTests:

2008-12-09 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Added a test for an assertion followed by a quantifier.

  • fast/regex/quantified-assertions-expected.txt: Added.
  • fast/regex/quantified-assertions.html: Added.
  • fast/regex/resources/quantified-assertions.js: Copied from fast/regex/resources/alternative-length-miscalculation.js.
10:48 PM Changeset in webkit [39163] by abarth@webkit.org
  • 4 edits in trunk/WebCore

2008-12-09 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

Add ScriptController::updateSecurityOrigin to notify the bindings
that a document's securityOrigin has been updated. This is used by
V8 to update its security context.

  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::updateSecurityOrigin):
  • bindings/js/ScriptController.h:
  • dom/Document.cpp: (WebCore::Document::setDomain):
8:59 PM Changeset in webkit [39162] by ggaren@apple.com
  • 12 edits in trunk

JavaScriptCore:

2008-12-09 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Cameron Zwarich.

In preparation for compiling WREC without PCRE:


Further relaxed WREC's parsing to be more web-compatible. Fixed PCRE to
match in cases where it didn't already.


Changed JavaScriptCore to report syntax errors detected by WREC, rather
than falling back on PCRE any time WREC sees an error.


  • pcre/pcre_compile.cpp: (checkEscape): Relaxed parsing of \c and \N escapes to be more web-compatible.


  • runtime/RegExp.cpp: (JSC::RegExp::RegExp): Only fall back on PCRE if WREC has not reported a syntax error.
  • wrec/WREC.cpp: (JSC::WREC::Generator::compileRegExp): Fixed some error reporting to match PCRE.
  • wrec/WRECParser.cpp: Added error messages that match PCRE.

(JSC::WREC::Parser::consumeGreedyQuantifier):
(JSC::WREC::Parser::parseParentheses):
(JSC::WREC::Parser::parseCharacterClass):
(JSC::WREC::Parser::parseNonCharacterEscape): Updated the above functions to
use the new setError API.

(JSC::WREC::Parser::consumeEscape): Relaxed parsing of \c \N \u \x \B
to be more web-compatible.

(JSC::WREC::Parser::parseAlternative): Distinguish between a malformed
quantifier and a quantifier with no prefix, like PCRE does.

(JSC::WREC::Parser::consumeParenthesesType): Updated to use the new setError API.

  • wrec/WRECParser.h: (JSC::WREC::Parser::error): (JSC::WREC::Parser::syntaxError): (JSC::WREC::Parser::parsePattern): (JSC::WREC::Parser::reset): (JSC::WREC::Parser::setError): Store error messages instead of error codes, to provide for exception messages. Use a setter for reporting errors, so errors detected early are not overwritten by errors detected later.

LayoutTests:

2008-12-09 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Cameron Zwarich.

Updated regular expression layout tests to be agnostic between WREC
and PCRE quirks. Also, updated results to match new, more web-compatible
regular expression parsing.

  • fast/js/regexp-charclass-crash-expected.txt:
  • fast/js/regexp-charclass-crash.html:
  • fast/js/regexp-no-extensions-expected.txt:
  • fast/js/resources/regexp-no-extensions.js:
  • fast/regex/test1-expected.txt:
8:22 PM Changeset in webkit [39161] by barraclough@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-12-09 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Oliver Hunt.

Use va_args to access cti function arguments.
​https://bugs.webkit.org/show_bug.cgi?id=22774

This may be a minor regression, but we'll take the hit if so to reduce fragility.

  • interpreter/Interpreter.cpp:
  • interpreter/Interpreter.h:
5:42 PM Changeset in webkit [39160] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Fix gdb-safari on Tiger.

gdb on Tiger does not take the -arch flag, so do not pass it.

Rubber-stamped by Ada Chan.

5:35 PM Changeset in webkit [39159] by pam@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

2008-12-09 David Levin <​levin@chromium.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=22512

Add a test to check for checks when attaching an event to a document created by
'document.implementation.createDocument'.

  • fast/events/create-document-crash-on-attach-event-expected.txt: Added.
  • fast/events/create-document-crash-on-attach-event.html: Added.
  • fast/events/resources/create-document-crash-on-attach-event.js: Added. (doc.onload):
5:28 PM Changeset in webkit [39158] by pam@chromium.org
  • 1 edit
    5 adds in trunk/LayoutTests

2008-12-09 David Levin <​levin@chromium.org>

Reviewed by Eric Seidel.

Add a test to check the event order for context clicks on Windows.

​https://bugs.webkit.org/show_bug.cgi?id=22505

  • platform/win/fast/events/context-click-events-expected.txt: Added.
  • platform/win/fast/events/context-click-events.html: Added.
  • platform/win/fast/events/resources: Added.
  • platform/win/fast/events/resources/TEMPLATE.html: Added.
  • platform/win/fast/events/resources/context-click-events.js: Added. (clickHandler): (traceMouseEvent):
4:39 PM Changeset in webkit [39157] by weinig@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-12-09 Sam Weinig <​sam@webkit.org>

Reviewed twice by Cameron Zwarich.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=22752
Clear SymbolTable after codegen for Function codeblocks that
don't require an activation

This is a ~1.5MB improvement on Membuster-head.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dumpStatistics): Add logging of non-empty symbol tables and total size used by symbol tables.
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::generate): Clear the symbol table here.
4:26 PM Changeset in webkit [39156] by weinig@apple.com
  • 5 edits in trunk/JavaScriptCore

2008-12-09 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Remove unnecessary extra lookup when throwing an exception.
We used to first lookup the target offset using getHandlerForVPC
and then we would lookup the native code stub using
nativeExceptionCodeForHandlerVPC. Instead, we can just pass around
the HandlerInfo.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::handlerForVPC): Return the HandlerInfo.
  • bytecode/CodeBlock.h: Remove nativeExceptionCodeForHandlerVPC.
  • interpreter/Interpreter.cpp: (JSC::Interpreter::throwException): Return a HandlerInfo instead of and Instruction offset. (JSC::Interpreter::privateExecute): Get the offset from HandlerInfo. (JSC::Interpreter::cti_op_throw): Get the native code from the HandleInfo. (JSC::Interpreter::cti_vm_throw): Ditto.
  • interpreter/Interpreter.h:
4:14 PM Changeset in webkit [39155] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2008-12-09 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler.

Fix typecast.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]):
4:13 PM Changeset in webkit [39154] by andersca@apple.com
  • 5 edits in trunk/WebKit/mac

2008-12-09 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler.

Implement software rendering of hosted plug-ins.


  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCInvalidateRect): New MiG function. This is called by the plug-in host when it has drawn something.


  • Plugins/Hosted/WebHostedNetscapePluginView.h:
  • Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView createPlugin]): Create a software renderer.


(-[WebHostedNetscapePluginView destroyPlugin]):
Destroy the software renderer.


(-[WebHostedNetscapePluginView drawRect:]):
Draw using the software renderer.


  • Plugins/Hosted/WebKitPluginClient.defs: Add InvalidateRect.
4:11 PM Changeset in webkit [39153] by eric@webkit.org
  • 4 edits in trunk

No review, build fix only.

Fix a few config issues to let the Chromium Windows WebCore build get further.

  • WebCore.scons:
4:01 PM Changeset in webkit [39152] by brettw@chromium.org
  • 16 edits in trunk

Reviewed by Dave Hyatt.

​https://bugs.webkit.org/show_bug.cgi?id=22177

Add a callback on ChromeClient that the state of form elements on
the page has changed. This is to allow clients implementing session
saving to know when the current state is dirty.

3:51 PM Changeset in webkit [39151] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2008-12-09 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Make sure to pause null events for hosted plug-ins as well.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]):
3:49 PM Changeset in webkit [39150] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2008-12-09 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler.

  • Plugins/Hosted/NetscapePluginHostProxy.h:
  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Unfortunately we can't use a libdispatch source right now, because of <rdar://problem/6393180>.
3:36 PM Changeset in webkit [39149] by weinig@apple.com
  • 6 edits in trunk/WebCore

2008-12-09 Sam Weinig <​sam@webkit.org>

Reviewed by Darin Adler.

Fix intermittent crash in buildbot. The CSSCursorImageValues and
SVGCursorElements held onto raw SVGElement pointers without any
guarantee that the element is still around.

We did not fix the design that resulted in this issue, we just fixed
the pointer lifetimes.

  • css/CSSCursorImageValue.cpp: (WebCore::CSSCursorImageValue::~CSSCursorImageValue): Zero out the back pointers. (WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed): Set up a back pointer. (WebCore::CSSCursorImageValue::removeReferencedElement): Added. Used when the element is destroyed.
  • css/CSSCursorImageValue.h: Added removeReferencedElement.
  • svg/SVGCursorElement.cpp: (WebCore::SVGCursorElement::~SVGCursorElement): Zero out the back pointers. (WebCore::SVGCursorElement::addClient): Set up a back pointer. (WebCore::SVGCursorElement::removeClient): Zero out the back pointer.
  • svg/SVGElement.cpp: (WebCore::SVGElement::SVGElement): Initialize back pointers to zero. (WebCore::SVGElement::~SVGElement): Call both the element and cursor image value to remove the element from their sets.
  • svg/SVGElement.h: (WebCore::SVGElement::setCursorElement): Added. (WebCore::SVGElement::setCursorImageValue): Added.
3:33 PM Changeset in webkit [39148] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

No review, build fix only.

Add ExecutableAllocator files missing from Scons build.

3:11 PM Changeset in webkit [39147] by darin@chromium.org
  • 2 edits in trunk/WebKit/cf

2008-12-09 Dimitri Glazkov <Dimitri Glazkov>

Fix bustage.

  • WebCoreSupport/WebInspectorClientCF.cpp:
2:36 PM Changeset in webkit [39146] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2008-12-09 David Hyatt <​hyatt@apple.com>

Add code that will create custom CSS scrollbars from the <body>, the document element (<html>) and the owning
frame/iframe. If any of them set a custom style, it will be used. The scrollbars do not update dynamically
yet as you switch from page to page (until they are destroyed and recreated).

Reviewed by Adele

  • page/FrameView.cpp: (WebCore::FrameView::createScrollbar):
2:02 PM Changeset in webkit [39145] by timothy@apple.com
  • 3 edits in trunk/WebKit/mac

Implement a few methods needed to keep Dictionary.app working on Leopard.

<rdar://problem/6002160> Internal changes to WebKit in Safari 4
Developer Preview might break Dictionary

Reviewed by Dan Bernstein.

  • WebView/WebFrame.mm: (-[WebFrame convertNSRangeToDOMRange:]): Added. Calls _convertNSRangeToDOMRange. (-[WebFrame convertDOMRangeToNSRange:]): Added. Calls _convertDOMRangeToNSRange.
  • WebView/WebHTMLView.mm: (-[WebHTMLView _bridge]): Added. Returns the WebFrame, which has the methods that Dictionary.app is using.
1:46 PM Changeset in webkit [39144] by darin@chromium.org
  • 7 edits in trunk/WebCore

2008-12-09 Ojan Vafai <​ojan@chromium.org>

Reviewed by Dave Hyatt.

​https://bugs.webkit.org/show_bug.cgi?id=22689
Match Firefox button metrics on Windows.

  • rendering/RenderButton.cpp: (WebCore::RenderButton::addChild): (WebCore::RenderButton::styleDidChange): (WebCore::RenderButton::setupInnerStyle):
  • rendering/RenderButton.h:
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustButtonInnerStyle):
  • rendering/RenderTheme.h:
  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::adjustSliderThumbSize): (WebCore::RenderThemeWin::adjustButtonInnerStyle):
  • rendering/RenderThemeWin.h:
12:43 PM Changeset in webkit [39143] by darin@chromium.org
  • 1 edit
    4 adds in trunk/WebCore

2008-12-09 Darin Fisher <​darin@chromium.org>

Fixes bustages.

​https://bugs.webkit.org/show_bug.cgi?id=22631
Adding missing files from previous commit.

  • bindings/js/ScriptCallFrame.cpp: Added. (WebCore::ScriptCallFrame::ScriptCallFrame): (WebCore::ScriptCallFrame::~ScriptCallFrame): (WebCore::ScriptCallFrame::argumentAt):
  • bindings/js/ScriptCallFrame.h: Added. (WebCore::ScriptCallFrame::functionName): (WebCore::ScriptCallFrame::sourceURL): (WebCore::ScriptCallFrame::lineNumber): (WebCore::ScriptCallFrame::argumentCount):
  • bindings/js/ScriptCallStack.cpp: Added. (WebCore::ScriptCallStack::ScriptCallStack): (WebCore::ScriptCallStack::~ScriptCallStack): (WebCore::ScriptCallStack::at): (WebCore::ScriptCallStack::size): (WebCore::ScriptCallStack::initialize):
  • bindings/js/ScriptCallStack.h: Added. (WebCore::ScriptCallStack::state):
12:25 PM Changeset in webkit [39142] by darin@chromium.org
  • 19 edits in trunk

2008-12-09 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Timothy Hatcher.

​https://bugs.webkit.org/show_bug.cgi?id=22631
Streamline Console.cpp, abstract out the use of JSC::ExecState and
JSC::ArgList by introducing ScriptCallFrame and ScriptCallStack
abstractions.

  • GNUmakefile.am: Added ScriptCallFrame and ScriptCallStack to build
  • WebCore.pro: Added ScriptCallFrame and ScriptCallStack to build
  • WebCore.vcproj/WebCore.vcproj: Added ScriptCallFrame and ScriptCallStack to project
  • WebCore.xcodeproj/project.pbxproj: Added ScriptCallFrame and ScriptCallStack to project
  • bindings/js/JSConsoleCustom.cpp: Remove custom bindings.
  • bindings/js/ScriptCallFrame.cpp: Added. (WebCore::ScriptCallFrame::ScriptCallFrame): (WebCore::ScriptCallFrame::~ScriptCallFrame): (WebCore::ScriptCallFrame::argumentAt):
  • bindings/js/ScriptCallFrame.h: Added. (WebCore::ScriptCallFrame::functionName): (WebCore::ScriptCallFrame::sourceURL): (WebCore::ScriptCallFrame::lineNumber): (WebCore::ScriptCallFrame::argumentCount):
  • bindings/js/ScriptCallStack.cpp: Added. (WebCore::ScriptCallStack::ScriptCallStack): (WebCore::ScriptCallStack::~ScriptCallStack): (WebCore::ScriptCallStack::at): (WebCore::ScriptCallStack::size): (WebCore::ScriptCallStack::initialize):
  • bindings/js/ScriptCallStack.h: Added. (WebCore::ScriptCallStack::ScriptCallStack): (WebCore::ScriptCallStack::~ScriptCallStack): (WebCore::ScriptCallStack::state): (WebCore::ScriptCallStack::at): (WebCore::ScriptCallStack::size): (WebCore::ScriptCallStack::initialize):
  • bindings/js/ScriptString.h: Added missing PlatformString include. (WebCore::ScriptString::ScriptString): Added default constructor. (WebCore::ScriptString::operator==): Added equality operator. (WebCore::ScriptString::operator!=):
  • bindings/js/ScriptValue.cpp: Added isNull and isUndefined. (WebCore::ScriptValue::isNull): (WebCore::ScriptValue::isUndefined):
  • bindings/js/ScriptValue.h: Added isNull and isUndefined
  • bindings/scripts/CodeGeneratorJS.pm: Add handling for CustomArgumentHandling attribute.
  • inspector/InspectorController.cpp: Refactored to use ScriptCallFrame and ScriptCallStack. (WebCore::ConsoleMessage::ConsoleMessage): (WebCore::InspectorController::addMessageToConsole): (WebCore::InspectorController::startGroup): (WebCore::InspectorController::addScriptConsoleMessage): (WebCore::InspectorController::count): (WebCore::InspectorController::startTiming): (WebCore::InspectorController::stopTiming):
  • inspector/InspectorController.h: Refactored to use ScriptCallFrame and ScriptCallStack.
  • inspector/front-end/Console.js: Modified to use argument value itself rather than f.name for stack trace.
  • page/Console.cpp: Refactored to use ScriptCallFrame and ScriptCallStack. (WebCore::getFirstArgumentAsString): (WebCore::Console::addMessage): (WebCore::Console::debug): (WebCore::Console::error): (WebCore::Console::info): (WebCore::Console::log): (WebCore::Console::dir): (WebCore::Console::dirxml): (WebCore::Console::trace): (WebCore::Console::assertCondition): (WebCore::Console::count): (WebCore::Console::profile): (WebCore::Console::profileEnd): (WebCore::Console::time): (WebCore::Console::timeEnd): (WebCore::Console::group): (WebCore::Console::warn):
  • page/Console.h:
  • page/Console.idl: Removed Custom attributes, added CustomArgumentHandling attributes, and tweaked argument defs.
11:19 AM Changeset in webkit [39141] by cwzwarich@webkit.org
  • 5 edits in trunk/JavaScriptCore

2008-12-08 Judit Jasz <​jasy@inf.u-szeged.hu>

Reviewed and tweaked by Cameron Zwarich.

Bug 22352: Annotate opcodes with their length
<​https://bugs.webkit.org/show_bug.cgi?id=22352>

  • bytecode/Opcode.cpp:
  • bytecode/Opcode.h:
  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
10:42 AM Changeset in webkit [39140] by Darin Adler
  • 7 edits in trunk/WebCore

2008-12-09 Darin Adler <Darin Adler>

Try to fix non-Mac builds.

  • GNUmakefile.am: Added NavigatorBase.
  • WebCore.pro: Ditto.
  • WebCore.scons: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCoreSources.bkl: Ditto.

Unrelated tweak sitting in my tree.

  • bindings/objc/DOMAbstractView.mm: Remove pointless override of finalize method.
10:38 AM Changeset in webkit [39139] by Darin Adler
  • 2 edits in trunk/WebCore

2008-12-09 Darin Adler <Darin Adler>

Try to fix Tiger build.

  • platform/network/mac/NetworkStateNotifierMac.cpp: Declare CFRunLoopGetMain.
9:58 AM Changeset in webkit [39138] by ap@webkit.org
  • 17 edits
    7 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=22719
Implement Navigator object in Workers

Test: fast/workers/worker-navigator.html

  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj: Added WorkerNavigator sources.
  • bindings/js/JSWorkerContext.cpp: (WebCore::jsWorkerContextNavigator): Worker.navigator returns a WoerkerNavigator object (it is named just Navigator in the spec, but it is not the same interface that is available on Windows).
  • dom/Worker.cpp: (WebCore::Worker::notifyFinished):
  • dom/WorkerContext.cpp: (WebCore::WorkerContext::WorkerContext): (WebCore::WorkerContext::navigator):
  • dom/WorkerContext.h: (WebCore::WorkerContext::create):
  • dom/WorkerThread.cpp: (WebCore::WorkerThread::create): (WebCore::WorkerThread::WorkerThread): (WebCore::WorkerThread::workerThread):
  • dom/WorkerThread.h: Pass a pre-computed user agent string into worker, because it cannot call a client method directly, and pre-computing is easier than sending a synchronous message to the main thread.
  • page/Navigator.cpp:
  • page/Navigator.h:
  • page/NavigatorBase.cpp: Added.
  • page/NavigatorBase.h: Added. Factor out common (and uncommon, but very similar) functionality into a base class.
  • page/WorkerNavigator.cpp: Added.
  • page/WorkerNavigator.h: Added.
  • page/WorkerNavigator.idl: Added. Per Web Workers and HTML5, implement a small subset of what we currently have in Window.Navigator.
  • platform/network/NetworkStateNotifier.cpp: (WebCore::networkStateNotifier): Make networkStateNotifier() static constructor thread safe. The object is created on the thread it is first called from, while callbacks are registered on the main thread. Calls to onLine() from other threads are safe, because it is just loading a boolean.
  • platform/network/mac/NetworkStateNotifierMac.cpp: (WebCore::NetworkStateNotifier::NetworkStateNotifier): Schedule notifications on main event loop, not the current one.
9:53 AM Changeset in webkit [39137] by pam@chromium.org
  • 2 edits in trunk/LayoutTests

2008-12-09 Pamela Greene <​pam@chromium.org>

Submitted without review.
Corrected results so the test passes.

  • fast/events/special-key-events-in-input-text-expected.txt:
8:42 AM QtWebKitGitInstructions edited by Simon Hausmann
(diff)
8:40 AM Changeset in webkit [39136] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

008-12-09 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Reviewed by Simon Hausmann.

Fix the documentation of the localStorageDatabasePath setters/getters.

6:50 AM Changeset in webkit [39135] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

Rubber-stamped by Alexey Proskuryakov.
Forgot to update Qt/WML build - add some new files to the build.

6:48 AM Changeset in webkit [39134] by ddkilzer@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fixed more ChangeLog dates.

6:42 AM Changeset in webkit [39133] by Nikolas Zimmermann
  • 16 edits
    2 moves
    13 adds in trunk

Reviewed by Alexey Proskuryakov.

Fixes: ​https://bugs.webkit.org/show_bug.cgi?id=22637

Implement the GET method for WMLGoElement, and some test covering it's behaviour.
Update all build systems supporting WML that haven't been updated since a while.

Add WMLPostField stub implementation, needed for implementing POST method.

Tests: wml/go-task-get-method-external-deck-with-href.html

wml/go-task-get-method-external-deck.html
wml/go-task-get-method-same-deck.html

2:13 AM Changeset in webkit [39132] by Simon Hausmann
  • 4 edits in trunk/WebKit/qt

2008-12-08 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Reviewed by Simon Hausmann.

Multiple files support for the file chooser.

  • Api/qwebpage.cpp: (QWebPage::chooseFiles):
  • Api/qwebpage.h:
  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::runOpenPanel):
Note: See TracTimeline for information about the timeline view.