Timeline
Dec 11, 2008:
- 11:51 PM Changeset in webkit [39228] by
-
- 4 edits in trunk/WebCore
2008-12-11 Stephanie Lewis <Stephanie Lewis>
Reviewed by Geoff Garen
Account for the size of the response and request headers as well as other overhead
when calculating the size a resource takes up in the cache. Halts unbounded
growth in the cache. Reduced stress test memory high water marks by > 50%.
Uses estimates gathered from the stress test to set the overhead size.
A version of the patch was created that calculated most of the sizes, but it was
decided that the patch was still at a basic level an estimate. What gains it made
in accuracy was offset by the complexity involved in creating and updating the
estimate.
- loader/Cache.cpp: (WebCore::Cache::resourceAccessed): (WebCore::Cache::TypeStatistic::addResource): (WebCore::Cache::dumpLRULists):
- loader/CachedResource.cpp: (WebCore::CachedResource::overheadSize):
- loader/CachedResource.h: (WebCore::CachedResource::size):
- 11:28 PM Changeset in webkit [39227] by
-
- 17 edits6 deletes in trunk
2008-12-11 Cameron Zwarich <zwarich@apple.com>
Rubber-stamped by Mark Rowe.
Roll out r39212 due to assertion failures during layout tests, multiple
layout test failures, memory leaks, and obvious incorrectness.
WebKit/mac:
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm: (-[WebPreferences fullDocumentTeardownEnabled]):
- WebView/WebPreferencesPrivate.h:
WebKit/win:
- Interfaces/IWebPreferencesPrivate.idl:
- WebPreferenceKeysPrivate.h:
- WebPreferences.cpp:
- WebPreferences.h:
WebKitTools:
- DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
- DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
LayoutTests:
- security/override-preferences-2-expected.txt: Removed.
- security/override-preferences-2.html: Removed.
- security/override-preferences-expected.txt: Removed.
- security/override-preferences.html: Removed.
- security/override-zzz-reset-expected.txt: Removed.
- security/override-zzz-reset.html: Removed.
- 8:20 PM Changeset in webkit [39226] by
-
- 7 edits in trunk/JavaScriptCore
2008-12-11 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Remove CTI_ARGUMENTS mode, use va_start implementation on Windows,
unifying JIT callback (cti_*) argument access on OS X & Windows
No performance impact.
- interpreter/Interpreter.h:
- jit/JIT.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines):
- jit/JIT.h:
- jit/JITInlineMethods.h: (JSC::JIT::emitCTICall):
- jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition):
- wtf/Platform.h:
- 6:02 PM Changeset in webkit [39225] by
-
- 20 edits7 adds in trunk
Reviewed by Holger Freyther.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=22814
Add <wml> image element support. Based on HTML/SVGImage{Element/Loader}, with
the only difference that WML defines a second source attribute 'localsrc', that
takes precedence over the 'src' attribute. If loading the 'localsrc' attribute
fails, the user agent should try loading the 'src' attribute. If both fail the
'alt' fallback content will be used - just like in HTML.
Fixes: fast/wml/img-localsrc.wml (<img> and 'localsrc' attribute)
fast/wml/img-src-localsrc-alt.wml ('localsrc'/'src' fallback handling)
fast/wml/img-src.wml (<img> and 'src' attribute)
- 5:15 PM Changeset in webkit [39224] by
-
- 2 edits in trunk/WebKit/mac
2008-12-11 Stephanie Lewis <Stephanie Lewis>
Fix build.
- WebView/WebView.mm:
- 5:01 PM Changeset in webkit [39223] by
-
- 4 edits in trunk/WebKit/gtk
Make webkit_web_view_set_window_features internal
Calling this method will not result in a notify::window-features
signal being emitted. This would allow replacing a
WebKitWebWindowFeature on a WebKitWebView without anyone noticing
and the client code would monitor the wrong object.
- 4:37 PM Changeset in webkit [39222] by
-
- 3 edits in trunk
2008-12-11 Daniel Macks <dmacks@netspace.org>
Reviewed by Darin Adler.
Put libtool macro files in subdir that it wants.
- GNUmakefile.am:
- configure.ac:
- 4:37 PM Changeset in webkit [39221] by
-
- 2 edits in trunk/WebCore
2008-12-11 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Darin Adler.
Do not run into the WebCore::DocumentLoader::updateLoading
ASSERT on Gtk+/CURL when trying to load tests from our LayoutTests.
Do not call setPrimaryLoadComplete when the
activeDocumentLoader has already been replaced. This can happen
when a script executed from within FramerLoader::didFinishLoading will
navigate to another URL.
The assertion is caused by existing tests (e.g.
fast/history/clicked-link-is-visited.html) reproducing this with
network backends not equal to curl is tough or maybe not
even possible.
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::setPrimaryLoadComplete):
- 4:20 PM Changeset in webkit [39220] by
-
- 2 edits in trunk/WebKit/mac
2008-12-11 Stephanie Lewis <Stephanie Lewis>
Reviewed by Oliver Hunt.
Empty Web cache before quitting a debug build in order
to report accurate CachedResource leaks.
- WebView/WebView.mm: (-[WebView _close]):
- 3:42 PM Changeset in webkit [39219] by
-
- 6 edits in trunk/WebCore
Reviewed by Eric Seidel.
- Remove some dead, commented-out code from WMLAElement.
- Add missing virtual destructor for <noop>, as suggested by Alexey.
- Refactor addHTMLAlignment in a static helper function to share with WML.
- 2:33 PM Changeset in webkit [39218] by
-
- 3 edits2 adds in trunk
<rdar://problem/6302405> Crash (null-deref) when using :before pseudoselector with content CSS rule in SVG
<https://bugs.webkit.org/show_bug.cgi?id=22804>
Reviewed by Adele Peterson.
This issue was caused by css generated content resulting in non-svg flowboxes
being injected into SVG content. As SVG spec does not describe behaviour in
this case, and neither Opera nor Firefox displays such generated content, so
now we make svg text layout and rendering just ignore any such content.
Test: svg/css/crash-css-generated-content.xhtml
- 1:56 PM Changeset in webkit [39217] by
-
- 5 edits in trunk/WebCore
2008-12-11 Cameron Zwarich <zwarich@apple.com>
Reviewed by Dave Hyatt.
Bug 21256: REGRESSION (r36906): horizontally repeating image leaves ghosts when vertical scrolling
<https://bugs.webkit.org/show_bug.cgi?id=21256>
<rdar://problem/6362978>
The ScrollView refactoring in r36906 caused the ScrollView and the
platform widget to disagree about whether optimizing scrolling via
blitting is allowed. The easiest way to fix this is to make ScrollView
simply ask the platform widget whether this is safe on platforms that
are affected.
It is not possible to write a layout test for this bug because it
involves the back/forward cache.
- platform/ScrollView.cpp: (WebCore::ScrollView::ScrollView): (WebCore::ScrollView::setCanBlitOnScroll): (WebCore::ScrollView::canBlitOnScroll): (WebCore::ScrollView::platformSetCanBlitOnScroll): (WebCore::ScrollView::platformCanBlitOnScroll):
- platform/ScrollView.h:
- platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::platformSetCanBlitOnScroll): (WebCore::ScrollView::platformCanBlitOnScroll):
- platform/wx/ScrollViewWx.cpp: (WebCore::ScrollView::platformSetCanBlitOnScroll): (WebCore::ScrollView::platformCanBlitOnScroll):
- 1:27 PM Changeset in webkit [39216] by
-
- 2 edits in trunk/WebKit/mac
2008-12-11 Anders Carlsson <andersca@apple.com>
Fix Tiger build.
- Misc/WebNSDataExtras.h:
- 1:26 PM Changeset in webkit [39215] by
-
- 3 edits2 adds in trunk
WebKit/mac:
2008-12-11 Anders Carlsson <andersca@apple.com>
Reviewed by Cameron Zwarich.
https://bugs.webkit.org/show_bug.cgi?id=22797
REGRESSION: Crash at http://news.cnet.com/8301-17939_109-10119149-2.html
Make sure to protect the stream because destroyStream can otherwise cause it to be deleted.
- Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::destroyStreamWithReason):
LayoutTests:
2008-12-11 Anders Carlsson <andersca@apple.com>
Reviewed by Cameron Zwarich.
https://bugs.webkit.org/show_bug.cgi?id=22797
REGRESSION: Crash at http://news.cnet.com/8301-17939_109-10119149-2.html
- http/tests/plugins/get-url-expected.txt: Added.
- http/tests/plugins/get-url.html: Added.
- 12:44 PM Changeset in webkit [39214] by
-
- 3 edits in trunk/LayoutTests
Reviewed by Eric Seidel.
Fix typo in doctype (correct wapforum.org URL)
- 11:16 AM Changeset in webkit [39213] by
-
- 2 edits in trunk/WebCore
2008-12-11 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Adam Roben.
Correct build break due to malformed XML in Visual Studio project
following @r39205 change.
- WebCore.vcproj/WebCore.vcproj: Correct file entry so project loads.
- 11:10 AM Changeset in webkit [39212] by
-
- 16 edits6 adds in trunk
2008-12-10 Glenn Wilson <gwilson@google.com>
Reviewed by Adam Roben.
Added new methods for overriding default WebPreference values
and for resetting preferences to their defaults.
https://bugs.webkit.org/show_bug.cgi?id=20534
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm: (-[WebPreferences resetToDefaults]): new method (-[WebPreferences overridePreference:flag:]): new method
- WebView/WebPreferencesPrivate.h: new method signatures
2008-12-10 Glenn Wilson <gwilson@google.com>
Reviewed by Adam Roben.
Added support for overriding default preferences per-test.
https://bugs.webkit.org/show_bug.cgi?id=20534
Two new methods were added: resetToDefaults and overridePreference.
- Interfaces/IWebPreferencesPrivate.idl: new method signatures
- WebPreferenceKeysPrivate.h: added new key for internal state
- WebPreferences.cpp: added new methods (WebPreferences::overridePreference): new method (WebPreferences::resetToDefaults): new method
- WebPreferences.h: new method signatures
2008-12-10 Glenn Wilson <gwilson@google.com>
Reviewed by Adam Roben.
Changed LayoutTestController and DumpRenderTree to allow for manual
overriding of default preferences at test time. Also added support for
resetting the preferences after each test.
https://bugs.webkit.org/show_bug.cgi?id=20534
- DumpRenderTree/LayoutTestController.cpp: Added callback method for overriding preferences
- DumpRenderTree/LayoutTestController.h: Added signature for callback
- DumpRenderTree/win/DumpRenderTree.cpp: Added calls to reset preferences after each test if necessary
- DumpRenderTree/win/LayoutTestControllerWin.cpp: Added JS override function
- DumpRenderTree/mac/DumpRenderTree.mm: Added calls to reset preferences after each test if necessary
- DumpRenderTree/mac/LayoutTestControllerMac.mm: Added JS override function
- 8:24 AM Changeset in webkit [39211] by
-
- 11 edits in trunk/WebCore
Reviewed by Dave Hyatt.
This gets rid of the per-animation timers which were used when an animation
started, ended and looped. Their job is now done by the main AnimationController's
timer. It is now set to fire as needed. For instance, if there is a delay, it will
fire after the delay time and then every 30ms to run the animation. The start, loop
and end events are generated as needed during the firing of this timer.
I had to add one more bit of code. When animation timers used to fire the animation events.
This would always happen from the RunLoop, so any style changes that happened in the
event handler would get picked up on the next updateRendering() call. But now the start
event is generated during the styleIsAvailable() call, which is in the middle of the
updateRendering() cycle. And calling an event handler in the middle of updateRendering()
is not allowed and causes style changes to get missed. We already have a mechanism in
AnimationController to defer updateRendering() calls. So I added logic to defer all
event handling to there. Now, I put any request for event handling into a list and ask
for a deferred updateRendering() call. When that deferred timer fires, I go through that
list, send all the events and then call updateRendering().
- 7:57 AM Changeset in webkit [39210] by
-
- 7 edits in trunk/WebKit/qt
2008-12-11 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Simon Hausmann.
Allow applications to save and restore their state between loads.
- 7:45 AM Changeset in webkit [39209] by
-
- 2 edits in trunk/WebCore
2008-12-11 Simon Hausmann <simon.hausmann@nokia.com>
Fix the Qt build with an empty filenameExtension() implementation.
- 7:03 AM Changeset in webkit [39208] by
-
- 2 edits in trunk/WebCore
Fix crash in the cairo implementation of the SVGPaintServer
For SVGFonts the RenderObject can be zero. The existing SVGFont
test cases is exposing this bug. Qt and other ports have fixed
this issue by adding null checks as well.
- 6:46 AM Changeset in webkit [39207] by
-
- 13 edits1 copy2 adds in trunk/WebCore
2008-12-11 Holger Freyther <zecke@selfish.org>
Reviewed by Simon Hausmann.
Make the Qt port follow the Win, Mac, Gtk+ port in regard to Font
handling. FontQt.cpp from now on is only implementing the complex path. Create
FontFallbackListQt.cpp and FontPlatformDataQt.cpp to work within
the framework set by the Font code.
Sharing the Font.cpp implementation allows the Qt port to support
the CSS font faces and SVG fonts.
Split out the Qt4.3 Font handling into FonQt43.cpp to allow to more
easily deprecate it.
This commit is removing a lot of #ifdefs from Font.h as the Qt Font
implementation is now in line with the rest of WebCore.
- WebCore.pro:
- platform/graphics/Font.h: Remove #ifdefs (WebCore::Font::letterSpacing): (WebCore::Font::setLetterSpacing): (WebCore::Font::isPlatformFont):
- platform/graphics/FontFallbackList.h:
- platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::SimpleFontData): (WebCore::SimpleFontData::platformGlyphInit): There is no GlyphCache on Qt, move the initialisation over. (WebCore::SimpleFontData::~SimpleFontData):
- platform/graphics/SimpleFontData.h: (WebCore::SimpleFontData::getQtFont):
- platform/graphics/qt/FontCacheQt.cpp: (WebCore::FontCache::getCachedFontPlatformData): Remove unused parameter (WebCore::FontCache::releaseFontData): Add to build
- platform/graphics/qt/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::~FontCustomPlatformData): (WebCore::FontCustomPlatformData::fontPlatformData): (WebCore::createFontCustomPlatformData):
- platform/graphics/qt/FontCustomPlatformData.h:
- platform/graphics/qt/FontFallbackListQt.cpp: Added. (WebCore::FontFallbackList::FontFallbackList): (WebCore::FontFallbackList::invalidate): (WebCore::FontFallbackList::releaseFontData): (WebCore::FontFallbackList::determinePitch): (WebCore::FontFallbackList::fontDataAt): (WebCore::FontFallbackList::fontDataForCharacters): (WebCore::FontFallbackList::setPlatformFont):
- platform/graphics/qt/FontPlatformData.h: (WebCore::FontPlatformData::font): (WebCore::FontPlatformData::size):
- platform/graphics/qt/FontPlatformDataQt.cpp: Added. (WebCore::FontPlatformData::FontPlatformData):
- platform/graphics/qt/FontQt.cpp: (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText): (WebCore::Font::selectionRectForComplexText): (WebCore::Font::font):
- platform/graphics/qt/FontQt43.cpp: Added. Moved Qt4.3 code from FontQt.cpp (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText): (WebCore::Font::selectionRectForComplexText):
- platform/graphics/qt/GlyphPageTreeNodeQt.cpp: (WebCore::GlyphPageTreeNode::pruneTreeCustomFontData): (WebCore::GlyphPageTreeNode::pruneTreeFontData):
- platform/graphics/qt/SimpleFontDataQt.cpp: (WebCore::SimpleFontData::determinePitch): (WebCore::SimpleFontData::containsCharacters): (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::platformGlyphInit): (WebCore::SimpleFontData::platformDestroy):
- platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::adjustButtonStyle): Avoid crashes.
- 6:14 AM Changeset in webkit [39206] by
-
- 5 edits in trunk
WebCorv
2008-12-11 Holger Freyther <zecke@selfish.org>
Reviewed by Simon Hausmann.
For Qt it is not pratical to have a FontCache and GlyphPageTreeNode
implementation. This is one of the reasons why the Qt port is currently not
using WebCore/platform/graphics/Font.cpp. By allowing to not use
the simple/fast-path the Qt port will be able to use it.
Introduce USE(FONT_FAST_PATH) and define it for every port but the
Qt one.
- platform/graphics/Font.cpp: (WebCore::Font::drawText): (WebCore::Font::floatWidth): (WebCore::Font::selectionRectForText): (WebCore::Font::offsetForPosition):
- platform/graphics/Font.h:
JavaScriptCore
2008-12-11 Holger Freyther <zecke@selfish.org>
Reviewed by Simon Hausmann.
For Qt it is not pratical to have a FontCache and GlyphPageTreeNode
implementation. This is one of the reasons why the Qt port is currently not
using WebCore/platform/graphics/Font.cpp. By allowing to not use
the simple/fast-path the Qt port will be able to use it.
Introduce USE(FONT_FAST_PATH) and define it for every port but the
Qt one.
- wtf/Platform.h: Enable USE(FONT_FAST_PATH)
- 3:18 AM Changeset in webkit [39205] by
-
- 6 edits1 copy in trunk/WebCore
2008-12-11 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Darin Adler.
Split out the font fast path from Fast.cpp into FontFastPath.cpp. This
will allow the Qt port to share most of WebCore::Font
implementation but the fast path. Qt does not provide the API to get
individual Glyphs making the fast path hard to support.
- GNUmakefile.am:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- platform/graphics/Font.cpp:
- platform/graphics/FontFastPath.cpp: Added. (WebCore::Font::glyphDataForCharacter):
- 3:15 AM Changeset in webkit [39204] by
-
- 3 edits in trunk/JavaScriptCore
2008-12-04 Gabor Loki <loki@inf.u-szeged.hu>
Reviewed by Darin Adler and landed by Holger Freyther.
<https://bugs.webkit.org/show_bug.cgi?id=22648>
Fix threading on Qt-port and Gtk-port for Sampling tool.
- wtf/ThreadingGtk.cpp: (WTF::waitForThreadCompletion):
- wtf/ThreadingQt.cpp: (WTF::waitForThreadCompletion):
- 2:22 AM Changeset in webkit [39203] by
-
- 2 edits in trunk/WebCore
2008-12-11 Robert Carr <racarr@svn.gnome.org>
Reviewed by Holger Freyther.
Code in PlatformScreenGtk for screenDepth and screenRect can not
assume that the platformWindow for the widget has a valid "window"
member. For example in the case of, a new browser view opening as a
child of a GtkNotebook, but never being switched to, or manually
realized. Solve by using the toplevel window of the widget, rather
than the widget itself.
- platform/gtk/PlatformScreenGtk.cpp: (WebCore::screenDepth): (WebCore::screenRect):
- 2:20 AM Changeset in webkit [39202] by
-
- 6 edits in trunk/LayoutTests
2008-12-08 Dean McNamee <deanm@chromium.org>
Reviewed by Darin Adler.
Always append a trailing slash when using PHP's sys_get_temp_dir().
This allows these tests to run on Linux, where this API returns the
directory without a trailing slash.
- http/tests/xmlhttprequest/resources/access-control-basic-preflight-cache-invalidation.php:
- http/tests/xmlhttprequest/resources/access-control-basic-preflight-cache-timeout.php:
- http/tests/xmlhttprequest/resources/access-control-basic-preflight-cache.php:
- http/tests/xmlhttprequest/resources/portabilityLayer.php:
- http/tests/xmlhttprequest/resources/reset-temp-file.php:
- 2:09 AM Changeset in webkit [39201] by
-
- 13 edits in trunk
2008-12-08 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Darin Adler and Holger Freyther.
Make Widget::frameRectsChanged() and overrides non-const
This will hopefully allow us to get rid of some of the mutables in
the classes that react to the callback by changing their own state.
- 2:03 AM Changeset in webkit [39200] by
-
- 3 edits in trunk/WebCore
Reimplement RenderTheme::caretBlinkInterval for Qt.
The QApplication::cursorFlashTime is in milliseconds and describes
the whole cycle while WebCore expects half a cycle.
- 12:27 AM Changeset in webkit [39199] by
-
- 2 edits in trunk/WebCore
2008-12-09 Trenton Schulz <trenton.schulz@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt/Mac] Don't call HIGetScaleFactor() if we're not on Tiger or better
Dec 10, 2008:
- 10:27 PM Changeset in webkit [39198] by
-
- 3 edits in trunk/JavaScriptCore
2008-12-10 Cameron Zwarich <zwarich@apple.com>
Reviewed by Oliver Hunt.
Bug 22734: Debugger crashes when stepping into a function call in a return statement
<https://bugs.webkit.org/show_bug.cgi?id=22734>
<rdar://problem/6426796>
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): The DebuggerCallFrame uses the 'this' value stored in a callFrame, so op_convert_this should be emitted at the beginning of a function body when generating bytecode with debug hooks.
- debugger/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::thisObject): The assertion inherent in the call to asObject() here is valid, because any 'this' value should have been converted to a JSObject*.
- 8:35 PM Changeset in webkit [39197] by
-
- 5 edits in trunk/JavaScriptCore
2008-12-10 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Port more of the JIT to use the MacroAssembler interface.
Everything in the main pass, bar a few corner cases (operations with required
registers, or calling convention code). Slightly refactors array creation,
moving the offset calculation into the callFrame into C code (reducing code
planted).
Overall this appears to be a 1% win on v8-tests, due to the smaller immediates
being planted (in jfalse in particular).
- interpreter/Interpreter.cpp: (JSC::Interpreter::cti_op_new_array):
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
- jit/JIT.h:
- wrec/WRECGenerator.cpp: (JSC::WREC::Generator::generateEnter):
- 6:42 PM Changeset in webkit [39196] by
-
- 5 edits in trunk/LayoutTests
Rubber-stamped by George Staikos.
Update WML pixel test results, after adding <template> support.
- 6:41 PM Changeset in webkit [39195] by
-
- 3 edits in trunk/WebKit/mac
2008-12-10 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Implement support for NPN_PostURL/NPN_PostURLNotify in WebKit.
- Plugins/Hosted/NetscapePluginInstanceProxy.h: Add stopAllStreams.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::stopAllStreams): Factored out this from ::destroy.
(WebKit::NetscapePluginInstanceProxy::destroy):
Call stopAllStreams().
(WebKit::NetscapePluginInstanceProxy::pluginHostDied):
Ditto.
(WebKit::NetscapePluginInstanceProxy::loadURL):
Handle post being true. This code has been copied from WebNetscapePluginView.mm (for now).
- 6:34 PM Changeset in webkit [39194] by
-
- 18 edits2 adds in trunk
Reviewed by Eric Seidel and George Staikos.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=22799
Add WML <template> support. The <template> element is specified at deck-level
and declares a template for all <card> elements in the document.
- 6:14 PM Changeset in webkit [39193] by
-
- 2 edits in trunk/WebCore
2008-12-09 Dmitry Titov <dimich@chromium.org>
Reviewed by Darin Adler.
Fix memory leak - need to call stopActiveDOMObjects
when cached pages get destroyed.
https://bugs.webkit.org/show_bug.cgi?id=22753
- dom/Document.cpp: (WebCore::Document::detach):
- 5:55 PM Changeset in webkit [39192] by
-
- 2 edits in trunk/WebCore
2008-12-10 Simon Fraser <Simon Fraser>
Reviewed by Antti Koivisto
<rdar://problem/6431224>
When updating the value of a slider, don't mark the parents
as needing layout, because the size of the slider can never
change. This fixes full-page repaints in some cases.
- rendering/RenderSlider.cpp: (WebCore::RenderSlider::updateFromElement):
- 5:51 PM Changeset in webkit [39191] by
-
- 8 edits in trunk
WebKitTools:
2008-12-10 Brady Eidson <beidson@apple.com>
Reviewed by Darin
Implement the new policy delegate (including navigation type and permissive mode) for DRT/win
- DumpRenderTree/win/DumpRenderTree.cpp:
- DumpRenderTree/win/DumpRenderTreeWin.h:
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setCustomPolicyDelegate):
- DumpRenderTree/win/PolicyDelegate.cpp: (PolicyDelegate::PolicyDelegate): (PolicyDelegate::decidePolicyForNavigationAction):
- DumpRenderTree/win/PolicyDelegate.h: (PolicyDelegate::setPermissive):
LayoutTests:
2008-12-10 Brady Eidson <beidson@apple.com>
Reviewed by Darin
Most of these policy delegate related tests will now pass with accompanying DRT changes.
- platform/win/Skipped:
- 5:49 PM Changeset in webkit [39190] by
-
- 3 edits in trunk/LayoutTests
2008-12-10 Pierre-Olivier Latour <pol@apple.com>
Reviewed by Darin Adler.
Replaced outdated reference image for svg/webarchive/svg-cursor-subresources.svg
- platform/mac/svg/webarchive/svg-cursor-subresources-expected.checksum:
- platform/mac/svg/webarchive/svg-cursor-subresources-expected.png:
- 5:25 PM Changeset in webkit [39189] by
-
- 4 edits in trunk/WebKit/mac
2008-12-10 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Move two NSData category methods to WebNSDataExtras.m.
- Misc/WebNSDataExtras.h:
- Misc/WebNSDataExtras.m: (-[NSData _web_startsWithBlankLine]): (-[NSData _web_locationAfterFirstBlankLine]):
- Plugins/WebNetscapePluginView.mm:
- 5:01 PM Changeset in webkit [39188] by
-
- 1 edit in trunk/LayoutTests/platform/win/Skipped
Updated Radar bug reference.
- 4:48 PM Changeset in webkit [39187] by
-
- 39 edits in trunk/LayoutTests
2008-12-10 Pierre-Olivier Latour <pol@apple.com>
Reviewed by Darin Adler.
Rewrote animations/animation-test-helpers.js to take advantage of the pauseAnimationAtTimeOnElementWithId()
API when available in DRT.
Updated all animations tests that check for values of animated CSS properties to use these new helper functions.
- animations/animation-test-helpers.js: (isCloseEnough): (checkExpectedValue): (endTest): (startTest): (runAnimationTest):
- animations/big-rotation-expected.txt:
- animations/big-rotation.html:
- animations/change-keyframes-expected.txt:
- animations/change-keyframes-name-expected.txt:
- animations/change-keyframes-name.html:
- animations/change-keyframes.html:
- animations/change-one-anim-expected.txt:
- animations/change-one-anim.html:
- animations/generic-from-to-expected.txt:
- animations/generic-from-to.html:
- animations/import-expected.txt:
- animations/import.html:
- animations/keyframe-timing-functions-expected.txt:
- animations/keyframe-timing-functions.html:
- animations/keyframes-comma-separated-expected.txt:
- animations/keyframes-comma-separated.html:
- animations/keyframes-expected.txt:
- animations/keyframes-from-missing.html:
- animations/keyframes-out-of-order-expected.txt:
- animations/keyframes-out-of-order.html:
- animations/keyframes-to-missing.html:
- animations/keyframes.html:
- animations/lineheight-animation-expected.txt:
- animations/lineheight-animation.html:
- animations/matrix-anim-expected.txt:
- animations/matrix-anim.html:
- animations/multiple-animations-expected.txt:
- animations/multiple-animations.html:
- animations/multiple-keyframes-expected.txt:
- animations/multiple-keyframes.html:
- animations/transition-and-animation-1-expected.txt:
- animations/transition-and-animation-1.html:
- animations/transition-and-animation-2-expected.txt:
- animations/transition-and-animation-2.html:
- animations/width-using-ems-expected.txt:
- animations/width-using-ems.html:
- platform/win/Skipped:
- 4:00 PM Changeset in webkit [39186] by
-
- 6 edits2 adds in trunk
WebCore:
2008-12-10 Alice Liu <alice.liu@apple.com>
Manual test for https://bugs.webkit.org/show_bug.cgi?id=20685
Reviewed by Darin Adler.
- manual-tests/drag-image-to-desktop.html: Added.
LayoutTests:
2008-12-10 Alice Liu <alice.liu@apple.com>
Adding tweak to .conf files needed for
WebCore/manual-tests/drag-image-to-desktop.html
Reviewed by Darin Adler.
- http/conf/apache2-debian-httpd.conf:
- http/conf/apache2-httpd.conf:
- http/conf/cygwin-httpd.conf:
- http/conf/httpd.conf:
- http/tests/misc/resources/generatedimage.bat: Added.
- 3:57 PM Changeset in webkit [39185] by
-
- 17 edits3 adds in trunk
WebCore:
2008-12-10 Alice Liu <alice.liu@apple.com>
Reviewed by Darin Adler.
Manual test case is manual-tests/drag-image-to-desktop.html
Added new files to projects
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- page/DragController.cpp: (WebCore::DragController::startDrag):
- platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedImageMIMETypes): (WebCore::initializeSupportedImageMIMETypesForEncoding):
These changes add a method to obtain the extension for an image
- platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::filenameExtension):
- platform/graphics/BitmapImage.h:
- platform/graphics/Image.h: (WebCore::Image::filenameExtension):
- platform/graphics/ImageSource.h:
- platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::filenameExtension):
- platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::filenameExtension):
These changes added a utility that returns the preferred extension for a UTI
- platform/graphics/cg/ImageSourceCG.h: Added.
- platform/graphics/cg/ImageSourceCGMac.mm: Added. (WebCore::MIMETypeForImageSourceType): (WebCore::preferredExtensionForImageSourceType):
- platform/graphics/cg/ImageSourceCGWin.cpp: Added. (WebCore::MIMETypeForImageSourceType): (WebCore::preferredExtensionForImageSourceType):
- platform/mac/MIMETypeRegistryMac.mm: moved getMIMETypeForUTI to ImageSourceCGMac.mm
Ask image for its file extension instead of relying on MIME type and file path
- platform/win/ClipboardWin.cpp: (WebCore::createGlobalImageFileDescriptor):
Remove extraneous code from getPreferredExtensionForMIMEType.
Also moved getMIMETypeForUTI to ImageSourceCGWin.cpp
- platform/win/MIMETypeRegistryWin.cpp: (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
WebKit/mac:
2008-12-10 Alice Liu <alice.liu@apple.com>
Reviewed by Darin Adler.
- Misc/WebNSPasteboardExtras.mm: Ask image for its file extension instead of falling back on MIME type and file path. Also moved this code to before setting the pasteboard data so as not to set any if no extension can be determined. (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
- WebView/WebHTMLView.mm: Fixed a separate but related long-standing bug of how the filename for the promised drag data is determined by asking the image for a proper file extension. (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
- 1:33 PM Changeset in webkit [39184] by
-
- 2 edits in trunk/JavaScriptCore
2008-12-10 Sam Weinig <sam@webkit.org>
Fix non-JIT builds.
- bytecode/CodeBlock.h:
- 12:57 PM Changeset in webkit [39183] by
-
- 2 edits in trunk/WebCore
2008-12-10 Simon Fraser <Simon Fraser>
Potential build fix. The forward declaration of FloatPoint should
be inside the WebCore namespace.
- platform/graphics/FloatPoint3D.h:
- 12:05 PM Changeset in webkit [39182] by
-
- 5 edits in trunk/JavaScriptCore
2008-12-10 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
<rdar://problem/6428332> Remove the CTI return address table from CodeBlock
Step 2:
Convert the return address table from a HashMap to a sorted Vector. This
reduces the size of the data structure by ~4.5MB on Membuster head.
SunSpider reports a 0.5% progression.
- bytecode/CodeBlock.cpp: (JSC::sizeInBytes): Generic method to get the cost of a Vector. (JSC::CodeBlock::dumpStatistics): Add dumping of member sizes.
- bytecode/CodeBlock.h: (JSC::PC::PC): Struct representing NativePC -> VirtualPC mappings. (JSC::getNativePC): Helper for binary chop. (JSC::CodeBlock::getBytecodeIndex): Used to get the VirtualPC from a NativePC using a binary chop of the pcVector. (JSC::CodeBlock::pcVector): Accessor.
- interpreter/Interpreter.cpp: (JSC::vPCForPC): Use getBytecodeIndex instead of jitReturnAddressVPCMap().get(). (JSC::Interpreter::cti_op_instanceof): Ditto. (JSC::Interpreter::cti_op_resolve): Ditto. (JSC::Interpreter::cti_op_resolve_func): Ditto. (JSC::Interpreter::cti_op_resolve_skip): Ditto. (JSC::Interpreter::cti_op_resolve_with_base): Ditto. (JSC::Interpreter::cti_op_throw): Ditto. (JSC::Interpreter::cti_op_in): Ditto. (JSC::Interpreter::cti_vm_throw): Ditto.
- jit/JIT.cpp: (JSC::JIT::privateCompile): Reserve exact capacity and fill the pcVector.
- 12:03 PM Changeset in webkit [39181] by
-
- 3 edits in trunk/WebCore
2008-12-10 Simon Fraser <Simon Fraser>
Reviewed by Sam Weinig
Cleanup FloatPoint3D: inline the getters and setters,
fix a potential divide-by-zero in normalize(), and add
a FloatPoint constructor.
- 11:18 AM Changeset in webkit [39180] by
-
- 14 edits in trunk/WebCore
2008-12-10 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Eric Seidel.
Bug 22665: Remove setCreatedByParser(bool) from the few elements that use it
https://bugs.webkit.org/show_bug.cgi?id=22665
- Removed setCreatedByParser from style and link elements.
- Removed XMLTokenizer::eventuallyMarkAsCreatedByParser.
- dom/XMLTokenizer.cpp:
- dom/XMLTokenizer.h:
- dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::startElementNs):
- dom/XMLTokenizerQt.cpp: (WebCore::XMLTokenizer::parseStartElement):
- html/HTMLElementFactory.cpp: (WebCore::linkConstructor): (WebCore::styleConstructor):
- html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::HTMLLinkElement):
- html/HTMLLinkElement.h:
- html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::HTMLStyleElement):
- html/HTMLStyleElement.h:
- html/HTMLTagNames.in:
- svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::SVGStyleElement):
- svg/SVGStyleElement.h:
- svg/svgtags.in:
- 10:58 AM Changeset in webkit [39179] by
-
- 1 edit3 adds in trunk/LayoutTests
2008-12-10 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam :( Weinig.
Added a test for http://trac.webkit.org/changeset/39162.
- fast/regex/malformed-escapes-expected.txt: Added.
- fast/regex/malformed-escapes.html: Added.
- fast/regex/resources/malformed-escapes.js: Added.
- 10:37 AM Changeset in webkit [39178] by
-
- 31 edits4 adds in trunk
WebCore:
2008-12-10 Brady Eidson <beidson@apple.com>
Reviewed by Darin
https://bugs.webkit.org/show_bug.cgi?id=22194 and <rdar://problem/6388378> -
Dialog when going back to a page from whence you submitted a form
http://trac.webkit.org/changeset/37317 changed the manner in which headers are added to
http requests, which caused the networking layer to have an incomplete set of headers
just before consulting the Policy Delegate. This caused a cache miss and incorrectly made
us believe we'd be resubmitting the form.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadItem): Being careful to maintain the new behavior required by the Origin header mechanism as discussed in bug 22194, restore the previous behavior of setting all the headers before the networking layer is asked about the cache lookup.
WebKitTools:
2008-12-10 Brady Eidson <beidson@apple.com>
Reviewed by Darin
Change the custom policy delegate to actually allow navigation for tests that need it.
The new behavior is opt-in and doesn't require any changes in old tests.
- DumpRenderTree/LayoutTestController.cpp: (setCustomPolicyDelegateCallback): Allow for a second boolean argument to set the permissive flag on the custom policy delegate, which will be false by default to maintain original behavior.
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setCustomPolicyDelegate):
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setCustomPolicyDelegate): Partially stubbed out for now.
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setCustomPolicyDelegate): Still stubbed out, but with new param.
- DumpRenderTree/mac/PolicyDelegate.h:
- DumpRenderTree/mac/PolicyDelegate.mm: (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]): If the permissive flag is set, allow the navigation. (-[PolicyDelegate setPermissive:]): Change the behavior between "use" and "ignore" - allowing navigation or not.
LayoutTests:
2008-12-10 Brady Eidson <beidson@apple.com>
Reviewed by Darin
New layout tests for testing the fix for https://bugs.webkit.org/show_bug.cgi?id=22194:
- http/tests/navigation/post-goback-repost-policy-expected.txt: Added.
- http/tests/navigation/post-goback-repost-policy.html: Added.
- http/tests/navigation/resources/goback-with-policydelegate.html: Added.
- http/tests/navigation/resources/post-target-policy-test.html: Added.
Updated layout test results for the new "custom policy delegate" mechanism:
- fast/encoding/mailto-always-utf-8-expected.txt:
- fast/forms/mailto/advanced-get-expected.txt:
- fast/forms/mailto/advanced-put-expected.txt:
- fast/forms/mailto/get-multiple-items-expected.txt:
- fast/forms/mailto/get-multiple-items-text-plain-expected.txt:
- fast/forms/mailto/get-multiple-items-x-www-form-urlencoded-expected.txt:
- fast/forms/mailto/get-non-ascii-always-utf-8-expected.txt:
- fast/forms/mailto/get-non-ascii-expected.txt:
- fast/forms/mailto/get-non-ascii-text-plain-expected.txt:
- fast/forms/mailto/get-non-ascii-text-plain-latin-1-expected.txt:
- fast/forms/mailto/get-overwrite-query-expected.txt:
- fast/forms/mailto/post-append-query-expected.txt:
- fast/forms/mailto/post-multiple-items-expected.txt:
- fast/forms/mailto/post-multiple-items-multipart-form-data-expected.txt:
- fast/forms/mailto/post-multiple-items-text-plain-expected.txt:
- fast/forms/mailto/post-multiple-items-x-www-form-urlencoded-expected.txt:
- fast/forms/mailto/post-text-plain-expected.txt:
- fast/forms/mailto/post-text-plain-with-accept-charset-expected.txt:
- http/tests/security/feed-urls-from-remote-expected.txt:
Skip the new test on Windows until the policy delegate can be enhanced there:
- platform/win/Skipped: (It is already implicitly skipped for qt and gtk)
- 10:27 AM Changeset in webkit [39177] by
-
- 2 edits in trunk/WebCore
2008-12-10 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Timothy Hatcher.
Add back ability to end all profiling via console by invoking profileEnd
with no arguments.
- page/Console.cpp: (WebCore::Console::profileEnd): Removed title null-checking and
subsequent early exit.
- 10:00 AM Changeset in webkit [39176] by
-
- 4 edits4 adds in trunk
2008-12-10 Pierre-Olivier Latour <pol@apple.com>
Reviewed by Darin Adler.
KeyframeAnimation::animate() needs to compute the elapsed animation time
properly taking into account its paused state.
Test: animations/animation-drt-api-multiple-keyframes.html
- page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::animate):
- 9:18 AM Changeset in webkit [39175] by
-
- 6 edits in trunk/WebCore
2008-12-10 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein
Rename methods on RenderLayer for clarity:
clearClipRects -> clearClipRectsIncludingDescendants
clearClipRect -> clearClipRects
- 9:06 AM Changeset in webkit [39174] by
-
- 2 edits in trunk/WebCore
wx build fix after the script call stack/frame additions.
- 8:41 AM Changeset in webkit [39173] by
-
- 14 edits in trunk/WebKit/qt
2008-12-10 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Simon Hausmann.
API changes discussed with Simon Hausmann, Tor Arne
Vestbø, Ariya Hidayat...
- Api/qwebdatabase.cpp: (QWebDatabase::fileName): (QWebDatabase::removeDatabase):
- Api/qwebdatabase.h:
- Api/qwebframe.cpp: (QWebFrame::scroll): (QWebFrame::scrollPosition): (QWebFrame::setScrollPosition):
- Api/qwebframe.h:
- Api/qwebpage.cpp: (QWebPage::setContentEditable): (QWebPage::isContentEditable): (QWebPage::extension):
- Api/qwebpage.h:
- Api/qwebsecurityorigin.cpp:
- Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): (QWebSettings::QWebSettings):
- Api/qwebsettings.h:
- QtLauncher/main.cpp: (MainWindow::setEditable):
- WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::exceededDatabaseQuota): (WebCore::ChromeClientQt::runOpenPanel):
- WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::isEditable):
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::database):
- 8:35 AM Changeset in webkit [39172] by
-
- 2 edits in trunk/WebCore
2008-12-10 Srinivasa Rao M. Hamse <msrinirao@gmail.com>
Reviewed by Holger Freyther.
F1-F12 key mappings for WebKit Gtk Port
- platform/gtk/KeyEventGtk.cpp: (WebCore::windowsKeyCodeForKeyEvent):
- 8:06 AM Changeset in webkit [39171] by
-
- 2 edits in trunk/WebCore
2008-12-10 Enrico Ros <enrico.ros@m31.com>
Reviewed by Simon Hausmann.
Fix the Qt build when SVG is disabled. A broken dependancy caused
unnecessary rebuilds even with no changes.
- 7:59 AM Changeset in webkit [39170] by
-
- 2 edits in trunk/WebKit/qt
2008-12-09 Balazs Kelemen <Kelemen.Balazs.3@stud.u-szeged.hu>
Reviewed by Simon Hausmann.
Extended QtLauncher so now it can load pages from an url list
one by one. This can be useful for testing purposes (eq. leak hunting).
The -r option activates this feature.
- 4:49 AM Changeset in webkit [39169] by
-
- 3 edits6 adds in trunk
2008-12-10 Hironori Bono <hbono@chromium.org>
Reviewed by Alexey Proskuryakov.
Bug 21820: Unable to enter the Tamil UNICODE Characters via Thamizha Phonetic IME
https://bugs.webkit.org/show_bug.cgi?id=21820
<rdar://problem/5683248> Typing backspace to delete a diacritical mark also deletes the character before (Arabic)
<rdar://problem/5702038> Backspace removes Thai Character in wrong sequence
Tests: editing/deleting/delete-ligature-001.html
editing/deleting/delete-ligature-002.html
editing/deleting/delete-ligature-003.html
- editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): Delete only the last character of a ligature which consists of multiple Unicode characters when deleting it with a backspace key.
- 4:23 AM Changeset in webkit [39168] by
-
- 3 edits in trunk
2008-12-10 David Levin <levin@chromium.org>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=22177
Fix the windows build by removing calls to notifyFormStateChanged
where they didn't appear in the original reviewed patch.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::type): (WebCore::HTMLInputElement::attach):
- 1:10 AM Changeset in webkit [39167] by
-
- 2 edits in trunk/WebKit/qt
2008-12-10 Simon Hausmann <Simon Hausmann>
Fix the Qt build, added const to Node* parameter after change
in signature.
- 12:15 AM Changeset in webkit [39166] by
-
- 1 edit2 adds in trunk/LayoutTests
Rubber-stamped by Maciej Stachowiak.
<rdar://problem/5959165> Crash in a number of iExploder tests in WebCore::CachedImage::notifyObservers
Add a test for a crash that is no longer reproducible.
- fast/css/mask-missing-image-crash-expected.txt: Added.
- fast/css/mask-missing-image-crash.html: Added.
