⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 13, 2008:

11:55 PM Changeset in webkit [39288] by krit@webkit.org
  • 1 edit
    4 deletes in trunk/LayoutTests

2008-12-13 Dirk Schulze <​krit@webkit.org>

Reviewed by Oliver Hunt.

LayoutTest:

This test is wrong. We shouldn't fill something with a gradient, if the
path is empty.

  • fast/canvas/gradient-empty-path.html: Removed.
  • platform/mac/fast/canvas/gradient-empty-path-expected.checksum: Removed.
  • platform/mac/fast/canvas/gradient-empty-path-expected.png: Removed.
  • platform/mac/fast/canvas/gradient-empty-path-expected.txt: Removed.
11:19 PM Changeset in webkit [39287] by barraclough@apple.com
  • 4 edits in trunk/JavaScriptCore

2008-12-13 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Cameron Zwarich.

Re-enable WREC on 64-bit.
Implements one of the MacroAssembler::jnzPtr methods, previously only implemented for 32-bit x86.

​https://bugs.webkit.org/show_bug.cgi?id=22849

  • assembler/MacroAssembler.h: (JSC::MacroAssembler::testImm64): (JSC::MacroAssembler::jnzPtr):
  • assembler/X86Assembler.h: (JSC::X86Assembler::testq_i32r): (JSC::X86Assembler::testq_rr):
  • wtf/Platform.h:
5:28 PM Changeset in webkit [39286] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-12-13 Gavin Barraclough <​barraclough@apple.com>

Fix PPC builds.

  • assembler/MacroAssembler.h:
4:24 PM Changeset in webkit [39285] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-12-13 Gavin Barraclough <​barraclough@apple.com>

Build fix only, no review.

  • bytecode/CodeBlock.h:
3:58 PM Changeset in webkit [39284] by barraclough@apple.com
  • 11 edits in trunk/JavaScriptCore

2008-12-13 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Cameron Zwarich.

Port the remainder of the JIT, bar calling convention related code, and code
implementing optimizations which can be disabled, to use the MacroAssembler.

  • assembler/MacroAssembler.h: (JSC::MacroAssembler::DataLabelPtr::DataLabelPtr): (JSC::MacroAssembler::RepatchBuffer::RepatchBuffer): (JSC::MacroAssembler::RepatchBuffer::link): (JSC::MacroAssembler::RepatchBuffer::addressOf): (JSC::MacroAssembler::RepatchBuffer::setPtr): (JSC::MacroAssembler::addPtr): (JSC::MacroAssembler::lshift32): (JSC::MacroAssembler::mod32): (JSC::MacroAssembler::rshift32): (JSC::MacroAssembler::storePtrWithRepatch): (JSC::MacroAssembler::jnzPtr): (JSC::MacroAssembler::jzPtr): (JSC::MacroAssembler::jump): (JSC::MacroAssembler::label):
  • assembler/X86Assembler.h: (JSC::X86Assembler::): (JSC::X86Assembler::xchgl_rr): (JSC::X86Assembler::jmp_m): (JSC::X86Assembler::repatchAddress): (JSC::X86Assembler::getRelocatedAddress):
  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::CodeBlock):
  • bytecode/CodeBlock.h: (JSC::JITCodeRef::JITCodeRef): (JSC::CodeBlock::setJITCode): (JSC::CodeBlock::jitCode): (JSC::CodeBlock::executablePool):
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileLinkPass): (JSC::JIT::privateCompile): (JSC::JIT::privateCompileCTIMachineTrampolines):
  • jit/JIT.h: (JSC::CallRecord::CallRecord): (JSC::JumpTable::JumpTable): (JSC::JIT::emitCTICall): (JSC::JIT::JSRInfo::JSRInfo):
  • jit/JITArithmetic.cpp:
  • jit/JITCall.cpp:
  • jit/JITInlineMethods.h: (JSC::JIT::emitNakedCall): (JSC::JIT::emitCTICall_internal): (JSC::JIT::checkStructure): (JSC::JIT::emitFastArithDeTagImmediateJumpIfZero): (JSC::JIT::addSlowCase): (JSC::JIT::addJump): (JSC::JIT::emitJumpSlowToHot):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
3:28 PM Changeset in webkit [39283] by Darin Adler
  • 2 edits in trunk/WebCore

2008-12-13 Darin Adler <Darin Adler>

  • fix Release build
  • dom/Node.cpp: (WebCore::Node::rareData): Remove inappropriate inline directive.
3:17 PM Changeset in webkit [39282] by Darin Adler
  • 2 edits in trunk/WebKit/mac

2008-12-13 Darin Adler <Darin Adler>

  • <rdar://problem/6441035> WebTextIterator class not exported in WebKit
  • WebKit.exp: Added the class. We forgot to export it when we added the WebTextIterator SPI.
3:02 PM Changeset in webkit [39281] by Darin Adler
  • 4 edits
    2 adds in trunk

WebCore:

2008-12-13 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Test: fast/forms/textarea-selection-preservation.html

The regression reported was caused by the fact that the renderer code had
a bug where it would constantly think the newline at the end of text was
missing, and so it would replace all the text even though it wasn't changing,
which would destroy the selection.

When writing the regression test I discovered another problem: The value
property in HTMLTextAreaElement was intentionally changing the selection
to the end of the textarea, but doing that even when the value wasn't changing.

This patch fixes both and the test checks both.

  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::setValue): Exit early if the value is not changing.
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::text): Add a newline character for each <br> element encountered in the control

LayoutTests:

2008-12-13 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

  • fast/forms/textarea-selection-preservation-expected.txt: Added.
  • fast/forms/textarea-selection-preservation.html: Added.
2:58 PM Changeset in webkit [39280] by Darin Adler
  • 7 edits
    4 deletes in trunk/WebCore

2008-12-13 Darin Adler <Darin Adler>

  • GNUmakefile.am: Removed references to deleted files.
  • WebCore.pro: Ditto.
  • WebCore.scons: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • WebCoreSources.bkl: Ditto.
  • platform/DeprecatedPtrQueue.h: Removed.
  • platform/DeprecatedValueList.h: Removed.
  • platform/DeprecatedValueListImpl.cpp: Removed.
  • platform/DeprecatedValueListImpl.h: Removed.
2:53 PM Changeset in webkit [39279] by Darin Adler
  • 16 edits in trunk/WebCore

2008-12-13 Darin Adler <Darin Adler>

Reviewed by Anders Carlsson.

  • css/CSSStyleDeclaration.cpp: Removed unneeded include.
  • dom/Document.cpp: (WebCore::Document::removeAllEventListenersFromAllNodes): Set the removed flag on the window event listeners in case we are in the middle of dispatching events on this window. (WebCore::Document::clear): Ditto. (WebCore::Document::handleWindowEvent): Changed to use a vector instead of a DeprecatedPtrList. (WebCore::Document::windowInlineEventListenerForType): Ditto. (WebCore::Document::removeWindowInlineEventListenerForType): Ditto. Also added a call to setRemoved, which is needed here just as in other functions that remove. (WebCore::Document::removeWindowEventListener): Ditto. (WebCore::Document::hasWindowEventListener): Ditto.
  • dom/Document.h: Changed RegisteredEventListenerList to RegisteredEventListeners.
  • dom/Element.cpp: (WebCore::Element::attach): Use a function to access rare data instead of getting directly at the data field. (WebCore::Element::focus): Ditto. (WebCore::Element::cancelFocusAppearanceUpdate): Ditto.
  • dom/ElementRareData.h: Use "using" to make things that are protected in NodeRareData be public here.
  • dom/EventTarget.h: Removed include of DeprecatedValueList and related declearations that weren't needed. Tweaked the definitions of the forbidEventDispatch functions too.
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::EventTargetNode): Eliminated code that was used to initialized m_regdListeners. (WebCore::EventTargetNode::~EventTargetNode): Elminated delete of m_regdListeners. Changed code to use eventListeners() instead of m_regdListeners. (WebCore::EventTargetNode::eventListeners): Added. (WebCore::EventTargetNode::insertedIntoDocument): Use eventListeners. (WebCore::EventTargetNode::removedFromDocument): Ditto. (WebCore::EventTargetNode::willMoveToNewOwnerDocument): Ditto. (WebCore::EventTargetNode::didMoveToNewOwnerDocument): Ditto. (WebCore::EventTargetNode::addEventListener): Ditto. (WebCore::EventTargetNode::removeEventListener): Ditto. (WebCore::EventTargetNode::removeAllEventListeners): Ditto. Also added code to call setRemoved on all the listeners. (WebCore::EventTargetNode::handleLocalEvents): Ditto. (WebCore::EventTargetNode::dispatchGenericEvent): Fixed indentation. (WebCore::EventTargetNode::removeInlineEventListenerForType): Use the new event listeners vector. Also added missing call to setRemoved. (WebCore::EventTargetNode::inlineEventListenerForType): Ditto.
  • dom/EventTargetNode.h: Added a new RegisteredEventListenerVector type and replaced the old localEventListeners function with a new eventListeners function. Removed m_regdListeners.
  • dom/Node.cpp: (WebCore::Node::childNodes): Removed unneeded std prefix. (WebCore::Node::setFocus): Use function instead of going directly at rare data. (WebCore::Node::rareDataFocused): Ditto. (WebCore::Node::registerDynamicNodeList): Removed unneeded std prefix. (WebCore::Node::getElementsByName): Ditto. (WebCore::Node::getElementsByClassName): Ditto. (WebCore::Node::compareDocumentPosition): Ditto.
  • dom/Node.h: Removed unneeded forward declaration of RegisteredEventListener. This is now in EventTargetNode.
  • dom/NodeRareData.h: Renamed m_focused to m_isFocused and made it private. Made m_needsFocusAppearanceUpdateSoonAfterAttach private. Added listeners and ensureListeners functions as well as isFocused, setFocused, and focus-appearance functions. Made all data members private.
  • dom/RegisteredEventListener.cpp: Removed operator ==.
  • dom/RegisteredEventListener.h: Removed operator == and !=.
  • svg/SVGElement.cpp: (WebCore::hasLoadListener): Rewrote to work with the vector.
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::transferEventListenersToShadowTree): Ditto.
2:39 PM Changeset in webkit [39278] by zecke@webkit.org
  • 2 edits in trunk/WebKit/gtk

[GTK] Fix crash with LayoutTests/fast/loader/frame-creation-removal.html

Call WebCore::Frame::init after the frame has been given
a name and been added to the FrameTree of the parent.

Removing the call to init is fine as FrameLoaderClientGtk::createFrame
is the only user of webkit_web_frame_init_with_web_view and is already
calling WebCore::Frame::init.

1:45 PM Changeset in webkit [39277] by zecke@webkit.org
  • 12 edits in trunk

Change ENABLE(FONT_FAST_PATH) to USE(FONT_FAST_PATH) and
revert pixel test results back to the state as before r39254.

​https://bugs.webkit.org/show_bug.cgi?id=22824

12:45 PM Changeset in webkit [39276] by krit@webkit.org
  • 3 edits
    3 adds in trunk

2008-12-13 Dirk Schulze <​krit@webkit.org>

Reviewed by Darin Adler.

WebCore:

Fixes behavior of gradients on empty path in canvas/Cg

​https://bugs.webkit.org/show_bug.cgi?id=22844
[Cg] Canvas fill() draws gradients even without a path

Test: fast/canvas/canvas-gradient-without-path.html

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::fill): (WebCore::CanvasRenderingContext2D::stroke):

LayoutTest:

Checks behavior of gradients on an empty path in canvas.

  • fast/canvas/canvas-gradient-without-path-expected.txt: Added.
  • fast/canvas/canvas-gradient-without-path.html: Added.
  • fast/canvas/resources/canvas-gradient-without-path.js: Added.
10:38 AM Changeset in webkit [39275] by zecke@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-12-13 Adam Bergkvist <​adam.bergkvist@ericsson.com>

Reviewed by Holger Freyther.

​https://bugs.webkit.org/show_bug.cgi?id=22779

Check for GTK version >= 2.14.0 before using gtk_test_init.

  • tests/main.c: (main):
10:37 AM Changeset in webkit [39274] by zecke@webkit.org
  • 5 edits in trunk

WebKit/gtk
2008-12-13 Zan Dobersek <​zandobersek@gmail.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=22039

Implement animation and transition pausing as needed by DumpRenderTree.

  • webkit/webkitprivate.h:
  • webkit/webkitwebframe.cpp:

WebKitTools
2008-12-13 Zan Dobersek <​zandobersek@gmail.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=22039

Implement animation and transition pausing.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::pauseAnimationAtTimeOnElementWithId): (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
9:50 AM Changeset in webkit [39273] by kevino@webkit.org
  • 5 edits in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

Expose findString in wxWebView as FindString.

​https://bugs.webkit.org/show_bug.cgi?id=22458

9:38 AM Changeset in webkit [39272] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx build fix.

Dec 12, 2008:

10:58 PM Changeset in webkit [39271] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-12-12 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Sam Weinig.

Fix the failures of the following layout tests, which regressed in
r39255:

fast/dom/StyleSheet/ownerNode-lifetime-2.html
fast/xsl/transform-xhr-doc.xhtml

The binary search in CodeBlock::getByIdExceptionInfoForBytecodeOffset()
doesn't guarantee that it actually finds a match, so add an explicit check
for this.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::getByIdExceptionInfoForBytecodeOffset):
10:32 PM Changeset in webkit [39270] by pewtermoose@webkit.org
  • 5 edits in trunk

WebCore:

2008-12-12 Brent Fulgham <​bfulgham@gmail.com>

Reviewed by Oliver Hunt.

Fixes: ​https://bugs.webkit.org/show_bug.cgi?id=22805

Provides implementation of image dragging logic for Windows Cairo
back-end.

  • platform/win/DragImageCGWin.cpp: (WebCore::deallocContext): Add a generic CGContextRef destructor.
  • platform/win/DragImageCairoWin.cpp: (WebCore::deallocContext): Add a generic cairo_* destructor. (WebCore::allocImage): New implementation to allocate a Cairo surface of a specified size. (WebCore::createCairoContextFromBitmap): New implementation to create a Cairo surface from a Windows BITMAP. (WebCore::scaleDragImage): Replace stub with implementation to actually create a scaled image. (WebCore::createDragImageFromImage): Replace stub with implementation to actually create an image.

WebKit/win:

2008-12-12 Brent Fulgham <​bfulgham@gmail.com>

Reviewed by Oliver Hunt.

Fixes: ​https://bugs.webkit.org/show_bug.cgi?id=22805

Provides implementation of image drag for Windows Cairo back-end.
Switch to generic PlatformGraphicsContext data type, rather than
specific use of CoreGraphics types.

  • WebCoreSupport/WebDragClient.cpp: (WebDragClient::createDragImageForLink): Revise calls to use more generic PlatformGraphicsContext data types and calls for better portability.
10:06 PM Changeset in webkit [39269] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

Update Windows cache sizes to match recent Mac change.


Reviewed by Stephanie Lewis, Sam Weinig.

  • WebView.cpp: (WebView::setCacheModel):
9:25 PM Changeset in webkit [39268] by barraclough@apple.com
  • 7 edits in trunk/JavaScriptCore

2008-12-12 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Camron Zwarich.

Replace emitPutCallArg methods with emitPutJITStubArg methods. Primarily to make the argument numbering
more sensible (1-based incrementing by 1, rather than 0-based incrementing by 4). The CTI name also seems
to be being deprecated from the code generally.

  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases): (JSC::JIT::privateCompileCTIMachineTrampolines):
  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::compileBinaryArithOp): (JSC::JIT::compileBinaryArithOpSlowCase):
  • jit/JITCall.cpp: (JSC::JIT::compileOpCallSetupArgs): (JSC::JIT::compileOpCallEvalSetupArgs): (JSC::JIT::compileOpConstructSetupArgs): (JSC::JIT::compileOpCall):
  • jit/JITInlineMethods.h: (JSC::JIT::emitPutJITStubArg): (JSC::JIT::emitPutJITStubArgConstant): (JSC::JIT::emitGetJITStubArg): (JSC::JIT::emitPutJITStubArgFromVirtualRegister):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compilePutByIdHotPath): (JSC::JIT::compileGetByIdSlowCase): (JSC::JIT::compilePutByIdSlowCase):
8:16 PM Changeset in webkit [39267] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-12-12 Gavin Barraclough <​barraclough@apple.com>

Fix windows builds.

  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases): (JSC::JIT::privateCompile):
7:18 PM Changeset in webkit [39266] by barraclough@apple.com
  • 7 edits in trunk/JavaScriptCore

2008-12-12 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Geoff Garen.

Remove loop counter 'i' from the JIT generation passes, replace with a member m_bytecodeIndex.

No impact on performance.

  • jit/JIT.cpp: (JSC::JIT::compileOpStrictEq): (JSC::JIT::emitSlowScriptCheck): (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases): (JSC::JIT::privateCompile):
  • jit/JIT.h: (JSC::CallRecord::CallRecord): (JSC::JmpTable::JmpTable): (JSC::JIT::emitCTICall):
  • jit/JITArithmetic.cpp: (JSC::JIT::compileBinaryArithOp): (JSC::JIT::compileBinaryArithOpSlowCase):
  • jit/JITCall.cpp: (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase):
  • jit/JITInlineMethods.h: (JSC::JIT::emitGetVirtualRegister): (JSC::JIT::emitGetVirtualRegisters): (JSC::JIT::emitNakedCall): (JSC::JIT::emitCTICall_internal): (JSC::JIT::emitJumpSlowCaseIfJSCell): (JSC::JIT::emitJumpSlowCaseIfNotJSCell): (JSC::JIT::emitJumpSlowCaseIfNotImmNum): (JSC::JIT::emitJumpSlowCaseIfNotImmNums): (JSC::JIT::emitFastArithIntToImmOrSlowCase): (JSC::JIT::addSlowCase): (JSC::JIT::addJump): (JSC::JIT::emitJumpSlowToHot):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compileGetByIdSlowCase): (JSC::JIT::compilePutByIdHotPath): (JSC::JIT::compilePutByIdSlowCase):
7:03 PM Changeset in webkit [39265] by weinig@apple.com
  • 8 edits in trunk/JavaScriptCore

2008-12-12 Sam Weinig <​sam@webkit.org>

Reviewed by Cameron Zwarich.

<rdar://problem/6428342> Look into feasibility of discarding bytecode after native codegen

Move more JIT functionality to using offsets into the Instruction buffer
instead of raw pointers. Two to go!

  • interpreter/Interpreter.cpp: (JSC::bytecodeOffsetForPC): Rename from vPCForPC. (JSC::Interpreter::resolve): Pass offset to exception helper. (JSC::Interpreter::resolveSkip): Ditto. (JSC::Interpreter::resolveGlobal): Ditto. (JSC::Interpreter::resolveBaseAndProperty): Ditto. (JSC::Interpreter::resolveBaseAndFunc): Ditto. (JSC::isNotObject): Ditto. (JSC::Interpreter::unwindCallFrame): Call bytecodeOffsetForPC. (JSC::Interpreter::throwException): Use offsets instead of vPCs. (JSC::Interpreter::privateExecute): Pass offset to exception helper. (JSC::Interpreter::retrieveLastCaller): Ditto. (JSC::Interpreter::cti_op_instanceof): Ditto. (JSC::Interpreter::cti_op_call_NotJSFunction): Ditto. (JSC::Interpreter::cti_op_resolve): Pass offset to exception helper. (JSC::Interpreter::cti_op_construct_NotJSConstruct): Ditto. (JSC::Interpreter::cti_op_resolve_func): Ditto. (JSC::Interpreter::cti_op_resolve_skip): Ditto. (JSC::Interpreter::cti_op_resolve_global): Ditto. (JSC::Interpreter::cti_op_resolve_with_base): Ditto. (JSC::Interpreter::cti_op_throw): Ditto. (JSC::Interpreter::cti_op_in): Ditto. (JSC::Interpreter::cti_vm_throw): Ditto.
  • interpreter/Interpreter.h:
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): Don't pass unnecessary vPC to stub.
  • jit/JIT.h: Remove ARG_instr1 - ARG_instr3 and ARG_instr5 - ARG_instr6.
  • jit/JITCall.cpp: (JSC::JIT::compileOpCallEvalSetupArgs): Don't pass unnecessary vPC to stub.. (JSC::JIT::compileOpConstructSetupArgs): Ditto.
  • runtime/ExceptionHelpers.cpp: (JSC::createUndefinedVariableError): Take an offset instead of vPC. (JSC::createInvalidParamError): Ditto. (JSC::createNotAConstructorError): Ditto. (JSC::createNotAFunctionError): Ditto. (JSC::createNotAnObjectError): Ditto.
  • runtime/ExceptionHelpers.h:
6:30 PM Changeset in webkit [39264] by dino@apple.com
  • 13 edits in trunk

2008-12-12 Dean Jackson <​dino@apple.com>

Reviewed by Darin Adler.

Expose WebKitAnimationEvent, WebKitTransitionEvent,
WebKitCSSTransformValue, WebKitCSSKeyframeRule and
WebKitCSSKeyframesRule to Window object.
This required generating constructors for the event
interfaces.

​https://bugs.webkit.org/show_bug.cgi?id=20560

WebCore:

  • dom/WebKitAnimationEvent.idl:
  • dom/WebKitTransitionEvent.idl:
  • page/DOMWindow.idl:

LayoutTests:

  • animations/keyframes-rule-expected.txt:
  • animations/keyframes-rule.html:
  • fast/dom/Window/window-properties-expected.txt:
  • fast/events/event-instanceof-expected.txt:
  • fast/events/resources/event-instanceof.js:
  • fast/js/global-constructors-expected.txt:
  • transforms/transform-value-types-expected.txt:
  • transforms/transform-value-types.html:
5:47 PM Changeset in webkit [39263] by cwzwarich@webkit.org
  • 3 edits
    3 adds in trunk

2008-12-12 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Oliver Hunt.

Bug 22835: Crash during bytecode generation when comparing to null
<​https://bugs.webkit.org/show_bug.cgi?id=22835>
<rdar://problem/6286749>

Change the special cases in bytecode generation for comparison to null
to use tempDestination().

JavaScriptCore:

  • parser/Nodes.cpp: (JSC::BinaryOpNode::emitBytecode): (JSC::EqualNode::emitBytecode):

LayoutTests:

  • fast/js/ignored-result-null-comparison-crash-expected.txt: Added.
  • fast/js/ignored-result-null-comparison-crash.html: Added.
  • fast/js/resources/ignored-result-null-comparison-crash.js: Added.
5:41 PM Changeset in webkit [39262] by Darin Adler
  • 2 edits
    1 add
    2 deletes in trunk/WebKit/mac

2008-12-12 Darin Adler <Darin Adler>

Rubber stamped by Adam Roben.

  • fix <rdar://problem/5648301> Can't tab around to text fields in Safari login sheet after clicking static text, due to AppKit key loop change
  • Panels/English.lproj/WebAuthenticationPanel.nib/classes.nib: Removed.
  • Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib: Added.
  • Panels/English.lproj/WebAuthenticationPanel.nib/info.nib: Removed.
  • Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib: Set nextKeyView of the selectable static texts to the editable text. Updated nib format.
5:39 PM Changeset in webkit [39261] by barraclough@apple.com
  • 8 edits in trunk/JavaScriptCore

2008-12-12 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Geoff Garen.

Move slow-cases of JIT code generation over to the MacroAssembler interface.

  • assembler/MacroAssembler.h: (JSC::MacroAssembler::Label::Label): (JSC::MacroAssembler::jae32): (JSC::MacroAssembler::jg32): (JSC::MacroAssembler::jzPtr):
  • jit/JIT.cpp: (JSC::JIT::privateCompileSlowCases): (JSC::JIT::privateCompile): (JSC::JIT::emitGetVariableObjectRegister): (JSC::JIT::emitPutVariableObjectRegister):
  • jit/JIT.h: (JSC::SlowCaseEntry::SlowCaseEntry): (JSC::JIT::getSlowCase): (JSC::JIT::linkSlowCase):
  • jit/JITArithmetic.cpp: (JSC::JIT::compileBinaryArithOpSlowCase):
  • jit/JITCall.cpp: (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase):
  • jit/JITInlineMethods.h: (JSC::JIT::emitJumpSlowCaseIfNotJSCell): (JSC::JIT::linkSlowCaseIfNotJSCell):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compilePutByIdHotPath): (JSC::JIT::compileGetByIdSlowCase): (JSC::JIT::compilePutByIdSlowCase):
5:20 PM Changeset in webkit [39260] by eric@webkit.org
  • 2 edits in trunk/WebCore

2008-12-12 Dave Moore <​davemoore@google.com>

Reviewed by Eric Seidel.

Fixed ​https://bugs.webkit.org/show_bug.cgi?id=22798

In Font::drawTextUsingSVGFont() a variable of type SVGTextRunWalkerDrawTextData
is created on the stack (called data). One of its fields, charsConsumed, is
unitialized, leading to random values after calling walk() on the
SVGTextRunWalker created with it. I now initialize the variable

This bug was revealed in our Purify run. I don't know of any specific incorrect
behavior caused by it but it would lead to the charsConsumed field having a
a wrong value.

  • svg/SVGFont.cpp: (WebCore::Font::drawTextUsingSVGFont):
4:25 PM Changeset in webkit [39259] by Stephanie Lewis
  • 2 edits in trunk/WebKit/mac

2008-12-12 Stephanie Lewis <Stephanie Lewis>

Reviewed by Geoff Garen.

Shrink Cache Sizes.

  • WebView/WebView.mm: (+[WebView _setCacheModel:]):
4:11 PM Changeset in webkit [39258] by Beth Dakin
  • 2 edits in trunk/WebCore

2008-12-12 Beth Dakin <Beth Dakin>

Rubber Stamped by Steve Falkenburg.

Build fix.

  • platform/KURL.h:
4:01 PM Changeset in webkit [39257] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2008-12-12 Anders Carlsson <​andersca@apple.com>

Reviewed by Tim Hatcher.

Don't try to free the dummy "1" port state.


  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView sendEvent:isDrawRect:]): (-[WebNetscapePluginView updateAndSetWindow]):
4:00 PM Changeset in webkit [39256] by andersca@apple.com
  • 3 edits in trunk/WebKitExamplePlugins

2008-12-12 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler.

There's no need to hold on to the QCComposition. Also, toggle between a gold and silver compass
when a mouse button is pressed.


  • NetscapeCoreAnimationPlugin/Composition.qtz:
  • NetscapeCoreAnimationPlugin/main.m: (NPP_Destroy): (handleMouseClick): (NPP_GetValue):
2:48 PM Changeset in webkit [39255] by cwzwarich@webkit.org
  • 7 edits in trunk/JavaScriptCore

2008-12-12 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Sam Weinig.

Bug 22828: Do not inspect bytecode instruction stream for op_get_by_id exception information
<​https://bugs.webkit.org/show_bug.cgi?id=22828>

In order to remove the bytecode instruction stream after generating
native code, all inspection of bytecode instructions at runtime must
be removed. One particular instance of this is the special handling of
exceptions thrown by the op_get_by_id emitted directly before an
op_construct or an op_instanceof. This patch moves that information to
an auxiliary data structure in CodeBlock.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::getByIdExceptionInfoForBytecodeOffset):
  • bytecode/CodeBlock.h: (JSC::CodeBlock::addGetByIdExceptionInfo):
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitConstruct):
  • bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::emitGetByIdExceptionInfo):
  • parser/Nodes.cpp: (JSC::InstanceOfNode::emitBytecode):
  • runtime/ExceptionHelpers.cpp: (JSC::createNotAnObjectError):
2:33 PM Changeset in webkit [39254] by pol@apple.com
  • 10 edits in trunk/LayoutTests

2008-12-12 Pierre-Olivier Latour <​pol@apple.com>

Checked-in new results for failing SVG tests so that the bots are green again.

​https://bugs.webkit.org/show_bug.cgi?id=22824

  • platform/mac/svg/W3C-SVG-1.1/text-tselect-02-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/text-tselect-02-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt:
  • platform/mac/svg/custom/image-small-width-height-expected.checksum:
  • platform/mac/svg/custom/image-small-width-height-expected.png:
  • platform/mac/svg/custom/image-small-width-height-expected.txt:
  • platform/mac/svg/text/text-tselect-02-f-expected.checksum:
  • platform/mac/svg/text/text-tselect-02-f-expected.png:
  • platform/mac/svg/text/text-tselect-02-f-expected.txt:
2:22 PM Changeset in webkit [39253] by brettw@chromium.org
  • 3 edits in trunk/WebCore

Reviewed by Darin Adler.

Add the ability so that Google-URL can optionally be used in a build
of WebKit without changing the shared header. The guts of KURL are
optionally ifdefed out, and the replacement code goes in a different
header to avoid polluting KURL.h

  • platform/KURL.cpp:
  • platform/KURL.h:

(WebCore::KURL::string):
(WebCore::KURL::operator const String&):
(WebCore::KURL::operator JSC::UString):
(WebCore::KURL::operator NSString*):
(WebCore::KURL::parsed):
(WebCore::KURL::utf8String):
(WebCore::KURL::isNull):
(WebCore::KURL::isEmpty):
(WebCore::KURL::isValid):
(WebCore::KURL::hostStart):
(WebCore::KURL::hostEnd):
(WebCore::KURL::pathStart):
(WebCore::KURL::pathEnd):
(WebCore::KURL::pathAfterLastSlash):

1:31 PM Changeset in webkit [39252] by weinig@apple.com
  • 7 edits in trunk/JavaScriptCore

2008-12-12 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Change exception information accessors to take offsets into the bytecode
instruction buffer instead of pointers so that they can work even even
if the bytecode buffer is purged.

  • bytecode/CodeBlock.cpp: (JSC::instructionOffsetForNth): (JSC::CodeBlock::handlerForBytecodeOffset): (JSC::CodeBlock::lineNumberForBytecodeOffset): (JSC::CodeBlock::expressionRangeForBytecodeOffset):
  • bytecode/CodeBlock.h:
  • bytecode/SamplingTool.cpp: (JSC::SamplingTool::dump):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::throwException): (JSC::Interpreter::privateExecute): (JSC::Interpreter::retrieveLastCaller):
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
  • runtime/ExceptionHelpers.cpp: (JSC::createUndefinedVariableError): (JSC::createInvalidParamError): (JSC::createNotAConstructorError): (JSC::createNotAFunctionError): (JSC::createNotAnObjectError):
12:44 PM Changeset in webkit [39251] by Simon Hausmann
  • 2 edits in trunk/LayoutTests

2008-12-12 Simon Hausmann <Simon Hausmann>

Rubber-stamped by Holger Freyther.

Added all the failing tests in the Qt build that require font metrics
to the skipped list, as discussed. We cannot maintain the metrics
currently.

12:35 PM Changeset in webkit [39250] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-12-12 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Cameron Zwarich.


Tiny bit of refactoring in quantifier generation.

  • wrec/WRECGenerator.cpp: (JSC::WREC::Generator::generateNonGreedyQuantifier): (JSC::WREC::Generator::generateGreedyQuantifier):
12:31 PM Changeset in webkit [39249] by andersca@apple.com
  • 3 edits in trunk/WebKitExamplePlugins

2008-12-12 Anders Carlsson <​andersca@apple.com>

Revert some accidentally committed changes.


  • NetscapeCocoaPlugin/NetscapeCocoaPlugin.xcodeproj/project.pbxproj:
  • NetscapeCocoaPlugin/main.m: (handleDraw): (handleMouseEvent): (NPP_HandleEvent):
12:29 PM Changeset in webkit [39248] by andersca@apple.com
  • 3 edits
    9 adds in trunk/WebKitExamplePlugins

2008-12-12 Anders Carlsson <​andersca@apple.com>

Reviewed by Kevin Decker.

Add a sample Core Animation NPAPI plug-in.


  • NetscapeCocoaPlugin/NetscapeCocoaPlugin.xcodeproj/project.pbxproj:
  • NetscapeCocoaPlugin/main.m: (handleDraw): (handleMouseEvent): (NPP_HandleEvent):
  • NetscapeCoreAnimationPlugin: Added.
  • NetscapeCoreAnimationPlugin/Composition.qtz: Added.
  • NetscapeCoreAnimationPlugin/English.lproj: Added.
  • NetscapeCoreAnimationPlugin/English.lproj/InfoPlist.strings: Added.
  • NetscapeCoreAnimationPlugin/Info.plist: Added.
  • NetscapeCoreAnimationPlugin/NetscapeCoreAnimationPlugin.xcodeproj: Added.
  • NetscapeCoreAnimationPlugin/NetscapeCoreAnimationPlugin.xcodeproj/project.pbxproj: Added.
  • NetscapeCoreAnimationPlugin/main.m: Added. (NP_Initialize): (NP_GetEntryPoints): (NP_Shutdown): (NPP_New): (NPP_Destroy): (NPP_SetWindow): (NPP_NewStream): (NPP_DestroyStream): (NPP_WriteReady): (NPP_Write): (NPP_StreamAsFile): (NPP_Print): (handleMouseClick): (NPP_HandleEvent): (NPP_URLNotify): (NPP_GetValue): (NPP_SetValue):
  • NetscapeCoreAnimationPlugin/test.html: Added.
10:10 AM Changeset in webkit [39247] by sfalken@apple.com
  • 2 edits in trunk/WebCore

Delete the previous timer-queue timer in the main thread, just prior to scheduling a new timer.
The code previously called DeleteTimerQueueTimer in the timer callback proc.


The new technique simplifies the code, since we now create and delete timers on the
same thread, and don't access the timer queue or timer handles in the callback.
This allows us to remove some mutex use, and more importantly, it solves a race
condition that was occuring between ChangeTimerQueueTimer and DeleteTimerQueueTimer.


Since the timer callback isn't passed the timer handle, we were retrieving that handle
via a global. If the timer callback code was entered, but then a new timer was immediately
scheduled (prior to the callback acquiring the mutex and calling DeleteTimerQueueTimer),
there was a small window where the timer could be re-scheduled via ChangeTimerQueueTimer
and then immediately deleted once the already running callback acquired the mutex and
then called DeleteTimerQueueTimer. This resulted in the newly scheduled timer never firing.


Reviewed by Oliver Hunt.

  • platform/win/SharedTimerWin.cpp: (WebCore::queueTimerProc): Don't delete the timer in the callback. (WebCore::setSharedTimerFireTime): Always delete and create the timer instead of using ChangeTimerQueueTimer. (WebCore::stopSharedTimer): Call DeleteTimerQueueTimer directly.
10:06 AM Changeset in webkit [39246] by Darin Adler
  • 6 edits in trunk/WebCore

2008-12-12 Kai Brüning <​kai@granus.net>

Reviewed and tweaked by Darin Adler.

Fixes resurrection bug for wrapper objects by using an NSMapTable with zeroing weak
memory for the wrapper reference for DOMWrapperCache (DOMInternal.mm),
JSWrapperCache (WebScriptObject.mm) and wrapperCache (DOMRGBColor.mm).
BUILDING_ON_TIGER is used to create a Leopard-only NSMapTable or an old-style
procedural map table for Tiger systems.

No regression tests yet since we don't currently run any tests in GC mode.

  • bindings/objc/DOMInternal.h: added WebCore::createWrapperCache for use by all three caches
  • bindings/objc/DOMInternal.mm: (WebCore::createWrapperCache): Contains the compile-time check for map table creation (WebCore::getDOMWrapper): HashMap -> NSMapTable (WebCore::addDOMWrapper): ditto (WebCore::removeDOMWrapper): ditto
  • bindings/objc/DOMObject.mm: removed [DOMObject finalize]
  • bindings/objc/DOMRGBColor.mm: removed [DOMRGBColor finalize] (WebCore::getWrapperForRGB): CFMutableDictionaryRef -> NSMapTable (WebCore::setWrapperForRGB): ditto (WebCore::removeWrapperForRGB): ditto
  • bindings/objc/WebScriptObject.mm: (WebCore::getJSWrapper): HashMap -> NSMapTable (WebCore::addJSWrapper): ditto (WebCore::removeJSWrapper): ditto (-[WebScriptObject finalize]): removed call of removeJSWrapper()
9:42 AM Changeset in webkit [39245] by zecke@webkit.org
  • 2 edits in trunk/WebKitTools

2008-12-12 Brent Fulgham <​bfulgham@gmail.com>

Reviewed by Adam Roben.

​https://bugs.webkit.org/show_bug.cgi?id=22809

Increase timeout in call to initWithURL so that people actually see
new web pages when they type URLs rather than a blank screen.

  • WinLauncher/WinLauncher.cpp: (loadURL): Increase timeout in initWithURL from 0 to 60 seconds.
9:30 AM Changeset in webkit [39244] by Darin Adler
  • 2 edits in trunk/WebKitTools

2008-12-12 Darin Adler <Darin Adler>

  • Scripts/do-webcore-rename: Add a renaming idea.
8:10 AM Changeset in webkit [39243] by darin@chromium.org
  • 3 edits in trunk/WebCore

2008-12-12 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=22813
Remove unused references to JSDOMBinding, CallFrame, and JSLock.

  • dom/Node.cpp: Removed CallFrame and JSLock header includes.
  • loader/FrameLoader.cpp: Removed JSDOMBinding header include.
8:09 AM Changeset in webkit [39242] by zecke@webkit.org
  • 3 edits
    1 add in trunk

Update the WebKit.qrc and add a script to automatically generate the file.

With the way rcc and qmake work this can not be done at build time
as the WebKit.qrc must sit inside the directory that contains the files
and at build time we may not change the content of the source directory.

8:08 AM Changeset in webkit [39241] by zecke@webkit.org
  • 3 edits in trunk

Back out r39222 as this is breaking the build on Gentoo (aclocal-1.10)

The m4 directory does not exist and we now have a compile issue on
Gentoo systems.

6:11 AM Changeset in webkit [39240] by oliver@apple.com
  • 2 edits in trunk/WebCore

REGRESSION: Canvas is broken in high dpi mode
<rdar://problem/6432739> <​https://bugs.webkit.org/show_bug.cgi?id=22823>

Reviewed by Alexey Proskuryakov.

Simply made sure that we correctly scale the graphics context to
account for the difference between logical and buffer resolution.

5:49 AM Changeset in webkit [39239] by Simon Hausmann
  • 4 edits in trunk/WebKit/qt

2008-12-12 Simon Hausmann <Simon Hausmann>

Reviewed by Tor Arne Vestbø.

Fix pressing return/enter not triggering any action on web sites
that define event handlers, such as the JS console in the web
inspector.

Process the key events in the DOM first and if not handled map them
to editor actions.

5:18 AM Changeset in webkit [39238] by vestbo@webkit.org
  • 6 edits in trunk/WebCore

2008-12-12 Tor Arne Vestbø <​tavestbo@trolltech.com>

Rubber-stamped by Oliver Hunt.

Share PluginView::paintMissingPluginIcon() between ports

Also, enable this feature for Qt/X11, Qt/Mac and GTK

5:16 AM Changeset in webkit [39237] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2008-12-12 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon Hausmann.

[Qt/Mac] Implement PluginView::updatePluginWidget()

We should update the window and clip rect regardless of whether or
not the plugin has been loaded, for example to ensure that the
missing plugin image is placed correctly.

5:15 AM Changeset in webkit [39236] by vestbo@webkit.org
  • 8 edits in trunk/WebCore

2008-12-12 Tor Arne Vestbø <​tavestbo@trolltech.com>

Rubber-stamped by Oliver Hunt.

Make PluginView::updatePluginWidget() non-const

We can do this now since frameRectsChanged() is no longer const. This
also allows us to get rid of the mutables in the PluginView.

5:09 AM Changeset in webkit [39235] by vestbo@webkit.org
  • 2 edits in trunk/WebKit/win

2008-12-12 Tor Arne Vestbø <​tavestbo@trolltech.com>

Rubber-stamped by Oliver Hunt.

Remove mutables from EmbeddedWidget

We can do this now that frameRectsChanged() is no longer const

3:35 AM Changeset in webkit [39234] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

2008-12-12 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Reviewed by Simon Hausmann.

Create the plugin widget even though the web page has no associated
view. This prevents the plugin to be uselessly constructed more than once.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createPlugin):
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::createViewlessPlugin):
2:54 AM Changeset in webkit [39233] by vestbo@webkit.org
  • 4 edits in trunk/WebCore

2008-12-12 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon Hausmann.

Implement ImageSource::filenameExtension() for the Qt port

We're using QImageReader::imageFormat().toLower() to check
that the image format is supported, and if it is we store
the resulting extension when creating the ImageDecoderQt.

1:42 AM Changeset in webkit [39232] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

2008-12-11 Enrico Ros <​enrico.ros@m31.com>

Reviewed by Simon Hausmann.

Fix the broken focus behavior that happened when QWebPage lost
focus to a popup menu.

The previous code didn't notify the QWebPage at all when the
focus was back in (breaking focus rects, caret blinking, ...).
By the way when a popup is show, 2 FocusOut events are delivered
to the QWebPage, but this doesn't seem to hurt.

Added a test to check popup opening, closing a lineedit blinks.

12:22 AM Changeset in webkit [39231] by vestbo@webkit.org
  • 3 edits in trunk/WebKit/qt

2008-12-11 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Reviewed by Tor Arne Vestbø.

When the web page is navigated away, delete the instance
of the native plugin.

​http://trolltech.com/developer/task-tracker/index_html?id=214946&method=entry

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::):
  • tests/qwebpage/tst_qwebpage.cpp: (PluginTrackedPage::PluginTrackedPage): (PluginTrackedPage::createPlugin): (tst_QWebPage::destroyPlugin):
12:03 AM Changeset in webkit [39230] by weinig@apple.com
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Fix typo

12:02 AM Changeset in webkit [39229] by weinig@apple.com
  • 15 edits
    2 copies in trunk/JavaScriptCore

2008-12-11 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Remove dependancy on having the Instruction buffer in order to
deref Structures used for property access and global resolves.
Instead, we put references to the necessary Structures in axillary
data structures on the CodeBlock. This is not an ideal solution,
as we still pay for having the Structures in two places and we
would like to eventually just hold on to offsets into the machine
code buffer.

  • Also removes CodeBlock bloat in non-JIT by #ifdefing the JIT only data structures.
  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.scons:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • bytecode/CodeBlock.cpp: (JSC::isGlobalResolve): (JSC::isPropertyAccess): (JSC::instructionOffsetForNth): (JSC::printGlobalResolveInfo): (JSC::printStructureStubInfo): (JSC::CodeBlock::printStructures): (JSC::CodeBlock::dump): (JSC::CodeBlock::~CodeBlock): (JSC::CodeBlock::shrinkToFit):
  • bytecode/CodeBlock.h: (JSC::GlobalResolveInfo::GlobalResolveInfo): (JSC::getNativePC): (JSC::CodeBlock::instructions): (JSC::CodeBlock::getStubInfo): (JSC::CodeBlock::getBytecodeIndex): (JSC::CodeBlock::addPropertyAccessInstruction): (JSC::CodeBlock::addGlobalResolveInstruction): (JSC::CodeBlock::numberOfStructureStubInfos): (JSC::CodeBlock::addStructureStubInfo): (JSC::CodeBlock::structureStubInfo): (JSC::CodeBlock::addGlobalResolveInfo): (JSC::CodeBlock::globalResolveInfo): (JSC::CodeBlock::numberOfCallLinkInfos): (JSC::CodeBlock::addCallLinkInfo): (JSC::CodeBlock::callLinkInfo):
  • bytecode/Instruction.h: (JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set): (JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):
  • bytecode/Opcode.h: (JSC::):
  • bytecode/StructureStubInfo.cpp: Copied from bytecode/CodeBlock.cpp. (JSC::StructureStubInfo::deref):
  • bytecode/StructureStubInfo.h: Copied from bytecode/CodeBlock.h. (JSC::StructureStubInfo::StructureStubInfo): (JSC::StructureStubInfo::initGetByIdSelf): (JSC::StructureStubInfo::initGetByIdProto): (JSC::StructureStubInfo::initGetByIdChain): (JSC::StructureStubInfo::initGetByIdSelfList): (JSC::StructureStubInfo::initGetByIdProtoList): (JSC::StructureStubInfo::initPutByIdTransition): (JSC::StructureStubInfo::initPutByIdReplace): (JSC::StructureStubInfo::):
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitResolve): (JSC::BytecodeGenerator::emitGetById): (JSC::BytecodeGenerator::emitPutById): (JSC::BytecodeGenerator::emitCall): (JSC::BytecodeGenerator::emitConstruct): (JSC::BytecodeGenerator::emitCatch):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::tryCTICachePutByID): (JSC::Interpreter::tryCTICacheGetByID): (JSC::Interpreter::cti_op_get_by_id_self_fail): (JSC::getPolymorphicAccessStructureListSlot): (JSC::Interpreter::cti_op_get_by_id_proto_list): (JSC::Interpreter::cti_op_resolve_global):
  • jit/JIT.cpp: (JSC::JIT::JIT): (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases): (JSC::JIT::privateCompile):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compilePutByIdHotPath): (JSC::JIT::compileGetByIdSlowCase): (JSC::JIT::compilePutByIdSlowCase): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList):
Note: See TracTimeline for information about the timeline view.