⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 20, 2008:

2:41 PM Changeset in webkit [39425] by mitz@apple.com
  • 4 edits
    1 add in trunk/WebKit/win

Reviewed by Ada Chan.

  • expose the new allItems() method via a new IWebHistoryPrivate interface
  • Interfaces/IWebHistoryPrivate.idl: Added.
  • Interfaces/WebKit.idl: Added IWebHistoryPrivate.idl.
  • WebHistory.cpp: (WebHistory::QueryInterface): Added IWebHistoryPrivate. (WebHistory::allItems):
  • WebHistory.h:
12:52 PM Changeset in webkit [39424] by ddkilzer@apple.com
  • 3 edits in trunk/WebCore

Fix typo "CSSAferRuleValue" to "CSSAfterRuleValue"

  • html/PreloadScanner.cpp: (WebCore::PreloadScanner::tokenizeCSS):
  • html/PreloadScanner.h: (WebCore::PreloadScanner::CSSState):
2:26 AM Changeset in webkit [39423] by ap@webkit.org
  • 3 edits in trunk/WebCore

Reviewed by Geoff Garen.

<rdar://problem/6454076> Random crashes on JS raytracer

No test, because the crash is not readily reproducible.

  • platform/text/StringImpl.cpp: (WebCore::StringImpl::empty):
  • platform/text/StringImpl.h: Made empty string per-thread.
2:11 AM Changeset in webkit [39422] by barraclough@apple.com
  • 8 edits in trunk/JavaScriptCore

2008-12-20 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver Hunt.

Port optimized property access generation to the MacroAssembler.

  • assembler/MacroAssembler.h: (JSC::MacroAssembler::AbsoluteAddress::AbsoluteAddress): (JSC::MacroAssembler::DataLabelPtr::repatch): (JSC::MacroAssembler::DataLabel32::DataLabel32): (JSC::MacroAssembler::DataLabel32::repatch): (JSC::MacroAssembler::Label::operator X86Assembler::JmpDst): (JSC::MacroAssembler::Jump::repatch): (JSC::MacroAssembler::JumpList::empty): (JSC::MacroAssembler::RepatchBuffer::link): (JSC::MacroAssembler::add32): (JSC::MacroAssembler::and32): (JSC::MacroAssembler::sub32): (JSC::MacroAssembler::loadPtrWithAddressRepatch): (JSC::MacroAssembler::storePtrWithAddressRepatch): (JSC::MacroAssembler::push): (JSC::MacroAssembler::ja32): (JSC::MacroAssembler::jePtr): (JSC::MacroAssembler::jnePtr): (JSC::MacroAssembler::jnePtrWithRepatch): (JSC::MacroAssembler::align): (JSC::MacroAssembler::differenceBetween):
  • assembler/X86Assembler.h: (JSC::X86Assembler::movl_rm_disp32): (JSC::X86Assembler::movl_mr_disp32): (JSC::X86Assembler::X86InstructionFormatter::oneByteOp_disp32): (JSC::X86Assembler::X86InstructionFormatter::memoryModRM):
  • jit/JIT.cpp: (JSC::ctiRepatchCallByReturnAddress): (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompile): (JSC::JIT::privateCompileCTIMachineTrampolines):
  • jit/JIT.h:
  • jit/JITPropertyAccess.cpp: (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compileGetByIdSlowCase): (JSC::JIT::compilePutByIdHotPath): (JSC::JIT::compilePutByIdSlowCase): (JSC::resizePropertyStorage): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchPutByIdReplace): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdSelf): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain): (JSC::JIT::privateCompilePutByIdReplace):
  • wtf/RefCounted.h: (WTF::RefCountedBase::addressOfCount):

Dec 19, 2008:

7:18 PM Changeset in webkit [39421] by zecke@webkit.org
  • 11 edits
    4 adds in trunk

2008-12-19 Marco Barisione <marco.barisione@collabora.co.uk>

Reviewed by Holger Freyther.

http://bugs.webkit.org/show_bug.cgi?id=16562
[gtk] Implement WebPolicyDelegate methods

Original work by Pierre-Luc Beaudoin. Final touches by Gustavo
Noronha.

This implements the delegates methods of WebPolicyDelegate.
Since Gtk+/C doesn't have delegate methods, they are replaced with
signals.

A new object WebKitWebPolicyDecision allows the browser to delay its
response in certain cases. WebKitWebNavigationAction contains the
information about what caused a navigation request.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::FrameLoaderClient): (WebKit::FrameLoaderClient::~FrameLoaderClient): (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction): (WebKit::FrameLoaderClient::cancelPolicyCheck): (WebKit::FrameLoaderClient::canShowMIMEType):
  • WebCoreSupport/FrameLoaderClientGtk.h:
  • webkit/webkit.h:
  • webkit/webkitdefines.h:
  • webkit/webkitprivate.cpp: (WebKit::kit): (WebKit::core):
  • webkit/webkitprivate.h:
  • webkit/webkitwebnavigationaction.cpp: Added. (_WebKitWebNavigationActionPrivate::): (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_get_property): (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_set_property): (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_init): (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_finalize): (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_class_init): (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_get_reason): (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_set_reason): (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_get_original_uri): (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_set_original_uri):
  • webkit/webkitwebnavigationaction.h: Added.
  • webkit/webkitwebpolicydecision.cpp: Added. (_WebKitWebPolicyDecisionPrivate::webkit_web_policy_decision_class_init): (_WebKitWebPolicyDecisionPrivate::webkit_web_policy_decision_init): (_WebKitWebPolicyDecisionPrivate::webkit_web_policy_decision_new): (_WebKitWebPolicyDecisionPrivate::webkit_web_policy_decision_use): (_WebKitWebPolicyDecisionPrivate::webkit_web_policy_decision_ignore): (_WebKitWebPolicyDecisionPrivate::webkit_web_policy_decision_download): (_WebKitWebPolicyDecisionPrivate::webkit_web_policy_decision_cancel):
  • webkit/webkitwebpolicydecision.h: Added.
6:35 PM Changeset in webkit [39420] by zecke@webkit.org
  • 2 edits in trunk/LayoutTests

2008-12-19 Zan Dobersek <zandobersek@gmail.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=22039

Enable more tests for testing on Gtk+ port.

  • platform/gtk/Skipped:
6:04 PM Changeset in webkit [39419] by andersca@apple.com
  • 7 edits in trunk/WebCore

2008-12-19 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Replace some uses of HardRetain etc with RetainPtr.

  • platform/mac/DragImageMac.mm:
  • platform/mac/SharedBufferMac.mm: (WebCore::SharedBuffer::createCFData):
  • rendering/RenderThemeMac.mm:
  • svg/graphics/cg/SVGResourceFilterCg.mm: (WebCore::SVGResourceFilter::prepareFilter): (WebCore::SVGResourceFilter::applyFilter):
  • svg/graphics/mac/SVGResourceFilterPlatformDataMac.h:
  • svg/graphics/mac/SVGResourceFilterPlatformDataMac.mm: (WebCore::SVGResourceFilterPlatformDataMac::SVGResourceFilterPlatformDataMac):
5:39 PM Changeset in webkit [39418] by ggaren@apple.com
  • 2 edits in trunk/WebKit/win

2008-12-19 Geoffrey Garen <ggaren@apple.com>

Build fix.

  • WebHistory.cpp: (WebHistory::allItems):
4:31 PM Changeset in webkit [39417] by ggaren@apple.com
  • 6 edits in trunk/WebKit

WebKit/mac:

2008-12-19 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler, Adele Peterson, Brady Eidson.


Added SPI for getting an unsorted vector of all items in history.


  • History/WebHistory.h:
  • History/WebHistory.mm: (-[WebHistory allItems]):

WebKit/win:

2008-12-19 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler, Adele Peterson, Brady Eidson.


Added SPI for getting an unsorted vector of all items in history.


  • WebHistory.cpp: (WebHistory::orderedItemsLastVisitedOnDay): (WebHistory::allItems):
  • WebHistory.h:
4:28 PM Changeset in webkit [39416] by kevino@webkit.org
  • 10 edits
    2 adds in trunk

Reviewed by Kevin Ollivier.

Add Context Menu support to wx bindings.

https://bugs.webkit.org/show_bug.cgi?id=22675

4:03 PM Changeset in webkit [39415] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2008-12-19 David Levin <levin@chromium.org>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=22930

Make the git diff command used for preparing the change log avoid using any external diff tools.

  • Scripts/prepare-ChangeLog:
2:54 PM Changeset in webkit [39414] by Beth Dakin
  • 2 edits in trunk/WebCore

2008-12-19 Beth Dakin <Beth Dakin>

Reviewed by Darin Adler.

Temporary band-aide fix for <rdar://problem/6372481> In Gmail, a
crash occurs at
AccessibilityTable::isTableExposableThroughAccessibility() when
attempting to create a link in a rich text message

We need to disable Accessibility Tables until we get this fixed for
real to prevent rampant crashing.

  • page/AccessibilityTable.cpp: (WebCore::AccessibilityTable::AccessibilityTable):
2:44 PM Changeset in webkit [39413] by Simon Fraser
  • 3 edits
    4 adds in trunk

2008-12-19 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler

https://bugs.webkit.org/show_bug.cgi?id=22938

When the document element is transformed, we need to paint
the view background to avoid unpainted areas.

Test: fast/transforms/transformed-document-element.html

  • rendering/RenderView.cpp: (WebCore::RenderView::paintBoxDecorations):
1:37 PM Changeset in webkit [39412] by dino@apple.com
  • 2 edits in trunk/WebKitSite

2008-12-19 Dean Jackson <dino@apple.com>

Media queries that return <integer> but are really boolean
are restricted to 0 and 1. This is in line with other
media features.

  • specs/MediaQueriesExtensions.html:
1:19 PM Changeset in webkit [39411] by sfalken@apple.com
  • 2 edits in trunk/WebCore

Fix build.

  • WebCore.vcproj/WebCore.vcproj:
11:10 AM Changeset in webkit [39410] by pam@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2008-12-19 Pamela Greene <pam@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=22612
Add test to verify type enforcement in DOM setters.
Resubmitting corrected copies; first submission had patching errors.

  • fast/dom/setter-type-enforcement-expected.txt: Added.
  • fast/dom/setter-type-enforcement.html: Added.
10:52 AM Changeset in webkit [39409] by kevino@webkit.org
  • 6 edits in trunk

wx build fixes after recent changes.

10:34 AM Changeset in webkit [39408] by zecke@webkit.org
  • 2 edits in trunk/WebCore

[GTK] Fix make distcheck again

These files were moved to WebCore/platform/animation
and WebCore/platform/graphics/transforms.

8:54 AM Changeset in webkit [39407] by zecke@webkit.org
  • 2 edits in trunk

2008-12-19 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Holger Freyther.

Use ustar tar format for WebKit/GTK+'s make dist target, so that
storing files whose filenames are > 99 is possible.

  • configure.ac:
8:53 AM Changeset in webkit [39406] by zecke@webkit.org
  • 2 edits in trunk/WebCore

2008-12-19 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=22900

Fix AtomicString usage, so that building works.

  • platform/network/soup/ResourceHandleSoup.cpp:
8:47 AM Changeset in webkit [39405] by zecke@webkit.org
  • 4 edits in trunk

JavaScriptCore:
2008-12-19 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=22686

Added file which was missing to the javascriptcore_sources
variable, so that it shows up in the tarball created by `make
dist'.

  • GNUmakefile.am:

WebKitTools
2008-12-19 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=22686

Added files which were missing from the TestNetscapePlugin
directory to the SOURCES variable, so that they will be
distributed in a make dist.

  • GNUMakefile.am:
8:35 AM Changeset in webkit [39404] by zecke@webkit.org
  • 2 edits in trunk

[GTK] Build fix by defining WTF_USE_JIT_STUB_ARGUMENT_VA_LIST

Fix the jit compilation on i*686 on Linux by using the va_list
to pass arguments to the CTI. This is done on the MAC as well
and sunspider and javascriptcore seem to work with that.

7:32 AM Changeset in webkit [39403] by Adam Roben
  • 2 edits in trunk/WebCore

Windows build fix on older versions of CFNetwork after r39393

  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::highestSupportedCFURLConnectionClientVersion): Changed preprocessor directives not to leave in unreachable code on old versions of CFNetwork.
4:45 AM Changeset in webkit [39402] by Antti Koivisto
  • 2 edits in trunk/WebCore

2008-12-19 Antti Koivisto <Antti Koivisto>

Comment fix.

  • platform/PurgeableBuffer.h:
3:27 AM Changeset in webkit [39401] by zecke@webkit.org
  • 2 edits in trunk/JavaScriptCore

Build fix when building JS API tests with a c89 c compiler

Do not use C++ style comments and convert them to C comments.

3:26 AM Changeset in webkit [39400] by zecke@webkit.org
  • 2 edits in trunk/WebCore

[GTK] Build fix by adding the new files

2:41 AM Changeset in webkit [39399] by vestbo@webkit.org
  • 4 edits in trunk

2008-12-19 Jade Han <jade.han@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Allow conversion of JavaScript Number and Boolean types to Qt types

https://bugs.webkit.org/show_bug.cgi?id=22880

2:05 AM Changeset in webkit [39398] by vestbo@webkit.org
  • 4 edits in trunk/WebCore

2008-12-19 Tor Arne Vestbø <tavestbo@trolltech.com>

Reviewed by Holger Freyther.

Implement ImageDecoder::filenameExtension() for Qt

1:14 AM Changeset in webkit [39397] by vestbo@webkit.org
  • 1 edit in trunk/WebCore/WebCore.pro

Fix the Qt build after r39378

1:03 AM Changeset in webkit [39396] by abarth@webkit.org
  • 9 edits in trunk/WebCore

2008-12-18 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Implement ImageSource::filenameExtension for Cario

https://bugs.webkit.org/show_bug.cgi?id=22905

  • platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::filenameExtension):
  • platform/image-decoders/ImageDecoder.h:
  • platform/image-decoders/bmp/BMPImageDecoder.h: (WebCore::BMPImageDecoder::filenameExtension):
  • platform/image-decoders/gif/GIFImageDecoder.h: (WebCore::GIFImageDecoder::filenameExtension):
  • platform/image-decoders/ico/ICOImageDecoder.h: (WebCore::ICOImageDecoder::filenameExtension):
  • platform/image-decoders/jpeg/JPEGImageDecoder.h: (WebCore::JPEGImageDecoder::filenameExtension):
  • platform/image-decoders/png/PNGImageDecoder.h: (WebCore::PNGImageDecoder::filenameExtension):
  • platform/image-decoders/xbm/XBMImageDecoder.h: (WebCore::XBMImageDecoder::filenameExtension):
12:52 AM Changeset in webkit [39395] by vestbo@webkit.org
  • 1 edit in trunk/JavaScriptCore/wtf/Platform.h

Fix build break in Platform.h

12:19 AM Changeset in webkit [39394] by vestbo@webkit.org
  • 2 edits in trunk/WebKit/qt

2008-12-18 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Tor Arne Vestbø.

When Web Inspector is launched without an associated node,
call show() instead of inspect().

https://bugs.webkit.org/show_bug.cgi?id=22918

Note: See TracTimeline for information about the timeline view.