⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 22, 2008:

11:08 PM Changeset in webkit [39450] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-12-22 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Oliver Hunt.

Fix rounding / bounds / signed comparison bug in ExecutableAllocator.

ExecutableAllocator::alloc assumed that m_freePtr would be aligned. This was
not always true, since the first allocation from an additional pool would not
be rounded up. Subsequent allocations would be unaligned, and too much memory
could be erroneously allocated from the pool, when the size requested was
available, but the size rounded up to word granularity was not available in the
pool. This may result in the value of m_freePtr being greater than m_end.

Under these circumstances, the unsigned check for space will always pass,
resulting in pointers to memory outside of the arena being returned, and
ultimately segfaulty goodness when attempting to memcpy the hot freshly jitted
code from the AssemblerBuffer.

​https://bugs.webkit.org/show_bug.cgi?id=22974
... and probably many, many more.

  • jit/ExecutableAllocator.h: (JSC::ExecutablePool::alloc): (JSC::ExecutablePool::roundUpAllocationSize): (JSC::ExecutablePool::ExecutablePool): (JSC::ExecutablePool::poolAllocate):
7:05 PM Changeset in webkit [39449] by weinig@apple.com
  • 5 edits in trunk/WebCore

2008-12-22 Sam Weinig <​sam@webkit.org>

Reviewed by Mark Rowe.

Save a word in all Elements by moving the 5 loose bits to Node,
where we had 16 spare.

  • dom/Element.cpp: (WebCore::Element::Element):
  • dom/Element.h:
  • dom/Node.cpp: (WebCore::Node::Node):
  • dom/Node.h:
6:14 PM Changeset in webkit [39448] by Nikolas Zimmermann
  • 6 edits
    2 adds in trunk/WebCore

Reviewed by George Staikos.

Fixes: ​https://bugs.webkit.org/show_bug.cgi?id=22972

Add WML <meta> element support. All needed functionality is present
in Document::processHttpEquiv, already covered by tests.

5:55 PM Changeset in webkit [39447] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

Rubber-stamped by Darin Adler.

Don't reference specific layout tests in comments.

5:31 PM Changeset in webkit [39446] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

Reviewed by George Staikos.

Fixes: ​https://bugs.webkit.org/show_bug.cgi?id=22965

Add WML <head> element support. Doesn't require a WMLHeadElement.
No functional behaviour, as we already created a WMLElement for headTag, by default.
It's just cleaner to list <head> in WMLTagNames, forwarding to a WMLElement constructor.

5:29 PM Changeset in webkit [39445] by Nikolas Zimmermann
  • 3 edits
    3 adds in trunk

Reviewed by George Staikos.

Fixes: ​https://bugs.webkit.org/show_bug.cgi?id=22971

Fix regression caused by the HTMLFormElement refactorization.
File form elements without a name have to be included in multipart/form-data
submission. Cover this behaviour with a new test case.

5:06 PM Changeset in webkit [39444] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/6438298> Bump schema version for app cache

Reviewed by Alexey Proskuryakov.

  • loader/appcache/ApplicationCacheStorage.cpp: Increment SchemaVersion from 2 to 3.
4:49 PM Changeset in webkit [39443] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

Use Deque in CSSStyleSheet::addSubresourceStyleURLs()

Reviewed by Darin Adler.

  • css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::addSubresourceStyleURLs): Replaced use of ListHashSet with more efficient Deque.
4:25 PM Changeset in webkit [39442] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

Reviewed by Sam Weinig.

Fix obvious crash fix for WML enabled builds.

4:00 PM Changeset in webkit [39441] by ddkilzer@apple.com
  • 46 edits
    16 adds in trunk

Bug 11850: Webarchive fails to save images referenced in CSS

<​https://bugs.webkit.org/show_bug.cgi?id=11850>

Reviewed by Darin Adler.

WebCore:

This entry contains two parts since the tests for adding a
completeURL() method to StyleSheet and CSSStyleSheet (part 1) depend
on Bug 11850 being fixed (part 2).

--

Tests: http/tests/webarchive/test-css-url-encoding-shift-jis.html

http/tests/webarchive/test-css-url-encoding-utf-8.html
http/tests/webarchive/test-css-url-encoding.html

Added completeURL() methods to StyleSheet and CSSStyleSheet that
match the behavior of Document::completeURL(). Most notably,
CSSStyleSheet::completeURL() uses the charset of the stylesheet
(if it exists) to construct URLs, just like Document::completeURL().

  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Use CSSStyleSheet::completeURL(). (WebCore::CSSParser::parseContent): Ditto. (WebCore::CSSParser::parseFillImage): Ditto. (WebCore::CSSParser::parseFontFaceSrc): Ditto. (WebCore::CSSParser::parseBorderImage): Ditto.
  • css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::completeURL): Added.
  • css/CSSStyleSheet.h: (WebCore::CSSStyleSheet::completeURL): Added declaration.
  • css/StyleSheet.cpp: (WebCore::StyleSheet::completeURL): Added.
  • css/StyleSheet.h: (WebCore::StyleSheet::completeURL): Added declaration.
  • dom/Document.cpp: (WebCore::Document::completeURL): Added comment referring to the new completeURL() methods in StyleSheet and CSSStyleSheet.

--

Tests: webarchive/test-css-url-resources-in-stylesheets.html

webarchive/test-css-url-resources-inline-styles.html

Walk stylesheets and inline style attributes for url() references
when building a list of URLs to include in a webarchive. Note that
not all URLs found this way will be included in the webarchive if
they were not used (and thus not downloaded) when laying out the
page.

The key method for CSS stylesheets is
CSSStyleSheet::addSubresourceStyleURLs() which iterates over all
CSSStyleSheet objects recursively referenced from its own stylesheet
through @import rules. Starting with the CSSRule objects in each
sheet and continuing down through the CSSMutableStyleDeclaration and
CSSValue objects, addSubresourceStyleURLs() methods are called to
gather URLs.

For inline style attributes in HTML DOM elements,
StyledElement::addSubresourceAttributeURLs() calls
CSSMutableStyleDeclaration::addSubresourceStyleURLs() to gather URLs
from each element, hence the need to call
addSubresourceAttributeURLs() on superclasses when the method is
implemented on the element class itself.

  • css/CSSBorderImageValue.cpp: (WebCore::CSSBorderImageValue::addSubresourceStyleURLs): Added.
  • css/CSSBorderImageValue.h: (WebCore::CSSBorderImageValue::addSubresourceStyleURLs): Added declaration.
  • css/CSSFontFaceRule.cpp: (WebCore::CSSFontFaceRule::addSubresourceStyleURLs): Added.
  • css/CSSFontFaceRule.h: (WebCore::CSSFontFaceRule::addSubresourceStyleURLs): Added declaration.
  • css/CSSFontFaceSrcValue.cpp: (WebCore::CSSFontFaceSrcValue::addSubresourceStyleURLs): Added.
  • css/CSSFontFaceSrcValue.h: (WebCore::CSSFontFaceSrcValue::addSubresourceStyleURLs): Added declaration.
  • css/CSSImportRule.cpp: (WebCore::CSSImportRule::addSubresourceStyleURLs): Added.
  • css/CSSImportRule.h: (WebCore::CSSImportRule::addSubresourceStyleURLs): Added declaration.
  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::addSubresourceStyleURLs): Added. Iterates over m_properties vector of CSSProperty objects calling addSubresourceStyleURLs() on each property's CSSValue object.
  • css/CSSMutableStyleDeclaration.h: (WebCore::CSSMutableStyleDeclaration::addSubresourceStyleURLs): Added declaration.
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::addSubresourceStyleURLs): Added.
  • css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::addSubresourceStyleURLs): Added declaration.
  • css/CSSReflectValue.cpp: (WebCore::CSSReflectValue::addSubresourceStyleURLs): Added.
  • css/CSSReflectValue.h: (WebCore::CSSReflectValue::addSubresourceStyleURLs): Added declaration.
  • css/CSSRule.h: (WebCore::CSSRule::addSubresourceStyleURLs): Added. Virtual method with empty implementation that's overridden by subclasses as needed.
  • css/CSSStyleRule.cpp: (WebCore::CSSStyleRule::addSubresourceStyleURLs): Added.
  • css/CSSStyleRule.h: (WebCore::CSSStyleRule::addSubresourceStyleURLs): Added declaration.
  • css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::addSubresourceStyleURLs): Updated to call CSSRule::addSubresourceStyleURLs on each rule to extract URLs. Removed unneeded baseURL parameter now that the completeURL() method exists.
  • css/CSSStyleSheet.h: (WebCore::CSSStyleSheet::addSubresourceStyleURLs): Updated declaration.
  • css/CSSValue.h: (WebCore::CSSValue::addSubresourceStyleURLs): Added. Virtual method with empty implementation that's overridden by subclasses as needed.
  • css/CSSValueList.cpp: (WebCore::CSSValueList::addSubresourceStyleURLs): Added. Iterates over m_values vector of CSSValue objects calling addSubresourceStyleURLs() on each.
  • css/CSSValueList.h: (WebCore::CSSValueList::addSubresourceStyleURLs): Added declaration.
  • css/StyleSheet.h: (WebCore::StyleSheet::addSubresourceStyleURLs): Updated declaration to remove unneeded baseURL parameter.
  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::addSubresourceAttributeURLs): Fixed to use the StyleBase::baseURL() method to get the stylesheet's URL instead of calling Document::completeURL().
  • dom/StyledElement.cpp: (WebCore::StyledElement::addSubresourceAttributeURLs): Added method to extract URLs from inline style declarations.
  • dom/StyledElement.h: (WebCore::StyledElement::addSubresourceAttributeURLs): Added declaration.
  • html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::addSubresourceAttributeURLs): Call addSubresourceAttributeURLs() in superclass to extract URLs from inline style declarations.
  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::addSubresourceAttributeURLs): Ditto.
  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::addSubresourceAttributeURLs): Ditto.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::addSubresourceAttributeURLs): Ditto.
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::addSubresourceAttributeURLs): Ditto.
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::addSubresourceAttributeURLs): Ditto.
  • html/HTMLParamElement.cpp: (WebCore::HTMLParamElement::addSubresourceAttributeURLs): Ditto.
  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::addSubresourceAttributeURLs): Ditto.
  • html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::addSubresourceAttributeURLs): Ditto.
  • html/HTMLTableCellElement.cpp: (WebCore::HTMLTableCellElement::addSubresourceAttributeURLs): Ditto.
  • html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::addSubresourceAttributeURLs): Ditto.
  • svg/SVGCursorElement.cpp: (WebCore::SVGCursorElement::addSubresourceAttributeURLs): Ditto.
  • svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::addSubresourceAttributeURLs): Ditto.
  • svg/SVGImageElement.cpp: (WebCore::SVGImageElement::addSubresourceAttributeURLs): Ditto.
  • svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::addSubresourceAttributeURLs): Ditto.

LayoutTests:

The first set of files below tests that URLs are encoded properly
based on the charset of the stylesheet. Normally this behavior may
only be tested by looking at web server logs with manual tests, but
webarchives represent this information in such a way that they may
be tested by DumpRenderTree. Note that these tests depend on Bug
11850 being fixed, so it's not possible to separate them.

The second set of files below tests that all types of resources
referenced by url() in CSS stylesheets are now saved in webarchives.

  • http/tests/webarchive/resources/.htaccess: Added.
  • http/tests/webarchive/resources/apple.gif: Copied from LayoutTests/fast/canvas/resources/apple.gif.
  • http/tests/webarchive/resources/test-no-charset.css: Added.
  • http/tests/webarchive/resources/test-shift-jis.css: Added.
  • http/tests/webarchive/resources/test-utf-8.css: Added.
  • http/tests/webarchive/test-css-url-encoding-expected.webarchive: Added.
  • http/tests/webarchive/test-css-url-encoding-shift-jis-expected.webarchive: Added.
  • http/tests/webarchive/test-css-url-encoding-shift-jis.html: Added.
  • http/tests/webarchive/test-css-url-encoding-utf-8-expected.webarchive: Added.
  • http/tests/webarchive/test-css-url-encoding-utf-8.html: Added.
  • http/tests/webarchive/test-css-url-encoding.html: Added.
  • webarchive/resources/Ahem.ttf: Copied from LayoutTests/fast/css/resources/Ahem.ttf.
  • webarchive/test-css-url-resources-in-stylesheets-expected.webarchive: Added.
  • webarchive/test-css-url-resources-in-stylesheets.html: Added.
  • webarchive/test-css-url-resources-inline-styles-expected.webarchive: Added.
  • webarchive/test-css-url-resources-inline-styles.html: Added.
1:21 PM Changeset in webkit [39440] by weinig@apple.com
  • 8 edits in trunk/JavaScriptCore

2008-12-22 Sam Weinig <​sam@webkit.org>

Reviewed by Gavin Barraclough.

Rename all uses of the term "repatch" to "patch".

  • assembler/MacroAssembler.h: (JSC::MacroAssembler::DataLabelPtr::patch): (JSC::MacroAssembler::DataLabel32::patch): (JSC::MacroAssembler::Jump::patch): (JSC::MacroAssembler::PatchBuffer::PatchBuffer): (JSC::MacroAssembler::PatchBuffer::setPtr): (JSC::MacroAssembler::loadPtrWithAddressOffsetPatch): (JSC::MacroAssembler::storePtrWithAddressOffsetPatch): (JSC::MacroAssembler::storePtrWithPatch): (JSC::MacroAssembler::jnePtrWithPatch):
  • assembler/X86Assembler.h: (JSC::X86Assembler::patchAddress): (JSC::X86Assembler::patchImmediate): (JSC::X86Assembler::patchPointer): (JSC::X86Assembler::patchBranchOffset):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::tryCTICachePutByID): (JSC::Interpreter::tryCTICacheGetByID): (JSC::Interpreter::cti_op_put_by_id): (JSC::Interpreter::cti_op_get_by_id): (JSC::Interpreter::cti_op_get_by_id_self_fail): (JSC::Interpreter::cti_op_get_by_id_proto_list): (JSC::Interpreter::cti_vm_dontLazyLinkCall):
  • jit/JIT.cpp: (JSC::ctiPatchCallByReturnAddress): (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompile): (JSC::JIT::privateCompileCTIMachineTrampolines):
  • jit/JIT.h:
  • jit/JITCall.cpp: (JSC::JIT::unlinkCall): (JSC::JIT::linkCall): (JSC::JIT::compileOpCall):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compilePutByIdHotPath): (JSC::JIT::compileGetByIdSlowCase): (JSC::JIT::compilePutByIdSlowCase): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchPutByIdReplace): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdSelf): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain): (JSC::JIT::privateCompilePutByIdReplace):
1:20 PM Changeset in webkit [39439] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

2008-12-22 Dhananjoy Chutia <​dhanrd@gmail.com>

Reviewed by David Kilzer.

Fixes: ​https://bugs.webkit.org/show_bug.cgi?id=22959
Memory leak fixes for WebKit+soup

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::finishedCallback):
11:19 AM Changeset in webkit [39438] by kdecker@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Anders Carlsson.

<rdar://problem/6449588> REGRESSION (r38279-r38280): Minimize them remaximize a window with a flash plugin, plugin doesn't resume at full speed


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView windowDidDeminiaturize:]): Deminiaturizing should restart timers, not stop timers.
10:16 AM Changeset in webkit [39437] by ap@webkit.org
  • 4 edits
    5 adds in trunk

Reviewed by Darin Adler.

<rdar://problem/6277060> ASSERTION FAILED: !m_cacheBeingUpdated if the manifest is not available

Tests: http/tests/appcache/404-manifest.html

http/tests/appcache/fail-on-update.html

  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::stopLoading): Removed the incorrect assertion.
  • loader/appcache/ApplicationCacheGroup.h: Added an explanation of somewhat nonintuitive m_currentHandle handling.
8:00 AM Changeset in webkit [39436] by Nikolas Zimmermann
  • 13 edits
    8 adds in trunk

Reviewed by Alexey Proskuryakov & George Staikos.

Fixes: ​https://bugs.webkit.org/show_bug.cgi?id=22961

Add WML <fieldset> element support.
Unlike HTML's <fieldset> element, WML doesn't provide a <legend> child element
to describe the <fieldset>. WML instead offers a 'title' attribute on the <fieldset>
element. To integrate within the existing RenderFieldset code, we just create an
internal <insertedLegend> element as first child for a WML <fieldset> element, containing
the title attribute value.

6:28 AM Changeset in webkit [39435] by Adam Roben
  • 2 edits in trunk/JavaScriptCore

Build fix after r39428

  • jit/JITCall.cpp: (JSC::JIT::compileOpCallSlowCase): Added a missing MacroAssembler::

Dec 21, 2008:

11:31 PM Changeset in webkit [39434] by ap@webkit.org
  • 6 edits in trunk/LayoutTests

2008-12-21 David Levin <​levin@chromium.org>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=22950

Attempted fix for 4 failing XMLHttpReuqest tests on Tiger:

access-control-basic-allow-preflight-cache-invalidation-by-header.html
access-control-basic-allow-preflight-cache-invalidation-by-method.html
access-control-basic-allow-preflight-cache-timeout.html
access-control-basic-allow-preflight-cache.html

  • http/tests/xmlhttprequest/resources/access-control-basic-preflight-cache-invalidation.php:
  • http/tests/xmlhttprequest/resources/access-control-basic-preflight-cache-timeout.php:
  • http/tests/xmlhttprequest/resources/access-control-basic-preflight-cache.php:
  • http/tests/xmlhttprequest/resources/portabilityLayer.php:
  • http/tests/xmlhttprequest/resources/reset-temp-file.php:
6:57 PM Changeset in webkit [39433] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

Not reviewed. Try to fix clean Mac builds, set role=private for FormDataBuilder.h

6:22 PM Changeset in webkit [39432] by Nikolas Zimmermann
  • 80 edits in trunk

Rubber-stamped by George Staikos.

Unify all TorchMobile copyright lines. Consolidate in a single line, as requested by Mark Rowe, some time ago.

6:04 PM Changeset in webkit [39431] by Nikolas Zimmermann
  • 16 edits
    17 adds in trunk

Reviewed by George Staikos.

Fixes: ​https://bugs.webkit.org/show_bug.cgi?id=22638

Add POST method support to WMLGoElement. GET & POST over HTTP
covered by a new set of WML HTTP layout tests.

Tests: http/tests/wml/go-task-get-method-accept-charset.html

http/tests/wml/go-task-get-method.html
http/tests/wml/go-task-post-method-accept-charset.html
http/tests/wml/go-task-post-method.html

5:45 PM Changeset in webkit [39430] by Nikolas Zimmermann
  • 9 edits
    2 adds in trunk/WebCore

Reviewed by Darin Adler and George Staikos.

Fixes: ​https://bugs.webkit.org/show_bug.cgi?id=22949

Refactor HTMLFormElement to share a maximum level of code between HTMLFormElement & WMLGoElement.
Create a new helper class 'FormDataBuilder', which is hold as member variable in those classes.
It encapsulates all functionality needed to generate a FormData object, usable for HTML/WML form
submission, including boundary string generation, multi-part form handling etc.

No functional changes, no test cases affected.
WMLGoElement will be converted in a follow-up patch.

5:42 PM Changeset in webkit [39429] by Nikolas Zimmermann
  • 4 edits in trunk/JavaScriptCore

Rubber-stamped by George Staikos.
Fix copyright of the new RandomNumber* files.

5:00 PM Changeset in webkit [39428] by barraclough@apple.com
  • 9 edits in trunk/JavaScriptCore

2008-12-21 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Oliver Hunt & Cameron Zwarich.

Add support for call and property access repatching on x86-64.

No change in performance on current configurations (2x impovement on v8-tests with JIT enabled on x86-64).

  • assembler/MacroAssembler.h: (JSC::MacroAssembler::DataLabelPtr::repatch): (JSC::MacroAssembler::DataLabelPtr::operator X86Assembler::JmpDst): (JSC::MacroAssembler::DataLabel32::repatch): (JSC::MacroAssembler::RepatchBuffer::addressOf): (JSC::MacroAssembler::add32): (JSC::MacroAssembler::sub32): (JSC::MacroAssembler::loadPtrWithAddressOffsetRepatch): (JSC::MacroAssembler::storePtrWithAddressOffsetRepatch): (JSC::MacroAssembler::jePtr): (JSC::MacroAssembler::jnePtr): (JSC::MacroAssembler::jnePtrWithRepatch): (JSC::MacroAssembler::differenceBetween):
  • assembler/X86Assembler.h: (JSC::X86Assembler::addl_im): (JSC::X86Assembler::subl_im): (JSC::X86Assembler::cmpl_rm): (JSC::X86Assembler::movq_rm_disp32): (JSC::X86Assembler::movq_mr_disp32): (JSC::X86Assembler::repatchPointer): (JSC::X86Assembler::X86InstructionFormatter::oneByteOp64_disp32):
  • jit/JIT.cpp: (JSC::JIT::privateCompile): (JSC::JIT::privateCompileCTIMachineTrampolines):
  • jit/JIT.h:
  • jit/JITCall.cpp: (JSC::JIT::unlinkCall): (JSC::JIT::linkCall): (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase):
  • jit/JITInlineMethods.h: (JSC::JIT::restoreArgumentReferenceForTrampoline):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compileGetByIdSlowCase): (JSC::JIT::compilePutByIdHotPath): (JSC::JIT::compilePutByIdSlowCase): (JSC::resizePropertyStorage): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
  • wtf/Platform.h:
3:44 PM Changeset in webkit [39427] by krit@webkit.org
  • 14 edits
    1 add in trunk/WebCore

2008-12-21 Dirk Schulze <​krit@webkit.org>

Reviewed by Darin Adler, Nikolas Zimmermann.

Move the the platform dependent strokeBBox functionality out of RenderPath
into Path with strokeBoundingRect.

RenderPath clean-up for strokeBoundingBox
​https://bugs.webkit.org/show_bug.cgi?id=22902

  • GNUmakefile.am:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/Path.h:
  • platform/graphics/StrokeStyleApplier.h: Added. (WebCore::StrokeStyleApplier::~StrokeStyleApplier):
  • platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::strokeBoundingRect):
  • platform/graphics/cg/PathCG.cpp: (WebCore::createScratchContext): (WebCore::scratchContext): (WebCore::Path::strokeBoundingRect):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::pen):
  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::strokeBoundingRect):
  • rendering/RenderPath.cpp: (WebCore::StrokeBoundingRectStyleApplier::StrokeBoundingRectStyleApplier): (WebCore::StrokeBoundingRectStyleApplier::strokeStyle): (WebCore::RenderPath::relativeBBox):
  • rendering/RenderPath.h:
  • svg/graphics/cairo/RenderPathCairo.cpp:
  • svg/graphics/cg/RenderPathCg.cpp:
  • svg/graphics/qt/RenderPathQt.cpp:
6:49 AM Changeset in webkit [39426] by christian@webkit.org
  • 4 edits in trunk/WebKit/gtk

2008-12-21 Xan Lopez <​xan@gnome.org>

Reviewed by Holger Freyther.

​https://bugs.webkit.org/show_bug.cgi?id=16092
[GTK] Middle-mouse click should allow opening a URL in a new tab

Add mouse button and keyboard state modifiers info to navigation action.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
  • webkit/webkitwebnavigationaction.cpp: (_WebKitWebNavigationActionPrivate::): (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_get_property): (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_set_property): (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_class_init): (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_get_button): (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_get_modifier_state):
  • webkit/webkitwebnavigationaction.h:
Note: See TracTimeline for information about the timeline view.