Timeline
Dec 24, 2008:
- 9:26 PM Changeset in webkit [39471] by
-
- 3 edits in trunk/WebKitTools
Move the guts of determineCurrentSVNRevision to VCSUtils as svnRevisionForDirectory,
and make it work for git too.
Reviewed by Timothy Hatcher.
- Scripts/VCSUtils.pm:
- Scripts/webkitdirs.pm:
- 4:42 PM Changeset in webkit [39470] by
-
- 2 edits in trunk/WebCore
Build fix.
- WebCore.base.exp: Remove a symbol from the export file now that it is no longer generated.
- 1:39 PM Changeset in webkit [39469] by
-
- 7 edits in trunk/LayoutTests
2008-12-24 Simon Fraser <Simon Fraser>
Reviewed by Oliver Hunt
Update more svg-as-image test results affected by the fix
for SVGImage drawing.
- platform/mac/fast/images/svg-as-background-expected.checksum:
- platform/mac/fast/images/svg-as-background-expected.png:
- platform/mac/fast/images/svg-as-image-expected.checksum:
- platform/mac/fast/images/svg-as-image-expected.png:
- platform/mac/fast/images/svg-as-relative-image-expected.checksum:
- platform/mac/fast/images/svg-as-relative-image-expected.png:
- transforms/2d/compound-transforms-vs-containers.html:
- 10:08 AM Changeset in webkit [39468] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Fix a typo in ChangeLog.
- 10:06 AM Changeset in webkit [39467] by
-
- 3 edits2 moves in trunk/LayoutTests
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=22982
http/tests/navigation/post-goback-repost-policy.html fails on Tiger
Change resources that are accessed with POST form .html to .php. I don't know why Apache 2.0
had no problem with this.
- http/tests/navigation/post-goback-repost-policy.html:
- http/tests/navigation/resources/goback-with-policydelegate.html: Removed.
- http/tests/navigation/resources/goback-with-policydelegate.php: Copied from LayoutTests/http/tests/navigation/resources/goback-with-policydelegate.html.
- http/tests/navigation/resources/post-target-policy-test.html: Removed.
- http/tests/navigation/resources/post-target-policy-test.php: Copied from LayoutTests/http/tests/navigation/resources/post-target-policy-test.html.
- 4:44 AM Changeset in webkit [39466] by
-
- 2 edits in trunk/WebCore
Unreviewed build fix to find addSubresourceURL
This is needed to compile on WebKit/Gtk+
Dec 23, 2008:
- 11:46 PM Changeset in webkit [39465] by
-
- 17 edits2 adds in trunk/WebCore
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22980
WebCore uses more thread specific keys than it really needs
Consolidated ThreadSpecific data into a single ThreadGlobalData structure.
- 10:27 PM Google Summer of Code 2008 edited by
- (diff)
- 10:12 PM Changeset in webkit [39464] by
-
- 2 edits in trunk/WebCore
Build fix.
- WebCore.xcodeproj/project.pbxproj: CSSPropertyNames.h is a generated file so it needs to be explicitly copied
into the PrivateHeaders directory, rather than relying on the automatic copying of headers which runs before the
derived sources are generated.
- 9:23 PM Changeset in webkit [39463] by
-
- 5 edits4 adds in trunk
2008-12-23 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein
If the document element has opacity, we need to erase the view background to
white before painting.
Test: fast/backgrounds/opacity-on-document-element.html
- rendering/RenderView.cpp: (WebCore::rendererObscuresBackground):
- 9:19 PM Changeset in webkit [39462] by
-
- 17 edits in trunk
2008-12-23 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein
Fix SVGImage painting by ensuring that the SVGImage resizes its FrameView correctly.
Otherwise the FrameView is left at 0x0, and nothing paints.
- svg/graphics/SVGImage.cpp: (WebCore::SVGImage::draw):
- 8:39 PM Changeset in webkit [39461] by
-
- 16 edits1 copy in tags/Safari-6528.8/WebKit
Merge r39455.
- 8:39 PM Changeset in webkit [39460] by
-
- 1 edit in tags/Safari-6528.8/JavaScriptCore/Configurations/JavaScriptCore.xcconfig
Disable our custom OTHER_CFLAGS until the build issues are resolved.
- 8:39 PM Changeset in webkit [39459] by
-
- 2 edits in tags/Safari-6528.8/WebKit/mac
Merge r39452.
- 7:51 PM Changeset in webkit [39458] by
-
- 4 edits in trunk
Versioning.
- 7:28 PM Changeset in webkit [39457] by
-
- 1 copy in tags/Safari-6528.8
New tag.
- 1:42 PM Changeset in webkit [39456] by
-
- 52 edits in trunk/WebCore
2008-12-23 Darin Adler <Darin Adler>
Reviewed by John Sullivan.
- improve robustness of undo/redo in HTML editing to fix the following bugs <https://bugs.webkit.org/show_bug.cgi?id=19703> Crash in WebCore::InsertNodeBeforeCommand::doUnapply() <rdar://problem/4059423> DOM operations performed on editable HTML can cause a crash later during Undo
Major categories of improvements:
1) Added null checks.
2) Eliminated type casts without corresponding type checks.
3) Avoided possible infinite loops by building up lists of nodes to operate on
before starting to make DOM changes.
4) Use more RefPtr.
No test at this time, but test cases should follow in separate patches.
- WebCore.xcodeproj/project.pbxproj: Set the role of CSSPropertyNames.h to Private so it can be used in other Private headers, specifically editing ones.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::locateCousinList): Adopt parentElement. (WebCore::CSSStyleSelector::locateSharedStyle): Ditto. (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Ditto.
- dom/Element.cpp: (WebCore::Element::cloneElement): Added.
- dom/Element.h: Added cloneElement and an implementation of parentElement.
- dom/Node.h: Moved parentElement from here to Element.h and changed its implementation so it will return 0 when the parent is not an element (document, document fragment, etc.).
- editing/AppendNodeCommand.cpp: (WebCore::AppendNodeCommand::AppendNodeCommand): Made parent be an Element. Moved assertions from doApply in here. (WebCore::AppendNodeCommand::doApply): Simplified to just a single unchecked appendChild call. (WebCore::AppendNodeCommand::doUnapply): Simplified to just a single remove call.
- editing/AppendNodeCommand.h: Updated.
- editing/ApplyStyleCommand.cpp: (WebCore::createStyleSpanElement): Eliminate casting by creating an element in a more direct way with new instead of createElementNS. (WebCore::ApplyStyleCommand::ApplyStyleCommand): Use PassRefPtr. (WebCore::ApplyStyleCommand::removeCSSStyle): Use CSSPropertyID. (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded): Use cloneElement.
- editing/ApplyStyleCommand.h:
- editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply): Use Element* and cloneElement.
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::applyStyledElement): Use PassRefPtr and unsigned. (WebCore::CompositeEditCommand::removeStyledElement): Ditto. (WebCore::CompositeEditCommand::insertNodeBefore): Ditto. (WebCore::CompositeEditCommand::insertNodeAfter): Ditto. (WebCore::CompositeEditCommand::insertNodeAt): Ditto. (WebCore::CompositeEditCommand::appendNode): Ditto. (WebCore::CompositeEditCommand::removeChildrenInRange): Ditto. Also use a vector to make the list of children in case removing them has side effects. (WebCore::CompositeEditCommand::removeNode): Ditto. (WebCore::CompositeEditCommand::removeNodePreservingChildren): Ditto. (WebCore::CompositeEditCommand::removeNodeAndPruneAncestors): Ditto. (WebCore::CompositeEditCommand::splitTextNode): Ditto. (WebCore::CompositeEditCommand::splitElement): Ditto. (WebCore::CompositeEditCommand::mergeIdenticalElements): Ditto. (WebCore::CompositeEditCommand::wrapContentsInDummySpan): Ditto. (WebCore::CompositeEditCommand::splitTextNodeContainingElement): Ditto. (WebCore::CompositeEditCommand::joinTextNodes): Ditto. (WebCore::CompositeEditCommand::inputText): Ditto. (WebCore::CompositeEditCommand::insertTextIntoNode): Ditto. (WebCore::CompositeEditCommand::deleteTextFromNode): Ditto. (WebCore::CompositeEditCommand::replaceTextInNode): Ditto. (WebCore::CompositeEditCommand::insertNodeAtTabSpanPosition): Ditto. (WebCore::CompositeEditCommand::removeCSSProperty): Ditto. (WebCore::CompositeEditCommand::removeNodeAttribute): Ditto. Implement by calling setNodeAttribute instead of with its own SimpleEditCommand. (WebCore::CompositeEditCommand::setNodeAttribute): Ditto. (WebCore::CompositeEditCommand::deleteInsignificantText): Ditto. (WebCore::CompositeEditCommand::appendBlockPlaceholder): Ditto. (WebCore::CompositeEditCommand::addBlockPlaceholderIfNeeded): Ditto. (WebCore::CompositeEditCommand::insertNewDefaultParagraphElementAt): Ditto. Don't bother using an undoable operation to put the break element into the paragraph element because there's no need to split them and redo this when doing undo/redo. (WebCore::CompositeEditCommand::moveParagraphs): Ditto. (WebCore::CompositeEditCommand::breakOutOfEmptyListItem): Ditto.
- editing/CompositeEditCommand.h: Ditto.
- editing/DeleteFromTextNodeCommand.cpp: (WebCore::DeleteFromTextNodeCommand::DeleteFromTextNodeCommand): Use unsigned. (WebCore::DeleteFromTextNodeCommand::doApply): Eliminated inappropriate assertions. (WebCore::DeleteFromTextNodeCommand::doUnapply): Ditto.
- editing/DeleteFromTextNodeCommand.h:
- editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::removeNode): Use PassRefPtr. (WebCore::DeleteSelectionCommand::deleteTextFromNode): Ditto.
- editing/DeleteSelectionCommand.h:
- editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::FormatBlockCommand): Use AtomicString. (WebCore::FormatBlockCommand::doApply): Use Element.
- editing/FormatBlockCommand.h:
- editing/IndentOutdentCommand.cpp: (WebCore::createIndentBlockquoteElement): Use new to create the element instead of calling a function so we have a more specific type. (WebCore::IndentOutdentCommand::prepareBlockquoteLevelForInsertion): Use RefPtr and Element. (WebCore::IndentOutdentCommand::indentRegion): Ditto. (WebCore::IndentOutdentCommand::outdentParagraph): Ditto.
- editing/IndentOutdentCommand.h:
- editing/InsertIntoTextNodeCommand.cpp: (WebCore::InsertIntoTextNodeCommand::InsertIntoTextNodeCommand): Use unsigned. Added an assertion. (WebCore::InsertIntoTextNodeCommand::doApply): Eliminated inappropriate assertions. (WebCore::InsertIntoTextNodeCommand::doUnapply): Ditto.
- editing/InsertIntoTextNodeCommand.h:
- editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::insertNodeAfterPosition): Use Element. (WebCore::InsertLineBreakCommand::insertNodeBeforePosition): Ditto.
- editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply): Use Element.
- editing/InsertNodeBeforeCommand.cpp: (WebCore::InsertNodeBeforeCommand::InsertNodeBeforeCommand): Moved assertions here from doApply. (WebCore::InsertNodeBeforeCommand::doApply): Eliminated inappropriate assertions. Added a null check. (WebCore::InsertNodeBeforeCommand::doUnapply): Simplified to just a single remove call.
- editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Use Element and cloneElement.
- editing/JoinTextNodesCommand.cpp: (WebCore::JoinTextNodesCommand::doApply): Eliminated inappropriate assertions. Added some runtime checks. Don't store anything in m_offset. (WebCore::JoinTextNodesCommand::doUnapply): Ditto.
- editing/JoinTextNodesCommand.h:
- editing/MergeIdenticalElementsCommand.cpp: (WebCore::MergeIdenticalElementsCommand::MergeIdenticalElementsCommand): Moved an assertion here from doApply. (WebCore::MergeIdenticalElementsCommand::doApply): Eliminated inappropriate assertions. Added a null check. Changed implementation to use remove to avoid null parent issue. Use a vector of nodes to avoid possible infinite loop if mutation happens while iterating. (WebCore::MergeIdenticalElementsCommand::doUnapply): Ditto.
- editing/ModifySelectionListLevel.cpp: (WebCore::ModifySelectionListLevelCommand::appendSiblingNodeRange): Use Element*. (WebCore::IncreaseSelectionListLevelCommand::doApply): Ditto.
- editing/ModifySelectionListLevel.h:
- editing/RemoveCSSPropertyCommand.cpp: (WebCore::RemoveCSSPropertyCommand::RemoveCSSPropertyCommand): Use PassRefPtr and CSSPropertyID. Also renamed m_decl to m_style. (WebCore::RemoveCSSPropertyCommand::doApply): Eliminated inappropriate assertions. (WebCore::RemoveCSSPropertyCommand::doUnapply): Ditto.
- editing/RemoveNodeAttributeCommand.cpp: Removed contents of this file. To be deleted. Use SetNodeAttributeCommand instead.
- editing/RemoveNodeAttributeCommand.h: Ditto.
- editing/RemoveNodeCommand.cpp: (WebCore::RemoveNodeCommand::RemoveNodeCommand): Moved assertions here from doApply. Don't initialize m_refChild here; rather do it in doApply. (WebCore::RemoveNodeCommand::doApply): Eliminated inappropriate assertions. Added checks and streamlined implementation. (WebCore::RemoveNodeCommand::doUnapply): Ditto.
- editing/RemoveNodeCommand.h:
- editing/RemoveNodePreservingChildrenCommand.cpp: (WebCore::RemoveNodePreservingChildrenCommand::doApply): Use a vector.
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::insertFragmentForTestRendering): Removed now-unneeded cast.
- editing/SetNodeAttributeCommand.cpp: (WebCore::SetNodeAttributeCommand::SetNodeAttributeCommand): Use AtomicString. Removed assertion that prevents us from using this to remove an attribute. (WebCore::SetNodeAttributeCommand::doApply): Eliminated inappropriate assertions. (WebCore::SetNodeAttributeCommand::doUnapply): Ditto.
- editing/SetNodeAttributeCommand.h:
- editing/SplitElementCommand.cpp: (WebCore::SplitElementCommand::SplitElementCommand): Moved assertion here from doApply. (WebCore::SplitElementCommand::doApply): Check some more invariants and use a vector to avoid possible infinite loops. (WebCore::SplitElementCommand::doUnapply): Ditto.
- editing/SplitTextNodeCommand.cpp: (WebCore::SplitTextNodeCommand::SplitTextNodeCommand): Moved assertions and comment here from doApply. (WebCore::SplitTextNodeCommand::doApply): Check for null and failures when applying. (WebCore::SplitTextNodeCommand::doUnapply): Ditto.
- editing/SplitTextNodeContainingElementCommand.cpp: (WebCore::SplitTextNodeContainingElementCommand::doApply): Use Element.
- editing/WrapContentsInDummySpanCommand.cpp: (WebCore::WrapContentsInDummySpanCommand::doApply): Check for null and ignore failures. Don't reuse the dummy span. Simplified logic. (WebCore::WrapContentsInDummySpanCommand::doUnapply): Ditto.
- editing/htmlediting.cpp: (WebCore::isBlock): Make sure this returns true only for elements. (WebCore::enclosingBlock): Return an Element*. (WebCore::enclosingTableCell): Ditto. (WebCore::enclosingList): Return an HTMLElement*. (WebCore::outermostEnclosingList): Return an HTMLElement*. (WebCore::createDefaultParagraphElement): Return an HTMLElement*. (WebCore::createBreakElement): Return an HTMLElement*. (WebCore::createOrderedListElement): Return an HTMLElement*. (WebCore::createUnorderedListElement): Return an HTMLElement*. (WebCore::createListItemElement): Return an HTMLElement*. (WebCore::createHTMLElement): Return an HTMLElement*.
- editing/htmlediting.h:
- editing/markup.cpp: (WebCore::createFragmentFromText): Use createBreakElement and use Element*.
- page/MouseEventWithHitTestResults.cpp: (WebCore::MouseEventWithHitTestResults::targetNode): Use parentElement.
- 1:40 PM Changeset in webkit [39455] by
-
- 16 edits1 add in trunk/WebKit
WebKit:
2008-12-23 Darin Adler <Darin Adler>
Reviewed by Alexey Proskuryakov.
- fix https://bugs.webkit.org/show_bug.cgi?id=22976 crash due to Mail's use of WebArchive and WebResource on non-main thread
- StringsNotToBeLocalized.txt: Updated.
- WebKit.xcodeproj/project.pbxproj: Added new file WebNSObjectExtras.mm and existing file WebResourceInternal.h.
WebKit/mac:
2008-12-23 Darin Adler <Darin Adler>
Reviewed by Alexey Proskuryakov (a slightly earlier version).
- fix https://bugs.webkit.org/show_bug.cgi?id=22976 crash due to Mail's use of WebArchive and WebResource on non-main thread
- Misc/WebKitLogging.h: Improved comments for ASSERT_MAIN_THREAD. Got rid of WebKitRunningOnMainThread function, which was just a cover for pthread_main_np.
- Misc/WebKitLogging.m: Ditto.
- Misc/WebKitVersionChecks.h: Added a version after which we won't do the main thread workaround.
- Misc/WebNSObjectExtras.h: Added a new method, _webkit_getPropertyOnMainThread:, which performs a selector on the main thread, waits for it to complete, and then returns the value on the caller thread.
- Misc/WebNSObjectExtras.mm: Added.
- WebView/WebArchive.mm: (-[WebArchive init]): Added WebCoreThreadViolationCheck. (-[WebArchive initWithMainResource:subresources:subframeArchives:]): Perform initialization on main thread if needMailThreadWorkaround is true. Also added WebCoreThreadViolationCheck. (-[WebArchive initWithData:]): Added WebCoreThreadViolationCheck. (-[WebArchive mainResource]): Get property on main thread if needMailThreadWorkaround is true. Also added WebCoreThreadViolationCheck. (-[WebArchive subresources]): Ditto. (-[WebArchive subframeArchives]): Ditto. (-[WebArchive data]): Ditto. (-[WebArchive _initWithCoreLegacyWebArchive:]): Added WebCoreThreadViolationCheck. (-[WebArchive _coreLegacyWebArchive]): Ditto. (-[WebArchive _initWithArguments:]): Added. Used to implement the cross-thread version of initWithMainResource above.
- WebView/WebResource.mm: (-[WebResource initWithCoder:]): Added WebCoreThreadViolationCheck. (-[WebResource data]): Get property on main thread if needMailThreadWorkaround is true. Also added WebCoreThreadViolationCheck. (-[WebResource URL]): Ditto. (-[WebResource MIMEType]): Ditto. (-[WebResource textEncodingName]): Ditto. (-[WebResource frameName]): Ditto. (-[WebResource _ignoreWhenUnarchiving]): Ditto. (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]): Perform initialization on main thread if needMailThreadWorkaround is true. Also added WebCoreThreadViolationCheck. (-[WebResource _suggestedFilename]): Added. Helper for _fileWrapperRepresentation. (-[WebResource _fileWrapperRepresentation]): Rewrote to use methods instead of getting at coreResource directly. (-[WebResource _response]): Get property on main thread if needMailThreadWorkaround is true. Also added WebCoreThreadViolationCheck. (-[WebResource _stringValue]): Ditto. (+[WebResource _needMailThreadWorkaroundIfCalledOffMainThread]): Added. (-[WebResource _initWithArguments:]): Added. Used to implement the cross-thread version of _initWithData above.
- WebView/WebResourceInternal.h: Changed to include WebResourcePrivate.h since internal clients have access to the SPI as well as the API. Added definition of MAIL_THREAD_WORKAROUND and the needMainThreadWorkaround helper function.
- Misc/WebIconDatabase.mm: Removed include of now-defunct FoundationExtras.h file. This probably fixes clean builds.
- WebCoreSupport/WebIconDatabaseClient.mm: Ditto.
- WebCoreSupport/WebFrameLoaderClient.mm: Removed include of WebResourcePrivate.h, since it's not actually used.
- WebView/WebDataSource.mm: Ditto.
- WebView/WebHTMLRepresentation.mm: Ditto.
- 12:28 PM Changeset in webkit [39454] by
-
- 3 edits in trunk/WebCore
2008-12-23 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
- dom/Node.h: Tweak comments and order of bits that Sam moved here last night.
- dom/Node.cpp: Ditto.
- 11:01 AM Changeset in webkit [39453] by
-
- 8 edits23 adds in trunk
WebCore:
2008-12-22 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Darin Adler.
Bug 11106: Some XMLHttpRequest URI resolving tests fail
https://bugs.webkit.org/show_bug.cgi?id=11106
Use the ScriptExecutionContext to resolve the URI when calling open in JavaScript.
The previous code was using the containing DOMWindow to do so which would fail for
XMLHttpRequest object being passed between iframe.
Tests: http/tests/xmlhttprequest/uri-resolution-opera-open-004.html
http/tests/xmlhttprequest/uri-resolution-opera-open-005.html
http/tests/xmlhttprequest/uri-resolution-opera-open-006.html
http/tests/xmlhttprequest/uri-resolution-opera-open-007.html
http/tests/xmlhttprequest/uri-resolution-opera-open-008.html
http/tests/xmlhttprequest/uri-resolution-opera-open-009.html
http/tests/xmlhttprequest/uri-resolution-opera-open-010.html
- bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::open): Use the ScriptExecutionContext to resolve the URL.
- dom/Document.cpp: (WebCore::Document::virtualCompleteURL): Virtual method added to avoid performance hit on completeURL call.
- dom/Document.h:
- dom/ScriptExecutionContext.h: (WebCore::ScriptExecutionContext::completeURL): Non-virtual method that wrap the call to the virtual call.
- dom/WorkerContext.cpp: (WebCore::WorkerContext::virtualCompleteURL): Pure virtual method.
- dom/WorkerContext.h:
LayoutTests:
2008-12-22 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Darin Adler.
Test case for bug 11106: Some XMLHttpRequest URI resolving tests fail
https://bugs.webkit.org/show_bug.cgi?id=11106
These tests are borrowed from Opera's test case suite (http://tc.labs.opera.com/apis/XMLHttpRequest).
They correspond to open/004.html - open/010.html which were previously failing.
- http/tests/xmlhttprequest/resources/test-uri-resolution.txt: Added.
- http/tests/xmlhttprequest/resources/uri-resolution-opera-open-004-iframe.html: Added.
- http/tests/xmlhttprequest/resources/uri-resolution-opera-open-005-iframe.html: Added.
- http/tests/xmlhttprequest/resources/uri-resolution-opera-open-006-iframe.html: Added.
- http/tests/xmlhttprequest/resources/uri-resolution-opera-open-007-iframe.html: Added.
- http/tests/xmlhttprequest/resources/uri-resolution-opera-open-008-iframe.html: Added.
- http/tests/xmlhttprequest/resources/uri-resolution-opera-open-009-iframe.html: Added.
- http/tests/xmlhttprequest/resources/uri-resolution-opera-open-010-iframe.html: Added.
- http/tests/xmlhttprequest/test-uri-resolution.txt: Added.
- http/tests/xmlhttprequest/uri-resolution-opera-open-004-expected.txt: Added.
- http/tests/xmlhttprequest/uri-resolution-opera-open-004.html: Added.
- http/tests/xmlhttprequest/uri-resolution-opera-open-005-expected.txt: Added.
- http/tests/xmlhttprequest/uri-resolution-opera-open-005.html: Added.
- http/tests/xmlhttprequest/uri-resolution-opera-open-006-expected.txt: Added.
- http/tests/xmlhttprequest/uri-resolution-opera-open-006.html: Added.
- http/tests/xmlhttprequest/uri-resolution-opera-open-007-expected.txt: Added.
- http/tests/xmlhttprequest/uri-resolution-opera-open-007.html: Added.
- http/tests/xmlhttprequest/uri-resolution-opera-open-008-expected.txt: Added.
- http/tests/xmlhttprequest/uri-resolution-opera-open-008.html: Added.
- http/tests/xmlhttprequest/uri-resolution-opera-open-009-expected.txt: Added.
- http/tests/xmlhttprequest/uri-resolution-opera-open-009.html: Added.
- http/tests/xmlhttprequest/uri-resolution-opera-open-010-expected.txt: Added.
- http/tests/xmlhttprequest/uri-resolution-opera-open-010.html: Added.
- 9:25 AM Changeset in webkit [39452] by
-
- 2 edits in trunk/WebKit/mac
2008-12-23 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
- fix https://bugs.webkit.org/show_bug.cgi?id=22979 crash seen in -[WebView drawsBackground] when quitting <rdar://problem/6464601>
- WebView/WebView.mm: (-[WebView drawsBackground]): Added comment and a null check for _private.
- 9:22 AM Changeset in webkit [39451] by
-
- 3 edits in trunk/WebCore
2008-12-23 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
- https://bugs.webkit.org/show_bug.cgi?id=22978 a couple tweaks to the new strokeBoundingRect functions
- platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::strokeBoundingRect): Only create a GraphicsContext if the applier is non-null.
- platform/graphics/cg/PathCG.cpp: (WebCore::putBytesNowhere): Added. (WebCore::createScratchContext): Changed to use a "/dev/null" type function to discard bytes rather than using a data object. This eliminates the possibility that memory will be used if someone draws into the scratch context by accident. Also moved to the top of the file; it was in a slightly strange place before. (WebCore::Path::strokeBoundingRect): Only create a GraphicsContext if the applier is non-null. Simplify the empty path special case.