Timeline
Dec 27, 2008:
- 6:54 PM Changeset in webkit [39487] by
-
- 13 edits1 add in trunk/JavaScriptCore
<rdar://problem/6467376> Race condition in WTF::currentThread can lead to a thread using two different identifiers during its lifetime
If a newly-created thread calls WTF::currentThread() before WTF::createThread calls establishIdentifierForPthreadHandle
then more than one identifier will be used for the same thread. We can avoid this by adding some extra synchronization
during thread creation that delays the execution of the thread function until the thread identifier has been set up, and
an assertion to catch this problem should it reappear in the future.
Reviewed by Alexey Proskuryakov.
- wtf/Threading.cpp: Added.
(WTF::NewThreadContext::NewThreadContext):
(WTF::threadEntryPoint):
(WTF::createThread): Add cross-platform createThread function that delays the execution of the thread function until
after the thread identifier has been set up.
- wtf/Threading.h:
- wtf/ThreadingGtk.cpp:
(WTF::establishIdentifierForThread):
(WTF::createThreadInternal):
- wtf/ThreadingNone.cpp:
(WTF::createThreadInternal):
- wtf/ThreadingPthreads.cpp:
(WTF::establishIdentifierForPthreadHandle):
(WTF::createThreadInternal):
- wtf/ThreadingQt.cpp:
(WTF::identifierByQthreadHandle):
(WTF::establishIdentifierForThread):
(WTF::createThreadInternal):
- wtf/ThreadingWin.cpp:
(WTF::storeThreadHandleByIdentifier):
(WTF::createThreadInternal):
Add Threading.cpp to the build.
- GNUmakefile.am:
- JavaScriptCore.pri:
- JavaScriptCore.scons:
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- JavaScriptCoreSources.bkl:
- 12:30 AM Changeset in webkit [39486] by
-
- 2 edits in trunk/LayoutTests
Suggested by Dave Levin.
Another attempt to fix the failing XHR tests on Tiger buildbot: make file_put_contents
portable implementation return a result.
- http/tests/xmlhttprequest/resources/portabilityLayer.php:
Dec 26, 2008:
- 1:31 PM Changeset in webkit [39485] by
-
- 2 edits in trunk/LayoutTests
2008-12-26 David Levin <levin@chromium.org>
Reviewed by Alexey Proskuryakov.
Remove ensureTrailingSlash from appcache test.
- http/tests/appcache/resources/fail-on-update.php:
- 1:19 PM Changeset in webkit [39484] by
-
- 2 edits in trunk/WebCore
2008-12-26 Zalan Bujtas <zbujtas@gmail.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22999
Check if database thread exists.
- storage/Database.cpp: (WebCore::Database::openAndVerifyVersion): (WebCore::Database::markAsDeletedAndClose): (WebCore::Database::tableNames):
- 1:01 PM Changeset in webkit [39483] by
-
- 2 edits in trunk/JavaScriptCore
2008-12-26 Sam Weinig <sam@webkit.org>
Reviewed by Alexey Proskuryakov.
Remove unused method.
- runtime/Structure.h: Remove mutableTypeInfo.
- 12:00 PM Changeset in webkit [39482] by
-
- 6 edits in trunk/LayoutTests
2008-12-26 David Levin <levin@chromium.org>
Reviewed by Alexey Proskuryakov.
Attempt to fix the failiing XHR tests on tiger buildbot.
Remove the no longer needed ensureTrailingSlash function.
- http/tests/xmlhttprequest/resources/access-control-basic-preflight-cache-invalidation.php:
- http/tests/xmlhttprequest/resources/access-control-basic-preflight-cache-timeout.php:
- http/tests/xmlhttprequest/resources/access-control-basic-preflight-cache.php:
- http/tests/xmlhttprequest/resources/portabilityLayer.php: Make sys_get_temp_dir() return "/tmp" when it can't find the temp directory through other means.
- http/tests/xmlhttprequest/resources/reset-temp-file.php:
- 11:54 AM Changeset in webkit [39481] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Sam Weinig.
- fix <rdar://problem/6467608> lastVisitWasFailure flag persists in global history after a successful visit
- History/WebHistory.mm: (-[WebHistory _visitedURL:withTitle:wasFailure:]): Changed to always update the wasFailure flag on the HistoryItem.
- 11:05 AM Changeset in webkit [39480] by
-
- 2 edits in trunk/LayoutTests
Reviewed by Anders Carlsson.
Fix a layout test that was broken by the previous appcache commit
(it only passed every other time as a result).
- http/tests/appcache/fail-on-update.html:
- 10:59 AM Changeset in webkit [39479] by
-
- 5 edits in trunk/LayoutTests
2008-12-26 Simon Fraser <Simon Fraser>
Update more svg-as-image test results affected by the fix
for SVGImage drawing.
- platform/mac/fast/borders/svg-as-border-image-2-expected.checksum:
- platform/mac/fast/borders/svg-as-border-image-2-expected.png:
- platform/mac/fast/borders/svg-as-border-image-expected.checksum:
- platform/mac/fast/borders/svg-as-border-image-expected.png:
- 10:52 AM Changeset in webkit [39478] by
-
- 3 edits3 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23001
A call to applicationCache.update() from a cached event listener should be ignored
Test: http/tests/appcache/idempotent-update.html
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): Only reset m_status after dispatching events.
- 9:40 AM Changeset in webkit [39477] by
-
- 4 edits16 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22997
ASSERTION FAILED: !m_resources.contains(url) in ApplicationCache::addResource()
Tests: http/tests/appcache/top-frame-1.html
http/tests/appcache/top-frame-2.html
http/tests/appcache/top-frame-3.html
http/tests/appcache/top-frame-4.html
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::cacheForMainRequest): Fixed one more instance of top level frame being used for caching purposes.
- 3:03 AM Changeset in webkit [39476] by
-
- 3 edits in trunk/LayoutTests
2008-12-26 David Levin <levin@chromium.org>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=22950
Added more logging to reset-temp-file to help expose potential issues that could cause test failures (on the tiger buildbot).
If there are issues in reset-temp-file, they are printed from the test access-control-basic-allow-preflight-cache.html
- http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache.html:
- http/tests/xmlhttprequest/resources/reset-temp-file.php:
- 12:46 AM Changeset in webkit [39475] by
-
- 2 edits in trunk/WebCore
2008-12-26 Dmitry Titov <dimich@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22987
Fix for broken test editing/execCommand/5763082.html
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::mergeIdenticalElements): Used local RefPtr to hold onto function parameter across multiple calls.
