Timeline
Dec 31, 2008:
- 6:33 PM Changeset in webkit [39533] by
-
- 5 edits in trunk
[jsfunfuzz] Computed exception offset wrong when first instruction is attempt to resolve deleted eval
<https://bugs.webkit.org/show_bug.cgi?id=23062>
Reviewed by Gavin Barraclough.
This was caused by the expression information for the initial resolve of
eval not being emitted. If this resolve was the first instruction that
could throw an exception the information search would fail leading to an
assertion failure. If it was not the first throwable opcode the wrong
expression information would used.
Fix is simply to emit the expression info.
- 9:52 AM Changeset in webkit [39532] by
-
- 12 edits in trunk/WebKit/gtk
Add section information for View, Frame, Settings, HistoryItem, BackForwardList, WindowFeatures and Inspector
Add section information and informal examples for WebKitWebView,
WebKitWebFrame, WebKitWebSettings, WebKitWebNetworkRequest,
WebKitWebWindowFeatures, WebKitWebHistoryItem,
WebKitWebBackForwardList and WebKitWebInspector.
- 9:31 AM Changeset in webkit [39531] by
-
- 2 edits in trunk/WebKitTools
2008-12-31 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Holger Freyther.
Prevent TestNetscapePlugin from installing system-wide.
- GNUmakefile.am:
- 9:12 AM Changeset in webkit [39530] by
-
- 2 edits in trunk/WebCore
2008-12-31 Laszlo Gombos <Laszlo Gombos>
Reviewed by Holger Freyther.
MinGW build failure.
- platform/graphics/qt/SimpleFontDataQt.cpp: (WebCore::SimpleFontData::containsCharacters):
- 8:52 AM Changeset in webkit [39529] by
-
- 2 edits in trunk/WebKitTools
2008-12-31 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Holger Freyther.
Move WebKitWebView's size allocation into a proper place.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (dump): (runTest):
- 8:37 AM Changeset in webkit [39528] by
-
- 2 edits in trunk/WebCore
2008-12-31 Alexander V. Butenko <alex@digiqube.com>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=22750
[gtk] webkit up to r39121 crash on image urls like
http:///sitename.com
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::start):
- 8:17 AM Changeset in webkit [39527] by
-
- 2 edits in trunk/WebCore
2008-12-31 Hiroyuki Ikezoe <poincare@ikezoe.net>
Reviewed by Holger Freyther.
- platform/graphics/gtk/SimpleFontDataPango.cpp: (WebCore::SimpleFontData::determinePitch): Do not invoke isFixedPitch() when the font is a custom font.
- 4:32 AM Changeset in webkit [39526] by
-
- 2 edits in trunk/WebCore
More work on Bug 3781: Animation via canvas could be faster
<https://bugs.webkit.org/show_bug.cgi?id=3781>
Reviewed by Cameron Zwarich
Make use of the fast path parsing of color strings that Color
uses. This improves performance of '#rgb', '#rrggbb', etc and
named (eg. 'green') colors.
Improves frame rate of test by around 40%
- 2:17 AM Changeset in webkit [39525] by
-
- 3 edits2 adds in trunk
2008-12-31 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Oliver Hunt.
Bug 23054: Caching of global lookups occurs even when the global object has become a dictionary
<https://bugs.webkit.org/show_bug.cgi?id=23054>
<rdar://problem/6469905>
- interpreter/Interpreter.cpp: (JSC::Interpreter::resolveGlobal): Do not cache lookup if the global object has transitioned to a dictionary. (JSC::Interpreter::cti_op_resolve_global): Do not cache lookup if the global object has transitioned to a dictionary.
LayoutTests:
- fast/js/pic/delete-global-object-expected.txt: Added.
- fast/js/pic/delete-global-object.html: Added.
Dec 30, 2008:
- 10:49 PM Changeset in webkit [39524] by
-
- 7 edits3 adds in trunk
<https://bugs.webkit.org/show_bug.cgi?id=23049> [jsfunfuzz] With blocks do not correctly protect their scope object
<rdar://problem/6469742> Crash in JSC::TypeInfo::hasStandardGetOwnPropertySlot() running jsfunfuzz
Reviewed by Darin Adler
The problem that caused this was that with nodes were not correctly protecting
the final object that was placed in the scope chain. We correct this by forcing
the use of a temporary register (which stops us relying on a local register
protecting the scope) and changing the behaviour of op_push_scope so that it
will store the final scope object.
- 9:16 PM Changeset in webkit [39523] by
-
- 6 edits in trunk/LayoutTests
2008-12-30 Simon Fraser <Simon Fraser>
Fix spurious test failures by rounding floating point values to
mask math differences between machines.
- transitions/transform-op-list-match-expected.txt:
- transitions/transform-op-list-match.html:
- transitions/transform-op-list-no-match-expected.txt:
- transitions/transform-op-list-no-match.html:
- transitions/transition-test-helpers.js: (roundNumber):
- 4:11 PM Changeset in webkit [39522] by
-
- 5 edits4 adds in trunk
2008-12-30 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler
Rather than doing a repaint() inside of computeAbsoluteRepaintRect()
when there is a reflection, compute the location of the rect inside
the reflection and take the union of the unreflected and reflected rects.
Test: fast/repaint/reflection-redraw.html
- rendering/RenderBox.cpp: (WebCore::RenderBox::computeAbsoluteRepaintRect):
- rendering/RenderObject.cpp: (WebCore::RenderObject::reflectedRect):
- rendering/RenderObject.h:
- 4:07 PM Changeset in webkit [39521] by
-
- 5 edits3 adds in trunk
2008-12-30 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Sam Weinig.
Bug 23037: Parsing and reparsing disagree on automatic semicolon insertion
<https://bugs.webkit.org/show_bug.cgi?id=23037>
<rdar://problem/6467124>
Parsing and reparsing disagree about automatic semicolon insertion, so that a
function like
function() { a = 1, }
is parsed as being syntactically valid but gets a syntax error upon reparsing.
This leads to an assertion failure in Parser::reparse(). It is not that big of
an issue in practice, because in a Release build such a function will return
'undefined' when called.
In this case, we are not following the spec and it should be a syntax error.
However, unless there is a newline separating the ',' and the '}', WebKit would
not treat it as a syntax error in the past either. It would be a bit of work to
make the automatic semicolon insertion match the spec exactly, so this patch
changes it to match our past behaviour.
The problem is that even during reparsing, the Lexer adds a semicolon at the
end of the input, which confuses allowAutomaticSemicolon(), because it is
expecting either a '}', the end of input, or a terminator like a newline.
- parser/Lexer.cpp: (JSC::Lexer::Lexer): Initialize m_isReparsing to false. (JSC::Lexer::lex): Do not perform automatic semicolon insertion in the Lexer if we are in the middle of reparsing. (JSC::Lexer::clear): Set m_isReparsing to false.
- parser/Lexer.h: (JSC::Lexer::setIsReparsing): Added.
- parser/Parser.cpp: (JSC::Parser::reparse): Call Lexer::setIsReparsing() to notify the Lexer of reparsing.
LayoutTests:
- fast/js/reparsing-semicolon-insertion-expected.txt: Added.
- fast/js/reparsing-semicolon-insertion.html: Added.
- fast/js/resources/reparsing-semicolon-insertion.js: Added.
- 2:30 PM Changeset in webkit [39520] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Adele Peterson.
- fix <rdar://problem/6469944> REGRESSION(3.2.1-ToT): Repro crash in WebCore::HTMLInputElement::updatePlaceholderVisibility opening http://billshrink.com
Test: fast/forms/placeholder-non-textfield.html
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute): Only call updatePlaceholderVisibility() when the placeholder attribute changes if the element is a text field.
LayoutTests:
Reviewed by Adele Peterson.
- test for <rdar://problem/6469944> REGRESSION(3.2.1-ToT): Repro crash in WebCore::HTMLInputElement::updatePlaceholderVisibility opening http://billshrink.com
- fast/forms/placeholder-non-textfield-expected.txt: Added.
- fast/forms/placeholder-non-textfield.html: Added.
- 11:24 AM Changeset in webkit [39519] by
-
- 2 edits in trunk/WebKitSite
2008-12-30 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Darin Adler.
Landed by Pamela Greene.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=22908.
Update website so that newbies are told they must set the
WebKitOutputDir to get a valid build.
- building/build.html: Add language (and link) indicating the importance of setting the WebKitOutputDir variable, as well as a link to instructions on how to do so.
- 4:19 AM Changeset in webkit [39518] by
-
- 3 edits in trunk/WebCore
First step of Bug 3781: Animation via canvas could be faster
Reviewed by Antti Koivisto.
Amortise the cost of calling repaint by coalescing repaint rects
while the canvas is drawn to. In a later step we'll stop calling
repaint() directly, and instead have all dirty canvases repaint
at the end of JS execution.
- 3:08 AM Changeset in webkit [39517] by
-
- 3 edits in trunk/WebCore
2008-12-30 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Antti Koivisto.
Bug 22931: Using the inspector with purgeable resources leads to assertion failures
<https://bugs.webkit.org/show_bug.cgi?id=22931>
Change InspectorResource::sourceString() so that it doesn't attempt to
unsafely get the data of a purgeable CachedResource.
- inspector/InspectorController.cpp: (WebCore::InspectorResource::sourceString): Attempt to make a purgeable resource unpurgeable, and if this not possible, return an empty string.
- loader/CachedResource.h: Make InspectorResource a friend of CachedResource.
